blob: 91911a769606c826e3274ec47ee706ca58bf50d1 [file] [log] [blame]
pbos@webrtc.orga0d78272014-09-12 11:51:47 +00001/*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020011#include "modules/video_coding/utility/quality_scaler.h"
pbos@webrtc.orga0d78272014-09-12 11:51:47 +000012
kthelgason876222f2016-11-29 01:44:11 -080013#include <memory>
Åsa Perssona945aee2018-04-24 16:53:25 +020014#include <string>
kthelgason876222f2016-11-29 01:44:11 -080015
Yves Gerey3e707812018-11-28 16:47:49 +010016#include "rtc_base/checks.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020017#include "rtc_base/event.h"
Danil Chapovalovb42165e2019-03-20 14:29:43 +010018#include "rtc_base/task_queue_for_test.h"
Åsa Perssona945aee2018-04-24 16:53:25 +020019#include "test/field_trial.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020020#include "test/gtest.h"
pbos@webrtc.orga0d78272014-09-12 11:51:47 +000021
22namespace webrtc {
23namespace {
pbos@webrtc.orga0d78272014-09-12 11:51:47 +000024static const int kFramerate = 30;
25static const int kLowQp = 15;
Peter Boström17417702015-09-25 17:03:26 +020026static const int kHighQp = 40;
Åsa Persson0ad2d8a2018-04-19 11:06:11 +020027static const int kMinFramesNeededToScale = 60; // From quality_scaler.cc.
kthelgason86cf9a22016-12-01 02:57:01 -080028static const size_t kDefaultTimeoutMs = 150;
pbos@webrtc.orga0d78272014-09-12 11:51:47 +000029} // namespace
30
Evan Shrubsolea1c77f62020-08-10 11:01:06 +020031class FakeQpUsageHandler : public QualityScalerQpUsageHandlerInterface {
kthelgason876222f2016-11-29 01:44:11 -080032 public:
Evan Shrubsolea1c77f62020-08-10 11:01:06 +020033 ~FakeQpUsageHandler() override = default;
kthelgason876222f2016-11-29 01:44:11 -080034
Henrik Boström012aa372020-04-27 17:40:55 +020035 // QualityScalerQpUsageHandlerInterface implementation.
Evan Shrubsolea1c77f62020-08-10 11:01:06 +020036 void OnReportQpUsageHigh() override {
sprangb1ca0732017-02-01 08:38:12 -080037 adapt_down_events_++;
kthelgason876222f2016-11-29 01:44:11 -080038 event.Set();
Henrik Boström012aa372020-04-27 17:40:55 +020039 }
40
Evan Shrubsolea1c77f62020-08-10 11:01:06 +020041 void OnReportQpUsageLow() override {
Henrik Boström012aa372020-04-27 17:40:55 +020042 adapt_up_events_++;
43 event.Set();
kthelgason876222f2016-11-29 01:44:11 -080044 }
45
46 rtc::Event event;
sprangb1ca0732017-02-01 08:38:12 -080047 int adapt_up_events_ = 0;
48 int adapt_down_events_ = 0;
kthelgason876222f2016-11-29 01:44:11 -080049};
50
51// Pass a lower sampling period to speed up the tests.
52class QualityScalerUnderTest : public QualityScaler {
53 public:
Henrik Boström012aa372020-04-27 17:40:55 +020054 explicit QualityScalerUnderTest(QualityScalerQpUsageHandlerInterface* handler,
kthelgason876222f2016-11-29 01:44:11 -080055 VideoEncoder::QpThresholds thresholds)
Henrik Boström012aa372020-04-27 17:40:55 +020056 : QualityScaler(handler, thresholds, 5) {}
kthelgason876222f2016-11-29 01:44:11 -080057};
58
Åsa Perssona945aee2018-04-24 16:53:25 +020059class QualityScalerTest : public ::testing::Test,
60 public ::testing::WithParamInterface<std::string> {
pbos@webrtc.orga0d78272014-09-12 11:51:47 +000061 protected:
Peter Boström17417702015-09-25 17:03:26 +020062 enum ScaleDirection {
Åsa Persson0ad2d8a2018-04-19 11:06:11 +020063 kKeepScaleAboveLowQp,
Peter Boström17417702015-09-25 17:03:26 +020064 kKeepScaleAtHighQp,
65 kScaleDown,
66 kScaleDownAboveHighQp,
67 kScaleUp
68 };
pbos@webrtc.orga0d78272014-09-12 11:51:47 +000069
kthelgason876222f2016-11-29 01:44:11 -080070 QualityScalerTest()
Åsa Perssona945aee2018-04-24 16:53:25 +020071 : scoped_field_trial_(GetParam()),
Danil Chapovalovb42165e2019-03-20 14:29:43 +010072 task_queue_("QualityScalerTestQueue"),
Evan Shrubsolea1c77f62020-08-10 11:01:06 +020073 handler_(std::make_unique<FakeQpUsageHandler>()) {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +020074 task_queue_.SendTask(
75 [this] {
76 qs_ = std::unique_ptr<QualityScaler>(new QualityScalerUnderTest(
Henrik Boström012aa372020-04-27 17:40:55 +020077 handler_.get(), VideoEncoder::QpThresholds(kLowQp, kHighQp)));
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +020078 },
79 RTC_FROM_HERE);
pbos@webrtc.orga0d78272014-09-12 11:51:47 +000080 }
81
Evan Shrubsolea1c77f62020-08-10 11:01:06 +020082 ~QualityScalerTest() override {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +020083 task_queue_.SendTask([this] { qs_ = nullptr; }, RTC_FROM_HERE);
kthelgason876222f2016-11-29 01:44:11 -080084 }
85
86 void TriggerScale(ScaleDirection scale_direction) {
87 for (int i = 0; i < kFramerate * 5; ++i) {
pbos@webrtc.orga0d78272014-09-12 11:51:47 +000088 switch (scale_direction) {
Åsa Persson0ad2d8a2018-04-19 11:06:11 +020089 case kKeepScaleAboveLowQp:
Sebastian Janssonb6789402019-03-01 15:40:49 +010090 qs_->ReportQp(kLowQp + 1, 0);
Åsa Persson0ad2d8a2018-04-19 11:06:11 +020091 break;
pbos@webrtc.orga0d78272014-09-12 11:51:47 +000092 case kScaleUp:
Sebastian Janssonb6789402019-03-01 15:40:49 +010093 qs_->ReportQp(kLowQp, 0);
pbos@webrtc.orga0d78272014-09-12 11:51:47 +000094 break;
95 case kScaleDown:
Åsa Perssona945aee2018-04-24 16:53:25 +020096 qs_->ReportDroppedFrameByMediaOpt();
pbos@webrtc.orga0d78272014-09-12 11:51:47 +000097 break;
Peter Boström17417702015-09-25 17:03:26 +020098 case kKeepScaleAtHighQp:
Sebastian Janssonb6789402019-03-01 15:40:49 +010099 qs_->ReportQp(kHighQp, 0);
Peter Boström17417702015-09-25 17:03:26 +0200100 break;
101 case kScaleDownAboveHighQp:
Sebastian Janssonb6789402019-03-01 15:40:49 +0100102 qs_->ReportQp(kHighQp + 1, 0);
Peter Boström17417702015-09-25 17:03:26 +0200103 break;
pbos@webrtc.orga0d78272014-09-12 11:51:47 +0000104 }
pbos@webrtc.orga0d78272014-09-12 11:51:47 +0000105 }
pbos@webrtc.orga0d78272014-09-12 11:51:47 +0000106 }
107
Åsa Perssona945aee2018-04-24 16:53:25 +0200108 test::ScopedFieldTrials scoped_field_trial_;
Danil Chapovalovb42165e2019-03-20 14:29:43 +0100109 TaskQueueForTest task_queue_;
kthelgason876222f2016-11-29 01:44:11 -0800110 std::unique_ptr<QualityScaler> qs_;
Evan Shrubsolea1c77f62020-08-10 11:01:06 +0200111 std::unique_ptr<FakeQpUsageHandler> handler_;
pbos@webrtc.orga0d78272014-09-12 11:51:47 +0000112};
113
Mirko Bonadeic84f6612019-01-31 12:20:57 +0100114INSTANTIATE_TEST_SUITE_P(
Åsa Perssona945aee2018-04-24 16:53:25 +0200115 FieldTrials,
116 QualityScalerTest,
117 ::testing::Values(
Ilya Nikolaevskiyd6604df2021-02-01 12:01:06 +0000118 "WebRTC-Video-QualityScaling/Enabled-1,2,3,4,5,6,7,8,0.9,0.99,1/",
Ilya Nikolaevskiy483b31c2021-02-03 17:19:31 +0100119 "WebRTC-Video-QualityScaling/Disabled/"));
Åsa Perssona945aee2018-04-24 16:53:25 +0200120
121TEST_P(QualityScalerTest, DownscalesAfterContinuousFramedrop) {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200122 task_queue_.SendTask([this] { TriggerScale(kScaleDown); }, RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200123 EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
124 EXPECT_EQ(1, handler_->adapt_down_events_);
125 EXPECT_EQ(0, handler_->adapt_up_events_);
pbos@webrtc.orga0d78272014-09-12 11:51:47 +0000126}
127
Åsa Perssona945aee2018-04-24 16:53:25 +0200128TEST_P(QualityScalerTest, KeepsScaleAtHighQp) {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200129 task_queue_.SendTask([this] { TriggerScale(kKeepScaleAtHighQp); },
130 RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200131 EXPECT_FALSE(handler_->event.Wait(kDefaultTimeoutMs));
132 EXPECT_EQ(0, handler_->adapt_down_events_);
133 EXPECT_EQ(0, handler_->adapt_up_events_);
Peter Boström17417702015-09-25 17:03:26 +0200134}
135
Åsa Perssona945aee2018-04-24 16:53:25 +0200136TEST_P(QualityScalerTest, DownscalesAboveHighQp) {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200137 task_queue_.SendTask([this] { TriggerScale(kScaleDownAboveHighQp); },
138 RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200139 EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
140 EXPECT_EQ(1, handler_->adapt_down_events_);
141 EXPECT_EQ(0, handler_->adapt_up_events_);
Peter Boström17417702015-09-25 17:03:26 +0200142}
143
Åsa Perssona945aee2018-04-24 16:53:25 +0200144TEST_P(QualityScalerTest, DownscalesAfterTwoThirdsFramedrop) {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200145 task_queue_.SendTask(
146 [this] {
147 for (int i = 0; i < kFramerate * 5; ++i) {
148 qs_->ReportDroppedFrameByMediaOpt();
149 qs_->ReportDroppedFrameByMediaOpt();
150 qs_->ReportQp(kHighQp, 0);
151 }
152 },
153 RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200154 EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
155 EXPECT_EQ(1, handler_->adapt_down_events_);
156 EXPECT_EQ(0, handler_->adapt_up_events_);
pbos@webrtc.orga0d78272014-09-12 11:51:47 +0000157}
158
Åsa Perssona945aee2018-04-24 16:53:25 +0200159TEST_P(QualityScalerTest, DoesNotDownscaleAfterHalfFramedrop) {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200160 task_queue_.SendTask(
161 [this] {
162 for (int i = 0; i < kFramerate * 5; ++i) {
163 qs_->ReportDroppedFrameByMediaOpt();
164 qs_->ReportQp(kHighQp, 0);
165 }
166 },
167 RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200168 EXPECT_FALSE(handler_->event.Wait(kDefaultTimeoutMs));
169 EXPECT_EQ(0, handler_->adapt_down_events_);
170 EXPECT_EQ(0, handler_->adapt_up_events_);
pbos@webrtc.orga0d78272014-09-12 11:51:47 +0000171}
172
Åsa Perssona945aee2018-04-24 16:53:25 +0200173TEST_P(QualityScalerTest, DownscalesAfterTwoThirdsIfFieldTrialEnabled) {
Ilya Nikolaevskiy483b31c2021-02-03 17:19:31 +0100174 const bool kDownScaleExpected =
175 GetParam().find("Enabled") != std::string::npos;
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200176 task_queue_.SendTask(
177 [this] {
178 for (int i = 0; i < kFramerate * 5; ++i) {
179 qs_->ReportDroppedFrameByMediaOpt();
180 qs_->ReportDroppedFrameByEncoder();
181 qs_->ReportQp(kHighQp, 0);
182 }
183 },
184 RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200185 EXPECT_EQ(kDownScaleExpected, handler_->event.Wait(kDefaultTimeoutMs));
186 EXPECT_EQ(kDownScaleExpected ? 1 : 0, handler_->adapt_down_events_);
187 EXPECT_EQ(0, handler_->adapt_up_events_);
Åsa Perssona945aee2018-04-24 16:53:25 +0200188}
189
190TEST_P(QualityScalerTest, KeepsScaleOnNormalQp) {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200191 task_queue_.SendTask([this] { TriggerScale(kKeepScaleAboveLowQp); },
192 RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200193 EXPECT_FALSE(handler_->event.Wait(kDefaultTimeoutMs));
194 EXPECT_EQ(0, handler_->adapt_down_events_);
195 EXPECT_EQ(0, handler_->adapt_up_events_);
Åsa Persson0ad2d8a2018-04-19 11:06:11 +0200196}
197
Åsa Perssona945aee2018-04-24 16:53:25 +0200198TEST_P(QualityScalerTest, UpscalesAfterLowQp) {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200199 task_queue_.SendTask([this] { TriggerScale(kScaleUp); }, RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200200 EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
201 EXPECT_EQ(0, handler_->adapt_down_events_);
202 EXPECT_EQ(1, handler_->adapt_up_events_);
pbos@webrtc.orga0d78272014-09-12 11:51:47 +0000203}
204
Åsa Perssona945aee2018-04-24 16:53:25 +0200205TEST_P(QualityScalerTest, ScalesDownAndBackUp) {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200206 task_queue_.SendTask([this] { TriggerScale(kScaleDown); }, RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200207 EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
208 EXPECT_EQ(1, handler_->adapt_down_events_);
209 EXPECT_EQ(0, handler_->adapt_up_events_);
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200210 task_queue_.SendTask([this] { TriggerScale(kScaleUp); }, RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200211 EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
212 EXPECT_EQ(1, handler_->adapt_down_events_);
213 EXPECT_EQ(1, handler_->adapt_up_events_);
Peter Boström6a688f52015-06-22 08:02:58 +0200214}
kthelgason55a01352017-04-04 02:31:42 -0700215
Åsa Perssona945aee2018-04-24 16:53:25 +0200216TEST_P(QualityScalerTest, DoesNotScaleUntilEnoughFramesObserved) {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200217 task_queue_.SendTask(
218 [this] {
219 // Not enough frames to make a decision.
220 for (int i = 0; i < kMinFramesNeededToScale - 1; ++i) {
221 qs_->ReportQp(kLowQp, 0);
222 }
223 },
224 RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200225 EXPECT_FALSE(handler_->event.Wait(kDefaultTimeoutMs));
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200226 task_queue_.SendTask(
227 [this] {
228 // Send 1 more. Enough frames observed, should result in an adapt
229 // request.
230 qs_->ReportQp(kLowQp, 0);
231 },
232 RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200233 EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
234 EXPECT_EQ(0, handler_->adapt_down_events_);
235 EXPECT_EQ(1, handler_->adapt_up_events_);
Åsa Persson0ad2d8a2018-04-19 11:06:11 +0200236
237 // Samples should be cleared after an adapt request.
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200238 task_queue_.SendTask(
239 [this] {
240 // Not enough frames to make a decision.
241 qs_->ReportQp(kLowQp, 0);
242 },
243 RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200244 EXPECT_FALSE(handler_->event.Wait(kDefaultTimeoutMs));
245 EXPECT_EQ(0, handler_->adapt_down_events_);
246 EXPECT_EQ(1, handler_->adapt_up_events_);
kthelgason55a01352017-04-04 02:31:42 -0700247}
Åsa Persson0ad2d8a2018-04-19 11:06:11 +0200248
Åsa Perssona945aee2018-04-24 16:53:25 +0200249TEST_P(QualityScalerTest, ScalesDownAndBackUpWithMinFramesNeeded) {
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200250 task_queue_.SendTask(
251 [this] {
252 for (int i = 0; i < kMinFramesNeededToScale; ++i) {
253 qs_->ReportQp(kHighQp + 1, 0);
254 }
255 },
256 RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200257 EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
258 EXPECT_EQ(1, handler_->adapt_down_events_);
259 EXPECT_EQ(0, handler_->adapt_up_events_);
Åsa Persson0ad2d8a2018-04-19 11:06:11 +0200260 // Samples cleared.
Danil Chapovaloveb90e6f2019-10-15 10:04:57 +0200261 task_queue_.SendTask(
262 [this] {
263 for (int i = 0; i < kMinFramesNeededToScale; ++i) {
264 qs_->ReportQp(kLowQp, 0);
265 }
266 },
267 RTC_FROM_HERE);
Henrik Boström012aa372020-04-27 17:40:55 +0200268 EXPECT_TRUE(handler_->event.Wait(kDefaultTimeoutMs));
269 EXPECT_EQ(1, handler_->adapt_down_events_);
270 EXPECT_EQ(1, handler_->adapt_up_events_);
271}
272
pbos@webrtc.orga0d78272014-09-12 11:51:47 +0000273} // namespace webrtc