henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | // Unit tests for DelayManager class. |
| 12 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 13 | #include "modules/audio_coding/neteq/delay_manager.h" |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 14 | |
| 15 | #include <math.h> |
| 16 | |
Jakob Ivarsson | 1eb3d7e | 2019-02-21 15:42:31 +0100 | [diff] [blame] | 17 | #include "absl/memory/memory.h" |
| 18 | #include "modules/audio_coding/neteq/histogram.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 19 | #include "modules/audio_coding/neteq/mock/mock_delay_peak_detector.h" |
Jakob Ivarsson | 1eb3d7e | 2019-02-21 15:42:31 +0100 | [diff] [blame] | 20 | #include "modules/audio_coding/neteq/mock/mock_histogram.h" |
Jakob Ivarsson | 4450708 | 2019-03-05 16:59:03 +0100 | [diff] [blame] | 21 | #include "modules/audio_coding/neteq/mock/mock_statistics_calculator.h" |
Ruslan Burakov | 4a68fb9 | 2019-02-13 14:25:39 +0100 | [diff] [blame] | 22 | #include "rtc_base/checks.h" |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 23 | #include "test/field_trial.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 24 | #include "test/gmock.h" |
| 25 | #include "test/gtest.h" |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 26 | |
| 27 | namespace webrtc { |
| 28 | |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 29 | namespace { |
| 30 | constexpr int kMaxNumberOfPackets = 240; |
| 31 | constexpr int kMinDelayMs = 0; |
| 32 | constexpr int kTimeStepMs = 10; |
| 33 | constexpr int kFs = 8000; |
| 34 | constexpr int kFrameSizeMs = 20; |
| 35 | constexpr int kTsIncrement = kFrameSizeMs * kFs / 1000; |
| 36 | constexpr int kMaxBufferSizeMs = kMaxNumberOfPackets * kFrameSizeMs; |
| 37 | constexpr int kDefaultHistogramQuantile = 1020054733; |
| 38 | constexpr int kMaxIat = 64; |
| 39 | constexpr int kForgetFactor = 32745; |
| 40 | } // namespace |
| 41 | |
turaj@webrtc.org | f1efc57 | 2013-08-16 23:44:24 +0000 | [diff] [blame] | 42 | using ::testing::_; |
Jonas Olsson | a4d8737 | 2019-07-05 19:08:33 +0200 | [diff] [blame^] | 43 | using ::testing::Return; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 44 | |
| 45 | class DelayManagerTest : public ::testing::Test { |
| 46 | protected: |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 47 | DelayManagerTest(); |
| 48 | virtual void SetUp(); |
| 49 | virtual void TearDown(); |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 50 | void RecreateDelayManager(); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 51 | void SetPacketAudioLength(int lengt_ms); |
| 52 | void InsertNextPacket(); |
| 53 | void IncreaseTime(int inc_ms); |
| 54 | |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 55 | std::unique_ptr<DelayManager> dm_; |
henrik.lundin | f393370 | 2016-04-28 01:53:52 -0700 | [diff] [blame] | 56 | TickTimer tick_timer_; |
Jakob Ivarsson | 4450708 | 2019-03-05 16:59:03 +0100 | [diff] [blame] | 57 | MockStatisticsCalculator stats_; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 58 | MockDelayPeakDetector detector_; |
Jakob Ivarsson | 1eb3d7e | 2019-02-21 15:42:31 +0100 | [diff] [blame] | 59 | MockHistogram* mock_histogram_; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 60 | uint16_t seq_no_; |
| 61 | uint32_t ts_; |
Jakob Ivarsson | e98954c | 2019-02-06 15:37:50 +0100 | [diff] [blame] | 62 | bool enable_rtx_handling_ = false; |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 63 | bool use_mock_histogram_ = false; |
| 64 | DelayManager::HistogramMode histogram_mode_ = |
| 65 | DelayManager::HistogramMode::INTER_ARRIVAL_TIME; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 66 | }; |
| 67 | |
| 68 | DelayManagerTest::DelayManagerTest() |
Jakob Ivarsson | 39b934b | 2019-01-10 10:28:23 +0100 | [diff] [blame] | 69 | : dm_(nullptr), |
| 70 | detector_(&tick_timer_, false), |
| 71 | seq_no_(0x1234), |
| 72 | ts_(0x12345678) {} |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 73 | |
| 74 | void DelayManagerTest::SetUp() { |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 75 | RecreateDelayManager(); |
| 76 | } |
| 77 | |
| 78 | void DelayManagerTest::RecreateDelayManager() { |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 79 | EXPECT_CALL(detector_, Reset()).Times(1); |
Jakob Ivarsson | 1eb3d7e | 2019-02-21 15:42:31 +0100 | [diff] [blame] | 80 | if (use_mock_histogram_) { |
| 81 | mock_histogram_ = new MockHistogram(kMaxIat, kForgetFactor); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 82 | std::unique_ptr<Histogram> histogram(mock_histogram_); |
| 83 | dm_ = absl::make_unique<DelayManager>( |
| 84 | kMaxNumberOfPackets, kMinDelayMs, kDefaultHistogramQuantile, |
| 85 | histogram_mode_, enable_rtx_handling_, &detector_, &tick_timer_, |
Jakob Ivarsson | 4450708 | 2019-03-05 16:59:03 +0100 | [diff] [blame] | 86 | &stats_, std::move(histogram)); |
Jakob Ivarsson | 1eb3d7e | 2019-02-21 15:42:31 +0100 | [diff] [blame] | 87 | } else { |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 88 | dm_ = DelayManager::Create(kMaxNumberOfPackets, kMinDelayMs, |
Jakob Ivarsson | 4450708 | 2019-03-05 16:59:03 +0100 | [diff] [blame] | 89 | enable_rtx_handling_, &detector_, &tick_timer_, |
| 90 | &stats_); |
Jakob Ivarsson | 1eb3d7e | 2019-02-21 15:42:31 +0100 | [diff] [blame] | 91 | } |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 92 | } |
| 93 | |
| 94 | void DelayManagerTest::SetPacketAudioLength(int lengt_ms) { |
| 95 | EXPECT_CALL(detector_, SetPacketAudioLength(lengt_ms)); |
| 96 | dm_->SetPacketAudioLength(lengt_ms); |
| 97 | } |
| 98 | |
| 99 | void DelayManagerTest::InsertNextPacket() { |
| 100 | EXPECT_EQ(0, dm_->Update(seq_no_, ts_, kFs)); |
| 101 | seq_no_ += 1; |
| 102 | ts_ += kTsIncrement; |
| 103 | } |
| 104 | |
| 105 | void DelayManagerTest::IncreaseTime(int inc_ms) { |
| 106 | for (int t = 0; t < inc_ms; t += kTimeStepMs) { |
henrik.lundin | f393370 | 2016-04-28 01:53:52 -0700 | [diff] [blame] | 107 | tick_timer_.Increment(); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 108 | } |
| 109 | } |
Ruslan Burakov | 1e193fa | 2019-05-15 14:31:22 +0200 | [diff] [blame] | 110 | |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 111 | void DelayManagerTest::TearDown() { |
| 112 | EXPECT_CALL(detector_, Die()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 113 | } |
| 114 | |
| 115 | TEST_F(DelayManagerTest, CreateAndDestroy) { |
| 116 | // Nothing to do here. The test fixture creates and destroys the DelayManager |
| 117 | // object. |
| 118 | } |
| 119 | |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 120 | TEST_F(DelayManagerTest, SetPacketAudioLength) { |
| 121 | const int kLengthMs = 30; |
| 122 | // Expect DelayManager to pass on the new length to the detector object. |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 123 | EXPECT_CALL(detector_, SetPacketAudioLength(kLengthMs)).Times(1); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 124 | EXPECT_EQ(0, dm_->SetPacketAudioLength(kLengthMs)); |
| 125 | EXPECT_EQ(-1, dm_->SetPacketAudioLength(-1)); // Illegal parameter value. |
| 126 | } |
| 127 | |
| 128 | TEST_F(DelayManagerTest, PeakFound) { |
| 129 | // Expect DelayManager to pass on the question to the detector. |
| 130 | // Call twice, and let the detector return true the first time and false the |
| 131 | // second time. |
| 132 | EXPECT_CALL(detector_, peak_found()) |
| 133 | .WillOnce(Return(true)) |
| 134 | .WillOnce(Return(false)); |
| 135 | EXPECT_TRUE(dm_->PeakFound()); |
| 136 | EXPECT_FALSE(dm_->PeakFound()); |
| 137 | } |
| 138 | |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 139 | TEST_F(DelayManagerTest, UpdateNormal) { |
| 140 | SetPacketAudioLength(kFrameSizeMs); |
| 141 | // First packet arrival. |
| 142 | InsertNextPacket(); |
| 143 | // Advance time by one frame size. |
| 144 | IncreaseTime(kFrameSizeMs); |
| 145 | // Second packet arrival. |
| 146 | // Expect detector update method to be called once with inter-arrival time |
| 147 | // equal to 1 packet, and (base) target level equal to 1 as well. |
| 148 | // Return false to indicate no peaks found. |
Jakob Ivarsson | 39b934b | 2019-01-10 10:28:23 +0100 | [diff] [blame] | 149 | EXPECT_CALL(detector_, Update(1, false, 1)).WillOnce(Return(false)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 150 | InsertNextPacket(); |
| 151 | EXPECT_EQ(1 << 8, dm_->TargetLevel()); // In Q8. |
| 152 | EXPECT_EQ(1, dm_->base_target_level()); |
| 153 | int lower, higher; |
| 154 | dm_->BufferLimits(&lower, &higher); |
| 155 | // Expect |lower| to be 75% of target level, and |higher| to be target level, |
| 156 | // but also at least 20 ms higher than |lower|, which is the limiting case |
| 157 | // here. |
| 158 | EXPECT_EQ((1 << 8) * 3 / 4, lower); |
| 159 | EXPECT_EQ(lower + (20 << 8) / kFrameSizeMs, higher); |
| 160 | } |
| 161 | |
| 162 | TEST_F(DelayManagerTest, UpdateLongInterArrivalTime) { |
| 163 | SetPacketAudioLength(kFrameSizeMs); |
| 164 | // First packet arrival. |
| 165 | InsertNextPacket(); |
| 166 | // Advance time by two frame size. |
| 167 | IncreaseTime(2 * kFrameSizeMs); |
| 168 | // Second packet arrival. |
| 169 | // Expect detector update method to be called once with inter-arrival time |
| 170 | // equal to 1 packet, and (base) target level equal to 1 as well. |
| 171 | // Return false to indicate no peaks found. |
Jakob Ivarsson | 39b934b | 2019-01-10 10:28:23 +0100 | [diff] [blame] | 172 | EXPECT_CALL(detector_, Update(2, false, 2)).WillOnce(Return(false)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 173 | InsertNextPacket(); |
| 174 | EXPECT_EQ(2 << 8, dm_->TargetLevel()); // In Q8. |
| 175 | EXPECT_EQ(2, dm_->base_target_level()); |
| 176 | int lower, higher; |
| 177 | dm_->BufferLimits(&lower, &higher); |
| 178 | // Expect |lower| to be 75% of target level, and |higher| to be target level, |
| 179 | // but also at least 20 ms higher than |lower|, which is the limiting case |
| 180 | // here. |
| 181 | EXPECT_EQ((2 << 8) * 3 / 4, lower); |
| 182 | EXPECT_EQ(lower + (20 << 8) / kFrameSizeMs, higher); |
| 183 | } |
| 184 | |
| 185 | TEST_F(DelayManagerTest, UpdatePeakFound) { |
| 186 | SetPacketAudioLength(kFrameSizeMs); |
| 187 | // First packet arrival. |
| 188 | InsertNextPacket(); |
| 189 | // Advance time by one frame size. |
| 190 | IncreaseTime(kFrameSizeMs); |
| 191 | // Second packet arrival. |
| 192 | // Expect detector update method to be called once with inter-arrival time |
| 193 | // equal to 1 packet, and (base) target level equal to 1 as well. |
| 194 | // Return true to indicate that peaks are found. Let the peak height be 5. |
Jakob Ivarsson | 39b934b | 2019-01-10 10:28:23 +0100 | [diff] [blame] | 195 | EXPECT_CALL(detector_, Update(1, false, 1)).WillOnce(Return(true)); |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 196 | EXPECT_CALL(detector_, MaxPeakHeight()).WillOnce(Return(5)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 197 | InsertNextPacket(); |
| 198 | EXPECT_EQ(5 << 8, dm_->TargetLevel()); |
| 199 | EXPECT_EQ(1, dm_->base_target_level()); // Base target level is w/o peaks. |
| 200 | int lower, higher; |
| 201 | dm_->BufferLimits(&lower, &higher); |
| 202 | // Expect |lower| to be 75% of target level, and |higher| to be target level. |
| 203 | EXPECT_EQ((5 << 8) * 3 / 4, lower); |
| 204 | EXPECT_EQ(5 << 8, higher); |
| 205 | } |
| 206 | |
turaj@webrtc.org | f1efc57 | 2013-08-16 23:44:24 +0000 | [diff] [blame] | 207 | TEST_F(DelayManagerTest, TargetDelay) { |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 208 | SetPacketAudioLength(kFrameSizeMs); |
| 209 | // First packet arrival. |
| 210 | InsertNextPacket(); |
| 211 | // Advance time by one frame size. |
| 212 | IncreaseTime(kFrameSizeMs); |
| 213 | // Second packet arrival. |
| 214 | // Expect detector update method to be called once with inter-arrival time |
| 215 | // equal to 1 packet, and (base) target level equal to 1 as well. |
| 216 | // Return false to indicate no peaks found. |
Jakob Ivarsson | 39b934b | 2019-01-10 10:28:23 +0100 | [diff] [blame] | 217 | EXPECT_CALL(detector_, Update(1, false, 1)).WillOnce(Return(false)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 218 | InsertNextPacket(); |
turaj@webrtc.org | f1efc57 | 2013-08-16 23:44:24 +0000 | [diff] [blame] | 219 | const int kExpectedTarget = 1; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 220 | EXPECT_EQ(kExpectedTarget << 8, dm_->TargetLevel()); // In Q8. |
| 221 | EXPECT_EQ(1, dm_->base_target_level()); |
| 222 | int lower, higher; |
| 223 | dm_->BufferLimits(&lower, &higher); |
turaj@webrtc.org | f1efc57 | 2013-08-16 23:44:24 +0000 | [diff] [blame] | 224 | // Expect |lower| to be 75% of base target level, and |higher| to be |
| 225 | // lower + 20 ms headroom. |
| 226 | EXPECT_EQ((1 << 8) * 3 / 4, lower); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 227 | EXPECT_EQ(lower + (20 << 8) / kFrameSizeMs, higher); |
| 228 | } |
| 229 | |
Niels Möller | 18f1adc | 2018-08-23 08:40:41 +0200 | [diff] [blame] | 230 | TEST_F(DelayManagerTest, MaxDelay) { |
turaj@webrtc.org | f1efc57 | 2013-08-16 23:44:24 +0000 | [diff] [blame] | 231 | const int kExpectedTarget = 5; |
| 232 | const int kTimeIncrement = kExpectedTarget * kFrameSizeMs; |
| 233 | SetPacketAudioLength(kFrameSizeMs); |
| 234 | // First packet arrival. |
| 235 | InsertNextPacket(); |
| 236 | // Second packet arrival. |
| 237 | // Expect detector update method to be called once with inter-arrival time |
| 238 | // equal to |kExpectedTarget| packet. Return true to indicate peaks found. |
Jakob Ivarsson | 39b934b | 2019-01-10 10:28:23 +0100 | [diff] [blame] | 239 | EXPECT_CALL(detector_, Update(kExpectedTarget, false, _)) |
turaj@webrtc.org | f1efc57 | 2013-08-16 23:44:24 +0000 | [diff] [blame] | 240 | .WillRepeatedly(Return(true)); |
| 241 | EXPECT_CALL(detector_, MaxPeakHeight()) |
| 242 | .WillRepeatedly(Return(kExpectedTarget)); |
| 243 | IncreaseTime(kTimeIncrement); |
| 244 | InsertNextPacket(); |
| 245 | |
| 246 | // No limit is set. |
| 247 | EXPECT_EQ(kExpectedTarget << 8, dm_->TargetLevel()); |
| 248 | |
| 249 | int kMaxDelayPackets = kExpectedTarget - 2; |
| 250 | int kMaxDelayMs = kMaxDelayPackets * kFrameSizeMs; |
| 251 | EXPECT_TRUE(dm_->SetMaximumDelay(kMaxDelayMs)); |
| 252 | IncreaseTime(kTimeIncrement); |
| 253 | InsertNextPacket(); |
turaj@webrtc.org | f1efc57 | 2013-08-16 23:44:24 +0000 | [diff] [blame] | 254 | EXPECT_EQ(kMaxDelayPackets << 8, dm_->TargetLevel()); |
| 255 | |
| 256 | // Target level at least should be one packet. |
| 257 | EXPECT_FALSE(dm_->SetMaximumDelay(kFrameSizeMs - 1)); |
| 258 | } |
| 259 | |
Niels Möller | 18f1adc | 2018-08-23 08:40:41 +0200 | [diff] [blame] | 260 | TEST_F(DelayManagerTest, MinDelay) { |
turaj@webrtc.org | f1efc57 | 2013-08-16 23:44:24 +0000 | [diff] [blame] | 261 | const int kExpectedTarget = 5; |
| 262 | const int kTimeIncrement = kExpectedTarget * kFrameSizeMs; |
| 263 | SetPacketAudioLength(kFrameSizeMs); |
| 264 | // First packet arrival. |
| 265 | InsertNextPacket(); |
| 266 | // Second packet arrival. |
| 267 | // Expect detector update method to be called once with inter-arrival time |
| 268 | // equal to |kExpectedTarget| packet. Return true to indicate peaks found. |
Jakob Ivarsson | 39b934b | 2019-01-10 10:28:23 +0100 | [diff] [blame] | 269 | EXPECT_CALL(detector_, Update(kExpectedTarget, false, _)) |
turaj@webrtc.org | f1efc57 | 2013-08-16 23:44:24 +0000 | [diff] [blame] | 270 | .WillRepeatedly(Return(true)); |
| 271 | EXPECT_CALL(detector_, MaxPeakHeight()) |
| 272 | .WillRepeatedly(Return(kExpectedTarget)); |
| 273 | IncreaseTime(kTimeIncrement); |
| 274 | InsertNextPacket(); |
| 275 | |
| 276 | // No limit is applied. |
| 277 | EXPECT_EQ(kExpectedTarget << 8, dm_->TargetLevel()); |
| 278 | |
| 279 | int kMinDelayPackets = kExpectedTarget + 2; |
| 280 | int kMinDelayMs = kMinDelayPackets * kFrameSizeMs; |
| 281 | dm_->SetMinimumDelay(kMinDelayMs); |
| 282 | IncreaseTime(kTimeIncrement); |
| 283 | InsertNextPacket(); |
turaj@webrtc.org | f1efc57 | 2013-08-16 23:44:24 +0000 | [diff] [blame] | 284 | EXPECT_EQ(kMinDelayPackets << 8, dm_->TargetLevel()); |
| 285 | } |
| 286 | |
Ruslan Burakov | 4a68fb9 | 2019-02-13 14:25:39 +0100 | [diff] [blame] | 287 | TEST_F(DelayManagerTest, BaseMinimumDelayCheckValidRange) { |
| 288 | SetPacketAudioLength(kFrameSizeMs); |
| 289 | |
| 290 | // Base minimum delay should be between [0, 10000] milliseconds. |
| 291 | EXPECT_FALSE(dm_->SetBaseMinimumDelay(-1)); |
| 292 | EXPECT_FALSE(dm_->SetBaseMinimumDelay(10001)); |
| 293 | EXPECT_EQ(dm_->GetBaseMinimumDelay(), 0); |
| 294 | |
| 295 | EXPECT_TRUE(dm_->SetBaseMinimumDelay(7999)); |
| 296 | EXPECT_EQ(dm_->GetBaseMinimumDelay(), 7999); |
| 297 | } |
| 298 | |
| 299 | TEST_F(DelayManagerTest, BaseMinimumDelayLowerThanMinimumDelay) { |
| 300 | SetPacketAudioLength(kFrameSizeMs); |
| 301 | constexpr int kBaseMinimumDelayMs = 100; |
| 302 | constexpr int kMinimumDelayMs = 200; |
| 303 | |
| 304 | // Base minimum delay sets lower bound on minimum. That is why when base |
| 305 | // minimum delay is lower than minimum delay we use minimum delay. |
| 306 | RTC_DCHECK_LT(kBaseMinimumDelayMs, kMinimumDelayMs); |
| 307 | |
| 308 | EXPECT_TRUE(dm_->SetBaseMinimumDelay(kBaseMinimumDelayMs)); |
| 309 | EXPECT_TRUE(dm_->SetMinimumDelay(kMinimumDelayMs)); |
| 310 | EXPECT_EQ(dm_->effective_minimum_delay_ms_for_test(), kMinimumDelayMs); |
| 311 | } |
| 312 | |
| 313 | TEST_F(DelayManagerTest, BaseMinimumDelayGreaterThanMinimumDelay) { |
| 314 | SetPacketAudioLength(kFrameSizeMs); |
| 315 | constexpr int kBaseMinimumDelayMs = 70; |
| 316 | constexpr int kMinimumDelayMs = 30; |
| 317 | |
| 318 | // Base minimum delay sets lower bound on minimum. That is why when base |
| 319 | // minimum delay is greater than minimum delay we use base minimum delay. |
| 320 | RTC_DCHECK_GT(kBaseMinimumDelayMs, kMinimumDelayMs); |
| 321 | |
| 322 | EXPECT_TRUE(dm_->SetBaseMinimumDelay(kBaseMinimumDelayMs)); |
| 323 | EXPECT_TRUE(dm_->SetMinimumDelay(kMinimumDelayMs)); |
| 324 | EXPECT_EQ(dm_->effective_minimum_delay_ms_for_test(), kBaseMinimumDelayMs); |
| 325 | } |
| 326 | |
| 327 | TEST_F(DelayManagerTest, BaseMinimumDelayGreaterThanBufferSize) { |
| 328 | SetPacketAudioLength(kFrameSizeMs); |
| 329 | constexpr int kBaseMinimumDelayMs = kMaxBufferSizeMs + 1; |
| 330 | constexpr int kMinimumDelayMs = 12; |
Ruslan Burakov | b35bacc | 2019-02-20 13:41:59 +0100 | [diff] [blame] | 331 | constexpr int kMaximumDelayMs = 20; |
Ruslan Burakov | 4a68fb9 | 2019-02-13 14:25:39 +0100 | [diff] [blame] | 332 | constexpr int kMaxBufferSizeMsQ75 = 3 * kMaxBufferSizeMs / 4; |
| 333 | |
Ruslan Burakov | b35bacc | 2019-02-20 13:41:59 +0100 | [diff] [blame] | 334 | EXPECT_TRUE(dm_->SetMaximumDelay(kMaximumDelayMs)); |
| 335 | |
Ruslan Burakov | 4a68fb9 | 2019-02-13 14:25:39 +0100 | [diff] [blame] | 336 | // Base minimum delay is greater than minimum delay, that is why we clamp |
| 337 | // it to current the highest possible value which is maximum delay. |
| 338 | RTC_DCHECK_GT(kBaseMinimumDelayMs, kMinimumDelayMs); |
| 339 | RTC_DCHECK_GT(kBaseMinimumDelayMs, kMaxBufferSizeMs); |
Ruslan Burakov | b35bacc | 2019-02-20 13:41:59 +0100 | [diff] [blame] | 340 | RTC_DCHECK_GT(kBaseMinimumDelayMs, kMaximumDelayMs); |
| 341 | RTC_DCHECK_LT(kMaximumDelayMs, kMaxBufferSizeMsQ75); |
Ruslan Burakov | 4a68fb9 | 2019-02-13 14:25:39 +0100 | [diff] [blame] | 342 | |
| 343 | EXPECT_TRUE(dm_->SetMinimumDelay(kMinimumDelayMs)); |
| 344 | EXPECT_TRUE(dm_->SetBaseMinimumDelay(kBaseMinimumDelayMs)); |
| 345 | |
| 346 | // Unset maximum value. |
| 347 | EXPECT_TRUE(dm_->SetMaximumDelay(0)); |
| 348 | |
| 349 | // With maximum value unset, the highest possible value now is 75% of |
| 350 | // currently possible maximum buffer size. |
| 351 | EXPECT_EQ(dm_->effective_minimum_delay_ms_for_test(), kMaxBufferSizeMsQ75); |
| 352 | } |
| 353 | |
| 354 | TEST_F(DelayManagerTest, BaseMinimumDelayGreaterThanMaximumDelay) { |
| 355 | SetPacketAudioLength(kFrameSizeMs); |
| 356 | constexpr int kMaximumDelayMs = 400; |
| 357 | constexpr int kBaseMinimumDelayMs = kMaximumDelayMs + 1; |
| 358 | constexpr int kMinimumDelayMs = 20; |
| 359 | |
| 360 | // Base minimum delay is greater than minimum delay, that is why we clamp |
| 361 | // it to current the highest possible value which is kMaximumDelayMs. |
| 362 | RTC_DCHECK_GT(kBaseMinimumDelayMs, kMinimumDelayMs); |
| 363 | RTC_DCHECK_GT(kBaseMinimumDelayMs, kMaximumDelayMs); |
| 364 | RTC_DCHECK_LT(kMaximumDelayMs, kMaxBufferSizeMs); |
| 365 | |
| 366 | EXPECT_TRUE(dm_->SetMaximumDelay(kMaximumDelayMs)); |
| 367 | EXPECT_TRUE(dm_->SetMinimumDelay(kMinimumDelayMs)); |
| 368 | EXPECT_TRUE(dm_->SetBaseMinimumDelay(kBaseMinimumDelayMs)); |
| 369 | EXPECT_EQ(dm_->effective_minimum_delay_ms_for_test(), kMaximumDelayMs); |
| 370 | } |
| 371 | |
| 372 | TEST_F(DelayManagerTest, BaseMinimumDelayLowerThanMaxSize) { |
| 373 | SetPacketAudioLength(kFrameSizeMs); |
| 374 | constexpr int kMaximumDelayMs = 400; |
| 375 | constexpr int kBaseMinimumDelayMs = kMaximumDelayMs - 1; |
| 376 | constexpr int kMinimumDelayMs = 20; |
| 377 | |
| 378 | // Base minimum delay is greater than minimum delay, and lower than maximum |
| 379 | // delays that is why it is used. |
| 380 | RTC_DCHECK_GT(kBaseMinimumDelayMs, kMinimumDelayMs); |
| 381 | RTC_DCHECK_LT(kBaseMinimumDelayMs, kMaximumDelayMs); |
| 382 | |
| 383 | EXPECT_TRUE(dm_->SetMaximumDelay(kMaximumDelayMs)); |
| 384 | EXPECT_TRUE(dm_->SetMinimumDelay(kMinimumDelayMs)); |
| 385 | EXPECT_TRUE(dm_->SetBaseMinimumDelay(kBaseMinimumDelayMs)); |
| 386 | EXPECT_EQ(dm_->effective_minimum_delay_ms_for_test(), kBaseMinimumDelayMs); |
| 387 | } |
| 388 | |
| 389 | TEST_F(DelayManagerTest, MinimumDelayMemorization) { |
| 390 | // Check that when we increase base minimum delay to value higher than |
| 391 | // minimum delay then minimum delay is still memorized. This allows to |
| 392 | // restore effective minimum delay to memorized minimum delay value when we |
| 393 | // decrease base minimum delay. |
| 394 | SetPacketAudioLength(kFrameSizeMs); |
| 395 | |
| 396 | constexpr int kBaseMinimumDelayMsLow = 10; |
| 397 | constexpr int kMinimumDelayMs = 20; |
| 398 | constexpr int kBaseMinimumDelayMsHigh = 30; |
| 399 | |
| 400 | EXPECT_TRUE(dm_->SetBaseMinimumDelay(kBaseMinimumDelayMsLow)); |
| 401 | EXPECT_TRUE(dm_->SetMinimumDelay(kMinimumDelayMs)); |
| 402 | // Minimum delay is used as it is higher than base minimum delay. |
| 403 | EXPECT_EQ(dm_->effective_minimum_delay_ms_for_test(), kMinimumDelayMs); |
| 404 | |
| 405 | EXPECT_TRUE(dm_->SetBaseMinimumDelay(kBaseMinimumDelayMsHigh)); |
| 406 | // Base minimum delay is used as it is now higher than minimum delay. |
| 407 | EXPECT_EQ(dm_->effective_minimum_delay_ms_for_test(), |
| 408 | kBaseMinimumDelayMsHigh); |
| 409 | |
| 410 | EXPECT_TRUE(dm_->SetBaseMinimumDelay(kBaseMinimumDelayMsLow)); |
| 411 | // Check that minimum delay is memorized and is used again. |
| 412 | EXPECT_EQ(dm_->effective_minimum_delay_ms_for_test(), kMinimumDelayMs); |
| 413 | } |
| 414 | |
| 415 | TEST_F(DelayManagerTest, BaseMinimumDelay) { |
Ruslan Burakov | edbea46 | 2019-02-04 16:17:31 +0100 | [diff] [blame] | 416 | const int kExpectedTarget = 5; |
| 417 | const int kTimeIncrement = kExpectedTarget * kFrameSizeMs; |
| 418 | SetPacketAudioLength(kFrameSizeMs); |
| 419 | // First packet arrival. |
| 420 | InsertNextPacket(); |
| 421 | // Second packet arrival. |
| 422 | // Expect detector update method to be called once with inter-arrival time |
| 423 | // equal to |kExpectedTarget| packet. Return true to indicate peaks found. |
| 424 | EXPECT_CALL(detector_, Update(kExpectedTarget, false, _)) |
| 425 | .WillRepeatedly(Return(true)); |
| 426 | EXPECT_CALL(detector_, MaxPeakHeight()) |
| 427 | .WillRepeatedly(Return(kExpectedTarget)); |
| 428 | IncreaseTime(kTimeIncrement); |
| 429 | InsertNextPacket(); |
| 430 | |
| 431 | // No limit is applied. |
| 432 | EXPECT_EQ(kExpectedTarget << 8, dm_->TargetLevel()); |
| 433 | |
Ruslan Burakov | 4a68fb9 | 2019-02-13 14:25:39 +0100 | [diff] [blame] | 434 | constexpr int kBaseMinimumDelayPackets = kExpectedTarget + 2; |
| 435 | constexpr int kBaseMinimumDelayMs = kBaseMinimumDelayPackets * kFrameSizeMs; |
| 436 | EXPECT_TRUE(dm_->SetBaseMinimumDelay(kBaseMinimumDelayMs)); |
| 437 | EXPECT_EQ(dm_->GetBaseMinimumDelay(), kBaseMinimumDelayMs); |
Ruslan Burakov | edbea46 | 2019-02-04 16:17:31 +0100 | [diff] [blame] | 438 | |
| 439 | IncreaseTime(kTimeIncrement); |
| 440 | InsertNextPacket(); |
Ruslan Burakov | 4a68fb9 | 2019-02-13 14:25:39 +0100 | [diff] [blame] | 441 | EXPECT_EQ(dm_->GetBaseMinimumDelay(), kBaseMinimumDelayMs); |
| 442 | EXPECT_EQ(kBaseMinimumDelayPackets << 8, dm_->TargetLevel()); |
Ruslan Burakov | edbea46 | 2019-02-04 16:17:31 +0100 | [diff] [blame] | 443 | } |
| 444 | |
Ruslan Burakov | 4a68fb9 | 2019-02-13 14:25:39 +0100 | [diff] [blame] | 445 | TEST_F(DelayManagerTest, BaseMinimumDealyAffectTargetLevel) { |
| 446 | const int kExpectedTarget = 5; |
| 447 | const int kTimeIncrement = kExpectedTarget * kFrameSizeMs; |
| 448 | SetPacketAudioLength(kFrameSizeMs); |
| 449 | // First packet arrival. |
| 450 | InsertNextPacket(); |
| 451 | // Second packet arrival. |
| 452 | // Expect detector update method to be called once with inter-arrival time |
| 453 | // equal to |kExpectedTarget|. Return true to indicate peaks found. |
| 454 | EXPECT_CALL(detector_, Update(kExpectedTarget, false, _)) |
| 455 | .WillRepeatedly(Return(true)); |
| 456 | EXPECT_CALL(detector_, MaxPeakHeight()) |
| 457 | .WillRepeatedly(Return(kExpectedTarget)); |
| 458 | IncreaseTime(kTimeIncrement); |
| 459 | InsertNextPacket(); |
Ruslan Burakov | edbea46 | 2019-02-04 16:17:31 +0100 | [diff] [blame] | 460 | |
Ruslan Burakov | 4a68fb9 | 2019-02-13 14:25:39 +0100 | [diff] [blame] | 461 | // No limit is applied. |
| 462 | EXPECT_EQ(kExpectedTarget << 8, dm_->TargetLevel()); |
| 463 | |
| 464 | // Minimum delay is lower than base minimum delay, that is why base minimum |
| 465 | // delay is used to calculate target level. |
| 466 | constexpr int kMinimumDelayPackets = kExpectedTarget + 1; |
| 467 | constexpr int kBaseMinimumDelayPackets = kExpectedTarget + 2; |
| 468 | |
| 469 | constexpr int kMinimumDelayMs = kMinimumDelayPackets * kFrameSizeMs; |
| 470 | constexpr int kBaseMinimumDelayMs = kBaseMinimumDelayPackets * kFrameSizeMs; |
| 471 | |
| 472 | EXPECT_TRUE(kMinimumDelayMs < kBaseMinimumDelayMs); |
| 473 | EXPECT_TRUE(dm_->SetMinimumDelay(kMinimumDelayMs)); |
| 474 | EXPECT_TRUE(dm_->SetBaseMinimumDelay(kBaseMinimumDelayMs)); |
| 475 | EXPECT_EQ(dm_->GetBaseMinimumDelay(), kBaseMinimumDelayMs); |
| 476 | |
| 477 | IncreaseTime(kTimeIncrement); |
| 478 | InsertNextPacket(); |
| 479 | EXPECT_EQ(dm_->GetBaseMinimumDelay(), kBaseMinimumDelayMs); |
| 480 | EXPECT_EQ(kBaseMinimumDelayPackets << 8, dm_->TargetLevel()); |
Ruslan Burakov | edbea46 | 2019-02-04 16:17:31 +0100 | [diff] [blame] | 481 | } |
| 482 | |
Jakob Ivarsson | 39b934b | 2019-01-10 10:28:23 +0100 | [diff] [blame] | 483 | TEST_F(DelayManagerTest, UpdateReorderedPacket) { |
| 484 | SetPacketAudioLength(kFrameSizeMs); |
| 485 | InsertNextPacket(); |
| 486 | |
| 487 | // Insert packet that was sent before the previous packet. |
| 488 | EXPECT_CALL(detector_, Update(_, true, _)); |
| 489 | EXPECT_EQ(0, dm_->Update(seq_no_ - 1, ts_ - kFrameSizeMs, kFs)); |
| 490 | } |
| 491 | |
Jakob Ivarsson | e98954c | 2019-02-06 15:37:50 +0100 | [diff] [blame] | 492 | TEST_F(DelayManagerTest, EnableRtxHandling) { |
| 493 | enable_rtx_handling_ = true; |
Jakob Ivarsson | 1eb3d7e | 2019-02-21 15:42:31 +0100 | [diff] [blame] | 494 | use_mock_histogram_ = true; |
Jakob Ivarsson | e98954c | 2019-02-06 15:37:50 +0100 | [diff] [blame] | 495 | RecreateDelayManager(); |
Jakob Ivarsson | 1eb3d7e | 2019-02-21 15:42:31 +0100 | [diff] [blame] | 496 | EXPECT_TRUE(mock_histogram_); |
Jakob Ivarsson | e98954c | 2019-02-06 15:37:50 +0100 | [diff] [blame] | 497 | |
| 498 | // Insert first packet. |
| 499 | SetPacketAudioLength(kFrameSizeMs); |
| 500 | InsertNextPacket(); |
| 501 | |
| 502 | // Insert reordered packet. |
Jakob Ivarsson | 1eb3d7e | 2019-02-21 15:42:31 +0100 | [diff] [blame] | 503 | EXPECT_CALL(*mock_histogram_, Add(3)); |
Jakob Ivarsson | e98954c | 2019-02-06 15:37:50 +0100 | [diff] [blame] | 504 | EXPECT_EQ(0, dm_->Update(seq_no_ - 3, ts_ - 3 * kFrameSizeMs, kFs)); |
| 505 | |
| 506 | // Insert another reordered packet. |
Jakob Ivarsson | 1eb3d7e | 2019-02-21 15:42:31 +0100 | [diff] [blame] | 507 | EXPECT_CALL(*mock_histogram_, Add(2)); |
Jakob Ivarsson | e98954c | 2019-02-06 15:37:50 +0100 | [diff] [blame] | 508 | EXPECT_EQ(0, dm_->Update(seq_no_ - 2, ts_ - 2 * kFrameSizeMs, kFs)); |
| 509 | |
| 510 | // Insert the next packet in order and verify that the inter-arrival time is |
| 511 | // estimated correctly. |
| 512 | IncreaseTime(kFrameSizeMs); |
Jakob Ivarsson | 1eb3d7e | 2019-02-21 15:42:31 +0100 | [diff] [blame] | 513 | EXPECT_CALL(*mock_histogram_, Add(1)); |
Jakob Ivarsson | e98954c | 2019-02-06 15:37:50 +0100 | [diff] [blame] | 514 | InsertNextPacket(); |
| 515 | } |
| 516 | |
henrik.lundin | b8c55b1 | 2017-05-10 07:38:01 -0700 | [diff] [blame] | 517 | // Tests that skipped sequence numbers (simulating empty packets) are handled |
| 518 | // correctly. |
| 519 | TEST_F(DelayManagerTest, EmptyPacketsReported) { |
| 520 | SetPacketAudioLength(kFrameSizeMs); |
| 521 | // First packet arrival. |
| 522 | InsertNextPacket(); |
| 523 | |
| 524 | // Advance time by one frame size. |
| 525 | IncreaseTime(kFrameSizeMs); |
| 526 | |
| 527 | // Advance the sequence number by 5, simulating that 5 empty packets were |
| 528 | // received, but never inserted. |
| 529 | seq_no_ += 10; |
| 530 | for (int j = 0; j < 10; ++j) { |
| 531 | dm_->RegisterEmptyPacket(); |
| 532 | } |
| 533 | |
| 534 | // Second packet arrival. |
| 535 | // Expect detector update method to be called once with inter-arrival time |
| 536 | // equal to 1 packet, and (base) target level equal to 1 as well. |
| 537 | // Return false to indicate no peaks found. |
Jakob Ivarsson | 39b934b | 2019-01-10 10:28:23 +0100 | [diff] [blame] | 538 | EXPECT_CALL(detector_, Update(1, false, 1)).WillOnce(Return(false)); |
henrik.lundin | b8c55b1 | 2017-05-10 07:38:01 -0700 | [diff] [blame] | 539 | InsertNextPacket(); |
| 540 | |
| 541 | EXPECT_EQ(1 << 8, dm_->TargetLevel()); // In Q8. |
| 542 | } |
| 543 | |
| 544 | // Same as above, but do not call RegisterEmptyPacket. Observe the target level |
| 545 | // increase dramatically. |
| 546 | TEST_F(DelayManagerTest, EmptyPacketsNotReported) { |
| 547 | SetPacketAudioLength(kFrameSizeMs); |
| 548 | // First packet arrival. |
| 549 | InsertNextPacket(); |
| 550 | |
| 551 | // Advance time by one frame size. |
| 552 | IncreaseTime(kFrameSizeMs); |
| 553 | |
| 554 | // Advance the sequence number by 5, simulating that 5 empty packets were |
| 555 | // received, but never inserted. |
| 556 | seq_no_ += 10; |
| 557 | |
| 558 | // Second packet arrival. |
| 559 | // Expect detector update method to be called once with inter-arrival time |
| 560 | // equal to 1 packet, and (base) target level equal to 1 as well. |
| 561 | // Return false to indicate no peaks found. |
Jakob Ivarsson | 39b934b | 2019-01-10 10:28:23 +0100 | [diff] [blame] | 562 | EXPECT_CALL(detector_, Update(10, false, 10)).WillOnce(Return(false)); |
henrik.lundin | b8c55b1 | 2017-05-10 07:38:01 -0700 | [diff] [blame] | 563 | InsertNextPacket(); |
| 564 | |
| 565 | // Note 10 times higher target value. |
| 566 | EXPECT_EQ(10 * 1 << 8, dm_->TargetLevel()); // In Q8. |
| 567 | } |
| 568 | |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 569 | TEST_F(DelayManagerTest, Failures) { |
| 570 | // Wrong sample rate. |
| 571 | EXPECT_EQ(-1, dm_->Update(0, 0, -1)); |
| 572 | // Wrong packet size. |
| 573 | EXPECT_EQ(-1, dm_->SetPacketAudioLength(0)); |
| 574 | EXPECT_EQ(-1, dm_->SetPacketAudioLength(-1)); |
turaj@webrtc.org | f1efc57 | 2013-08-16 23:44:24 +0000 | [diff] [blame] | 575 | |
| 576 | // Minimum delay higher than a maximum delay is not accepted. |
| 577 | EXPECT_TRUE(dm_->SetMaximumDelay(10)); |
| 578 | EXPECT_FALSE(dm_->SetMinimumDelay(20)); |
| 579 | |
| 580 | // Maximum delay less than minimum delay is not accepted. |
| 581 | EXPECT_TRUE(dm_->SetMaximumDelay(100)); |
| 582 | EXPECT_TRUE(dm_->SetMinimumDelay(80)); |
| 583 | EXPECT_FALSE(dm_->SetMaximumDelay(60)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 584 | } |
| 585 | |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 586 | TEST_F(DelayManagerTest, TargetDelayGreaterThanOne) { |
| 587 | test::ScopedFieldTrials field_trial( |
| 588 | "WebRTC-Audio-NetEqForceTargetDelayPercentile/Enabled-0/"); |
| 589 | RecreateDelayManager(); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 590 | EXPECT_EQ(0, dm_->histogram_quantile()); |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 591 | |
| 592 | SetPacketAudioLength(kFrameSizeMs); |
| 593 | // First packet arrival. |
| 594 | InsertNextPacket(); |
| 595 | // Advance time by one frame size. |
| 596 | IncreaseTime(kFrameSizeMs); |
| 597 | // Second packet arrival. |
| 598 | // Expect detector update method to be called once with inter-arrival time |
| 599 | // equal to 1 packet. |
Jakob Ivarsson | 39b934b | 2019-01-10 10:28:23 +0100 | [diff] [blame] | 600 | EXPECT_CALL(detector_, Update(1, false, 1)).WillOnce(Return(false)); |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 601 | InsertNextPacket(); |
| 602 | constexpr int kExpectedTarget = 1; |
| 603 | EXPECT_EQ(kExpectedTarget << 8, dm_->TargetLevel()); // In Q8. |
| 604 | } |
| 605 | |
| 606 | TEST_F(DelayManagerTest, ForcedTargetDelayPercentile) { |
| 607 | { |
| 608 | test::ScopedFieldTrials field_trial( |
| 609 | "WebRTC-Audio-NetEqForceTargetDelayPercentile/Enabled-95/"); |
| 610 | RecreateDelayManager(); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 611 | EXPECT_EQ(kDefaultHistogramQuantile, dm_->histogram_quantile()); |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 612 | } |
| 613 | { |
| 614 | test::ScopedFieldTrials field_trial( |
| 615 | "WebRTC-Audio-NetEqForceTargetDelayPercentile/Enabled-99.95/"); |
| 616 | RecreateDelayManager(); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 617 | EXPECT_EQ(1073204953, dm_->histogram_quantile()); // 0.9995 in Q30. |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 618 | } |
| 619 | { |
| 620 | test::ScopedFieldTrials field_trial( |
| 621 | "WebRTC-Audio-NetEqForceTargetDelayPercentile/Disabled/"); |
| 622 | RecreateDelayManager(); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 623 | EXPECT_EQ(kDefaultHistogramQuantile, dm_->histogram_quantile()); |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 624 | } |
| 625 | { |
| 626 | test::ScopedFieldTrials field_trial( |
| 627 | "WebRTC-Audio-NetEqForceTargetDelayPercentile/Enabled--1/"); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 628 | EXPECT_EQ(kDefaultHistogramQuantile, dm_->histogram_quantile()); |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 629 | } |
| 630 | { |
| 631 | test::ScopedFieldTrials field_trial( |
| 632 | "WebRTC-Audio-NetEqForceTargetDelayPercentile/Enabled-100.1/"); |
| 633 | RecreateDelayManager(); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 634 | EXPECT_EQ(kDefaultHistogramQuantile, dm_->histogram_quantile()); |
Minyue Li | 002fbb8 | 2018-10-04 11:31:03 +0200 | [diff] [blame] | 635 | } |
| 636 | } |
| 637 | |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 638 | TEST_F(DelayManagerTest, DelayHistogramFieldTrial) { |
| 639 | { |
| 640 | test::ScopedFieldTrials field_trial( |
| 641 | "WebRTC-Audio-NetEqDelayHistogram/Enabled-96-0.998/"); |
| 642 | RecreateDelayManager(); |
| 643 | EXPECT_EQ(DelayManager::HistogramMode::RELATIVE_ARRIVAL_DELAY, |
| 644 | dm_->histogram_mode()); |
| 645 | EXPECT_EQ(1030792151, dm_->histogram_quantile()); // 0.96 in Q30. |
Jakob Ivarsson | e9a2ee2 | 2019-05-22 16:54:09 +0200 | [diff] [blame] | 646 | EXPECT_EQ( |
| 647 | 32702, |
| 648 | dm_->histogram()->base_forget_factor_for_testing()); // 0.998 in Q15. |
| 649 | EXPECT_FALSE(dm_->histogram()->start_forget_weight_for_testing()); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 650 | } |
| 651 | { |
| 652 | test::ScopedFieldTrials field_trial( |
| 653 | "WebRTC-Audio-NetEqDelayHistogram/Enabled-97.5-0.998/"); |
| 654 | RecreateDelayManager(); |
| 655 | EXPECT_EQ(DelayManager::HistogramMode::RELATIVE_ARRIVAL_DELAY, |
| 656 | dm_->histogram_mode()); |
| 657 | EXPECT_EQ(1046898278, dm_->histogram_quantile()); // 0.975 in Q30. |
Jakob Ivarsson | e9a2ee2 | 2019-05-22 16:54:09 +0200 | [diff] [blame] | 658 | EXPECT_EQ( |
| 659 | 32702, |
| 660 | dm_->histogram()->base_forget_factor_for_testing()); // 0.998 in Q15. |
| 661 | EXPECT_FALSE(dm_->histogram()->start_forget_weight_for_testing()); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 662 | } |
| 663 | { |
| 664 | // NetEqDelayHistogram should take precedence over |
| 665 | // NetEqForceTargetDelayPercentile. |
| 666 | test::ScopedFieldTrials field_trial( |
| 667 | "WebRTC-Audio-NetEqForceTargetDelayPercentile/Enabled-99.95/" |
| 668 | "WebRTC-Audio-NetEqDelayHistogram/Enabled-96-0.998/"); |
| 669 | RecreateDelayManager(); |
| 670 | EXPECT_EQ(DelayManager::HistogramMode::RELATIVE_ARRIVAL_DELAY, |
| 671 | dm_->histogram_mode()); |
| 672 | EXPECT_EQ(1030792151, dm_->histogram_quantile()); // 0.96 in Q30. |
Jakob Ivarsson | e9a2ee2 | 2019-05-22 16:54:09 +0200 | [diff] [blame] | 673 | EXPECT_EQ( |
| 674 | 32702, |
| 675 | dm_->histogram()->base_forget_factor_for_testing()); // 0.998 in Q15. |
| 676 | EXPECT_FALSE(dm_->histogram()->start_forget_weight_for_testing()); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 677 | } |
| 678 | { |
| 679 | // Invalid parameters. |
| 680 | test::ScopedFieldTrials field_trial( |
| 681 | "WebRTC-Audio-NetEqDelayHistogram/Enabled-96/"); |
| 682 | RecreateDelayManager(); |
| 683 | EXPECT_EQ(DelayManager::HistogramMode::RELATIVE_ARRIVAL_DELAY, |
| 684 | dm_->histogram_mode()); |
| 685 | EXPECT_EQ(kDefaultHistogramQuantile, |
Jonas Olsson | a4d8737 | 2019-07-05 19:08:33 +0200 | [diff] [blame^] | 686 | dm_->histogram_quantile()); // 0.95 in Q30. |
Jakob Ivarsson | e9a2ee2 | 2019-05-22 16:54:09 +0200 | [diff] [blame] | 687 | EXPECT_EQ( |
| 688 | kForgetFactor, |
| 689 | dm_->histogram()->base_forget_factor_for_testing()); // 0.9993 in Q15. |
| 690 | EXPECT_FALSE(dm_->histogram()->start_forget_weight_for_testing()); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 691 | } |
| 692 | { |
| 693 | test::ScopedFieldTrials field_trial( |
| 694 | "WebRTC-Audio-NetEqDelayHistogram/Disabled/"); |
| 695 | RecreateDelayManager(); |
| 696 | EXPECT_EQ(DelayManager::HistogramMode::INTER_ARRIVAL_TIME, |
| 697 | dm_->histogram_mode()); |
| 698 | EXPECT_EQ(kDefaultHistogramQuantile, |
Jonas Olsson | a4d8737 | 2019-07-05 19:08:33 +0200 | [diff] [blame^] | 699 | dm_->histogram_quantile()); // 0.95 in Q30. |
Jakob Ivarsson | e9a2ee2 | 2019-05-22 16:54:09 +0200 | [diff] [blame] | 700 | EXPECT_EQ( |
| 701 | kForgetFactor, |
| 702 | dm_->histogram()->base_forget_factor_for_testing()); // 0.9993 in Q15. |
| 703 | EXPECT_FALSE(dm_->histogram()->start_forget_weight_for_testing()); |
| 704 | } |
| 705 | |
| 706 | // Test parameter for new call start adaptation. |
| 707 | { |
| 708 | test::ScopedFieldTrials field_trial( |
| 709 | "WebRTC-Audio-NetEqDelayHistogram/Enabled-96-0.998-1/"); |
| 710 | RecreateDelayManager(); |
| 711 | EXPECT_EQ(dm_->histogram()->start_forget_weight_for_testing().value(), 1.0); |
| 712 | } |
| 713 | { |
| 714 | test::ScopedFieldTrials field_trial( |
| 715 | "WebRTC-Audio-NetEqDelayHistogram/Enabled-96-0.998-1.5/"); |
| 716 | RecreateDelayManager(); |
| 717 | EXPECT_EQ(dm_->histogram()->start_forget_weight_for_testing().value(), 1.5); |
| 718 | } |
| 719 | { |
| 720 | test::ScopedFieldTrials field_trial( |
| 721 | "WebRTC-Audio-NetEqDelayHistogram/Enabled-96-0.998-0.5/"); |
| 722 | RecreateDelayManager(); |
| 723 | EXPECT_FALSE(dm_->histogram()->start_forget_weight_for_testing()); |
Jakob Ivarsson | db42ed2 | 2019-02-27 10:08:09 +0100 | [diff] [blame] | 724 | } |
| 725 | } |
| 726 | |
| 727 | TEST_F(DelayManagerTest, RelativeArrivalDelayMode) { |
| 728 | histogram_mode_ = DelayManager::HistogramMode::RELATIVE_ARRIVAL_DELAY; |
| 729 | use_mock_histogram_ = true; |
| 730 | RecreateDelayManager(); |
| 731 | |
| 732 | SetPacketAudioLength(kFrameSizeMs); |
| 733 | InsertNextPacket(); |
| 734 | |
| 735 | IncreaseTime(kFrameSizeMs); |
| 736 | EXPECT_CALL(*mock_histogram_, Add(0)); // Not delayed. |
| 737 | InsertNextPacket(); |
| 738 | |
| 739 | IncreaseTime(2 * kFrameSizeMs); |
| 740 | EXPECT_CALL(*mock_histogram_, Add(1)); // 20ms delayed. |
| 741 | EXPECT_EQ(0, dm_->Update(seq_no_, ts_, kFs)); |
| 742 | |
| 743 | IncreaseTime(2 * kFrameSizeMs); |
| 744 | EXPECT_CALL(*mock_histogram_, Add(2)); // 40ms delayed. |
| 745 | EXPECT_EQ(0, dm_->Update(seq_no_ + 1, ts_ + kTsIncrement, kFs)); |
| 746 | |
| 747 | EXPECT_CALL(*mock_histogram_, Add(1)); // Reordered, 20ms delayed. |
| 748 | EXPECT_EQ(0, dm_->Update(seq_no_, ts_, kFs)); |
| 749 | } |
| 750 | |
Jakob Ivarsson | 4450708 | 2019-03-05 16:59:03 +0100 | [diff] [blame] | 751 | TEST_F(DelayManagerTest, RelativeArrivalDelayStatistic) { |
| 752 | SetPacketAudioLength(kFrameSizeMs); |
| 753 | InsertNextPacket(); |
| 754 | |
| 755 | IncreaseTime(kFrameSizeMs); |
| 756 | EXPECT_CALL(stats_, RelativePacketArrivalDelay(0)); |
| 757 | InsertNextPacket(); |
| 758 | |
| 759 | IncreaseTime(2 * kFrameSizeMs); |
| 760 | EXPECT_CALL(stats_, RelativePacketArrivalDelay(20)); |
| 761 | InsertNextPacket(); |
| 762 | } |
| 763 | |
Ruslan Burakov | 1e193fa | 2019-05-15 14:31:22 +0200 | [diff] [blame] | 764 | TEST_F(DelayManagerTest, DecelerationTargetLevelOffsetFieldTrial) { |
| 765 | { |
| 766 | test::ScopedFieldTrials field_trial( |
| 767 | "WebRTC-Audio-NetEqDecelerationTargetLevelOffset/Enabled-105/"); |
| 768 | RecreateDelayManager(); |
| 769 | EXPECT_EQ(dm_->deceleration_target_level_offset_ms().value(), 105 << 8); |
| 770 | } |
| 771 | { |
| 772 | // Negative number. |
| 773 | test::ScopedFieldTrials field_trial( |
| 774 | "WebRTC-Audio-NetEqDecelerationTargetLevelOffset/Enabled--105/"); |
| 775 | RecreateDelayManager(); |
| 776 | EXPECT_FALSE(dm_->deceleration_target_level_offset_ms().has_value()); |
| 777 | } |
| 778 | { |
| 779 | // Disabled. |
| 780 | test::ScopedFieldTrials field_trial( |
| 781 | "WebRTC-Audio-NetEqDecelerationTargetLevelOffset/Disabled/"); |
| 782 | RecreateDelayManager(); |
| 783 | EXPECT_FALSE(dm_->deceleration_target_level_offset_ms().has_value()); |
| 784 | } |
| 785 | { |
| 786 | // Float number. |
| 787 | test::ScopedFieldTrials field_trial( |
| 788 | "WebRTC-Audio-NetEqDecelerationTargetLevelOffset/Enabled-105.5/"); |
| 789 | RecreateDelayManager(); |
| 790 | EXPECT_EQ(dm_->deceleration_target_level_offset_ms().value(), 105 << 8); |
| 791 | } |
| 792 | { |
| 793 | // Several numbers. |
| 794 | test::ScopedFieldTrials field_trial( |
| 795 | "WebRTC-Audio-NetEqDecelerationTargetLevelOffset/Enabled-20-40/"); |
| 796 | RecreateDelayManager(); |
| 797 | EXPECT_EQ(dm_->deceleration_target_level_offset_ms().value(), 20 << 8); |
| 798 | } |
| 799 | } |
| 800 | |
| 801 | TEST_F(DelayManagerTest, DecelerationTargetLevelOffset) { |
| 802 | // Border value where 1/4 target buffer level meets |
| 803 | // WebRTC-Audio-NetEqDecelerationTargetLevelOffset. |
| 804 | constexpr int kBoarderTargetLevel = 100 * 4; |
| 805 | { |
| 806 | // Test that for a low target level, default behaviour is intact. |
| 807 | test::ScopedFieldTrials field_trial( |
| 808 | "WebRTC-Audio-NetEqDecelerationTargetLevelOffset/Enabled-100/"); |
| 809 | const int target_level_ms = ((kBoarderTargetLevel - 1) << 8) / kFrameSizeMs; |
| 810 | RecreateDelayManager(); |
| 811 | SetPacketAudioLength(kFrameSizeMs); |
| 812 | |
| 813 | int lower, higher; // In Q8. |
| 814 | dm_->BufferLimits(target_level_ms, &lower, &higher); |
| 815 | |
| 816 | // Default behaviour of taking 75% of target level. |
| 817 | EXPECT_EQ(target_level_ms * 3 / 4, lower); |
| 818 | EXPECT_EQ(target_level_ms, higher); |
| 819 | } |
| 820 | |
| 821 | { |
| 822 | // Test that for the high target level, |lower| is below target level by |
| 823 | // fixed constant (100 ms in this Field Trial setup). |
| 824 | test::ScopedFieldTrials field_trial( |
| 825 | "WebRTC-Audio-NetEqDecelerationTargetLevelOffset/Enabled-100/"); |
| 826 | const int target_level_ms = ((kBoarderTargetLevel + 1) << 8) / kFrameSizeMs; |
| 827 | RecreateDelayManager(); |
| 828 | SetPacketAudioLength(kFrameSizeMs); |
| 829 | |
| 830 | int lower, higher; // In Q8. |
| 831 | dm_->BufferLimits(target_level_ms, &lower, &higher); |
| 832 | |
| 833 | EXPECT_EQ(target_level_ms - ((100 << 8) / kFrameSizeMs), lower); |
| 834 | EXPECT_EQ(target_level_ms, higher); |
| 835 | } |
| 836 | |
| 837 | { |
| 838 | // Test that for the high target level, without Field Trial the behaviour |
| 839 | // will remain the same. |
| 840 | const int target_level_ms = ((kBoarderTargetLevel + 1) << 8) / kFrameSizeMs; |
| 841 | RecreateDelayManager(); |
| 842 | SetPacketAudioLength(kFrameSizeMs); |
| 843 | |
| 844 | int lower, higher; // In Q8. |
| 845 | dm_->BufferLimits(target_level_ms, &lower, &higher); |
| 846 | |
| 847 | // Default behaviour of taking 75% of target level. |
| 848 | EXPECT_EQ(target_level_ms * 3 / 4, lower); |
| 849 | EXPECT_EQ(target_level_ms, higher); |
| 850 | } |
| 851 | } |
| 852 | |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 853 | } // namespace webrtc |