henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | // Unit tests for PacketBuffer class. |
| 12 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame^] | 13 | #include "modules/audio_coding/neteq/packet_buffer.h" |
| 14 | #include "api/audio_codecs/builtin_audio_decoder_factory.h" |
| 15 | #include "modules/audio_coding/neteq/mock/mock_decoder_database.h" |
| 16 | #include "modules/audio_coding/neteq/mock/mock_statistics_calculator.h" |
| 17 | #include "modules/audio_coding/neteq/packet.h" |
| 18 | #include "modules/audio_coding/neteq/tick_timer.h" |
| 19 | #include "test/gmock.h" |
| 20 | #include "test/gtest.h" |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 21 | |
| 22 | using ::testing::Return; |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 23 | using ::testing::StrictMock; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 24 | using ::testing::_; |
henrik.lundin | 63d146b | 2017-07-05 07:03:34 -0700 | [diff] [blame] | 25 | using ::testing::InSequence; |
| 26 | using ::testing::MockFunction; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 27 | |
| 28 | namespace webrtc { |
| 29 | |
| 30 | // Helper class to generate packets. Packets must be deleted by the user. |
| 31 | class PacketGenerator { |
| 32 | public: |
| 33 | PacketGenerator(uint16_t seq_no, uint32_t ts, uint8_t pt, int frame_size); |
| 34 | virtual ~PacketGenerator() {} |
minyue@webrtc.org | c803907 | 2014-10-09 10:49:54 +0000 | [diff] [blame] | 35 | void Reset(uint16_t seq_no, uint32_t ts, uint8_t pt, int frame_size); |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 36 | Packet NextPacket(int payload_size_bytes); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 37 | |
| 38 | uint16_t seq_no_; |
| 39 | uint32_t ts_; |
| 40 | uint8_t pt_; |
| 41 | int frame_size_; |
| 42 | }; |
| 43 | |
| 44 | PacketGenerator::PacketGenerator(uint16_t seq_no, uint32_t ts, uint8_t pt, |
minyue@webrtc.org | c803907 | 2014-10-09 10:49:54 +0000 | [diff] [blame] | 45 | int frame_size) { |
| 46 | Reset(seq_no, ts, pt, frame_size); |
| 47 | } |
| 48 | |
| 49 | void PacketGenerator::Reset(uint16_t seq_no, uint32_t ts, uint8_t pt, |
| 50 | int frame_size) { |
| 51 | seq_no_ = seq_no; |
| 52 | ts_ = ts; |
| 53 | pt_ = pt; |
| 54 | frame_size_ = frame_size; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 55 | } |
| 56 | |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 57 | Packet PacketGenerator::NextPacket(int payload_size_bytes) { |
| 58 | Packet packet; |
| 59 | packet.sequence_number = seq_no_; |
| 60 | packet.timestamp = ts_; |
| 61 | packet.payload_type = pt_; |
| 62 | packet.payload.SetSize(payload_size_bytes); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 63 | ++seq_no_; |
| 64 | ts_ += frame_size_; |
| 65 | return packet; |
| 66 | } |
| 67 | |
minyue@webrtc.org | c803907 | 2014-10-09 10:49:54 +0000 | [diff] [blame] | 68 | struct PacketsToInsert { |
| 69 | uint16_t sequence_number; |
| 70 | uint32_t timestamp; |
| 71 | uint8_t payload_type; |
| 72 | bool primary; |
| 73 | // Order of this packet to appear upon extraction, after inserting a series |
| 74 | // of packets. A negative number means that it should have been discarded |
| 75 | // before extraction. |
| 76 | int extract_order; |
| 77 | }; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 78 | |
| 79 | // Start of test definitions. |
| 80 | |
| 81 | TEST(PacketBuffer, CreateAndDestroy) { |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 82 | TickTimer tick_timer; |
| 83 | PacketBuffer* buffer = new PacketBuffer(10, &tick_timer); // 10 packets. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 84 | EXPECT_TRUE(buffer->Empty()); |
| 85 | delete buffer; |
| 86 | } |
| 87 | |
| 88 | TEST(PacketBuffer, InsertPacket) { |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 89 | TickTimer tick_timer; |
| 90 | PacketBuffer buffer(10, &tick_timer); // 10 packets. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 91 | PacketGenerator gen(17u, 4711u, 0, 10); |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 92 | StrictMock<MockStatisticsCalculator> mock_stats; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 93 | |
| 94 | const int payload_len = 100; |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 95 | const Packet packet = gen.NextPacket(payload_len); |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 96 | EXPECT_EQ(0, buffer.InsertPacket(packet.Clone(), &mock_stats)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 97 | uint32_t next_ts; |
| 98 | EXPECT_EQ(PacketBuffer::kOK, buffer.NextTimestamp(&next_ts)); |
| 99 | EXPECT_EQ(4711u, next_ts); |
| 100 | EXPECT_FALSE(buffer.Empty()); |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 101 | EXPECT_EQ(1u, buffer.NumPacketsInBuffer()); |
ossu | 7a37761 | 2016-10-18 04:06:13 -0700 | [diff] [blame] | 102 | const Packet* next_packet = buffer.PeekNextPacket(); |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 103 | EXPECT_EQ(packet, *next_packet); // Compare contents. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 104 | |
| 105 | // Do not explicitly flush buffer or delete packet to test that it is deleted |
| 106 | // with the buffer. (Tested with Valgrind or similar tool.) |
| 107 | } |
| 108 | |
| 109 | // Test to flush buffer. |
| 110 | TEST(PacketBuffer, FlushBuffer) { |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 111 | TickTimer tick_timer; |
| 112 | PacketBuffer buffer(10, &tick_timer); // 10 packets. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 113 | PacketGenerator gen(0, 0, 0, 10); |
| 114 | const int payload_len = 10; |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 115 | StrictMock<MockStatisticsCalculator> mock_stats; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 116 | |
| 117 | // Insert 10 small packets; should be ok. |
| 118 | for (int i = 0; i < 10; ++i) { |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 119 | EXPECT_EQ(PacketBuffer::kOK, |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 120 | buffer.InsertPacket(gen.NextPacket(payload_len), &mock_stats)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 121 | } |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 122 | EXPECT_EQ(10u, buffer.NumPacketsInBuffer()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 123 | EXPECT_FALSE(buffer.Empty()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 124 | |
| 125 | buffer.Flush(); |
| 126 | // Buffer should delete the payloads itself. |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 127 | EXPECT_EQ(0u, buffer.NumPacketsInBuffer()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 128 | EXPECT_TRUE(buffer.Empty()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 129 | } |
| 130 | |
| 131 | // Test to fill the buffer over the limits, and verify that it flushes. |
| 132 | TEST(PacketBuffer, OverfillBuffer) { |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 133 | TickTimer tick_timer; |
| 134 | PacketBuffer buffer(10, &tick_timer); // 10 packets. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 135 | PacketGenerator gen(0, 0, 0, 10); |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 136 | StrictMock<MockStatisticsCalculator> mock_stats; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 137 | |
| 138 | // Insert 10 small packets; should be ok. |
| 139 | const int payload_len = 10; |
| 140 | int i; |
| 141 | for (i = 0; i < 10; ++i) { |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 142 | EXPECT_EQ(PacketBuffer::kOK, |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 143 | buffer.InsertPacket(gen.NextPacket(payload_len), &mock_stats)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 144 | } |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 145 | EXPECT_EQ(10u, buffer.NumPacketsInBuffer()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 146 | uint32_t next_ts; |
| 147 | EXPECT_EQ(PacketBuffer::kOK, buffer.NextTimestamp(&next_ts)); |
| 148 | EXPECT_EQ(0u, next_ts); // Expect first inserted packet to be first in line. |
| 149 | |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 150 | const Packet packet = gen.NextPacket(payload_len); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 151 | // Insert 11th packet; should flush the buffer and insert it after flushing. |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 152 | EXPECT_EQ(PacketBuffer::kFlushed, |
| 153 | buffer.InsertPacket(packet.Clone(), &mock_stats)); |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 154 | EXPECT_EQ(1u, buffer.NumPacketsInBuffer()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 155 | EXPECT_EQ(PacketBuffer::kOK, buffer.NextTimestamp(&next_ts)); |
| 156 | // Expect last inserted packet to be first in line. |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 157 | EXPECT_EQ(packet.timestamp, next_ts); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 158 | |
henrik.lundin@webrtc.org | 116ed1d | 2014-04-28 08:20:04 +0000 | [diff] [blame] | 159 | // Flush buffer to delete all packets. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 160 | buffer.Flush(); |
| 161 | } |
| 162 | |
| 163 | // Test inserting a list of packets. |
| 164 | TEST(PacketBuffer, InsertPacketList) { |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 165 | TickTimer tick_timer; |
| 166 | PacketBuffer buffer(10, &tick_timer); // 10 packets. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 167 | PacketGenerator gen(0, 0, 0, 10); |
| 168 | PacketList list; |
| 169 | const int payload_len = 10; |
| 170 | |
| 171 | // Insert 10 small packets. |
| 172 | for (int i = 0; i < 10; ++i) { |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 173 | list.push_back(gen.NextPacket(payload_len)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 174 | } |
| 175 | |
| 176 | MockDecoderDatabase decoder_database; |
henrik.lundin | ebd9fd7 | 2016-08-31 13:03:36 -0700 | [diff] [blame] | 177 | auto factory = CreateBuiltinAudioDecoderFactory(); |
ossu | f1b08da | 2016-09-23 02:19:43 -0700 | [diff] [blame] | 178 | const DecoderDatabase::DecoderInfo info(NetEqDecoder::kDecoderPCMu, factory); |
henrik.lundin | ebd9fd7 | 2016-08-31 13:03:36 -0700 | [diff] [blame] | 179 | EXPECT_CALL(decoder_database, GetDecoderInfo(0)) |
| 180 | .WillRepeatedly(Return(&info)); |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 181 | |
| 182 | StrictMock<MockStatisticsCalculator> mock_stats; |
| 183 | |
henrik.lundin | da8bbf6 | 2016-08-31 03:14:11 -0700 | [diff] [blame] | 184 | rtc::Optional<uint8_t> current_pt; |
| 185 | rtc::Optional<uint8_t> current_cng_pt; |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 186 | EXPECT_EQ(PacketBuffer::kOK, |
| 187 | buffer.InsertPacketList(&list, decoder_database, ¤t_pt, |
| 188 | ¤t_cng_pt, &mock_stats)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 189 | EXPECT_TRUE(list.empty()); // The PacketBuffer should have depleted the list. |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 190 | EXPECT_EQ(10u, buffer.NumPacketsInBuffer()); |
henrik.lundin | da8bbf6 | 2016-08-31 03:14:11 -0700 | [diff] [blame] | 191 | EXPECT_EQ(rtc::Optional<uint8_t>(0), |
| 192 | current_pt); // Current payload type changed to 0. |
| 193 | EXPECT_FALSE(current_cng_pt); // CNG payload type not changed. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 194 | |
| 195 | buffer.Flush(); // Clean up. |
| 196 | |
| 197 | EXPECT_CALL(decoder_database, Die()); // Called when object is deleted. |
| 198 | } |
| 199 | |
| 200 | // Test inserting a list of packets. Last packet is of a different payload type. |
| 201 | // Expecting the buffer to flush. |
| 202 | // TODO(hlundin): Remove this test when legacy operation is no longer needed. |
| 203 | TEST(PacketBuffer, InsertPacketListChangePayloadType) { |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 204 | TickTimer tick_timer; |
| 205 | PacketBuffer buffer(10, &tick_timer); // 10 packets. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 206 | PacketGenerator gen(0, 0, 0, 10); |
| 207 | PacketList list; |
| 208 | const int payload_len = 10; |
| 209 | |
| 210 | // Insert 10 small packets. |
| 211 | for (int i = 0; i < 10; ++i) { |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 212 | list.push_back(gen.NextPacket(payload_len)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 213 | } |
| 214 | // Insert 11th packet of another payload type (not CNG). |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 215 | { |
| 216 | Packet packet = gen.NextPacket(payload_len); |
| 217 | packet.payload_type = 1; |
| 218 | list.push_back(std::move(packet)); |
| 219 | } |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 220 | |
| 221 | MockDecoderDatabase decoder_database; |
henrik.lundin | ebd9fd7 | 2016-08-31 13:03:36 -0700 | [diff] [blame] | 222 | auto factory = CreateBuiltinAudioDecoderFactory(); |
ossu | f1b08da | 2016-09-23 02:19:43 -0700 | [diff] [blame] | 223 | const DecoderDatabase::DecoderInfo info0(NetEqDecoder::kDecoderPCMu, factory); |
henrik.lundin | ebd9fd7 | 2016-08-31 13:03:36 -0700 | [diff] [blame] | 224 | EXPECT_CALL(decoder_database, GetDecoderInfo(0)) |
| 225 | .WillRepeatedly(Return(&info0)); |
ossu | f1b08da | 2016-09-23 02:19:43 -0700 | [diff] [blame] | 226 | const DecoderDatabase::DecoderInfo info1(NetEqDecoder::kDecoderPCMa, factory); |
henrik.lundin | ebd9fd7 | 2016-08-31 13:03:36 -0700 | [diff] [blame] | 227 | EXPECT_CALL(decoder_database, GetDecoderInfo(1)) |
| 228 | .WillRepeatedly(Return(&info1)); |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 229 | |
| 230 | StrictMock<MockStatisticsCalculator> mock_stats; |
| 231 | |
henrik.lundin | da8bbf6 | 2016-08-31 03:14:11 -0700 | [diff] [blame] | 232 | rtc::Optional<uint8_t> current_pt; |
| 233 | rtc::Optional<uint8_t> current_cng_pt; |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 234 | EXPECT_EQ(PacketBuffer::kFlushed, |
| 235 | buffer.InsertPacketList(&list, decoder_database, ¤t_pt, |
| 236 | ¤t_cng_pt, &mock_stats)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 237 | EXPECT_TRUE(list.empty()); // The PacketBuffer should have depleted the list. |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 238 | EXPECT_EQ(1u, buffer.NumPacketsInBuffer()); // Only the last packet. |
henrik.lundin | da8bbf6 | 2016-08-31 03:14:11 -0700 | [diff] [blame] | 239 | EXPECT_EQ(rtc::Optional<uint8_t>(1), |
| 240 | current_pt); // Current payload type changed to 1. |
| 241 | EXPECT_FALSE(current_cng_pt); // CNG payload type not changed. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 242 | |
| 243 | buffer.Flush(); // Clean up. |
| 244 | |
| 245 | EXPECT_CALL(decoder_database, Die()); // Called when object is deleted. |
| 246 | } |
| 247 | |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 248 | TEST(PacketBuffer, ExtractOrderRedundancy) { |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 249 | TickTimer tick_timer; |
| 250 | PacketBuffer buffer(100, &tick_timer); // 100 packets. |
minyue@webrtc.org | c803907 | 2014-10-09 10:49:54 +0000 | [diff] [blame] | 251 | const int kPackets = 18; |
| 252 | const int kFrameSize = 10; |
| 253 | const int kPayloadLength = 10; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 254 | |
minyue@webrtc.org | c803907 | 2014-10-09 10:49:54 +0000 | [diff] [blame] | 255 | PacketsToInsert packet_facts[kPackets] = { |
| 256 | {0xFFFD, 0xFFFFFFD7, 0, true, 0}, |
| 257 | {0xFFFE, 0xFFFFFFE1, 0, true, 1}, |
| 258 | {0xFFFE, 0xFFFFFFD7, 1, false, -1}, |
| 259 | {0xFFFF, 0xFFFFFFEB, 0, true, 2}, |
| 260 | {0xFFFF, 0xFFFFFFE1, 1, false, -1}, |
| 261 | {0x0000, 0xFFFFFFF5, 0, true, 3}, |
| 262 | {0x0000, 0xFFFFFFEB, 1, false, -1}, |
| 263 | {0x0001, 0xFFFFFFFF, 0, true, 4}, |
| 264 | {0x0001, 0xFFFFFFF5, 1, false, -1}, |
| 265 | {0x0002, 0x0000000A, 0, true, 5}, |
| 266 | {0x0002, 0xFFFFFFFF, 1, false, -1}, |
| 267 | {0x0003, 0x0000000A, 1, false, -1}, |
| 268 | {0x0004, 0x0000001E, 0, true, 7}, |
| 269 | {0x0004, 0x00000014, 1, false, 6}, |
| 270 | {0x0005, 0x0000001E, 0, true, -1}, |
| 271 | {0x0005, 0x00000014, 1, false, -1}, |
| 272 | {0x0006, 0x00000028, 0, true, 8}, |
| 273 | {0x0006, 0x0000001E, 1, false, -1}, |
| 274 | }; |
| 275 | |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 276 | const size_t kExpectPacketsInBuffer = 9; |
minyue@webrtc.org | c803907 | 2014-10-09 10:49:54 +0000 | [diff] [blame] | 277 | |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 278 | std::vector<Packet> expect_order(kExpectPacketsInBuffer); |
minyue@webrtc.org | c803907 | 2014-10-09 10:49:54 +0000 | [diff] [blame] | 279 | |
| 280 | PacketGenerator gen(0, 0, 0, kFrameSize); |
| 281 | |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 282 | StrictMock<MockStatisticsCalculator> mock_stats; |
| 283 | |
| 284 | // Interleaving the EXPECT_CALL sequence with expectations on the MockFunction |
| 285 | // check ensures that exactly one call to PacketsDiscarded happens in each |
| 286 | // DiscardNextPacket call. |
| 287 | InSequence s; |
| 288 | MockFunction<void(int check_point_id)> check; |
minyue@webrtc.org | c803907 | 2014-10-09 10:49:54 +0000 | [diff] [blame] | 289 | for (int i = 0; i < kPackets; ++i) { |
| 290 | gen.Reset(packet_facts[i].sequence_number, |
| 291 | packet_facts[i].timestamp, |
| 292 | packet_facts[i].payload_type, |
| 293 | kFrameSize); |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 294 | Packet packet = gen.NextPacket(kPayloadLength); |
minyue-webrtc | 0c3ca75 | 2017-08-23 15:59:38 +0200 | [diff] [blame] | 295 | packet.priority.codec_level = packet_facts[i].primary ? 0 : 1; |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 296 | if (packet_facts[i].extract_order < 0) { |
minyue-webrtc | 0c3ca75 | 2017-08-23 15:59:38 +0200 | [diff] [blame] | 297 | if (packet.priority.codec_level > 0) { |
| 298 | EXPECT_CALL(mock_stats, SecondaryPacketsDiscarded(1)); |
| 299 | } else { |
| 300 | EXPECT_CALL(mock_stats, PacketsDiscarded(1)); |
| 301 | } |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 302 | } |
| 303 | EXPECT_CALL(check, Call(i)); |
| 304 | EXPECT_EQ(PacketBuffer::kOK, |
| 305 | buffer.InsertPacket(packet.Clone(), &mock_stats)); |
minyue@webrtc.org | c803907 | 2014-10-09 10:49:54 +0000 | [diff] [blame] | 306 | if (packet_facts[i].extract_order >= 0) { |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 307 | expect_order[packet_facts[i].extract_order] = std::move(packet); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 308 | } |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 309 | check.Call(i); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 310 | } |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 311 | |
minyue@webrtc.org | c803907 | 2014-10-09 10:49:54 +0000 | [diff] [blame] | 312 | EXPECT_EQ(kExpectPacketsInBuffer, buffer.NumPacketsInBuffer()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 313 | |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 314 | for (size_t i = 0; i < kExpectPacketsInBuffer; ++i) { |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 315 | const rtc::Optional<Packet> packet = buffer.GetNextPacket(); |
| 316 | EXPECT_EQ(packet, expect_order[i]); // Compare contents. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 317 | } |
minyue@webrtc.org | c803907 | 2014-10-09 10:49:54 +0000 | [diff] [blame] | 318 | EXPECT_TRUE(buffer.Empty()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 319 | } |
| 320 | |
| 321 | TEST(PacketBuffer, DiscardPackets) { |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 322 | TickTimer tick_timer; |
| 323 | PacketBuffer buffer(100, &tick_timer); // 100 packets. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 324 | const uint16_t start_seq_no = 17; |
| 325 | const uint32_t start_ts = 4711; |
| 326 | const uint32_t ts_increment = 10; |
| 327 | PacketGenerator gen(start_seq_no, start_ts, 0, ts_increment); |
| 328 | PacketList list; |
| 329 | const int payload_len = 10; |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 330 | StrictMock<MockStatisticsCalculator> mock_stats; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 331 | |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 332 | constexpr int kTotalPackets = 10; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 333 | // Insert 10 small packets. |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 334 | for (int i = 0; i < kTotalPackets; ++i) { |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 335 | buffer.InsertPacket(gen.NextPacket(payload_len), &mock_stats); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 336 | } |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 337 | EXPECT_EQ(10u, buffer.NumPacketsInBuffer()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 338 | |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 339 | uint32_t current_ts = start_ts; |
| 340 | |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 341 | // Discard them one by one and make sure that the right packets are at the |
| 342 | // front of the buffer. |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 343 | constexpr int kDiscardPackets = 5; |
henrik.lundin | 63d146b | 2017-07-05 07:03:34 -0700 | [diff] [blame] | 344 | |
| 345 | // Interleaving the EXPECT_CALL sequence with expectations on the MockFunction |
| 346 | // check ensures that exactly one call to PacketsDiscarded happens in each |
| 347 | // DiscardNextPacket call. |
| 348 | InSequence s; |
| 349 | MockFunction<void(int check_point_id)> check; |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 350 | for (int i = 0; i < kDiscardPackets; ++i) { |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 351 | uint32_t ts; |
| 352 | EXPECT_EQ(PacketBuffer::kOK, buffer.NextTimestamp(&ts)); |
| 353 | EXPECT_EQ(current_ts, ts); |
henrik.lundin | 63d146b | 2017-07-05 07:03:34 -0700 | [diff] [blame] | 354 | EXPECT_CALL(mock_stats, PacketsDiscarded(1)); |
| 355 | EXPECT_CALL(check, Call(i)); |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 356 | EXPECT_EQ(PacketBuffer::kOK, buffer.DiscardNextPacket(&mock_stats)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 357 | current_ts += ts_increment; |
henrik.lundin | 63d146b | 2017-07-05 07:03:34 -0700 | [diff] [blame] | 358 | check.Call(i); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 359 | } |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 360 | |
| 361 | constexpr int kRemainingPackets = kTotalPackets - kDiscardPackets; |
henrik.lundin | 63d146b | 2017-07-05 07:03:34 -0700 | [diff] [blame] | 362 | // This will discard all remaining packets but one. The oldest packet is older |
| 363 | // than the indicated horizon_samples, and will thus be left in the buffer. |
| 364 | constexpr size_t kSkipPackets = 1; |
minyue-webrtc | 0c3ca75 | 2017-08-23 15:59:38 +0200 | [diff] [blame] | 365 | EXPECT_CALL(mock_stats, PacketsDiscarded(1)) |
| 366 | .Times(kRemainingPackets - kSkipPackets); |
henrik.lundin | 63d146b | 2017-07-05 07:03:34 -0700 | [diff] [blame] | 367 | EXPECT_CALL(check, Call(17)); // Arbitrary id number. |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 368 | buffer.DiscardOldPackets(start_ts + kTotalPackets * ts_increment, |
| 369 | kRemainingPackets * ts_increment, &mock_stats); |
henrik.lundin | 63d146b | 2017-07-05 07:03:34 -0700 | [diff] [blame] | 370 | check.Call(17); // Same arbitrary id number. |
| 371 | |
| 372 | EXPECT_EQ(kSkipPackets, buffer.NumPacketsInBuffer()); |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 373 | uint32_t ts; |
| 374 | EXPECT_EQ(PacketBuffer::kOK, buffer.NextTimestamp(&ts)); |
| 375 | EXPECT_EQ(current_ts, ts); |
| 376 | |
| 377 | // Discard all remaining packets. |
henrik.lundin | 63d146b | 2017-07-05 07:03:34 -0700 | [diff] [blame] | 378 | EXPECT_CALL(mock_stats, PacketsDiscarded(kSkipPackets)); |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 379 | buffer.DiscardAllOldPackets(start_ts + kTotalPackets * ts_increment, |
| 380 | &mock_stats); |
| 381 | |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 382 | EXPECT_TRUE(buffer.Empty()); |
| 383 | } |
| 384 | |
| 385 | TEST(PacketBuffer, Reordering) { |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 386 | TickTimer tick_timer; |
| 387 | PacketBuffer buffer(100, &tick_timer); // 100 packets. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 388 | const uint16_t start_seq_no = 17; |
| 389 | const uint32_t start_ts = 4711; |
| 390 | const uint32_t ts_increment = 10; |
| 391 | PacketGenerator gen(start_seq_no, start_ts, 0, ts_increment); |
| 392 | const int payload_len = 10; |
| 393 | |
| 394 | // Generate 10 small packets and insert them into a PacketList. Insert every |
| 395 | // odd packet to the front, and every even packet to the back, thus creating |
| 396 | // a (rather strange) reordering. |
| 397 | PacketList list; |
| 398 | for (int i = 0; i < 10; ++i) { |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 399 | Packet packet = gen.NextPacket(payload_len); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 400 | if (i % 2) { |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 401 | list.push_front(std::move(packet)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 402 | } else { |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 403 | list.push_back(std::move(packet)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 404 | } |
| 405 | } |
| 406 | |
| 407 | MockDecoderDatabase decoder_database; |
henrik.lundin | ebd9fd7 | 2016-08-31 13:03:36 -0700 | [diff] [blame] | 408 | auto factory = CreateBuiltinAudioDecoderFactory(); |
ossu | f1b08da | 2016-09-23 02:19:43 -0700 | [diff] [blame] | 409 | const DecoderDatabase::DecoderInfo info(NetEqDecoder::kDecoderPCMu, factory); |
henrik.lundin | ebd9fd7 | 2016-08-31 13:03:36 -0700 | [diff] [blame] | 410 | EXPECT_CALL(decoder_database, GetDecoderInfo(0)) |
| 411 | .WillRepeatedly(Return(&info)); |
henrik.lundin | da8bbf6 | 2016-08-31 03:14:11 -0700 | [diff] [blame] | 412 | rtc::Optional<uint8_t> current_pt; |
| 413 | rtc::Optional<uint8_t> current_cng_pt; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 414 | |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 415 | StrictMock<MockStatisticsCalculator> mock_stats; |
| 416 | |
| 417 | EXPECT_EQ(PacketBuffer::kOK, |
| 418 | buffer.InsertPacketList(&list, decoder_database, ¤t_pt, |
| 419 | ¤t_cng_pt, &mock_stats)); |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 420 | EXPECT_EQ(10u, buffer.NumPacketsInBuffer()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 421 | |
| 422 | // Extract them and make sure that come out in the right order. |
| 423 | uint32_t current_ts = start_ts; |
| 424 | for (int i = 0; i < 10; ++i) { |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 425 | const rtc::Optional<Packet> packet = buffer.GetNextPacket(); |
| 426 | ASSERT_TRUE(packet); |
ossu | 7a37761 | 2016-10-18 04:06:13 -0700 | [diff] [blame] | 427 | EXPECT_EQ(current_ts, packet->timestamp); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 428 | current_ts += ts_increment; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 429 | } |
| 430 | EXPECT_TRUE(buffer.Empty()); |
| 431 | |
| 432 | EXPECT_CALL(decoder_database, Die()); // Called when object is deleted. |
| 433 | } |
| 434 | |
henrik.lundin | 067d855 | 2016-09-01 23:19:05 -0700 | [diff] [blame] | 435 | // The test first inserts a packet with narrow-band CNG, then a packet with |
| 436 | // wide-band speech. The expected behavior of the packet buffer is to detect a |
| 437 | // change in sample rate, even though no speech packet has been inserted before, |
| 438 | // and flush out the CNG packet. |
| 439 | TEST(PacketBuffer, CngFirstThenSpeechWithNewSampleRate) { |
| 440 | TickTimer tick_timer; |
| 441 | PacketBuffer buffer(10, &tick_timer); // 10 packets. |
| 442 | const uint8_t kCngPt = 13; |
| 443 | const int kPayloadLen = 10; |
| 444 | const uint8_t kSpeechPt = 100; |
| 445 | |
| 446 | MockDecoderDatabase decoder_database; |
| 447 | auto factory = CreateBuiltinAudioDecoderFactory(); |
ossu | f1b08da | 2016-09-23 02:19:43 -0700 | [diff] [blame] | 448 | const DecoderDatabase::DecoderInfo info_cng(NetEqDecoder::kDecoderCNGnb, |
henrik.lundin | 067d855 | 2016-09-01 23:19:05 -0700 | [diff] [blame] | 449 | factory); |
| 450 | EXPECT_CALL(decoder_database, GetDecoderInfo(kCngPt)) |
| 451 | .WillRepeatedly(Return(&info_cng)); |
| 452 | const DecoderDatabase::DecoderInfo info_speech(NetEqDecoder::kDecoderPCM16Bwb, |
ossu | f1b08da | 2016-09-23 02:19:43 -0700 | [diff] [blame] | 453 | factory); |
henrik.lundin | 067d855 | 2016-09-01 23:19:05 -0700 | [diff] [blame] | 454 | EXPECT_CALL(decoder_database, GetDecoderInfo(kSpeechPt)) |
| 455 | .WillRepeatedly(Return(&info_speech)); |
| 456 | |
| 457 | // Insert first packet, which is narrow-band CNG. |
| 458 | PacketGenerator gen(0, 0, kCngPt, 10); |
| 459 | PacketList list; |
| 460 | list.push_back(gen.NextPacket(kPayloadLen)); |
| 461 | rtc::Optional<uint8_t> current_pt; |
| 462 | rtc::Optional<uint8_t> current_cng_pt; |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 463 | |
| 464 | StrictMock<MockStatisticsCalculator> mock_stats; |
| 465 | |
henrik.lundin | 067d855 | 2016-09-01 23:19:05 -0700 | [diff] [blame] | 466 | EXPECT_EQ(PacketBuffer::kOK, |
| 467 | buffer.InsertPacketList(&list, decoder_database, ¤t_pt, |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 468 | ¤t_cng_pt, &mock_stats)); |
henrik.lundin | 067d855 | 2016-09-01 23:19:05 -0700 | [diff] [blame] | 469 | EXPECT_TRUE(list.empty()); |
| 470 | EXPECT_EQ(1u, buffer.NumPacketsInBuffer()); |
ossu | 7a37761 | 2016-10-18 04:06:13 -0700 | [diff] [blame] | 471 | ASSERT_TRUE(buffer.PeekNextPacket()); |
| 472 | EXPECT_EQ(kCngPt, buffer.PeekNextPacket()->payload_type); |
henrik.lundin | 067d855 | 2016-09-01 23:19:05 -0700 | [diff] [blame] | 473 | EXPECT_FALSE(current_pt); // Current payload type not set. |
| 474 | EXPECT_EQ(rtc::Optional<uint8_t>(kCngPt), |
| 475 | current_cng_pt); // CNG payload type set. |
| 476 | |
| 477 | // Insert second packet, which is wide-band speech. |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 478 | { |
| 479 | Packet packet = gen.NextPacket(kPayloadLen); |
| 480 | packet.payload_type = kSpeechPt; |
| 481 | list.push_back(std::move(packet)); |
| 482 | } |
henrik.lundin | 067d855 | 2016-09-01 23:19:05 -0700 | [diff] [blame] | 483 | // Expect the buffer to flush out the CNG packet, since it does not match the |
| 484 | // new speech sample rate. |
| 485 | EXPECT_EQ(PacketBuffer::kFlushed, |
| 486 | buffer.InsertPacketList(&list, decoder_database, ¤t_pt, |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 487 | ¤t_cng_pt, &mock_stats)); |
henrik.lundin | 067d855 | 2016-09-01 23:19:05 -0700 | [diff] [blame] | 488 | EXPECT_TRUE(list.empty()); |
| 489 | EXPECT_EQ(1u, buffer.NumPacketsInBuffer()); |
ossu | 7a37761 | 2016-10-18 04:06:13 -0700 | [diff] [blame] | 490 | ASSERT_TRUE(buffer.PeekNextPacket()); |
| 491 | EXPECT_EQ(kSpeechPt, buffer.PeekNextPacket()->payload_type); |
henrik.lundin | 067d855 | 2016-09-01 23:19:05 -0700 | [diff] [blame] | 492 | |
| 493 | EXPECT_EQ(rtc::Optional<uint8_t>(kSpeechPt), |
| 494 | current_pt); // Current payload type set. |
| 495 | EXPECT_FALSE(current_cng_pt); // CNG payload type reset. |
| 496 | |
| 497 | buffer.Flush(); // Clean up. |
| 498 | EXPECT_CALL(decoder_database, Die()); // Called when object is deleted. |
| 499 | } |
| 500 | |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 501 | TEST(PacketBuffer, Failures) { |
| 502 | const uint16_t start_seq_no = 17; |
| 503 | const uint32_t start_ts = 4711; |
| 504 | const uint32_t ts_increment = 10; |
| 505 | int payload_len = 100; |
| 506 | PacketGenerator gen(start_seq_no, start_ts, 0, ts_increment); |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 507 | TickTimer tick_timer; |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 508 | StrictMock<MockStatisticsCalculator> mock_stats; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 509 | |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 510 | PacketBuffer* buffer = new PacketBuffer(100, &tick_timer); // 100 packets. |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 511 | { |
| 512 | Packet packet = gen.NextPacket(payload_len); |
| 513 | packet.payload.Clear(); |
| 514 | EXPECT_EQ(PacketBuffer::kInvalidPacket, |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 515 | buffer->InsertPacket(std::move(packet), &mock_stats)); |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 516 | } |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 517 | // Buffer should still be empty. Test all empty-checks. |
| 518 | uint32_t temp_ts; |
| 519 | EXPECT_EQ(PacketBuffer::kBufferEmpty, buffer->NextTimestamp(&temp_ts)); |
| 520 | EXPECT_EQ(PacketBuffer::kBufferEmpty, |
| 521 | buffer->NextHigherTimestamp(0, &temp_ts)); |
ossu | 7a37761 | 2016-10-18 04:06:13 -0700 | [diff] [blame] | 522 | EXPECT_EQ(NULL, buffer->PeekNextPacket()); |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 523 | EXPECT_FALSE(buffer->GetNextPacket()); |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 524 | |
minyue-webrtc | fae474c | 2017-07-05 11:17:40 +0200 | [diff] [blame] | 525 | // Discarding packets will not invoke mock_stats.PacketDiscarded() because the |
| 526 | // packet buffer is empty. |
| 527 | EXPECT_EQ(PacketBuffer::kBufferEmpty, buffer->DiscardNextPacket(&mock_stats)); |
| 528 | buffer->DiscardAllOldPackets(0, &mock_stats); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 529 | |
| 530 | // Insert one packet to make the buffer non-empty. |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 531 | EXPECT_EQ(PacketBuffer::kOK, |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 532 | buffer->InsertPacket(gen.NextPacket(payload_len), &mock_stats)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 533 | EXPECT_EQ(PacketBuffer::kInvalidPointer, buffer->NextTimestamp(NULL)); |
| 534 | EXPECT_EQ(PacketBuffer::kInvalidPointer, |
| 535 | buffer->NextHigherTimestamp(0, NULL)); |
| 536 | delete buffer; |
| 537 | |
| 538 | // Insert packet list of three packets, where the second packet has an invalid |
| 539 | // payload. Expect first packet to be inserted, and the remaining two to be |
| 540 | // discarded. |
henrik.lundin | 84f8cd6 | 2016-04-26 07:45:16 -0700 | [diff] [blame] | 541 | buffer = new PacketBuffer(100, &tick_timer); // 100 packets. |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 542 | PacketList list; |
| 543 | list.push_back(gen.NextPacket(payload_len)); // Valid packet. |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 544 | { |
| 545 | Packet packet = gen.NextPacket(payload_len); |
| 546 | packet.payload.Clear(); // Invalid. |
| 547 | list.push_back(std::move(packet)); |
| 548 | } |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 549 | list.push_back(gen.NextPacket(payload_len)); // Valid packet. |
| 550 | MockDecoderDatabase decoder_database; |
henrik.lundin | ebd9fd7 | 2016-08-31 13:03:36 -0700 | [diff] [blame] | 551 | auto factory = CreateBuiltinAudioDecoderFactory(); |
ossu | f1b08da | 2016-09-23 02:19:43 -0700 | [diff] [blame] | 552 | const DecoderDatabase::DecoderInfo info(NetEqDecoder::kDecoderPCMu, factory); |
henrik.lundin | ebd9fd7 | 2016-08-31 13:03:36 -0700 | [diff] [blame] | 553 | EXPECT_CALL(decoder_database, GetDecoderInfo(0)) |
| 554 | .WillRepeatedly(Return(&info)); |
henrik.lundin | da8bbf6 | 2016-08-31 03:14:11 -0700 | [diff] [blame] | 555 | rtc::Optional<uint8_t> current_pt; |
| 556 | rtc::Optional<uint8_t> current_cng_pt; |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 557 | EXPECT_EQ(PacketBuffer::kInvalidPacket, |
minyue-webrtc | 12d3084 | 2017-07-19 11:44:06 +0200 | [diff] [blame] | 558 | buffer->InsertPacketList(&list, decoder_database, ¤t_pt, |
| 559 | ¤t_cng_pt, &mock_stats)); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 560 | EXPECT_TRUE(list.empty()); // The PacketBuffer should have depleted the list. |
Peter Kasting | dce40cf | 2015-08-24 14:52:23 -0700 | [diff] [blame] | 561 | EXPECT_EQ(1u, buffer->NumPacketsInBuffer()); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 562 | delete buffer; |
| 563 | EXPECT_CALL(decoder_database, Die()); // Called when object is deleted. |
| 564 | } |
| 565 | |
| 566 | // Test packet comparison function. |
| 567 | // The function should return true if the first packet "goes before" the second. |
| 568 | TEST(PacketBuffer, ComparePackets) { |
| 569 | PacketGenerator gen(0, 0, 0, 10); |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 570 | Packet a(gen.NextPacket(10)); // SN = 0, TS = 0. |
| 571 | Packet b(gen.NextPacket(10)); // SN = 1, TS = 10. |
| 572 | EXPECT_FALSE(a == b); |
| 573 | EXPECT_TRUE(a != b); |
| 574 | EXPECT_TRUE(a < b); |
| 575 | EXPECT_FALSE(a > b); |
| 576 | EXPECT_TRUE(a <= b); |
| 577 | EXPECT_FALSE(a >= b); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 578 | |
| 579 | // Testing wrap-around case; 'a' is earlier but has a larger timestamp value. |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 580 | a.timestamp = 0xFFFFFFFF - 10; |
| 581 | EXPECT_FALSE(a == b); |
| 582 | EXPECT_TRUE(a != b); |
| 583 | EXPECT_TRUE(a < b); |
| 584 | EXPECT_FALSE(a > b); |
| 585 | EXPECT_TRUE(a <= b); |
| 586 | EXPECT_FALSE(a >= b); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 587 | |
| 588 | // Test equal packets. |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 589 | EXPECT_TRUE(a == a); |
| 590 | EXPECT_FALSE(a != a); |
| 591 | EXPECT_FALSE(a < a); |
| 592 | EXPECT_FALSE(a > a); |
| 593 | EXPECT_TRUE(a <= a); |
| 594 | EXPECT_TRUE(a >= a); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 595 | |
| 596 | // Test equal timestamps but different sequence numbers (0 and 1). |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 597 | a.timestamp = b.timestamp; |
| 598 | EXPECT_FALSE(a == b); |
| 599 | EXPECT_TRUE(a != b); |
| 600 | EXPECT_TRUE(a < b); |
| 601 | EXPECT_FALSE(a > b); |
| 602 | EXPECT_TRUE(a <= b); |
| 603 | EXPECT_FALSE(a >= b); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 604 | |
| 605 | // Test equal timestamps but different sequence numbers (32767 and 1). |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 606 | a.sequence_number = 0xFFFF; |
| 607 | EXPECT_FALSE(a == b); |
| 608 | EXPECT_TRUE(a != b); |
| 609 | EXPECT_TRUE(a < b); |
| 610 | EXPECT_FALSE(a > b); |
| 611 | EXPECT_TRUE(a <= b); |
| 612 | EXPECT_FALSE(a >= b); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 613 | |
ossu | a70695a | 2016-09-22 02:06:28 -0700 | [diff] [blame] | 614 | // Test equal timestamps and sequence numbers, but differing priorities. |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 615 | a.sequence_number = b.sequence_number; |
| 616 | a.priority = {1, 0}; |
| 617 | b.priority = {0, 0}; |
ossu | a70695a | 2016-09-22 02:06:28 -0700 | [diff] [blame] | 618 | // a after b |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 619 | EXPECT_FALSE(a == b); |
| 620 | EXPECT_TRUE(a != b); |
| 621 | EXPECT_FALSE(a < b); |
| 622 | EXPECT_TRUE(a > b); |
| 623 | EXPECT_FALSE(a <= b); |
| 624 | EXPECT_TRUE(a >= b); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 625 | |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 626 | Packet c(gen.NextPacket(0)); // SN = 2, TS = 20. |
| 627 | Packet d(gen.NextPacket(0)); // SN = 3, TS = 20. |
| 628 | c.timestamp = b.timestamp; |
| 629 | d.timestamp = b.timestamp; |
| 630 | c.sequence_number = b.sequence_number; |
| 631 | d.sequence_number = b.sequence_number; |
| 632 | c.priority = {1, 1}; |
| 633 | d.priority = {0, 1}; |
ossu | a70695a | 2016-09-22 02:06:28 -0700 | [diff] [blame] | 634 | // c after d |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 635 | EXPECT_FALSE(c == d); |
| 636 | EXPECT_TRUE(c != d); |
| 637 | EXPECT_FALSE(c < d); |
| 638 | EXPECT_TRUE(c > d); |
| 639 | EXPECT_FALSE(c <= d); |
| 640 | EXPECT_TRUE(c >= d); |
ossu | a70695a | 2016-09-22 02:06:28 -0700 | [diff] [blame] | 641 | |
| 642 | // c after a |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 643 | EXPECT_FALSE(c == a); |
| 644 | EXPECT_TRUE(c != a); |
| 645 | EXPECT_FALSE(c < a); |
| 646 | EXPECT_TRUE(c > a); |
| 647 | EXPECT_FALSE(c <= a); |
| 648 | EXPECT_TRUE(c >= a); |
ossu | a70695a | 2016-09-22 02:06:28 -0700 | [diff] [blame] | 649 | |
| 650 | // c after b |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 651 | EXPECT_FALSE(c == b); |
| 652 | EXPECT_TRUE(c != b); |
| 653 | EXPECT_FALSE(c < b); |
| 654 | EXPECT_TRUE(c > b); |
| 655 | EXPECT_FALSE(c <= b); |
| 656 | EXPECT_TRUE(c >= b); |
ossu | a70695a | 2016-09-22 02:06:28 -0700 | [diff] [blame] | 657 | |
| 658 | // a after d |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 659 | EXPECT_FALSE(a == d); |
| 660 | EXPECT_TRUE(a != d); |
| 661 | EXPECT_FALSE(a < d); |
| 662 | EXPECT_TRUE(a > d); |
| 663 | EXPECT_FALSE(a <= d); |
| 664 | EXPECT_TRUE(a >= d); |
ossu | a70695a | 2016-09-22 02:06:28 -0700 | [diff] [blame] | 665 | |
| 666 | // d after b |
ossu | a73f6c9 | 2016-10-24 08:25:28 -0700 | [diff] [blame] | 667 | EXPECT_FALSE(d == b); |
| 668 | EXPECT_TRUE(d != b); |
| 669 | EXPECT_FALSE(d < b); |
| 670 | EXPECT_TRUE(d > b); |
| 671 | EXPECT_FALSE(d <= b); |
| 672 | EXPECT_TRUE(d >= b); |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 673 | } |
| 674 | |
henrik.lundin@webrtc.org | 52b42cb | 2014-11-04 14:03:58 +0000 | [diff] [blame] | 675 | namespace { |
| 676 | void TestIsObsoleteTimestamp(uint32_t limit_timestamp) { |
| 677 | // Check with zero horizon, which implies that the horizon is at 2^31, i.e., |
| 678 | // half the timestamp range. |
| 679 | static const uint32_t kZeroHorizon = 0; |
| 680 | static const uint32_t k2Pow31Minus1 = 0x7FFFFFFF; |
| 681 | // Timestamp on the limit is not old. |
| 682 | EXPECT_FALSE(PacketBuffer::IsObsoleteTimestamp( |
| 683 | limit_timestamp, limit_timestamp, kZeroHorizon)); |
| 684 | // 1 sample behind is old. |
| 685 | EXPECT_TRUE(PacketBuffer::IsObsoleteTimestamp( |
| 686 | limit_timestamp - 1, limit_timestamp, kZeroHorizon)); |
| 687 | // 2^31 - 1 samples behind is old. |
| 688 | EXPECT_TRUE(PacketBuffer::IsObsoleteTimestamp( |
| 689 | limit_timestamp - k2Pow31Minus1, limit_timestamp, kZeroHorizon)); |
| 690 | // 1 sample ahead is not old. |
| 691 | EXPECT_FALSE(PacketBuffer::IsObsoleteTimestamp( |
| 692 | limit_timestamp + 1, limit_timestamp, kZeroHorizon)); |
Cesar Magalhaes | f69f1fb | 2015-05-30 17:49:18 +0200 | [diff] [blame] | 693 | // If |t1-t2|=2^31 and t1>t2, t2 is older than t1 but not the opposite. |
| 694 | uint32_t other_timestamp = limit_timestamp + (1 << 31); |
| 695 | uint32_t lowest_timestamp = std::min(limit_timestamp, other_timestamp); |
| 696 | uint32_t highest_timestamp = std::max(limit_timestamp, other_timestamp); |
| 697 | EXPECT_TRUE(PacketBuffer::IsObsoleteTimestamp( |
| 698 | lowest_timestamp, highest_timestamp, kZeroHorizon)); |
henrik.lundin@webrtc.org | 52b42cb | 2014-11-04 14:03:58 +0000 | [diff] [blame] | 699 | EXPECT_FALSE(PacketBuffer::IsObsoleteTimestamp( |
Cesar Magalhaes | f69f1fb | 2015-05-30 17:49:18 +0200 | [diff] [blame] | 700 | highest_timestamp, lowest_timestamp, kZeroHorizon)); |
henrik.lundin@webrtc.org | 52b42cb | 2014-11-04 14:03:58 +0000 | [diff] [blame] | 701 | |
| 702 | // Fixed horizon at 10 samples. |
| 703 | static const uint32_t kHorizon = 10; |
| 704 | // Timestamp on the limit is not old. |
| 705 | EXPECT_FALSE(PacketBuffer::IsObsoleteTimestamp( |
| 706 | limit_timestamp, limit_timestamp, kHorizon)); |
| 707 | // 1 sample behind is old. |
| 708 | EXPECT_TRUE(PacketBuffer::IsObsoleteTimestamp( |
| 709 | limit_timestamp - 1, limit_timestamp, kHorizon)); |
| 710 | // 9 samples behind is old. |
| 711 | EXPECT_TRUE(PacketBuffer::IsObsoleteTimestamp( |
| 712 | limit_timestamp - 9, limit_timestamp, kHorizon)); |
| 713 | // 10 samples behind is not old. |
| 714 | EXPECT_FALSE(PacketBuffer::IsObsoleteTimestamp( |
| 715 | limit_timestamp - 10, limit_timestamp, kHorizon)); |
| 716 | // 2^31 - 1 samples behind is not old. |
| 717 | EXPECT_FALSE(PacketBuffer::IsObsoleteTimestamp( |
| 718 | limit_timestamp - k2Pow31Minus1, limit_timestamp, kHorizon)); |
| 719 | // 1 sample ahead is not old. |
| 720 | EXPECT_FALSE(PacketBuffer::IsObsoleteTimestamp( |
| 721 | limit_timestamp + 1, limit_timestamp, kHorizon)); |
| 722 | // 2^31 samples ahead is not old. |
| 723 | EXPECT_FALSE(PacketBuffer::IsObsoleteTimestamp( |
| 724 | limit_timestamp + (1 << 31), limit_timestamp, kHorizon)); |
| 725 | } |
| 726 | } // namespace |
| 727 | |
| 728 | // Test the IsObsoleteTimestamp method with different limit timestamps. |
| 729 | TEST(PacketBuffer, IsObsoleteTimestamp) { |
| 730 | TestIsObsoleteTimestamp(0); |
| 731 | TestIsObsoleteTimestamp(1); |
| 732 | TestIsObsoleteTimestamp(0xFFFFFFFF); // -1 in uint32_t. |
| 733 | TestIsObsoleteTimestamp(0x80000000); // 2^31. |
| 734 | TestIsObsoleteTimestamp(0x80000001); // 2^31 + 1. |
| 735 | TestIsObsoleteTimestamp(0x7FFFFFFF); // 2^31 - 1. |
| 736 | } |
henrik.lundin@webrtc.org | d94659d | 2013-01-29 12:09:21 +0000 | [diff] [blame] | 737 | } // namespace webrtc |