aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 11 | #include "modules/audio_mixer/frame_combiner.h" |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 12 | |
| 13 | #include <numeric> |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 14 | #include <string> |
| 15 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 16 | #include "audio/utility/audio_frame_operations.h" |
| 17 | #include "modules/audio_mixer/gain_change_calculator.h" |
| 18 | #include "modules/audio_mixer/sine_wave_generator.h" |
| 19 | #include "rtc_base/checks.h" |
Jonas Olsson | 366a50c | 2018-09-06 13:41:30 +0200 | [diff] [blame] | 20 | #include "rtc_base/strings/string_builder.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 21 | #include "test/gtest.h" |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 22 | |
| 23 | namespace webrtc { |
| 24 | |
| 25 | namespace { |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 26 | using LimiterType = FrameCombiner::LimiterType; |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 27 | struct FrameCombinerConfig { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 28 | bool use_limiter; |
| 29 | int sample_rate_hz; |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 30 | int number_of_channels; |
| 31 | float wave_frequency; |
| 32 | }; |
| 33 | |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 34 | std::string ProduceDebugText(int sample_rate_hz, |
| 35 | int number_of_channels, |
| 36 | int number_of_sources) { |
Jonas Olsson | 366a50c | 2018-09-06 13:41:30 +0200 | [diff] [blame] | 37 | rtc::StringBuilder ss; |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 38 | ss << "Sample rate: " << sample_rate_hz << " ,"; |
| 39 | ss << "number of channels: " << number_of_channels << " ,"; |
| 40 | ss << "number of sources: " << number_of_sources; |
Jonas Olsson | 84df1c7 | 2018-09-14 16:59:32 +0200 | [diff] [blame^] | 41 | return ss.Release(); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 42 | } |
| 43 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 44 | std::string ProduceDebugText(const FrameCombinerConfig& config) { |
Jonas Olsson | 366a50c | 2018-09-06 13:41:30 +0200 | [diff] [blame] | 45 | rtc::StringBuilder ss; |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 46 | ss << "Sample rate: " << config.sample_rate_hz << " ,"; |
| 47 | ss << "number of channels: " << config.number_of_channels << " ,"; |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 48 | ss << "limiter active: " << (config.use_limiter ? "on" : "off") << " ,"; |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 49 | ss << "wave frequency: " << config.wave_frequency << " ,"; |
Jonas Olsson | 84df1c7 | 2018-09-14 16:59:32 +0200 | [diff] [blame^] | 50 | return ss.Release(); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 51 | } |
| 52 | |
| 53 | AudioFrame frame1; |
| 54 | AudioFrame frame2; |
| 55 | AudioFrame audio_frame_for_mixing; |
| 56 | |
| 57 | void SetUpFrames(int sample_rate_hz, int number_of_channels) { |
| 58 | for (auto* frame : {&frame1, &frame2}) { |
solenberg | c7b4a45 | 2017-09-28 07:37:11 -0700 | [diff] [blame] | 59 | frame->UpdateFrame(0, nullptr, rtc::CheckedDivExact(sample_rate_hz, 100), |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 60 | sample_rate_hz, AudioFrame::kNormalSpeech, |
| 61 | AudioFrame::kVadActive, number_of_channels); |
| 62 | } |
| 63 | } |
| 64 | } // namespace |
| 65 | |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 66 | // The limiter requires sample rate divisible by 2000. |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 67 | TEST(FrameCombiner, BasicApiCallsLimiter) { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 68 | FrameCombiner combiner(true); |
| 69 | for (const int rate : {8000, 18000, 34000, 48000}) { |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 70 | for (const int number_of_channels : {1, 2}) { |
| 71 | const std::vector<AudioFrame*> all_frames = {&frame1, &frame2}; |
| 72 | SetUpFrames(rate, number_of_channels); |
| 73 | |
| 74 | for (const int number_of_frames : {0, 1, 2}) { |
| 75 | SCOPED_TRACE( |
| 76 | ProduceDebugText(rate, number_of_channels, number_of_frames)); |
| 77 | const std::vector<AudioFrame*> frames_to_combine( |
| 78 | all_frames.begin(), all_frames.begin() + number_of_frames); |
| 79 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 80 | frames_to_combine.size(), &audio_frame_for_mixing); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 81 | } |
| 82 | } |
| 83 | } |
| 84 | } |
| 85 | |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 86 | // With no limiter, the rate has to be divisible by 100 since we use |
| 87 | // 10 ms frames. |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 88 | TEST(FrameCombiner, BasicApiCallsNoLimiter) { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 89 | FrameCombiner combiner(false); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 90 | for (const int rate : {8000, 10000, 11000, 32000, 44100}) { |
| 91 | for (const int number_of_channels : {1, 2}) { |
| 92 | const std::vector<AudioFrame*> all_frames = {&frame1, &frame2}; |
| 93 | SetUpFrames(rate, number_of_channels); |
| 94 | |
| 95 | for (const int number_of_frames : {0, 1, 2}) { |
| 96 | SCOPED_TRACE( |
| 97 | ProduceDebugText(rate, number_of_channels, number_of_frames)); |
| 98 | const std::vector<AudioFrame*> frames_to_combine( |
| 99 | all_frames.begin(), all_frames.begin() + number_of_frames); |
| 100 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 101 | frames_to_combine.size(), &audio_frame_for_mixing); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 102 | } |
| 103 | } |
| 104 | } |
| 105 | } |
| 106 | |
| 107 | TEST(FrameCombiner, CombiningZeroFramesShouldProduceSilence) { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 108 | FrameCombiner combiner(false); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 109 | for (const int rate : {8000, 10000, 11000, 32000, 44100}) { |
| 110 | for (const int number_of_channels : {1, 2}) { |
| 111 | SCOPED_TRACE(ProduceDebugText(rate, number_of_channels, 0)); |
| 112 | |
| 113 | const std::vector<AudioFrame*> frames_to_combine; |
| 114 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 115 | frames_to_combine.size(), &audio_frame_for_mixing); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 116 | |
yujo | 36b1a5f | 2017-06-12 12:45:32 -0700 | [diff] [blame] | 117 | const int16_t* audio_frame_for_mixing_data = |
| 118 | audio_frame_for_mixing.data(); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 119 | const std::vector<int16_t> mixed_data( |
yujo | 36b1a5f | 2017-06-12 12:45:32 -0700 | [diff] [blame] | 120 | audio_frame_for_mixing_data, |
| 121 | audio_frame_for_mixing_data + number_of_channels * rate / 100); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 122 | |
| 123 | const std::vector<int16_t> expected(number_of_channels * rate / 100, 0); |
| 124 | EXPECT_EQ(mixed_data, expected); |
| 125 | } |
| 126 | } |
| 127 | } |
| 128 | |
| 129 | TEST(FrameCombiner, CombiningOneFrameShouldNotChangeFrame) { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 130 | FrameCombiner combiner(false); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 131 | for (const int rate : {8000, 10000, 11000, 32000, 44100}) { |
| 132 | for (const int number_of_channels : {1, 2}) { |
| 133 | SCOPED_TRACE(ProduceDebugText(rate, number_of_channels, 1)); |
| 134 | |
| 135 | SetUpFrames(rate, number_of_channels); |
yujo | 36b1a5f | 2017-06-12 12:45:32 -0700 | [diff] [blame] | 136 | int16_t* frame1_data = frame1.mutable_data(); |
| 137 | std::iota(frame1_data, frame1_data + number_of_channels * rate / 100, 0); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 138 | const std::vector<AudioFrame*> frames_to_combine = {&frame1}; |
| 139 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 140 | frames_to_combine.size(), &audio_frame_for_mixing); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 141 | |
yujo | 36b1a5f | 2017-06-12 12:45:32 -0700 | [diff] [blame] | 142 | const int16_t* audio_frame_for_mixing_data = |
| 143 | audio_frame_for_mixing.data(); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 144 | const std::vector<int16_t> mixed_data( |
yujo | 36b1a5f | 2017-06-12 12:45:32 -0700 | [diff] [blame] | 145 | audio_frame_for_mixing_data, |
| 146 | audio_frame_for_mixing_data + number_of_channels * rate / 100); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 147 | |
| 148 | std::vector<int16_t> expected(number_of_channels * rate / 100); |
| 149 | std::iota(expected.begin(), expected.end(), 0); |
| 150 | EXPECT_EQ(mixed_data, expected); |
| 151 | } |
| 152 | } |
| 153 | } |
| 154 | |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 155 | // Send a sine wave through the FrameCombiner, and check that the |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 156 | // difference between input and output varies smoothly. Also check |
| 157 | // that it is inside reasonable bounds. This is to catch issues like |
| 158 | // chromium:695993 and chromium:816875. |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 159 | TEST(FrameCombiner, GainCurveIsSmoothForAlternatingNumberOfStreams) { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 160 | // Rates are divisible by 2000 when limiter is active. |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 161 | std::vector<FrameCombinerConfig> configs = { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 162 | {false, 30100, 2, 50.f}, {false, 16500, 1, 3200.f}, |
| 163 | {true, 8000, 1, 3200.f}, {true, 16000, 1, 50.f}, |
| 164 | {true, 18000, 2, 3200.f}, {true, 10000, 2, 50.f}, |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 165 | }; |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 166 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 167 | for (const auto& config : configs) { |
| 168 | SCOPED_TRACE(ProduceDebugText(config)); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 169 | |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 170 | FrameCombiner combiner(config.use_limiter); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 171 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 172 | constexpr int16_t wave_amplitude = 30000; |
| 173 | SineWaveGenerator wave_generator(config.wave_frequency, wave_amplitude); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 174 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 175 | GainChangeCalculator change_calculator; |
| 176 | float cumulative_change = 0.f; |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 177 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 178 | constexpr size_t iterations = 100; |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 179 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 180 | for (size_t i = 0; i < iterations; ++i) { |
| 181 | SetUpFrames(config.sample_rate_hz, config.number_of_channels); |
| 182 | wave_generator.GenerateNextFrame(&frame1); |
| 183 | AudioFrameOperations::Mute(&frame2); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 184 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 185 | std::vector<AudioFrame*> frames_to_combine = {&frame1}; |
| 186 | if (i % 2 == 0) { |
| 187 | frames_to_combine.push_back(&frame2); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 188 | } |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 189 | const size_t number_of_samples = |
| 190 | frame1.samples_per_channel_ * config.number_of_channels; |
| 191 | |
| 192 | // Ensures limiter is on if 'use_limiter'. |
| 193 | constexpr size_t number_of_streams = 2; |
| 194 | combiner.Combine(frames_to_combine, config.number_of_channels, |
| 195 | config.sample_rate_hz, number_of_streams, |
| 196 | &audio_frame_for_mixing); |
| 197 | cumulative_change += change_calculator.CalculateGainChange( |
| 198 | rtc::ArrayView<const int16_t>(frame1.data(), number_of_samples), |
| 199 | rtc::ArrayView<const int16_t>(audio_frame_for_mixing.data(), |
| 200 | number_of_samples)); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 201 | } |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 202 | |
| 203 | // Check that the gain doesn't vary too much. |
| 204 | EXPECT_LT(cumulative_change, 10); |
| 205 | |
| 206 | // Check that the latest gain is within reasonable bounds. It |
| 207 | // should be slightly less that 1. |
| 208 | EXPECT_LT(0.9f, change_calculator.LatestGain()); |
| 209 | EXPECT_LT(change_calculator.LatestGain(), 1.01f); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 210 | } |
| 211 | } |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 212 | } // namespace webrtc |