blob: 321281f4c754f6dd34545929050ed91f22905f38 [file] [log] [blame]
philipelbe7a9e52016-05-19 12:19:35 +02001/*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020011#include "modules/video_coding/frame_buffer2.h"
philipelbe7a9e52016-05-19 12:19:35 +020012
13#include <algorithm>
14#include <cstring>
15#include <limits>
16#include <vector>
17
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020018#include "modules/video_coding/frame_object.h"
19#include "modules/video_coding/jitter_estimator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020020#include "modules/video_coding/timing.h"
Bjorn Tereliusa194e582017-10-25 13:07:09 +020021#include "rtc_base/numerics/sequence_number_util.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020022#include "rtc_base/platform_thread.h"
23#include "rtc_base/random.h"
24#include "system_wrappers/include/clock.h"
25#include "test/gmock.h"
26#include "test/gtest.h"
philipelbe7a9e52016-05-19 12:19:35 +020027
philipela45102f2017-02-22 05:30:39 -080028using testing::_;
29using testing::Return;
30
philipelbe7a9e52016-05-19 12:19:35 +020031namespace webrtc {
32namespace video_coding {
33
34class VCMTimingFake : public VCMTiming {
35 public:
36 explicit VCMTimingFake(Clock* clock) : VCMTiming(clock) {}
37
38 int64_t RenderTimeMs(uint32_t frame_timestamp,
39 int64_t now_ms) const override {
40 if (last_ms_ == -1) {
41 last_ms_ = now_ms + kDelayMs;
42 last_timestamp_ = frame_timestamp;
43 }
44
45 uint32_t diff = MinDiff(frame_timestamp, last_timestamp_);
46 if (AheadOf(frame_timestamp, last_timestamp_))
47 last_ms_ += diff / 90;
48 else
49 last_ms_ -= diff / 90;
50
51 last_timestamp_ = frame_timestamp;
52 return last_ms_;
53 }
54
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +010055 int64_t MaxWaitingTime(int64_t render_time_ms,
56 int64_t now_ms) const override {
57 return render_time_ms - now_ms - kDecodeTime;
philipelbe7a9e52016-05-19 12:19:35 +020058 }
59
philipela45102f2017-02-22 05:30:39 -080060 bool GetTimings(int* decode_ms,
61 int* max_decode_ms,
62 int* current_delay_ms,
63 int* target_delay_ms,
64 int* jitter_buffer_ms,
65 int* min_playout_delay_ms,
66 int* render_delay_ms) const override {
67 return true;
68 }
69
philipelbe7a9e52016-05-19 12:19:35 +020070 private:
71 static constexpr int kDelayMs = 50;
72 static constexpr int kDecodeTime = kDelayMs / 2;
73 mutable uint32_t last_timestamp_ = 0;
74 mutable int64_t last_ms_ = -1;
75};
76
77class VCMJitterEstimatorMock : public VCMJitterEstimator {
78 public:
79 explicit VCMJitterEstimatorMock(Clock* clock) : VCMJitterEstimator(clock) {}
80
81 MOCK_METHOD1(UpdateRtt, void(int64_t rttMs));
82 MOCK_METHOD3(UpdateEstimate,
83 void(int64_t frameDelayMs,
84 uint32_t frameSizeBytes,
85 bool incompleteFrame));
philipel4f6cd6a2016-08-03 10:59:32 +020086 MOCK_METHOD1(GetJitterEstimate, int(double rttMultiplier));
philipelbe7a9e52016-05-19 12:19:35 +020087};
88
philipele7c891f2018-02-22 14:35:06 +010089class FrameObjectFake : public EncodedFrame {
philipelbe7a9e52016-05-19 12:19:35 +020090 public:
philipelb4d31082016-07-11 08:46:29 -070091 int64_t ReceivedTime() const override { return 0; }
92
93 int64_t RenderTime() const override { return _renderTimeMs; }
philipela45102f2017-02-22 05:30:39 -080094
95 // In EncodedImage |_length| is used to descibe its size and |_size| to
96 // describe its capacity.
97 void SetSize(int size) { _length = size; }
98};
99
100class VCMReceiveStatisticsCallbackMock : public VCMReceiveStatisticsCallback {
101 public:
102 MOCK_METHOD2(OnReceiveRatesUpdated,
103 void(uint32_t bitRate, uint32_t frameRate));
ilnik6d5b4d62017-08-30 03:32:14 -0700104 MOCK_METHOD3(OnCompleteFrame,
105 void(bool is_keyframe,
106 size_t size_bytes,
107 VideoContentType content_type));
philipela45102f2017-02-22 05:30:39 -0800108 MOCK_METHOD1(OnDiscardedPacketsUpdated, void(int discarded_packets));
109 MOCK_METHOD1(OnFrameCountsUpdated, void(const FrameCounts& frame_counts));
110 MOCK_METHOD7(OnFrameBufferTimingsUpdated,
111 void(int decode_ms,
112 int max_decode_ms,
113 int current_delay_ms,
114 int target_delay_ms,
115 int jitter_buffer_ms,
116 int min_playout_delay_ms,
117 int render_delay_ms));
ilnik2edc6842017-07-06 03:06:50 -0700118 MOCK_METHOD1(OnTimingFrameInfoUpdated, void(const TimingFrameInfo& info));
philipelbe7a9e52016-05-19 12:19:35 +0200119};
120
121class TestFrameBuffer2 : public ::testing::Test {
122 protected:
123 static constexpr int kMaxReferences = 5;
124 static constexpr int kFps1 = 1000;
125 static constexpr int kFps10 = kFps1 / 10;
126 static constexpr int kFps20 = kFps1 / 20;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100127 static constexpr size_t kFrameSize = 10;
philipelbe7a9e52016-05-19 12:19:35 +0200128
129 TestFrameBuffer2()
130 : clock_(0),
131 timing_(&clock_),
132 jitter_estimator_(&clock_),
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200133 buffer_(new FrameBuffer(&clock_,
134 &jitter_estimator_,
135 &timing_,
136 &stats_callback_)),
philipelbe7a9e52016-05-19 12:19:35 +0200137 rand_(0x34678213),
138 tear_down_(false),
Niels Möllerc572ff32018-11-07 08:43:50 +0100139 extract_thread_(&ExtractLoop, this, "Extract Thread") {}
philipelbe7a9e52016-05-19 12:19:35 +0200140
141 void SetUp() override { extract_thread_.Start(); }
142
143 void TearDown() override {
144 tear_down_ = true;
145 trigger_extract_event_.Set();
146 extract_thread_.Stop();
147 }
148
149 template <typename... T>
philipele0b2f152016-09-28 10:23:49 +0200150 int InsertFrame(uint16_t picture_id,
151 uint8_t spatial_layer,
152 int64_t ts_ms,
153 bool inter_layer_predicted,
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100154 bool last_spatial_layer,
philipele0b2f152016-09-28 10:23:49 +0200155 T... refs) {
philipelbe7a9e52016-05-19 12:19:35 +0200156 static_assert(sizeof...(refs) <= kMaxReferences,
philipele7c891f2018-02-22 14:35:06 +0100157 "To many references specified for EncodedFrame.");
kwiberg5b9746e2017-08-16 04:52:35 -0700158 std::array<uint16_t, sizeof...(refs)> references = {
159 {rtc::checked_cast<uint16_t>(refs)...}};
philipelbe7a9e52016-05-19 12:19:35 +0200160
philipelb4d31082016-07-11 08:46:29 -0700161 std::unique_ptr<FrameObjectFake> frame(new FrameObjectFake());
philipel0fa82a62018-03-19 15:34:53 +0100162 frame->id.picture_id = picture_id;
163 frame->id.spatial_layer = spatial_layer;
Sergey Silkin61832dd2018-12-20 14:32:14 +0100164 frame->SetSpatialIndex(spatial_layer);
Niels Möller23775882018-08-16 10:24:12 +0200165 frame->SetTimestamp(ts_ms * 90);
philipelbe7a9e52016-05-19 12:19:35 +0200166 frame->num_references = references.size();
167 frame->inter_layer_predicted = inter_layer_predicted;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100168 frame->is_last_spatial_layer = last_spatial_layer;
169 // Add some data to buffer.
170 frame->VerifyAndAllocate(kFrameSize);
171 frame->SetSize(kFrameSize);
philipelbe7a9e52016-05-19 12:19:35 +0200172 for (size_t r = 0; r < references.size(); ++r)
173 frame->references[r] = references[r];
174
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200175 return buffer_->InsertFrame(std::move(frame));
philipelbe7a9e52016-05-19 12:19:35 +0200176 }
177
philipel3042c2d2017-08-18 04:55:02 -0700178 void ExtractFrame(int64_t max_wait_time = 0, bool keyframe_required = false) {
philipelbe7a9e52016-05-19 12:19:35 +0200179 crit_.Enter();
180 if (max_wait_time == 0) {
philipele7c891f2018-02-22 14:35:06 +0100181 std::unique_ptr<EncodedFrame> frame;
philipel3042c2d2017-08-18 04:55:02 -0700182 FrameBuffer::ReturnReason res =
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200183 buffer_->NextFrame(0, &frame, keyframe_required);
philipel75562822016-09-05 10:57:41 +0200184 if (res != FrameBuffer::ReturnReason::kStopped)
185 frames_.emplace_back(std::move(frame));
philipelbe7a9e52016-05-19 12:19:35 +0200186 crit_.Leave();
187 } else {
188 max_wait_time_ = max_wait_time;
189 trigger_extract_event_.Set();
190 crit_.Leave();
191 // Make sure |crit_| is aquired by |extract_thread_| before returning.
192 crit_acquired_event_.Wait(rtc::Event::kForever);
193 }
194 }
195
196 void CheckFrame(size_t index, int picture_id, int spatial_layer) {
197 rtc::CritScope lock(&crit_);
198 ASSERT_LT(index, frames_.size());
199 ASSERT_TRUE(frames_[index]);
philipel0fa82a62018-03-19 15:34:53 +0100200 ASSERT_EQ(picture_id, frames_[index]->id.picture_id);
201 ASSERT_EQ(spatial_layer, frames_[index]->id.spatial_layer);
philipelbe7a9e52016-05-19 12:19:35 +0200202 }
203
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100204 void CheckFrameSize(size_t index, size_t size) {
205 rtc::CritScope lock(&crit_);
206 ASSERT_LT(index, frames_.size());
207 ASSERT_TRUE(frames_[index]);
208 ASSERT_EQ(frames_[index]->size(), size);
209 }
210
philipelbe7a9e52016-05-19 12:19:35 +0200211 void CheckNoFrame(size_t index) {
212 rtc::CritScope lock(&crit_);
213 ASSERT_LT(index, frames_.size());
214 ASSERT_FALSE(frames_[index]);
215 }
216
tommi0f8b4032017-02-22 11:22:05 -0800217 static void ExtractLoop(void* obj) {
philipelbe7a9e52016-05-19 12:19:35 +0200218 TestFrameBuffer2* tfb = static_cast<TestFrameBuffer2*>(obj);
219 while (true) {
220 tfb->trigger_extract_event_.Wait(rtc::Event::kForever);
221 {
222 rtc::CritScope lock(&tfb->crit_);
223 tfb->crit_acquired_event_.Set();
224 if (tfb->tear_down_)
tommi0f8b4032017-02-22 11:22:05 -0800225 return;
philipelbe7a9e52016-05-19 12:19:35 +0200226
philipele7c891f2018-02-22 14:35:06 +0100227 std::unique_ptr<EncodedFrame> frame;
philipel75562822016-09-05 10:57:41 +0200228 FrameBuffer::ReturnReason res =
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200229 tfb->buffer_->NextFrame(tfb->max_wait_time_, &frame);
philipel75562822016-09-05 10:57:41 +0200230 if (res != FrameBuffer::ReturnReason::kStopped)
231 tfb->frames_.emplace_back(std::move(frame));
philipelbe7a9e52016-05-19 12:19:35 +0200232 }
233 }
234 }
235
236 uint32_t Rand() { return rand_.Rand<uint32_t>(); }
237
238 SimulatedClock clock_;
239 VCMTimingFake timing_;
philipel4f6cd6a2016-08-03 10:59:32 +0200240 ::testing::NiceMock<VCMJitterEstimatorMock> jitter_estimator_;
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200241 std::unique_ptr<FrameBuffer> buffer_;
philipele7c891f2018-02-22 14:35:06 +0100242 std::vector<std::unique_ptr<EncodedFrame>> frames_;
philipelbe7a9e52016-05-19 12:19:35 +0200243 Random rand_;
philipela45102f2017-02-22 05:30:39 -0800244 ::testing::NiceMock<VCMReceiveStatisticsCallbackMock> stats_callback_;
philipelbe7a9e52016-05-19 12:19:35 +0200245
246 int64_t max_wait_time_;
247 bool tear_down_;
248 rtc::PlatformThread extract_thread_;
249 rtc::Event trigger_extract_event_;
250 rtc::Event crit_acquired_event_;
251 rtc::CriticalSection crit_;
252};
253
philipel6e8224f2016-05-19 17:07:44 +0200254// Following tests are timing dependent. Either the timeouts have to
255// be increased by a large margin, which would slow down all trybots,
256// or we disable them for the very slow ones, like we do here.
257#if !defined(ADDRESS_SANITIZER) && !defined(MEMORY_SANITIZER)
philipelbe7a9e52016-05-19 12:19:35 +0200258TEST_F(TestFrameBuffer2, WaitForFrame) {
259 uint16_t pid = Rand();
260 uint32_t ts = Rand();
261
philipel6e8224f2016-05-19 17:07:44 +0200262 ExtractFrame(50);
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100263 InsertFrame(pid, 0, ts, false, true);
philipelbe7a9e52016-05-19 12:19:35 +0200264 CheckFrame(0, pid, 0);
265}
266
267TEST_F(TestFrameBuffer2, OneSuperFrame) {
268 uint16_t pid = Rand();
269 uint32_t ts = Rand();
270
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100271 InsertFrame(pid, 0, ts, false, false);
272 InsertFrame(pid, 1, ts, true, true);
philipele0b2f152016-09-28 10:23:49 +0200273 ExtractFrame();
274
Sergey Silkin61832dd2018-12-20 14:32:14 +0100275 CheckFrame(0, pid, 1);
philipele0b2f152016-09-28 10:23:49 +0200276}
277
gnishb2a318b2017-05-10 09:21:33 -0700278TEST_F(TestFrameBuffer2, SetPlayoutDelay) {
279 const PlayoutDelay kPlayoutDelayMs = {123, 321};
280 std::unique_ptr<FrameObjectFake> test_frame(new FrameObjectFake());
philipel0fa82a62018-03-19 15:34:53 +0100281 test_frame->id.picture_id = 0;
gnishb2a318b2017-05-10 09:21:33 -0700282 test_frame->SetPlayoutDelay(kPlayoutDelayMs);
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200283 buffer_->InsertFrame(std::move(test_frame));
gnishb2a318b2017-05-10 09:21:33 -0700284 EXPECT_EQ(kPlayoutDelayMs.min_ms, timing_.min_playout_delay());
285 EXPECT_EQ(kPlayoutDelayMs.max_ms, timing_.max_playout_delay());
286}
287
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200288TEST_F(TestFrameBuffer2, ZeroPlayoutDelay) {
289 VCMTiming timing(&clock_);
290 buffer_.reset(
291 new FrameBuffer(&clock_, &jitter_estimator_, &timing, &stats_callback_));
292 const PlayoutDelay kPlayoutDelayMs = {0, 0};
293 std::unique_ptr<FrameObjectFake> test_frame(new FrameObjectFake());
294 test_frame->id.picture_id = 0;
295 test_frame->SetPlayoutDelay(kPlayoutDelayMs);
296 buffer_->InsertFrame(std::move(test_frame));
297 ExtractFrame(0, false);
298 CheckFrame(0, 0, 0);
299 EXPECT_EQ(0, frames_[0]->RenderTimeMs());
300}
301
aleloi3e005282017-01-26 05:38:00 -0800302// Flaky test, see bugs.webrtc.org/7068.
303TEST_F(TestFrameBuffer2, DISABLED_OneUnorderedSuperFrame) {
philipele0b2f152016-09-28 10:23:49 +0200304 uint16_t pid = Rand();
305 uint32_t ts = Rand();
306
philipel6e8224f2016-05-19 17:07:44 +0200307 ExtractFrame(50);
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100308 InsertFrame(pid, 1, ts, true, true);
309 InsertFrame(pid, 0, ts, false, false);
philipelbe7a9e52016-05-19 12:19:35 +0200310 ExtractFrame();
311
312 CheckFrame(0, pid, 0);
313 CheckFrame(1, pid, 1);
314}
315
philipel94616b32016-05-20 10:43:01 +0200316TEST_F(TestFrameBuffer2, DISABLED_OneLayerStreamReordered) {
philipel6e8224f2016-05-19 17:07:44 +0200317 uint16_t pid = Rand();
318 uint32_t ts = Rand();
319
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100320 InsertFrame(pid, 0, ts, false, true);
philipel6e8224f2016-05-19 17:07:44 +0200321 ExtractFrame();
322 CheckFrame(0, pid, 0);
323 for (int i = 1; i < 10; i += 2) {
324 ExtractFrame(50);
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100325 InsertFrame(pid + i + 1, 0, ts + (i + 1) * kFps10, false, true, pid + i);
philipel6e8224f2016-05-19 17:07:44 +0200326 clock_.AdvanceTimeMilliseconds(kFps10);
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100327 InsertFrame(pid + i, 0, ts + i * kFps10, false, true, pid + i - 1);
philipel6e8224f2016-05-19 17:07:44 +0200328 clock_.AdvanceTimeMilliseconds(kFps10);
329 ExtractFrame();
330 CheckFrame(i, pid + i, 0);
331 CheckFrame(i + 1, pid + i + 1, 0);
332 }
333}
334#endif // Timing dependent tests.
335
336TEST_F(TestFrameBuffer2, ExtractFromEmptyBuffer) {
337 ExtractFrame();
338 CheckNoFrame(0);
339}
340
philipel93e451b2016-10-06 12:25:13 +0200341TEST_F(TestFrameBuffer2, MissingFrame) {
342 uint16_t pid = Rand();
343 uint32_t ts = Rand();
344
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100345 InsertFrame(pid, 0, ts, false, true);
346 InsertFrame(pid + 2, 0, ts, false, true, pid);
347 InsertFrame(pid + 3, 0, ts, false, true, pid + 1, pid + 2);
philipel93e451b2016-10-06 12:25:13 +0200348 ExtractFrame();
349 ExtractFrame();
350 ExtractFrame();
351
352 CheckFrame(0, pid, 0);
353 CheckFrame(1, pid + 2, 0);
354 CheckNoFrame(2);
355}
356
philipelbe7a9e52016-05-19 12:19:35 +0200357TEST_F(TestFrameBuffer2, OneLayerStream) {
358 uint16_t pid = Rand();
359 uint32_t ts = Rand();
360
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100361 InsertFrame(pid, 0, ts, false, true);
philipelbe7a9e52016-05-19 12:19:35 +0200362 ExtractFrame();
363 CheckFrame(0, pid, 0);
364 for (int i = 1; i < 10; ++i) {
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100365 InsertFrame(pid + i, 0, ts + i * kFps10, false, true, pid + i - 1);
philipelbe7a9e52016-05-19 12:19:35 +0200366 ExtractFrame();
367 clock_.AdvanceTimeMilliseconds(kFps10);
368 CheckFrame(i, pid + i, 0);
369 }
370}
371
philipelbe7a9e52016-05-19 12:19:35 +0200372TEST_F(TestFrameBuffer2, DropTemporalLayerSlowDecoder) {
373 uint16_t pid = Rand();
374 uint32_t ts = Rand();
375
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100376 InsertFrame(pid, 0, ts, false, true);
377 InsertFrame(pid + 1, 0, ts + kFps20, false, true, pid);
philipelbe7a9e52016-05-19 12:19:35 +0200378 for (int i = 2; i < 10; i += 2) {
379 uint32_t ts_tl0 = ts + i / 2 * kFps10;
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100380 InsertFrame(pid + i, 0, ts_tl0, false, true, pid + i - 2);
381 InsertFrame(pid + i + 1, 0, ts_tl0 + kFps20, false, true, pid + i,
382 pid + i - 1);
philipelbe7a9e52016-05-19 12:19:35 +0200383 }
384
385 for (int i = 0; i < 10; ++i) {
386 ExtractFrame();
Ilya Nikolaevskiy8c4fe162018-02-27 15:49:47 +0100387 clock_.AdvanceTimeMilliseconds(70);
philipelbe7a9e52016-05-19 12:19:35 +0200388 }
389
390 CheckFrame(0, pid, 0);
391 CheckFrame(1, pid + 1, 0);
392 CheckFrame(2, pid + 2, 0);
393 CheckFrame(3, pid + 4, 0);
394 CheckFrame(4, pid + 6, 0);
395 CheckFrame(5, pid + 8, 0);
396 CheckNoFrame(6);
397 CheckNoFrame(7);
398 CheckNoFrame(8);
399 CheckNoFrame(9);
400}
401
philipelbe7a9e52016-05-19 12:19:35 +0200402TEST_F(TestFrameBuffer2, InsertLateFrame) {
403 uint16_t pid = Rand();
404 uint32_t ts = Rand();
405
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100406 InsertFrame(pid, 0, ts, false, true);
philipelbe7a9e52016-05-19 12:19:35 +0200407 ExtractFrame();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100408 InsertFrame(pid + 2, 0, ts, false, true);
philipelbe7a9e52016-05-19 12:19:35 +0200409 ExtractFrame();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100410 InsertFrame(pid + 1, 0, ts, false, true, pid);
philipelbe7a9e52016-05-19 12:19:35 +0200411 ExtractFrame();
412
413 CheckFrame(0, pid, 0);
414 CheckFrame(1, pid + 2, 0);
415 CheckNoFrame(2);
416}
417
philipel4f6cd6a2016-08-03 10:59:32 +0200418TEST_F(TestFrameBuffer2, ProtectionMode) {
419 uint16_t pid = Rand();
420 uint32_t ts = Rand();
421
422 EXPECT_CALL(jitter_estimator_, GetJitterEstimate(1.0));
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100423 InsertFrame(pid, 0, ts, false, true);
philipel4f6cd6a2016-08-03 10:59:32 +0200424 ExtractFrame();
425
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200426 buffer_->SetProtectionMode(kProtectionNackFEC);
philipel4f6cd6a2016-08-03 10:59:32 +0200427 EXPECT_CALL(jitter_estimator_, GetJitterEstimate(0.0));
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100428 InsertFrame(pid + 1, 0, ts, false, true);
philipel4f6cd6a2016-08-03 10:59:32 +0200429 ExtractFrame();
430}
431
philipele0b2f152016-09-28 10:23:49 +0200432TEST_F(TestFrameBuffer2, NoContinuousFrame) {
433 uint16_t pid = Rand();
434 uint32_t ts = Rand();
435
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100436 EXPECT_EQ(-1, InsertFrame(pid + 1, 0, ts, false, true, pid));
philipele0b2f152016-09-28 10:23:49 +0200437}
438
439TEST_F(TestFrameBuffer2, LastContinuousFrameSingleLayer) {
440 uint16_t pid = Rand();
441 uint32_t ts = Rand();
442
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100443 EXPECT_EQ(pid, InsertFrame(pid, 0, ts, false, true));
444 EXPECT_EQ(pid, InsertFrame(pid + 2, 0, ts, false, true, pid + 1));
445 EXPECT_EQ(pid + 2, InsertFrame(pid + 1, 0, ts, false, true, pid));
446 EXPECT_EQ(pid + 2, InsertFrame(pid + 4, 0, ts, false, true, pid + 3));
447 EXPECT_EQ(pid + 5, InsertFrame(pid + 5, 0, ts, false, true));
philipele0b2f152016-09-28 10:23:49 +0200448}
449
450TEST_F(TestFrameBuffer2, LastContinuousFrameTwoLayers) {
451 uint16_t pid = Rand();
452 uint32_t ts = Rand();
453
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100454 EXPECT_EQ(pid, InsertFrame(pid, 0, ts, false, false));
455 EXPECT_EQ(pid, InsertFrame(pid, 1, ts, true, true));
456 EXPECT_EQ(pid, InsertFrame(pid + 1, 1, ts, true, true, pid));
457 EXPECT_EQ(pid, InsertFrame(pid + 2, 0, ts, false, false, pid + 1));
458 EXPECT_EQ(pid, InsertFrame(pid + 2, 1, ts, true, true, pid + 1));
459 EXPECT_EQ(pid, InsertFrame(pid + 3, 0, ts, false, false, pid + 2));
460 EXPECT_EQ(pid + 3, InsertFrame(pid + 1, 0, ts, false, false, pid));
461 EXPECT_EQ(pid + 3, InsertFrame(pid + 3, 1, ts, true, true, pid + 2));
philipele0b2f152016-09-28 10:23:49 +0200462}
463
philipelfcc60062017-01-18 05:35:20 -0800464TEST_F(TestFrameBuffer2, PictureIdJumpBack) {
465 uint16_t pid = Rand();
466 uint32_t ts = Rand();
467
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100468 EXPECT_EQ(pid, InsertFrame(pid, 0, ts, false, true));
469 EXPECT_EQ(pid + 1, InsertFrame(pid + 1, 0, ts + 1, false, true, pid));
philipelfcc60062017-01-18 05:35:20 -0800470 ExtractFrame();
471 CheckFrame(0, pid, 0);
472
473 // Jump back in pid but increase ts.
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100474 EXPECT_EQ(pid - 1, InsertFrame(pid - 1, 0, ts + 2, false, true));
philipelfcc60062017-01-18 05:35:20 -0800475 ExtractFrame();
476 ExtractFrame();
477 CheckFrame(1, pid - 1, 0);
478 CheckNoFrame(2);
479}
480
philipela45102f2017-02-22 05:30:39 -0800481TEST_F(TestFrameBuffer2, StatsCallback) {
482 uint16_t pid = Rand();
483 uint32_t ts = Rand();
484 const int kFrameSize = 5000;
485
ilnik6d5b4d62017-08-30 03:32:14 -0700486 EXPECT_CALL(stats_callback_,
487 OnCompleteFrame(true, kFrameSize, VideoContentType::UNSPECIFIED));
philipela45102f2017-02-22 05:30:39 -0800488 EXPECT_CALL(stats_callback_,
489 OnFrameBufferTimingsUpdated(_, _, _, _, _, _, _));
490
491 {
492 std::unique_ptr<FrameObjectFake> frame(new FrameObjectFake());
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100493 frame->VerifyAndAllocate(kFrameSize);
philipela45102f2017-02-22 05:30:39 -0800494 frame->SetSize(kFrameSize);
philipel0fa82a62018-03-19 15:34:53 +0100495 frame->id.picture_id = pid;
496 frame->id.spatial_layer = 0;
Niels Möller23775882018-08-16 10:24:12 +0200497 frame->SetTimestamp(ts);
philipela45102f2017-02-22 05:30:39 -0800498 frame->num_references = 0;
499 frame->inter_layer_predicted = false;
500
Stefan Holmer812ceaf2018-05-15 13:00:10 +0200501 EXPECT_EQ(buffer_->InsertFrame(std::move(frame)), pid);
philipela45102f2017-02-22 05:30:39 -0800502 }
503
504 ExtractFrame();
505 CheckFrame(0, pid, 0);
506}
507
philipel146a48b2017-04-20 04:04:38 -0700508TEST_F(TestFrameBuffer2, ForwardJumps) {
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100509 EXPECT_EQ(5453, InsertFrame(5453, 0, 1, false, true));
philipel146a48b2017-04-20 04:04:38 -0700510 ExtractFrame();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100511 EXPECT_EQ(5454, InsertFrame(5454, 0, 1, false, true, 5453));
philipel146a48b2017-04-20 04:04:38 -0700512 ExtractFrame();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100513 EXPECT_EQ(15670, InsertFrame(15670, 0, 1, false, true));
philipel146a48b2017-04-20 04:04:38 -0700514 ExtractFrame();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100515 EXPECT_EQ(29804, InsertFrame(29804, 0, 1, false, true));
philipel146a48b2017-04-20 04:04:38 -0700516 ExtractFrame();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100517 EXPECT_EQ(29805, InsertFrame(29805, 0, 1, false, true, 29804));
philipel146a48b2017-04-20 04:04:38 -0700518 ExtractFrame();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100519 EXPECT_EQ(29806, InsertFrame(29806, 0, 1, false, true, 29805));
philipel146a48b2017-04-20 04:04:38 -0700520 ExtractFrame();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100521 EXPECT_EQ(33819, InsertFrame(33819, 0, 1, false, true));
philipel146a48b2017-04-20 04:04:38 -0700522 ExtractFrame();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100523 EXPECT_EQ(41248, InsertFrame(41248, 0, 1, false, true));
philipel146a48b2017-04-20 04:04:38 -0700524 ExtractFrame();
525}
526
philipelf6842692017-04-28 03:29:15 -0700527TEST_F(TestFrameBuffer2, DuplicateFrames) {
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100528 EXPECT_EQ(22256, InsertFrame(22256, 0, 1, false, true));
philipelf6842692017-04-28 03:29:15 -0700529 ExtractFrame();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100530 EXPECT_EQ(22256, InsertFrame(22256, 0, 1, false, true));
philipelf6842692017-04-28 03:29:15 -0700531}
532
philipel112adf92017-06-15 09:06:21 -0700533// TODO(philipel): implement more unittests related to invalid references.
534TEST_F(TestFrameBuffer2, InvalidReferences) {
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100535 EXPECT_EQ(-1, InsertFrame(0, 0, 1000, false, true, 2));
536 EXPECT_EQ(1, InsertFrame(1, 0, 2000, false, true));
philipel112adf92017-06-15 09:06:21 -0700537 ExtractFrame();
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100538 EXPECT_EQ(2, InsertFrame(2, 0, 3000, false, true, 1));
philipel112adf92017-06-15 09:06:21 -0700539}
540
philipel3042c2d2017-08-18 04:55:02 -0700541TEST_F(TestFrameBuffer2, KeyframeRequired) {
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100542 EXPECT_EQ(1, InsertFrame(1, 0, 1000, false, true));
543 EXPECT_EQ(2, InsertFrame(2, 0, 2000, false, true, 1));
544 EXPECT_EQ(3, InsertFrame(3, 0, 3000, false, true));
philipel3042c2d2017-08-18 04:55:02 -0700545 ExtractFrame();
546 ExtractFrame(0, true);
547 ExtractFrame();
548
549 CheckFrame(0, 1, 0);
550 CheckFrame(1, 3, 0);
551 CheckNoFrame(2);
552}
553
philipel9771c502018-03-02 11:06:27 +0100554TEST_F(TestFrameBuffer2, KeyframeClearsFullBuffer) {
555 const int kMaxBufferSize = 600;
556
557 for (int i = 1; i <= kMaxBufferSize; ++i)
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100558 EXPECT_EQ(-1, InsertFrame(i, 0, i * 1000, false, true, i - 1));
philipel9771c502018-03-02 11:06:27 +0100559 ExtractFrame();
560 CheckNoFrame(0);
561
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100562 EXPECT_EQ(kMaxBufferSize + 1,
563 InsertFrame(kMaxBufferSize + 1, 0, (kMaxBufferSize + 1) * 1000,
564 false, true));
philipel9771c502018-03-02 11:06:27 +0100565 ExtractFrame();
566 CheckFrame(1, kMaxBufferSize + 1, 0);
567}
568
philipel798b2822018-06-11 13:10:14 +0200569TEST_F(TestFrameBuffer2, DontUpdateOnUndecodableFrame) {
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100570 InsertFrame(1, 0, 0, false, true);
philipel798b2822018-06-11 13:10:14 +0200571 ExtractFrame(0, true);
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100572 InsertFrame(3, 0, 0, false, true, 2, 0);
573 InsertFrame(3, 0, 0, false, true, 0);
574 InsertFrame(2, 0, 0, false, true);
philipel798b2822018-06-11 13:10:14 +0200575 ExtractFrame(0, true);
576 ExtractFrame(0, true);
577}
578
philipel6d216502018-10-22 14:36:45 +0200579TEST_F(TestFrameBuffer2, DontDecodeOlderTimestamp) {
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100580 InsertFrame(2, 0, 1, false, true);
581 InsertFrame(1, 0, 2, false, true); // Older picture id but newer timestamp.
philipel6d216502018-10-22 14:36:45 +0200582 ExtractFrame(0);
583 ExtractFrame(0);
584 CheckFrame(0, 1, 0);
585 CheckNoFrame(1);
586
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100587 InsertFrame(3, 0, 4, false, true);
588 InsertFrame(4, 0, 3, false, true); // Newer picture id but older timestamp.
philipel6d216502018-10-22 14:36:45 +0200589 ExtractFrame(0);
590 ExtractFrame(0);
591 CheckFrame(2, 3, 0);
592 CheckNoFrame(3);
593}
594
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100595TEST_F(TestFrameBuffer2, CombineFramesToSuperframe) {
596 uint16_t pid = Rand();
597 uint32_t ts = Rand();
598
599 InsertFrame(pid, 0, ts, false, false);
600 InsertFrame(pid, 1, ts, true, true);
601 ExtractFrame(0);
602 ExtractFrame(0);
Sergey Silkin61832dd2018-12-20 14:32:14 +0100603 CheckFrame(0, pid, 1);
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100604 CheckNoFrame(1);
605 // Two frames should be combined and returned together.
606 CheckFrameSize(0, kFrameSize * 2);
607}
608
609TEST_F(TestFrameBuffer2, HigherSpatialLayerNonDecodable) {
610 uint16_t pid = Rand();
611 uint32_t ts = Rand();
612
613 InsertFrame(pid, 0, ts, false, false);
614 InsertFrame(pid, 1, ts, true, true);
615
616 ExtractFrame(0);
Sergey Silkin61832dd2018-12-20 14:32:14 +0100617 CheckFrame(0, pid, 1);
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100618
619 InsertFrame(pid + 1, 1, ts + kFps20, false, true, pid);
620 InsertFrame(pid + 2, 0, ts + kFps10, false, false, pid);
621 InsertFrame(pid + 2, 1, ts + kFps10, true, true, pid + 1);
622
623 clock_.AdvanceTimeMilliseconds(1000);
624 // Frame pid+1 is decodable but too late.
625 // In superframe pid+2 frame sid=0 is decodable, but frame sid=1 is not.
626 // Incorrect implementation might skip pid+1 frame and output undecodable
627 // pid+2 instead.
628 ExtractFrame();
629 ExtractFrame();
630 CheckFrame(1, pid + 1, 1);
Sergey Silkin61832dd2018-12-20 14:32:14 +0100631 CheckFrame(2, pid + 2, 1);
Ilya Nikolaevskiy5546aef2018-12-04 15:54:52 +0100632}
633
philipelbe7a9e52016-05-19 12:19:35 +0200634} // namespace video_coding
635} // namespace webrtc