Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2019 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Mirko Bonadei | 317a1f0 | 2019-09-17 17:06:18 +0200 | [diff] [blame] | 11 | #include <memory> |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 12 | #include <ostream> // no-presubmit-check TODO(webrtc:8982) |
| 13 | |
| 14 | #include "absl/algorithm/container.h" |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 15 | #include "api/audio_codecs/builtin_audio_decoder_factory.h" |
| 16 | #include "api/audio_codecs/builtin_audio_encoder_factory.h" |
| 17 | #include "api/create_peerconnection_factory.h" |
Amit Hilbuch | f477040 | 2019-04-08 14:11:57 -0700 | [diff] [blame] | 18 | #include "api/media_types.h" |
| 19 | #include "api/rtc_error.h" |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 20 | #include "api/rtp_transceiver_interface.h" |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 21 | #include "api/uma_metrics.h" |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 22 | #include "api/video_codecs/builtin_video_decoder_factory.h" |
| 23 | #include "api/video_codecs/builtin_video_encoder_factory.h" |
| 24 | #include "pc/peer_connection.h" |
| 25 | #include "pc/peer_connection_wrapper.h" |
| 26 | #include "pc/test/fake_audio_capture_module.h" |
| 27 | #include "pc/test/mock_peer_connection_observers.h" |
| 28 | #include "rtc_base/gunit.h" |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 29 | #include "system_wrappers/include/metrics.h" |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 30 | #include "test/gmock.h" |
| 31 | |
| 32 | using ::testing::Contains; |
| 33 | using ::testing::Each; |
| 34 | using ::testing::ElementsAre; |
| 35 | using ::testing::ElementsAreArray; |
| 36 | using ::testing::Eq; |
| 37 | using ::testing::Field; |
| 38 | using ::testing::IsEmpty; |
| 39 | using ::testing::Ne; |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 40 | using ::testing::Pair; |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 41 | using ::testing::Property; |
| 42 | using ::testing::SizeIs; |
| 43 | |
| 44 | using cricket::MediaContentDescription; |
| 45 | using cricket::RidDescription; |
| 46 | using cricket::SimulcastDescription; |
| 47 | using cricket::SimulcastLayer; |
| 48 | using cricket::StreamParams; |
| 49 | |
| 50 | namespace cricket { |
| 51 | |
| 52 | std::ostream& operator<<( // no-presubmit-check TODO(webrtc:8982) |
| 53 | std::ostream& os, // no-presubmit-check TODO(webrtc:8982) |
| 54 | const SimulcastLayer& layer) { |
| 55 | if (layer.is_paused) { |
| 56 | os << "~"; |
| 57 | } |
| 58 | return os << layer.rid; |
| 59 | } |
| 60 | |
| 61 | } // namespace cricket |
| 62 | |
| 63 | namespace { |
| 64 | |
| 65 | std::vector<SimulcastLayer> CreateLayers(const std::vector<std::string>& rids, |
| 66 | const std::vector<bool>& active) { |
| 67 | RTC_DCHECK_EQ(rids.size(), active.size()); |
| 68 | std::vector<SimulcastLayer> result; |
| 69 | absl::c_transform(rids, active, std::back_inserter(result), |
| 70 | [](const std::string& rid, bool is_active) { |
| 71 | return SimulcastLayer(rid, !is_active); |
| 72 | }); |
| 73 | return result; |
| 74 | } |
| 75 | std::vector<SimulcastLayer> CreateLayers(const std::vector<std::string>& rids, |
| 76 | bool active) { |
| 77 | return CreateLayers(rids, std::vector<bool>(rids.size(), active)); |
| 78 | } |
| 79 | |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 80 | std::vector<SimulcastLayer> CreateLayers(int num_layers, bool active) { |
| 81 | rtc::UniqueStringGenerator rid_generator; |
| 82 | std::vector<std::string> rids; |
| 83 | for (int i = 0; i < num_layers; ++i) { |
| 84 | rids.push_back(rid_generator()); |
| 85 | } |
| 86 | return CreateLayers(rids, active); |
| 87 | } |
| 88 | |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 89 | } // namespace |
| 90 | namespace webrtc { |
| 91 | |
Mirko Bonadei | 6a489f2 | 2019-04-09 15:11:12 +0200 | [diff] [blame] | 92 | class PeerConnectionSimulcastTests : public ::testing::Test { |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 93 | public: |
| 94 | PeerConnectionSimulcastTests() |
| 95 | : pc_factory_( |
| 96 | CreatePeerConnectionFactory(rtc::Thread::Current(), |
| 97 | rtc::Thread::Current(), |
| 98 | rtc::Thread::Current(), |
| 99 | FakeAudioCaptureModule::Create(), |
| 100 | CreateBuiltinAudioEncoderFactory(), |
| 101 | CreateBuiltinAudioDecoderFactory(), |
| 102 | CreateBuiltinVideoEncoderFactory(), |
| 103 | CreateBuiltinVideoDecoderFactory(), |
| 104 | nullptr, |
| 105 | nullptr)) {} |
| 106 | |
| 107 | rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection( |
| 108 | MockPeerConnectionObserver* observer) { |
| 109 | PeerConnectionInterface::RTCConfiguration config; |
| 110 | config.sdp_semantics = SdpSemantics::kUnifiedPlan; |
| 111 | PeerConnectionDependencies pcd(observer); |
| 112 | auto pc = pc_factory_->CreatePeerConnection(config, std::move(pcd)); |
| 113 | EXPECT_TRUE(pc); |
| 114 | observer->SetPeerConnectionInterface(pc); |
| 115 | return pc; |
| 116 | } |
| 117 | |
| 118 | std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWrapper() { |
Mirko Bonadei | 317a1f0 | 2019-09-17 17:06:18 +0200 | [diff] [blame] | 119 | auto observer = std::make_unique<MockPeerConnectionObserver>(); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 120 | auto pc = CreatePeerConnection(observer.get()); |
Mirko Bonadei | 317a1f0 | 2019-09-17 17:06:18 +0200 | [diff] [blame] | 121 | return std::make_unique<PeerConnectionWrapper>(pc_factory_, pc, |
| 122 | std::move(observer)); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 123 | } |
| 124 | |
Amit Hilbuch | 619b294 | 2019-02-26 15:55:19 -0800 | [diff] [blame] | 125 | void ExchangeOfferAnswer(PeerConnectionWrapper* local, |
| 126 | PeerConnectionWrapper* remote, |
| 127 | const std::vector<SimulcastLayer>& answer_layers) { |
| 128 | auto offer = local->CreateOfferAndSetAsLocal(); |
| 129 | // Remove simulcast as the second peer connection won't support it. |
Amit Hilbuch | aabd036 | 2019-03-01 13:14:46 -0800 | [diff] [blame] | 130 | RemoveSimulcast(offer.get()); |
Amit Hilbuch | 619b294 | 2019-02-26 15:55:19 -0800 | [diff] [blame] | 131 | std::string err; |
| 132 | EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &err)) << err; |
| 133 | auto answer = remote->CreateAnswerAndSetAsLocal(); |
| 134 | // Setup the answer to look like a server response. |
| 135 | auto mcd_answer = answer->description()->contents()[0].media_description(); |
| 136 | auto& receive_layers = mcd_answer->simulcast_description().receive_layers(); |
| 137 | for (const SimulcastLayer& layer : answer_layers) { |
| 138 | receive_layers.AddLayer(layer); |
| 139 | } |
| 140 | EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &err)) << err; |
| 141 | } |
| 142 | |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 143 | RtpTransceiverInit CreateTransceiverInit( |
| 144 | const std::vector<SimulcastLayer>& layers) { |
| 145 | RtpTransceiverInit init; |
| 146 | for (const SimulcastLayer& layer : layers) { |
| 147 | RtpEncodingParameters encoding; |
| 148 | encoding.rid = layer.rid; |
| 149 | encoding.active = !layer.is_paused; |
| 150 | init.send_encodings.push_back(encoding); |
| 151 | } |
| 152 | return init; |
| 153 | } |
| 154 | |
| 155 | rtc::scoped_refptr<RtpTransceiverInterface> AddTransceiver( |
| 156 | PeerConnectionWrapper* pc, |
| 157 | const std::vector<SimulcastLayer>& layers) { |
| 158 | auto init = CreateTransceiverInit(layers); |
| 159 | return pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init); |
| 160 | } |
| 161 | |
| 162 | SimulcastDescription RemoveSimulcast(SessionDescriptionInterface* sd) { |
| 163 | auto mcd = sd->description()->contents()[0].media_description(); |
| 164 | auto result = mcd->simulcast_description(); |
| 165 | mcd->set_simulcast_description(SimulcastDescription()); |
| 166 | return result; |
| 167 | } |
| 168 | |
| 169 | void AddRequestToReceiveSimulcast(const std::vector<SimulcastLayer>& layers, |
| 170 | SessionDescriptionInterface* sd) { |
| 171 | auto mcd = sd->description()->contents()[0].media_description(); |
| 172 | SimulcastDescription simulcast; |
| 173 | auto& receive_layers = simulcast.receive_layers(); |
| 174 | for (const SimulcastLayer& layer : layers) { |
| 175 | receive_layers.AddLayer(layer); |
| 176 | } |
| 177 | mcd->set_simulcast_description(simulcast); |
| 178 | } |
| 179 | |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 180 | void ValidateTransceiverParameters( |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 181 | rtc::scoped_refptr<RtpTransceiverInterface> transceiver, |
| 182 | const std::vector<SimulcastLayer>& layers) { |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 183 | auto parameters = transceiver->sender()->GetParameters(); |
| 184 | std::vector<SimulcastLayer> result_layers; |
| 185 | absl::c_transform(parameters.encodings, std::back_inserter(result_layers), |
| 186 | [](const RtpEncodingParameters& encoding) { |
| 187 | return SimulcastLayer(encoding.rid, !encoding.active); |
| 188 | }); |
| 189 | EXPECT_THAT(result_layers, ElementsAreArray(layers)); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 190 | } |
| 191 | |
| 192 | private: |
| 193 | rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_; |
| 194 | }; |
| 195 | |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 196 | // This class is used to test the metrics emitted for simulcast. |
| 197 | class PeerConnectionSimulcastMetricsTests |
| 198 | : public PeerConnectionSimulcastTests, |
| 199 | public ::testing::WithParamInterface<int> { |
| 200 | protected: |
| 201 | PeerConnectionSimulcastMetricsTests() { webrtc::metrics::Reset(); } |
| 202 | |
| 203 | std::map<int, int> LocalDescriptionSamples() { |
| 204 | return metrics::Samples( |
| 205 | "WebRTC.PeerConnection.Simulcast.ApplyLocalDescription"); |
| 206 | } |
| 207 | std::map<int, int> RemoteDescriptionSamples() { |
| 208 | return metrics::Samples( |
| 209 | "WebRTC.PeerConnection.Simulcast.ApplyRemoteDescription"); |
| 210 | } |
| 211 | }; |
| 212 | |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 213 | // Validates that RIDs are supported arguments when adding a transceiver. |
| 214 | TEST_F(PeerConnectionSimulcastTests, CanCreateTransceiverWithRid) { |
| 215 | auto pc = CreatePeerConnectionWrapper(); |
| 216 | auto layers = CreateLayers({"f"}, true); |
| 217 | auto transceiver = AddTransceiver(pc.get(), layers); |
| 218 | ASSERT_TRUE(transceiver); |
| 219 | auto parameters = transceiver->sender()->GetParameters(); |
| 220 | // Single RID should be removed. |
| 221 | EXPECT_THAT(parameters.encodings, |
Amit Hilbuch | 2297d33 | 2019-02-19 12:49:22 -0800 | [diff] [blame] | 222 | ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq("")))); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 223 | } |
| 224 | |
| 225 | TEST_F(PeerConnectionSimulcastTests, CanCreateTransceiverWithSimulcast) { |
| 226 | auto pc = CreatePeerConnectionWrapper(); |
| 227 | auto layers = CreateLayers({"f", "h", "q"}, true); |
| 228 | auto transceiver = AddTransceiver(pc.get(), layers); |
| 229 | ASSERT_TRUE(transceiver); |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 230 | ValidateTransceiverParameters(transceiver, layers); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 231 | } |
| 232 | |
| 233 | TEST_F(PeerConnectionSimulcastTests, RidsAreAutogeneratedIfNotProvided) { |
| 234 | auto pc = CreatePeerConnectionWrapper(); |
| 235 | auto init = CreateTransceiverInit(CreateLayers({"f", "h", "q"}, true)); |
| 236 | for (RtpEncodingParameters& parameters : init.send_encodings) { |
| 237 | parameters.rid = ""; |
| 238 | } |
| 239 | auto transceiver = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init); |
| 240 | auto parameters = transceiver->sender()->GetParameters(); |
| 241 | ASSERT_EQ(3u, parameters.encodings.size()); |
| 242 | EXPECT_THAT(parameters.encodings, |
Amit Hilbuch | 2297d33 | 2019-02-19 12:49:22 -0800 | [diff] [blame] | 243 | Each(Field("rid", &RtpEncodingParameters::rid, Ne("")))); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 244 | } |
| 245 | |
| 246 | // Validates that an error is returned when there is a mix of supplied and not |
| 247 | // supplied RIDs in a call to AddTransceiver. |
| 248 | TEST_F(PeerConnectionSimulcastTests, MustSupplyAllOrNoRidsInSimulcast) { |
| 249 | auto pc_wrapper = CreatePeerConnectionWrapper(); |
| 250 | auto pc = pc_wrapper->pc(); |
| 251 | // Cannot create a layer with empty RID. Remove the RID after init is created. |
| 252 | auto layers = CreateLayers({"f", "h", "remove"}, true); |
| 253 | auto init = CreateTransceiverInit(layers); |
| 254 | init.send_encodings[2].rid = ""; |
| 255 | auto error = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init); |
| 256 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, error.error().type()); |
| 257 | } |
| 258 | |
Amit Hilbuch | f477040 | 2019-04-08 14:11:57 -0700 | [diff] [blame] | 259 | // Validates that an error is returned when illegal RIDs are supplied. |
| 260 | TEST_F(PeerConnectionSimulcastTests, ChecksForIllegalRidValues) { |
| 261 | auto pc_wrapper = CreatePeerConnectionWrapper(); |
| 262 | auto pc = pc_wrapper->pc(); |
| 263 | auto layers = CreateLayers({"f", "h", "~q"}, true); |
| 264 | auto init = CreateTransceiverInit(layers); |
| 265 | auto error = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init); |
| 266 | EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, error.error().type()); |
| 267 | } |
| 268 | |
Amit Hilbuch | 2297d33 | 2019-02-19 12:49:22 -0800 | [diff] [blame] | 269 | // Validates that a single RID is removed from the encoding layer. |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 270 | TEST_F(PeerConnectionSimulcastTests, SingleRidIsRemovedFromSessionDescription) { |
| 271 | auto pc = CreatePeerConnectionWrapper(); |
| 272 | auto transceiver = AddTransceiver(pc.get(), CreateLayers({"1"}, true)); |
| 273 | auto offer = pc->CreateOfferAndSetAsLocal(); |
| 274 | ASSERT_TRUE(offer); |
| 275 | auto contents = offer->description()->contents(); |
| 276 | ASSERT_EQ(1u, contents.size()); |
| 277 | EXPECT_THAT(contents[0].media_description()->streams(), |
| 278 | ElementsAre(Property(&StreamParams::has_rids, false))); |
| 279 | } |
| 280 | |
| 281 | TEST_F(PeerConnectionSimulcastTests, SimulcastLayersRemovedFromTail) { |
| 282 | static_assert( |
| 283 | kMaxSimulcastStreams < 8, |
| 284 | "Test assumes that the platform does not allow 8 simulcast layers"); |
| 285 | auto pc = CreatePeerConnectionWrapper(); |
| 286 | auto layers = CreateLayers({"1", "2", "3", "4", "5", "6", "7", "8"}, true); |
| 287 | std::vector<SimulcastLayer> expected_layers; |
| 288 | std::copy_n(layers.begin(), kMaxSimulcastStreams, |
| 289 | std::back_inserter(expected_layers)); |
| 290 | auto transceiver = AddTransceiver(pc.get(), layers); |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 291 | ValidateTransceiverParameters(transceiver, expected_layers); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 292 | } |
| 293 | |
| 294 | // Checks that an offfer to send simulcast contains a SimulcastDescription. |
| 295 | TEST_F(PeerConnectionSimulcastTests, SimulcastAppearsInSessionDescription) { |
| 296 | auto pc = CreatePeerConnectionWrapper(); |
| 297 | std::vector<std::string> rids({"f", "h", "q"}); |
| 298 | auto layers = CreateLayers(rids, true); |
| 299 | auto transceiver = AddTransceiver(pc.get(), layers); |
| 300 | auto offer = pc->CreateOffer(); |
| 301 | ASSERT_TRUE(offer); |
| 302 | auto contents = offer->description()->contents(); |
| 303 | ASSERT_EQ(1u, contents.size()); |
| 304 | auto content = contents[0]; |
| 305 | auto mcd = content.media_description(); |
| 306 | ASSERT_TRUE(mcd->HasSimulcast()); |
| 307 | auto simulcast = mcd->simulcast_description(); |
| 308 | EXPECT_THAT(simulcast.receive_layers(), IsEmpty()); |
| 309 | // The size is validated separately because GetAllLayers() flattens the list. |
| 310 | EXPECT_THAT(simulcast.send_layers(), SizeIs(3)); |
| 311 | std::vector<SimulcastLayer> result = simulcast.send_layers().GetAllLayers(); |
| 312 | EXPECT_THAT(result, ElementsAreArray(layers)); |
| 313 | auto streams = mcd->streams(); |
| 314 | ASSERT_EQ(1u, streams.size()); |
| 315 | auto stream = streams[0]; |
| 316 | EXPECT_FALSE(stream.has_ssrcs()); |
| 317 | EXPECT_TRUE(stream.has_rids()); |
| 318 | std::vector<std::string> result_rids; |
| 319 | absl::c_transform(stream.rids(), std::back_inserter(result_rids), |
| 320 | [](const RidDescription& rid) { return rid.rid; }); |
| 321 | EXPECT_THAT(result_rids, ElementsAreArray(rids)); |
| 322 | } |
| 323 | |
| 324 | // Checks that Simulcast layers propagate to the sender parameters. |
| 325 | TEST_F(PeerConnectionSimulcastTests, SimulcastLayersAreSetInSender) { |
| 326 | auto local = CreatePeerConnectionWrapper(); |
| 327 | auto remote = CreatePeerConnectionWrapper(); |
| 328 | auto layers = CreateLayers({"f", "h", "q"}, true); |
| 329 | auto transceiver = AddTransceiver(local.get(), layers); |
| 330 | auto offer = local->CreateOfferAndSetAsLocal(); |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 331 | { |
| 332 | SCOPED_TRACE("after create offer"); |
| 333 | ValidateTransceiverParameters(transceiver, layers); |
| 334 | } |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 335 | // Remove simulcast as the second peer connection won't support it. |
| 336 | auto simulcast = RemoveSimulcast(offer.get()); |
| 337 | std::string error; |
| 338 | EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error; |
| 339 | auto answer = remote->CreateAnswerAndSetAsLocal(); |
| 340 | |
| 341 | // Setup an answer that mimics a server accepting simulcast. |
| 342 | auto mcd_answer = answer->description()->contents()[0].media_description(); |
| 343 | mcd_answer->mutable_streams().clear(); |
| 344 | auto simulcast_layers = simulcast.send_layers().GetAllLayers(); |
| 345 | auto& receive_layers = mcd_answer->simulcast_description().receive_layers(); |
| 346 | for (const auto& layer : simulcast_layers) { |
| 347 | receive_layers.AddLayer(layer); |
| 348 | } |
| 349 | EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error; |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 350 | { |
| 351 | SCOPED_TRACE("after set remote"); |
| 352 | ValidateTransceiverParameters(transceiver, layers); |
| 353 | } |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 354 | } |
| 355 | |
| 356 | // Checks that paused Simulcast layers propagate to the sender parameters. |
| 357 | TEST_F(PeerConnectionSimulcastTests, PausedSimulcastLayersAreDisabledInSender) { |
| 358 | auto local = CreatePeerConnectionWrapper(); |
| 359 | auto remote = CreatePeerConnectionWrapper(); |
| 360 | auto layers = CreateLayers({"f", "h", "q"}, {true, false, true}); |
| 361 | auto server_layers = CreateLayers({"f", "h", "q"}, {true, false, false}); |
| 362 | RTC_DCHECK_EQ(layers.size(), server_layers.size()); |
| 363 | auto transceiver = AddTransceiver(local.get(), layers); |
| 364 | auto offer = local->CreateOfferAndSetAsLocal(); |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 365 | { |
| 366 | SCOPED_TRACE("after create offer"); |
| 367 | ValidateTransceiverParameters(transceiver, layers); |
| 368 | } |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 369 | |
| 370 | // Remove simulcast as the second peer connection won't support it. |
| 371 | RemoveSimulcast(offer.get()); |
| 372 | std::string error; |
| 373 | EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error; |
| 374 | auto answer = remote->CreateAnswerAndSetAsLocal(); |
| 375 | |
| 376 | // Setup an answer that mimics a server accepting simulcast. |
| 377 | auto mcd_answer = answer->description()->contents()[0].media_description(); |
| 378 | mcd_answer->mutable_streams().clear(); |
| 379 | auto& receive_layers = mcd_answer->simulcast_description().receive_layers(); |
| 380 | for (const SimulcastLayer& layer : server_layers) { |
| 381 | receive_layers.AddLayer(layer); |
| 382 | } |
| 383 | EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error; |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 384 | { |
| 385 | SCOPED_TRACE("after set remote"); |
| 386 | ValidateTransceiverParameters(transceiver, server_layers); |
| 387 | } |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 388 | } |
| 389 | |
| 390 | // Checks that when Simulcast is not supported by the remote party, then all |
Amit Hilbuch | 2297d33 | 2019-02-19 12:49:22 -0800 | [diff] [blame] | 391 | // the layers (except the first) are removed. |
| 392 | TEST_F(PeerConnectionSimulcastTests, SimulcastRejectedRemovesExtraLayers) { |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 393 | auto local = CreatePeerConnectionWrapper(); |
| 394 | auto remote = CreatePeerConnectionWrapper(); |
| 395 | auto layers = CreateLayers({"1", "2", "3", "4"}, true); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 396 | auto transceiver = AddTransceiver(local.get(), layers); |
Amit Hilbuch | 619b294 | 2019-02-26 15:55:19 -0800 | [diff] [blame] | 397 | ExchangeOfferAnswer(local.get(), remote.get(), {}); |
Amit Hilbuch | 2297d33 | 2019-02-19 12:49:22 -0800 | [diff] [blame] | 398 | auto parameters = transceiver->sender()->GetParameters(); |
| 399 | // Should only have the first layer. |
| 400 | EXPECT_THAT(parameters.encodings, |
| 401 | ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq("1")))); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 402 | } |
| 403 | |
Amit Hilbuch | 2297d33 | 2019-02-19 12:49:22 -0800 | [diff] [blame] | 404 | // Checks that if Simulcast is supported by remote party, but some layers are |
| 405 | // rejected, then only rejected layers are removed from the sender. |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 406 | TEST_F(PeerConnectionSimulcastTests, RejectedSimulcastLayersAreDeactivated) { |
| 407 | auto local = CreatePeerConnectionWrapper(); |
| 408 | auto remote = CreatePeerConnectionWrapper(); |
Florent Castelli | 3fbf1e2 | 2019-07-04 17:09:05 +0200 | [diff] [blame] | 409 | auto layers = CreateLayers({"1", "2", "3"}, true); |
| 410 | auto expected_layers = CreateLayers({"2", "3"}, true); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 411 | auto transceiver = AddTransceiver(local.get(), layers); |
| 412 | auto offer = local->CreateOfferAndSetAsLocal(); |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 413 | { |
| 414 | SCOPED_TRACE("after create offer"); |
| 415 | ValidateTransceiverParameters(transceiver, layers); |
| 416 | } |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 417 | // Remove simulcast as the second peer connection won't support it. |
| 418 | auto removed_simulcast = RemoveSimulcast(offer.get()); |
| 419 | std::string error; |
| 420 | EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error; |
| 421 | auto answer = remote->CreateAnswerAndSetAsLocal(); |
| 422 | auto mcd_answer = answer->description()->contents()[0].media_description(); |
| 423 | // Setup the answer to look like a server response. |
| 424 | // Remove one of the layers to reject it in the answer. |
| 425 | auto simulcast_layers = removed_simulcast.send_layers().GetAllLayers(); |
| 426 | simulcast_layers.erase(simulcast_layers.begin()); |
| 427 | auto& receive_layers = mcd_answer->simulcast_description().receive_layers(); |
| 428 | for (const auto& layer : simulcast_layers) { |
| 429 | receive_layers.AddLayer(layer); |
| 430 | } |
| 431 | ASSERT_TRUE(mcd_answer->HasSimulcast()); |
| 432 | EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error; |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 433 | { |
| 434 | SCOPED_TRACE("after set remote"); |
| 435 | ValidateTransceiverParameters(transceiver, expected_layers); |
| 436 | } |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 437 | } |
| 438 | |
| 439 | // Checks that simulcast is set up correctly when the server sends an offer |
| 440 | // requesting to receive simulcast. |
| 441 | TEST_F(PeerConnectionSimulcastTests, ServerSendsOfferToReceiveSimulcast) { |
| 442 | auto local = CreatePeerConnectionWrapper(); |
| 443 | auto remote = CreatePeerConnectionWrapper(); |
| 444 | auto layers = CreateLayers({"f", "h", "q"}, true); |
| 445 | AddTransceiver(local.get(), layers); |
| 446 | auto offer = local->CreateOfferAndSetAsLocal(); |
| 447 | // Remove simulcast as a sender and set it up as a receiver. |
| 448 | RemoveSimulcast(offer.get()); |
| 449 | AddRequestToReceiveSimulcast(layers, offer.get()); |
| 450 | std::string error; |
| 451 | EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error; |
| 452 | auto transceiver = remote->pc()->GetTransceivers()[0]; |
| 453 | transceiver->SetDirection(RtpTransceiverDirection::kSendRecv); |
| 454 | EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal()); |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 455 | ValidateTransceiverParameters(transceiver, layers); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 456 | } |
| 457 | |
| 458 | // Checks that SetRemoteDescription doesn't attempt to associate a transceiver |
| 459 | // when simulcast is requested by the server. |
| 460 | TEST_F(PeerConnectionSimulcastTests, TransceiverIsNotRecycledWithSimulcast) { |
| 461 | auto local = CreatePeerConnectionWrapper(); |
| 462 | auto remote = CreatePeerConnectionWrapper(); |
| 463 | auto layers = CreateLayers({"f", "h", "q"}, true); |
| 464 | AddTransceiver(local.get(), layers); |
| 465 | auto offer = local->CreateOfferAndSetAsLocal(); |
| 466 | // Remove simulcast as a sender and set it up as a receiver. |
| 467 | RemoveSimulcast(offer.get()); |
| 468 | AddRequestToReceiveSimulcast(layers, offer.get()); |
| 469 | // Call AddTrack so that a transceiver is created. |
| 470 | remote->AddVideoTrack("fake_track"); |
| 471 | std::string error; |
| 472 | EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error; |
| 473 | auto transceivers = remote->pc()->GetTransceivers(); |
| 474 | ASSERT_EQ(2u, transceivers.size()); |
| 475 | auto transceiver = transceivers[1]; |
| 476 | transceiver->SetDirection(RtpTransceiverDirection::kSendRecv); |
| 477 | EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal()); |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 478 | ValidateTransceiverParameters(transceiver, layers); |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 479 | } |
| 480 | |
Amit Hilbuch | 619b294 | 2019-02-26 15:55:19 -0800 | [diff] [blame] | 481 | // Checks that if the number of layers changes during negotiation, then any |
| 482 | // outstanding get/set parameters transaction is invalidated. |
| 483 | TEST_F(PeerConnectionSimulcastTests, ParametersAreInvalidatedWhenLayersChange) { |
| 484 | auto local = CreatePeerConnectionWrapper(); |
| 485 | auto remote = CreatePeerConnectionWrapper(); |
| 486 | auto layers = CreateLayers({"1", "2", "3"}, true); |
| 487 | auto transceiver = AddTransceiver(local.get(), layers); |
| 488 | auto parameters = transceiver->sender()->GetParameters(); |
| 489 | ASSERT_EQ(3u, parameters.encodings.size()); |
| 490 | // Response will reject simulcast altogether. |
| 491 | ExchangeOfferAnswer(local.get(), remote.get(), {}); |
| 492 | auto result = transceiver->sender()->SetParameters(parameters); |
| 493 | EXPECT_EQ(RTCErrorType::INVALID_STATE, result.type()); |
| 494 | } |
| 495 | |
| 496 | // Checks that even though negotiation modifies the sender's parameters, an |
| 497 | // outstanding get/set parameters transaction is not invalidated. |
| 498 | // This test negotiates twice because initial parameters before negotiation |
| 499 | // is missing critical information and cannot be set on the sender. |
| 500 | TEST_F(PeerConnectionSimulcastTests, |
| 501 | NegotiationDoesNotInvalidateParameterTransactions) { |
| 502 | auto local = CreatePeerConnectionWrapper(); |
| 503 | auto remote = CreatePeerConnectionWrapper(); |
| 504 | auto layers = CreateLayers({"1", "2", "3"}, true); |
| 505 | auto expected_layers = CreateLayers({"1", "2", "3"}, false); |
| 506 | auto transceiver = AddTransceiver(local.get(), layers); |
| 507 | ExchangeOfferAnswer(local.get(), remote.get(), expected_layers); |
| 508 | |
| 509 | // Verify that negotiation does not invalidate the parameters. |
| 510 | auto parameters = transceiver->sender()->GetParameters(); |
| 511 | ExchangeOfferAnswer(local.get(), remote.get(), expected_layers); |
| 512 | |
| 513 | auto result = transceiver->sender()->SetParameters(parameters); |
| 514 | EXPECT_TRUE(result.ok()); |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 515 | ValidateTransceiverParameters(transceiver, expected_layers); |
Amit Hilbuch | 619b294 | 2019-02-26 15:55:19 -0800 | [diff] [blame] | 516 | } |
| 517 | |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 518 | // Tests that simulcast is disabled if the RID extension is not negotiated |
| 519 | // regardless of if the RIDs and simulcast attribute were negotiated properly. |
Amit Hilbuch | aabd036 | 2019-03-01 13:14:46 -0800 | [diff] [blame] | 520 | TEST_F(PeerConnectionSimulcastTests, NegotiationDoesNotHaveRidExtension) { |
| 521 | auto local = CreatePeerConnectionWrapper(); |
| 522 | auto remote = CreatePeerConnectionWrapper(); |
| 523 | auto layers = CreateLayers({"1", "2", "3"}, true); |
| 524 | auto expected_layers = CreateLayers({"1"}, true); |
| 525 | auto transceiver = AddTransceiver(local.get(), layers); |
| 526 | auto offer = local->CreateOfferAndSetAsLocal(); |
| 527 | // Remove simulcast as the second peer connection won't support it. |
| 528 | RemoveSimulcast(offer.get()); |
| 529 | std::string err; |
| 530 | EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &err)) << err; |
| 531 | auto answer = remote->CreateAnswerAndSetAsLocal(); |
| 532 | // Setup the answer to look like a server response. |
| 533 | // Drop the RID header extension. |
| 534 | auto mcd_answer = answer->description()->contents()[0].media_description(); |
| 535 | auto& receive_layers = mcd_answer->simulcast_description().receive_layers(); |
| 536 | for (const SimulcastLayer& layer : layers) { |
| 537 | receive_layers.AddLayer(layer); |
| 538 | } |
| 539 | cricket::RtpHeaderExtensions extensions; |
| 540 | for (auto extension : mcd_answer->rtp_header_extensions()) { |
| 541 | if (extension.uri != RtpExtension::kRidUri) { |
| 542 | extensions.push_back(extension); |
| 543 | } |
| 544 | } |
| 545 | mcd_answer->set_rtp_header_extensions(extensions); |
| 546 | EXPECT_EQ(layers.size(), mcd_answer->simulcast_description() |
| 547 | .receive_layers() |
| 548 | .GetAllLayers() |
| 549 | .size()); |
| 550 | EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &err)) << err; |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 551 | ValidateTransceiverParameters(transceiver, expected_layers); |
Amit Hilbuch | aabd036 | 2019-03-01 13:14:46 -0800 | [diff] [blame] | 552 | } |
Amit Hilbuch | e2a284d | 2019-03-05 12:36:31 -0800 | [diff] [blame] | 553 | // |
| 554 | // Checks the logged metrics when simulcast is not used. |
| 555 | TEST_F(PeerConnectionSimulcastMetricsTests, NoSimulcastUsageIsLogged) { |
| 556 | auto local = CreatePeerConnectionWrapper(); |
| 557 | auto remote = CreatePeerConnectionWrapper(); |
| 558 | auto layers = CreateLayers(0, true); |
| 559 | AddTransceiver(local.get(), layers); |
| 560 | ExchangeOfferAnswer(local.get(), remote.get(), layers); |
| 561 | |
| 562 | EXPECT_THAT(LocalDescriptionSamples(), |
| 563 | ElementsAre(Pair(kSimulcastApiVersionNone, 2))); |
| 564 | EXPECT_THAT(RemoteDescriptionSamples(), |
| 565 | ElementsAre(Pair(kSimulcastApiVersionNone, 2))); |
| 566 | } |
| 567 | |
| 568 | // Checks the logged metrics when spec-compliant simulcast is used. |
| 569 | TEST_F(PeerConnectionSimulcastMetricsTests, SpecComplianceIsLogged) { |
| 570 | auto local = CreatePeerConnectionWrapper(); |
| 571 | auto remote = CreatePeerConnectionWrapper(); |
| 572 | auto layers = CreateLayers(3, true); |
| 573 | AddTransceiver(local.get(), layers); |
| 574 | ExchangeOfferAnswer(local.get(), remote.get(), layers); |
| 575 | |
| 576 | // Expecting 2 invocations of each, because we have 2 peer connections. |
| 577 | // Only the local peer connection will be aware of simulcast. |
| 578 | // The remote peer connection will think that there is no simulcast. |
| 579 | EXPECT_THAT(LocalDescriptionSamples(), |
| 580 | ElementsAre(Pair(kSimulcastApiVersionNone, 1), |
| 581 | Pair(kSimulcastApiVersionSpecCompliant, 1))); |
| 582 | EXPECT_THAT(RemoteDescriptionSamples(), |
| 583 | ElementsAre(Pair(kSimulcastApiVersionNone, 1), |
| 584 | Pair(kSimulcastApiVersionSpecCompliant, 1))); |
| 585 | } |
| 586 | |
| 587 | // Checks the logged metrics when and incoming request to send spec-compliant |
| 588 | // simulcast is received from the remote party. |
| 589 | TEST_F(PeerConnectionSimulcastMetricsTests, IncomingSimulcastIsLogged) { |
| 590 | auto local = CreatePeerConnectionWrapper(); |
| 591 | auto remote = CreatePeerConnectionWrapper(); |
| 592 | auto layers = CreateLayers(3, true); |
| 593 | AddTransceiver(local.get(), layers); |
| 594 | auto offer = local->CreateOfferAndSetAsLocal(); |
| 595 | EXPECT_THAT(LocalDescriptionSamples(), |
| 596 | ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1))); |
| 597 | |
| 598 | // Remove simulcast as a sender and set it up as a receiver. |
| 599 | RemoveSimulcast(offer.get()); |
| 600 | AddRequestToReceiveSimulcast(layers, offer.get()); |
| 601 | std::string error; |
| 602 | EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error; |
| 603 | EXPECT_THAT(RemoteDescriptionSamples(), |
| 604 | ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1))); |
| 605 | |
| 606 | auto transceiver = remote->pc()->GetTransceivers()[0]; |
| 607 | transceiver->SetDirection(RtpTransceiverDirection::kSendRecv); |
| 608 | EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal()); |
| 609 | EXPECT_THAT(LocalDescriptionSamples(), |
| 610 | ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 2))); |
| 611 | } |
| 612 | |
| 613 | // Checks that a spec-compliant simulcast offer that is rejected is logged. |
| 614 | TEST_F(PeerConnectionSimulcastMetricsTests, RejectedSimulcastIsLogged) { |
| 615 | auto local = CreatePeerConnectionWrapper(); |
| 616 | auto remote = CreatePeerConnectionWrapper(); |
| 617 | auto layers = CreateLayers({"1", "2", "3"}, true); |
| 618 | AddTransceiver(local.get(), layers); |
| 619 | auto offer = local->CreateOfferAndSetAsLocal(); |
| 620 | EXPECT_THAT(LocalDescriptionSamples(), |
| 621 | ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1))); |
| 622 | RemoveSimulcast(offer.get()); |
| 623 | std::string error; |
| 624 | EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error; |
| 625 | EXPECT_THAT(RemoteDescriptionSamples(), |
| 626 | ElementsAre(Pair(kSimulcastApiVersionNone, 1))); |
| 627 | |
| 628 | auto answer = remote->CreateAnswerAndSetAsLocal(); |
| 629 | EXPECT_THAT(LocalDescriptionSamples(), |
| 630 | ElementsAre(Pair(kSimulcastApiVersionNone, 1), |
| 631 | Pair(kSimulcastApiVersionSpecCompliant, 1))); |
| 632 | EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error; |
| 633 | EXPECT_THAT(RemoteDescriptionSamples(), |
| 634 | ElementsAre(Pair(kSimulcastApiVersionNone, 2))); |
| 635 | } |
| 636 | |
| 637 | // Checks the logged metrics when legacy munging simulcast technique is used. |
| 638 | TEST_F(PeerConnectionSimulcastMetricsTests, LegacySimulcastIsLogged) { |
| 639 | auto local = CreatePeerConnectionWrapper(); |
| 640 | auto remote = CreatePeerConnectionWrapper(); |
| 641 | auto layers = CreateLayers(0, true); |
| 642 | AddTransceiver(local.get(), layers); |
| 643 | auto offer = local->CreateOffer(); |
| 644 | // Munge the SDP to set up legacy simulcast. |
| 645 | const std::string end_line = "\r\n"; |
| 646 | std::string sdp; |
| 647 | offer->ToString(&sdp); |
| 648 | rtc::StringBuilder builder(sdp); |
| 649 | builder << "a=ssrc:1111 cname:slimshady" << end_line; |
| 650 | builder << "a=ssrc:2222 cname:slimshady" << end_line; |
| 651 | builder << "a=ssrc:3333 cname:slimshady" << end_line; |
| 652 | builder << "a=ssrc-group:SIM 1111 2222 3333" << end_line; |
| 653 | |
| 654 | SdpParseError parse_error; |
| 655 | auto sd = |
| 656 | CreateSessionDescription(SdpType::kOffer, builder.str(), &parse_error); |
| 657 | ASSERT_TRUE(sd) << parse_error.line << parse_error.description; |
| 658 | std::string error; |
| 659 | EXPECT_TRUE(local->SetLocalDescription(std::move(sd), &error)) << error; |
| 660 | EXPECT_THAT(LocalDescriptionSamples(), |
| 661 | ElementsAre(Pair(kSimulcastApiVersionLegacy, 1))); |
| 662 | EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error; |
| 663 | EXPECT_THAT(RemoteDescriptionSamples(), |
| 664 | ElementsAre(Pair(kSimulcastApiVersionNone, 1))); |
| 665 | auto answer = remote->CreateAnswerAndSetAsLocal(); |
| 666 | EXPECT_THAT(LocalDescriptionSamples(), |
| 667 | ElementsAre(Pair(kSimulcastApiVersionNone, 1), |
| 668 | Pair(kSimulcastApiVersionLegacy, 1))); |
| 669 | // Legacy simulcast is not signaled in remote description. |
| 670 | EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error; |
| 671 | EXPECT_THAT(RemoteDescriptionSamples(), |
| 672 | ElementsAre(Pair(kSimulcastApiVersionNone, 2))); |
| 673 | } |
| 674 | |
| 675 | // Checks that disabling simulcast is logged in the metrics. |
| 676 | TEST_F(PeerConnectionSimulcastMetricsTests, SimulcastDisabledIsLogged) { |
| 677 | auto local = CreatePeerConnectionWrapper(); |
| 678 | auto remote = CreatePeerConnectionWrapper(); |
| 679 | auto layers = CreateLayers({"1", "2", "3"}, true); |
| 680 | AddTransceiver(local.get(), layers); |
| 681 | auto offer = local->CreateOfferAndSetAsLocal(); |
| 682 | RemoveSimulcast(offer.get()); |
| 683 | std::string error; |
| 684 | EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error; |
| 685 | auto answer = remote->CreateAnswerAndSetAsLocal(); |
| 686 | EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error; |
| 687 | |
| 688 | EXPECT_EQ(1, metrics::NumSamples("WebRTC.PeerConnection.Simulcast.Disabled")); |
| 689 | EXPECT_EQ(1, |
| 690 | metrics::NumEvents("WebRTC.PeerConnection.Simulcast.Disabled", 1)); |
| 691 | } |
| 692 | |
| 693 | // Checks that the disabled metric is not logged if simulcast is not disabled. |
| 694 | TEST_F(PeerConnectionSimulcastMetricsTests, SimulcastDisabledIsNotLogged) { |
| 695 | auto local = CreatePeerConnectionWrapper(); |
| 696 | auto remote = CreatePeerConnectionWrapper(); |
| 697 | auto layers = CreateLayers({"1", "2", "3"}, true); |
| 698 | AddTransceiver(local.get(), layers); |
| 699 | ExchangeOfferAnswer(local.get(), remote.get(), layers); |
| 700 | |
| 701 | EXPECT_EQ(0, metrics::NumSamples("WebRTC.PeerConnection.Simulcast.Disabled")); |
| 702 | } |
| 703 | |
| 704 | const int kMaxLayersInMetricsTest = 8; |
| 705 | |
| 706 | // Checks that the number of send encodings is logged in a metric. |
| 707 | TEST_P(PeerConnectionSimulcastMetricsTests, NumberOfSendEncodingsIsLogged) { |
| 708 | auto local = CreatePeerConnectionWrapper(); |
| 709 | auto num_layers = GetParam(); |
| 710 | auto layers = CreateLayers(num_layers, true); |
| 711 | AddTransceiver(local.get(), layers); |
| 712 | EXPECT_EQ(1, metrics::NumSamples( |
| 713 | "WebRTC.PeerConnection.Simulcast.NumberOfSendEncodings")); |
| 714 | EXPECT_EQ(1, metrics::NumEvents( |
| 715 | "WebRTC.PeerConnection.Simulcast.NumberOfSendEncodings", |
| 716 | num_layers)); |
| 717 | } |
| 718 | |
| 719 | INSTANTIATE_TEST_SUITE_P(NumberOfSendEncodings, |
| 720 | PeerConnectionSimulcastMetricsTests, |
| 721 | ::testing::Range(0, kMaxLayersInMetricsTest)); |
Amit Hilbuch | aabd036 | 2019-03-01 13:14:46 -0800 | [diff] [blame] | 722 | |
Amit Hilbuch | aa58415 | 2019-02-06 17:09:52 -0800 | [diff] [blame] | 723 | } // namespace webrtc |