blob: 5b5f6e71c1d656818e684c5a624beb7a90d3c67e [file] [log] [blame]
Erik Språngd05edec2019-08-14 10:43:47 +02001/*
2 * Copyright (c) 2019 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11#include "modules/pacing/pacing_controller.h"
12
13#include <algorithm>
14#include <list>
15#include <memory>
16#include <string>
17#include <utility>
18#include <vector>
19
Erik Språngd05edec2019-08-14 10:43:47 +020020#include "api/units/data_rate.h"
21#include "modules/pacing/packet_router.h"
22#include "system_wrappers/include/clock.h"
23#include "test/field_trial.h"
24#include "test/gmock.h"
25#include "test/gtest.h"
26
27using ::testing::_;
28using ::testing::Field;
29using ::testing::Pointee;
30using ::testing::Property;
31using ::testing::Return;
32
33namespace webrtc {
34namespace test {
35namespace {
36constexpr DataRate kFirstClusterRate = DataRate::KilobitsPerSec<900>();
37constexpr DataRate kSecondClusterRate = DataRate::KilobitsPerSec<1800>();
38
39// The error stems from truncating the time interval of probe packets to integer
40// values. This results in probing slightly higher than the target bitrate.
41// For 1.8 Mbps, this comes to be about 120 kbps with 1200 probe packets.
42constexpr DataRate kProbingErrorMargin = DataRate::KilobitsPerSec<150>();
43
44const float kPaceMultiplier = 2.5f;
45
46constexpr uint32_t kAudioSsrc = 12345;
47constexpr uint32_t kVideoSsrc = 234565;
48constexpr uint32_t kVideoRtxSsrc = 34567;
49constexpr uint32_t kFlexFecSsrc = 45678;
50
51constexpr DataRate kTargetRate = DataRate::KilobitsPerSec<800>();
52
Erik Språngd05edec2019-08-14 10:43:47 +020053std::unique_ptr<RtpPacketToSend> BuildPacket(RtpPacketToSend::Type type,
54 uint32_t ssrc,
55 uint16_t sequence_number,
56 int64_t capture_time_ms,
57 size_t size) {
Mirko Bonadei317a1f02019-09-17 17:06:18 +020058 auto packet = std::make_unique<RtpPacketToSend>(nullptr);
Erik Språngd05edec2019-08-14 10:43:47 +020059 packet->set_packet_type(type);
60 packet->SetSsrc(ssrc);
61 packet->SetSequenceNumber(sequence_number);
62 packet->set_capture_time_ms(capture_time_ms);
63 packet->SetPayloadSize(size);
64 return packet;
65}
66} // namespace
67
68// Mock callback proxy, where both new and old api redirects to common mock
69// methods that focus on core aspects.
70class MockPacingControllerCallback : public PacingController::PacketSender {
71 public:
Erik Språngd05edec2019-08-14 10:43:47 +020072 void SendRtpPacket(std::unique_ptr<RtpPacketToSend> packet,
73 const PacedPacketInfo& cluster_info) override {
74 SendPacket(packet->Ssrc(), packet->SequenceNumber(),
75 packet->capture_time_ms(),
76 packet->packet_type() == RtpPacketToSend::Type::kRetransmission,
77 packet->packet_type() == RtpPacketToSend::Type::kPadding);
78 }
79
Erik Språngd05edec2019-08-14 10:43:47 +020080 std::vector<std::unique_ptr<RtpPacketToSend>> GeneratePadding(
81 DataSize target_size) override {
82 std::vector<std::unique_ptr<RtpPacketToSend>> ret;
83 size_t padding_size = SendPadding(target_size.bytes());
84 if (padding_size > 0) {
Mirko Bonadei317a1f02019-09-17 17:06:18 +020085 auto packet = std::make_unique<RtpPacketToSend>(nullptr);
Erik Språngd05edec2019-08-14 10:43:47 +020086 packet->SetPayloadSize(padding_size);
87 packet->set_packet_type(RtpPacketToSend::Type::kPadding);
88 ret.emplace_back(std::move(packet));
89 }
90 return ret;
91 }
92
93 MOCK_METHOD5(SendPacket,
94 void(uint32_t ssrc,
95 uint16_t sequence_number,
96 int64_t capture_timestamp,
97 bool retransmission,
98 bool padding));
99 MOCK_METHOD1(SendPadding, size_t(size_t target_size));
100};
101
102// Mock callback implementing the raw api.
103class MockPacketSender : public PacingController::PacketSender {
104 public:
Erik Språngd05edec2019-08-14 10:43:47 +0200105 MOCK_METHOD2(SendRtpPacket,
106 void(std::unique_ptr<RtpPacketToSend> packet,
107 const PacedPacketInfo& cluster_info));
108 MOCK_METHOD1(
109 GeneratePadding,
110 std::vector<std::unique_ptr<RtpPacketToSend>>(DataSize target_size));
111};
112
113class PacingControllerPadding : public PacingController::PacketSender {
114 public:
115 static const size_t kPaddingPacketSize = 224;
116
Erik Språngeb487992019-11-14 14:15:15 +0100117 PacingControllerPadding() : padding_sent_(0), total_bytes_sent_(0) {}
Erik Språngd05edec2019-08-14 10:43:47 +0200118
Erik Språngd05edec2019-08-14 10:43:47 +0200119 void SendRtpPacket(std::unique_ptr<RtpPacketToSend> packet,
Erik Språngeb487992019-11-14 14:15:15 +0100120 const PacedPacketInfo& pacing_info) override {
121 total_bytes_sent_ += packet->payload_size();
122 }
Erik Språngd05edec2019-08-14 10:43:47 +0200123
Erik Språngd05edec2019-08-14 10:43:47 +0200124 std::vector<std::unique_ptr<RtpPacketToSend>> GeneratePadding(
125 DataSize target_size) override {
126 size_t num_packets =
127 (target_size.bytes() + kPaddingPacketSize - 1) / kPaddingPacketSize;
128 std::vector<std::unique_ptr<RtpPacketToSend>> packets;
129 for (size_t i = 0; i < num_packets; ++i) {
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200130 packets.emplace_back(std::make_unique<RtpPacketToSend>(nullptr));
Erik Språngd05edec2019-08-14 10:43:47 +0200131 packets.back()->SetPadding(kPaddingPacketSize);
132 packets.back()->set_packet_type(RtpPacketToSend::Type::kPadding);
133 padding_sent_ += kPaddingPacketSize;
134 }
135 return packets;
136 }
137
138 size_t padding_sent() { return padding_sent_; }
Erik Språngeb487992019-11-14 14:15:15 +0100139 size_t total_bytes_sent() { return total_bytes_sent_; }
Erik Språngd05edec2019-08-14 10:43:47 +0200140
141 private:
142 size_t padding_sent_;
Erik Språngeb487992019-11-14 14:15:15 +0100143 size_t total_bytes_sent_;
Erik Språngd05edec2019-08-14 10:43:47 +0200144};
145
146class PacingControllerProbing : public PacingController::PacketSender {
147 public:
148 PacingControllerProbing() : packets_sent_(0), padding_sent_(0) {}
149
Erik Språngd05edec2019-08-14 10:43:47 +0200150 void SendRtpPacket(std::unique_ptr<RtpPacketToSend> packet,
151 const PacedPacketInfo& pacing_info) override {
152 if (packet->packet_type() != RtpPacketToSend::Type::kPadding) {
153 ++packets_sent_;
154 }
155 }
156
Erik Språngd05edec2019-08-14 10:43:47 +0200157 std::vector<std::unique_ptr<RtpPacketToSend>> GeneratePadding(
158 DataSize target_size) override {
Erik Språngb210eeb2019-11-05 11:21:48 +0100159 // From RTPSender:
160 // Max in the RFC 3550 is 255 bytes, we limit it to be modulus 32 for SRTP.
161 const DataSize kMaxPadding = DataSize::bytes(224);
162
Erik Språngd05edec2019-08-14 10:43:47 +0200163 std::vector<std::unique_ptr<RtpPacketToSend>> packets;
Erik Språngb210eeb2019-11-05 11:21:48 +0100164 while (target_size > DataSize::Zero()) {
165 DataSize padding_size = std::min(kMaxPadding, target_size);
166 packets.emplace_back(std::make_unique<RtpPacketToSend>(nullptr));
167 packets.back()->SetPadding(padding_size.bytes());
168 packets.back()->set_packet_type(RtpPacketToSend::Type::kPadding);
169 padding_sent_ += padding_size.bytes();
170 target_size -= padding_size;
171 }
Erik Språngd05edec2019-08-14 10:43:47 +0200172 return packets;
173 }
174
175 int packets_sent() const { return packets_sent_; }
176
177 int padding_sent() const { return padding_sent_; }
178
179 private:
180 int packets_sent_;
181 int padding_sent_;
182};
183
Erik Språngeb487992019-11-14 14:15:15 +0100184class PacingControllerTest
185 : public ::testing::TestWithParam<PacingController::ProcessMode> {
Erik Språngd05edec2019-08-14 10:43:47 +0200186 protected:
Erik Språngf5815fa2019-08-21 14:27:31 +0200187 PacingControllerTest() : clock_(123456) {
Erik Språngd05edec2019-08-14 10:43:47 +0200188 srand(0);
189 // Need to initialize PacingController after we initialize clock.
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200190 pacer_ = std::make_unique<PacingController>(&clock_, &callback_, nullptr,
Erik Språngeb487992019-11-14 14:15:15 +0100191 nullptr, GetParam());
Erik Språngd05edec2019-08-14 10:43:47 +0200192 Init();
193 }
194
Erik Språngeb487992019-11-14 14:15:15 +0100195 bool PeriodicProcess() const {
196 return GetParam() == PacingController::ProcessMode::kPeriodic;
197 }
198
Erik Språngd05edec2019-08-14 10:43:47 +0200199 void Init() {
200 pacer_->CreateProbeCluster(kFirstClusterRate, /*cluster_id=*/0);
201 pacer_->CreateProbeCluster(kSecondClusterRate, /*cluster_id=*/1);
202 // Default to bitrate probing disabled for testing purposes. Probing tests
203 // have to enable probing, either by creating a new PacingController
204 // instance or by calling SetProbingEnabled(true).
205 pacer_->SetProbingEnabled(false);
206 pacer_->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero());
207
208 clock_.AdvanceTime(TimeUntilNextProcess());
209 }
210
211 void Send(RtpPacketToSend::Type type,
212 uint32_t ssrc,
213 uint16_t sequence_number,
214 int64_t capture_time_ms,
215 size_t size) {
Erik Språngf5815fa2019-08-21 14:27:31 +0200216 pacer_->EnqueuePacket(
217 BuildPacket(type, ssrc, sequence_number, capture_time_ms, size));
Erik Språngd05edec2019-08-14 10:43:47 +0200218 }
219
220 void SendAndExpectPacket(RtpPacketToSend::Type type,
221 uint32_t ssrc,
222 uint16_t sequence_number,
223 int64_t capture_time_ms,
224 size_t size) {
225 Send(type, ssrc, sequence_number, capture_time_ms, size);
226 EXPECT_CALL(
227 callback_,
228 SendPacket(ssrc, sequence_number, capture_time_ms,
229 type == RtpPacketToSend::Type::kRetransmission, false))
230 .Times(1);
231 }
232
Erik Språngd05edec2019-08-14 10:43:47 +0200233 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(RtpPacketToSend::Type type) {
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200234 auto packet = std::make_unique<RtpPacketToSend>(nullptr);
Erik Språngd05edec2019-08-14 10:43:47 +0200235 packet->set_packet_type(type);
236 switch (type) {
237 case RtpPacketToSend::Type::kAudio:
238 packet->SetSsrc(kAudioSsrc);
239 break;
240 case RtpPacketToSend::Type::kVideo:
241 packet->SetSsrc(kVideoSsrc);
242 break;
243 case RtpPacketToSend::Type::kRetransmission:
244 case RtpPacketToSend::Type::kPadding:
245 packet->SetSsrc(kVideoRtxSsrc);
246 break;
247 case RtpPacketToSend::Type::kForwardErrorCorrection:
248 packet->SetSsrc(kFlexFecSsrc);
249 break;
250 }
251
252 packet->SetPayloadSize(234);
253 return packet;
254 }
255
256 TimeDelta TimeUntilNextProcess() {
Erik Språngeb487992019-11-14 14:15:15 +0100257 Timestamp now = clock_.CurrentTime();
258 return std::max(pacer_->NextSendTime() - now, TimeDelta::Zero());
259 }
Erik Språngd05edec2019-08-14 10:43:47 +0200260
Erik Språngeb487992019-11-14 14:15:15 +0100261 void AdvanceTimeAndProcess() {
262 Timestamp now = clock_.CurrentTime();
263 Timestamp next_send_time = pacer_->NextSendTime();
264 clock_.AdvanceTime(std::max(TimeDelta::Zero(), next_send_time - now));
265 pacer_->ProcessPackets();
266 }
267
268 void ConsumeInitialBudget() {
269 const uint32_t kSsrc = 54321;
270 uint16_t sequence_number = 1234;
271 int64_t capture_time_ms = clock_.TimeInMilliseconds();
272 const size_t kPacketSize = 250;
273
274 EXPECT_EQ(TimeDelta::Zero(), pacer_->OldestPacketWaitTime());
275
276 // Due to the multiplicative factor we can send 5 packets during a send
277 // interval. (network capacity * multiplier / (8 bits per byte *
278 // (packet size * #send intervals per second)
279 const size_t packets_to_send_per_interval =
280 kTargetRate.bps() * kPaceMultiplier / (8 * kPacketSize * 200);
281 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
282 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, kSsrc,
283 sequence_number++, capture_time_ms, kPacketSize);
Erik Språngd05edec2019-08-14 10:43:47 +0200284 }
285
Erik Språngeb487992019-11-14 14:15:15 +0100286 while (pacer_->QueueSizePackets() > 0) {
287 if (PeriodicProcess()) {
288 clock_.AdvanceTime(TimeUntilNextProcess());
289 pacer_->ProcessPackets();
290 } else {
291 AdvanceTimeAndProcess();
292 }
Erik Språngd05edec2019-08-14 10:43:47 +0200293 }
Erik Språngd05edec2019-08-14 10:43:47 +0200294 }
295
296 SimulatedClock clock_;
Erik Språngd05edec2019-08-14 10:43:47 +0200297 MockPacingControllerCallback callback_;
298 std::unique_ptr<PacingController> pacer_;
299};
300
Erik Språngeb487992019-11-14 14:15:15 +0100301class PacingControllerFieldTrialTest
302 : public ::testing::TestWithParam<PacingController::ProcessMode> {
Erik Språngd05edec2019-08-14 10:43:47 +0200303 protected:
304 struct MediaStream {
305 const RtpPacketToSend::Type type;
306 const uint32_t ssrc;
307 const size_t packet_size;
308 uint16_t seq_num;
309 };
310
311 const int kProcessIntervalsPerSecond = 1000 / 5;
312
313 PacingControllerFieldTrialTest() : clock_(123456) {}
314 void InsertPacket(PacingController* pacer, MediaStream* stream) {
Erik Språngf5815fa2019-08-21 14:27:31 +0200315 pacer->EnqueuePacket(
316 BuildPacket(stream->type, stream->ssrc, stream->seq_num++,
317 clock_.TimeInMilliseconds(), stream->packet_size));
Erik Språngd05edec2019-08-14 10:43:47 +0200318 }
319 void ProcessNext(PacingController* pacer) {
Erik Språngeb487992019-11-14 14:15:15 +0100320 if (GetParam() == PacingController::ProcessMode::kPeriodic) {
321 TimeDelta process_interval = TimeDelta::ms(5);
322 clock_.AdvanceTime(process_interval);
323 pacer->ProcessPackets();
324 return;
325 }
326
327 Timestamp now = clock_.CurrentTime();
328 Timestamp next_send_time = pacer->NextSendTime();
329 TimeDelta wait_time = std::max(TimeDelta::Zero(), next_send_time - now);
330 clock_.AdvanceTime(wait_time);
Erik Språngd05edec2019-08-14 10:43:47 +0200331 pacer->ProcessPackets();
332 }
333 MediaStream audio{/*type*/ RtpPacketToSend::Type::kAudio,
334 /*ssrc*/ 3333, /*packet_size*/ 100, /*seq_num*/ 1000};
335 MediaStream video{/*type*/ RtpPacketToSend::Type::kVideo,
336 /*ssrc*/ 4444, /*packet_size*/ 1000, /*seq_num*/ 1000};
337 SimulatedClock clock_;
338 MockPacingControllerCallback callback_;
339};
340
Erik Språngeb487992019-11-14 14:15:15 +0100341TEST_P(PacingControllerFieldTrialTest, DefaultNoPaddingInSilence) {
342 PacingController pacer(&clock_, &callback_, nullptr, nullptr, GetParam());
Erik Språngd05edec2019-08-14 10:43:47 +0200343 pacer.SetPacingRates(kTargetRate, DataRate::Zero());
344 // Video packet to reset last send time and provide padding data.
345 InsertPacket(&pacer, &video);
346 EXPECT_CALL(callback_, SendPacket).Times(1);
347 clock_.AdvanceTimeMilliseconds(5);
348 pacer.ProcessPackets();
349 EXPECT_CALL(callback_, SendPadding).Times(0);
350 // Waiting 500 ms should not trigger sending of padding.
351 clock_.AdvanceTimeMilliseconds(500);
352 pacer.ProcessPackets();
353}
354
Erik Språngeb487992019-11-14 14:15:15 +0100355TEST_P(PacingControllerFieldTrialTest, PaddingInSilenceWithTrial) {
Erik Språngf5815fa2019-08-21 14:27:31 +0200356 ScopedFieldTrials trial("WebRTC-Pacer-PadInSilence/Enabled/");
Erik Språngeb487992019-11-14 14:15:15 +0100357 PacingController pacer(&clock_, &callback_, nullptr, nullptr, GetParam());
Erik Språngd05edec2019-08-14 10:43:47 +0200358 pacer.SetPacingRates(kTargetRate, DataRate::Zero());
359 // Video packet to reset last send time and provide padding data.
360 InsertPacket(&pacer, &video);
Erik Språngf5815fa2019-08-21 14:27:31 +0200361 EXPECT_CALL(callback_, SendPacket).Times(2);
Erik Språngd05edec2019-08-14 10:43:47 +0200362 clock_.AdvanceTimeMilliseconds(5);
363 pacer.ProcessPackets();
364 EXPECT_CALL(callback_, SendPadding).WillOnce(Return(1000));
365 // Waiting 500 ms should trigger sending of padding.
366 clock_.AdvanceTimeMilliseconds(500);
367 pacer.ProcessPackets();
368}
369
Erik Språngeb487992019-11-14 14:15:15 +0100370TEST_P(PacingControllerFieldTrialTest, DefaultCongestionWindowAffectsAudio) {
Erik Språngd05edec2019-08-14 10:43:47 +0200371 EXPECT_CALL(callback_, SendPadding).Times(0);
Erik Språngeb487992019-11-14 14:15:15 +0100372 PacingController pacer(&clock_, &callback_, nullptr, nullptr, GetParam());
373 pacer.SetPacingRates(DataRate::kbps(10000), DataRate::Zero());
374 pacer.SetCongestionWindow(DataSize::bytes(video.packet_size - 100));
Erik Språngd05edec2019-08-14 10:43:47 +0200375 pacer.UpdateOutstandingData(DataSize::Zero());
376 // Video packet fills congestion window.
377 InsertPacket(&pacer, &video);
378 EXPECT_CALL(callback_, SendPacket).Times(1);
379 ProcessNext(&pacer);
380 // Audio packet blocked due to congestion.
381 InsertPacket(&pacer, &audio);
382 EXPECT_CALL(callback_, SendPacket).Times(0);
Erik Språngeb487992019-11-14 14:15:15 +0100383 if (GetParam() == PacingController::ProcessMode::kDynamic) {
384 // Without interval budget we'll forward time to where we send keep-alive.
385 EXPECT_CALL(callback_, SendPadding(1)).Times(2);
386 }
Erik Språngd05edec2019-08-14 10:43:47 +0200387 ProcessNext(&pacer);
388 ProcessNext(&pacer);
389 // Audio packet unblocked when congestion window clear.
390 ::testing::Mock::VerifyAndClearExpectations(&callback_);
391 pacer.UpdateOutstandingData(DataSize::Zero());
392 EXPECT_CALL(callback_, SendPacket).Times(1);
393 ProcessNext(&pacer);
394}
395
Erik Språngeb487992019-11-14 14:15:15 +0100396TEST_P(PacingControllerFieldTrialTest,
Erik Språngd05edec2019-08-14 10:43:47 +0200397 CongestionWindowDoesNotAffectAudioInTrial) {
Erik Språngf5815fa2019-08-21 14:27:31 +0200398 ScopedFieldTrials trial("WebRTC-Pacer-BlockAudio/Disabled/");
Erik Språngd05edec2019-08-14 10:43:47 +0200399 EXPECT_CALL(callback_, SendPadding).Times(0);
Erik Språngeb487992019-11-14 14:15:15 +0100400 PacingController pacer(&clock_, &callback_, nullptr, nullptr, GetParam());
Erik Språngd05edec2019-08-14 10:43:47 +0200401 pacer.SetPacingRates(DataRate::bps(10000000), DataRate::Zero());
402 pacer.SetCongestionWindow(DataSize::bytes(800));
403 pacer.UpdateOutstandingData(DataSize::Zero());
404 // Video packet fills congestion window.
405 InsertPacket(&pacer, &video);
406 EXPECT_CALL(callback_, SendPacket).Times(1);
407 ProcessNext(&pacer);
408 // Audio not blocked due to congestion.
409 InsertPacket(&pacer, &audio);
410 EXPECT_CALL(callback_, SendPacket).Times(1);
411 ProcessNext(&pacer);
412}
413
Erik Språngeb487992019-11-14 14:15:15 +0100414TEST_P(PacingControllerFieldTrialTest, DefaultBudgetAffectsAudio) {
415 PacingController pacer(&clock_, &callback_, nullptr, nullptr, GetParam());
416 DataRate pacing_rate =
417 DataRate::bps(video.packet_size / 3 * 8 * kProcessIntervalsPerSecond);
418 pacer.SetPacingRates(pacing_rate, DataRate::Zero());
Erik Språngd05edec2019-08-14 10:43:47 +0200419 // Video fills budget for following process periods.
420 InsertPacket(&pacer, &video);
421 EXPECT_CALL(callback_, SendPacket).Times(1);
422 ProcessNext(&pacer);
423 // Audio packet blocked due to budget limit.
Erik Språngd05edec2019-08-14 10:43:47 +0200424 InsertPacket(&pacer, &audio);
Erik Språngeb487992019-11-14 14:15:15 +0100425 Timestamp wait_start_time = clock_.CurrentTime();
426 Timestamp wait_end_time = Timestamp::MinusInfinity();
427 EXPECT_CALL(callback_, SendPacket)
428 .WillOnce([&](uint32_t ssrc, uint16_t sequence_number,
429 int64_t capture_timestamp, bool retransmission,
430 bool padding) { wait_end_time = clock_.CurrentTime(); });
431 while (!wait_end_time.IsFinite()) {
432 ProcessNext(&pacer);
433 }
434 const TimeDelta expected_wait_time =
435 DataSize::bytes(video.packet_size) / pacing_rate;
436 // Verify delay is near expectation, within timing margin.
437 EXPECT_LT(((wait_end_time - wait_start_time) - expected_wait_time).Abs(),
438 GetParam() == PacingController::ProcessMode::kPeriodic
439 ? TimeDelta::ms(5)
440 : PacingController::kMinSleepTime);
Erik Språngd05edec2019-08-14 10:43:47 +0200441}
442
Erik Språngeb487992019-11-14 14:15:15 +0100443TEST_P(PacingControllerFieldTrialTest, BudgetDoesNotAffectAudioInTrial) {
Erik Språngf5815fa2019-08-21 14:27:31 +0200444 ScopedFieldTrials trial("WebRTC-Pacer-BlockAudio/Disabled/");
Erik Språngd05edec2019-08-14 10:43:47 +0200445 EXPECT_CALL(callback_, SendPadding).Times(0);
Erik Språngeb487992019-11-14 14:15:15 +0100446 PacingController pacer(&clock_, &callback_, nullptr, nullptr, GetParam());
Erik Språngd05edec2019-08-14 10:43:47 +0200447 pacer.SetPacingRates(
448 DataRate::bps(video.packet_size / 3 * 8 * kProcessIntervalsPerSecond),
449 DataRate::Zero());
450 // Video fills budget for following process periods.
451 InsertPacket(&pacer, &video);
452 EXPECT_CALL(callback_, SendPacket).Times(1);
453 ProcessNext(&pacer);
454 // Audio packet not blocked due to budget limit.
455 EXPECT_CALL(callback_, SendPacket).Times(1);
456 InsertPacket(&pacer, &audio);
457 ProcessNext(&pacer);
458}
459
Erik Språngeb487992019-11-14 14:15:15 +0100460INSTANTIATE_TEST_SUITE_P(WithAndWithoutIntervalBudget,
461 PacingControllerFieldTrialTest,
462 ::testing::Values(false, true));
463
464TEST_P(PacingControllerTest, FirstSentPacketTimeIsSet) {
Erik Språngd05edec2019-08-14 10:43:47 +0200465 uint16_t sequence_number = 1234;
466 const uint32_t kSsrc = 12345;
467 const size_t kSizeBytes = 250;
468 const size_t kPacketToSend = 3;
469 const Timestamp kStartTime = clock_.CurrentTime();
470
471 // No packet sent.
472 EXPECT_FALSE(pacer_->FirstSentPacketTime().has_value());
473
474 for (size_t i = 0; i < kPacketToSend; ++i) {
475 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, kSsrc, sequence_number++,
476 clock_.TimeInMilliseconds(), kSizeBytes);
Erik Språngd05edec2019-08-14 10:43:47 +0200477 clock_.AdvanceTime(TimeUntilNextProcess());
Erik Språngeb487992019-11-14 14:15:15 +0100478 pacer_->ProcessPackets();
Erik Språngd05edec2019-08-14 10:43:47 +0200479 }
480 EXPECT_EQ(kStartTime, pacer_->FirstSentPacketTime());
481}
482
Erik Språngeb487992019-11-14 14:15:15 +0100483TEST_P(PacingControllerTest, QueuePacket) {
484 if (!PeriodicProcess()) {
485 // This test checks behavior applicable only when using interval budget.
486 return;
487 }
488
Erik Språngd05edec2019-08-14 10:43:47 +0200489 uint32_t ssrc = 12345;
490 uint16_t sequence_number = 1234;
Erik Språngeb487992019-11-14 14:15:15 +0100491 // Due to the multiplicative factor we can send 5 packets during a 5ms send
Erik Språngd05edec2019-08-14 10:43:47 +0200492 // interval. (network capacity * multiplier / (8 bits per byte *
493 // (packet size * #send intervals per second)
Erik Språngeb487992019-11-14 14:15:15 +0100494 const size_t kPacketsToSend =
Erik Språngd05edec2019-08-14 10:43:47 +0200495 kTargetRate.bps() * kPaceMultiplier / (8 * 250 * 200);
Erik Språngeb487992019-11-14 14:15:15 +0100496 for (size_t i = 0; i < kPacketsToSend; ++i) {
Erik Språngd05edec2019-08-14 10:43:47 +0200497 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
498 clock_.TimeInMilliseconds(), 250);
499 }
Erik Språngeb487992019-11-14 14:15:15 +0100500 EXPECT_CALL(callback_, SendPadding).Times(0);
Erik Språngd05edec2019-08-14 10:43:47 +0200501
Erik Språngeb487992019-11-14 14:15:15 +0100502 // Enqueue one extra packet.
Erik Språngd05edec2019-08-14 10:43:47 +0200503 int64_t queued_packet_timestamp = clock_.TimeInMilliseconds();
504 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number,
505 queued_packet_timestamp, 250);
Erik Språngeb487992019-11-14 14:15:15 +0100506 EXPECT_EQ(kPacketsToSend + 1, pacer_->QueueSizePackets());
507
508 // The first kPacketsToSend packets will be sent with budget from the
509 // initial 5ms interval.
Erik Språngd05edec2019-08-14 10:43:47 +0200510 pacer_->ProcessPackets();
Erik Språngd05edec2019-08-14 10:43:47 +0200511 EXPECT_EQ(1u, pacer_->QueueSizePackets());
Erik Språngeb487992019-11-14 14:15:15 +0100512
513 // Advance time to next interval, make sure the last packet is sent.
514 clock_.AdvanceTimeMilliseconds(5);
Erik Språngd05edec2019-08-14 10:43:47 +0200515 EXPECT_CALL(callback_, SendPacket(ssrc, sequence_number++,
516 queued_packet_timestamp, false, false))
517 .Times(1);
518 pacer_->ProcessPackets();
519 sequence_number++;
520 EXPECT_EQ(0u, pacer_->QueueSizePackets());
521
522 // We can send packets_to_send -1 packets of size 250 during the current
523 // interval since one packet has already been sent.
Erik Språngeb487992019-11-14 14:15:15 +0100524 for (size_t i = 0; i < kPacketsToSend - 1; ++i) {
Erik Språngd05edec2019-08-14 10:43:47 +0200525 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
526 clock_.TimeInMilliseconds(), 250);
527 }
528 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
529 clock_.TimeInMilliseconds(), 250);
Erik Språngeb487992019-11-14 14:15:15 +0100530 EXPECT_EQ(kPacketsToSend, pacer_->QueueSizePackets());
Erik Språngd05edec2019-08-14 10:43:47 +0200531 pacer_->ProcessPackets();
532 EXPECT_EQ(1u, pacer_->QueueSizePackets());
533}
534
Erik Språngeb487992019-11-14 14:15:15 +0100535TEST_P(PacingControllerTest, QueueAndPacePackets) {
536 if (PeriodicProcess()) {
537 // This test checks behavior when not using interval budget.
538 return;
539 }
540
541 const uint32_t kSsrc = 12345;
542 uint16_t sequence_number = 1234;
543 const DataSize kPackeSize = DataSize::bytes(250);
544 const TimeDelta kSendInterval = TimeDelta::ms(5);
545
546 // Due to the multiplicative factor we can send 5 packets during a 5ms send
547 // interval. (send interval * network capacity * multiplier / packet size)
548 const size_t kPacketsToSend = (kSendInterval * kTargetRate).bytes() *
549 kPaceMultiplier / kPackeSize.bytes();
550
551 for (size_t i = 0; i < kPacketsToSend; ++i) {
552 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, kSsrc, sequence_number++,
553 clock_.TimeInMilliseconds(), kPackeSize.bytes());
554 }
555 EXPECT_CALL(callback_, SendPadding).Times(0);
556
557 // Enqueue one extra packet.
558 int64_t queued_packet_timestamp = clock_.TimeInMilliseconds();
559 Send(RtpPacketToSend::Type::kVideo, kSsrc, sequence_number,
560 queued_packet_timestamp, kPackeSize.bytes());
561 EXPECT_EQ(kPacketsToSend + 1, pacer_->QueueSizePackets());
562
563 // Send packets until the initial kPacketsToSend packets are done.
564 Timestamp start_time = clock_.CurrentTime();
565 while (pacer_->QueueSizePackets() > 1) {
566 AdvanceTimeAndProcess();
567 }
568 EXPECT_LT(clock_.CurrentTime() - start_time, kSendInterval);
569
570 // Proceed till last packet can be sent.
571 EXPECT_CALL(callback_, SendPacket(kSsrc, sequence_number,
572 queued_packet_timestamp, false, false))
573 .Times(1);
574 AdvanceTimeAndProcess();
575 EXPECT_GE(clock_.CurrentTime() - start_time, kSendInterval);
576 EXPECT_EQ(pacer_->QueueSizePackets(), 0u);
577}
578
579TEST_P(PacingControllerTest, PaceQueuedPackets) {
Erik Språngd05edec2019-08-14 10:43:47 +0200580 uint32_t ssrc = 12345;
581 uint16_t sequence_number = 1234;
Erik Språngeb487992019-11-14 14:15:15 +0100582 const size_t kPacketSize = 250;
Erik Språngd05edec2019-08-14 10:43:47 +0200583
584 // Due to the multiplicative factor we can send 5 packets during a send
585 // interval. (network capacity * multiplier / (8 bits per byte *
586 // (packet size * #send intervals per second)
587 const size_t packets_to_send_per_interval =
Erik Språngeb487992019-11-14 14:15:15 +0100588 kTargetRate.bps() * kPaceMultiplier / (8 * kPacketSize * 200);
Erik Språngd05edec2019-08-14 10:43:47 +0200589 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
590 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
Erik Språngeb487992019-11-14 14:15:15 +0100591 clock_.TimeInMilliseconds(), kPacketSize);
Erik Språngd05edec2019-08-14 10:43:47 +0200592 }
593
594 for (size_t j = 0; j < packets_to_send_per_interval * 10; ++j) {
595 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
Erik Språngeb487992019-11-14 14:15:15 +0100596 clock_.TimeInMilliseconds(), kPacketSize);
Erik Språngd05edec2019-08-14 10:43:47 +0200597 }
598 EXPECT_EQ(packets_to_send_per_interval + packets_to_send_per_interval * 10,
599 pacer_->QueueSizePackets());
Erik Språngeb487992019-11-14 14:15:15 +0100600 if (PeriodicProcess()) {
Erik Språngd05edec2019-08-14 10:43:47 +0200601 pacer_->ProcessPackets();
Erik Språngeb487992019-11-14 14:15:15 +0100602 } else {
603 while (pacer_->QueueSizePackets() > packets_to_send_per_interval * 10) {
604 AdvanceTimeAndProcess();
605 }
Erik Språngd05edec2019-08-14 10:43:47 +0200606 }
Erik Språngeb487992019-11-14 14:15:15 +0100607 EXPECT_EQ(pacer_->QueueSizePackets(), packets_to_send_per_interval * 10);
608 EXPECT_CALL(callback_, SendPadding).Times(0);
609
610 EXPECT_CALL(callback_, SendPacket(ssrc, _, _, false, false))
611 .Times(pacer_->QueueSizePackets());
612 const TimeDelta expected_pace_time =
613 DataSize::bytes(pacer_->QueueSizePackets() * kPacketSize) /
614 (kPaceMultiplier * kTargetRate);
615 Timestamp start_time = clock_.CurrentTime();
616 while (pacer_->QueueSizePackets() > 0) {
617 if (PeriodicProcess()) {
618 clock_.AdvanceTime(TimeUntilNextProcess());
619 pacer_->ProcessPackets();
620 } else {
621 AdvanceTimeAndProcess();
622 }
623 }
624 const TimeDelta actual_pace_time = clock_.CurrentTime() - start_time;
625 EXPECT_LT(
626 (actual_pace_time - expected_pace_time).Abs(),
627 PeriodicProcess() ? TimeDelta::ms(5) : PacingController::kMinSleepTime);
628
Erik Språngd05edec2019-08-14 10:43:47 +0200629 EXPECT_EQ(0u, pacer_->QueueSizePackets());
630 clock_.AdvanceTime(TimeUntilNextProcess());
631 EXPECT_EQ(0u, pacer_->QueueSizePackets());
632 pacer_->ProcessPackets();
633
Erik Språngeb487992019-11-14 14:15:15 +0100634 // Send some more packet, just show that we can..?
Erik Språngd05edec2019-08-14 10:43:47 +0200635 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
636 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
637 clock_.TimeInMilliseconds(), 250);
638 }
Erik Språngeb487992019-11-14 14:15:15 +0100639 EXPECT_EQ(packets_to_send_per_interval, pacer_->QueueSizePackets());
640 if (PeriodicProcess()) {
641 pacer_->ProcessPackets();
642 } else {
643 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
644 AdvanceTimeAndProcess();
645 }
646 }
647 EXPECT_EQ(0u, pacer_->QueueSizePackets());
Erik Språngd05edec2019-08-14 10:43:47 +0200648}
649
Erik Språngeb487992019-11-14 14:15:15 +0100650TEST_P(PacingControllerTest, RepeatedRetransmissionsAllowed) {
Erik Språngd05edec2019-08-14 10:43:47 +0200651 // Send one packet, then two retransmissions of that packet.
652 for (size_t i = 0; i < 3; i++) {
653 constexpr uint32_t ssrc = 333;
654 constexpr uint16_t sequence_number = 444;
655 constexpr size_t bytes = 250;
656 bool is_retransmission = (i != 0); // Original followed by retransmissions.
657 SendAndExpectPacket(
658 is_retransmission ? RtpPacketToSend::Type::kRetransmission
659 : RtpPacketToSend::Type::kVideo,
660 ssrc, sequence_number, clock_.TimeInMilliseconds(), bytes);
661 clock_.AdvanceTimeMilliseconds(5);
662 }
Erik Språngeb487992019-11-14 14:15:15 +0100663 if (PeriodicProcess()) {
664 pacer_->ProcessPackets();
665 } else {
666 while (pacer_->QueueSizePackets() > 0) {
667 AdvanceTimeAndProcess();
668 }
669 }
Erik Språngd05edec2019-08-14 10:43:47 +0200670}
671
Erik Språngeb487992019-11-14 14:15:15 +0100672TEST_P(PacingControllerTest,
Erik Språngd05edec2019-08-14 10:43:47 +0200673 CanQueuePacketsWithSameSequenceNumberOnDifferentSsrcs) {
674 uint32_t ssrc = 12345;
675 uint16_t sequence_number = 1234;
676
677 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number,
678 clock_.TimeInMilliseconds(), 250);
679
680 // Expect packet on second ssrc to be queued and sent as well.
681 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc + 1, sequence_number,
682 clock_.TimeInMilliseconds(), 250);
683
684 clock_.AdvanceTimeMilliseconds(1000);
Erik Språngeb487992019-11-14 14:15:15 +0100685 if (PeriodicProcess()) {
686 pacer_->ProcessPackets();
687 } else {
688 while (pacer_->QueueSizePackets() > 0) {
689 AdvanceTimeAndProcess();
690 }
691 }
Erik Språngd05edec2019-08-14 10:43:47 +0200692}
693
Erik Språngeb487992019-11-14 14:15:15 +0100694TEST_P(PacingControllerTest, Padding) {
Erik Språngd05edec2019-08-14 10:43:47 +0200695 uint32_t ssrc = 12345;
696 uint16_t sequence_number = 1234;
Erik Språngeb487992019-11-14 14:15:15 +0100697 const size_t kPacketSize = 250;
Erik Språngd05edec2019-08-14 10:43:47 +0200698
699 pacer_->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate);
700
Erik Språngeb487992019-11-14 14:15:15 +0100701 if (PeriodicProcess()) {
702 ConsumeInitialBudget();
703
704 // 5 milliseconds later should not send padding since we filled the buffers
705 // initially.
706 EXPECT_CALL(callback_, SendPadding(kPacketSize)).Times(0);
707 clock_.AdvanceTime(TimeUntilNextProcess());
708 pacer_->ProcessPackets();
709
710 // 5 milliseconds later we have enough budget to send some padding.
711 EXPECT_CALL(callback_, SendPadding(250)).WillOnce(Return(kPacketSize));
712 EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1);
713 clock_.AdvanceTime(TimeUntilNextProcess());
714 pacer_->ProcessPackets();
715 } else {
716 const size_t kPacketsToSend = 20;
717 for (size_t i = 0; i < kPacketsToSend; ++i) {
718 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc,
719 sequence_number++, clock_.TimeInMilliseconds(),
720 kPacketSize);
721 }
722 const TimeDelta expected_pace_time =
723 DataSize::bytes(pacer_->QueueSizePackets() * kPacketSize) /
724 (kPaceMultiplier * kTargetRate);
725 EXPECT_CALL(callback_, SendPadding).Times(0);
726 // Only the media packets should be sent.
727 Timestamp start_time = clock_.CurrentTime();
728 while (pacer_->QueueSizePackets() > 0) {
729 AdvanceTimeAndProcess();
730 }
731 const TimeDelta actual_pace_time = clock_.CurrentTime() - start_time;
732 EXPECT_LE((actual_pace_time - expected_pace_time).Abs(),
733 PacingController::kMinSleepTime);
734
735 // Pacing media happens 2.5x factor, but padding was configured with 1.0x
736 // factor. We have to wait until the padding debt is gone before we start
737 // sending padding.
738 const TimeDelta time_to_padding_debt_free =
739 (expected_pace_time * kPaceMultiplier) - actual_pace_time;
740 TimeDelta time_to_next = pacer_->NextSendTime() - clock_.CurrentTime();
741 EXPECT_EQ(time_to_next, time_to_padding_debt_free);
742 clock_.AdvanceTime(time_to_next);
743
744 // Send 10 padding packets.
745 const size_t kPaddingPacketsToSend = 10;
746 DataSize padding_sent = DataSize::Zero();
747 EXPECT_CALL(callback_, SendPadding)
748 .Times(kPaddingPacketsToSend)
749 .WillRepeatedly([&](size_t target_size) {
750 padding_sent += DataSize::bytes(target_size);
751 return target_size;
752 });
753 EXPECT_CALL(callback_, SendPacket(_, _, _, false, true))
754 .Times(kPaddingPacketsToSend);
755 const Timestamp padding_start_time = clock_.CurrentTime();
756 for (size_t i = 0; i < kPaddingPacketsToSend; ++i) {
757 AdvanceTimeAndProcess();
758 }
759
760 // Verify rate of sent padding.
761 TimeDelta padding_duration = pacer_->NextSendTime() - padding_start_time;
762 DataRate padding_rate = padding_sent / padding_duration;
763 EXPECT_EQ(padding_rate, kTargetRate);
Erik Språngd05edec2019-08-14 10:43:47 +0200764 }
Erik Språngd05edec2019-08-14 10:43:47 +0200765}
766
Erik Språngeb487992019-11-14 14:15:15 +0100767TEST_P(PacingControllerTest, NoPaddingBeforeNormalPacket) {
Erik Språngd05edec2019-08-14 10:43:47 +0200768 pacer_->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate);
769
770 EXPECT_CALL(callback_, SendPadding).Times(0);
Erik Språngeb487992019-11-14 14:15:15 +0100771
Erik Språngd05edec2019-08-14 10:43:47 +0200772 pacer_->ProcessPackets();
773 clock_.AdvanceTime(TimeUntilNextProcess());
774
775 pacer_->ProcessPackets();
776 clock_.AdvanceTime(TimeUntilNextProcess());
777
778 uint32_t ssrc = 12345;
779 uint16_t sequence_number = 1234;
780 int64_t capture_time_ms = 56789;
781
782 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
783 capture_time_ms, 250);
Erik Språngeb487992019-11-14 14:15:15 +0100784 EXPECT_CALL(callback_, SendPadding).WillOnce([](size_t padding) {
785 return padding;
786 });
Erik Språngf5815fa2019-08-21 14:27:31 +0200787 EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1);
Erik Språngeb487992019-11-14 14:15:15 +0100788 if (PeriodicProcess()) {
789 pacer_->ProcessPackets();
790 } else {
791 AdvanceTimeAndProcess(); // Media.
792 AdvanceTimeAndProcess(); // Padding.
793 }
Erik Språngd05edec2019-08-14 10:43:47 +0200794}
795
Erik Språngeb487992019-11-14 14:15:15 +0100796TEST_P(PacingControllerTest, VerifyPaddingUpToBitrate) {
797 if (!PeriodicProcess()) {
798 // Already tested in PacingControllerTest.Padding.
799 return;
800 }
801
Erik Språngd05edec2019-08-14 10:43:47 +0200802 uint32_t ssrc = 12345;
803 uint16_t sequence_number = 1234;
804 int64_t capture_time_ms = 56789;
805 const int kTimeStep = 5;
806 const int64_t kBitrateWindow = 100;
807 pacer_->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate);
808
809 int64_t start_time = clock_.TimeInMilliseconds();
810 while (clock_.TimeInMilliseconds() - start_time < kBitrateWindow) {
811 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
812 capture_time_ms, 250);
813 EXPECT_CALL(callback_, SendPadding(250)).WillOnce(Return(250));
Erik Språngf5815fa2019-08-21 14:27:31 +0200814 EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1);
Erik Språngd05edec2019-08-14 10:43:47 +0200815 pacer_->ProcessPackets();
816 clock_.AdvanceTimeMilliseconds(kTimeStep);
817 }
818}
819
Erik Språngeb487992019-11-14 14:15:15 +0100820TEST_P(PacingControllerTest, VerifyAverageBitrateVaryingMediaPayload) {
Erik Språngd05edec2019-08-14 10:43:47 +0200821 uint32_t ssrc = 12345;
822 uint16_t sequence_number = 1234;
823 int64_t capture_time_ms = 56789;
824 const int kTimeStep = 5;
Erik Språngeb487992019-11-14 14:15:15 +0100825 const TimeDelta kAveragingWindowLength = TimeDelta::seconds(10);
Erik Språngd05edec2019-08-14 10:43:47 +0200826 PacingControllerPadding callback;
Erik Språngeb487992019-11-14 14:15:15 +0100827 pacer_ = std::make_unique<PacingController>(&clock_, &callback, nullptr,
828 nullptr, GetParam());
Erik Språngd05edec2019-08-14 10:43:47 +0200829 pacer_->SetProbingEnabled(false);
830 pacer_->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate);
831
Erik Språngeb487992019-11-14 14:15:15 +0100832 Timestamp start_time = clock_.CurrentTime();
Erik Språngd05edec2019-08-14 10:43:47 +0200833 size_t media_bytes = 0;
Erik Språngeb487992019-11-14 14:15:15 +0100834 while (clock_.CurrentTime() - start_time < kAveragingWindowLength) {
835 // Maybe add some new media packets corresponding to expected send rate.
Erik Språngd05edec2019-08-14 10:43:47 +0200836 int rand_value = rand(); // NOLINT (rand_r instead of rand)
Erik Språngeb487992019-11-14 14:15:15 +0100837 while (
838 media_bytes <
839 (kTargetRate * (clock_.CurrentTime() - start_time)).bytes<size_t>()) {
840 size_t media_payload = rand_value % 400 + 800; // [400, 1200] bytes.
841 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
842 capture_time_ms, media_payload);
843 media_bytes += media_payload;
844 }
845
846 if (PeriodicProcess()) {
847 clock_.AdvanceTimeMilliseconds(kTimeStep);
848 pacer_->ProcessPackets();
849 } else {
850 AdvanceTimeAndProcess();
851 }
Erik Språngd05edec2019-08-14 10:43:47 +0200852 }
Erik Språngeb487992019-11-14 14:15:15 +0100853
854 EXPECT_NEAR(
855 kTargetRate.bps(),
856 (DataSize::bytes(callback.total_bytes_sent()) / kAveragingWindowLength)
857 .bps(),
858 (kTargetRate * 0.01 /* 1% error marging */).bps());
Erik Språngd05edec2019-08-14 10:43:47 +0200859}
860
Erik Språngeb487992019-11-14 14:15:15 +0100861TEST_P(PacingControllerTest, Priority) {
Erik Språngd05edec2019-08-14 10:43:47 +0200862 uint32_t ssrc_low_priority = 12345;
863 uint32_t ssrc = 12346;
864 uint16_t sequence_number = 1234;
865 int64_t capture_time_ms = 56789;
866 int64_t capture_time_ms_low_priority = 1234567;
867
Erik Språngeb487992019-11-14 14:15:15 +0100868 ConsumeInitialBudget();
Erik Språngd05edec2019-08-14 10:43:47 +0200869
870 // Expect normal and low priority to be queued and high to pass through.
871 Send(RtpPacketToSend::Type::kVideo, ssrc_low_priority, sequence_number++,
872 capture_time_ms_low_priority, 250);
873
Erik Språngeb487992019-11-14 14:15:15 +0100874 const size_t packets_to_send_per_interval =
875 kTargetRate.bps() * kPaceMultiplier / (8 * 250 * 200);
Erik Språngd05edec2019-08-14 10:43:47 +0200876 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
877 Send(RtpPacketToSend::Type::kRetransmission, ssrc, sequence_number++,
878 capture_time_ms, 250);
879 }
880 Send(RtpPacketToSend::Type::kAudio, ssrc, sequence_number++, capture_time_ms,
881 250);
882
883 // Expect all high and normal priority to be sent out first.
884 EXPECT_CALL(callback_, SendPadding).Times(0);
885 EXPECT_CALL(callback_, SendPacket(ssrc, _, capture_time_ms, _, _))
886 .Times(packets_to_send_per_interval + 1);
887
Erik Språngeb487992019-11-14 14:15:15 +0100888 if (PeriodicProcess()) {
889 clock_.AdvanceTime(TimeUntilNextProcess());
890 pacer_->ProcessPackets();
891 } else {
892 while (pacer_->QueueSizePackets() > 1) {
893 AdvanceTimeAndProcess();
894 }
895 }
896
Erik Språngd05edec2019-08-14 10:43:47 +0200897 EXPECT_EQ(1u, pacer_->QueueSizePackets());
898
899 EXPECT_CALL(callback_, SendPacket(ssrc_low_priority, _,
900 capture_time_ms_low_priority, _, _))
901 .Times(1);
Erik Språngeb487992019-11-14 14:15:15 +0100902 if (PeriodicProcess()) {
903 clock_.AdvanceTime(TimeUntilNextProcess());
904 pacer_->ProcessPackets();
905 } else {
906 AdvanceTimeAndProcess();
907 }
Erik Språngd05edec2019-08-14 10:43:47 +0200908}
909
Erik Språngeb487992019-11-14 14:15:15 +0100910TEST_P(PacingControllerTest, RetransmissionPriority) {
Erik Språngd05edec2019-08-14 10:43:47 +0200911 uint32_t ssrc = 12345;
912 uint16_t sequence_number = 1234;
913 int64_t capture_time_ms = 45678;
914 int64_t capture_time_ms_retransmission = 56789;
915
916 // Due to the multiplicative factor we can send 5 packets during a send
917 // interval. (network capacity * multiplier / (8 bits per byte *
918 // (packet size * #send intervals per second)
919 const size_t packets_to_send_per_interval =
920 kTargetRate.bps() * kPaceMultiplier / (8 * 250 * 200);
921 pacer_->ProcessPackets();
922 EXPECT_EQ(0u, pacer_->QueueSizePackets());
923
924 // Alternate retransmissions and normal packets.
925 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
926 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
927 capture_time_ms, 250);
928 Send(RtpPacketToSend::Type::kRetransmission, ssrc, sequence_number++,
929 capture_time_ms_retransmission, 250);
930 }
931 EXPECT_EQ(2 * packets_to_send_per_interval, pacer_->QueueSizePackets());
932
933 // Expect all retransmissions to be sent out first despite having a later
934 // capture time.
935 EXPECT_CALL(callback_, SendPadding).Times(0);
936 EXPECT_CALL(callback_, SendPacket(_, _, _, false, _)).Times(0);
937 EXPECT_CALL(callback_,
938 SendPacket(ssrc, _, capture_time_ms_retransmission, true, _))
939 .Times(packets_to_send_per_interval);
940
Erik Språngeb487992019-11-14 14:15:15 +0100941 if (PeriodicProcess()) {
942 clock_.AdvanceTime(TimeUntilNextProcess());
943 pacer_->ProcessPackets();
944 } else {
945 while (pacer_->QueueSizePackets() > packets_to_send_per_interval) {
946 AdvanceTimeAndProcess();
947 }
948 }
Erik Språngd05edec2019-08-14 10:43:47 +0200949 EXPECT_EQ(packets_to_send_per_interval, pacer_->QueueSizePackets());
950
951 // Expect the remaining (non-retransmission) packets to be sent.
952 EXPECT_CALL(callback_, SendPadding).Times(0);
953 EXPECT_CALL(callback_, SendPacket(_, _, _, true, _)).Times(0);
954 EXPECT_CALL(callback_, SendPacket(ssrc, _, capture_time_ms, false, _))
955 .Times(packets_to_send_per_interval);
956
Erik Språngeb487992019-11-14 14:15:15 +0100957 if (PeriodicProcess()) {
958 clock_.AdvanceTime(TimeUntilNextProcess());
959 pacer_->ProcessPackets();
960 } else {
961 while (pacer_->QueueSizePackets() > 0) {
962 AdvanceTimeAndProcess();
963 }
964 }
Erik Språngd05edec2019-08-14 10:43:47 +0200965
966 EXPECT_EQ(0u, pacer_->QueueSizePackets());
967}
968
Erik Språngeb487992019-11-14 14:15:15 +0100969TEST_P(PacingControllerTest, HighPrioDoesntAffectBudget) {
970 const size_t kPacketSize = 250;
Erik Språngd05edec2019-08-14 10:43:47 +0200971 uint32_t ssrc = 12346;
972 uint16_t sequence_number = 1234;
973 int64_t capture_time_ms = 56789;
974
975 // As high prio packets doesn't affect the budget, we should be able to send
976 // a high number of them at once.
Erik Språngeb487992019-11-14 14:15:15 +0100977 const size_t kNumAudioPackets = 25;
978 for (size_t i = 0; i < kNumAudioPackets; ++i) {
Erik Språngd05edec2019-08-14 10:43:47 +0200979 SendAndExpectPacket(RtpPacketToSend::Type::kAudio, ssrc, sequence_number++,
Erik Språngeb487992019-11-14 14:15:15 +0100980 capture_time_ms, kPacketSize);
Erik Språngd05edec2019-08-14 10:43:47 +0200981 }
982 pacer_->ProcessPackets();
983 // Low prio packets does affect the budget.
984 // Due to the multiplicative factor we can send 5 packets during a send
985 // interval. (network capacity * multiplier / (8 bits per byte *
986 // (packet size * #send intervals per second)
Erik Språngeb487992019-11-14 14:15:15 +0100987 const size_t kPacketsToSendPerInterval =
988 kTargetRate.bps() * kPaceMultiplier / (8 * kPacketSize * 200);
989 for (size_t i = 0; i < kPacketsToSendPerInterval; ++i) {
Erik Språngd05edec2019-08-14 10:43:47 +0200990 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
Erik Språngeb487992019-11-14 14:15:15 +0100991 clock_.TimeInMilliseconds(), kPacketSize);
Erik Språngd05edec2019-08-14 10:43:47 +0200992 }
Erik Språngeb487992019-11-14 14:15:15 +0100993
994 // Send all packets and measure pace time.
995 Timestamp start_time = clock_.CurrentTime();
996 while (pacer_->QueueSizePackets() > 0) {
997 if (PeriodicProcess()) {
998 clock_.AdvanceTime(TimeUntilNextProcess());
999 pacer_->ProcessPackets();
1000 } else {
1001 AdvanceTimeAndProcess();
1002 }
1003 }
1004
1005 // Measure pacing time. Expect only low-prio packets to affect this.
1006 TimeDelta pacing_time = clock_.CurrentTime() - start_time;
1007 TimeDelta expected_pacing_time =
1008 DataSize::bytes(kPacketsToSendPerInterval * kPacketSize) /
1009 (kTargetRate * kPaceMultiplier);
1010 EXPECT_NEAR(pacing_time.us<double>(), expected_pacing_time.us<double>(),
1011 PeriodicProcess() ? 5000.0
1012 : PacingController::kMinSleepTime.us<double>());
Erik Språngd05edec2019-08-14 10:43:47 +02001013}
1014
Erik Språngeb487992019-11-14 14:15:15 +01001015TEST_P(PacingControllerTest, SendsOnlyPaddingWhenCongested) {
Erik Språngd05edec2019-08-14 10:43:47 +02001016 uint32_t ssrc = 202020;
1017 uint16_t sequence_number = 1000;
1018 int kPacketSize = 250;
1019 int kCongestionWindow = kPacketSize * 10;
1020
1021 pacer_->UpdateOutstandingData(DataSize::Zero());
1022 pacer_->SetCongestionWindow(DataSize::bytes(kCongestionWindow));
1023 int sent_data = 0;
1024 while (sent_data < kCongestionWindow) {
1025 sent_data += kPacketSize;
1026 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1027 clock_.TimeInMilliseconds(), kPacketSize);
Erik Språngeb487992019-11-14 14:15:15 +01001028 AdvanceTimeAndProcess();
Erik Språngd05edec2019-08-14 10:43:47 +02001029 }
1030 ::testing::Mock::VerifyAndClearExpectations(&callback_);
1031 EXPECT_CALL(callback_, SendPacket).Times(0);
1032 EXPECT_CALL(callback_, SendPadding).Times(0);
1033
1034 size_t blocked_packets = 0;
1035 int64_t expected_time_until_padding = 500;
1036 while (expected_time_until_padding > 5) {
1037 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1038 clock_.TimeInMilliseconds(), kPacketSize);
1039 blocked_packets++;
1040 clock_.AdvanceTimeMilliseconds(5);
1041 pacer_->ProcessPackets();
1042 expected_time_until_padding -= 5;
1043 }
1044 ::testing::Mock::VerifyAndClearExpectations(&callback_);
1045 EXPECT_CALL(callback_, SendPadding(1)).WillOnce(Return(1));
Erik Språngf5815fa2019-08-21 14:27:31 +02001046 EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1);
Erik Språngd05edec2019-08-14 10:43:47 +02001047 clock_.AdvanceTimeMilliseconds(5);
1048 pacer_->ProcessPackets();
1049 EXPECT_EQ(blocked_packets, pacer_->QueueSizePackets());
1050}
1051
Erik Språngeb487992019-11-14 14:15:15 +01001052TEST_P(PacingControllerTest, DoesNotAllowOveruseAfterCongestion) {
Erik Språngd05edec2019-08-14 10:43:47 +02001053 uint32_t ssrc = 202020;
1054 uint16_t seq_num = 1000;
1055 int size = 1000;
1056 auto now_ms = [this] { return clock_.TimeInMilliseconds(); };
1057 EXPECT_CALL(callback_, SendPadding).Times(0);
1058 // The pacing rate is low enough that the budget should not allow two packets
1059 // to be sent in a row.
1060 pacer_->SetPacingRates(DataRate::bps(400 * 8 * 1000 / 5), DataRate::Zero());
1061 // The congestion window is small enough to only let one packet through.
1062 pacer_->SetCongestionWindow(DataSize::bytes(800));
1063 pacer_->UpdateOutstandingData(DataSize::Zero());
1064 // Not yet budget limited or congested, packet is sent.
1065 Send(RtpPacketToSend::Type::kVideo, ssrc, seq_num++, now_ms(), size);
1066 EXPECT_CALL(callback_, SendPacket).Times(1);
1067 clock_.AdvanceTimeMilliseconds(5);
1068 pacer_->ProcessPackets();
1069 // Packet blocked due to congestion.
1070 Send(RtpPacketToSend::Type::kVideo, ssrc, seq_num++, now_ms(), size);
1071 EXPECT_CALL(callback_, SendPacket).Times(0);
1072 clock_.AdvanceTimeMilliseconds(5);
1073 pacer_->ProcessPackets();
1074 // Packet blocked due to congestion.
1075 Send(RtpPacketToSend::Type::kVideo, ssrc, seq_num++, now_ms(), size);
1076 EXPECT_CALL(callback_, SendPacket).Times(0);
1077 clock_.AdvanceTimeMilliseconds(5);
1078 pacer_->ProcessPackets();
Erik Språngd05edec2019-08-14 10:43:47 +02001079 // Congestion removed and budget has recovered, packet is sent.
1080 Send(RtpPacketToSend::Type::kVideo, ssrc, seq_num++, now_ms(), size);
1081 EXPECT_CALL(callback_, SendPacket).Times(1);
1082 clock_.AdvanceTimeMilliseconds(5);
Erik Språngd05edec2019-08-14 10:43:47 +02001083 pacer_->UpdateOutstandingData(DataSize::Zero());
Erik Språngeb487992019-11-14 14:15:15 +01001084 pacer_->ProcessPackets();
Erik Språngd05edec2019-08-14 10:43:47 +02001085 // Should be blocked due to budget limitation as congestion has be removed.
1086 Send(RtpPacketToSend::Type::kVideo, ssrc, seq_num++, now_ms(), size);
1087 EXPECT_CALL(callback_, SendPacket).Times(0);
1088 clock_.AdvanceTimeMilliseconds(5);
1089 pacer_->ProcessPackets();
1090}
1091
Erik Språngeb487992019-11-14 14:15:15 +01001092TEST_P(PacingControllerTest, ResumesSendingWhenCongestionEnds) {
Erik Språngd05edec2019-08-14 10:43:47 +02001093 uint32_t ssrc = 202020;
1094 uint16_t sequence_number = 1000;
1095 int64_t kPacketSize = 250;
1096 int64_t kCongestionCount = 10;
1097 int64_t kCongestionWindow = kPacketSize * kCongestionCount;
1098 int64_t kCongestionTimeMs = 1000;
1099
1100 pacer_->UpdateOutstandingData(DataSize::Zero());
1101 pacer_->SetCongestionWindow(DataSize::bytes(kCongestionWindow));
1102 int sent_data = 0;
1103 while (sent_data < kCongestionWindow) {
1104 sent_data += kPacketSize;
1105 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1106 clock_.TimeInMilliseconds(), kPacketSize);
1107 clock_.AdvanceTimeMilliseconds(5);
1108 pacer_->ProcessPackets();
1109 }
1110 ::testing::Mock::VerifyAndClearExpectations(&callback_);
1111 EXPECT_CALL(callback_, SendPacket).Times(0);
1112 int unacked_packets = 0;
1113 for (int duration = 0; duration < kCongestionTimeMs; duration += 5) {
1114 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1115 clock_.TimeInMilliseconds(), kPacketSize);
1116 unacked_packets++;
1117 clock_.AdvanceTimeMilliseconds(5);
1118 pacer_->ProcessPackets();
1119 }
1120 ::testing::Mock::VerifyAndClearExpectations(&callback_);
1121
1122 // First mark half of the congested packets as cleared and make sure that just
1123 // as many are sent
1124 int ack_count = kCongestionCount / 2;
1125 EXPECT_CALL(callback_, SendPacket(ssrc, _, _, false, _)).Times(ack_count);
1126 pacer_->UpdateOutstandingData(
1127 DataSize::bytes(kCongestionWindow - kPacketSize * ack_count));
1128
1129 for (int duration = 0; duration < kCongestionTimeMs; duration += 5) {
1130 clock_.AdvanceTimeMilliseconds(5);
1131 pacer_->ProcessPackets();
1132 }
1133 unacked_packets -= ack_count;
1134 ::testing::Mock::VerifyAndClearExpectations(&callback_);
1135
1136 // Second make sure all packets are sent if sent packets are continuously
1137 // marked as acked.
1138 EXPECT_CALL(callback_, SendPacket(ssrc, _, _, false, _))
1139 .Times(unacked_packets);
1140 for (int duration = 0; duration < kCongestionTimeMs; duration += 5) {
1141 pacer_->UpdateOutstandingData(DataSize::Zero());
1142 clock_.AdvanceTimeMilliseconds(5);
1143 pacer_->ProcessPackets();
1144 }
1145}
1146
Erik Språngeb487992019-11-14 14:15:15 +01001147TEST_P(PacingControllerTest, Pause) {
Erik Språngd05edec2019-08-14 10:43:47 +02001148 uint32_t ssrc_low_priority = 12345;
1149 uint32_t ssrc = 12346;
1150 uint32_t ssrc_high_priority = 12347;
1151 uint16_t sequence_number = 1234;
Erik Språngd05edec2019-08-14 10:43:47 +02001152
1153 EXPECT_EQ(TimeDelta::Zero(), pacer_->OldestPacketWaitTime());
1154
Erik Språngeb487992019-11-14 14:15:15 +01001155 ConsumeInitialBudget();
Erik Språngd05edec2019-08-14 10:43:47 +02001156
1157 pacer_->Pause();
1158
Erik Språngeb487992019-11-14 14:15:15 +01001159 int64_t capture_time_ms = clock_.TimeInMilliseconds();
1160 const size_t packets_to_send_per_interval =
1161 kTargetRate.bps() * kPaceMultiplier / (8 * 250 * 200);
Erik Språngd05edec2019-08-14 10:43:47 +02001162 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
1163 Send(RtpPacketToSend::Type::kVideo, ssrc_low_priority, sequence_number++,
1164 capture_time_ms, 250);
1165 Send(RtpPacketToSend::Type::kRetransmission, ssrc, sequence_number++,
1166 capture_time_ms, 250);
1167 Send(RtpPacketToSend::Type::kAudio, ssrc_high_priority, sequence_number++,
1168 capture_time_ms, 250);
1169 }
1170 clock_.AdvanceTimeMilliseconds(10000);
1171 int64_t second_capture_time_ms = clock_.TimeInMilliseconds();
1172 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
1173 Send(RtpPacketToSend::Type::kVideo, ssrc_low_priority, sequence_number++,
1174 second_capture_time_ms, 250);
1175 Send(RtpPacketToSend::Type::kRetransmission, ssrc, sequence_number++,
1176 second_capture_time_ms, 250);
1177 Send(RtpPacketToSend::Type::kAudio, ssrc_high_priority, sequence_number++,
1178 second_capture_time_ms, 250);
1179 }
1180
1181 // Expect everything to be queued.
1182 EXPECT_EQ(TimeDelta::ms(second_capture_time_ms - capture_time_ms),
1183 pacer_->OldestPacketWaitTime());
1184
Erik Språngeb487992019-11-14 14:15:15 +01001185 // Process triggers keep-alive packet.
1186 EXPECT_CALL(callback_, SendPadding).WillOnce([](size_t padding) {
1187 return padding;
1188 });
Erik Språngf5815fa2019-08-21 14:27:31 +02001189 EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1);
Erik Språngd05edec2019-08-14 10:43:47 +02001190 pacer_->ProcessPackets();
1191
Erik Språngeb487992019-11-14 14:15:15 +01001192 // Verify no packets sent for the rest of the paused process interval.
1193 const TimeDelta kProcessInterval = TimeDelta::ms(5);
1194 TimeDelta expected_time_until_send = PacingController::kPausedProcessInterval;
Erik Språngd05edec2019-08-14 10:43:47 +02001195 EXPECT_CALL(callback_, SendPadding).Times(0);
Erik Språngeb487992019-11-14 14:15:15 +01001196 while (expected_time_until_send >= kProcessInterval) {
Erik Språngd05edec2019-08-14 10:43:47 +02001197 pacer_->ProcessPackets();
Erik Språngeb487992019-11-14 14:15:15 +01001198 clock_.AdvanceTime(kProcessInterval);
1199 expected_time_until_send -= kProcessInterval;
Erik Språngd05edec2019-08-14 10:43:47 +02001200 }
1201
Erik Språngeb487992019-11-14 14:15:15 +01001202 // New keep-alive packet.
Erik Språngd05edec2019-08-14 10:43:47 +02001203 ::testing::Mock::VerifyAndClearExpectations(&callback_);
Erik Språngeb487992019-11-14 14:15:15 +01001204 EXPECT_CALL(callback_, SendPadding).WillOnce([](size_t padding) {
1205 return padding;
1206 });
Erik Språngf5815fa2019-08-21 14:27:31 +02001207 EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1);
Erik Språngeb487992019-11-14 14:15:15 +01001208 clock_.AdvanceTime(kProcessInterval);
Erik Språngd05edec2019-08-14 10:43:47 +02001209 pacer_->ProcessPackets();
1210 ::testing::Mock::VerifyAndClearExpectations(&callback_);
1211
1212 // Expect high prio packets to come out first followed by normal
1213 // prio packets and low prio packets (all in capture order).
1214 {
1215 ::testing::InSequence sequence;
1216 EXPECT_CALL(callback_,
1217 SendPacket(ssrc_high_priority, _, capture_time_ms, _, _))
1218 .Times(packets_to_send_per_interval);
1219 EXPECT_CALL(callback_,
1220 SendPacket(ssrc_high_priority, _, second_capture_time_ms, _, _))
1221 .Times(packets_to_send_per_interval);
1222
1223 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
1224 EXPECT_CALL(callback_, SendPacket(ssrc, _, capture_time_ms, _, _))
1225 .Times(1);
1226 }
1227 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
1228 EXPECT_CALL(callback_, SendPacket(ssrc, _, second_capture_time_ms, _, _))
1229 .Times(1);
1230 }
1231 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
1232 EXPECT_CALL(callback_,
1233 SendPacket(ssrc_low_priority, _, capture_time_ms, _, _))
1234 .Times(1);
1235 }
1236 for (size_t i = 0; i < packets_to_send_per_interval; ++i) {
1237 EXPECT_CALL(callback_, SendPacket(ssrc_low_priority, _,
1238 second_capture_time_ms, _, _))
1239 .Times(1);
1240 }
1241 }
1242 pacer_->Resume();
1243
Erik Språngeb487992019-11-14 14:15:15 +01001244 if (PeriodicProcess()) {
1245 // The pacer was resumed directly after the previous process call finished.
1246 // It will therefore wait 5 ms until next process.
Erik Språngd05edec2019-08-14 10:43:47 +02001247 clock_.AdvanceTime(TimeUntilNextProcess());
Erik Språngeb487992019-11-14 14:15:15 +01001248
1249 for (size_t i = 0; i < 4; i++) {
1250 pacer_->ProcessPackets();
1251 clock_.AdvanceTime(TimeUntilNextProcess());
1252 }
1253 } else {
1254 while (pacer_->QueueSizePackets() > 0) {
1255 AdvanceTimeAndProcess();
1256 }
Erik Språngd05edec2019-08-14 10:43:47 +02001257 }
1258
1259 EXPECT_EQ(TimeDelta::Zero(), pacer_->OldestPacketWaitTime());
1260}
1261
Erik Språngeb487992019-11-14 14:15:15 +01001262TEST_P(PacingControllerTest, InactiveFromStart) {
1263 // Recreate the pacer without the inital time forwarding.
1264 pacer_ = std::make_unique<PacingController>(&clock_, &callback_, nullptr,
1265 nullptr, GetParam());
1266 pacer_->SetProbingEnabled(false);
1267 pacer_->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate);
1268
1269 if (PeriodicProcess()) {
1270 // In period mode, pause the pacer to check the same idle behavior as
1271 // dynamic.
1272 pacer_->Pause();
1273 }
1274
1275 // No packets sent, there should be no keep-alives sent either.
1276 EXPECT_CALL(callback_, SendPadding).Times(0);
1277 EXPECT_CALL(callback_, SendPacket).Times(0);
1278 pacer_->ProcessPackets();
1279
1280 const Timestamp start_time = clock_.CurrentTime();
1281
1282 // Determine the margin need so we can advance to the last possible moment
1283 // that will not cause a process event.
1284 const TimeDelta time_margin =
1285 (GetParam() == PacingController::ProcessMode::kDynamic
1286 ? PacingController::kMinSleepTime
1287 : TimeDelta::Zero()) +
1288 TimeDelta::us(1);
1289
1290 EXPECT_EQ(pacer_->NextSendTime() - start_time,
1291 PacingController::kPausedProcessInterval);
1292 clock_.AdvanceTime(PacingController::kPausedProcessInterval - time_margin);
1293 pacer_->ProcessPackets();
1294 EXPECT_EQ(pacer_->NextSendTime() - start_time,
1295 PacingController::kPausedProcessInterval);
1296
1297 clock_.AdvanceTime(time_margin);
1298 pacer_->ProcessPackets();
1299 EXPECT_EQ(pacer_->NextSendTime() - start_time,
1300 2 * PacingController::kPausedProcessInterval);
1301}
1302
1303TEST_P(PacingControllerTest, ExpectedQueueTimeMs) {
Erik Språngd05edec2019-08-14 10:43:47 +02001304 uint32_t ssrc = 12346;
1305 uint16_t sequence_number = 1234;
1306 const size_t kNumPackets = 60;
1307 const size_t kPacketSize = 1200;
1308 const int32_t kMaxBitrate = kPaceMultiplier * 30000;
1309 EXPECT_EQ(TimeDelta::Zero(), pacer_->OldestPacketWaitTime());
1310
1311 pacer_->SetPacingRates(DataRate::bps(30000 * kPaceMultiplier),
1312 DataRate::Zero());
1313 for (size_t i = 0; i < kNumPackets; ++i) {
1314 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1315 clock_.TimeInMilliseconds(), kPacketSize);
1316 }
1317
1318 // Queue in ms = 1000 * (bytes in queue) *8 / (bits per second)
1319 TimeDelta queue_time =
1320 TimeDelta::ms(1000 * kNumPackets * kPacketSize * 8 / kMaxBitrate);
1321 EXPECT_EQ(queue_time, pacer_->ExpectedQueueTime());
1322
1323 const Timestamp time_start = clock_.CurrentTime();
1324 while (pacer_->QueueSizePackets() > 0) {
1325 clock_.AdvanceTime(TimeUntilNextProcess());
1326 pacer_->ProcessPackets();
1327 }
1328 TimeDelta duration = clock_.CurrentTime() - time_start;
1329
1330 EXPECT_EQ(TimeDelta::Zero(), pacer_->ExpectedQueueTime());
1331
1332 // Allow for aliasing, duration should be within one pack of max time limit.
1333 const TimeDelta deviation =
1334 duration - PacingController::kMaxExpectedQueueLength;
1335 EXPECT_LT(deviation.Abs(),
1336 TimeDelta::ms(1000 * kPacketSize * 8 / kMaxBitrate));
1337}
1338
Erik Språngeb487992019-11-14 14:15:15 +01001339TEST_P(PacingControllerTest, QueueTimeGrowsOverTime) {
Erik Språngd05edec2019-08-14 10:43:47 +02001340 uint32_t ssrc = 12346;
1341 uint16_t sequence_number = 1234;
1342 EXPECT_EQ(TimeDelta::Zero(), pacer_->OldestPacketWaitTime());
1343
1344 pacer_->SetPacingRates(DataRate::bps(30000 * kPaceMultiplier),
1345 DataRate::Zero());
1346 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number,
1347 clock_.TimeInMilliseconds(), 1200);
1348
1349 clock_.AdvanceTimeMilliseconds(500);
1350 EXPECT_EQ(TimeDelta::ms(500), pacer_->OldestPacketWaitTime());
1351 pacer_->ProcessPackets();
1352 EXPECT_EQ(TimeDelta::Zero(), pacer_->OldestPacketWaitTime());
1353}
1354
Erik Språngeb487992019-11-14 14:15:15 +01001355TEST_P(PacingControllerTest, ProbingWithInsertedPackets) {
Erik Språngd05edec2019-08-14 10:43:47 +02001356 const size_t kPacketSize = 1200;
1357 const int kInitialBitrateBps = 300000;
1358 uint32_t ssrc = 12346;
1359 uint16_t sequence_number = 1234;
1360
1361 PacingControllerProbing packet_sender;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001362 pacer_ = std::make_unique<PacingController>(&clock_, &packet_sender, nullptr,
Erik Språngeb487992019-11-14 14:15:15 +01001363 nullptr, GetParam());
Erik Språngd05edec2019-08-14 10:43:47 +02001364 pacer_->CreateProbeCluster(kFirstClusterRate,
1365 /*cluster_id=*/0);
1366 pacer_->CreateProbeCluster(kSecondClusterRate,
1367 /*cluster_id=*/1);
1368 pacer_->SetPacingRates(DataRate::bps(kInitialBitrateBps * kPaceMultiplier),
1369 DataRate::Zero());
1370
1371 for (int i = 0; i < 10; ++i) {
1372 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1373 clock_.TimeInMilliseconds(), kPacketSize);
1374 }
1375
1376 int64_t start = clock_.TimeInMilliseconds();
1377 while (packet_sender.packets_sent() < 5) {
1378 clock_.AdvanceTime(TimeUntilNextProcess());
1379 pacer_->ProcessPackets();
1380 }
1381 int packets_sent = packet_sender.packets_sent();
1382 // Validate first cluster bitrate. Note that we have to account for number
1383 // of intervals and hence (packets_sent - 1) on the first cluster.
1384 EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 /
1385 (clock_.TimeInMilliseconds() - start),
1386 kFirstClusterRate.bps(), kProbingErrorMargin.bps());
1387 EXPECT_EQ(0, packet_sender.padding_sent());
1388
1389 clock_.AdvanceTime(TimeUntilNextProcess());
1390 start = clock_.TimeInMilliseconds();
1391 while (packet_sender.packets_sent() < 10) {
1392 clock_.AdvanceTime(TimeUntilNextProcess());
1393 pacer_->ProcessPackets();
1394 }
1395 packets_sent = packet_sender.packets_sent() - packets_sent;
1396 // Validate second cluster bitrate.
1397 EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 /
1398 (clock_.TimeInMilliseconds() - start),
1399 kSecondClusterRate.bps(), kProbingErrorMargin.bps());
1400}
1401
Erik Språngeb487992019-11-14 14:15:15 +01001402TEST_P(PacingControllerTest, SkipsProbesWhenProcessIntervalTooLarge) {
Erik Språngb210eeb2019-11-05 11:21:48 +01001403 const size_t kPacketSize = 1200;
1404 const int kInitialBitrateBps = 300000;
1405 uint32_t ssrc = 12346;
1406 uint16_t sequence_number = 1234;
1407
1408 PacingControllerProbing packet_sender;
1409 pacer_ = std::make_unique<PacingController>(&clock_, &packet_sender, nullptr,
Erik Språngeb487992019-11-14 14:15:15 +01001410 nullptr, GetParam());
Erik Språngb210eeb2019-11-05 11:21:48 +01001411 pacer_->SetPacingRates(DataRate::bps(kInitialBitrateBps * kPaceMultiplier),
1412 DataRate::Zero());
1413
1414 for (int i = 0; i < 10; ++i) {
1415 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1416 clock_.TimeInMilliseconds(), kPacketSize);
1417 }
1418 while (pacer_->QueueSizePackets() > 0) {
1419 clock_.AdvanceTime(TimeUntilNextProcess());
1420 pacer_->ProcessPackets();
1421 }
1422
1423 // Probe at a very high rate.
1424 pacer_->CreateProbeCluster(DataRate::kbps(10000), // 10 Mbps.
1425 /*cluster_id=*/3);
1426 // We need one packet to start the probe.
1427 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1428 clock_.TimeInMilliseconds(), kPacketSize);
1429 const int packets_sent_before_probe = packet_sender.packets_sent();
1430 clock_.AdvanceTime(TimeUntilNextProcess());
1431 pacer_->ProcessPackets();
1432 EXPECT_EQ(packet_sender.packets_sent(), packets_sent_before_probe + 1);
1433
1434 // Figure out how long between probe packets.
1435 Timestamp start_time = clock_.CurrentTime();
1436 clock_.AdvanceTime(TimeUntilNextProcess());
1437 TimeDelta time_between_probes = clock_.CurrentTime() - start_time;
1438 // Advance that distance again + 1ms.
1439 clock_.AdvanceTime(time_between_probes);
1440
1441 // Send second probe packet.
1442 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1443 clock_.TimeInMilliseconds(), kPacketSize);
1444 pacer_->ProcessPackets();
1445 EXPECT_EQ(packet_sender.packets_sent(), packets_sent_before_probe + 2);
1446
1447 // We're exactly where we should be for the next probe.
Erik Språngeb487992019-11-14 14:15:15 +01001448 const Timestamp probe_time = clock_.CurrentTime();
1449 EXPECT_EQ(pacer_->NextSendTime(), clock_.CurrentTime());
Erik Språngb210eeb2019-11-05 11:21:48 +01001450
Erik Språng22fd5d72019-11-07 14:21:05 +01001451 FieldTrialBasedConfig field_trial_config;
1452 BitrateProberConfig probing_config(&field_trial_config);
1453 EXPECT_GT(probing_config.max_probe_delay.Get(), TimeDelta::Zero());
Erik Språngeb487992019-11-14 14:15:15 +01001454 // Advance to within max probe delay, should still return same target.
Erik Språng22fd5d72019-11-07 14:21:05 +01001455 clock_.AdvanceTime(probing_config.max_probe_delay.Get());
Erik Språngeb487992019-11-14 14:15:15 +01001456 EXPECT_EQ(pacer_->NextSendTime(), probe_time);
Erik Språngb210eeb2019-11-05 11:21:48 +01001457
Erik Språng22fd5d72019-11-07 14:21:05 +01001458 // Too high probe delay, drop it!
1459 clock_.AdvanceTime(TimeDelta::us(1));
Erik Språngeb487992019-11-14 14:15:15 +01001460 EXPECT_GT(pacer_->NextSendTime(), probe_time);
Erik Språngb210eeb2019-11-05 11:21:48 +01001461}
1462
Erik Språngeb487992019-11-14 14:15:15 +01001463TEST_P(PacingControllerTest, ProbingWithPaddingSupport) {
Erik Språngd05edec2019-08-14 10:43:47 +02001464 const size_t kPacketSize = 1200;
1465 const int kInitialBitrateBps = 300000;
1466 uint32_t ssrc = 12346;
1467 uint16_t sequence_number = 1234;
1468
1469 PacingControllerProbing packet_sender;
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001470 pacer_ = std::make_unique<PacingController>(&clock_, &packet_sender, nullptr,
Erik Språngeb487992019-11-14 14:15:15 +01001471 nullptr, GetParam());
Erik Språngd05edec2019-08-14 10:43:47 +02001472 pacer_->CreateProbeCluster(kFirstClusterRate,
1473 /*cluster_id=*/0);
1474 pacer_->SetPacingRates(DataRate::bps(kInitialBitrateBps * kPaceMultiplier),
1475 DataRate::Zero());
1476
1477 for (int i = 0; i < 3; ++i) {
1478 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1479 clock_.TimeInMilliseconds(), kPacketSize);
1480 }
1481
1482 int64_t start = clock_.TimeInMilliseconds();
1483 int process_count = 0;
1484 while (process_count < 5) {
1485 clock_.AdvanceTime(TimeUntilNextProcess());
1486 pacer_->ProcessPackets();
1487 ++process_count;
1488 }
1489 int packets_sent = packet_sender.packets_sent();
1490 int padding_sent = packet_sender.padding_sent();
1491 EXPECT_GT(packets_sent, 0);
1492 EXPECT_GT(padding_sent, 0);
1493 // Note that the number of intervals here for kPacketSize is
1494 // packets_sent due to padding in the same cluster.
1495 EXPECT_NEAR((packets_sent * kPacketSize * 8000 + padding_sent) /
1496 (clock_.TimeInMilliseconds() - start),
1497 kFirstClusterRate.bps(), kProbingErrorMargin.bps());
1498}
1499
Erik Språngeb487992019-11-14 14:15:15 +01001500TEST_P(PacingControllerTest, PaddingOveruse) {
Erik Språngd05edec2019-08-14 10:43:47 +02001501 uint32_t ssrc = 12346;
1502 uint16_t sequence_number = 1234;
1503 const size_t kPacketSize = 1200;
1504
Erik Språngeb487992019-11-14 14:15:15 +01001505 // Initially no padding rate.
Erik Språngd05edec2019-08-14 10:43:47 +02001506 pacer_->ProcessPackets();
1507 pacer_->SetPacingRates(DataRate::bps(60000 * kPaceMultiplier),
1508 DataRate::Zero());
1509
1510 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1511 clock_.TimeInMilliseconds(), kPacketSize);
1512 pacer_->ProcessPackets();
1513
1514 // Add 30kbit padding. When increasing budget, media budget will increase from
1515 // negative (overuse) while padding budget will increase from 0.
1516 clock_.AdvanceTimeMilliseconds(5);
1517 pacer_->SetPacingRates(DataRate::bps(60000 * kPaceMultiplier),
1518 DataRate::bps(30000));
1519
1520 SendAndExpectPacket(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1521 clock_.TimeInMilliseconds(), kPacketSize);
1522 EXPECT_LT(TimeDelta::ms(5), pacer_->ExpectedQueueTime());
1523 // Don't send padding if queue is non-empty, even if padding budget > 0.
1524 EXPECT_CALL(callback_, SendPadding).Times(0);
Erik Språngeb487992019-11-14 14:15:15 +01001525 if (PeriodicProcess()) {
1526 pacer_->ProcessPackets();
1527 } else {
1528 AdvanceTimeAndProcess();
1529 }
Erik Språngd05edec2019-08-14 10:43:47 +02001530}
1531
Erik Språngeb487992019-11-14 14:15:15 +01001532TEST_P(PacingControllerTest, ProbeClusterId) {
Erik Språngd05edec2019-08-14 10:43:47 +02001533 MockPacketSender callback;
1534
Erik Språngeb487992019-11-14 14:15:15 +01001535 pacer_ = std::make_unique<PacingController>(&clock_, &callback, nullptr,
1536 nullptr, GetParam());
Erik Språngd05edec2019-08-14 10:43:47 +02001537 Init();
1538
1539 uint32_t ssrc = 12346;
1540 uint16_t sequence_number = 1234;
1541 const size_t kPacketSize = 1200;
1542
1543 pacer_->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate);
1544 pacer_->SetProbingEnabled(true);
1545 for (int i = 0; i < 10; ++i) {
1546 Send(RtpPacketToSend::Type::kVideo, ssrc, sequence_number++,
1547 clock_.TimeInMilliseconds(), kPacketSize);
1548 }
1549
1550 // First probing cluster.
Erik Språngf5815fa2019-08-21 14:27:31 +02001551 EXPECT_CALL(callback,
1552 SendRtpPacket(_, Field(&PacedPacketInfo::probe_cluster_id, 0)))
1553 .Times(5);
Erik Språngd05edec2019-08-14 10:43:47 +02001554
1555 for (int i = 0; i < 5; ++i) {
Erik Språngeb487992019-11-14 14:15:15 +01001556 AdvanceTimeAndProcess();
Erik Språngd05edec2019-08-14 10:43:47 +02001557 }
1558
1559 // Second probing cluster.
Erik Språngf5815fa2019-08-21 14:27:31 +02001560 EXPECT_CALL(callback,
1561 SendRtpPacket(_, Field(&PacedPacketInfo::probe_cluster_id, 1)))
1562 .Times(5);
Erik Språngd05edec2019-08-14 10:43:47 +02001563
1564 for (int i = 0; i < 5; ++i) {
Erik Språngeb487992019-11-14 14:15:15 +01001565 AdvanceTimeAndProcess();
Erik Språngd05edec2019-08-14 10:43:47 +02001566 }
1567
1568 // Needed for the Field comparer below.
1569 const int kNotAProbe = PacedPacketInfo::kNotAProbe;
1570 // No more probing packets.
Erik Språngf5815fa2019-08-21 14:27:31 +02001571 EXPECT_CALL(callback, GeneratePadding).WillOnce([&](DataSize padding_size) {
1572 std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets;
1573 padding_packets.emplace_back(
1574 BuildPacket(RtpPacketToSend::Type::kPadding, ssrc, sequence_number++,
1575 clock_.TimeInMilliseconds(), padding_size.bytes()));
1576 return padding_packets;
1577 });
Erik Språngeb487992019-11-14 14:15:15 +01001578 bool non_probe_packet_seen = false;
1579 EXPECT_CALL(callback, SendRtpPacket)
1580 .WillOnce([&](std::unique_ptr<RtpPacketToSend> packet,
1581 const PacedPacketInfo& cluster_info) {
1582 EXPECT_EQ(cluster_info.probe_cluster_id, kNotAProbe);
1583 non_probe_packet_seen = true;
1584 });
1585 while (!non_probe_packet_seen) {
1586 AdvanceTimeAndProcess();
1587 }
Erik Språngd05edec2019-08-14 10:43:47 +02001588}
1589
Erik Språngeb487992019-11-14 14:15:15 +01001590TEST_P(PacingControllerTest, OwnedPacketPrioritizedOnType) {
Erik Språngd05edec2019-08-14 10:43:47 +02001591 MockPacketSender callback;
Erik Språngeb487992019-11-14 14:15:15 +01001592 pacer_ = std::make_unique<PacingController>(&clock_, &callback, nullptr,
1593 nullptr, GetParam());
Erik Språngd05edec2019-08-14 10:43:47 +02001594 Init();
1595
1596 // Insert a packet of each type, from low to high priority. Since priority
1597 // is weighted higher than insert order, these should come out of the pacer
1598 // in backwards order with the exception of FEC and Video.
1599 for (RtpPacketToSend::Type type :
1600 {RtpPacketToSend::Type::kPadding,
1601 RtpPacketToSend::Type::kForwardErrorCorrection,
1602 RtpPacketToSend::Type::kVideo, RtpPacketToSend::Type::kRetransmission,
1603 RtpPacketToSend::Type::kAudio}) {
1604 pacer_->EnqueuePacket(BuildRtpPacket(type));
1605 }
1606
1607 ::testing::InSequence seq;
1608 EXPECT_CALL(
1609 callback,
1610 SendRtpPacket(Pointee(Property(&RtpPacketToSend::Ssrc, kAudioSsrc)), _));
1611 EXPECT_CALL(callback,
1612 SendRtpPacket(
1613 Pointee(Property(&RtpPacketToSend::Ssrc, kVideoRtxSsrc)), _));
1614
1615 // FEC and video actually have the same priority, so will come out in
1616 // insertion order.
1617 EXPECT_CALL(callback,
1618 SendRtpPacket(
1619 Pointee(Property(&RtpPacketToSend::Ssrc, kFlexFecSsrc)), _));
1620 EXPECT_CALL(
1621 callback,
1622 SendRtpPacket(Pointee(Property(&RtpPacketToSend::Ssrc, kVideoSsrc)), _));
1623
1624 EXPECT_CALL(callback,
1625 SendRtpPacket(
1626 Pointee(Property(&RtpPacketToSend::Ssrc, kVideoRtxSsrc)), _));
1627
Erik Språngeb487992019-11-14 14:15:15 +01001628 while (pacer_->QueueSizePackets() > 0) {
1629 if (PeriodicProcess()) {
1630 clock_.AdvanceTimeMilliseconds(5);
1631 pacer_->ProcessPackets();
1632 } else {
1633 AdvanceTimeAndProcess();
1634 }
1635 }
Erik Språngd05edec2019-08-14 10:43:47 +02001636}
Erik Språng78c82a42019-10-03 18:46:04 +02001637
Erik Språngeb487992019-11-14 14:15:15 +01001638TEST_P(PacingControllerTest, SmallFirstProbePacket) {
Erik Språng78c82a42019-10-03 18:46:04 +02001639 ScopedFieldTrials trial("WebRTC-Pacer-SmallFirstProbePacket/Enabled/");
1640 MockPacketSender callback;
Erik Språngeb487992019-11-14 14:15:15 +01001641 pacer_ = std::make_unique<PacingController>(&clock_, &callback, nullptr,
1642 nullptr, GetParam());
Erik Språng78c82a42019-10-03 18:46:04 +02001643 pacer_->CreateProbeCluster(kFirstClusterRate, /*cluster_id=*/0);
1644 pacer_->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero());
1645
1646 // Add high prio media.
1647 pacer_->EnqueuePacket(BuildRtpPacket(RtpPacketToSend::Type::kAudio));
1648
1649 // Expect small padding packet to be requested.
1650 EXPECT_CALL(callback, GeneratePadding(DataSize::bytes(1)))
1651 .WillOnce([&](DataSize padding_size) {
1652 std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets;
1653 padding_packets.emplace_back(
1654 BuildPacket(RtpPacketToSend::Type::kPadding, kAudioSsrc, 1,
1655 clock_.TimeInMilliseconds(), 1));
1656 return padding_packets;
1657 });
1658
1659 size_t packets_sent = 0;
1660 bool media_seen = false;
1661 EXPECT_CALL(callback, SendRtpPacket)
1662 .Times(::testing::AnyNumber())
1663 .WillRepeatedly([&](std::unique_ptr<RtpPacketToSend> packet,
1664 const PacedPacketInfo& cluster_info) {
1665 if (packets_sent == 0) {
1666 EXPECT_EQ(packet->packet_type(), RtpPacketToSend::Type::kPadding);
1667 } else {
1668 if (packet->packet_type() == RtpPacketToSend::Type::kAudio) {
1669 media_seen = true;
1670 }
1671 }
1672 packets_sent++;
1673 });
1674 while (!media_seen) {
1675 pacer_->ProcessPackets();
1676 clock_.AdvanceTimeMilliseconds(5);
1677 }
1678}
Erik Språngeb487992019-11-14 14:15:15 +01001679
1680TEST_P(PacingControllerTest, TaskEarly) {
1681 if (PeriodicProcess()) {
1682 // This test applies only when NOT using interval budget.
1683 return;
1684 }
1685
1686 // Set a low send rate to more easily test timing issues.
1687 DataRate kSendRate = DataRate::kbps(30);
1688 pacer_->SetPacingRates(kSendRate, DataRate::Zero());
1689
1690 // Add two packets.
1691 pacer_->EnqueuePacket(BuildRtpPacket(RtpPacketToSend::Type::kVideo));
1692 pacer_->EnqueuePacket(BuildRtpPacket(RtpPacketToSend::Type::kVideo));
1693
1694 // Process packets, only first should be sent.
1695 EXPECT_CALL(callback_, SendPacket).Times(1);
1696 pacer_->ProcessPackets();
1697
1698 Timestamp next_send_time = pacer_->NextSendTime();
1699
1700 // Packets won't be sent if we try process more than one sleep time early.
1701 ASSERT_GT(next_send_time - clock_.CurrentTime(),
1702 PacingController::kMinSleepTime);
1703 clock_.AdvanceTime(next_send_time - clock_.CurrentTime() -
1704 (PacingController::kMinSleepTime + TimeDelta::ms(1)));
1705
1706 EXPECT_CALL(callback_, SendPacket).Times(0);
1707 pacer_->ProcessPackets();
1708
1709 // Assume timing is accurate within +-100us due to rounding.
1710 const TimeDelta kErrorMargin = TimeDelta::us(100);
1711
1712 // Check that next scheduled send time is still the same (within margin).
1713 EXPECT_LT((pacer_->NextSendTime() - next_send_time).Abs(), kErrorMargin);
1714
1715 // Advance to within error margin for execution.
1716 clock_.AdvanceTime(TimeDelta::ms(1) + kErrorMargin);
1717 EXPECT_CALL(callback_, SendPacket).Times(1);
1718 pacer_->ProcessPackets();
1719}
1720
1721TEST_P(PacingControllerTest, TaskLate) {
1722 if (PeriodicProcess()) {
1723 // This test applies only when NOT using interval budget.
1724 return;
1725 }
1726
1727 // Set a low send rate to more easily test timing issues.
1728 DataRate kSendRate = DataRate::kbps(30);
1729 pacer_->SetPacingRates(kSendRate, DataRate::Zero());
1730
1731 // Add four packets of equal size and priority.
1732 pacer_->EnqueuePacket(BuildRtpPacket(RtpPacketToSend::Type::kVideo));
1733 pacer_->EnqueuePacket(BuildRtpPacket(RtpPacketToSend::Type::kVideo));
1734 pacer_->EnqueuePacket(BuildRtpPacket(RtpPacketToSend::Type::kVideo));
1735 pacer_->EnqueuePacket(BuildRtpPacket(RtpPacketToSend::Type::kVideo));
1736
1737 // Process packets, only first should be sent.
1738 EXPECT_CALL(callback_, SendPacket).Times(1);
1739 pacer_->ProcessPackets();
1740
1741 Timestamp next_send_time = pacer_->NextSendTime();
1742 const TimeDelta time_between_packets = next_send_time - clock_.CurrentTime();
1743
1744 // Simulate a late process call, executed just before we allow sending the
1745 // fourth packet.
1746 clock_.AdvanceTime((time_between_packets * 3) -
1747 (PacingController::kMinSleepTime + TimeDelta::ms(1)));
1748
1749 EXPECT_CALL(callback_, SendPacket).Times(2);
1750 pacer_->ProcessPackets();
1751
1752 // Check that next scheduled send time is within sleep-time + 1ms.
1753 next_send_time = pacer_->NextSendTime();
1754 EXPECT_LE(next_send_time - clock_.CurrentTime(),
1755 PacingController::kMinSleepTime + TimeDelta::ms(1));
1756
1757 // Advance to within error margin for execution.
1758 clock_.AdvanceTime(TimeDelta::ms(1));
1759 EXPECT_CALL(callback_, SendPacket).Times(1);
1760 pacer_->ProcessPackets();
1761}
1762
1763INSTANTIATE_TEST_SUITE_P(
1764 WithAndWithoutIntervalBudget,
1765 PacingControllerTest,
1766 ::testing::Values(PacingController::ProcessMode::kPeriodic,
1767 PacingController::ProcessMode::kDynamic));
1768
Erik Språngd05edec2019-08-14 10:43:47 +02001769} // namespace test
1770} // namespace webrtc