Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2019 The WebRTC Project Authors. All rights reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | #include "api/task_queue/task_queue_test.h" |
| 11 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 12 | #include <memory> |
| 13 | |
| 14 | #include "absl/cleanup/cleanup.h" |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 15 | #include "absl/strings/string_view.h" |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 16 | #include "api/units/time_delta.h" |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 17 | #include "rtc_base/event.h" |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 18 | #include "rtc_base/ref_counter.h" |
Steve Anton | f380284 | 2019-01-24 19:07:40 -0800 | [diff] [blame] | 19 | #include "rtc_base/time_utils.h" |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 20 | |
| 21 | namespace webrtc { |
| 22 | namespace { |
| 23 | |
| 24 | std::unique_ptr<TaskQueueBase, TaskQueueDeleter> CreateTaskQueue( |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 25 | const std::unique_ptr<webrtc::TaskQueueFactory>& factory, |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 26 | absl::string_view task_queue_name, |
| 27 | TaskQueueFactory::Priority priority = TaskQueueFactory::Priority::NORMAL) { |
| 28 | return factory->CreateTaskQueue(task_queue_name, priority); |
| 29 | } |
| 30 | |
| 31 | TEST_P(TaskQueueTest, Construct) { |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 32 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(); |
| 33 | auto queue = CreateTaskQueue(factory, "Construct"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 34 | EXPECT_FALSE(queue->IsCurrent()); |
| 35 | } |
| 36 | |
| 37 | TEST_P(TaskQueueTest, PostAndCheckCurrent) { |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 38 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 39 | rtc::Event event; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 40 | auto queue = CreateTaskQueue(factory, "PostAndCheckCurrent"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 41 | |
Artem Titov | 0e61fdd | 2021-07-25 21:50:14 +0200 | [diff] [blame] | 42 | // We're not running a task, so `queue` shouldn't be current. |
Tommi | 6866dc7 | 2020-05-15 10:11:56 +0200 | [diff] [blame] | 43 | // Note that because rtc::Thread also supports the TQ interface and |
| 44 | // TestMainImpl::Init wraps the main test thread (bugs.webrtc.org/9714), that |
| 45 | // means that TaskQueueBase::Current() will still return a valid value. |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 46 | EXPECT_FALSE(queue->IsCurrent()); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 47 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 48 | queue->PostTask([&event, &queue] { |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 49 | EXPECT_TRUE(queue->IsCurrent()); |
| 50 | event.Set(); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 51 | }); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame^] | 52 | EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 53 | } |
| 54 | |
| 55 | TEST_P(TaskQueueTest, PostCustomTask) { |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 56 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 57 | rtc::Event ran; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 58 | auto queue = CreateTaskQueue(factory, "PostCustomImplementation"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 59 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 60 | class CustomTask { |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 61 | public: |
| 62 | explicit CustomTask(rtc::Event* ran) : ran_(ran) {} |
| 63 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 64 | void operator()() { ran_->Set(); } |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 65 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 66 | private: |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 67 | rtc::Event* const ran_; |
| 68 | } my_task(&ran); |
| 69 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 70 | queue->PostTask(my_task); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame^] | 71 | EXPECT_TRUE(ran.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 72 | } |
| 73 | |
| 74 | TEST_P(TaskQueueTest, PostDelayedZero) { |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 75 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 76 | rtc::Event event; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 77 | auto queue = CreateTaskQueue(factory, "PostDelayedZero"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 78 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 79 | queue->PostDelayedTask([&event] { event.Set(); }, TimeDelta::Zero()); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame^] | 80 | EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 81 | } |
| 82 | |
| 83 | TEST_P(TaskQueueTest, PostFromQueue) { |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 84 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 85 | rtc::Event event; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 86 | auto queue = CreateTaskQueue(factory, "PostFromQueue"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 87 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 88 | queue->PostTask( |
| 89 | [&event, &queue] { queue->PostTask([&event] { event.Set(); }); }); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame^] | 90 | EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 91 | } |
| 92 | |
| 93 | TEST_P(TaskQueueTest, PostDelayed) { |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 94 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 95 | rtc::Event event; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 96 | auto queue = |
| 97 | CreateTaskQueue(factory, "PostDelayed", TaskQueueFactory::Priority::HIGH); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 98 | |
| 99 | int64_t start = rtc::TimeMillis(); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 100 | queue->PostDelayedTask( |
| 101 | [&event, &queue] { |
| 102 | EXPECT_TRUE(queue->IsCurrent()); |
| 103 | event.Set(); |
| 104 | }, |
| 105 | TimeDelta::Millis(100)); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame^] | 106 | EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 107 | int64_t end = rtc::TimeMillis(); |
| 108 | // These tests are a little relaxed due to how "powerful" our test bots can |
| 109 | // be. Most recently we've seen windows bots fire the callback after 94-99ms, |
| 110 | // which is why we have a little bit of leeway backwards as well. |
| 111 | EXPECT_GE(end - start, 90u); |
| 112 | EXPECT_NEAR(end - start, 190u, 100u); // Accept 90-290. |
| 113 | } |
| 114 | |
| 115 | TEST_P(TaskQueueTest, PostMultipleDelayed) { |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 116 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(); |
| 117 | auto queue = CreateTaskQueue(factory, "PostMultipleDelayed"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 118 | |
| 119 | std::vector<rtc::Event> events(100); |
| 120 | for (int i = 0; i < 100; ++i) { |
| 121 | rtc::Event* event = &events[i]; |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 122 | queue->PostDelayedTask( |
| 123 | [event, &queue] { |
| 124 | EXPECT_TRUE(queue->IsCurrent()); |
| 125 | event->Set(); |
| 126 | }, |
| 127 | TimeDelta::Millis(i)); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 128 | } |
| 129 | |
| 130 | for (rtc::Event& e : events) |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame^] | 131 | EXPECT_TRUE(e.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 132 | } |
| 133 | |
| 134 | TEST_P(TaskQueueTest, PostDelayedAfterDestruct) { |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 135 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 136 | rtc::Event run; |
| 137 | rtc::Event deleted; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 138 | auto queue = CreateTaskQueue(factory, "PostDelayedAfterDestruct"); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 139 | absl::Cleanup cleanup = [&deleted] { deleted.Set(); }; |
| 140 | queue->PostDelayedTask([&run, cleanup = std::move(cleanup)] { run.Set(); }, |
| 141 | TimeDelta::Millis(100)); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 142 | // Destroy the queue. |
| 143 | queue = nullptr; |
| 144 | // Task might outlive the TaskQueue, but still should be deleted. |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame^] | 145 | EXPECT_TRUE(deleted.Wait(TimeDelta::Seconds(1))); |
| 146 | EXPECT_FALSE(run.Wait(TimeDelta::Zero())); // and should not run. |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 147 | } |
| 148 | |
| 149 | TEST_P(TaskQueueTest, PostAndReuse) { |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 150 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 151 | rtc::Event event; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 152 | auto post_queue = CreateTaskQueue(factory, "PostQueue"); |
| 153 | auto reply_queue = CreateTaskQueue(factory, "ReplyQueue"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 154 | |
| 155 | int call_count = 0; |
| 156 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 157 | class ReusedTask { |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 158 | public: |
| 159 | ReusedTask(int* counter, TaskQueueBase* reply_queue, rtc::Event* event) |
| 160 | : counter_(*counter), reply_queue_(reply_queue), event_(*event) { |
| 161 | EXPECT_EQ(counter_, 0); |
| 162 | } |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 163 | ReusedTask(ReusedTask&&) = default; |
| 164 | ReusedTask& operator=(ReusedTask&&) = delete; |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 165 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 166 | void operator()() && { |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 167 | if (++counter_ == 1) { |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 168 | reply_queue_->PostTask(std::move(*this)); |
| 169 | // At this point, the object is in the moved-from state. |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 170 | } else { |
| 171 | EXPECT_EQ(counter_, 2); |
| 172 | EXPECT_TRUE(reply_queue_->IsCurrent()); |
| 173 | event_.Set(); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 174 | } |
| 175 | } |
| 176 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 177 | private: |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 178 | int& counter_; |
| 179 | TaskQueueBase* const reply_queue_; |
| 180 | rtc::Event& event_; |
| 181 | }; |
| 182 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 183 | ReusedTask task(&call_count, reply_queue.get(), &event); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 184 | post_queue->PostTask(std::move(task)); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame^] | 185 | EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 186 | } |
| 187 | |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 188 | TEST_P(TaskQueueTest, PostALot) { |
Artem Titov | 0e61fdd | 2021-07-25 21:50:14 +0200 | [diff] [blame] | 189 | // Waits until DecrementCount called `count` times. Thread safe. |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 190 | class BlockingCounter { |
| 191 | public: |
| 192 | explicit BlockingCounter(int initial_count) : count_(initial_count) {} |
| 193 | |
| 194 | void DecrementCount() { |
| 195 | if (count_.DecRef() == rtc::RefCountReleaseStatus::kDroppedLastRef) { |
| 196 | event_.Set(); |
| 197 | } |
| 198 | } |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame^] | 199 | bool Wait(TimeDelta give_up_after) { return event_.Wait(give_up_after); } |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 200 | |
| 201 | private: |
| 202 | webrtc_impl::RefCounter count_; |
| 203 | rtc::Event event_; |
| 204 | }; |
| 205 | |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 206 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(); |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 207 | static constexpr int kTaskCount = 0xffff; |
| 208 | rtc::Event posting_done; |
| 209 | BlockingCounter all_destroyed(kTaskCount); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 210 | |
| 211 | int tasks_executed = 0; |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 212 | auto task_queue = CreateTaskQueue(factory, "PostALot"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 213 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 214 | task_queue->PostTask([&] { |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 215 | // Post tasks from the queue to guarantee that the 1st task won't be |
| 216 | // executed before the last one is posted. |
| 217 | for (int i = 0; i < kTaskCount; ++i) { |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 218 | absl::Cleanup cleanup = [&] { all_destroyed.DecrementCount(); }; |
| 219 | task_queue->PostTask([&tasks_executed, cleanup = std::move(cleanup)] { |
| 220 | ++tasks_executed; |
| 221 | }); |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 222 | } |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 223 | |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 224 | posting_done.Set(); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 225 | }); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 226 | |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 227 | // Before destroying the task queue wait until all child tasks are posted. |
Danil Chapovalov | 95e0a60 | 2019-06-11 13:49:20 +0200 | [diff] [blame] | 228 | posting_done.Wait(rtc::Event::kForever); |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 229 | // Destroy the task queue. |
| 230 | task_queue = nullptr; |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 231 | |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 232 | // Expect all tasks are destroyed eventually. In some task queue |
| 233 | // implementations that might happen on a different thread after task queue is |
| 234 | // destroyed. |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame^] | 235 | EXPECT_TRUE(all_destroyed.Wait(TimeDelta::Minutes(1))); |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 236 | EXPECT_LE(tasks_executed, kTaskCount); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 237 | } |
| 238 | |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 239 | // Test posting two tasks that have shared state not protected by a |
| 240 | // lock. The TaskQueue should guarantee memory read-write order and |
| 241 | // FIFO task execution order, so the second task should always see the |
| 242 | // changes that were made by the first task. |
| 243 | // |
| 244 | // If the TaskQueue doesn't properly synchronize the execution of |
| 245 | // tasks, there will be a data race, which is undefined behavior. The |
| 246 | // EXPECT calls may randomly catch this, but to make the most of this |
| 247 | // unit test, run it under TSan or some other tool that is able to |
| 248 | // directly detect data races. |
| 249 | TEST_P(TaskQueueTest, PostTwoWithSharedUnprotectedState) { |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 250 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(); |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 251 | struct SharedState { |
| 252 | // First task will set this value to 1 and second will assert it. |
| 253 | int state = 0; |
| 254 | } state; |
| 255 | |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 256 | auto queue = CreateTaskQueue(factory, "PostTwoWithSharedUnprotectedState"); |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 257 | rtc::Event done; |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 258 | queue->PostTask([&state, &queue, &done] { |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 259 | // Post tasks from queue to guarantee, that 1st task won't be |
| 260 | // executed before the second one will be posted. |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 261 | queue->PostTask([&state] { state.state = 1; }); |
| 262 | queue->PostTask([&state, &done] { |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 263 | EXPECT_EQ(state.state, 1); |
| 264 | done.Set(); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 265 | }); |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 266 | // Check, that state changing tasks didn't start yet. |
| 267 | EXPECT_EQ(state.state, 0); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 268 | }); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame^] | 269 | EXPECT_TRUE(done.Wait(TimeDelta::Seconds(1))); |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 270 | } |
| 271 | |
Danil Chapovalov | 5ad16a5 | 2020-06-09 14:44:31 +0200 | [diff] [blame] | 272 | // TaskQueueTest is a set of tests for any implementation of the TaskQueueBase. |
| 273 | // Tests are instantiated next to the concrete implementation(s). |
| 274 | // https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#creating-value-parameterized-abstract-tests |
| 275 | GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(TaskQueueTest); |
| 276 | |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 277 | } // namespace |
| 278 | } // namespace webrtc |