Jeff Bolz | 8769753 | 2019-01-11 22:54:00 -0600 | [diff] [blame] | 1 | /* Copyright (c) 2015-2019 The Khronos Group Inc. |
| 2 | * Copyright (c) 2015-2019 Valve Corporation |
| 3 | * Copyright (c) 2015-2019 LunarG, Inc. |
| 4 | * Copyright (C) 2015-2019 Google Inc. |
Mark Lobodzinski | d42e4d2 | 2017-01-17 14:14:22 -0700 | [diff] [blame] | 5 | * |
| 6 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 7 | * you may not use this file except in compliance with the License. |
| 8 | * You may obtain a copy of the License at |
| 9 | * |
| 10 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 11 | * |
| 12 | * Unless required by applicable law or agreed to in writing, software |
| 13 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 14 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 15 | * See the License for the specific language governing permissions and |
| 16 | * limitations under the License. |
| 17 | * |
| 18 | * Author: Mark Lobodzinski <mark@lunarg.com> |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 19 | * Author: Dave Houlton <daveh@lunarg.com> |
Shannon McPherson | 3ea6513 | 2018-12-05 10:37:39 -0700 | [diff] [blame] | 20 | * Shannon McPherson <shannon@lunarg.com> |
Mark Lobodzinski | d42e4d2 | 2017-01-17 14:14:22 -0700 | [diff] [blame] | 21 | */ |
| 22 | |
| 23 | // Allow use of STL min and max functions in Windows |
| 24 | #define NOMINMAX |
| 25 | |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 26 | #include <cmath> |
| 27 | #include <set> |
Mark Lobodzinski | 90224de | 2017-01-26 15:23:11 -0700 | [diff] [blame] | 28 | #include <sstream> |
Petr Kraus | 4d71868 | 2017-05-18 03:38:41 +0200 | [diff] [blame] | 29 | #include <string> |
Mark Lobodzinski | 90224de | 2017-01-26 15:23:11 -0700 | [diff] [blame] | 30 | |
| 31 | #include "vk_enum_string_helper.h" |
| 32 | #include "vk_layer_data.h" |
| 33 | #include "vk_layer_utils.h" |
| 34 | #include "vk_layer_logging.h" |
Dave Houlton | bd2e262 | 2018-04-10 16:41:14 -0600 | [diff] [blame] | 35 | #include "vk_typemap_helper.h" |
Mark Lobodzinski | 90224de | 2017-01-26 15:23:11 -0700 | [diff] [blame] | 36 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 37 | #include "chassis.h" |
Mark Lobodzinski | 76d7666 | 2019-02-14 14:38:21 -0700 | [diff] [blame] | 38 | #include "core_validation.h" |
| 39 | #include "shader_validation.h" |
| 40 | #include "descriptor_sets.h" |
Mark Lobodzinski | d42e4d2 | 2017-01-17 14:14:22 -0700 | [diff] [blame] | 41 | #include "buffer_validation.h" |
Mark Lobodzinski | 42fe5f7 | 2017-01-11 11:36:16 -0700 | [diff] [blame] | 42 | |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 43 | uint32_t FullMipChainLevels(uint32_t height, uint32_t width, uint32_t depth) { |
| 44 | // uint cast applies floor() |
| 45 | return 1u + (uint32_t)log2(std::max({height, width, depth})); |
| 46 | } |
| 47 | |
| 48 | uint32_t FullMipChainLevels(VkExtent3D extent) { return FullMipChainLevels(extent.height, extent.width, extent.depth); } |
| 49 | |
| 50 | uint32_t FullMipChainLevels(VkExtent2D extent) { return FullMipChainLevels(extent.height, extent.width); } |
| 51 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 52 | void CoreChecks::SetLayout(layer_data *device_data, GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, |
| 53 | const VkImageLayout &layout) { |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 54 | auto it = pCB->imageLayoutMap.find(imgpair); |
| 55 | if (it != pCB->imageLayoutMap.end()) { |
| 56 | it->second.layout = layout; |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 57 | } else { |
| 58 | assert(imgpair.hasSubresource); |
| 59 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
| 60 | if (!FindCmdBufLayout(device_data, pCB, imgpair.image, imgpair.subresource, node)) { |
| 61 | node.initialLayout = layout; |
| 62 | } |
| 63 | SetLayout(device_data, pCB, imgpair, {node.initialLayout, layout}); |
| 64 | } |
| 65 | } |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 66 | |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 67 | template <class OBJECT, class LAYOUT> |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 68 | void CoreChecks::SetLayout(layer_data *device_data, OBJECT *pObject, VkImage image, VkImageSubresource range, |
| 69 | const LAYOUT &layout) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 70 | ImageSubresourcePair imgpair = {image, true, range}; |
| 71 | SetLayout(device_data, pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); |
| 72 | SetLayout(device_data, pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 73 | SetLayout(device_data, pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 74 | SetLayout(device_data, pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 75 | if (GetDeviceExtensions()->vk_khr_sampler_ycbcr_conversion) { |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 76 | SetLayout(device_data, pObject, imgpair, layout, VK_IMAGE_ASPECT_PLANE_0_BIT_KHR); |
| 77 | SetLayout(device_data, pObject, imgpair, layout, VK_IMAGE_ASPECT_PLANE_1_BIT_KHR); |
| 78 | SetLayout(device_data, pObject, imgpair, layout, VK_IMAGE_ASPECT_PLANE_2_BIT_KHR); |
| 79 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 80 | } |
| 81 | |
| 82 | template <class OBJECT, class LAYOUT> |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 83 | void CoreChecks::SetLayout(layer_data *device_data, OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, |
| 84 | VkImageAspectFlags aspectMask) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 85 | if (imgpair.subresource.aspectMask & aspectMask) { |
| 86 | imgpair.subresource.aspectMask = aspectMask; |
| 87 | SetLayout(device_data, pObject, imgpair, layout); |
| 88 | } |
| 89 | } |
| 90 | |
Tony Barbour | df013b9 | 2017-01-25 12:53:48 -0700 | [diff] [blame] | 91 | // Set the layout in supplied map |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 92 | void CoreChecks::SetLayout(std::unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> &imageLayoutMap, |
| 93 | ImageSubresourcePair imgpair, VkImageLayout layout) { |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 94 | auto it = imageLayoutMap.find(imgpair); |
| 95 | if (it != imageLayoutMap.end()) { |
| 96 | it->second.layout = layout; // Update |
| 97 | } else { |
| 98 | imageLayoutMap[imgpair].layout = layout; // Insert |
| 99 | } |
Tony Barbour | df013b9 | 2017-01-25 12:53:48 -0700 | [diff] [blame] | 100 | } |
| 101 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 102 | bool CoreChecks::FindLayoutVerifyNode(layer_data const *device_data, GLOBAL_CB_NODE const *pCB, ImageSubresourcePair imgpair, |
| 103 | IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 104 | if (!(imgpair.subresource.aspectMask & aspectMask)) { |
| 105 | return false; |
| 106 | } |
| 107 | VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; |
| 108 | imgpair.subresource.aspectMask = aspectMask; |
| 109 | auto imgsubIt = pCB->imageLayoutMap.find(imgpair); |
| 110 | if (imgsubIt == pCB->imageLayoutMap.end()) { |
| 111 | return false; |
| 112 | } |
| 113 | if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 114 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(imgpair.image), |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 115 | kVUID_Core_DrawState_InvalidLayout, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 116 | "Cannot query for VkImage %s layout when combined aspect mask %d has multiple layout types: %s and %s", |
| 117 | report_data->FormatHandle(imgpair.image).c_str(), oldAspectMask, string_VkImageLayout(node.layout), |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 118 | string_VkImageLayout(imgsubIt->second.layout)); |
| 119 | } |
| 120 | if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 121 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(imgpair.image), |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 122 | kVUID_Core_DrawState_InvalidLayout, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 123 | "Cannot query for VkImage %s" |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 124 | " layout when combined aspect mask %d has multiple initial layout types: %s and %s", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 125 | report_data->FormatHandle(imgpair.image).c_str(), oldAspectMask, string_VkImageLayout(node.initialLayout), |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 126 | string_VkImageLayout(imgsubIt->second.initialLayout)); |
| 127 | } |
| 128 | node = imgsubIt->second; |
| 129 | return true; |
| 130 | } |
| 131 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 132 | bool CoreChecks::FindLayoutVerifyLayout(layer_data const *device_data, ImageSubresourcePair imgpair, VkImageLayout &layout, |
| 133 | const VkImageAspectFlags aspectMask) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 134 | if (!(imgpair.subresource.aspectMask & aspectMask)) { |
| 135 | return false; |
| 136 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 137 | VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; |
| 138 | imgpair.subresource.aspectMask = aspectMask; |
Mark Lobodzinski | 44d46d5 | 2019-03-07 11:04:06 -0700 | [diff] [blame] | 139 | auto imgsubIt = (*GetImageLayoutMap()).find(imgpair); |
| 140 | if (imgsubIt == (*GetImageLayoutMap()).end()) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 141 | return false; |
| 142 | } |
| 143 | if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 144 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(imgpair.image), |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 145 | kVUID_Core_DrawState_InvalidLayout, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 146 | "Cannot query for VkImage %s layout when combined aspect mask %d has multiple layout types: %s and %s", |
| 147 | report_data->FormatHandle(imgpair.image).c_str(), oldAspectMask, string_VkImageLayout(layout), |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 148 | string_VkImageLayout(imgsubIt->second.layout)); |
| 149 | } |
| 150 | layout = imgsubIt->second.layout; |
| 151 | return true; |
| 152 | } |
| 153 | |
| 154 | // Find layout(s) on the command buffer level |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 155 | bool CoreChecks::FindCmdBufLayout(layer_data const *device_data, GLOBAL_CB_NODE const *pCB, VkImage image, VkImageSubresource range, |
| 156 | IMAGE_CMD_BUF_LAYOUT_NODE &node) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 157 | ImageSubresourcePair imgpair = {image, true, range}; |
| 158 | node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); |
| 159 | FindLayoutVerifyNode(device_data, pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); |
| 160 | FindLayoutVerifyNode(device_data, pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 161 | FindLayoutVerifyNode(device_data, pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 162 | FindLayoutVerifyNode(device_data, pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 163 | if (GetDeviceExtensions()->vk_khr_sampler_ycbcr_conversion) { |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 164 | FindLayoutVerifyNode(device_data, pCB, imgpair, node, VK_IMAGE_ASPECT_PLANE_0_BIT_KHR); |
| 165 | FindLayoutVerifyNode(device_data, pCB, imgpair, node, VK_IMAGE_ASPECT_PLANE_1_BIT_KHR); |
| 166 | FindLayoutVerifyNode(device_data, pCB, imgpair, node, VK_IMAGE_ASPECT_PLANE_2_BIT_KHR); |
| 167 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 168 | if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { |
| 169 | imgpair = {image, false, VkImageSubresource()}; |
| 170 | auto imgsubIt = pCB->imageLayoutMap.find(imgpair); |
| 171 | if (imgsubIt == pCB->imageLayoutMap.end()) return false; |
| 172 | // TODO: This is ostensibly a find function but it changes state here |
| 173 | node = imgsubIt->second; |
| 174 | } |
| 175 | return true; |
| 176 | } |
| 177 | |
| 178 | // Find layout(s) on the global level |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 179 | bool CoreChecks::FindGlobalLayout(layer_data *device_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 180 | layout = VK_IMAGE_LAYOUT_MAX_ENUM; |
| 181 | FindLayoutVerifyLayout(device_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); |
| 182 | FindLayoutVerifyLayout(device_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 183 | FindLayoutVerifyLayout(device_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 184 | FindLayoutVerifyLayout(device_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 185 | if (GetDeviceExtensions()->vk_khr_sampler_ycbcr_conversion) { |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 186 | FindLayoutVerifyLayout(device_data, imgpair, layout, VK_IMAGE_ASPECT_PLANE_0_BIT_KHR); |
| 187 | FindLayoutVerifyLayout(device_data, imgpair, layout, VK_IMAGE_ASPECT_PLANE_1_BIT_KHR); |
| 188 | FindLayoutVerifyLayout(device_data, imgpair, layout, VK_IMAGE_ASPECT_PLANE_2_BIT_KHR); |
| 189 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 190 | if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { |
| 191 | imgpair = {imgpair.image, false, VkImageSubresource()}; |
Mark Lobodzinski | 44d46d5 | 2019-03-07 11:04:06 -0700 | [diff] [blame] | 192 | auto imgsubIt = (*GetImageLayoutMap()).find(imgpair); |
| 193 | if (imgsubIt == (*GetImageLayoutMap()).end()) return false; |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 194 | layout = imgsubIt->second.layout; |
| 195 | } |
| 196 | return true; |
| 197 | } |
| 198 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 199 | bool CoreChecks::FindLayouts(layer_data *device_data, VkImage image, std::vector<VkImageLayout> &layouts) { |
Mark Lobodzinski | 44d46d5 | 2019-03-07 11:04:06 -0700 | [diff] [blame] | 200 | auto sub_data = (*GetImageSubresourceMap()).find(image); |
| 201 | if (sub_data == (*GetImageSubresourceMap()).end()) return false; |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 202 | auto image_state = GetImageState(image); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 203 | if (!image_state) return false; |
| 204 | bool ignoreGlobal = false; |
| 205 | // TODO: Make this robust for >1 aspect mask. Now it will just say ignore potential errors in this case. |
| 206 | if (sub_data->second.size() >= (image_state->createInfo.arrayLayers * image_state->createInfo.mipLevels + 1)) { |
| 207 | ignoreGlobal = true; |
| 208 | } |
| 209 | for (auto imgsubpair : sub_data->second) { |
| 210 | if (ignoreGlobal && !imgsubpair.hasSubresource) continue; |
Mark Lobodzinski | 44d46d5 | 2019-03-07 11:04:06 -0700 | [diff] [blame] | 211 | auto img_data = (*GetImageLayoutMap()).find(imgsubpair); |
| 212 | if (img_data != (*GetImageLayoutMap()).end()) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 213 | layouts.push_back(img_data->second.layout); |
| 214 | } |
| 215 | } |
| 216 | return true; |
| 217 | } |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 218 | |
| 219 | bool CoreChecks::FindLayout(const std::unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> &imageLayoutMap, |
| 220 | ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { |
Tony Barbour | df013b9 | 2017-01-25 12:53:48 -0700 | [diff] [blame] | 221 | if (!(imgpair.subresource.aspectMask & aspectMask)) { |
| 222 | return false; |
| 223 | } |
| 224 | imgpair.subresource.aspectMask = aspectMask; |
| 225 | auto imgsubIt = imageLayoutMap.find(imgpair); |
| 226 | if (imgsubIt == imageLayoutMap.end()) { |
| 227 | return false; |
| 228 | } |
| 229 | layout = imgsubIt->second.layout; |
| 230 | return true; |
Tony Barbour | e0c5cc9 | 2017-02-08 13:53:39 -0700 | [diff] [blame] | 231 | } |
Tony Barbour | df013b9 | 2017-01-25 12:53:48 -0700 | [diff] [blame] | 232 | |
| 233 | // find layout in supplied map |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 234 | bool CoreChecks::FindLayout(layer_data *device_data, |
| 235 | const std::unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> &imageLayoutMap, |
| 236 | ImageSubresourcePair imgpair, VkImageLayout &layout) { |
Tony Barbour | df013b9 | 2017-01-25 12:53:48 -0700 | [diff] [blame] | 237 | layout = VK_IMAGE_LAYOUT_MAX_ENUM; |
| 238 | FindLayout(imageLayoutMap, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); |
| 239 | FindLayout(imageLayoutMap, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 240 | FindLayout(imageLayoutMap, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 241 | FindLayout(imageLayoutMap, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 242 | if (GetDeviceExtensions()->vk_khr_sampler_ycbcr_conversion) { |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 243 | FindLayout(imageLayoutMap, imgpair, layout, VK_IMAGE_ASPECT_PLANE_0_BIT_KHR); |
| 244 | FindLayout(imageLayoutMap, imgpair, layout, VK_IMAGE_ASPECT_PLANE_1_BIT_KHR); |
| 245 | FindLayout(imageLayoutMap, imgpair, layout, VK_IMAGE_ASPECT_PLANE_2_BIT_KHR); |
| 246 | } |
| 247 | // Image+subresource not found, look for image handle w/o subresource |
Tony Barbour | df013b9 | 2017-01-25 12:53:48 -0700 | [diff] [blame] | 248 | if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { |
| 249 | imgpair = {imgpair.image, false, VkImageSubresource()}; |
| 250 | auto imgsubIt = imageLayoutMap.find(imgpair); |
| 251 | if (imgsubIt == imageLayoutMap.end()) return false; |
| 252 | layout = imgsubIt->second.layout; |
| 253 | } |
| 254 | return true; |
| 255 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 256 | |
| 257 | // Set the layout on the global level |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 258 | void CoreChecks::SetGlobalLayout(layer_data *device_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 259 | VkImage &image = imgpair.image; |
Mark Lobodzinski | 44d46d5 | 2019-03-07 11:04:06 -0700 | [diff] [blame] | 260 | auto &lmap = (*GetImageLayoutMap()); |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 261 | auto data = lmap.find(imgpair); |
| 262 | if (data != lmap.end()) { |
| 263 | data->second.layout = layout; // Update |
| 264 | } else { |
| 265 | lmap[imgpair].layout = layout; // Insert |
| 266 | } |
Mark Lobodzinski | 44d46d5 | 2019-03-07 11:04:06 -0700 | [diff] [blame] | 267 | auto &image_subresources = (*GetImageSubresourceMap())[image]; |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 268 | auto subresource = std::find(image_subresources.begin(), image_subresources.end(), imgpair); |
| 269 | if (subresource == image_subresources.end()) { |
| 270 | image_subresources.push_back(imgpair); |
| 271 | } |
| 272 | } |
| 273 | |
| 274 | // Set the layout on the cmdbuf level |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 275 | void CoreChecks::SetLayout(layer_data *device_data, GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, |
| 276 | const IMAGE_CMD_BUF_LAYOUT_NODE &node) { |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 277 | auto it = pCB->imageLayoutMap.find(imgpair); |
| 278 | if (it != pCB->imageLayoutMap.end()) { |
| 279 | it->second = node; // Update |
| 280 | } else { |
| 281 | pCB->imageLayoutMap[imgpair] = node; // Insert |
| 282 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 283 | } |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 284 | // Set image layout for given VkImageSubresourceRange struct |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 285 | void CoreChecks::SetImageLayout(layer_data *device_data, GLOBAL_CB_NODE *cb_node, const IMAGE_STATE *image_state, |
| 286 | VkImageSubresourceRange image_subresource_range, const VkImageLayout &layout) { |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 287 | assert(image_state); |
John Zulauf | 48a6a70 | 2017-12-22 17:14:54 -0700 | [diff] [blame] | 288 | cb_node->image_layout_change_count++; // Change the version of this data to force revalidation |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 289 | for (uint32_t level_index = 0; level_index < image_subresource_range.levelCount; ++level_index) { |
| 290 | uint32_t level = image_subresource_range.baseMipLevel + level_index; |
| 291 | for (uint32_t layer_index = 0; layer_index < image_subresource_range.layerCount; layer_index++) { |
| 292 | uint32_t layer = image_subresource_range.baseArrayLayer + layer_index; |
| 293 | VkImageSubresource sub = {image_subresource_range.aspectMask, level, layer}; |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 294 | // TODO: If ImageView was created with depth or stencil, transition both layouts as the aspectMask is ignored and both |
| 295 | // are used. Verify that the extra implicit layout is OK for descriptor set layout validation |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 296 | if (image_subresource_range.aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 297 | if (FormatIsDepthAndStencil(image_state->createInfo.format)) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 298 | sub.aspectMask |= (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); |
| 299 | } |
| 300 | } |
Tony-LunarG | 119b38a | 2018-12-18 09:49:16 -0700 | [diff] [blame] | 301 | // For multiplane images, IMAGE_ASPECT_COLOR is an alias for all of the plane bits |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 302 | if (GetDeviceExtensions()->vk_khr_sampler_ycbcr_conversion) { |
Tony-LunarG | 119b38a | 2018-12-18 09:49:16 -0700 | [diff] [blame] | 303 | if (FormatIsMultiplane(image_state->createInfo.format)) { |
| 304 | if (sub.aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { |
| 305 | sub.aspectMask &= ~VK_IMAGE_ASPECT_COLOR_BIT; |
| 306 | sub.aspectMask |= VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR; |
| 307 | if (FormatPlaneCount(image_state->createInfo.format) > 2) { |
| 308 | sub.aspectMask |= VK_IMAGE_ASPECT_PLANE_2_BIT_KHR; |
| 309 | } |
| 310 | } |
| 311 | } |
| 312 | } |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 313 | SetLayout(device_data, cb_node, image_state->image, sub, layout); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 314 | } |
| 315 | } |
| 316 | } |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 317 | // Set image layout for given VkImageSubresourceLayers struct |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 318 | void CoreChecks::SetImageLayout(layer_data *device_data, GLOBAL_CB_NODE *cb_node, const IMAGE_STATE *image_state, |
| 319 | VkImageSubresourceLayers image_subresource_layers, const VkImageLayout &layout) { |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 320 | // Transfer VkImageSubresourceLayers into VkImageSubresourceRange struct |
| 321 | VkImageSubresourceRange image_subresource_range; |
| 322 | image_subresource_range.aspectMask = image_subresource_layers.aspectMask; |
| 323 | image_subresource_range.baseArrayLayer = image_subresource_layers.baseArrayLayer; |
| 324 | image_subresource_range.layerCount = image_subresource_layers.layerCount; |
| 325 | image_subresource_range.baseMipLevel = image_subresource_layers.mipLevel; |
| 326 | image_subresource_range.levelCount = 1; |
| 327 | SetImageLayout(device_data, cb_node, image_state, image_subresource_range, layout); |
| 328 | } |
Dave Houlton | ddd65c5 | 2018-05-08 14:58:01 -0600 | [diff] [blame] | 329 | |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 330 | // Set image layout for all slices of an image view |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 331 | void CoreChecks::SetImageViewLayout(layer_data *device_data, GLOBAL_CB_NODE *cb_node, IMAGE_VIEW_STATE *view_state, |
| 332 | const VkImageLayout &layout) { |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 333 | assert(view_state); |
| 334 | |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 335 | IMAGE_STATE *image_state = GetImageState(view_state->create_info.image); |
Dave Houlton | ddd65c5 | 2018-05-08 14:58:01 -0600 | [diff] [blame] | 336 | VkImageSubresourceRange sub_range = view_state->create_info.subresourceRange; |
| 337 | |
| 338 | // When changing the layout of a 3D image subresource via a 2D or 2D_ARRRAY image view, all depth slices of |
| 339 | // the subresource mip level(s) are transitioned, ignoring any layers restriction in the subresource info. |
| 340 | if ((image_state->createInfo.imageType == VK_IMAGE_TYPE_3D) && (view_state->create_info.viewType != VK_IMAGE_VIEW_TYPE_3D)) { |
| 341 | sub_range.baseArrayLayer = 0; |
| 342 | sub_range.layerCount = image_state->createInfo.extent.depth; |
| 343 | } |
| 344 | |
| 345 | SetImageLayout(device_data, cb_node, image_state, sub_range, layout); |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 346 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 347 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 348 | void CoreChecks::SetImageViewLayout(layer_data *device_data, GLOBAL_CB_NODE *cb_node, VkImageView imageView, |
| 349 | const VkImageLayout &layout) { |
Mark Lobodzinski | a3a230b | 2019-03-06 15:35:13 -0700 | [diff] [blame] | 350 | auto view_state = GetImageViewState(imageView); |
John Zulauf | 4ccf5c0 | 2018-09-21 11:46:18 -0600 | [diff] [blame] | 351 | SetImageViewLayout(device_data, cb_node, view_state, layout); |
| 352 | } |
| 353 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 354 | bool CoreChecks::ValidateRenderPassLayoutAgainstFramebufferImageUsage(layer_data *device_data, RenderPassCreateVersion rp_version, |
| 355 | VkImageLayout layout, VkImage image, VkImageView image_view, |
| 356 | VkFramebuffer framebuffer, VkRenderPass renderpass, |
| 357 | uint32_t attachment_index, const char *variable_name) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 358 | bool skip = false; |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 359 | const auto report_data = GetReportData(device_data); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 360 | auto image_state = GetImageState(image); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 361 | const char *vuid; |
| 362 | const bool use_rp2 = (rp_version == RENDER_PASS_VERSION_2); |
| 363 | |
| 364 | if (!image_state) { |
| 365 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), |
| 366 | "VUID-VkRenderPassBeginInfo-framebuffer-parameter", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 367 | "Render Pass begin with renderpass %s uses framebuffer %s where pAttachments[%" PRIu32 |
| 368 | "] = image view %s, which refers to an invalid image", |
| 369 | report_data->FormatHandle(renderpass).c_str(), report_data->FormatHandle(framebuffer).c_str(), |
| 370 | attachment_index, report_data->FormatHandle(image_view).c_str()); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 371 | return skip; |
| 372 | } |
| 373 | |
| 374 | auto image_usage = image_state->createInfo.usage; |
| 375 | |
| 376 | // Check for layouts that mismatch image usages in the framebuffer |
| 377 | if (layout == VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL && !(image_usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT)) { |
| 378 | vuid = use_rp2 ? "VUID-vkCmdBeginRenderPass2KHR-initialLayout-03094" : "VUID-vkCmdBeginRenderPass-initialLayout-00895"; |
| 379 | skip |= |
| 380 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), vuid, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 381 | "Layout/usage mismatch for attachment %u in render pass %s" |
| 382 | " - the %s is %s but the image attached to framebuffer %s via image view %s" |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 383 | " was not created with VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 384 | attachment_index, report_data->FormatHandle(framebuffer).c_str(), variable_name, string_VkImageLayout(layout), |
| 385 | report_data->FormatHandle(renderpass).c_str(), report_data->FormatHandle(image_view).c_str()); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 386 | } |
| 387 | |
| 388 | if (layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL && |
| 389 | !(image_usage & (VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT | VK_IMAGE_USAGE_SAMPLED_BIT))) { |
| 390 | vuid = use_rp2 ? "VUID-vkCmdBeginRenderPass2KHR-initialLayout-03097" : "VUID-vkCmdBeginRenderPass-initialLayout-00897"; |
| 391 | skip |= |
| 392 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), vuid, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 393 | "Layout/usage mismatch for attachment %u in render pass %s" |
| 394 | " - the %s is %s but the image attached to framebuffer %s via image view %s" |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 395 | " was not created with VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT or VK_IMAGE_USAGE_SAMPLED_BIT", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 396 | attachment_index, report_data->FormatHandle(framebuffer).c_str(), variable_name, string_VkImageLayout(layout), |
| 397 | report_data->FormatHandle(renderpass).c_str(), report_data->FormatHandle(image_view).c_str()); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 398 | } |
| 399 | |
| 400 | if (layout == VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL && !(image_usage & VK_IMAGE_USAGE_TRANSFER_SRC_BIT)) { |
| 401 | vuid = use_rp2 ? "VUID-vkCmdBeginRenderPass2KHR-initialLayout-03098" : "VUID-vkCmdBeginRenderPass-initialLayout-00898"; |
| 402 | skip |= |
| 403 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), vuid, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 404 | "Layout/usage mismatch for attachment %u in render pass %s" |
| 405 | " - the %s is %s but the image attached to framebuffer %s via image view %s" |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 406 | " was not created with VK_IMAGE_USAGE_TRANSFER_SRC_BIT", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 407 | attachment_index, report_data->FormatHandle(framebuffer).c_str(), variable_name, string_VkImageLayout(layout), |
| 408 | report_data->FormatHandle(renderpass).c_str(), report_data->FormatHandle(image_view).c_str()); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 409 | } |
| 410 | |
| 411 | if (layout == VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL && !(image_usage & VK_IMAGE_USAGE_TRANSFER_DST_BIT)) { |
| 412 | vuid = use_rp2 ? "VUID-vkCmdBeginRenderPass2KHR-initialLayout-03099" : "VUID-vkCmdBeginRenderPass-initialLayout-00899"; |
| 413 | skip |= |
| 414 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), vuid, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 415 | "Layout/usage mismatch for attachment %u in render pass %s" |
| 416 | " - the %s is %s but the image attached to framebuffer %s via image view %s" |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 417 | " was not created with VK_IMAGE_USAGE_TRANSFER_DST_BIT", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 418 | attachment_index, report_data->FormatHandle(framebuffer).c_str(), variable_name, string_VkImageLayout(layout), |
| 419 | report_data->FormatHandle(renderpass).c_str(), report_data->FormatHandle(image_view).c_str()); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 420 | } |
| 421 | |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 422 | if (GetDeviceExtensions()->vk_khr_maintenance2) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 423 | if ((layout == VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL || |
| 424 | layout == VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL || |
| 425 | layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL || |
| 426 | layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) && |
| 427 | !(image_usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { |
| 428 | vuid = use_rp2 ? "VUID-vkCmdBeginRenderPass2KHR-initialLayout-03096" : "VUID-vkCmdBeginRenderPass-initialLayout-01758"; |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 429 | skip |= log_msg( |
| 430 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), vuid, |
| 431 | "Layout/usage mismatch for attachment %u in render pass %s" |
| 432 | " - the %s is %s but the image attached to framebuffer %s via image view %s" |
| 433 | " was not created with VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT", |
| 434 | attachment_index, report_data->FormatHandle(framebuffer).c_str(), variable_name, string_VkImageLayout(layout), |
| 435 | report_data->FormatHandle(renderpass).c_str(), report_data->FormatHandle(image_view).c_str()); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 436 | } |
| 437 | } else { |
| 438 | // The create render pass 2 extension requires maintenance 2 (the previous branch), so no vuid switch needed here. |
| 439 | if ((layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL || |
| 440 | layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) && |
| 441 | !(image_usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { |
| 442 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 443 | HandleToUint64(image), "VUID-vkCmdBeginRenderPass-initialLayout-00896", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 444 | "Layout/usage mismatch for attachment %u in render pass %s" |
| 445 | " - the %s is %s but the image attached to framebuffer %s via image view %s" |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 446 | " was not created with VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 447 | attachment_index, report_data->FormatHandle(framebuffer).c_str(), variable_name, |
| 448 | string_VkImageLayout(layout), report_data->FormatHandle(renderpass).c_str(), |
| 449 | report_data->FormatHandle(image_view).c_str()); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 450 | } |
| 451 | } |
| 452 | return skip; |
| 453 | } |
| 454 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 455 | bool CoreChecks::VerifyFramebufferAndRenderPassLayouts(layer_data *device_data, RenderPassCreateVersion rp_version, |
| 456 | GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, |
| 457 | const FRAMEBUFFER_STATE *framebuffer_state) { |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 458 | bool skip = false; |
Mark Lobodzinski | 2e49588 | 2019-03-06 16:11:56 -0700 | [diff] [blame] | 459 | auto const pRenderPassInfo = GetRenderPassState(pRenderPassBegin->renderPass)->createInfo.ptr(); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 460 | auto const &framebufferInfo = framebuffer_state->createInfo; |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 461 | |
Mark Lobodzinski | 2e49588 | 2019-03-06 16:11:56 -0700 | [diff] [blame] | 462 | auto render_pass = GetRenderPassState(pRenderPassBegin->renderPass)->renderPass; |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 463 | auto framebuffer = framebuffer_state->framebuffer; |
| 464 | |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 465 | if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 466 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 467 | HandleToUint64(pCB->commandBuffer), kVUID_Core_DrawState_InvalidRenderpass, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 468 | "You cannot start a render pass using a framebuffer with a different number of attachments."); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 469 | } |
| 470 | for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { |
| 471 | const VkImageView &image_view = framebufferInfo.pAttachments[i]; |
Mark Lobodzinski | a3a230b | 2019-03-06 15:35:13 -0700 | [diff] [blame] | 472 | auto view_state = GetImageViewState(image_view); |
John Zulauf | 8e30829 | 2018-09-21 11:34:37 -0600 | [diff] [blame] | 473 | |
| 474 | if (!view_state) { |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 475 | skip |= |
| 476 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, |
| 477 | HandleToUint64(pRenderPassBegin->renderPass), "VUID-VkRenderPassBeginInfo-framebuffer-parameter", |
| 478 | "vkCmdBeginRenderPass(): framebuffer %s pAttachments[%" PRIu32 "] = %s is not a valid VkImageView handle", |
| 479 | report_data->FormatHandle(framebuffer_state->framebuffer).c_str(), i, |
| 480 | report_data->FormatHandle(image_view).c_str()); |
John Zulauf | 8e30829 | 2018-09-21 11:34:37 -0600 | [diff] [blame] | 481 | continue; |
| 482 | } |
| 483 | |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 484 | const VkImage &image = view_state->create_info.image; |
| 485 | const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; |
Tobin Ehlis | 0d4274b | 2017-02-17 15:17:04 -0700 | [diff] [blame] | 486 | auto initial_layout = pRenderPassInfo->pAttachments[i].initialLayout; |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 487 | auto final_layout = pRenderPassInfo->pAttachments[i].finalLayout; |
| 488 | |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 489 | // TODO: Do not iterate over every possibility - consolidate where possible |
| 490 | for (uint32_t j = 0; j < subRange.levelCount; j++) { |
| 491 | uint32_t level = subRange.baseMipLevel + j; |
| 492 | for (uint32_t k = 0; k < subRange.layerCount; k++) { |
| 493 | uint32_t layer = subRange.baseArrayLayer + k; |
| 494 | VkImageSubresource sub = {subRange.aspectMask, level, layer}; |
| 495 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
| 496 | if (!FindCmdBufLayout(device_data, pCB, image, sub, node)) { |
Tobin Ehlis | 0d4274b | 2017-02-17 15:17:04 -0700 | [diff] [blame] | 497 | // Missing layouts will be added during state update |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 498 | continue; |
| 499 | } |
Tobin Ehlis | 0d4274b | 2017-02-17 15:17:04 -0700 | [diff] [blame] | 500 | if (initial_layout != VK_IMAGE_LAYOUT_UNDEFINED && initial_layout != node.layout) { |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 501 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 502 | kVUID_Core_DrawState_InvalidRenderpass, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 503 | "You cannot start a render pass using attachment %u where the render pass initial layout is %s " |
| 504 | "and the previous known layout of the attachment is %s. The layouts must match, or the render " |
| 505 | "pass initial layout for the attachment must be VK_IMAGE_LAYOUT_UNDEFINED", |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 506 | i, string_VkImageLayout(initial_layout), string_VkImageLayout(node.layout)); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 507 | } |
| 508 | } |
| 509 | } |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 510 | |
| 511 | ValidateRenderPassLayoutAgainstFramebufferImageUsage(device_data, rp_version, initial_layout, image, image_view, |
| 512 | framebuffer, render_pass, i, "initial layout"); |
| 513 | |
| 514 | ValidateRenderPassLayoutAgainstFramebufferImageUsage(device_data, rp_version, final_layout, image, image_view, framebuffer, |
| 515 | render_pass, i, "final layout"); |
| 516 | } |
| 517 | |
| 518 | for (uint32_t j = 0; j < pRenderPassInfo->subpassCount; ++j) { |
| 519 | auto &subpass = pRenderPassInfo->pSubpasses[j]; |
| 520 | for (uint32_t k = 0; k < pRenderPassInfo->pSubpasses[j].inputAttachmentCount; ++k) { |
| 521 | auto &attachment_ref = subpass.pInputAttachments[k]; |
| 522 | if (attachment_ref.attachment != VK_ATTACHMENT_UNUSED) { |
| 523 | auto image_view = framebufferInfo.pAttachments[attachment_ref.attachment]; |
Mark Lobodzinski | a3a230b | 2019-03-06 15:35:13 -0700 | [diff] [blame] | 524 | auto view_state = GetImageViewState(image_view); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 525 | |
| 526 | if (view_state) { |
| 527 | auto image = view_state->create_info.image; |
| 528 | ValidateRenderPassLayoutAgainstFramebufferImageUsage(device_data, rp_version, attachment_ref.layout, image, |
| 529 | image_view, framebuffer, render_pass, |
| 530 | attachment_ref.attachment, "input attachment layout"); |
| 531 | } |
| 532 | } |
| 533 | } |
| 534 | |
| 535 | for (uint32_t k = 0; k < pRenderPassInfo->pSubpasses[j].colorAttachmentCount; ++k) { |
| 536 | auto &attachment_ref = subpass.pColorAttachments[k]; |
| 537 | if (attachment_ref.attachment != VK_ATTACHMENT_UNUSED) { |
| 538 | auto image_view = framebufferInfo.pAttachments[attachment_ref.attachment]; |
Mark Lobodzinski | a3a230b | 2019-03-06 15:35:13 -0700 | [diff] [blame] | 539 | auto view_state = GetImageViewState(image_view); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 540 | |
| 541 | if (view_state) { |
| 542 | auto image = view_state->create_info.image; |
| 543 | ValidateRenderPassLayoutAgainstFramebufferImageUsage(device_data, rp_version, attachment_ref.layout, image, |
| 544 | image_view, framebuffer, render_pass, |
| 545 | attachment_ref.attachment, "color attachment layout"); |
| 546 | if (subpass.pResolveAttachments) { |
| 547 | ValidateRenderPassLayoutAgainstFramebufferImageUsage( |
| 548 | device_data, rp_version, attachment_ref.layout, image, image_view, framebuffer, render_pass, |
| 549 | attachment_ref.attachment, "resolve attachment layout"); |
| 550 | } |
| 551 | } |
| 552 | } |
| 553 | } |
| 554 | |
| 555 | if (pRenderPassInfo->pSubpasses[j].pDepthStencilAttachment) { |
| 556 | auto &attachment_ref = *subpass.pDepthStencilAttachment; |
| 557 | if (attachment_ref.attachment != VK_ATTACHMENT_UNUSED) { |
| 558 | auto image_view = framebufferInfo.pAttachments[attachment_ref.attachment]; |
Mark Lobodzinski | a3a230b | 2019-03-06 15:35:13 -0700 | [diff] [blame] | 559 | auto view_state = GetImageViewState(image_view); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 560 | |
| 561 | if (view_state) { |
| 562 | auto image = view_state->create_info.image; |
| 563 | ValidateRenderPassLayoutAgainstFramebufferImageUsage(device_data, rp_version, attachment_ref.layout, image, |
| 564 | image_view, framebuffer, render_pass, |
| 565 | attachment_ref.attachment, "input attachment layout"); |
| 566 | } |
| 567 | } |
| 568 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 569 | } |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 570 | return skip; |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 571 | } |
| 572 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 573 | void CoreChecks::TransitionAttachmentRefLayout(layer_data *device_data, GLOBAL_CB_NODE *pCB, FRAMEBUFFER_STATE *pFramebuffer, |
| 574 | const safe_VkAttachmentReference2KHR &ref) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 575 | if (ref.attachment != VK_ATTACHMENT_UNUSED) { |
Mark Lobodzinski | a3a230b | 2019-03-06 15:35:13 -0700 | [diff] [blame] | 576 | auto image_view = GetAttachmentImageViewState(pFramebuffer, ref.attachment); |
John Zulauf | 8e30829 | 2018-09-21 11:34:37 -0600 | [diff] [blame] | 577 | if (image_view) { |
| 578 | SetImageViewLayout(device_data, pCB, image_view, ref.layout); |
| 579 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 580 | } |
| 581 | } |
| 582 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 583 | void CoreChecks::TransitionSubpassLayouts(layer_data *device_data, GLOBAL_CB_NODE *pCB, const RENDER_PASS_STATE *render_pass_state, |
| 584 | const int subpass_index, FRAMEBUFFER_STATE *framebuffer_state) { |
Tobin Ehlis | 0d4274b | 2017-02-17 15:17:04 -0700 | [diff] [blame] | 585 | assert(render_pass_state); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 586 | |
| 587 | if (framebuffer_state) { |
Tobin Ehlis | 0d4274b | 2017-02-17 15:17:04 -0700 | [diff] [blame] | 588 | auto const &subpass = render_pass_state->createInfo.pSubpasses[subpass_index]; |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 589 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| 590 | TransitionAttachmentRefLayout(device_data, pCB, framebuffer_state, subpass.pInputAttachments[j]); |
| 591 | } |
| 592 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 593 | TransitionAttachmentRefLayout(device_data, pCB, framebuffer_state, subpass.pColorAttachments[j]); |
| 594 | } |
| 595 | if (subpass.pDepthStencilAttachment) { |
| 596 | TransitionAttachmentRefLayout(device_data, pCB, framebuffer_state, *subpass.pDepthStencilAttachment); |
| 597 | } |
| 598 | } |
| 599 | } |
| 600 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 601 | bool CoreChecks::ValidateImageAspectLayout(layer_data *device_data, GLOBAL_CB_NODE const *pCB, |
| 602 | const VkImageMemoryBarrier *mem_barrier, uint32_t level, uint32_t layer, |
| 603 | VkImageAspectFlags aspect) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 604 | if (!(mem_barrier->subresourceRange.aspectMask & aspect)) { |
| 605 | return false; |
| 606 | } |
| 607 | VkImageSubresource sub = {aspect, level, layer}; |
| 608 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
| 609 | if (!FindCmdBufLayout(device_data, pCB, mem_barrier->image, sub, node)) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 610 | return false; |
| 611 | } |
| 612 | bool skip = false; |
| 613 | if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { |
| 614 | // TODO: Set memory invalid which is in mem_tracker currently |
| 615 | } else if (node.layout != mem_barrier->oldLayout) { |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 616 | skip = log_msg( |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 617 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 618 | HandleToUint64(pCB->commandBuffer), "VUID-VkImageMemoryBarrier-oldLayout-01197", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 619 | "For image %s you cannot transition the layout of aspect=%d level=%d layer=%d from %s when current layout is %s.", |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 620 | report_data->FormatHandle(mem_barrier->image).c_str(), aspect, level, layer, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 621 | string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 622 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 623 | return skip; |
| 624 | } |
| 625 | |
Tobin Ehlis | 0d4274b | 2017-02-17 15:17:04 -0700 | [diff] [blame] | 626 | // Transition the layout state for renderpass attachments based on the BeginRenderPass() call. This includes: |
| 627 | // 1. Transition into initialLayout state |
| 628 | // 2. Transition from initialLayout to layout used in subpass 0 |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 629 | void CoreChecks::TransitionBeginRenderPassLayouts(layer_data *device_data, GLOBAL_CB_NODE *cb_state, |
| 630 | const RENDER_PASS_STATE *render_pass_state, |
| 631 | FRAMEBUFFER_STATE *framebuffer_state) { |
Tobin Ehlis | 0d4274b | 2017-02-17 15:17:04 -0700 | [diff] [blame] | 632 | // First transition into initialLayout |
| 633 | auto const rpci = render_pass_state->createInfo.ptr(); |
| 634 | for (uint32_t i = 0; i < rpci->attachmentCount; ++i) { |
Mark Lobodzinski | a3a230b | 2019-03-06 15:35:13 -0700 | [diff] [blame] | 635 | auto view_state = GetAttachmentImageViewState(framebuffer_state, i); |
John Zulauf | 8e30829 | 2018-09-21 11:34:37 -0600 | [diff] [blame] | 636 | if (view_state) { |
| 637 | SetImageViewLayout(device_data, cb_state, view_state, rpci->pAttachments[i].initialLayout); |
| 638 | } |
Tobin Ehlis | 0d4274b | 2017-02-17 15:17:04 -0700 | [diff] [blame] | 639 | } |
| 640 | // Now transition for first subpass (index 0) |
| 641 | TransitionSubpassLayouts(device_data, cb_state, render_pass_state, 0, framebuffer_state); |
| 642 | } |
| 643 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 644 | void CoreChecks::TransitionImageAspectLayout(layer_data *device_data, GLOBAL_CB_NODE *pCB, const VkImageMemoryBarrier *mem_barrier, |
| 645 | uint32_t level, uint32_t layer, VkImageAspectFlags aspect_mask, |
| 646 | VkImageAspectFlags aspect) { |
Tony-LunarG | 0d27b30 | 2018-10-08 09:26:21 -0600 | [diff] [blame] | 647 | if (!(aspect_mask & aspect)) { |
Mark Lobodzinski | 6b6c50a | 2017-02-27 12:56:14 -0700 | [diff] [blame] | 648 | return; |
| 649 | } |
| 650 | VkImageSubresource sub = {aspect, level, layer}; |
| 651 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
| 652 | if (!FindCmdBufLayout(device_data, pCB, mem_barrier->image, sub, node)) { |
John Zulauf | 48a6a70 | 2017-12-22 17:14:54 -0700 | [diff] [blame] | 653 | pCB->image_layout_change_count++; // Change the version of this data to force revalidation |
Mark Lobodzinski | 6b6c50a | 2017-02-27 12:56:14 -0700 | [diff] [blame] | 654 | SetLayout(device_data, pCB, mem_barrier->image, sub, |
| 655 | IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); |
| 656 | return; |
| 657 | } |
| 658 | if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { |
| 659 | // TODO: Set memory invalid |
| 660 | } |
| 661 | SetLayout(device_data, pCB, mem_barrier->image, sub, mem_barrier->newLayout); |
| 662 | } |
| 663 | |
Dave Houlton | 10b3948 | 2017-03-16 13:18:15 -0600 | [diff] [blame] | 664 | bool VerifyAspectsPresent(VkImageAspectFlags aspect_mask, VkFormat format) { |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 665 | if ((aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) != 0) { |
Dave Houlton | e2fca55 | 2018-04-05 16:20:33 -0600 | [diff] [blame] | 666 | if (!(FormatIsColor(format) || FormatIsMultiplane(format))) return false; |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 667 | } |
| 668 | if ((aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) != 0) { |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 669 | if (!FormatHasDepth(format)) return false; |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 670 | } |
| 671 | if ((aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) != 0) { |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 672 | if (!FormatHasStencil(format)) return false; |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 673 | } |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 674 | if (0 != |
| 675 | (aspect_mask & (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR))) { |
| 676 | if (FormatPlaneCount(format) == 1) return false; |
| 677 | } |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 678 | return true; |
| 679 | } |
| 680 | |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 681 | // Verify an ImageMemoryBarrier's old/new ImageLayouts are compatible with the Image's ImageUsageFlags. |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 682 | bool CoreChecks::ValidateBarrierLayoutToImageUsage(layer_data *device_data, const VkImageMemoryBarrier *img_barrier, |
| 683 | bool new_not_old, VkImageUsageFlags usage_flags, const char *func_name) { |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 684 | bool skip = false; |
| 685 | const VkImageLayout layout = (new_not_old) ? img_barrier->newLayout : img_barrier->oldLayout; |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 686 | const char *msg_code = kVUIDUndefined; // sentinel value meaning "no error" |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 687 | |
| 688 | switch (layout) { |
| 689 | case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: |
| 690 | if ((usage_flags & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) == 0) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 691 | msg_code = "VUID-VkImageMemoryBarrier-oldLayout-01208"; |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 692 | } |
| 693 | break; |
| 694 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: |
| 695 | if ((usage_flags & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 696 | msg_code = "VUID-VkImageMemoryBarrier-oldLayout-01209"; |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 697 | } |
| 698 | break; |
| 699 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: |
| 700 | if ((usage_flags & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) == 0) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 701 | msg_code = "VUID-VkImageMemoryBarrier-oldLayout-01210"; |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 702 | } |
| 703 | break; |
| 704 | case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: |
| 705 | if ((usage_flags & (VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT)) == 0) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 706 | msg_code = "VUID-VkImageMemoryBarrier-oldLayout-01211"; |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 707 | } |
| 708 | break; |
| 709 | case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: |
| 710 | if ((usage_flags & VK_IMAGE_USAGE_TRANSFER_SRC_BIT) == 0) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 711 | msg_code = "VUID-VkImageMemoryBarrier-oldLayout-01212"; |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 712 | } |
| 713 | break; |
| 714 | case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: |
| 715 | if ((usage_flags & VK_IMAGE_USAGE_TRANSFER_DST_BIT) == 0) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 716 | msg_code = "VUID-VkImageMemoryBarrier-oldLayout-01213"; |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 717 | } |
| 718 | break; |
Dave Houlton | 142c4cb | 2018-10-17 15:04:41 -0600 | [diff] [blame] | 719 | case VK_IMAGE_LAYOUT_SHADING_RATE_OPTIMAL_NV: |
Jeff Bolz | 9af91c5 | 2018-09-01 21:53:57 -0500 | [diff] [blame] | 720 | if ((usage_flags & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) == 0) { |
| 721 | msg_code = "VUID-VkImageMemoryBarrier-oldLayout-02088"; |
| 722 | } |
| 723 | break; |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 724 | default: |
| 725 | // Other VkImageLayout values do not have VUs defined in this context. |
| 726 | break; |
| 727 | } |
| 728 | |
Dave Houlton | 8e9f654 | 2018-05-18 12:18:22 -0600 | [diff] [blame] | 729 | if (msg_code != kVUIDUndefined) { |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 730 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 731 | HandleToUint64(img_barrier->image), msg_code, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 732 | "%s: Image barrier 0x%p %sLayout=%s is not compatible with image %s usage flags 0x%" PRIx32 ".", func_name, |
| 733 | static_cast<const void *>(img_barrier), ((new_not_old) ? "new" : "old"), string_VkImageLayout(layout), |
| 734 | report_data->FormatHandle(img_barrier->image).c_str(), usage_flags); |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 735 | } |
| 736 | return skip; |
| 737 | } |
| 738 | |
John Zulauf | 463c51e | 2018-05-31 13:29:20 -0600 | [diff] [blame] | 739 | // Scoreboard for checking for duplicate and inconsistent barriers to images |
| 740 | struct ImageBarrierScoreboardEntry { |
| 741 | uint32_t index; |
| 742 | // This is designed for temporary storage within the scope of the API call. If retained storage of the barriers is |
| 743 | // required, copies should be made and smart or unique pointers used in some other stucture (or this one refactored) |
| 744 | const VkImageMemoryBarrier *barrier; |
| 745 | }; |
| 746 | using ImageBarrierScoreboardSubresMap = std::unordered_map<VkImageSubresourceRange, ImageBarrierScoreboardEntry>; |
| 747 | using ImageBarrierScoreboardImageMap = std::unordered_map<VkImage, ImageBarrierScoreboardSubresMap>; |
| 748 | |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 749 | // Verify image barriers are compatible with the images they reference. |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 750 | bool CoreChecks::ValidateBarriersToImages(layer_data *device_data, GLOBAL_CB_NODE const *cb_state, uint32_t imageMemoryBarrierCount, |
| 751 | const VkImageMemoryBarrier *pImageMemoryBarriers, const char *func_name) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 752 | bool skip = false; |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 753 | |
John Zulauf | 463c51e | 2018-05-31 13:29:20 -0600 | [diff] [blame] | 754 | // Scoreboard for duplicate layout transition barriers within the list |
| 755 | // Pointers retained in the scoreboard only have the lifetime of *this* call (i.e. within the scope of the API call) |
| 756 | ImageBarrierScoreboardImageMap layout_transitions; |
| 757 | |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 758 | for (uint32_t i = 0; i < imageMemoryBarrierCount; ++i) { |
| 759 | auto img_barrier = &pImageMemoryBarriers[i]; |
| 760 | if (!img_barrier) continue; |
| 761 | |
John Zulauf | 463c51e | 2018-05-31 13:29:20 -0600 | [diff] [blame] | 762 | // Update the scoreboard of layout transitions and check for barriers affecting the same image and subresource |
| 763 | // TODO: a higher precision could be gained by adapting the command_buffer image_layout_map logic looking for conflicts |
| 764 | // at a per sub-resource level |
| 765 | if (img_barrier->oldLayout != img_barrier->newLayout) { |
| 766 | ImageBarrierScoreboardEntry new_entry{i, img_barrier}; |
| 767 | auto image_it = layout_transitions.find(img_barrier->image); |
| 768 | if (image_it != layout_transitions.end()) { |
| 769 | auto &subres_map = image_it->second; |
| 770 | auto subres_it = subres_map.find(img_barrier->subresourceRange); |
| 771 | if (subres_it != subres_map.end()) { |
| 772 | auto &entry = subres_it->second; |
| 773 | if ((entry.barrier->newLayout != img_barrier->oldLayout) && |
| 774 | (img_barrier->oldLayout != VK_IMAGE_LAYOUT_UNDEFINED)) { |
| 775 | const VkImageSubresourceRange &range = img_barrier->subresourceRange; |
| 776 | skip = log_msg( |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 777 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 778 | HandleToUint64(cb_state->commandBuffer), "VUID-VkImageMemoryBarrier-oldLayout-01197", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 779 | "%s: pImageMemoryBarrier[%u] conflicts with earlier entry pImageMemoryBarrier[%u]. Image %s" |
John Zulauf | 463c51e | 2018-05-31 13:29:20 -0600 | [diff] [blame] | 780 | " subresourceRange: aspectMask=%u baseMipLevel=%u levelCount=%u, baseArrayLayer=%u, layerCount=%u; " |
| 781 | "conflicting barrier transitions image layout from %s when earlier barrier transitioned to layout %s.", |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 782 | func_name, i, entry.index, report_data->FormatHandle(img_barrier->image).c_str(), range.aspectMask, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 783 | range.baseMipLevel, range.levelCount, range.baseArrayLayer, range.layerCount, |
| 784 | string_VkImageLayout(img_barrier->oldLayout), string_VkImageLayout(entry.barrier->newLayout)); |
John Zulauf | 463c51e | 2018-05-31 13:29:20 -0600 | [diff] [blame] | 785 | } |
| 786 | entry = new_entry; |
| 787 | } else { |
| 788 | subres_map[img_barrier->subresourceRange] = new_entry; |
| 789 | } |
| 790 | } else { |
| 791 | layout_transitions[img_barrier->image][img_barrier->subresourceRange] = new_entry; |
| 792 | } |
| 793 | } |
| 794 | |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 795 | auto image_state = GetImageState(img_barrier->image); |
Tobin Ehlis | bb03e5f | 2017-05-11 08:52:51 -0600 | [diff] [blame] | 796 | if (image_state) { |
| 797 | VkImageUsageFlags usage_flags = image_state->createInfo.usage; |
| 798 | skip |= ValidateBarrierLayoutToImageUsage(device_data, img_barrier, false, usage_flags, func_name); |
| 799 | skip |= ValidateBarrierLayoutToImageUsage(device_data, img_barrier, true, usage_flags, func_name); |
| 800 | |
| 801 | // Make sure layout is able to be transitioned, currently only presented shared presentable images are locked |
| 802 | if (image_state->layout_locked) { |
| 803 | // TODO: Add unique id for error when available |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 804 | skip |= log_msg( |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 805 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 806 | HandleToUint64(img_barrier->image), 0, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 807 | "Attempting to transition shared presentable image %s" |
Tobin Ehlis | bb03e5f | 2017-05-11 08:52:51 -0600 | [diff] [blame] | 808 | " from layout %s to layout %s, but image has already been presented and cannot have its layout transitioned.", |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 809 | report_data->FormatHandle(img_barrier->image).c_str(), string_VkImageLayout(img_barrier->oldLayout), |
| 810 | string_VkImageLayout(img_barrier->newLayout)); |
Tobin Ehlis | bb03e5f | 2017-05-11 08:52:51 -0600 | [diff] [blame] | 811 | } |
| 812 | } |
| 813 | |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 814 | VkImageCreateInfo *image_create_info = &(GetImageState(img_barrier->image)->createInfo); |
Tobin Ehlis | 7ee9cbd | 2017-04-26 16:51:48 -0600 | [diff] [blame] | 815 | // For a Depth/Stencil image both aspects MUST be set |
| 816 | if (FormatIsDepthAndStencil(image_create_info->format)) { |
| 817 | auto const aspect_mask = img_barrier->subresourceRange.aspectMask; |
| 818 | auto const ds_mask = VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT; |
| 819 | if ((aspect_mask & ds_mask) != (ds_mask)) { |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 820 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 821 | HandleToUint64(img_barrier->image), "VUID-VkImageMemoryBarrier-image-01207", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 822 | "%s: Image barrier 0x%p references image %s of format %s that must have the depth and stencil " |
| 823 | "aspects set, but its aspectMask is 0x%" PRIx32 ".", |
| 824 | func_name, static_cast<const void *>(img_barrier), |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 825 | report_data->FormatHandle(img_barrier->image).c_str(), string_VkFormat(image_create_info->format), |
| 826 | aspect_mask); |
Tobin Ehlis | 7ee9cbd | 2017-04-26 16:51:48 -0600 | [diff] [blame] | 827 | } |
| 828 | } |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 829 | uint32_t level_count = ResolveRemainingLevels(&img_barrier->subresourceRange, image_create_info->mipLevels); |
| 830 | uint32_t layer_count = ResolveRemainingLayers(&img_barrier->subresourceRange, image_create_info->arrayLayers); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 831 | |
Mike Weiblen | 62d08a3 | 2017-03-07 22:18:27 -0700 | [diff] [blame] | 832 | for (uint32_t j = 0; j < level_count; j++) { |
| 833 | uint32_t level = img_barrier->subresourceRange.baseMipLevel + j; |
| 834 | for (uint32_t k = 0; k < layer_count; k++) { |
| 835 | uint32_t layer = img_barrier->subresourceRange.baseArrayLayer + k; |
Tobin Ehlis | 9c0df96 | 2017-07-17 10:14:27 -0600 | [diff] [blame] | 836 | skip |= ValidateImageAspectLayout(device_data, cb_state, img_barrier, level, layer, VK_IMAGE_ASPECT_COLOR_BIT); |
| 837 | skip |= ValidateImageAspectLayout(device_data, cb_state, img_barrier, level, layer, VK_IMAGE_ASPECT_DEPTH_BIT); |
| 838 | skip |= ValidateImageAspectLayout(device_data, cb_state, img_barrier, level, layer, VK_IMAGE_ASPECT_STENCIL_BIT); |
| 839 | skip |= ValidateImageAspectLayout(device_data, cb_state, img_barrier, level, layer, VK_IMAGE_ASPECT_METADATA_BIT); |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 840 | if (GetDeviceExtensions()->vk_khr_sampler_ycbcr_conversion) { |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 841 | skip |= ValidateImageAspectLayout(device_data, cb_state, img_barrier, level, layer, |
| 842 | VK_IMAGE_ASPECT_PLANE_0_BIT_KHR); |
| 843 | skip |= ValidateImageAspectLayout(device_data, cb_state, img_barrier, level, layer, |
| 844 | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR); |
| 845 | skip |= ValidateImageAspectLayout(device_data, cb_state, img_barrier, level, layer, |
| 846 | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR); |
| 847 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 848 | } |
| 849 | } |
| 850 | } |
| 851 | return skip; |
| 852 | } |
| 853 | |
Mark Lobodzinski | 8deebf1 | 2019-03-07 11:38:38 -0700 | [diff] [blame^] | 854 | bool CoreChecks::IsReleaseOp(GLOBAL_CB_NODE *cb_state, VkImageMemoryBarrier const *barrier) { |
John Zulauf | 1b33d5a | 2018-03-24 19:52:19 -0600 | [diff] [blame] | 855 | if (!IsTransferOp(barrier)) return false; |
Chris Forbes | 4de4b13 | 2017-08-21 11:27:08 -0700 | [diff] [blame] | 856 | |
Mark Lobodzinski | 8b0a7b8 | 2019-03-06 16:17:45 -0700 | [diff] [blame] | 857 | auto pool = GetCommandPoolNode(cb_state->createInfo.commandPool); |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 858 | return pool && TempIsReleaseOp<VkImageMemoryBarrier, true>(pool, barrier); |
Chris Forbes | 4de4b13 | 2017-08-21 11:27:08 -0700 | [diff] [blame] | 859 | } |
| 860 | |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 861 | template <typename Barrier> |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 862 | bool CoreChecks::ValidateQFOTransferBarrierUniqueness(layer_data *device_data, const char *func_name, GLOBAL_CB_NODE *cb_state, |
| 863 | uint32_t barrier_count, const Barrier *barriers) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 864 | using BarrierRecord = QFOTransferBarrier<Barrier>; |
| 865 | bool skip = false; |
Mark Lobodzinski | 8b0a7b8 | 2019-03-06 16:17:45 -0700 | [diff] [blame] | 866 | auto pool = GetCommandPoolNode(cb_state->createInfo.commandPool); |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 867 | auto &barrier_sets = GetQFOBarrierSets(cb_state, typename BarrierRecord::Tag()); |
| 868 | const char *barrier_name = BarrierRecord::BarrierName(); |
| 869 | const char *handle_name = BarrierRecord::HandleName(); |
| 870 | const char *transfer_type = nullptr; |
| 871 | for (uint32_t b = 0; b < barrier_count; b++) { |
| 872 | if (!IsTransferOp(&barriers[b])) continue; |
| 873 | const BarrierRecord *barrier_record = nullptr; |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 874 | if (TempIsReleaseOp<Barrier, true /* Assume IsTransfer */>(pool, &barriers[b]) && |
| 875 | !IsSpecial(barriers[b].dstQueueFamilyIndex)) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 876 | const auto found = barrier_sets.release.find(barriers[b]); |
| 877 | if (found != barrier_sets.release.cend()) { |
| 878 | barrier_record = &(*found); |
| 879 | transfer_type = "releasing"; |
| 880 | } |
Shannon McPherson | ed2f009 | 2018-08-30 17:18:04 -0600 | [diff] [blame] | 881 | } else if (IsAcquireOp<Barrier, true /*Assume IsTransfer */>(pool, &barriers[b]) && |
| 882 | !IsSpecial(barriers[b].srcQueueFamilyIndex)) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 883 | const auto found = barrier_sets.acquire.find(barriers[b]); |
| 884 | if (found != barrier_sets.acquire.cend()) { |
| 885 | barrier_record = &(*found); |
| 886 | transfer_type = "acquiring"; |
| 887 | } |
| 888 | } |
| 889 | if (barrier_record != nullptr) { |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 890 | skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 891 | HandleToUint64(cb_state->commandBuffer), BarrierRecord::ErrMsgDuplicateQFOInCB(), |
| 892 | "%s: %s at index %" PRIu32 " %s queue ownership of %s (%s), from srcQueueFamilyIndex %" PRIu32 |
| 893 | " to dstQueueFamilyIndex %" PRIu32 " duplicates existing barrier recorded in this command buffer.", |
| 894 | func_name, barrier_name, b, transfer_type, handle_name, |
| 895 | report_data->FormatHandle(barrier_record->handle).c_str(), barrier_record->srcQueueFamilyIndex, |
| 896 | barrier_record->dstQueueFamilyIndex); |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 897 | } |
| 898 | } |
| 899 | return skip; |
| 900 | } |
| 901 | |
| 902 | template <typename Barrier> |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 903 | void CoreChecks::RecordQFOTransferBarriers(layer_data *device_data, GLOBAL_CB_NODE *cb_state, uint32_t barrier_count, |
| 904 | const Barrier *barriers) { |
Mark Lobodzinski | 8b0a7b8 | 2019-03-06 16:17:45 -0700 | [diff] [blame] | 905 | auto pool = GetCommandPoolNode(cb_state->createInfo.commandPool); |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 906 | auto &barrier_sets = GetQFOBarrierSets(cb_state, typename QFOTransferBarrier<Barrier>::Tag()); |
| 907 | for (uint32_t b = 0; b < barrier_count; b++) { |
| 908 | if (!IsTransferOp(&barriers[b])) continue; |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 909 | if (TempIsReleaseOp<Barrier, true /* Assume IsTransfer*/>(pool, &barriers[b]) && |
| 910 | !IsSpecial(barriers[b].dstQueueFamilyIndex)) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 911 | barrier_sets.release.emplace(barriers[b]); |
Shannon McPherson | ed2f009 | 2018-08-30 17:18:04 -0600 | [diff] [blame] | 912 | } else if (IsAcquireOp<Barrier, true /*Assume IsTransfer */>(pool, &barriers[b]) && |
| 913 | !IsSpecial(barriers[b].srcQueueFamilyIndex)) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 914 | barrier_sets.acquire.emplace(barriers[b]); |
| 915 | } |
| 916 | } |
| 917 | } |
| 918 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 919 | bool CoreChecks::ValidateBarriersQFOTransferUniqueness(layer_data *device_data, const char *func_name, GLOBAL_CB_NODE *cb_state, |
| 920 | uint32_t bufferBarrierCount, const VkBufferMemoryBarrier *pBufferMemBarriers, |
| 921 | uint32_t imageMemBarrierCount, |
| 922 | const VkImageMemoryBarrier *pImageMemBarriers) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 923 | bool skip = false; |
| 924 | skip |= ValidateQFOTransferBarrierUniqueness(device_data, func_name, cb_state, bufferBarrierCount, pBufferMemBarriers); |
| 925 | skip |= ValidateQFOTransferBarrierUniqueness(device_data, func_name, cb_state, imageMemBarrierCount, pImageMemBarriers); |
| 926 | return skip; |
| 927 | } |
| 928 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 929 | void CoreChecks::RecordBarriersQFOTransfers(layer_data *device_data, GLOBAL_CB_NODE *cb_state, uint32_t bufferBarrierCount, |
| 930 | const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, |
| 931 | const VkImageMemoryBarrier *pImageMemBarriers) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 932 | RecordQFOTransferBarriers(device_data, cb_state, bufferBarrierCount, pBufferMemBarriers); |
| 933 | RecordQFOTransferBarriers(device_data, cb_state, imageMemBarrierCount, pImageMemBarriers); |
| 934 | } |
| 935 | |
| 936 | template <typename BarrierRecord, typename Scoreboard> |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 937 | bool CoreChecks::ValidateAndUpdateQFOScoreboard(const debug_report_data *report_data, const GLOBAL_CB_NODE *cb_state, |
| 938 | const char *operation, const BarrierRecord &barrier, Scoreboard *scoreboard) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 939 | // Record to the scoreboard or report that we have a duplication |
| 940 | bool skip = false; |
| 941 | auto inserted = scoreboard->insert(std::make_pair(barrier, cb_state)); |
| 942 | if (!inserted.second && inserted.first->second != cb_state) { |
| 943 | // This is a duplication (but don't report duplicates from the same CB, as we do that at record time |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 944 | skip = log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 945 | HandleToUint64(cb_state->commandBuffer), BarrierRecord::ErrMsgDuplicateQFOInSubmit(), |
| 946 | "%s: %s %s queue ownership of %s (%s), from srcQueueFamilyIndex %" PRIu32 " to dstQueueFamilyIndex %" PRIu32 |
| 947 | " duplicates existing barrier submitted in this batch from command buffer %s.", |
| 948 | "vkQueueSubmit()", BarrierRecord::BarrierName(), operation, BarrierRecord::HandleName(), |
| 949 | report_data->FormatHandle(barrier.handle).c_str(), barrier.srcQueueFamilyIndex, barrier.dstQueueFamilyIndex, |
| 950 | report_data->FormatHandle(inserted.first->second).c_str()); |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 951 | } |
| 952 | return skip; |
| 953 | } |
| 954 | |
| 955 | template <typename Barrier> |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 956 | bool CoreChecks::ValidateQueuedQFOTransferBarriers(layer_data *device_data, GLOBAL_CB_NODE *cb_state, |
| 957 | QFOTransferCBScoreboards<Barrier> *scoreboards) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 958 | using BarrierRecord = QFOTransferBarrier<Barrier>; |
| 959 | using TypeTag = typename BarrierRecord::Tag; |
| 960 | bool skip = false; |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 961 | const auto report_data = device_data->GetReportData(device_data); |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 962 | const auto &cb_barriers = GetQFOBarrierSets(cb_state, TypeTag()); |
Mark Lobodzinski | 8deebf1 | 2019-03-07 11:38:38 -0700 | [diff] [blame^] | 963 | const GlobalQFOTransferBarrierMap<Barrier> &global_release_barriers = GetGlobalQFOReleaseBarrierMap(TypeTag()); |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 964 | const char *barrier_name = BarrierRecord::BarrierName(); |
| 965 | const char *handle_name = BarrierRecord::HandleName(); |
| 966 | // No release should have an extant duplicate (WARNING) |
| 967 | for (const auto &release : cb_barriers.release) { |
| 968 | // Check the global pending release barriers |
| 969 | const auto set_it = global_release_barriers.find(release.handle); |
| 970 | if (set_it != global_release_barriers.cend()) { |
| 971 | const QFOTransferBarrierSet<Barrier> &set_for_handle = set_it->second; |
| 972 | const auto found = set_for_handle.find(release); |
| 973 | if (found != set_for_handle.cend()) { |
| 974 | skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 975 | HandleToUint64(cb_state->commandBuffer), BarrierRecord::ErrMsgDuplicateQFOSubmitted(), |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 976 | "%s: %s releasing queue ownership of %s (%s), from srcQueueFamilyIndex %" PRIu32 |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 977 | " to dstQueueFamilyIndex %" PRIu32 |
| 978 | " duplicates existing barrier queued for execution, without intervening acquire operation.", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 979 | "vkQueueSubmit()", barrier_name, handle_name, report_data->FormatHandle(found->handle).c_str(), |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 980 | found->srcQueueFamilyIndex, found->dstQueueFamilyIndex); |
| 981 | } |
| 982 | } |
| 983 | skip |= ValidateAndUpdateQFOScoreboard(report_data, cb_state, "releasing", release, &scoreboards->release); |
| 984 | } |
| 985 | // Each acquire must have a matching release (ERROR) |
| 986 | for (const auto &acquire : cb_barriers.acquire) { |
| 987 | const auto set_it = global_release_barriers.find(acquire.handle); |
| 988 | bool matching_release_found = false; |
| 989 | if (set_it != global_release_barriers.cend()) { |
| 990 | const QFOTransferBarrierSet<Barrier> &set_for_handle = set_it->second; |
| 991 | matching_release_found = set_for_handle.find(acquire) != set_for_handle.cend(); |
| 992 | } |
| 993 | if (!matching_release_found) { |
| 994 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 995 | HandleToUint64(cb_state->commandBuffer), BarrierRecord::ErrMsgMissingQFOReleaseInSubmit(), |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 996 | "%s: in submitted command buffer %s acquiring ownership of %s (%s), from srcQueueFamilyIndex %" PRIu32 |
| 997 | " to dstQueueFamilyIndex %" PRIu32 " has no matching release barrier queued for execution.", |
| 998 | "vkQueueSubmit()", barrier_name, handle_name, report_data->FormatHandle(acquire.handle).c_str(), |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 999 | acquire.srcQueueFamilyIndex, acquire.dstQueueFamilyIndex); |
| 1000 | } |
| 1001 | skip |= ValidateAndUpdateQFOScoreboard(report_data, cb_state, "acquiring", acquire, &scoreboards->acquire); |
| 1002 | } |
| 1003 | return skip; |
| 1004 | } |
| 1005 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1006 | bool CoreChecks::ValidateQueuedQFOTransfers(layer_data *device_data, GLOBAL_CB_NODE *cb_state, |
| 1007 | QFOTransferCBScoreboards<VkImageMemoryBarrier> *qfo_image_scoreboards, |
| 1008 | QFOTransferCBScoreboards<VkBufferMemoryBarrier> *qfo_buffer_scoreboards) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 1009 | bool skip = false; |
| 1010 | skip |= ValidateQueuedQFOTransferBarriers<VkImageMemoryBarrier>(device_data, cb_state, qfo_image_scoreboards); |
| 1011 | skip |= ValidateQueuedQFOTransferBarriers<VkBufferMemoryBarrier>(device_data, cb_state, qfo_buffer_scoreboards); |
| 1012 | return skip; |
| 1013 | } |
| 1014 | |
| 1015 | template <typename Barrier> |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1016 | void CoreChecks::RecordQueuedQFOTransferBarriers(layer_data *device_data, GLOBAL_CB_NODE *cb_state) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 1017 | using BarrierRecord = QFOTransferBarrier<Barrier>; |
| 1018 | using TypeTag = typename BarrierRecord::Tag; |
| 1019 | const auto &cb_barriers = GetQFOBarrierSets(cb_state, TypeTag()); |
Mark Lobodzinski | 8deebf1 | 2019-03-07 11:38:38 -0700 | [diff] [blame^] | 1020 | GlobalQFOTransferBarrierMap<Barrier> &global_release_barriers = GetGlobalQFOReleaseBarrierMap(TypeTag()); |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 1021 | |
| 1022 | // Add release barriers from this submit to the global map |
| 1023 | for (const auto &release : cb_barriers.release) { |
| 1024 | // the global barrier list is mapped by resource handle to allow cleanup on resource destruction |
| 1025 | // NOTE: We're using [] because creation of a Set is a needed side effect for new handles |
| 1026 | global_release_barriers[release.handle].insert(release); |
| 1027 | } |
| 1028 | |
| 1029 | // Erase acquired barriers from this submit from the global map -- essentially marking releases as consumed |
| 1030 | for (const auto &acquire : cb_barriers.acquire) { |
| 1031 | // NOTE: We're not using [] because we don't want to create entries for missing releases |
| 1032 | auto set_it = global_release_barriers.find(acquire.handle); |
| 1033 | if (set_it != global_release_barriers.end()) { |
| 1034 | QFOTransferBarrierSet<Barrier> &set_for_handle = set_it->second; |
| 1035 | set_for_handle.erase(acquire); |
| 1036 | if (set_for_handle.size() == 0) { // Clean up empty sets |
| 1037 | global_release_barriers.erase(set_it); |
| 1038 | } |
| 1039 | } |
| 1040 | } |
| 1041 | } |
| 1042 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1043 | void CoreChecks::RecordQueuedQFOTransfers(layer_data *device_data, GLOBAL_CB_NODE *cb_state) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 1044 | RecordQueuedQFOTransferBarriers<VkImageMemoryBarrier>(device_data, cb_state); |
| 1045 | RecordQueuedQFOTransferBarriers<VkBufferMemoryBarrier>(device_data, cb_state); |
| 1046 | } |
| 1047 | |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 1048 | // Avoid making the template globally visible by exporting the one instance of it we need. |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1049 | void CoreChecks::EraseQFOImageRelaseBarriers(layer_data *device_data, const VkImage &image) { |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 1050 | EraseQFOReleaseBarriers<VkImageMemoryBarrier>(device_data, image); |
| 1051 | } |
| 1052 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1053 | void CoreChecks::TransitionImageLayouts(layer_data *device_data, GLOBAL_CB_NODE *cb_state, uint32_t memBarrierCount, |
| 1054 | const VkImageMemoryBarrier *pImgMemBarriers) { |
Mark Lobodzinski | 6b6c50a | 2017-02-27 12:56:14 -0700 | [diff] [blame] | 1055 | for (uint32_t i = 0; i < memBarrierCount; ++i) { |
| 1056 | auto mem_barrier = &pImgMemBarriers[i]; |
| 1057 | if (!mem_barrier) continue; |
Mark Lobodzinski | 6b6c50a | 2017-02-27 12:56:14 -0700 | [diff] [blame] | 1058 | |
Chris Forbes | 4de4b13 | 2017-08-21 11:27:08 -0700 | [diff] [blame] | 1059 | // For ownership transfers, the barrier is specified twice; as a release |
| 1060 | // operation on the yielding queue family, and as an acquire operation |
| 1061 | // on the acquiring queue family. This barrier may also include a layout |
| 1062 | // transition, which occurs 'between' the two operations. For validation |
| 1063 | // purposes it doesn't seem important which side performs the layout |
| 1064 | // transition, but it must not be performed twice. We'll arbitrarily |
| 1065 | // choose to perform it as part of the acquire operation. |
Mark Lobodzinski | 8deebf1 | 2019-03-07 11:38:38 -0700 | [diff] [blame^] | 1066 | if (IsReleaseOp(cb_state, mem_barrier)) { |
Chris Forbes | 4de4b13 | 2017-08-21 11:27:08 -0700 | [diff] [blame] | 1067 | continue; |
| 1068 | } |
| 1069 | |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 1070 | VkImageCreateInfo *image_create_info = &(GetImageState(mem_barrier->image)->createInfo); |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1071 | uint32_t level_count = ResolveRemainingLevels(&mem_barrier->subresourceRange, image_create_info->mipLevels); |
| 1072 | uint32_t layer_count = ResolveRemainingLayers(&mem_barrier->subresourceRange, image_create_info->arrayLayers); |
| 1073 | |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 1074 | // Special case for 3D images with VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT_KHR flag bit, where <extent.depth> and |
| 1075 | // <arrayLayers> can potentially alias. When recording layout for the entire image, pre-emptively record layouts |
| 1076 | // for all (potential) layer sub_resources. |
| 1077 | if ((0 != (image_create_info->flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT_KHR)) && |
| 1078 | (mem_barrier->subresourceRange.baseArrayLayer == 0) && (layer_count == 1)) { |
| 1079 | layer_count = image_create_info->extent.depth; // Treat each depth slice as a layer subresource |
| 1080 | } |
| 1081 | |
Tony-LunarG | 0d27b30 | 2018-10-08 09:26:21 -0600 | [diff] [blame] | 1082 | // For multiplanar formats, IMAGE_ASPECT_COLOR is equivalent to adding the aspect of the individual planes |
| 1083 | VkImageAspectFlags aspect_mask = mem_barrier->subresourceRange.aspectMask; |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 1084 | if (GetDeviceExtensions()->vk_khr_sampler_ycbcr_conversion) { |
Tony-LunarG | 0d27b30 | 2018-10-08 09:26:21 -0600 | [diff] [blame] | 1085 | if (FormatIsMultiplane(image_create_info->format)) { |
| 1086 | if (aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) { |
| 1087 | aspect_mask &= ~VK_IMAGE_ASPECT_COLOR_BIT; |
| 1088 | aspect_mask |= (VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT); |
| 1089 | if (FormatPlaneCount(image_create_info->format) > 2) { |
| 1090 | aspect_mask |= VK_IMAGE_ASPECT_PLANE_2_BIT; |
| 1091 | } |
| 1092 | } |
| 1093 | } |
| 1094 | } |
| 1095 | |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1096 | for (uint32_t j = 0; j < level_count; j++) { |
Mark Lobodzinski | 6b6c50a | 2017-02-27 12:56:14 -0700 | [diff] [blame] | 1097 | uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1098 | for (uint32_t k = 0; k < layer_count; k++) { |
Mark Lobodzinski | 6b6c50a | 2017-02-27 12:56:14 -0700 | [diff] [blame] | 1099 | uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; |
Tony-LunarG | 0d27b30 | 2018-10-08 09:26:21 -0600 | [diff] [blame] | 1100 | TransitionImageAspectLayout(device_data, cb_state, mem_barrier, level, layer, aspect_mask, |
| 1101 | VK_IMAGE_ASPECT_COLOR_BIT); |
| 1102 | TransitionImageAspectLayout(device_data, cb_state, mem_barrier, level, layer, aspect_mask, |
| 1103 | VK_IMAGE_ASPECT_DEPTH_BIT); |
| 1104 | TransitionImageAspectLayout(device_data, cb_state, mem_barrier, level, layer, aspect_mask, |
| 1105 | VK_IMAGE_ASPECT_STENCIL_BIT); |
| 1106 | TransitionImageAspectLayout(device_data, cb_state, mem_barrier, level, layer, aspect_mask, |
| 1107 | VK_IMAGE_ASPECT_METADATA_BIT); |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 1108 | if (GetDeviceExtensions()->vk_khr_sampler_ycbcr_conversion) { |
Tony-LunarG | 0d27b30 | 2018-10-08 09:26:21 -0600 | [diff] [blame] | 1109 | TransitionImageAspectLayout(device_data, cb_state, mem_barrier, level, layer, aspect_mask, |
| 1110 | VK_IMAGE_ASPECT_PLANE_0_BIT_KHR); |
| 1111 | TransitionImageAspectLayout(device_data, cb_state, mem_barrier, level, layer, aspect_mask, |
| 1112 | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR); |
| 1113 | TransitionImageAspectLayout(device_data, cb_state, mem_barrier, level, layer, aspect_mask, |
| 1114 | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR); |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 1115 | } |
Mark Lobodzinski | 6b6c50a | 2017-02-27 12:56:14 -0700 | [diff] [blame] | 1116 | } |
| 1117 | } |
| 1118 | } |
| 1119 | } |
| 1120 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1121 | bool CoreChecks::VerifyImageLayout(layer_data const *device_data, GLOBAL_CB_NODE const *cb_node, IMAGE_STATE *image_state, |
| 1122 | VkImageSubresourceLayers subLayers, VkImageLayout explicit_layout, VkImageLayout optimal_layout, |
| 1123 | const char *caller, const char *layout_invalid_msg_code, const char *layout_mismatch_msg_code, |
| 1124 | bool *error) { |
Tobin Ehlis | 2d85ec6 | 2017-03-14 15:38:48 -0600 | [diff] [blame] | 1125 | const auto image = image_state->image; |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 1126 | bool skip = false; |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1127 | |
| 1128 | for (uint32_t i = 0; i < subLayers.layerCount; ++i) { |
| 1129 | uint32_t layer = i + subLayers.baseArrayLayer; |
| 1130 | VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; |
| 1131 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 1132 | if (FindCmdBufLayout(device_data, cb_node, image, sub, node)) { |
| 1133 | if (node.layout != explicit_layout) { |
Tobin Ehlis | c826645 | 2017-04-07 12:20:30 -0600 | [diff] [blame] | 1134 | *error = true; |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 1135 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 1136 | HandleToUint64(cb_node->commandBuffer), layout_mismatch_msg_code, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 1137 | "%s: Cannot use image %s (layer=%u mip=%u) with specific layout %s that doesn't match the actual " |
| 1138 | "current layout %s.", |
| 1139 | caller, report_data->FormatHandle(image).c_str(), layer, subLayers.mipLevel, |
| 1140 | string_VkImageLayout(explicit_layout), string_VkImageLayout(node.layout)); |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 1141 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1142 | } |
| 1143 | } |
Tobin Ehlis | 2d85ec6 | 2017-03-14 15:38:48 -0600 | [diff] [blame] | 1144 | // If optimal_layout is not UNDEFINED, check that layout matches optimal for this case |
| 1145 | if ((VK_IMAGE_LAYOUT_UNDEFINED != optimal_layout) && (explicit_layout != optimal_layout)) { |
| 1146 | if (VK_IMAGE_LAYOUT_GENERAL == explicit_layout) { |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1147 | if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { |
| 1148 | // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 1149 | skip |= log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 1150 | VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, HandleToUint64(cb_node->commandBuffer), |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 1151 | kVUID_Core_DrawState_InvalidImageLayout, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 1152 | "%s: For optimal performance image %s layout should be %s instead of GENERAL.", caller, |
| 1153 | report_data->FormatHandle(image).c_str(), string_VkImageLayout(optimal_layout)); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1154 | } |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 1155 | } else if (GetDeviceExtensions()->vk_khr_shared_presentable_image) { |
Mark Lobodzinski | 087380c | 2017-05-16 14:42:25 -0600 | [diff] [blame] | 1156 | if (image_state->shared_presentable) { |
| 1157 | if (VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR != explicit_layout) { |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 1158 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1159 | layout_invalid_msg_code, |
| 1160 | "Layout for shared presentable image is %s but must be VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR.", |
| 1161 | string_VkImageLayout(optimal_layout)); |
Mark Lobodzinski | 087380c | 2017-05-16 14:42:25 -0600 | [diff] [blame] | 1162 | } |
Tobin Ehlis | bb03e5f | 2017-05-11 08:52:51 -0600 | [diff] [blame] | 1163 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1164 | } else { |
Tobin Ehlis | c826645 | 2017-04-07 12:20:30 -0600 | [diff] [blame] | 1165 | *error = true; |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 1166 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 1167 | HandleToUint64(cb_node->commandBuffer), layout_invalid_msg_code, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 1168 | "%s: Layout for image %s is %s but can only be %s or VK_IMAGE_LAYOUT_GENERAL.", caller, |
| 1169 | report_data->FormatHandle(image).c_str(), string_VkImageLayout(explicit_layout), |
| 1170 | string_VkImageLayout(optimal_layout)); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1171 | } |
| 1172 | } |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 1173 | return skip; |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1174 | } |
| 1175 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1176 | void CoreChecks::TransitionFinalSubpassLayouts(layer_data *device_data, GLOBAL_CB_NODE *pCB, |
| 1177 | const VkRenderPassBeginInfo *pRenderPassBegin, |
| 1178 | FRAMEBUFFER_STATE *framebuffer_state) { |
Mark Lobodzinski | 2e49588 | 2019-03-06 16:11:56 -0700 | [diff] [blame] | 1179 | auto renderPass = GetRenderPassState(pRenderPassBegin->renderPass); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1180 | if (!renderPass) return; |
| 1181 | |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 1182 | const VkRenderPassCreateInfo2KHR *pRenderPassInfo = renderPass->createInfo.ptr(); |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1183 | if (framebuffer_state) { |
| 1184 | for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { |
Mark Lobodzinski | a3a230b | 2019-03-06 15:35:13 -0700 | [diff] [blame] | 1185 | auto view_state = GetAttachmentImageViewState(framebuffer_state, i); |
John Zulauf | 8e30829 | 2018-09-21 11:34:37 -0600 | [diff] [blame] | 1186 | if (view_state) { |
| 1187 | SetImageViewLayout(device_data, pCB, view_state, pRenderPassInfo->pAttachments[i].finalLayout); |
| 1188 | } |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1189 | } |
| 1190 | } |
| 1191 | } |
Dave Houlton | e19e20d | 2018-02-02 16:32:41 -0700 | [diff] [blame] | 1192 | |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1193 | #ifdef VK_USE_PLATFORM_ANDROID_KHR |
| 1194 | // Android-specific validation that uses types defined only with VK_USE_PLATFORM_ANDROID_KHR |
| 1195 | // This could also move into a seperate core_validation_android.cpp file... ? |
| 1196 | |
| 1197 | // |
| 1198 | // AHB-specific validation within non-AHB APIs |
| 1199 | // |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1200 | bool CoreChecks::ValidateCreateImageANDROID(layer_data *device_data, const debug_report_data *report_data, |
| 1201 | const VkImageCreateInfo *create_info) { |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1202 | bool skip = false; |
| 1203 | |
| 1204 | const VkExternalFormatANDROID *ext_fmt_android = lvl_find_in_chain<VkExternalFormatANDROID>(create_info->pNext); |
| 1205 | if (ext_fmt_android) { |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1206 | if (0 != ext_fmt_android->externalFormat) { |
| 1207 | if (VK_FORMAT_UNDEFINED != create_info->format) { |
| 1208 | skip |= |
| 1209 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1210 | "VUID-VkImageCreateInfo-pNext-01974", |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1211 | "vkCreateImage(): VkImageCreateInfo struct has a chained VkExternalFormatANDROID struct with non-zero " |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1212 | "externalFormat, but the VkImageCreateInfo's format is not VK_FORMAT_UNDEFINED."); |
| 1213 | } |
| 1214 | |
| 1215 | if (0 != (VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT & create_info->flags)) { |
| 1216 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1217 | "VUID-VkImageCreateInfo-pNext-02396", |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1218 | "vkCreateImage(): VkImageCreateInfo struct has a chained VkExternalFormatANDROID struct with " |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1219 | "non-zero externalFormat, but flags include VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT."); |
| 1220 | } |
| 1221 | |
| 1222 | if (0 != (~VK_IMAGE_USAGE_SAMPLED_BIT & create_info->usage)) { |
| 1223 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1224 | "VUID-VkImageCreateInfo-pNext-02397", |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1225 | "vkCreateImage(): VkImageCreateInfo struct has a chained VkExternalFormatANDROID struct with " |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1226 | "non-zero externalFormat, but usage includes bits other than VK_IMAGE_USAGE_SAMPLED_BIT."); |
| 1227 | } |
| 1228 | |
| 1229 | if (VK_IMAGE_TILING_OPTIMAL != create_info->tiling) { |
| 1230 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1231 | "VUID-VkImageCreateInfo-pNext-02398", |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1232 | "vkCreateImage(): VkImageCreateInfo struct has a chained VkExternalFormatANDROID struct with " |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1233 | "non-zero externalFormat, but layout is not VK_IMAGE_TILING_OPTIMAL."); |
| 1234 | } |
| 1235 | } |
| 1236 | |
Mark Lobodzinski | eb8654d | 2019-03-07 11:14:47 -0700 | [diff] [blame] | 1237 | auto ahb_formats = GetAHBExternalFormatsSet(); |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1238 | if ((0 != ext_fmt_android->externalFormat) && (0 == ahb_formats->count(ext_fmt_android->externalFormat))) { |
| 1239 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1240 | "VUID-VkExternalFormatANDROID-externalFormat-01894", |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1241 | "vkCreateImage(): Chained VkExternalFormatANDROID struct contains a non-zero externalFormat which has " |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1242 | "not been previously retrieved by vkGetAndroidHardwareBufferPropertiesANDROID()."); |
| 1243 | } |
| 1244 | } |
| 1245 | |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1246 | if ((nullptr == ext_fmt_android) || (0 == ext_fmt_android->externalFormat)) { |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1247 | if (VK_FORMAT_UNDEFINED == create_info->format) { |
| 1248 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1249 | "VUID-VkImageCreateInfo-pNext-01975", |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1250 | "vkCreateImage(): VkImageCreateInfo struct's format is VK_FORMAT_UNDEFINED, but either does not have a " |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1251 | "chained VkExternalFormatANDROID struct or the struct exists but has an externalFormat of 0."); |
| 1252 | } |
| 1253 | } |
| 1254 | |
| 1255 | const VkExternalMemoryImageCreateInfo *emici = lvl_find_in_chain<VkExternalMemoryImageCreateInfo>(create_info->pNext); |
| 1256 | if (emici && (emici->handleTypes & VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID)) { |
| 1257 | if (create_info->imageType != VK_IMAGE_TYPE_2D) { |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1258 | skip |= |
| 1259 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1260 | "VUID-VkImageCreateInfo-pNext-02393", |
| 1261 | "vkCreateImage(): VkImageCreateInfo struct with imageType %s has chained VkExternalMemoryImageCreateInfo " |
| 1262 | "struct with handleType VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID.", |
| 1263 | string_VkImageType(create_info->imageType)); |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1264 | } |
| 1265 | |
| 1266 | if ((create_info->mipLevels != 1) && (create_info->mipLevels != FullMipChainLevels(create_info->extent))) { |
| 1267 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1268 | "VUID-VkImageCreateInfo-pNext-02394", |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1269 | "vkCreateImage(): VkImageCreateInfo struct with chained VkExternalMemoryImageCreateInfo struct of " |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1270 | "handleType VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID " |
| 1271 | "specifies mipLevels = %" PRId32 " (full chain mipLevels are %" PRId32 ").", |
| 1272 | create_info->mipLevels, FullMipChainLevels(create_info->extent)); |
| 1273 | } |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1274 | } |
| 1275 | |
| 1276 | return skip; |
| 1277 | } |
| 1278 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1279 | void CoreChecks::RecordCreateImageANDROID(const VkImageCreateInfo *create_info, IMAGE_STATE *is_node) { |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1280 | const VkExternalMemoryImageCreateInfo *emici = lvl_find_in_chain<VkExternalMemoryImageCreateInfo>(create_info->pNext); |
| 1281 | if (emici && (emici->handleTypes & VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID)) { |
| 1282 | is_node->imported_ahb = true; |
| 1283 | } |
Dave Houlton | d3e046d | 2018-11-28 13:08:09 -0700 | [diff] [blame] | 1284 | const VkExternalFormatANDROID *ext_fmt_android = lvl_find_in_chain<VkExternalFormatANDROID>(create_info->pNext); |
egdaniel | 1f4d2a4 | 2019-02-04 10:25:38 -0500 | [diff] [blame] | 1285 | if (ext_fmt_android && (0 != ext_fmt_android->externalFormat)) { |
Dave Houlton | d3e046d | 2018-11-28 13:08:09 -0700 | [diff] [blame] | 1286 | is_node->has_ahb_format = true; |
| 1287 | is_node->ahb_format = ext_fmt_android->externalFormat; |
| 1288 | } |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1289 | } |
| 1290 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1291 | bool CoreChecks::ValidateCreateImageViewANDROID(layer_data *device_data, const VkImageViewCreateInfo *create_info) { |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1292 | bool skip = false; |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 1293 | IMAGE_STATE *image_state = GetImageState(create_info->image); |
Dave Houlton | d3e046d | 2018-11-28 13:08:09 -0700 | [diff] [blame] | 1294 | |
| 1295 | if (image_state->has_ahb_format) { |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1296 | if (VK_FORMAT_UNDEFINED != create_info->format) { |
| 1297 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 1298 | HandleToUint64(create_info->image), "VUID-VkImageViewCreateInfo-image-02399", |
| 1299 | "vkCreateImageView(): VkImageViewCreateInfo struct has a chained VkExternalFormatANDROID struct, but " |
| 1300 | "format member is %s.", |
| 1301 | string_VkFormat(create_info->format)); |
| 1302 | } |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1303 | |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1304 | // Chain must include a compatible ycbcr conversion |
| 1305 | bool conv_found = false; |
| 1306 | uint64_t external_format = 0; |
| 1307 | const VkSamplerYcbcrConversionInfo *ycbcr_conv_info = lvl_find_in_chain<VkSamplerYcbcrConversionInfo>(create_info->pNext); |
| 1308 | if (ycbcr_conv_info != nullptr) { |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1309 | VkSamplerYcbcrConversion conv_handle = ycbcr_conv_info->conversion; |
Mark Lobodzinski | eb8654d | 2019-03-07 11:14:47 -0700 | [diff] [blame] | 1310 | auto fmap = GetYcbcrConversionFormatMap(); |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1311 | if (fmap->find(conv_handle) != fmap->end()) { |
| 1312 | conv_found = true; |
| 1313 | external_format = fmap->at(conv_handle); |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1314 | } |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1315 | } |
Dave Houlton | d3e046d | 2018-11-28 13:08:09 -0700 | [diff] [blame] | 1316 | if ((!conv_found) || (external_format != image_state->ahb_format)) { |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1317 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1318 | HandleToUint64(create_info->image), "VUID-VkImageViewCreateInfo-image-02400", |
| 1319 | "vkCreateImageView(): VkImageViewCreateInfo struct has a chained VkExternalFormatANDROID struct, but " |
| 1320 | "without a chained VkSamplerYcbcrConversionInfo struct with the same external format."); |
| 1321 | } |
| 1322 | |
| 1323 | // Errors in create_info swizzles |
| 1324 | if ((create_info->components.r != VK_COMPONENT_SWIZZLE_IDENTITY) || |
| 1325 | (create_info->components.g != VK_COMPONENT_SWIZZLE_IDENTITY) || |
| 1326 | (create_info->components.b != VK_COMPONENT_SWIZZLE_IDENTITY) || |
| 1327 | (create_info->components.a != VK_COMPONENT_SWIZZLE_IDENTITY)) { |
| 1328 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 1329 | HandleToUint64(create_info->image), "VUID-VkImageViewCreateInfo-image-02401", |
| 1330 | "vkCreateImageView(): VkImageViewCreateInfo struct has a chained VkExternalFormatANDROID struct, but " |
| 1331 | "includes one or more non-identity component swizzles."); |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1332 | } |
| 1333 | } |
Dave Houlton | d961131 | 2018-11-19 17:03:36 -0700 | [diff] [blame] | 1334 | |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1335 | return skip; |
| 1336 | } |
| 1337 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1338 | bool CoreChecks::ValidateGetImageSubresourceLayoutANDROID(layer_data *device_data, const VkImage image) { |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1339 | bool skip = false; |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1340 | |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 1341 | IMAGE_STATE *image_state = GetImageState(image); |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1342 | if (image_state->imported_ahb && (0 == image_state->GetBoundMemory().size())) { |
| 1343 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), |
| 1344 | "VUID-vkGetImageSubresourceLayout-image-01895", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 1345 | "vkGetImageSubresourceLayout(): Attempt to query layout from an image created with " |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1346 | "VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID handleType which has not yet been " |
| 1347 | "bound to memory."); |
| 1348 | } |
| 1349 | return skip; |
| 1350 | } |
| 1351 | |
| 1352 | #else |
| 1353 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1354 | bool CoreChecks::ValidateCreateImageANDROID(layer_data *device_data, const debug_report_data *report_data, |
| 1355 | const VkImageCreateInfo *create_info) { |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1356 | return false; |
| 1357 | } |
| 1358 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1359 | void CoreChecks::RecordCreateImageANDROID(const VkImageCreateInfo *create_info, IMAGE_STATE *is_node) {} |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1360 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1361 | bool CoreChecks::ValidateCreateImageViewANDROID(layer_data *device_data, const VkImageViewCreateInfo *create_info) { return false; } |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1362 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1363 | bool CoreChecks::ValidateGetImageSubresourceLayoutANDROID(layer_data *device_data, const VkImage image) { return false; } |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1364 | |
| 1365 | #endif // VK_USE_PLATFORM_ANDROID_KHR |
| 1366 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1367 | bool CoreChecks::PreCallValidateCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, |
| 1368 | const VkAllocationCallbacks *pAllocator, VkImage *pImage) { |
| 1369 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 1370 | bool skip = false; |
Mark Lobodzinski | 90224de | 2017-01-26 15:23:11 -0700 | [diff] [blame] | 1371 | |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 1372 | if (GetDeviceExtensions()->vk_android_external_memory_android_hardware_buffer) { |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1373 | skip |= ValidateCreateImageANDROID(device_data, report_data, pCreateInfo); |
| 1374 | } else { // These checks are omitted or replaced when Android HW Buffer extension is active |
| 1375 | if (pCreateInfo->format == VK_FORMAT_UNDEFINED) { |
| 1376 | return log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1377 | "VUID-VkImageCreateInfo-format-00943", |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1378 | "vkCreateImage(): VkFormat for image must not be VK_FORMAT_UNDEFINED."); |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1379 | } |
Jeremy Hayes | 96dcd81 | 2017-03-14 14:04:19 -0600 | [diff] [blame] | 1380 | } |
| 1381 | |
Dave Houlton | 130c021 | 2018-01-29 13:39:56 -0700 | [diff] [blame] | 1382 | if ((pCreateInfo->flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT) && (VK_IMAGE_TYPE_2D != pCreateInfo->imageType)) { |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1383 | skip |= log_msg( |
| 1384 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1385 | "VUID-VkImageCreateInfo-flags-00949", |
| 1386 | "vkCreateImage(): Image type must be VK_IMAGE_TYPE_2D when VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT flag bit is set"); |
Dave Houlton | 130c021 | 2018-01-29 13:39:56 -0700 | [diff] [blame] | 1387 | } |
Mark Lobodzinski | 90224de | 2017-01-26 15:23:11 -0700 | [diff] [blame] | 1388 | |
Mark Lobodzinski | 5c04880 | 2019-03-07 10:47:31 -0700 | [diff] [blame] | 1389 | const VkPhysicalDeviceLimits *device_limits = &(GetPDProperties()->limits); |
Dave Houlton | 130c021 | 2018-01-29 13:39:56 -0700 | [diff] [blame] | 1390 | VkImageUsageFlags attach_flags = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | |
| 1391 | VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT; |
| 1392 | if ((pCreateInfo->usage & attach_flags) && (pCreateInfo->extent.width > device_limits->maxFramebufferWidth)) { |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 1393 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1394 | "VUID-VkImageCreateInfo-usage-00964", |
| 1395 | "vkCreateImage(): Image usage flags include a frame buffer attachment bit and image width exceeds device " |
| 1396 | "maxFramebufferWidth."); |
Dave Houlton | 130c021 | 2018-01-29 13:39:56 -0700 | [diff] [blame] | 1397 | } |
| 1398 | |
| 1399 | if ((pCreateInfo->usage & attach_flags) && (pCreateInfo->extent.height > device_limits->maxFramebufferHeight)) { |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 1400 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1401 | "VUID-VkImageCreateInfo-usage-00965", |
| 1402 | "vkCreateImage(): Image usage flags include a frame buffer attachment bit and image height exceeds device " |
| 1403 | "maxFramebufferHeight"); |
Dave Houlton | 130c021 | 2018-01-29 13:39:56 -0700 | [diff] [blame] | 1404 | } |
| 1405 | |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1406 | VkImageFormatProperties format_limits = {}; |
Mark Lobodzinski | 5c04880 | 2019-03-07 10:47:31 -0700 | [diff] [blame] | 1407 | VkResult res = GetPDImageFormatProperties(pCreateInfo, &format_limits); |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1408 | if (res == VK_ERROR_FORMAT_NOT_SUPPORTED) { |
| 1409 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUIDUndefined, |
| 1410 | "vkCreateImage(): Format %s is not supported for this combination of parameters.", |
| 1411 | string_VkFormat(pCreateInfo->format)); |
| 1412 | } else { |
| 1413 | if (pCreateInfo->mipLevels > format_limits.maxMipLevels) { |
| 1414 | const char *format_string = string_VkFormat(pCreateInfo->format); |
| 1415 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 1416 | "VUID-VkImageCreateInfo-mipLevels-02255", |
| 1417 | "vkCreateImage(): Image mip levels=%d exceed image format maxMipLevels=%d for format %s.", |
| 1418 | pCreateInfo->mipLevels, format_limits.maxMipLevels, format_string); |
| 1419 | } |
Dave Houlton | 130c021 | 2018-01-29 13:39:56 -0700 | [diff] [blame] | 1420 | |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 1421 | uint64_t texel_count = (uint64_t)pCreateInfo->extent.width * (uint64_t)pCreateInfo->extent.height * |
| 1422 | (uint64_t)pCreateInfo->extent.depth * (uint64_t)pCreateInfo->arrayLayers * |
| 1423 | (uint64_t)pCreateInfo->samples; |
| 1424 | uint64_t total_size = (uint64_t)std::ceil(FormatTexelSize(pCreateInfo->format) * texel_count); |
Dave Houlton | 130c021 | 2018-01-29 13:39:56 -0700 | [diff] [blame] | 1425 | |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1426 | // Round up to imageGranularity boundary |
Mark Lobodzinski | 5c04880 | 2019-03-07 10:47:31 -0700 | [diff] [blame] | 1427 | VkDeviceSize imageGranularity = GetPDProperties()->limits.bufferImageGranularity; |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1428 | uint64_t ig_mask = imageGranularity - 1; |
| 1429 | total_size = (total_size + ig_mask) & ~ig_mask; |
Mark Lobodzinski | 90224de | 2017-01-26 15:23:11 -0700 | [diff] [blame] | 1430 | |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1431 | if (total_size > format_limits.maxResourceSize) { |
| 1432 | skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 0, |
| 1433 | kVUID_Core_Image_InvalidFormatLimitsViolation, |
| 1434 | "vkCreateImage(): resource size exceeds allowable maximum Image resource size = 0x%" PRIxLEAST64 |
| 1435 | ", maximum resource size = 0x%" PRIxLEAST64 " ", |
| 1436 | total_size, format_limits.maxResourceSize); |
| 1437 | } |
Mark Lobodzinski | 90224de | 2017-01-26 15:23:11 -0700 | [diff] [blame] | 1438 | |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1439 | if (pCreateInfo->arrayLayers > format_limits.maxArrayLayers) { |
| 1440 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 0, |
| 1441 | "VUID-VkImageCreateInfo-arrayLayers-02256", |
| 1442 | "vkCreateImage(): arrayLayers=%d exceeds allowable maximum supported by format of %d.", |
| 1443 | pCreateInfo->arrayLayers, format_limits.maxArrayLayers); |
| 1444 | } |
| 1445 | |
| 1446 | if ((pCreateInfo->samples & format_limits.sampleCounts) == 0) { |
| 1447 | skip |= |
| 1448 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 0, |
| 1449 | "VUID-VkImageCreateInfo-samples-02258", "vkCreateImage(): samples %s is not supported by format 0x%.8X.", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 1450 | string_VkSampleCountFlagBits(pCreateInfo->samples), format_limits.sampleCounts); |
Graeme Leese | 2cd2a1f | 2018-11-19 15:11:45 +0000 | [diff] [blame] | 1451 | } |
Mark Lobodzinski | 90224de | 2017-01-26 15:23:11 -0700 | [diff] [blame] | 1452 | } |
| 1453 | |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 1454 | if ((pCreateInfo->flags & VK_IMAGE_CREATE_SPARSE_ALIASED_BIT) && (!GetEnabledFeatures()->core.sparseResidencyAliased)) { |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 1455 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Dave Houlton | 12befb9 | 2018-06-26 17:16:46 -0600 | [diff] [blame] | 1456 | "VUID-VkImageCreateInfo-flags-01924", |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 1457 | "vkCreateImage(): the sparseResidencyAliased device feature is disabled: Images cannot be created with the " |
| 1458 | "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT set."); |
Mark Lobodzinski | 035a4cf | 2017-03-13 09:45:07 -0600 | [diff] [blame] | 1459 | } |
| 1460 | |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 1461 | if (GetDeviceExtensions()->vk_khr_maintenance2) { |
Lenny Komow | b79f04a | 2017-09-18 17:07:00 -0600 | [diff] [blame] | 1462 | if (pCreateInfo->flags & VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR) { |
| 1463 | if (!(FormatIsCompressed_BC(pCreateInfo->format) || FormatIsCompressed_ASTC_LDR(pCreateInfo->format) || |
| 1464 | FormatIsCompressed_ETC2_EAC(pCreateInfo->format))) { |
| 1465 | // TODO: Add Maintenance2 VUID |
Dave Houlton | 8e9f654 | 2018-05-18 12:18:22 -0600 | [diff] [blame] | 1466 | skip |= |
| 1467 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUIDUndefined, |
| 1468 | "vkCreateImage(): If pCreateInfo->flags contains VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR, " |
| 1469 | "format must be block, ETC or ASTC compressed, but is %s", |
| 1470 | string_VkFormat(pCreateInfo->format)); |
Lenny Komow | b79f04a | 2017-09-18 17:07:00 -0600 | [diff] [blame] | 1471 | } |
| 1472 | if (!(pCreateInfo->flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT)) { |
| 1473 | // TODO: Add Maintenance2 VUID |
Dave Houlton | 8e9f654 | 2018-05-18 12:18:22 -0600 | [diff] [blame] | 1474 | skip |= |
| 1475 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUIDUndefined, |
| 1476 | "vkCreateImage(): If pCreateInfo->flags contains VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR, " |
| 1477 | "flags must also contain VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT."); |
Lenny Komow | b79f04a | 2017-09-18 17:07:00 -0600 | [diff] [blame] | 1478 | } |
| 1479 | } |
| 1480 | } |
| 1481 | |
Mark Lobodzinski | 08ee03c | 2019-02-04 10:57:47 -0700 | [diff] [blame] | 1482 | if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT && pCreateInfo->pQueueFamilyIndices) { |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1483 | skip |= |
| 1484 | ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices, |
| 1485 | "vkCreateImage", "pCreateInfo->pQueueFamilyIndices", "VUID-VkImageCreateInfo-sharingMode-01420", |
| 1486 | "VUID-VkImageCreateInfo-sharingMode-01420", false); |
Mark Lobodzinski | 08ee03c | 2019-02-04 10:57:47 -0700 | [diff] [blame] | 1487 | } |
| 1488 | |
Mark Lobodzinski | bdc3b02 | 2017-04-24 09:11:35 -0600 | [diff] [blame] | 1489 | return skip; |
Mark Lobodzinski | 90224de | 2017-01-26 15:23:11 -0700 | [diff] [blame] | 1490 | } |
| 1491 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1492 | void CoreChecks::PostCallRecordCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, |
| 1493 | const VkAllocationCallbacks *pAllocator, VkImage *pImage, VkResult result) { |
Mark Lobodzinski | 701507e | 2019-01-18 14:31:53 -0700 | [diff] [blame] | 1494 | if (VK_SUCCESS != result) return; |
Mark Lobodzinski | 42fe5f7 | 2017-01-11 11:36:16 -0700 | [diff] [blame] | 1495 | IMAGE_LAYOUT_NODE image_state; |
| 1496 | image_state.layout = pCreateInfo->initialLayout; |
| 1497 | image_state.format = pCreateInfo->format; |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1498 | IMAGE_STATE *is_node = new IMAGE_STATE(*pImage, pCreateInfo); |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 1499 | if (GetDeviceExtensions()->vk_android_external_memory_android_hardware_buffer) { |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 1500 | RecordCreateImageANDROID(pCreateInfo, is_node); |
| 1501 | } |
Mark Lobodzinski | 44d46d5 | 2019-03-07 11:04:06 -0700 | [diff] [blame] | 1502 | GetImageMap()->insert(std::make_pair(*pImage, std::unique_ptr<IMAGE_STATE>(is_node))); |
Mark Lobodzinski | 42fe5f7 | 2017-01-11 11:36:16 -0700 | [diff] [blame] | 1503 | ImageSubresourcePair subpair{*pImage, false, VkImageSubresource()}; |
Mark Lobodzinski | 44d46d5 | 2019-03-07 11:04:06 -0700 | [diff] [blame] | 1504 | (*GetImageSubresourceMap())[*pImage].push_back(subpair); |
| 1505 | (*GetImageLayoutMap())[subpair] = image_state; |
Mark Lobodzinski | 42fe5f7 | 2017-01-11 11:36:16 -0700 | [diff] [blame] | 1506 | } |
Mark Lobodzinski | 9ef5d56 | 2017-01-27 12:28:30 -0700 | [diff] [blame] | 1507 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1508 | bool CoreChecks::PreCallValidateDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | 6b35c8a | 2019-01-10 10:57:27 -0700 | [diff] [blame] | 1509 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 1510 | IMAGE_STATE *image_state = GetImageState(image); |
Mark Lobodzinski | 6b35c8a | 2019-01-10 10:57:27 -0700 | [diff] [blame] | 1511 | const VK_OBJECT obj_struct = {HandleToUint64(image), kVulkanObjectTypeImage}; |
Mark Lobodzinski | 9ef5d56 | 2017-01-27 12:28:30 -0700 | [diff] [blame] | 1512 | bool skip = false; |
Mark Lobodzinski | 6b35c8a | 2019-01-10 10:57:27 -0700 | [diff] [blame] | 1513 | if (image_state) { |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1514 | skip |= ValidateObjectNotInUse(device_data, image_state, obj_struct, "vkDestroyImage", "VUID-vkDestroyImage-image-01000"); |
Mark Lobodzinski | 9ef5d56 | 2017-01-27 12:28:30 -0700 | [diff] [blame] | 1515 | } |
| 1516 | return skip; |
| 1517 | } |
| 1518 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1519 | void CoreChecks::PreCallRecordDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | 6b35c8a | 2019-01-10 10:57:27 -0700 | [diff] [blame] | 1520 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | dfa6411 | 2019-03-04 12:17:24 -0700 | [diff] [blame] | 1521 | if (!image) return; |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 1522 | IMAGE_STATE *image_state = GetImageState(image); |
Mark Lobodzinski | 6b35c8a | 2019-01-10 10:57:27 -0700 | [diff] [blame] | 1523 | VK_OBJECT obj_struct = {HandleToUint64(image), kVulkanObjectTypeImage}; |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1524 | InvalidateCommandBuffers(device_data, image_state->cb_bindings, obj_struct); |
Mark Lobodzinski | 9ef5d56 | 2017-01-27 12:28:30 -0700 | [diff] [blame] | 1525 | // Clean up memory mapping, bindings and range references for image |
| 1526 | for (auto mem_binding : image_state->GetBoundMemory()) { |
Mark Lobodzinski | 97f83f7 | 2019-03-07 10:01:52 -0700 | [diff] [blame] | 1527 | auto mem_info = GetMemObjInfo(mem_binding); |
Mark Lobodzinski | 9ef5d56 | 2017-01-27 12:28:30 -0700 | [diff] [blame] | 1528 | if (mem_info) { |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1529 | RemoveImageMemoryRange(obj_struct.handle, mem_info); |
Mark Lobodzinski | 9ef5d56 | 2017-01-27 12:28:30 -0700 | [diff] [blame] | 1530 | } |
| 1531 | } |
Mark Lobodzinski | 97f83f7 | 2019-03-07 10:01:52 -0700 | [diff] [blame] | 1532 | ClearMemoryObjectBindings(obj_struct.handle, kVulkanObjectTypeImage); |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 1533 | EraseQFOReleaseBarriers<VkImageMemoryBarrier>(device_data, image); |
Mark Lobodzinski | 9ef5d56 | 2017-01-27 12:28:30 -0700 | [diff] [blame] | 1534 | // Remove image from imageMap |
Mark Lobodzinski | 44d46d5 | 2019-03-07 11:04:06 -0700 | [diff] [blame] | 1535 | GetImageMap()->erase(image); |
| 1536 | std::unordered_map<VkImage, std::vector<ImageSubresourcePair>> *imageSubresourceMap = GetImageSubresourceMap(); |
Mark Lobodzinski | 9ef5d56 | 2017-01-27 12:28:30 -0700 | [diff] [blame] | 1537 | |
| 1538 | const auto &sub_entry = imageSubresourceMap->find(image); |
| 1539 | if (sub_entry != imageSubresourceMap->end()) { |
| 1540 | for (const auto &pair : sub_entry->second) { |
Mark Lobodzinski | 44d46d5 | 2019-03-07 11:04:06 -0700 | [diff] [blame] | 1541 | GetImageLayoutMap()->erase(pair); |
Mark Lobodzinski | 9ef5d56 | 2017-01-27 12:28:30 -0700 | [diff] [blame] | 1542 | } |
| 1543 | imageSubresourceMap->erase(sub_entry); |
| 1544 | } |
| 1545 | } |
Mark Lobodzinski | c409a58 | 2017-01-27 15:16:01 -0700 | [diff] [blame] | 1546 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1547 | bool CoreChecks::ValidateImageAttributes(layer_data *device_data, IMAGE_STATE *image_state, VkImageSubresourceRange range) { |
Mark Lobodzinski | c409a58 | 2017-01-27 15:16:01 -0700 | [diff] [blame] | 1548 | bool skip = false; |
Mark Lobodzinski | c409a58 | 2017-01-27 15:16:01 -0700 | [diff] [blame] | 1549 | |
| 1550 | if (range.aspectMask != VK_IMAGE_ASPECT_COLOR_BIT) { |
| 1551 | char const str[] = "vkCmdClearColorImage aspectMasks for all subresource ranges must be set to VK_IMAGE_ASPECT_COLOR_BIT"; |
| 1552 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 1553 | HandleToUint64(image_state->image), kVUID_Core_DrawState_InvalidImageAspect, str); |
Mark Lobodzinski | c409a58 | 2017-01-27 15:16:01 -0700 | [diff] [blame] | 1554 | } |
| 1555 | |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 1556 | if (FormatIsDepthOrStencil(image_state->createInfo.format)) { |
Mark Lobodzinski | c409a58 | 2017-01-27 15:16:01 -0700 | [diff] [blame] | 1557 | char const str[] = "vkCmdClearColorImage called with depth/stencil image."; |
| 1558 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 1559 | HandleToUint64(image_state->image), "VUID-vkCmdClearColorImage-image-00007", "%s.", str); |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 1560 | } else if (FormatIsCompressed(image_state->createInfo.format)) { |
Mark Lobodzinski | c409a58 | 2017-01-27 15:16:01 -0700 | [diff] [blame] | 1561 | char const str[] = "vkCmdClearColorImage called with compressed image."; |
| 1562 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 1563 | HandleToUint64(image_state->image), "VUID-vkCmdClearColorImage-image-00007", "%s.", str); |
Mark Lobodzinski | c409a58 | 2017-01-27 15:16:01 -0700 | [diff] [blame] | 1564 | } |
| 1565 | |
| 1566 | if (!(image_state->createInfo.usage & VK_IMAGE_USAGE_TRANSFER_DST_BIT)) { |
| 1567 | char const str[] = "vkCmdClearColorImage called with image created without VK_IMAGE_USAGE_TRANSFER_DST_BIT."; |
| 1568 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 1569 | HandleToUint64(image_state->image), "VUID-vkCmdClearColorImage-image-00002", "%s.", str); |
Mark Lobodzinski | c409a58 | 2017-01-27 15:16:01 -0700 | [diff] [blame] | 1570 | } |
| 1571 | return skip; |
| 1572 | } |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1573 | |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1574 | uint32_t ResolveRemainingLevels(const VkImageSubresourceRange *range, uint32_t mip_levels) { |
| 1575 | // Return correct number of mip levels taking into account VK_REMAINING_MIP_LEVELS |
| 1576 | uint32_t mip_level_count = range->levelCount; |
Mark Lobodzinski | 9c93dbd | 2017-02-02 08:31:18 -0700 | [diff] [blame] | 1577 | if (range->levelCount == VK_REMAINING_MIP_LEVELS) { |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1578 | mip_level_count = mip_levels - range->baseMipLevel; |
Mark Lobodzinski | 9c93dbd | 2017-02-02 08:31:18 -0700 | [diff] [blame] | 1579 | } |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1580 | return mip_level_count; |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1581 | } |
| 1582 | |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1583 | uint32_t ResolveRemainingLayers(const VkImageSubresourceRange *range, uint32_t layers) { |
| 1584 | // Return correct number of layers taking into account VK_REMAINING_ARRAY_LAYERS |
| 1585 | uint32_t array_layer_count = range->layerCount; |
| 1586 | if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { |
| 1587 | array_layer_count = layers - range->baseArrayLayer; |
Mark Lobodzinski | 9c93dbd | 2017-02-02 08:31:18 -0700 | [diff] [blame] | 1588 | } |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1589 | return array_layer_count; |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1590 | } |
| 1591 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1592 | bool CoreChecks::VerifyClearImageLayout(layer_data *device_data, GLOBAL_CB_NODE *cb_node, IMAGE_STATE *image_state, |
| 1593 | VkImageSubresourceRange range, VkImageLayout dest_image_layout, const char *func_name) { |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1594 | bool skip = false; |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1595 | |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1596 | uint32_t level_count = ResolveRemainingLevels(&range, image_state->createInfo.mipLevels); |
| 1597 | uint32_t layer_count = ResolveRemainingLayers(&range, image_state->createInfo.arrayLayers); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1598 | |
| 1599 | if (dest_image_layout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { |
| 1600 | if (dest_image_layout == VK_IMAGE_LAYOUT_GENERAL) { |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1601 | if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { |
| 1602 | // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. |
Mark Lobodzinski | 0827aec | 2017-03-21 16:41:45 -0600 | [diff] [blame] | 1603 | skip |= log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 1604 | HandleToUint64(image_state->image), kVUID_Core_DrawState_InvalidImageLayout, |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1605 | "%s: Layout for cleared image should be TRANSFER_DST_OPTIMAL instead of GENERAL.", func_name); |
| 1606 | } |
Mark Lobodzinski | 087380c | 2017-05-16 14:42:25 -0600 | [diff] [blame] | 1607 | } else if (VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR == dest_image_layout) { |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 1608 | if (!GetDeviceExtensions()->vk_khr_shared_presentable_image) { |
Tobin Ehlis | fb0661c | 2017-05-11 08:52:51 -0600 | [diff] [blame] | 1609 | // TODO: Add unique error id when available. |
Mark Lobodzinski | 087380c | 2017-05-16 14:42:25 -0600 | [diff] [blame] | 1610 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 1611 | HandleToUint64(image_state->image), 0, |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 1612 | "Must enable VK_KHR_shared_presentable_image extension before creating images with a layout type " |
| 1613 | "of VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR."); |
Mark Lobodzinski | 087380c | 2017-05-16 14:42:25 -0600 | [diff] [blame] | 1614 | |
| 1615 | } else { |
| 1616 | if (image_state->shared_presentable) { |
| 1617 | skip |= log_msg( |
| 1618 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 1619 | HandleToUint64(image_state->image), 0, |
Mark Lobodzinski | 087380c | 2017-05-16 14:42:25 -0600 | [diff] [blame] | 1620 | "Layout for shared presentable cleared image is %s but can only be VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR.", |
| 1621 | string_VkImageLayout(dest_image_layout)); |
| 1622 | } |
Tobin Ehlis | bb03e5f | 2017-05-11 08:52:51 -0600 | [diff] [blame] | 1623 | } |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1624 | } else { |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 1625 | const char *error_code = "VUID-vkCmdClearColorImage-imageLayout-00005"; |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1626 | if (strcmp(func_name, "vkCmdClearDepthStencilImage()") == 0) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 1627 | error_code = "VUID-vkCmdClearDepthStencilImage-imageLayout-00012"; |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1628 | } else { |
| 1629 | assert(strcmp(func_name, "vkCmdClearColorImage()") == 0); |
| 1630 | } |
Mark Lobodzinski | 0827aec | 2017-03-21 16:41:45 -0600 | [diff] [blame] | 1631 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 1632 | HandleToUint64(image_state->image), error_code, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 1633 | "%s: Layout for cleared image is %s but can only be TRANSFER_DST_OPTIMAL or GENERAL.", func_name, |
| 1634 | string_VkImageLayout(dest_image_layout)); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1635 | } |
| 1636 | } |
| 1637 | |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1638 | for (uint32_t level_index = 0; level_index < level_count; ++level_index) { |
| 1639 | uint32_t level = level_index + range.baseMipLevel; |
| 1640 | for (uint32_t layer_index = 0; layer_index < layer_count; ++layer_index) { |
| 1641 | uint32_t layer = layer_index + range.baseArrayLayer; |
| 1642 | VkImageSubresource sub = {range.aspectMask, level, layer}; |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1643 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1644 | if (FindCmdBufLayout(device_data, cb_node, image_state->image, sub, node)) { |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1645 | if (node.layout != dest_image_layout) { |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 1646 | const char *error_code = "VUID-vkCmdClearColorImage-imageLayout-00004"; |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1647 | if (strcmp(func_name, "vkCmdClearDepthStencilImage()") == 0) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 1648 | error_code = "VUID-vkCmdClearDepthStencilImage-imageLayout-00011"; |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1649 | } else { |
| 1650 | assert(strcmp(func_name, "vkCmdClearColorImage()") == 0); |
| 1651 | } |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 1652 | skip |= |
| 1653 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, |
| 1654 | error_code, "%s: Cannot clear an image whose layout is %s and doesn't match the current layout %s.", |
| 1655 | func_name, string_VkImageLayout(dest_image_layout), string_VkImageLayout(node.layout)); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1656 | } |
| 1657 | } |
| 1658 | } |
| 1659 | } |
| 1660 | |
| 1661 | return skip; |
| 1662 | } |
| 1663 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1664 | void CoreChecks::RecordClearImageLayout(layer_data *device_data, GLOBAL_CB_NODE *cb_node, VkImage image, |
| 1665 | VkImageSubresourceRange range, VkImageLayout dest_image_layout) { |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 1666 | VkImageCreateInfo *image_create_info = &(GetImageState(image)->createInfo); |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1667 | uint32_t level_count = ResolveRemainingLevels(&range, image_create_info->mipLevels); |
| 1668 | uint32_t layer_count = ResolveRemainingLayers(&range, image_create_info->arrayLayers); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1669 | |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 1670 | for (uint32_t level_index = 0; level_index < level_count; ++level_index) { |
| 1671 | uint32_t level = level_index + range.baseMipLevel; |
| 1672 | for (uint32_t layer_index = 0; layer_index < layer_count; ++layer_index) { |
| 1673 | uint32_t layer = layer_index + range.baseArrayLayer; |
| 1674 | VkImageSubresource sub = {range.aspectMask, level, layer}; |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1675 | IMAGE_CMD_BUF_LAYOUT_NODE node; |
Mark Lobodzinski | 3c0f636 | 2017-02-01 13:35:48 -0700 | [diff] [blame] | 1676 | if (!FindCmdBufLayout(device_data, cb_node, image, sub, node)) { |
| 1677 | SetLayout(device_data, cb_node, image, sub, IMAGE_CMD_BUF_LAYOUT_NODE(dest_image_layout, dest_image_layout)); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1678 | } |
| 1679 | } |
| 1680 | } |
| 1681 | } |
| 1682 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1683 | bool CoreChecks::PreCallValidateCmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, |
| 1684 | const VkClearColorValue *pColor, uint32_t rangeCount, |
| 1685 | const VkImageSubresourceRange *pRanges) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1686 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| 1687 | |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1688 | bool skip = false; |
| 1689 | // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 1690 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 1691 | auto image_state = GetImageState(image); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1692 | if (cb_node && image_state) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1693 | skip |= ValidateMemoryIsBoundToImage(device_data, image_state, "vkCmdClearColorImage()", |
| 1694 | "VUID-vkCmdClearColorImage-image-00003"); |
| 1695 | skip |= ValidateCmdQueueFlags(device_data, cb_node, "vkCmdClearColorImage()", VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 1696 | "VUID-vkCmdClearColorImage-commandBuffer-cmdpool"); |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1697 | skip |= ValidateCmd(device_data, cb_node, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); |
Mark Lobodzinski | 96d5c6e | 2019-03-07 11:28:21 -0700 | [diff] [blame] | 1698 | if (GetApiVersion() >= VK_API_VERSION_1_1 || GetDeviceExtensions()->vk_khr_maintenance1) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1699 | skip |= ValidateImageFormatFeatureFlags(device_data, image_state, VK_FORMAT_FEATURE_TRANSFER_DST_BIT, |
| 1700 | "vkCmdClearColorImage", "VUID-vkCmdClearColorImage-image-01993", |
| 1701 | "VUID-vkCmdClearColorImage-image-01993"); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 1702 | } |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1703 | skip |= InsideRenderPass(device_data, cb_node, "vkCmdClearColorImage()", "VUID-vkCmdClearColorImage-renderpass"); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1704 | for (uint32_t i = 0; i < rangeCount; ++i) { |
Petr Kraus | 4d71868 | 2017-05-18 03:38:41 +0200 | [diff] [blame] | 1705 | std::string param_name = "pRanges[" + std::to_string(i) + "]"; |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1706 | skip |= ValidateCmdClearColorSubresourceRange(device_data, image_state, pRanges[i], param_name.c_str()); |
| 1707 | skip |= ValidateImageAttributes(device_data, image_state, pRanges[i]); |
| 1708 | skip |= VerifyClearImageLayout(device_data, cb_node, image_state, pRanges[i], imageLayout, "vkCmdClearColorImage()"); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1709 | } |
| 1710 | } |
| 1711 | return skip; |
| 1712 | } |
| 1713 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1714 | void CoreChecks::PreCallRecordCmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, |
| 1715 | const VkClearColorValue *pColor, uint32_t rangeCount, |
| 1716 | const VkImageSubresourceRange *pRanges) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1717 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| 1718 | |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 1719 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 1720 | auto image_state = GetImageState(image); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1721 | if (cb_node && image_state) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1722 | AddCommandBufferBindingImage(device_data, cb_node, image_state); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1723 | for (uint32_t i = 0; i < rangeCount; ++i) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1724 | RecordClearImageLayout(device_data, cb_node, image, pRanges[i], imageLayout); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1725 | } |
| 1726 | } |
| 1727 | } |
| 1728 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1729 | bool CoreChecks::PreCallValidateCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, |
| 1730 | const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, |
| 1731 | const VkImageSubresourceRange *pRanges) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1732 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1733 | bool skip = false; |
Mark Lobodzinski | 1241a31 | 2017-02-01 10:57:21 -0700 | [diff] [blame] | 1734 | |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1735 | // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 1736 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 1737 | auto image_state = GetImageState(image); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1738 | if (cb_node && image_state) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 1739 | skip |= ValidateMemoryIsBoundToImage(device_data, image_state, "vkCmdClearDepthStencilImage()", |
| 1740 | "VUID-vkCmdClearDepthStencilImage-image-00010"); |
Mike Schuchardt | 9c58240 | 2017-02-23 15:57:37 -0700 | [diff] [blame] | 1741 | skip |= ValidateCmdQueueFlags(device_data, cb_node, "vkCmdClearDepthStencilImage()", VK_QUEUE_GRAPHICS_BIT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 1742 | "VUID-vkCmdClearDepthStencilImage-commandBuffer-cmdpool"); |
Mark Lobodzinski | 1241a31 | 2017-02-01 10:57:21 -0700 | [diff] [blame] | 1743 | skip |= ValidateCmd(device_data, cb_node, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); |
Mark Lobodzinski | 96d5c6e | 2019-03-07 11:28:21 -0700 | [diff] [blame] | 1744 | if (GetApiVersion() >= VK_API_VERSION_1_1 || GetDeviceExtensions()->vk_khr_maintenance1) { |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 1745 | skip |= ValidateImageFormatFeatureFlags(device_data, image_state, VK_FORMAT_FEATURE_TRANSFER_DST_BIT, |
Shannon McPherson | 40c0cba | 2018-08-07 13:39:13 -0600 | [diff] [blame] | 1746 | "vkCmdClearDepthStencilImage", "VUID-vkCmdClearDepthStencilImage-image-01994", |
| 1747 | "VUID-vkCmdClearDepthStencilImage-image-01994"); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 1748 | } |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 1749 | skip |= |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 1750 | InsideRenderPass(device_data, cb_node, "vkCmdClearDepthStencilImage()", "VUID-vkCmdClearDepthStencilImage-renderpass"); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1751 | for (uint32_t i = 0; i < rangeCount; ++i) { |
Petr Kraus | 4d71868 | 2017-05-18 03:38:41 +0200 | [diff] [blame] | 1752 | std::string param_name = "pRanges[" + std::to_string(i) + "]"; |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 1753 | skip |= ValidateCmdClearDepthSubresourceRange(device_data, image_state, pRanges[i], param_name.c_str()); |
Mark Lobodzinski | 9c93dbd | 2017-02-02 08:31:18 -0700 | [diff] [blame] | 1754 | skip |= |
| 1755 | VerifyClearImageLayout(device_data, cb_node, image_state, pRanges[i], imageLayout, "vkCmdClearDepthStencilImage()"); |
Mark Lobodzinski | 1241a31 | 2017-02-01 10:57:21 -0700 | [diff] [blame] | 1756 | // Image aspect must be depth or stencil or both |
Dave Houlton | 12befb9 | 2018-06-26 17:16:46 -0600 | [diff] [blame] | 1757 | VkImageAspectFlags valid_aspects = VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT; |
| 1758 | if (((pRanges[i].aspectMask & valid_aspects) == 0) || ((pRanges[i].aspectMask & ~valid_aspects) != 0)) { |
Mark Lobodzinski | 1241a31 | 2017-02-01 10:57:21 -0700 | [diff] [blame] | 1759 | char const str[] = |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 1760 | "vkCmdClearDepthStencilImage aspectMasks for all subresource ranges must be set to VK_IMAGE_ASPECT_DEPTH_BIT " |
| 1761 | "and/or VK_IMAGE_ASPECT_STENCIL_BIT"; |
Mark Lobodzinski | 1241a31 | 2017-02-01 10:57:21 -0700 | [diff] [blame] | 1762 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 1763 | HandleToUint64(commandBuffer), kVUID_Core_DrawState_InvalidImageAspect, str); |
Mark Lobodzinski | 1241a31 | 2017-02-01 10:57:21 -0700 | [diff] [blame] | 1764 | } |
| 1765 | } |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 1766 | if (image_state && !FormatIsDepthOrStencil(image_state->createInfo.format)) { |
Mark Lobodzinski | 1241a31 | 2017-02-01 10:57:21 -0700 | [diff] [blame] | 1767 | char const str[] = "vkCmdClearDepthStencilImage called without a depth/stencil image."; |
Tobin Ehlis | 3c37fb3 | 2017-05-24 09:31:13 -0600 | [diff] [blame] | 1768 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 1769 | HandleToUint64(image), "VUID-vkCmdClearDepthStencilImage-image-00014", "%s.", str); |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1770 | } |
Tobin Ehlis | 4af8c24 | 2017-11-30 13:47:11 -0700 | [diff] [blame] | 1771 | if (VK_IMAGE_USAGE_TRANSFER_DST_BIT != (VK_IMAGE_USAGE_TRANSFER_DST_BIT & image_state->createInfo.usage)) { |
| 1772 | char const str[] = |
| 1773 | "vkCmdClearDepthStencilImage() called with an image that was not created with the VK_IMAGE_USAGE_TRANSFER_DST_BIT " |
| 1774 | "set."; |
| 1775 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 1776 | HandleToUint64(image), "VUID-vkCmdClearDepthStencilImage-image-00009", "%s.", str); |
Tobin Ehlis | 4af8c24 | 2017-11-30 13:47:11 -0700 | [diff] [blame] | 1777 | } |
Mark Lobodzinski | d81d101 | 2017-02-01 09:03:06 -0700 | [diff] [blame] | 1778 | } |
| 1779 | return skip; |
| 1780 | } |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 1781 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1782 | void CoreChecks::PreCallRecordCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, |
| 1783 | const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, |
| 1784 | const VkImageSubresourceRange *pRanges) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1785 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| 1786 | |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 1787 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 1788 | auto image_state = GetImageState(image); |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 1789 | if (cb_node && image_state) { |
| 1790 | AddCommandBufferBindingImage(device_data, cb_node, image_state); |
| 1791 | for (uint32_t i = 0; i < rangeCount; ++i) { |
| 1792 | RecordClearImageLayout(device_data, cb_node, image, pRanges[i], imageLayout); |
| 1793 | } |
| 1794 | } |
| 1795 | } |
| 1796 | |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 1797 | // Returns true if [x, xoffset] and [y, yoffset] overlap |
| 1798 | static bool RangesIntersect(int32_t start, uint32_t start_offset, int32_t end, uint32_t end_offset) { |
| 1799 | bool result = false; |
| 1800 | uint32_t intersection_min = std::max(static_cast<uint32_t>(start), static_cast<uint32_t>(end)); |
| 1801 | uint32_t intersection_max = std::min(static_cast<uint32_t>(start) + start_offset, static_cast<uint32_t>(end) + end_offset); |
| 1802 | |
| 1803 | if (intersection_max > intersection_min) { |
| 1804 | result = true; |
| 1805 | } |
| 1806 | return result; |
| 1807 | } |
| 1808 | |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 1809 | // Returns true if source area of first copy region intersects dest area of second region |
| 1810 | // It is assumed that these are copy regions within a single image (otherwise no possibility of collision) |
| 1811 | static bool RegionIntersects(const VkImageCopy *rgn0, const VkImageCopy *rgn1, VkImageType type, bool is_multiplane) { |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 1812 | bool result = false; |
Dave Houlton | f521761 | 2018-02-02 16:18:52 -0700 | [diff] [blame] | 1813 | |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 1814 | // Separate planes within a multiplane image cannot intersect |
| 1815 | if (is_multiplane && (rgn0->srcSubresource.aspectMask != rgn1->dstSubresource.aspectMask)) { |
Dave Houlton | f521761 | 2018-02-02 16:18:52 -0700 | [diff] [blame] | 1816 | return result; |
| 1817 | } |
| 1818 | |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 1819 | if ((rgn0->srcSubresource.mipLevel == rgn1->dstSubresource.mipLevel) && |
| 1820 | (RangesIntersect(rgn0->srcSubresource.baseArrayLayer, rgn0->srcSubresource.layerCount, rgn1->dstSubresource.baseArrayLayer, |
| 1821 | rgn1->dstSubresource.layerCount))) { |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 1822 | result = true; |
| 1823 | switch (type) { |
| 1824 | case VK_IMAGE_TYPE_3D: |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 1825 | result &= RangesIntersect(rgn0->srcOffset.z, rgn0->extent.depth, rgn1->dstOffset.z, rgn1->extent.depth); |
Tobin Ehlis | 648b1cf | 2018-04-13 15:24:13 -0600 | [diff] [blame] | 1826 | // fall through |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 1827 | case VK_IMAGE_TYPE_2D: |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 1828 | result &= RangesIntersect(rgn0->srcOffset.y, rgn0->extent.height, rgn1->dstOffset.y, rgn1->extent.height); |
Tobin Ehlis | 648b1cf | 2018-04-13 15:24:13 -0600 | [diff] [blame] | 1829 | // fall through |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 1830 | case VK_IMAGE_TYPE_1D: |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 1831 | result &= RangesIntersect(rgn0->srcOffset.x, rgn0->extent.width, rgn1->dstOffset.x, rgn1->extent.width); |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 1832 | break; |
| 1833 | default: |
| 1834 | // Unrecognized or new IMAGE_TYPE enums will be caught in parameter_validation |
| 1835 | assert(false); |
| 1836 | } |
| 1837 | } |
| 1838 | return result; |
| 1839 | } |
| 1840 | |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 1841 | // Returns non-zero if offset and extent exceed image extents |
| 1842 | static const uint32_t x_bit = 1; |
| 1843 | static const uint32_t y_bit = 2; |
| 1844 | static const uint32_t z_bit = 4; |
Dave Houlton | 1150cf5 | 2017-04-27 14:38:11 -0600 | [diff] [blame] | 1845 | static uint32_t ExceedsBounds(const VkOffset3D *offset, const VkExtent3D *extent, const VkExtent3D *image_extent) { |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 1846 | uint32_t result = 0; |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 1847 | // Extents/depths cannot be negative but checks left in for clarity |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 1848 | if ((offset->z + extent->depth > image_extent->depth) || (offset->z < 0) || |
| 1849 | ((offset->z + static_cast<int32_t>(extent->depth)) < 0)) { |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 1850 | result |= z_bit; |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 1851 | } |
| 1852 | if ((offset->y + extent->height > image_extent->height) || (offset->y < 0) || |
| 1853 | ((offset->y + static_cast<int32_t>(extent->height)) < 0)) { |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 1854 | result |= y_bit; |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 1855 | } |
| 1856 | if ((offset->x + extent->width > image_extent->width) || (offset->x < 0) || |
| 1857 | ((offset->x + static_cast<int32_t>(extent->width)) < 0)) { |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 1858 | result |= x_bit; |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 1859 | } |
| 1860 | return result; |
| 1861 | } |
| 1862 | |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1863 | // Test if two VkExtent3D structs are equivalent |
| 1864 | static inline bool IsExtentEqual(const VkExtent3D *extent, const VkExtent3D *other_extent) { |
| 1865 | bool result = true; |
| 1866 | if ((extent->width != other_extent->width) || (extent->height != other_extent->height) || |
| 1867 | (extent->depth != other_extent->depth)) { |
| 1868 | result = false; |
| 1869 | } |
| 1870 | return result; |
| 1871 | } |
| 1872 | |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 1873 | // For image copies between compressed/uncompressed formats, the extent is provided in source image texels |
| 1874 | // Destination image texel extents must be adjusted by block size for the dest validation checks |
| 1875 | VkExtent3D GetAdjustedDestImageExtent(VkFormat src_format, VkFormat dst_format, VkExtent3D extent) { |
| 1876 | VkExtent3D adjusted_extent = extent; |
| 1877 | if ((FormatIsCompressed(src_format) && (!FormatIsCompressed(dst_format)))) { |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 1878 | VkExtent3D block_size = FormatTexelBlockExtent(src_format); |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 1879 | adjusted_extent.width /= block_size.width; |
| 1880 | adjusted_extent.height /= block_size.height; |
| 1881 | adjusted_extent.depth /= block_size.depth; |
| 1882 | } else if ((!FormatIsCompressed(src_format) && (FormatIsCompressed(dst_format)))) { |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 1883 | VkExtent3D block_size = FormatTexelBlockExtent(dst_format); |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 1884 | adjusted_extent.width *= block_size.width; |
| 1885 | adjusted_extent.height *= block_size.height; |
| 1886 | adjusted_extent.depth *= block_size.depth; |
| 1887 | } |
| 1888 | return adjusted_extent; |
| 1889 | } |
| 1890 | |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 1891 | // Returns the effective extent of an image subresource, adjusted for mip level and array depth. |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1892 | static inline VkExtent3D GetImageSubresourceExtent(const IMAGE_STATE *img, const VkImageSubresourceLayers *subresource) { |
| 1893 | const uint32_t mip = subresource->mipLevel; |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 1894 | |
| 1895 | // Return zero extent if mip level doesn't exist |
Dave Houlton | 1150cf5 | 2017-04-27 14:38:11 -0600 | [diff] [blame] | 1896 | if (mip >= img->createInfo.mipLevels) { |
| 1897 | return VkExtent3D{0, 0, 0}; |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 1898 | } |
Dave Houlton | 1150cf5 | 2017-04-27 14:38:11 -0600 | [diff] [blame] | 1899 | |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 1900 | // Don't allow mip adjustment to create 0 dim, but pass along a 0 if that's what subresource specified |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 1901 | VkExtent3D extent = img->createInfo.extent; |
Jeff Bolz | ef40fec | 2018-09-01 22:04:34 -0500 | [diff] [blame] | 1902 | |
Dave Houlton | e48cd11 | 2019-01-03 17:01:18 -0700 | [diff] [blame] | 1903 | // If multi-plane, adjust per-plane extent |
| 1904 | if (FormatIsMultiplane(img->createInfo.format)) { |
| 1905 | VkExtent2D divisors = FindMultiplaneExtentDivisors(img->createInfo.format, subresource->aspectMask); |
| 1906 | extent.width /= divisors.width; |
| 1907 | extent.height /= divisors.height; |
| 1908 | } |
| 1909 | |
Jeff Bolz | ef40fec | 2018-09-01 22:04:34 -0500 | [diff] [blame] | 1910 | if (img->createInfo.flags & VK_IMAGE_CREATE_CORNER_SAMPLED_BIT_NV) { |
| 1911 | extent.width = (0 == extent.width ? 0 : std::max(2U, 1 + ((extent.width - 1) >> mip))); |
Dave Houlton | 142c4cb | 2018-10-17 15:04:41 -0600 | [diff] [blame] | 1912 | extent.height = (0 == extent.height ? 0 : std::max(2U, 1 + ((extent.height - 1) >> mip))); |
Jeff Bolz | ef40fec | 2018-09-01 22:04:34 -0500 | [diff] [blame] | 1913 | extent.depth = (0 == extent.depth ? 0 : std::max(2U, 1 + ((extent.depth - 1) >> mip))); |
| 1914 | } else { |
| 1915 | extent.width = (0 == extent.width ? 0 : std::max(1U, extent.width >> mip)); |
| 1916 | extent.height = (0 == extent.height ? 0 : std::max(1U, extent.height >> mip)); |
| 1917 | extent.depth = (0 == extent.depth ? 0 : std::max(1U, extent.depth >> mip)); |
| 1918 | } |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 1919 | |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 1920 | // Image arrays have an effective z extent that isn't diminished by mip level |
| 1921 | if (VK_IMAGE_TYPE_3D != img->createInfo.imageType) { |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 1922 | extent.depth = img->createInfo.arrayLayers; |
| 1923 | } |
| 1924 | |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1925 | return extent; |
| 1926 | } |
| 1927 | |
| 1928 | // Test if the extent argument has all dimensions set to 0. |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 1929 | static inline bool IsExtentAllZeroes(const VkExtent3D *extent) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1930 | return ((extent->width == 0) && (extent->height == 0) && (extent->depth == 0)); |
| 1931 | } |
| 1932 | |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 1933 | // Test if the extent argument has any dimensions set to 0. |
| 1934 | static inline bool IsExtentSizeZero(const VkExtent3D *extent) { |
| 1935 | return ((extent->width == 0) || (extent->height == 0) || (extent->depth == 0)); |
| 1936 | } |
| 1937 | |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1938 | // Returns the image transfer granularity for a specific image scaled by compressed block size if necessary. |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1939 | VkExtent3D CoreChecks::GetScaledItg(layer_data *device_data, const GLOBAL_CB_NODE *cb_node, const IMAGE_STATE *img) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1940 | // Default to (0, 0, 0) granularity in case we can't find the real granularity for the physical device. |
| 1941 | VkExtent3D granularity = {0, 0, 0}; |
Mark Lobodzinski | 8b0a7b8 | 2019-03-06 16:17:45 -0700 | [diff] [blame] | 1942 | auto pPool = GetCommandPoolNode(cb_node->createInfo.commandPool); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1943 | if (pPool) { |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1944 | granularity = GetPhysicalDeviceState()->queue_family_properties[pPool->queueFamilyIndex].minImageTransferGranularity; |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 1945 | if (FormatIsCompressed(img->createInfo.format)) { |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 1946 | auto block_size = FormatTexelBlockExtent(img->createInfo.format); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1947 | granularity.width *= block_size.width; |
| 1948 | granularity.height *= block_size.height; |
| 1949 | } |
| 1950 | } |
| 1951 | return granularity; |
| 1952 | } |
| 1953 | |
| 1954 | // Test elements of a VkExtent3D structure against alignment constraints contained in another VkExtent3D structure |
| 1955 | static inline bool IsExtentAligned(const VkExtent3D *extent, const VkExtent3D *granularity) { |
| 1956 | bool valid = true; |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 1957 | if ((SafeModulo(extent->depth, granularity->depth) != 0) || (SafeModulo(extent->width, granularity->width) != 0) || |
| 1958 | (SafeModulo(extent->height, granularity->height) != 0)) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1959 | valid = false; |
| 1960 | } |
| 1961 | return valid; |
| 1962 | } |
| 1963 | |
| 1964 | // Check elements of a VkOffset3D structure against a queue family's Image Transfer Granularity values |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1965 | bool CoreChecks::CheckItgOffset(layer_data *device_data, const GLOBAL_CB_NODE *cb_node, const VkOffset3D *offset, |
| 1966 | const VkExtent3D *granularity, const uint32_t i, const char *function, const char *member, |
| 1967 | const char *vuid) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1968 | bool skip = false; |
| 1969 | VkExtent3D offset_extent = {}; |
| 1970 | offset_extent.width = static_cast<uint32_t>(abs(offset->x)); |
| 1971 | offset_extent.height = static_cast<uint32_t>(abs(offset->y)); |
| 1972 | offset_extent.depth = static_cast<uint32_t>(abs(offset->z)); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 1973 | if (IsExtentAllZeroes(granularity)) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1974 | // If the queue family image transfer granularity is (0, 0, 0), then the offset must always be (0, 0, 0) |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 1975 | if (IsExtentAllZeroes(&offset_extent) == false) { |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 1976 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Cort Stratton | 420ebd4 | 2018-05-04 01:12:23 -0400 | [diff] [blame] | 1977 | HandleToUint64(cb_node->commandBuffer), vuid, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 1978 | "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) must be (x=0, y=0, z=0) when the command buffer's queue family " |
| 1979 | "image transfer granularity is (w=0, h=0, d=0).", |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 1980 | function, i, member, offset->x, offset->y, offset->z); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1981 | } |
| 1982 | } else { |
| 1983 | // If the queue family image transfer granularity is not (0, 0, 0), then the offset dimensions must always be even |
| 1984 | // integer multiples of the image transfer granularity. |
| 1985 | if (IsExtentAligned(&offset_extent, granularity) == false) { |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 1986 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Cort Stratton | 420ebd4 | 2018-05-04 01:12:23 -0400 | [diff] [blame] | 1987 | HandleToUint64(cb_node->commandBuffer), vuid, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 1988 | "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) dimensions must be even integer multiples of this command " |
| 1989 | "buffer's queue family image transfer granularity (w=%d, h=%d, d=%d).", |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 1990 | function, i, member, offset->x, offset->y, offset->z, granularity->width, granularity->height, |
| 1991 | granularity->depth); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 1992 | } |
| 1993 | } |
| 1994 | return skip; |
| 1995 | } |
| 1996 | |
| 1997 | // Check elements of a VkExtent3D structure against a queue family's Image Transfer Granularity values |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 1998 | bool CoreChecks::CheckItgExtent(layer_data *device_data, const GLOBAL_CB_NODE *cb_node, const VkExtent3D *extent, |
| 1999 | const VkOffset3D *offset, const VkExtent3D *granularity, const VkExtent3D *subresource_extent, |
| 2000 | const VkImageType image_type, const uint32_t i, const char *function, const char *member, |
| 2001 | const char *vuid) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2002 | bool skip = false; |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 2003 | if (IsExtentAllZeroes(granularity)) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2004 | // If the queue family image transfer granularity is (0, 0, 0), then the extent must always match the image |
| 2005 | // subresource extent. |
| 2006 | if (IsExtentEqual(extent, subresource_extent) == false) { |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 2007 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Cort Stratton | 420ebd4 | 2018-05-04 01:12:23 -0400 | [diff] [blame] | 2008 | HandleToUint64(cb_node->commandBuffer), vuid, |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 2009 | "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d) " |
| 2010 | "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", |
| 2011 | function, i, member, extent->width, extent->height, extent->depth, subresource_extent->width, |
| 2012 | subresource_extent->height, subresource_extent->depth); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2013 | } |
| 2014 | } else { |
| 2015 | // If the queue family image transfer granularity is not (0, 0, 0), then the extent dimensions must always be even |
| 2016 | // integer multiples of the image transfer granularity or the offset + extent dimensions must always match the image |
| 2017 | // subresource extent dimensions. |
| 2018 | VkExtent3D offset_extent_sum = {}; |
| 2019 | offset_extent_sum.width = static_cast<uint32_t>(abs(offset->x)) + extent->width; |
| 2020 | offset_extent_sum.height = static_cast<uint32_t>(abs(offset->y)) + extent->height; |
| 2021 | offset_extent_sum.depth = static_cast<uint32_t>(abs(offset->z)) + extent->depth; |
Mark Lobodzinski | 283ade6 | 2017-10-09 16:36:49 -0600 | [diff] [blame] | 2022 | bool x_ok = true; |
| 2023 | bool y_ok = true; |
| 2024 | bool z_ok = true; |
| 2025 | switch (image_type) { |
| 2026 | case VK_IMAGE_TYPE_3D: |
| 2027 | z_ok = ((0 == SafeModulo(extent->depth, granularity->depth)) || |
| 2028 | (subresource_extent->depth == offset_extent_sum.depth)); |
Tobin Ehlis | 648b1cf | 2018-04-13 15:24:13 -0600 | [diff] [blame] | 2029 | // fall through |
Mark Lobodzinski | 283ade6 | 2017-10-09 16:36:49 -0600 | [diff] [blame] | 2030 | case VK_IMAGE_TYPE_2D: |
| 2031 | y_ok = ((0 == SafeModulo(extent->height, granularity->height)) || |
| 2032 | (subresource_extent->height == offset_extent_sum.height)); |
Tobin Ehlis | 648b1cf | 2018-04-13 15:24:13 -0600 | [diff] [blame] | 2033 | // fall through |
Mark Lobodzinski | 283ade6 | 2017-10-09 16:36:49 -0600 | [diff] [blame] | 2034 | case VK_IMAGE_TYPE_1D: |
| 2035 | x_ok = ((0 == SafeModulo(extent->width, granularity->width)) || |
| 2036 | (subresource_extent->width == offset_extent_sum.width)); |
| 2037 | break; |
| 2038 | default: |
| 2039 | // Unrecognized or new IMAGE_TYPE enums will be caught in parameter_validation |
| 2040 | assert(false); |
| 2041 | } |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2042 | if (!(x_ok && y_ok && z_ok)) { |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 2043 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Cort Stratton | 420ebd4 | 2018-05-04 01:12:23 -0400 | [diff] [blame] | 2044 | HandleToUint64(cb_node->commandBuffer), vuid, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 2045 | "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) dimensions must be even integer multiples of this command " |
| 2046 | "buffer's queue family image transfer granularity (w=%d, h=%d, d=%d) or offset (x=%d, y=%d, z=%d) + " |
| 2047 | "extent (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d).", |
| 2048 | function, i, member, extent->width, extent->height, extent->depth, granularity->width, |
| 2049 | granularity->height, granularity->depth, offset->x, offset->y, offset->z, extent->width, extent->height, |
| 2050 | extent->depth, subresource_extent->width, subresource_extent->height, subresource_extent->depth); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2051 | } |
| 2052 | } |
| 2053 | return skip; |
| 2054 | } |
| 2055 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2056 | bool CoreChecks::ValidateImageMipLevel(layer_data *device_data, const GLOBAL_CB_NODE *cb_node, const IMAGE_STATE *img, |
| 2057 | uint32_t mip_level, const uint32_t i, const char *function, const char *member, |
| 2058 | const char *vuid) { |
Cort Stratton | ff1542a | 2018-05-27 10:49:28 -0700 | [diff] [blame] | 2059 | bool skip = false; |
| 2060 | if (mip_level >= img->createInfo.mipLevels) { |
| 2061 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 2062 | HandleToUint64(cb_node->commandBuffer), vuid, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 2063 | "In %s, pRegions[%u].%s.mipLevel is %u, but provided image %s has %u mip levels.", function, i, member, |
| 2064 | mip_level, report_data->FormatHandle(img->image).c_str(), img->createInfo.mipLevels); |
Cort Stratton | ff1542a | 2018-05-27 10:49:28 -0700 | [diff] [blame] | 2065 | } |
| 2066 | return skip; |
| 2067 | } |
| 2068 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2069 | bool CoreChecks::ValidateImageArrayLayerRange(layer_data *device_data, const GLOBAL_CB_NODE *cb_node, const IMAGE_STATE *img, |
| 2070 | const uint32_t base_layer, const uint32_t layer_count, const uint32_t i, |
| 2071 | const char *function, const char *member, const char *vuid) { |
Cort Stratton | ff1542a | 2018-05-27 10:49:28 -0700 | [diff] [blame] | 2072 | bool skip = false; |
| 2073 | if (base_layer >= img->createInfo.arrayLayers || layer_count > img->createInfo.arrayLayers || |
| 2074 | (base_layer + layer_count) > img->createInfo.arrayLayers) { |
| 2075 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 2076 | HandleToUint64(cb_node->commandBuffer), vuid, |
| 2077 | "In %s, pRegions[%u].%s.baseArrayLayer is %u and .layerCount is " |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 2078 | "%u, but provided image %s has %u array layers.", |
| 2079 | function, i, member, base_layer, layer_count, report_data->FormatHandle(img->image).c_str(), |
| 2080 | img->createInfo.arrayLayers); |
Cort Stratton | ff1542a | 2018-05-27 10:49:28 -0700 | [diff] [blame] | 2081 | } |
| 2082 | return skip; |
| 2083 | } |
| 2084 | |
Mark Lobodzinski | bf0042d | 2018-02-26 16:01:22 -0700 | [diff] [blame] | 2085 | // Check valid usage Image Transfer Granularity requirements for elements of a VkBufferImageCopy structure |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2086 | bool CoreChecks::ValidateCopyBufferImageTransferGranularityRequirements(layer_data *device_data, const GLOBAL_CB_NODE *cb_node, |
| 2087 | const IMAGE_STATE *img, const VkBufferImageCopy *region, |
| 2088 | const uint32_t i, const char *function, const char *vuid) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2089 | bool skip = false; |
Cort Stratton | 420ebd4 | 2018-05-04 01:12:23 -0400 | [diff] [blame] | 2090 | VkExtent3D granularity = GetScaledItg(device_data, cb_node, img); |
| 2091 | skip |= CheckItgOffset(device_data, cb_node, ®ion->imageOffset, &granularity, i, function, "imageOffset", vuid); |
| 2092 | VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->imageSubresource); |
| 2093 | skip |= CheckItgExtent(device_data, cb_node, ®ion->imageExtent, ®ion->imageOffset, &granularity, &subresource_extent, |
| 2094 | img->createInfo.imageType, i, function, "imageExtent", vuid); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2095 | return skip; |
| 2096 | } |
| 2097 | |
Mark Lobodzinski | bf0042d | 2018-02-26 16:01:22 -0700 | [diff] [blame] | 2098 | // Check valid usage Image Transfer Granularity requirements for elements of a VkImageCopy structure |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2099 | bool CoreChecks::ValidateCopyImageTransferGranularityRequirements(layer_data *device_data, const GLOBAL_CB_NODE *cb_node, |
| 2100 | const IMAGE_STATE *src_img, const IMAGE_STATE *dst_img, |
| 2101 | const VkImageCopy *region, const uint32_t i, |
| 2102 | const char *function) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2103 | bool skip = false; |
Mark Lobodzinski | d078880 | 2017-10-19 15:38:59 -0600 | [diff] [blame] | 2104 | // Source image checks |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2105 | VkExtent3D granularity = GetScaledItg(device_data, cb_node, src_img); |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2106 | skip |= CheckItgOffset(device_data, cb_node, ®ion->srcOffset, &granularity, i, function, "srcOffset", |
| 2107 | "VUID-vkCmdCopyImage-srcOffset-01783"); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2108 | VkExtent3D subresource_extent = GetImageSubresourceExtent(src_img, ®ion->srcSubresource); |
Dave Houlton | 94a0037 | 2017-12-14 15:08:47 -0700 | [diff] [blame] | 2109 | const VkExtent3D extent = region->extent; |
Mark Lobodzinski | d078880 | 2017-10-19 15:38:59 -0600 | [diff] [blame] | 2110 | skip |= CheckItgExtent(device_data, cb_node, &extent, ®ion->srcOffset, &granularity, &subresource_extent, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2111 | src_img->createInfo.imageType, i, function, "extent", "VUID-vkCmdCopyImage-srcOffset-01783"); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2112 | |
Mark Lobodzinski | d078880 | 2017-10-19 15:38:59 -0600 | [diff] [blame] | 2113 | // Destination image checks |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2114 | granularity = GetScaledItg(device_data, cb_node, dst_img); |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2115 | skip |= CheckItgOffset(device_data, cb_node, ®ion->dstOffset, &granularity, i, function, "dstOffset", |
| 2116 | "VUID-vkCmdCopyImage-dstOffset-01784"); |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2117 | // Adjust dest extent, if necessary |
Dave Houlton | 94a0037 | 2017-12-14 15:08:47 -0700 | [diff] [blame] | 2118 | const VkExtent3D dest_effective_extent = |
| 2119 | GetAdjustedDestImageExtent(src_img->createInfo.format, dst_img->createInfo.format, extent); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2120 | subresource_extent = GetImageSubresourceExtent(dst_img, ®ion->dstSubresource); |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2121 | skip |= CheckItgExtent(device_data, cb_node, &dest_effective_extent, ®ion->dstOffset, &granularity, &subresource_extent, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2122 | dst_img->createInfo.imageType, i, function, "extent", "VUID-vkCmdCopyImage-dstOffset-01784"); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2123 | return skip; |
| 2124 | } |
| 2125 | |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2126 | // Validate contents of a VkImageCopy struct |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2127 | bool CoreChecks::ValidateImageCopyData(const layer_data *device_data, const debug_report_data *report_data, |
| 2128 | const uint32_t regionCount, const VkImageCopy *ic_regions, const IMAGE_STATE *src_state, |
| 2129 | const IMAGE_STATE *dst_state) { |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2130 | bool skip = false; |
| 2131 | |
| 2132 | for (uint32_t i = 0; i < regionCount; i++) { |
Dave Houlton | 94a0037 | 2017-12-14 15:08:47 -0700 | [diff] [blame] | 2133 | const VkImageCopy region = ic_regions[i]; |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2134 | |
| 2135 | // For comp<->uncomp copies, the copy extent for the dest image must be adjusted |
Dave Houlton | 94a0037 | 2017-12-14 15:08:47 -0700 | [diff] [blame] | 2136 | const VkExtent3D src_copy_extent = region.extent; |
| 2137 | const VkExtent3D dst_copy_extent = |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2138 | GetAdjustedDestImageExtent(src_state->createInfo.format, dst_state->createInfo.format, region.extent); |
| 2139 | |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2140 | bool slice_override = false; |
| 2141 | uint32_t depth_slices = 0; |
| 2142 | |
| 2143 | // Special case for copying between a 1D/2D array and a 3D image |
| 2144 | // TBD: This seems like the only way to reconcile 3 mutually-exclusive VU checks for 2D/3D copies. Heads up. |
| 2145 | if ((VK_IMAGE_TYPE_3D == src_state->createInfo.imageType) && (VK_IMAGE_TYPE_3D != dst_state->createInfo.imageType)) { |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2146 | depth_slices = region.dstSubresource.layerCount; // Slice count from 2D subresource |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2147 | slice_override = (depth_slices != 1); |
| 2148 | } else if ((VK_IMAGE_TYPE_3D == dst_state->createInfo.imageType) && (VK_IMAGE_TYPE_3D != src_state->createInfo.imageType)) { |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2149 | depth_slices = region.srcSubresource.layerCount; // Slice count from 2D subresource |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2150 | slice_override = (depth_slices != 1); |
| 2151 | } |
| 2152 | |
| 2153 | // Do all checks on source image |
| 2154 | // |
| 2155 | if (src_state->createInfo.imageType == VK_IMAGE_TYPE_1D) { |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2156 | if ((0 != region.srcOffset.y) || (1 != src_copy_extent.height)) { |
| 2157 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2158 | HandleToUint64(src_state->image), "VUID-VkImageCopy-srcImage-00146", |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2159 | "vkCmdCopyImage(): pRegion[%d] srcOffset.y is %d and extent.height is %d. For 1D images these must " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2160 | "be 0 and 1, respectively.", |
| 2161 | i, region.srcOffset.y, src_copy_extent.height); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2162 | } |
| 2163 | } |
| 2164 | |
Dave Houlton | 533be9f | 2018-03-26 17:08:30 -0600 | [diff] [blame] | 2165 | // VUID-VkImageCopy-srcImage-01785 |
| 2166 | if ((src_state->createInfo.imageType == VK_IMAGE_TYPE_1D) && ((0 != region.srcOffset.z) || (1 != src_copy_extent.depth))) { |
| 2167 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2168 | HandleToUint64(src_state->image), "VUID-VkImageCopy-srcImage-01785", |
Dave Houlton | 533be9f | 2018-03-26 17:08:30 -0600 | [diff] [blame] | 2169 | "vkCmdCopyImage(): pRegion[%d] srcOffset.z is %d and extent.depth is %d. For 1D images " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2170 | "these must be 0 and 1, respectively.", |
| 2171 | i, region.srcOffset.z, src_copy_extent.depth); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2172 | } |
| 2173 | |
Dave Houlton | 533be9f | 2018-03-26 17:08:30 -0600 | [diff] [blame] | 2174 | // VUID-VkImageCopy-srcImage-01787 |
| 2175 | if ((src_state->createInfo.imageType == VK_IMAGE_TYPE_2D) && (0 != region.srcOffset.z)) { |
| 2176 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2177 | HandleToUint64(src_state->image), "VUID-VkImageCopy-srcImage-01787", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2178 | "vkCmdCopyImage(): pRegion[%d] srcOffset.z is %d. For 2D images the z-offset must be 0.", i, |
| 2179 | region.srcOffset.z); |
Dave Houlton | 533be9f | 2018-03-26 17:08:30 -0600 | [diff] [blame] | 2180 | } |
| 2181 | |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 2182 | if (GetDeviceExtensions()->vk_khr_maintenance1) { |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2183 | if (src_state->createInfo.imageType == VK_IMAGE_TYPE_3D) { |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2184 | if ((0 != region.srcSubresource.baseArrayLayer) || (1 != region.srcSubresource.layerCount)) { |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2185 | skip |= |
| 2186 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2187 | HandleToUint64(src_state->image), "VUID-VkImageCopy-srcImage-00141", |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2188 | "vkCmdCopyImage(): pRegion[%d] srcSubresource.baseArrayLayer is %d and srcSubresource.layerCount " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2189 | "is %d. For VK_IMAGE_TYPE_3D images these must be 0 and 1, respectively.", |
| 2190 | i, region.srcSubresource.baseArrayLayer, region.srcSubresource.layerCount); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2191 | } |
| 2192 | } |
| 2193 | } else { // Pre maint 1 |
| 2194 | if (src_state->createInfo.imageType == VK_IMAGE_TYPE_3D || dst_state->createInfo.imageType == VK_IMAGE_TYPE_3D) { |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2195 | if ((0 != region.srcSubresource.baseArrayLayer) || (1 != region.srcSubresource.layerCount)) { |
Petr Kraus | 13c98a6 | 2017-12-09 00:22:39 +0100 | [diff] [blame] | 2196 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2197 | HandleToUint64(src_state->image), "VUID-VkImageCopy-srcImage-00141", |
Petr Kraus | 13c98a6 | 2017-12-09 00:22:39 +0100 | [diff] [blame] | 2198 | "vkCmdCopyImage(): pRegion[%d] srcSubresource.baseArrayLayer is %d and " |
| 2199 | "srcSubresource.layerCount is %d. For copies with either source or dest of type " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2200 | "VK_IMAGE_TYPE_3D, these must be 0 and 1, respectively.", |
| 2201 | i, region.srcSubresource.baseArrayLayer, region.srcSubresource.layerCount); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2202 | } |
| 2203 | } |
| 2204 | } |
| 2205 | |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2206 | // Source checks that apply only to compressed images (or to _422 images if ycbcr enabled) |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 2207 | bool ext_ycbcr = GetDeviceExtensions()->vk_khr_sampler_ycbcr_conversion; |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2208 | if (FormatIsCompressed(src_state->createInfo.format) || |
| 2209 | (ext_ycbcr && FormatIsSinglePlane_422(src_state->createInfo.format))) { |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 2210 | const VkExtent3D block_size = FormatTexelBlockExtent(src_state->createInfo.format); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2211 | // image offsets must be multiples of block dimensions |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2212 | if ((SafeModulo(region.srcOffset.x, block_size.width) != 0) || |
| 2213 | (SafeModulo(region.srcOffset.y, block_size.height) != 0) || |
| 2214 | (SafeModulo(region.srcOffset.z, block_size.depth) != 0)) { |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 2215 | const char *vuid = ext_ycbcr ? "VUID-VkImageCopy-srcImage-01727" : "VUID-VkImageCopy-srcOffset-00157"; |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2216 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2217 | HandleToUint64(src_state->image), vuid, |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2218 | "vkCmdCopyImage(): pRegion[%d] srcOffset (%d, %d) must be multiples of the compressed image's " |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2219 | "texel width & height (%d, %d).", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2220 | i, region.srcOffset.x, region.srcOffset.y, block_size.width, block_size.height); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2221 | } |
| 2222 | |
Dave Houlton | 94a0037 | 2017-12-14 15:08:47 -0700 | [diff] [blame] | 2223 | const VkExtent3D mip_extent = GetImageSubresourceExtent(src_state, &(region.srcSubresource)); |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2224 | if ((SafeModulo(src_copy_extent.width, block_size.width) != 0) && |
| 2225 | (src_copy_extent.width + region.srcOffset.x != mip_extent.width)) { |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 2226 | const char *vuid = ext_ycbcr ? "VUID-VkImageCopy-srcImage-01728" : "VUID-VkImageCopy-extent-00158"; |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2227 | skip |= |
| 2228 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2229 | HandleToUint64(src_state->image), vuid, |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2230 | "vkCmdCopyImage(): pRegion[%d] extent width (%d) must be a multiple of the compressed texture block " |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2231 | "width (%d), or when added to srcOffset.x (%d) must equal the image subresource width (%d).", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2232 | i, src_copy_extent.width, block_size.width, region.srcOffset.x, mip_extent.width); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2233 | } |
| 2234 | |
Mark Lobodzinski | d078880 | 2017-10-19 15:38:59 -0600 | [diff] [blame] | 2235 | // Extent height must be a multiple of block height, or extent+offset height must equal subresource height |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2236 | if ((SafeModulo(src_copy_extent.height, block_size.height) != 0) && |
| 2237 | (src_copy_extent.height + region.srcOffset.y != mip_extent.height)) { |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 2238 | const char *vuid = ext_ycbcr ? "VUID-VkImageCopy-srcImage-01729" : "VUID-VkImageCopy-extent-00159"; |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2239 | skip |= |
| 2240 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2241 | HandleToUint64(src_state->image), vuid, |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2242 | "vkCmdCopyImage(): pRegion[%d] extent height (%d) must be a multiple of the compressed texture block " |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2243 | "height (%d), or when added to srcOffset.y (%d) must equal the image subresource height (%d).", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2244 | i, src_copy_extent.height, block_size.height, region.srcOffset.y, mip_extent.height); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2245 | } |
| 2246 | |
Mark Lobodzinski | d078880 | 2017-10-19 15:38:59 -0600 | [diff] [blame] | 2247 | // Extent depth must be a multiple of block depth, or extent+offset depth must equal subresource depth |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2248 | uint32_t copy_depth = (slice_override ? depth_slices : src_copy_extent.depth); |
| 2249 | if ((SafeModulo(copy_depth, block_size.depth) != 0) && (copy_depth + region.srcOffset.z != mip_extent.depth)) { |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 2250 | const char *vuid = ext_ycbcr ? "VUID-VkImageCopy-srcImage-01730" : "VUID-VkImageCopy-extent-00160"; |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2251 | skip |= |
| 2252 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2253 | HandleToUint64(src_state->image), vuid, |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2254 | "vkCmdCopyImage(): pRegion[%d] extent width (%d) must be a multiple of the compressed texture block " |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2255 | "depth (%d), or when added to srcOffset.z (%d) must equal the image subresource depth (%d).", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2256 | i, src_copy_extent.depth, block_size.depth, region.srcOffset.z, mip_extent.depth); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2257 | } |
| 2258 | } // Compressed |
| 2259 | |
| 2260 | // Do all checks on dest image |
| 2261 | // |
| 2262 | if (dst_state->createInfo.imageType == VK_IMAGE_TYPE_1D) { |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2263 | if ((0 != region.dstOffset.y) || (1 != dst_copy_extent.height)) { |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 2264 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2265 | HandleToUint64(dst_state->image), "VUID-VkImageCopy-dstImage-00152", |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 2266 | "vkCmdCopyImage(): pRegion[%d] dstOffset.y is %d and dst_copy_extent.height is %d. For 1D images " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2267 | "these must be 0 and 1, respectively.", |
| 2268 | i, region.dstOffset.y, dst_copy_extent.height); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2269 | } |
| 2270 | } |
| 2271 | |
Dave Houlton | 533be9f | 2018-03-26 17:08:30 -0600 | [diff] [blame] | 2272 | // VUID-VkImageCopy-dstImage-01786 |
| 2273 | if ((dst_state->createInfo.imageType == VK_IMAGE_TYPE_1D) && ((0 != region.dstOffset.z) || (1 != dst_copy_extent.depth))) { |
| 2274 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2275 | HandleToUint64(dst_state->image), "VUID-VkImageCopy-dstImage-01786", |
Dave Houlton | 533be9f | 2018-03-26 17:08:30 -0600 | [diff] [blame] | 2276 | "vkCmdCopyImage(): pRegion[%d] dstOffset.z is %d and extent.depth is %d. For 1D images these must be 0 " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2277 | "and 1, respectively.", |
| 2278 | i, region.dstOffset.z, dst_copy_extent.depth); |
Dave Houlton | 533be9f | 2018-03-26 17:08:30 -0600 | [diff] [blame] | 2279 | } |
| 2280 | |
| 2281 | // VUID-VkImageCopy-dstImage-01788 |
| 2282 | if ((dst_state->createInfo.imageType == VK_IMAGE_TYPE_2D) && (0 != region.dstOffset.z)) { |
| 2283 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2284 | HandleToUint64(dst_state->image), "VUID-VkImageCopy-dstImage-01788", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2285 | "vkCmdCopyImage(): pRegion[%d] dstOffset.z is %d. For 2D images the z-offset must be 0.", i, |
| 2286 | region.dstOffset.z); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2287 | } |
| 2288 | |
| 2289 | if (dst_state->createInfo.imageType == VK_IMAGE_TYPE_3D) { |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2290 | if ((0 != region.dstSubresource.baseArrayLayer) || (1 != region.dstSubresource.layerCount)) { |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2291 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2292 | HandleToUint64(dst_state->image), "VUID-VkImageCopy-srcImage-00141", |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2293 | "vkCmdCopyImage(): pRegion[%d] dstSubresource.baseArrayLayer is %d and dstSubresource.layerCount " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2294 | "is %d. For VK_IMAGE_TYPE_3D images these must be 0 and 1, respectively.", |
| 2295 | i, region.dstSubresource.baseArrayLayer, region.dstSubresource.layerCount); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2296 | } |
| 2297 | } |
| 2298 | // VU01199 changed with mnt1 |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 2299 | if (GetDeviceExtensions()->vk_khr_maintenance1) { |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2300 | if (dst_state->createInfo.imageType == VK_IMAGE_TYPE_3D) { |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2301 | if ((0 != region.dstSubresource.baseArrayLayer) || (1 != region.dstSubresource.layerCount)) { |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2302 | skip |= |
| 2303 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2304 | HandleToUint64(dst_state->image), "VUID-VkImageCopy-srcImage-00141", |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2305 | "vkCmdCopyImage(): pRegion[%d] dstSubresource.baseArrayLayer is %d and dstSubresource.layerCount " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2306 | "is %d. For VK_IMAGE_TYPE_3D images these must be 0 and 1, respectively.", |
| 2307 | i, region.dstSubresource.baseArrayLayer, region.dstSubresource.layerCount); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2308 | } |
| 2309 | } |
| 2310 | } else { // Pre maint 1 |
| 2311 | if (src_state->createInfo.imageType == VK_IMAGE_TYPE_3D || dst_state->createInfo.imageType == VK_IMAGE_TYPE_3D) { |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2312 | if ((0 != region.dstSubresource.baseArrayLayer) || (1 != region.dstSubresource.layerCount)) { |
Petr Kraus | 13c98a6 | 2017-12-09 00:22:39 +0100 | [diff] [blame] | 2313 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2314 | HandleToUint64(dst_state->image), "VUID-VkImageCopy-srcImage-00141", |
Petr Kraus | 13c98a6 | 2017-12-09 00:22:39 +0100 | [diff] [blame] | 2315 | "vkCmdCopyImage(): pRegion[%d] dstSubresource.baseArrayLayer is %d and " |
| 2316 | "dstSubresource.layerCount is %d. For copies with either source or dest of type " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2317 | "VK_IMAGE_TYPE_3D, these must be 0 and 1, respectively.", |
| 2318 | i, region.dstSubresource.baseArrayLayer, region.dstSubresource.layerCount); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2319 | } |
| 2320 | } |
| 2321 | } |
| 2322 | |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2323 | // Dest checks that apply only to compressed images (or to _422 images if ycbcr enabled) |
| 2324 | if (FormatIsCompressed(dst_state->createInfo.format) || |
| 2325 | (ext_ycbcr && FormatIsSinglePlane_422(dst_state->createInfo.format))) { |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 2326 | const VkExtent3D block_size = FormatTexelBlockExtent(dst_state->createInfo.format); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2327 | |
| 2328 | // image offsets must be multiples of block dimensions |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2329 | if ((SafeModulo(region.dstOffset.x, block_size.width) != 0) || |
| 2330 | (SafeModulo(region.dstOffset.y, block_size.height) != 0) || |
| 2331 | (SafeModulo(region.dstOffset.z, block_size.depth) != 0)) { |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 2332 | const char *vuid = ext_ycbcr ? "VUID-VkImageCopy-dstImage-01731" : "VUID-VkImageCopy-dstOffset-00162"; |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2333 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2334 | HandleToUint64(dst_state->image), vuid, |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2335 | "vkCmdCopyImage(): pRegion[%d] dstOffset (%d, %d) must be multiples of the compressed image's " |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2336 | "texel width & height (%d, %d).", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2337 | i, region.dstOffset.x, region.dstOffset.y, block_size.width, block_size.height); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2338 | } |
| 2339 | |
Dave Houlton | 94a0037 | 2017-12-14 15:08:47 -0700 | [diff] [blame] | 2340 | const VkExtent3D mip_extent = GetImageSubresourceExtent(dst_state, &(region.dstSubresource)); |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2341 | if ((SafeModulo(dst_copy_extent.width, block_size.width) != 0) && |
| 2342 | (dst_copy_extent.width + region.dstOffset.x != mip_extent.width)) { |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 2343 | const char *vuid = ext_ycbcr ? "VUID-VkImageCopy-dstImage-01732" : "VUID-VkImageCopy-extent-00163"; |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 2344 | skip |= |
| 2345 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2346 | HandleToUint64(dst_state->image), vuid, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 2347 | "vkCmdCopyImage(): pRegion[%d] dst_copy_extent width (%d) must be a multiple of the compressed texture " |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2348 | "block width (%d), or when added to dstOffset.x (%d) must equal the image subresource width (%d).", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2349 | i, dst_copy_extent.width, block_size.width, region.dstOffset.x, mip_extent.width); |
Mark Lobodzinski | d078880 | 2017-10-19 15:38:59 -0600 | [diff] [blame] | 2350 | } |
| 2351 | |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2352 | // Extent height must be a multiple of block height, or dst_copy_extent+offset height must equal subresource height |
| 2353 | if ((SafeModulo(dst_copy_extent.height, block_size.height) != 0) && |
| 2354 | (dst_copy_extent.height + region.dstOffset.y != mip_extent.height)) { |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 2355 | const char *vuid = ext_ycbcr ? "VUID-VkImageCopy-dstImage-01733" : "VUID-VkImageCopy-extent-00164"; |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 2356 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2357 | HandleToUint64(dst_state->image), vuid, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 2358 | "vkCmdCopyImage(): pRegion[%d] dst_copy_extent height (%d) must be a multiple of the compressed " |
| 2359 | "texture block height (%d), or when added to dstOffset.y (%d) must equal the image subresource " |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2360 | "height (%d).", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2361 | i, dst_copy_extent.height, block_size.height, region.dstOffset.y, mip_extent.height); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2362 | } |
| 2363 | |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2364 | // Extent depth must be a multiple of block depth, or dst_copy_extent+offset depth must equal subresource depth |
| 2365 | uint32_t copy_depth = (slice_override ? depth_slices : dst_copy_extent.depth); |
| 2366 | if ((SafeModulo(copy_depth, block_size.depth) != 0) && (copy_depth + region.dstOffset.z != mip_extent.depth)) { |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 2367 | const char *vuid = ext_ycbcr ? "VUID-VkImageCopy-dstImage-01734" : "VUID-VkImageCopy-extent-00165"; |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 2368 | skip |= |
| 2369 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2370 | HandleToUint64(dst_state->image), vuid, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 2371 | "vkCmdCopyImage(): pRegion[%d] dst_copy_extent width (%d) must be a multiple of the compressed texture " |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2372 | "block depth (%d), or when added to dstOffset.z (%d) must equal the image subresource depth (%d).", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2373 | i, dst_copy_extent.depth, block_size.depth, region.dstOffset.z, mip_extent.depth); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2374 | } |
| 2375 | } // Compressed |
| 2376 | } |
| 2377 | return skip; |
| 2378 | } |
| 2379 | |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2380 | // vkCmdCopyImage checks that only apply if the multiplane extension is enabled |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2381 | bool CoreChecks::CopyImageMultiplaneValidation(const layer_data *dev_data, VkCommandBuffer command_buffer, |
| 2382 | const IMAGE_STATE *src_image_state, const IMAGE_STATE *dst_image_state, |
| 2383 | const VkImageCopy region) { |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2384 | bool skip = false; |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2385 | |
| 2386 | // Neither image is multiplane |
| 2387 | if ((!FormatIsMultiplane(src_image_state->createInfo.format)) && (!FormatIsMultiplane(dst_image_state->createInfo.format))) { |
| 2388 | // If neither image is multi-plane the aspectMask member of src and dst must match |
| 2389 | if (region.srcSubresource.aspectMask != region.dstSubresource.aspectMask) { |
| 2390 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2391 | ss << "vkCmdCopyImage(): Copy between non-multiplane images with differing aspectMasks ( 0x" << std::hex |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2392 | << region.srcSubresource.aspectMask << " and 0x" << region.dstSubresource.aspectMask << " )"; |
| 2393 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2394 | HandleToUint64(command_buffer), "VUID-VkImageCopy-srcImage-01551", "%s.", ss.str().c_str()); |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2395 | } |
| 2396 | } else { |
| 2397 | // Source image multiplane checks |
| 2398 | uint32_t planes = FormatPlaneCount(src_image_state->createInfo.format); |
| 2399 | VkImageAspectFlags aspect = region.srcSubresource.aspectMask; |
| 2400 | if ((2 == planes) && (aspect != VK_IMAGE_ASPECT_PLANE_0_BIT_KHR) && (aspect != VK_IMAGE_ASPECT_PLANE_1_BIT_KHR)) { |
| 2401 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2402 | ss << "vkCmdCopyImage(): Source image aspect mask (0x" << std::hex << aspect << ") is invalid for 2-plane format"; |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2403 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2404 | HandleToUint64(command_buffer), "VUID-VkImageCopy-srcImage-01552", "%s.", ss.str().c_str()); |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2405 | } |
| 2406 | if ((3 == planes) && (aspect != VK_IMAGE_ASPECT_PLANE_0_BIT_KHR) && (aspect != VK_IMAGE_ASPECT_PLANE_1_BIT_KHR) && |
| 2407 | (aspect != VK_IMAGE_ASPECT_PLANE_2_BIT_KHR)) { |
| 2408 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2409 | ss << "vkCmdCopyImage(): Source image aspect mask (0x" << std::hex << aspect << ") is invalid for 3-plane format"; |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2410 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2411 | HandleToUint64(command_buffer), "VUID-VkImageCopy-srcImage-01553", "%s.", ss.str().c_str()); |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2412 | } |
| 2413 | // Single-plane to multi-plane |
| 2414 | if ((!FormatIsMultiplane(src_image_state->createInfo.format)) && (FormatIsMultiplane(dst_image_state->createInfo.format)) && |
| 2415 | (VK_IMAGE_ASPECT_COLOR_BIT != aspect)) { |
| 2416 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2417 | ss << "vkCmdCopyImage(): Source image aspect mask (0x" << std::hex << aspect << ") is not VK_IMAGE_ASPECT_COLOR_BIT"; |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2418 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2419 | HandleToUint64(command_buffer), "VUID-VkImageCopy-dstImage-01557", "%s.", ss.str().c_str()); |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2420 | } |
| 2421 | |
| 2422 | // Dest image multiplane checks |
| 2423 | planes = FormatPlaneCount(dst_image_state->createInfo.format); |
| 2424 | aspect = region.dstSubresource.aspectMask; |
| 2425 | if ((2 == planes) && (aspect != VK_IMAGE_ASPECT_PLANE_0_BIT_KHR) && (aspect != VK_IMAGE_ASPECT_PLANE_1_BIT_KHR)) { |
| 2426 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2427 | ss << "vkCmdCopyImage(): Dest image aspect mask (0x" << std::hex << aspect << ") is invalid for 2-plane format"; |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2428 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2429 | HandleToUint64(command_buffer), "VUID-VkImageCopy-dstImage-01554", "%s.", ss.str().c_str()); |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2430 | } |
| 2431 | if ((3 == planes) && (aspect != VK_IMAGE_ASPECT_PLANE_0_BIT_KHR) && (aspect != VK_IMAGE_ASPECT_PLANE_1_BIT_KHR) && |
| 2432 | (aspect != VK_IMAGE_ASPECT_PLANE_2_BIT_KHR)) { |
| 2433 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2434 | ss << "vkCmdCopyImage(): Dest image aspect mask (0x" << std::hex << aspect << ") is invalid for 3-plane format"; |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2435 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2436 | HandleToUint64(command_buffer), "VUID-VkImageCopy-dstImage-01555", "%s.", ss.str().c_str()); |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2437 | } |
| 2438 | // Multi-plane to single-plane |
| 2439 | if ((FormatIsMultiplane(src_image_state->createInfo.format)) && (!FormatIsMultiplane(dst_image_state->createInfo.format)) && |
| 2440 | (VK_IMAGE_ASPECT_COLOR_BIT != aspect)) { |
| 2441 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2442 | ss << "vkCmdCopyImage(): Dest image aspect mask (0x" << std::hex << aspect << ") is not VK_IMAGE_ASPECT_COLOR_BIT"; |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2443 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2444 | HandleToUint64(command_buffer), "VUID-VkImageCopy-srcImage-01556", "%s.", ss.str().c_str()); |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2445 | } |
| 2446 | } |
| 2447 | |
| 2448 | return skip; |
| 2449 | } |
| 2450 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2451 | bool CoreChecks::PreCallValidateCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 2452 | VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| 2453 | const VkImageCopy *pRegions) { |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 2454 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 2455 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 2456 | auto src_image_state = GetImageState(srcImage); |
| 2457 | auto dst_image_state = GetImageState(dstImage); |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 2458 | bool skip = false; |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 2459 | |
| 2460 | skip = ValidateImageCopyData(device_data, report_data, regionCount, pRegions, src_image_state, dst_image_state); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2461 | |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 2462 | VkCommandBuffer command_buffer = cb_node->commandBuffer; |
| 2463 | |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 2464 | for (uint32_t i = 0; i < regionCount; i++) { |
| 2465 | const VkImageCopy region = pRegions[i]; |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2466 | |
| 2467 | // For comp/uncomp copies, the copy extent for the dest image must be adjusted |
| 2468 | VkExtent3D src_copy_extent = region.extent; |
| 2469 | VkExtent3D dst_copy_extent = |
| 2470 | GetAdjustedDestImageExtent(src_image_state->createInfo.format, dst_image_state->createInfo.format, region.extent); |
| 2471 | |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2472 | bool slice_override = false; |
| 2473 | uint32_t depth_slices = 0; |
| 2474 | |
| 2475 | // Special case for copying between a 1D/2D array and a 3D image |
| 2476 | // TBD: This seems like the only way to reconcile 3 mutually-exclusive VU checks for 2D/3D copies. Heads up. |
| 2477 | if ((VK_IMAGE_TYPE_3D == src_image_state->createInfo.imageType) && |
| 2478 | (VK_IMAGE_TYPE_3D != dst_image_state->createInfo.imageType)) { |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2479 | depth_slices = region.dstSubresource.layerCount; // Slice count from 2D subresource |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2480 | slice_override = (depth_slices != 1); |
| 2481 | } else if ((VK_IMAGE_TYPE_3D == dst_image_state->createInfo.imageType) && |
| 2482 | (VK_IMAGE_TYPE_3D != src_image_state->createInfo.imageType)) { |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2483 | depth_slices = region.srcSubresource.layerCount; // Slice count from 2D subresource |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2484 | slice_override = (depth_slices != 1); |
| 2485 | } |
| 2486 | |
Cort Stratton | d619a30 | 2018-05-17 19:46:32 -0700 | [diff] [blame] | 2487 | skip |= ValidateImageSubresourceLayers(device_data, cb_node, ®ion.srcSubresource, "vkCmdCopyImage", "srcSubresource", i); |
| 2488 | skip |= ValidateImageSubresourceLayers(device_data, cb_node, ®ion.dstSubresource, "vkCmdCopyImage", "dstSubresource", i); |
Cort Stratton | ff1542a | 2018-05-27 10:49:28 -0700 | [diff] [blame] | 2489 | skip |= ValidateImageMipLevel(device_data, cb_node, src_image_state, region.srcSubresource.mipLevel, i, "vkCmdCopyImage", |
| 2490 | "srcSubresource", "VUID-vkCmdCopyImage-srcSubresource-01696"); |
| 2491 | skip |= ValidateImageMipLevel(device_data, cb_node, dst_image_state, region.dstSubresource.mipLevel, i, "vkCmdCopyImage", |
| 2492 | "dstSubresource", "VUID-vkCmdCopyImage-dstSubresource-01697"); |
| 2493 | skip |= ValidateImageArrayLayerRange(device_data, cb_node, src_image_state, region.srcSubresource.baseArrayLayer, |
| 2494 | region.srcSubresource.layerCount, i, "vkCmdCopyImage", "srcSubresource", |
| 2495 | "VUID-vkCmdCopyImage-srcSubresource-01698"); |
| 2496 | skip |= ValidateImageArrayLayerRange(device_data, cb_node, dst_image_state, region.dstSubresource.baseArrayLayer, |
| 2497 | region.dstSubresource.layerCount, i, "vkCmdCopyImage", "dstSubresource", |
| 2498 | "VUID-vkCmdCopyImage-dstSubresource-01699"); |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 2499 | |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 2500 | if (GetDeviceExtensions()->vk_khr_maintenance1) { |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2501 | // No chance of mismatch if we're overriding depth slice count |
| 2502 | if (!slice_override) { |
| 2503 | // The number of depth slices in srcSubresource and dstSubresource must match |
| 2504 | // Depth comes from layerCount for 1D,2D resources, from extent.depth for 3D |
| 2505 | uint32_t src_slices = |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2506 | (VK_IMAGE_TYPE_3D == src_image_state->createInfo.imageType ? src_copy_extent.depth |
| 2507 | : region.srcSubresource.layerCount); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2508 | uint32_t dst_slices = |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2509 | (VK_IMAGE_TYPE_3D == dst_image_state->createInfo.imageType ? dst_copy_extent.depth |
| 2510 | : region.dstSubresource.layerCount); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2511 | if (src_slices != dst_slices) { |
| 2512 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2513 | ss << "vkCmdCopyImage(): number of depth slices in source and destination subresources for pRegions[" << i |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2514 | << "] do not match"; |
| 2515 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2516 | HandleToUint64(command_buffer), "VUID-VkImageCopy-extent-00140", "%s.", ss.str().c_str()); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2517 | } |
| 2518 | } |
| 2519 | } else { |
Mike Schuchardt | 64b5bb7 | 2017-03-21 16:33:26 -0600 | [diff] [blame] | 2520 | // For each region the layerCount member of srcSubresource and dstSubresource must match |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2521 | if (region.srcSubresource.layerCount != region.dstSubresource.layerCount) { |
Mike Schuchardt | 64b5bb7 | 2017-03-21 16:33:26 -0600 | [diff] [blame] | 2522 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2523 | ss << "vkCmdCopyImage(): number of layers in source and destination subresources for pRegions[" << i |
Mike Schuchardt | 64b5bb7 | 2017-03-21 16:33:26 -0600 | [diff] [blame] | 2524 | << "] do not match"; |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 2525 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2526 | HandleToUint64(command_buffer), "VUID-VkImageCopy-extent-00140", "%s.", ss.str().c_str()); |
Mike Schuchardt | 64b5bb7 | 2017-03-21 16:33:26 -0600 | [diff] [blame] | 2527 | } |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2528 | } |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 2529 | |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2530 | // Do multiplane-specific checks, if extension enabled |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 2531 | if (GetDeviceExtensions()->vk_khr_sampler_ycbcr_conversion) { |
Dave Houlton | c991cc9 | 2018-03-06 11:08:51 -0700 | [diff] [blame] | 2532 | skip |= CopyImageMultiplaneValidation(device_data, command_buffer, src_image_state, dst_image_state, region); |
| 2533 | } |
| 2534 | |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 2535 | if (!GetDeviceExtensions()->vk_khr_sampler_ycbcr_conversion) { |
Dave Houlton | f521761 | 2018-02-02 16:18:52 -0700 | [diff] [blame] | 2536 | // not multi-plane, the aspectMask member of srcSubresource and dstSubresource must match |
| 2537 | if (region.srcSubresource.aspectMask != region.dstSubresource.aspectMask) { |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2538 | char const str[] = "vkCmdCopyImage(): Src and dest aspectMasks for each region must match"; |
Dave Houlton | f521761 | 2018-02-02 16:18:52 -0700 | [diff] [blame] | 2539 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2540 | HandleToUint64(command_buffer), "VUID-VkImageCopy-aspectMask-00137", "%s.", str); |
Dave Houlton | f521761 | 2018-02-02 16:18:52 -0700 | [diff] [blame] | 2541 | } |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2542 | } |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 2543 | |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 2544 | // For each region, the aspectMask member of srcSubresource must be present in the source image |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2545 | if (!VerifyAspectsPresent(region.srcSubresource.aspectMask, src_image_state->createInfo.format)) { |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 2546 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2547 | ss << "vkCmdCopyImage(): pRegion[" << i |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 2548 | << "] srcSubresource.aspectMask cannot specify aspects not present in source image"; |
| 2549 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2550 | HandleToUint64(command_buffer), "VUID-VkImageCopy-aspectMask-00142", "%s.", ss.str().c_str()); |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 2551 | } |
| 2552 | |
| 2553 | // For each region, the aspectMask member of dstSubresource must be present in the destination image |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2554 | if (!VerifyAspectsPresent(region.dstSubresource.aspectMask, dst_image_state->createInfo.format)) { |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 2555 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2556 | ss << "vkCmdCopyImage(): pRegion[" << i |
| 2557 | << "] dstSubresource.aspectMask cannot specify aspects not present in dest image"; |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 2558 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2559 | HandleToUint64(command_buffer), "VUID-VkImageCopy-aspectMask-00143", "%s.", ss.str().c_str()); |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 2560 | } |
| 2561 | |
Mike Schuchardt | 64b5bb7 | 2017-03-21 16:33:26 -0600 | [diff] [blame] | 2562 | // Check region extents for 1D-1D, 2D-2D, and 3D-3D copies |
| 2563 | if (src_image_state->createInfo.imageType == dst_image_state->createInfo.imageType) { |
| 2564 | // The source region specified by a given element of regions must be a region that is contained within srcImage |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2565 | VkExtent3D img_extent = GetImageSubresourceExtent(src_image_state, &(region.srcSubresource)); |
| 2566 | if (0 != ExceedsBounds(®ion.srcOffset, &src_copy_extent, &img_extent)) { |
Mike Schuchardt | 64b5bb7 | 2017-03-21 16:33:26 -0600 | [diff] [blame] | 2567 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2568 | ss << "vkCmdCopyImage(): Source pRegion[" << i << "] with mipLevel [ " << region.srcSubresource.mipLevel |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2569 | << " ], offset [ " << region.srcOffset.x << ", " << region.srcOffset.y << ", " << region.srcOffset.z |
| 2570 | << " ], extent [ " << src_copy_extent.width << ", " << src_copy_extent.height << ", " << src_copy_extent.depth |
| 2571 | << " ] exceeds the source image dimensions"; |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 2572 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2573 | HandleToUint64(command_buffer), "VUID-vkCmdCopyImage-pRegions-00122", "%s.", ss.str().c_str()); |
Mike Schuchardt | 64b5bb7 | 2017-03-21 16:33:26 -0600 | [diff] [blame] | 2574 | } |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 2575 | |
Mike Schuchardt | 64b5bb7 | 2017-03-21 16:33:26 -0600 | [diff] [blame] | 2576 | // The destination region specified by a given element of regions must be a region that is contained within dst_image |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2577 | img_extent = GetImageSubresourceExtent(dst_image_state, &(region.dstSubresource)); |
| 2578 | if (0 != ExceedsBounds(®ion.dstOffset, &dst_copy_extent, &img_extent)) { |
Mike Schuchardt | 64b5bb7 | 2017-03-21 16:33:26 -0600 | [diff] [blame] | 2579 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2580 | ss << "vkCmdCopyImage(): Dest pRegion[" << i << "] with mipLevel [ " << region.dstSubresource.mipLevel |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2581 | << " ], offset [ " << region.dstOffset.x << ", " << region.dstOffset.y << ", " << region.dstOffset.z |
| 2582 | << " ], extent [ " << dst_copy_extent.width << ", " << dst_copy_extent.height << ", " << dst_copy_extent.depth |
| 2583 | << " ] exceeds the destination image dimensions"; |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 2584 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2585 | HandleToUint64(command_buffer), "VUID-vkCmdCopyImage-pRegions-00123", "%s.", ss.str().c_str()); |
Mike Schuchardt | 64b5bb7 | 2017-03-21 16:33:26 -0600 | [diff] [blame] | 2586 | } |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2587 | } |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 2588 | |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 2589 | // Each dimension offset + extent limits must fall with image subresource extent |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2590 | VkExtent3D subresource_extent = GetImageSubresourceExtent(src_image_state, &(region.srcSubresource)); |
| 2591 | if (slice_override) src_copy_extent.depth = depth_slices; |
| 2592 | uint32_t extent_check = ExceedsBounds(&(region.srcOffset), &src_copy_extent, &subresource_extent); |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 2593 | if (extent_check & x_bit) { |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2594 | skip |= |
| 2595 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 2596 | HandleToUint64(command_buffer), "VUID-VkImageCopy-srcOffset-00144", |
| 2597 | "vkCmdCopyImage(): Source image pRegion %1d x-dimension offset [%1d] + extent [%1d] exceeds subResource " |
| 2598 | "width [%1d].", |
| 2599 | i, region.srcOffset.x, src_copy_extent.width, subresource_extent.width); |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 2600 | } |
| 2601 | |
| 2602 | if (extent_check & y_bit) { |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2603 | skip |= |
| 2604 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 2605 | HandleToUint64(command_buffer), "VUID-VkImageCopy-srcOffset-00145", |
| 2606 | "vkCmdCopyImage(): Source image pRegion %1d y-dimension offset [%1d] + extent [%1d] exceeds subResource " |
| 2607 | "height [%1d].", |
| 2608 | i, region.srcOffset.y, src_copy_extent.height, subresource_extent.height); |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 2609 | } |
| 2610 | if (extent_check & z_bit) { |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2611 | skip |= |
| 2612 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 2613 | HandleToUint64(command_buffer), "VUID-VkImageCopy-srcOffset-00147", |
| 2614 | "vkCmdCopyImage(): Source image pRegion %1d z-dimension offset [%1d] + extent [%1d] exceeds subResource " |
| 2615 | "depth [%1d].", |
| 2616 | i, region.srcOffset.z, src_copy_extent.depth, subresource_extent.depth); |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 2617 | } |
| 2618 | |
Dave Houlton | ee281a5 | 2017-12-08 13:51:02 -0700 | [diff] [blame] | 2619 | // Adjust dest extent if necessary |
| 2620 | subresource_extent = GetImageSubresourceExtent(dst_image_state, &(region.dstSubresource)); |
| 2621 | if (slice_override) dst_copy_extent.depth = depth_slices; |
| 2622 | |
| 2623 | extent_check = ExceedsBounds(&(region.dstOffset), &dst_copy_extent, &subresource_extent); |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 2624 | if (extent_check & x_bit) { |
| 2625 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2626 | HandleToUint64(command_buffer), "VUID-VkImageCopy-dstOffset-00150", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2627 | "vkCmdCopyImage(): Dest image pRegion %1d x-dimension offset [%1d] + extent [%1d] exceeds subResource " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2628 | "width [%1d].", |
| 2629 | i, region.dstOffset.x, dst_copy_extent.width, subresource_extent.width); |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 2630 | } |
| 2631 | if (extent_check & y_bit) { |
| 2632 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2633 | HandleToUint64(command_buffer), "VUID-VkImageCopy-dstOffset-00151", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2634 | "vkCmdCopyImage(): Dest image pRegion %1d y-dimension offset [%1d] + extent [%1d] exceeds subResource " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2635 | "height [%1d].", |
| 2636 | i, region.dstOffset.y, dst_copy_extent.height, subresource_extent.height); |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 2637 | } |
| 2638 | if (extent_check & z_bit) { |
| 2639 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2640 | HandleToUint64(command_buffer), "VUID-VkImageCopy-dstOffset-00153", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2641 | "vkCmdCopyImage(): Dest image pRegion %1d z-dimension offset [%1d] + extent [%1d] exceeds subResource " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2642 | "depth [%1d].", |
| 2643 | i, region.dstOffset.z, dst_copy_extent.depth, subresource_extent.depth); |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 2644 | } |
| 2645 | |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2646 | // The union of all source regions, and the union of all destination regions, specified by the elements of regions, |
| 2647 | // must not overlap in memory |
| 2648 | if (src_image_state->image == dst_image_state->image) { |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 2649 | for (uint32_t j = 0; j < regionCount; j++) { |
| 2650 | if (RegionIntersects(®ion, &pRegions[j], src_image_state->createInfo.imageType, |
Dave Houlton | f521761 | 2018-02-02 16:18:52 -0700 | [diff] [blame] | 2651 | FormatIsMultiplane(src_image_state->createInfo.format))) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2652 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2653 | ss << "vkCmdCopyImage(): pRegions[" << i << "] src overlaps with pRegions[" << j << "]."; |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2654 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2655 | HandleToUint64(command_buffer), "VUID-vkCmdCopyImage-pRegions-00124", "%s.", ss.str().c_str()); |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 2656 | } |
| 2657 | } |
| 2658 | } |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2659 | } |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 2660 | |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2661 | // The formats of src_image and dst_image must be compatible. Formats are considered compatible if their texel size in bytes |
| 2662 | // is the same between both formats. For example, VK_FORMAT_R8G8B8A8_UNORM is compatible with VK_FORMAT_R32_UINT because |
| 2663 | // because both texels are 4 bytes in size. Depth/stencil formats must match exactly. |
Dave Houlton | 1150cf5 | 2017-04-27 14:38:11 -0600 | [diff] [blame] | 2664 | if (FormatIsDepthOrStencil(src_image_state->createInfo.format) || FormatIsDepthOrStencil(dst_image_state->createInfo.format)) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2665 | if (src_image_state->createInfo.format != dst_image_state->createInfo.format) { |
| 2666 | char const str[] = "vkCmdCopyImage called with unmatched source and dest image depth/stencil formats."; |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 2667 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 2668 | HandleToUint64(command_buffer), kVUID_Core_DrawState_MismatchedImageFormat, str); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2669 | } |
| 2670 | } else { |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 2671 | if (!FormatSizesAreEqual(src_image_state->createInfo.format, dst_image_state->createInfo.format, regionCount, pRegions)) { |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2672 | char const str[] = "vkCmdCopyImage called with unmatched source and dest image format sizes."; |
| 2673 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2674 | HandleToUint64(command_buffer), "VUID-vkCmdCopyImage-srcImage-00135", "%s.", str); |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 2675 | } |
| 2676 | } |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2677 | |
Dave Houlton | 33c22b7 | 2017-02-28 13:16:02 -0700 | [diff] [blame] | 2678 | // Source and dest image sample counts must match |
| 2679 | if (src_image_state->createInfo.samples != dst_image_state->createInfo.samples) { |
| 2680 | char const str[] = "vkCmdCopyImage() called on image pair with non-identical sample counts."; |
| 2681 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2682 | HandleToUint64(command_buffer), "VUID-vkCmdCopyImage-srcImage-00136", "%s", str); |
Dave Houlton | 33c22b7 | 2017-02-28 13:16:02 -0700 | [diff] [blame] | 2683 | } |
| 2684 | |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2685 | skip |= ValidateMemoryIsBoundToImage(device_data, src_image_state, "vkCmdCopyImage()", "VUID-vkCmdCopyImage-srcImage-00127"); |
| 2686 | skip |= ValidateMemoryIsBoundToImage(device_data, dst_image_state, "vkCmdCopyImage()", "VUID-vkCmdCopyImage-dstImage-00132"); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2687 | // Validate that SRC & DST images have correct usage flags set |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2688 | skip |= ValidateImageUsageFlags(device_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, |
| 2689 | "VUID-vkCmdCopyImage-srcImage-00126", "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); |
| 2690 | skip |= ValidateImageUsageFlags(device_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, |
| 2691 | "VUID-vkCmdCopyImage-dstImage-00131", "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); |
Mark Lobodzinski | 96d5c6e | 2019-03-07 11:28:21 -0700 | [diff] [blame] | 2692 | if (GetApiVersion() >= VK_API_VERSION_1_1 || GetDeviceExtensions()->vk_khr_maintenance1) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2693 | skip |= |
| 2694 | ValidateImageFormatFeatureFlags(device_data, src_image_state, VK_FORMAT_FEATURE_TRANSFER_SRC_BIT, "vkCmdCopyImage()", |
Shannon McPherson | 40c0cba | 2018-08-07 13:39:13 -0600 | [diff] [blame] | 2695 | "VUID-vkCmdCopyImage-srcImage-01995", "VUID-vkCmdCopyImage-srcImage-01995"); |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2696 | skip |= |
| 2697 | ValidateImageFormatFeatureFlags(device_data, dst_image_state, VK_FORMAT_FEATURE_TRANSFER_DST_BIT, "vkCmdCopyImage()", |
Shannon McPherson | 40c0cba | 2018-08-07 13:39:13 -0600 | [diff] [blame] | 2698 | "VUID-vkCmdCopyImage-dstImage-01996", "VUID-vkCmdCopyImage-dstImage-01996"); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 2699 | } |
Mike Schuchardt | 9c58240 | 2017-02-23 15:57:37 -0700 | [diff] [blame] | 2700 | skip |= ValidateCmdQueueFlags(device_data, cb_node, "vkCmdCopyImage()", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2701 | VK_QUEUE_TRANSFER_BIT | VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| 2702 | "VUID-vkCmdCopyImage-commandBuffer-cmdpool"); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2703 | skip |= ValidateCmd(device_data, cb_node, CMD_COPYIMAGE, "vkCmdCopyImage()"); |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 2704 | skip |= InsideRenderPass(device_data, cb_node, "vkCmdCopyImage()", "VUID-vkCmdCopyImage-renderpass"); |
Tobin Ehlis | c826645 | 2017-04-07 12:20:30 -0600 | [diff] [blame] | 2705 | bool hit_error = false; |
Jeff Bolz | fdd0d85 | 2019-02-03 21:55:12 -0600 | [diff] [blame] | 2706 | const char *invalid_src_layout_vuid = |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 2707 | (src_image_state->shared_presentable && GetDeviceExtensions()->vk_khr_shared_presentable_image) |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 2708 | ? "VUID-vkCmdCopyImage-srcImageLayout-01917" |
| 2709 | : "VUID-vkCmdCopyImage-srcImageLayout-00129"; |
Jeff Bolz | fdd0d85 | 2019-02-03 21:55:12 -0600 | [diff] [blame] | 2710 | const char *invalid_dst_layout_vuid = |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 2711 | (dst_image_state->shared_presentable && GetDeviceExtensions()->vk_khr_shared_presentable_image) |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 2712 | ? "VUID-vkCmdCopyImage-dstImageLayout-01395" |
| 2713 | : "VUID-vkCmdCopyImage-dstImageLayout-00134"; |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 2714 | for (uint32_t i = 0; i < regionCount; ++i) { |
| 2715 | skip |= VerifyImageLayout(device_data, cb_node, src_image_state, pRegions[i].srcSubresource, srcImageLayout, |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 2716 | VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, "vkCmdCopyImage()", invalid_src_layout_vuid, |
| 2717 | "VUID-vkCmdCopyImage-srcImageLayout-00128", &hit_error); |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 2718 | skip |= VerifyImageLayout(device_data, cb_node, dst_image_state, pRegions[i].dstSubresource, dstImageLayout, |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 2719 | VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, "vkCmdCopyImage()", invalid_dst_layout_vuid, |
| 2720 | "VUID-vkCmdCopyImage-dstImageLayout-00133", &hit_error); |
Dave Houlton | 6f9059e | 2017-05-02 17:15:13 -0600 | [diff] [blame] | 2721 | skip |= ValidateCopyImageTransferGranularityRequirements(device_data, cb_node, src_image_state, dst_image_state, |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 2722 | &pRegions[i], i, "vkCmdCopyImage()"); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2723 | } |
| 2724 | |
Mark Lobodzinski | b39d2ec | 2017-02-02 14:38:47 -0700 | [diff] [blame] | 2725 | return skip; |
| 2726 | } |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2727 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2728 | void CoreChecks::PreCallRecordCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 2729 | VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| 2730 | const VkImageCopy *pRegions) { |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 2731 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 2732 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 2733 | auto src_image_state = GetImageState(srcImage); |
| 2734 | auto dst_image_state = GetImageState(dstImage); |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 2735 | |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 2736 | // Make sure that all image slices are updated to correct layout |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 2737 | for (uint32_t i = 0; i < regionCount; ++i) { |
| 2738 | SetImageLayout(device_data, cb_node, src_image_state, pRegions[i].srcSubresource, srcImageLayout); |
| 2739 | SetImageLayout(device_data, cb_node, dst_image_state, pRegions[i].dstSubresource, dstImageLayout); |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 2740 | } |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2741 | // Update bindings between images and cmd buffer |
| 2742 | AddCommandBufferBindingImage(device_data, cb_node, src_image_state); |
| 2743 | AddCommandBufferBindingImage(device_data, cb_node, dst_image_state); |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 2744 | } |
| 2745 | |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2746 | // Returns true if sub_rect is entirely contained within rect |
| 2747 | static inline bool ContainsRect(VkRect2D rect, VkRect2D sub_rect) { |
| 2748 | if ((sub_rect.offset.x < rect.offset.x) || (sub_rect.offset.x + sub_rect.extent.width > rect.offset.x + rect.extent.width) || |
| 2749 | (sub_rect.offset.y < rect.offset.y) || (sub_rect.offset.y + sub_rect.extent.height > rect.offset.y + rect.extent.height)) |
| 2750 | return false; |
| 2751 | return true; |
| 2752 | } |
| 2753 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2754 | bool CoreChecks::ValidateClearAttachmentExtent(layer_data *device_data, VkCommandBuffer command_buffer, uint32_t attachment_index, |
| 2755 | FRAMEBUFFER_STATE *framebuffer, uint32_t fb_attachment, const VkRect2D &render_area, |
| 2756 | uint32_t rect_count, const VkClearRect *clear_rects) { |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2757 | bool skip = false; |
John Zulauf | f258297 | 2019-02-09 14:53:30 -0700 | [diff] [blame] | 2758 | const IMAGE_VIEW_STATE *image_view_state = nullptr; |
| 2759 | if (framebuffer && (fb_attachment != VK_ATTACHMENT_UNUSED) && (fb_attachment < framebuffer->createInfo.attachmentCount)) { |
Mark Lobodzinski | a3a230b | 2019-03-06 15:35:13 -0700 | [diff] [blame] | 2760 | image_view_state = GetImageViewState(framebuffer->createInfo.pAttachments[fb_attachment]); |
John Zulauf | f258297 | 2019-02-09 14:53:30 -0700 | [diff] [blame] | 2761 | } |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2762 | |
| 2763 | for (uint32_t j = 0; j < rect_count; j++) { |
| 2764 | if (!ContainsRect(render_area, clear_rects[j].rect)) { |
| 2765 | skip |= log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 2766 | HandleToUint64(command_buffer), "VUID-vkCmdClearAttachments-pRects-00016", |
| 2767 | "vkCmdClearAttachments(): The area defined by pRects[%d] is not contained in the area of " |
| 2768 | "the current render pass instance.", |
| 2769 | j); |
| 2770 | } |
| 2771 | |
| 2772 | if (image_view_state) { |
| 2773 | // The layers specified by a given element of pRects must be contained within every attachment that |
| 2774 | // pAttachments refers to |
| 2775 | const auto attachment_layer_count = image_view_state->create_info.subresourceRange.layerCount; |
| 2776 | if ((clear_rects[j].baseArrayLayer >= attachment_layer_count) || |
| 2777 | (clear_rects[j].baseArrayLayer + clear_rects[j].layerCount > attachment_layer_count)) { |
| 2778 | skip |= |
| 2779 | log_msg(device_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 2780 | HandleToUint64(command_buffer), "VUID-vkCmdClearAttachments-pRects-00017", |
| 2781 | "vkCmdClearAttachments(): The layers defined in pRects[%d] are not contained in the layers " |
| 2782 | "of pAttachment[%d].", |
| 2783 | j, attachment_index); |
| 2784 | } |
| 2785 | } |
| 2786 | } |
| 2787 | return skip; |
| 2788 | } |
| 2789 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2790 | bool CoreChecks::PreCallValidateCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, |
| 2791 | const VkClearAttachment *pAttachments, uint32_t rectCount, |
| 2792 | const VkClearRect *pRects) { |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 2793 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
| 2794 | |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 2795 | GLOBAL_CB_NODE *cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2796 | |
| 2797 | bool skip = false; |
| 2798 | if (cb_node) { |
Tobin Ehlis | 3c37fb3 | 2017-05-24 09:31:13 -0600 | [diff] [blame] | 2799 | skip |= ValidateCmdQueueFlags(device_data, cb_node, "vkCmdClearAttachments()", VK_QUEUE_GRAPHICS_BIT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2800 | "VUID-vkCmdClearAttachments-commandBuffer-cmdpool"); |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2801 | skip |= ValidateCmd(device_data, cb_node, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2802 | // Warn if this is issued prior to Draw Cmd and clearing the entire attachment |
Chris Forbes | 05375e7 | 2017-04-21 13:15:15 -0700 | [diff] [blame] | 2803 | if (!cb_node->hasDrawCmd && (cb_node->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2804 | (cb_node->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { |
| 2805 | // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) |
Mark Lobodzinski | d833bb7 | 2017-02-22 10:55:30 -0700 | [diff] [blame] | 2806 | // This warning should be made more specific. It'd be best to avoid triggering this test if it's a use that must call |
| 2807 | // CmdClearAttachments. |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 2808 | skip |= |
| 2809 | log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 2810 | HandleToUint64(commandBuffer), kVUID_Core_DrawState_ClearCmdBeforeDraw, |
| 2811 | "vkCmdClearAttachments() issued on command buffer object %s prior to any Draw Cmds. It is recommended you " |
| 2812 | "use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", |
| 2813 | report_data->FormatHandle(commandBuffer).c_str()); |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2814 | } |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 2815 | skip |= OutsideRenderPass(device_data, cb_node, "vkCmdClearAttachments()", "VUID-vkCmdClearAttachments-renderpass"); |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2816 | } |
| 2817 | |
| 2818 | // Validate that attachment is in reference list of active subpass |
| 2819 | if (cb_node->activeRenderPass) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 2820 | const VkRenderPassCreateInfo2KHR *renderpass_create_info = cb_node->activeRenderPass->createInfo.ptr(); |
John Zulauf | f258297 | 2019-02-09 14:53:30 -0700 | [diff] [blame] | 2821 | const uint32_t renderpass_attachment_count = renderpass_create_info->attachmentCount; |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 2822 | const VkSubpassDescription2KHR *subpass_desc = &renderpass_create_info->pSubpasses[cb_node->activeSubpass]; |
Mark Lobodzinski | 74772ca | 2019-03-06 16:15:06 -0700 | [diff] [blame] | 2823 | auto framebuffer = GetFramebufferState(cb_node->activeFramebuffer); |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2824 | const auto &render_area = cb_node->activeRenderPassBeginInfo.renderArea; |
| 2825 | std::shared_ptr<std::vector<VkClearRect>> clear_rect_copy; |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2826 | |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2827 | for (uint32_t attachment_index = 0; attachment_index < attachmentCount; attachment_index++) { |
| 2828 | auto clear_desc = &pAttachments[attachment_index]; |
| 2829 | uint32_t fb_attachment = VK_ATTACHMENT_UNUSED; |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2830 | |
Mark Lobodzinski | ac7e51e | 2017-02-02 15:50:27 -0700 | [diff] [blame] | 2831 | if (0 == clear_desc->aspectMask) { |
| 2832 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2833 | HandleToUint64(commandBuffer), "VUID-VkClearAttachment-aspectMask-requiredbitmask", " "); |
Mark Lobodzinski | ac7e51e | 2017-02-02 15:50:27 -0700 | [diff] [blame] | 2834 | } else if (clear_desc->aspectMask & VK_IMAGE_ASPECT_METADATA_BIT) { |
| 2835 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2836 | HandleToUint64(commandBuffer), "VUID-VkClearAttachment-aspectMask-00020", " "); |
Mark Lobodzinski | ac7e51e | 2017-02-02 15:50:27 -0700 | [diff] [blame] | 2837 | } else if (clear_desc->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { |
John Zulauf | f258297 | 2019-02-09 14:53:30 -0700 | [diff] [blame] | 2838 | uint32_t color_attachment = VK_ATTACHMENT_UNUSED; |
| 2839 | if (clear_desc->colorAttachment < subpass_desc->colorAttachmentCount) { |
| 2840 | color_attachment = subpass_desc->pColorAttachments[clear_desc->colorAttachment].attachment; |
| 2841 | if ((color_attachment != VK_ATTACHMENT_UNUSED) && (color_attachment >= renderpass_attachment_count)) { |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 2842 | skip |= log_msg( |
| 2843 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 2844 | HandleToUint64(commandBuffer), "VUID-vkCmdClearAttachments-aspectMask-02501", |
| 2845 | "vkCmdClearAttachments() pAttachments[%u].colorAttachment=%u is not VK_ATTACHMENT_UNUSED " |
| 2846 | "and not a valid attachment for render pass %s attachmentCount=%u. Subpass %u pColorAttachment[%u]=%u.", |
| 2847 | attachment_index, clear_desc->colorAttachment, |
| 2848 | report_data->FormatHandle(cb_node->activeRenderPass->renderPass).c_str(), cb_node->activeSubpass, |
| 2849 | clear_desc->colorAttachment, color_attachment, renderpass_attachment_count); |
| 2850 | |
John Zulauf | f258297 | 2019-02-09 14:53:30 -0700 | [diff] [blame] | 2851 | color_attachment = VK_ATTACHMENT_UNUSED; // Defensive, prevent lookup past end of renderpass attachment |
| 2852 | } |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2853 | } else { |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 2854 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 2855 | HandleToUint64(commandBuffer), "VUID-vkCmdClearAttachments-aspectMask-02501", |
| 2856 | "vkCmdClearAttachments() pAttachments[%u].colorAttachment=%u out of range for render pass %s" |
| 2857 | " subpass %u. colorAttachmentCount=%u", |
| 2858 | attachment_index, clear_desc->colorAttachment, |
| 2859 | report_data->FormatHandle(cb_node->activeRenderPass->renderPass).c_str(), |
| 2860 | cb_node->activeSubpass, subpass_desc->colorAttachmentCount); |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2861 | } |
John Zulauf | f258297 | 2019-02-09 14:53:30 -0700 | [diff] [blame] | 2862 | fb_attachment = color_attachment; |
| 2863 | |
Mark Lobodzinski | ac7e51e | 2017-02-02 15:50:27 -0700 | [diff] [blame] | 2864 | if ((clear_desc->aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || |
| 2865 | (clear_desc->aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) { |
| 2866 | char const str[] = |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2867 | "vkCmdClearAttachments() aspectMask [%d] must set only VK_IMAGE_ASPECT_COLOR_BIT of a color attachment."; |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2868 | skip |= |
| 2869 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 2870 | HandleToUint64(commandBuffer), "VUID-VkClearAttachment-aspectMask-00019", str, attachment_index); |
Mark Lobodzinski | ac7e51e | 2017-02-02 15:50:27 -0700 | [diff] [blame] | 2871 | } |
| 2872 | } else { // Must be depth and/or stencil |
| 2873 | if (((clear_desc->aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) != VK_IMAGE_ASPECT_DEPTH_BIT) && |
| 2874 | ((clear_desc->aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 2875 | char const str[] = "vkCmdClearAttachments() aspectMask [%d] is not a valid combination of bits."; |
Mark Lobodzinski | ac7e51e | 2017-02-02 15:50:27 -0700 | [diff] [blame] | 2876 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2877 | HandleToUint64(commandBuffer), "VUID-VkClearAttachment-aspectMask-parameter", str, |
| 2878 | attachment_index); |
Mark Lobodzinski | ac7e51e | 2017-02-02 15:50:27 -0700 | [diff] [blame] | 2879 | } |
| 2880 | if (!subpass_desc->pDepthStencilAttachment || |
| 2881 | (subpass_desc->pDepthStencilAttachment->attachment == VK_ATTACHMENT_UNUSED)) { |
| 2882 | skip |= log_msg( |
| 2883 | report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 2884 | HandleToUint64(commandBuffer), kVUID_Core_DrawState_MissingAttachmentReference, |
Mark Lobodzinski | ac7e51e | 2017-02-02 15:50:27 -0700 | [diff] [blame] | 2885 | "vkCmdClearAttachments() depth/stencil clear with no depth/stencil attachment in subpass; ignored"); |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2886 | } else { |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2887 | fb_attachment = subpass_desc->pDepthStencilAttachment->attachment; |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2888 | } |
| 2889 | } |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2890 | if (cb_node->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) { |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2891 | skip |= ValidateClearAttachmentExtent(device_data, commandBuffer, attachment_index, framebuffer, fb_attachment, |
| 2892 | render_area, rectCount, pRects); |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2893 | } else { |
| 2894 | // if a secondary level command buffer inherits the framebuffer from the primary command buffer |
| 2895 | // (see VkCommandBufferInheritanceInfo), this validation must be deferred until queue submit time |
| 2896 | if (!clear_rect_copy) { |
| 2897 | // We need a copy of the clear rectangles that will persist until the last lambda executes |
| 2898 | // but we want to create it as lazily as possible |
| 2899 | clear_rect_copy.reset(new std::vector<VkClearRect>(pRects, pRects + rectCount)); |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2900 | } |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2901 | |
| 2902 | auto val_fn = [device_data, commandBuffer, attachment_index, fb_attachment, rectCount, clear_rect_copy]( |
| 2903 | GLOBAL_CB_NODE *prim_cb, VkFramebuffer fb) { |
| 2904 | assert(rectCount == clear_rect_copy->size()); |
Mark Lobodzinski | 74772ca | 2019-03-06 16:15:06 -0700 | [diff] [blame] | 2905 | FRAMEBUFFER_STATE *framebuffer = device_data->GetFramebufferState(fb); |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2906 | const auto &render_area = prim_cb->activeRenderPassBeginInfo.renderArea; |
| 2907 | bool skip = false; |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2908 | skip = |
| 2909 | device_data->ValidateClearAttachmentExtent(device_data, commandBuffer, attachment_index, framebuffer, |
| 2910 | fb_attachment, render_area, rectCount, clear_rect_copy->data()); |
John Zulauf | 3a548ef | 2019-02-01 16:14:07 -0700 | [diff] [blame] | 2911 | return skip; |
| 2912 | }; |
| 2913 | cb_node->cmd_execute_commands_functions.emplace_back(val_fn); |
Mark Lobodzinski | 2def2bf | 2017-02-02 15:22:50 -0700 | [diff] [blame] | 2914 | } |
| 2915 | } |
| 2916 | } |
| 2917 | return skip; |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 2918 | } |
| 2919 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2920 | bool CoreChecks::PreCallValidateCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 2921 | VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| 2922 | const VkImageResolve *pRegions) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 2923 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 2924 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 2925 | auto src_image_state = GetImageState(srcImage); |
| 2926 | auto dst_image_state = GetImageState(dstImage); |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 2927 | |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 2928 | bool skip = false; |
| 2929 | if (cb_node && src_image_state && dst_image_state) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2930 | skip |= ValidateMemoryIsBoundToImage(device_data, src_image_state, "vkCmdResolveImage()", |
| 2931 | "VUID-vkCmdResolveImage-srcImage-00256"); |
| 2932 | skip |= ValidateMemoryIsBoundToImage(device_data, dst_image_state, "vkCmdResolveImage()", |
| 2933 | "VUID-vkCmdResolveImage-dstImage-00258"); |
| 2934 | skip |= ValidateCmdQueueFlags(device_data, cb_node, "vkCmdResolveImage()", VK_QUEUE_GRAPHICS_BIT, |
| 2935 | "VUID-vkCmdResolveImage-commandBuffer-cmdpool"); |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 2936 | skip |= ValidateCmd(device_data, cb_node, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 2937 | skip |= InsideRenderPass(device_data, cb_node, "vkCmdResolveImage()", "VUID-vkCmdResolveImage-renderpass"); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 2938 | skip |= ValidateImageFormatFeatureFlags(device_data, dst_image_state, VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT, |
Shannon McPherson | 40c0cba | 2018-08-07 13:39:13 -0600 | [diff] [blame] | 2939 | "vkCmdResolveImage()", "VUID-vkCmdResolveImage-dstImage-02003", |
| 2940 | "VUID-vkCmdResolveImage-dstImage-02003"); |
Mark Lobodzinski | 2a3368e | 2017-02-06 15:29:37 -0700 | [diff] [blame] | 2941 | |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 2942 | bool hit_error = false; |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2943 | const char *invalid_src_layout_vuid = |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 2944 | (src_image_state->shared_presentable && GetDeviceExtensions()->vk_khr_shared_presentable_image) |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2945 | ? "VUID-vkCmdResolveImage-srcImageLayout-01400" |
| 2946 | : "VUID-vkCmdResolveImage-srcImageLayout-00261"; |
| 2947 | const char *invalid_dst_layout_vuid = |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 2948 | (dst_image_state->shared_presentable && GetDeviceExtensions()->vk_khr_shared_presentable_image) |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 2949 | ? "VUID-vkCmdResolveImage-dstImageLayout-01401" |
| 2950 | : "VUID-vkCmdResolveImage-dstImageLayout-00263"; |
Mark Lobodzinski | 2a3368e | 2017-02-06 15:29:37 -0700 | [diff] [blame] | 2951 | // For each region, the number of layers in the image subresource should not be zero |
| 2952 | // For each region, src and dest image aspect must be color only |
| 2953 | for (uint32_t i = 0; i < regionCount; i++) { |
Cort Stratton | d619a30 | 2018-05-17 19:46:32 -0700 | [diff] [blame] | 2954 | skip |= ValidateImageSubresourceLayers(device_data, cb_node, &pRegions[i].srcSubresource, "vkCmdResolveImage()", |
| 2955 | "srcSubresource", i); |
| 2956 | skip |= ValidateImageSubresourceLayers(device_data, cb_node, &pRegions[i].dstSubresource, "vkCmdResolveImage()", |
| 2957 | "dstSubresource", i); |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 2958 | skip |= VerifyImageLayout(device_data, cb_node, src_image_state, pRegions[i].srcSubresource, srcImageLayout, |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 2959 | VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, "vkCmdResolveImage()", invalid_src_layout_vuid, |
| 2960 | "VUID-vkCmdResolveImage-srcImageLayout-00260", &hit_error); |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 2961 | skip |= VerifyImageLayout(device_data, cb_node, dst_image_state, pRegions[i].dstSubresource, dstImageLayout, |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 2962 | VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, "vkCmdResolveImage()", invalid_dst_layout_vuid, |
| 2963 | "VUID-vkCmdResolveImage-dstImageLayout-00262", &hit_error); |
Cort Stratton | ff1542a | 2018-05-27 10:49:28 -0700 | [diff] [blame] | 2964 | skip |= ValidateImageMipLevel(device_data, cb_node, src_image_state, pRegions[i].srcSubresource.mipLevel, i, |
| 2965 | "vkCmdResolveImage()", "srcSubresource", "VUID-vkCmdResolveImage-srcSubresource-01709"); |
| 2966 | skip |= ValidateImageMipLevel(device_data, cb_node, dst_image_state, pRegions[i].dstSubresource.mipLevel, i, |
| 2967 | "vkCmdResolveImage()", "dstSubresource", "VUID-vkCmdResolveImage-dstSubresource-01710"); |
| 2968 | skip |= ValidateImageArrayLayerRange(device_data, cb_node, src_image_state, pRegions[i].srcSubresource.baseArrayLayer, |
| 2969 | pRegions[i].srcSubresource.layerCount, i, "vkCmdResolveImage()", "srcSubresource", |
| 2970 | "VUID-vkCmdResolveImage-srcSubresource-01711"); |
| 2971 | skip |= ValidateImageArrayLayerRange(device_data, cb_node, dst_image_state, pRegions[i].dstSubresource.baseArrayLayer, |
| 2972 | pRegions[i].dstSubresource.layerCount, i, "vkCmdResolveImage()", "srcSubresource", |
| 2973 | "VUID-vkCmdResolveImage-dstSubresource-01712"); |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 2974 | |
| 2975 | // layer counts must match |
Mark Lobodzinski | 50fbef1 | 2017-02-06 15:31:33 -0700 | [diff] [blame] | 2976 | if (pRegions[i].srcSubresource.layerCount != pRegions[i].dstSubresource.layerCount) { |
| 2977 | skip |= log_msg( |
| 2978 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2979 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageResolve-layerCount-00267", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2980 | "vkCmdResolveImage(): layerCount in source and destination subresource of pRegions[%d] does not match.", i); |
Mark Lobodzinski | 50fbef1 | 2017-02-06 15:31:33 -0700 | [diff] [blame] | 2981 | } |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 2982 | // For each region, src and dest image aspect must be color only |
Mark Lobodzinski | 2a3368e | 2017-02-06 15:29:37 -0700 | [diff] [blame] | 2983 | if ((pRegions[i].srcSubresource.aspectMask != VK_IMAGE_ASPECT_COLOR_BIT) || |
| 2984 | (pRegions[i].dstSubresource.aspectMask != VK_IMAGE_ASPECT_COLOR_BIT)) { |
| 2985 | char const str[] = |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 2986 | "vkCmdResolveImage(): src and dest aspectMasks for each region must specify only VK_IMAGE_ASPECT_COLOR_BIT"; |
Mark Lobodzinski | 2a3368e | 2017-02-06 15:29:37 -0700 | [diff] [blame] | 2987 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 2988 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageResolve-aspectMask-00266", "%s.", str); |
Mark Lobodzinski | 2a3368e | 2017-02-06 15:29:37 -0700 | [diff] [blame] | 2989 | } |
| 2990 | } |
| 2991 | |
| 2992 | if (src_image_state->createInfo.format != dst_image_state->createInfo.format) { |
| 2993 | char const str[] = "vkCmdResolveImage called with unmatched source and dest formats."; |
Mark Lobodzinski | 50fbef1 | 2017-02-06 15:31:33 -0700 | [diff] [blame] | 2994 | skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 2995 | HandleToUint64(cb_node->commandBuffer), kVUID_Core_DrawState_MismatchedImageFormat, str); |
Mark Lobodzinski | 2a3368e | 2017-02-06 15:29:37 -0700 | [diff] [blame] | 2996 | } |
| 2997 | if (src_image_state->createInfo.imageType != dst_image_state->createInfo.imageType) { |
| 2998 | char const str[] = "vkCmdResolveImage called with unmatched source and dest image types."; |
Mark Lobodzinski | 50fbef1 | 2017-02-06 15:31:33 -0700 | [diff] [blame] | 2999 | skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3000 | HandleToUint64(cb_node->commandBuffer), kVUID_Core_DrawState_MismatchedImageType, str); |
Mark Lobodzinski | 2a3368e | 2017-02-06 15:29:37 -0700 | [diff] [blame] | 3001 | } |
| 3002 | if (src_image_state->createInfo.samples == VK_SAMPLE_COUNT_1_BIT) { |
| 3003 | char const str[] = "vkCmdResolveImage called with source sample count less than 2."; |
| 3004 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3005 | HandleToUint64(cb_node->commandBuffer), "VUID-vkCmdResolveImage-srcImage-00257", "%s.", str); |
Mark Lobodzinski | 2a3368e | 2017-02-06 15:29:37 -0700 | [diff] [blame] | 3006 | } |
| 3007 | if (dst_image_state->createInfo.samples != VK_SAMPLE_COUNT_1_BIT) { |
| 3008 | char const str[] = "vkCmdResolveImage called with dest sample count greater than 1."; |
| 3009 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3010 | HandleToUint64(cb_node->commandBuffer), "VUID-vkCmdResolveImage-dstImage-00259", "%s.", str); |
Mark Lobodzinski | 2a3368e | 2017-02-06 15:29:37 -0700 | [diff] [blame] | 3011 | } |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 3012 | } else { |
| 3013 | assert(0); |
| 3014 | } |
| 3015 | return skip; |
| 3016 | } |
| 3017 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3018 | void CoreChecks::PreCallRecordCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 3019 | VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| 3020 | const VkImageResolve *pRegions) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 3021 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 3022 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 3023 | auto src_image_state = GetImageState(srcImage); |
| 3024 | auto dst_image_state = GetImageState(dstImage); |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 3025 | |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 3026 | // Update bindings between images and cmd buffer |
| 3027 | AddCommandBufferBindingImage(device_data, cb_node, src_image_state); |
| 3028 | AddCommandBufferBindingImage(device_data, cb_node, dst_image_state); |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 3029 | } |
| 3030 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3031 | bool CoreChecks::PreCallValidateCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 3032 | VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| 3033 | const VkImageBlit *pRegions, VkFilter filter) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 3034 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 3035 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 3036 | auto src_image_state = GetImageState(srcImage); |
| 3037 | auto dst_image_state = GetImageState(dstImage); |
Mark Lobodzinski | 9ad9658 | 2017-02-06 14:01:54 -0700 | [diff] [blame] | 3038 | |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 3039 | bool skip = false; |
John Zulauf | 5c2750c | 2018-01-30 15:04:56 -0700 | [diff] [blame] | 3040 | if (cb_node) { |
| 3041 | skip |= ValidateCmd(device_data, cb_node, CMD_BLITIMAGE, "vkCmdBlitImage()"); |
| 3042 | } |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 3043 | if (cb_node && src_image_state && dst_image_state) { |
| 3044 | skip |= ValidateImageSampleCount(device_data, src_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): srcImage", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3045 | "VUID-vkCmdBlitImage-srcImage-00233"); |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 3046 | skip |= ValidateImageSampleCount(device_data, dst_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): dstImage", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3047 | "VUID-vkCmdBlitImage-dstImage-00234"); |
| 3048 | skip |= |
| 3049 | ValidateMemoryIsBoundToImage(device_data, src_image_state, "vkCmdBlitImage()", "VUID-vkCmdBlitImage-srcImage-00220"); |
| 3050 | skip |= |
| 3051 | ValidateMemoryIsBoundToImage(device_data, dst_image_state, "vkCmdBlitImage()", "VUID-vkCmdBlitImage-dstImage-00225"); |
| 3052 | skip |= |
| 3053 | ValidateImageUsageFlags(device_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, |
| 3054 | "VUID-vkCmdBlitImage-srcImage-00219", "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); |
| 3055 | skip |= |
| 3056 | ValidateImageUsageFlags(device_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, |
| 3057 | "VUID-vkCmdBlitImage-dstImage-00224", "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); |
| 3058 | skip |= ValidateCmdQueueFlags(device_data, cb_node, "vkCmdBlitImage()", VK_QUEUE_GRAPHICS_BIT, |
| 3059 | "VUID-vkCmdBlitImage-commandBuffer-cmdpool"); |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 3060 | skip |= ValidateCmd(device_data, cb_node, CMD_BLITIMAGE, "vkCmdBlitImage()"); |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 3061 | skip |= InsideRenderPass(device_data, cb_node, "vkCmdBlitImage()", "VUID-vkCmdBlitImage-renderpass"); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 3062 | skip |= ValidateImageFormatFeatureFlags(device_data, src_image_state, VK_FORMAT_FEATURE_BLIT_SRC_BIT, "vkCmdBlitImage()", |
Shannon McPherson | 40c0cba | 2018-08-07 13:39:13 -0600 | [diff] [blame] | 3063 | "VUID-vkCmdBlitImage-srcImage-01999", "VUID-vkCmdBlitImage-srcImage-01999"); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 3064 | skip |= ValidateImageFormatFeatureFlags(device_data, dst_image_state, VK_FORMAT_FEATURE_BLIT_DST_BIT, "vkCmdBlitImage()", |
Shannon McPherson | 40c0cba | 2018-08-07 13:39:13 -0600 | [diff] [blame] | 3065 | "VUID-vkCmdBlitImage-dstImage-02000", "VUID-vkCmdBlitImage-dstImage-02000"); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 3066 | |
Tobin Ehlis | bb03e5f | 2017-05-11 08:52:51 -0600 | [diff] [blame] | 3067 | // TODO: Need to validate image layouts, which will include layout validation for shared presentable images |
Mark Lobodzinski | 9ad9658 | 2017-02-06 14:01:54 -0700 | [diff] [blame] | 3068 | |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3069 | VkFormat src_format = src_image_state->createInfo.format; |
| 3070 | VkFormat dst_format = dst_image_state->createInfo.format; |
| 3071 | VkImageType src_type = src_image_state->createInfo.imageType; |
| 3072 | VkImageType dst_type = dst_image_state->createInfo.imageType; |
| 3073 | |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 3074 | if (VK_FILTER_LINEAR == filter) { |
| 3075 | skip |= ValidateImageFormatFeatureFlags(device_data, src_image_state, VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT, |
Shannon McPherson | 40c0cba | 2018-08-07 13:39:13 -0600 | [diff] [blame] | 3076 | "vkCmdBlitImage()", "VUID-vkCmdBlitImage-filter-02001", |
| 3077 | "VUID-vkCmdBlitImage-filter-02001"); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 3078 | } else if (VK_FILTER_CUBIC_IMG == filter) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3079 | skip |= ValidateImageFormatFeatureFlags(device_data, src_image_state, |
| 3080 | VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_CUBIC_BIT_IMG, "vkCmdBlitImage()", |
Shannon McPherson | 40c0cba | 2018-08-07 13:39:13 -0600 | [diff] [blame] | 3081 | "VUID-vkCmdBlitImage-filter-02002", "VUID-vkCmdBlitImage-filter-02002"); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3082 | } |
| 3083 | |
| 3084 | if ((VK_FILTER_CUBIC_IMG == filter) && (VK_IMAGE_TYPE_3D != src_type)) { |
| 3085 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3086 | HandleToUint64(cb_node->commandBuffer), "VUID-vkCmdBlitImage-filter-00237", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3087 | "vkCmdBlitImage(): source image type must be VK_IMAGE_TYPE_3D when cubic filtering is specified."); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3088 | } |
| 3089 | |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3090 | if ((VK_SAMPLE_COUNT_1_BIT != src_image_state->createInfo.samples) || |
| 3091 | (VK_SAMPLE_COUNT_1_BIT != dst_image_state->createInfo.samples)) { |
| 3092 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3093 | HandleToUint64(cb_node->commandBuffer), "VUID-vkCmdBlitImage-srcImage-00228", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3094 | "vkCmdBlitImage(): source or dest image has sample count other than VK_SAMPLE_COUNT_1_BIT."); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3095 | } |
| 3096 | |
| 3097 | // Validate consistency for unsigned formats |
| 3098 | if (FormatIsUInt(src_format) != FormatIsUInt(dst_format)) { |
| 3099 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3100 | ss << "vkCmdBlitImage(): If one of srcImage and dstImage images has unsigned integer format, " |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3101 | << "the other one must also have unsigned integer format. " |
| 3102 | << "Source format is " << string_VkFormat(src_format) << " Destination format is " << string_VkFormat(dst_format); |
| 3103 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3104 | HandleToUint64(cb_node->commandBuffer), "VUID-vkCmdBlitImage-srcImage-00230", "%s.", ss.str().c_str()); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3105 | } |
| 3106 | |
| 3107 | // Validate consistency for signed formats |
| 3108 | if (FormatIsSInt(src_format) != FormatIsSInt(dst_format)) { |
| 3109 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3110 | ss << "vkCmdBlitImage(): If one of srcImage and dstImage images has signed integer format, " |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3111 | << "the other one must also have signed integer format. " |
| 3112 | << "Source format is " << string_VkFormat(src_format) << " Destination format is " << string_VkFormat(dst_format); |
| 3113 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3114 | HandleToUint64(cb_node->commandBuffer), "VUID-vkCmdBlitImage-srcImage-00229", "%s.", ss.str().c_str()); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3115 | } |
| 3116 | |
| 3117 | // Validate filter for Depth/Stencil formats |
| 3118 | if (FormatIsDepthOrStencil(src_format) && (filter != VK_FILTER_NEAREST)) { |
| 3119 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3120 | ss << "vkCmdBlitImage(): If the format of srcImage is a depth, stencil, or depth stencil " |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3121 | << "then filter must be VK_FILTER_NEAREST."; |
| 3122 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3123 | HandleToUint64(cb_node->commandBuffer), "VUID-vkCmdBlitImage-srcImage-00232", "%s.", ss.str().c_str()); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3124 | } |
| 3125 | |
| 3126 | // Validate aspect bits and formats for depth/stencil images |
| 3127 | if (FormatIsDepthOrStencil(src_format) || FormatIsDepthOrStencil(dst_format)) { |
| 3128 | if (src_format != dst_format) { |
| 3129 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3130 | ss << "vkCmdBlitImage(): If one of srcImage and dstImage images has a format of depth, stencil or depth " |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3131 | << "stencil, the other one must have exactly the same format. " |
| 3132 | << "Source format is " << string_VkFormat(src_format) << " Destination format is " |
| 3133 | << string_VkFormat(dst_format); |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3134 | skip |= |
| 3135 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3136 | HandleToUint64(cb_node->commandBuffer), "VUID-vkCmdBlitImage-srcImage-00231", "%s.", ss.str().c_str()); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3137 | } |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3138 | } // Depth or Stencil |
| 3139 | |
| 3140 | // Do per-region checks |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3141 | const char *invalid_src_layout_vuid = |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 3142 | (src_image_state->shared_presentable && GetDeviceExtensions()->vk_khr_shared_presentable_image) |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3143 | ? "VUID-vkCmdBlitImage-srcImageLayout-01398" |
| 3144 | : "VUID-vkCmdBlitImage-srcImageLayout-00222"; |
| 3145 | const char *invalid_dst_layout_vuid = |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 3146 | (dst_image_state->shared_presentable && GetDeviceExtensions()->vk_khr_shared_presentable_image) |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3147 | ? "VUID-vkCmdBlitImage-dstImageLayout-01399" |
| 3148 | : "VUID-vkCmdBlitImage-dstImageLayout-00227"; |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 3149 | for (uint32_t i = 0; i < regionCount; i++) { |
| 3150 | const VkImageBlit rgn = pRegions[i]; |
Norbert Garnys | 7bd4c2c | 2017-11-16 10:58:04 +0100 | [diff] [blame] | 3151 | bool hit_error = false; |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 3152 | skip |= VerifyImageLayout(device_data, cb_node, src_image_state, rgn.srcSubresource, srcImageLayout, |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 3153 | VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, "vkCmdBlitImage()", invalid_src_layout_vuid, |
| 3154 | "VUID-vkCmdBlitImage-srcImageLayout-00221", &hit_error); |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 3155 | skip |= VerifyImageLayout(device_data, cb_node, dst_image_state, rgn.dstSubresource, dstImageLayout, |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 3156 | VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, "vkCmdBlitImage()", invalid_dst_layout_vuid, |
| 3157 | "VUID-vkCmdBlitImage-dstImageLayout-00226", &hit_error); |
Cort Stratton | d619a30 | 2018-05-17 19:46:32 -0700 | [diff] [blame] | 3158 | skip |= |
| 3159 | ValidateImageSubresourceLayers(device_data, cb_node, &rgn.srcSubresource, "vkCmdBlitImage()", "srcSubresource", i); |
| 3160 | skip |= |
| 3161 | ValidateImageSubresourceLayers(device_data, cb_node, &rgn.dstSubresource, "vkCmdBlitImage()", "dstSubresource", i); |
Cort Stratton | ff1542a | 2018-05-27 10:49:28 -0700 | [diff] [blame] | 3162 | skip |= ValidateImageMipLevel(device_data, cb_node, src_image_state, rgn.srcSubresource.mipLevel, i, "vkCmdBlitImage()", |
| 3163 | "srcSubresource", "VUID-vkCmdBlitImage-srcSubresource-01705"); |
| 3164 | skip |= ValidateImageMipLevel(device_data, cb_node, dst_image_state, rgn.dstSubresource.mipLevel, i, "vkCmdBlitImage()", |
| 3165 | "dstSubresource", "VUID-vkCmdBlitImage-dstSubresource-01706"); |
| 3166 | skip |= ValidateImageArrayLayerRange(device_data, cb_node, src_image_state, rgn.srcSubresource.baseArrayLayer, |
| 3167 | rgn.srcSubresource.layerCount, i, "vkCmdBlitImage()", "srcSubresource", |
| 3168 | "VUID-vkCmdBlitImage-srcSubresource-01707"); |
| 3169 | skip |= ValidateImageArrayLayerRange(device_data, cb_node, dst_image_state, rgn.dstSubresource.baseArrayLayer, |
| 3170 | rgn.dstSubresource.layerCount, i, "vkCmdBlitImage()", "dstSubresource", |
| 3171 | "VUID-vkCmdBlitImage-dstSubresource-01708"); |
Mark Lobodzinski | 23c8114 | 2017-02-06 15:04:23 -0700 | [diff] [blame] | 3172 | // Warn for zero-sized regions |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3173 | if ((rgn.srcOffsets[0].x == rgn.srcOffsets[1].x) || (rgn.srcOffsets[0].y == rgn.srcOffsets[1].y) || |
| 3174 | (rgn.srcOffsets[0].z == rgn.srcOffsets[1].z)) { |
Mark Lobodzinski | 9ad9658 | 2017-02-06 14:01:54 -0700 | [diff] [blame] | 3175 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3176 | ss << "vkCmdBlitImage(): pRegions[" << i << "].srcOffsets specify a zero-volume area."; |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3177 | skip |= |
| 3178 | log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3179 | HandleToUint64(cb_node->commandBuffer), kVUID_Core_DrawState_InvalidExtents, "%s", ss.str().c_str()); |
Mark Lobodzinski | 9ad9658 | 2017-02-06 14:01:54 -0700 | [diff] [blame] | 3180 | } |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3181 | if ((rgn.dstOffsets[0].x == rgn.dstOffsets[1].x) || (rgn.dstOffsets[0].y == rgn.dstOffsets[1].y) || |
| 3182 | (rgn.dstOffsets[0].z == rgn.dstOffsets[1].z)) { |
Mark Lobodzinski | 9ad9658 | 2017-02-06 14:01:54 -0700 | [diff] [blame] | 3183 | std::stringstream ss; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3184 | ss << "vkCmdBlitImage(): pRegions[" << i << "].dstOffsets specify a zero-volume area."; |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3185 | skip |= |
| 3186 | log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3187 | HandleToUint64(cb_node->commandBuffer), kVUID_Core_DrawState_InvalidExtents, "%s", ss.str().c_str()); |
Mark Lobodzinski | 9ad9658 | 2017-02-06 14:01:54 -0700 | [diff] [blame] | 3188 | } |
Mark Lobodzinski | 23c8114 | 2017-02-06 15:04:23 -0700 | [diff] [blame] | 3189 | |
| 3190 | // Check that src/dst layercounts match |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3191 | if (rgn.srcSubresource.layerCount != rgn.dstSubresource.layerCount) { |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3192 | skip |= log_msg( |
| 3193 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3194 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-layerCount-00239", |
| 3195 | "vkCmdBlitImage(): layerCount in source and destination subresource of pRegions[%d] does not match.", i); |
Mark Lobodzinski | 23c8114 | 2017-02-06 15:04:23 -0700 | [diff] [blame] | 3196 | } |
Mark Lobodzinski | e7e85fd | 2017-02-07 13:44:57 -0700 | [diff] [blame] | 3197 | |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3198 | if (rgn.srcSubresource.aspectMask != rgn.dstSubresource.aspectMask) { |
Mark Lobodzinski | e7e85fd | 2017-02-07 13:44:57 -0700 | [diff] [blame] | 3199 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3200 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-aspectMask-00238", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3201 | "vkCmdBlitImage(): aspectMask members for pRegion[%d] do not match.", i); |
Mark Lobodzinski | e7e85fd | 2017-02-07 13:44:57 -0700 | [diff] [blame] | 3202 | } |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3203 | |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3204 | if (!VerifyAspectsPresent(rgn.srcSubresource.aspectMask, src_format)) { |
| 3205 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3206 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-aspectMask-00241", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3207 | "vkCmdBlitImage(): region [%d] source aspectMask (0x%x) specifies aspects not present in source " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 3208 | "image format %s.", |
| 3209 | i, rgn.srcSubresource.aspectMask, string_VkFormat(src_format)); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3210 | } |
| 3211 | |
| 3212 | if (!VerifyAspectsPresent(rgn.dstSubresource.aspectMask, dst_format)) { |
| 3213 | skip |= log_msg( |
| 3214 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3215 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-aspectMask-00242", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3216 | "vkCmdBlitImage(): region [%d] dest aspectMask (0x%x) specifies aspects not present in dest image format %s.", |
| 3217 | i, rgn.dstSubresource.aspectMask, string_VkFormat(dst_format)); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3218 | } |
| 3219 | |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3220 | // Validate source image offsets |
| 3221 | VkExtent3D src_extent = GetImageSubresourceExtent(src_image_state, &(rgn.srcSubresource)); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3222 | if (VK_IMAGE_TYPE_1D == src_type) { |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3223 | if ((0 != rgn.srcOffsets[0].y) || (1 != rgn.srcOffsets[1].y)) { |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3224 | skip |= |
| 3225 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3226 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-srcImage-00245", |
| 3227 | "vkCmdBlitImage(): region [%d], source image of type VK_IMAGE_TYPE_1D with srcOffset[].y values " |
| 3228 | "of (%1d, %1d). These must be (0, 1).", |
| 3229 | i, rgn.srcOffsets[0].y, rgn.srcOffsets[1].y); |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3230 | } |
| 3231 | } |
| 3232 | |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3233 | if ((VK_IMAGE_TYPE_1D == src_type) || (VK_IMAGE_TYPE_2D == src_type)) { |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3234 | if ((0 != rgn.srcOffsets[0].z) || (1 != rgn.srcOffsets[1].z)) { |
| 3235 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3236 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-srcImage-00247", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3237 | "vkCmdBlitImage(): region [%d], source image of type VK_IMAGE_TYPE_1D or VK_IMAGE_TYPE_2D with " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 3238 | "srcOffset[].z values of (%1d, %1d). These must be (0, 1).", |
| 3239 | i, rgn.srcOffsets[0].z, rgn.srcOffsets[1].z); |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3240 | } |
| 3241 | } |
| 3242 | |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3243 | bool oob = false; |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3244 | if ((rgn.srcOffsets[0].x < 0) || (rgn.srcOffsets[0].x > static_cast<int32_t>(src_extent.width)) || |
| 3245 | (rgn.srcOffsets[1].x < 0) || (rgn.srcOffsets[1].x > static_cast<int32_t>(src_extent.width))) { |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3246 | oob = true; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3247 | skip |= log_msg( |
| 3248 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3249 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-srcOffset-00243", |
| 3250 | "vkCmdBlitImage(): region [%d] srcOffset[].x values (%1d, %1d) exceed srcSubresource width extent (%1d).", i, |
| 3251 | rgn.srcOffsets[0].x, rgn.srcOffsets[1].x, src_extent.width); |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3252 | } |
| 3253 | if ((rgn.srcOffsets[0].y < 0) || (rgn.srcOffsets[0].y > static_cast<int32_t>(src_extent.height)) || |
| 3254 | (rgn.srcOffsets[1].y < 0) || (rgn.srcOffsets[1].y > static_cast<int32_t>(src_extent.height))) { |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3255 | oob = true; |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3256 | skip |= log_msg( |
| 3257 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3258 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-srcOffset-00244", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3259 | "vkCmdBlitImage(): region [%d] srcOffset[].y values (%1d, %1d) exceed srcSubresource height extent (%1d).", i, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 3260 | rgn.srcOffsets[0].y, rgn.srcOffsets[1].y, src_extent.height); |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3261 | } |
| 3262 | if ((rgn.srcOffsets[0].z < 0) || (rgn.srcOffsets[0].z > static_cast<int32_t>(src_extent.depth)) || |
| 3263 | (rgn.srcOffsets[1].z < 0) || (rgn.srcOffsets[1].z > static_cast<int32_t>(src_extent.depth))) { |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3264 | oob = true; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3265 | skip |= log_msg( |
| 3266 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3267 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-srcOffset-00246", |
| 3268 | "vkCmdBlitImage(): region [%d] srcOffset[].z values (%1d, %1d) exceed srcSubresource depth extent (%1d).", i, |
| 3269 | rgn.srcOffsets[0].z, rgn.srcOffsets[1].z, src_extent.depth); |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3270 | } |
Cort Stratton | ff1542a | 2018-05-27 10:49:28 -0700 | [diff] [blame] | 3271 | if (oob) { |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3272 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3273 | HandleToUint64(cb_node->commandBuffer), "VUID-vkCmdBlitImage-pRegions-00215", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3274 | "vkCmdBlitImage(): region [%d] source image blit region exceeds image dimensions.", i); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3275 | } |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3276 | |
| 3277 | // Validate dest image offsets |
| 3278 | VkExtent3D dst_extent = GetImageSubresourceExtent(dst_image_state, &(rgn.dstSubresource)); |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3279 | if (VK_IMAGE_TYPE_1D == dst_type) { |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3280 | if ((0 != rgn.dstOffsets[0].y) || (1 != rgn.dstOffsets[1].y)) { |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3281 | skip |= |
| 3282 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3283 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-dstImage-00250", |
| 3284 | "vkCmdBlitImage(): region [%d], dest image of type VK_IMAGE_TYPE_1D with dstOffset[].y values of " |
| 3285 | "(%1d, %1d). These must be (0, 1).", |
| 3286 | i, rgn.dstOffsets[0].y, rgn.dstOffsets[1].y); |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3287 | } |
| 3288 | } |
| 3289 | |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3290 | if ((VK_IMAGE_TYPE_1D == dst_type) || (VK_IMAGE_TYPE_2D == dst_type)) { |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3291 | if ((0 != rgn.dstOffsets[0].z) || (1 != rgn.dstOffsets[1].z)) { |
| 3292 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3293 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-dstImage-00252", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3294 | "vkCmdBlitImage(): region [%d], dest image of type VK_IMAGE_TYPE_1D or VK_IMAGE_TYPE_2D with " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 3295 | "dstOffset[].z values of (%1d, %1d). These must be (0, 1).", |
| 3296 | i, rgn.dstOffsets[0].z, rgn.dstOffsets[1].z); |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3297 | } |
| 3298 | } |
| 3299 | |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3300 | oob = false; |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3301 | if ((rgn.dstOffsets[0].x < 0) || (rgn.dstOffsets[0].x > static_cast<int32_t>(dst_extent.width)) || |
| 3302 | (rgn.dstOffsets[1].x < 0) || (rgn.dstOffsets[1].x > static_cast<int32_t>(dst_extent.width))) { |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3303 | oob = true; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3304 | skip |= log_msg( |
| 3305 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3306 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-dstOffset-00248", |
| 3307 | "vkCmdBlitImage(): region [%d] dstOffset[].x values (%1d, %1d) exceed dstSubresource width extent (%1d).", i, |
| 3308 | rgn.dstOffsets[0].x, rgn.dstOffsets[1].x, dst_extent.width); |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3309 | } |
| 3310 | if ((rgn.dstOffsets[0].y < 0) || (rgn.dstOffsets[0].y > static_cast<int32_t>(dst_extent.height)) || |
| 3311 | (rgn.dstOffsets[1].y < 0) || (rgn.dstOffsets[1].y > static_cast<int32_t>(dst_extent.height))) { |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3312 | oob = true; |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3313 | skip |= log_msg( |
| 3314 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3315 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-dstOffset-00249", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3316 | "vkCmdBlitImage(): region [%d] dstOffset[].y values (%1d, %1d) exceed dstSubresource height extent (%1d).", i, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 3317 | rgn.dstOffsets[0].y, rgn.dstOffsets[1].y, dst_extent.height); |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3318 | } |
| 3319 | if ((rgn.dstOffsets[0].z < 0) || (rgn.dstOffsets[0].z > static_cast<int32_t>(dst_extent.depth)) || |
| 3320 | (rgn.dstOffsets[1].z < 0) || (rgn.dstOffsets[1].z > static_cast<int32_t>(dst_extent.depth))) { |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3321 | oob = true; |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3322 | skip |= log_msg( |
| 3323 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3324 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-dstOffset-00251", |
| 3325 | "vkCmdBlitImage(): region [%d] dstOffset[].z values (%1d, %1d) exceed dstSubresource depth extent (%1d).", i, |
| 3326 | rgn.dstOffsets[0].z, rgn.dstOffsets[1].z, dst_extent.depth); |
Dave Houlton | 48989f3 | 2017-05-26 15:01:46 -0600 | [diff] [blame] | 3327 | } |
Cort Stratton | ff1542a | 2018-05-27 10:49:28 -0700 | [diff] [blame] | 3328 | if (oob) { |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3329 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3330 | HandleToUint64(cb_node->commandBuffer), "VUID-vkCmdBlitImage-pRegions-00216", |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3331 | "vkCmdBlitImage(): region [%d] destination image blit region exceeds image dimensions.", i); |
Mark Lobodzinski | 9ad9658 | 2017-02-06 14:01:54 -0700 | [diff] [blame] | 3332 | } |
| 3333 | |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3334 | if ((VK_IMAGE_TYPE_3D == src_type) || (VK_IMAGE_TYPE_3D == dst_type)) { |
| 3335 | if ((0 != rgn.srcSubresource.baseArrayLayer) || (1 != rgn.srcSubresource.layerCount) || |
| 3336 | (0 != rgn.dstSubresource.baseArrayLayer) || (1 != rgn.dstSubresource.layerCount)) { |
Graeme Leese | 79b60cb | 2018-11-28 11:51:20 +0000 | [diff] [blame] | 3337 | skip |= |
| 3338 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3339 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageBlit-srcImage-00240", |
| 3340 | "vkCmdBlitImage(): region [%d] blit to/from a 3D image type with a non-zero baseArrayLayer, or a " |
| 3341 | "layerCount other than 1.", |
| 3342 | i); |
Mark Lobodzinski | 9ad9658 | 2017-02-06 14:01:54 -0700 | [diff] [blame] | 3343 | } |
| 3344 | } |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3345 | } // per-region checks |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 3346 | } else { |
| 3347 | assert(0); |
| 3348 | } |
| 3349 | return skip; |
| 3350 | } |
| 3351 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3352 | void CoreChecks::PreCallRecordCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 3353 | VkImage dstImage, VkImageLayout dstImageLayout, uint32_t regionCount, |
| 3354 | const VkImageBlit *pRegions, VkFilter filter) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 3355 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 3356 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 3357 | auto src_image_state = GetImageState(srcImage); |
| 3358 | auto dst_image_state = GetImageState(dstImage); |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 3359 | |
Norbert Garnys | 7bd4c2c | 2017-11-16 10:58:04 +0100 | [diff] [blame] | 3360 | // Make sure that all image slices are updated to correct layout |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 3361 | for (uint32_t i = 0; i < regionCount; ++i) { |
| 3362 | SetImageLayout(device_data, cb_node, src_image_state, pRegions[i].srcSubresource, srcImageLayout); |
| 3363 | SetImageLayout(device_data, cb_node, dst_image_state, pRegions[i].dstSubresource, dstImageLayout); |
Norbert Garnys | 7bd4c2c | 2017-11-16 10:58:04 +0100 | [diff] [blame] | 3364 | } |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 3365 | // Update bindings between images and cmd buffer |
| 3366 | AddCommandBufferBindingImage(device_data, cb_node, src_image_state); |
| 3367 | AddCommandBufferBindingImage(device_data, cb_node, dst_image_state); |
Mark Lobodzinski | 8e0c0bf | 2017-02-06 11:06:26 -0700 | [diff] [blame] | 3368 | } |
| 3369 | |
Shannon McPherson | 449fa9c | 2018-10-25 11:51:07 -0600 | [diff] [blame] | 3370 | // This validates that the initial layout specified in the command buffer for the IMAGE is the same as the global IMAGE layout |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3371 | bool CoreChecks::ValidateCmdBufImageLayouts(layer_data *device_data, GLOBAL_CB_NODE *pCB, |
| 3372 | std::unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> const &globalImageLayoutMap, |
| 3373 | std::unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> &overlayLayoutMap) { |
Mark Lobodzinski | b0dd947 | 2017-02-07 16:38:17 -0700 | [diff] [blame] | 3374 | bool skip = false; |
Mark Lobodzinski | 4a3065e | 2017-02-07 16:36:03 -0700 | [diff] [blame] | 3375 | for (auto cb_image_data : pCB->imageLayoutMap) { |
| 3376 | VkImageLayout imageLayout; |
Tony Barbour | df013b9 | 2017-01-25 12:53:48 -0700 | [diff] [blame] | 3377 | |
Dave Houlton | b3f4b28 | 2018-02-22 16:25:16 -0700 | [diff] [blame] | 3378 | if (FindLayout(device_data, overlayLayoutMap, cb_image_data.first, imageLayout) || |
| 3379 | FindLayout(device_data, globalImageLayoutMap, cb_image_data.first, imageLayout)) { |
Mark Lobodzinski | 4a3065e | 2017-02-07 16:36:03 -0700 | [diff] [blame] | 3380 | if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { |
| 3381 | // TODO: Set memory invalid which is in mem_tracker currently |
| 3382 | } else if (imageLayout != cb_image_data.second.initialLayout) { |
| 3383 | if (cb_image_data.first.hasSubresource) { |
Shannon McPherson | 449fa9c | 2018-10-25 11:51:07 -0600 | [diff] [blame] | 3384 | skip |= |
| 3385 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3386 | HandleToUint64(pCB->commandBuffer), kVUID_Core_DrawState_InvalidImageLayout, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 3387 | "Submitted command buffer expects image %s (subresource: aspectMask 0x%X array layer %u, mip level " |
| 3388 | "%u) to be in layout %s--instead, image %s's current layout is %s.", |
| 3389 | report_data->FormatHandle(cb_image_data.first.image).c_str(), |
| 3390 | cb_image_data.first.subresource.aspectMask, cb_image_data.first.subresource.arrayLayer, |
| 3391 | cb_image_data.first.subresource.mipLevel, string_VkImageLayout(cb_image_data.second.initialLayout), |
| 3392 | report_data->FormatHandle(cb_image_data.first.image).c_str(), string_VkImageLayout(imageLayout)); |
| 3393 | } else { |
| 3394 | skip |= log_msg( |
| 3395 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3396 | HandleToUint64(pCB->commandBuffer), kVUID_Core_DrawState_InvalidImageLayout, |
| 3397 | "Submitted command buffer expects image %s to be in layout %s--instead, image %s's current layout is %s.", |
| 3398 | report_data->FormatHandle(cb_image_data.first.image).c_str(), |
| 3399 | string_VkImageLayout(cb_image_data.second.initialLayout), |
| 3400 | report_data->FormatHandle(cb_image_data.first.image).c_str(), string_VkImageLayout(imageLayout)); |
Mark Lobodzinski | 4a3065e | 2017-02-07 16:36:03 -0700 | [diff] [blame] | 3401 | } |
| 3402 | } |
Chris Forbes | f9d7acd | 2017-06-26 17:57:39 -0700 | [diff] [blame] | 3403 | SetLayout(overlayLayoutMap, cb_image_data.first, cb_image_data.second.layout); |
Mark Lobodzinski | 4a3065e | 2017-02-07 16:36:03 -0700 | [diff] [blame] | 3404 | } |
| 3405 | } |
Mark Lobodzinski | b0dd947 | 2017-02-07 16:38:17 -0700 | [diff] [blame] | 3406 | return skip; |
Mark Lobodzinski | 4a3065e | 2017-02-07 16:36:03 -0700 | [diff] [blame] | 3407 | } |
Mark Lobodzinski | b3829a5 | 2017-02-07 16:55:53 -0700 | [diff] [blame] | 3408 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3409 | void CoreChecks::UpdateCmdBufImageLayouts(layer_data *device_data, GLOBAL_CB_NODE *pCB) { |
Tony Barbour | df013b9 | 2017-01-25 12:53:48 -0700 | [diff] [blame] | 3410 | for (auto cb_image_data : pCB->imageLayoutMap) { |
| 3411 | VkImageLayout imageLayout; |
| 3412 | FindGlobalLayout(device_data, cb_image_data.first, imageLayout); |
| 3413 | SetGlobalLayout(device_data, cb_image_data.first, cb_image_data.second.layout); |
| 3414 | } |
| 3415 | } |
| 3416 | |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3417 | // ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the |
Mark Lobodzinski | 552e440 | 2017-02-07 17:14:53 -0700 | [diff] [blame] | 3418 | // VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that READ_ONLY |
| 3419 | // layout attachments don't have CLEAR as their loadOp. |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3420 | bool CoreChecks::ValidateLayoutVsAttachmentDescription(const debug_report_data *report_data, RenderPassCreateVersion rp_version, |
| 3421 | const VkImageLayout first_layout, const uint32_t attachment, |
| 3422 | const VkAttachmentDescription2KHR &attachment_description) { |
Mark Lobodzinski | 552e440 | 2017-02-07 17:14:53 -0700 | [diff] [blame] | 3423 | bool skip = false; |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3424 | const char *vuid; |
| 3425 | const bool use_rp2 = (rp_version == RENDER_PASS_VERSION_2); |
| 3426 | |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3427 | // Verify that initial loadOp on READ_ONLY attachments is not CLEAR |
| 3428 | if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { |
Shannon McPherson | 3ea6513 | 2018-12-05 10:37:39 -0700 | [diff] [blame] | 3429 | if (use_rp2 && ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || |
| 3430 | (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) || |
| 3431 | (first_layout == VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL))) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3432 | skip |= |
Shannon McPherson | 3ea6513 | 2018-12-05 10:37:39 -0700 | [diff] [blame] | 3433 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 3434 | "VUID-VkRenderPassCreateInfo2KHR-pAttachments-02522", |
| 3435 | "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); |
| 3436 | } else if (!use_rp2 && ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || |
| 3437 | (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL))) { |
| 3438 | skip |= |
| 3439 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 3440 | "VUID-VkRenderPassCreateInfo-pAttachments-00836", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3441 | "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3442 | } |
| 3443 | } |
Slawomir Cygan | adf2b55 | 2018-04-24 17:18:26 +0200 | [diff] [blame] | 3444 | if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { |
| 3445 | if (first_layout == VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3446 | vuid = use_rp2 ? kVUID_Core_DrawState_InvalidRenderpass : "VUID-VkRenderPassCreateInfo-pAttachments-01566"; |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3447 | skip |= |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3448 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3449 | "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); |
Slawomir Cygan | adf2b55 | 2018-04-24 17:18:26 +0200 | [diff] [blame] | 3450 | } |
| 3451 | } |
| 3452 | |
| 3453 | if (attachment_description.stencilLoadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { |
| 3454 | if (first_layout == VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3455 | vuid = use_rp2 ? kVUID_Core_DrawState_InvalidRenderpass : "VUID-VkRenderPassCreateInfo-pAttachments-01567"; |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3456 | skip |= |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3457 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3458 | "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); |
Slawomir Cygan | adf2b55 | 2018-04-24 17:18:26 +0200 | [diff] [blame] | 3459 | } |
| 3460 | } |
Mark Lobodzinski | 552e440 | 2017-02-07 17:14:53 -0700 | [diff] [blame] | 3461 | return skip; |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3462 | } |
| 3463 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3464 | bool CoreChecks::ValidateLayouts(layer_data *device_data, RenderPassCreateVersion rp_version, VkDevice device, |
| 3465 | const VkRenderPassCreateInfo2KHR *pCreateInfo) { |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3466 | bool skip = false; |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3467 | const char *vuid; |
| 3468 | const bool use_rp2 = (rp_version == RENDER_PASS_VERSION_2); |
| 3469 | const char *const function_name = use_rp2 ? "vkCreateRenderPass2KHR()" : "vkCreateRenderPass()"; |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3470 | |
Jason Ekstrand | a190630 | 2017-12-03 20:16:32 -0800 | [diff] [blame] | 3471 | for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { |
| 3472 | VkFormat format = pCreateInfo->pAttachments[i].format; |
| 3473 | if (pCreateInfo->pAttachments[i].initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { |
| 3474 | if ((FormatIsColor(format) || FormatHasDepth(format)) && |
| 3475 | pCreateInfo->pAttachments[i].loadOp == VK_ATTACHMENT_LOAD_OP_LOAD) { |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 3476 | skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3477 | kVUID_Core_DrawState_InvalidRenderpass, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3478 | "Render pass has an attachment with loadOp == VK_ATTACHMENT_LOAD_OP_LOAD and initialLayout == " |
| 3479 | "VK_IMAGE_LAYOUT_UNDEFINED. This is probably not what you intended. Consider using " |
| 3480 | "VK_ATTACHMENT_LOAD_OP_DONT_CARE instead if the image truely is undefined at the start of the " |
| 3481 | "render pass."); |
Jason Ekstrand | a190630 | 2017-12-03 20:16:32 -0800 | [diff] [blame] | 3482 | } |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3483 | if (FormatHasStencil(format) && pCreateInfo->pAttachments[i].stencilLoadOp == VK_ATTACHMENT_LOAD_OP_LOAD) { |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 3484 | skip |= log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3485 | kVUID_Core_DrawState_InvalidRenderpass, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3486 | "Render pass has an attachment with stencilLoadOp == VK_ATTACHMENT_LOAD_OP_LOAD and initialLayout " |
| 3487 | "== VK_IMAGE_LAYOUT_UNDEFINED. This is probably not what you intended. Consider using " |
| 3488 | "VK_ATTACHMENT_LOAD_OP_DONT_CARE instead if the image truely is undefined at the start of the " |
| 3489 | "render pass."); |
Jason Ekstrand | a190630 | 2017-12-03 20:16:32 -0800 | [diff] [blame] | 3490 | } |
| 3491 | } |
| 3492 | } |
| 3493 | |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3494 | // Track when we're observing the first use of an attachment |
| 3495 | std::vector<bool> attach_first_use(pCreateInfo->attachmentCount, true); |
| 3496 | for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3497 | const VkSubpassDescription2KHR &subpass = pCreateInfo->pSubpasses[i]; |
Cort Stratton | 7547f77 | 2017-05-04 15:18:52 -0700 | [diff] [blame] | 3498 | |
| 3499 | // Check input attachments first, so we can detect first-use-as-input for VU #00349 |
| 3500 | for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { |
| 3501 | auto attach_index = subpass.pInputAttachments[j].attachment; |
| 3502 | if (attach_index == VK_ATTACHMENT_UNUSED) continue; |
Cort Stratton | 7547f77 | 2017-05-04 15:18:52 -0700 | [diff] [blame] | 3503 | switch (subpass.pInputAttachments[j].layout) { |
| 3504 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: |
| 3505 | case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: |
| 3506 | // These are ideal. |
| 3507 | break; |
| 3508 | |
| 3509 | case VK_IMAGE_LAYOUT_GENERAL: |
| 3510 | // May not be optimal. TODO: reconsider this warning based on other constraints. |
| 3511 | skip |= log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3512 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUID_Core_DrawState_InvalidImageLayout, |
Cort Stratton | 7547f77 | 2017-05-04 15:18:52 -0700 | [diff] [blame] | 3513 | "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); |
| 3514 | break; |
| 3515 | |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3516 | case VK_IMAGE_LAYOUT_UNDEFINED: |
| 3517 | case VK_IMAGE_LAYOUT_PREINITIALIZED: |
| 3518 | vuid = use_rp2 ? "VUID-VkAttachmentReference2KHR-layout-03077" : "VUID-VkAttachmentReference-layout-00857"; |
| 3519 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid, |
| 3520 | "Layout for input attachment reference %u in subpass %u is %s but must be " |
| 3521 | "DEPTH_STENCIL_READ_ONLY, SHADER_READ_ONLY_OPTIMAL, or GENERAL.", |
| 3522 | j, i, string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); |
| 3523 | break; |
| 3524 | |
Graeme Leese | 668a986 | 2018-10-08 10:40:02 +0100 | [diff] [blame] | 3525 | case VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL_KHR: |
| 3526 | case VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL_KHR: |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 3527 | if (GetDeviceExtensions()->vk_khr_maintenance2) { |
Graeme Leese | 668a986 | 2018-10-08 10:40:02 +0100 | [diff] [blame] | 3528 | break; |
| 3529 | } else { |
| 3530 | // Intentionally fall through to generic error message |
| 3531 | } |
| 3532 | // fall through |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3533 | |
Cort Stratton | 7547f77 | 2017-05-04 15:18:52 -0700 | [diff] [blame] | 3534 | default: |
| 3535 | // No other layouts are acceptable |
| 3536 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3537 | kVUID_Core_DrawState_InvalidImageLayout, |
Cort Stratton | 7547f77 | 2017-05-04 15:18:52 -0700 | [diff] [blame] | 3538 | "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", |
| 3539 | string_VkImageLayout(subpass.pInputAttachments[j].layout)); |
| 3540 | } |
| 3541 | |
Cort Stratton | 7547f77 | 2017-05-04 15:18:52 -0700 | [diff] [blame] | 3542 | if (attach_first_use[attach_index]) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3543 | skip |= ValidateLayoutVsAttachmentDescription(report_data, rp_version, subpass.pInputAttachments[j].layout, |
| 3544 | attach_index, pCreateInfo->pAttachments[attach_index]); |
Cort Stratton | 7547f77 | 2017-05-04 15:18:52 -0700 | [diff] [blame] | 3545 | |
| 3546 | bool used_as_depth = |
| 3547 | (subpass.pDepthStencilAttachment != NULL && subpass.pDepthStencilAttachment->attachment == attach_index); |
| 3548 | bool used_as_color = false; |
| 3549 | for (uint32_t k = 0; !used_as_depth && !used_as_color && k < subpass.colorAttachmentCount; ++k) { |
| 3550 | used_as_color = (subpass.pColorAttachments[k].attachment == attach_index); |
| 3551 | } |
| 3552 | if (!used_as_depth && !used_as_color && |
| 3553 | pCreateInfo->pAttachments[attach_index].loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3554 | vuid = use_rp2 ? "VUID-VkSubpassDescription2KHR-loadOp-03064" : "VUID-VkSubpassDescription-loadOp-00846"; |
| 3555 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid, |
| 3556 | "%s: attachment %u is first used as an input attachment in subpass %u with loadOp=CLEAR.", |
| 3557 | function_name, attach_index, attach_index); |
Cort Stratton | 7547f77 | 2017-05-04 15:18:52 -0700 | [diff] [blame] | 3558 | } |
| 3559 | } |
| 3560 | attach_first_use[attach_index] = false; |
| 3561 | } |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3562 | |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3563 | for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { |
| 3564 | auto attach_index = subpass.pColorAttachments[j].attachment; |
| 3565 | if (attach_index == VK_ATTACHMENT_UNUSED) continue; |
| 3566 | |
Tobin Ehlis | bb03e5f | 2017-05-11 08:52:51 -0600 | [diff] [blame] | 3567 | // TODO: Need a way to validate shared presentable images here, currently just allowing |
| 3568 | // VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR |
| 3569 | // as an acceptable layout, but need to make sure shared presentable images ONLY use that layout |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3570 | switch (subpass.pColorAttachments[j].layout) { |
Mark Lobodzinski | 552e440 | 2017-02-07 17:14:53 -0700 | [diff] [blame] | 3571 | case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 3572 | // This is ideal. |
Tobin Ehlis | bb03e5f | 2017-05-11 08:52:51 -0600 | [diff] [blame] | 3573 | case VK_IMAGE_LAYOUT_SHARED_PRESENT_KHR: |
| 3574 | // TODO: See note above, just assuming that attachment is shared presentable and allowing this for now. |
Mark Lobodzinski | 552e440 | 2017-02-07 17:14:53 -0700 | [diff] [blame] | 3575 | break; |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3576 | |
Mark Lobodzinski | 552e440 | 2017-02-07 17:14:53 -0700 | [diff] [blame] | 3577 | case VK_IMAGE_LAYOUT_GENERAL: |
| 3578 | // May not be optimal; TODO: reconsider this warning based on other constraints? |
| 3579 | skip |= log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3580 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUID_Core_DrawState_InvalidImageLayout, |
Mark Lobodzinski | 552e440 | 2017-02-07 17:14:53 -0700 | [diff] [blame] | 3581 | "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); |
| 3582 | break; |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3583 | |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3584 | case VK_IMAGE_LAYOUT_UNDEFINED: |
| 3585 | case VK_IMAGE_LAYOUT_PREINITIALIZED: |
| 3586 | vuid = use_rp2 ? "VUID-VkAttachmentReference2KHR-layout-03077" : "VUID-VkAttachmentReference-layout-00857"; |
| 3587 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid, |
| 3588 | "Layout for color attachment reference %u in subpass %u is %s but should be " |
| 3589 | "COLOR_ATTACHMENT_OPTIMAL or GENERAL.", |
| 3590 | j, i, string_VkImageLayout(subpass.pColorAttachments[j].layout)); |
| 3591 | break; |
| 3592 | |
Mark Lobodzinski | 552e440 | 2017-02-07 17:14:53 -0700 | [diff] [blame] | 3593 | default: |
| 3594 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3595 | kVUID_Core_DrawState_InvalidImageLayout, |
Mark Lobodzinski | 552e440 | 2017-02-07 17:14:53 -0700 | [diff] [blame] | 3596 | "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", |
| 3597 | string_VkImageLayout(subpass.pColorAttachments[j].layout)); |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3598 | } |
| 3599 | |
John Zulauf | 4eee269 | 2019-02-09 16:14:25 -0700 | [diff] [blame] | 3600 | if (subpass.pResolveAttachments && (subpass.pResolveAttachments[j].attachment != VK_ATTACHMENT_UNUSED) && |
| 3601 | (subpass.pResolveAttachments[j].layout == VK_IMAGE_LAYOUT_UNDEFINED || |
| 3602 | subpass.pResolveAttachments[j].layout == VK_IMAGE_LAYOUT_PREINITIALIZED)) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3603 | vuid = use_rp2 ? "VUID-VkAttachmentReference2KHR-layout-03077" : "VUID-VkAttachmentReference-layout-00857"; |
| 3604 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid, |
John Zulauf | 4eee269 | 2019-02-09 16:14:25 -0700 | [diff] [blame] | 3605 | "Layout for resolve attachment reference %u in subpass %u is %s but should be " |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3606 | "COLOR_ATTACHMENT_OPTIMAL or GENERAL.", |
John Zulauf | f0f8c2b | 2019-02-14 12:13:44 -0700 | [diff] [blame] | 3607 | j, i, string_VkImageLayout(subpass.pResolveAttachments[j].layout)); |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3608 | } |
| 3609 | |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3610 | if (attach_first_use[attach_index]) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3611 | skip |= ValidateLayoutVsAttachmentDescription(report_data, rp_version, subpass.pColorAttachments[j].layout, |
| 3612 | attach_index, pCreateInfo->pAttachments[attach_index]); |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3613 | } |
| 3614 | attach_first_use[attach_index] = false; |
| 3615 | } |
Lenny Komow | b79f04a | 2017-09-18 17:07:00 -0600 | [diff] [blame] | 3616 | |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3617 | if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { |
| 3618 | switch (subpass.pDepthStencilAttachment->layout) { |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3619 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: |
| 3620 | case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: |
| 3621 | // These are ideal. |
Lenny Komow | b79f04a | 2017-09-18 17:07:00 -0600 | [diff] [blame] | 3622 | break; |
Lenny Komow | b79f04a | 2017-09-18 17:07:00 -0600 | [diff] [blame] | 3623 | |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3624 | case VK_IMAGE_LAYOUT_GENERAL: |
| 3625 | // May not be optimal; TODO: reconsider this warning based on other constraints? GENERAL can be better than |
| 3626 | // doing a bunch of transitions. |
| 3627 | skip |= log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3628 | VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, kVUID_Core_DrawState_InvalidImageLayout, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3629 | "GENERAL layout for depth attachment may not give optimal performance."); |
| 3630 | break; |
| 3631 | |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3632 | case VK_IMAGE_LAYOUT_UNDEFINED: |
| 3633 | case VK_IMAGE_LAYOUT_PREINITIALIZED: |
| 3634 | vuid = use_rp2 ? "VUID-VkAttachmentReference2KHR-layout-03077" : "VUID-VkAttachmentReference-layout-00857"; |
| 3635 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, vuid, |
| 3636 | "Layout for depth attachment reference in subpass %u is %s but must be a valid depth/stencil " |
| 3637 | "layout or GENERAL.", |
| 3638 | i, string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); |
| 3639 | break; |
| 3640 | |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3641 | case VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL_KHR: |
| 3642 | case VK_IMAGE_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL_KHR: |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 3643 | if (GetDeviceExtensions()->vk_khr_maintenance2) { |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3644 | break; |
| 3645 | } else { |
| 3646 | // Intentionally fall through to generic error message |
| 3647 | } |
Tobin Ehlis | 648b1cf | 2018-04-13 15:24:13 -0600 | [diff] [blame] | 3648 | // fall through |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3649 | |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3650 | default: |
| 3651 | // No other layouts are acceptable |
| 3652 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3653 | kVUID_Core_DrawState_InvalidImageLayout, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3654 | "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL, " |
| 3655 | "DEPTH_STENCIL_READ_ONLY_OPTIMAL or GENERAL.", |
| 3656 | string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3657 | } |
| 3658 | |
| 3659 | auto attach_index = subpass.pDepthStencilAttachment->attachment; |
| 3660 | if (attach_first_use[attach_index]) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3661 | skip |= ValidateLayoutVsAttachmentDescription(report_data, rp_version, subpass.pDepthStencilAttachment->layout, |
| 3662 | attach_index, pCreateInfo->pAttachments[attach_index]); |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3663 | } |
| 3664 | attach_first_use[attach_index] = false; |
| 3665 | } |
Mark Lobodzinski | c679b03 | 2017-02-07 17:11:55 -0700 | [diff] [blame] | 3666 | } |
| 3667 | return skip; |
| 3668 | } |
Mark Lobodzinski | 08f14fa | 2017-02-07 17:20:06 -0700 | [diff] [blame] | 3669 | |
| 3670 | // For any image objects that overlap mapped memory, verify that their layouts are PREINIT or GENERAL |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3671 | bool CoreChecks::ValidateMapImageLayouts(layer_data *device_data, VkDevice device, DEVICE_MEM_INFO const *mem_info, |
| 3672 | VkDeviceSize offset, VkDeviceSize end_offset) { |
Mark Lobodzinski | ac23ec8 | 2017-02-07 17:21:55 -0700 | [diff] [blame] | 3673 | bool skip = false; |
| 3674 | // Iterate over all bound image ranges and verify that for any that overlap the map ranges, the layouts are |
| 3675 | // VK_IMAGE_LAYOUT_PREINITIALIZED or VK_IMAGE_LAYOUT_GENERAL |
Mark Lobodzinski | 08f14fa | 2017-02-07 17:20:06 -0700 | [diff] [blame] | 3676 | // TODO : This can be optimized if we store ranges based on starting address and early exit when we pass our range |
| 3677 | for (auto image_handle : mem_info->bound_images) { |
| 3678 | auto img_it = mem_info->bound_ranges.find(image_handle); |
| 3679 | if (img_it != mem_info->bound_ranges.end()) { |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 3680 | if (RangesIntersect(device_data, &img_it->second, offset, end_offset)) { |
Mark Lobodzinski | 08f14fa | 2017-02-07 17:20:06 -0700 | [diff] [blame] | 3681 | std::vector<VkImageLayout> layouts; |
Mark Lobodzinski | ac23ec8 | 2017-02-07 17:21:55 -0700 | [diff] [blame] | 3682 | if (FindLayouts(device_data, VkImage(image_handle), layouts)) { |
Mark Lobodzinski | 08f14fa | 2017-02-07 17:20:06 -0700 | [diff] [blame] | 3683 | for (auto layout : layouts) { |
| 3684 | if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 3685 | skip |= |
| 3686 | log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 3687 | HandleToUint64(mem_info->mem), kVUID_Core_DrawState_InvalidImageLayout, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3688 | "Mapping an image with layout %s can result in undefined behavior if this memory is used " |
| 3689 | "by the device. Only GENERAL or PREINITIALIZED should be used.", |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 3690 | string_VkImageLayout(layout)); |
Mark Lobodzinski | 08f14fa | 2017-02-07 17:20:06 -0700 | [diff] [blame] | 3691 | } |
| 3692 | } |
| 3693 | } |
| 3694 | } |
| 3695 | } |
| 3696 | } |
Mark Lobodzinski | ac23ec8 | 2017-02-07 17:21:55 -0700 | [diff] [blame] | 3697 | return skip; |
Mark Lobodzinski | 08f14fa | 2017-02-07 17:20:06 -0700 | [diff] [blame] | 3698 | } |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3699 | |
| 3700 | // Helper function to validate correct usage bits set for buffers or images. Verify that (actual & desired) flags != 0 or, if strict |
| 3701 | // is true, verify that (actual & desired) flags == desired |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3702 | bool CoreChecks::ValidateUsageFlags(const layer_data *device_data, VkFlags actual, VkFlags desired, VkBool32 strict, |
| 3703 | uint64_t obj_handle, VulkanObjectType obj_type, const char *msgCode, char const *func_name, |
| 3704 | char const *usage_str) { |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3705 | bool correct_usage = false; |
Mark Lobodzinski | 95dbbe5 | 2017-02-09 10:40:41 -0700 | [diff] [blame] | 3706 | bool skip = false; |
Mark Lobodzinski | 3382637 | 2017-04-13 11:10:11 -0600 | [diff] [blame] | 3707 | const char *type_str = object_string[obj_type]; |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3708 | if (strict) { |
| 3709 | correct_usage = ((actual & desired) == desired); |
| 3710 | } else { |
| 3711 | correct_usage = ((actual & desired) != 0); |
| 3712 | } |
| 3713 | if (!correct_usage) { |
Dave Houlton | 8e9f654 | 2018-05-18 12:18:22 -0600 | [diff] [blame] | 3714 | if (msgCode == kVUIDUndefined) { |
Dave Houlton | 12befb9 | 2018-06-26 17:16:46 -0600 | [diff] [blame] | 3715 | // TODO: Fix callers with kVUIDUndefined to use correct validation checks. |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 3716 | skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, get_debug_report_enum[obj_type], obj_handle, |
| 3717 | kVUID_Core_MemTrack_InvalidUsageFlag, |
| 3718 | "Invalid usage flag for %s %s used by %s. In this case, %s should have %s set during creation.", |
| 3719 | type_str, report_data->FormatHandle(obj_handle).c_str(), func_name, type_str, usage_str); |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3720 | } else { |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 3721 | skip = log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, get_debug_report_enum[obj_type], obj_handle, msgCode, |
| 3722 | "Invalid usage flag for %s %s used by %s. In this case, %s should have %s set during creation.", |
| 3723 | type_str, report_data->FormatHandle(obj_handle).c_str(), func_name, type_str, usage_str); |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3724 | } |
| 3725 | } |
Mark Lobodzinski | 95dbbe5 | 2017-02-09 10:40:41 -0700 | [diff] [blame] | 3726 | return skip; |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3727 | } |
| 3728 | |
| 3729 | // Helper function to validate usage flags for buffers. For given buffer_state send actual vs. desired usage off to helper above |
| 3730 | // where an error will be flagged if usage is not correct |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3731 | bool CoreChecks::ValidateImageUsageFlags(layer_data *device_data, IMAGE_STATE const *image_state, VkFlags desired, bool strict, |
| 3732 | const char *msgCode, char const *func_name, char const *usage_string) { |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 3733 | return ValidateUsageFlags(device_data, image_state->createInfo.usage, desired, strict, HandleToUint64(image_state->image), |
| 3734 | kVulkanObjectTypeImage, msgCode, func_name, usage_string); |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3735 | } |
| 3736 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3737 | bool CoreChecks::ValidateImageFormatFeatureFlags(layer_data *dev_data, IMAGE_STATE const *image_state, VkFormatFeatureFlags desired, |
| 3738 | char const *func_name, const char *linear_vuid, const char *optimal_vuid) { |
Mark Lobodzinski | 5c04880 | 2019-03-07 10:47:31 -0700 | [diff] [blame] | 3739 | VkFormatProperties format_properties = GetPDFormatProperties(image_state->createInfo.format); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 3740 | bool skip = false; |
| 3741 | if (image_state->createInfo.tiling == VK_IMAGE_TILING_LINEAR) { |
| 3742 | if ((format_properties.linearTilingFeatures & desired) != desired) { |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 3743 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 3744 | HandleToUint64(image_state->image), linear_vuid, |
| 3745 | "In %s, invalid linearTilingFeatures (0x%08X) for format %u used by image %s.", func_name, |
| 3746 | format_properties.linearTilingFeatures, image_state->createInfo.format, |
| 3747 | report_data->FormatHandle(image_state->image).c_str()); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 3748 | } |
| 3749 | } else if (image_state->createInfo.tiling == VK_IMAGE_TILING_OPTIMAL) { |
| 3750 | if ((format_properties.optimalTilingFeatures & desired) != desired) { |
| 3751 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
| 3752 | HandleToUint64(image_state->image), optimal_vuid, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 3753 | "In %s, invalid optimalTilingFeatures (0x%08X) for format %u used by image %s.", func_name, |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 3754 | format_properties.optimalTilingFeatures, image_state->createInfo.format, |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 3755 | report_data->FormatHandle(image_state->image).c_str()); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 3756 | } |
| 3757 | } |
| 3758 | return skip; |
| 3759 | } |
| 3760 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3761 | bool CoreChecks::ValidateImageSubresourceLayers(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, |
| 3762 | const VkImageSubresourceLayers *subresource_layers, char const *func_name, |
| 3763 | char const *member, uint32_t i) { |
Cort Stratton | d619a30 | 2018-05-17 19:46:32 -0700 | [diff] [blame] | 3764 | bool skip = false; |
Cort Stratton | d619a30 | 2018-05-17 19:46:32 -0700 | [diff] [blame] | 3765 | // layerCount must not be zero |
| 3766 | if (subresource_layers->layerCount == 0) { |
| 3767 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3768 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageSubresourceLayers-layerCount-01700", |
| 3769 | "In %s, pRegions[%u].%s.layerCount must not be zero.", func_name, i, member); |
| 3770 | } |
| 3771 | // aspectMask must not contain VK_IMAGE_ASPECT_METADATA_BIT |
| 3772 | if (subresource_layers->aspectMask & VK_IMAGE_ASPECT_METADATA_BIT) { |
| 3773 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3774 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageSubresourceLayers-aspectMask-00168", |
| 3775 | "In %s, pRegions[%u].%s.aspectMask has VK_IMAGE_ASPECT_METADATA_BIT set.", func_name, i, member); |
| 3776 | } |
| 3777 | // if aspectMask contains COLOR, it must not contain either DEPTH or STENCIL |
| 3778 | if ((subresource_layers->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) && |
| 3779 | (subresource_layers->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT))) { |
| 3780 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
| 3781 | HandleToUint64(cb_node->commandBuffer), "VUID-VkImageSubresourceLayers-aspectMask-00167", |
| 3782 | "In %s, pRegions[%u].%s.aspectMask has VK_IMAGE_ASPECT_COLOR_BIT and either VK_IMAGE_ASPECT_DEPTH_BIT or " |
| 3783 | "VK_IMAGE_ASPECT_STENCIL_BIT set.", |
| 3784 | func_name, i, member); |
| 3785 | } |
| 3786 | return skip; |
| 3787 | } |
| 3788 | |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3789 | // Helper function to validate usage flags for buffers. For given buffer_state send actual vs. desired usage off to helper above |
| 3790 | // where an error will be flagged if usage is not correct |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3791 | bool CoreChecks::ValidateBufferUsageFlags(const layer_data *device_data, BUFFER_STATE const *buffer_state, VkFlags desired, |
| 3792 | bool strict, const char *msgCode, char const *func_name, char const *usage_string) { |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 3793 | return ValidateUsageFlags(device_data, buffer_state->createInfo.usage, desired, strict, HandleToUint64(buffer_state->buffer), |
| 3794 | kVulkanObjectTypeBuffer, msgCode, func_name, usage_string); |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3795 | } |
| 3796 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3797 | bool CoreChecks::ValidateBufferViewRange(const layer_data *device_data, const BUFFER_STATE *buffer_state, |
| 3798 | const VkBufferViewCreateInfo *pCreateInfo, const VkPhysicalDeviceLimits *device_limits) { |
Shannon McPherson | 4c9505b | 2018-06-19 15:18:55 -0600 | [diff] [blame] | 3799 | bool skip = false; |
Shannon McPherson | 4c9505b | 2018-06-19 15:18:55 -0600 | [diff] [blame] | 3800 | |
| 3801 | const VkDeviceSize &range = pCreateInfo->range; |
| 3802 | if (range != VK_WHOLE_SIZE) { |
| 3803 | // Range must be greater than 0 |
| 3804 | if (range <= 0) { |
| 3805 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 3806 | HandleToUint64(buffer_state->buffer), "VUID-VkBufferViewCreateInfo-range-00928", |
| 3807 | "If VkBufferViewCreateInfo range (%" PRIuLEAST64 |
| 3808 | ") does not equal VK_WHOLE_SIZE, range must be greater than 0.", |
| 3809 | range); |
| 3810 | } |
| 3811 | // Range must be a multiple of the element size of format |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 3812 | const size_t format_size = FormatElementSize(pCreateInfo->format); |
Shannon McPherson | 4c9505b | 2018-06-19 15:18:55 -0600 | [diff] [blame] | 3813 | if (range % format_size != 0) { |
| 3814 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 3815 | HandleToUint64(buffer_state->buffer), "VUID-VkBufferViewCreateInfo-range-00929", |
| 3816 | "If VkBufferViewCreateInfo range (%" PRIuLEAST64 |
| 3817 | ") does not equal VK_WHOLE_SIZE, range must be a multiple of the element size of the format " |
| 3818 | "(" PRINTF_SIZE_T_SPECIFIER ").", |
| 3819 | range, format_size); |
| 3820 | } |
| 3821 | // Range divided by the element size of format must be less than or equal to VkPhysicalDeviceLimits::maxTexelBufferElements |
| 3822 | if (range / format_size > device_limits->maxTexelBufferElements) { |
| 3823 | skip |= |
| 3824 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 3825 | HandleToUint64(buffer_state->buffer), "VUID-VkBufferViewCreateInfo-range-00930", |
| 3826 | "If VkBufferViewCreateInfo range (%" PRIuLEAST64 |
| 3827 | ") does not equal VK_WHOLE_SIZE, range divided by the element size of the format (" PRINTF_SIZE_T_SPECIFIER |
| 3828 | ") must be less than or equal to VkPhysicalDeviceLimits::maxTexelBufferElements (%" PRIuLEAST32 ").", |
| 3829 | range, format_size, device_limits->maxTexelBufferElements); |
| 3830 | } |
| 3831 | // The sum of range and offset must be less than or equal to the size of buffer |
| 3832 | if (range + pCreateInfo->offset > buffer_state->createInfo.size) { |
| 3833 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 3834 | HandleToUint64(buffer_state->buffer), "VUID-VkBufferViewCreateInfo-offset-00931", |
| 3835 | "If VkBufferViewCreateInfo range (%" PRIuLEAST64 |
| 3836 | ") does not equal VK_WHOLE_SIZE, the sum of offset (%" PRIuLEAST64 |
| 3837 | ") and range must be less than or equal to the size of the buffer (%" PRIuLEAST64 ").", |
| 3838 | range, pCreateInfo->offset, buffer_state->createInfo.size); |
| 3839 | } |
| 3840 | } |
| 3841 | return skip; |
| 3842 | } |
| 3843 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3844 | bool CoreChecks::ValidateBufferViewBuffer(const layer_data *device_data, const BUFFER_STATE *buffer_state, |
| 3845 | const VkBufferViewCreateInfo *pCreateInfo) { |
Shannon McPherson | 265383a | 2018-06-21 15:37:52 -0600 | [diff] [blame] | 3846 | bool skip = false; |
Mark Lobodzinski | 5c04880 | 2019-03-07 10:47:31 -0700 | [diff] [blame] | 3847 | const VkFormatProperties format_properties = GetPDFormatProperties(pCreateInfo->format); |
Shannon McPherson | 265383a | 2018-06-21 15:37:52 -0600 | [diff] [blame] | 3848 | if ((buffer_state->createInfo.usage & VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT) && |
| 3849 | !(format_properties.bufferFeatures & VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT)) { |
| 3850 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 3851 | HandleToUint64(buffer_state->buffer), "VUID-VkBufferViewCreateInfo-buffer-00933", |
| 3852 | "If buffer was created with `usage` containing VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT, format must " |
| 3853 | "be supported for uniform texel buffers"); |
| 3854 | } |
| 3855 | if ((buffer_state->createInfo.usage & VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT) && |
| 3856 | !(format_properties.bufferFeatures & VK_FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_BIT)) { |
| 3857 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 3858 | HandleToUint64(buffer_state->buffer), "VUID-VkBufferViewCreateInfo-buffer-00934", |
| 3859 | "If buffer was created with `usage` containing VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, format must " |
| 3860 | "be supported for storage texel buffers"); |
| 3861 | } |
| 3862 | return skip; |
| 3863 | } |
| 3864 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3865 | bool CoreChecks::PreCallValidateCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, |
| 3866 | const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 3867 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| 3868 | |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3869 | bool skip = false; |
Mark Lobodzinski | 847b60c | 2017-03-13 09:32:45 -0600 | [diff] [blame] | 3870 | |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3871 | // TODO: Add check for "VUID-vkCreateBuffer-flags-00911" (sparse address space accounting) |
Mark Lobodzinski | 847b60c | 2017-03-13 09:32:45 -0600 | [diff] [blame] | 3872 | |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 3873 | if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT) && (!GetEnabledFeatures()->core.sparseBinding)) { |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 3874 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3875 | "VUID-VkBufferCreateInfo-flags-00915", |
Mark Lobodzinski | 847b60c | 2017-03-13 09:32:45 -0600 | [diff] [blame] | 3876 | "vkCreateBuffer(): the sparseBinding device feature is disabled: Buffers cannot be created with the " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 3877 | "VK_BUFFER_CREATE_SPARSE_BINDING_BIT set."); |
Mark Lobodzinski | 847b60c | 2017-03-13 09:32:45 -0600 | [diff] [blame] | 3878 | } |
Mark Lobodzinski | af35506 | 2017-03-13 09:35:01 -0600 | [diff] [blame] | 3879 | |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 3880 | if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT) && (!GetEnabledFeatures()->core.sparseResidencyBuffer)) { |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 3881 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3882 | "VUID-VkBufferCreateInfo-flags-00916", |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3883 | "vkCreateBuffer(): the sparseResidencyBuffer device feature is disabled: Buffers cannot be created with " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 3884 | "the VK_BUFFER_CREATE_SPARSE_RESIDENCY_BIT set."); |
Mark Lobodzinski | af35506 | 2017-03-13 09:35:01 -0600 | [diff] [blame] | 3885 | } |
Mark Lobodzinski | 035a4cf | 2017-03-13 09:45:07 -0600 | [diff] [blame] | 3886 | |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 3887 | if ((pCreateInfo->flags & VK_BUFFER_CREATE_SPARSE_ALIASED_BIT) && (!GetEnabledFeatures()->core.sparseResidencyAliased)) { |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 3888 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3889 | "VUID-VkBufferCreateInfo-flags-00917", |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 3890 | "vkCreateBuffer(): the sparseResidencyAliased device feature is disabled: Buffers cannot be created with " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 3891 | "the VK_BUFFER_CREATE_SPARSE_ALIASED_BIT set."); |
Mark Lobodzinski | 035a4cf | 2017-03-13 09:45:07 -0600 | [diff] [blame] | 3892 | } |
Jeff Bolz | 8769753 | 2019-01-11 22:54:00 -0600 | [diff] [blame] | 3893 | |
| 3894 | auto chained_devaddr_struct = lvl_find_in_chain<VkBufferDeviceAddressCreateInfoEXT>(pCreateInfo->pNext); |
| 3895 | if (chained_devaddr_struct) { |
| 3896 | if (!(pCreateInfo->flags & VK_BUFFER_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_EXT) && |
| 3897 | chained_devaddr_struct->deviceAddress != 0) { |
| 3898 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 3899 | "VUID-VkBufferCreateInfo-deviceAddress-02604", |
| 3900 | "vkCreateBuffer(): Non-zero VkBufferDeviceAddressCreateInfoEXT::deviceAddress " |
| 3901 | "requires VK_BUFFER_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_EXT."); |
| 3902 | } |
| 3903 | } |
| 3904 | |
| 3905 | if ((pCreateInfo->flags & VK_BUFFER_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_EXT) && |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 3906 | !GetEnabledFeatures()->buffer_address.bufferDeviceAddressCaptureReplay) { |
Jeff Bolz | 8769753 | 2019-01-11 22:54:00 -0600 | [diff] [blame] | 3907 | skip |= log_msg( |
| 3908 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 3909 | "VUID-VkBufferCreateInfo-flags-02605", |
| 3910 | "vkCreateBuffer(): the bufferDeviceAddressCaptureReplay device feature is disabled: Buffers cannot be created with " |
| 3911 | "the VK_BUFFER_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT_EXT set."); |
| 3912 | } |
| 3913 | |
| 3914 | if ((pCreateInfo->usage & VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT_EXT) && |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 3915 | !GetEnabledFeatures()->buffer_address.bufferDeviceAddress) { |
Jeff Bolz | 8769753 | 2019-01-11 22:54:00 -0600 | [diff] [blame] | 3916 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, |
| 3917 | "VUID-VkBufferCreateInfo-usage-02606", |
| 3918 | "vkCreateBuffer(): the bufferDeviceAddress device feature is disabled: Buffers cannot be created with " |
| 3919 | "the VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT_EXT set."); |
| 3920 | } |
| 3921 | |
Mark Lobodzinski | 08ee03c | 2019-02-04 10:57:47 -0700 | [diff] [blame] | 3922 | if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT && pCreateInfo->pQueueFamilyIndices) { |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3923 | skip |= |
| 3924 | ValidateQueueFamilies(device_data, pCreateInfo->queueFamilyIndexCount, pCreateInfo->pQueueFamilyIndices, |
| 3925 | "vkCreateBuffer", "pCreateInfo->pQueueFamilyIndices", "VUID-VkBufferCreateInfo-sharingMode-01419", |
| 3926 | "VUID-VkBufferCreateInfo-sharingMode-01419", false); |
Mark Lobodzinski | 08ee03c | 2019-02-04 10:57:47 -0700 | [diff] [blame] | 3927 | } |
| 3928 | |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3929 | return skip; |
| 3930 | } |
| 3931 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3932 | void CoreChecks::PostCallRecordCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, |
| 3933 | const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer, VkResult result) { |
Mark Lobodzinski | 701507e | 2019-01-18 14:31:53 -0700 | [diff] [blame] | 3934 | if (result != VK_SUCCESS) return; |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3935 | // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid |
Mark Lobodzinski | 1170cf2 | 2019-03-07 11:08:21 -0700 | [diff] [blame] | 3936 | GetBufferMap()->insert(std::make_pair(*pBuffer, std::unique_ptr<BUFFER_STATE>(new BUFFER_STATE(*pBuffer, pCreateInfo)))); |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3937 | } |
| 3938 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3939 | bool CoreChecks::PreCallValidateCreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, |
| 3940 | const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 3941 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| 3942 | |
Mark Lobodzinski | 95dbbe5 | 2017-02-09 10:40:41 -0700 | [diff] [blame] | 3943 | bool skip = false; |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 3944 | BUFFER_STATE *buffer_state = GetBufferState(pCreateInfo->buffer); |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3945 | // If this isn't a sparse buffer, it needs to have memory backing it at CreateBufferView time |
| 3946 | if (buffer_state) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3947 | skip |= ValidateMemoryIsBoundToBuffer(device_data, buffer_state, "vkCreateBufferView()", |
| 3948 | "VUID-VkBufferViewCreateInfo-buffer-00935"); |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3949 | // In order to create a valid buffer view, the buffer must have been created with at least one of the following flags: |
| 3950 | // UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 3951 | skip |= ValidateBufferUsageFlags(device_data, buffer_state, |
| 3952 | VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, false, |
| 3953 | "VUID-VkBufferViewCreateInfo-buffer-00932", "vkCreateBufferView()", |
| 3954 | "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); |
Shannon McPherson | 883f609 | 2018-06-14 13:15:25 -0600 | [diff] [blame] | 3955 | |
Shannon McPherson | 0eb84f6 | 2018-06-18 16:32:40 -0600 | [diff] [blame] | 3956 | // Buffer view offset must be less than the size of buffer |
| 3957 | if (pCreateInfo->offset >= buffer_state->createInfo.size) { |
| 3958 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 3959 | HandleToUint64(buffer_state->buffer), "VUID-VkBufferViewCreateInfo-offset-00925", |
| 3960 | "VkBufferViewCreateInfo offset (%" PRIuLEAST64 |
| 3961 | ") must be less than the size of the buffer (%" PRIuLEAST64 ").", |
| 3962 | pCreateInfo->offset, buffer_state->createInfo.size); |
| 3963 | } |
| 3964 | |
Mark Lobodzinski | 5c04880 | 2019-03-07 10:47:31 -0700 | [diff] [blame] | 3965 | const VkPhysicalDeviceLimits *device_limits = &(GetPDProperties()->limits); |
Shannon McPherson | 883f609 | 2018-06-14 13:15:25 -0600 | [diff] [blame] | 3966 | // Buffer view offset must be a multiple of VkPhysicalDeviceLimits::minTexelBufferOffsetAlignment |
| 3967 | if ((pCreateInfo->offset % device_limits->minTexelBufferOffsetAlignment) != 0) { |
| 3968 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
| 3969 | HandleToUint64(buffer_state->buffer), "VUID-VkBufferViewCreateInfo-offset-00926", |
| 3970 | "VkBufferViewCreateInfo offset (%" PRIuLEAST64 |
| 3971 | ") must be a multiple of VkPhysicalDeviceLimits::minTexelBufferOffsetAlignment (%" PRIuLEAST64 ").", |
| 3972 | pCreateInfo->offset, device_limits->minTexelBufferOffsetAlignment); |
| 3973 | } |
Shannon McPherson | 4c9505b | 2018-06-19 15:18:55 -0600 | [diff] [blame] | 3974 | |
| 3975 | skip |= ValidateBufferViewRange(device_data, buffer_state, pCreateInfo, device_limits); |
Shannon McPherson | 265383a | 2018-06-21 15:37:52 -0600 | [diff] [blame] | 3976 | |
| 3977 | skip |= ValidateBufferViewBuffer(device_data, buffer_state, pCreateInfo); |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3978 | } |
Mark Lobodzinski | 95dbbe5 | 2017-02-09 10:40:41 -0700 | [diff] [blame] | 3979 | return skip; |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3980 | } |
| 3981 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3982 | void CoreChecks::PostCallRecordCreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, |
| 3983 | const VkAllocationCallbacks *pAllocator, VkBufferView *pView, VkResult result) { |
Mark Lobodzinski | 701507e | 2019-01-18 14:31:53 -0700 | [diff] [blame] | 3984 | if (result != VK_SUCCESS) return; |
Mark Lobodzinski | 1170cf2 | 2019-03-07 11:08:21 -0700 | [diff] [blame] | 3985 | (*GetBufferViewMap())[*pView] = std::unique_ptr<BUFFER_VIEW_STATE>(new BUFFER_VIEW_STATE(*pView, pCreateInfo)); |
Mark Lobodzinski | 9621074 | 2017-02-09 10:33:46 -0700 | [diff] [blame] | 3986 | } |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 3987 | |
| 3988 | // For the given format verify that the aspect masks make sense |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 3989 | bool CoreChecks::ValidateImageAspectMask(const layer_data *device_data, VkImage image, VkFormat format, |
| 3990 | VkImageAspectFlags aspect_mask, const char *func_name, const char *vuid) { |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 3991 | bool skip = false; |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3992 | VkDebugReportObjectTypeEXT objectType = VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT; |
| 3993 | if (image != VK_NULL_HANDLE) { |
| 3994 | objectType = VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT; |
| 3995 | } |
| 3996 | |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 3997 | if (FormatIsColor(format)) { |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 3998 | if ((aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 3999 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, objectType, HandleToUint64(image), vuid, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4000 | "%s: Color image formats must have the VK_IMAGE_ASPECT_COLOR_BIT set.", func_name); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4001 | } else if ((aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) != aspect_mask) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 4002 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, objectType, HandleToUint64(image), vuid, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4003 | "%s: Color image formats must have ONLY the VK_IMAGE_ASPECT_COLOR_BIT set.", func_name); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4004 | } |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4005 | } else if (FormatIsDepthAndStencil(format)) { |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4006 | if ((aspect_mask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) == 0) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 4007 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, objectType, HandleToUint64(image), vuid, |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 4008 | "%s: Depth/stencil image formats must have at least one of VK_IMAGE_ASPECT_DEPTH_BIT and " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4009 | "VK_IMAGE_ASPECT_STENCIL_BIT set.", |
| 4010 | func_name); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4011 | } else if ((aspect_mask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) != aspect_mask) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 4012 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, objectType, HandleToUint64(image), vuid, |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4013 | "%s: Combination depth/stencil image formats can have only the VK_IMAGE_ASPECT_DEPTH_BIT and " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4014 | "VK_IMAGE_ASPECT_STENCIL_BIT set.", |
| 4015 | func_name); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4016 | } |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4017 | } else if (FormatIsDepthOnly(format)) { |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4018 | if ((aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) != VK_IMAGE_ASPECT_DEPTH_BIT) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 4019 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, objectType, HandleToUint64(image), vuid, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4020 | "%s: Depth-only image formats must have the VK_IMAGE_ASPECT_DEPTH_BIT set.", func_name); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4021 | } else if ((aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) != aspect_mask) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 4022 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, objectType, HandleToUint64(image), vuid, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4023 | "%s: Depth-only image formats can have only the VK_IMAGE_ASPECT_DEPTH_BIT set.", func_name); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4024 | } |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4025 | } else if (FormatIsStencilOnly(format)) { |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4026 | if ((aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) != VK_IMAGE_ASPECT_STENCIL_BIT) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 4027 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, objectType, HandleToUint64(image), vuid, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4028 | "%s: Stencil-only image formats must have the VK_IMAGE_ASPECT_STENCIL_BIT set.", func_name); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4029 | } else if ((aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) != aspect_mask) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 4030 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, objectType, HandleToUint64(image), vuid, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4031 | "%s: Stencil-only image formats can have only the VK_IMAGE_ASPECT_STENCIL_BIT set.", func_name); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4032 | } |
Dave Houlton | 501b15b | 2018-03-30 15:07:41 -0600 | [diff] [blame] | 4033 | } else if (FormatIsMultiplane(format)) { |
| 4034 | VkImageAspectFlags valid_flags = VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT; |
| 4035 | if (3 == FormatPlaneCount(format)) { |
| 4036 | valid_flags = valid_flags | VK_IMAGE_ASPECT_PLANE_2_BIT; |
| 4037 | } |
| 4038 | if ((aspect_mask & valid_flags) != aspect_mask) { |
Tobias Hector | bbb1228 | 2018-10-22 15:17:59 +0100 | [diff] [blame] | 4039 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, objectType, HandleToUint64(image), vuid, |
Dave Houlton | 501b15b | 2018-03-30 15:07:41 -0600 | [diff] [blame] | 4040 | "%s: Multi-plane image formats may have only VK_IMAGE_ASPECT_COLOR_BIT or VK_IMAGE_ASPECT_PLANE_n_BITs " |
| 4041 | "set, where n = [0, 1, 2].", |
| 4042 | func_name); |
| 4043 | } |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4044 | } |
| 4045 | return skip; |
| 4046 | } |
| 4047 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4048 | bool CoreChecks::ValidateImageSubresourceRange(const layer_data *device_data, const uint32_t image_mip_count, |
| 4049 | const uint32_t image_layer_count, const VkImageSubresourceRange &subresourceRange, |
| 4050 | const char *cmd_name, const char *param_name, const char *image_layer_count_var_name, |
| 4051 | const uint64_t image_handle, SubresourceRangeErrorCodes errorCodes) { |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4052 | bool skip = false; |
Petr Kraus | 4d71868 | 2017-05-18 03:38:41 +0200 | [diff] [blame] | 4053 | |
| 4054 | // Validate mip levels |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4055 | if (subresourceRange.baseMipLevel >= image_mip_count) { |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 4056 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, image_handle, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 4057 | errorCodes.base_mip_err, |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4058 | "%s: %s.baseMipLevel (= %" PRIu32 |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4059 | ") is greater or equal to the mip level count of the image (i.e. greater or equal to %" PRIu32 ").", |
| 4060 | cmd_name, param_name, subresourceRange.baseMipLevel, image_mip_count); |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4061 | } |
Petr Kraus | 4d71868 | 2017-05-18 03:38:41 +0200 | [diff] [blame] | 4062 | |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4063 | if (subresourceRange.levelCount != VK_REMAINING_MIP_LEVELS) { |
| 4064 | if (subresourceRange.levelCount == 0) { |
| 4065 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, image_handle, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 4066 | errorCodes.mip_count_err, "%s: %s.levelCount is 0.", cmd_name, param_name); |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4067 | } else { |
| 4068 | const uint64_t necessary_mip_count = uint64_t{subresourceRange.baseMipLevel} + uint64_t{subresourceRange.levelCount}; |
Petr Kraus | 4d71868 | 2017-05-18 03:38:41 +0200 | [diff] [blame] | 4069 | |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4070 | if (necessary_mip_count > image_mip_count) { |
| 4071 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, image_handle, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 4072 | errorCodes.mip_count_err, |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4073 | "%s: %s.baseMipLevel + .levelCount (= %" PRIu32 " + %" PRIu32 " = %" PRIu64 |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4074 | ") is greater than the mip level count of the image (i.e. greater than %" PRIu32 ").", |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4075 | cmd_name, param_name, subresourceRange.baseMipLevel, subresourceRange.levelCount, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4076 | necessary_mip_count, image_mip_count); |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4077 | } |
Petr Kraus | 4d71868 | 2017-05-18 03:38:41 +0200 | [diff] [blame] | 4078 | } |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4079 | } |
Petr Kraus | 4d71868 | 2017-05-18 03:38:41 +0200 | [diff] [blame] | 4080 | |
| 4081 | // Validate array layers |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4082 | if (subresourceRange.baseArrayLayer >= image_layer_count) { |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 4083 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, image_handle, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 4084 | errorCodes.base_layer_err, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4085 | "%s: %s.baseArrayLayer (= %" PRIu32 |
| 4086 | ") is greater or equal to the %s of the image when it was created (i.e. greater or equal to %" PRIu32 ").", |
| 4087 | cmd_name, param_name, subresourceRange.baseArrayLayer, image_layer_count_var_name, image_layer_count); |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4088 | } |
Petr Kraus | 4d71868 | 2017-05-18 03:38:41 +0200 | [diff] [blame] | 4089 | |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4090 | if (subresourceRange.layerCount != VK_REMAINING_ARRAY_LAYERS) { |
| 4091 | if (subresourceRange.layerCount == 0) { |
| 4092 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, image_handle, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 4093 | errorCodes.layer_count_err, "%s: %s.layerCount is 0.", cmd_name, param_name); |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4094 | } else { |
| 4095 | const uint64_t necessary_layer_count = |
| 4096 | uint64_t{subresourceRange.baseArrayLayer} + uint64_t{subresourceRange.layerCount}; |
Petr Kraus | 8423f15 | 2017-05-26 01:20:04 +0200 | [diff] [blame] | 4097 | |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4098 | if (necessary_layer_count > image_layer_count) { |
| 4099 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, image_handle, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 4100 | errorCodes.layer_count_err, |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4101 | "%s: %s.baseArrayLayer + .layerCount (= %" PRIu32 " + %" PRIu32 " = %" PRIu64 |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4102 | ") is greater than the %s of the image when it was created (i.e. greater than %" PRIu32 ").", |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4103 | cmd_name, param_name, subresourceRange.baseArrayLayer, subresourceRange.layerCount, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4104 | necessary_layer_count, image_layer_count_var_name, image_layer_count); |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4105 | } |
Petr Kraus | 4d71868 | 2017-05-18 03:38:41 +0200 | [diff] [blame] | 4106 | } |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4107 | } |
Petr Kraus | 4d71868 | 2017-05-18 03:38:41 +0200 | [diff] [blame] | 4108 | |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4109 | return skip; |
| 4110 | } |
| 4111 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4112 | bool CoreChecks::ValidateCreateImageViewSubresourceRange(const layer_data *device_data, const IMAGE_STATE *image_state, |
| 4113 | bool is_imageview_2d_type, |
| 4114 | const VkImageSubresourceRange &subresourceRange) { |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 4115 | bool is_khr_maintenance1 = GetDeviceExtensions()->vk_khr_maintenance1; |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4116 | bool is_image_slicable = image_state->createInfo.imageType == VK_IMAGE_TYPE_3D && |
| 4117 | (image_state->createInfo.flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT_KHR); |
| 4118 | bool is_3D_to_2D_map = is_khr_maintenance1 && is_image_slicable && is_imageview_2d_type; |
| 4119 | |
| 4120 | const auto image_layer_count = is_3D_to_2D_map ? image_state->createInfo.extent.depth : image_state->createInfo.arrayLayers; |
| 4121 | const auto image_layer_count_var_name = is_3D_to_2D_map ? "extent.depth" : "arrayLayers"; |
| 4122 | |
| 4123 | SubresourceRangeErrorCodes subresourceRangeErrorCodes = {}; |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4124 | subresourceRangeErrorCodes.base_mip_err = "VUID-VkImageViewCreateInfo-subresourceRange-01478"; |
| 4125 | subresourceRangeErrorCodes.mip_count_err = "VUID-VkImageViewCreateInfo-subresourceRange-01718"; |
| 4126 | subresourceRangeErrorCodes.base_layer_err = is_khr_maintenance1 ? (is_3D_to_2D_map ? "VUID-VkImageViewCreateInfo-image-01484" |
| 4127 | : "VUID-VkImageViewCreateInfo-image-01482") |
| 4128 | : "VUID-VkImageViewCreateInfo-subresourceRange-01480"; |
| 4129 | subresourceRangeErrorCodes.layer_count_err = is_khr_maintenance1 |
| 4130 | ? (is_3D_to_2D_map ? "VUID-VkImageViewCreateInfo-subresourceRange-01485" |
| 4131 | : "VUID-VkImageViewCreateInfo-subresourceRange-01483") |
| 4132 | : "VUID-VkImageViewCreateInfo-subresourceRange-01719"; |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4133 | |
| 4134 | return ValidateImageSubresourceRange(device_data, image_state->createInfo.mipLevels, image_layer_count, subresourceRange, |
| 4135 | "vkCreateImageView", "pCreateInfo->subresourceRange", image_layer_count_var_name, |
| 4136 | HandleToUint64(image_state->image), subresourceRangeErrorCodes); |
| 4137 | } |
| 4138 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4139 | bool CoreChecks::ValidateCmdClearColorSubresourceRange(const layer_data *device_data, const IMAGE_STATE *image_state, |
| 4140 | const VkImageSubresourceRange &subresourceRange, const char *param_name) { |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4141 | SubresourceRangeErrorCodes subresourceRangeErrorCodes = {}; |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4142 | subresourceRangeErrorCodes.base_mip_err = "VUID-vkCmdClearColorImage-baseMipLevel-01470"; |
| 4143 | subresourceRangeErrorCodes.mip_count_err = "VUID-vkCmdClearColorImage-pRanges-01692"; |
| 4144 | subresourceRangeErrorCodes.base_layer_err = "VUID-vkCmdClearColorImage-baseArrayLayer-01472"; |
| 4145 | subresourceRangeErrorCodes.layer_count_err = "VUID-vkCmdClearColorImage-pRanges-01693"; |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4146 | |
| 4147 | return ValidateImageSubresourceRange(device_data, image_state->createInfo.mipLevels, image_state->createInfo.arrayLayers, |
| 4148 | subresourceRange, "vkCmdClearColorImage", param_name, "arrayLayers", |
| 4149 | HandleToUint64(image_state->image), subresourceRangeErrorCodes); |
| 4150 | } |
| 4151 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4152 | bool CoreChecks::ValidateCmdClearDepthSubresourceRange(const layer_data *device_data, const IMAGE_STATE *image_state, |
| 4153 | const VkImageSubresourceRange &subresourceRange, const char *param_name) { |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4154 | SubresourceRangeErrorCodes subresourceRangeErrorCodes = {}; |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4155 | subresourceRangeErrorCodes.base_mip_err = "VUID-vkCmdClearDepthStencilImage-baseMipLevel-01474"; |
| 4156 | subresourceRangeErrorCodes.mip_count_err = "VUID-vkCmdClearDepthStencilImage-pRanges-01694"; |
| 4157 | subresourceRangeErrorCodes.base_layer_err = "VUID-vkCmdClearDepthStencilImage-baseArrayLayer-01476"; |
| 4158 | subresourceRangeErrorCodes.layer_count_err = "VUID-vkCmdClearDepthStencilImage-pRanges-01695"; |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4159 | |
| 4160 | return ValidateImageSubresourceRange(device_data, image_state->createInfo.mipLevels, image_state->createInfo.arrayLayers, |
| 4161 | subresourceRange, "vkCmdClearDepthStencilImage", param_name, "arrayLayers", |
| 4162 | HandleToUint64(image_state->image), subresourceRangeErrorCodes); |
| 4163 | } |
| 4164 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4165 | bool CoreChecks::ValidateImageBarrierSubresourceRange(const layer_data *device_data, const IMAGE_STATE *image_state, |
| 4166 | const VkImageSubresourceRange &subresourceRange, const char *cmd_name, |
| 4167 | const char *param_name) { |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4168 | SubresourceRangeErrorCodes subresourceRangeErrorCodes = {}; |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4169 | subresourceRangeErrorCodes.base_mip_err = "VUID-VkImageMemoryBarrier-subresourceRange-01486"; |
| 4170 | subresourceRangeErrorCodes.mip_count_err = "VUID-VkImageMemoryBarrier-subresourceRange-01724"; |
| 4171 | subresourceRangeErrorCodes.base_layer_err = "VUID-VkImageMemoryBarrier-subresourceRange-01488"; |
| 4172 | subresourceRangeErrorCodes.layer_count_err = "VUID-VkImageMemoryBarrier-subresourceRange-01725"; |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4173 | |
| 4174 | return ValidateImageSubresourceRange(device_data, image_state->createInfo.mipLevels, image_state->createInfo.arrayLayers, |
| 4175 | subresourceRange, cmd_name, param_name, "arrayLayers", HandleToUint64(image_state->image), |
| 4176 | subresourceRangeErrorCodes); |
| 4177 | } |
| 4178 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4179 | bool CoreChecks::PreCallValidateCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, |
| 4180 | const VkAllocationCallbacks *pAllocator, VkImageView *pView) { |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4181 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4182 | bool skip = false; |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 4183 | IMAGE_STATE *image_state = GetImageState(pCreateInfo->image); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4184 | if (image_state) { |
| 4185 | skip |= ValidateImageUsageFlags( |
| 4186 | device_data, image_state, |
| 4187 | VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT | |
Dave Houlton | 142c4cb | 2018-10-17 15:04:41 -0600 | [diff] [blame] | 4188 | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | |
| 4189 | VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, |
Dave Houlton | 8e9f654 | 2018-05-18 12:18:22 -0600 | [diff] [blame] | 4190 | false, kVUIDUndefined, "vkCreateImageView()", |
Jeff Bolz | 9af91c5 | 2018-09-01 21:53:57 -0500 | [diff] [blame] | 4191 | "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT|DEPTH_STENCIL_ATTACHMENT|INPUT_ATTACHMENT|SHADING_RATE_IMAGE]_BIT"); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4192 | // If this isn't a sparse image, it needs to have memory backing it at CreateImageView time |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4193 | skip |= |
| 4194 | ValidateMemoryIsBoundToImage(device_data, image_state, "vkCreateImageView()", "VUID-VkImageViewCreateInfo-image-01020"); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4195 | // Checks imported from image layer |
Petr Kraus | ffa94af | 2017-08-08 21:46:02 +0200 | [diff] [blame] | 4196 | skip |= ValidateCreateImageViewSubresourceRange( |
| 4197 | device_data, image_state, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4198 | pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_2D || pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_2D_ARRAY, |
| 4199 | pCreateInfo->subresourceRange); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4200 | |
| 4201 | VkImageCreateFlags image_flags = image_state->createInfo.flags; |
| 4202 | VkFormat image_format = image_state->createInfo.format; |
Jeremy Kniager | cef491c | 2017-07-18 11:10:28 -0600 | [diff] [blame] | 4203 | VkImageUsageFlags image_usage = image_state->createInfo.usage; |
| 4204 | VkImageTiling image_tiling = image_state->createInfo.tiling; |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4205 | VkFormat view_format = pCreateInfo->format; |
| 4206 | VkImageAspectFlags aspect_mask = pCreateInfo->subresourceRange.aspectMask; |
Jeremy Kniager | 846ab73 | 2017-07-10 13:12:04 -0600 | [diff] [blame] | 4207 | VkImageType image_type = image_state->createInfo.imageType; |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4208 | VkImageViewType view_type = pCreateInfo->viewType; |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4209 | |
Dave Houlton | bd2e262 | 2018-04-10 16:41:14 -0600 | [diff] [blame] | 4210 | // If there's a chained VkImageViewUsageCreateInfo struct, modify image_usage to match |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4211 | auto chained_ivuci_struct = lvl_find_in_chain<VkImageViewUsageCreateInfoKHR>(pCreateInfo->pNext); |
Dave Houlton | bd2e262 | 2018-04-10 16:41:14 -0600 | [diff] [blame] | 4212 | if (chained_ivuci_struct) { |
| 4213 | if (chained_ivuci_struct->usage & ~image_usage) { |
| 4214 | std::stringstream ss; |
| 4215 | ss << "vkCreateImageView(): Chained VkImageViewUsageCreateInfo usage field (0x" << std::hex |
Dave Houlton | 0f3795b | 2018-04-13 15:04:35 -0600 | [diff] [blame] | 4216 | << chained_ivuci_struct->usage << ") must not include flags not present in underlying image's usage (0x" |
Dave Houlton | bd2e262 | 2018-04-10 16:41:14 -0600 | [diff] [blame] | 4217 | << image_usage << ")."; |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4218 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4219 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewUsageCreateInfo-usage-01587", "%s", |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4220 | ss.str().c_str()); |
Dave Houlton | bd2e262 | 2018-04-10 16:41:14 -0600 | [diff] [blame] | 4221 | } |
| 4222 | |
| 4223 | image_usage = chained_ivuci_struct->usage; |
| 4224 | } |
| 4225 | |
Dave Houlton | 6f5f20a | 2018-05-04 12:37:44 -0600 | [diff] [blame] | 4226 | // Validate VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT state, if view/image formats differ |
| 4227 | if ((image_flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT) && (image_format != view_format)) { |
Dave Houlton | c798807 | 2018-04-16 11:46:56 -0600 | [diff] [blame] | 4228 | if (FormatIsMultiplane(image_format)) { |
| 4229 | // View format must match the multiplane compatible format |
| 4230 | uint32_t plane = 3; // invalid |
| 4231 | switch (aspect_mask) { |
| 4232 | case VK_IMAGE_ASPECT_PLANE_0_BIT: |
| 4233 | plane = 0; |
| 4234 | break; |
| 4235 | case VK_IMAGE_ASPECT_PLANE_1_BIT: |
| 4236 | plane = 1; |
| 4237 | break; |
| 4238 | case VK_IMAGE_ASPECT_PLANE_2_BIT: |
| 4239 | plane = 2; |
| 4240 | break; |
| 4241 | default: |
| 4242 | break; |
| 4243 | } |
| 4244 | |
| 4245 | VkFormat compat_format = FindMultiplaneCompatibleFormat(image_format, plane); |
| 4246 | if (view_format != compat_format) { |
Lenny Komow | b79f04a | 2017-09-18 17:07:00 -0600 | [diff] [blame] | 4247 | std::stringstream ss; |
| 4248 | ss << "vkCreateImageView(): ImageView format " << string_VkFormat(view_format) |
Dave Houlton | c798807 | 2018-04-16 11:46:56 -0600 | [diff] [blame] | 4249 | << " is not compatible with plane " << plane << " of underlying image format " |
| 4250 | << string_VkFormat(image_format) << ", must be " << string_VkFormat(compat_format) << "."; |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4251 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4252 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-image-01586", "%s", |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4253 | ss.str().c_str()); |
Dave Houlton | c798807 | 2018-04-16 11:46:56 -0600 | [diff] [blame] | 4254 | } |
| 4255 | } else { |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 4256 | if ((!GetDeviceExtensions()->vk_khr_maintenance2 || |
Dave Houlton | c798807 | 2018-04-16 11:46:56 -0600 | [diff] [blame] | 4257 | !(image_flags & VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR))) { |
| 4258 | // Format MUST be compatible (in the same format compatibility class) as the format the image was created with |
| 4259 | if (FormatCompatibilityClass(image_format) != FormatCompatibilityClass(view_format)) { |
| 4260 | std::stringstream ss; |
| 4261 | ss << "vkCreateImageView(): ImageView format " << string_VkFormat(view_format) |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 4262 | << " is not in the same format compatibility class as image (" |
| 4263 | << report_data->FormatHandle(pCreateInfo->image).c_str() << ") format " << string_VkFormat(image_format) |
Dave Houlton | c798807 | 2018-04-16 11:46:56 -0600 | [diff] [blame] | 4264 | << ". Images created with the VK_IMAGE_CREATE_MUTABLE_FORMAT BIT " |
| 4265 | << "can support ImageViews with differing formats but they must be in the same compatibility class."; |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4266 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4267 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-image-01018", "%s", |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4268 | ss.str().c_str()); |
Dave Houlton | c798807 | 2018-04-16 11:46:56 -0600 | [diff] [blame] | 4269 | } |
Lenny Komow | b79f04a | 2017-09-18 17:07:00 -0600 | [diff] [blame] | 4270 | } |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4271 | } |
| 4272 | } else { |
| 4273 | // Format MUST be IDENTICAL to the format the image was created with |
| 4274 | if (image_format != view_format) { |
| 4275 | std::stringstream ss; |
| 4276 | ss << "vkCreateImageView() format " << string_VkFormat(view_format) << " differs from image " |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 4277 | << report_data->FormatHandle(pCreateInfo->image).c_str() << " format " << string_VkFormat(image_format) |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4278 | << ". Formats MUST be IDENTICAL unless VK_IMAGE_CREATE_MUTABLE_FORMAT BIT was set on image creation."; |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4279 | skip |= |
| 4280 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4281 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-image-01019", "%s", ss.str().c_str()); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4282 | } |
| 4283 | } |
| 4284 | |
| 4285 | // Validate correct image aspect bits for desired formats and format consistency |
| 4286 | skip |= ValidateImageAspectMask(device_data, image_state->image, image_format, aspect_mask, "vkCreateImageView()"); |
Jeremy Kniager | 846ab73 | 2017-07-10 13:12:04 -0600 | [diff] [blame] | 4287 | |
| 4288 | switch (image_type) { |
| 4289 | case VK_IMAGE_TYPE_1D: |
| 4290 | if (view_type != VK_IMAGE_VIEW_TYPE_1D && view_type != VK_IMAGE_VIEW_TYPE_1D_ARRAY) { |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4291 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4292 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-subResourceRange-01021", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4293 | "vkCreateImageView(): pCreateInfo->viewType %s is not compatible with image type %s.", |
| 4294 | string_VkImageViewType(view_type), string_VkImageType(image_type)); |
Jeremy Kniager | 846ab73 | 2017-07-10 13:12:04 -0600 | [diff] [blame] | 4295 | } |
| 4296 | break; |
| 4297 | case VK_IMAGE_TYPE_2D: |
| 4298 | if (view_type != VK_IMAGE_VIEW_TYPE_2D && view_type != VK_IMAGE_VIEW_TYPE_2D_ARRAY) { |
| 4299 | if ((view_type == VK_IMAGE_VIEW_TYPE_CUBE || view_type == VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) && |
| 4300 | !(image_flags & VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT)) { |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4301 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4302 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-image-01003", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4303 | "vkCreateImageView(): pCreateInfo->viewType %s is not compatible with image type %s.", |
| 4304 | string_VkImageViewType(view_type), string_VkImageType(image_type)); |
Jeremy Kniager | 846ab73 | 2017-07-10 13:12:04 -0600 | [diff] [blame] | 4305 | } else if (view_type != VK_IMAGE_VIEW_TYPE_CUBE && view_type != VK_IMAGE_VIEW_TYPE_CUBE_ARRAY) { |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4306 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4307 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-subResourceRange-01021", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4308 | "vkCreateImageView(): pCreateInfo->viewType %s is not compatible with image type %s.", |
| 4309 | string_VkImageViewType(view_type), string_VkImageType(image_type)); |
Jeremy Kniager | 846ab73 | 2017-07-10 13:12:04 -0600 | [diff] [blame] | 4310 | } |
| 4311 | } |
| 4312 | break; |
| 4313 | case VK_IMAGE_TYPE_3D: |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 4314 | if (GetDeviceExtensions()->vk_khr_maintenance1) { |
Jeremy Kniager | 846ab73 | 2017-07-10 13:12:04 -0600 | [diff] [blame] | 4315 | if (view_type != VK_IMAGE_VIEW_TYPE_3D) { |
| 4316 | if ((view_type == VK_IMAGE_VIEW_TYPE_2D || view_type == VK_IMAGE_VIEW_TYPE_2D_ARRAY)) { |
| 4317 | if (!(image_flags & VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT_KHR)) { |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4318 | skip |= |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4319 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4320 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-image-01005", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4321 | "vkCreateImageView(): pCreateInfo->viewType %s is not compatible with image type %s.", |
| 4322 | string_VkImageViewType(view_type), string_VkImageType(image_type)); |
Jeremy Kniager | 846ab73 | 2017-07-10 13:12:04 -0600 | [diff] [blame] | 4323 | } else if ((image_flags & (VK_IMAGE_CREATE_SPARSE_BINDING_BIT | VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT | |
| 4324 | VK_IMAGE_CREATE_SPARSE_ALIASED_BIT))) { |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 4325 | skip |= |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4326 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4327 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-subResourceRange-01021", |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 4328 | "vkCreateImageView(): pCreateInfo->viewType %s is not compatible with image type %s " |
| 4329 | "when the VK_IMAGE_CREATE_SPARSE_BINDING_BIT, VK_IMAGE_CREATE_SPARSE_RESIDENCY_BIT, or " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4330 | "VK_IMAGE_CREATE_SPARSE_ALIASED_BIT flags are enabled.", |
| 4331 | string_VkImageViewType(view_type), string_VkImageType(image_type)); |
Jeremy Kniager | 846ab73 | 2017-07-10 13:12:04 -0600 | [diff] [blame] | 4332 | } |
| 4333 | } else { |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4334 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4335 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-subResourceRange-01021", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4336 | "vkCreateImageView(): pCreateInfo->viewType %s is not compatible with image type %s.", |
| 4337 | string_VkImageViewType(view_type), string_VkImageType(image_type)); |
Jeremy Kniager | 846ab73 | 2017-07-10 13:12:04 -0600 | [diff] [blame] | 4338 | } |
| 4339 | } |
| 4340 | } else { |
| 4341 | if (view_type != VK_IMAGE_VIEW_TYPE_3D) { |
Mark Young | 9d1ac31 | 2018-05-21 16:28:27 -0600 | [diff] [blame] | 4342 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4343 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-subResourceRange-01021", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4344 | "vkCreateImageView(): pCreateInfo->viewType %s is not compatible with image type %s.", |
| 4345 | string_VkImageViewType(view_type), string_VkImageType(image_type)); |
Jeremy Kniager | 846ab73 | 2017-07-10 13:12:04 -0600 | [diff] [blame] | 4346 | } |
| 4347 | } |
| 4348 | break; |
| 4349 | default: |
| 4350 | break; |
| 4351 | } |
Jeremy Kniager | cef491c | 2017-07-18 11:10:28 -0600 | [diff] [blame] | 4352 | |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 4353 | // External format checks needed when VK_ANDROID_external_memory_android_hardware_buffer enabled |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 4354 | if (GetDeviceExtensions()->vk_android_external_memory_android_hardware_buffer) { |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4355 | skip |= ValidateCreateImageViewANDROID(device_data, pCreateInfo); |
Jeremy Kniager | cef491c | 2017-07-18 11:10:28 -0600 | [diff] [blame] | 4356 | } |
| 4357 | |
Mark Lobodzinski | 5c04880 | 2019-03-07 10:47:31 -0700 | [diff] [blame] | 4358 | VkFormatProperties format_properties = GetPDFormatProperties(view_format); |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 4359 | VkFormatFeatureFlags tiling_features = (image_tiling & VK_IMAGE_TILING_LINEAR) ? format_properties.linearTilingFeatures |
| 4360 | : format_properties.optimalTilingFeatures; |
| 4361 | |
| 4362 | if (tiling_features == 0) { |
| 4363 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4364 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-None-02273", |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 4365 | "vkCreateImageView(): pCreateInfo->format %s with tiling %s has no supported format features on this " |
| 4366 | "physical device.", |
| 4367 | string_VkFormat(view_format), string_VkImageTiling(image_tiling)); |
| 4368 | } else if ((image_usage & VK_IMAGE_USAGE_SAMPLED_BIT) && !(tiling_features & VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT)) { |
| 4369 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4370 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-usage-02274", |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 4371 | "vkCreateImageView(): pCreateInfo->format %s with tiling %s does not support usage that includes " |
| 4372 | "VK_IMAGE_USAGE_SAMPLED_BIT.", |
| 4373 | string_VkFormat(view_format), string_VkImageTiling(image_tiling)); |
| 4374 | } else if ((image_usage & VK_IMAGE_USAGE_STORAGE_BIT) && !(tiling_features & VK_FORMAT_FEATURE_STORAGE_IMAGE_BIT)) { |
| 4375 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4376 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-usage-02275", |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 4377 | "vkCreateImageView(): pCreateInfo->format %s with tiling %s does not support usage that includes " |
| 4378 | "VK_IMAGE_USAGE_STORAGE_BIT.", |
| 4379 | string_VkFormat(view_format), string_VkImageTiling(image_tiling)); |
| 4380 | } else if ((image_usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) && |
| 4381 | !(tiling_features & VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT)) { |
| 4382 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4383 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-usage-02276", |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 4384 | "vkCreateImageView(): pCreateInfo->format %s with tiling %s does not support usage that includes " |
| 4385 | "VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT.", |
| 4386 | string_VkFormat(view_format), string_VkImageTiling(image_tiling)); |
| 4387 | } else if ((image_usage & VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT) && |
| 4388 | !(tiling_features & VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT)) { |
| 4389 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4390 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-usage-02277", |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 4391 | "vkCreateImageView(): pCreateInfo->format %s with tiling %s does not support usage that includes " |
| 4392 | "VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT.", |
| 4393 | string_VkFormat(view_format), string_VkImageTiling(image_tiling)); |
Jeremy Kniager | cef491c | 2017-07-18 11:10:28 -0600 | [diff] [blame] | 4394 | } |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 4395 | |
Jeff Bolz | 9af91c5 | 2018-09-01 21:53:57 -0500 | [diff] [blame] | 4396 | if (image_usage & VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV) { |
| 4397 | if (view_type != VK_IMAGE_VIEW_TYPE_2D && view_type != VK_IMAGE_VIEW_TYPE_2D_ARRAY) { |
| 4398 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4399 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-image-02086", |
Jeff Bolz | 9af91c5 | 2018-09-01 21:53:57 -0500 | [diff] [blame] | 4400 | "vkCreateImageView() If image was created with usage containing " |
| 4401 | "VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, viewType must be " |
| 4402 | "VK_IMAGE_VIEW_TYPE_2D or VK_IMAGE_VIEW_TYPE_2D_ARRAY."); |
| 4403 | } |
| 4404 | if (view_format != VK_FORMAT_R8_UINT) { |
| 4405 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4406 | HandleToUint64(pCreateInfo->image), "VUID-VkImageViewCreateInfo-image-02087", |
Jeff Bolz | 9af91c5 | 2018-09-01 21:53:57 -0500 | [diff] [blame] | 4407 | "vkCreateImageView() If image was created with usage containing " |
| 4408 | "VK_IMAGE_USAGE_SHADING_RATE_IMAGE_BIT_NV, format must be VK_FORMAT_R8_UINT."); |
| 4409 | } |
| 4410 | } |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4411 | } |
| 4412 | return skip; |
| 4413 | } |
| 4414 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4415 | void CoreChecks::PostCallRecordCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, |
| 4416 | const VkAllocationCallbacks *pAllocator, VkImageView *pView, VkResult result) { |
Mark Lobodzinski | 701507e | 2019-01-18 14:31:53 -0700 | [diff] [blame] | 4417 | if (result != VK_SUCCESS) return; |
Mark Lobodzinski | 1170cf2 | 2019-03-07 11:08:21 -0700 | [diff] [blame] | 4418 | auto image_view_map = GetImageViewMap(); |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4419 | (*image_view_map)[*pView] = std::unique_ptr<IMAGE_VIEW_STATE>(new IMAGE_VIEW_STATE(*pView, pCreateInfo)); |
Mark Lobodzinski | efd933b | 2017-02-10 12:09:23 -0700 | [diff] [blame] | 4420 | |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 4421 | auto image_state = GetImageState(pCreateInfo->image); |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4422 | auto &sub_res_range = (*image_view_map)[*pView].get()->create_info.subresourceRange; |
Mark Lobodzinski | 903e5ff | 2017-03-23 09:43:35 -0600 | [diff] [blame] | 4423 | sub_res_range.levelCount = ResolveRemainingLevels(&sub_res_range, image_state->createInfo.mipLevels); |
| 4424 | sub_res_range.layerCount = ResolveRemainingLayers(&sub_res_range, image_state->createInfo.arrayLayers); |
Mark Lobodzinski | 602de98 | 2017-02-09 11:01:33 -0700 | [diff] [blame] | 4425 | } |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 4426 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4427 | bool CoreChecks::PreCallValidateCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, |
| 4428 | uint32_t regionCount, const VkBufferCopy *pRegions) { |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 4429 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 4430 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 4431 | auto src_buffer_state = GetBufferState(srcBuffer); |
| 4432 | auto dst_buffer_state = GetBufferState(dstBuffer); |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 4433 | |
Mark Lobodzinski | 680421d | 2017-02-09 13:06:56 -0700 | [diff] [blame] | 4434 | bool skip = false; |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4435 | skip |= |
| 4436 | ValidateMemoryIsBoundToBuffer(device_data, src_buffer_state, "vkCmdCopyBuffer()", "VUID-vkCmdCopyBuffer-srcBuffer-00119"); |
| 4437 | skip |= |
| 4438 | ValidateMemoryIsBoundToBuffer(device_data, dst_buffer_state, "vkCmdCopyBuffer()", "VUID-vkCmdCopyBuffer-dstBuffer-00121"); |
Mark Lobodzinski | 680421d | 2017-02-09 13:06:56 -0700 | [diff] [blame] | 4439 | // Validate that SRC & DST buffers have correct usage flags set |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4440 | skip |= |
| 4441 | ValidateBufferUsageFlags(device_data, src_buffer_state, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, |
| 4442 | "VUID-vkCmdCopyBuffer-srcBuffer-00118", "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); |
| 4443 | skip |= |
| 4444 | ValidateBufferUsageFlags(device_data, dst_buffer_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, |
| 4445 | "VUID-vkCmdCopyBuffer-dstBuffer-00120", "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Mike Schuchardt | 9c58240 | 2017-02-23 15:57:37 -0700 | [diff] [blame] | 4446 | skip |= ValidateCmdQueueFlags(device_data, cb_node, "vkCmdCopyBuffer()", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4447 | VK_QUEUE_TRANSFER_BIT | VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| 4448 | "VUID-vkCmdCopyBuffer-commandBuffer-cmdpool"); |
Mark Lobodzinski | 680421d | 2017-02-09 13:06:56 -0700 | [diff] [blame] | 4449 | skip |= ValidateCmd(device_data, cb_node, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 4450 | skip |= InsideRenderPass(device_data, cb_node, "vkCmdCopyBuffer()", "VUID-vkCmdCopyBuffer-renderpass"); |
Mark Lobodzinski | 680421d | 2017-02-09 13:06:56 -0700 | [diff] [blame] | 4451 | return skip; |
| 4452 | } |
Mark Lobodzinski | ab9be28 | 2017-02-09 12:01:27 -0700 | [diff] [blame] | 4453 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4454 | void CoreChecks::PreCallRecordCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, |
| 4455 | uint32_t regionCount, const VkBufferCopy *pRegions) { |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 4456 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 4457 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 4458 | auto src_buffer_state = GetBufferState(srcBuffer); |
| 4459 | auto dst_buffer_state = GetBufferState(dstBuffer); |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 4460 | |
Mark Lobodzinski | 680421d | 2017-02-09 13:06:56 -0700 | [diff] [blame] | 4461 | // Update bindings between buffers and cmd buffer |
| 4462 | AddCommandBufferBindingBuffer(device_data, cb_node, src_buffer_state); |
| 4463 | AddCommandBufferBindingBuffer(device_data, cb_node, dst_buffer_state); |
Mark Lobodzinski | 680421d | 2017-02-09 13:06:56 -0700 | [diff] [blame] | 4464 | } |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4465 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4466 | bool CoreChecks::ValidateIdleBuffer(layer_data *device_data, VkBuffer buffer) { |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4467 | bool skip = false; |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 4468 | auto buffer_state = GetBufferState(buffer); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4469 | if (!buffer_state) { |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 4470 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, HandleToUint64(buffer), |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 4471 | kVUID_Core_DrawState_DoubleDestroy, "Cannot free buffer %s that has not been allocated.", |
| 4472 | report_data->FormatHandle(buffer).c_str()); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4473 | } else { |
| 4474 | if (buffer_state->in_use.load()) { |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 4475 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4476 | HandleToUint64(buffer), "VUID-vkDestroyBuffer-buffer-00922", |
Locke | e9aeebf | 2019-03-03 23:50:08 -0700 | [diff] [blame] | 4477 | "Cannot free buffer %s that is in use by a command buffer.", report_data->FormatHandle(buffer).c_str()); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4478 | } |
| 4479 | } |
| 4480 | return skip; |
| 4481 | } |
| 4482 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4483 | bool CoreChecks::PreCallValidateDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4484 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | a3a230b | 2019-03-06 15:35:13 -0700 | [diff] [blame] | 4485 | IMAGE_VIEW_STATE *image_view_state = GetImageViewState(imageView); |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4486 | VK_OBJECT obj_struct = {HandleToUint64(imageView), kVulkanObjectTypeImageView}; |
| 4487 | |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4488 | bool skip = false; |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4489 | if (image_view_state) { |
| 4490 | skip |= ValidateObjectNotInUse(device_data, image_view_state, obj_struct, "vkDestroyImageView", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4491 | "VUID-vkDestroyImageView-imageView-01026"); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4492 | } |
| 4493 | return skip; |
| 4494 | } |
| 4495 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4496 | void CoreChecks::PreCallRecordDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4497 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | a3a230b | 2019-03-06 15:35:13 -0700 | [diff] [blame] | 4498 | IMAGE_VIEW_STATE *image_view_state = GetImageViewState(imageView); |
Mark Lobodzinski | c8c8d0d | 2019-01-10 12:55:26 -0700 | [diff] [blame] | 4499 | if (!image_view_state) return; |
| 4500 | VK_OBJECT obj_struct = {HandleToUint64(imageView), kVulkanObjectTypeImageView}; |
| 4501 | |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4502 | // Any bound cmd buffers are now invalid |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 4503 | InvalidateCommandBuffers(device_data, image_view_state->cb_bindings, obj_struct); |
Mark Lobodzinski | 1170cf2 | 2019-03-07 11:08:21 -0700 | [diff] [blame] | 4504 | (*GetImageViewMap()).erase(imageView); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4505 | } |
| 4506 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4507 | bool CoreChecks::PreCallValidateDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 4508 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 4509 | auto buffer_state = GetBufferState(buffer); |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 4510 | |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4511 | bool skip = false; |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 4512 | if (buffer_state) { |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 4513 | skip |= ValidateIdleBuffer(device_data, buffer); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4514 | } |
| 4515 | return skip; |
| 4516 | } |
| 4517 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4518 | void CoreChecks::PreCallRecordDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 4519 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| 4520 | if (!buffer) return; |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 4521 | auto buffer_state = GetBufferState(buffer); |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 4522 | VK_OBJECT obj_struct = {HandleToUint64(buffer), kVulkanObjectTypeBuffer}; |
| 4523 | |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 4524 | InvalidateCommandBuffers(device_data, buffer_state->cb_bindings, obj_struct); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4525 | for (auto mem_binding : buffer_state->GetBoundMemory()) { |
Mark Lobodzinski | 97f83f7 | 2019-03-07 10:01:52 -0700 | [diff] [blame] | 4526 | auto mem_info = GetMemObjInfo(mem_binding); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4527 | if (mem_info) { |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4528 | RemoveBufferMemoryRange(HandleToUint64(buffer), mem_info); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4529 | } |
| 4530 | } |
Mark Lobodzinski | 97f83f7 | 2019-03-07 10:01:52 -0700 | [diff] [blame] | 4531 | ClearMemoryObjectBindings(HandleToUint64(buffer), kVulkanObjectTypeBuffer); |
John Zulauf | 6b4aae8 | 2018-05-09 13:03:36 -0600 | [diff] [blame] | 4532 | EraseQFOReleaseBarriers<VkBufferMemoryBarrier>(device_data, buffer); |
Mark Lobodzinski | 1170cf2 | 2019-03-07 11:08:21 -0700 | [diff] [blame] | 4533 | GetBufferMap()->erase(buffer_state->buffer); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4534 | } |
| 4535 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4536 | bool CoreChecks::PreCallValidateDestroyBufferView(VkDevice device, VkBufferView bufferView, |
| 4537 | const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 4538 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
Mark Lobodzinski | 31aa9b0 | 2019-03-06 11:51:37 -0700 | [diff] [blame] | 4539 | auto buffer_view_state = GetBufferViewState(bufferView); |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 4540 | VK_OBJECT obj_struct = {HandleToUint64(bufferView), kVulkanObjectTypeBufferView}; |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4541 | bool skip = false; |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 4542 | if (buffer_view_state) { |
| 4543 | skip |= ValidateObjectNotInUse(device_data, buffer_view_state, obj_struct, "vkDestroyBufferView", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4544 | "VUID-vkDestroyBufferView-bufferView-00936"); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4545 | } |
| 4546 | return skip; |
| 4547 | } |
| 4548 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4549 | void CoreChecks::PreCallRecordDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 4550 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| 4551 | if (!bufferView) return; |
Mark Lobodzinski | 31aa9b0 | 2019-03-06 11:51:37 -0700 | [diff] [blame] | 4552 | auto buffer_view_state = GetBufferViewState(bufferView); |
Mark Lobodzinski | dd995d2 | 2019-01-11 11:05:15 -0700 | [diff] [blame] | 4553 | VK_OBJECT obj_struct = {HandleToUint64(bufferView), kVulkanObjectTypeBufferView}; |
| 4554 | |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4555 | // Any bound cmd buffers are now invalid |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 4556 | InvalidateCommandBuffers(device_data, buffer_view_state->cb_bindings, obj_struct); |
Mark Lobodzinski | 1170cf2 | 2019-03-07 11:08:21 -0700 | [diff] [blame] | 4557 | GetBufferViewMap()->erase(bufferView); |
Mark Lobodzinski | 306441e | 2017-02-10 13:48:38 -0700 | [diff] [blame] | 4558 | } |
Mark Lobodzinski | df0acbf | 2017-02-10 14:01:27 -0700 | [diff] [blame] | 4559 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4560 | bool CoreChecks::PreCallValidateCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, |
| 4561 | VkDeviceSize size, uint32_t data) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 4562 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 4563 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 4564 | auto buffer_state = GetBufferState(dstBuffer); |
Mark Lobodzinski | df0acbf | 2017-02-10 14:01:27 -0700 | [diff] [blame] | 4565 | bool skip = false; |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4566 | skip |= ValidateMemoryIsBoundToBuffer(device_data, buffer_state, "vkCmdFillBuffer()", "VUID-vkCmdFillBuffer-dstBuffer-00031"); |
Mike Schuchardt | 9c58240 | 2017-02-23 15:57:37 -0700 | [diff] [blame] | 4567 | skip |= ValidateCmdQueueFlags(device_data, cb_node, "vkCmdFillBuffer()", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4568 | VK_QUEUE_TRANSFER_BIT | VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT, |
| 4569 | "VUID-vkCmdFillBuffer-commandBuffer-cmdpool"); |
Mark Lobodzinski | df0acbf | 2017-02-10 14:01:27 -0700 | [diff] [blame] | 4570 | skip |= ValidateCmd(device_data, cb_node, CMD_FILLBUFFER, "vkCmdFillBuffer()"); |
| 4571 | // Validate that DST buffer has correct usage flags set |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4572 | skip |= |
| 4573 | ValidateBufferUsageFlags(device_data, buffer_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, |
| 4574 | "VUID-vkCmdFillBuffer-dstBuffer-00029", "vkCmdFillBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 4575 | skip |= InsideRenderPass(device_data, cb_node, "vkCmdFillBuffer()", "VUID-vkCmdFillBuffer-renderpass"); |
Mark Lobodzinski | df0acbf | 2017-02-10 14:01:27 -0700 | [diff] [blame] | 4576 | return skip; |
| 4577 | } |
| 4578 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4579 | void CoreChecks::PreCallRecordCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, |
| 4580 | VkDeviceSize size, uint32_t data) { |
Mark Lobodzinski | 9a075c2 | 2019-01-10 14:30:39 -0700 | [diff] [blame] | 4581 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 4582 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 4583 | auto buffer_state = GetBufferState(dstBuffer); |
Mark Lobodzinski | df0acbf | 2017-02-10 14:01:27 -0700 | [diff] [blame] | 4584 | // Update bindings between buffer and cmd buffer |
| 4585 | AddCommandBufferBindingBuffer(device_data, cb_node, buffer_state); |
Mark Lobodzinski | df0acbf | 2017-02-10 14:01:27 -0700 | [diff] [blame] | 4586 | } |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4587 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4588 | bool CoreChecks::ValidateBufferImageCopyData(const debug_report_data *report_data, uint32_t regionCount, |
| 4589 | const VkBufferImageCopy *pRegions, IMAGE_STATE *image_state, const char *function) { |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4590 | bool skip = false; |
| 4591 | |
| 4592 | for (uint32_t i = 0; i < regionCount; i++) { |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4593 | if (image_state->createInfo.imageType == VK_IMAGE_TYPE_1D) { |
| 4594 | if ((pRegions[i].imageOffset.y != 0) || (pRegions[i].imageExtent.height != 1)) { |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4595 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4596 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-srcImage-00199", |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 4597 | "%s(): pRegion[%d] imageOffset.y is %d and imageExtent.height is %d. For 1D images these must be 0 " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4598 | "and 1, respectively.", |
| 4599 | function, i, pRegions[i].imageOffset.y, pRegions[i].imageExtent.height); |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4600 | } |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4601 | } |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4602 | |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4603 | if ((image_state->createInfo.imageType == VK_IMAGE_TYPE_1D) || (image_state->createInfo.imageType == VK_IMAGE_TYPE_2D)) { |
| 4604 | if ((pRegions[i].imageOffset.z != 0) || (pRegions[i].imageExtent.depth != 1)) { |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4605 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4606 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-srcImage-00201", |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4607 | "%s(): pRegion[%d] imageOffset.z is %d and imageExtent.depth is %d. For 1D and 2D images these " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4608 | "must be 0 and 1, respectively.", |
| 4609 | function, i, pRegions[i].imageOffset.z, pRegions[i].imageExtent.depth); |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4610 | } |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4611 | } |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4612 | |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4613 | if (image_state->createInfo.imageType == VK_IMAGE_TYPE_3D) { |
| 4614 | if ((0 != pRegions[i].imageSubresource.baseArrayLayer) || (1 != pRegions[i].imageSubresource.layerCount)) { |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 4615 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4616 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-baseArrayLayer-00213", |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 4617 | "%s(): pRegion[%d] imageSubresource.baseArrayLayer is %d and imageSubresource.layerCount is %d. " |
| 4618 | "For 3D images these must be 0 and 1, respectively.", |
| 4619 | function, i, pRegions[i].imageSubresource.baseArrayLayer, pRegions[i].imageSubresource.layerCount); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4620 | } |
| 4621 | } |
| 4622 | |
| 4623 | // If the the calling command's VkImage parameter's format is not a depth/stencil format, |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 4624 | // then bufferOffset must be a multiple of the calling command's VkImage parameter's element size |
| 4625 | uint32_t element_size = FormatElementSize(image_state->createInfo.format); |
| 4626 | if (!FormatIsDepthAndStencil(image_state->createInfo.format) && SafeModulo(pRegions[i].bufferOffset, element_size) != 0) { |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4627 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4628 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-bufferOffset-00193", |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4629 | "%s(): pRegion[%d] bufferOffset 0x%" PRIxLEAST64 |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 4630 | " must be a multiple of this format's texel size (%" PRIu32 ").", |
| 4631 | function, i, pRegions[i].bufferOffset, element_size); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4632 | } |
| 4633 | |
| 4634 | // BufferOffset must be a multiple of 4 |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4635 | if (SafeModulo(pRegions[i].bufferOffset, 4) != 0) { |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4636 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4637 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-bufferOffset-00194", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4638 | "%s(): pRegion[%d] bufferOffset 0x%" PRIxLEAST64 " must be a multiple of 4.", function, i, |
| 4639 | pRegions[i].bufferOffset); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4640 | } |
| 4641 | |
| 4642 | // BufferRowLength must be 0, or greater than or equal to the width member of imageExtent |
| 4643 | if ((pRegions[i].bufferRowLength != 0) && (pRegions[i].bufferRowLength < pRegions[i].imageExtent.width)) { |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4644 | skip |= |
| 4645 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4646 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-bufferRowLength-00195", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4647 | "%s(): pRegion[%d] bufferRowLength (%d) must be zero or greater-than-or-equal-to imageExtent.width (%d).", |
| 4648 | function, i, pRegions[i].bufferRowLength, pRegions[i].imageExtent.width); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4649 | } |
| 4650 | |
| 4651 | // BufferImageHeight must be 0, or greater than or equal to the height member of imageExtent |
| 4652 | if ((pRegions[i].bufferImageHeight != 0) && (pRegions[i].bufferImageHeight < pRegions[i].imageExtent.height)) { |
| 4653 | skip |= log_msg( |
| 4654 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4655 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-bufferImageHeight-00196", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4656 | "%s(): pRegion[%d] bufferImageHeight (%d) must be zero or greater-than-or-equal-to imageExtent.height (%d).", |
| 4657 | function, i, pRegions[i].bufferImageHeight, pRegions[i].imageExtent.height); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4658 | } |
| 4659 | |
| 4660 | // subresource aspectMask must have exactly 1 bit set |
| 4661 | const int num_bits = sizeof(VkFlags) * CHAR_BIT; |
| 4662 | std::bitset<num_bits> aspect_mask_bits(pRegions[i].imageSubresource.aspectMask); |
| 4663 | if (aspect_mask_bits.count() != 1) { |
| 4664 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4665 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-aspectMask-00212", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4666 | "%s: aspectMasks for imageSubresource in each region must have only a single bit set.", function); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4667 | } |
| 4668 | |
| 4669 | // image subresource aspect bit must match format |
Dave Houlton | 4eaaf3a | 2017-03-14 11:31:20 -0600 | [diff] [blame] | 4670 | if (!VerifyAspectsPresent(pRegions[i].imageSubresource.aspectMask, image_state->createInfo.format)) { |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4671 | skip |= log_msg( |
| 4672 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4673 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-aspectMask-00211", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4674 | "%s(): pRegion[%d] subresource aspectMask 0x%x specifies aspects that are not present in image format 0x%x.", |
| 4675 | function, i, pRegions[i].imageSubresource.aspectMask, image_state->createInfo.format); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4676 | } |
| 4677 | |
| 4678 | // Checks that apply only to compressed images |
Cort Stratton | 420ebd4 | 2018-05-04 01:12:23 -0400 | [diff] [blame] | 4679 | if (FormatIsCompressed(image_state->createInfo.format) || FormatIsSinglePlane_422(image_state->createInfo.format)) { |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 4680 | auto block_size = FormatTexelBlockExtent(image_state->createInfo.format); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4681 | |
| 4682 | // BufferRowLength must be a multiple of block width |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4683 | if (SafeModulo(pRegions[i].bufferRowLength, block_size.width) != 0) { |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4684 | skip |= log_msg( |
| 4685 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4686 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-bufferRowLength-00203", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4687 | "%s(): pRegion[%d] bufferRowLength (%d) must be a multiple of the compressed image's texel width (%d)..", |
| 4688 | function, i, pRegions[i].bufferRowLength, block_size.width); |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4689 | } |
| 4690 | |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4691 | // BufferRowHeight must be a multiple of block height |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4692 | if (SafeModulo(pRegions[i].bufferImageHeight, block_size.height) != 0) { |
Dave Houlton | a9df0ce | 2018-02-07 10:51:23 -0700 | [diff] [blame] | 4693 | skip |= log_msg( |
| 4694 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4695 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-bufferImageHeight-00204", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4696 | "%s(): pRegion[%d] bufferImageHeight (%d) must be a multiple of the compressed image's texel height (%d)..", |
| 4697 | function, i, pRegions[i].bufferImageHeight, block_size.height); |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4698 | } |
| 4699 | |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4700 | // image offsets must be multiples of block dimensions |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4701 | if ((SafeModulo(pRegions[i].imageOffset.x, block_size.width) != 0) || |
| 4702 | (SafeModulo(pRegions[i].imageOffset.y, block_size.height) != 0) || |
| 4703 | (SafeModulo(pRegions[i].imageOffset.z, block_size.depth) != 0)) { |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4704 | skip |= |
| 4705 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4706 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-imageOffset-00205", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4707 | "%s(): pRegion[%d] imageOffset(x,y) (%d, %d) must be multiples of the compressed image's texel " |
| 4708 | "width & height (%d, %d)..", |
| 4709 | function, i, pRegions[i].imageOffset.x, pRegions[i].imageOffset.y, block_size.width, block_size.height); |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4710 | } |
| 4711 | |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4712 | // bufferOffset must be a multiple of block size (linear bytes) |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 4713 | uint32_t block_size_in_bytes = FormatElementSize(image_state->createInfo.format); |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4714 | if (SafeModulo(pRegions[i].bufferOffset, block_size_in_bytes) != 0) { |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4715 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4716 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-bufferOffset-00206", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4717 | "%s(): pRegion[%d] bufferOffset (0x%" PRIxLEAST64 |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 4718 | ") must be a multiple of the compressed image's texel block size (%" PRIu32 ")..", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4719 | function, i, pRegions[i].bufferOffset, block_size_in_bytes); |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4720 | } |
Dave Houlton | 67e9b53 | 2017-03-02 17:00:10 -0700 | [diff] [blame] | 4721 | |
| 4722 | // imageExtent width must be a multiple of block width, or extent+offset width must equal subresource width |
Dave Houlton | 75967fc | 2017-03-06 17:21:16 -0700 | [diff] [blame] | 4723 | VkExtent3D mip_extent = GetImageSubresourceExtent(image_state, &(pRegions[i].imageSubresource)); |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4724 | if ((SafeModulo(pRegions[i].imageExtent.width, block_size.width) != 0) && |
Dave Houlton | 75967fc | 2017-03-06 17:21:16 -0700 | [diff] [blame] | 4725 | (pRegions[i].imageExtent.width + pRegions[i].imageOffset.x != mip_extent.width)) { |
| 4726 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4727 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-imageExtent-00207", |
Dave Houlton | 75967fc | 2017-03-06 17:21:16 -0700 | [diff] [blame] | 4728 | "%s(): pRegion[%d] extent width (%d) must be a multiple of the compressed texture block width " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4729 | "(%d), or when added to offset.x (%d) must equal the image subresource width (%d)..", |
Dave Houlton | 75967fc | 2017-03-06 17:21:16 -0700 | [diff] [blame] | 4730 | function, i, pRegions[i].imageExtent.width, block_size.width, pRegions[i].imageOffset.x, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4731 | mip_extent.width); |
Dave Houlton | 67e9b53 | 2017-03-02 17:00:10 -0700 | [diff] [blame] | 4732 | } |
| 4733 | |
| 4734 | // imageExtent height must be a multiple of block height, or extent+offset height must equal subresource height |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4735 | if ((SafeModulo(pRegions[i].imageExtent.height, block_size.height) != 0) && |
Dave Houlton | 75967fc | 2017-03-06 17:21:16 -0700 | [diff] [blame] | 4736 | (pRegions[i].imageExtent.height + pRegions[i].imageOffset.y != mip_extent.height)) { |
| 4737 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4738 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-imageExtent-00208", |
Dave Houlton | 75967fc | 2017-03-06 17:21:16 -0700 | [diff] [blame] | 4739 | "%s(): pRegion[%d] extent height (%d) must be a multiple of the compressed texture block height " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4740 | "(%d), or when added to offset.y (%d) must equal the image subresource height (%d)..", |
Dave Houlton | 75967fc | 2017-03-06 17:21:16 -0700 | [diff] [blame] | 4741 | function, i, pRegions[i].imageExtent.height, block_size.height, pRegions[i].imageOffset.y, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4742 | mip_extent.height); |
Dave Houlton | 67e9b53 | 2017-03-02 17:00:10 -0700 | [diff] [blame] | 4743 | } |
| 4744 | |
| 4745 | // imageExtent depth must be a multiple of block depth, or extent+offset depth must equal subresource depth |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4746 | if ((SafeModulo(pRegions[i].imageExtent.depth, block_size.depth) != 0) && |
Dave Houlton | 75967fc | 2017-03-06 17:21:16 -0700 | [diff] [blame] | 4747 | (pRegions[i].imageExtent.depth + pRegions[i].imageOffset.z != mip_extent.depth)) { |
| 4748 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4749 | HandleToUint64(image_state->image), "VUID-VkBufferImageCopy-imageExtent-00209", |
Dave Houlton | 75967fc | 2017-03-06 17:21:16 -0700 | [diff] [blame] | 4750 | "%s(): pRegion[%d] extent width (%d) must be a multiple of the compressed texture block depth " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4751 | "(%d), or when added to offset.z (%d) must equal the image subresource depth (%d)..", |
Dave Houlton | 75967fc | 2017-03-06 17:21:16 -0700 | [diff] [blame] | 4752 | function, i, pRegions[i].imageExtent.depth, block_size.depth, pRegions[i].imageOffset.z, |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4753 | mip_extent.depth); |
Dave Houlton | 67e9b53 | 2017-03-02 17:00:10 -0700 | [diff] [blame] | 4754 | } |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4755 | } |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4756 | } |
| 4757 | |
| 4758 | return skip; |
| 4759 | } |
| 4760 | |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4761 | static bool ValidateImageBounds(const debug_report_data *report_data, const IMAGE_STATE *image_state, const uint32_t regionCount, |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 4762 | const VkBufferImageCopy *pRegions, const char *func_name, const char *msg_code) { |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4763 | bool skip = false; |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4764 | const VkImageCreateInfo *image_info = &(image_state->createInfo); |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4765 | |
| 4766 | for (uint32_t i = 0; i < regionCount; i++) { |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4767 | VkExtent3D extent = pRegions[i].imageExtent; |
| 4768 | VkOffset3D offset = pRegions[i].imageOffset; |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4769 | |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4770 | if (IsExtentSizeZero(&extent)) // Warn on zero area subresource |
| 4771 | { |
Dave Houlton | 5165390 | 2018-06-22 17:32:13 -0600 | [diff] [blame] | 4772 | skip |= |
| 4773 | log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)0, |
| 4774 | kVUID_Core_Image_ZeroAreaSubregion, "%s: pRegion[%d] imageExtent of {%1d, %1d, %1d} has zero area", |
| 4775 | func_name, i, extent.width, extent.height, extent.depth); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4776 | } |
| 4777 | |
| 4778 | VkExtent3D image_extent = GetImageSubresourceExtent(image_state, &(pRegions[i].imageSubresource)); |
| 4779 | |
| 4780 | // If we're using a compressed format, valid extent is rounded up to multiple of block size (per 18.1) |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 4781 | if (FormatIsCompressed(image_info->format)) { |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 4782 | auto block_extent = FormatTexelBlockExtent(image_info->format); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4783 | if (image_extent.width % block_extent.width) { |
| 4784 | image_extent.width += (block_extent.width - (image_extent.width % block_extent.width)); |
| 4785 | } |
| 4786 | if (image_extent.height % block_extent.height) { |
| 4787 | image_extent.height += (block_extent.height - (image_extent.height % block_extent.height)); |
| 4788 | } |
| 4789 | if (image_extent.depth % block_extent.depth) { |
| 4790 | image_extent.depth += (block_extent.depth - (image_extent.depth % block_extent.depth)); |
| 4791 | } |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4792 | } |
| 4793 | |
Dave Houlton | fc1a405 | 2017-04-27 14:32:45 -0600 | [diff] [blame] | 4794 | if (0 != ExceedsBounds(&offset, &extent, &image_extent)) { |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4795 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)0, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 4796 | msg_code, "%s: pRegion[%d] exceeds image bounds..", func_name, i); |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4797 | } |
| 4798 | } |
| 4799 | |
| 4800 | return skip; |
| 4801 | } |
| 4802 | |
Chris Forbes | e8ba09a | 2017-06-01 17:39:02 -0700 | [diff] [blame] | 4803 | static inline bool ValidateBufferBounds(const debug_report_data *report_data, IMAGE_STATE *image_state, BUFFER_STATE *buff_state, |
Dave Houlton | 33c2d25 | 2017-06-09 17:08:32 -0600 | [diff] [blame] | 4804 | uint32_t regionCount, const VkBufferImageCopy *pRegions, const char *func_name, |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 4805 | const char *msg_code) { |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4806 | bool skip = false; |
| 4807 | |
| 4808 | VkDeviceSize buffer_size = buff_state->createInfo.size; |
| 4809 | |
| 4810 | for (uint32_t i = 0; i < regionCount; i++) { |
| 4811 | VkExtent3D copy_extent = pRegions[i].imageExtent; |
| 4812 | |
| 4813 | VkDeviceSize buffer_width = (0 == pRegions[i].bufferRowLength ? copy_extent.width : pRegions[i].bufferRowLength); |
| 4814 | VkDeviceSize buffer_height = (0 == pRegions[i].bufferImageHeight ? copy_extent.height : pRegions[i].bufferImageHeight); |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 4815 | VkDeviceSize unit_size = FormatElementSize(image_state->createInfo.format); // size (bytes) of texel or block |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4816 | |
Dave Houlton | f3229d5 | 2017-02-21 15:59:08 -0700 | [diff] [blame] | 4817 | // Handle special buffer packing rules for specific depth/stencil formats |
| 4818 | if (pRegions[i].imageSubresource.aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) { |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 4819 | unit_size = FormatElementSize(VK_FORMAT_S8_UINT); |
Dave Houlton | f3229d5 | 2017-02-21 15:59:08 -0700 | [diff] [blame] | 4820 | } else if (pRegions[i].imageSubresource.aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) { |
| 4821 | switch (image_state->createInfo.format) { |
| 4822 | case VK_FORMAT_D16_UNORM_S8_UINT: |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 4823 | unit_size = FormatElementSize(VK_FORMAT_D16_UNORM); |
Dave Houlton | f3229d5 | 2017-02-21 15:59:08 -0700 | [diff] [blame] | 4824 | break; |
| 4825 | case VK_FORMAT_D32_SFLOAT_S8_UINT: |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 4826 | unit_size = FormatElementSize(VK_FORMAT_D32_SFLOAT); |
Dave Houlton | f3229d5 | 2017-02-21 15:59:08 -0700 | [diff] [blame] | 4827 | break; |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4828 | case VK_FORMAT_X8_D24_UNORM_PACK32: // Fall through |
Dave Houlton | f3229d5 | 2017-02-21 15:59:08 -0700 | [diff] [blame] | 4829 | case VK_FORMAT_D24_UNORM_S8_UINT: |
| 4830 | unit_size = 4; |
| 4831 | break; |
| 4832 | default: |
| 4833 | break; |
| 4834 | } |
| 4835 | } |
| 4836 | |
Tom Cooper | b2550c7 | 2018-10-15 13:08:41 +0100 | [diff] [blame] | 4837 | if (FormatIsCompressed(image_state->createInfo.format) || FormatIsSinglePlane_422(image_state->createInfo.format)) { |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4838 | // Switch to texel block units, rounding up for any partially-used blocks |
Dave Houlton | a585d13 | 2019-01-18 13:05:42 -0700 | [diff] [blame] | 4839 | auto block_dim = FormatTexelBlockExtent(image_state->createInfo.format); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4840 | buffer_width = (buffer_width + block_dim.width - 1) / block_dim.width; |
| 4841 | buffer_height = (buffer_height + block_dim.height - 1) / block_dim.height; |
| 4842 | |
| 4843 | copy_extent.width = (copy_extent.width + block_dim.width - 1) / block_dim.width; |
| 4844 | copy_extent.height = (copy_extent.height + block_dim.height - 1) / block_dim.height; |
| 4845 | copy_extent.depth = (copy_extent.depth + block_dim.depth - 1) / block_dim.depth; |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4846 | } |
| 4847 | |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4848 | // Either depth or layerCount may be greater than 1 (not both). This is the number of 'slices' to copy |
| 4849 | uint32_t z_copies = std::max(copy_extent.depth, pRegions[i].imageSubresource.layerCount); |
| 4850 | if (IsExtentSizeZero(©_extent) || (0 == z_copies)) { |
Chris Forbes | e8ba09a | 2017-06-01 17:39:02 -0700 | [diff] [blame] | 4851 | // TODO: Issue warning here? Already warned in ValidateImageBounds()... |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4852 | } else { |
| 4853 | // Calculate buffer offset of final copied byte, + 1. |
| 4854 | VkDeviceSize max_buffer_offset = (z_copies - 1) * buffer_height * buffer_width; // offset to slice |
| 4855 | max_buffer_offset += ((copy_extent.height - 1) * buffer_width) + copy_extent.width; // add row,col |
| 4856 | max_buffer_offset *= unit_size; // convert to bytes |
| 4857 | max_buffer_offset += pRegions[i].bufferOffset; // add initial offset (bytes) |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4858 | |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4859 | if (buffer_size < max_buffer_offset) { |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 4860 | skip |= |
| 4861 | log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)0, |
| 4862 | msg_code, "%s: pRegion[%d] exceeds buffer size of %" PRIu64 " bytes..", func_name, i, buffer_size); |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4863 | } |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4864 | } |
| 4865 | } |
| 4866 | |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 4867 | return skip; |
| 4868 | } |
| 4869 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4870 | bool CoreChecks::PreCallValidateCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 4871 | VkBuffer dstBuffer, uint32_t regionCount, const VkBufferImageCopy *pRegions) { |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 4872 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 4873 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 4874 | auto src_image_state = GetImageState(srcImage); |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 4875 | auto dst_buffer_state = GetBufferState(dstBuffer); |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 4876 | |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4877 | bool skip = ValidateBufferImageCopyData(report_data, regionCount, pRegions, src_image_state, "vkCmdCopyImageToBuffer"); |
| 4878 | |
| 4879 | // Validate command buffer state |
John Zulauf | 5c2750c | 2018-01-30 15:04:56 -0700 | [diff] [blame] | 4880 | skip |= ValidateCmd(device_data, cb_node, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4881 | |
| 4882 | // Command pool must support graphics, compute, or transfer operations |
Mark Lobodzinski | 8b0a7b8 | 2019-03-06 16:17:45 -0700 | [diff] [blame] | 4883 | auto pPool = GetCommandPoolNode(cb_node->createInfo.commandPool); |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4884 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4885 | VkQueueFlags queue_flags = GetPhysicalDeviceState()->queue_family_properties[pPool->queueFamilyIndex].queueFlags; |
Mark Lobodzinski | f6dd376 | 2019-02-27 12:11:59 -0700 | [diff] [blame] | 4886 | |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4887 | if (0 == (queue_flags & (VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT))) { |
| 4888 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4889 | HandleToUint64(cb_node->createInfo.commandPool), "VUID-vkCmdCopyImageToBuffer-commandBuffer-cmdpool", |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4890 | "Cannot call vkCmdCopyImageToBuffer() on a command buffer allocated from a pool without graphics, compute, " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4891 | "or transfer capabilities.."); |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4892 | } |
Dave Houlton | 0ef2749 | 2018-04-04 11:41:48 -0600 | [diff] [blame] | 4893 | skip |= ValidateImageBounds(report_data, src_image_state, regionCount, pRegions, "vkCmdCopyImageToBuffer()", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4894 | "VUID-vkCmdCopyImageToBuffer-pRegions-00182"); |
Chris Forbes | e8ba09a | 2017-06-01 17:39:02 -0700 | [diff] [blame] | 4895 | skip |= ValidateBufferBounds(report_data, src_image_state, dst_buffer_state, regionCount, pRegions, "vkCmdCopyImageToBuffer()", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4896 | "VUID-vkCmdCopyImageToBuffer-pRegions-00183"); |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4897 | |
| 4898 | skip |= ValidateImageSampleCount(device_data, src_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyImageToBuffer(): srcImage", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4899 | "VUID-vkCmdCopyImageToBuffer-srcImage-00188"); |
| 4900 | skip |= ValidateMemoryIsBoundToImage(device_data, src_image_state, "vkCmdCopyImageToBuffer()", |
| 4901 | "VUID-vkCmdCopyImageToBuffer-srcImage-00187"); |
| 4902 | skip |= ValidateMemoryIsBoundToBuffer(device_data, dst_buffer_state, "vkCmdCopyImageToBuffer()", |
| 4903 | "VUID-vkCmdCopyImageToBuffer-dstBuffer-00192"); |
Mark Lobodzinski | 033c90b | 2017-02-15 13:58:23 -0700 | [diff] [blame] | 4904 | |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4905 | // Validate that SRC image & DST buffer have correct usage flags set |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4906 | skip |= ValidateImageUsageFlags(device_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, |
| 4907 | "VUID-vkCmdCopyImageToBuffer-srcImage-00186", "vkCmdCopyImageToBuffer()", |
| 4908 | "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); |
Tobin Ehlis | 3c37fb3 | 2017-05-24 09:31:13 -0600 | [diff] [blame] | 4909 | skip |= ValidateBufferUsageFlags(device_data, dst_buffer_state, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4910 | "VUID-vkCmdCopyImageToBuffer-dstBuffer-00191", "vkCmdCopyImageToBuffer()", |
| 4911 | "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); |
Mark Lobodzinski | 96d5c6e | 2019-03-07 11:28:21 -0700 | [diff] [blame] | 4912 | if (GetApiVersion() >= VK_API_VERSION_1_1 || GetDeviceExtensions()->vk_khr_maintenance1) { |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 4913 | skip |= ValidateImageFormatFeatureFlags(device_data, src_image_state, VK_FORMAT_FEATURE_TRANSFER_SRC_BIT, |
Shannon McPherson | 40c0cba | 2018-08-07 13:39:13 -0600 | [diff] [blame] | 4914 | "vkCmdCopyImageToBuffer()", "VUID-vkCmdCopyImageToBuffer-srcImage-01998", |
| 4915 | "VUID-vkCmdCopyImageToBuffer-srcImage-01998"); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 4916 | } |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 4917 | skip |= InsideRenderPass(device_data, cb_node, "vkCmdCopyImageToBuffer()", "VUID-vkCmdCopyImageToBuffer-renderpass"); |
Tobin Ehlis | c826645 | 2017-04-07 12:20:30 -0600 | [diff] [blame] | 4918 | bool hit_error = false; |
Jeff Bolz | fdd0d85 | 2019-02-03 21:55:12 -0600 | [diff] [blame] | 4919 | const char *src_invalid_layout_vuid = |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 4920 | (src_image_state->shared_presentable && GetDeviceExtensions()->vk_khr_shared_presentable_image) |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 4921 | ? "VUID-vkCmdCopyImageToBuffer-srcImageLayout-01397" |
| 4922 | : "VUID-vkCmdCopyImageToBuffer-srcImageLayout-00190"; |
Mark Lobodzinski | 033c90b | 2017-02-15 13:58:23 -0700 | [diff] [blame] | 4923 | for (uint32_t i = 0; i < regionCount; ++i) { |
Cort Stratton | d619a30 | 2018-05-17 19:46:32 -0700 | [diff] [blame] | 4924 | skip |= ValidateImageSubresourceLayers(device_data, cb_node, &pRegions[i].imageSubresource, "vkCmdCopyImageToBuffer()", |
| 4925 | "imageSubresource", i); |
Tobin Ehlis | 3c37fb3 | 2017-05-24 09:31:13 -0600 | [diff] [blame] | 4926 | skip |= VerifyImageLayout(device_data, cb_node, src_image_state, pRegions[i].imageSubresource, srcImageLayout, |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 4927 | VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, "vkCmdCopyImageToBuffer()", src_invalid_layout_vuid, |
| 4928 | "VUID-vkCmdCopyImageToBuffer-srcImageLayout-00189", &hit_error); |
Mark Lobodzinski | 033c90b | 2017-02-15 13:58:23 -0700 | [diff] [blame] | 4929 | skip |= ValidateCopyBufferImageTransferGranularityRequirements(device_data, cb_node, src_image_state, &pRegions[i], i, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4930 | "vkCmdCopyImageToBuffer()", |
| 4931 | "VUID-vkCmdCopyImageToBuffer-imageOffset-01794"); |
Cort Stratton | ff1542a | 2018-05-27 10:49:28 -0700 | [diff] [blame] | 4932 | skip |= ValidateImageMipLevel(device_data, cb_node, src_image_state, pRegions[i].imageSubresource.mipLevel, i, |
| 4933 | "vkCmdCopyImageToBuffer()", "imageSubresource", |
| 4934 | "VUID-vkCmdCopyImageToBuffer-imageSubresource-01703"); |
| 4935 | skip |= ValidateImageArrayLayerRange(device_data, cb_node, src_image_state, pRegions[i].imageSubresource.baseArrayLayer, |
| 4936 | pRegions[i].imageSubresource.layerCount, i, "vkCmdCopyImageToBuffer()", |
| 4937 | "imageSubresource", "VUID-vkCmdCopyImageToBuffer-imageSubresource-01704"); |
Mark Lobodzinski | 033c90b | 2017-02-15 13:58:23 -0700 | [diff] [blame] | 4938 | } |
| 4939 | return skip; |
| 4940 | } |
| 4941 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4942 | void CoreChecks::PreCallRecordCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, |
| 4943 | VkBuffer dstBuffer, uint32_t regionCount, const VkBufferImageCopy *pRegions) { |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 4944 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 4945 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 4946 | auto src_image_state = GetImageState(srcImage); |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 4947 | auto dst_buffer_state = GetBufferState(dstBuffer); |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 4948 | |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 4949 | // Make sure that all image slices are updated to correct layout |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 4950 | for (uint32_t i = 0; i < regionCount; ++i) { |
| 4951 | SetImageLayout(device_data, cb_node, src_image_state, pRegions[i].imageSubresource, srcImageLayout); |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 4952 | } |
Mark Lobodzinski | 033c90b | 2017-02-15 13:58:23 -0700 | [diff] [blame] | 4953 | // Update bindings between buffer/image and cmd buffer |
| 4954 | AddCommandBufferBindingImage(device_data, cb_node, src_image_state); |
Mark Lobodzinski | 1fe9b00 | 2017-02-15 14:11:12 -0700 | [diff] [blame] | 4955 | AddCommandBufferBindingBuffer(device_data, cb_node, dst_buffer_state); |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4956 | } |
| 4957 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4958 | bool CoreChecks::PreCallValidateCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, |
| 4959 | VkImageLayout dstImageLayout, uint32_t regionCount, |
| 4960 | const VkBufferImageCopy *pRegions) { |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 4961 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 4962 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 4963 | auto src_buffer_state = GetBufferState(srcBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 4964 | auto dst_image_state = GetImageState(dstImage); |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 4965 | |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4966 | bool skip = ValidateBufferImageCopyData(report_data, regionCount, pRegions, dst_image_state, "vkCmdCopyBufferToImage"); |
| 4967 | |
| 4968 | // Validate command buffer state |
John Zulauf | 5c2750c | 2018-01-30 15:04:56 -0700 | [diff] [blame] | 4969 | skip |= ValidateCmd(device_data, cb_node, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4970 | |
| 4971 | // Command pool must support graphics, compute, or transfer operations |
Mark Lobodzinski | 8b0a7b8 | 2019-03-06 16:17:45 -0700 | [diff] [blame] | 4972 | auto pPool = GetCommandPoolNode(cb_node->createInfo.commandPool); |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 4973 | VkQueueFlags queue_flags = GetPhysicalDeviceState()->queue_family_properties[pPool->queueFamilyIndex].queueFlags; |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4974 | if (0 == (queue_flags & (VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT))) { |
| 4975 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4976 | HandleToUint64(cb_node->createInfo.commandPool), "VUID-vkCmdCopyBufferToImage-commandBuffer-cmdpool", |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4977 | "Cannot call vkCmdCopyBufferToImage() on a command buffer allocated from a pool without graphics, compute, " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 4978 | "or transfer capabilities.."); |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4979 | } |
Dave Houlton | 9dae7ec | 2017-03-01 16:23:25 -0700 | [diff] [blame] | 4980 | skip |= ValidateImageBounds(report_data, dst_image_state, regionCount, pRegions, "vkCmdCopyBufferToImage()", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4981 | "VUID-vkCmdCopyBufferToImage-pRegions-00172"); |
Chris Forbes | e8ba09a | 2017-06-01 17:39:02 -0700 | [diff] [blame] | 4982 | skip |= ValidateBufferBounds(report_data, dst_image_state, src_buffer_state, regionCount, pRegions, "vkCmdCopyBufferToImage()", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4983 | "VUID-vkCmdCopyBufferToImage-pRegions-00171"); |
Mark Lobodzinski | d2b2f61 | 2017-02-15 13:45:18 -0700 | [diff] [blame] | 4984 | skip |= ValidateImageSampleCount(device_data, dst_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyBufferToImage(): dstImage", |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4985 | "VUID-vkCmdCopyBufferToImage-dstImage-00179"); |
| 4986 | skip |= ValidateMemoryIsBoundToBuffer(device_data, src_buffer_state, "vkCmdCopyBufferToImage()", |
| 4987 | "VUID-vkCmdCopyBufferToImage-srcBuffer-00176"); |
| 4988 | skip |= ValidateMemoryIsBoundToImage(device_data, dst_image_state, "vkCmdCopyBufferToImage()", |
| 4989 | "VUID-vkCmdCopyBufferToImage-dstImage-00178"); |
Tobin Ehlis | 3c37fb3 | 2017-05-24 09:31:13 -0600 | [diff] [blame] | 4990 | skip |= ValidateBufferUsageFlags(device_data, src_buffer_state, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 4991 | "VUID-vkCmdCopyBufferToImage-srcBuffer-00174", "vkCmdCopyBufferToImage()", |
| 4992 | "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); |
| 4993 | skip |= ValidateImageUsageFlags(device_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, |
| 4994 | "VUID-vkCmdCopyBufferToImage-dstImage-00177", "vkCmdCopyBufferToImage()", |
| 4995 | "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); |
Mark Lobodzinski | 96d5c6e | 2019-03-07 11:28:21 -0700 | [diff] [blame] | 4996 | if (GetApiVersion() >= VK_API_VERSION_1_1 || GetDeviceExtensions()->vk_khr_maintenance1) { |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 4997 | skip |= ValidateImageFormatFeatureFlags(device_data, dst_image_state, VK_FORMAT_FEATURE_TRANSFER_DST_BIT, |
Shannon McPherson | 40c0cba | 2018-08-07 13:39:13 -0600 | [diff] [blame] | 4998 | "vkCmdCopyBufferToImage()", "VUID-vkCmdCopyBufferToImage-dstImage-01997", |
| 4999 | "VUID-vkCmdCopyBufferToImage-dstImage-01997"); |
Cort Stratton | 186b1a2 | 2018-05-01 20:18:06 -0400 | [diff] [blame] | 5000 | } |
Shannon McPherson | c06c33d | 2018-06-28 17:21:12 -0600 | [diff] [blame] | 5001 | skip |= InsideRenderPass(device_data, cb_node, "vkCmdCopyBufferToImage()", "VUID-vkCmdCopyBufferToImage-renderpass"); |
Tobin Ehlis | c826645 | 2017-04-07 12:20:30 -0600 | [diff] [blame] | 5002 | bool hit_error = false; |
Jeff Bolz | fdd0d85 | 2019-02-03 21:55:12 -0600 | [diff] [blame] | 5003 | const char *dst_invalid_layout_vuid = |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 5004 | (dst_image_state->shared_presentable && GetDeviceExtensions()->vk_khr_shared_presentable_image) |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 5005 | ? "VUID-vkCmdCopyBufferToImage-dstImageLayout-01396" |
| 5006 | : "VUID-vkCmdCopyBufferToImage-dstImageLayout-00181"; |
Mark Lobodzinski | 033c90b | 2017-02-15 13:58:23 -0700 | [diff] [blame] | 5007 | for (uint32_t i = 0; i < regionCount; ++i) { |
Cort Stratton | d619a30 | 2018-05-17 19:46:32 -0700 | [diff] [blame] | 5008 | skip |= ValidateImageSubresourceLayers(device_data, cb_node, &pRegions[i].imageSubresource, "vkCmdCopyBufferToImage()", |
| 5009 | "imageSubresource", i); |
Tobin Ehlis | 3c37fb3 | 2017-05-24 09:31:13 -0600 | [diff] [blame] | 5010 | skip |= VerifyImageLayout(device_data, cb_node, dst_image_state, pRegions[i].imageSubresource, dstImageLayout, |
Cort Stratton | 7df3096 | 2018-05-17 19:45:57 -0700 | [diff] [blame] | 5011 | VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, "vkCmdCopyBufferToImage()", dst_invalid_layout_vuid, |
| 5012 | "VUID-vkCmdCopyBufferToImage-dstImageLayout-00180", &hit_error); |
Mark Lobodzinski | 033c90b | 2017-02-15 13:58:23 -0700 | [diff] [blame] | 5013 | skip |= ValidateCopyBufferImageTransferGranularityRequirements(device_data, cb_node, dst_image_state, &pRegions[i], i, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 5014 | "vkCmdCopyBufferToImage()", |
| 5015 | "VUID-vkCmdCopyBufferToImage-imageOffset-01793"); |
Cort Stratton | ff1542a | 2018-05-27 10:49:28 -0700 | [diff] [blame] | 5016 | skip |= ValidateImageMipLevel(device_data, cb_node, dst_image_state, pRegions[i].imageSubresource.mipLevel, i, |
| 5017 | "vkCmdCopyBufferToImage()", "imageSubresource", |
| 5018 | "VUID-vkCmdCopyBufferToImage-imageSubresource-01701"); |
| 5019 | skip |= ValidateImageArrayLayerRange(device_data, cb_node, dst_image_state, pRegions[i].imageSubresource.baseArrayLayer, |
| 5020 | pRegions[i].imageSubresource.layerCount, i, "vkCmdCopyBufferToImage()", |
| 5021 | "imageSubresource", "VUID-vkCmdCopyBufferToImage-imageSubresource-01702"); |
Mark Lobodzinski | 033c90b | 2017-02-15 13:58:23 -0700 | [diff] [blame] | 5022 | } |
| 5023 | return skip; |
| 5024 | } |
| 5025 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 5026 | void CoreChecks::PreCallRecordCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkImage dstImage, |
| 5027 | VkImageLayout dstImageLayout, uint32_t regionCount, |
| 5028 | const VkBufferImageCopy *pRegions) { |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 5029 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(commandBuffer), layer_data_map); |
Mark Lobodzinski | 1b3a971 | 2019-03-06 15:51:47 -0700 | [diff] [blame] | 5030 | auto cb_node = GetCBNode(commandBuffer); |
Mark Lobodzinski | 6ed7414 | 2019-03-06 11:35:39 -0700 | [diff] [blame] | 5031 | auto src_buffer_state = GetBufferState(srcBuffer); |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 5032 | auto dst_image_state = GetImageState(dstImage); |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 5033 | |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 5034 | // Make sure that all image slices are updated to correct layout |
Mark Lobodzinski | b7eafbe | 2019-01-10 13:40:39 -0700 | [diff] [blame] | 5035 | for (uint32_t i = 0; i < regionCount; ++i) { |
| 5036 | SetImageLayout(device_data, cb_node, dst_image_state, pRegions[i].imageSubresource, dstImageLayout); |
Tobin Ehlis | e35b66a | 2017-03-15 12:18:31 -0600 | [diff] [blame] | 5037 | } |
Mark Lobodzinski | 1fe9b00 | 2017-02-15 14:11:12 -0700 | [diff] [blame] | 5038 | AddCommandBufferBindingBuffer(device_data, cb_node, src_buffer_state); |
Mark Lobodzinski | 033c90b | 2017-02-15 13:58:23 -0700 | [diff] [blame] | 5039 | AddCommandBufferBindingImage(device_data, cb_node, dst_image_state); |
Mark Lobodzinski | ab9ea3e | 2017-02-15 12:59:00 -0700 | [diff] [blame] | 5040 | } |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5041 | |
Mark Lobodzinski | b56bbb9 | 2019-02-18 11:49:59 -0700 | [diff] [blame] | 5042 | bool CoreChecks::PreCallValidateGetImageSubresourceLayout(VkDevice device, VkImage image, const VkImageSubresource *pSubresource, |
| 5043 | VkSubresourceLayout *pLayout) { |
Mark Lobodzinski | 6b35c8a | 2019-01-10 10:57:27 -0700 | [diff] [blame] | 5044 | layer_data *device_data = GetLayerDataPtr(get_dispatch_key(device), layer_data_map); |
| 5045 | const auto report_data = device_data->report_data; |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5046 | bool skip = false; |
| 5047 | const VkImageAspectFlags sub_aspect = pSubresource->aspectMask; |
| 5048 | |
Dave Houlton | 1d960ff | 2018-01-19 12:17:05 -0700 | [diff] [blame] | 5049 | // The aspectMask member of pSubresource must only have a single bit set |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5050 | const int num_bits = sizeof(sub_aspect) * CHAR_BIT; |
| 5051 | std::bitset<num_bits> aspect_mask_bits(sub_aspect); |
| 5052 | if (aspect_mask_bits.count() != 1) { |
Petr Kraus | bc7f544 | 2017-05-14 23:43:38 +0200 | [diff] [blame] | 5053 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 5054 | "VUID-vkGetImageSubresourceLayout-aspectMask-00997", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 5055 | "vkGetImageSubresourceLayout(): VkImageSubresource.aspectMask must have exactly 1 bit set."); |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5056 | } |
| 5057 | |
Mark Lobodzinski | 8ddc23f | 2019-03-06 11:48:49 -0700 | [diff] [blame] | 5058 | IMAGE_STATE *image_entry = GetImageState(image); |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5059 | if (!image_entry) { |
| 5060 | return skip; |
| 5061 | } |
| 5062 | |
Dave Houlton | 1d960ff | 2018-01-19 12:17:05 -0700 | [diff] [blame] | 5063 | // image must have been created with tiling equal to VK_IMAGE_TILING_LINEAR |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5064 | if (image_entry->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 5065 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), |
| 5066 | "VUID-vkGetImageSubresourceLayout-image-00996", |
| 5067 | "vkGetImageSubresourceLayout(): Image must have tiling of VK_IMAGE_TILING_LINEAR."); |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5068 | } |
| 5069 | |
Dave Houlton | 1d960ff | 2018-01-19 12:17:05 -0700 | [diff] [blame] | 5070 | // mipLevel must be less than the mipLevels specified in VkImageCreateInfo when the image was created |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5071 | if (pSubresource->mipLevel >= image_entry->createInfo.mipLevels) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 5072 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), |
| 5073 | "VUID-vkGetImageSubresourceLayout-mipLevel-01716", |
| 5074 | "vkGetImageSubresourceLayout(): pSubresource.mipLevel (%d) must be less than %d.", pSubresource->mipLevel, |
| 5075 | image_entry->createInfo.mipLevels); |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5076 | } |
| 5077 | |
Dave Houlton | 1d960ff | 2018-01-19 12:17:05 -0700 | [diff] [blame] | 5078 | // arrayLayer must be less than the arrayLayers specified in VkImageCreateInfo when the image was created |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5079 | if (pSubresource->arrayLayer >= image_entry->createInfo.arrayLayers) { |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 5080 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), |
| 5081 | "VUID-vkGetImageSubresourceLayout-arrayLayer-01717", |
| 5082 | "vkGetImageSubresourceLayout(): pSubresource.arrayLayer (%d) must be less than %d.", |
| 5083 | pSubresource->arrayLayer, image_entry->createInfo.arrayLayers); |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5084 | } |
| 5085 | |
Dave Houlton | 1d960ff | 2018-01-19 12:17:05 -0700 | [diff] [blame] | 5086 | // subresource's aspect must be compatible with image's format. |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5087 | const VkFormat img_format = image_entry->createInfo.format; |
Dave Houlton | 1d960ff | 2018-01-19 12:17:05 -0700 | [diff] [blame] | 5088 | if (FormatIsMultiplane(img_format)) { |
| 5089 | VkImageAspectFlags allowed_flags = (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR); |
Jeff Bolz | 6d3beaa | 2019-02-09 21:00:05 -0600 | [diff] [blame] | 5090 | const char *vuid = "VUID-vkGetImageSubresourceLayout-format-01581"; // 2-plane version |
Dave Houlton | 1d960ff | 2018-01-19 12:17:05 -0700 | [diff] [blame] | 5091 | if (FormatPlaneCount(img_format) > 2u) { |
| 5092 | allowed_flags |= VK_IMAGE_ASPECT_PLANE_2_BIT_KHR; |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 5093 | vuid = "VUID-vkGetImageSubresourceLayout-format-01582"; // 3-plane version |
Dave Houlton | 1d960ff | 2018-01-19 12:17:05 -0700 | [diff] [blame] | 5094 | } |
| 5095 | if (sub_aspect != (sub_aspect & allowed_flags)) { |
| 5096 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Mark Lobodzinski | 8852949 | 2018-04-01 10:38:15 -0600 | [diff] [blame] | 5097 | HandleToUint64(image), vuid, |
Dave Houlton | 1d960ff | 2018-01-19 12:17:05 -0700 | [diff] [blame] | 5098 | "vkGetImageSubresourceLayout(): For multi-planar images, VkImageSubresource.aspectMask (0x%" PRIx32 |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 5099 | ") must be a single-plane specifier flag.", |
| 5100 | sub_aspect); |
Dave Houlton | 1d960ff | 2018-01-19 12:17:05 -0700 | [diff] [blame] | 5101 | } |
| 5102 | } else if (FormatIsColor(img_format)) { |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5103 | if (sub_aspect != VK_IMAGE_ASPECT_COLOR_BIT) { |
Dave Houlton | 852287e | 2018-01-19 15:11:51 -0700 | [diff] [blame] | 5104 | skip |= log_msg( |
Mark Lobodzinski | b1fd9d1 | 2018-03-30 14:26:00 -0600 | [diff] [blame] | 5105 | report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, HandleToUint64(image), |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 5106 | "VUID-VkImageSubresource-aspectMask-parameter", |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 5107 | "vkGetImageSubresourceLayout(): For color formats, VkImageSubresource.aspectMask must be VK_IMAGE_ASPECT_COLOR."); |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5108 | } |
Dave Houlton | 1d2022c | 2017-03-29 11:43:58 -0600 | [diff] [blame] | 5109 | } else if (FormatIsDepthOrStencil(img_format)) { |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5110 | if ((sub_aspect != VK_IMAGE_ASPECT_DEPTH_BIT) && (sub_aspect != VK_IMAGE_ASPECT_STENCIL_BIT)) { |
Mark Lobodzinski | 0827aec | 2017-03-21 16:41:45 -0600 | [diff] [blame] | 5111 | skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, |
Dave Houlton | d8ed021 | 2018-05-16 17:18:24 -0600 | [diff] [blame] | 5112 | HandleToUint64(image), "VUID-VkImageSubresource-aspectMask-parameter", |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5113 | "vkGetImageSubresourceLayout(): For depth/stencil formats, VkImageSubresource.aspectMask must be " |
Mark Lobodzinski | 487a0d1 | 2018-03-30 10:09:03 -0600 | [diff] [blame] | 5114 | "either VK_IMAGE_ASPECT_DEPTH_BIT or VK_IMAGE_ASPECT_STENCIL_BIT."); |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5115 | } |
| 5116 | } |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 5117 | |
Mark Lobodzinski | 60e7903 | 2019-03-07 10:22:31 -0700 | [diff] [blame] | 5118 | if (GetDeviceExtensions()->vk_android_external_memory_android_hardware_buffer) { |
Dave Houlton | 0d4ad6f | 2018-09-05 14:53:34 -0600 | [diff] [blame] | 5119 | skip |= ValidateGetImageSubresourceLayoutANDROID(device_data, image); |
| 5120 | } |
| 5121 | |
Mike Weiblen | 672b58b | 2017-02-21 14:32:53 -0700 | [diff] [blame] | 5122 | return skip; |
| 5123 | } |