blob: a709c0236252923e8139183647c59b51f0a80b4d [file] [log] [blame]
Dejan Mircevskib6fe02f2016-01-07 13:44:22 -05001// Copyright (c) 2015-2016 The Khronos Group Inc.
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +01002//
David Neto9fc86582016-09-01 15:33:59 -04003// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +01006//
David Neto9fc86582016-09-01 15:33:59 -04007// http://www.apache.org/licenses/LICENSE-2.0
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +01008//
David Neto9fc86582016-09-01 15:33:59 -04009// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +010014
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +010015#include "binary.h"
David Netofcc7d582015-10-27 15:31:10 -040016
David Neto7bff3eb2015-11-20 14:21:10 -050017#include <algorithm>
David Netofcc7d582015-10-27 15:31:10 -040018#include <cassert>
19#include <cstring>
Andrew Woloszyn7ffd8ff2016-01-11 16:22:34 -050020#include <iterator>
David Neto0ca6b592015-10-30 16:06:15 -040021#include <limits>
David Netofcc7d582015-10-27 15:31:10 -040022#include <unordered_map>
23
David Netofcc7d582015-10-27 15:31:10 -040024#include "assembly_grammar.h"
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +010025#include "diagnostic.h"
26#include "ext_inst.h"
27#include "opcode.h"
28#include "operand.h"
David Neto5a703352016-02-17 14:44:00 -050029#include "spirv-tools/libspirv.h"
Lei Zhangaa056cd2015-11-11 14:24:04 -050030#include "spirv_constant.h"
David Neto4c215712015-12-22 15:08:41 -050031#include "spirv_endian.h"
Andrew Woloszyn157e41b2015-10-16 15:11:00 -040032
Andrew Woloszyn55ecc2e2015-11-11 11:05:07 -050033spv_result_t spvBinaryHeaderGet(const spv_const_binary binary,
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +010034 const spv_endianness_t endian,
Lei Zhang1a0334e2015-11-02 09:41:20 -050035 spv_header_t* pHeader) {
David Neto0ca6b592015-10-30 16:06:15 -040036 if (!binary->code) return SPV_ERROR_INVALID_BINARY;
37 if (binary->wordCount < SPV_INDEX_INSTRUCTION)
38 return SPV_ERROR_INVALID_BINARY;
Lei Zhang40056702015-09-11 14:31:27 -040039 if (!pHeader) return SPV_ERROR_INVALID_POINTER;
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +010040
41 // TODO: Validation checking?
42 pHeader->magic = spvFixWord(binary->code[SPV_INDEX_MAGIC_NUMBER], endian);
43 pHeader->version = spvFixWord(binary->code[SPV_INDEX_VERSION_NUMBER], endian);
44 pHeader->generator =
45 spvFixWord(binary->code[SPV_INDEX_GENERATOR_NUMBER], endian);
46 pHeader->bound = spvFixWord(binary->code[SPV_INDEX_BOUND], endian);
47 pHeader->schema = spvFixWord(binary->code[SPV_INDEX_SCHEMA], endian);
48 pHeader->instructions = &binary->code[SPV_INDEX_INSTRUCTION];
49
50 return SPV_SUCCESS;
51}
52
David Neto0ca6b592015-10-30 16:06:15 -040053namespace {
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +010054
David Neto0ca6b592015-10-30 16:06:15 -040055// A SPIR-V binary parser. A parser instance communicates detailed parse
56// results via callbacks.
57class Parser {
58 public:
59 // The user_data value is provided to the callbacks as context.
Lei Zhang972788b2015-11-12 13:48:30 -050060 Parser(const spv_const_context context, void* user_data,
61 spv_parsed_header_fn_t parsed_header_fn,
David Neto0ca6b592015-10-30 16:06:15 -040062 spv_parsed_instruction_fn_t parsed_instruction_fn)
Lei Zhang972788b2015-11-12 13:48:30 -050063 : grammar_(context),
64 user_data_(user_data),
David Neto0ca6b592015-10-30 16:06:15 -040065 parsed_header_fn_(parsed_header_fn),
66 parsed_instruction_fn_(parsed_instruction_fn) {}
67
68 // Parses the specified binary SPIR-V module, issuing callbacks on a parsed
69 // header and for each parsed instruction. Returns SPV_SUCCESS on success.
70 // Otherwise returns an error code and issues a diagnostic.
71 spv_result_t parse(const uint32_t* words, size_t num_words,
72 spv_diagnostic* diagnostic);
73
74 private:
75 // All remaining methods work on the current module parse state.
76
77 // Like the parse method, but works on the current module parse state.
78 spv_result_t parseModule();
79
80 // Parses an instruction at the current position of the binary. Assumes
81 // the header has been parsed, the endian has been set, and the word index is
82 // still in range. Advances the parsing position past the instruction, and
83 // updates other parsing state for the current module.
84 // On success, returns SPV_SUCCESS and issues the parsed-instruction callback.
85 // On failure, returns an error code and issues a diagnostic.
86 spv_result_t parseInstruction();
87
David Neto7bff3eb2015-11-20 14:21:10 -050088 // Parses an instruction operand with the given type, for an instruction
89 // starting at inst_offset words into the SPIR-V binary.
90 // If the SPIR-V binary is the same endianness as the host, then the
91 // endian_converted_inst_words parameter is ignored. Otherwise, this method
92 // appends the words for this operand, converted to host native endianness,
93 // to the end of endian_converted_inst_words. This method also updates the
94 // expected_operands parameter, and the scalar members of the inst parameter.
95 // On success, returns SPV_SUCCESS, advances past the operand, and pushes a
96 // new entry on to the operands vector. Otherwise returns an error code and
97 // issues a diagnostic.
98 spv_result_t parseOperand(size_t inst_offset, spv_parsed_instruction_t* inst,
David Neto0ca6b592015-10-30 16:06:15 -040099 const spv_operand_type_t type,
David Neto7bff3eb2015-11-20 14:21:10 -0500100 std::vector<uint32_t>* endian_converted_inst_words,
David Neto0ca6b592015-10-30 16:06:15 -0400101 std::vector<spv_parsed_operand_t>* operands,
102 spv_operand_pattern_t* expected_operands);
103
104 // Records the numeric type for an operand according to the type information
105 // associated with the given non-zero type Id. This can fail if the type Id
106 // is not a type Id, or if the type Id does not reference a scalar numeric
107 // type. On success, return SPV_SUCCESS and populates the num_words,
108 // number_kind, and number_bit_width fields of parsed_operand.
109 spv_result_t setNumericTypeInfoForType(spv_parsed_operand_t* parsed_operand,
110 uint32_t type_id);
111
David Neto7bff3eb2015-11-20 14:21:10 -0500112 // Records the number type for an instruction at the given offset, if that
113 // instruction generates a type. For types that aren't scalar numbers,
114 // record something with number kind SPV_NUMBER_NONE.
115 void recordNumberType(size_t inst_offset,
116 const spv_parsed_instruction_t* inst);
David Neto0ca6b592015-10-30 16:06:15 -0400117
118 // Returns a diagnostic stream object initialized with current position in
119 // the input stream, and for the given error code. Any data written to the
120 // returned object will be propagated to the current parse's diagnostic
121 // object.
David Neto01656362015-11-20 10:44:41 -0500122 libspirv::DiagnosticStream diagnostic(spv_result_t error) {
David Neto7bff3eb2015-11-20 14:21:10 -0500123 return libspirv::DiagnosticStream({0, 0, _.word_index}, _.diagnostic,
124 error);
David Neto0ca6b592015-10-30 16:06:15 -0400125 }
126
127 // Returns a diagnostic stream object with the default parse error code.
David Neto01656362015-11-20 10:44:41 -0500128 libspirv::DiagnosticStream diagnostic() {
David Neto0ca6b592015-10-30 16:06:15 -0400129 // The default failure for parsing is invalid binary.
130 return diagnostic(SPV_ERROR_INVALID_BINARY);
131 }
132
David Netod9ad0502015-11-24 18:37:24 -0500133 // Issues a diagnostic describing an exhaustion of input condition when
134 // trying to decode an instruction operand, and returns
135 // SPV_ERROR_INVALID_BINARY.
136 spv_result_t exhaustedInputDiagnostic(size_t inst_offset, SpvOp opcode,
137 spv_operand_type_t type) {
138 return diagnostic() << "End of input reached while decoding Op"
139 << spvOpcodeString(opcode) << " starting at word "
140 << inst_offset
141 << ((_.word_index < _.num_words) ? ": truncated "
142 : ": missing ")
143 << spvOperandTypeStr(type) << " operand at word offset "
144 << _.word_index - inst_offset << ".";
145 }
146
David Neto0ca6b592015-10-30 16:06:15 -0400147 // Returns the endian-corrected word at the current position.
148 uint32_t peek() const { return peekAt(_.word_index); }
149
150 // Returns the endian-corrected word at the given position.
151 uint32_t peekAt(size_t index) const {
152 assert(index < _.num_words);
153 return spvFixWord(_.words[index], _.endian);
154 }
155
156 // Data members
157
158 const libspirv::AssemblyGrammar grammar_; // SPIR-V syntax utility.
159 void* const user_data_; // Context for the callbacks
160 const spv_parsed_header_fn_t parsed_header_fn_; // Parsed header callback
161 const spv_parsed_instruction_fn_t
162 parsed_instruction_fn_; // Parsed instruction callback
163
164 // Describes the format of a typed literal number.
165 struct NumberType {
166 spv_number_kind_t type;
167 uint32_t bit_width;
168 };
169
170 // The state used to parse a single SPIR-V binary module.
171 struct State {
172 State(const uint32_t* words_arg, size_t num_words_arg,
173 spv_diagnostic* diagnostic_arg)
174 : words(words_arg),
175 num_words(num_words_arg),
176 diagnostic(diagnostic_arg),
177 word_index(0),
Lei Zhang712bed02016-02-25 16:11:16 -0500178 endian(),
179 requires_endian_conversion(false) {}
David Neto0ca6b592015-10-30 16:06:15 -0400180 State() : State(0, 0, nullptr) {}
181 const uint32_t* words; // Words in the binary SPIR-V module.
182 size_t num_words; // Number of words in the module.
183 spv_diagnostic* diagnostic; // Where diagnostics go.
184 size_t word_index; // The current position in words.
185 spv_endianness_t endian; // The endianness of the binary.
David Neto7bff3eb2015-11-20 14:21:10 -0500186 // Is the SPIR-V binary in a different endiannes from the host native
187 // endianness?
188 bool requires_endian_conversion;
David Neto0ca6b592015-10-30 16:06:15 -0400189
190 // Maps a result ID to its type ID. By convention:
191 // - a result ID that is a type definition maps to itself.
192 // - a result ID without a type maps to 0. (E.g. for OpLabel)
193 std::unordered_map<uint32_t, uint32_t> id_to_type_id;
194 // Maps a type ID to its number type description.
195 std::unordered_map<uint32_t, NumberType> type_id_to_number_type_info;
196 // Maps an ExtInstImport id to the extended instruction type.
197 std::unordered_map<uint32_t, spv_ext_inst_type_t>
198 import_id_to_ext_inst_type;
199 } _;
200};
201
202spv_result_t Parser::parse(const uint32_t* words, size_t num_words,
203 spv_diagnostic* diagnostic_arg) {
204 _ = State(words, num_words, diagnostic_arg);
205
206 const spv_result_t result = parseModule();
207
208 // Clear the module state. The tables might be big.
209 _ = State();
210
211 return result;
212}
213
214spv_result_t Parser::parseModule() {
215 if (!_.words) return diagnostic() << "Missing module.";
216
217 if (_.num_words < SPV_INDEX_INSTRUCTION)
218 return diagnostic() << "Module has incomplete header: only " << _.num_words
219 << " words instead of " << SPV_INDEX_INSTRUCTION;
220
221 // Check the magic number and detect the module's endianness.
Andrew Woloszyn55ecc2e2015-11-11 11:05:07 -0500222 spv_const_binary_t binary{_.words, _.num_words};
David Neto0ca6b592015-10-30 16:06:15 -0400223 if (spvBinaryEndianness(&binary, &_.endian)) {
224 return diagnostic() << "Invalid SPIR-V magic number '" << std::hex
225 << _.words[0] << "'.";
226 }
David Neto7bff3eb2015-11-20 14:21:10 -0500227 _.requires_endian_conversion = !spvIsHostEndian(_.endian);
David Neto0ca6b592015-10-30 16:06:15 -0400228
229 // Process the header.
230 spv_header_t header;
231 if (spvBinaryHeaderGet(&binary, _.endian, &header)) {
232 // It turns out there is no way to trigger this error since the only
233 // failure cases are already handled above, with better messages.
234 return diagnostic(SPV_ERROR_INTERNAL)
235 << "Internal error: unhandled header parse failure";
236 }
237 if (parsed_header_fn_) {
238 if (auto error = parsed_header_fn_(user_data_, _.endian, header.magic,
239 header.version, header.generator,
240 header.bound, header.schema)) {
241 return error;
242 }
243 }
244
245 // Process the instructions.
246 _.word_index = SPV_INDEX_INSTRUCTION;
247 while (_.word_index < _.num_words)
248 if (auto error = parseInstruction()) return error;
249
250 // Running off the end should already have been reported earlier.
251 assert(_.word_index == _.num_words);
252
253 return SPV_SUCCESS;
254}
255
256spv_result_t Parser::parseInstruction() {
257 // The zero values for all members except for opcode are the
258 // correct initial values.
259 spv_parsed_instruction_t inst = {};
David Neto7bff3eb2015-11-20 14:21:10 -0500260
261 const uint32_t first_word = peek();
262
263 // TODO(dneto): If it's too expensive to construct the following "words"
264 // and "operands" vectors for each instruction, each instruction, then make
265 // them class data members instead, and clear them here.
266
267 // If the module's endianness is different from the host native endianness,
268 // then converted_words contains the the endian-translated words in the
269 // instruction.
270 std::vector<uint32_t> endian_converted_words = {first_word};
271 if (_.requires_endian_conversion) {
272 // Most instructions have fewer than 25 words.
273 endian_converted_words.reserve(25);
274 }
David Neto0ca6b592015-10-30 16:06:15 -0400275
276 // After a successful parse of the instruction, the inst.operands member
277 // will point to this vector's storage.
David Neto0ca6b592015-10-30 16:06:15 -0400278 std::vector<spv_parsed_operand_t> operands;
279 // Most instructions have fewer than 25 logical operands.
280 operands.reserve(25);
281
282 assert(_.word_index < _.num_words);
283 // Decompose and check the first word.
284 uint16_t inst_word_count = 0;
David Neto7bff3eb2015-11-20 14:21:10 -0500285 spvOpcodeSplit(first_word, &inst_word_count, &inst.opcode);
David Neto0ca6b592015-10-30 16:06:15 -0400286 if (inst_word_count < 1) {
287 return diagnostic() << "Invalid instruction word count: "
288 << inst_word_count;
289 }
290 spv_opcode_desc opcode_desc;
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400291 if (grammar_.lookupOpcode(static_cast<SpvOp>(inst.opcode), &opcode_desc))
292 return diagnostic() << "Invalid opcode: " << inst.opcode;
David Neto0ca6b592015-10-30 16:06:15 -0400293
David Neto7bff3eb2015-11-20 14:21:10 -0500294 // Advance past the opcode word. But remember the of the start
295 // of the instruction.
296 const size_t inst_offset = _.word_index;
David Neto0ca6b592015-10-30 16:06:15 -0400297 _.word_index++;
298
299 // Maintains the ordered list of expected operand types.
300 // For many instructions we only need the {numTypes, operandTypes}
301 // entries in opcode_desc. However, sometimes we need to modify
302 // the list as we parse the operands. This occurs when an operand
303 // has its own logical operands (such as the LocalSize operand for
304 // ExecutionMode), or for extended instructions that may have their
305 // own operands depending on the selected extended instruction.
306 spv_operand_pattern_t expected_operands(
307 opcode_desc->operandTypes,
308 opcode_desc->operandTypes + opcode_desc->numTypes);
309
David Neto7bff3eb2015-11-20 14:21:10 -0500310 while (_.word_index < inst_offset + inst_word_count) {
311 const uint16_t inst_word_index = uint16_t(_.word_index - inst_offset);
David Neto0ca6b592015-10-30 16:06:15 -0400312 if (expected_operands.empty()) {
313 return diagnostic() << "Invalid instruction Op" << opcode_desc->name
David Neto7bff3eb2015-11-20 14:21:10 -0500314 << " starting at word " << inst_offset
David Neto0ca6b592015-10-30 16:06:15 -0400315 << ": expected no more operands after "
316 << inst_word_index
317 << " words, but stated word count is "
318 << inst_word_count << ".";
319 }
320
321 spv_operand_type_t type = spvTakeFirstMatchableOperand(&expected_operands);
322
David Neto7bff3eb2015-11-20 14:21:10 -0500323 if (auto error =
324 parseOperand(inst_offset, &inst, type, &endian_converted_words,
David Netod9ad0502015-11-24 18:37:24 -0500325 &operands, &expected_operands)) {
David Neto0ca6b592015-10-30 16:06:15 -0400326 return error;
David Netod9ad0502015-11-24 18:37:24 -0500327 }
David Neto0ca6b592015-10-30 16:06:15 -0400328 }
329
330 if (!expected_operands.empty() &&
331 !spvOperandIsOptional(expected_operands.front())) {
332 return diagnostic() << "End of input reached while decoding Op"
333 << opcode_desc->name << " starting at word "
David Neto7bff3eb2015-11-20 14:21:10 -0500334 << inst_offset << ": expected more operands after "
David Neto0ca6b592015-10-30 16:06:15 -0400335 << inst_word_count << " words.";
336 }
337
David Neto7bff3eb2015-11-20 14:21:10 -0500338 if ((inst_offset + inst_word_count) != _.word_index) {
David Netod9ad0502015-11-24 18:37:24 -0500339 return diagnostic() << "Invalid word count: Op" << opcode_desc->name
340 << " starting at word " << inst_offset
341 << " says it has " << inst_word_count
David Neto7bff3eb2015-11-20 14:21:10 -0500342 << " words, but found " << _.word_index - inst_offset
David Neto0ca6b592015-10-30 16:06:15 -0400343 << " words instead.";
344 }
David Neto15afbf92015-11-23 14:17:35 -0500345
346 // Check the computed length of the endian-converted words vector against
347 // the declared number of words in the instruction. If endian conversion
348 // is required, then they should match. If no endian conversion was
349 // performed, then the vector only contains the initial opcode/word-count
350 // word.
351 assert(!_.requires_endian_conversion ||
352 (inst_word_count == endian_converted_words.size()));
353 assert(_.requires_endian_conversion || (endian_converted_words.size() == 1));
David Neto0ca6b592015-10-30 16:06:15 -0400354
David Neto7bff3eb2015-11-20 14:21:10 -0500355 recordNumberType(inst_offset, &inst);
David Neto0ca6b592015-10-30 16:06:15 -0400356
David Neto7bff3eb2015-11-20 14:21:10 -0500357 if (_.requires_endian_conversion) {
358 // We must wait until here to set this pointer, because the vector might
359 // have been be resized while we accumulated its elements.
360 inst.words = endian_converted_words.data();
361 } else {
362 // If no conversion is required, then just point to the underlying binary.
363 // This saves time and space.
364 inst.words = _.words + inst_offset;
365 }
366 inst.num_words = inst_word_count;
367
368 // We must wait until here to set this pointer, because the vector might
369 // have been be resized while we accumulated its elements.
David Neto0ca6b592015-10-30 16:06:15 -0400370 inst.operands = operands.data();
Andrew Woloszyn3a4bc7e2015-11-19 09:22:53 -0500371 inst.num_operands = uint16_t(operands.size());
David Neto0ca6b592015-10-30 16:06:15 -0400372
373 // Issue the callback. The callee should know that all the storage in inst
374 // is transient, and will disappear immediately afterward.
375 if (parsed_instruction_fn_) {
376 if (auto error = parsed_instruction_fn_(user_data_, &inst)) return error;
377 }
378
379 return SPV_SUCCESS;
380}
381
David Neto7bff3eb2015-11-20 14:21:10 -0500382spv_result_t Parser::parseOperand(size_t inst_offset,
383 spv_parsed_instruction_t* inst,
David Neto0ca6b592015-10-30 16:06:15 -0400384 const spv_operand_type_t type,
David Neto7bff3eb2015-11-20 14:21:10 -0500385 std::vector<uint32_t>* words,
David Neto0ca6b592015-10-30 16:06:15 -0400386 std::vector<spv_parsed_operand_t>* operands,
387 spv_operand_pattern_t* expected_operands) {
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400388 const SpvOp opcode = static_cast<SpvOp>(inst->opcode);
David Neto0ca6b592015-10-30 16:06:15 -0400389 // We'll fill in this result as we go along.
390 spv_parsed_operand_t parsed_operand;
David Neto7bff3eb2015-11-20 14:21:10 -0500391 parsed_operand.offset = uint16_t(_.word_index - inst_offset);
David Neto0ca6b592015-10-30 16:06:15 -0400392 // Most operands occupy one word. This might be be adjusted later.
393 parsed_operand.num_words = 1;
394 // The type argument is the one used by the grammar to parse the instruction.
395 // But it can exposes internal parser details such as whether an operand is
396 // optional or actually represents a variable-length sequence of operands.
397 // The resulting type should be adjusted to avoid those internal details.
398 // In most cases, the resulting operand type is the same as the grammar type.
399 parsed_operand.type = type;
400
401 // Assume non-numeric values. This will be updated for literal numbers.
402 parsed_operand.number_kind = SPV_NUMBER_NONE;
403 parsed_operand.number_bit_width = 0;
404
David Netod9ad0502015-11-24 18:37:24 -0500405 if (_.word_index >= _.num_words)
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400406 return exhaustedInputDiagnostic(inst_offset, opcode, type);
David Netod9ad0502015-11-24 18:37:24 -0500407
David Neto0ca6b592015-10-30 16:06:15 -0400408 const uint32_t word = peek();
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100409
David Neto7bff3eb2015-11-20 14:21:10 -0500410 // Do the words in this operand have to be converted to native endianness?
411 // True for all but literal strings.
412 bool convert_operand_endianness = true;
413
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100414 switch (type) {
Andrew Woloszyn537e7762015-09-29 11:28:34 -0400415 case SPV_OPERAND_TYPE_TYPE_ID:
David Neto677e0c72016-01-05 14:56:02 -0500416 if (!word)
417 return diagnostic(SPV_ERROR_INVALID_ID) << "Error: Type Id is 0";
David Neto0ca6b592015-10-30 16:06:15 -0400418 inst->type_id = word;
419 break;
420
421 case SPV_OPERAND_TYPE_RESULT_ID:
David Neto677e0c72016-01-05 14:56:02 -0500422 if (!word)
423 return diagnostic(SPV_ERROR_INVALID_ID) << "Error: Result Id is 0";
David Neto0ca6b592015-10-30 16:06:15 -0400424 inst->result_id = word;
425 // Save the result ID to type ID mapping.
426 // In the grammar, type ID always appears before result ID.
427 if (_.id_to_type_id.find(inst->result_id) != _.id_to_type_id.end())
Umar Arshadf76e0f52015-11-18 15:43:43 -0500428 return diagnostic(SPV_ERROR_INVALID_ID) << "Id " << inst->result_id
David Neto677e0c72016-01-05 14:56:02 -0500429 << " is defined more than once";
David Neto0ca6b592015-10-30 16:06:15 -0400430 // Record it.
431 // A regular value maps to its type. Some instructions (e.g. OpLabel)
432 // have no type Id, and will map to 0. The result Id for a
433 // type-generating instruction (e.g. OpTypeInt) maps to itself.
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400434 _.id_to_type_id[inst->result_id] =
435 spvOpcodeGeneratesType(opcode) ? inst->result_id : inst->type_id;
David Neto0ca6b592015-10-30 16:06:15 -0400436 break;
437
438 case SPV_OPERAND_TYPE_ID:
David Neto78c3b432015-08-27 13:03:52 -0400439 case SPV_OPERAND_TYPE_OPTIONAL_ID:
Umar Arshadf76e0f52015-11-18 15:43:43 -0500440 if (!word) return diagnostic(SPV_ERROR_INVALID_ID) << "Id is 0";
David Neto0ca6b592015-10-30 16:06:15 -0400441 parsed_operand.type = SPV_OPERAND_TYPE_ID;
442
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400443 if (opcode == SpvOpExtInst && parsed_operand.offset == 3) {
David Neto0ca6b592015-10-30 16:06:15 -0400444 // The current word is the extended instruction set Id.
445 // Set the extended instruction set type for the current instruction.
446 auto ext_inst_type_iter = _.import_id_to_ext_inst_type.find(word);
447 if (ext_inst_type_iter == _.import_id_to_ext_inst_type.end()) {
Umar Arshadf76e0f52015-11-18 15:43:43 -0500448 return diagnostic(SPV_ERROR_INVALID_ID)
David Neto0ca6b592015-10-30 16:06:15 -0400449 << "OpExtInst set Id " << word
450 << " does not reference an OpExtInstImport result Id";
451 }
452 inst->ext_inst_type = ext_inst_type_iter->second;
453 }
454 break;
455
David Neto64a9be92015-11-18 15:48:32 -0500456 case SPV_OPERAND_TYPE_SCOPE_ID:
457 case SPV_OPERAND_TYPE_MEMORY_SEMANTICS_ID:
David Netod9ad0502015-11-24 18:37:24 -0500458 // Check for trivially invalid values. The operand descriptions already
459 // have the word "ID" in them.
460 if (!word) return diagnostic() << spvOperandTypeStr(type) << " is 0";
David Neto0ca6b592015-10-30 16:06:15 -0400461 break;
462
David Neto445ce442015-10-15 15:22:06 -0400463 case SPV_OPERAND_TYPE_EXTENSION_INSTRUCTION_NUMBER: {
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400464 assert(SpvOpExtInst == opcode);
David Neto0ca6b592015-10-30 16:06:15 -0400465 assert(inst->ext_inst_type != SPV_EXT_INST_TYPE_NONE);
466 spv_ext_inst_desc ext_inst;
467 if (grammar_.lookupExtInst(inst->ext_inst_type, word, &ext_inst))
468 return diagnostic() << "Invalid extended instruction number: " << word;
469 spvPrependOperandTypes(ext_inst->operandTypes, expected_operands);
David Neto445ce442015-10-15 15:22:06 -0400470 } break;
David Neto0ca6b592015-10-30 16:06:15 -0400471
David Neto21196942015-11-11 02:45:45 -0500472 case SPV_OPERAND_TYPE_SPEC_CONSTANT_OP_NUMBER: {
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400473 assert(SpvOpSpecConstantOp == opcode);
David Neto21196942015-11-11 02:45:45 -0500474 if (grammar_.lookupSpecConstantOpcode(SpvOp(word))) {
475 return diagnostic() << "Invalid " << spvOperandTypeStr(type) << ": "
476 << word;
477 }
478 spv_opcode_desc opcode_entry = nullptr;
479 if (grammar_.lookupOpcode(SpvOp(word), &opcode_entry)) {
480 return diagnostic(SPV_ERROR_INTERNAL)
481 << "OpSpecConstant opcode table out of sync";
482 }
483 // OpSpecConstant opcodes must have a type and result. We've already
484 // processed them, so skip them when preparing to parse the other
485 // operants for the opcode.
486 assert(opcode_entry->hasType);
487 assert(opcode_entry->hasResult);
488 assert(opcode_entry->numTypes >= 2);
489 spvPrependOperandTypes(opcode_entry->operandTypes + 2, expected_operands);
490 } break;
491
David Neto445ce442015-10-15 15:22:06 -0400492 case SPV_OPERAND_TYPE_LITERAL_INTEGER:
Lei Zhang6483bd72015-10-14 17:02:39 -0400493 case SPV_OPERAND_TYPE_OPTIONAL_LITERAL_INTEGER:
David Neto201caf72015-11-04 17:38:17 -0500494 // These are regular single-word literal integer operands.
495 // Post-parsing validation should check the range of the parsed value.
David Neto0ca6b592015-10-30 16:06:15 -0400496 parsed_operand.type = SPV_OPERAND_TYPE_LITERAL_INTEGER;
David Neto201caf72015-11-04 17:38:17 -0500497 // It turns out they are always unsigned integers!
498 parsed_operand.number_kind = SPV_NUMBER_UNSIGNED_INT;
499 parsed_operand.number_bit_width = 32;
500 break;
501
502 case SPV_OPERAND_TYPE_TYPED_LITERAL_NUMBER:
503 case SPV_OPERAND_TYPE_OPTIONAL_TYPED_LITERAL_INTEGER:
Lei Zhangaa3cd5a2015-11-10 14:29:35 -0500504 parsed_operand.type = SPV_OPERAND_TYPE_TYPED_LITERAL_NUMBER;
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400505 if (opcode == SpvOpSwitch) {
David Neto0ca6b592015-10-30 16:06:15 -0400506 // The literal operands have the same type as the value
507 // referenced by the selector Id.
David Neto7bff3eb2015-11-20 14:21:10 -0500508 const uint32_t selector_id = peekAt(inst_offset + 1);
David Neto3664bd52015-12-23 13:21:43 -0500509 const auto type_id_iter = _.id_to_type_id.find(selector_id);
510 if (type_id_iter == _.id_to_type_id.end() ||
511 type_id_iter->second == 0) {
David Neto0ca6b592015-10-30 16:06:15 -0400512 return diagnostic() << "Invalid OpSwitch: selector id " << selector_id
513 << " has no type";
514 }
515 uint32_t type_id = type_id_iter->second;
516
517 if (selector_id == type_id) {
518 // Recall that by convention, a result ID that is a type definition
519 // maps to itself.
520 return diagnostic() << "Invalid OpSwitch: selector id " << selector_id
521 << " is a type, not a value";
522 }
523 if (auto error = setNumericTypeInfoForType(&parsed_operand, type_id))
524 return error;
525 if (parsed_operand.number_kind != SPV_NUMBER_UNSIGNED_INT &&
526 parsed_operand.number_kind != SPV_NUMBER_SIGNED_INT) {
527 return diagnostic() << "Invalid OpSwitch: selector id " << selector_id
528 << " is not a scalar integer";
529 }
Lei Zhangb41d1502015-09-14 15:22:23 -0400530 } else {
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400531 assert(opcode == SpvOpConstant || opcode == SpvOpSpecConstant);
David Neto201caf72015-11-04 17:38:17 -0500532 // The literal number type is determined by the type Id for the
533 // constant.
534 assert(inst->type_id);
535 if (auto error =
536 setNumericTypeInfoForType(&parsed_operand, inst->type_id))
537 return error;
Lei Zhangb41d1502015-09-14 15:22:23 -0400538 }
David Neto0ca6b592015-10-30 16:06:15 -0400539 break;
540
David Neto78c3b432015-08-27 13:03:52 -0400541 case SPV_OPERAND_TYPE_LITERAL_STRING:
542 case SPV_OPERAND_TYPE_OPTIONAL_LITERAL_STRING: {
David Neto7bff3eb2015-11-20 14:21:10 -0500543 convert_operand_endianness = false;
David Neto0ca6b592015-10-30 16:06:15 -0400544 const char* string =
545 reinterpret_cast<const char*>(_.words + _.word_index);
David Netod9ad0502015-11-24 18:37:24 -0500546 // Compute the length of the string, but make sure we don't run off the
547 // end of the input.
548 const size_t remaining_input_bytes =
549 sizeof(uint32_t) * (_.num_words - _.word_index);
550 const size_t string_num_content_bytes =
551 strnlen(string, remaining_input_bytes);
552 // If there was no terminating null byte, then that's an end-of-input
553 // error.
554 if (string_num_content_bytes == remaining_input_bytes)
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400555 return exhaustedInputDiagnostic(inst_offset, opcode, type);
David Netod9ad0502015-11-24 18:37:24 -0500556 // Account for null in the word length, so add 1 for null, then add 3 to
557 // make sure we round up. The following is equivalent to:
558 // (string_num_content_bytes + 1 + 3) / 4
559 const size_t string_num_words = string_num_content_bytes / 4 + 1;
David Neto0ca6b592015-10-30 16:06:15 -0400560 // Make sure we can record the word count without overflow.
David Netod9ad0502015-11-24 18:37:24 -0500561 //
562 // This error can't currently be triggered because of validity
563 // checks elsewhere.
David Neto0ca6b592015-10-30 16:06:15 -0400564 if (string_num_words > std::numeric_limits<uint16_t>::max()) {
565 return diagnostic() << "Literal string is longer than "
566 << std::numeric_limits<uint16_t>::max()
567 << " words: " << string_num_words << " words long";
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100568 }
Andrew Woloszyn3a4bc7e2015-11-19 09:22:53 -0500569 parsed_operand.num_words = uint16_t(string_num_words);
David Neto0ca6b592015-10-30 16:06:15 -0400570 parsed_operand.type = SPV_OPERAND_TYPE_LITERAL_STRING;
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100571
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400572 if (SpvOpExtInstImport == opcode) {
David Neto0ca6b592015-10-30 16:06:15 -0400573 // Record the extended instruction type for the ID for this import.
574 // There is only one string literal argument to OpExtInstImport,
575 // so it's sufficient to guard this just on the opcode.
576 const spv_ext_inst_type_t ext_inst_type =
577 spvExtInstImportTypeGet(string);
578 if (SPV_EXT_INST_TYPE_NONE == ext_inst_type) {
579 return diagnostic() << "Invalid extended instruction import '"
580 << string << "'";
Andrew Woloszyne59e6b72015-10-14 14:18:43 -0400581 }
David Neto0ca6b592015-10-30 16:06:15 -0400582 // We must have parsed a valid result ID. It's a condition
583 // of the grammar, and we only accept non-zero result Ids.
584 assert(inst->result_id);
585 _.import_id_to_ext_inst_type[inst->result_id] = ext_inst_type;
Andrew Woloszyne59e6b72015-10-14 14:18:43 -0400586 }
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100587 } break;
David Neto0ca6b592015-10-30 16:06:15 -0400588
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100589 case SPV_OPERAND_TYPE_CAPABILITY:
590 case SPV_OPERAND_TYPE_SOURCE_LANGUAGE:
591 case SPV_OPERAND_TYPE_EXECUTION_MODEL:
592 case SPV_OPERAND_TYPE_ADDRESSING_MODEL:
593 case SPV_OPERAND_TYPE_MEMORY_MODEL:
594 case SPV_OPERAND_TYPE_EXECUTION_MODE:
595 case SPV_OPERAND_TYPE_STORAGE_CLASS:
596 case SPV_OPERAND_TYPE_DIMENSIONALITY:
597 case SPV_OPERAND_TYPE_SAMPLER_ADDRESSING_MODE:
598 case SPV_OPERAND_TYPE_SAMPLER_FILTER_MODE:
David Netod9ad0502015-11-24 18:37:24 -0500599 case SPV_OPERAND_TYPE_SAMPLER_IMAGE_FORMAT:
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100600 case SPV_OPERAND_TYPE_FP_ROUNDING_MODE:
601 case SPV_OPERAND_TYPE_LINKAGE_TYPE:
602 case SPV_OPERAND_TYPE_ACCESS_QUALIFIER:
David Neto2889a0c2016-02-15 13:50:00 -0500603 case SPV_OPERAND_TYPE_OPTIONAL_ACCESS_QUALIFIER:
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100604 case SPV_OPERAND_TYPE_FUNCTION_PARAMETER_ATTRIBUTE:
605 case SPV_OPERAND_TYPE_DECORATION:
606 case SPV_OPERAND_TYPE_BUILT_IN:
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100607 case SPV_OPERAND_TYPE_GROUP_OPERATION:
608 case SPV_OPERAND_TYPE_KERNEL_ENQ_FLAGS:
David Neto47994822015-08-27 13:11:01 -0400609 case SPV_OPERAND_TYPE_KERNEL_PROFILING_INFO: {
David Neto0ca6b592015-10-30 16:06:15 -0400610 // A single word that is a plain enum value.
David Neto2889a0c2016-02-15 13:50:00 -0500611
612 // Map an optional operand type to its corresponding concrete type.
613 if (type == SPV_OPERAND_TYPE_OPTIONAL_ACCESS_QUALIFIER)
614 parsed_operand.type = SPV_OPERAND_TYPE_ACCESS_QUALIFIER;
615
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100616 spv_operand_desc entry;
David Neto0ca6b592015-10-30 16:06:15 -0400617 if (grammar_.lookupOperand(type, word, &entry)) {
David Neto201caf72015-11-04 17:38:17 -0500618 return diagnostic() << "Invalid "
619 << spvOperandTypeStr(parsed_operand.type)
David Neto0ca6b592015-10-30 16:06:15 -0400620 << " operand: " << word;
Lei Zhang40056702015-09-11 14:31:27 -0400621 }
David Neto78c3b432015-08-27 13:03:52 -0400622 // Prepare to accept operands to this operand, if needed.
David Neto0ca6b592015-10-30 16:06:15 -0400623 spvPrependOperandTypes(entry->operandTypes, expected_operands);
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100624 } break;
David Neto0ca6b592015-10-30 16:06:15 -0400625
David Neto619db262015-09-25 12:43:37 -0400626 case SPV_OPERAND_TYPE_FP_FAST_MATH_MODE:
627 case SPV_OPERAND_TYPE_FUNCTION_CONTROL:
628 case SPV_OPERAND_TYPE_LOOP_CONTROL:
David Neto2889a0c2016-02-15 13:50:00 -0500629 case SPV_OPERAND_TYPE_IMAGE:
David Neto619db262015-09-25 12:43:37 -0400630 case SPV_OPERAND_TYPE_OPTIONAL_IMAGE:
631 case SPV_OPERAND_TYPE_OPTIONAL_MEMORY_ACCESS:
632 case SPV_OPERAND_TYPE_SELECTION_CONTROL: {
633 // This operand is a mask.
David Neto201caf72015-11-04 17:38:17 -0500634
635 // Map an optional operand type to its corresponding concrete type.
636 if (type == SPV_OPERAND_TYPE_OPTIONAL_IMAGE)
637 parsed_operand.type = SPV_OPERAND_TYPE_IMAGE;
638 else if (type == SPV_OPERAND_TYPE_OPTIONAL_MEMORY_ACCESS)
639 parsed_operand.type = SPV_OPERAND_TYPE_MEMORY_ACCESS;
640
David Neto0ca6b592015-10-30 16:06:15 -0400641 // Check validity of set mask bits. Also prepare for operands for those
642 // masks if they have any. To get operand order correct, scan from
643 // MSB to LSB since we can only prepend operands to a pattern.
644 // The only case in the grammar where you have more than one mask bit
645 // having an operand is for image operands. See SPIR-V 3.14 Image
646 // Operands.
647 uint32_t remaining_word = word;
648 for (uint32_t mask = (1u << 31); remaining_word; mask >>= 1) {
David Neto619db262015-09-25 12:43:37 -0400649 if (remaining_word & mask) {
David Neto619db262015-09-25 12:43:37 -0400650 spv_operand_desc entry;
David Neto0ca6b592015-10-30 16:06:15 -0400651 if (grammar_.lookupOperand(type, mask, &entry)) {
David Neto201caf72015-11-04 17:38:17 -0500652 return diagnostic()
653 << "Invalid " << spvOperandTypeStr(parsed_operand.type)
654 << " operand: " << word << " has invalid mask component "
655 << mask;
David Neto619db262015-09-25 12:43:37 -0400656 }
David Neto0ca6b592015-10-30 16:06:15 -0400657 remaining_word ^= mask;
658 spvPrependOperandTypes(entry->operandTypes, expected_operands);
David Neto619db262015-09-25 12:43:37 -0400659 }
660 }
David Neto0ca6b592015-10-30 16:06:15 -0400661 if (word == 0) {
662 // An all-zeroes mask *might* also be valid.
David Neto619db262015-09-25 12:43:37 -0400663 spv_operand_desc entry;
David Neto0ca6b592015-10-30 16:06:15 -0400664 if (SPV_SUCCESS == grammar_.lookupOperand(type, 0, &entry)) {
David Neto619db262015-09-25 12:43:37 -0400665 // Prepare for its operands, if any.
David Neto0ca6b592015-10-30 16:06:15 -0400666 spvPrependOperandTypes(entry->operandTypes, expected_operands);
David Neto619db262015-09-25 12:43:37 -0400667 }
668 }
David Neto619db262015-09-25 12:43:37 -0400669 } break;
David Neto0ca6b592015-10-30 16:06:15 -0400670 default:
671 return diagnostic() << "Internal error: Unhandled operand type: " << type;
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100672 }
673
David Neto0ca6b592015-10-30 16:06:15 -0400674 assert(int(SPV_OPERAND_TYPE_FIRST_CONCRETE_TYPE) <= int(parsed_operand.type));
675 assert(int(SPV_OPERAND_TYPE_LAST_CONCRETE_TYPE) >= int(parsed_operand.type));
676
677 operands->push_back(parsed_operand);
678
David Neto7bff3eb2015-11-20 14:21:10 -0500679 const size_t index_after_operand = _.word_index + parsed_operand.num_words;
David Netod9ad0502015-11-24 18:37:24 -0500680
681 // Avoid buffer overrun for the cases where the operand has more than one
682 // word, and where it isn't a string. (Those other cases have already been
683 // handled earlier.) For example, this error can occur for a multi-word
684 // argument to OpConstant, or a multi-word case literal operand for OpSwitch.
685 if (_.num_words < index_after_operand)
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400686 return exhaustedInputDiagnostic(inst_offset, opcode, type);
David Netod9ad0502015-11-24 18:37:24 -0500687
David Neto7bff3eb2015-11-20 14:21:10 -0500688 if (_.requires_endian_conversion) {
689 // Copy instruction words. Translate to native endianness as needed.
690 if (convert_operand_endianness) {
691 const spv_endianness_t endianness = _.endian;
692 std::transform(_.words + _.word_index, _.words + index_after_operand,
Andrew Woloszyn3b69d052016-01-11 13:54:30 -0500693 std::back_inserter(*words),
694 [endianness](const uint32_t raw_word) {
David Neto677e0c72016-01-05 14:56:02 -0500695 return spvFixWord(raw_word, endianness);
David Neto7bff3eb2015-11-20 14:21:10 -0500696 });
697 } else {
698 words->insert(words->end(), _.words + _.word_index,
699 _.words + index_after_operand);
700 }
701 }
702
703 // Advance past the operand.
704 _.word_index = index_after_operand;
David Neto0ca6b592015-10-30 16:06:15 -0400705
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100706 return SPV_SUCCESS;
707}
708
David Neto0ca6b592015-10-30 16:06:15 -0400709spv_result_t Parser::setNumericTypeInfoForType(
710 spv_parsed_operand_t* parsed_operand, uint32_t type_id) {
David Neto201caf72015-11-04 17:38:17 -0500711 assert(type_id != 0);
David Neto0ca6b592015-10-30 16:06:15 -0400712 auto type_info_iter = _.type_id_to_number_type_info.find(type_id);
713 if (type_info_iter == _.type_id_to_number_type_info.end()) {
714 return diagnostic() << "Type Id " << type_id << " is not a type";
715 }
716 const NumberType& info = type_info_iter->second;
717 if (info.type == SPV_NUMBER_NONE) {
718 // This is a valid type, but for something other than a scalar number.
719 return diagnostic() << "Type Id " << type_id
720 << " is not a scalar numeric type";
Andrew Woloszyn157e41b2015-10-16 15:11:00 -0400721 }
722
David Neto0ca6b592015-10-30 16:06:15 -0400723 parsed_operand->number_kind = info.type;
724 parsed_operand->number_bit_width = info.bit_width;
David Neto066bd522016-01-05 14:57:58 -0500725 // Round up the word count.
726 parsed_operand->num_words = static_cast<uint16_t>((info.bit_width + 31) / 32);
Andrew Woloszyn157e41b2015-10-16 15:11:00 -0400727 return SPV_SUCCESS;
728}
729
David Neto7bff3eb2015-11-20 14:21:10 -0500730void Parser::recordNumberType(size_t inst_offset,
731 const spv_parsed_instruction_t* inst) {
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400732 const SpvOp opcode = static_cast<SpvOp>(inst->opcode);
733 if (spvOpcodeGeneratesType(opcode)) {
David Neto0ca6b592015-10-30 16:06:15 -0400734 NumberType info = {SPV_NUMBER_NONE, 0};
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400735 if (SpvOpTypeInt == opcode) {
David Neto7bff3eb2015-11-20 14:21:10 -0500736 const bool is_signed = peekAt(inst_offset + 3) != 0;
David Neto0ca6b592015-10-30 16:06:15 -0400737 info.type = is_signed ? SPV_NUMBER_SIGNED_INT : SPV_NUMBER_UNSIGNED_INT;
David Neto7bff3eb2015-11-20 14:21:10 -0500738 info.bit_width = peekAt(inst_offset + 2);
Lei Zhang6fa3f8a2016-03-31 17:26:31 -0400739 } else if (SpvOpTypeFloat == opcode) {
David Neto0ca6b592015-10-30 16:06:15 -0400740 info.type = SPV_NUMBER_FLOATING;
David Neto7bff3eb2015-11-20 14:21:10 -0500741 info.bit_width = peekAt(inst_offset + 2);
Lei Zhang40056702015-09-11 14:31:27 -0400742 }
David Neto0ca6b592015-10-30 16:06:15 -0400743 // The *result* Id of a type generating instruction is the type Id.
744 _.type_id_to_number_type_info[inst->result_id] = info;
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100745 }
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100746}
747
David Neto0ca6b592015-10-30 16:06:15 -0400748} // anonymous namespace
Andrew Woloszyncfeac482015-09-09 13:04:32 -0400749
Lei Zhang972788b2015-11-12 13:48:30 -0500750spv_result_t spvBinaryParse(const spv_const_context context, void* user_data,
751 const uint32_t* code, const size_t num_words,
David Neto0ca6b592015-10-30 16:06:15 -0400752 spv_parsed_header_fn_t parsed_header,
753 spv_parsed_instruction_fn_t parsed_instruction,
754 spv_diagnostic* diagnostic) {
Lei Zhang972788b2015-11-12 13:48:30 -0500755 Parser parser(context, user_data, parsed_header, parsed_instruction);
David Neto0ca6b592015-10-30 16:06:15 -0400756 return parser.parse(code, num_words, diagnostic);
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100757}
758
David Neto0ca6b592015-10-30 16:06:15 -0400759// TODO(dneto): This probably belongs in text.cpp since that's the only place
760// that a spv_binary_t value is created.
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100761void spvBinaryDestroy(spv_binary binary) {
Lei Zhang40056702015-09-11 14:31:27 -0400762 if (!binary) return;
Eric Engestromeb6ae972016-02-18 23:41:16 +0000763 delete[] binary->code;
Kenneth Benzie (Benie)83e5a292015-05-22 18:26:19 +0100764 delete binary;
765}