blob: 5a9093b546aba69ed4f4005b6c9cce7a26ad2909 [file] [log] [blame]
David Netodd992212017-06-23 17:47:55 -04001// Copyright 2017 The Clspv Authors. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
David Neto156783e2017-07-05 15:39:41 -040015// Cluster POD kernel arguments.
16//
17// Collect plain-old-data kernel arguments and place them into a single
18// struct argument, at the end. Other arguments are pointers, and retain
19// their relative order.
20//
21// We will create a kernel function as the new entry point, and change
22// the original kernel function into a regular SPIR function. Key
23// kernel metadata is moved from the old function to the wrapper.
24// We also attach a "kernel_arg_map" metadata node to the function to
25// encode the mapping from old kernel argument to new kernel argument.
26
David Netodd992212017-06-23 17:47:55 -040027#include <cassert>
David Netoc6f3ab22018-04-06 18:02:31 -040028#include <cstring>
David Netodd992212017-06-23 17:47:55 -040029
David Netoc6f3ab22018-04-06 18:02:31 -040030#include "llvm/IR/Constants.h"
31#include "llvm/IR/DerivedTypes.h"
32#include "llvm/IR/Function.h"
33#include "llvm/IR/Instructions.h"
34#include "llvm/IR/IRBuilder.h"
35#include "llvm/IR/Metadata.h"
36#include "llvm/IR/Module.h"
37#include "llvm/Pass.h"
38#include "llvm/Support/CommandLine.h"
39#include "llvm/Support/raw_ostream.h"
40#include "llvm/Transforms/Utils/Cloning.h"
David Netodd992212017-06-23 17:47:55 -040041
David Neto4feb7a42017-10-06 17:29:42 -040042#include "ArgKind.h"
David Netodd992212017-06-23 17:47:55 -040043
44using namespace llvm;
45
46#define DEBUG_TYPE "clusterpodkernelargs"
47
48namespace {
49struct ClusterPodKernelArgumentsPass : public ModulePass {
50 static char ID;
51 ClusterPodKernelArgumentsPass() : ModulePass(ID) {}
52
53 bool runOnModule(Module &M) override;
54};
David Neto48f56a42017-10-06 16:44:25 -040055
David Netodd992212017-06-23 17:47:55 -040056} // namespace
57
58char ClusterPodKernelArgumentsPass::ID = 0;
59static RegisterPass<ClusterPodKernelArgumentsPass>
60 X("ClusterPodKernelArgumentsPass",
61 "Cluster POD Kernel Arguments Pass");
62
63namespace clspv {
64llvm::ModulePass *createClusterPodKernelArgumentsPass() {
65 return new ClusterPodKernelArgumentsPass();
66}
67} // namespace clspv
68
69bool ClusterPodKernelArgumentsPass::runOnModule(Module &M) {
70 bool Changed = false;
71 LLVMContext &Context = M.getContext();
72
73 SmallVector<Function *, 8> WorkList;
74
75 for (Function &F : M) {
76 if (F.isDeclaration() || F.getCallingConv() != CallingConv::SPIR_KERNEL) {
77 continue;
78 }
79 for (Argument &Arg : F.args()) {
80 if (!isa<PointerType>(Arg.getType())) {
81 WorkList.push_back(&F);
82 break;
83 }
84 }
85 }
86
David Netod5b3f982017-09-28 14:49:49 -040087 SmallVector<CallInst*, 8> CallList;
88
David Netoc6f3ab22018-04-06 18:02:31 -040089 // Note: The transformation done in this pass preserves the pointer-to-local
90 // arg to spec-id mapping.
91 clspv::ArgIdMapType arg_spec_id_map = clspv::AllocateArgSpecIds(M);
92
David Netodd992212017-06-23 17:47:55 -040093 for (Function* F : WorkList) {
94 Changed = true;
95
David Neto156783e2017-07-05 15:39:41 -040096 // An ArgMapping describes how a kernel argument is remapped.
97 struct ArgMapping {
98 std::string name;
99 // 0-based argument index in the old kernel function.
100 unsigned old_index;
101 // 0-based argument index in the new kernel function.
David Netoc6f3ab22018-04-06 18:02:31 -0400102 int new_index;
David Neto156783e2017-07-05 15:39:41 -0400103 // Offset of the argument value within the new kernel argument.
104 // This is always zero for non-POD arguments. For a POD argument,
105 // this is the byte offset within the POD arguments struct.
106 unsigned offset;
Kévin PETITa353c832018-03-20 23:21:21 +0000107 // Size of the argument
108 unsigned arg_size;
David Neto48f56a42017-10-06 16:44:25 -0400109 // Argument type. Same range of values as the result of
David Neto862b7d82018-06-14 18:48:37 -0400110 // clspv::GetArgKindNameForType.
David Neto4feb7a42017-10-06 17:29:42 -0400111 const char* arg_kind;
David Netoc6f3ab22018-04-06 18:02:31 -0400112 // If non-negative, this argument is a pointer-to-local, and the value
113 // here is the specialization constant id for the array size.
114 int spec_id;
David Neto156783e2017-07-05 15:39:41 -0400115 };
116
David Netodd992212017-06-23 17:47:55 -0400117 // In OpenCL, kernel arguments are either pointers or POD. A composite with
Kévin Petit921c1ab2019-03-19 21:25:44 +0000118 // an element or member that is a pointer is not allowed. So we'll use POD
David Netodd992212017-06-23 17:47:55 -0400119 // as a shorthand for non-pointer.
120
121 SmallVector<Type *, 8> PtrArgTys;
122 SmallVector<Type *, 8> PodArgTys;
David Neto156783e2017-07-05 15:39:41 -0400123 SmallVector<ArgMapping, 8> RemapInfo;
124 unsigned arg_index = 0;
David Netoc6f3ab22018-04-06 18:02:31 -0400125 int new_index = 0;
David Netodd992212017-06-23 17:47:55 -0400126 for (Argument &Arg : F->args()) {
127 Type *ArgTy = Arg.getType();
128 if (isa<PointerType>(ArgTy)) {
129 PtrArgTys.push_back(ArgTy);
David Neto862b7d82018-06-14 18:48:37 -0400130 const auto kind = clspv::GetArgKindForType(ArgTy);
David Netoc6f3ab22018-04-06 18:02:31 -0400131 int spec_id = -1;
David Neto862b7d82018-06-14 18:48:37 -0400132 if (kind == clspv::ArgKind::Local) {
David Netoc6f3ab22018-04-06 18:02:31 -0400133 spec_id = arg_spec_id_map[&Arg];
134 assert(spec_id > 0);
135 }
David Neto862b7d82018-06-14 18:48:37 -0400136 RemapInfo.push_back({std::string(Arg.getName()), arg_index, new_index++,
Kévin PETITa353c832018-03-20 23:21:21 +0000137 0u, 0u, clspv::GetArgKindName(kind), spec_id});
David Netodd992212017-06-23 17:47:55 -0400138 } else {
139 PodArgTys.push_back(ArgTy);
140 }
David Neto156783e2017-07-05 15:39:41 -0400141 arg_index++;
David Netodd992212017-06-23 17:47:55 -0400142 }
143
David Netodd992212017-06-23 17:47:55 -0400144 // Put the pointer arguments first, and then POD arguments struct last.
David Neto2ded02e2017-10-23 15:30:59 -0400145 // Use StructType::get so we reuse types where possible.
146 auto PodArgsStructTy = StructType::get(Context, PodArgTys);
David Netodd992212017-06-23 17:47:55 -0400147 SmallVector<Type *, 8> NewFuncParamTys(PtrArgTys);
148 NewFuncParamTys.push_back(PodArgsStructTy);
149
David Neto156783e2017-07-05 15:39:41 -0400150 // We've recorded the remapping for pointer arguments. Now record the
151 // remapping for POD arguments.
152 {
Kévin PETITa353c832018-03-20 23:21:21 +0000153 const DataLayout DL(&M);
154 const auto StructLayout = DL.getStructLayout(PodArgsStructTy);
David Neto156783e2017-07-05 15:39:41 -0400155 arg_index = 0;
156 int pod_index = 0;
David Neto156783e2017-07-05 15:39:41 -0400157 for (Argument &Arg : F->args()) {
158 Type *ArgTy = Arg.getType();
159 if (!isa<PointerType>(ArgTy)) {
Kévin PETITa353c832018-03-20 23:21:21 +0000160 unsigned arg_size = DL.getTypeStoreSize(ArgTy);
David Neto156783e2017-07-05 15:39:41 -0400161 RemapInfo.push_back(
David Netoc6f3ab22018-04-06 18:02:31 -0400162 {std::string(Arg.getName()), arg_index, new_index,
David Neto48f56a42017-10-06 16:44:25 -0400163 unsigned(StructLayout->getElementOffset(pod_index++)),
Kévin PETITa353c832018-03-20 23:21:21 +0000164 arg_size, clspv::GetArgKindNameForType(ArgTy), -1});
David Neto156783e2017-07-05 15:39:41 -0400165 }
166 arg_index++;
167 }
168 }
169
David Netodd992212017-06-23 17:47:55 -0400170 FunctionType *NewFuncTy =
171 FunctionType::get(F->getReturnType(), NewFuncParamTys, false);
172
173 // Create the new function and set key properties.
174 auto NewFunc = Function::Create(NewFuncTy, F->getLinkage());
175 // The new function adopts the real name so that linkage to the outside
176 // world remains the same.
177 NewFunc->setName(F->getName());
178 F->setName(NewFunc->getName().str() + ".inner");
179
180 NewFunc->setCallingConv(F->getCallingConv());
181 F->setCallingConv(CallingConv::SPIR_FUNC);
182
Kévin Petit921c1ab2019-03-19 21:25:44 +0000183 // Transfer attributes that don't apply to the POD arguments
184 // to the new functions.
185 auto Attributes = F->getAttributes();
186 SmallVector<std::pair<unsigned, AttributeSet>, 8> AttrBuildInfo;
187
188 // Return attributes have to come first
189 if (Attributes.hasAttributes(AttributeList::ReturnIndex)) {
190 auto idx = AttributeList::ReturnIndex;
191 auto attrs = Attributes.getRetAttributes();
192 AttrBuildInfo.push_back(std::make_pair(idx, attrs));
193 }
194
195 // Then attributes for pointer parameters
196 for (auto &rinfo : RemapInfo) {
197 if (Attributes.hasParamAttrs(rinfo.old_index)) {
198 auto idx = rinfo.new_index + AttributeList::FirstArgIndex;
199 auto attrs = Attributes.getParamAttributes(rinfo.old_index);
200 AttrBuildInfo.push_back(std::make_pair(idx, attrs));
201 }
202 }
203
204 // And finally function attributes. We deal with function attributes
205 // differently since the version of LLVM used by clspv has a bug in get().
206 // TODO(kpet): Add function attributes to AttrBuildInfo when updating
207 // LLVM past r330136.
208 auto newAttributes = AttributeList::get(M.getContext(), AttrBuildInfo);
209 if (Attributes.hasAttributes(AttributeList::FunctionIndex)) {
210 auto attrs = AttrBuilder(Attributes.getFnAttributes());
211 auto idx = AttributeList::FunctionIndex;
212 newAttributes = newAttributes.addAttributes(M.getContext(), idx, attrs);
213 }
214 NewFunc->setAttributes(newAttributes);
215
David Netodd992212017-06-23 17:47:55 -0400216 // Move OpenCL kernel named attributes.
217 // TODO(dneto): Attributes starting with kernel_arg_* should be rewritten
218 // to reflect change in the argument shape.
219 std::vector<const char *> Metadatas{
220 "reqd_work_group_size", "kernel_arg_addr_space",
221 "kernel_arg_access_qual", "kernel_arg_type",
222 "kernel_arg_base_type", "kernel_arg_type_qual"};
223 for (auto name : Metadatas) {
224 NewFunc->setMetadata(name, F->getMetadata(name));
225 F->setMetadata(name, nullptr);
226 }
227
David Neto156783e2017-07-05 15:39:41 -0400228 IRBuilder<> Builder(BasicBlock::Create(Context, "entry", NewFunc));
229
230 // Set kernel argument mapping metadata.
231 {
232 // Attach a metadata node named "kernel_arg_map" to the new kernel
233 // function. It is a tuple of nodes, each of which is a tuple for
234 // each argument, with members:
235 // - Argument name
236 // - Ordinal index in the original kernel function
237 // - Ordinal index in the new kernel function
238 // - Byte offset within the argument. This is always 0 for pointer
239 // arguments. For POD arguments this is the offest within the POD
240 // argument struct.
David Neto48f56a42017-10-06 16:44:25 -0400241 // - Argument type
David Neto156783e2017-07-05 15:39:41 -0400242 LLVMContext& Context = M.getContext();
243 SmallVector<Metadata*, 8> mappings;
244 for (auto &arg_mapping : RemapInfo) {
245 auto *name_md = MDString::get(Context, arg_mapping.name);
246 auto *old_index_md =
247 ConstantAsMetadata::get(Builder.getInt32(arg_mapping.old_index));
David Netoc6f3ab22018-04-06 18:02:31 -0400248 auto *new_index_md = ConstantAsMetadata::get(
249 Builder.getInt32(arg_mapping.new_index));
250 auto *offset_md =
David Neto156783e2017-07-05 15:39:41 -0400251 ConstantAsMetadata::get(Builder.getInt32(arg_mapping.offset));
Kévin PETITa353c832018-03-20 23:21:21 +0000252 auto *arg_size_md =
253 ConstantAsMetadata::get(Builder.getInt32(arg_mapping.arg_size));
David Neto4feb7a42017-10-06 17:29:42 -0400254 auto *argtype_md = MDString::get(Context, arg_mapping.arg_kind);
David Netoc6f3ab22018-04-06 18:02:31 -0400255 auto *spec_id_md = ConstantAsMetadata::get(
256 Builder.getInt32(arg_mapping.spec_id));
257 auto *arg_md =
258 MDNode::get(Context, {name_md, old_index_md, new_index_md,
Kévin PETITa353c832018-03-20 23:21:21 +0000259 offset_md, arg_size_md, argtype_md, spec_id_md});
David Neto156783e2017-07-05 15:39:41 -0400260 mappings.push_back(arg_md);
261 }
262
263 NewFunc->setMetadata("kernel_arg_map", MDNode::get(Context, mappings));
264 }
265
David Netodd992212017-06-23 17:47:55 -0400266 // Insert the function after the original, to preserve ordering
267 // in the module as much as possible.
268 auto &FunctionList = M.getFunctionList();
269 for (auto Iter = FunctionList.begin(), IterEnd = FunctionList.end();
270 Iter != IterEnd; ++Iter) {
271 if (&*Iter == F) {
272 FunctionList.insertAfter(Iter, NewFunc);
273 break;
274 }
275 }
276
277 // The body of the wrapper is essentially a call to the original function,
278 // but we have to unwrap the non-pointer arguments from the struct.
David Netodd992212017-06-23 17:47:55 -0400279
280 // Map the wrapper's arguments to the callee's arguments.
281 SmallVector<Argument *, 8> CallerArgs;
282 for (Argument &Arg : NewFunc->args()) {
283 CallerArgs.push_back(&Arg);
284 }
285 Argument *PodArg = CallerArgs.back();
286 PodArg->setName("podargs");
287
288 SmallVector<Value *, 8> CalleeArgs;
289 unsigned podIndex = 0;
290 unsigned ptrIndex = 0;
291 for (const Argument &Arg : F->args()) {
292 if (isa<PointerType>(Arg.getType())) {
293 CalleeArgs.push_back(CallerArgs[ptrIndex++]);
294 } else {
295 CalleeArgs.push_back(Builder.CreateExtractValue(PodArg, {podIndex++}));
296 }
297 CalleeArgs.back()->setName(Arg.getName());
298 }
299 assert(ptrIndex + podIndex == F->arg_size());
Kévin Petit98d9c332019-03-13 15:03:40 +0000300 assert(ptrIndex == PtrArgTys.size());
301 assert(podIndex != 0);
302 assert(podIndex == PodArgTys.size());
David Netodd992212017-06-23 17:47:55 -0400303
304 auto Call = Builder.CreateCall(F, CalleeArgs);
305 Call->setCallingConv(F->getCallingConv());
David Netod5b3f982017-09-28 14:49:49 -0400306 CallList.push_back(Call);
David Netodd992212017-06-23 17:47:55 -0400307
308 Builder.CreateRetVoid();
309 }
310
David Neto482550a2018-03-24 05:21:07 -0700311 // Inline the inner function. It's cleaner to do this.
312 for (CallInst *C : CallList) {
313 InlineFunctionInfo info;
314 Changed |= InlineFunction(C, info);
David Netod5b3f982017-09-28 14:49:49 -0400315 }
316
David Netodd992212017-06-23 17:47:55 -0400317 return Changed;
318}