| commit | fdc410002de3f6465e4fa5cf43625efa36b87398 | [log] [tgz] |
|---|---|---|
| author | Chung-Sheng Wu <chungsheng@google.com> | Tue Feb 07 11:12:40 2023 +0000 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Feb 08 19:44:46 2023 -0800 |
| tree | 09e1e19e120620042a33a973b01280f4990c1ea6 | |
| parent | 7ca980bfe831b4f4db1e576e6f2cfd362e64485c [diff] |
system_api: Add new healthd mojo service Add CrosHealthdAshEventReporter constant. BUG=b:267968613 TEST=Build with other CLs. Change-Id: I4c9323863245eb7814ec066c3f6cff0c884b60c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4225617 Commit-Queue: Chung-sheng Wu <chungsheng@google.com> Auto-Submit: Chung-sheng Wu <chungsheng@google.com> Tested-by: Chung-sheng Wu <chungsheng@google.com> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 31ae1a05e25013fc335ad852ba9f9b6a4002bde8
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.