| commit | 7ca980bfe831b4f4db1e576e6f2cfd362e64485c | [log] [tgz] |
|---|---|---|
| author | Eric Wang <qianwan@google.com> | Sun Feb 05 20:28:06 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Feb 08 16:12:23 2023 -0800 |
| tree | 919421b50a2cd5e0eb27fc36e8c7573fed6809fe | |
| parent | a573c6c36b78f5c11564f5f98fb8c8085abb74db [diff] |
system_api: Add the churn_active_status in preserved file Preserve the churn active status history into preserved file. BUG=chromium:1386189 TEST=USE=test emerge-dedede chromeos-base/system_api Change-Id: I2b07816bc1026990a4a80af22f13a7dba4cf68ba Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4223256 Tested-by: Eric Wang <qianwan@google.com> Reviewed-by: Hirthanan Subenderan <hirthanan@google.com> Commit-Queue: Eric Wang <qianwan@google.com> NOKEYCHECK=True GitOrigin-RevId: f4535287f2bbd22b13d34e0563b4e035be14b342
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. "Required is Forever" and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.