Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "cros-disks/process.h" |
| 6 | |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 7 | #include <algorithm> |
| 8 | #include <array> |
| 9 | #include <string> |
François Degros | 899487c | 2019-07-12 11:57:52 +1000 | [diff] [blame] | 10 | #include <utility> |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 11 | |
| 12 | #include <poll.h> |
| 13 | |
| 14 | #include <base/files/file_util.h> |
François Degros | 8c14d38 | 2019-09-12 14:50:43 +1000 | [diff] [blame] | 15 | #include <base/posix/eintr_wrapper.h> |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 16 | #include <base/process/kill.h> |
| 17 | #include <base/strings/string_util.h> |
| 18 | #include <base/strings/string_split.h> |
| 19 | #include <base/time/time.h> |
| 20 | |
François Degros | 899487c | 2019-07-12 11:57:52 +1000 | [diff] [blame] | 21 | #include "cros-disks/quote.h" |
| 22 | |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 23 | namespace cros_disks { |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 24 | namespace { |
| 25 | |
| 26 | enum class ReadResult { |
| 27 | kSuccess, |
| 28 | kWouldBlock, |
| 29 | kFailure, |
| 30 | }; |
| 31 | |
| 32 | ReadResult ReadFD(int fd, std::string* data) { |
| 33 | const size_t kMaxSize = 4096; |
| 34 | char buffer[kMaxSize]; |
| 35 | ssize_t bytes_read = HANDLE_EINTR(read(fd, buffer, kMaxSize)); |
| 36 | |
| 37 | if (bytes_read < 0) { |
| 38 | if (errno == EAGAIN || errno == EWOULDBLOCK) { |
| 39 | data->clear(); |
| 40 | return ReadResult::kWouldBlock; |
| 41 | } |
| 42 | PLOG(ERROR) << "Read failed."; |
| 43 | return ReadResult::kFailure; |
| 44 | } |
| 45 | |
| 46 | data->assign(buffer, bytes_read); |
| 47 | return ReadResult::kSuccess; |
| 48 | } |
| 49 | |
| 50 | // Interleaves streams. |
| 51 | class StreamMerger { |
| 52 | public: |
François Degros | d5d2688 | 2019-09-13 11:23:51 +1000 | [diff] [blame] | 53 | explicit StreamMerger(std::vector<std::string>* output) : output_(output) {} |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 54 | |
| 55 | ~StreamMerger() { |
François Degros | d5d2688 | 2019-09-13 11:23:51 +1000 | [diff] [blame] | 56 | for (size_t i = 0; i < kStreamCount; ++i) { |
| 57 | const std::string& remaining = remaining_[i]; |
| 58 | if (!remaining.empty()) |
| 59 | output_->push_back(base::JoinString({kTags[i], ": ", remaining}, "")); |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 60 | } |
| 61 | } |
| 62 | |
François Degros | d5d2688 | 2019-09-13 11:23:51 +1000 | [diff] [blame] | 63 | void Append(const size_t stream, const base::StringPiece data) { |
| 64 | DCHECK_LT(stream, kStreamCount); |
| 65 | |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 66 | if (data.empty()) { |
| 67 | return; |
| 68 | } |
| 69 | |
François Degros | d5d2688 | 2019-09-13 11:23:51 +1000 | [diff] [blame] | 70 | std::string& remaining = remaining_[stream]; |
| 71 | const base::StringPiece tag = kTags[stream]; |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 72 | |
François Degros | d5d2688 | 2019-09-13 11:23:51 +1000 | [diff] [blame] | 73 | std::vector<base::StringPiece> lines = base::SplitStringPiece( |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 74 | data, "\n", base::WhitespaceHandling::KEEP_WHITESPACE, |
| 75 | base::SplitResult::SPLIT_WANT_ALL); |
François Degros | d5d2688 | 2019-09-13 11:23:51 +1000 | [diff] [blame] | 76 | const base::StringPiece last_line = lines.back(); |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 77 | lines.pop_back(); |
| 78 | |
François Degros | d5d2688 | 2019-09-13 11:23:51 +1000 | [diff] [blame] | 79 | for (const base::StringPiece line : lines) { |
| 80 | output_->push_back(base::JoinString({tag, ": ", remaining, line}, "")); |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 81 | remaining.clear(); |
| 82 | } |
François Degros | d5d2688 | 2019-09-13 11:23:51 +1000 | [diff] [blame] | 83 | |
| 84 | remaining = last_line.as_string(); |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 85 | } |
| 86 | |
| 87 | private: |
François Degros | d5d2688 | 2019-09-13 11:23:51 +1000 | [diff] [blame] | 88 | // Number of streams to interleave. |
| 89 | static const size_t kStreamCount = 2; |
| 90 | static const base::StringPiece kTags[kStreamCount]; |
| 91 | std::vector<std::string>* const output_; |
| 92 | std::string remaining_[kStreamCount]; |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 93 | |
| 94 | DISALLOW_COPY_AND_ASSIGN(StreamMerger); |
| 95 | }; |
| 96 | |
François Degros | d5d2688 | 2019-09-13 11:23:51 +1000 | [diff] [blame] | 97 | const size_t StreamMerger::kStreamCount; |
| 98 | const base::StringPiece StreamMerger::kTags[kStreamCount] = {"OUT", "ERR"}; |
| 99 | |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 100 | } // namespace |
| 101 | |
Ben Chan | acac395 | 2012-04-24 22:50:01 -0700 | [diff] [blame] | 102 | // static |
| 103 | const pid_t Process::kInvalidProcessId = -1; |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 104 | const int Process::kInvalidFD = base::ScopedFD::traits_type::InvalidValue(); |
Ben Chan | acac395 | 2012-04-24 22:50:01 -0700 | [diff] [blame] | 105 | |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 106 | Process::Process() = default; |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 107 | |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 108 | Process::~Process() = default; |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 109 | |
Ben Chan | 213c6d9 | 2019-04-10 16:21:52 -0700 | [diff] [blame] | 110 | void Process::AddArgument(const std::string& argument) { |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 111 | arguments_.push_back(argument); |
| 112 | } |
| 113 | |
François Degros | 5593b8c | 2019-07-25 12:27:42 +1000 | [diff] [blame] | 114 | char* const* Process::GetArguments() { |
Ben Chan | 5e3ca67 | 2014-08-25 15:53:58 -0700 | [diff] [blame] | 115 | if (arguments_array_.empty()) |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 116 | BuildArgumentsArray(); |
| 117 | |
Ben Chan | 5e3ca67 | 2014-08-25 15:53:58 -0700 | [diff] [blame] | 118 | return arguments_array_.data(); |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 119 | } |
| 120 | |
| 121 | bool Process::BuildArgumentsArray() { |
| 122 | // The following code creates a writable copy of argument strings. |
| 123 | size_t num_arguments = arguments_.size(); |
| 124 | if (num_arguments == 0) |
| 125 | return false; |
| 126 | |
| 127 | size_t arguments_buffer_size = 0; |
Ben Chan | 6057fe6 | 2016-12-02 10:08:59 -0800 | [diff] [blame] | 128 | for (const auto& argument : arguments_) { |
| 129 | arguments_buffer_size += argument.size() + 1; |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 130 | } |
| 131 | |
Ben Chan | 5e3ca67 | 2014-08-25 15:53:58 -0700 | [diff] [blame] | 132 | arguments_buffer_.resize(arguments_buffer_size); |
| 133 | arguments_array_.resize(num_arguments + 1); |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 134 | |
Ben Chan | 6057fe6 | 2016-12-02 10:08:59 -0800 | [diff] [blame] | 135 | char** array_pointer = arguments_array_.data(); |
Ben Chan | 5e3ca67 | 2014-08-25 15:53:58 -0700 | [diff] [blame] | 136 | char* buffer_pointer = arguments_buffer_.data(); |
Ben Chan | 6057fe6 | 2016-12-02 10:08:59 -0800 | [diff] [blame] | 137 | for (const auto& argument : arguments_) { |
| 138 | *array_pointer = buffer_pointer; |
| 139 | size_t argument_size = argument.size(); |
| 140 | argument.copy(buffer_pointer, argument_size); |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 141 | buffer_pointer[argument_size] = '\0'; |
| 142 | buffer_pointer += argument_size + 1; |
Ben Chan | 6057fe6 | 2016-12-02 10:08:59 -0800 | [diff] [blame] | 143 | ++array_pointer; |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 144 | } |
Ben Chan | 6057fe6 | 2016-12-02 10:08:59 -0800 | [diff] [blame] | 145 | *array_pointer = nullptr; |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 146 | return true; |
| 147 | } |
| 148 | |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 149 | bool Process::Start() { |
| 150 | CHECK_EQ(kInvalidProcessId, pid_); |
François Degros | 0156464 | 2019-09-13 14:10:17 +1000 | [diff] [blame] | 151 | CHECK(!finished()); |
François Degros | 5593b8c | 2019-07-25 12:27:42 +1000 | [diff] [blame] | 152 | CHECK(!arguments_.empty()) << "No arguments provided"; |
François Degros | 899487c | 2019-07-12 11:57:52 +1000 | [diff] [blame] | 153 | LOG(INFO) << "Starting process " << quote(arguments_); |
François Degros | 5593b8c | 2019-07-25 12:27:42 +1000 | [diff] [blame] | 154 | pid_ = StartImpl(&in_fd_, &out_fd_, &err_fd_); |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 155 | return pid_ != kInvalidProcessId; |
| 156 | } |
| 157 | |
| 158 | int Process::Wait() { |
François Degros | 0156464 | 2019-09-13 14:10:17 +1000 | [diff] [blame] | 159 | if (finished()) { |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 160 | return status_; |
Sergei Datsenko | 9246e9c | 2019-03-22 10:26:47 +1100 | [diff] [blame] | 161 | } |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 162 | |
| 163 | CHECK_NE(kInvalidProcessId, pid_); |
| 164 | status_ = WaitImpl(); |
François Degros | 0156464 | 2019-09-13 14:10:17 +1000 | [diff] [blame] | 165 | CHECK(finished()); |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 166 | pid_ = kInvalidProcessId; |
| 167 | return status_; |
| 168 | } |
| 169 | |
| 170 | bool Process::IsFinished() { |
François Degros | 0156464 | 2019-09-13 14:10:17 +1000 | [diff] [blame] | 171 | if (finished()) { |
| 172 | return true; |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 173 | } |
François Degros | 0156464 | 2019-09-13 14:10:17 +1000 | [diff] [blame] | 174 | |
| 175 | CHECK_NE(kInvalidProcessId, pid_); |
| 176 | status_ = WaitNonBlockingImpl(); |
| 177 | return finished(); |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 178 | } |
| 179 | |
| 180 | int Process::Run(std::vector<std::string>* output) { |
François Degros | edaefc5 | 2019-10-03 12:00:20 +1000 | [diff] [blame^] | 181 | DCHECK(output); |
| 182 | |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 183 | if (!Start()) { |
| 184 | return -1; |
| 185 | } |
| 186 | |
François Degros | edaefc5 | 2019-10-03 12:00:20 +1000 | [diff] [blame^] | 187 | Communicate(output); |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 188 | |
François Degros | 899487c | 2019-07-12 11:57:52 +1000 | [diff] [blame] | 189 | const int result = Wait(); |
| 190 | |
| 191 | LOG(INFO) << "Process finished with return code " << result; |
François Degros | edaefc5 | 2019-10-03 12:00:20 +1000 | [diff] [blame^] | 192 | if (LOG_IS_ON(INFO) && !output->empty()) { |
François Degros | 899487c | 2019-07-12 11:57:52 +1000 | [diff] [blame] | 193 | LOG(INFO) << "Process outputted " << output->size() << " lines:"; |
| 194 | for (const std::string& line : *output) { |
François Degros | 16ad1ae | 2019-07-17 16:02:39 +1000 | [diff] [blame] | 195 | LOG(INFO) << line; |
François Degros | 899487c | 2019-07-12 11:57:52 +1000 | [diff] [blame] | 196 | } |
| 197 | } |
| 198 | |
| 199 | return result; |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 200 | } |
| 201 | |
| 202 | void Process::Communicate(std::vector<std::string>* output) { |
| 203 | // We are not going to write there. |
| 204 | in_fd_.reset(); |
| 205 | // No FD leaves this function alive! |
| 206 | base::ScopedFD out_fd = std::move(out_fd_); |
| 207 | base::ScopedFD err_fd = std::move(err_fd_); |
| 208 | |
| 209 | if (out_fd.is_valid()) { |
| 210 | CHECK(base::SetNonBlocking(out_fd.get())); |
| 211 | } |
| 212 | if (err_fd.is_valid()) { |
| 213 | CHECK(base::SetNonBlocking(err_fd.get())); |
| 214 | } |
| 215 | |
| 216 | std::string data; |
François Degros | d5d2688 | 2019-09-13 11:23:51 +1000 | [diff] [blame] | 217 | StreamMerger merger(output); |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 218 | std::array<struct pollfd, 2> fds; |
| 219 | fds[0] = {out_fd.get(), POLLIN, 0}; |
| 220 | fds[1] = {err_fd.get(), POLLIN, 0}; |
| 221 | |
| 222 | while (!IsFinished()) { |
| 223 | size_t still_open = 0; |
| 224 | for (const auto& f : fds) { |
| 225 | still_open += f.fd != kInvalidFD; |
| 226 | } |
| 227 | if (still_open == 0) { |
| 228 | // No comms expected anymore. |
| 229 | break; |
| 230 | } |
| 231 | |
François Degros | 8c14d38 | 2019-09-12 14:50:43 +1000 | [diff] [blame] | 232 | const int ret = |
| 233 | HANDLE_EINTR(poll(fds.data(), fds.size(), 10 /* milliseconds */)); |
Sergei Datsenko | cd676b7 | 2019-05-10 11:42:05 +1000 | [diff] [blame] | 234 | if (ret == -1) { |
| 235 | PLOG(ERROR) << "poll() failed"; |
| 236 | break; |
| 237 | } |
| 238 | |
| 239 | if (ret) { |
| 240 | for (size_t i = 0; i < fds.size(); ++i) { |
| 241 | auto& f = fds[i]; |
| 242 | if (f.revents) { |
| 243 | if (ReadFD(f.fd, &data) == ReadResult::kFailure) { |
| 244 | // Failure. |
| 245 | f.fd = kInvalidFD; |
| 246 | } else { |
| 247 | merger.Append(i, data); |
| 248 | } |
| 249 | } |
| 250 | } |
| 251 | } |
| 252 | } |
| 253 | |
| 254 | Wait(); |
| 255 | |
| 256 | // Final read after process exited. |
| 257 | for (size_t i = 0; i < fds.size(); ++i) { |
| 258 | auto& f = fds[i]; |
| 259 | if (f.fd != kInvalidFD) { |
| 260 | if (ReadFD(f.fd, &data) == ReadResult::kFailure) { |
| 261 | // Failure. |
| 262 | f.fd = kInvalidFD; |
| 263 | } else { |
| 264 | merger.Append(i, data); |
| 265 | } |
| 266 | } |
| 267 | } |
Sergei Datsenko | 9246e9c | 2019-03-22 10:26:47 +1100 | [diff] [blame] | 268 | } |
| 269 | |
Ben Chan | 6f391cb | 2012-03-21 17:38:21 -0700 | [diff] [blame] | 270 | } // namespace cros_disks |