Garrick Evans | 5d55f5e | 2019-07-17 15:28:10 +0900 | [diff] [blame] | 1 | // Copyright 2019 The Chromium OS Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Garrick Evans | 3388a03 | 2020-03-24 11:25:55 +0900 | [diff] [blame] | 5 | #include "patchpanel/arc_service.h" |
Garrick Evans | 5d55f5e | 2019-07-17 15:28:10 +0900 | [diff] [blame] | 6 | |
Garrick Evans | 5486162 | 2019-07-19 09:05:09 +0900 | [diff] [blame] | 7 | #include <linux/rtnetlink.h> |
| 8 | #include <net/if.h> |
Garrick Evans | 71e4a86 | 2020-05-18 12:22:23 +0900 | [diff] [blame] | 9 | #include <sys/utsname.h> |
Garrick Evans | 5486162 | 2019-07-19 09:05:09 +0900 | [diff] [blame] | 10 | |
Garrick Evans | 5d55f5e | 2019-07-17 15:28:10 +0900 | [diff] [blame] | 11 | #include <utility> |
| 12 | |
Garrick Evans | 5486162 | 2019-07-19 09:05:09 +0900 | [diff] [blame] | 13 | #include <base/bind.h> |
Garrick Evans | 5d55f5e | 2019-07-17 15:28:10 +0900 | [diff] [blame] | 14 | #include <base/files/file_path.h> |
| 15 | #include <base/files/file_util.h> |
| 16 | #include <base/logging.h> |
| 17 | #include <base/strings/string_number_conversions.h> |
Qijiang Fan | 2d7aeb4 | 2020-05-19 02:06:39 +0900 | [diff] [blame] | 18 | #include <base/system/sys_info.h> |
Garrick Evans | 1f5a361 | 2019-11-08 12:59:03 +0900 | [diff] [blame] | 19 | #include <brillo/key_value_store.h> |
Garrick Evans | b4eb389 | 2019-11-13 12:07:07 +0900 | [diff] [blame] | 20 | #include <chromeos/constants/vm_tools.h> |
Garrick Evans | 5486162 | 2019-07-19 09:05:09 +0900 | [diff] [blame] | 21 | |
Jason Jeremy Iman | 3081d0e | 2020-03-04 15:52:06 +0900 | [diff] [blame] | 22 | #include "patchpanel/adb_proxy.h" |
Garrick Evans | 3388a03 | 2020-03-24 11:25:55 +0900 | [diff] [blame] | 23 | #include "patchpanel/mac_address_generator.h" |
| 24 | #include "patchpanel/manager.h" |
| 25 | #include "patchpanel/minijailed_process_runner.h" |
| 26 | #include "patchpanel/net_util.h" |
| 27 | #include "patchpanel/scoped_ns.h" |
Garrick Evans | 5d55f5e | 2019-07-17 15:28:10 +0900 | [diff] [blame] | 28 | |
Garrick Evans | 3388a03 | 2020-03-24 11:25:55 +0900 | [diff] [blame] | 29 | namespace patchpanel { |
Garrick Evans | 5d55f5e | 2019-07-17 15:28:10 +0900 | [diff] [blame] | 30 | namespace { |
Hugo Benichi | 0781d40 | 2021-02-22 13:43:11 +0900 | [diff] [blame] | 31 | // UID of Android root, relative to the host pid namespace. |
Hugo Benichi | 6c0233e | 2020-10-06 22:37:57 +0900 | [diff] [blame] | 32 | const int32_t kAndroidRootUid = 655360; |
Hugo Benichi | 4d4bb8f | 2020-07-07 12:16:07 +0900 | [diff] [blame] | 33 | constexpr uint32_t kInvalidId = 0; |
Hugo Benichi | 33860d7 | 2020-07-09 16:34:01 +0900 | [diff] [blame] | 34 | constexpr char kArcNetnsName[] = "arc_netns"; |
Garrick Evans | e94b6de | 2020-02-20 09:19:13 +0900 | [diff] [blame] | 35 | constexpr char kArcIfname[] = "arc0"; |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 36 | |
| 37 | bool IsAdbAllowed(ShillClient::Device::Type type) { |
| 38 | static const std::set<ShillClient::Device::Type> adb_allowed_types{ |
| 39 | ShillClient::Device::Type::kEthernet, |
| 40 | ShillClient::Device::Type::kEthernetEap, |
| 41 | ShillClient::Device::Type::kWifi, |
| 42 | }; |
| 43 | return adb_allowed_types.find(type) != adb_allowed_types.end(); |
| 44 | } |
| 45 | |
Garrick Evans | 71e4a86 | 2020-05-18 12:22:23 +0900 | [diff] [blame] | 46 | bool KernelVersion(int* major, int* minor) { |
| 47 | struct utsname u; |
| 48 | if (uname(&u) != 0) { |
| 49 | PLOG(ERROR) << "uname failed"; |
| 50 | *major = *minor = 0; |
| 51 | return false; |
| 52 | } |
| 53 | int unused; |
| 54 | if (sscanf(u.release, "%d.%d.%d", major, minor, &unused) != 3) { |
| 55 | LOG(ERROR) << "unexpected release string: " << u.release; |
| 56 | *major = *minor = 0; |
| 57 | return false; |
| 58 | } |
| 59 | return true; |
| 60 | } |
| 61 | |
Hugo Benichi | 0781d40 | 2021-02-22 13:43:11 +0900 | [diff] [blame] | 62 | // Makes Android root the owner of /sys/class/ + |path|. |pid| is the ARC |
| 63 | // container pid. |
| 64 | void SetSysfsOwnerToAndroidRoot(uint32_t pid, const std::string& path) { |
Jie Jiang | f679931 | 2021-05-14 16:27:03 +0900 | [diff] [blame] | 65 | auto ns = ScopedNS::EnterMountNS(pid); |
| 66 | if (!ns) { |
Hugo Benichi | 0781d40 | 2021-02-22 13:43:11 +0900 | [diff] [blame] | 67 | LOG(ERROR) << "Cannot enter mnt namespace for pid " << pid; |
| 68 | return; |
| 69 | } |
| 70 | |
| 71 | const std::string sysfs_path = "/sys/class/" + path; |
| 72 | if (chown(sysfs_path.c_str(), kAndroidRootUid, kAndroidRootUid) == -1) |
| 73 | PLOG(ERROR) << "Failed to change ownership of " + sysfs_path; |
| 74 | } |
| 75 | |
| 76 | void OneTimeContainerSetup(const Datapath& datapath, uint32_t pid) { |
Garrick Evans | a34b586 | 2019-11-20 09:34:01 +0900 | [diff] [blame] | 77 | static bool done = false; |
| 78 | if (done) |
| 79 | return; |
| 80 | |
Garrick Evans | 6d227b9 | 2019-12-03 16:11:29 +0900 | [diff] [blame] | 81 | auto& runner = datapath.runner(); |
| 82 | |
| 83 | // Load networking modules needed by Android that are not compiled in the |
| 84 | // kernel. Android does not allow auto-loading of kernel modules. |
Garrick Evans | c53b970 | 2020-05-13 13:20:09 +0900 | [diff] [blame] | 85 | // Expected for all kernels. |
Garrick Evans | 8e8e347 | 2020-01-23 14:03:50 +0900 | [diff] [blame] | 86 | if (runner.modprobe_all({ |
Garrick Evans | a34b586 | 2019-11-20 09:34:01 +0900 | [diff] [blame] | 87 | // The netfilter modules needed by netd for iptables commands. |
| 88 | "ip6table_filter", |
| 89 | "ip6t_ipv6header", |
| 90 | "ip6t_REJECT", |
Garrick Evans | a34b586 | 2019-11-20 09:34:01 +0900 | [diff] [blame] | 91 | // The ipsec modules for AH and ESP encryption for ipv6. |
| 92 | "ah6", |
| 93 | "esp6", |
| 94 | }) != 0) { |
| 95 | LOG(ERROR) << "One or more required kernel modules failed to load." |
| 96 | << " Some Android functionality may be broken."; |
| 97 | } |
Garrick Evans | c53b970 | 2020-05-13 13:20:09 +0900 | [diff] [blame] | 98 | // The xfrm modules needed for Android's ipsec APIs on kernels < 5.4. |
Garrick Evans | 71e4a86 | 2020-05-18 12:22:23 +0900 | [diff] [blame] | 99 | int major, minor; |
| 100 | if (KernelVersion(&major, &minor) && |
| 101 | (major < 5 || (major == 5 && minor < 4)) && |
| 102 | runner.modprobe_all({ |
| 103 | "xfrm4_mode_transport", |
| 104 | "xfrm4_mode_tunnel", |
| 105 | "xfrm6_mode_transport", |
| 106 | "xfrm6_mode_tunnel", |
| 107 | }) != 0) { |
Garrick Evans | c53b970 | 2020-05-13 13:20:09 +0900 | [diff] [blame] | 108 | LOG(ERROR) << "One or more required kernel modules failed to load." |
| 109 | << " Some Android functionality may be broken."; |
| 110 | } |
| 111 | |
Garrick Evans | a34b586 | 2019-11-20 09:34:01 +0900 | [diff] [blame] | 112 | // Optional modules. |
Garrick Evans | 8e8e347 | 2020-01-23 14:03:50 +0900 | [diff] [blame] | 113 | if (runner.modprobe_all({ |
Garrick Evans | a34b586 | 2019-11-20 09:34:01 +0900 | [diff] [blame] | 114 | // This module is not available in kernels < 3.18 |
| 115 | "nf_reject_ipv6", |
| 116 | // These modules are needed for supporting Chrome traffic on Android |
| 117 | // VPN which uses Android's NAT feature. Android NAT sets up |
| 118 | // iptables |
| 119 | // rules that use these conntrack modules for FTP/TFTP. |
| 120 | "nf_nat_ftp", |
| 121 | "nf_nat_tftp", |
Hugo Benichi | a0cde9e | 2019-12-16 11:57:20 +0900 | [diff] [blame] | 122 | // The tun module is needed by the Android 464xlat clatd process. |
| 123 | "tun", |
Garrick Evans | a34b586 | 2019-11-20 09:34:01 +0900 | [diff] [blame] | 124 | }) != 0) { |
| 125 | LOG(WARNING) << "One or more optional kernel modules failed to load."; |
| 126 | } |
| 127 | |
Garrick Evans | 6d227b9 | 2019-12-03 16:11:29 +0900 | [diff] [blame] | 128 | // This is only needed for CTS (b/27932574). |
Hugo Benichi | 0781d40 | 2021-02-22 13:43:11 +0900 | [diff] [blame] | 129 | SetSysfsOwnerToAndroidRoot(pid, "xt_idletimer"); |
Garrick Evans | 6d227b9 | 2019-12-03 16:11:29 +0900 | [diff] [blame] | 130 | |
Garrick Evans | a34b586 | 2019-11-20 09:34:01 +0900 | [diff] [blame] | 131 | done = true; |
| 132 | } |
| 133 | |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 134 | // Returns the ARC management device used for VPN forwarding, ADB-over-TCP. |
| 135 | std::unique_ptr<Device> MakeArcDevice(AddressManager* addr_mgr, |
| 136 | GuestMessage::GuestType guest) { |
| 137 | auto ipv4_subnet = addr_mgr->AllocateIPv4Subnet(AddressManager::Guest::ARC); |
Garrick Evans | e94b6de | 2020-02-20 09:19:13 +0900 | [diff] [blame] | 138 | if (!ipv4_subnet) { |
Garrick Evans | 6c7dcb8 | 2020-03-16 15:21:05 +0900 | [diff] [blame] | 139 | LOG(ERROR) << "Subnet already in use or unavailable"; |
Garrick Evans | e94b6de | 2020-02-20 09:19:13 +0900 | [diff] [blame] | 140 | return nullptr; |
| 141 | } |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 142 | |
Garrick Evans | e94b6de | 2020-02-20 09:19:13 +0900 | [diff] [blame] | 143 | auto host_ipv4_addr = ipv4_subnet->AllocateAtOffset(0); |
| 144 | if (!host_ipv4_addr) { |
Garrick Evans | 6c7dcb8 | 2020-03-16 15:21:05 +0900 | [diff] [blame] | 145 | LOG(ERROR) << "Bridge address already in use or unavailable"; |
Garrick Evans | e94b6de | 2020-02-20 09:19:13 +0900 | [diff] [blame] | 146 | return nullptr; |
| 147 | } |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 148 | |
Garrick Evans | e94b6de | 2020-02-20 09:19:13 +0900 | [diff] [blame] | 149 | auto guest_ipv4_addr = ipv4_subnet->AllocateAtOffset(1); |
| 150 | if (!guest_ipv4_addr) { |
Garrick Evans | 6c7dcb8 | 2020-03-16 15:21:05 +0900 | [diff] [blame] | 151 | LOG(ERROR) << "ARC address already in use or unavailable"; |
Garrick Evans | e94b6de | 2020-02-20 09:19:13 +0900 | [diff] [blame] | 152 | return nullptr; |
| 153 | } |
| 154 | |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 155 | int subnet_index = (guest == GuestMessage::ARC_VM) ? 1 : kAnySubnetIndex; |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 156 | |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 157 | auto config = std::make_unique<Device::Config>( |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 158 | addr_mgr->GenerateMacAddress(subnet_index), std::move(ipv4_subnet), |
| 159 | std::move(host_ipv4_addr), std::move(guest_ipv4_addr)); |
Garrick Evans | e94b6de | 2020-02-20 09:19:13 +0900 | [diff] [blame] | 160 | |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 161 | return std::make_unique<Device>(kArcIfname, kArcBridge, kArcIfname, |
Hugo Benichi | 6f118a3 | 2021-03-01 12:28:14 +0900 | [diff] [blame] | 162 | std::move(config)); |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 163 | } |
Garrick Evans | 5d55f5e | 2019-07-17 15:28:10 +0900 | [diff] [blame] | 164 | } // namespace |
| 165 | |
Garrick Evans | 69b8587 | 2020-02-04 11:40:26 +0900 | [diff] [blame] | 166 | ArcService::ArcService(ShillClient* shill_client, |
Garrick Evans | 2e5c9ab | 2020-03-05 14:33:58 +0900 | [diff] [blame] | 167 | Datapath* datapath, |
| 168 | AddressManager* addr_mgr, |
Garrick Evans | 209a80a | 2020-11-30 14:42:40 +0900 | [diff] [blame] | 169 | GuestMessage::GuestType guest, |
| 170 | Device::ChangeEventHandler device_changed_handler) |
Garrick Evans | 2e5c9ab | 2020-03-05 14:33:58 +0900 | [diff] [blame] | 171 | : shill_client_(shill_client), |
Garrick Evans | 2e5c9ab | 2020-03-05 14:33:58 +0900 | [diff] [blame] | 172 | datapath_(datapath), |
| 173 | addr_mgr_(addr_mgr), |
Hugo Benichi | 4d4bb8f | 2020-07-07 12:16:07 +0900 | [diff] [blame] | 174 | guest_(guest), |
Garrick Evans | 209a80a | 2020-11-30 14:42:40 +0900 | [diff] [blame] | 175 | device_changed_handler_(device_changed_handler), |
Hugo Benichi | 4d4bb8f | 2020-07-07 12:16:07 +0900 | [diff] [blame] | 176 | id_(kInvalidId) { |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 177 | arc_device_ = MakeArcDevice(addr_mgr, guest_); |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 178 | AllocateAddressConfigs(); |
Garrick Evans | 6e4eb3b | 2020-03-09 07:18:31 +0900 | [diff] [blame] | 179 | shill_client_->RegisterDevicesChangedHandler( |
| 180 | base::Bind(&ArcService::OnDevicesChanged, weak_factory_.GetWeakPtr())); |
Jie Jiang | 84c76a1 | 2020-04-17 16:45:20 +0900 | [diff] [blame] | 181 | shill_client_->ScanDevices(); |
Garrick Evans | f29f5a3 | 2019-12-06 11:34:25 +0900 | [diff] [blame] | 182 | } |
| 183 | |
| 184 | ArcService::~ArcService() { |
Hugo Benichi | 4d4bb8f | 2020-07-07 12:16:07 +0900 | [diff] [blame] | 185 | if (IsStarted()) { |
| 186 | Stop(id_); |
Garrick Evans | 664a82f | 2019-12-17 12:18:05 +0900 | [diff] [blame] | 187 | } |
Garrick Evans | 5486162 | 2019-07-19 09:05:09 +0900 | [diff] [blame] | 188 | } |
Garrick Evans | 5d55f5e | 2019-07-17 15:28:10 +0900 | [diff] [blame] | 189 | |
Hugo Benichi | 4d4bb8f | 2020-07-07 12:16:07 +0900 | [diff] [blame] | 190 | bool ArcService::IsStarted() const { |
| 191 | return id_ != kInvalidId; |
| 192 | } |
| 193 | |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 194 | void ArcService::AllocateAddressConfigs() { |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 195 | // The first usable subnet is the "other" ARC device subnet. |
Garrick Evans | c707112 | 2020-04-17 12:31:57 +0900 | [diff] [blame] | 196 | // As a temporary workaround, for ARCVM, allocate fixed MAC addresses. |
| 197 | uint8_t mac_addr_index = 2; |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 198 | // Allocate 2 subnets each for Ethernet and WiFi and 1 for LTE WAN interfaces. |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 199 | for (const auto type : |
| 200 | {ShillClient::Device::Type::kEthernet, |
| 201 | ShillClient::Device::Type::kEthernet, ShillClient::Device::Type::kWifi, |
| 202 | ShillClient::Device::Type::kWifi, |
| 203 | ShillClient::Device::Type::kCellular}) { |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 204 | auto ipv4_subnet = |
| 205 | addr_mgr_->AllocateIPv4Subnet(AddressManager::Guest::ARC_NET); |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 206 | if (!ipv4_subnet) { |
| 207 | LOG(ERROR) << "Subnet already in use or unavailable"; |
| 208 | continue; |
| 209 | } |
| 210 | // For here out, use the same slices. |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 211 | auto host_ipv4_addr = ipv4_subnet->AllocateAtOffset(0); |
| 212 | if (!host_ipv4_addr) { |
| 213 | LOG(ERROR) << "Bridge address already in use or unavailable"; |
| 214 | continue; |
| 215 | } |
| 216 | auto guest_ipv4_addr = ipv4_subnet->AllocateAtOffset(1); |
| 217 | if (!guest_ipv4_addr) { |
| 218 | LOG(ERROR) << "ARC address already in use or unavailable"; |
| 219 | continue; |
| 220 | } |
| 221 | |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 222 | MacAddress mac_addr = (guest_ == GuestMessage::ARC_VM) |
Garrick Evans | c707112 | 2020-04-17 12:31:57 +0900 | [diff] [blame] | 223 | ? addr_mgr_->GenerateMacAddress(mac_addr_index++) |
| 224 | : addr_mgr_->GenerateMacAddress(); |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 225 | available_configs_[type].emplace_back(std::make_unique<Device::Config>( |
Garrick Evans | c707112 | 2020-04-17 12:31:57 +0900 | [diff] [blame] | 226 | mac_addr, std::move(ipv4_subnet), std::move(host_ipv4_addr), |
| 227 | std::move(guest_ipv4_addr))); |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 228 | } |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 229 | |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 230 | all_configs_.push_back(&arc_device_->config()); |
| 231 | // Iterate over |available_configs_| with a fixed explicit order and do not |
| 232 | // rely on the implicit ordering derived from key values. |
| 233 | for (const auto type : |
| 234 | {ShillClient::Device::Type::kEthernet, ShillClient::Device::Type::kWifi, |
| 235 | ShillClient::Device::Type::kCellular}) { |
| 236 | for (const auto& c : available_configs_[type]) { |
| 237 | all_configs_.push_back(c.get()); |
| 238 | } |
| 239 | } |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 240 | } |
| 241 | |
| 242 | std::unique_ptr<Device::Config> ArcService::AcquireConfig( |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 243 | ShillClient::Device::Type type) { |
| 244 | // Normalize shill Device types for different ethernet flavors. |
| 245 | if (type == ShillClient::Device::Type::kEthernetEap) |
| 246 | type = ShillClient::Device::Type::kEthernet; |
| 247 | |
| 248 | auto it = available_configs_.find(type); |
| 249 | if (it == available_configs_.end()) { |
| 250 | LOG(ERROR) << "Unsupported shill Device type " << type; |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 251 | return nullptr; |
| 252 | } |
| 253 | |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 254 | if (it->second.empty()) { |
| 255 | LOG(ERROR) |
| 256 | << "Cannot make virtual device: No more addresses available for type " |
| 257 | << type; |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 258 | return nullptr; |
| 259 | } |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 260 | |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 261 | std::unique_ptr<Device::Config> config; |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 262 | config = std::move(it->second.front()); |
| 263 | it->second.pop_front(); |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 264 | return config; |
| 265 | } |
| 266 | |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 267 | void ArcService::ReleaseConfig(ShillClient::Device::Type type, |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 268 | std::unique_ptr<Device::Config> config) { |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 269 | available_configs_[type].push_front(std::move(config)); |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 270 | } |
| 271 | |
Garrick Evans | 015b0d6 | 2020-02-07 09:06:38 +0900 | [diff] [blame] | 272 | bool ArcService::Start(uint32_t id) { |
Hugo Benichi | 4d4bb8f | 2020-07-07 12:16:07 +0900 | [diff] [blame] | 273 | if (IsStarted()) { |
| 274 | LOG(WARNING) << "Already running - did something crash?" |
| 275 | << " Stopping and restarting..."; |
| 276 | Stop(id_); |
Garrick Evans | a51d0a1 | 2019-11-28 13:51:23 +0900 | [diff] [blame] | 277 | } |
| 278 | |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 279 | std::string arc_device_ifname; |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 280 | if (guest_ == GuestMessage::ARC_VM) { |
Hugo Benichi | 8e44842 | 2020-07-07 10:49:00 +0900 | [diff] [blame] | 281 | // Allocate TAP devices for all configs. |
| 282 | for (auto* config : all_configs_) { |
| 283 | auto mac = config->mac_addr(); |
| 284 | auto tap = datapath_->AddTAP("" /* auto-generate name */, &mac, |
| 285 | nullptr /* no ipv4 subnet */, |
| 286 | vm_tools::kCrosVmUser); |
| 287 | if (tap.empty()) { |
| 288 | LOG(ERROR) << "Failed to create TAP device"; |
| 289 | continue; |
| 290 | } |
| 291 | |
| 292 | config->set_tap_ifname(tap); |
| 293 | } |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 294 | arc_device_ifname = arc_device_->config().tap_ifname(); |
Garrick Evans | 2961c7c | 2020-04-03 11:34:40 +0900 | [diff] [blame] | 295 | } else { |
Hugo Benichi | 0781d40 | 2021-02-22 13:43:11 +0900 | [diff] [blame] | 296 | OneTimeContainerSetup(*datapath_, id); |
Hugo Benichi | 33860d7 | 2020-07-09 16:34:01 +0900 | [diff] [blame] | 297 | if (!datapath_->NetnsAttachName(kArcNetnsName, id)) { |
| 298 | LOG(ERROR) << "Failed to attach name " << kArcNetnsName << " to pid " |
| 299 | << id; |
| 300 | return false; |
| 301 | } |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 302 | arc_device_ifname = ArcVethHostName(arc_device_->guest_ifname()); |
Hugo Benichi | 4d4bb8f | 2020-07-07 12:16:07 +0900 | [diff] [blame] | 303 | if (!datapath_->ConnectVethPair(id, kArcNetnsName, arc_device_ifname, |
| 304 | arc_device_->guest_ifname(), |
| 305 | arc_device_->config().mac_addr(), |
| 306 | arc_device_->config().guest_ipv4_addr(), 30, |
Hugo Benichi | 6f118a3 | 2021-03-01 12:28:14 +0900 | [diff] [blame] | 307 | false /*remote_multicast_flag*/)) { |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 308 | LOG(ERROR) << "Cannot create virtual link for device " |
| 309 | << arc_device_->phys_ifname(); |
| 310 | return false; |
| 311 | } |
Hugo Benichi | 40fbf0b | 2021-01-20 19:44:15 +0900 | [diff] [blame] | 312 | // Allow netd to write to /sys/class/net/arc0/mtu (b/175571457). |
Hugo Benichi | 0781d40 | 2021-02-22 13:43:11 +0900 | [diff] [blame] | 313 | SetSysfsOwnerToAndroidRoot(id, |
| 314 | "net/" + arc_device_->guest_ifname() + "/mtu"); |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 315 | } |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 316 | id_ = id; |
| 317 | |
| 318 | // Create the bridge for the management device arc0. |
| 319 | // Per crbug/1008686 this device cannot be deleted and then re-added. |
| 320 | // So instead of removing the bridge when the service stops, bring down the |
| 321 | // device instead and re-up it on restart. |
| 322 | if (!datapath_->AddBridge(kArcBridge, arc_device_->config().host_ipv4_addr(), |
| 323 | 30) && |
| 324 | !datapath_->MaskInterfaceFlags(kArcBridge, IFF_UP)) { |
| 325 | LOG(ERROR) << "Failed to bring up arc bridge " << kArcBridge; |
| 326 | return false; |
| 327 | } |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 328 | |
| 329 | if (!datapath_->AddToBridge(kArcBridge, arc_device_ifname)) { |
| 330 | LOG(ERROR) << "Failed to bridge arc device " << arc_device_ifname << " to " |
| 331 | << kArcBridge; |
| 332 | return false; |
| 333 | } |
Hugo Benichi | 33860d7 | 2020-07-09 16:34:01 +0900 | [diff] [blame] | 334 | LOG(INFO) << "Started ARC management device " << *arc_device_.get(); |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 335 | |
Garrick Evans | 6e4eb3b | 2020-03-09 07:18:31 +0900 | [diff] [blame] | 336 | // Start already known Shill <-> ARC mapped devices. |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 337 | for (const auto& [ifname, type] : shill_devices_) |
| 338 | AddDevice(ifname, type); |
Garrick Evans | cb791e7 | 2019-11-11 15:44:34 +0900 | [diff] [blame] | 339 | |
Damien Dejean | 61eccae | 2021-05-21 07:11:53 +0000 | [diff] [blame^] | 340 | // Enable conntrack helpers (b/172214190). |
| 341 | if (!datapath_->SetConntrackHelpers(true)) { |
| 342 | LOG(ERROR) << "Failed to enable conntrack helpers"; |
| 343 | return false; |
| 344 | } |
| 345 | |
Garrick Evans | f29f5a3 | 2019-12-06 11:34:25 +0900 | [diff] [blame] | 346 | return true; |
Garrick Evans | cb791e7 | 2019-11-11 15:44:34 +0900 | [diff] [blame] | 347 | } |
| 348 | |
Garrick Evans | 015b0d6 | 2020-02-07 09:06:38 +0900 | [diff] [blame] | 349 | void ArcService::Stop(uint32_t id) { |
Hugo Benichi | 4d4bb8f | 2020-07-07 12:16:07 +0900 | [diff] [blame] | 350 | if (!IsStarted()) { |
| 351 | LOG(ERROR) << "ArcService was not running"; |
| 352 | return; |
| 353 | } |
| 354 | |
| 355 | // After the ARC container has stopped, the pid is not known anymore. |
| 356 | if (guest_ == GuestMessage::ARC_VM && id_ != id) { |
| 357 | LOG(ERROR) << "Mismatched ARCVM CIDs " << id_ << " != " << id; |
| 358 | return; |
| 359 | } |
| 360 | |
Damien Dejean | 61eccae | 2021-05-21 07:11:53 +0000 | [diff] [blame^] | 361 | if (!datapath_->SetConntrackHelpers(false)) |
| 362 | LOG(ERROR) << "Failed to disable conntrack helpers"; |
| 363 | |
Garrick Evans | 6e4eb3b | 2020-03-09 07:18:31 +0900 | [diff] [blame] | 364 | // Stop Shill <-> ARC mapped devices. |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 365 | for (const auto& [ifname, type] : shill_devices_) |
| 366 | RemoveDevice(ifname, type); |
Garrick Evans | f29f5a3 | 2019-12-06 11:34:25 +0900 | [diff] [blame] | 367 | |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 368 | // Per crbug/1008686 this device cannot be deleted and then re-added. |
| 369 | // So instead of removing the bridge, bring it down and mark it. This will |
| 370 | // allow us to detect if the device is re-added in case of a crash restart |
| 371 | // and do the right thing. |
| 372 | if (!datapath_->MaskInterfaceFlags(kArcBridge, IFF_DEBUG, IFF_UP)) |
| 373 | LOG(ERROR) << "Failed to bring down arc bridge " |
| 374 | << "- it may not restart correctly"; |
| 375 | |
Hugo Benichi | 33860d7 | 2020-07-09 16:34:01 +0900 | [diff] [blame] | 376 | if (guest_ == GuestMessage::ARC) { |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 377 | datapath_->RemoveInterface(ArcVethHostName(arc_device_->phys_ifname())); |
Hugo Benichi | 33860d7 | 2020-07-09 16:34:01 +0900 | [diff] [blame] | 378 | if (!datapath_->NetnsDeleteName(kArcNetnsName)) |
| 379 | LOG(WARNING) << "Failed to delete netns name " << kArcNetnsName; |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 380 | } |
| 381 | |
| 382 | // Destroy allocated TAP devices if any, including the ARC management device. |
| 383 | for (auto* config : all_configs_) { |
| 384 | if (config->tap_ifname().empty()) |
| 385 | continue; |
| 386 | datapath_->RemoveInterface(config->tap_ifname()); |
| 387 | config->set_tap_ifname(""); |
Hugo Benichi | 33860d7 | 2020-07-09 16:34:01 +0900 | [diff] [blame] | 388 | } |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 389 | |
Hugo Benichi | 33860d7 | 2020-07-09 16:34:01 +0900 | [diff] [blame] | 390 | LOG(INFO) << "Stopped ARC management device " << *arc_device_.get(); |
Hugo Benichi | 4d4bb8f | 2020-07-07 12:16:07 +0900 | [diff] [blame] | 391 | id_ = kInvalidId; |
Garrick Evans | 5d55f5e | 2019-07-17 15:28:10 +0900 | [diff] [blame] | 392 | } |
| 393 | |
Garrick Evans | 6e4eb3b | 2020-03-09 07:18:31 +0900 | [diff] [blame] | 394 | void ArcService::OnDevicesChanged(const std::set<std::string>& added, |
| 395 | const std::set<std::string>& removed) { |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 396 | for (const std::string& ifname : removed) { |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 397 | RemoveDevice(ifname, shill_devices_[ifname]); |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 398 | shill_devices_.erase(ifname); |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 399 | } |
Garrick Evans | 6e4eb3b | 2020-03-09 07:18:31 +0900 | [diff] [blame] | 400 | |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 401 | for (const std::string& ifname : added) { |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 402 | ShillClient::Device shill_device; |
| 403 | if (!shill_client_->GetDeviceProperties(ifname, &shill_device)) { |
| 404 | LOG(ERROR) << "Could not read shill Device properties for " << ifname; |
| 405 | continue; |
| 406 | } |
| 407 | shill_devices_[ifname] = shill_device.type; |
| 408 | AddDevice(ifname, shill_device.type); |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 409 | } |
Garrick Evans | 6e4eb3b | 2020-03-09 07:18:31 +0900 | [diff] [blame] | 410 | } |
| 411 | |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 412 | void ArcService::AddDevice(const std::string& ifname, |
| 413 | ShillClient::Device::Type type) { |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 414 | if (!IsStarted()) |
| 415 | return; |
| 416 | |
Garrick Evans | 6e4eb3b | 2020-03-09 07:18:31 +0900 | [diff] [blame] | 417 | if (ifname.empty()) |
| 418 | return; |
| 419 | |
| 420 | if (devices_.find(ifname) != devices_.end()) { |
| 421 | LOG(DFATAL) << "Attemping to add already tracked device: " << ifname; |
| 422 | return; |
| 423 | } |
| 424 | |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 425 | auto config = AcquireConfig(type); |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 426 | if (!config) { |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 427 | LOG(ERROR) << "Cannot acquire a Config for " << ifname; |
Garrick Evans | 86c7d9c | 2020-03-17 09:25:48 +0900 | [diff] [blame] | 428 | return; |
| 429 | } |
| 430 | |
Garrick Evans | 8a06756 | 2020-05-11 12:47:30 +0900 | [diff] [blame] | 431 | auto device = std::make_unique<Device>(ifname, ArcBridgeName(ifname), ifname, |
Hugo Benichi | 6f118a3 | 2021-03-01 12:28:14 +0900 | [diff] [blame] | 432 | std::move(config)); |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 433 | LOG(INFO) << "Starting device " << *device; |
Garrick Evans | 5486162 | 2019-07-19 09:05:09 +0900 | [diff] [blame] | 434 | |
| 435 | // Create the bridge. |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 436 | if (!datapath_->AddBridge(device->host_ifname(), |
| 437 | device->config().host_ipv4_addr(), 30)) { |
| 438 | LOG(ERROR) << "Failed to setup bridge " << device->host_ifname(); |
Garrick Evans | e94b6de | 2020-02-20 09:19:13 +0900 | [diff] [blame] | 439 | return; |
Garrick Evans | 5486162 | 2019-07-19 09:05:09 +0900 | [diff] [blame] | 440 | } |
| 441 | |
Hugo Benichi | 8d622b5 | 2020-08-13 15:24:12 +0900 | [diff] [blame] | 442 | datapath_->StartRoutingDevice(device->phys_ifname(), device->host_ifname(), |
| 443 | device->config().guest_ipv4_addr(), |
Hugo Benichi | 93306e5 | 2020-12-04 16:08:00 +0900 | [diff] [blame] | 444 | TrafficSource::ARC, false /*route_on_vpn*/); |
Garrick Evans | 2c26310 | 2019-07-26 16:07:18 +0900 | [diff] [blame] | 445 | |
Hugo Benichi | cf90402 | 2020-07-07 09:21:58 +0900 | [diff] [blame] | 446 | std::string virtual_device_ifname; |
| 447 | if (guest_ == GuestMessage::ARC_VM) { |
| 448 | virtual_device_ifname = device->config().tap_ifname(); |
| 449 | if (virtual_device_ifname.empty()) { |
| 450 | LOG(ERROR) << "No TAP device for " << *device; |
| 451 | return; |
| 452 | } |
| 453 | } else { |
| 454 | virtual_device_ifname = ArcVethHostName(device->guest_ifname()); |
| 455 | if (!datapath_->ConnectVethPair( |
Hugo Benichi | 4d4bb8f | 2020-07-07 12:16:07 +0900 | [diff] [blame] | 456 | id_, kArcNetnsName, virtual_device_ifname, device->guest_ifname(), |
Hugo Benichi | cf90402 | 2020-07-07 09:21:58 +0900 | [diff] [blame] | 457 | device->config().mac_addr(), device->config().guest_ipv4_addr(), 30, |
Hugo Benichi | 6f118a3 | 2021-03-01 12:28:14 +0900 | [diff] [blame] | 458 | IsMulticastInterface(device->phys_ifname()))) { |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 459 | LOG(ERROR) << "Cannot create veth link for device " << *device; |
Hugo Benichi | cf90402 | 2020-07-07 09:21:58 +0900 | [diff] [blame] | 460 | return; |
| 461 | } |
Hugo Benichi | 6c0233e | 2020-10-06 22:37:57 +0900 | [diff] [blame] | 462 | // Allow netd to write to /sys/class/net/<guest_ifname>/mtu (b/169936104). |
Hugo Benichi | 0781d40 | 2021-02-22 13:43:11 +0900 | [diff] [blame] | 463 | SetSysfsOwnerToAndroidRoot(id_, "net/" + device->guest_ifname() + "/mtu"); |
Hugo Benichi | cf90402 | 2020-07-07 09:21:58 +0900 | [diff] [blame] | 464 | } |
| 465 | |
| 466 | if (!datapath_->AddToBridge(device->host_ifname(), virtual_device_ifname)) { |
| 467 | if (guest_ == GuestMessage::ARC) { |
| 468 | datapath_->RemoveInterface(virtual_device_ifname); |
| 469 | } |
| 470 | LOG(ERROR) << "Failed to bridge interface " << virtual_device_ifname; |
Hugo Benichi | 4833fda | 2020-07-06 14:56:56 +0900 | [diff] [blame] | 471 | return; |
| 472 | } |
| 473 | |
Hugo Benichi | 6f118a3 | 2021-03-01 12:28:14 +0900 | [diff] [blame] | 474 | if (IsAdbAllowed(type) && !datapath_->AddAdbPortAccessRule(ifname)) { |
Jason Jeremy Iman | 3081d0e | 2020-03-04 15:52:06 +0900 | [diff] [blame] | 475 | LOG(ERROR) << "Failed to add ADB port access rule"; |
| 476 | } |
| 477 | |
Garrick Evans | 209a80a | 2020-11-30 14:42:40 +0900 | [diff] [blame] | 478 | device_changed_handler_.Run(*device, Device::ChangeEvent::ADDED, guest_); |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 479 | devices_.emplace(ifname, std::move(device)); |
Garrick Evans | 6e4eb3b | 2020-03-09 07:18:31 +0900 | [diff] [blame] | 480 | } |
| 481 | |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 482 | void ArcService::RemoveDevice(const std::string& ifname, |
| 483 | ShillClient::Device::Type type) { |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 484 | if (!IsStarted()) |
| 485 | return; |
| 486 | |
Garrick Evans | 6e4eb3b | 2020-03-09 07:18:31 +0900 | [diff] [blame] | 487 | const auto it = devices_.find(ifname); |
| 488 | if (it == devices_.end()) { |
| 489 | LOG(WARNING) << "Unknown device: " << ifname; |
Garrick Evans | cb791e7 | 2019-11-11 15:44:34 +0900 | [diff] [blame] | 490 | return; |
| 491 | } |
| 492 | |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 493 | const auto* device = it->second.get(); |
Hugo Benichi | ad1bdd9 | 2020-06-12 13:48:37 +0900 | [diff] [blame] | 494 | LOG(INFO) << "Removing device " << *device; |
Garrick Evans | 6e4eb3b | 2020-03-09 07:18:31 +0900 | [diff] [blame] | 495 | |
Garrick Evans | 209a80a | 2020-11-30 14:42:40 +0900 | [diff] [blame] | 496 | device_changed_handler_.Run(*device, Device::ChangeEvent::REMOVED, guest_); |
| 497 | |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 498 | // ARCVM TAP devices are removed in VmImpl::Stop() when the service stops |
Hugo Benichi | 4833fda | 2020-07-06 14:56:56 +0900 | [diff] [blame] | 499 | if (guest_ == GuestMessage::ARC) |
| 500 | datapath_->RemoveInterface(ArcVethHostName(device->phys_ifname())); |
Garrick Evans | 5486162 | 2019-07-19 09:05:09 +0900 | [diff] [blame] | 501 | |
Hugo Benichi | 8d622b5 | 2020-08-13 15:24:12 +0900 | [diff] [blame] | 502 | datapath_->StopRoutingDevice(device->phys_ifname(), device->host_ifname(), |
| 503 | device->config().guest_ipv4_addr(), |
Hugo Benichi | 93306e5 | 2020-12-04 16:08:00 +0900 | [diff] [blame] | 504 | TrafficSource::ARC, false /*route_on_vpn*/); |
Garrick Evans | 6c7dcb8 | 2020-03-16 15:21:05 +0900 | [diff] [blame] | 505 | datapath_->RemoveBridge(device->host_ifname()); |
Hugo Benichi | 6f118a3 | 2021-03-01 12:28:14 +0900 | [diff] [blame] | 506 | if (IsAdbAllowed(type)) |
Jason Jeremy Iman | 3081d0e | 2020-03-04 15:52:06 +0900 | [diff] [blame] | 507 | datapath_->DeleteAdbPortAccessRule(ifname); |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 508 | |
Hugo Benichi | 84d96c4 | 2021-02-26 14:20:13 +0900 | [diff] [blame] | 509 | // Once the physical Device is gone it may not be possible to retrieve |
| 510 | // the device type from Shill DBus interface by interface name. |
| 511 | ReleaseConfig(type, it->second->release_config()); |
Hugo Benichi | f0f10c7 | 2020-07-09 10:42:45 +0900 | [diff] [blame] | 512 | devices_.erase(it); |
Garrick Evans | cb791e7 | 2019-11-11 15:44:34 +0900 | [diff] [blame] | 513 | } |
| 514 | |
Garrick Evans | 38b25a4 | 2020-04-06 15:17:42 +0900 | [diff] [blame] | 515 | std::vector<const Device::Config*> ArcService::GetDeviceConfigs() const { |
Hugo Benichi | 8e44842 | 2020-07-07 10:49:00 +0900 | [diff] [blame] | 516 | std::vector<const Device::Config*> configs; |
| 517 | for (auto* c : all_configs_) |
| 518 | configs.emplace_back(c); |
Garrick Evans | e94b6de | 2020-02-20 09:19:13 +0900 | [diff] [blame] | 519 | |
Hugo Benichi | 8e44842 | 2020-07-07 10:49:00 +0900 | [diff] [blame] | 520 | return configs; |
Garrick Evans | e94b6de | 2020-02-20 09:19:13 +0900 | [diff] [blame] | 521 | } |
Garrick Evans | 02e6e87 | 2020-11-30 11:53:13 +0900 | [diff] [blame] | 522 | |
| 523 | void ArcService::ScanDevices( |
| 524 | base::RepeatingCallback<void(const Device&)> callback) const { |
| 525 | for (const auto& [_, d] : devices_) |
| 526 | callback.Run(*d.get()); |
| 527 | } |
| 528 | |
Garrick Evans | 3388a03 | 2020-03-24 11:25:55 +0900 | [diff] [blame] | 529 | } // namespace patchpanel |