Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 1 | // Copyright 2019 The Chromium OS Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Garrick Evans | 3388a03 | 2020-03-24 11:25:55 +0900 | [diff] [blame^] | 5 | #include "patchpanel/crostini_service.h" |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 6 | |
| 7 | #include <memory> |
| 8 | #include <utility> |
| 9 | |
| 10 | #include <base/strings/string_number_conversions.h> |
| 11 | #include <base/strings/string_util.h> |
| 12 | #include <base/strings/stringprintf.h> |
Jason Jeremy Iman | fa8b6d2 | 2020-02-20 03:44:21 +0000 | [diff] [blame] | 13 | #include "base/threading/thread_task_runner_handle.h" |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 14 | #include <chromeos/constants/vm_tools.h> |
Jason Jeremy Iman | fa8b6d2 | 2020-02-20 03:44:21 +0000 | [diff] [blame] | 15 | #include <chromeos/dbus/service_constants.h> |
| 16 | #include <dbus/message.h> |
| 17 | #include <dbus/object_path.h> |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 18 | |
Garrick Evans | 3388a03 | 2020-03-24 11:25:55 +0900 | [diff] [blame^] | 19 | #include "patchpanel/adb_proxy.h" |
| 20 | #include "patchpanel/device.h" |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 21 | |
Garrick Evans | 3388a03 | 2020-03-24 11:25:55 +0900 | [diff] [blame^] | 22 | namespace patchpanel { |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 23 | namespace { |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 24 | constexpr int32_t kInvalidID = 0; |
Jason Jeremy Iman | fa8b6d2 | 2020-02-20 03:44:21 +0000 | [diff] [blame] | 25 | constexpr int kDbusTimeoutMs = 200; |
| 26 | constexpr base::TimeDelta kAdbSideloadUpdateDelay = |
| 27 | base::TimeDelta::FromMilliseconds(5000); |
Jason Jeremy Iman | bb8787e | 2019-12-13 14:08:20 +0900 | [diff] [blame] | 28 | |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 29 | std::string MakeKey(uint64_t vm_id, bool is_termina) { |
| 30 | return base::StringPrintf("%s:%s", is_termina ? "t" : "p", |
| 31 | base::NumberToString(vm_id).c_str()); |
| 32 | } |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 33 | |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 34 | } // namespace |
| 35 | |
Garrick Evans | 69b8587 | 2020-02-04 11:40:26 +0900 | [diff] [blame] | 36 | CrostiniService::CrostiniService(ShillClient* shill_client, |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 37 | AddressManager* addr_mgr, |
| 38 | Datapath* datapath, |
| 39 | TrafficForwarder* forwarder) |
| 40 | : shill_client_(shill_client), |
| 41 | addr_mgr_(addr_mgr), |
| 42 | datapath_(datapath), |
Jason Jeremy Iman | fa8b6d2 | 2020-02-20 03:44:21 +0000 | [diff] [blame] | 43 | forwarder_(forwarder), |
| 44 | adb_sideloading_enabled_(false) { |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 45 | DCHECK(shill_client_); |
| 46 | DCHECK(addr_mgr_); |
Garrick Evans | f29f5a3 | 2019-12-06 11:34:25 +0900 | [diff] [blame] | 47 | DCHECK(datapath_); |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 48 | DCHECK(forwarder_); |
Garrick Evans | f29f5a3 | 2019-12-06 11:34:25 +0900 | [diff] [blame] | 49 | |
Jason Jeremy Iman | fa8b6d2 | 2020-02-20 03:44:21 +0000 | [diff] [blame] | 50 | // Setup for ADB sideloading. |
| 51 | if (!SetupFirewallClient()) { |
| 52 | LOG(ERROR) << "Failed to setup firewall client for ADB sideloading"; |
| 53 | } else { |
| 54 | CheckAdbSideloadingStatus(); |
| 55 | } |
| 56 | |
Garrick Evans | 69b8587 | 2020-02-04 11:40:26 +0900 | [diff] [blame] | 57 | shill_client_->RegisterDefaultInterfaceChangedHandler(base::Bind( |
| 58 | &CrostiniService::OnDefaultInterfaceChanged, weak_factory_.GetWeakPtr())); |
Garrick Evans | f29f5a3 | 2019-12-06 11:34:25 +0900 | [diff] [blame] | 59 | } |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 60 | |
Garrick Evans | c1ac5c4 | 2020-03-31 15:31:22 +0900 | [diff] [blame] | 61 | CrostiniService::~CrostiniService() { |
| 62 | if (bus_) |
| 63 | bus_->ShutdownAndBlock(); |
| 64 | } |
| 65 | |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 66 | bool CrostiniService::Start(uint64_t vm_id, bool is_termina, int subnet_index) { |
| 67 | if (vm_id == kInvalidID) { |
| 68 | LOG(ERROR) << "Invalid VM id"; |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 69 | return false; |
| 70 | } |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 71 | |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 72 | const auto key = MakeKey(vm_id, is_termina); |
| 73 | if (taps_.find(key) != taps_.end()) { |
| 74 | LOG(WARNING) << "Already started for {id: " << vm_id << "}"; |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 75 | return false; |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 76 | } |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 77 | |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 78 | auto tap = AddTAP(is_termina, subnet_index); |
| 79 | if (!tap) { |
| 80 | LOG(ERROR) << "Cannot start for {id: " << vm_id << "}"; |
| 81 | return false; |
| 82 | } |
Jason Jeremy Iman | bb8787e | 2019-12-13 14:08:20 +0900 | [diff] [blame] | 83 | |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 84 | LOG(INFO) << "Crostini network service started for {id: " << vm_id << "}"; |
Garrick Evans | 6c7dcb8 | 2020-03-16 15:21:05 +0900 | [diff] [blame] | 85 | StartForwarding(shill_client_->default_interface(), tap->host_ifname()); |
| 86 | |
Jason Jeremy Iman | fa8b6d2 | 2020-02-20 03:44:21 +0000 | [diff] [blame] | 87 | if (adb_sideloading_enabled_) |
Garrick Evans | 6c7dcb8 | 2020-03-16 15:21:05 +0900 | [diff] [blame] | 88 | StartAdbPortForwarding(tap->phys_ifname()); |
| 89 | |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 90 | taps_.emplace(key, std::move(tap)); |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 91 | return true; |
| 92 | } |
| 93 | |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 94 | void CrostiniService::Stop(uint64_t vm_id, bool is_termina) { |
| 95 | const auto key = MakeKey(vm_id, is_termina); |
| 96 | const auto it = taps_.find(key); |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 97 | if (it == taps_.end()) { |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 98 | LOG(WARNING) << "Unknown {id: " << vm_id << "}"; |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 99 | return; |
| 100 | } |
| 101 | |
Garrick Evans | 6c7dcb8 | 2020-03-16 15:21:05 +0900 | [diff] [blame] | 102 | const auto& ifname = it->second->host_ifname(); |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 103 | StopForwarding(shill_client_->default_interface(), ifname); |
Jason Jeremy Iman | fa8b6d2 | 2020-02-20 03:44:21 +0000 | [diff] [blame] | 104 | if (adb_sideloading_enabled_) |
| 105 | StopAdbPortForwarding(ifname); |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 106 | datapath_->RemoveInterface(ifname); |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 107 | taps_.erase(key); |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 108 | |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 109 | LOG(INFO) << "Crostini network service stopped for {id: " << vm_id << "}"; |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 110 | } |
| 111 | |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 112 | const Device* const CrostiniService::TAP(uint64_t vm_id, |
| 113 | bool is_termina) const { |
| 114 | const auto it = taps_.find(MakeKey(vm_id, is_termina)); |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 115 | if (it == taps_.end()) { |
| 116 | return nullptr; |
| 117 | } |
| 118 | return it->second.get(); |
| 119 | } |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 120 | |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 121 | std::unique_ptr<Device> CrostiniService::AddTAP(bool is_termina, |
| 122 | int subnet_index) { |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 123 | auto ipv4_subnet = addr_mgr_->AllocateIPv4Subnet( |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 124 | is_termina ? AddressManager::Guest::VM_TERMINA |
Garrick Evans | 1fa4e64 | 2020-03-13 11:43:41 +0900 | [diff] [blame] | 125 | : AddressManager::Guest::VM_PLUGIN, |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 126 | subnet_index); |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 127 | if (!ipv4_subnet) { |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 128 | LOG(ERROR) << "Subnet already in use or unavailable."; |
| 129 | return nullptr; |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 130 | } |
| 131 | auto host_ipv4_addr = ipv4_subnet->AllocateAtOffset(0); |
| 132 | if (!host_ipv4_addr) { |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 133 | LOG(ERROR) << "Host address already in use or unavailable."; |
| 134 | return nullptr; |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 135 | } |
| 136 | auto guest_ipv4_addr = ipv4_subnet->AllocateAtOffset(1); |
| 137 | if (!guest_ipv4_addr) { |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 138 | LOG(ERROR) << "VM address already in use or unavailable."; |
| 139 | return nullptr; |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 140 | } |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 141 | std::unique_ptr<Subnet> lxd_subnet; |
| 142 | if (is_termina) { |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 143 | lxd_subnet = |
| 144 | addr_mgr_->AllocateIPv4Subnet(AddressManager::Guest::CONTAINER); |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 145 | if (!lxd_subnet) { |
| 146 | LOG(ERROR) << "lxd subnet already in use or unavailable."; |
| 147 | return nullptr; |
| 148 | } |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 149 | } |
| 150 | |
Garrick Evans | 7d9a232 | 2020-04-02 11:59:56 +0900 | [diff] [blame] | 151 | const auto mac_addr = addr_mgr_->GenerateMacAddress(subnet_index); |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 152 | const std::string tap = |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 153 | datapath_->AddTAP("" /* auto-generate name */, &mac_addr, |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 154 | host_ipv4_addr.get(), vm_tools::kCrosVmUser); |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 155 | if (tap.empty()) { |
Garrick Evans | 51d5b55 | 2020-01-30 10:42:06 +0900 | [diff] [blame] | 156 | LOG(ERROR) << "Failed to create TAP device."; |
| 157 | return nullptr; |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 158 | } |
| 159 | |
Garrick Evans | 3d97a39 | 2020-02-21 15:24:37 +0900 | [diff] [blame] | 160 | if (lxd_subnet) { |
| 161 | // Setup lxd route for the container using the VM as a gateway. |
| 162 | if (!datapath_->AddIPv4Route(ipv4_subnet->AddressAtOffset(1), |
| 163 | lxd_subnet->AddressAtOffset(0), |
| 164 | lxd_subnet->Netmask())) { |
| 165 | LOG(ERROR) << "Failed to setup lxd route"; |
| 166 | return nullptr; |
| 167 | } |
| 168 | } |
| 169 | |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 170 | auto config = std::make_unique<Device::Config>( |
Garrick Evans | 6c7dcb8 | 2020-03-16 15:21:05 +0900 | [diff] [blame] | 171 | mac_addr, std::move(ipv4_subnet), std::move(host_ipv4_addr), |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 172 | std::move(guest_ipv4_addr), std::move(lxd_subnet)); |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 173 | |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 174 | Device::Options opts{ |
| 175 | .fwd_multicast = true, |
| 176 | .ipv6_enabled = true, |
Garrick Evans | b1c9371 | 2020-01-22 09:28:25 +0900 | [diff] [blame] | 177 | }; |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 178 | |
Garrick Evans | 6c7dcb8 | 2020-03-16 15:21:05 +0900 | [diff] [blame] | 179 | return std::make_unique<Device>(tap, tap, "", std::move(config), opts); |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 180 | } |
| 181 | |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 182 | void CrostiniService::OnDefaultInterfaceChanged( |
| 183 | const std::string& new_ifname, const std::string& prev_ifname) { |
| 184 | for (const auto& t : taps_) { |
Garrick Evans | 6c7dcb8 | 2020-03-16 15:21:05 +0900 | [diff] [blame] | 185 | StopForwarding(prev_ifname, t.second->host_ifname()); |
| 186 | StartForwarding(new_ifname, t.second->host_ifname()); |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 187 | } |
| 188 | } |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 189 | |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 190 | void CrostiniService::StartForwarding(const std::string& phys_ifname, |
Jason Jeremy Iman | 0e9f826 | 2020-03-06 14:50:49 +0900 | [diff] [blame] | 191 | const std::string& virt_ifname) { |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 192 | if (!phys_ifname.empty()) |
Jason Jeremy Iman | 0e9f826 | 2020-03-06 14:50:49 +0900 | [diff] [blame] | 193 | forwarder_->StartForwarding(phys_ifname, virt_ifname, true /*ipv6*/, |
| 194 | true /*multicast*/); |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 195 | } |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 196 | |
Garrick Evans | 1b1f67c | 2020-02-04 16:21:25 +0900 | [diff] [blame] | 197 | void CrostiniService::StopForwarding(const std::string& phys_ifname, |
| 198 | const std::string& virt_ifname) { |
| 199 | if (!phys_ifname.empty()) |
| 200 | forwarder_->StopForwarding(phys_ifname, virt_ifname, true /*ipv6*/, |
| 201 | true /*multicast*/); |
Garrick Evans | 47c1927 | 2019-11-21 10:58:21 +0900 | [diff] [blame] | 202 | } |
| 203 | |
Jason Jeremy Iman | fa8b6d2 | 2020-02-20 03:44:21 +0000 | [diff] [blame] | 204 | bool CrostiniService::SetupFirewallClient() { |
| 205 | dbus::Bus::Options options; |
| 206 | options.bus_type = dbus::Bus::SYSTEM; |
| 207 | |
| 208 | bus_ = new dbus::Bus(options); |
| 209 | if (!bus_->Connect()) { |
| 210 | LOG(ERROR) << "Failed to connect to system bus"; |
| 211 | return false; |
| 212 | } |
| 213 | |
| 214 | permission_broker_proxy_.reset( |
| 215 | new org::chromium::PermissionBrokerProxy(bus_)); |
| 216 | |
| 217 | return true; |
| 218 | } |
| 219 | |
| 220 | void CrostiniService::StartAdbPortForwarding(const std::string& ifname) { |
| 221 | if (!permission_broker_proxy_) |
| 222 | return; |
| 223 | |
| 224 | DCHECK(lifeline_fds_.find(ifname) == lifeline_fds_.end()); |
| 225 | // Setup lifeline pipe. |
| 226 | int lifeline_fds[2]; |
| 227 | if (pipe(lifeline_fds) != 0) { |
| 228 | PLOG(ERROR) << "Failed to create lifeline pipe"; |
| 229 | return; |
| 230 | } |
| 231 | base::ScopedFD lifeline_read_fd(lifeline_fds[0]); |
| 232 | base::ScopedFD lifeline_write_fd(lifeline_fds[1]); |
| 233 | |
| 234 | bool allowed = false; |
| 235 | brillo::ErrorPtr error; |
| 236 | permission_broker_proxy_->RequestAdbPortForward(ifname, lifeline_fds[0], |
| 237 | &allowed, &error); |
| 238 | if (error) { |
| 239 | LOG(ERROR) << "Error calling D-Bus proxy call to interface " |
| 240 | << "'" << permission_broker_proxy_->GetObjectPath().value() |
| 241 | << "': " << error->GetMessage(); |
| 242 | return; |
| 243 | } |
| 244 | if (!allowed) { |
| 245 | LOG(ERROR) << "ADB port forwarding on " << ifname << " not allowed"; |
| 246 | return; |
| 247 | } |
| 248 | |
| 249 | permission_broker_proxy_->RequestTcpPortAccess( |
| 250 | kAdbProxyTcpListenPort, ifname, lifeline_fds[0], &allowed, &error); |
| 251 | if (error) { |
| 252 | LOG(ERROR) << "Error calling D-Bus proxy call to interface " |
| 253 | << "'" << permission_broker_proxy_->GetObjectPath().value() |
| 254 | << "': " << error->GetMessage(); |
| 255 | return; |
| 256 | } |
| 257 | if (!allowed) { |
| 258 | LOG(ERROR) << "ADB port access on " << ifname << " not allowed"; |
| 259 | return; |
| 260 | } |
| 261 | |
| 262 | if (datapath_->runner().sysctl_w( |
| 263 | "net.ipv4.conf." + ifname + ".route_localnet", "1") != 0) { |
| 264 | LOG(ERROR) << "Failed to set up route localnet for " << ifname; |
| 265 | return; |
| 266 | } |
| 267 | |
| 268 | lifeline_fds_.emplace(ifname, std::move(lifeline_write_fd)); |
| 269 | } |
| 270 | |
| 271 | void CrostiniService::StopAdbPortForwarding(const std::string& ifname) { |
| 272 | lifeline_fds_.erase(ifname); |
| 273 | } |
| 274 | |
| 275 | void CrostiniService::CheckAdbSideloadingStatus() { |
| 276 | dbus::ObjectProxy* proxy = bus_->GetObjectProxy( |
| 277 | login_manager::kSessionManagerServiceName, |
| 278 | dbus::ObjectPath(login_manager::kSessionManagerServicePath)); |
| 279 | dbus::MethodCall method_call(login_manager::kSessionManagerInterface, |
| 280 | login_manager::kSessionManagerQueryAdbSideload); |
| 281 | std::unique_ptr<dbus::Response> dbus_response = |
| 282 | proxy->CallMethodAndBlock(&method_call, kDbusTimeoutMs); |
| 283 | |
| 284 | if (!dbus_response) { |
| 285 | LOG(WARNING) << "Failed to get ADB sideloading status"; |
| 286 | base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( |
| 287 | FROM_HERE, |
| 288 | base::BindOnce(&CrostiniService::CheckAdbSideloadingStatus, |
| 289 | weak_factory_.GetWeakPtr()), |
| 290 | kAdbSideloadUpdateDelay); |
| 291 | return; |
| 292 | } |
| 293 | |
| 294 | dbus::MessageReader reader(dbus_response.get()); |
| 295 | reader.PopBool(&adb_sideloading_enabled_); |
| 296 | if (!adb_sideloading_enabled_) |
| 297 | return; |
| 298 | |
| 299 | // If ADB sideloading is enabled, start ADB forwarding on all configured |
| 300 | // Crostini's TAP interfaces. |
| 301 | for (const auto& tap : taps_) { |
Garrick Evans | 6c7dcb8 | 2020-03-16 15:21:05 +0900 | [diff] [blame] | 302 | StartAdbPortForwarding(tap.second->phys_ifname()); |
Jason Jeremy Iman | fa8b6d2 | 2020-02-20 03:44:21 +0000 | [diff] [blame] | 303 | } |
| 304 | } |
| 305 | |
Garrick Evans | 3388a03 | 2020-03-24 11:25:55 +0900 | [diff] [blame^] | 306 | } // namespace patchpanel |