blob: a2a1d5c8e971f489d23af7983860ce73dde29244 [file] [log] [blame]
Derek Beckettf73baca2020-08-19 15:08:47 -07001# Lint as: python2, python3
Fang Deng5d518f42013-08-02 14:04:32 -07002# Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
3# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5#
6# Expects to be run in an environment with sudo and no interactive password
7# prompt, such as within the Chromium OS development chroot.
8
9
10"""This file provides core logic for servo verify/repair process."""
11
12
Derek Beckettf73baca2020-08-19 15:08:47 -070013from __future__ import absolute_import
14from __future__ import division
15from __future__ import print_function
16
Fang Deng5d518f42013-08-02 14:04:32 -070017import logging
Raul E Rangel52ca2e82018-07-03 14:10:14 -060018import os
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080019import re
20import tarfile
Andrew McRaef0679932020-08-13 09:15:23 +100021import threading
Garry Wang2b5eef92020-08-21 16:23:35 -070022import json
Garry Wangc1288cf2019-12-17 14:58:00 -080023import time
Derek Beckettf73baca2020-08-19 15:08:47 -070024import six
25import six.moves.xmlrpc_client
Otabek Kasimov120b6fa2020-07-03 00:15:27 -070026import calendar
Fang Deng5d518f42013-08-02 14:04:32 -070027
28from autotest_lib.client.bin import utils
Garry Wang79e9af62019-06-12 15:19:19 -070029from autotest_lib.client.common_lib import error
Richard Barnette9a26ad62016-06-10 12:03:08 -070030from autotest_lib.client.common_lib import hosts
Garry Wang7b0e1b72020-03-25 19:08:59 -070031from autotest_lib.client.common_lib import lsbrelease_utils
Fang Deng5d518f42013-08-02 14:04:32 -070032from autotest_lib.client.common_lib.cros import retry
Christopher Wileycef1f902014-06-19 11:11:23 -070033from autotest_lib.client.common_lib.cros.network import ping_runner
Richard Barnette9a26ad62016-06-10 12:03:08 -070034from autotest_lib.server.cros.servo import servo
Richard Barnetted31580e2018-05-14 19:58:00 +000035from autotest_lib.server.hosts import servo_repair
Garry Wangebc015b2019-06-06 17:45:06 -070036from autotest_lib.server.hosts import base_servohost
Garry Wang11b5e872020-03-11 15:14:08 -070037from autotest_lib.server.hosts import servo_constants
Otabek Kasimov4ea636e2020-04-14 23:35:06 -070038from autotest_lib.server.cros.faft.utils import config
Garry Wang11b5e872020-03-11 15:14:08 -070039from autotest_lib.client.common_lib import global_config
Otabek Kasimov8475cce2020-07-14 12:11:31 -070040from autotest_lib.site_utils.admin_audit import servo_updater
Garry Wangd7367482020-02-27 13:52:40 -080041
Otabek Kasimov15963492020-06-23 21:10:51 -070042try:
43 from chromite.lib import metrics
44except ImportError:
45 metrics = utils.metrics_mock
46
Dan Shi3b2adf62015-09-02 17:46:54 -070047_CONFIG = global_config.global_config
Fang Deng5d518f42013-08-02 14:04:32 -070048
Otabek Kasimova7ba91a2020-03-09 08:31:01 -070049
Garry Wangebc015b2019-06-06 17:45:06 -070050class ServoHost(base_servohost.BaseServoHost):
51 """Host class for a servo host(e.g. beaglebone, labstation)
Dana Goyette0b6e6402019-10-04 11:09:24 -070052 that with a servo instance for a specific port.
53
54 @type _servo: servo.Servo | None
55 """
Fang Deng5d518f42013-08-02 14:04:32 -070056
Raul E Rangel52ca2e82018-07-03 14:10:14 -060057 DEFAULT_PORT = int(os.getenv('SERVOD_PORT', '9999'))
Richard Barnette9a26ad62016-06-10 12:03:08 -070058
Dan Shie5b3c512014-08-21 12:12:09 -070059 # Timeout for initializing servo signals.
Wai-Hong Tam37b6ed32017-09-19 15:52:39 -070060 INITIALIZE_SERVO_TIMEOUT_SECS = 60
Richard Barnette9a26ad62016-06-10 12:03:08 -070061
Otabek Kasimov545739c2020-08-20 00:24:21 -070062 # Default timeout for run terminal command.
63 DEFAULT_TERMINAL_TIMEOUT = 30
64
xixuan6cf6d2f2016-01-29 15:29:00 -080065 # Ready test function
66 SERVO_READY_METHOD = 'get_version'
Fang Deng5d518f42013-08-02 14:04:32 -070067
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080068 # Directory prefix on the servo host where the servod logs are stored.
69 SERVOD_LOG_PREFIX = '/var/log/servod'
70
71 # Exit code to use when symlinks for servod logs are not found.
72 NO_SYMLINKS_CODE = 9
73
74 # Directory in the job's results directory to dump the logs into.
75 LOG_DIR = 'servod'
76
77 # Prefix for joint loglevel files in the logs.
78 JOINT_LOG_PREFIX = 'log'
79
80 # Regex group to extract timestamp from logfile name.
81 TS_GROUP = 'ts'
82
83 # This regex is used to extract the timestamp from servod logs.
Garry Wang22f2e842020-09-09 20:19:19 -070084 # files always start with log.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -080085 TS_RE = (r'log.'
86 # The timestamp is of format %Y-%m-%d--%H-%M-%S.MS
87 r'(?P<%s>\d{4}(\-\d{2}){2}\-(-\d{2}){3}.\d{3})'
88 # The loglevel is optional depending on labstation version.
89 r'(.(INFO|DEBUG|WARNING))?' % TS_GROUP)
90 TS_EXTRACTOR = re.compile(TS_RE)
91
92 # Regex group to extract MCU name from logline in servod logs.
93 MCU_GROUP = 'mcu'
94
95 # Regex group to extract logline from MCU logline in servod logs.
96 LINE_GROUP = 'line'
97
98 # This regex is used to extract the mcu and the line content from an
99 # MCU logline in servod logs. e.g. EC or servo_v4 console logs.
100 # Here is an example log-line:
101 #
102 # 2020-01-23 13:15:12,223 - servo_v4 - EC3PO.Console - DEBUG -
103 # console.py:219:LogConsoleOutput - /dev/pts/9 - cc polarity: cc1
104 #
105 # Here is conceptually how they are formatted:
106 #
107 # <time> - <MCU> - EC3PO.Console - <LVL> - <file:line:func> - <pts> -
108 # <output>
109 #
Garry Wang22f2e842020-09-09 20:19:19 -0700110 # The log format starts with a timestamp
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800111 MCU_RE = (r'[\d\-]+ [\d:,]+ '
112 # The mcu that is logging this is next.
113 r'- (?P<%s>\w+) - '
114 # Next, we have more log outputs before the actual line.
115 # Information about the file line, logging function etc.
116 # Anchor on EC3PO Console, LogConsoleOutput and dev/pts.
117 # NOTE: if the log format changes, this regex needs to be
118 # adjusted.
119 r'EC3PO\.Console[\s\-\w\d:.]+LogConsoleOutput - /dev/pts/\d+ - '
120 # Lastly, we get the MCU's console line.
121 r'(?P<%s>.+$)' % (MCU_GROUP, LINE_GROUP))
122 MCU_EXTRACTOR = re.compile(MCU_RE)
123
Otabek Kasimov545739c2020-08-20 00:24:21 -0700124 # Regex to detect timeout messages when USBC pigtail has timeout issue.
125 # e.g.: [475635.427072 PD TMOUT RX 1/1]
126 USBC_PIGTAIL_TIMEOUT_RE = r'\[[\d \.]{1,20}(PD TMOUT RX 1\/1)\]'
127
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800128 # Suffix to identify compressed logfiles.
129 COMPRESSION_SUFFIX = '.tbz2'
130
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700131 # A suffix to mark servod log directories that came from instance that
132 # ran during this servo_host, but are not the last one running e.g. when
133 # an instance (on purpose, or due to a bug) restarted in the middle of the
134 # run.
135 OLD_LOG_SUFFIX = 'old'
136
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700137 # Mapping servo board with their vid-pid
138 SERVO_VID_PID = {
139 'servo_v4':'18d1:501b',
140 'ccd_cr50':'18d1:5014',
141 'servo_micro':'18d1:501a',
142 'servo_v3':['18d1:5004', '0403:6014'],
143 }
144
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800145 def _init_attributes(self):
146 self._servo_state = None
147 self.servo_port = None
148 self.servo_board = None
149 self.servo_model = None
150 self.servo_serial = None
Garry Wang000c6c02020-05-11 21:27:23 -0700151 # The flag that indicate if a servo is connected to a smart usbhub.
152 # TODO(xianuowang@) remove this flag once all usbhubs in the lab
153 # get replaced.
154 self.smart_usbhub = None
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800155 self._servo = None
Andrew McRaef0679932020-08-13 09:15:23 +1000156 self._tunnel_proxy = None
157 self._tunnel_proxy_lock = threading.Lock()
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700158 self._initial_instance_ts = None
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800159 # Flag to make sure that multiple calls to close do not result in the
160 # logic executing multiple times.
161 self._closed = False
Andrew McRaef0679932020-08-13 09:15:23 +1000162 # Per-thread local data
163 self._local = threading.local()
Fang Deng5d518f42013-08-02 14:04:32 -0700164
Richard Barnette17bfc6c2016-08-04 18:41:43 -0700165 def _initialize(self, servo_host='localhost',
Richard Barnettee519dcd2016-08-15 17:37:17 -0700166 servo_port=DEFAULT_PORT, servo_board=None,
Nick Sanders2f3c9852018-10-24 12:10:24 -0700167 servo_model=None, servo_serial=None, is_in_lab=None,
168 *args, **dargs):
Fang Deng5d518f42013-08-02 14:04:32 -0700169 """Initialize a ServoHost instance.
170
171 A ServoHost instance represents a host that controls a servo.
172
173 @param servo_host: Name of the host where the servod process
174 is running.
Raul E Rangel52ca2e82018-07-03 14:10:14 -0600175 @param servo_port: Port the servod process is listening on. Defaults
176 to the SERVOD_PORT environment variable if set,
177 otherwise 9999.
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700178 @param servo_board: Board that the servo is connected to.
Nick Sanders2f3c9852018-10-24 12:10:24 -0700179 @param servo_model: Model that the servo is connected to.
Dan Shi4d478522014-02-14 13:46:32 -0800180 @param is_in_lab: True if the servo host is in Cros Lab. Default is set
181 to None, for which utils.host_is_in_lab_zone will be
182 called to check if the servo host is in Cros lab.
Fang Deng5d518f42013-08-02 14:04:32 -0700183
184 """
185 super(ServoHost, self)._initialize(hostname=servo_host,
Garry Wangebc015b2019-06-06 17:45:06 -0700186 is_in_lab=is_in_lab, *args, **dargs)
Otabek Kasimovcc9738e2020-02-14 16:17:15 -0800187 self._init_attributes()
Richard Barnette42f4db92018-08-23 15:05:15 -0700188 self.servo_port = int(servo_port)
Richard Barnettee519dcd2016-08-15 17:37:17 -0700189 self.servo_board = servo_board
Nick Sanders2f3c9852018-10-24 12:10:24 -0700190 self.servo_model = servo_model
Kevin Cheng643ce8a2016-09-15 15:42:12 -0700191 self.servo_serial = servo_serial
Wai-Hong Tam3a8a2552019-11-19 14:28:04 +0800192
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800193 # The location of the log files on the servo host for this instance.
194 self.remote_log_dir = '%s_%s' % (self.SERVOD_LOG_PREFIX,
195 self.servo_port)
Garry Wang79e9af62019-06-12 15:19:19 -0700196 # Path of the servo host lock file.
Derek Beckettf73baca2020-08-19 15:08:47 -0700197 self._lock_file = (self.TEMP_FILE_DIR + str(self.servo_port) +
198 self.LOCK_FILE_POSTFIX)
Garry Wang79e9af62019-06-12 15:19:19 -0700199 # File path to declare a reboot request.
Derek Beckettf73baca2020-08-19 15:08:47 -0700200 self._reboot_file = (self.TEMP_FILE_DIR + str(self.servo_port) +
201 self.REBOOT_FILE_POSTFIX)
Garry Wang79e9af62019-06-12 15:19:19 -0700202
203 # Lock the servo host if it's an in-lab labstation to prevent other
204 # task to reboot it until current task completes. We also wait and
205 # make sure the labstation is up here, in the case of the labstation is
206 # in the middle of reboot.
Garry Wang7c00b0f2019-06-25 17:28:17 -0700207 self._is_locked = False
Garry Wang42b4d862019-06-25 15:50:49 -0700208 if (self.wait_up(self.REBOOT_TIMEOUT) and self.is_in_lab()
209 and self.is_labstation()):
Garry Wang79e9af62019-06-12 15:19:19 -0700210 self._lock()
Garry Wangebc015b2019-06-06 17:45:06 -0700211
Richard Barnette9a26ad62016-06-10 12:03:08 -0700212 self._repair_strategy = (
213 servo_repair.create_servo_repair_strategy())
Richard Barnettee519dcd2016-08-15 17:37:17 -0700214
Dana Goyetteafa62fd2020-03-16 13:45:27 -0700215 def __str__(self):
216 return "<%s '%s:%s'>" % (
217 type(self).__name__, self.hostname, self.servo_port)
218
Richard Barnette9a26ad62016-06-10 12:03:08 -0700219 def connect_servo(self):
Garry Wang8c8dc972020-06-09 13:41:51 -0700220 """ Initialize and setup servo for later use.
221 """
222 self.initilize_servo()
223 self.initialize_dut_for_servo()
224
Garry Wang8c8dc972020-06-09 13:41:51 -0700225 def initilize_servo(self):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700226 """Establish a connection to the servod server on this host.
Richard Barnette9a26ad62016-06-10 12:03:08 -0700227
228 Initializes `self._servo` and then verifies that all network
229 connections are working. This will create an ssh tunnel if
230 it's required.
Garry Wang8c8dc972020-06-09 13:41:51 -0700231 """
232 self._servo = servo.Servo(servo_host=self,
233 servo_serial=self.servo_serial)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700234
Garry Wang8c8dc972020-06-09 13:41:51 -0700235 def initialize_dut_for_servo(self):
236 """This method will do some setup for dut control, e.g. setup
237 main servo_v4 device, and also testing the connection between servo
238 and DUT. As a side effect of testing the connection, all signals on
239 the target servo are reset to default values, and the USB stick is
Richard Barnette9a26ad62016-06-10 12:03:08 -0700240 set to the neutral (off) position.
241 """
Garry Wang8c8dc972020-06-09 13:41:51 -0700242 if not self._servo:
243 raise hosts.AutoservVerifyError('Servo object needs to be'
244 ' initialized before initialize'
245 ' DUT.')
Richard Barnette9a26ad62016-06-10 12:03:08 -0700246 timeout, _ = retry.timeout(
Garry Wang8c8dc972020-06-09 13:41:51 -0700247 self._servo.initialize_dut,
248 timeout_sec=self.INITIALIZE_SERVO_TIMEOUT_SECS)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700249 if timeout:
Garry Wang8c8dc972020-06-09 13:41:51 -0700250 raise hosts.AutoservVerifyError('Initialize dut for servo timed'
251 ' out.')
Richard Barnette9a26ad62016-06-10 12:03:08 -0700252
Richard Barnette9a26ad62016-06-10 12:03:08 -0700253 def disconnect_servo(self):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -0700254 """Disconnect our servo if it exists.
Richard Barnette9a26ad62016-06-10 12:03:08 -0700255
256 If we've previously successfully connected to our servo,
257 disconnect any established ssh tunnel, and set `self._servo`
258 back to `None`.
259 """
260 if self._servo:
261 # N.B. This call is safe even without a tunnel:
262 # rpc_server_tracker.disconnect() silently ignores
263 # unknown ports.
264 self.rpc_server_tracker.disconnect(self.servo_port)
265 self._servo = None
Fang Deng5d518f42013-08-02 14:04:32 -0700266
Andrew McRaef0679932020-08-13 09:15:23 +1000267 def _maybe_create_servod_ssh_tunnel_proxy(self):
268 """Create a xmlrpc proxy for use with a ssh tunnel.
269 A lock is used to safely create a singleton proxy.
270 """
271 with self._tunnel_proxy_lock:
272 if self._tunnel_proxy is None:
273 self._tunnel_proxy = self.rpc_server_tracker.xmlrpc_connect(
274 None,
275 self.servo_port,
276 ready_test_name=self.SERVO_READY_METHOD,
277 timeout_seconds=60,
278 request_timeout_seconds=3600,
279 server_desc=str(self))
280
Andrew McRaef0679932020-08-13 09:15:23 +1000281 def get_servod_server_proxy(self):
282 """Return a proxy if it exists; otherwise, create a new one.
283 A proxy can either be a ssh tunnel based proxy, or a httplib
284 based proxy.
Fang Deng5d518f42013-08-02 14:04:32 -0700285
286 @returns: An xmlrpclib.ServerProxy that is connected to the servod
287 server on the host.
Fang Deng5d518f42013-08-02 14:04:32 -0700288 """
Garry Wang11b5e872020-03-11 15:14:08 -0700289 if (servo_constants.ENABLE_SSH_TUNNEL_FOR_SERVO
290 and not self.is_localhost()):
Andrew McRaef0679932020-08-13 09:15:23 +1000291 # Check for existing ssh tunnel proxy.
292 if self._tunnel_proxy is None:
293 self._maybe_create_servod_ssh_tunnel_proxy()
294 return self._tunnel_proxy
Richard Barnette9a26ad62016-06-10 12:03:08 -0700295 else:
Andrew McRaef0679932020-08-13 09:15:23 +1000296 # xmlrpc/httplib is not thread-safe, so each thread must have its
297 # own separate proxy connection.
298 if not hasattr(self._local, "_per_thread_proxy"):
299 remote = 'http://%s:%s' % (self.hostname, self.servo_port)
Derek Beckettf73baca2020-08-19 15:08:47 -0700300 self._local._per_thread_proxy = six.moves.xmlrpc_client.ServerProxy(remote)
Andrew McRaef0679932020-08-13 09:15:23 +1000301 return self._local._per_thread_proxy
Wai-Hong Tam3a8a2552019-11-19 14:28:04 +0800302
Richard Barnette1edbb162016-11-01 11:47:50 -0700303 def verify(self, silent=False):
304 """Update the servo host and verify it's in a good state.
305
306 @param silent If true, suppress logging in `status.log`.
307 """
Richard Barnetteabbdc252018-07-26 16:57:42 -0700308 message = 'Beginning verify for servo host %s port %s serial %s'
309 message %= (self.hostname, self.servo_port, self.servo_serial)
310 self.record('INFO', None, None, message)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700311 try:
Richard Barnette1edbb162016-11-01 11:47:50 -0700312 self._repair_strategy.verify(self, silent)
Garry Wang11b5e872020-03-11 15:14:08 -0700313 self._servo_state = servo_constants.SERVO_STATE_WORKING
314 self.record('INFO', None, None,
315 'ServoHost verify set servo_state as WORKING')
Garry Wang63b8c382020-03-11 22:28:40 -0700316 except Exception as e:
Otabek Kasimov120b6fa2020-07-03 00:15:27 -0700317 if not self.is_localhost():
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700318 self._servo_state = self.determine_servo_state()
319 self.record('INFO', None, None,
320 'ServoHost verify set servo_state as %s'
321 % self._servo_state)
Garry Wang63b8c382020-03-11 22:28:40 -0700322 if self._is_critical_error(e):
323 raise
Fang Deng5d518f42013-08-02 14:04:32 -0700324
Garry Wang2b5eef92020-08-21 16:23:35 -0700325 def _get_default_usbkey_mount_path(self):
326 return '/media/servo_usb/%s' % self.servo_port
Fang Deng5d518f42013-08-02 14:04:32 -0700327
Garry Wang7b0e1b72020-03-25 19:08:59 -0700328 def get_image_name_from_usbkey(self, usbkey_dev):
329 """Mount usb drive and check ChromeOS image name on it if there is
330 one. This method assumes the image_usbkey_direction is already set
331 to servo side.
332
Garry Wang4b980202020-09-24 17:00:17 -0700333 @param usbkey_dev: usbkey dev path(e.g. /dev/sdb).
Garry Wang7b0e1b72020-03-25 19:08:59 -0700334
335 @returns: image_name on the usbkey, e.g. nami-release/R82.10138.0.0,
336 or empty string if no test image detected, or unexpected
337 error occurred.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700338 """
Garry Wang70e5d062020-04-03 18:01:05 -0700339 logging.info('Checking ChromeOS image name on usbkey.')
Garry Wang2b5eef92020-08-21 16:23:35 -0700340 mount_dst = self._get_default_usbkey_mount_path()
Garry Wang7b0e1b72020-03-25 19:08:59 -0700341 # Unmount if there is an existing stale mount.
Garry Wang2b5eef92020-08-21 16:23:35 -0700342 self._unmount_drive(mount_dst)
343 # ChromeOS root fs is in /dev/sdx3
344 mount_src = usbkey_dev + '3'
Garry Wang7b0e1b72020-03-25 19:08:59 -0700345 try:
Garry Wang2b5eef92020-08-21 16:23:35 -0700346 if not self._mount_drive(mount_src, mount_dst):
347 logging.debug('Unexpected error occurred on mount usb drive.')
Garry Wang7b0e1b72020-03-25 19:08:59 -0700348 return ''
Garry Wang70e5d062020-04-03 18:01:05 -0700349
350 release_content = self.run(
Garry Wang2b5eef92020-08-21 16:23:35 -0700351 'cat %s/etc/lsb-release' % mount_dst,
Garry Wang70e5d062020-04-03 18:01:05 -0700352 ignore_status=True).stdout.strip()
353
354 if not re.search(r'RELEASE_TRACK=.*test', release_content):
355 logging.info('The image on usbkey is not a test image')
356 return ''
357
358 return lsbrelease_utils.get_chromeos_release_builder_path(
359 lsb_release_content=release_content)
Garry Wang7b0e1b72020-03-25 19:08:59 -0700360 finally:
Garry Wang70e5d062020-04-03 18:01:05 -0700361 logging.debug('Image check compeleted, unmounting the usb drive.')
Garry Wang2b5eef92020-08-21 16:23:35 -0700362 self._unmount_drive(mount_dst)
Garry Wang7b0e1b72020-03-25 19:08:59 -0700363
Garry Wang2b5eef92020-08-21 16:23:35 -0700364 def _extract_firmware_image_from_usbkey(self, fw_dst):
365 """Extract firmware images from the usbkey on servo, this method
366 assumes there is already a ChromeOS test image staged on servo.
367
Garry Wang4b980202020-09-24 17:00:17 -0700368 @param fw_dst: the path that we'll copy firmware images to.
Garry Wang2b5eef92020-08-21 16:23:35 -0700369
370 @returns: a json format string of firmware manifest data.
371 """
372 usbkey_dev = self._probe_and_validate_usb_dev()
373 if not usbkey_dev:
374 raise hosts.AutoservRepairError('Unexpected error occurred when'
375 ' probe usbkey dev path, please check logs for detail.')
376
377 mount_dst = self._get_default_usbkey_mount_path()
378 # Unmount if there is an existing stale mount.
379 self._unmount_drive(mount_dst)
380 # ChromeOS root fs is in /dev/sdx3
381 mount_src = usbkey_dev + '3'
382 try:
383 if not self._mount_drive(mount_src, mount_dst):
384 raise hosts.AutoservRepairError('Failed to extract firmware'
385 ' image; Unable to mount %s.' % usbkey_dev,
386 'unable to mount usbkey')
387 updater_bin = os.path.join(mount_dst,
388 'usr/sbin/chromeos-firmwareupdate')
389 self.run('%s --unpack %s' % (updater_bin, fw_dst))
390 return self.run('%s --manifest' % updater_bin).stdout
391 finally:
392 self._unmount_drive(mount_dst)
393
394 def prepare_repair_firmware_image(self, fw_dst=None):
395 """Prepare firmware image on the servohost for auto repair process
396 to consume.
397
Garry Wang4b980202020-09-24 17:00:17 -0700398 @param fw_dst: the path that we want to store firmware image on
399 the servohost.
Garry Wang2b5eef92020-08-21 16:23:35 -0700400
401 @returns: A tuple that containes ec firmware image path and bios
402 firmware image path on the servohost, or None if type of
403 image is not available based on manifest and dut's model.
404 """
405 model = self.servo_model or self._dut_host_info.model
406 if not model:
407 raise hosts.AutoservRepairError(
408 'Could not determine DUT\'s model.',
409 'model infomation unknown')
410
411 if not fw_dst:
412 fw_dst = '/tmp/firmware_image/%s' % self.servo_port
413 # Cleanup and re-create dst path to have a fresh start.
414 self.run('rm -rf %s' % fw_dst)
415 self.run('mkdir -p %s' % fw_dst)
416
417 manifest = json.loads(self._extract_firmware_image_from_usbkey(fw_dst))
Garry Wang50b56c12020-09-24 17:26:52 -0700418 # For models that have packed $MODEL_signed variant, we want use the
419 # 'signed' variant once we get DVT devices, so try to read manifest
420 # from $MODEL_signed first.
421 build = manifest.get('%s_signed' % model) or manifest.get(model)
422 if not build:
Garry Wang2b5eef92020-08-21 16:23:35 -0700423 raise hosts.AutoservRepairError('Could not find firmware manifest'
424 ' for model:%s' % model, 'model manifest not found')
425 try:
Garry Wang50b56c12020-09-24 17:26:52 -0700426 ec_image = os.path.join(fw_dst, build['ec']['image'])
Garry Wang2b5eef92020-08-21 16:23:35 -0700427 except KeyError:
428 ec_image = None
429 try:
Garry Wang50b56c12020-09-24 17:26:52 -0700430 bios_image = os.path.join(fw_dst, build['host']['image'])
Garry Wang2b5eef92020-08-21 16:23:35 -0700431 except KeyError:
432 bios_image = None
433 if not ec_image and not bios_image:
434 raise hosts.AutoservRepairError('Could not find any firmware image'
435 ' for model:%s' % model, 'cannot find firmware image')
436 return ec_image, bios_image
Garry Wang7b0e1b72020-03-25 19:08:59 -0700437
Garry Wang4b980202020-09-24 17:00:17 -0700438 def flash_ap_firmware_via_servo(self, image):
439 """Flash AP firmware by use a provided image.
440
441 This is will be a short term enhanment for infra repair use, it use
442 'futility update' which will automatically determine various parameters
443 needed for flashrom, and will preserve the GBB, VPD, and HWID for
444 AP firmware update.
445 @TODO(xianuowang@) Remove this method once b/148403277 implemented.
446
447 @param image: the firmware image path on servohost.
448 """
449 cmd = 'futility update -i %s --servo_port=%s'
450 self.run(cmd % (image, self.servo_port), timeout=900)
451
Garry Wang70e5d062020-04-03 18:01:05 -0700452 def _probe_and_validate_usb_dev(self):
453 """This method probe the usb dev path by talking to servo, and then
454 validate the dev path is valid block device to servohost.
455 Possible output:
456 1. Encounter error during probe usb dev, returns empty string.
457 2. probe usb dev completed without error but cannot find usb dev,
458 raise AutoservRepairError.
459 3. probe usb dev find a usb dev path, but failed validation in this
460 method, raise AutoservRepairError.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700461
Garry Wang70e5d062020-04-03 18:01:05 -0700462 @returns: A string of usb dev path(e.g. '/dev/sdb'), or empty string
463 if unexpected error occurred during probe.
464 @raises: AutoservRepairError if servo couldn't probe the usb dev path
465 (servo.probe_host_usb_dev() returns empty string), or the dev path is
466 not valid block device to servohost.
Garry Wang7b0e1b72020-03-25 19:08:59 -0700467 """
468 logging.info('Validating image usbkey on servo.')
Garry Wang7b0e1b72020-03-25 19:08:59 -0700469 try:
Garry Wang70e5d062020-04-03 18:01:05 -0700470 usb_dev = self._servo.probe_host_usb_dev()
Garry Wang7b0e1b72020-03-25 19:08:59 -0700471 except Exception as e:
472 # We don't want any unexpected or transient servo communicating
473 # failure block usb repair, so capture all errors here.
474 logging.error(e, exc_info=True)
475 logging.error('Unexpected error occurred on get usbkey dev path,'
476 ' skipping usbkey validation.')
477 return ''
478
Garry Wang70e5d062020-04-03 18:01:05 -0700479 if usb_dev:
480 # probe_host_usb_dev() sometimes return stale record,
481 # so we need to make sure the path exists in fdisk.
Otabek Kasimov77bff672020-10-08 15:52:03 -0700482 validate_cmd = 'fdisk -l %s' % usb_dev
Garry Wang11441182020-06-16 18:34:14 -0700483 try:
Otabek Kasimov77bff672020-10-08 15:52:03 -0700484 resp = self.run(validate_cmd, ignore_status=True, timeout=30)
Garry Wang11441182020-06-16 18:34:14 -0700485 if resp.exit_status == 0:
486 return usb_dev
Garry Wang11441182020-06-16 18:34:14 -0700487 logging.error('%s is reported from "image_usbkey_dev" control'
488 ' but not detected by fdisk!', usb_dev)
489 except error.AutoservRunError as e:
490 if 'Timeout encountered' in str(e):
491 logging.warning('Timeout encountered during fdisk run,'
492 ' skipping usbkey validation.')
493 return ''
494 raise
Garry Wang70e5d062020-04-03 18:01:05 -0700495
496 raise hosts.AutoservRepairError(
497 'No usbkey detected on servo, the usbkey may be either missing'
498 ' or broken. Please replace usbkey on the servo and retry.',
499 'missing usbkey')
500
Otabek Kasimov4ea636e2020-04-14 23:35:06 -0700501 def is_ec_supported(self):
Garry Wang9b8f2342020-04-17 16:34:09 -0700502 """Check if ec is supported on the servo_board"""
Otabek Kasimov4ea636e2020-04-14 23:35:06 -0700503 if self.servo_board:
504 try:
505 frm_config = config.Config(self.servo_board, self.servo_model)
506 return frm_config.chrome_ec
507 except Exception as e:
508 logging.error('Unexpected error when read from firmware'
509 ' configs; %s', str(e))
510 return False
511
Garry Wang70e5d062020-04-03 18:01:05 -0700512 def validate_image_usbkey(self):
513 """This method first validate if there is a recover usbkey on servo
514 that accessible to servohost, and second check if a ChromeOS image is
515 already on the usb drive and return the image_name so we can avoid
516 unnecessary download and flash to the recover usbkey on servo.
517
518 Please note that, there is special error handling logic here:
519 1. If unexpected error happens, we return empty string. So repair
520 actions will not get blocked.
521 2. If no working usbkey present on servo, but no errors, we'll raise
522 AutoservRepairError here.
523
524 @returns: image_name on the usbkey, e.g. nami-release/R82.10138.0.0,
525 or empty string if no test image detected, or unexpected
526 error occurred.
527 @raises: AutoservRepairError if the usbkey is not detected on servo.
528 """
529 usb_dev = self._probe_and_validate_usb_dev()
530 if usb_dev:
531 return self.get_image_name_from_usbkey(usb_dev)
532 else:
533 return ''
Garry Wang7b0e1b72020-03-25 19:08:59 -0700534
Richard Barnette1edbb162016-11-01 11:47:50 -0700535 def repair(self, silent=False):
536 """Attempt to repair servo host.
537
538 @param silent If true, suppress logging in `status.log`.
539 """
Richard Barnetteabbdc252018-07-26 16:57:42 -0700540 message = 'Beginning repair for servo host %s port %s serial %s'
541 message %= (self.hostname, self.servo_port, self.servo_serial)
542 self.record('INFO', None, None, message)
Richard Barnette9a26ad62016-06-10 12:03:08 -0700543 try:
Richard Barnette1edbb162016-11-01 11:47:50 -0700544 self._repair_strategy.repair(self, silent)
Garry Wang11b5e872020-03-11 15:14:08 -0700545 self._servo_state = servo_constants.SERVO_STATE_WORKING
546 self.record('INFO', None, None,
547 'ServoHost repair set servo_state as WORKING')
Garry Wang464ff1e2019-07-18 17:20:34 -0700548 # If target is a labstation then try to withdraw any existing
549 # reboot request created by this servo because it passed repair.
550 if self.is_labstation():
551 self.withdraw_reboot_request()
Garry Wang63b8c382020-03-11 22:28:40 -0700552 except Exception as e:
Otabek Kasimov120b6fa2020-07-03 00:15:27 -0700553 if not self.is_localhost():
Otabek Kasimovc6f30412020-06-30 20:08:12 -0700554 self._servo_state = self.determine_servo_state()
555 self.record('INFO', None, None,
556 'ServoHost repair set servo_state as %s'
557 % self._servo_state)
Garry Wang63b8c382020-03-11 22:28:40 -0700558 if self._is_critical_error(e):
559 self.disconnect_servo()
560 self.stop_servod()
561 raise
562
Garry Wang63b8c382020-03-11 22:28:40 -0700563 def _is_critical_error(self, error):
564 if (isinstance(error, hosts.AutoservVerifyDependencyError)
565 and not error.is_critical()):
566 logging.warning('Non-critical verify failure(s) detected during'
567 ' verify/repair servo, servo connection will'
568 ' still up but may not fully functional.'
569 ' Some repair actions and servo depended'
570 ' tests may not run.')
571 return False
572 logging.info('Critical verify failure(s) detected during repair/verify'
573 ' servo. Disconnecting servo and stop servod, all repair '
574 'action and tests that depends on servo will not run.')
575 return True
Fang Deng5d518f42013-08-02 14:04:32 -0700576
Dan Shi4d478522014-02-14 13:46:32 -0800577 def get_servo(self):
578 """Get the cached servo.Servo object.
Fang Deng5d518f42013-08-02 14:04:32 -0700579
Dan Shi4d478522014-02-14 13:46:32 -0800580 @return: a servo.Servo object.
Dana Goyette353d1d92019-06-27 10:43:59 -0700581 @rtype: autotest_lib.server.cros.servo.servo.Servo
Fang Deng5d518f42013-08-02 14:04:32 -0700582 """
Dan Shi4d478522014-02-14 13:46:32 -0800583 return self._servo
584
Garry Wang79e9af62019-06-12 15:19:19 -0700585 def request_reboot(self):
586 """Request servohost to be rebooted when it's safe to by touch a file.
587 """
588 logging.debug('Request to reboot servohost %s has been created by '
Garry Wang464ff1e2019-07-18 17:20:34 -0700589 'servo with port # %s', self.hostname, self.servo_port)
Garry Wang79e9af62019-06-12 15:19:19 -0700590 self.run('touch %s' % self._reboot_file, ignore_status=True)
591
Garry Wang464ff1e2019-07-18 17:20:34 -0700592 def withdraw_reboot_request(self):
593 """Withdraw a servohost reboot request if exists by remove the flag
594 file.
595 """
596 logging.debug('Withdrawing request to reboot servohost %s that created'
597 ' by servo with port # %s if exists.',
598 self.hostname, self.servo_port)
599 self.run('rm -f %s' % self._reboot_file, ignore_status=True)
600
Garry Wangc1288cf2019-12-17 14:58:00 -0800601 def start_servod(self, quick_startup=False):
602 """Start the servod process on servohost.
603 """
Garry Wang2ac15ee2019-12-30 19:03:02 -0800604 # Skip if running on the localhost.(crbug.com/1038168)
605 if self.is_localhost():
606 logging.debug("Servohost is a localhost, skipping start servod.")
607 return
608
609 cmd = 'start servod'
Garry Wangc1288cf2019-12-17 14:58:00 -0800610 if self.servo_board:
Garry Wang2ac15ee2019-12-30 19:03:02 -0800611 cmd += ' BOARD=%s' % self.servo_board
Garry Wangc1288cf2019-12-17 14:58:00 -0800612 if self.servo_model:
613 cmd += ' MODEL=%s' % self.servo_model
Garry Wangc1288cf2019-12-17 14:58:00 -0800614 else:
Garry Wang2ac15ee2019-12-30 19:03:02 -0800615 logging.warning('Board for DUT is unknown; starting servod'
616 ' assuming a pre-configured board.')
617
618 cmd += ' PORT=%d' % self.servo_port
619 if self.servo_serial:
620 cmd += ' SERIAL=%s' % self.servo_serial
Garry Wangd7367482020-02-27 13:52:40 -0800621
622 # Start servod with dual_v4 if the DUT/servo from designated pools.
623 dut_host_info = self.get_dut_host_info()
624 if dut_host_info:
Otabek Kasimovf10a7052020-08-14 03:09:23 -0700625 # DUAL_V4: servo setup includes servo_micro and ccd_cr50
626 # connection to the DUT
627 is_dual_setup = False
Garry Wang11b5e872020-03-11 15:14:08 -0700628 if bool(dut_host_info.pools &
629 servo_constants.POOLS_SUPPORT_DUAL_V4):
Garry Wangd7367482020-02-27 13:52:40 -0800630 logging.debug('The DUT is detected in following designated'
631 ' pools %s,starting servod with DUAL_V4 option.',
Garry Wang11b5e872020-03-11 15:14:08 -0700632 servo_constants.POOLS_SUPPORT_DUAL_V4)
Otabek Kasimovf10a7052020-08-14 03:09:23 -0700633 is_dual_setup = True
634 elif dut_host_info.attributes.get('servo_setup') == 'DUAL_V4':
635 logging.debug('The DUT servo setup specified in config as '
636 ' "DUAL_V4"')
637 is_dual_setup = True
638 if is_dual_setup:
Garry Wangd7367482020-02-27 13:52:40 -0800639 cmd += ' DUAL_V4=1'
640
Garry Wangb5cee3e2020-09-16 14:58:13 -0700641 # Start servod with CONFIG=cr50.xml which required for some pools.
642 if self._require_cr50_servod_config():
643 cmd += ' CONFIG=cr50.xml'
644
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800645 # Remove the symbolic links from the logs. This helps ensure that
646 # a failed servod instantiation does not cause us to grab old logs
647 # by mistake.
648 self.remove_latest_log_symlinks()
Garry Wangcdd27b22020-01-13 14:59:11 -0800649 self.run(cmd, timeout=60)
Garry Wangc1288cf2019-12-17 14:58:00 -0800650
651 # There's a lag between when `start servod` completes and when
652 # the _ServodConnectionVerifier trigger can actually succeed.
653 # The call to time.sleep() below gives time to make sure that
654 # the trigger won't fail after we return.
655
656 # Normally servod on servo_v3 and labstation take ~10 seconds to ready,
657 # But in the rare case all servo on a labstation are in heavy use they
658 # may take ~30 seconds. So the timeout value will double these value,
659 # and we'll try quick start up when first time initialize servohost,
660 # and use standard start up timeout in repair.
661 if quick_startup:
Garry Wang11b5e872020-03-11 15:14:08 -0700662 timeout = servo_constants.SERVOD_QUICK_STARTUP_TIMEOUT
Garry Wangc1288cf2019-12-17 14:58:00 -0800663 else:
Garry Wang11b5e872020-03-11 15:14:08 -0700664 timeout = servo_constants.SERVOD_STARTUP_TIMEOUT
Garry Wangc1288cf2019-12-17 14:58:00 -0800665 logging.debug('Wait %s seconds for servod process fully up.', timeout)
666 time.sleep(timeout)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700667 # Cache the initial instance timestamp to check against servod restarts
668 self._initial_instance_ts = self.get_instance_logs_ts()
Garry Wangc1288cf2019-12-17 14:58:00 -0800669
Garry Wangc1288cf2019-12-17 14:58:00 -0800670 def stop_servod(self):
671 """Stop the servod process on servohost.
672 """
Garry Wang2ac15ee2019-12-30 19:03:02 -0800673 # Skip if running on the localhost.(crbug.com/1038168)
674 if self.is_localhost():
675 logging.debug("Servohost is a localhost, skipping stop servod.")
676 return
677
Garry Wangc1288cf2019-12-17 14:58:00 -0800678 logging.debug('Stopping servod on port %s', self.servo_port)
Garry Wangcdd27b22020-01-13 14:59:11 -0800679 self.run('stop servod PORT=%d' % self.servo_port,
680 timeout=60, ignore_status=True)
Garry Wangc1288cf2019-12-17 14:58:00 -0800681 logging.debug('Wait %s seconds for servod process fully teardown.',
Garry Wang11b5e872020-03-11 15:14:08 -0700682 servo_constants.SERVOD_TEARDOWN_TIMEOUT)
683 time.sleep(servo_constants.SERVOD_TEARDOWN_TIMEOUT)
Garry Wangc1288cf2019-12-17 14:58:00 -0800684
Garry Wangc1288cf2019-12-17 14:58:00 -0800685 def restart_servod(self, quick_startup=False):
686 """Restart the servod process on servohost.
687 """
688 self.stop_servod()
689 self.start_servod(quick_startup)
690
Garry Wangffbd2162020-04-17 16:13:48 -0700691 def _process_servodtool_error(self, response):
692 """Helper function to handle non-zero servodtool response.
693 """
694 if re.search(servo_constants.ERROR_MESSAGE_USB_HUB_NOT_COMPATIBLE,
Garry Wangad245002020-05-15 15:20:23 -0700695 response.stdout):
Garry Wangffbd2162020-04-17 16:13:48 -0700696 logging.error('The servo is not plugged on a usb hub that supports'
697 ' power-cycle!')
Garry Wang000c6c02020-05-11 21:27:23 -0700698 # change the flag so we can update this label in later process.
699 self.smart_usbhub = False
Garry Wangffbd2162020-04-17 16:13:48 -0700700 return
701
702 if re.search(servo_constants.ERROR_MESSAGE_DEVICE_NOT_FOUND %
703 self.servo_serial, response.stdout):
704 logging.error('No servo with serial %s found!', self.servo_serial)
705 return
706
707 logging.error('Unexpected error occurred from usbhub control, please'
708 ' file a bug and inform chrome-fleet-software@ team!')
709
Garry Wangffbd2162020-04-17 16:13:48 -0700710 def _get_servo_usb_devnum(self):
711 """Helper function to collect current usb devnum of servo.
712 """
Otabek Kasimov09192682020-06-01 18:17:44 -0700713 # TODO remove try-except when fix crbug.com/1087964
714 try:
715 cmd = 'servodtool device -s %s usb-path' % self.servo_serial
716 resp = self.run(cmd, ignore_status=True, timeout=30)
717 except Exception as e:
718 # Here we catch only timeout errors.
719 # Other errors is filtered by ignore_status=True
720 logging.debug('Attempt to get servo usb-path failed due to '
721 'timeout; %s', e)
722 return ''
723
Garry Wangffbd2162020-04-17 16:13:48 -0700724 if resp.exit_status != 0:
725 self._process_servodtool_error(resp)
726 return ''
727 usb_path = resp.stdout.strip()
728 logging.info('Usb path of servo %s is %s', self.servo_serial, usb_path)
729
730 resp = self.run('cat %s/devnum' % usb_path,
731 ignore_status=True)
732 if resp.exit_status != 0:
733 self._process_servodtool_error(resp)
734 return ''
735 return resp.stdout.strip()
736
Garry Wang358aad42020-08-02 20:56:04 -0700737 def reboot_servo_v3_on_need(self):
738 """Check and reboot servo_v3 based on below conditions.
739 1. If there is an update pending on reboot.
740 2. Servo_v3 has been up for more than 96 hours.
741 """
742 if self.get_board() != 'beaglebone_servo':
743 logging.info('Servo reboot is only applicable for servo V3.')
Otabek Kasimove6df8102020-07-21 20:15:25 -0700744 return
745
Garry Wang358aad42020-08-02 20:56:04 -0700746 update_pending_reboot = (self._check_update_status() ==
747 self.UPDATE_STATE.PENDING_REBOOT)
748 uptime_hours = float(self.check_uptime())/3600
749 logging.info('Uptime of servo_v3: %s hour(s)', uptime_hours)
750 long_up_time = uptime_hours > 96
751
752 # Skip reboot if neither condition are met.
753 if not (update_pending_reboot or long_up_time):
Otabek Kasimove6df8102020-07-21 20:15:25 -0700754 return
755
Garry Wang358aad42020-08-02 20:56:04 -0700756 if update_pending_reboot:
757 message = 'Starting reboot servo_v3 because an update is pending.'
758 reboot_method = self._post_update_reboot
759 elif long_up_time:
760 message = 'Starting reboot servo_v3 because uptime > 96 hours.'
761 reboot_method = self._servo_host_reboot
762 self.record('INFO', None, None, message)
763 logging.info(message)
Otabek Kasimove6df8102020-07-21 20:15:25 -0700764 try:
Garry Wang358aad42020-08-02 20:56:04 -0700765 reboot_method()
Otabek Kasimove6df8102020-07-21 20:15:25 -0700766 message = 'Servo_v3 reboot completed successfully.'
767 except Exception as e:
768 logging.debug("Fail to reboot servo_v3; %s", e)
769 message = ('Servo_v3 reboot failed, please check debug log '
770 'for details.')
771 logging.info(message)
772 self.record('INFO', None, None, message)
Garry Wangffbd2162020-04-17 16:13:48 -0700773
774 def _reset_servo(self):
775 logging.info('Resetting servo through smart usbhub.')
Otabek Kasimov09192682020-06-01 18:17:44 -0700776 # TODO remove try-except when fix crbug.com/1087964
777 try:
778 resp = self.run('servodtool device -s %s power-cycle' %
779 self.servo_serial, ignore_status=True,
780 timeout=30)
781 if resp.exit_status != 0:
782 self._process_servodtool_error(resp)
783 return False
784 except Exception as e:
785 # Here we catch only timeout errors.
786 # Other errors is filtered by ignore_status=True
787 logging.debug('Attempt to reset servo failed due to timeout;'
788 ' %s', e)
Garry Wangffbd2162020-04-17 16:13:48 -0700789 return False
790
791 logging.debug('Wait %s seconds for servo to come back from reset.',
792 servo_constants.SERVO_RESET_TIMEOUT_SECONDS)
793 time.sleep(servo_constants.SERVO_RESET_TIMEOUT_SECONDS)
Garry Wang000c6c02020-05-11 21:27:23 -0700794 # change the flag so we can update this label in later process.
795 self.smart_usbhub = True
Garry Wangffbd2162020-04-17 16:13:48 -0700796 return True
797
Garry Wangffbd2162020-04-17 16:13:48 -0700798 def reset_servo(self):
799 """Reset(power-cycle) the servo via smart usbhub.
800 """
801 if not self.is_labstation():
802 logging.info('Servo reset is not applicable to servo_v3.')
803 return
804
805 pre_reset_devnum = self._get_servo_usb_devnum()
806 logging.info('Servo usb devnum before reset: %s', pre_reset_devnum)
807 result = self._reset_servo()
808 if not result:
Garry Wangfd5c8b62020-06-08 15:36:54 -0700809 message = ('Failed to reset servo with serial: %s. (Please ignore'
810 ' this error if the DUT is not connected to a smart'
811 ' usbhub).' % self.servo_serial)
Garry Wangffbd2162020-04-17 16:13:48 -0700812 logging.warning(message)
813 self.record('INFO', None, None, message)
814 return
815
816 post_reset_devnum = self._get_servo_usb_devnum()
817 logging.info('Servo usb devnum after reset: %s', post_reset_devnum)
818 if not (pre_reset_devnum and post_reset_devnum):
819 message = ('Servo reset completed but unable to verify'
820 ' devnum change!')
821 elif pre_reset_devnum != post_reset_devnum:
822 message = ('Reset servo with serial %s completed successfully!'
823 % self.servo_serial)
824 else:
825 message = 'Servo reset completed but devnum is still not changed!'
826 logging.info(message)
827 self.record('INFO', None, None, message)
828
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800829 def _extract_compressed_logs(self, logdir, relevant_files):
830 """Decompress servod logs in |logdir|.
831
832 @param logdir: directory containing compressed servod logs.
833 @param relevant_files: list of files in |logdir| to consider.
834
835 @returns: tuple, (tarfiles, files) where
836 tarfiles: list of the compressed filenames that have been
837 extracted and deleted
838 files: list of the uncompressed files that were generated
839 """
840 # For all tar-files, first extract them to the directory, and
841 # then let the common flow handle them.
842 tarfiles = [cf for cf in relevant_files if
843 cf.endswith(self.COMPRESSION_SUFFIX)]
844 files = []
845 for f in tarfiles:
846 norm_name = os.path.basename(f)[:-len(self.COMPRESSION_SUFFIX)]
847 with tarfile.open(f) as tf:
848 # Each tarfile has only one member, as
849 # that's the compressed log.
850 member = tf.members[0]
851 # Manipulate so that it only extracts the basename, and not
852 # the directories etc.
853 member.name = norm_name
854 files.append(os.path.join(logdir, member.name))
855 tf.extract(member, logdir)
856 # File has been extracted: remove the compressed file.
857 os.remove(f)
858 return tarfiles, files
859
860 def _extract_mcu_logs(self, log_subdir):
861 """Extract MCU (EC, Cr50, etc) console output from servod debug logs.
862
863 Using the MCU_EXTRACTOR regex (above) extract and split out MCU console
864 lines from the logs to generate invidiual console logs e.g. after
865 this method, you can find an ec.txt and servo_v4.txt in |log_dir| if
866 those MCUs had any console input/output.
867
868 @param log_subdir: directory with log.DEBUG.txt main servod debug logs.
869 """
870 # Extract the MCU for each one. The MCU logs are only in the .DEBUG
871 # files
872 mcu_lines_file = os.path.join(log_subdir, 'log.DEBUG.txt')
873 if not os.path.exists(mcu_lines_file):
874 logging.info('No DEBUG logs found to extract MCU logs from.')
875 return
876 mcu_files = {}
877 mcu_file_template = '%s.txt'
878 with open(mcu_lines_file, 'r') as f:
879 for line in f:
880 match = self.MCU_EXTRACTOR.match(line)
881 if match:
882 mcu = match.group(self.MCU_GROUP).lower()
883 line = match.group(self.LINE_GROUP)
884 if mcu not in mcu_files:
885 mcu_file = os.path.join(log_subdir,
886 mcu_file_template % mcu)
887 mcu_files[mcu] = open(mcu_file, 'a')
888 fd = mcu_files[mcu]
889 fd.write(line + '\n')
890 for f in mcu_files:
891 mcu_files[f].close()
892
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800893 def remove_latest_log_symlinks(self):
894 """Remove the conveninence symlinks 'latest' servod logs."""
895 symlink_wildcard = '%s/latest*' % self.remote_log_dir
896 cmd = 'rm ' + symlink_wildcard
897 self.run(cmd, stderr_tee=None, ignore_status=True)
898
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700899 def probe_servod_restart(self, instance_ts, outdir):
900 """Grab servod logs from previous instances if part of this session.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800901
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700902 If since the last time this host called start_servod() servod crashed
903 and restarted, this helper finds those logs as well, and stores them
904 with the |OLD_LOG_SUFFIX| to investigate if necessary.
Prasad Vuppalapu5bd9da12020-03-31 01:46:47 +0000905
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700906 It also issues a panicinfo command to servo devices after the restart
907 to try and collect reboot information for debugging.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800908
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700909 @param instance_ts: the log timestamp that the current instance uses
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800910 @param outdir: directory to create a subdirectory into to place the
911 servod logs into.
912 """
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -0700913 if self._initial_instance_ts is None:
914 logging.info('No log timestamp grabbed successfully on servod '
915 'startup. Cannot check device restarts. Ignoring.')
916 return
917 if instance_ts == self._initial_instance_ts:
918 logging.debug('Servod appears to have run without restarting')
919 return
920 # Servod seems to have restarted (at least once). |_initial_instance_ts|
921 # is the first timestamp, and instance_ts is the current timestamp. Find
922 # all timestamps in between them, and grab the logs for each.
923 tss = self._find_instance_timestamps_between(self._initial_instance_ts,
924 instance_ts)
925 logging.info('Servod has restarted %d times between the start and the '
926 'end of this servo_host.', len(tss))
927 logging.info('This might be an issue. Will extract all logs from each '
928 'instance.')
929 logging.info('Logs that are not the currently running (about to turn '
930 'down) instance are maked with a .%s in their folder.',
931 self.OLD_LOG_SUFFIX)
932 for ts in tss:
933 self.get_instance_logs(ts, outdir, old=True)
934 # Lastly, servod has restarted due to a potential issue. Try to get
935 # panic information from servo micro and servo v4 for the current logs.
936 # This can only happen if the |_servo| attribute is initialized.
937 if self._servo:
938 for mcu in ['servo_micro', 'servo_v4']:
939 ctrl = '%s_uart_cmd' % mcu
940 if self._servo.has_control(ctrl):
941 logging.info('Trying to retrieve %r panicinfo into logs',
942 mcu)
943 try:
944 self._servo.set_nocheck(ctrl, 'panicinfo')
945 except error.TestFail as e:
946 logging.error('Failed to generate panicinfo for %r '
947 'logs. %s', mcu, str(e))
948
949 def _find_instance_timestamps_between(self, start_ts, end_ts):
950 """Find all log timestamps between [start_ts, end_ts).
951
952 @param start_ts: str, earliest log timestamp of interest
953 @param end_ts: str, latest log timestamp of interest
954
955 @returns: list, all timestamps between start_ts and end_ts, end_ts
956 exclusive, on the servo_host. An empty list on errors
957 """
958 # Simply get all timestamp, and then sort and remove
959 cmd = 'ls %s' % self.remote_log_dir
960 res = self.run(cmd, stderr_tee=None, ignore_status=True)
961 if res.exit_status != 0:
962 # Here we failed to find anything.
963 logging.info('Failed to find remote servod logs. Ignoring.')
964 return []
965 logfiles = res.stdout.strip().split()
966 timestamps = set()
967 for logfile in logfiles:
968 ts_match = self.TS_EXTRACTOR.match(logfile)
969 if not ts_match:
970 # Simply ignore files that fail the check. It might be the
971 # 'latest' symlinks or random files.
972 continue
973 timestamps.add(ts_match.group(self.TS_GROUP))
974 # At this point we have all unique timestamps.
975 timestamps = sorted(timestamps)
976 for ts in [start_ts, end_ts]:
977 if ts not in timestamps:
978 logging.error('Timestamp %r not in servod logs. Cannot query '
979 'for timestamps in between %r and %r', ts,
980 start_ts, end_ts)
981 return []
982 return timestamps[timestamps.index(start_ts):timestamps.index(end_ts)]
983
984 def get_instance_logs_ts(self):
985 """Retrieve the currently running servod instance's log timestamp
986
987 @returns: str, timestamp for current instance, or None on failure
988 """
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -0800989 # First, extract the timestamp. This cmd gives the real filename of
990 # the latest aka current log file.
991 cmd = ('if [ -f %(dir)s/latest.DEBUG ];'
992 'then realpath %(dir)s/latest.DEBUG;'
993 'elif [ -f %(dir)s/latest ];'
994 'then realpath %(dir)s/latest;'
995 'else exit %(code)d;'
996 'fi' % {'dir': self.remote_log_dir,
997 'code': self.NO_SYMLINKS_CODE})
998 res = self.run(cmd, stderr_tee=None, ignore_status=True)
999 if res.exit_status != 0:
1000 if res.exit_status == self.NO_SYMLINKS_CODE:
1001 logging.warning('servod log latest symlinks not found. '
1002 'This is likely due to an error starting up '
1003 'servod. Ignoring..')
1004 else:
1005 logging.warning('Failed to find servod logs on servo host.')
1006 logging.warning(res.stderr.strip())
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001007 return None
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001008 fname = os.path.basename(res.stdout.strip())
1009 # From the fname, ought to extract the timestamp using the TS_EXTRACTOR
Ruben Rodriguez Buchillone9aa2b02020-03-04 12:14:28 -08001010 ts_match = self.TS_EXTRACTOR.match(fname)
1011 if not ts_match:
1012 logging.warning('Failed to extract timestamp from servod log file '
1013 '%r. Skipping. The servo host is using outdated '
1014 'servod logging and needs to be updated.', fname)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001015 return None
1016 return ts_match.group(self.TS_GROUP)
1017
1018 def get_instance_logs(self, instance_ts, outdir, old=False):
1019 """Collect all logs with |instance_ts| and dump into a dir in |outdir|
1020
1021 This method first collects all logs on the servo_host side pertaining
1022 to this servod instance (port, instatiation). It glues them together
1023 into combined log.[level].txt files and extracts all available MCU
1024 console I/O from the logs into individual files e.g. servo_v4.txt
1025
1026 All the output can be found in a directory inside |outdir| that
1027 this generates based on |LOG_DIR|, the servod port, and the instance
1028 timestamp on the servo_host side.
1029
1030 @param instance_ts: log timestamp to grab logfiles for
1031 @param outdir: directory to create a subdirectory into to place the
1032 servod logs into.
1033 @param old: bool, whether to append |OLD_LOG_SUFFIX| to output dir
1034 """
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001035 # Create the local results log dir.
1036 log_dir = os.path.join(outdir, '%s_%s.%s' % (self.LOG_DIR,
1037 str(self.servo_port),
1038 instance_ts))
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001039 if old:
Garry Wang22f2e842020-09-09 20:19:19 -07001040 log_dir = '%s.%s' % (log_dir, self.OLD_LOG_SUFFIX)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001041 logging.info('Saving servod logs to %r.', log_dir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001042 os.mkdir(log_dir)
1043 # Now, get all files with that timestamp.
1044 cmd = 'find %s -maxdepth 1 -name "log.%s*"' % (self.remote_log_dir,
1045 instance_ts)
1046 res = self.run(cmd, stderr_tee=None, ignore_status=True)
1047 files = res.stdout.strip().split()
1048 try:
1049 self.get_file(files, log_dir, try_rsync=False)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001050 if not os.listdir(log_dir):
1051 logging.info('No servod logs retrieved. Ignoring, and removing '
1052 '%r again.', log_dir)
1053 os.rmdir(log_dir)
1054 return
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001055 except error.AutoservRunError as e:
1056 result = e.result_obj
1057 if result.exit_status != 0:
1058 stderr = result.stderr.strip()
1059 logging.warning("Couldn't retrieve servod logs. Ignoring: %s",
1060 stderr or '\n%s' % result)
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001061 # Remove the log_dir as nothing was added to it.
1062 os.rmdir(log_dir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001063 return
1064 local_files = [os.path.join(log_dir, f) for f in os.listdir(log_dir)]
1065 # TODO(crrev.com/c/1793030): remove no-level case once CL is pushed
1066 for level_name in ('DEBUG', 'INFO', 'WARNING', ''):
1067 # Create the joint files for each loglevel. i.e log.DEBUG
1068 joint_file = self.JOINT_LOG_PREFIX
1069 if level_name:
1070 joint_file = '%s.%s' % (self.JOINT_LOG_PREFIX, level_name)
1071 # This helps with some online tools to avoid complaints about an
1072 # unknown filetype.
1073 joint_file = joint_file + '.txt'
1074 joint_path = os.path.join(log_dir, joint_file)
1075 files = [f for f in local_files if level_name in f]
1076 if not files:
1077 # TODO(crrev.com/c/1793030): remove no-level case once CL
1078 # is pushed
1079 continue
1080 # Extract compressed logs if any.
1081 compressed, extracted = self._extract_compressed_logs(log_dir,
1082 files)
1083 files = list(set(files) - set(compressed))
1084 files.extend(extracted)
1085 # Need to sort. As they all share the same timestamp, and
1086 # loglevel, the index itself is sufficient. The highest index
1087 # is the oldest file, therefore we need a descending sort.
1088 def sortkey(f, level=level_name):
1089 """Custom sortkey to sort based on rotation number int."""
1090 if f.endswith(level_name): return 0
1091 return int(f.split('.')[-1])
1092
1093 files.sort(reverse=True, key=sortkey)
1094 # Just rename the first file rather than building from scratch.
1095 os.rename(files[0], joint_path)
1096 with open(joint_path, 'a') as joint_f:
1097 for logfile in files[1:]:
1098 # Transfer the file to the joint file line by line.
1099 with open(logfile, 'r') as log_f:
1100 for line in log_f:
1101 joint_f.write(line)
1102 # File has been written over. Delete safely.
1103 os.remove(logfile)
1104 # Need to remove all files form |local_files| so we don't
1105 # analyze them again.
1106 local_files = list(set(local_files) - set(files) - set(compressed))
1107 # Lastly, extract MCU logs from the joint logs.
1108 self._extract_mcu_logs(log_dir)
1109
Garry Wang79e9af62019-06-12 15:19:19 -07001110 def _lock(self):
1111 """lock servohost by touching a file.
1112 """
1113 logging.debug('Locking servohost %s by touching %s file',
1114 self.hostname, self._lock_file)
1115 self.run('touch %s' % self._lock_file, ignore_status=True)
Garry Wang7c00b0f2019-06-25 17:28:17 -07001116 self._is_locked = True
Garry Wang79e9af62019-06-12 15:19:19 -07001117
Garry Wang79e9af62019-06-12 15:19:19 -07001118 def _unlock(self):
1119 """Unlock servohost by removing the lock file.
1120 """
1121 logging.debug('Unlocking servohost by removing %s file',
1122 self._lock_file)
1123 self.run('rm %s' % self._lock_file, ignore_status=True)
Garry Wang7c00b0f2019-06-25 17:28:17 -07001124 self._is_locked = False
Garry Wang79e9af62019-06-12 15:19:19 -07001125
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001126 def close(self):
Congbin Guofc3b8962019-03-22 17:38:46 -07001127 """Close the associated servo and the host object."""
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001128 # NOTE: throughout this method there are multiple attempts to catch
1129 # all errors. This is WAI as log grabbing should not fail tests.
1130 # However, the goal is to catch and handle/process all errors, thus
1131 # we print the traceback and ask for a bug.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001132 if self._closed:
1133 logging.debug('ServoHost is already closed.')
1134 return
Garry Wang22f2e842020-09-09 20:19:19 -07001135
1136 # Only attempt ssh related actions if servohost is sshable. We call
1137 # check_cached_up_status() first because it's lightweighted and return
1138 # much faster in the case servohost is down, however, we still want
1139 # to call is_up() later since check_cached_up_status() is ping based check
1140 # and not guarantee the servohost is sshable.
1141 servo_host_ready = self.check_cached_up_status() and self.is_up()
1142
1143 if servo_host_ready:
1144 instance_ts = self.get_instance_logs_ts()
1145 else:
1146 logging.info('Servohost is down, will skip servod log collecting.')
1147 instance_ts = None
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001148 # TODO(crbug.com/1011516): once enabled, remove the check against
1149 # localhost and instead check against log-rotiation enablement.
1150 logs_available = (instance_ts is not None and
1151 self.job and
1152 not self.is_localhost())
1153 if logs_available:
1154 # Probe whether there was a servod restart, and grab those old
1155 # logs as well.
1156 try:
1157 self.probe_servod_restart(instance_ts, self.job.resultdir)
1158 except (error.AutoservRunError, error.TestFail) as e:
1159 logging.info('Failed to grab servo logs due to: %s. '
1160 'This error is forgiven.', str(e))
1161 except Exception as e:
1162 logging.error('Unexpected error probing for old logs. %s. '
1163 'Forgiven. Please file a bug and fix or catch '
1164 'in log probing function', str(e),
1165 exc_info=True)
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001166 if self._servo:
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001167 outdir = None if not self.job else self.job.resultdir
Congbin Guo2e5e2a22018-07-27 10:32:48 -07001168 # In some cases when we run as lab-tools, the job object is None.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001169 self._servo.close(outdir)
1170
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001171 if logs_available:
1172 # Grab current (not old like above) logs after the servo instance
1173 # was closed out.
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001174 try:
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001175 self.get_instance_logs(instance_ts, self.job.resultdir)
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001176 except error.AutoservRunError as e:
1177 logging.info('Failed to grab servo logs due to: %s. '
1178 'This error is forgiven.', str(e))
Ruben Rodriguez Buchillon5bac3062020-03-25 21:32:58 -07001179 except Exception as e:
1180 logging.error('Unexpected error grabbing servod logs. %s. '
1181 'Forgiven. Please file a bug and fix or catch '
1182 'in log grabbing function', str(e), exc_info=True)
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001183
Garry Wang22f2e842020-09-09 20:19:19 -07001184 if self._is_locked and servo_host_ready:
Garry Wang7c00b0f2019-06-25 17:28:17 -07001185 # Remove the lock if the servohost has been locked.
Garry Wang79e9af62019-06-12 15:19:19 -07001186 try:
1187 self._unlock()
1188 except error.AutoservSSHTimeout:
1189 logging.error('Unlock servohost failed due to ssh timeout.'
1190 ' It may caused by servohost went down during'
1191 ' the task.')
Garry Wangc1288cf2019-12-17 14:58:00 -08001192 # We want always stop servod after task to minimum the impact of bad
1193 # servod process interfere other servods.(see crbug.com/1028665)
Garry Wang22f2e842020-09-09 20:19:19 -07001194 if servo_host_ready:
1195 try:
1196 self.stop_servod()
1197 except error.AutoservRunError as e:
1198 logging.info(
1199 "Failed to stop servod due to:\n%s\n"
1200 "This error is forgiven.", str(e))
Garry Wangc1288cf2019-12-17 14:58:00 -08001201
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001202 super(ServoHost, self).close()
Ruben Rodriguez Buchillon93084d02020-01-21 15:17:36 -08001203 # Mark closed.
1204 self._closed = True
Congbin Guoa1f9cba2018-07-03 11:36:59 -07001205
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001206 def get_servo_state(self):
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001207 return self._servo_state
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001208
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001209 def _get_host_metrics_data(self):
1210 return {'port': self.servo_port,
Otabek Kasimov0ea47362020-07-11 20:55:09 -07001211 'host': self.get_dut_hostname() or self.hostname,
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001212 'board': self.servo_board or ''}
1213
1214 def _is_servo_device_connected(self, servo_type, serial):
1215 """Check if device is connected to the labstation.
1216
1217 Works for all servo devices connected to the labstation.
1218 For servo_v3 please use 'self._is_servo_board_present_on_servo_v3'
1219
1220 @param servo_type: The type of servo device. Expecting value can be
1221 servo_v4 or servo_micro.
1222 @param serial: The serial number of the device to detect it.
1223 """
1224 vid_pid = self.SERVO_VID_PID.get(servo_type)
1225 if not vid_pid or not serial:
1226 # device cannot detected without VID/PID or serial number
1227 return False
1228 logging.debug('Started to detect %s', servo_type)
1229 try:
1230 cmd = 'lsusb -v -d %s |grep iSerial |grep %s' % (vid_pid, serial)
1231 result = self.run(cmd, ignore_status=True, timeout=30)
1232 if result.exit_status == 0 and result.stdout.strip():
1233 logging.debug('The %s is plugged in to the host.', servo_type)
1234 return True
1235 logging.debug('%s device is not detected; %s', servo_type, result)
1236 return False
1237 except Exception as e:
1238 # can be triggered by timeout issue due running the script
1239 metrics.Counter(
1240 'chromeos/autotest/repair/servo_detection/timeout'
1241 ).increment(fields=self._get_host_metrics_data())
1242 logging.error('%s device is not detected; %s', servo_type, str(e))
1243 return None
1244
1245 def _is_servo_board_present_on_servo_v3(self):
1246 """Check if servo board is detected on servo_v3"""
1247 vid_pids = self.SERVO_VID_PID['servo_v3']
1248 if not vid_pids or len(vid_pids) == 0:
1249 # device cannot detected without VID/PID
1250 return False
1251 logging.debug('Started to detect servo board on servo_v3')
1252 not_detected = 'The servo board is not detected on servo_v3'
1253 try:
1254 cmd = 'lsusb | grep "%s"' % "\|".join(vid_pids)
1255 result = self.run(cmd, ignore_status=True, timeout=30)
1256 if result.exit_status == 0 and result.stdout.strip():
1257 logging.debug('The servo board is detected on servo_v3')
1258 return True
1259 logging.debug('%s; %s', not_detected, result)
1260 return False
1261 except Exception as e:
1262 # can be triggered by timeout issue due running the script
1263 metrics.Counter(
1264 'chromeos/autotest/repair/servo_detection/timeout'
1265 ).increment(fields=self._get_host_metrics_data())
1266 logging.error('%s; %s', not_detected, str(e))
1267 return None
1268
Otabek Kasimov120b6fa2020-07-03 00:15:27 -07001269 def _is_main_device_not_detected_on_servo_v4(self):
1270 """Check if servod cannot find main device on servo.
1271
1272 The check based on reading servod logs for servo_v4.
1273 """
1274 if not self._initial_instance_ts:
1275 # latest log not found
1276 return False
1277 logging.debug('latest log for servod created at %s',
1278 self._initial_instance_ts)
1279 try:
1280 log_created = calendar.timegm(time.strptime(
1281 self._initial_instance_ts,
1282 "%Y-%m-%d--%H-%M-%S.%f"))
1283 except ValueError as e:
1284 logging.debug('Cannot read time from log file name: %s',
1285 self._initial_instance_ts)
1286 return False
1287 min_time_created = calendar.timegm(time.gmtime())
1288 if min_time_created > log_created + 3600:
1289 # the log file is old we cannot use it
1290 logging.debug('log file was created more than hour ago, too old')
1291 return False
1292 logging.debug('latest log was created not longer then 1 hour ago')
1293
1294 # check if servod can detect main device by servo_v4
1295 message = 'ERROR - No servo micro or CCD detected for board'
1296 cmd = ('cat /var/log/servod_%s/log.%s.INFO |grep "%s"'
1297 % (self.servo_port, self._initial_instance_ts, message))
1298 result = self.run(cmd, ignore_status=True)
1299 if result.stdout.strip():
1300 logging.info('Servod cannot detect main device on the servo; '
1301 'Can be caused by bad hardware of servo or '
1302 'issue on the DUT side.')
1303 return True
1304 logging.debug('The main device is detected')
1305 return False
1306
Garry Wangb5cee3e2020-09-16 14:58:13 -07001307 def _require_cr50_servod_config(self):
1308 """Check whether we need start servod with CONFIG=cr50.xml"""
1309 dut_host_info = self.get_dut_host_info()
1310 if not dut_host_info:
1311 return False
1312 for pool in dut_host_info.pools:
1313 if pool.startswith(servo_constants.CR50_CONFIG_POOL_PREFIX):
1314 return True
1315 return False
1316
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001317 def get_verifier_state(self, tag):
Otabek Kasimov15963492020-06-23 21:10:51 -07001318 """Return the state of servo verifier.
1319
1320 @returns: bool or None
1321 """
1322 return self._repair_strategy.verifier_is_good(tag)
1323
1324 def determine_servo_state(self):
1325 """Determine servo state based on the failed verifier.
1326
1327 @returns: servo state value
1328 The state detecting based on first fail verifier or collecting of
1329 them.
1330 """
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001331 ssh = self.get_verifier_state('servo_ssh')
1332 disk_space = self.get_verifier_state('disk_space')
1333 start_servod = self.get_verifier_state('servod_job')
1334 create_servo = self.get_verifier_state('servod_connection')
1335 init_servo = self.get_verifier_state('servod_control')
1336 dut_connected = self.get_verifier_state('dut_connected')
1337 pwr_button = self.get_verifier_state('pwr_button')
1338 lid_open = self.get_verifier_state('lid_open')
1339 ec_board = self.get_verifier_state('ec_board')
1340 ccd_testlab = self.get_verifier_state('ccd_testlab')
Otabek Kasimov15963492020-06-23 21:10:51 -07001341
1342 if not ssh:
1343 return servo_constants.SERVO_STATE_NO_SSH
1344
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001345 if (start_servod == hosts.VERIFY_FAILED
1346 or create_servo == hosts.VERIFY_FAILED):
Otabek Kasimov066bdb82020-08-12 15:57:44 -07001347 # sometimes servo can start with out present servo
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001348 if self.is_labstation():
1349 if not self.servo_serial:
1350 return servo_constants.SERVO_STATE_WRONG_CONFIG
1351 if self._is_servo_device_connected(
1352 'servo_v4',
1353 self.servo_serial) == False:
1354 return servo_constants.SERVO_STATE_NOT_CONNECTED
1355 elif self._is_servo_board_present_on_servo_v3() == False:
1356 return servo_constants.SERVO_STATE_NOT_CONNECTED
Otabek Kasimov066bdb82020-08-12 15:57:44 -07001357
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001358 if dut_connected == hosts.VERIFY_FAILED:
1359 if pwr_button == hosts.VERIFY_SUCCESS:
Otabek Kasimova7eb4dc2020-09-16 10:25:17 -07001360 # unexpected case
1361 metrics.Counter(
1362 'chromeos/autotest/repair/servo_unexpected/pwr_button'
1363 ).increment(fields=self._get_host_metrics_data())
1364 return servo_constants.SERVO_STATE_DUT_NOT_CONNECTED
1365
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001366 if start_servod == hosts.VERIFY_FAILED:
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001367 return servo_constants.SERVO_STATE_SERVOD_ISSUE
1368
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001369 if create_servo == hosts.VERIFY_FAILED:
Otabek Kasimov120b6fa2020-07-03 00:15:27 -07001370 if (self.is_labstation()
1371 and self._is_main_device_not_detected_on_servo_v4()):
1372 servo_type = None
1373 if self.get_dut_host_info():
1374 servo_type = self.get_dut_host_info().get_label_value(
1375 servo_constants.SERVO_TYPE_LABEL_PREFIX)
1376 if servo_type and 'servo_micro' in servo_type:
1377 serial = self.get_servo_micro_serial_number()
1378 logging.debug('servo_micro serial: %s', serial)
1379 if self._is_servo_device_detected('servo_micro',
1380 serial):
1381 return servo_constants.SERVO_STATE_BAD_RIBBON_CABLE
1382 # Device can be not detected because of DUT
1383 # TODO (otabek) update after b/159755652 and b/159754985
1384 metrics.Counter(
1385 'chromeos/autotest/repair/servo_state/needs_replacement'
1386 ).increment(fields=self._get_host_metrics_data())
1387 elif not self.is_labstation():
1388 # Here need logic to check if flex cable is connected
1389 pass
1390
Otabek Kasimov15963492020-06-23 21:10:51 -07001391 # one of the reason why servo can not initialized
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001392 if ccd_testlab == hosts.VERIFY_FAILED:
Otabek Kasimov15963492020-06-23 21:10:51 -07001393 return servo_constants.SERVO_STATE_CCD_TESTLAB_ISSUE
1394
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001395 if (create_servo == hosts.VERIFY_FAILED
1396 or init_servo == hosts.VERIFY_FAILED):
Otabek Kasimov15963492020-06-23 21:10:51 -07001397 return servo_constants.SERVO_STATE_SERVOD_ISSUE
1398
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001399 if ec_board == hosts.VERIFY_FAILED:
Otabek Kasimov015c15c2020-08-20 00:40:42 -07001400 return servo_constants.SERVO_STATE_EC_BROKEN
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001401 if pwr_button == hosts.VERIFY_FAILED:
Otabek Kasimov15963492020-06-23 21:10:51 -07001402 return servo_constants.SERVO_STATE_BAD_RIBBON_CABLE
Otabek Kasimov8bb09912020-10-01 14:44:57 -07001403 if lid_open == hosts.VERIFY_FAILED:
Otabek Kasimov15963492020-06-23 21:10:51 -07001404 return servo_constants.SERVO_STATE_LID_OPEN_FAILED
Otabek Kasimov15963492020-06-23 21:10:51 -07001405
Otabek Kasimov15963492020-06-23 21:10:51 -07001406 metrics.Counter(
1407 'chromeos/autotest/repair/unknown_servo_state'
Otabek Kasimovc6f30412020-06-30 20:08:12 -07001408 ).increment(fields=self._get_host_metrics_data())
Otabek Kasimov15963492020-06-23 21:10:51 -07001409 logging.info('We do not have special state for this failure yet :)')
1410 return servo_constants.SERVO_STATE_BROKEN
1411
Otabek Kasimovcc9738e2020-02-14 16:17:15 -08001412
Richard Barnetteea3e4602016-06-10 12:36:41 -07001413def make_servo_hostname(dut_hostname):
1414 """Given a DUT's hostname, return the hostname of its servo.
1415
1416 @param dut_hostname: hostname of a DUT.
1417
1418 @return hostname of the DUT's servo.
1419
1420 """
1421 host_parts = dut_hostname.split('.')
1422 host_parts[0] = host_parts[0] + '-servo'
1423 return '.'.join(host_parts)
1424
1425
1426def servo_host_is_up(servo_hostname):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001427 """Given a servo host name, return if it's up or not.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001428
1429 @param servo_hostname: hostname of the servo host.
1430
1431 @return True if it's up, False otherwise
1432 """
1433 # Technically, this duplicates the SSH ping done early in the servo
1434 # proxy initialization code. However, this ping ends in a couple
1435 # seconds when if fails, rather than the 60 seconds it takes to decide
1436 # that an SSH ping has timed out. Specifically, that timeout happens
1437 # when our servo DNS name resolves, but there is no host at that IP.
1438 logging.info('Pinging servo host at %s', servo_hostname)
1439 ping_config = ping_runner.PingConfig(
1440 servo_hostname, count=3,
1441 ignore_result=True, ignore_status=True)
1442 return ping_runner.PingRunner().ping(ping_config).received > 0
1443
1444
Richard Barnettee519dcd2016-08-15 17:37:17 -07001445def _map_afe_board_to_servo_board(afe_board):
1446 """Map a board we get from the AFE to a servo appropriate value.
1447
1448 Many boards are identical to other boards for servo's purposes.
1449 This function makes that mapping.
1450
1451 @param afe_board string board name received from AFE.
1452 @return board we expect servo to have.
1453
1454 """
1455 KNOWN_SUFFIXES = ['-freon', '_freon', '_moblab', '-cheets']
1456 BOARD_MAP = {'gizmo': 'panther'}
1457 mapped_board = afe_board
1458 if afe_board in BOARD_MAP:
1459 mapped_board = BOARD_MAP[afe_board]
1460 else:
1461 for suffix in KNOWN_SUFFIXES:
1462 if afe_board.endswith(suffix):
1463 mapped_board = afe_board[0:-len(suffix)]
1464 break
1465 if mapped_board != afe_board:
1466 logging.info('Mapping AFE board=%s to %s', afe_board, mapped_board)
1467 return mapped_board
1468
1469
Prathmesh Prabhub4810232018-09-07 13:24:08 -07001470def get_servo_args_for_host(dut_host):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001471 """Return servo data associated with a given DUT.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001472
Richard Barnetteea3e4602016-06-10 12:36:41 -07001473 @param dut_host Instance of `Host` on which to find the servo
1474 attributes.
Prathmesh Prabhuf605dd32018-08-28 17:09:04 -07001475 @return `servo_args` dict with host and an optional port.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001476 """
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001477 info = dut_host.host_info_store.get()
Derek Beckettf73baca2020-08-19 15:08:47 -07001478 servo_args = {k: v for k, v in six.iteritems(info.attributes)
Garry Wang11b5e872020-03-11 15:14:08 -07001479 if k in servo_constants.SERVO_ATTR_KEYS}
Richard Barnetteea3e4602016-06-10 12:36:41 -07001480
Garry Wang11b5e872020-03-11 15:14:08 -07001481 if servo_constants.SERVO_PORT_ATTR in servo_args:
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001482 try:
Garry Wang11b5e872020-03-11 15:14:08 -07001483 servo_args[servo_constants.SERVO_PORT_ATTR] = int(
1484 servo_args[servo_constants.SERVO_PORT_ATTR])
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001485 except ValueError:
1486 logging.error('servo port is not an int: %s',
Garry Wang11b5e872020-03-11 15:14:08 -07001487 servo_args[servo_constants.SERVO_PORT_ATTR])
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001488 # Reset servo_args because we don't want to use an invalid port.
Garry Wang11b5e872020-03-11 15:14:08 -07001489 servo_args.pop(servo_constants.SERVO_HOST_ATTR, None)
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001490
1491 if info.board:
Garry Wang11b5e872020-03-11 15:14:08 -07001492 servo_board = _map_afe_board_to_servo_board(info.board)
1493 servo_args[servo_constants.SERVO_BOARD_ATTR] = servo_board
Nick Sanders2f3c9852018-10-24 12:10:24 -07001494 if info.model:
Garry Wang11b5e872020-03-11 15:14:08 -07001495 servo_args[servo_constants.SERVO_MODEL_ATTR] = info.model
1496 return servo_args if servo_constants.SERVO_HOST_ATTR in servo_args else None
Richard Barnetteea3e4602016-06-10 12:36:41 -07001497
1498
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001499def _tweak_args_for_ssp_moblab(servo_args):
Garry Wang11b5e872020-03-11 15:14:08 -07001500 if (servo_args[servo_constants.SERVO_HOST_ATTR]
1501 in ['localhost', '127.0.0.1']):
1502 servo_args[servo_constants.SERVO_HOST_ATTR] = _CONFIG.get_config_value(
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001503 'SSP', 'host_container_ip', type=str, default=None)
1504
1505
Dan Shi023aae32016-05-25 11:13:01 -07001506def create_servo_host(dut, servo_args, try_lab_servo=False,
Gregory Nisbetde13e2a2019-12-09 22:44:00 -08001507 try_servo_repair=False, dut_host_info=None):
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001508 """Create a ServoHost object for a given DUT, if appropriate.
Dan Shi4d478522014-02-14 13:46:32 -08001509
Richard Barnette9a26ad62016-06-10 12:03:08 -07001510 This function attempts to create and verify or repair a `ServoHost`
1511 object for a servo connected to the given `dut`, subject to various
1512 constraints imposed by the parameters:
1513 * When the `servo_args` parameter is not `None`, a servo
1514 host must be created, and must be checked with `repair()`.
1515 * Otherwise, if a servo exists in the lab and `try_lab_servo` is
1516 true:
1517 * If `try_servo_repair` is true, then create a servo host and
1518 check it with `repair()`.
1519 * Otherwise, if the servo responds to `ping` then create a
1520 servo host and check it with `verify()`.
Fang Denge545abb2014-12-30 18:43:47 -08001521
Richard Barnette9a26ad62016-06-10 12:03:08 -07001522 In cases where `servo_args` was not `None`, repair failure
1523 exceptions are passed back to the caller; otherwise, exceptions
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001524 are logged and then discarded. Note that this only happens in cases
1525 where we're called from a test (not special task) control file that
1526 has an explicit dependency on servo. In that case, we require that
1527 repair not write to `status.log`, so as to avoid polluting test
1528 results.
1529
1530 TODO(jrbarnette): The special handling for servo in test control
1531 files is a thorn in my flesh; I dearly hope to see it cut out before
1532 my retirement.
Richard Barnette9a26ad62016-06-10 12:03:08 -07001533
1534 Parameters for a servo host consist of a host name, port number, and
1535 DUT board, and are determined from one of these sources, in order of
1536 priority:
Richard Barnetteea3e4602016-06-10 12:36:41 -07001537 * Servo attributes from the `dut` parameter take precedence over
1538 all other sources of information.
1539 * If a DNS entry for the servo based on the DUT hostname exists in
1540 the CrOS lab network, that hostname is used with the default
Richard Barnette9a26ad62016-06-10 12:03:08 -07001541 port and the DUT's board.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001542 * If no other options are found, the parameters will be taken
Richard Barnette9a26ad62016-06-10 12:03:08 -07001543 from the `servo_args` dict passed in from the caller.
Richard Barnetteea3e4602016-06-10 12:36:41 -07001544
1545 @param dut An instance of `Host` from which to take
1546 servo parameters (if available).
1547 @param servo_args A dictionary with servo parameters to use if
1548 they can't be found from `dut`. If this
1549 argument is supplied, unrepaired exceptions
1550 from `verify()` will be passed back to the
1551 caller.
1552 @param try_lab_servo If not true, servo host creation will be
1553 skipped unless otherwise required by the
1554 caller.
Richard Barnette9a26ad62016-06-10 12:03:08 -07001555 @param try_servo_repair If true, check a servo host with
1556 `repair()` instead of `verify()`.
Otabek Kasimov8475cce2020-07-14 12:11:31 -07001557 @param dut_host_info: A HostInfo object of the DUT that connected
1558 to this servo.
Dan Shi4d478522014-02-14 13:46:32 -08001559
1560 @returns: A ServoHost object or None. See comments above.
1561
1562 """
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001563 servo_dependency = servo_args is not None
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001564 if dut is not None and (try_lab_servo or servo_dependency):
Prathmesh Prabhub4810232018-09-07 13:24:08 -07001565 servo_args_override = get_servo_args_for_host(dut)
Richard Barnetteea3e4602016-06-10 12:36:41 -07001566 if servo_args_override is not None:
Prathmesh Prabhuefb1b482018-08-28 17:15:05 -07001567 if utils.in_moblab_ssp():
1568 _tweak_args_for_ssp_moblab(servo_args_override)
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001569 logging.debug(
1570 'Overriding provided servo_args (%s) with arguments'
1571 ' determined from the host (%s)',
1572 servo_args,
1573 servo_args_override,
1574 )
Richard Barnetteea3e4602016-06-10 12:36:41 -07001575 servo_args = servo_args_override
Prathmesh Prabhucba44292018-08-28 17:44:45 -07001576
Richard Barnetteea3e4602016-06-10 12:36:41 -07001577 if servo_args is None:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001578 logging.debug('No servo_args provided, and failed to find overrides.')
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001579 if try_lab_servo or servo_dependency:
Otabek Kasimov646812c2020-06-23 20:01:36 -07001580 return None, servo_constants.SERVO_STATE_MISSING_CONFIG
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001581 else:
1582 # For regular test case which not required the servo
1583 return None, None
1584
Garry Wang11b5e872020-03-11 15:14:08 -07001585 servo_hostname = servo_args.get(servo_constants.SERVO_HOST_ATTR)
1586 servo_port = servo_args.get(servo_constants.SERVO_PORT_ATTR)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001587 if not _is_servo_host_information_exist(servo_hostname, servo_port):
1588 logging.debug(
1589 'Servo connection info missed hostname: %s , port: %s',
1590 servo_hostname, servo_port)
Otabek Kasimov646812c2020-06-23 20:01:36 -07001591 return None, servo_constants.SERVO_STATE_MISSING_CONFIG
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001592 if not is_servo_host_information_valid(servo_hostname, servo_port):
1593 logging.debug(
1594 'Servo connection info is incorrect hostname: %s , port: %s',
1595 servo_hostname, servo_port)
Garry Wang11b5e872020-03-11 15:14:08 -07001596 return None, servo_constants.SERVO_STATE_WRONG_CONFIG
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001597 if (not servo_dependency and not try_servo_repair and
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001598 not servo_host_is_up(servo_hostname)):
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001599 logging.debug('ServoHost is not up.')
Otabek Kasimov646812c2020-06-23 20:01:36 -07001600 return None, servo_constants.SERVO_STATE_NO_SSH
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001601
Garry Wangebc015b2019-06-06 17:45:06 -07001602 newhost = ServoHost(**servo_args)
Garry Wangffbd2162020-04-17 16:13:48 -07001603
Otabek Kasimove6df8102020-07-21 20:15:25 -07001604 # Reset or reboot servo device only during AdminRepair tasks.
1605 if try_servo_repair:
1606 if newhost._is_locked:
1607 # Reset servo if the servo is locked, as we check if the servohost
1608 # is up, if the servohost is labstation and if the servohost is in
1609 # lab inside the locking logic.
1610 newhost.reset_servo()
1611 else:
Garry Wang358aad42020-08-02 20:56:04 -07001612 try:
1613 newhost.reboot_servo_v3_on_need()
Garry Wang1f0d5332020-08-10 19:32:32 -07001614 except Exception as e:
1615 logging.info('[Non-critical] Unexpected error while trying to'
1616 ' reboot servo_v3, skipping the reboot; %s', e)
Otabek Kasimove6df8102020-07-21 20:15:25 -07001617
Otabek Kasimov2b50cdb2020-07-06 19:16:06 -07001618 if dut:
1619 newhost.set_dut_hostname(dut.hostname)
Otabek Kasimov9e90ae12020-08-14 03:01:19 -07001620 if dut_host_info:
1621 newhost.set_dut_host_info(dut_host_info)
Garry Wangffbd2162020-04-17 16:13:48 -07001622
Otabek Kasimov8475cce2020-07-14 12:11:31 -07001623 if try_lab_servo or try_servo_repair:
1624 try:
1625 logging.info("Check and update servo firmware.")
1626 servo_updater.update_servo_firmware(
1627 newhost,
1628 force_update=False)
1629 except Exception as e:
1630 logging.error("Servo device update error: %s", e)
1631
Garry Wangcdd27b22020-01-13 14:59:11 -08001632 try:
1633 newhost.restart_servod(quick_startup=True)
1634 except error.AutoservSSHTimeout:
1635 logging.warning("Restart servod failed due ssh connection "
1636 "to servohost timed out. This error is forgiven"
1637 " here, we will retry in servo repair process.")
1638 except error.AutoservRunError as e:
1639 logging.warning("Restart servod failed due to:\n%s\n"
1640 "This error is forgiven here, we will retry"
1641 " in servo repair process.", str(e))
Garry Wangebc015b2019-06-06 17:45:06 -07001642
Richard Barnette9a26ad62016-06-10 12:03:08 -07001643 # Note that the logic of repair() includes everything done
1644 # by verify(). It's sufficient to call one or the other;
1645 # we don't need both.
Richard Barnette07c2e1d2016-10-26 14:24:28 -07001646 if servo_dependency:
1647 newhost.repair(silent=True)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001648 return newhost, newhost.get_servo_state()
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001649
1650 if try_servo_repair:
1651 try:
1652 newhost.repair()
1653 except Exception:
1654 logging.exception('servo repair failed for %s', newhost.hostname)
Richard Barnette9a26ad62016-06-10 12:03:08 -07001655 else:
1656 try:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001657 newhost.verify()
Kevin Cheng5f2ba6c2016-09-28 10:20:05 -07001658 except Exception:
Prathmesh Prabhu88bf6052018-08-28 16:21:26 -07001659 logging.exception('servo verify failed for %s', newhost.hostname)
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001660 return newhost, newhost.get_servo_state()
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001661
1662
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001663def _is_servo_host_information_exist(hostname, port):
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001664 if hostname is None or len(hostname.strip()) == 0:
1665 return False
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001666 if port is None:
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001667 return False
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001668 if not type(port) is int:
1669 try:
1670 int(port)
1671 except ValueError:
1672 return False
1673
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001674 return True
1675
1676
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001677def is_servo_host_information_valid(hostname, port):
Garry Wang9b8f2342020-04-17 16:34:09 -07001678 """Check if provided servo attributes are valid.
1679
1680 @param hostname Hostname of the servohost.
1681 @param port servo port number.
1682
1683 @returns: A bool value to indicate if provided servo attribute valid.
1684 """
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001685 if not _is_servo_host_information_exist(hostname, port):
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001686 return False
1687 # checking range and correct of the port
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001688 port_int = int(port)
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001689 if port_int < 1 or port_int > 65000:
1690 return False
1691 # we expecting host contain only latters, digits and '-' or '_'
Otabek Kasimova7ba91a2020-03-09 08:31:01 -07001692 if not re.match('[a-zA-Z0-9-_\.]*$', hostname) or len(hostname) < 5:
Otabek Kasimov7267a7a2020-03-04 11:18:45 -08001693 return False
1694 return True