Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 1 | # Copyright (c) 2011 The Chromium OS Authors. All rights reserved. |
| 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | """This module builds a firmware image for a tegra-based board. |
| 6 | |
| 7 | This modules uses a few rudimentary other libraries for its activity. |
| 8 | |
| 9 | Here are the names we give to the various files we deal with. It is important |
| 10 | to keep these consistent! |
| 11 | |
| 12 | uboot u-boot.bin (with no device tree) |
| 13 | fdt the fdt blob |
| 14 | bct the BCT file |
| 15 | bootstub uboot + fdt |
| 16 | signed (uboot + fdt + bct) signed blob |
| 17 | """ |
| 18 | |
| 19 | import os |
| 20 | import re |
| 21 | |
| 22 | import cros_output |
| 23 | from fdt import Fdt |
| 24 | from pack_firmware import PackFirmware |
| 25 | import shutil |
| 26 | import tempfile |
| 27 | from tools import Tools |
| 28 | from write_firmware import WriteFirmware |
| 29 | |
| 30 | # This data is required by bmpblk_utility. Does it ever change? |
| 31 | # It was stored with the chromeos-bootimage ebuild, but we want |
| 32 | # this utility to work outside the chroot. |
| 33 | yaml_data = ''' |
| 34 | bmpblock: 1.0 |
| 35 | |
| 36 | images: |
| 37 | devmode: DeveloperBmp/DeveloperBmp.bmp |
| 38 | recovery: RecoveryBmp/RecoveryBmp.bmp |
| 39 | rec_yuck: RecoveryNoOSBmp/RecoveryNoOSBmp.bmp |
| 40 | rec_insert: RecoveryMissingOSBmp/RecoveryMissingOSBmp.bmp |
| 41 | |
| 42 | screens: |
| 43 | dev_en: |
| 44 | - [0, 0, devmode] |
| 45 | rec_en: |
| 46 | - [0, 0, recovery] |
| 47 | yuck_en: |
| 48 | - [0, 0, rec_yuck] |
| 49 | ins_en: |
| 50 | - [0, 0, rec_insert] |
| 51 | |
| 52 | localizations: |
| 53 | - [ dev_en, rec_en, yuck_en, ins_en ] |
| 54 | ''' |
| 55 | |
| 56 | class Bundle: |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 57 | """This class encapsulates the entire bundle firmware logic. |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 58 | |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 59 | Sequence of events: |
| 60 | bundle = Bundle(tools.Tools(), cros_output.Output()) |
| 61 | bundle.SetDirs(...) |
| 62 | bundle.SetFiles(...) |
| 63 | bundle.SetOptions(...) |
| 64 | bundle.SelectFdt(fdt.Fdt('filename.dtb') |
| 65 | .. can call bundle.AddConfigList() if required |
| 66 | bundle.Start(...) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 67 | |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 68 | Public properties: |
| 69 | fdt: The fdt object that we use for building our image. This wil be the |
| 70 | one specified by the user, except that we might add config options |
| 71 | to it. This is set up by SelectFdt() which must be called before |
| 72 | bundling starts. |
| 73 | uboot_fname: Full filename of the U-Boot binary we use. |
| 74 | bct_fname: Full filename of the BCT file we use. |
| 75 | """ |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 76 | |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 77 | def __init__(self, tools, output): |
| 78 | """Set up a new Bundle object. |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 79 | |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 80 | Args: |
| 81 | tools: A tools.Tools object to use for external tools. |
| 82 | output: A cros_output.Output object to use for program output. |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 83 | """ |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 84 | self.text_base = None # Base of U-Boot image in memory |
| 85 | |
| 86 | self._tools = tools |
| 87 | self._out = output |
| 88 | |
| 89 | # Set up the things we need to know in order to operate. |
| 90 | self._board = None # Board name, e.g. tegra2_seaboard. |
| 91 | self._fdt_fname = None # Filename of our FDT. |
| 92 | self.uboot_fname = None # Filename of our U-Boot binary. |
| 93 | self.bct_fname = None # Filename of our BCT file. |
| 94 | self.fdt = None # Our Fdt object. |
| 95 | |
| 96 | def SetDirs(self, keydir): |
| 97 | """Set up directories required for Bundle. |
| 98 | |
| 99 | Args: |
| 100 | keydir: Directory containing keys to use for signing firmware. |
| 101 | """ |
| 102 | self._keydir = keydir |
| 103 | |
| 104 | def SetFiles(self, board, uboot, bct): |
| 105 | """Set up files required for Bundle. |
| 106 | |
| 107 | Args: |
| 108 | board: The name of the board to target (e.g. tegra2_seaboard). |
| 109 | uboot: The filename of the u-boot.bin image to use. |
| 110 | bct: The filename of the binary BCT file to use. |
| 111 | """ |
| 112 | self._board = board |
| 113 | self.uboot_fname = uboot |
| 114 | self.bct_fname = bct |
| 115 | |
| 116 | def SetOptions(self, small): |
| 117 | """Set up options supported by Bundle. |
| 118 | |
| 119 | Args: |
| 120 | small: Only create a signed U-Boot - don't produce the full packed |
| 121 | firmware image. This is useful for devs who want to replace just the |
| 122 | U-Boot part while keeping the keys, gbb, etc. the same. |
| 123 | """ |
| 124 | self._small = small |
| 125 | |
| 126 | def CheckOptions(self): |
| 127 | """Check provided options and select defaults.""" |
| 128 | if not self._board: |
| 129 | raise ValueError('No board defined - please define a board to use') |
| 130 | build_root = os.path.join('##', 'build', self._board, 'u-boot') |
| 131 | if not self._fdt_fname: |
| 132 | self._fdt_fname = os.path.join(build_root, 'dtb', '%s.dtb' % |
| 133 | re.sub('_', '-', self._board)) |
| 134 | if not self.uboot_fname: |
| 135 | self.uboot_fname = os.path.join(build_root, 'u-boot.bin') |
| 136 | if not self.bct_fname: |
| 137 | self.bct_fname = os.path.join(build_root, 'bct', 'board.bct') |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 138 | |
Simon Glass | 5657757 | 2011-07-19 11:08:06 +1200 | [diff] [blame^] | 139 | def _CreateGoogleBinaryBlock(self, hardware_id): |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 140 | """Create a GBB for the image. |
| 141 | |
Simon Glass | 5657757 | 2011-07-19 11:08:06 +1200 | [diff] [blame^] | 142 | Args: |
| 143 | hardware_id: Hardware ID to use for this board. If None, then the |
| 144 | default from the Fdt will be used |
| 145 | |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 146 | Returns: |
| 147 | Path of the created GBB file. |
| 148 | |
| 149 | Raises: |
| 150 | CmdError if a command fails. |
| 151 | """ |
Simon Glass | 5657757 | 2011-07-19 11:08:06 +1200 | [diff] [blame^] | 152 | if not hardware_id: |
| 153 | hardware_id = self.fdt.GetString('/config/hwid') |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 154 | gbb_size = self.fdt.GetFlashPartSize('ro', 'gbb') |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 155 | odir = self._tools.outdir |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 156 | |
| 157 | # Get LCD dimensions from the device tree. |
| 158 | screen_geometry = '%sx%s' % (self.fdt.GetInt('/lcd/width'), |
| 159 | self.fdt.GetInt('/lcd/height')) |
| 160 | |
| 161 | # This is the magic directory that make_bmp_image writes to! |
Simon Glass | 5657757 | 2011-07-19 11:08:06 +1200 | [diff] [blame^] | 162 | out_dir = 'out_%s' % re.sub(' ', '_', hardware_id) |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 163 | bmp_dir = os.path.join(odir, out_dir) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 164 | self._out.Progress('Creating bitmaps') |
Simon Glass | 5657757 | 2011-07-19 11:08:06 +1200 | [diff] [blame^] | 165 | self._tools.Run('make_bmp_image', [hardware_id, screen_geometry, 'arm'], |
| 166 | cwd=odir) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 167 | |
| 168 | self._out.Progress('Creating bitmap block') |
| 169 | yaml = 'config.yaml' |
| 170 | self._tools.WriteFile(os.path.join(bmp_dir, yaml), yaml_data) |
| 171 | self._tools.Run('bmpblk_utility', ['-z', '2', '-c', yaml, 'bmpblk.bin'], |
| 172 | cwd=bmp_dir) |
| 173 | |
| 174 | self._out.Progress('Creating GBB') |
| 175 | sizes = [0x100, 0x1000, gbb_size - 0x2180, 0x1000] |
| 176 | sizes = ['%#x' % size for size in sizes] |
| 177 | gbb = 'gbb.bin' |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 178 | keydir = self._tools.Filename(self._keydir) |
| 179 | self._tools.Run('gbb_utility', ['-c', ','.join(sizes), gbb], cwd=odir) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 180 | self._tools.Run('gbb_utility', ['-s', |
Simon Glass | 5657757 | 2011-07-19 11:08:06 +1200 | [diff] [blame^] | 181 | '--hwid=%s' % hardware_id, |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 182 | '--rootkey=%s/root_key.vbpubk' % keydir, |
| 183 | '--recoverykey=%s/recovery_key.vbpubk' % keydir, |
| 184 | '--bmpfv=%s' % os.path.join(out_dir, 'bmpblk.bin'), |
| 185 | gbb], |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 186 | cwd=odir) |
| 187 | return os.path.join(odir, gbb) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 188 | |
| 189 | def _SignBootstub(self, bct, bootstub, text_base, name): |
| 190 | """Sign an image so that the Tegra SOC will boot it. |
| 191 | |
| 192 | Args: |
| 193 | bct: BCT file to use. |
| 194 | bootstub: Boot stub (U-Boot + fdt) file to sign. |
| 195 | text_base: Address of text base for image. |
| 196 | name: root of basename to use for signed image. |
| 197 | |
| 198 | Returns: |
| 199 | filename of signed image. |
| 200 | |
| 201 | Raises: |
| 202 | CmdError if a command fails. |
| 203 | """ |
| 204 | # First create a config file - this is how we instruct cbootimage |
| 205 | signed = os.path.join(self._tools.outdir, 'signed%s.bin' % name) |
| 206 | self._out.Progress('Signing Bootstub') |
| 207 | config = os.path.join(self._tools.outdir, 'boot%s.cfg' % name) |
| 208 | fd = open(config, 'w') |
| 209 | fd.write('Version = 1;\n') |
| 210 | fd.write('Redundancy = 1;\n') |
| 211 | fd.write('Bctfile = %s;\n' % bct) |
| 212 | fd.write('BootLoader = %s,%#x,%#x,Complete;\n' % (bootstub, text_base, |
| 213 | text_base)) |
| 214 | fd.close() |
| 215 | |
| 216 | self._tools.Run('cbootimage', [config, signed]) |
| 217 | self._tools.OutputSize('BCT', bct) |
| 218 | self._tools.OutputSize('Signed image', signed) |
| 219 | return signed |
| 220 | |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 221 | def SetBootcmd(self, bootcmd): |
| 222 | """Set the boot command for U-Boot. |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 223 | |
| 224 | Args: |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 225 | bootcmd: Boot command to use, as a string (if None this this is a nop). |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 226 | """ |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 227 | if bootcmd: |
Simon Glass | b4447fd | 2011-07-26 11:18:25 +1200 | [diff] [blame] | 228 | self.fdt.PutString('/config/bootcmd', bootcmd) |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 229 | self._out.Info('Boot command: %s' % bootcmd) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 230 | |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 231 | def AddConfigList(self, config_list, use_int=False): |
| 232 | """Add a list of config items to the fdt. |
| 233 | |
| 234 | Normally these values are written to the fdt as strings, but integers |
| 235 | are also supported, in which case the values will be converted to integers |
| 236 | (if necessary) before being stored. |
| 237 | |
| 238 | Args: |
| 239 | config_list: List of (config, value) tuples to add to the fdt. For each |
| 240 | tuple: |
| 241 | config: The fdt node to write to will be /config/<config>. |
| 242 | value: An integer or string value to write. |
| 243 | use_int: True to only write integer values. |
| 244 | |
| 245 | Raises: |
| 246 | CmdError: if a value is required to be converted to integer but can't be. |
| 247 | """ |
| 248 | if config_list: |
| 249 | for config in config_list: |
| 250 | value = config[1] |
| 251 | if use_int: |
| 252 | try: |
| 253 | value = int(value) |
| 254 | except ValueError as str: |
| 255 | raise CmdError("Cannot convert config option '%s' to integer" % |
| 256 | value) |
| 257 | if type(value) == type(1): |
| 258 | self.fdt.PutInteger('/config/%s' % config[0], value) |
| 259 | else: |
| 260 | self.fdt.PutString('/config/%s' % config[0], value) |
| 261 | |
| 262 | def _CreateBootStub(self, uboot, fdt): |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 263 | """Create a boot stub and a signed boot stub. |
| 264 | |
| 265 | Args: |
| 266 | uboot: Path to u-boot.bin (may be chroot-relative) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 267 | text_base: Address of text base for image. |
| 268 | |
| 269 | Returns: |
| 270 | Tuple containing: |
| 271 | Full path to u-boot.bin. |
Simon Glass | 5657757 | 2011-07-19 11:08:06 +1200 | [diff] [blame^] | 272 | Full path to bootstub (uboot + fdt). |
| 273 | Full path to signed blob (uboot + fdt + bct). |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 274 | |
| 275 | Raises: |
| 276 | CmdError if a command fails. |
| 277 | """ |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 278 | text_base = self.fdt.GetInt('/chromeos-config/textbase'); |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 279 | uboot_data = self._tools.ReadFile(uboot) |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 280 | fdt_data = self._tools.ReadFile(fdt.fname) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 281 | bootstub = os.path.join(self._tools.outdir, 'u-boot-fdt.bin') |
| 282 | self._tools.WriteFile(bootstub, uboot_data + fdt_data) |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 283 | self._tools.OutputSize('U-Boot binary', self.uboot_fname) |
| 284 | self._tools.OutputSize('U-Boot fdt', self._fdt_fname) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 285 | self._tools.OutputSize('Combined binary', bootstub) |
| 286 | |
| 287 | # sign the bootstub; this is a combination of the board specific |
| 288 | # bct and the stub u-boot image. |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 289 | signed = self._SignBootstub(self._tools.Filename(self.bct_fname), |
| 290 | bootstub, text_base, '') |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 291 | return self._tools.Filename(uboot), bootstub, signed |
| 292 | |
| 293 | def _PackOutput(self, msg): |
| 294 | """Helper function to write output from PackFirmware (verbose level 2). |
| 295 | |
| 296 | This is passed to PackFirmware for it to use to write output. |
| 297 | |
| 298 | Args: |
| 299 | msg: Message to display. |
| 300 | """ |
| 301 | self._out.Notice(msg) |
| 302 | |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 303 | def _CreateImage(self, gbb, fdt): |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 304 | """Create a full firmware image, along with various by-products. |
| 305 | |
| 306 | This uses the provided u-boot.bin, fdt and bct to create a firmware |
| 307 | image containing all the required parts. If the GBB is not supplied |
| 308 | then this will just return a signed U-Boot as the image. |
| 309 | |
| 310 | Args: |
| 311 | gbb Full path to the GBB file, or empty if a GBB is not required. |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 312 | |
| 313 | Raises: |
| 314 | CmdError if a command fails. |
| 315 | """ |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 316 | self._out.Notice("Model: %s" % fdt.GetString('/model')) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 317 | |
| 318 | # Create the boot stub, which is U-Boot plus an fdt and bct |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 319 | uboot, bootstub, signed = self._CreateBootStub(self.uboot_fname, fdt) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 320 | |
| 321 | if gbb: |
| 322 | pack = PackFirmware(self._tools, self._out) |
| 323 | image = os.path.join(self._tools.outdir, 'image.bin') |
| 324 | fwid = self._tools.GetChromeosVersion() |
| 325 | self._out.Notice('Firmware ID: %s' % fwid) |
| 326 | pack.SetupFiles(boot=bootstub, signed=signed, gbb=gbb, |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 327 | fwid=fwid, keydir=self._keydir) |
| 328 | pack.SelectFdt(fdt) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 329 | pack.PackImage(self._tools.outdir, image) |
| 330 | else: |
| 331 | image = signed |
| 332 | |
| 333 | self._tools.OutputSize('Final image', image) |
| 334 | return uboot, image |
| 335 | |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 336 | def SelectFdt(self, fdt_fname): |
| 337 | """Select an FDT to control the firmware bundling |
| 338 | |
| 339 | Args: |
| 340 | fdt_fname: The filename of the fdt to use. |
| 341 | |
| 342 | We make a copy of this which will include any on-the-fly changes we want |
| 343 | to make. |
| 344 | """ |
| 345 | self._fdt_fname = fdt_fname |
| 346 | self.CheckOptions() |
| 347 | fdt = Fdt(self._tools, self._fdt_fname) |
| 348 | self.fdt = fdt.Copy(os.path.join(self._tools.outdir, 'updated.dtb')) |
| 349 | |
Simon Glass | 5657757 | 2011-07-19 11:08:06 +1200 | [diff] [blame^] | 350 | def Start(self, hardware_id, output_fname): |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 351 | """This creates a firmware bundle according to settings provided. |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 352 | |
| 353 | - Checks options, tools, output directory, fdt. |
| 354 | - Creates GBB and image. |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 355 | |
| 356 | Args: |
Simon Glass | 5657757 | 2011-07-19 11:08:06 +1200 | [diff] [blame^] | 357 | hardware_id: Hardware ID to use for this board. If None, then the |
| 358 | default from the Fdt will be used |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 359 | output_fname: Output filename for the image. If this is not None, then |
| 360 | the final image will be copied here. |
| 361 | |
| 362 | Returns: |
| 363 | Filename of the resulting image (not the output_fname copy). |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 364 | """ |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 365 | gbb = '' |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 366 | if not self._small: |
Simon Glass | 5657757 | 2011-07-19 11:08:06 +1200 | [diff] [blame^] | 367 | gbb = self._CreateGoogleBinaryBlock(hardware_id) |
Simon Glass | 89b86b8 | 2011-07-17 23:49:49 -0700 | [diff] [blame] | 368 | |
| 369 | # This creates the actual image. |
Simon Glass | 290a180 | 2011-07-17 13:54:32 -0700 | [diff] [blame] | 370 | uboot, image = self._CreateImage(gbb, self.fdt) |
| 371 | if output_fname: |
| 372 | shutil.copyfile(image, output_fname) |
| 373 | self._out.Notice("Output image '%s'" % output_fname) |
| 374 | return image |