Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 1 | # -*- coding: utf-8 -*- |
| 2 | # Copyright 2019 The Chromium OS Authors. All rights reserved. |
| 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
| 6 | """Package utility functionality.""" |
| 7 | |
| 8 | from __future__ import print_function |
| 9 | |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 10 | import collections |
Yaakov Shaul | cb1cfc3 | 2019-09-16 13:51:19 -0600 | [diff] [blame] | 11 | import fileinput |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 12 | import functools |
Yaakov Shaul | 395ae83 | 2019-09-09 14:45:32 -0600 | [diff] [blame] | 13 | import json |
Evan Hernandez | b51f152 | 2019-08-15 11:29:40 -0600 | [diff] [blame] | 14 | import os |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 15 | import re |
Yaakov Shaul | cb1cfc3 | 2019-09-16 13:51:19 -0600 | [diff] [blame] | 16 | import sys |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 17 | |
Alex Klein | 149fd3b | 2019-12-16 16:01:05 -0700 | [diff] [blame] | 18 | import six |
| 19 | |
Andrew Lamb | 2bde9e4 | 2019-11-04 13:24:09 -0700 | [diff] [blame] | 20 | from google.protobuf import json_format |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 21 | |
Andrew Lamb | 2bde9e4 | 2019-11-04 13:24:09 -0700 | [diff] [blame] | 22 | from chromite.api.gen.config import replication_config_pb2 |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 23 | from chromite.cbuildbot import manifest_version |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 24 | from chromite.lib import constants |
Evan Hernandez | b51f152 | 2019-08-15 11:29:40 -0600 | [diff] [blame] | 25 | from chromite.lib import cros_build_lib |
Alex Klein | 4de25e8 | 2019-08-05 15:58:39 -0600 | [diff] [blame] | 26 | from chromite.lib import cros_logging as logging |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 27 | from chromite.lib import git |
Michael Mortensen | de716a1 | 2020-05-15 11:27:00 -0600 | [diff] [blame] | 28 | from chromite.lib import image_lib |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 29 | from chromite.lib import osutils |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 30 | from chromite.lib import portage_util |
Andrew Lamb | 2bde9e4 | 2019-11-04 13:24:09 -0700 | [diff] [blame] | 31 | from chromite.lib import replication_lib |
Alex Klein | d6195b6 | 2019-08-06 16:01:16 -0600 | [diff] [blame] | 32 | from chromite.lib import uprev_lib |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 33 | |
Alex Klein | 36b117f | 2019-09-30 15:13:46 -0600 | [diff] [blame] | 34 | if cros_build_lib.IsInsideChroot(): |
| 35 | from chromite.service import dependency |
| 36 | |
Mike Frysinger | bafb318 | 2020-02-21 03:15:43 -0500 | [diff] [blame] | 37 | |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 38 | # Registered handlers for uprevving versioned packages. |
| 39 | _UPREV_FUNCS = {} |
| 40 | |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 41 | |
| 42 | class Error(Exception): |
| 43 | """Module's base error class.""" |
| 44 | |
| 45 | |
Alex Klein | 4de25e8 | 2019-08-05 15:58:39 -0600 | [diff] [blame] | 46 | class UnknownPackageError(Error): |
| 47 | """Uprev attempted for a package without a registered handler.""" |
| 48 | |
| 49 | |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 50 | class UprevError(Error): |
| 51 | """An error occurred while uprevving packages.""" |
| 52 | |
| 53 | |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 54 | class NoAndroidVersionError(Error): |
| 55 | """An error occurred while trying to determine the android version.""" |
| 56 | |
| 57 | |
| 58 | class NoAndroidBranchError(Error): |
| 59 | """An error occurred while trying to determine the android branch.""" |
| 60 | |
| 61 | |
| 62 | class NoAndroidTargetError(Error): |
| 63 | """An error occurred while trying to determine the android target.""" |
| 64 | |
| 65 | |
Alex Klein | 4de25e8 | 2019-08-05 15:58:39 -0600 | [diff] [blame] | 66 | class AndroidIsPinnedUprevError(UprevError): |
| 67 | """Raised when we try to uprev while Android is pinned.""" |
| 68 | |
| 69 | def __init__(self, new_android_atom): |
| 70 | """Initialize a AndroidIsPinnedUprevError. |
| 71 | |
| 72 | Args: |
| 73 | new_android_atom: The Android atom that we failed to |
| 74 | uprev to, due to Android being pinned. |
| 75 | """ |
| 76 | assert new_android_atom |
| 77 | msg = ('Failed up uprev to Android version %s as Android was pinned.' % |
| 78 | new_android_atom) |
| 79 | super(AndroidIsPinnedUprevError, self).__init__(msg) |
| 80 | self.new_android_atom = new_android_atom |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 81 | |
| 82 | |
Yaakov Shaul | 1eafe83 | 2019-09-10 16:50:26 -0600 | [diff] [blame] | 83 | class EbuildManifestError(Error): |
| 84 | """Error when running ebuild manifest.""" |
| 85 | |
| 86 | |
Andrew Lamb | 9563a15 | 2019-12-04 11:42:18 -0700 | [diff] [blame] | 87 | class GeneratedCrosConfigFilesError(Error): |
| 88 | """Error when cros_config_schema does not produce expected files""" |
| 89 | |
| 90 | def __init__(self, expected_files, found_files): |
| 91 | msg = ('Expected to find generated C files: %s. Actually found: %s' % |
| 92 | (expected_files, found_files)) |
| 93 | super(GeneratedCrosConfigFilesError, self).__init__(msg) |
| 94 | |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 95 | |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 96 | UprevVersionedPackageModifications = collections.namedtuple( |
| 97 | 'UprevVersionedPackageModifications', ('new_version', 'files')) |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 98 | |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 99 | |
| 100 | class UprevVersionedPackageResult(object): |
| 101 | """Data object for uprev_versioned_package.""" |
| 102 | |
| 103 | def __init__(self): |
| 104 | self.modified = [] |
| 105 | |
| 106 | def add_result(self, new_version, modified_files): |
| 107 | """Adds version/ebuilds tuple to result. |
| 108 | |
| 109 | Args: |
| 110 | new_version: New version number of package. |
| 111 | modified_files: List of files modified for the given version. |
| 112 | """ |
| 113 | result = UprevVersionedPackageModifications(new_version, modified_files) |
| 114 | self.modified.append(result) |
| 115 | return self |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 116 | |
| 117 | @property |
| 118 | def uprevved(self): |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 119 | return bool(self.modified) |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 120 | |
| 121 | |
Yaakov Shaul | cb1cfc3 | 2019-09-16 13:51:19 -0600 | [diff] [blame] | 122 | def patch_ebuild_vars(ebuild_path, variables): |
| 123 | """Updates variables in ebuild. |
| 124 | |
| 125 | Use this function rather than portage_util.EBuild.UpdateEBuild when you |
| 126 | want to preserve the variable position and quotes within the ebuild. |
| 127 | |
| 128 | Args: |
| 129 | ebuild_path: The path of the ebuild. |
| 130 | variables: Dictionary of variables to update in ebuild. |
| 131 | """ |
| 132 | try: |
| 133 | for line in fileinput.input(ebuild_path, inplace=1): |
| 134 | varname, eq, _ = line.partition('=') |
| 135 | if eq == '=' and varname.strip() in variables: |
| 136 | value = variables[varname] |
| 137 | sys.stdout.write('%s="%s"\n' % (varname, value)) |
| 138 | else: |
| 139 | sys.stdout.write(line) |
| 140 | finally: |
| 141 | fileinput.close() |
| 142 | |
| 143 | |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 144 | def uprevs_versioned_package(package): |
| 145 | """Decorator to register package uprev handlers.""" |
| 146 | assert package |
| 147 | |
| 148 | def register(func): |
| 149 | """Registers |func| as a handler for |package|.""" |
| 150 | _UPREV_FUNCS[package] = func |
| 151 | |
| 152 | @functools.wraps(func) |
| 153 | def pass_through(*args, **kwargs): |
| 154 | return func(*args, **kwargs) |
| 155 | |
| 156 | return pass_through |
| 157 | |
| 158 | return register |
| 159 | |
| 160 | |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 161 | def uprev_android(tracking_branch, |
| 162 | android_package, |
| 163 | android_build_branch, |
| 164 | chroot, |
| 165 | build_targets=None, |
Shao-Chuan Lee | 9c39e0c | 2020-04-24 11:40:34 +0900 | [diff] [blame] | 166 | android_version=None): |
Alex Klein | 4de25e8 | 2019-08-05 15:58:39 -0600 | [diff] [blame] | 167 | """Returns the portage atom for the revved Android ebuild - see man emerge.""" |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 168 | command = [ |
| 169 | 'cros_mark_android_as_stable', |
| 170 | '--tracking_branch=%s' % tracking_branch, |
| 171 | '--android_package=%s' % android_package, |
| 172 | '--android_build_branch=%s' % android_build_branch, |
| 173 | ] |
Alex Klein | 4de25e8 | 2019-08-05 15:58:39 -0600 | [diff] [blame] | 174 | if build_targets: |
| 175 | command.append('--boards=%s' % ':'.join(bt.name for bt in build_targets)) |
| 176 | if android_version: |
| 177 | command.append('--force_version=%s' % android_version) |
Alex Klein | 4de25e8 | 2019-08-05 15:58:39 -0600 | [diff] [blame] | 178 | |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 179 | result = cros_build_lib.run( |
| 180 | command, |
| 181 | stdout=True, |
| 182 | enter_chroot=True, |
Mike Frysinger | 88d9636 | 2020-02-14 19:05:45 -0500 | [diff] [blame] | 183 | encoding='utf-8', |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 184 | chroot_args=chroot.get_enter_args()) |
Alex Klein | 4de25e8 | 2019-08-05 15:58:39 -0600 | [diff] [blame] | 185 | |
Mike Frysinger | 88d9636 | 2020-02-14 19:05:45 -0500 | [diff] [blame] | 186 | portage_atom_string = result.stdout.strip() |
| 187 | android_atom = None |
| 188 | if portage_atom_string: |
| 189 | android_atom = portage_atom_string.splitlines()[-1].partition('=')[-1] |
Alex Klein | 4de25e8 | 2019-08-05 15:58:39 -0600 | [diff] [blame] | 190 | if not android_atom: |
| 191 | logging.info('Found nothing to rev.') |
| 192 | return None |
| 193 | |
| 194 | for target in build_targets or []: |
| 195 | # Sanity check: We should always be able to merge the version of |
| 196 | # Android we just unmasked. |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 197 | command = ['emerge-%s' % target.name, '-p', '--quiet', '=%s' % android_atom] |
Alex Klein | 4de25e8 | 2019-08-05 15:58:39 -0600 | [diff] [blame] | 198 | try: |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 199 | cros_build_lib.run( |
| 200 | command, enter_chroot=True, chroot_args=chroot.get_enter_args()) |
Alex Klein | 4de25e8 | 2019-08-05 15:58:39 -0600 | [diff] [blame] | 201 | except cros_build_lib.RunCommandError: |
| 202 | logging.error( |
| 203 | 'Cannot emerge-%s =%s\nIs Android pinned to an older ' |
| 204 | 'version?', target, android_atom) |
| 205 | raise AndroidIsPinnedUprevError(android_atom) |
| 206 | |
| 207 | return android_atom |
| 208 | |
| 209 | |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 210 | def uprev_build_targets(build_targets, |
| 211 | overlay_type, |
| 212 | chroot=None, |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 213 | output_dir=None): |
| 214 | """Uprev the set provided build targets, or all if not specified. |
| 215 | |
| 216 | Args: |
Alex Klein | 2960c75 | 2020-03-09 13:43:38 -0600 | [diff] [blame] | 217 | build_targets (list[build_target_lib.BuildTarget]|None): The build targets |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 218 | whose overlays should be uprevved, empty or None for all. |
| 219 | overlay_type (str): One of the valid overlay types except None (see |
| 220 | constants.VALID_OVERLAYS). |
| 221 | chroot (chroot_lib.Chroot|None): The chroot to clean, if desired. |
| 222 | output_dir (str|None): The path to optionally dump result files. |
| 223 | """ |
| 224 | # Need a valid overlay, but exclude None. |
| 225 | assert overlay_type and overlay_type in constants.VALID_OVERLAYS |
| 226 | |
| 227 | if build_targets: |
| 228 | overlays = portage_util.FindOverlaysForBoards( |
| 229 | overlay_type, boards=[t.name for t in build_targets]) |
| 230 | else: |
| 231 | overlays = portage_util.FindOverlays(overlay_type) |
| 232 | |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 233 | return uprev_overlays( |
| 234 | overlays, |
| 235 | build_targets=build_targets, |
| 236 | chroot=chroot, |
| 237 | output_dir=output_dir) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 238 | |
| 239 | |
| 240 | def uprev_overlays(overlays, build_targets=None, chroot=None, output_dir=None): |
| 241 | """Uprev the given overlays. |
| 242 | |
| 243 | Args: |
| 244 | overlays (list[str]): The list of overlay paths. |
Alex Klein | 2960c75 | 2020-03-09 13:43:38 -0600 | [diff] [blame] | 245 | build_targets (list[build_target_lib.BuildTarget]|None): The build targets |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 246 | to clean in |chroot|, if desired. No effect unless |chroot| is provided. |
| 247 | chroot (chroot_lib.Chroot|None): The chroot to clean, if desired. |
| 248 | output_dir (str|None): The path to optionally dump result files. |
| 249 | |
| 250 | Returns: |
| 251 | list[str] - The paths to all of the modified ebuild files. This includes the |
| 252 | new files that were added (i.e. the new versions) and all of the removed |
| 253 | files (i.e. the old versions). |
| 254 | """ |
| 255 | assert overlays |
| 256 | |
| 257 | manifest = git.ManifestCheckout.Cached(constants.SOURCE_ROOT) |
| 258 | |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 259 | uprev_manager = uprev_lib.UprevOverlayManager( |
| 260 | overlays, |
| 261 | manifest, |
| 262 | build_targets=build_targets, |
| 263 | chroot=chroot, |
| 264 | output_dir=output_dir) |
Alex Klein | eb77ffa | 2019-05-28 14:47:44 -0600 | [diff] [blame] | 265 | uprev_manager.uprev() |
| 266 | |
| 267 | return uprev_manager.modified_ebuilds |
| 268 | |
| 269 | |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 270 | def uprev_versioned_package(package, build_targets, refs, chroot): |
| 271 | """Call registered uprev handler function for the package. |
| 272 | |
| 273 | Args: |
| 274 | package (portage_util.CPV): The package being uprevved. |
Alex Klein | 2960c75 | 2020-03-09 13:43:38 -0600 | [diff] [blame] | 275 | build_targets (list[build_target_lib.BuildTarget]): The build targets to |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 276 | clean on a successful uprev. |
| 277 | refs (list[uprev_lib.GitRef]): |
| 278 | chroot (chroot_lib.Chroot): The chroot to enter for cleaning. |
| 279 | |
| 280 | Returns: |
Alex Klein | 34afcbc | 2019-08-22 16:14:31 -0600 | [diff] [blame] | 281 | UprevVersionedPackageResult: The result. |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 282 | """ |
| 283 | assert package |
| 284 | |
| 285 | if package.cp not in _UPREV_FUNCS: |
| 286 | raise UnknownPackageError( |
| 287 | 'Package "%s" does not have a registered handler.' % package.cp) |
| 288 | |
Andrew Lamb | ea9a8a2 | 2019-12-12 14:03:43 -0700 | [diff] [blame] | 289 | return _UPREV_FUNCS[package.cp](build_targets, refs, chroot) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 290 | |
| 291 | |
Navil Perez | f57ba87 | 2020-06-04 22:38:37 +0000 | [diff] [blame] | 292 | @uprevs_versioned_package('media-libs/virglrenderer') |
| 293 | def uprev_virglrenderer(_build_targets, refs, _chroot): |
| 294 | """Updates virglrenderer ebuilds. |
| 295 | |
| 296 | See: uprev_versioned_package. |
| 297 | |
| 298 | Returns: |
| 299 | UprevVersionedPackageResult: The result of updating virglrenderer ebuilds. |
| 300 | """ |
Navil Perez | f57ba87 | 2020-06-04 22:38:37 +0000 | [diff] [blame] | 301 | overlay = os.path.join(constants.SOURCE_ROOT, |
| 302 | constants.CHROMIUMOS_OVERLAY_DIR) |
George Engelbrecht | e73f278 | 2020-06-10 14:10:46 -0600 | [diff] [blame^] | 303 | repo_path = os.path.join(constants.SOURCE_ROOT, 'src', 'third_party', |
| 304 | 'virglrenderer') |
| 305 | manifest = git.ManifestCheckout.Cached(repo_path) |
Navil Perez | f57ba87 | 2020-06-04 22:38:37 +0000 | [diff] [blame] | 306 | |
| 307 | uprev_manager = uprev_lib.UprevOverlayManager([overlay], manifest) |
| 308 | # TODO(crbug.com/1066242): Ebuilds for virglrenderer are currently |
| 309 | # blacklisted. Do not force uprevs after builder is stable and ebuilds are no |
| 310 | # longer blacklisted. |
| 311 | uprev_manager.uprev(package_list=['media-libs/virglrenderer'], force=True) |
| 312 | |
George Engelbrecht | e73f278 | 2020-06-10 14:10:46 -0600 | [diff] [blame^] | 313 | updated_files = uprev_manager.modified_ebuilds |
Navil Perez | f57ba87 | 2020-06-04 22:38:37 +0000 | [diff] [blame] | 314 | result = UprevVersionedPackageResult() |
| 315 | result.add_result(refs[0].revision, updated_files) |
| 316 | return result |
| 317 | |
| 318 | |
Yaakov Shaul | 395ae83 | 2019-09-09 14:45:32 -0600 | [diff] [blame] | 319 | @uprevs_versioned_package('afdo/kernel-profiles') |
| 320 | def uprev_kernel_afdo(*_args, **_kwargs): |
David Burger | 9248534 | 2019-09-10 17:52:45 -0600 | [diff] [blame] | 321 | """Updates kernel ebuilds with versions from kernel_afdo.json. |
Yaakov Shaul | 395ae83 | 2019-09-09 14:45:32 -0600 | [diff] [blame] | 322 | |
| 323 | See: uprev_versioned_package. |
Yaakov Shaul | 1eafe83 | 2019-09-10 16:50:26 -0600 | [diff] [blame] | 324 | |
| 325 | Raises: |
| 326 | EbuildManifestError: When ebuild manifest does not complete successfuly. |
Yaakov Shaul | 395ae83 | 2019-09-09 14:45:32 -0600 | [diff] [blame] | 327 | """ |
| 328 | path = os.path.join(constants.SOURCE_ROOT, 'src', 'third_party', |
| 329 | 'toolchain-utils', 'afdo_metadata', 'kernel_afdo.json') |
| 330 | |
David Burger | 9248534 | 2019-09-10 17:52:45 -0600 | [diff] [blame] | 331 | with open(path, 'r') as f: |
| 332 | versions = json.load(f) |
Yaakov Shaul | 395ae83 | 2019-09-09 14:45:32 -0600 | [diff] [blame] | 333 | |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 334 | result = UprevVersionedPackageResult() |
Yaakov Shaul | 395ae83 | 2019-09-09 14:45:32 -0600 | [diff] [blame] | 335 | for version, version_info in versions.items(): |
Yaakov Shaul | dd8b411 | 2019-09-11 11:44:03 -0600 | [diff] [blame] | 336 | path = os.path.join('src', 'third_party', 'chromiumos-overlay', |
| 337 | 'sys-kernel', version) |
| 338 | ebuild_path = os.path.join(constants.SOURCE_ROOT, path, |
| 339 | '%s-9999.ebuild' % version) |
Yaakov Shaul | a187b15 | 2019-09-11 12:41:32 -0600 | [diff] [blame] | 340 | chroot_ebuild_path = os.path.join(constants.CHROOT_SOURCE_ROOT, path, |
| 341 | '%s-9999.ebuild' % version) |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 342 | afdo_profile_version = version_info['name'] |
Yaakov Shaul | cb1cfc3 | 2019-09-16 13:51:19 -0600 | [diff] [blame] | 343 | patch_ebuild_vars(ebuild_path, |
| 344 | dict(AFDO_PROFILE_VERSION=afdo_profile_version)) |
Yaakov Shaul | 1eafe83 | 2019-09-10 16:50:26 -0600 | [diff] [blame] | 345 | |
| 346 | try: |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 347 | cmd = ['ebuild', chroot_ebuild_path, 'manifest', '--force'] |
Mike Frysinger | 45602c7 | 2019-09-22 02:15:11 -0400 | [diff] [blame] | 348 | cros_build_lib.run(cmd, enter_chroot=True) |
Yaakov Shaul | 1eafe83 | 2019-09-10 16:50:26 -0600 | [diff] [blame] | 349 | except cros_build_lib.RunCommandError as e: |
| 350 | raise EbuildManifestError( |
| 351 | 'Error encountered when regenerating the manifest for ebuild: %s\n%s' |
Yaakov Shaul | a187b15 | 2019-09-11 12:41:32 -0600 | [diff] [blame] | 352 | % (chroot_ebuild_path, e), e) |
Yaakov Shaul | 1eafe83 | 2019-09-10 16:50:26 -0600 | [diff] [blame] | 353 | |
Yaakov Shaul | dd8b411 | 2019-09-11 11:44:03 -0600 | [diff] [blame] | 354 | manifest_path = os.path.join(constants.SOURCE_ROOT, path, 'Manifest') |
Yaakov Shaul | 1eafe83 | 2019-09-10 16:50:26 -0600 | [diff] [blame] | 355 | |
Yaakov Shaul | 730814a | 2019-09-10 13:58:25 -0600 | [diff] [blame] | 356 | result.add_result(afdo_profile_version, [ebuild_path, manifest_path]) |
| 357 | |
| 358 | return result |
Yaakov Shaul | 395ae83 | 2019-09-09 14:45:32 -0600 | [diff] [blame] | 359 | |
| 360 | |
Trent Begin | af51f1b | 2020-03-09 17:35:31 -0600 | [diff] [blame] | 361 | @uprevs_versioned_package('chromeos-base/termina-image-amd64') |
| 362 | def uprev_termina_amd64(_build_targets, _refs, chroot): |
| 363 | """Updates termina amd64 VM - chromeos-base/termina-image-amd64. |
| 364 | |
| 365 | See: uprev_versioned_package. |
| 366 | """ |
| 367 | return uprev_termina('termina-image-amd64', chroot) |
| 368 | |
| 369 | |
| 370 | @uprevs_versioned_package('chromeos-base/termina-image-arm') |
| 371 | def uprev_termina_arm(_build_targets, _refs, chroot): |
| 372 | """Updates termina arm VM - chromeos-base/termina-image-arm. |
| 373 | |
| 374 | See: uprev_versioned_package. |
| 375 | """ |
| 376 | return uprev_termina('termina-image-arm', chroot) |
| 377 | |
| 378 | |
| 379 | def uprev_termina(package, chroot): |
| 380 | """Helper function to uprev termina VM. |
| 381 | |
| 382 | Args: |
| 383 | package (string): name of the package |
| 384 | chroot (chroot_lib.Chroot): specify a chroot to enter. |
| 385 | |
| 386 | Returns: |
| 387 | UprevVersionedPackageResult: The result. |
| 388 | """ |
| 389 | package_path = os.path.join(constants.CHROMIUMOS_OVERLAY_DIR, 'chromeos-base', |
| 390 | package) |
| 391 | version_pin_path = os.path.join(package_path, 'VERSION-PIN') |
| 392 | return uprev_ebuild_from_pin(package_path, version_pin_path, chroot) |
| 393 | |
| 394 | |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 395 | @uprevs_versioned_package('chromeos-base/chromeos-dtc-vm') |
Trent Begin | af51f1b | 2020-03-09 17:35:31 -0600 | [diff] [blame] | 396 | def uprev_sludge(_build_targets, _refs, chroot): |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 397 | """Updates sludge VM - chromeos-base/chromeos-dtc-vm. |
| 398 | |
| 399 | See: uprev_versioned_package. |
| 400 | """ |
| 401 | package = 'chromeos-dtc-vm' |
Trent Begin | d943df9 | 2020-02-25 10:30:10 -0700 | [diff] [blame] | 402 | package_path = os.path.join('src', 'private-overlays', |
| 403 | 'project-wilco-private', 'chromeos-base', package) |
| 404 | version_pin_path = os.path.join(package_path, 'VERSION-PIN') |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 405 | |
Trent Begin | 6daa870 | 2020-01-29 14:58:12 -0700 | [diff] [blame] | 406 | return uprev_ebuild_from_pin(package_path, version_pin_path, chroot) |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 407 | |
| 408 | |
Trent Begin | 6daa870 | 2020-01-29 14:58:12 -0700 | [diff] [blame] | 409 | def uprev_ebuild_from_pin(package_path, version_pin_path, chroot): |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 410 | """Changes the package ebuild's version to match the version pin file. |
| 411 | |
| 412 | Args: |
| 413 | package_path: The path of the package relative to the src root. This path |
| 414 | should contain a single ebuild with the same name as the package. |
Trent Begin | d943df9 | 2020-02-25 10:30:10 -0700 | [diff] [blame] | 415 | version_pin_path: The path of the version_pin file that contains only a |
| 416 | version string. The ebuild's version will be directly set to this |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 417 | number. |
Trent Begin | 6daa870 | 2020-01-29 14:58:12 -0700 | [diff] [blame] | 418 | chroot (chroot_lib.Chroot): specify a chroot to enter. |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 419 | |
| 420 | Returns: |
| 421 | UprevVersionedPackageResult: The result. |
| 422 | """ |
| 423 | package = os.path.basename(package_path) |
Trent Begin | d943df9 | 2020-02-25 10:30:10 -0700 | [diff] [blame] | 424 | |
| 425 | package_src_path = os.path.join(constants.SOURCE_ROOT, package_path) |
| 426 | ebuild_paths = list(portage_util.EBuild.List(package_src_path)) |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 427 | if not ebuild_paths: |
| 428 | raise UprevError('No ebuilds found for %s' % package) |
| 429 | elif len(ebuild_paths) > 1: |
| 430 | raise UprevError('Multiple ebuilds found for %s' % package) |
| 431 | else: |
| 432 | ebuild_path = ebuild_paths[0] |
| 433 | |
Trent Begin | d943df9 | 2020-02-25 10:30:10 -0700 | [diff] [blame] | 434 | version_pin_src_path = os.path.join(constants.SOURCE_ROOT, version_pin_path) |
| 435 | version = osutils.ReadFile(version_pin_src_path).strip() |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 436 | new_ebuild_path = os.path.join(package_path, |
| 437 | '%s-%s-r1.ebuild' % (package, version)) |
Trent Begin | d943df9 | 2020-02-25 10:30:10 -0700 | [diff] [blame] | 438 | new_ebuild_src_path = os.path.join(constants.SOURCE_ROOT, new_ebuild_path) |
| 439 | os.rename(ebuild_path, new_ebuild_src_path) |
Trent Begin | 4a11a63 | 2020-02-28 12:59:58 -0700 | [diff] [blame] | 440 | manifest_src_path = os.path.join(package_src_path, 'Manifest') |
Trent Begin | d943df9 | 2020-02-25 10:30:10 -0700 | [diff] [blame] | 441 | new_ebuild_chroot_path = os.path.join(constants.CHROOT_SOURCE_ROOT, |
| 442 | new_ebuild_path) |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 443 | |
Trent Begin | 6daa870 | 2020-01-29 14:58:12 -0700 | [diff] [blame] | 444 | try: |
Trent Begin | d943df9 | 2020-02-25 10:30:10 -0700 | [diff] [blame] | 445 | portage_util.UpdateEbuildManifest(new_ebuild_chroot_path, chroot=chroot) |
Trent Begin | 6daa870 | 2020-01-29 14:58:12 -0700 | [diff] [blame] | 446 | except cros_build_lib.RunCommandError as e: |
Trent Begin | d943df9 | 2020-02-25 10:30:10 -0700 | [diff] [blame] | 447 | raise EbuildManifestError( |
Trent Begin | 6daa870 | 2020-01-29 14:58:12 -0700 | [diff] [blame] | 448 | 'Unable to update manifest for %s: %s' % (package, e.stderr)) |
| 449 | |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 450 | result = UprevVersionedPackageResult() |
Trent Begin | 4a11a63 | 2020-02-28 12:59:58 -0700 | [diff] [blame] | 451 | result.add_result(version, |
| 452 | [new_ebuild_src_path, ebuild_path, manifest_src_path]) |
Trent Begin | 315d9d9 | 2019-12-03 21:55:53 -0700 | [diff] [blame] | 453 | return result |
| 454 | |
| 455 | |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 456 | @uprevs_versioned_package(constants.CHROME_CP) |
Andrew Lamb | ea9a8a2 | 2019-12-12 14:03:43 -0700 | [diff] [blame] | 457 | def uprev_chrome(build_targets, refs, chroot): |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 458 | """Uprev chrome and its related packages. |
| 459 | |
| 460 | See: uprev_versioned_package. |
| 461 | """ |
| 462 | # Determine the version from the refs (tags), i.e. the chrome versions are the |
| 463 | # tag names. |
| 464 | chrome_version = uprev_lib.get_chrome_version_from_refs(refs) |
Chris McDonald | 25881af | 2020-05-12 03:17:53 -0600 | [diff] [blame] | 465 | logging.debug('Chrome version determined from refs: %s', chrome_version) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 466 | |
| 467 | uprev_manager = uprev_lib.UprevChromeManager( |
| 468 | chrome_version, build_targets=build_targets, chroot=chroot) |
David Burger | 37f4867 | 2019-09-18 17:07:56 -0600 | [diff] [blame] | 469 | result = UprevVersionedPackageResult() |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 470 | # Start with chrome itself, as we can't do anything else unless chrome |
| 471 | # uprevs successfully. |
Chris McDonald | 25881af | 2020-05-12 03:17:53 -0600 | [diff] [blame] | 472 | # TODO(crbug.com/1080429): Handle all possible outcomes of a Chrome uprev |
| 473 | # attempt. The expected behavior is documented in the following table: |
| 474 | # |
| 475 | # Outcome of Chrome uprev attempt: |
| 476 | # NEWER_VERSION_EXISTS: |
| 477 | # Do nothing. |
| 478 | # SAME_VERSION_EXISTS or REVISION_BUMP: |
| 479 | # Uprev followers |
| 480 | # Assert not VERSION_BUMP (any other outcome is fine) |
| 481 | # VERSION_BUMP or NEW_EBUILD_CREATED: |
| 482 | # Uprev followers |
| 483 | # Assert that Chrome & followers are at same package version |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 484 | if not uprev_manager.uprev(constants.CHROME_CP): |
David Burger | 37f4867 | 2019-09-18 17:07:56 -0600 | [diff] [blame] | 485 | return result |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 486 | |
| 487 | # With a successful chrome rev, also uprev related packages. |
| 488 | for package in constants.OTHER_CHROME_PACKAGES: |
| 489 | uprev_manager.uprev(package) |
| 490 | |
David Burger | 37f4867 | 2019-09-18 17:07:56 -0600 | [diff] [blame] | 491 | return result.add_result(chrome_version, uprev_manager.modified_ebuilds) |
Alex Klein | 8753118 | 2019-08-12 15:23:37 -0600 | [diff] [blame] | 492 | |
| 493 | |
Andrew Lamb | 9563a15 | 2019-12-04 11:42:18 -0700 | [diff] [blame] | 494 | def _generate_platform_c_files(replication_config, chroot): |
| 495 | """Generates platform C files from a platform JSON payload. |
| 496 | |
| 497 | Args: |
| 498 | replication_config (replication_config_pb2.ReplicationConfig): A |
| 499 | ReplicationConfig that has already been run. If it produced a |
| 500 | build_config.json file, that file will be used to generate platform C |
| 501 | files. Otherwise, nothing will be generated. |
| 502 | chroot (chroot_lib.Chroot): The chroot to use to generate. |
| 503 | |
| 504 | Returns: |
| 505 | A list of generated files. |
| 506 | """ |
| 507 | # Generate the platform C files from the build config. Note that it would be |
| 508 | # more intuitive to generate the platform C files from the platform config; |
| 509 | # however, cros_config_schema does not allow this, because the platform config |
| 510 | # payload is not always valid input. For example, if a property is both |
| 511 | # 'required' and 'build-only', it will fail schema validation. Thus, use the |
| 512 | # build config, and use '-f' to filter. |
| 513 | build_config_path = [ |
| 514 | rule.destination_path |
| 515 | for rule in replication_config.file_replication_rules |
| 516 | if rule.destination_path.endswith('build_config.json') |
| 517 | ] |
| 518 | |
| 519 | if not build_config_path: |
| 520 | logging.info( |
Alex Klein | ad6b48a | 2020-01-08 16:57:41 -0700 | [diff] [blame] | 521 | 'No build_config.json found, will not generate platform C files. ' |
| 522 | 'Replication config: %s', replication_config) |
Andrew Lamb | 9563a15 | 2019-12-04 11:42:18 -0700 | [diff] [blame] | 523 | return [] |
| 524 | |
| 525 | if len(build_config_path) > 1: |
Alex Klein | ad6b48a | 2020-01-08 16:57:41 -0700 | [diff] [blame] | 526 | raise ValueError('Expected at most one build_config.json destination path. ' |
| 527 | 'Replication config: %s' % replication_config) |
Andrew Lamb | 9563a15 | 2019-12-04 11:42:18 -0700 | [diff] [blame] | 528 | |
| 529 | build_config_path = build_config_path[0] |
| 530 | |
| 531 | # Paths to the build_config.json and dir to output C files to, in the |
| 532 | # chroot. |
| 533 | build_config_chroot_path = os.path.join(constants.CHROOT_SOURCE_ROOT, |
| 534 | build_config_path) |
| 535 | generated_output_chroot_dir = os.path.join(constants.CHROOT_SOURCE_ROOT, |
| 536 | os.path.dirname(build_config_path)) |
| 537 | |
| 538 | command = [ |
| 539 | 'cros_config_schema', '-m', build_config_chroot_path, '-g', |
| 540 | generated_output_chroot_dir, '-f', '"TRUE"' |
| 541 | ] |
| 542 | |
| 543 | cros_build_lib.run( |
| 544 | command, enter_chroot=True, chroot_args=chroot.get_enter_args()) |
| 545 | |
| 546 | # A relative (to the source root) path to the generated C files. |
| 547 | generated_output_dir = os.path.dirname(build_config_path) |
| 548 | generated_files = [] |
| 549 | expected_c_files = ['config.c', 'ec_config.c', 'ec_config.h'] |
| 550 | for f in expected_c_files: |
| 551 | if os.path.exists( |
| 552 | os.path.join(constants.SOURCE_ROOT, generated_output_dir, f)): |
| 553 | generated_files.append(os.path.join(generated_output_dir, f)) |
| 554 | |
| 555 | if len(expected_c_files) != len(generated_files): |
| 556 | raise GeneratedCrosConfigFilesError(expected_c_files, generated_files) |
| 557 | |
| 558 | return generated_files |
| 559 | |
| 560 | |
Andrew Lamb | e836f22 | 2019-12-09 12:27:38 -0700 | [diff] [blame] | 561 | def _get_private_overlay_package_root(ref, package): |
| 562 | """Returns the absolute path to the root of a given private overlay. |
| 563 | |
| 564 | Args: |
| 565 | ref (uprev_lib.GitRef): GitRef for the private overlay. |
| 566 | package (str): Path to the package in the overlay. |
| 567 | """ |
| 568 | # There might be a cleaner way to map from package -> path within the source |
| 569 | # tree. For now, just use string patterns. |
Andrew Lamb | 4aa0991 | 2020-01-08 13:55:56 -0700 | [diff] [blame] | 570 | private_overlay_ref_pattern = r'/chromeos\/overlays\/overlay-([\w-]+)-private' |
Andrew Lamb | e836f22 | 2019-12-09 12:27:38 -0700 | [diff] [blame] | 571 | match = re.match(private_overlay_ref_pattern, ref.path) |
| 572 | if not match: |
| 573 | raise ValueError('ref.path must match the pattern: %s. Actual ref: %s' % |
| 574 | (private_overlay_ref_pattern, ref)) |
| 575 | |
| 576 | overlay = match.group(1) |
| 577 | |
| 578 | return os.path.join(constants.SOURCE_ROOT, |
| 579 | 'src/private-overlays/overlay-%s-private' % overlay, |
| 580 | package) |
| 581 | |
| 582 | |
Andrew Lamb | ea9a8a2 | 2019-12-12 14:03:43 -0700 | [diff] [blame] | 583 | @uprevs_versioned_package('chromeos-base/chromeos-config-bsp') |
| 584 | def replicate_private_config(_build_targets, refs, chroot): |
Andrew Lamb | 2bde9e4 | 2019-11-04 13:24:09 -0700 | [diff] [blame] | 585 | """Replicate a private cros_config change to the corresponding public config. |
| 586 | |
Alex Klein | ad6b48a | 2020-01-08 16:57:41 -0700 | [diff] [blame] | 587 | See uprev_versioned_package for args |
Andrew Lamb | 2bde9e4 | 2019-11-04 13:24:09 -0700 | [diff] [blame] | 588 | """ |
Andrew Lamb | ea9a8a2 | 2019-12-12 14:03:43 -0700 | [diff] [blame] | 589 | package = 'chromeos-base/chromeos-config-bsp' |
| 590 | |
Andrew Lamb | 2bde9e4 | 2019-11-04 13:24:09 -0700 | [diff] [blame] | 591 | if len(refs) != 1: |
| 592 | raise ValueError('Expected exactly one ref, actual %s' % refs) |
| 593 | |
| 594 | # Expect a replication_config.jsonpb in the package root. |
Andrew Lamb | e836f22 | 2019-12-09 12:27:38 -0700 | [diff] [blame] | 595 | package_root = _get_private_overlay_package_root(refs[0], package) |
Andrew Lamb | 2bde9e4 | 2019-11-04 13:24:09 -0700 | [diff] [blame] | 596 | replication_config_path = os.path.join(package_root, |
| 597 | 'replication_config.jsonpb') |
| 598 | |
| 599 | try: |
| 600 | replication_config = json_format.Parse( |
| 601 | osutils.ReadFile(replication_config_path), |
| 602 | replication_config_pb2.ReplicationConfig()) |
| 603 | except IOError: |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 604 | raise ValueError( |
| 605 | 'Expected ReplicationConfig missing at %s' % replication_config_path) |
Andrew Lamb | 2bde9e4 | 2019-11-04 13:24:09 -0700 | [diff] [blame] | 606 | |
| 607 | replication_lib.Replicate(replication_config) |
| 608 | |
| 609 | modified_files = [ |
| 610 | rule.destination_path |
| 611 | for rule in replication_config.file_replication_rules |
| 612 | ] |
| 613 | |
Andrew Lamb | 9563a15 | 2019-12-04 11:42:18 -0700 | [diff] [blame] | 614 | # The generated platform C files are not easily filtered by replication rules, |
| 615 | # i.e. JSON / proto filtering can be described by a FieldMask, arbitrary C |
| 616 | # files cannot. Therefore, replicate and filter the JSON payloads, and then |
| 617 | # generate filtered C files from the JSON payload. |
| 618 | modified_files.extend(_generate_platform_c_files(replication_config, chroot)) |
Andrew Lamb | 2bde9e4 | 2019-11-04 13:24:09 -0700 | [diff] [blame] | 619 | |
| 620 | # Use the private repo's commit hash as the new version. |
| 621 | new_private_version = refs[0].revision |
| 622 | |
Andrew Lamb | 988f4da | 2019-12-10 10:16:43 -0700 | [diff] [blame] | 623 | # modified_files should contain only relative paths at this point, but the |
| 624 | # returned UprevVersionedPackageResult must contain only absolute paths. |
| 625 | for i, modified_file in enumerate(modified_files): |
| 626 | assert not os.path.isabs(modified_file) |
| 627 | modified_files[i] = os.path.join(constants.SOURCE_ROOT, modified_file) |
| 628 | |
Andrew Lamb | 2bde9e4 | 2019-11-04 13:24:09 -0700 | [diff] [blame] | 629 | return UprevVersionedPackageResult().add_result(new_private_version, |
| 630 | modified_files) |
| 631 | |
| 632 | |
Alex Klein | bbef2b3 | 2019-08-27 10:38:50 -0600 | [diff] [blame] | 633 | def get_best_visible(atom, build_target=None): |
| 634 | """Returns the best visible CPV for the given atom. |
| 635 | |
| 636 | Args: |
| 637 | atom (str): The atom to look up. |
Alex Klein | 2960c75 | 2020-03-09 13:43:38 -0600 | [diff] [blame] | 638 | build_target (build_target_lib.BuildTarget): The build target whose |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 639 | sysroot should be searched, or the SDK if not provided. |
Alex Klein | ad6b48a | 2020-01-08 16:57:41 -0700 | [diff] [blame] | 640 | |
| 641 | Returns: |
| 642 | portage_util.CPV|None: The best visible package. |
Alex Klein | bbef2b3 | 2019-08-27 10:38:50 -0600 | [diff] [blame] | 643 | """ |
David Burger | 1e0fe23 | 2019-07-01 14:52:07 -0600 | [diff] [blame] | 644 | assert atom |
Alex Klein | bbef2b3 | 2019-08-27 10:38:50 -0600 | [diff] [blame] | 645 | |
| 646 | board = build_target.name if build_target else None |
| 647 | return portage_util.PortageqBestVisible(atom, board=board) |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 648 | |
| 649 | |
Alex Klein | 149fd3b | 2019-12-16 16:01:05 -0700 | [diff] [blame] | 650 | def has_prebuilt(atom, build_target=None, useflags=None): |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 651 | """Check if a prebuilt exists. |
| 652 | |
| 653 | Args: |
| 654 | atom (str): The package whose prebuilt is being queried. |
Alex Klein | 2960c75 | 2020-03-09 13:43:38 -0600 | [diff] [blame] | 655 | build_target (build_target_lib.BuildTarget): The build target whose |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 656 | sysroot should be searched, or the SDK if not provided. |
Alex Klein | 149fd3b | 2019-12-16 16:01:05 -0700 | [diff] [blame] | 657 | useflags: Any additional USE flags that should be set. May be a string |
| 658 | of properly formatted USE flags, or an iterable of individual flags. |
Alex Klein | ad6b48a | 2020-01-08 16:57:41 -0700 | [diff] [blame] | 659 | |
| 660 | Returns: |
| 661 | bool: True iff there is an available prebuilt, False otherwise. |
Alex Klein | da39c6d | 2019-09-16 14:36:36 -0600 | [diff] [blame] | 662 | """ |
| 663 | assert atom |
| 664 | |
| 665 | board = build_target.name if build_target else None |
Alex Klein | 149fd3b | 2019-12-16 16:01:05 -0700 | [diff] [blame] | 666 | extra_env = None |
| 667 | if useflags: |
| 668 | new_flags = useflags |
| 669 | if not isinstance(useflags, six.string_types): |
| 670 | new_flags = ' '.join(useflags) |
| 671 | |
| 672 | existing = os.environ.get('USE', '') |
| 673 | final_flags = '%s %s' % (existing, new_flags) |
| 674 | extra_env = {'USE': final_flags.strip()} |
| 675 | return portage_util.HasPrebuilt(atom, board=board, extra_env=extra_env) |
Alex Klein | 36b117f | 2019-09-30 15:13:46 -0600 | [diff] [blame] | 676 | |
| 677 | |
David Burger | 0f9dd4e | 2019-10-08 12:33:42 -0600 | [diff] [blame] | 678 | def builds(atom, build_target, packages=None): |
Alex Klein | 36b117f | 2019-09-30 15:13:46 -0600 | [diff] [blame] | 679 | """Check if |build_target| builds |atom| (has it in its depgraph).""" |
| 680 | cros_build_lib.AssertInsideChroot() |
| 681 | |
LaMont Jones | 4cbecba | 2020-05-12 11:54:27 -0600 | [diff] [blame] | 682 | # TODO(crbug/1081828): Receive and use sysroot. |
| 683 | graph, _sdk_graph = dependency.GetBuildDependency( |
| 684 | build_target.root, build_target.name, packages) |
Alex Klein | 36b117f | 2019-09-30 15:13:46 -0600 | [diff] [blame] | 685 | return any(atom in package for package in graph['package_deps']) |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 686 | |
| 687 | |
Michael Mortensen | b51a1f0 | 2019-10-16 13:28:20 -0600 | [diff] [blame] | 688 | def determine_chrome_version(build_target): |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 689 | """Returns the current Chrome version for the board (or in buildroot). |
| 690 | |
| 691 | Args: |
Alex Klein | 2960c75 | 2020-03-09 13:43:38 -0600 | [diff] [blame] | 692 | build_target (build_target_lib.BuildTarget): The board build target. |
Alex Klein | ad6b48a | 2020-01-08 16:57:41 -0700 | [diff] [blame] | 693 | |
| 694 | Returns: |
| 695 | str|None: The chrome version if available. |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 696 | """ |
Michael Mortensen | 9fe740c | 2019-10-29 14:42:48 -0600 | [diff] [blame] | 697 | # TODO(crbug/1019770): Long term we should not need the try/catch here once |
| 698 | # the builds function above only returns True for chrome when |
| 699 | # determine_chrome_version will succeed. |
| 700 | try: |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 701 | cpv = portage_util.PortageqBestVisible( |
| 702 | constants.CHROME_CP, build_target.name, cwd=constants.SOURCE_ROOT) |
Michael Mortensen | 9fe740c | 2019-10-29 14:42:48 -0600 | [diff] [blame] | 703 | except cros_build_lib.RunCommandError as e: |
| 704 | # Return None because portage failed when trying to determine the chrome |
| 705 | # version. |
| 706 | logging.warning('Caught exception in determine_chrome_package: %s', e) |
| 707 | return None |
Michael Mortensen | c2615b7 | 2019-10-15 08:12:24 -0600 | [diff] [blame] | 708 | # Something like 78.0.3877.4_rc -> 78.0.3877.4 |
| 709 | return cpv.version_no_rev.partition('_')[0] |
| 710 | |
| 711 | |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 712 | def determine_android_package(board): |
| 713 | """Returns the active Android container package in use by the board. |
| 714 | |
| 715 | Args: |
| 716 | board: The board name this is specific to. |
Alex Klein | ad6b48a | 2020-01-08 16:57:41 -0700 | [diff] [blame] | 717 | |
| 718 | Returns: |
| 719 | str|None: The android package string if there is one. |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 720 | """ |
Michael Mortensen | e0f4b54 | 2019-10-24 15:30:23 -0600 | [diff] [blame] | 721 | try: |
| 722 | packages = portage_util.GetPackageDependencies(board, 'virtual/target-os') |
Michael Mortensen | e0f4b54 | 2019-10-24 15:30:23 -0600 | [diff] [blame] | 723 | except cros_build_lib.RunCommandError as e: |
| 724 | # Return None because a command (likely portage) failed when trying to |
| 725 | # determine the package. |
| 726 | logging.warning('Caught exception in determine_android_package: %s', e) |
| 727 | return None |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 728 | |
Alex Klein | ad6b48a | 2020-01-08 16:57:41 -0700 | [diff] [blame] | 729 | # We assume there is only one Android package in the depgraph. |
| 730 | for package in packages: |
| 731 | if package.startswith('chromeos-base/android-container-') or \ |
| 732 | package.startswith('chromeos-base/android-vm-'): |
| 733 | return package |
| 734 | return None |
| 735 | |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 736 | |
| 737 | def determine_android_version(boards=None): |
| 738 | """Determine the current Android version in buildroot now and return it. |
| 739 | |
| 740 | This uses the typical portage logic to determine which version of Android |
| 741 | is active right now in the buildroot. |
| 742 | |
| 743 | Args: |
| 744 | boards: List of boards to check version of. |
| 745 | |
| 746 | Returns: |
| 747 | The Android build ID of the container for the boards. |
| 748 | |
| 749 | Raises: |
| 750 | NoAndroidVersionError: if no unique Android version can be determined. |
| 751 | """ |
| 752 | if not boards: |
| 753 | return None |
| 754 | # Verify that all boards have the same version. |
| 755 | version = None |
| 756 | for board in boards: |
| 757 | package = determine_android_package(board) |
| 758 | if not package: |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 759 | return None |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 760 | cpv = portage_util.SplitCPV(package) |
| 761 | if not cpv: |
| 762 | raise NoAndroidVersionError( |
| 763 | 'Android version could not be determined for %s' % board) |
| 764 | if not version: |
| 765 | version = cpv.version_no_rev |
| 766 | elif version != cpv.version_no_rev: |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 767 | raise NoAndroidVersionError('Different Android versions (%s vs %s) for %s' |
| 768 | % (version, cpv.version_no_rev, boards)) |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 769 | return version |
| 770 | |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 771 | |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 772 | def determine_android_branch(board): |
| 773 | """Returns the Android branch in use by the active container ebuild.""" |
| 774 | try: |
| 775 | android_package = determine_android_package(board) |
| 776 | except cros_build_lib.RunCommandError: |
| 777 | raise NoAndroidBranchError( |
| 778 | 'Android branch could not be determined for %s' % board) |
| 779 | if not android_package: |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 780 | return None |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 781 | ebuild_path = portage_util.FindEbuildForBoardPackage(android_package, board) |
| 782 | # We assume all targets pull from the same branch and that we always |
Federico 'Morg' Pareschi | cd9165a | 2020-05-29 09:45:55 +0900 | [diff] [blame] | 783 | # have at least one of the following targets. |
Shao-Chuan Lee | ac91963 | 2020-05-28 13:14:37 +0900 | [diff] [blame] | 784 | # TODO(crbug.com/1087167): Ensure this condition in PFQ to avoid CQ breakage. |
Federico 'Morg' Pareschi | cd9165a | 2020-05-29 09:45:55 +0900 | [diff] [blame] | 785 | targets = ['ARM_TARGET', 'ARM_USERDEBUG_TARGET', 'X86_USERDEBUG_TARGET', |
| 786 | 'ARM64_TARGET', 'ARM64_USERDEBUG_TARGET', 'X86_64_TARGET', |
| 787 | 'X86_64_USERDEBUG_TARGET'] |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 788 | ebuild_content = osutils.SourceEnvironment(ebuild_path, targets) |
| 789 | for target in targets: |
| 790 | if target in ebuild_content: |
| 791 | branch = re.search(r'(.*?)-linux-', ebuild_content[target]) |
| 792 | if branch is not None: |
| 793 | return branch.group(1) |
| 794 | raise NoAndroidBranchError( |
| 795 | 'Android branch could not be determined for %s (ebuild empty?)' % board) |
| 796 | |
| 797 | |
| 798 | def determine_android_target(board): |
Michael Mortensen | 14960d0 | 2019-10-18 07:53:59 -0600 | [diff] [blame] | 799 | """Returns the Android target in use by the active container ebuild.""" |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 800 | try: |
| 801 | android_package = determine_android_package(board) |
| 802 | except cros_build_lib.RunCommandError: |
| 803 | raise NoAndroidTargetError( |
| 804 | 'Android Target could not be determined for %s' % board) |
| 805 | if not android_package: |
Michael Mortensen | edf7653 | 2019-10-16 14:22:37 -0600 | [diff] [blame] | 806 | return None |
Michael Mortensen | b70e8a8 | 2019-10-10 18:43:41 -0600 | [diff] [blame] | 807 | if android_package.startswith('chromeos-base/android-vm-'): |
| 808 | return 'bertha' |
| 809 | elif android_package.startswith('chromeos-base/android-container-'): |
| 810 | return 'cheets' |
| 811 | |
| 812 | raise NoAndroidTargetError( |
| 813 | 'Android Target cannot be determined for the package: %s' % |
| 814 | android_package) |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 815 | |
| 816 | |
| 817 | def determine_platform_version(): |
| 818 | """Returns the platform version from the source root.""" |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 819 | # Platform version is something like '12575.0.0'. |
Michael Mortensen | 9fdb14b | 2019-10-17 11:17:30 -0600 | [diff] [blame] | 820 | version = manifest_version.VersionInfo.from_repo(constants.SOURCE_ROOT) |
| 821 | return version.VersionString() |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 822 | |
| 823 | |
| 824 | def determine_milestone_version(): |
| 825 | """Returns the platform version from the source root.""" |
| 826 | # Milestone version is something like '79'. |
| 827 | version = manifest_version.VersionInfo.from_repo(constants.SOURCE_ROOT) |
| 828 | return version.chrome_branch |
| 829 | |
Alex Klein | 7a3a7dd | 2020-01-08 16:44:38 -0700 | [diff] [blame] | 830 | |
Michael Mortensen | 009cb66 | 2019-10-21 11:38:43 -0600 | [diff] [blame] | 831 | def determine_full_version(): |
| 832 | """Returns the full version from the source root.""" |
| 833 | # Full version is something like 'R79-12575.0.0'. |
| 834 | milestone_version = determine_milestone_version() |
| 835 | platform_version = determine_platform_version() |
| 836 | full_version = ('R%s-%s' % (milestone_version, platform_version)) |
| 837 | return full_version |
Michael Mortensen | 71ef568 | 2020-05-07 14:29:24 -0600 | [diff] [blame] | 838 | |
| 839 | |
Michael Mortensen | de716a1 | 2020-05-15 11:27:00 -0600 | [diff] [blame] | 840 | def find_fingerprints(build_target): |
| 841 | """Returns a list of fingerprints for this build. |
| 842 | |
| 843 | Args: |
| 844 | build_target (build_target_lib.BuildTarget): The build target. |
| 845 | |
| 846 | Returns: |
| 847 | list[str] - List of fingerprint strings. |
| 848 | """ |
| 849 | cros_build_lib.AssertInsideChroot() |
| 850 | fp_file = 'cheets-fingerprint.txt' |
| 851 | fp_path = os.path.join( |
| 852 | image_lib.GetLatestImageLink(build_target.name), |
| 853 | fp_file) |
| 854 | if not os.path.isfile(fp_path): |
| 855 | logging.info('Fingerprint file not found: %s', fp_path) |
Michael Mortensen | d81d81e | 2020-06-09 14:20:59 -0600 | [diff] [blame] | 856 | return [] |
Michael Mortensen | de716a1 | 2020-05-15 11:27:00 -0600 | [diff] [blame] | 857 | logging.info('Reading fingerprint file: %s', fp_path) |
| 858 | fingerprints = osutils.ReadFile(fp_path).splitlines() |
| 859 | return fingerprints |
| 860 | |
| 861 | |
Michael Mortensen | 59e3087 | 2020-05-18 14:12:49 -0600 | [diff] [blame] | 862 | def get_all_firmware_versions(build_target): |
| 863 | """Extract firmware version for all models present. |
| 864 | |
| 865 | Args: |
| 866 | build_target (build_target_lib.BuildTarget): The build target. |
| 867 | |
| 868 | Returns: |
| 869 | A dict of FirmwareVersions namedtuple instances by model. |
| 870 | Each element will be populated based on whether it was present in the |
| 871 | command output. |
| 872 | """ |
| 873 | cros_build_lib.AssertInsideChroot() |
| 874 | result = {} |
| 875 | # Note that example output for _get_firmware_version_cmd_result is available |
| 876 | # in the packages_unittest.py for testing get_all_firmware_versions. |
| 877 | cmd_result = _get_firmware_version_cmd_result(build_target) |
| 878 | |
| 879 | # There is a blank line between the version info for each model. |
| 880 | firmware_version_payloads = cmd_result.split('\n\n') |
| 881 | for firmware_version_payload in firmware_version_payloads: |
| 882 | if 'BIOS' in firmware_version_payload: |
| 883 | firmware_version = _find_firmware_versions(firmware_version_payload) |
| 884 | result[firmware_version.model] = firmware_version |
| 885 | return result |
| 886 | |
| 887 | |
Michael Mortensen | 71ef568 | 2020-05-07 14:29:24 -0600 | [diff] [blame] | 888 | FirmwareVersions = collections.namedtuple( |
| 889 | 'FirmwareVersions', ['model', 'main', 'main_rw', 'ec', 'ec_rw']) |
| 890 | |
| 891 | |
| 892 | def get_firmware_versions(build_target): |
| 893 | """Extract version information from the firmware updater, if one exists. |
| 894 | |
| 895 | Args: |
| 896 | build_target (build_target_lib.BuildTarget): The build target. |
| 897 | |
| 898 | Returns: |
| 899 | A FirmwareVersions namedtuple instance. |
| 900 | Each element will either be set to the string output by the firmware |
| 901 | updater shellball, or None if there is no firmware updater. |
| 902 | """ |
| 903 | cros_build_lib.AssertInsideChroot() |
| 904 | cmd_result = _get_firmware_version_cmd_result(build_target) |
| 905 | if cmd_result: |
| 906 | return _find_firmware_versions(cmd_result) |
| 907 | else: |
| 908 | return FirmwareVersions(None, None, None, None, None) |
| 909 | |
| 910 | |
| 911 | def _get_firmware_version_cmd_result(build_target): |
| 912 | """Gets the raw result output of the firmware updater version command. |
| 913 | |
| 914 | Args: |
| 915 | build_target (build_target_lib.BuildTarget): The build target. |
| 916 | |
| 917 | Returns: |
| 918 | Command execution result. |
| 919 | """ |
| 920 | updater = os.path.join(build_target.root, |
| 921 | 'usr/sbin/chromeos-firmwareupdate') |
| 922 | logging.info('Calling updater %s', updater) |
| 923 | # Call the updater using the chroot-based path. |
| 924 | return cros_build_lib.run([updater, '-V'], |
| 925 | capture_output=True, log_output=True, |
| 926 | encoding='utf-8').stdout |
| 927 | |
| 928 | |
| 929 | def _find_firmware_versions(cmd_output): |
| 930 | """Finds firmware version output via regex matches against the cmd_output. |
| 931 | |
| 932 | Args: |
| 933 | cmd_output: The raw output to search against. |
| 934 | |
| 935 | Returns: |
| 936 | FirmwareVersions namedtuple with results. |
| 937 | Each element will either be set to the string output by the firmware |
| 938 | updater shellball, or None if there is no match. |
| 939 | """ |
| 940 | |
| 941 | # Sometimes a firmware bundle includes a special combination of RO+RW |
| 942 | # firmware. In this case, the RW firmware version is indicated with a "(RW) |
| 943 | # version" field. In other cases, the "(RW) version" field is not present. |
| 944 | # Therefore, search for the "(RW)" fields first and if they aren't present, |
| 945 | # fallback to the other format. e.g. just "BIOS version:". |
| 946 | # TODO(mmortensen): Use JSON once the firmware updater supports it. |
| 947 | main = None |
| 948 | main_rw = None |
| 949 | ec = None |
| 950 | ec_rw = None |
| 951 | model = None |
| 952 | |
| 953 | match = re.search(r'BIOS version:\s*(?P<version>.*)', cmd_output) |
| 954 | if match: |
| 955 | main = match.group('version') |
| 956 | |
| 957 | match = re.search(r'BIOS \(RW\) version:\s*(?P<version>.*)', cmd_output) |
| 958 | if match: |
| 959 | main_rw = match.group('version') |
| 960 | |
| 961 | match = re.search(r'EC version:\s*(?P<version>.*)', cmd_output) |
| 962 | if match: |
| 963 | ec = match.group('version') |
| 964 | |
| 965 | match = re.search(r'EC \(RW\) version:\s*(?P<version>.*)', cmd_output) |
| 966 | if match: |
| 967 | ec_rw = match.group('version') |
| 968 | |
| 969 | match = re.search(r'Model:\s*(?P<model>.*)', cmd_output) |
| 970 | if match: |
| 971 | model = match.group('model') |
| 972 | |
| 973 | return FirmwareVersions(model, main, main_rw, ec, ec_rw) |
Michael Mortensen | a4af79e | 2020-05-06 16:18:48 -0600 | [diff] [blame] | 974 | |
| 975 | |
| 976 | MainEcFirmwareVersions = collections.namedtuple( |
| 977 | 'MainEcFirmwareVersions', ['main_fw_version', 'ec_fw_version']) |
| 978 | |
| 979 | def determine_firmware_versions(build_target): |
| 980 | """Returns a namedtuple with main and ec firmware versions. |
| 981 | |
| 982 | Args: |
| 983 | build_target (build_target_lib.BuildTarget): The build target. |
| 984 | |
| 985 | Returns: |
| 986 | MainEcFirmwareVersions namedtuple with results. |
| 987 | """ |
| 988 | fw_versions = get_firmware_versions(build_target) |
| 989 | main_fw_version = fw_versions.main_rw or fw_versions.main |
| 990 | ec_fw_version = fw_versions.ec_rw or fw_versions.ec |
| 991 | |
| 992 | return MainEcFirmwareVersions(main_fw_version, ec_fw_version) |
Michael Mortensen | fbf2b2d | 2020-05-14 16:33:06 -0600 | [diff] [blame] | 993 | |
| 994 | def determine_kernel_version(build_target): |
| 995 | """Returns a string containing the kernel version for this build target. |
| 996 | |
| 997 | Args: |
| 998 | build_target (build_target_lib.BuildTarget): The build target. |
| 999 | |
| 1000 | Returns: |
| 1001 | (str) The kernel versions, or None. |
| 1002 | """ |
| 1003 | try: |
| 1004 | packages = portage_util.GetPackageDependencies(build_target.name, |
| 1005 | 'virtual/linux-sources') |
| 1006 | except cros_build_lib.RunCommandError as e: |
| 1007 | logging.warning('Unable to get package list for metadata: %s', e) |
| 1008 | return None |
| 1009 | for package in packages: |
| 1010 | if package.startswith('sys-kernel/chromeos-kernel-'): |
| 1011 | kernel_version = portage_util.SplitCPV(package).version |
| 1012 | logging.info('Found active kernel version: %s', kernel_version) |
| 1013 | return kernel_version |
| 1014 | return None |
Michael Mortensen | 125bb01 | 2020-05-21 14:02:10 -0600 | [diff] [blame] | 1015 | |
| 1016 | |
| 1017 | def get_models(build_target, log_output=True): |
| 1018 | """Obtain a list of models supported by a unified board. |
| 1019 | |
| 1020 | This ignored whitelabel models since GoldenEye has no specific support for |
| 1021 | these at present. |
| 1022 | |
| 1023 | Args: |
| 1024 | build_target (build_target_lib.BuildTarget): The build target. |
| 1025 | log_output: Whether to log the output of the cros_config_host invocation. |
| 1026 | |
| 1027 | Returns: |
| 1028 | A list of models supported by this board, if it is a unified build; None, |
| 1029 | if it is not a unified build. |
| 1030 | """ |
| 1031 | return _run_cros_config_host(build_target, ['list-models'], |
| 1032 | log_output=log_output) |
| 1033 | |
| 1034 | |
Michael Mortensen | 359c1f3 | 2020-05-28 19:35:42 -0600 | [diff] [blame] | 1035 | def get_key_id(build_target, model): |
| 1036 | """Obtain the key_id for a model within the build_target. |
| 1037 | |
| 1038 | Args: |
| 1039 | build_target (build_target_lib.BuildTarget): The build target. |
| 1040 | model (str): The model name |
| 1041 | |
| 1042 | Returns: |
| 1043 | A key_id (str) or None. |
| 1044 | """ |
| 1045 | model_arg = '--model=' + model |
| 1046 | key_id_list = _run_cros_config_host( |
| 1047 | build_target, |
| 1048 | [model_arg, 'get', '/firmware-signing', 'key-id']) |
| 1049 | key_id = None |
| 1050 | if len(key_id_list) == 1: |
| 1051 | key_id = key_id_list[0] |
| 1052 | return key_id |
| 1053 | |
| 1054 | |
Michael Mortensen | 125bb01 | 2020-05-21 14:02:10 -0600 | [diff] [blame] | 1055 | def _run_cros_config_host(build_target, args, log_output=True): |
| 1056 | """Run the cros_config_host tool. |
| 1057 | |
| 1058 | Args: |
| 1059 | build_target (build_target_lib.BuildTarget): The build target. |
| 1060 | args: List of arguments to pass. |
| 1061 | log_output: Whether to log the output of the cros_config_host. |
| 1062 | |
| 1063 | Returns: |
| 1064 | Output of the tool |
| 1065 | """ |
| 1066 | cros_build_lib.AssertInsideChroot() |
| 1067 | tool = '/usr/bin/cros_config_host' |
| 1068 | if not os.path.isfile(tool): |
| 1069 | return None |
| 1070 | |
| 1071 | config_fname = build_target.full_path( |
| 1072 | 'usr/share/chromeos-config/yaml/config.yaml') |
| 1073 | |
| 1074 | result = cros_build_lib.run( |
| 1075 | [tool, '-c', config_fname] + args, |
| 1076 | capture_output=True, |
| 1077 | encoding='utf-8', |
| 1078 | log_output=log_output, |
| 1079 | check=False) |
| 1080 | if result.returncode: |
| 1081 | # Show the output for debugging purposes. |
| 1082 | if 'No such file or directory' not in result.error: |
| 1083 | logging.error('cros_config_host failed: %s\n', result.error) |
| 1084 | return None |
| 1085 | return result.output.strip().splitlines() |