blob: 04db7b1f519e54210f8c3a4fa610d07baf45f806 [file] [log] [blame]
Steven Bennettsddf9bcd2017-06-14 14:07:43 -07001# Copyright 2017 The Chromium OS Authors. All rights reserved.
2# Use of this source code is governed by a BSD-style license that can be
3# found in the LICENSE file.
4
5"""Unit tests for the chrome_chromeos_lkgm program."""
6
Ben Pastene6a8361a2021-08-19 19:52:05 -07007from unittest import mock
Ben Pasteneca7c71b2021-10-07 18:34:27 -07008import urllib.parse
Steven Bennettsddf9bcd2017-06-14 14:07:43 -07009
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070010from chromite.lib import cros_test_lib
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070011from chromite.scripts import chrome_chromeos_lkgm
12
Achuith Bhandarkarec8d7a72018-03-01 16:56:22 -080013
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070014# pylint: disable=protected-access
Benjamin Gordon121a2aa2018-05-04 16:24:45 -060015class ChromeLKGMCommitterTester(cros_test_lib.RunCommandTestCase,
Achuith Bhandarkardc3a3512018-03-16 15:10:57 -070016 cros_test_lib.MockTempDirTestCase):
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070017 """Test cros_chromeos_lkgm.Committer."""
Achuith Bhandarkarec8d7a72018-03-01 16:56:22 -080018
Achuith Bhandarkardc3a3512018-03-16 15:10:57 -070019 def setUp(self):
20 """Common set up method for all tests."""
21 self.committer = chrome_chromeos_lkgm.ChromeLKGMCommitter(
Ben Pastene769b1212021-12-14 18:26:50 -080022 'user@test.org', '1001.0.0')
Achuith Bhandarkardc3a3512018-03-16 15:10:57 -070023 self.old_lkgm = None
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070024
Ben Pastene769b1212021-12-14 18:26:50 -080025 @mock.patch('chromite.lib.gob_util.GetFileContentsOnHead')
26 def testCommitNewLKGM(self, mock_get_file):
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070027 """Tests that we can commit a new LKGM file."""
Ben Pastene769b1212021-12-14 18:26:50 -080028 mock_get_file.return_value = '999.0.0'
29 with mock.patch.object(self.committer._gerrit_helper, 'CreateChange') as cg:
30 cg.return_value = mock.MagicMock(gerrit_number=123456)
31 with mock.patch.object(self.committer._gerrit_helper, 'ChangeEdit') as ce:
32 self.committer.UpdateLKGM()
33 ce.assert_called_once_with(123456, 'chromeos/CHROMEOS_LKGM', '1001.0.0')
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070034
Ben Pastene769b1212021-12-14 18:26:50 -080035 @mock.patch('chromite.lib.gob_util.GetFileContentsOnHead')
36 def testOlderLKGMFails(self, mock_get_file):
Steven Bennetts4bc322a2017-08-28 09:37:39 -070037 """Tests that trying to update to an older lkgm version fails."""
Ben Pastene769b1212021-12-14 18:26:50 -080038 mock_get_file.return_value = '1002.0.0'
39 with mock.patch.object(self.committer._gerrit_helper, 'CreateChange') as cg:
40 cg.return_value = mock.MagicMock(gerrit_number=123456)
41 with mock.patch.object(self.committer._gerrit_helper, 'ChangeEdit') as ce:
42 self.assertRaises(chrome_chromeos_lkgm.LKGMNotValid,
43 self.committer.UpdateLKGM)
44 ce.assert_not_called()
Steven Bennetts4bc322a2017-08-28 09:37:39 -070045
Ben Pastene769b1212021-12-14 18:26:50 -080046 @mock.patch('chromite.lib.gob_util.GetFileContentsOnHead')
47 def testVersionWithChromeBranch(self, mock_get_file):
Steven Bennetts4bc322a2017-08-28 09:37:39 -070048 """Tests passing a version with a chrome branch strips the branch."""
Achuith Bhandarkar1b9180f2018-02-22 19:12:09 -080049 self.committer = chrome_chromeos_lkgm.ChromeLKGMCommitter(
Ben Pastene769b1212021-12-14 18:26:50 -080050 'user@test.org', '1003.0.0-rc2')
51 mock_get_file.return_value = '1002.0.0'
Steven Bennetts4bc322a2017-08-28 09:37:39 -070052
Ben Pastene769b1212021-12-14 18:26:50 -080053 with mock.patch.object(self.committer._gerrit_helper, 'CreateChange') as cg:
54 cg.return_value = mock.MagicMock(gerrit_number=123456)
55 with mock.patch.object(self.committer._gerrit_helper, 'ChangeEdit') as ce:
56 # Check the file was actually written out correctly.
57 self.committer.UpdateLKGM()
58 ce.assert_called_once_with(123456, 'chromeos/CHROMEOS_LKGM', '1003.0.0')
Ben Pastened3b93d42019-10-10 09:56:29 -070059
60 def testCommitMsg(self):
61 """Tests format of the commit message."""
Ben Pastened3b93d42019-10-10 09:56:29 -070062 self.committer._PRESUBMIT_BOTS = ['bot1', 'bot2']
Ben Pastenef0fb0622021-09-24 23:38:13 +000063 self.committer._buildbucket_id = 'some-build-id'
Ben Pastened3b93d42019-10-10 09:56:29 -070064 commit_msg_lines = self.committer.ComposeCommitMsg().splitlines()
Ben Pastene769b1212021-12-14 18:26:50 -080065 self.assertIn(
66 'Automated Commit: LKGM 1001.0.0 for chromeos.', commit_msg_lines)
Ben Pastenef0fb0622021-09-24 23:38:13 +000067 self.assertIn(
68 'Uploaded by https://ci.chromium.org/b/some-build-id', commit_msg_lines)
Ben Pastened3b93d42019-10-10 09:56:29 -070069 self.assertIn('CQ_INCLUDE_TRYBOTS=luci.chrome.try:bot1', commit_msg_lines)
70 self.assertIn('CQ_INCLUDE_TRYBOTS=luci.chrome.try:bot2', commit_msg_lines)
Ben Pastene6a8361a2021-08-19 19:52:05 -070071
72 def testFindAlreadyOpenLKGMRoll(self):
73 already_open_issues = [123456]
Ben Pasteneca7c71b2021-10-07 18:34:27 -070074 self.committer._commit_msg_header = 'A message with spaces'
Ben Pastene6a8361a2021-08-19 19:52:05 -070075 with mock.patch.object(
76 self.committer._gerrit_helper, 'Query',
Ben Pasteneca7c71b2021-10-07 18:34:27 -070077 return_value=already_open_issues) as mock_query:
Ben Pastene6a8361a2021-08-19 19:52:05 -070078 self.assertEqual(
79 self.committer.FindAlreadyOpenLKGMRoll(),
80 already_open_issues[0])
Ben Pasteneca7c71b2021-10-07 18:34:27 -070081 escaped_quotes = urllib.parse.quote('"')
82 message = mock_query.call_args.kwargs['message']
83 self.assertEqual(message.count(escaped_quotes), 2)
84 self.assertTrue(message.startswith(escaped_quotes))
85 self.assertTrue(message.endswith(escaped_quotes))
Ben Pastene6a8361a2021-08-19 19:52:05 -070086 already_open_issues = [123456, 654321]
87 with mock.patch.object(
88 self.committer._gerrit_helper, 'Query',
89 return_value=already_open_issues):
90 self.assertRaises(
91 chrome_chromeos_lkgm.LKGMNotValid,
92 self.committer.FindAlreadyOpenLKGMRoll)
93
94 def testSubmitToCQ(self):
Ben Pastene33da0c22021-11-29 21:14:05 -080095 self.committer._buildbucket_id = 'some-build-id'
Ben Pastene6a8361a2021-08-19 19:52:05 -070096 already_open_issue = 123456
Ben Pastene33da0c22021-11-29 21:14:05 -080097 with mock.patch.object(
98 self.committer._gerrit_helper, 'SetReview') as mock_review:
Ben Pastene6a8361a2021-08-19 19:52:05 -070099 self.committer.SubmitToCQ(already_open_issue)
Ben Pastene33da0c22021-11-29 21:14:05 -0800100 self.assertIn(
101 self.committer._buildbucket_id, mock_review.call_args[1]['msg'])