blob: 19308c15d4c0788aa5a988ef03ac7c606ded5e00 [file] [log] [blame]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001#!/usr/bin/python2.4
2#
erg@google.com26970fa2009-11-17 18:07:32 +00003# Copyright (c) 2009 Google Inc. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00004#
erg@google.com26970fa2009-11-17 18:07:32 +00005# Redistribution and use in source and binary forms, with or without
6# modification, are permitted provided that the following conditions are
7# met:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00008#
erg@google.com26970fa2009-11-17 18:07:32 +00009# * Redistributions of source code must retain the above copyright
10# notice, this list of conditions and the following disclaimer.
11# * Redistributions in binary form must reproduce the above
12# copyright notice, this list of conditions and the following disclaimer
13# in the documentation and/or other materials provided with the
14# distribution.
15# * Neither the name of Google Inc. nor the names of its
16# contributors may be used to endorse or promote products derived from
17# this software without specific prior written permission.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000018#
erg@google.com26970fa2009-11-17 18:07:32 +000019# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
20# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
21# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
22# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
23# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
24# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
25# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
26# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
27# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
28# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
29# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030
31# Here are some issues that I've had people identify in my code during reviews,
32# that I think are possible to flag automatically in a lint tool. If these were
33# caught by lint, it would save time both for myself and that of my reviewers.
34# Most likely, some of these are beyond the scope of the current lint framework,
35# but I think it is valuable to retain these wish-list items even if they cannot
36# be immediately implemented.
37#
38# Suggestions
39# -----------
40# - Check for no 'explicit' for multi-arg ctor
41# - Check for boolean assign RHS in parens
42# - Check for ctor initializer-list colon position and spacing
43# - Check that if there's a ctor, there should be a dtor
44# - Check accessors that return non-pointer member variables are
45# declared const
46# - Check accessors that return non-const pointer member vars are
47# *not* declared const
48# - Check for using public includes for testing
49# - Check for spaces between brackets in one-line inline method
50# - Check for no assert()
51# - Check for spaces surrounding operators
52# - Check for 0 in pointer context (should be NULL)
53# - Check for 0 in char context (should be '\0')
54# - Check for camel-case method name conventions for methods
55# that are not simple inline getters and setters
56# - Check that base classes have virtual destructors
57# put " // namespace" after } that closes a namespace, with
58# namespace's name after 'namespace' if it is named.
59# - Do not indent namespace contents
60# - Avoid inlining non-trivial constructors in header files
61# include base/basictypes.h if DISALLOW_EVIL_CONSTRUCTORS is used
62# - Check for old-school (void) cast for call-sites of functions
63# ignored return value
64# - Check gUnit usage of anonymous namespace
65# - Check for class declaration order (typedefs, consts, enums,
66# ctor(s?), dtor, friend declarations, methods, member vars)
67#
68
69"""Does google-lint on c++ files.
70
71The goal of this script is to identify places in the code that *may*
72be in non-compliance with google style. It does not attempt to fix
73up these problems -- the point is to educate. It does also not
74attempt to find all problems, or to ensure that everything it does
75find is legitimately a problem.
76
77In particular, we can get very confused by /* and // inside strings!
78We do a small hack, which is to ignore //'s with "'s after them on the
79same line, but it is far from perfect (in either direction).
80"""
81
82import codecs
83import getopt
84import math # for log
85import os
86import re
87import sre_compile
88import string
89import sys
90import unicodedata
91
92
93_USAGE = """
94Syntax: cpplint.py [--verbose=#] [--output=vs7] [--filter=-x,+y,...]
erg@google.com26970fa2009-11-17 18:07:32 +000095 [--counting=total|toplevel|detailed]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000096 <file> [file] ...
97
98 The style guidelines this tries to follow are those in
99 http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
100
101 Every problem is given a confidence score from 1-5, with 5 meaning we are
102 certain of the problem, and 1 meaning it could be a legitimate construct.
103 This will miss some errors, and is not a substitute for a code review.
104
erg@google.com35589e62010-11-17 18:58:16 +0000105 To suppress false-positive errors of a certain category, add a
106 'NOLINT(category)' comment to the line. NOLINT or NOLINT(*)
107 suppresses errors of all categories on that line.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000108
109 The files passed in will be linted; at least one file must be provided.
110 Linted extensions are .cc, .cpp, and .h. Other file types will be ignored.
111
112 Flags:
113
114 output=vs7
115 By default, the output is formatted to ease emacs parsing. Visual Studio
116 compatible output (vs7) may also be used. Other formats are unsupported.
117
118 verbose=#
119 Specify a number 0-5 to restrict errors to certain verbosity levels.
120
121 filter=-x,+y,...
122 Specify a comma-separated list of category-filters to apply: only
123 error messages whose category names pass the filters will be printed.
124 (Category names are printed with the message and look like
125 "[whitespace/indent]".) Filters are evaluated left to right.
126 "-FOO" and "FOO" means "do not print categories that start with FOO".
127 "+FOO" means "do print categories that start with FOO".
128
129 Examples: --filter=-whitespace,+whitespace/braces
130 --filter=whitespace,runtime/printf,+runtime/printf_format
131 --filter=-,+build/include_what_you_use
132
133 To see a list of all the categories used in cpplint, pass no arg:
134 --filter=
erg@google.com26970fa2009-11-17 18:07:32 +0000135
136 counting=total|toplevel|detailed
137 The total number of errors found is always printed. If
138 'toplevel' is provided, then the count of errors in each of
139 the top-level categories like 'build' and 'whitespace' will
140 also be printed. If 'detailed' is provided, then a count
141 is provided for each category like 'build/class'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000142"""
143
144# We categorize each error message we print. Here are the categories.
145# We want an explicit list so we can list them all in cpplint --filter=.
146# If you add a new error message with a new category, add it to the list
147# here! cpplint_unittest.py should tell you if you forget to do this.
erg@google.com6317a9c2009-06-25 00:28:19 +0000148# \ used for clearer layout -- pylint: disable-msg=C6013
erg@google.com35589e62010-11-17 18:58:16 +0000149_ERROR_CATEGORIES = [
150 'build/class',
151 'build/deprecated',
152 'build/endif_comment',
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +0000153 'build/explicit_make_pair',
erg@google.com35589e62010-11-17 18:58:16 +0000154 'build/forward_decl',
155 'build/header_guard',
156 'build/include',
157 'build/include_alpha',
158 'build/include_order',
159 'build/include_what_you_use',
160 'build/namespaces',
161 'build/printf_format',
162 'build/storage_class',
163 'legal/copyright',
164 'readability/braces',
165 'readability/casting',
166 'readability/check',
167 'readability/constructors',
168 'readability/fn_size',
169 'readability/function',
170 'readability/multiline_comment',
171 'readability/multiline_string',
172 'readability/nolint',
173 'readability/streams',
174 'readability/todo',
175 'readability/utf8',
176 'runtime/arrays',
177 'runtime/casting',
178 'runtime/explicit',
179 'runtime/int',
180 'runtime/init',
181 'runtime/invalid_increment',
182 'runtime/member_string_references',
183 'runtime/memset',
184 'runtime/operator',
185 'runtime/printf',
186 'runtime/printf_format',
187 'runtime/references',
188 'runtime/rtti',
189 'runtime/sizeof',
190 'runtime/string',
191 'runtime/threadsafe_fn',
192 'runtime/virtual',
193 'whitespace/blank_line',
194 'whitespace/braces',
195 'whitespace/comma',
196 'whitespace/comments',
197 'whitespace/end_of_line',
198 'whitespace/ending_newline',
199 'whitespace/indent',
200 'whitespace/labels',
201 'whitespace/line_length',
202 'whitespace/newline',
203 'whitespace/operators',
204 'whitespace/parens',
205 'whitespace/semicolon',
206 'whitespace/tab',
207 'whitespace/todo'
208 ]
erg@google.com6317a9c2009-06-25 00:28:19 +0000209
210# The default state of the category filter. This is overrided by the --filter=
211# flag. By default all errors are on, so only add here categories that should be
212# off by default (i.e., categories that must be enabled by the --filter= flags).
213# All entries here should start with a '-' or '+', as in the --filter= flag.
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +0000214_DEFAULT_FILTERS = ['-build/include_alpha']
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000215
216# We used to check for high-bit characters, but after much discussion we
217# decided those were OK, as long as they were in UTF-8 and didn't represent
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +0000218# hard-coded international strings, which belong in a separate i18n file.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000219
220# Headers that we consider STL headers.
221_STL_HEADERS = frozenset([
222 'algobase.h', 'algorithm', 'alloc.h', 'bitset', 'deque', 'exception',
223 'function.h', 'functional', 'hash_map', 'hash_map.h', 'hash_set',
erg@google.com35589e62010-11-17 18:58:16 +0000224 'hash_set.h', 'iterator', 'list', 'list.h', 'map', 'memory', 'new',
225 'pair.h', 'pthread_alloc', 'queue', 'set', 'set.h', 'sstream', 'stack',
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000226 'stl_alloc.h', 'stl_relops.h', 'type_traits.h',
227 'utility', 'vector', 'vector.h',
228 ])
229
230
231# Non-STL C++ system headers.
232_CPP_HEADERS = frozenset([
233 'algo.h', 'builtinbuf.h', 'bvector.h', 'cassert', 'cctype',
234 'cerrno', 'cfloat', 'ciso646', 'climits', 'clocale', 'cmath',
235 'complex', 'complex.h', 'csetjmp', 'csignal', 'cstdarg', 'cstddef',
236 'cstdio', 'cstdlib', 'cstring', 'ctime', 'cwchar', 'cwctype',
237 'defalloc.h', 'deque.h', 'editbuf.h', 'exception', 'fstream',
238 'fstream.h', 'hashtable.h', 'heap.h', 'indstream.h', 'iomanip',
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +0000239 'iomanip.h', 'ios', 'iosfwd', 'iostream', 'iostream.h', 'istream',
240 'istream.h', 'iterator.h', 'limits', 'map.h', 'multimap.h', 'multiset.h',
241 'numeric', 'ostream', 'ostream.h', 'parsestream.h', 'pfstream.h',
242 'PlotFile.h', 'procbuf.h', 'pthread_alloc.h', 'rope', 'rope.h',
243 'ropeimpl.h', 'SFile.h', 'slist', 'slist.h', 'stack.h', 'stdexcept',
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000244 'stdiostream.h', 'streambuf.h', 'stream.h', 'strfile.h', 'string',
245 'strstream', 'strstream.h', 'tempbuf.h', 'tree.h', 'typeinfo', 'valarray',
246 ])
247
248
249# Assertion macros. These are defined in base/logging.h and
250# testing/base/gunit.h. Note that the _M versions need to come first
251# for substring matching to work.
252_CHECK_MACROS = [
erg@google.com6317a9c2009-06-25 00:28:19 +0000253 'DCHECK', 'CHECK',
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000254 'EXPECT_TRUE_M', 'EXPECT_TRUE',
255 'ASSERT_TRUE_M', 'ASSERT_TRUE',
256 'EXPECT_FALSE_M', 'EXPECT_FALSE',
257 'ASSERT_FALSE_M', 'ASSERT_FALSE',
258 ]
259
erg@google.com6317a9c2009-06-25 00:28:19 +0000260# Replacement macros for CHECK/DCHECK/EXPECT_TRUE/EXPECT_FALSE
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000261_CHECK_REPLACEMENT = dict([(m, {}) for m in _CHECK_MACROS])
262
263for op, replacement in [('==', 'EQ'), ('!=', 'NE'),
264 ('>=', 'GE'), ('>', 'GT'),
265 ('<=', 'LE'), ('<', 'LT')]:
erg@google.com6317a9c2009-06-25 00:28:19 +0000266 _CHECK_REPLACEMENT['DCHECK'][op] = 'DCHECK_%s' % replacement
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000267 _CHECK_REPLACEMENT['CHECK'][op] = 'CHECK_%s' % replacement
268 _CHECK_REPLACEMENT['EXPECT_TRUE'][op] = 'EXPECT_%s' % replacement
269 _CHECK_REPLACEMENT['ASSERT_TRUE'][op] = 'ASSERT_%s' % replacement
270 _CHECK_REPLACEMENT['EXPECT_TRUE_M'][op] = 'EXPECT_%s_M' % replacement
271 _CHECK_REPLACEMENT['ASSERT_TRUE_M'][op] = 'ASSERT_%s_M' % replacement
272
273for op, inv_replacement in [('==', 'NE'), ('!=', 'EQ'),
274 ('>=', 'LT'), ('>', 'LE'),
275 ('<=', 'GT'), ('<', 'GE')]:
276 _CHECK_REPLACEMENT['EXPECT_FALSE'][op] = 'EXPECT_%s' % inv_replacement
277 _CHECK_REPLACEMENT['ASSERT_FALSE'][op] = 'ASSERT_%s' % inv_replacement
278 _CHECK_REPLACEMENT['EXPECT_FALSE_M'][op] = 'EXPECT_%s_M' % inv_replacement
279 _CHECK_REPLACEMENT['ASSERT_FALSE_M'][op] = 'ASSERT_%s_M' % inv_replacement
280
281
282# These constants define types of headers for use with
283# _IncludeState.CheckNextIncludeOrder().
284_C_SYS_HEADER = 1
285_CPP_SYS_HEADER = 2
286_LIKELY_MY_HEADER = 3
287_POSSIBLE_MY_HEADER = 4
288_OTHER_HEADER = 5
289
290
291_regexp_compile_cache = {}
292
erg@google.com35589e62010-11-17 18:58:16 +0000293# Finds occurrences of NOLINT or NOLINT(...).
294_RE_SUPPRESSION = re.compile(r'\bNOLINT\b(\([^)]*\))?')
295
296# {str, set(int)}: a map from error categories to sets of linenumbers
297# on which those errors are expected and should be suppressed.
298_error_suppressions = {}
299
300def ParseNolintSuppressions(filename, raw_line, linenum, error):
301 """Updates the global list of error-suppressions.
302
303 Parses any NOLINT comments on the current line, updating the global
304 error_suppressions store. Reports an error if the NOLINT comment
305 was malformed.
306
307 Args:
308 filename: str, the name of the input file.
309 raw_line: str, the line of input text, with comments.
310 linenum: int, the number of the current line.
311 error: function, an error handler.
312 """
313 # FIXME(adonovan): "NOLINT(" is misparsed as NOLINT(*).
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +0000314 matched = _RE_SUPPRESSION.search(raw_line)
315 if matched:
316 category = matched.group(1)
erg@google.com35589e62010-11-17 18:58:16 +0000317 if category in (None, '(*)'): # => "suppress all"
318 _error_suppressions.setdefault(None, set()).add(linenum)
319 else:
320 if category.startswith('(') and category.endswith(')'):
321 category = category[1:-1]
322 if category in _ERROR_CATEGORIES:
323 _error_suppressions.setdefault(category, set()).add(linenum)
324 else:
325 error(filename, linenum, 'readability/nolint', 5,
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +0000326 'Unknown NOLINT error category: %s' % category)
erg@google.com35589e62010-11-17 18:58:16 +0000327
328
329def ResetNolintSuppressions():
330 "Resets the set of NOLINT suppressions to empty."
331 _error_suppressions.clear()
332
333
334def IsErrorSuppressedByNolint(category, linenum):
335 """Returns true if the specified error category is suppressed on this line.
336
337 Consults the global error_suppressions map populated by
338 ParseNolintSuppressions/ResetNolintSuppressions.
339
340 Args:
341 category: str, the category of the error.
342 linenum: int, the current line number.
343 Returns:
344 bool, True iff the error should be suppressed due to a NOLINT comment.
345 """
346 return (linenum in _error_suppressions.get(category, set()) or
347 linenum in _error_suppressions.get(None, set()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000348
349def Match(pattern, s):
350 """Matches the string with the pattern, caching the compiled regexp."""
351 # The regexp compilation caching is inlined in both Match and Search for
352 # performance reasons; factoring it out into a separate function turns out
353 # to be noticeably expensive.
354 if not pattern in _regexp_compile_cache:
355 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
356 return _regexp_compile_cache[pattern].match(s)
357
358
359def Search(pattern, s):
360 """Searches the string for the pattern, caching the compiled regexp."""
361 if not pattern in _regexp_compile_cache:
362 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
363 return _regexp_compile_cache[pattern].search(s)
364
365
366class _IncludeState(dict):
367 """Tracks line numbers for includes, and the order in which includes appear.
368
369 As a dict, an _IncludeState object serves as a mapping between include
370 filename and line number on which that file was included.
371
372 Call CheckNextIncludeOrder() once for each header in the file, passing
373 in the type constants defined above. Calls in an illegal order will
374 raise an _IncludeError with an appropriate error message.
375
376 """
377 # self._section will move monotonically through this set. If it ever
378 # needs to move backwards, CheckNextIncludeOrder will raise an error.
379 _INITIAL_SECTION = 0
380 _MY_H_SECTION = 1
381 _C_SECTION = 2
382 _CPP_SECTION = 3
383 _OTHER_H_SECTION = 4
384
385 _TYPE_NAMES = {
386 _C_SYS_HEADER: 'C system header',
387 _CPP_SYS_HEADER: 'C++ system header',
388 _LIKELY_MY_HEADER: 'header this file implements',
389 _POSSIBLE_MY_HEADER: 'header this file may implement',
390 _OTHER_HEADER: 'other header',
391 }
392 _SECTION_NAMES = {
393 _INITIAL_SECTION: "... nothing. (This can't be an error.)",
394 _MY_H_SECTION: 'a header this file implements',
395 _C_SECTION: 'C system header',
396 _CPP_SECTION: 'C++ system header',
397 _OTHER_H_SECTION: 'other header',
398 }
399
400 def __init__(self):
401 dict.__init__(self)
erg@google.com26970fa2009-11-17 18:07:32 +0000402 # The name of the current section.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000403 self._section = self._INITIAL_SECTION
erg@google.com26970fa2009-11-17 18:07:32 +0000404 # The path of last found header.
405 self._last_header = ''
406
407 def CanonicalizeAlphabeticalOrder(self, header_path):
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +0000408 """Returns a path canonicalized for alphabetical comparison.
erg@google.com26970fa2009-11-17 18:07:32 +0000409
410 - replaces "-" with "_" so they both cmp the same.
411 - removes '-inl' since we don't require them to be after the main header.
412 - lowercase everything, just in case.
413
414 Args:
415 header_path: Path to be canonicalized.
416
417 Returns:
418 Canonicalized path.
419 """
420 return header_path.replace('-inl.h', '.h').replace('-', '_').lower()
421
422 def IsInAlphabeticalOrder(self, header_path):
423 """Check if a header is in alphabetical order with the previous header.
424
425 Args:
426 header_path: Header to be checked.
427
428 Returns:
429 Returns true if the header is in alphabetical order.
430 """
431 canonical_header = self.CanonicalizeAlphabeticalOrder(header_path)
432 if self._last_header > canonical_header:
433 return False
434 self._last_header = canonical_header
435 return True
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000436
437 def CheckNextIncludeOrder(self, header_type):
438 """Returns a non-empty error message if the next header is out of order.
439
440 This function also updates the internal state to be ready to check
441 the next include.
442
443 Args:
444 header_type: One of the _XXX_HEADER constants defined above.
445
446 Returns:
447 The empty string if the header is in the right order, or an
448 error message describing what's wrong.
449
450 """
451 error_message = ('Found %s after %s' %
452 (self._TYPE_NAMES[header_type],
453 self._SECTION_NAMES[self._section]))
454
erg@google.com26970fa2009-11-17 18:07:32 +0000455 last_section = self._section
456
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000457 if header_type == _C_SYS_HEADER:
458 if self._section <= self._C_SECTION:
459 self._section = self._C_SECTION
460 else:
erg@google.com26970fa2009-11-17 18:07:32 +0000461 self._last_header = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000462 return error_message
463 elif header_type == _CPP_SYS_HEADER:
464 if self._section <= self._CPP_SECTION:
465 self._section = self._CPP_SECTION
466 else:
erg@google.com26970fa2009-11-17 18:07:32 +0000467 self._last_header = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000468 return error_message
469 elif header_type == _LIKELY_MY_HEADER:
470 if self._section <= self._MY_H_SECTION:
471 self._section = self._MY_H_SECTION
472 else:
473 self._section = self._OTHER_H_SECTION
474 elif header_type == _POSSIBLE_MY_HEADER:
475 if self._section <= self._MY_H_SECTION:
476 self._section = self._MY_H_SECTION
477 else:
478 # This will always be the fallback because we're not sure
479 # enough that the header is associated with this file.
480 self._section = self._OTHER_H_SECTION
481 else:
482 assert header_type == _OTHER_HEADER
483 self._section = self._OTHER_H_SECTION
484
erg@google.com26970fa2009-11-17 18:07:32 +0000485 if last_section != self._section:
486 self._last_header = ''
487
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000488 return ''
489
490
491class _CppLintState(object):
492 """Maintains module-wide state.."""
493
494 def __init__(self):
495 self.verbose_level = 1 # global setting.
496 self.error_count = 0 # global count of reported errors
erg@google.com6317a9c2009-06-25 00:28:19 +0000497 # filters to apply when emitting error messages
498 self.filters = _DEFAULT_FILTERS[:]
erg@google.com26970fa2009-11-17 18:07:32 +0000499 self.counting = 'total' # In what way are we counting errors?
500 self.errors_by_category = {} # string to int dict storing error counts
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000501
502 # output format:
503 # "emacs" - format that emacs can parse (default)
504 # "vs7" - format that Microsoft Visual Studio 7 can parse
505 self.output_format = 'emacs'
506
507 def SetOutputFormat(self, output_format):
508 """Sets the output format for errors."""
509 self.output_format = output_format
510
511 def SetVerboseLevel(self, level):
512 """Sets the module's verbosity, and returns the previous setting."""
513 last_verbose_level = self.verbose_level
514 self.verbose_level = level
515 return last_verbose_level
516
erg@google.com26970fa2009-11-17 18:07:32 +0000517 def SetCountingStyle(self, counting_style):
518 """Sets the module's counting options."""
519 self.counting = counting_style
520
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000521 def SetFilters(self, filters):
522 """Sets the error-message filters.
523
524 These filters are applied when deciding whether to emit a given
525 error message.
526
527 Args:
528 filters: A string of comma-separated filters (eg "+whitespace/indent").
529 Each filter should start with + or -; else we die.
erg@google.com6317a9c2009-06-25 00:28:19 +0000530
531 Raises:
532 ValueError: The comma-separated filters did not all start with '+' or '-'.
533 E.g. "-,+whitespace,-whitespace/indent,whitespace/badfilter"
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000534 """
erg@google.com6317a9c2009-06-25 00:28:19 +0000535 # Default filters always have less priority than the flag ones.
536 self.filters = _DEFAULT_FILTERS[:]
537 for filt in filters.split(','):
538 clean_filt = filt.strip()
539 if clean_filt:
540 self.filters.append(clean_filt)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000541 for filt in self.filters:
542 if not (filt.startswith('+') or filt.startswith('-')):
543 raise ValueError('Every filter in --filters must start with + or -'
544 ' (%s does not)' % filt)
545
erg@google.com26970fa2009-11-17 18:07:32 +0000546 def ResetErrorCounts(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000547 """Sets the module's error statistic back to zero."""
548 self.error_count = 0
erg@google.com26970fa2009-11-17 18:07:32 +0000549 self.errors_by_category = {}
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000550
erg@google.com26970fa2009-11-17 18:07:32 +0000551 def IncrementErrorCount(self, category):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000552 """Bumps the module's error statistic."""
553 self.error_count += 1
erg@google.com26970fa2009-11-17 18:07:32 +0000554 if self.counting in ('toplevel', 'detailed'):
555 if self.counting != 'detailed':
556 category = category.split('/')[0]
557 if category not in self.errors_by_category:
558 self.errors_by_category[category] = 0
559 self.errors_by_category[category] += 1
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000560
erg@google.com26970fa2009-11-17 18:07:32 +0000561 def PrintErrorCounts(self):
562 """Print a summary of errors by category, and the total."""
563 for category, count in self.errors_by_category.iteritems():
564 sys.stderr.write('Category \'%s\' errors found: %d\n' %
565 (category, count))
566 sys.stderr.write('Total errors found: %d\n' % self.error_count)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000567
568_cpplint_state = _CppLintState()
569
570
571def _OutputFormat():
572 """Gets the module's output format."""
573 return _cpplint_state.output_format
574
575
576def _SetOutputFormat(output_format):
577 """Sets the module's output format."""
578 _cpplint_state.SetOutputFormat(output_format)
579
580
581def _VerboseLevel():
582 """Returns the module's verbosity setting."""
583 return _cpplint_state.verbose_level
584
585
586def _SetVerboseLevel(level):
587 """Sets the module's verbosity, and returns the previous setting."""
588 return _cpplint_state.SetVerboseLevel(level)
589
590
erg@google.com26970fa2009-11-17 18:07:32 +0000591def _SetCountingStyle(level):
592 """Sets the module's counting options."""
593 _cpplint_state.SetCountingStyle(level)
594
595
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000596def _Filters():
597 """Returns the module's list of output filters, as a list."""
598 return _cpplint_state.filters
599
600
601def _SetFilters(filters):
602 """Sets the module's error-message filters.
603
604 These filters are applied when deciding whether to emit a given
605 error message.
606
607 Args:
608 filters: A string of comma-separated filters (eg "whitespace/indent").
609 Each filter should start with + or -; else we die.
610 """
611 _cpplint_state.SetFilters(filters)
612
613
614class _FunctionState(object):
615 """Tracks current function name and the number of lines in its body."""
616
617 _NORMAL_TRIGGER = 250 # for --v=0, 500 for --v=1, etc.
618 _TEST_TRIGGER = 400 # about 50% more than _NORMAL_TRIGGER.
619
620 def __init__(self):
621 self.in_a_function = False
622 self.lines_in_function = 0
623 self.current_function = ''
624
625 def Begin(self, function_name):
626 """Start analyzing function body.
627
628 Args:
629 function_name: The name of the function being tracked.
630 """
631 self.in_a_function = True
632 self.lines_in_function = 0
633 self.current_function = function_name
634
635 def Count(self):
636 """Count line in current function body."""
637 if self.in_a_function:
638 self.lines_in_function += 1
639
640 def Check(self, error, filename, linenum):
641 """Report if too many lines in function body.
642
643 Args:
644 error: The function to call with any errors found.
645 filename: The name of the current file.
646 linenum: The number of the line to check.
647 """
648 if Match(r'T(EST|est)', self.current_function):
649 base_trigger = self._TEST_TRIGGER
650 else:
651 base_trigger = self._NORMAL_TRIGGER
652 trigger = base_trigger * 2**_VerboseLevel()
653
654 if self.lines_in_function > trigger:
655 error_level = int(math.log(self.lines_in_function / base_trigger, 2))
656 # 50 => 0, 100 => 1, 200 => 2, 400 => 3, 800 => 4, 1600 => 5, ...
657 if error_level > 5:
658 error_level = 5
659 error(filename, linenum, 'readability/fn_size', error_level,
660 'Small and focused functions are preferred:'
661 ' %s has %d non-comment lines'
662 ' (error triggered by exceeding %d lines).' % (
663 self.current_function, self.lines_in_function, trigger))
664
665 def End(self):
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +0000666 """Stop analyzing function body."""
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000667 self.in_a_function = False
668
669
670class _IncludeError(Exception):
671 """Indicates a problem with the include order in a file."""
672 pass
673
674
675class FileInfo:
676 """Provides utility functions for filenames.
677
678 FileInfo provides easy access to the components of a file's path
679 relative to the project root.
680 """
681
682 def __init__(self, filename):
683 self._filename = filename
684
685 def FullName(self):
686 """Make Windows paths like Unix."""
687 return os.path.abspath(self._filename).replace('\\', '/')
688
689 def RepositoryName(self):
690 """FullName after removing the local path to the repository.
691
692 If we have a real absolute path name here we can try to do something smart:
693 detecting the root of the checkout and truncating /path/to/checkout from
694 the name so that we get header guards that don't include things like
695 "C:\Documents and Settings\..." or "/home/username/..." in them and thus
696 people on different computers who have checked the source out to different
697 locations won't see bogus errors.
698 """
699 fullname = self.FullName()
700
701 if os.path.exists(fullname):
702 project_dir = os.path.dirname(fullname)
703
704 if os.path.exists(os.path.join(project_dir, ".svn")):
705 # If there's a .svn file in the current directory, we recursively look
706 # up the directory tree for the top of the SVN checkout
707 root_dir = project_dir
708 one_up_dir = os.path.dirname(root_dir)
709 while os.path.exists(os.path.join(one_up_dir, ".svn")):
710 root_dir = os.path.dirname(root_dir)
711 one_up_dir = os.path.dirname(one_up_dir)
712
713 prefix = os.path.commonprefix([root_dir, project_dir])
714 return fullname[len(prefix) + 1:]
715
erg@google.com35589e62010-11-17 18:58:16 +0000716 # Not SVN? Try to find a git or hg top level directory by searching up
717 # from the current path.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000718 root_dir = os.path.dirname(fullname)
719 while (root_dir != os.path.dirname(root_dir) and
erg@google.com35589e62010-11-17 18:58:16 +0000720 not os.path.exists(os.path.join(root_dir, ".git")) and
721 not os.path.exists(os.path.join(root_dir, ".hg"))):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000722 root_dir = os.path.dirname(root_dir)
erg@google.com35589e62010-11-17 18:58:16 +0000723
724 if (os.path.exists(os.path.join(root_dir, ".git")) or
725 os.path.exists(os.path.join(root_dir, ".hg"))):
726 prefix = os.path.commonprefix([root_dir, project_dir])
727 return fullname[len(prefix) + 1:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000728
729 # Don't know what to do; header guard warnings may be wrong...
730 return fullname
731
732 def Split(self):
733 """Splits the file into the directory, basename, and extension.
734
735 For 'chrome/browser/browser.cc', Split() would
736 return ('chrome/browser', 'browser', '.cc')
737
738 Returns:
739 A tuple of (directory, basename, extension).
740 """
741
742 googlename = self.RepositoryName()
743 project, rest = os.path.split(googlename)
744 return (project,) + os.path.splitext(rest)
745
746 def BaseName(self):
747 """File base name - text after the final slash, before the final period."""
748 return self.Split()[1]
749
750 def Extension(self):
751 """File extension - text following the final period."""
752 return self.Split()[2]
753
754 def NoExtension(self):
755 """File has no source file extension."""
756 return '/'.join(self.Split()[0:2])
757
758 def IsSource(self):
759 """File has a source file extension."""
760 return self.Extension()[1:] in ('c', 'cc', 'cpp', 'cxx')
761
762
erg@google.com35589e62010-11-17 18:58:16 +0000763def _ShouldPrintError(category, confidence, linenum):
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +0000764 """If confidence >= verbose, category passes filter and is not suppressed."""
erg@google.com35589e62010-11-17 18:58:16 +0000765
766 # There are three ways we might decide not to print an error message:
767 # a "NOLINT(category)" comment appears in the source,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000768 # the verbosity level isn't high enough, or the filters filter it out.
erg@google.com35589e62010-11-17 18:58:16 +0000769 if IsErrorSuppressedByNolint(category, linenum):
770 return False
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000771 if confidence < _cpplint_state.verbose_level:
772 return False
773
774 is_filtered = False
775 for one_filter in _Filters():
776 if one_filter.startswith('-'):
777 if category.startswith(one_filter[1:]):
778 is_filtered = True
779 elif one_filter.startswith('+'):
780 if category.startswith(one_filter[1:]):
781 is_filtered = False
782 else:
783 assert False # should have been checked for in SetFilter.
784 if is_filtered:
785 return False
786
787 return True
788
789
790def Error(filename, linenum, category, confidence, message):
791 """Logs the fact we've found a lint error.
792
793 We log where the error was found, and also our confidence in the error,
794 that is, how certain we are this is a legitimate style regression, and
795 not a misidentification or a use that's sometimes justified.
796
erg@google.com35589e62010-11-17 18:58:16 +0000797 False positives can be suppressed by the use of
798 "cpplint(category)" comments on the offending line. These are
799 parsed into _error_suppressions.
800
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000801 Args:
802 filename: The name of the file containing the error.
803 linenum: The number of the line containing the error.
804 category: A string used to describe the "category" this bug
805 falls under: "whitespace", say, or "runtime". Categories
806 may have a hierarchy separated by slashes: "whitespace/indent".
807 confidence: A number from 1-5 representing a confidence score for
808 the error, with 5 meaning that we are certain of the problem,
809 and 1 meaning that it could be a legitimate construct.
810 message: The error message.
811 """
erg@google.com35589e62010-11-17 18:58:16 +0000812 if _ShouldPrintError(category, confidence, linenum):
erg@google.com26970fa2009-11-17 18:07:32 +0000813 _cpplint_state.IncrementErrorCount(category)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000814 if _cpplint_state.output_format == 'vs7':
815 sys.stderr.write('%s(%s): %s [%s] [%d]\n' % (
816 filename, linenum, message, category, confidence))
817 else:
818 sys.stderr.write('%s:%s: %s [%s] [%d]\n' % (
819 filename, linenum, message, category, confidence))
820
821
822# Matches standard C++ escape esequences per 2.13.2.3 of the C++ standard.
823_RE_PATTERN_CLEANSE_LINE_ESCAPES = re.compile(
824 r'\\([abfnrtv?"\\\']|\d+|x[0-9a-fA-F]+)')
825# Matches strings. Escape codes should already be removed by ESCAPES.
826_RE_PATTERN_CLEANSE_LINE_DOUBLE_QUOTES = re.compile(r'"[^"]*"')
827# Matches characters. Escape codes should already be removed by ESCAPES.
828_RE_PATTERN_CLEANSE_LINE_SINGLE_QUOTES = re.compile(r"'.'")
829# Matches multi-line C++ comments.
830# This RE is a little bit more complicated than one might expect, because we
831# have to take care of space removals tools so we can handle comments inside
832# statements better.
833# The current rule is: We only clear spaces from both sides when we're at the
834# end of the line. Otherwise, we try to remove spaces from the right side,
835# if this doesn't work we try on left side but only if there's a non-character
836# on the right.
837_RE_PATTERN_CLEANSE_LINE_C_COMMENTS = re.compile(
838 r"""(\s*/\*.*\*/\s*$|
839 /\*.*\*/\s+|
840 \s+/\*.*\*/(?=\W)|
841 /\*.*\*/)""", re.VERBOSE)
842
843
844def IsCppString(line):
845 """Does line terminate so, that the next symbol is in string constant.
846
847 This function does not consider single-line nor multi-line comments.
848
849 Args:
850 line: is a partial line of code starting from the 0..n.
851
852 Returns:
853 True, if next character appended to 'line' is inside a
854 string constant.
855 """
856
857 line = line.replace(r'\\', 'XX') # after this, \\" does not match to \"
858 return ((line.count('"') - line.count(r'\"') - line.count("'\"'")) & 1) == 1
859
860
861def FindNextMultiLineCommentStart(lines, lineix):
862 """Find the beginning marker for a multiline comment."""
863 while lineix < len(lines):
864 if lines[lineix].strip().startswith('/*'):
865 # Only return this marker if the comment goes beyond this line
866 if lines[lineix].strip().find('*/', 2) < 0:
867 return lineix
868 lineix += 1
869 return len(lines)
870
871
872def FindNextMultiLineCommentEnd(lines, lineix):
873 """We are inside a comment, find the end marker."""
874 while lineix < len(lines):
875 if lines[lineix].strip().endswith('*/'):
876 return lineix
877 lineix += 1
878 return len(lines)
879
880
881def RemoveMultiLineCommentsFromRange(lines, begin, end):
882 """Clears a range of lines for multi-line comments."""
883 # Having // dummy comments makes the lines non-empty, so we will not get
884 # unnecessary blank line warnings later in the code.
885 for i in range(begin, end):
886 lines[i] = '// dummy'
887
888
889def RemoveMultiLineComments(filename, lines, error):
890 """Removes multiline (c-style) comments from lines."""
891 lineix = 0
892 while lineix < len(lines):
893 lineix_begin = FindNextMultiLineCommentStart(lines, lineix)
894 if lineix_begin >= len(lines):
895 return
896 lineix_end = FindNextMultiLineCommentEnd(lines, lineix_begin)
897 if lineix_end >= len(lines):
898 error(filename, lineix_begin + 1, 'readability/multiline_comment', 5,
899 'Could not find end of multi-line comment')
900 return
901 RemoveMultiLineCommentsFromRange(lines, lineix_begin, lineix_end + 1)
902 lineix = lineix_end + 1
903
904
905def CleanseComments(line):
906 """Removes //-comments and single-line C-style /* */ comments.
907
908 Args:
909 line: A line of C++ source.
910
911 Returns:
912 The line with single-line comments removed.
913 """
914 commentpos = line.find('//')
915 if commentpos != -1 and not IsCppString(line[:commentpos]):
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +0000916 line = line[:commentpos].rstrip()
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000917 # get rid of /* ... */
918 return _RE_PATTERN_CLEANSE_LINE_C_COMMENTS.sub('', line)
919
920
erg@google.com6317a9c2009-06-25 00:28:19 +0000921class CleansedLines(object):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000922 """Holds 3 copies of all lines with different preprocessing applied to them.
923
924 1) elided member contains lines without strings and comments,
925 2) lines member contains lines without comments, and
926 3) raw member contains all the lines without processing.
927 All these three members are of <type 'list'>, and of the same length.
928 """
929
930 def __init__(self, lines):
931 self.elided = []
932 self.lines = []
933 self.raw_lines = lines
934 self.num_lines = len(lines)
935 for linenum in range(len(lines)):
936 self.lines.append(CleanseComments(lines[linenum]))
937 elided = self._CollapseStrings(lines[linenum])
938 self.elided.append(CleanseComments(elided))
939
940 def NumLines(self):
941 """Returns the number of lines represented."""
942 return self.num_lines
943
944 @staticmethod
945 def _CollapseStrings(elided):
946 """Collapses strings and chars on a line to simple "" or '' blocks.
947
948 We nix strings first so we're not fooled by text like '"http://"'
949
950 Args:
951 elided: The line being processed.
952
953 Returns:
954 The line with collapsed strings.
955 """
956 if not _RE_PATTERN_INCLUDE.match(elided):
957 # Remove escaped characters first to make quote/single quote collapsing
958 # basic. Things that look like escaped characters shouldn't occur
959 # outside of strings and chars.
960 elided = _RE_PATTERN_CLEANSE_LINE_ESCAPES.sub('', elided)
961 elided = _RE_PATTERN_CLEANSE_LINE_SINGLE_QUOTES.sub("''", elided)
962 elided = _RE_PATTERN_CLEANSE_LINE_DOUBLE_QUOTES.sub('""', elided)
963 return elided
964
965
966def CloseExpression(clean_lines, linenum, pos):
967 """If input points to ( or { or [, finds the position that closes it.
968
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +0000969 If lines[linenum][pos] points to a '(' or '{' or '[', finds the
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000970 linenum/pos that correspond to the closing of the expression.
971
972 Args:
973 clean_lines: A CleansedLines instance containing the file.
974 linenum: The number of the line to check.
975 pos: A position on the line.
976
977 Returns:
978 A tuple (line, linenum, pos) pointer *past* the closing brace, or
979 (line, len(lines), -1) if we never find a close. Note we ignore
980 strings and comments when matching; and the line we return is the
981 'cleansed' line at linenum.
982 """
983
984 line = clean_lines.elided[linenum]
985 startchar = line[pos]
986 if startchar not in '({[':
987 return (line, clean_lines.NumLines(), -1)
988 if startchar == '(': endchar = ')'
989 if startchar == '[': endchar = ']'
990 if startchar == '{': endchar = '}'
991
992 num_open = line.count(startchar) - line.count(endchar)
993 while linenum < clean_lines.NumLines() and num_open > 0:
994 linenum += 1
995 line = clean_lines.elided[linenum]
996 num_open += line.count(startchar) - line.count(endchar)
997 # OK, now find the endchar that actually got us back to even
998 endpos = len(line)
999 while num_open >= 0:
1000 endpos = line.rfind(')', 0, endpos)
1001 num_open -= 1 # chopped off another )
1002 return (line, linenum, endpos + 1)
1003
1004
1005def CheckForCopyright(filename, lines, error):
1006 """Logs an error if no Copyright message appears at the top of the file."""
1007
1008 # We'll say it should occur by line 10. Don't forget there's a
1009 # dummy line at the front.
1010 for line in xrange(1, min(len(lines), 11)):
1011 if re.search(r'Copyright', lines[line], re.I): break
1012 else: # means no copyright line was found
1013 error(filename, 0, 'legal/copyright', 5,
1014 'No copyright message found. '
1015 'You should have a line: "Copyright [year] <Copyright Owner>"')
1016
1017
1018def GetHeaderGuardCPPVariable(filename):
1019 """Returns the CPP variable that should be used as a header guard.
1020
1021 Args:
1022 filename: The name of a C++ header file.
1023
1024 Returns:
1025 The CPP variable that should be used as a header guard in the
1026 named file.
1027
1028 """
1029
erg@google.com35589e62010-11-17 18:58:16 +00001030 # Restores original filename in case that cpplint is invoked from Emacs's
1031 # flymake.
1032 filename = re.sub(r'_flymake\.h$', '.h', filename)
1033
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001034 fileinfo = FileInfo(filename)
1035 return re.sub(r'[-./\s]', '_', fileinfo.RepositoryName()).upper() + '_'
1036
1037
1038def CheckForHeaderGuard(filename, lines, error):
1039 """Checks that the file contains a header guard.
1040
erg@google.com6317a9c2009-06-25 00:28:19 +00001041 Logs an error if no #ifndef header guard is present. For other
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001042 headers, checks that the full pathname is used.
1043
1044 Args:
1045 filename: The name of the C++ header file.
1046 lines: An array of strings, each representing a line of the file.
1047 error: The function to call with any errors found.
1048 """
1049
1050 cppvar = GetHeaderGuardCPPVariable(filename)
1051
1052 ifndef = None
1053 ifndef_linenum = 0
1054 define = None
1055 endif = None
1056 endif_linenum = 0
1057 for linenum, line in enumerate(lines):
1058 linesplit = line.split()
1059 if len(linesplit) >= 2:
1060 # find the first occurrence of #ifndef and #define, save arg
1061 if not ifndef and linesplit[0] == '#ifndef':
1062 # set ifndef to the header guard presented on the #ifndef line.
1063 ifndef = linesplit[1]
1064 ifndef_linenum = linenum
1065 if not define and linesplit[0] == '#define':
1066 define = linesplit[1]
1067 # find the last occurrence of #endif, save entire line
1068 if line.startswith('#endif'):
1069 endif = line
1070 endif_linenum = linenum
1071
1072 if not ifndef or not define or ifndef != define:
1073 error(filename, 0, 'build/header_guard', 5,
1074 'No #ifndef header guard found, suggested CPP variable is: %s' %
1075 cppvar)
1076 return
1077
1078 # The guard should be PATH_FILE_H_, but we also allow PATH_FILE_H__
1079 # for backward compatibility.
erg@google.com35589e62010-11-17 18:58:16 +00001080 if ifndef != cppvar:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001081 error_level = 0
1082 if ifndef != cppvar + '_':
1083 error_level = 5
1084
erg@google.com35589e62010-11-17 18:58:16 +00001085 ParseNolintSuppressions(filename, lines[ifndef_linenum], ifndef_linenum,
1086 error)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001087 error(filename, ifndef_linenum, 'build/header_guard', error_level,
1088 '#ifndef header guard has wrong style, please use: %s' % cppvar)
1089
erg@google.com35589e62010-11-17 18:58:16 +00001090 if endif != ('#endif // %s' % cppvar):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001091 error_level = 0
1092 if endif != ('#endif // %s' % (cppvar + '_')):
1093 error_level = 5
1094
erg@google.com35589e62010-11-17 18:58:16 +00001095 ParseNolintSuppressions(filename, lines[endif_linenum], endif_linenum,
1096 error)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001097 error(filename, endif_linenum, 'build/header_guard', error_level,
1098 '#endif line should be "#endif // %s"' % cppvar)
1099
1100
1101def CheckForUnicodeReplacementCharacters(filename, lines, error):
1102 """Logs an error for each line containing Unicode replacement characters.
1103
1104 These indicate that either the file contained invalid UTF-8 (likely)
1105 or Unicode replacement characters (which it shouldn't). Note that
1106 it's possible for this to throw off line numbering if the invalid
1107 UTF-8 occurred adjacent to a newline.
1108
1109 Args:
1110 filename: The name of the current file.
1111 lines: An array of strings, each representing a line of the file.
1112 error: The function to call with any errors found.
1113 """
1114 for linenum, line in enumerate(lines):
1115 if u'\ufffd' in line:
1116 error(filename, linenum, 'readability/utf8', 5,
1117 'Line contains invalid UTF-8 (or Unicode replacement character).')
1118
1119
1120def CheckForNewlineAtEOF(filename, lines, error):
1121 """Logs an error if there is no newline char at the end of the file.
1122
1123 Args:
1124 filename: The name of the current file.
1125 lines: An array of strings, each representing a line of the file.
1126 error: The function to call with any errors found.
1127 """
1128
1129 # The array lines() was created by adding two newlines to the
1130 # original file (go figure), then splitting on \n.
1131 # To verify that the file ends in \n, we just have to make sure the
1132 # last-but-two element of lines() exists and is empty.
1133 if len(lines) < 3 or lines[-2]:
1134 error(filename, len(lines) - 2, 'whitespace/ending_newline', 5,
1135 'Could not find a newline character at the end of the file.')
1136
1137
1138def CheckForMultilineCommentsAndStrings(filename, clean_lines, linenum, error):
1139 """Logs an error if we see /* ... */ or "..." that extend past one line.
1140
1141 /* ... */ comments are legit inside macros, for one line.
1142 Otherwise, we prefer // comments, so it's ok to warn about the
1143 other. Likewise, it's ok for strings to extend across multiple
1144 lines, as long as a line continuation character (backslash)
1145 terminates each line. Although not currently prohibited by the C++
1146 style guide, it's ugly and unnecessary. We don't do well with either
1147 in this lint program, so we warn about both.
1148
1149 Args:
1150 filename: The name of the current file.
1151 clean_lines: A CleansedLines instance containing the file.
1152 linenum: The number of the line to check.
1153 error: The function to call with any errors found.
1154 """
1155 line = clean_lines.elided[linenum]
1156
1157 # Remove all \\ (escaped backslashes) from the line. They are OK, and the
1158 # second (escaped) slash may trigger later \" detection erroneously.
1159 line = line.replace('\\\\', '')
1160
1161 if line.count('/*') > line.count('*/'):
1162 error(filename, linenum, 'readability/multiline_comment', 5,
1163 'Complex multi-line /*...*/-style comment found. '
1164 'Lint may give bogus warnings. '
1165 'Consider replacing these with //-style comments, '
1166 'with #if 0...#endif, '
1167 'or with more clearly structured multi-line comments.')
1168
1169 if (line.count('"') - line.count('\\"')) % 2:
1170 error(filename, linenum, 'readability/multiline_string', 5,
1171 'Multi-line string ("...") found. This lint script doesn\'t '
1172 'do well with such strings, and may give bogus warnings. They\'re '
1173 'ugly and unnecessary, and you should use concatenation instead".')
1174
1175
1176threading_list = (
1177 ('asctime(', 'asctime_r('),
1178 ('ctime(', 'ctime_r('),
1179 ('getgrgid(', 'getgrgid_r('),
1180 ('getgrnam(', 'getgrnam_r('),
1181 ('getlogin(', 'getlogin_r('),
1182 ('getpwnam(', 'getpwnam_r('),
1183 ('getpwuid(', 'getpwuid_r('),
1184 ('gmtime(', 'gmtime_r('),
1185 ('localtime(', 'localtime_r('),
1186 ('rand(', 'rand_r('),
1187 ('readdir(', 'readdir_r('),
1188 ('strtok(', 'strtok_r('),
1189 ('ttyname(', 'ttyname_r('),
1190 )
1191
1192
1193def CheckPosixThreading(filename, clean_lines, linenum, error):
1194 """Checks for calls to thread-unsafe functions.
1195
1196 Much code has been originally written without consideration of
1197 multi-threading. Also, engineers are relying on their old experience;
1198 they have learned posix before threading extensions were added. These
1199 tests guide the engineers to use thread-safe functions (when using
1200 posix directly).
1201
1202 Args:
1203 filename: The name of the current file.
1204 clean_lines: A CleansedLines instance containing the file.
1205 linenum: The number of the line to check.
1206 error: The function to call with any errors found.
1207 """
1208 line = clean_lines.elided[linenum]
1209 for single_thread_function, multithread_safe_function in threading_list:
1210 ix = line.find(single_thread_function)
erg@google.com6317a9c2009-06-25 00:28:19 +00001211 # Comparisons made explicit for clarity -- pylint: disable-msg=C6403
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001212 if ix >= 0 and (ix == 0 or (not line[ix - 1].isalnum() and
1213 line[ix - 1] not in ('_', '.', '>'))):
1214 error(filename, linenum, 'runtime/threadsafe_fn', 2,
1215 'Consider using ' + multithread_safe_function +
1216 '...) instead of ' + single_thread_function +
1217 '...) for improved thread safety.')
1218
1219
erg@google.com26970fa2009-11-17 18:07:32 +00001220# Matches invalid increment: *count++, which moves pointer instead of
erg@google.com6317a9c2009-06-25 00:28:19 +00001221# incrementing a value.
erg@google.com26970fa2009-11-17 18:07:32 +00001222_RE_PATTERN_INVALID_INCREMENT = re.compile(
erg@google.com6317a9c2009-06-25 00:28:19 +00001223 r'^\s*\*\w+(\+\+|--);')
1224
1225
1226def CheckInvalidIncrement(filename, clean_lines, linenum, error):
erg@google.com26970fa2009-11-17 18:07:32 +00001227 """Checks for invalid increment *count++.
erg@google.com6317a9c2009-06-25 00:28:19 +00001228
1229 For example following function:
1230 void increment_counter(int* count) {
1231 *count++;
1232 }
1233 is invalid, because it effectively does count++, moving pointer, and should
1234 be replaced with ++*count, (*count)++ or *count += 1.
1235
1236 Args:
1237 filename: The name of the current file.
1238 clean_lines: A CleansedLines instance containing the file.
1239 linenum: The number of the line to check.
1240 error: The function to call with any errors found.
1241 """
1242 line = clean_lines.elided[linenum]
erg@google.com26970fa2009-11-17 18:07:32 +00001243 if _RE_PATTERN_INVALID_INCREMENT.match(line):
erg@google.com6317a9c2009-06-25 00:28:19 +00001244 error(filename, linenum, 'runtime/invalid_increment', 5,
1245 'Changing pointer instead of value (or unused value of operator*).')
1246
1247
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001248class _ClassInfo(object):
1249 """Stores information about a class."""
1250
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001251 def __init__(self, name, clean_lines, linenum):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001252 self.name = name
1253 self.linenum = linenum
1254 self.seen_open_brace = False
1255 self.is_derived = False
1256 self.virtual_method_linenumber = None
1257 self.has_virtual_destructor = False
1258 self.brace_depth = 0
1259
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001260 # Try to find the end of the class. This will be confused by things like:
1261 # class A {
1262 # } *x = { ...
1263 #
1264 # But it's still good enough for CheckSectionSpacing.
1265 self.last_line = 0
1266 depth = 0
1267 for i in range(linenum, clean_lines.NumLines()):
1268 line = clean_lines.lines[i]
1269 depth += line.count('{') - line.count('}')
1270 if not depth:
1271 self.last_line = i
1272 break
1273
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001274
1275class _ClassState(object):
1276 """Holds the current state of the parse relating to class declarations.
1277
1278 It maintains a stack of _ClassInfos representing the parser's guess
1279 as to the current nesting of class declarations. The innermost class
1280 is at the top (back) of the stack. Typically, the stack will either
1281 be empty or have exactly one entry.
1282 """
1283
1284 def __init__(self):
1285 self.classinfo_stack = []
1286
1287 def CheckFinished(self, filename, error):
1288 """Checks that all classes have been completely parsed.
1289
1290 Call this when all lines in a file have been processed.
1291 Args:
1292 filename: The name of the current file.
1293 error: The function to call with any errors found.
1294 """
1295 if self.classinfo_stack:
1296 # Note: This test can result in false positives if #ifdef constructs
1297 # get in the way of brace matching. See the testBuildClass test in
1298 # cpplint_unittest.py for an example of this.
1299 error(filename, self.classinfo_stack[0].linenum, 'build/class', 5,
1300 'Failed to find complete declaration of class %s' %
1301 self.classinfo_stack[0].name)
1302
1303
1304def CheckForNonStandardConstructs(filename, clean_lines, linenum,
1305 class_state, error):
1306 """Logs an error if we see certain non-ANSI constructs ignored by gcc-2.
1307
1308 Complain about several constructs which gcc-2 accepts, but which are
1309 not standard C++. Warning about these in lint is one way to ease the
1310 transition to new compilers.
1311 - put storage class first (e.g. "static const" instead of "const static").
1312 - "%lld" instead of %qd" in printf-type functions.
1313 - "%1$d" is non-standard in printf-type functions.
1314 - "\%" is an undefined character escape sequence.
1315 - text after #endif is not allowed.
1316 - invalid inner-style forward declaration.
1317 - >? and <? operators, and their >?= and <?= cousins.
1318 - classes with virtual methods need virtual destructors (compiler warning
1319 available, but not turned on yet.)
1320
erg@google.com26970fa2009-11-17 18:07:32 +00001321 Additionally, check for constructor/destructor style violations and reference
1322 members, as it is very convenient to do so while checking for
1323 gcc-2 compliance.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001324
1325 Args:
1326 filename: The name of the current file.
1327 clean_lines: A CleansedLines instance containing the file.
1328 linenum: The number of the line to check.
1329 class_state: A _ClassState instance which maintains information about
1330 the current stack of nested class declarations being parsed.
1331 error: A callable to which errors are reported, which takes 4 arguments:
1332 filename, line number, error level, and message
1333 """
1334
1335 # Remove comments from the line, but leave in strings for now.
1336 line = clean_lines.lines[linenum]
1337
1338 if Search(r'printf\s*\(.*".*%[-+ ]?\d*q', line):
1339 error(filename, linenum, 'runtime/printf_format', 3,
1340 '%q in format strings is deprecated. Use %ll instead.')
1341
1342 if Search(r'printf\s*\(.*".*%\d+\$', line):
1343 error(filename, linenum, 'runtime/printf_format', 2,
1344 '%N$ formats are unconventional. Try rewriting to avoid them.')
1345
1346 # Remove escaped backslashes before looking for undefined escapes.
1347 line = line.replace('\\\\', '')
1348
1349 if Search(r'("|\').*\\(%|\[|\(|{)', line):
1350 error(filename, linenum, 'build/printf_format', 3,
1351 '%, [, (, and { are undefined character escapes. Unescape them.')
1352
1353 # For the rest, work with both comments and strings removed.
1354 line = clean_lines.elided[linenum]
1355
1356 if Search(r'\b(const|volatile|void|char|short|int|long'
1357 r'|float|double|signed|unsigned'
1358 r'|schar|u?int8|u?int16|u?int32|u?int64)'
1359 r'\s+(auto|register|static|extern|typedef)\b',
1360 line):
1361 error(filename, linenum, 'build/storage_class', 5,
1362 'Storage class (static, extern, typedef, etc) should be first.')
1363
1364 if Match(r'\s*#\s*endif\s*[^/\s]+', line):
1365 error(filename, linenum, 'build/endif_comment', 5,
1366 'Uncommented text after #endif is non-standard. Use a comment.')
1367
1368 if Match(r'\s*class\s+(\w+\s*::\s*)+\w+\s*;', line):
1369 error(filename, linenum, 'build/forward_decl', 5,
1370 'Inner-style forward declarations are invalid. Remove this line.')
1371
1372 if Search(r'(\w+|[+-]?\d+(\.\d*)?)\s*(<|>)\?=?\s*(\w+|[+-]?\d+)(\.\d*)?',
1373 line):
1374 error(filename, linenum, 'build/deprecated', 3,
1375 '>? and <? (max and min) operators are non-standard and deprecated.')
1376
erg@google.com26970fa2009-11-17 18:07:32 +00001377 if Search(r'^\s*const\s*string\s*&\s*\w+\s*;', line):
1378 # TODO(unknown): Could it be expanded safely to arbitrary references,
1379 # without triggering too many false positives? The first
1380 # attempt triggered 5 warnings for mostly benign code in the regtest, hence
1381 # the restriction.
1382 # Here's the original regexp, for the reference:
1383 # type_name = r'\w+((\s*::\s*\w+)|(\s*<\s*\w+?\s*>))?'
1384 # r'\s*const\s*' + type_name + '\s*&\s*\w+\s*;'
1385 error(filename, linenum, 'runtime/member_string_references', 2,
1386 'const string& members are dangerous. It is much better to use '
1387 'alternatives, such as pointers or simple constants.')
1388
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001389 # Track class entry and exit, and attempt to find cases within the
1390 # class declaration that don't meet the C++ style
1391 # guidelines. Tracking is very dependent on the code matching Google
1392 # style guidelines, but it seems to perform well enough in testing
1393 # to be a worthwhile addition to the checks.
1394 classinfo_stack = class_state.classinfo_stack
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001395 # Look for a class declaration. The regexp accounts for decorated classes
1396 # such as in:
1397 # class LOCKABLE API Object {
1398 # };
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001399 class_decl_match = Match(
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001400 r'\s*(template\s*<[\w\s<>,:]*>\s*)?'
1401 '(class|struct)\s+([A-Z_]+\s+)*(\w+(::\w+)*)', line)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001402 if class_decl_match:
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001403 classinfo_stack.append(_ClassInfo(
1404 class_decl_match.group(4), clean_lines, linenum))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001405
1406 # Everything else in this function uses the top of the stack if it's
1407 # not empty.
1408 if not classinfo_stack:
1409 return
1410
1411 classinfo = classinfo_stack[-1]
1412
1413 # If the opening brace hasn't been seen look for it and also
1414 # parent class declarations.
1415 if not classinfo.seen_open_brace:
1416 # If the line has a ';' in it, assume it's a forward declaration or
1417 # a single-line class declaration, which we won't process.
1418 if line.find(';') != -1:
1419 classinfo_stack.pop()
1420 return
1421 classinfo.seen_open_brace = (line.find('{') != -1)
1422 # Look for a bare ':'
1423 if Search('(^|[^:]):($|[^:])', line):
1424 classinfo.is_derived = True
1425 if not classinfo.seen_open_brace:
1426 return # Everything else in this function is for after open brace
1427
1428 # The class may have been declared with namespace or classname qualifiers.
1429 # The constructor and destructor will not have those qualifiers.
1430 base_classname = classinfo.name.split('::')[-1]
1431
1432 # Look for single-argument constructors that aren't marked explicit.
1433 # Technically a valid construct, but against style.
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001434 args = Match(r'\s+(?:inline\s+)?%s\s*\(([^,()]+)\)'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001435 % re.escape(base_classname),
1436 line)
1437 if (args and
1438 args.group(1) != 'void' and
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001439 not Match(r'(const\s+)?%s\s*(?:<\w+>\s*)?&' % re.escape(base_classname),
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001440 args.group(1).strip())):
1441 error(filename, linenum, 'runtime/explicit', 5,
1442 'Single-argument constructors should be marked explicit.')
1443
1444 # Look for methods declared virtual.
1445 if Search(r'\bvirtual\b', line):
1446 classinfo.virtual_method_linenumber = linenum
1447 # Only look for a destructor declaration on the same line. It would
1448 # be extremely unlikely for the destructor declaration to occupy
1449 # more than one line.
1450 if Search(r'~%s\s*\(' % base_classname, line):
1451 classinfo.has_virtual_destructor = True
1452
1453 # Look for class end.
1454 brace_depth = classinfo.brace_depth
1455 brace_depth = brace_depth + line.count('{') - line.count('}')
1456 if brace_depth <= 0:
1457 classinfo = classinfo_stack.pop()
1458 # Try to detect missing virtual destructor declarations.
1459 # For now, only warn if a non-derived class with virtual methods lacks
1460 # a virtual destructor. This is to make it less likely that people will
1461 # declare derived virtual destructors without declaring the base
1462 # destructor virtual.
1463 if ((classinfo.virtual_method_linenumber is not None) and
1464 (not classinfo.has_virtual_destructor) and
1465 (not classinfo.is_derived)): # Only warn for base classes
1466 error(filename, classinfo.linenum, 'runtime/virtual', 4,
1467 'The class %s probably needs a virtual destructor due to '
1468 'having virtual method(s), one declared at line %d.'
1469 % (classinfo.name, classinfo.virtual_method_linenumber))
1470 else:
1471 classinfo.brace_depth = brace_depth
1472
1473
1474def CheckSpacingForFunctionCall(filename, line, linenum, error):
1475 """Checks for the correctness of various spacing around function calls.
1476
1477 Args:
1478 filename: The name of the current file.
1479 line: The text of the line to check.
1480 linenum: The number of the line to check.
1481 error: The function to call with any errors found.
1482 """
1483
1484 # Since function calls often occur inside if/for/while/switch
1485 # expressions - which have their own, more liberal conventions - we
1486 # first see if we should be looking inside such an expression for a
1487 # function call, to which we can apply more strict standards.
1488 fncall = line # if there's no control flow construct, look at whole line
1489 for pattern in (r'\bif\s*\((.*)\)\s*{',
1490 r'\bfor\s*\((.*)\)\s*{',
1491 r'\bwhile\s*\((.*)\)\s*[{;]',
1492 r'\bswitch\s*\((.*)\)\s*{'):
1493 match = Search(pattern, line)
1494 if match:
1495 fncall = match.group(1) # look inside the parens for function calls
1496 break
1497
1498 # Except in if/for/while/switch, there should never be space
1499 # immediately inside parens (eg "f( 3, 4 )"). We make an exception
1500 # for nested parens ( (a+b) + c ). Likewise, there should never be
1501 # a space before a ( when it's a function argument. I assume it's a
1502 # function argument when the char before the whitespace is legal in
1503 # a function name (alnum + _) and we're not starting a macro. Also ignore
1504 # pointers and references to arrays and functions coz they're too tricky:
1505 # we use a very simple way to recognize these:
1506 # " (something)(maybe-something)" or
1507 # " (something)(maybe-something," or
1508 # " (something)[something]"
1509 # Note that we assume the contents of [] to be short enough that
1510 # they'll never need to wrap.
1511 if ( # Ignore control structures.
1512 not Search(r'\b(if|for|while|switch|return|delete)\b', fncall) and
1513 # Ignore pointers/references to functions.
1514 not Search(r' \([^)]+\)\([^)]*(\)|,$)', fncall) and
1515 # Ignore pointers/references to arrays.
1516 not Search(r' \([^)]+\)\[[^\]]+\]', fncall)):
erg@google.com6317a9c2009-06-25 00:28:19 +00001517 if Search(r'\w\s*\(\s(?!\s*\\$)', fncall): # a ( used for a fn call
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001518 error(filename, linenum, 'whitespace/parens', 4,
1519 'Extra space after ( in function call')
erg@google.com6317a9c2009-06-25 00:28:19 +00001520 elif Search(r'\(\s+(?!(\s*\\)|\()', fncall):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001521 error(filename, linenum, 'whitespace/parens', 2,
1522 'Extra space after (')
1523 if (Search(r'\w\s+\(', fncall) and
1524 not Search(r'#\s*define|typedef', fncall)):
1525 error(filename, linenum, 'whitespace/parens', 4,
1526 'Extra space before ( in function call')
1527 # If the ) is followed only by a newline or a { + newline, assume it's
1528 # part of a control statement (if/while/etc), and don't complain
1529 if Search(r'[^)]\s+\)\s*[^{\s]', fncall):
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001530 # If the closing parenthesis is preceded by only whitespaces,
1531 # try to give a more descriptive error message.
1532 if Search(r'^\s+\)', fncall):
1533 error(filename, linenum, 'whitespace/parens', 2,
1534 'Closing ) should be moved to the previous line')
1535 else:
1536 error(filename, linenum, 'whitespace/parens', 2,
1537 'Extra space before )')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001538
1539
1540def IsBlankLine(line):
1541 """Returns true if the given line is blank.
1542
1543 We consider a line to be blank if the line is empty or consists of
1544 only white spaces.
1545
1546 Args:
1547 line: A line of a string.
1548
1549 Returns:
1550 True, if the given line is blank.
1551 """
1552 return not line or line.isspace()
1553
1554
1555def CheckForFunctionLengths(filename, clean_lines, linenum,
1556 function_state, error):
1557 """Reports for long function bodies.
1558
1559 For an overview why this is done, see:
1560 http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Write_Short_Functions
1561
1562 Uses a simplistic algorithm assuming other style guidelines
1563 (especially spacing) are followed.
1564 Only checks unindented functions, so class members are unchecked.
1565 Trivial bodies are unchecked, so constructors with huge initializer lists
1566 may be missed.
1567 Blank/comment lines are not counted so as to avoid encouraging the removal
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001568 of vertical space and comments just to get through a lint check.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001569 NOLINT *on the last line of a function* disables this check.
1570
1571 Args:
1572 filename: The name of the current file.
1573 clean_lines: A CleansedLines instance containing the file.
1574 linenum: The number of the line to check.
1575 function_state: Current function name and lines in body so far.
1576 error: The function to call with any errors found.
1577 """
1578 lines = clean_lines.lines
1579 line = lines[linenum]
1580 raw = clean_lines.raw_lines
1581 raw_line = raw[linenum]
1582 joined_line = ''
1583
1584 starting_func = False
erg@google.com6317a9c2009-06-25 00:28:19 +00001585 regexp = r'(\w(\w|::|\*|\&|\s)*)\(' # decls * & space::name( ...
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001586 match_result = Match(regexp, line)
1587 if match_result:
1588 # If the name is all caps and underscores, figure it's a macro and
1589 # ignore it, unless it's TEST or TEST_F.
1590 function_name = match_result.group(1).split()[-1]
1591 if function_name == 'TEST' or function_name == 'TEST_F' or (
1592 not Match(r'[A-Z_]+$', function_name)):
1593 starting_func = True
1594
1595 if starting_func:
1596 body_found = False
erg@google.com6317a9c2009-06-25 00:28:19 +00001597 for start_linenum in xrange(linenum, clean_lines.NumLines()):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001598 start_line = lines[start_linenum]
1599 joined_line += ' ' + start_line.lstrip()
1600 if Search(r'(;|})', start_line): # Declarations and trivial functions
1601 body_found = True
1602 break # ... ignore
1603 elif Search(r'{', start_line):
1604 body_found = True
1605 function = Search(r'((\w|:)*)\(', line).group(1)
1606 if Match(r'TEST', function): # Handle TEST... macros
1607 parameter_regexp = Search(r'(\(.*\))', joined_line)
1608 if parameter_regexp: # Ignore bad syntax
1609 function += parameter_regexp.group(1)
1610 else:
1611 function += '()'
1612 function_state.Begin(function)
1613 break
1614 if not body_found:
erg@google.com6317a9c2009-06-25 00:28:19 +00001615 # No body for the function (or evidence of a non-function) was found.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001616 error(filename, linenum, 'readability/fn_size', 5,
1617 'Lint failed to find start of function body.')
1618 elif Match(r'^\}\s*$', line): # function end
erg@google.com35589e62010-11-17 18:58:16 +00001619 function_state.Check(error, filename, linenum)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001620 function_state.End()
1621 elif not Match(r'^\s*$', line):
1622 function_state.Count() # Count non-blank/non-comment lines.
1623
1624
1625_RE_PATTERN_TODO = re.compile(r'^//(\s*)TODO(\(.+?\))?:?(\s|$)?')
1626
1627
1628def CheckComment(comment, filename, linenum, error):
1629 """Checks for common mistakes in TODO comments.
1630
1631 Args:
1632 comment: The text of the comment from the line in question.
1633 filename: The name of the current file.
1634 linenum: The number of the line to check.
1635 error: The function to call with any errors found.
1636 """
1637 match = _RE_PATTERN_TODO.match(comment)
1638 if match:
1639 # One whitespace is correct; zero whitespace is handled elsewhere.
1640 leading_whitespace = match.group(1)
1641 if len(leading_whitespace) > 1:
1642 error(filename, linenum, 'whitespace/todo', 2,
1643 'Too many spaces before TODO')
1644
1645 username = match.group(2)
1646 if not username:
1647 error(filename, linenum, 'readability/todo', 2,
1648 'Missing username in TODO; it should look like '
1649 '"// TODO(my_username): Stuff."')
1650
1651 middle_whitespace = match.group(3)
erg@google.com6317a9c2009-06-25 00:28:19 +00001652 # Comparisons made explicit for correctness -- pylint: disable-msg=C6403
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001653 if middle_whitespace != ' ' and middle_whitespace != '':
1654 error(filename, linenum, 'whitespace/todo', 2,
1655 'TODO(my_username) should be followed by a space')
1656
1657
1658def CheckSpacing(filename, clean_lines, linenum, error):
1659 """Checks for the correctness of various spacing issues in the code.
1660
1661 Things we check for: spaces around operators, spaces after
1662 if/for/while/switch, no spaces around parens in function calls, two
1663 spaces between code and comment, don't start a block with a blank
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001664 line, don't end a function with a blank line, don't add a blank line
1665 after public/protected/private, don't have too many blank lines in a row.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001666
1667 Args:
1668 filename: The name of the current file.
1669 clean_lines: A CleansedLines instance containing the file.
1670 linenum: The number of the line to check.
1671 error: The function to call with any errors found.
1672 """
1673
1674 raw = clean_lines.raw_lines
1675 line = raw[linenum]
1676
1677 # Before nixing comments, check if the line is blank for no good
1678 # reason. This includes the first line after a block is opened, and
1679 # blank lines at the end of a function (ie, right before a line like '}'
1680 if IsBlankLine(line):
1681 elided = clean_lines.elided
1682 prev_line = elided[linenum - 1]
1683 prevbrace = prev_line.rfind('{')
1684 # TODO(unknown): Don't complain if line before blank line, and line after,
1685 # both start with alnums and are indented the same amount.
1686 # This ignores whitespace at the start of a namespace block
1687 # because those are not usually indented.
1688 if (prevbrace != -1 and prev_line[prevbrace:].find('}') == -1
1689 and prev_line[:prevbrace].find('namespace') == -1):
1690 # OK, we have a blank line at the start of a code block. Before we
1691 # complain, we check if it is an exception to the rule: The previous
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001692 # non-empty line has the parameters of a function header that are indented
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001693 # 4 spaces (because they did not fit in a 80 column line when placed on
1694 # the same line as the function name). We also check for the case where
1695 # the previous line is indented 6 spaces, which may happen when the
1696 # initializers of a constructor do not fit into a 80 column line.
1697 exception = False
1698 if Match(r' {6}\w', prev_line): # Initializer list?
1699 # We are looking for the opening column of initializer list, which
1700 # should be indented 4 spaces to cause 6 space indentation afterwards.
1701 search_position = linenum-2
1702 while (search_position >= 0
1703 and Match(r' {6}\w', elided[search_position])):
1704 search_position -= 1
1705 exception = (search_position >= 0
1706 and elided[search_position][:5] == ' :')
1707 else:
1708 # Search for the function arguments or an initializer list. We use a
1709 # simple heuristic here: If the line is indented 4 spaces; and we have a
1710 # closing paren, without the opening paren, followed by an opening brace
1711 # or colon (for initializer lists) we assume that it is the last line of
1712 # a function header. If we have a colon indented 4 spaces, it is an
1713 # initializer list.
1714 exception = (Match(r' {4}\w[^\(]*\)\s*(const\s*)?(\{\s*$|:)',
1715 prev_line)
1716 or Match(r' {4}:', prev_line))
1717
1718 if not exception:
1719 error(filename, linenum, 'whitespace/blank_line', 2,
1720 'Blank line at the start of a code block. Is this needed?')
1721 # This doesn't ignore whitespace at the end of a namespace block
1722 # because that is too hard without pairing open/close braces;
1723 # however, a special exception is made for namespace closing
1724 # brackets which have a comment containing "namespace".
1725 #
1726 # Also, ignore blank lines at the end of a block in a long if-else
1727 # chain, like this:
1728 # if (condition1) {
1729 # // Something followed by a blank line
1730 #
1731 # } else if (condition2) {
1732 # // Something else
1733 # }
1734 if linenum + 1 < clean_lines.NumLines():
1735 next_line = raw[linenum + 1]
1736 if (next_line
1737 and Match(r'\s*}', next_line)
1738 and next_line.find('namespace') == -1
1739 and next_line.find('} else ') == -1):
1740 error(filename, linenum, 'whitespace/blank_line', 3,
1741 'Blank line at the end of a code block. Is this needed?')
1742
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001743 matched = Match(r'\s*(public|protected|private):', prev_line)
1744 if matched:
1745 error(filename, linenum, 'whitespace/blank_line', 3,
1746 'Do not leave a blank line after "%s:"' % matched.group(1))
1747
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001748 # Next, we complain if there's a comment too near the text
1749 commentpos = line.find('//')
1750 if commentpos != -1:
1751 # Check if the // may be in quotes. If so, ignore it
erg@google.com6317a9c2009-06-25 00:28:19 +00001752 # Comparisons made explicit for clarity -- pylint: disable-msg=C6403
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001753 if (line.count('"', 0, commentpos) -
1754 line.count('\\"', 0, commentpos)) % 2 == 0: # not in quotes
1755 # Allow one space for new scopes, two spaces otherwise:
1756 if (not Match(r'^\s*{ //', line) and
1757 ((commentpos >= 1 and
1758 line[commentpos-1] not in string.whitespace) or
1759 (commentpos >= 2 and
1760 line[commentpos-2] not in string.whitespace))):
1761 error(filename, linenum, 'whitespace/comments', 2,
1762 'At least two spaces is best between code and comments')
1763 # There should always be a space between the // and the comment
1764 commentend = commentpos + 2
1765 if commentend < len(line) and not line[commentend] == ' ':
1766 # but some lines are exceptions -- e.g. if they're big
1767 # comment delimiters like:
1768 # //----------------------------------------------------------
erg@google.com35589e62010-11-17 18:58:16 +00001769 # or are an empty C++ style Doxygen comment, like:
1770 # ///
erg@google.com6317a9c2009-06-25 00:28:19 +00001771 # or they begin with multiple slashes followed by a space:
1772 # //////// Header comment
1773 match = (Search(r'[=/-]{4,}\s*$', line[commentend:]) or
erg@google.com35589e62010-11-17 18:58:16 +00001774 Search(r'^/$', line[commentend:]) or
erg@google.com6317a9c2009-06-25 00:28:19 +00001775 Search(r'^/+ ', line[commentend:]))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001776 if not match:
1777 error(filename, linenum, 'whitespace/comments', 4,
1778 'Should have a space between // and comment')
1779 CheckComment(line[commentpos:], filename, linenum, error)
1780
1781 line = clean_lines.elided[linenum] # get rid of comments and strings
1782
1783 # Don't try to do spacing checks for operator methods
1784 line = re.sub(r'operator(==|!=|<|<<|<=|>=|>>|>)\(', 'operator\(', line)
1785
1786 # We allow no-spaces around = within an if: "if ( (a=Foo()) == 0 )".
1787 # Otherwise not. Note we only check for non-spaces on *both* sides;
1788 # sometimes people put non-spaces on one side when aligning ='s among
1789 # many lines (not that this is behavior that I approve of...)
1790 if Search(r'[\w.]=[\w.]', line) and not Search(r'\b(if|while) ', line):
1791 error(filename, linenum, 'whitespace/operators', 4,
1792 'Missing spaces around =')
1793
1794 # It's ok not to have spaces around binary operators like + - * /, but if
1795 # there's too little whitespace, we get concerned. It's hard to tell,
1796 # though, so we punt on this one for now. TODO.
1797
1798 # You should always have whitespace around binary operators.
1799 # Alas, we can't test < or > because they're legitimately used sans spaces
1800 # (a->b, vector<int> a). The only time we can tell is a < with no >, and
1801 # only if it's not template params list spilling into the next line.
1802 match = Search(r'[^<>=!\s](==|!=|<=|>=)[^<>=!\s]', line)
1803 if not match:
1804 # Note that while it seems that the '<[^<]*' term in the following
1805 # regexp could be simplified to '<.*', which would indeed match
1806 # the same class of strings, the [^<] means that searching for the
1807 # regexp takes linear rather than quadratic time.
1808 if not Search(r'<[^<]*,\s*$', line): # template params spill
1809 match = Search(r'[^<>=!\s](<)[^<>=!\s]([^>]|->)*$', line)
1810 if match:
1811 error(filename, linenum, 'whitespace/operators', 3,
1812 'Missing spaces around %s' % match.group(1))
1813 # We allow no-spaces around << and >> when used like this: 10<<20, but
1814 # not otherwise (particularly, not when used as streams)
1815 match = Search(r'[^0-9\s](<<|>>)[^0-9\s]', line)
1816 if match:
1817 error(filename, linenum, 'whitespace/operators', 3,
1818 'Missing spaces around %s' % match.group(1))
1819
1820 # There shouldn't be space around unary operators
1821 match = Search(r'(!\s|~\s|[\s]--[\s;]|[\s]\+\+[\s;])', line)
1822 if match:
1823 error(filename, linenum, 'whitespace/operators', 4,
1824 'Extra space for operator %s' % match.group(1))
1825
1826 # A pet peeve of mine: no spaces after an if, while, switch, or for
1827 match = Search(r' (if\(|for\(|while\(|switch\()', line)
1828 if match:
1829 error(filename, linenum, 'whitespace/parens', 5,
1830 'Missing space before ( in %s' % match.group(1))
1831
1832 # For if/for/while/switch, the left and right parens should be
1833 # consistent about how many spaces are inside the parens, and
1834 # there should either be zero or one spaces inside the parens.
1835 # We don't want: "if ( foo)" or "if ( foo )".
erg@google.com6317a9c2009-06-25 00:28:19 +00001836 # Exception: "for ( ; foo; bar)" and "for (foo; bar; )" are allowed.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001837 match = Search(r'\b(if|for|while|switch)\s*'
1838 r'\(([ ]*)(.).*[^ ]+([ ]*)\)\s*{\s*$',
1839 line)
1840 if match:
1841 if len(match.group(2)) != len(match.group(4)):
1842 if not (match.group(3) == ';' and
erg@google.com6317a9c2009-06-25 00:28:19 +00001843 len(match.group(2)) == 1 + len(match.group(4)) or
1844 not match.group(2) and Search(r'\bfor\s*\(.*; \)', line)):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001845 error(filename, linenum, 'whitespace/parens', 5,
1846 'Mismatching spaces inside () in %s' % match.group(1))
1847 if not len(match.group(2)) in [0, 1]:
1848 error(filename, linenum, 'whitespace/parens', 5,
1849 'Should have zero or one spaces inside ( and ) in %s' %
1850 match.group(1))
1851
1852 # You should always have a space after a comma (either as fn arg or operator)
1853 if Search(r',[^\s]', line):
1854 error(filename, linenum, 'whitespace/comma', 3,
1855 'Missing space after ,')
1856
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001857 # You should always have a space after a semicolon
1858 # except for few corner cases
1859 # TODO(unknown): clarify if 'if (1) { return 1;}' is requires one more
1860 # space after ;
1861 if Search(r';[^\s};\\)/]', line):
1862 error(filename, linenum, 'whitespace/semicolon', 3,
1863 'Missing space after ;')
1864
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001865 # Next we will look for issues with function calls.
1866 CheckSpacingForFunctionCall(filename, line, linenum, error)
1867
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001868 # Except after an opening paren, or after another opening brace (in case of
1869 # an initializer list, for instance), you should have spaces before your
1870 # braces. And since you should never have braces at the beginning of a line,
1871 # this is an easy test.
1872 if Search(r'[^ ({]{', line):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001873 error(filename, linenum, 'whitespace/braces', 5,
1874 'Missing space before {')
1875
1876 # Make sure '} else {' has spaces.
1877 if Search(r'}else', line):
1878 error(filename, linenum, 'whitespace/braces', 5,
1879 'Missing space before else')
1880
1881 # You shouldn't have spaces before your brackets, except maybe after
1882 # 'delete []' or 'new char * []'.
1883 if Search(r'\w\s+\[', line) and not Search(r'delete\s+\[', line):
1884 error(filename, linenum, 'whitespace/braces', 5,
1885 'Extra space before [')
1886
1887 # You shouldn't have a space before a semicolon at the end of the line.
1888 # There's a special case for "for" since the style guide allows space before
1889 # the semicolon there.
1890 if Search(r':\s*;\s*$', line):
1891 error(filename, linenum, 'whitespace/semicolon', 5,
1892 'Semicolon defining empty statement. Use { } instead.')
1893 elif Search(r'^\s*;\s*$', line):
1894 error(filename, linenum, 'whitespace/semicolon', 5,
1895 'Line contains only semicolon. If this should be an empty statement, '
1896 'use { } instead.')
1897 elif (Search(r'\s+;\s*$', line) and
1898 not Search(r'\bfor\b', line)):
1899 error(filename, linenum, 'whitespace/semicolon', 5,
1900 'Extra space before last semicolon. If this should be an empty '
1901 'statement, use { } instead.')
1902
1903
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00001904def CheckSectionSpacing(filename, clean_lines, class_info, linenum, error):
1905 """Checks for additional blank line issues related to sections.
1906
1907 Currently the only thing checked here is blank line before protected/private.
1908
1909 Args:
1910 filename: The name of the current file.
1911 clean_lines: A CleansedLines instance containing the file.
1912 class_info: A _ClassInfo objects.
1913 linenum: The number of the line to check.
1914 error: The function to call with any errors found.
1915 """
1916 # Skip checks if the class is small, where small means 25 lines or less.
1917 # 25 lines seems like a good cutoff since that's the usual height of
1918 # terminals, and any class that can't fit in one screen can't really
1919 # be considered "small".
1920 #
1921 # Also skip checks if we are on the first line. This accounts for
1922 # classes that look like
1923 # class Foo { public: ... };
1924 #
1925 # If we didn't find the end of the class, last_line would be zero,
1926 # and the check will be skipped by the first condition.
1927 if (class_info.last_line - class_info.linenum <= 24 or
1928 linenum <= class_info.linenum):
1929 return
1930
1931 matched = Match(r'\s*(public|protected|private):', clean_lines.lines[linenum])
1932 if matched:
1933 # Issue warning if the line before public/protected/private was
1934 # not a blank line, but don't do this if the previous line contains
1935 # "class" or "struct". This can happen two ways:
1936 # - We are at the beginning of the class.
1937 # - We are forward-declaring an inner class that is semantically
1938 # private, but needed to be public for implementation reasons.
1939 prev_line = clean_lines.lines[linenum - 1]
1940 if (not IsBlankLine(prev_line) and
1941 not Search(r'\b(class|struct)\b', prev_line)):
1942 # Try a bit harder to find the beginning of the class. This is to
1943 # account for multi-line base-specifier lists, e.g.:
1944 # class Derived
1945 # : public Base {
1946 end_class_head = class_info.linenum
1947 for i in range(class_info.linenum, linenum):
1948 if Search(r'\{\s*$', clean_lines.lines[i]):
1949 end_class_head = i
1950 break
1951 if end_class_head < linenum - 1:
1952 error(filename, linenum, 'whitespace/blank_line', 3,
1953 '"%s:" should be preceded by a blank line' % matched.group(1))
1954
1955
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001956def GetPreviousNonBlankLine(clean_lines, linenum):
1957 """Return the most recent non-blank line and its line number.
1958
1959 Args:
1960 clean_lines: A CleansedLines instance containing the file contents.
1961 linenum: The number of the line to check.
1962
1963 Returns:
1964 A tuple with two elements. The first element is the contents of the last
1965 non-blank line before the current line, or the empty string if this is the
1966 first non-blank line. The second is the line number of that line, or -1
1967 if this is the first non-blank line.
1968 """
1969
1970 prevlinenum = linenum - 1
1971 while prevlinenum >= 0:
1972 prevline = clean_lines.elided[prevlinenum]
1973 if not IsBlankLine(prevline): # if not a blank line...
1974 return (prevline, prevlinenum)
1975 prevlinenum -= 1
1976 return ('', -1)
1977
1978
1979def CheckBraces(filename, clean_lines, linenum, error):
1980 """Looks for misplaced braces (e.g. at the end of line).
1981
1982 Args:
1983 filename: The name of the current file.
1984 clean_lines: A CleansedLines instance containing the file.
1985 linenum: The number of the line to check.
1986 error: The function to call with any errors found.
1987 """
1988
1989 line = clean_lines.elided[linenum] # get rid of comments and strings
1990
1991 if Match(r'\s*{\s*$', line):
1992 # We allow an open brace to start a line in the case where someone
1993 # is using braces in a block to explicitly create a new scope,
1994 # which is commonly used to control the lifetime of
1995 # stack-allocated variables. We don't detect this perfectly: we
1996 # just don't complain if the last non-whitespace character on the
1997 # previous non-blank line is ';', ':', '{', or '}'.
1998 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
1999 if not Search(r'[;:}{]\s*$', prevline):
2000 error(filename, linenum, 'whitespace/braces', 4,
2001 '{ should almost always be at the end of the previous line')
2002
2003 # An else clause should be on the same line as the preceding closing brace.
2004 if Match(r'\s*else\s*', line):
2005 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
2006 if Match(r'\s*}\s*$', prevline):
2007 error(filename, linenum, 'whitespace/newline', 4,
2008 'An else should appear on the same line as the preceding }')
2009
2010 # If braces come on one side of an else, they should be on both.
2011 # However, we have to worry about "else if" that spans multiple lines!
2012 if Search(r'}\s*else[^{]*$', line) or Match(r'[^}]*else\s*{', line):
2013 if Search(r'}\s*else if([^{]*)$', line): # could be multi-line if
2014 # find the ( after the if
2015 pos = line.find('else if')
2016 pos = line.find('(', pos)
2017 if pos > 0:
2018 (endline, _, endpos) = CloseExpression(clean_lines, linenum, pos)
2019 if endline[endpos:].find('{') == -1: # must be brace after if
2020 error(filename, linenum, 'readability/braces', 5,
2021 'If an else has a brace on one side, it should have it on both')
2022 else: # common case: else not followed by a multi-line if
2023 error(filename, linenum, 'readability/braces', 5,
2024 'If an else has a brace on one side, it should have it on both')
2025
2026 # Likewise, an else should never have the else clause on the same line
2027 if Search(r'\belse [^\s{]', line) and not Search(r'\belse if\b', line):
2028 error(filename, linenum, 'whitespace/newline', 4,
2029 'Else clause should never be on same line as else (use 2 lines)')
2030
2031 # In the same way, a do/while should never be on one line
2032 if Match(r'\s*do [^\s{]', line):
2033 error(filename, linenum, 'whitespace/newline', 4,
2034 'do/while clauses should not be on a single line')
2035
2036 # Braces shouldn't be followed by a ; unless they're defining a struct
2037 # or initializing an array.
2038 # We can't tell in general, but we can for some common cases.
2039 prevlinenum = linenum
2040 while True:
2041 (prevline, prevlinenum) = GetPreviousNonBlankLine(clean_lines, prevlinenum)
2042 if Match(r'\s+{.*}\s*;', line) and not prevline.count(';'):
2043 line = prevline + line
2044 else:
2045 break
2046 if (Search(r'{.*}\s*;', line) and
2047 line.count('{') == line.count('}') and
2048 not Search(r'struct|class|enum|\s*=\s*{', line)):
2049 error(filename, linenum, 'readability/braces', 4,
2050 "You don't need a ; after a }")
2051
2052
2053def ReplaceableCheck(operator, macro, line):
2054 """Determine whether a basic CHECK can be replaced with a more specific one.
2055
2056 For example suggest using CHECK_EQ instead of CHECK(a == b) and
2057 similarly for CHECK_GE, CHECK_GT, CHECK_LE, CHECK_LT, CHECK_NE.
2058
2059 Args:
2060 operator: The C++ operator used in the CHECK.
2061 macro: The CHECK or EXPECT macro being called.
2062 line: The current source line.
2063
2064 Returns:
2065 True if the CHECK can be replaced with a more specific one.
2066 """
2067
2068 # This matches decimal and hex integers, strings, and chars (in that order).
2069 match_constant = r'([-+]?(\d+|0[xX][0-9a-fA-F]+)[lLuU]{0,3}|".*"|\'.*\')'
2070
2071 # Expression to match two sides of the operator with something that
2072 # looks like a literal, since CHECK(x == iterator) won't compile.
2073 # This means we can't catch all the cases where a more specific
2074 # CHECK is possible, but it's less annoying than dealing with
2075 # extraneous warnings.
2076 match_this = (r'\s*' + macro + r'\((\s*' +
2077 match_constant + r'\s*' + operator + r'[^<>].*|'
2078 r'.*[^<>]' + operator + r'\s*' + match_constant +
2079 r'\s*\))')
2080
2081 # Don't complain about CHECK(x == NULL) or similar because
2082 # CHECK_EQ(x, NULL) won't compile (requires a cast).
2083 # Also, don't complain about more complex boolean expressions
2084 # involving && or || such as CHECK(a == b || c == d).
2085 return Match(match_this, line) and not Search(r'NULL|&&|\|\|', line)
2086
2087
2088def CheckCheck(filename, clean_lines, linenum, error):
2089 """Checks the use of CHECK and EXPECT macros.
2090
2091 Args:
2092 filename: The name of the current file.
2093 clean_lines: A CleansedLines instance containing the file.
2094 linenum: The number of the line to check.
2095 error: The function to call with any errors found.
2096 """
2097
2098 # Decide the set of replacement macros that should be suggested
2099 raw_lines = clean_lines.raw_lines
2100 current_macro = ''
2101 for macro in _CHECK_MACROS:
2102 if raw_lines[linenum].find(macro) >= 0:
2103 current_macro = macro
2104 break
2105 if not current_macro:
2106 # Don't waste time here if line doesn't contain 'CHECK' or 'EXPECT'
2107 return
2108
2109 line = clean_lines.elided[linenum] # get rid of comments and strings
2110
2111 # Encourage replacing plain CHECKs with CHECK_EQ/CHECK_NE/etc.
2112 for operator in ['==', '!=', '>=', '>', '<=', '<']:
2113 if ReplaceableCheck(operator, current_macro, line):
2114 error(filename, linenum, 'readability/check', 2,
2115 'Consider using %s instead of %s(a %s b)' % (
2116 _CHECK_REPLACEMENT[current_macro][operator],
2117 current_macro, operator))
2118 break
2119
2120
2121def GetLineWidth(line):
2122 """Determines the width of the line in column positions.
2123
2124 Args:
2125 line: A string, which may be a Unicode string.
2126
2127 Returns:
2128 The width of the line in column positions, accounting for Unicode
2129 combining characters and wide characters.
2130 """
2131 if isinstance(line, unicode):
2132 width = 0
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002133 for uc in unicodedata.normalize('NFC', line):
2134 if unicodedata.east_asian_width(uc) in ('W', 'F'):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002135 width += 2
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002136 elif not unicodedata.combining(uc):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002137 width += 1
2138 return width
2139 else:
2140 return len(line)
2141
2142
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002143def CheckStyle(filename, clean_lines, linenum, file_extension, class_state,
2144 error):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002145 """Checks rules from the 'C++ style rules' section of cppguide.html.
2146
2147 Most of these rules are hard to test (naming, comment style), but we
2148 do what we can. In particular we check for 2-space indents, line lengths,
2149 tab usage, spaces inside code, etc.
2150
2151 Args:
2152 filename: The name of the current file.
2153 clean_lines: A CleansedLines instance containing the file.
2154 linenum: The number of the line to check.
2155 file_extension: The extension (without the dot) of the filename.
2156 error: The function to call with any errors found.
2157 """
2158
2159 raw_lines = clean_lines.raw_lines
2160 line = raw_lines[linenum]
2161
2162 if line.find('\t') != -1:
2163 error(filename, linenum, 'whitespace/tab', 1,
2164 'Tab found; better to use spaces')
2165
2166 # One or three blank spaces at the beginning of the line is weird; it's
2167 # hard to reconcile that with 2-space indents.
2168 # NOTE: here are the conditions rob pike used for his tests. Mine aren't
2169 # as sophisticated, but it may be worth becoming so: RLENGTH==initial_spaces
2170 # if(RLENGTH > 20) complain = 0;
2171 # if(match($0, " +(error|private|public|protected):")) complain = 0;
2172 # if(match(prev, "&& *$")) complain = 0;
2173 # if(match(prev, "\\|\\| *$")) complain = 0;
2174 # if(match(prev, "[\",=><] *$")) complain = 0;
2175 # if(match($0, " <<")) complain = 0;
2176 # if(match(prev, " +for \\(")) complain = 0;
2177 # if(prevodd && match(prevprev, " +for \\(")) complain = 0;
2178 initial_spaces = 0
2179 cleansed_line = clean_lines.elided[linenum]
2180 while initial_spaces < len(line) and line[initial_spaces] == ' ':
2181 initial_spaces += 1
2182 if line and line[-1].isspace():
2183 error(filename, linenum, 'whitespace/end_of_line', 4,
2184 'Line ends in whitespace. Consider deleting these extra spaces.')
2185 # There are certain situations we allow one space, notably for labels
2186 elif ((initial_spaces == 1 or initial_spaces == 3) and
2187 not Match(r'\s*\w+\s*:\s*$', cleansed_line)):
2188 error(filename, linenum, 'whitespace/indent', 3,
2189 'Weird number of spaces at line-start. '
2190 'Are you using a 2-space indent?')
2191 # Labels should always be indented at least one space.
2192 elif not initial_spaces and line[:2] != '//' and Search(r'[^:]:\s*$',
2193 line):
2194 error(filename, linenum, 'whitespace/labels', 4,
2195 'Labels should always be indented at least one space. '
erg@google.com35589e62010-11-17 18:58:16 +00002196 'If this is a member-initializer list in a constructor or '
2197 'the base class list in a class definition, the colon should '
2198 'be on the following line.')
2199
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002200
2201 # Check if the line is a header guard.
2202 is_header_guard = False
2203 if file_extension == 'h':
2204 cppvar = GetHeaderGuardCPPVariable(filename)
2205 if (line.startswith('#ifndef %s' % cppvar) or
2206 line.startswith('#define %s' % cppvar) or
2207 line.startswith('#endif // %s' % cppvar)):
2208 is_header_guard = True
2209 # #include lines and header guards can be long, since there's no clean way to
2210 # split them.
erg@google.com6317a9c2009-06-25 00:28:19 +00002211 #
2212 # URLs can be long too. It's possible to split these, but it makes them
2213 # harder to cut&paste.
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002214 #
2215 # The "$Id:...$" comment may also get very long without it being the
2216 # developers fault.
erg@google.com6317a9c2009-06-25 00:28:19 +00002217 if (not line.startswith('#include') and not is_header_guard and
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002218 not Match(r'^\s*//.*http(s?)://\S*$', line) and
2219 not Match(r'^// \$Id:.*#[0-9]+ \$$', line)):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002220 line_width = GetLineWidth(line)
2221 if line_width > 100:
2222 error(filename, linenum, 'whitespace/line_length', 4,
2223 'Lines should very rarely be longer than 100 characters')
2224 elif line_width > 80:
2225 error(filename, linenum, 'whitespace/line_length', 2,
2226 'Lines should be <= 80 characters long')
2227
2228 if (cleansed_line.count(';') > 1 and
2229 # for loops are allowed two ;'s (and may run over two lines).
2230 cleansed_line.find('for') == -1 and
2231 (GetPreviousNonBlankLine(clean_lines, linenum)[0].find('for') == -1 or
2232 GetPreviousNonBlankLine(clean_lines, linenum)[0].find(';') != -1) and
2233 # It's ok to have many commands in a switch case that fits in 1 line
2234 not ((cleansed_line.find('case ') != -1 or
2235 cleansed_line.find('default:') != -1) and
2236 cleansed_line.find('break;') != -1)):
2237 error(filename, linenum, 'whitespace/newline', 4,
2238 'More than one command on the same line')
2239
2240 # Some more style checks
2241 CheckBraces(filename, clean_lines, linenum, error)
2242 CheckSpacing(filename, clean_lines, linenum, error)
2243 CheckCheck(filename, clean_lines, linenum, error)
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002244 if class_state and class_state.classinfo_stack:
2245 CheckSectionSpacing(filename, clean_lines,
2246 class_state.classinfo_stack[-1], linenum, error)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002247
2248
2249_RE_PATTERN_INCLUDE_NEW_STYLE = re.compile(r'#include +"[^/]+\.h"')
2250_RE_PATTERN_INCLUDE = re.compile(r'^\s*#\s*include\s*([<"])([^>"]*)[>"].*$')
2251# Matches the first component of a filename delimited by -s and _s. That is:
2252# _RE_FIRST_COMPONENT.match('foo').group(0) == 'foo'
2253# _RE_FIRST_COMPONENT.match('foo.cc').group(0) == 'foo'
2254# _RE_FIRST_COMPONENT.match('foo-bar_baz.cc').group(0) == 'foo'
2255# _RE_FIRST_COMPONENT.match('foo_bar-baz.cc').group(0) == 'foo'
2256_RE_FIRST_COMPONENT = re.compile(r'^[^-_.]+')
2257
2258
2259def _DropCommonSuffixes(filename):
2260 """Drops common suffixes like _test.cc or -inl.h from filename.
2261
2262 For example:
2263 >>> _DropCommonSuffixes('foo/foo-inl.h')
2264 'foo/foo'
2265 >>> _DropCommonSuffixes('foo/bar/foo.cc')
2266 'foo/bar/foo'
2267 >>> _DropCommonSuffixes('foo/foo_internal.h')
2268 'foo/foo'
2269 >>> _DropCommonSuffixes('foo/foo_unusualinternal.h')
2270 'foo/foo_unusualinternal'
2271
2272 Args:
2273 filename: The input filename.
2274
2275 Returns:
2276 The filename with the common suffix removed.
2277 """
2278 for suffix in ('test.cc', 'regtest.cc', 'unittest.cc',
2279 'inl.h', 'impl.h', 'internal.h'):
2280 if (filename.endswith(suffix) and len(filename) > len(suffix) and
2281 filename[-len(suffix) - 1] in ('-', '_')):
2282 return filename[:-len(suffix) - 1]
2283 return os.path.splitext(filename)[0]
2284
2285
2286def _IsTestFilename(filename):
2287 """Determines if the given filename has a suffix that identifies it as a test.
2288
2289 Args:
2290 filename: The input filename.
2291
2292 Returns:
2293 True if 'filename' looks like a test, False otherwise.
2294 """
2295 if (filename.endswith('_test.cc') or
2296 filename.endswith('_unittest.cc') or
2297 filename.endswith('_regtest.cc')):
2298 return True
2299 else:
2300 return False
2301
2302
2303def _ClassifyInclude(fileinfo, include, is_system):
2304 """Figures out what kind of header 'include' is.
2305
2306 Args:
2307 fileinfo: The current file cpplint is running over. A FileInfo instance.
2308 include: The path to a #included file.
2309 is_system: True if the #include used <> rather than "".
2310
2311 Returns:
2312 One of the _XXX_HEADER constants.
2313
2314 For example:
2315 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'stdio.h', True)
2316 _C_SYS_HEADER
2317 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'string', True)
2318 _CPP_SYS_HEADER
2319 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/foo.h', False)
2320 _LIKELY_MY_HEADER
2321 >>> _ClassifyInclude(FileInfo('foo/foo_unknown_extension.cc'),
2322 ... 'bar/foo_other_ext.h', False)
2323 _POSSIBLE_MY_HEADER
2324 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/bar.h', False)
2325 _OTHER_HEADER
2326 """
2327 # This is a list of all standard c++ header files, except
2328 # those already checked for above.
2329 is_stl_h = include in _STL_HEADERS
2330 is_cpp_h = is_stl_h or include in _CPP_HEADERS
2331
2332 if is_system:
2333 if is_cpp_h:
2334 return _CPP_SYS_HEADER
2335 else:
2336 return _C_SYS_HEADER
2337
2338 # If the target file and the include we're checking share a
2339 # basename when we drop common extensions, and the include
2340 # lives in . , then it's likely to be owned by the target file.
2341 target_dir, target_base = (
2342 os.path.split(_DropCommonSuffixes(fileinfo.RepositoryName())))
2343 include_dir, include_base = os.path.split(_DropCommonSuffixes(include))
2344 if target_base == include_base and (
2345 include_dir == target_dir or
2346 include_dir == os.path.normpath(target_dir + '/../public')):
2347 return _LIKELY_MY_HEADER
2348
2349 # If the target and include share some initial basename
2350 # component, it's possible the target is implementing the
2351 # include, so it's allowed to be first, but we'll never
2352 # complain if it's not there.
2353 target_first_component = _RE_FIRST_COMPONENT.match(target_base)
2354 include_first_component = _RE_FIRST_COMPONENT.match(include_base)
2355 if (target_first_component and include_first_component and
2356 target_first_component.group(0) ==
2357 include_first_component.group(0)):
2358 return _POSSIBLE_MY_HEADER
2359
2360 return _OTHER_HEADER
2361
2362
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002363
erg@google.com6317a9c2009-06-25 00:28:19 +00002364def CheckIncludeLine(filename, clean_lines, linenum, include_state, error):
2365 """Check rules that are applicable to #include lines.
2366
2367 Strings on #include lines are NOT removed from elided line, to make
2368 certain tasks easier. However, to prevent false positives, checks
2369 applicable to #include lines in CheckLanguage must be put here.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002370
2371 Args:
2372 filename: The name of the current file.
2373 clean_lines: A CleansedLines instance containing the file.
2374 linenum: The number of the line to check.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002375 include_state: An _IncludeState instance in which the headers are inserted.
2376 error: The function to call with any errors found.
2377 """
2378 fileinfo = FileInfo(filename)
2379
erg@google.com6317a9c2009-06-25 00:28:19 +00002380 line = clean_lines.lines[linenum]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002381
2382 # "include" should use the new style "foo/bar.h" instead of just "bar.h"
erg@google.com6317a9c2009-06-25 00:28:19 +00002383 if _RE_PATTERN_INCLUDE_NEW_STYLE.search(line):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002384 error(filename, linenum, 'build/include', 4,
2385 'Include the directory when naming .h files')
2386
2387 # we shouldn't include a file more than once. actually, there are a
2388 # handful of instances where doing so is okay, but in general it's
2389 # not.
erg@google.com6317a9c2009-06-25 00:28:19 +00002390 match = _RE_PATTERN_INCLUDE.search(line)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002391 if match:
2392 include = match.group(2)
2393 is_system = (match.group(1) == '<')
2394 if include in include_state:
2395 error(filename, linenum, 'build/include', 4,
2396 '"%s" already included at %s:%s' %
2397 (include, filename, include_state[include]))
2398 else:
2399 include_state[include] = linenum
2400
2401 # We want to ensure that headers appear in the right order:
2402 # 1) for foo.cc, foo.h (preferred location)
2403 # 2) c system files
2404 # 3) cpp system files
2405 # 4) for foo.cc, foo.h (deprecated location)
2406 # 5) other google headers
2407 #
2408 # We classify each include statement as one of those 5 types
2409 # using a number of techniques. The include_state object keeps
2410 # track of the highest type seen, and complains if we see a
2411 # lower type after that.
2412 error_message = include_state.CheckNextIncludeOrder(
2413 _ClassifyInclude(fileinfo, include, is_system))
2414 if error_message:
2415 error(filename, linenum, 'build/include_order', 4,
2416 '%s. Should be: %s.h, c system, c++ system, other.' %
2417 (error_message, fileinfo.BaseName()))
erg@google.com26970fa2009-11-17 18:07:32 +00002418 if not include_state.IsInAlphabeticalOrder(include):
2419 error(filename, linenum, 'build/include_alpha', 4,
2420 'Include "%s" not in alphabetical order' % include)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002421
erg@google.com6317a9c2009-06-25 00:28:19 +00002422 # Look for any of the stream classes that are part of standard C++.
2423 match = _RE_PATTERN_INCLUDE.match(line)
2424 if match:
2425 include = match.group(2)
2426 if Match(r'(f|ind|io|i|o|parse|pf|stdio|str|)?stream$', include):
2427 # Many unit tests use cout, so we exempt them.
2428 if not _IsTestFilename(filename):
2429 error(filename, linenum, 'readability/streams', 3,
2430 'Streams are highly discouraged.')
2431
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002432
2433def _GetTextInside(text, start_pattern):
2434 """Retrieves all the text between matching open and close parentheses.
2435
2436 Given a string of lines and a regular expression string, retrieve all the text
2437 following the expression and between opening punctuation symbols like
2438 (, [, or {, and the matching close-punctuation symbol. This properly nested
2439 occurrences of the punctuations, so for the text like
2440 printf(a(), b(c()));
2441 a call to _GetTextInside(text, r'printf\(') will return 'a(), b(c())'.
2442 start_pattern must match string having an open punctuation symbol at the end.
2443
2444 Args:
2445 text: The lines to extract text. Its comments and strings must be elided.
2446 It can be single line and can span multiple lines.
2447 start_pattern: The regexp string indicating where to start extracting
2448 the text.
2449 Returns:
2450 The extracted text.
2451 None if either the opening string or ending punctuation could not be found.
2452 """
2453 # TODO(sugawarayu): Audit cpplint.py to see what places could be profitably
2454 # rewritten to use _GetTextInside (and use inferior regexp matching today).
2455
2456 # Give opening punctuations to get the matching close-punctuations.
2457 matching_punctuation = {'(': ')', '{': '}', '[': ']'}
2458 closing_punctuation = set(matching_punctuation.itervalues())
2459
2460 # Find the position to start extracting text.
2461 match = re.search(start_pattern, text, re.M)
2462 if not match: # start_pattern not found in text.
2463 return None
2464 start_position = match.end(0)
2465
2466 assert start_position > 0, (
2467 'start_pattern must ends with an opening punctuation.')
2468 assert text[start_position - 1] in matching_punctuation, (
2469 'start_pattern must ends with an opening punctuation.')
2470 # Stack of closing punctuations we expect to have in text after position.
2471 punctuation_stack = [matching_punctuation[text[start_position - 1]]]
2472 position = start_position
2473 while punctuation_stack and position < len(text):
2474 if text[position] == punctuation_stack[-1]:
2475 punctuation_stack.pop()
2476 elif text[position] in closing_punctuation:
2477 # A closing punctuation without matching opening punctuations.
2478 return None
2479 elif text[position] in matching_punctuation:
2480 punctuation_stack.append(matching_punctuation[text[position]])
2481 position += 1
2482 if punctuation_stack:
2483 # Opening punctuations left without matching close-punctuations.
2484 return None
2485 # punctuations match.
2486 return text[start_position:position - 1]
2487
2488
erg@google.com6317a9c2009-06-25 00:28:19 +00002489def CheckLanguage(filename, clean_lines, linenum, file_extension, include_state,
2490 error):
2491 """Checks rules from the 'C++ language rules' section of cppguide.html.
2492
2493 Some of these rules are hard to test (function overloading, using
2494 uint32 inappropriately), but we do the best we can.
2495
2496 Args:
2497 filename: The name of the current file.
2498 clean_lines: A CleansedLines instance containing the file.
2499 linenum: The number of the line to check.
2500 file_extension: The extension (without the dot) of the filename.
2501 include_state: An _IncludeState instance in which the headers are inserted.
2502 error: The function to call with any errors found.
2503 """
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002504 # If the line is empty or consists of entirely a comment, no need to
2505 # check it.
2506 line = clean_lines.elided[linenum]
2507 if not line:
2508 return
2509
erg@google.com6317a9c2009-06-25 00:28:19 +00002510 match = _RE_PATTERN_INCLUDE.search(line)
2511 if match:
2512 CheckIncludeLine(filename, clean_lines, linenum, include_state, error)
2513 return
2514
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002515 # Create an extended_line, which is the concatenation of the current and
2516 # next lines, for more effective checking of code that may span more than one
2517 # line.
2518 if linenum + 1 < clean_lines.NumLines():
2519 extended_line = line + clean_lines.elided[linenum + 1]
2520 else:
2521 extended_line = line
2522
2523 # Make Windows paths like Unix.
2524 fullname = os.path.abspath(filename).replace('\\', '/')
2525
2526 # TODO(unknown): figure out if they're using default arguments in fn proto.
2527
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002528 # Check for non-const references in functions. This is tricky because &
2529 # is also used to take the address of something. We allow <> for templates,
2530 # (ignoring whatever is between the braces) and : for classes.
2531 # These are complicated re's. They try to capture the following:
2532 # paren (for fn-prototype start), typename, &, varname. For the const
2533 # version, we're willing for const to be before typename or after
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002534 # Don't check the implementation on same line.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002535 fnline = line.split('{', 1)[0]
2536 if (len(re.findall(r'\([^()]*\b(?:[\w:]|<[^()]*>)+(\s?&|&\s?)\w+', fnline)) >
2537 len(re.findall(r'\([^()]*\bconst\s+(?:typename\s+)?(?:struct\s+)?'
2538 r'(?:[\w:]|<[^()]*>)+(\s?&|&\s?)\w+', fnline)) +
2539 len(re.findall(r'\([^()]*\b(?:[\w:]|<[^()]*>)+\s+const(\s?&|&\s?)[\w]+',
2540 fnline))):
2541
2542 # We allow non-const references in a few standard places, like functions
2543 # called "swap()" or iostream operators like "<<" or ">>".
2544 if not Search(
2545 r'(swap|Swap|operator[<>][<>])\s*\(\s*(?:[\w:]|<.*>)+\s*&',
2546 fnline):
2547 error(filename, linenum, 'runtime/references', 2,
2548 'Is this a non-const reference? '
2549 'If so, make const or use a pointer.')
2550
2551 # Check to see if they're using an conversion function cast.
2552 # I just try to capture the most common basic types, though there are more.
2553 # Parameterless conversion functions, such as bool(), are allowed as they are
2554 # probably a member operator declaration or default constructor.
2555 match = Search(
erg@google.com26970fa2009-11-17 18:07:32 +00002556 r'(\bnew\s+)?\b' # Grab 'new' operator, if it's there
2557 r'(int|float|double|bool|char|int32|uint32|int64|uint64)\([^)]', line)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002558 if match:
2559 # gMock methods are defined using some variant of MOCK_METHODx(name, type)
2560 # where type may be float(), int(string), etc. Without context they are
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002561 # virtually indistinguishable from int(x) casts. Likewise, gMock's
2562 # MockCallback takes a template parameter of the form return_type(arg_type),
2563 # which looks much like the cast we're trying to detect.
erg@google.com26970fa2009-11-17 18:07:32 +00002564 if (match.group(1) is None and # If new operator, then this isn't a cast
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002565 not (Match(r'^\s*MOCK_(CONST_)?METHOD\d+(_T)?\(', line) or
2566 Match(r'^\s*MockCallback<.*>', line))):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002567 error(filename, linenum, 'readability/casting', 4,
2568 'Using deprecated casting style. '
2569 'Use static_cast<%s>(...) instead' %
erg@google.com26970fa2009-11-17 18:07:32 +00002570 match.group(2))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002571
2572 CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum],
2573 'static_cast',
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002574 r'\((int|float|double|bool|char|u?int(16|32|64))\)', error)
2575
2576 # This doesn't catch all cases. Consider (const char * const)"hello".
2577 #
2578 # (char *) "foo" should always be a const_cast (reinterpret_cast won't
2579 # compile).
2580 if CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum],
2581 'const_cast', r'\((char\s?\*+\s?)\)\s*"', error):
2582 pass
2583 else:
2584 # Check pointer casts for other than string constants
2585 CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum],
2586 'reinterpret_cast', r'\((\w+\s?\*+\s?)\)', error)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002587
2588 # In addition, we look for people taking the address of a cast. This
2589 # is dangerous -- casts can assign to temporaries, so the pointer doesn't
2590 # point where you think.
2591 if Search(
2592 r'(&\([^)]+\)[\w(])|(&(static|dynamic|reinterpret)_cast\b)', line):
2593 error(filename, linenum, 'runtime/casting', 4,
2594 ('Are you taking an address of a cast? '
2595 'This is dangerous: could be a temp var. '
2596 'Take the address before doing the cast, rather than after'))
2597
2598 # Check for people declaring static/global STL strings at the top level.
2599 # This is dangerous because the C++ language does not guarantee that
2600 # globals with constructors are initialized before the first access.
2601 match = Match(
2602 r'((?:|static +)(?:|const +))string +([a-zA-Z0-9_:]+)\b(.*)',
2603 line)
2604 # Make sure it's not a function.
2605 # Function template specialization looks like: "string foo<Type>(...".
2606 # Class template definitions look like: "string Foo<Type>::Method(...".
2607 if match and not Match(r'\s*(<.*>)?(::[a-zA-Z0-9_]+)?\s*\(([^"]|$)',
2608 match.group(3)):
2609 error(filename, linenum, 'runtime/string', 4,
2610 'For a static/global string constant, use a C style string instead: '
2611 '"%schar %s[]".' %
2612 (match.group(1), match.group(2)))
2613
2614 # Check that we're not using RTTI outside of testing code.
2615 if Search(r'\bdynamic_cast<', line) and not _IsTestFilename(filename):
2616 error(filename, linenum, 'runtime/rtti', 5,
2617 'Do not use dynamic_cast<>. If you need to cast within a class '
2618 "hierarchy, use static_cast<> to upcast. Google doesn't support "
2619 'RTTI.')
2620
2621 if Search(r'\b([A-Za-z0-9_]*_)\(\1\)', line):
2622 error(filename, linenum, 'runtime/init', 4,
2623 'You seem to be initializing a member variable with itself.')
2624
2625 if file_extension == 'h':
2626 # TODO(unknown): check that 1-arg constructors are explicit.
2627 # How to tell it's a constructor?
2628 # (handled in CheckForNonStandardConstructs for now)
2629 # TODO(unknown): check that classes have DISALLOW_EVIL_CONSTRUCTORS
2630 # (level 1 error)
2631 pass
2632
2633 # Check if people are using the verboten C basic types. The only exception
2634 # we regularly allow is "unsigned short port" for port.
2635 if Search(r'\bshort port\b', line):
2636 if not Search(r'\bunsigned short port\b', line):
2637 error(filename, linenum, 'runtime/int', 4,
2638 'Use "unsigned short" for ports, not "short"')
2639 else:
2640 match = Search(r'\b(short|long(?! +double)|long long)\b', line)
2641 if match:
2642 error(filename, linenum, 'runtime/int', 4,
2643 'Use int16/int64/etc, rather than the C type %s' % match.group(1))
2644
2645 # When snprintf is used, the second argument shouldn't be a literal.
2646 match = Search(r'snprintf\s*\(([^,]*),\s*([0-9]*)\s*,', line)
erg@google.com35589e62010-11-17 18:58:16 +00002647 if match and match.group(2) != '0':
2648 # If 2nd arg is zero, snprintf is used to calculate size.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002649 error(filename, linenum, 'runtime/printf', 3,
2650 'If you can, use sizeof(%s) instead of %s as the 2nd arg '
2651 'to snprintf.' % (match.group(1), match.group(2)))
2652
2653 # Check if some verboten C functions are being used.
2654 if Search(r'\bsprintf\b', line):
2655 error(filename, linenum, 'runtime/printf', 5,
2656 'Never use sprintf. Use snprintf instead.')
2657 match = Search(r'\b(strcpy|strcat)\b', line)
2658 if match:
2659 error(filename, linenum, 'runtime/printf', 4,
2660 'Almost always, snprintf is better than %s' % match.group(1))
2661
2662 if Search(r'\bsscanf\b', line):
2663 error(filename, linenum, 'runtime/printf', 1,
2664 'sscanf can be ok, but is slow and can overflow buffers.')
2665
erg@google.com26970fa2009-11-17 18:07:32 +00002666 # Check if some verboten operator overloading is going on
2667 # TODO(unknown): catch out-of-line unary operator&:
2668 # class X {};
2669 # int operator&(const X& x) { return 42; } // unary operator&
2670 # The trick is it's hard to tell apart from binary operator&:
2671 # class Y { int operator&(const Y& x) { return 23; } }; // binary operator&
2672 if Search(r'\boperator\s*&\s*\(\s*\)', line):
2673 error(filename, linenum, 'runtime/operator', 4,
2674 'Unary operator& is dangerous. Do not use it.')
2675
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002676 # Check for suspicious usage of "if" like
2677 # } if (a == b) {
2678 if Search(r'\}\s*if\s*\(', line):
2679 error(filename, linenum, 'readability/braces', 4,
2680 'Did you mean "else if"? If not, start a new line for "if".')
2681
2682 # Check for potential format string bugs like printf(foo).
2683 # We constrain the pattern not to pick things like DocidForPrintf(foo).
2684 # Not perfect but it can catch printf(foo.c_str()) and printf(foo->c_str())
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002685 # TODO(sugawarayu): Catch the following case. Need to change the calling
2686 # convention of the whole function to process multiple line to handle it.
2687 # printf(
2688 # boy_this_is_a_really_long_variable_that_cannot_fit_on_the_prev_line);
2689 printf_args = _GetTextInside(line, r'(?i)\b(string)?printf\s*\(')
2690 if printf_args:
2691 match = Match(r'([\w.\->()]+)$', printf_args)
2692 if match:
2693 function_name = re.search(r'\b((?:string)?printf)\s*\(',
2694 line, re.I).group(1)
2695 error(filename, linenum, 'runtime/printf', 4,
2696 'Potential format string bug. Do %s("%%s", %s) instead.'
2697 % (function_name, match.group(1)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002698
2699 # Check for potential memset bugs like memset(buf, sizeof(buf), 0).
2700 match = Search(r'memset\s*\(([^,]*),\s*([^,]*),\s*0\s*\)', line)
2701 if match and not Match(r"^''|-?[0-9]+|0x[0-9A-Fa-f]$", match.group(2)):
2702 error(filename, linenum, 'runtime/memset', 4,
2703 'Did you mean "memset(%s, 0, %s)"?'
2704 % (match.group(1), match.group(2)))
2705
2706 if Search(r'\busing namespace\b', line):
2707 error(filename, linenum, 'build/namespaces', 5,
2708 'Do not use namespace using-directives. '
2709 'Use using-declarations instead.')
2710
2711 # Detect variable-length arrays.
2712 match = Match(r'\s*(.+::)?(\w+) [a-z]\w*\[(.+)];', line)
2713 if (match and match.group(2) != 'return' and match.group(2) != 'delete' and
2714 match.group(3).find(']') == -1):
2715 # Split the size using space and arithmetic operators as delimiters.
2716 # If any of the resulting tokens are not compile time constants then
2717 # report the error.
2718 tokens = re.split(r'\s|\+|\-|\*|\/|<<|>>]', match.group(3))
2719 is_const = True
2720 skip_next = False
2721 for tok in tokens:
2722 if skip_next:
2723 skip_next = False
2724 continue
2725
2726 if Search(r'sizeof\(.+\)', tok): continue
2727 if Search(r'arraysize\(\w+\)', tok): continue
2728
2729 tok = tok.lstrip('(')
2730 tok = tok.rstrip(')')
2731 if not tok: continue
2732 if Match(r'\d+', tok): continue
2733 if Match(r'0[xX][0-9a-fA-F]+', tok): continue
2734 if Match(r'k[A-Z0-9]\w*', tok): continue
2735 if Match(r'(.+::)?k[A-Z0-9]\w*', tok): continue
2736 if Match(r'(.+::)?[A-Z][A-Z0-9_]*', tok): continue
2737 # A catch all for tricky sizeof cases, including 'sizeof expression',
2738 # 'sizeof(*type)', 'sizeof(const type)', 'sizeof(struct StructName)'
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002739 # requires skipping the next token because we split on ' ' and '*'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002740 if tok.startswith('sizeof'):
2741 skip_next = True
2742 continue
2743 is_const = False
2744 break
2745 if not is_const:
2746 error(filename, linenum, 'runtime/arrays', 1,
2747 'Do not use variable-length arrays. Use an appropriately named '
2748 "('k' followed by CamelCase) compile-time constant for the size.")
2749
2750 # If DISALLOW_EVIL_CONSTRUCTORS, DISALLOW_COPY_AND_ASSIGN, or
2751 # DISALLOW_IMPLICIT_CONSTRUCTORS is present, then it should be the last thing
2752 # in the class declaration.
2753 match = Match(
2754 (r'\s*'
2755 r'(DISALLOW_(EVIL_CONSTRUCTORS|COPY_AND_ASSIGN|IMPLICIT_CONSTRUCTORS))'
2756 r'\(.*\);$'),
2757 line)
2758 if match and linenum + 1 < clean_lines.NumLines():
2759 next_line = clean_lines.elided[linenum + 1]
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002760 # We allow some, but not all, declarations of variables to be present
2761 # in the statement that defines the class. The [\w\*,\s]* fragment of
2762 # the regular expression below allows users to declare instances of
2763 # the class or pointers to instances, but not less common types such
2764 # as function pointers or arrays. It's a tradeoff between allowing
2765 # reasonable code and avoiding trying to parse more C++ using regexps.
2766 if not Search(r'^\s*}[\w\*,\s]*;', next_line):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002767 error(filename, linenum, 'readability/constructors', 3,
2768 match.group(1) + ' should be the last thing in the class')
2769
2770 # Check for use of unnamed namespaces in header files. Registration
2771 # macros are typically OK, so we allow use of "namespace {" on lines
2772 # that end with backslashes.
2773 if (file_extension == 'h'
2774 and Search(r'\bnamespace\s*{', line)
2775 and line[-1] != '\\'):
2776 error(filename, linenum, 'build/namespaces', 4,
2777 'Do not use unnamed namespaces in header files. See '
2778 'http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces'
2779 ' for more information.')
2780
2781
2782def CheckCStyleCast(filename, linenum, line, raw_line, cast_type, pattern,
2783 error):
2784 """Checks for a C-style cast by looking for the pattern.
2785
2786 This also handles sizeof(type) warnings, due to similarity of content.
2787
2788 Args:
2789 filename: The name of the current file.
2790 linenum: The number of the line to check.
2791 line: The line of code to check.
2792 raw_line: The raw line of code to check, with comments.
2793 cast_type: The string for the C++ cast to recommend. This is either
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002794 reinterpret_cast, static_cast, or const_cast, depending.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002795 pattern: The regular expression used to find C-style casts.
2796 error: The function to call with any errors found.
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002797
2798 Returns:
2799 True if an error was emitted.
2800 False otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002801 """
2802 match = Search(pattern, line)
2803 if not match:
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002804 return False
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002805
2806 # e.g., sizeof(int)
2807 sizeof_match = Match(r'.*sizeof\s*$', line[0:match.start(1) - 1])
2808 if sizeof_match:
2809 error(filename, linenum, 'runtime/sizeof', 1,
2810 'Using sizeof(type). Use sizeof(varname) instead if possible')
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002811 return True
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002812
2813 remainder = line[match.end(0):]
2814
2815 # The close paren is for function pointers as arguments to a function.
2816 # eg, void foo(void (*bar)(int));
2817 # The semicolon check is a more basic function check; also possibly a
2818 # function pointer typedef.
2819 # eg, void foo(int); or void foo(int) const;
2820 # The equals check is for function pointer assignment.
2821 # eg, void *(*foo)(int) = ...
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002822 # The > is for MockCallback<...> ...
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002823 #
2824 # Right now, this will only catch cases where there's a single argument, and
2825 # it's unnamed. It should probably be expanded to check for multiple
2826 # arguments with some unnamed.
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002827 function_match = Match(r'\s*(\)|=|(const)?\s*(;|\{|throw\(\)|>))', remainder)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002828 if function_match:
2829 if (not function_match.group(3) or
2830 function_match.group(3) == ';' or
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002831 ('MockCallback<' not in raw_line and
2832 '/*' not in raw_line)):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002833 error(filename, linenum, 'readability/function', 3,
2834 'All parameters should be named in a function')
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002835 return True
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002836
2837 # At this point, all that should be left is actual casts.
2838 error(filename, linenum, 'readability/casting', 4,
2839 'Using C-style cast. Use %s<%s>(...) instead' %
2840 (cast_type, match.group(1)))
2841
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00002842 return True
2843
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002844
2845_HEADERS_CONTAINING_TEMPLATES = (
2846 ('<deque>', ('deque',)),
2847 ('<functional>', ('unary_function', 'binary_function',
2848 'plus', 'minus', 'multiplies', 'divides', 'modulus',
2849 'negate',
2850 'equal_to', 'not_equal_to', 'greater', 'less',
2851 'greater_equal', 'less_equal',
2852 'logical_and', 'logical_or', 'logical_not',
2853 'unary_negate', 'not1', 'binary_negate', 'not2',
2854 'bind1st', 'bind2nd',
2855 'pointer_to_unary_function',
2856 'pointer_to_binary_function',
2857 'ptr_fun',
2858 'mem_fun_t', 'mem_fun', 'mem_fun1_t', 'mem_fun1_ref_t',
2859 'mem_fun_ref_t',
2860 'const_mem_fun_t', 'const_mem_fun1_t',
2861 'const_mem_fun_ref_t', 'const_mem_fun1_ref_t',
2862 'mem_fun_ref',
2863 )),
2864 ('<limits>', ('numeric_limits',)),
2865 ('<list>', ('list',)),
2866 ('<map>', ('map', 'multimap',)),
2867 ('<memory>', ('allocator',)),
2868 ('<queue>', ('queue', 'priority_queue',)),
2869 ('<set>', ('set', 'multiset',)),
2870 ('<stack>', ('stack',)),
2871 ('<string>', ('char_traits', 'basic_string',)),
2872 ('<utility>', ('pair',)),
2873 ('<vector>', ('vector',)),
2874
2875 # gcc extensions.
2876 # Note: std::hash is their hash, ::hash is our hash
2877 ('<hash_map>', ('hash_map', 'hash_multimap',)),
2878 ('<hash_set>', ('hash_set', 'hash_multiset',)),
2879 ('<slist>', ('slist',)),
2880 )
2881
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002882_RE_PATTERN_STRING = re.compile(r'\bstring\b')
2883
2884_re_pattern_algorithm_header = []
erg@google.com6317a9c2009-06-25 00:28:19 +00002885for _template in ('copy', 'max', 'min', 'min_element', 'sort', 'swap',
2886 'transform'):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002887 # Match max<type>(..., ...), max(..., ...), but not foo->max, foo.max or
2888 # type::max().
2889 _re_pattern_algorithm_header.append(
2890 (re.compile(r'[^>.]\b' + _template + r'(<.*?>)?\([^\)]'),
2891 _template,
2892 '<algorithm>'))
2893
2894_re_pattern_templates = []
2895for _header, _templates in _HEADERS_CONTAINING_TEMPLATES:
2896 for _template in _templates:
2897 _re_pattern_templates.append(
2898 (re.compile(r'(\<|\b)' + _template + r'\s*\<'),
2899 _template + '<>',
2900 _header))
2901
2902
erg@google.com6317a9c2009-06-25 00:28:19 +00002903def FilesBelongToSameModule(filename_cc, filename_h):
2904 """Check if these two filenames belong to the same module.
2905
2906 The concept of a 'module' here is a as follows:
2907 foo.h, foo-inl.h, foo.cc, foo_test.cc and foo_unittest.cc belong to the
2908 same 'module' if they are in the same directory.
2909 some/path/public/xyzzy and some/path/internal/xyzzy are also considered
2910 to belong to the same module here.
2911
2912 If the filename_cc contains a longer path than the filename_h, for example,
2913 '/absolute/path/to/base/sysinfo.cc', and this file would include
2914 'base/sysinfo.h', this function also produces the prefix needed to open the
2915 header. This is used by the caller of this function to more robustly open the
2916 header file. We don't have access to the real include paths in this context,
2917 so we need this guesswork here.
2918
2919 Known bugs: tools/base/bar.cc and base/bar.h belong to the same module
2920 according to this implementation. Because of this, this function gives
2921 some false positives. This should be sufficiently rare in practice.
2922
2923 Args:
2924 filename_cc: is the path for the .cc file
2925 filename_h: is the path for the header path
2926
2927 Returns:
2928 Tuple with a bool and a string:
2929 bool: True if filename_cc and filename_h belong to the same module.
2930 string: the additional prefix needed to open the header file.
2931 """
2932
2933 if not filename_cc.endswith('.cc'):
2934 return (False, '')
2935 filename_cc = filename_cc[:-len('.cc')]
2936 if filename_cc.endswith('_unittest'):
2937 filename_cc = filename_cc[:-len('_unittest')]
2938 elif filename_cc.endswith('_test'):
2939 filename_cc = filename_cc[:-len('_test')]
2940 filename_cc = filename_cc.replace('/public/', '/')
2941 filename_cc = filename_cc.replace('/internal/', '/')
2942
2943 if not filename_h.endswith('.h'):
2944 return (False, '')
2945 filename_h = filename_h[:-len('.h')]
2946 if filename_h.endswith('-inl'):
2947 filename_h = filename_h[:-len('-inl')]
2948 filename_h = filename_h.replace('/public/', '/')
2949 filename_h = filename_h.replace('/internal/', '/')
2950
2951 files_belong_to_same_module = filename_cc.endswith(filename_h)
2952 common_path = ''
2953 if files_belong_to_same_module:
2954 common_path = filename_cc[:-len(filename_h)]
2955 return files_belong_to_same_module, common_path
2956
2957
2958def UpdateIncludeState(filename, include_state, io=codecs):
2959 """Fill up the include_state with new includes found from the file.
2960
2961 Args:
2962 filename: the name of the header to read.
2963 include_state: an _IncludeState instance in which the headers are inserted.
2964 io: The io factory to use to read the file. Provided for testability.
2965
2966 Returns:
2967 True if a header was succesfully added. False otherwise.
2968 """
2969 headerfile = None
2970 try:
2971 headerfile = io.open(filename, 'r', 'utf8', 'replace')
2972 except IOError:
2973 return False
2974 linenum = 0
2975 for line in headerfile:
2976 linenum += 1
2977 clean_line = CleanseComments(line)
2978 match = _RE_PATTERN_INCLUDE.search(clean_line)
2979 if match:
2980 include = match.group(2)
2981 # The value formatting is cute, but not really used right now.
2982 # What matters here is that the key is in include_state.
2983 include_state.setdefault(include, '%s:%d' % (filename, linenum))
2984 return True
2985
2986
2987def CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error,
2988 io=codecs):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002989 """Reports for missing stl includes.
2990
2991 This function will output warnings to make sure you are including the headers
2992 necessary for the stl containers and functions that you use. We only give one
2993 reason to include a header. For example, if you use both equal_to<> and
2994 less<> in a .h file, only one (the latter in the file) of these will be
2995 reported as a reason to include the <functional>.
2996
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002997 Args:
2998 filename: The name of the current file.
2999 clean_lines: A CleansedLines instance containing the file.
3000 include_state: An _IncludeState instance.
3001 error: The function to call with any errors found.
erg@google.com6317a9c2009-06-25 00:28:19 +00003002 io: The IO factory to use to read the header file. Provided for unittest
3003 injection.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003004 """
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003005 required = {} # A map of header name to linenumber and the template entity.
3006 # Example of required: { '<functional>': (1219, 'less<>') }
3007
3008 for linenum in xrange(clean_lines.NumLines()):
3009 line = clean_lines.elided[linenum]
3010 if not line or line[0] == '#':
3011 continue
3012
3013 # String is special -- it is a non-templatized type in STL.
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003014 matched = _RE_PATTERN_STRING.search(line)
3015 if matched:
erg@google.com35589e62010-11-17 18:58:16 +00003016 # Don't warn about strings in non-STL namespaces:
3017 # (We check only the first match per line; good enough.)
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003018 prefix = line[:matched.start()]
erg@google.com35589e62010-11-17 18:58:16 +00003019 if prefix.endswith('std::') or not prefix.endswith('::'):
3020 required['<string>'] = (linenum, 'string')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003021
3022 for pattern, template, header in _re_pattern_algorithm_header:
3023 if pattern.search(line):
3024 required[header] = (linenum, template)
3025
3026 # The following function is just a speed up, no semantics are changed.
3027 if not '<' in line: # Reduces the cpu time usage by skipping lines.
3028 continue
3029
3030 for pattern, template, header in _re_pattern_templates:
3031 if pattern.search(line):
3032 required[header] = (linenum, template)
3033
erg@google.com6317a9c2009-06-25 00:28:19 +00003034 # The policy is that if you #include something in foo.h you don't need to
3035 # include it again in foo.cc. Here, we will look at possible includes.
3036 # Let's copy the include_state so it is only messed up within this function.
3037 include_state = include_state.copy()
3038
3039 # Did we find the header for this file (if any) and succesfully load it?
3040 header_found = False
3041
3042 # Use the absolute path so that matching works properly.
3043 abs_filename = os.path.abspath(filename)
3044
3045 # For Emacs's flymake.
3046 # If cpplint is invoked from Emacs's flymake, a temporary file is generated
3047 # by flymake and that file name might end with '_flymake.cc'. In that case,
3048 # restore original file name here so that the corresponding header file can be
3049 # found.
3050 # e.g. If the file name is 'foo_flymake.cc', we should search for 'foo.h'
3051 # instead of 'foo_flymake.h'
erg@google.com35589e62010-11-17 18:58:16 +00003052 abs_filename = re.sub(r'_flymake\.cc$', '.cc', abs_filename)
erg@google.com6317a9c2009-06-25 00:28:19 +00003053
3054 # include_state is modified during iteration, so we iterate over a copy of
3055 # the keys.
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003056 header_keys = include_state.keys()
3057 for header in header_keys:
erg@google.com6317a9c2009-06-25 00:28:19 +00003058 (same_module, common_path) = FilesBelongToSameModule(abs_filename, header)
3059 fullpath = common_path + header
3060 if same_module and UpdateIncludeState(fullpath, include_state, io):
3061 header_found = True
3062
3063 # If we can't find the header file for a .cc, assume it's because we don't
3064 # know where to look. In that case we'll give up as we're not sure they
3065 # didn't include it in the .h file.
3066 # TODO(unknown): Do a better job of finding .h files so we are confident that
3067 # not having the .h file means there isn't one.
3068 if filename.endswith('.cc') and not header_found:
3069 return
3070
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003071 # All the lines have been processed, report the errors found.
3072 for required_header_unstripped in required:
3073 template = required[required_header_unstripped][1]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003074 if required_header_unstripped.strip('<>"') not in include_state:
3075 error(filename, required[required_header_unstripped][0],
3076 'build/include_what_you_use', 4,
3077 'Add #include ' + required_header_unstripped + ' for ' + template)
3078
3079
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003080_RE_PATTERN_EXPLICIT_MAKEPAIR = re.compile(r'\bmake_pair\s*<')
3081
3082
3083def CheckMakePairUsesDeduction(filename, clean_lines, linenum, error):
3084 """Check that make_pair's template arguments are deduced.
3085
3086 G++ 4.6 in C++0x mode fails badly if make_pair's template arguments are
3087 specified explicitly, and such use isn't intended in any case.
3088
3089 Args:
3090 filename: The name of the current file.
3091 clean_lines: A CleansedLines instance containing the file.
3092 linenum: The number of the line to check.
3093 error: The function to call with any errors found.
3094 """
3095 raw = clean_lines.raw_lines
3096 line = raw[linenum]
3097 match = _RE_PATTERN_EXPLICIT_MAKEPAIR.search(line)
3098 if match:
3099 error(filename, linenum, 'build/explicit_make_pair',
3100 4, # 4 = high confidence
3101 'Omit template arguments from make_pair OR use pair directly OR'
3102 ' if appropriate, construct a pair directly')
3103
3104
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003105def ProcessLine(filename, file_extension,
3106 clean_lines, line, include_state, function_state,
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003107 class_state, error, extra_check_functions=[]):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003108 """Processes a single line in the file.
3109
3110 Args:
3111 filename: Filename of the file that is being processed.
3112 file_extension: The extension (dot not included) of the file.
3113 clean_lines: An array of strings, each representing a line of the file,
3114 with comments stripped.
3115 line: Number of line being processed.
3116 include_state: An _IncludeState instance in which the headers are inserted.
3117 function_state: A _FunctionState instance which counts function lines, etc.
3118 class_state: A _ClassState instance which maintains information about
3119 the current stack of nested class declarations being parsed.
3120 error: A callable to which errors are reported, which takes 4 arguments:
3121 filename, line number, error level, and message
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003122 extra_check_functions: An array of additional check functions that will be
3123 run on each source line. Each function takes 4
3124 arguments: filename, clean_lines, line, error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003125 """
3126 raw_lines = clean_lines.raw_lines
erg@google.com35589e62010-11-17 18:58:16 +00003127 ParseNolintSuppressions(filename, raw_lines[line], line, error)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003128 CheckForFunctionLengths(filename, clean_lines, line, function_state, error)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003129 CheckForMultilineCommentsAndStrings(filename, clean_lines, line, error)
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003130 CheckStyle(filename, clean_lines, line, file_extension, class_state, error)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003131 CheckLanguage(filename, clean_lines, line, file_extension, include_state,
3132 error)
3133 CheckForNonStandardConstructs(filename, clean_lines, line,
3134 class_state, error)
3135 CheckPosixThreading(filename, clean_lines, line, error)
erg@google.com6317a9c2009-06-25 00:28:19 +00003136 CheckInvalidIncrement(filename, clean_lines, line, error)
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003137 CheckMakePairUsesDeduction(filename, clean_lines, line, error)
3138 for check_fn in extra_check_functions:
3139 check_fn(filename, clean_lines, line, error)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003140
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003141def ProcessFileData(filename, file_extension, lines, error,
3142 extra_check_functions=[]):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003143 """Performs lint checks and reports any errors to the given error function.
3144
3145 Args:
3146 filename: Filename of the file that is being processed.
3147 file_extension: The extension (dot not included) of the file.
3148 lines: An array of strings, each representing a line of the file, with the
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003149 last element being empty if the file is terminated with a newline.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003150 error: A callable to which errors are reported, which takes 4 arguments:
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003151 filename, line number, error level, and message
3152 extra_check_functions: An array of additional check functions that will be
3153 run on each source line. Each function takes 4
3154 arguments: filename, clean_lines, line, error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003155 """
3156 lines = (['// marker so line numbers and indices both start at 1'] + lines +
3157 ['// marker so line numbers end in a known way'])
3158
3159 include_state = _IncludeState()
3160 function_state = _FunctionState()
3161 class_state = _ClassState()
3162
erg@google.com35589e62010-11-17 18:58:16 +00003163 ResetNolintSuppressions()
3164
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003165 CheckForCopyright(filename, lines, error)
3166
3167 if file_extension == 'h':
3168 CheckForHeaderGuard(filename, lines, error)
3169
3170 RemoveMultiLineComments(filename, lines, error)
3171 clean_lines = CleansedLines(lines)
3172 for line in xrange(clean_lines.NumLines()):
3173 ProcessLine(filename, file_extension, clean_lines, line,
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003174 include_state, function_state, class_state, error,
3175 extra_check_functions)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003176 class_state.CheckFinished(filename, error)
3177
3178 CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error)
3179
3180 # We check here rather than inside ProcessLine so that we see raw
3181 # lines rather than "cleaned" lines.
3182 CheckForUnicodeReplacementCharacters(filename, lines, error)
3183
3184 CheckForNewlineAtEOF(filename, lines, error)
3185
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003186def ProcessFile(filename, vlevel, extra_check_functions=[]):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003187 """Does google-lint on a single file.
3188
3189 Args:
3190 filename: The name of the file to parse.
3191
3192 vlevel: The level of errors to report. Every error of confidence
3193 >= verbose_level will be reported. 0 is a good default.
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003194
3195 extra_check_functions: An array of additional check functions that will be
3196 run on each source line. Each function takes 4
3197 arguments: filename, clean_lines, line, error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003198 """
3199
3200 _SetVerboseLevel(vlevel)
3201
3202 try:
3203 # Support the UNIX convention of using "-" for stdin. Note that
3204 # we are not opening the file with universal newline support
3205 # (which codecs doesn't support anyway), so the resulting lines do
3206 # contain trailing '\r' characters if we are reading a file that
3207 # has CRLF endings.
3208 # If after the split a trailing '\r' is present, it is removed
3209 # below. If it is not expected to be present (i.e. os.linesep !=
3210 # '\r\n' as in Windows), a warning is issued below if this file
3211 # is processed.
3212
3213 if filename == '-':
3214 lines = codecs.StreamReaderWriter(sys.stdin,
3215 codecs.getreader('utf8'),
3216 codecs.getwriter('utf8'),
3217 'replace').read().split('\n')
3218 else:
3219 lines = codecs.open(filename, 'r', 'utf8', 'replace').read().split('\n')
3220
3221 carriage_return_found = False
3222 # Remove trailing '\r'.
3223 for linenum in range(len(lines)):
3224 if lines[linenum].endswith('\r'):
3225 lines[linenum] = lines[linenum].rstrip('\r')
3226 carriage_return_found = True
3227
3228 except IOError:
3229 sys.stderr.write(
3230 "Skipping input '%s': Can't open for reading\n" % filename)
3231 return
3232
3233 # Note, if no dot is found, this will give the entire filename as the ext.
3234 file_extension = filename[filename.rfind('.') + 1:]
3235
3236 # When reading from stdin, the extension is unknown, so no cpplint tests
3237 # should rely on the extension.
3238 if (filename != '-' and file_extension != 'cc' and file_extension != 'h'
3239 and file_extension != 'cpp'):
3240 sys.stderr.write('Ignoring %s; not a .cc or .h file\n' % filename)
3241 else:
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003242 ProcessFileData(filename, file_extension, lines, Error,
3243 extra_check_functions)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003244 if carriage_return_found and os.linesep != '\r\n':
asvitkine@chromium.org8b8d8be2011-09-08 15:34:45 +00003245 # Use 0 for linenum since outputting only one error for potentially
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003246 # several lines.
3247 Error(filename, 0, 'whitespace/newline', 1,
3248 'One or more unexpected \\r (^M) found;'
3249 'better to use only a \\n')
3250
3251 sys.stderr.write('Done processing %s\n' % filename)
3252
3253
3254def PrintUsage(message):
3255 """Prints a brief usage string and exits, optionally with an error message.
3256
3257 Args:
3258 message: The optional error message.
3259 """
3260 sys.stderr.write(_USAGE)
3261 if message:
3262 sys.exit('\nFATAL ERROR: ' + message)
3263 else:
3264 sys.exit(1)
3265
3266
3267def PrintCategories():
3268 """Prints a list of all the error-categories used by error messages.
3269
3270 These are the categories used to filter messages via --filter.
3271 """
erg@google.com35589e62010-11-17 18:58:16 +00003272 sys.stderr.write(''.join(' %s\n' % cat for cat in _ERROR_CATEGORIES))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003273 sys.exit(0)
3274
3275
3276def ParseArguments(args):
3277 """Parses the command line arguments.
3278
3279 This may set the output format and verbosity level as side-effects.
3280
3281 Args:
3282 args: The command line arguments:
3283
3284 Returns:
3285 The list of filenames to lint.
3286 """
3287 try:
3288 (opts, filenames) = getopt.getopt(args, '', ['help', 'output=', 'verbose=',
erg@google.com26970fa2009-11-17 18:07:32 +00003289 'counting=',
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003290 'filter='])
3291 except getopt.GetoptError:
3292 PrintUsage('Invalid arguments.')
3293
3294 verbosity = _VerboseLevel()
3295 output_format = _OutputFormat()
3296 filters = ''
erg@google.com26970fa2009-11-17 18:07:32 +00003297 counting_style = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003298
3299 for (opt, val) in opts:
3300 if opt == '--help':
3301 PrintUsage(None)
3302 elif opt == '--output':
3303 if not val in ('emacs', 'vs7'):
3304 PrintUsage('The only allowed output formats are emacs and vs7.')
3305 output_format = val
3306 elif opt == '--verbose':
3307 verbosity = int(val)
3308 elif opt == '--filter':
3309 filters = val
erg@google.com6317a9c2009-06-25 00:28:19 +00003310 if not filters:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003311 PrintCategories()
erg@google.com26970fa2009-11-17 18:07:32 +00003312 elif opt == '--counting':
3313 if val not in ('total', 'toplevel', 'detailed'):
3314 PrintUsage('Valid counting options are total, toplevel, and detailed')
3315 counting_style = val
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003316
3317 if not filenames:
3318 PrintUsage('No files were specified.')
3319
3320 _SetOutputFormat(output_format)
3321 _SetVerboseLevel(verbosity)
3322 _SetFilters(filters)
erg@google.com26970fa2009-11-17 18:07:32 +00003323 _SetCountingStyle(counting_style)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003324
3325 return filenames
3326
3327
3328def main():
3329 filenames = ParseArguments(sys.argv[1:])
3330
3331 # Change stderr to write with replacement characters so we don't die
3332 # if we try to print something containing non-ASCII characters.
3333 sys.stderr = codecs.StreamReaderWriter(sys.stderr,
3334 codecs.getreader('utf8'),
3335 codecs.getwriter('utf8'),
3336 'replace')
3337
erg@google.com26970fa2009-11-17 18:07:32 +00003338 _cpplint_state.ResetErrorCounts()
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003339 for filename in filenames:
3340 ProcessFile(filename, _cpplint_state.verbose_level)
erg@google.com26970fa2009-11-17 18:07:32 +00003341 _cpplint_state.PrintErrorCounts()
3342
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003343 sys.exit(_cpplint_state.error_count > 0)
3344
3345
3346if __name__ == '__main__':
3347 main()