blob: 1e0deb9b26d11f698ac177fb041fa92803373f0d [file] [log] [blame]
dpranke@chromium.org2a009622011-03-01 02:43:31 +00001# Copyright (c) 2010 The Chromium Authors. All rights reserved.
2# Use of this source code is governed by a BSD-style license that can be
3# found in the LICENSE file.
4
5"""A database of OWNERS files."""
6
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +00007import re
8
9
10# If this is present by itself on a line, this means that everyone can review.
11EVERYONE = '*'
12
13
14# Recognizes 'X@Y' email addresses. Very simplistic.
15BASIC_EMAIL_REGEXP = r'^[\w\-\+\%\.]+\@[\w\-\+\%\.]+$'
dpranke@chromium.org2a009622011-03-01 02:43:31 +000016
dpranke@chromium.org2a009622011-03-01 02:43:31 +000017
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000018class SyntaxErrorInOwnersFile(Exception):
19 def __init__(self, path, line, msg):
20 super(SyntaxErrorInOwnersFile, self).__init__((path, line, msg))
21 self.path = path
22 self.line = line
23 self.msg = msg
24
25 def __str__(self):
26 if self.msg:
27 return "%s:%d syntax error: %s" % (self.path, self.line, self.msg)
28 else:
29 return "%s:%d syntax error" % (self.path, self.line)
30
31
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000032class Database(object):
33 """A database of OWNERS files for a repository.
34
35 This class allows you to find a suggested set of reviewers for a list
36 of changed files, and see if a list of changed files is covered by a
37 list of reviewers."""
38
39 def __init__(self, root, fopen, os_path):
40 """Args:
dpranke@chromium.org2a009622011-03-01 02:43:31 +000041 root: the path to the root of the Repository
dpranke@chromium.org2a009622011-03-01 02:43:31 +000042 open: function callback to open a text file for reading
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000043 os_path: module/object callback with fields for 'abspath', 'dirname',
44 'exists', and 'join'
dpranke@chromium.org2a009622011-03-01 02:43:31 +000045 """
46 self.root = root
47 self.fopen = fopen
48 self.os_path = os_path
49
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000050 # TODO: Figure out how to share the owners email addr format w/
51 # tools/commit-queue/projects.py, especially for per-repo whitelists.
52 self.email_regexp = re.compile(BASIC_EMAIL_REGEXP)
dpranke@chromium.org2a009622011-03-01 02:43:31 +000053
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000054 # Mapping of owners to the paths they own.
55 self.owned_by = {EVERYONE: set()}
56
57 # Mapping of paths to authorized owners.
dpranke@chromium.org2a009622011-03-01 02:43:31 +000058 self.owners_for = {}
59
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000060 # Set of paths that stop us from looking above them for owners.
61 # (This is implicitly true for the root directory).
62 self.stop_looking = set([''])
dpranke@chromium.org2a009622011-03-01 02:43:31 +000063
dpranke@chromium.org898a10e2011-03-04 21:54:43 +000064 def ReviewersFor(self, files):
65 """Returns a suggested set of reviewers that will cover the set of files.
dpranke@chromium.org2a009622011-03-01 02:43:31 +000066
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000067 files is a set of paths relative to (and under) self.root."""
68 self._CheckPaths(files)
dpranke@chromium.org2a009622011-03-01 02:43:31 +000069 self._LoadDataNeededFor(files)
70 return self._CoveringSetOfOwnersFor(files)
71
72 def FilesAreCoveredBy(self, files, reviewers):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000073 """Returns whether every file is owned by at least one reviewer."""
dpranke@chromium.org2a009622011-03-01 02:43:31 +000074 return not self.FilesNotCoveredBy(files, reviewers)
75
76 def FilesNotCoveredBy(self, files, reviewers):
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +000077 """Returns the set of files that are not owned by at least one reviewer."""
78 self._CheckPaths(files)
79 self._CheckReviewers(reviewers)
80 if not reviewers:
81 return files
82
83 self._LoadDataNeededFor(files)
84 files_by_dir = self._FilesByDir(files)
85 covered_dirs = self._DirsCoveredBy(reviewers)
86 uncovered_files = []
87 for d, files_in_d in files_by_dir.iteritems():
88 if not self._IsDirCoveredBy(d, covered_dirs):
89 uncovered_files.extend(files_in_d)
90 return set(uncovered_files)
91
92 def _CheckPaths(self, files):
93 def _isunder(f, pfx):
94 return self.os_path.abspath(self.os_path.join(pfx, f)).startswith(pfx)
95 assert all(_isunder(f, self.os_path.abspath(self.root)) for f in files)
96
97 def _CheckReviewers(self, reviewers):
98 """Verifies each reviewer is a valid email address."""
99 assert all(self.email_regexp.match(r) for r in reviewers)
100
101 def _FilesByDir(self, files):
102 dirs = {}
103 for f in files:
104 dirs.setdefault(self.os_path.dirname(f), []).append(f)
105 return dirs
106
107 def _DirsCoveredBy(self, reviewers):
108 dirs = self.owned_by[EVERYONE]
109 for r in reviewers:
110 dirs = dirs | self.owned_by.get(r, set())
111 return dirs
112
113 def _StopLooking(self, dirname):
114 return dirname in self.stop_looking
115
116 def _IsDirCoveredBy(self, dirname, covered_dirs):
117 while not dirname in covered_dirs and not self._StopLooking(dirname):
118 dirname = self.os_path.dirname(dirname)
119 return dirname in covered_dirs
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000120
121 def _LoadDataNeededFor(self, files):
122 for f in files:
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000123 dirpath = self.os_path.dirname(f)
124 while not dirpath in self.owners_for:
125 self._ReadOwnersInDir(dirpath)
126 if self._StopLooking(dirpath):
127 break
128 dirpath = self.os_path.dirname(dirpath)
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000129
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000130 def _ReadOwnersInDir(self, dirpath):
131 owners_path = self.os_path.join(self.root, dirpath, 'OWNERS')
132 if not self.os_path.exists(owners_path):
133 return
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000134
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000135 lineno = 0
136 for line in self.fopen(owners_path):
137 lineno += 1
138 line = line.strip()
139 if line.startswith('#'):
140 continue
141 if line == 'set noparent':
142 self.stop_looking.add(dirpath)
143 continue
144 if self.email_regexp.match(line) or line == EVERYONE:
145 self.owned_by.setdefault(line, set()).add(dirpath)
146 self.owners_for.setdefault(dirpath, set()).add(line)
147 continue
148 raise SyntaxErrorInOwnersFile(owners_path, lineno, line)
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000149
150 def _CoveringSetOfOwnersFor(self, files):
151 # TODO(dpranke): implement the greedy algorithm for covering sets, and
152 # consider returning multiple options in case there are several equally
153 # short combinations of owners.
154 every_owner = set()
155 for f in files:
dpranke@chromium.org6dada4e2011-03-08 22:32:40 +0000156 dirname = self.os_path.dirname(f)
157 while dirname in self.owners_for:
158 every_owner |= self.owners_for[dirname]
159 if self._StopLooking(dirname):
160 break
161 dirname = self.os_path.dirname(dirname)
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000162 return every_owner