dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 1 | # Copyright (c) 2010 The Chromium Authors. All rights reserved. |
| 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | """A database of OWNERS files.""" |
| 6 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 7 | import re |
| 8 | |
| 9 | |
| 10 | # If this is present by itself on a line, this means that everyone can review. |
| 11 | EVERYONE = '*' |
| 12 | |
| 13 | |
| 14 | # Recognizes 'X@Y' email addresses. Very simplistic. |
| 15 | BASIC_EMAIL_REGEXP = r'^[\w\-\+\%\.]+\@[\w\-\+\%\.]+$' |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 16 | |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 17 | |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 18 | class SyntaxErrorInOwnersFile(Exception): |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 19 | def __init__(self, path, lineno, msg): |
| 20 | super(SyntaxErrorInOwnersFile, self).__init__((path, lineno, msg)) |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 21 | self.path = path |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 22 | self.lineno = lineno |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 23 | self.msg = msg |
| 24 | |
| 25 | def __str__(self): |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 26 | return "%s:%d syntax error: %s" % (self.path, self.lineno, self.msg) |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 27 | |
| 28 | |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 29 | class Database(object): |
| 30 | """A database of OWNERS files for a repository. |
| 31 | |
| 32 | This class allows you to find a suggested set of reviewers for a list |
| 33 | of changed files, and see if a list of changed files is covered by a |
| 34 | list of reviewers.""" |
| 35 | |
| 36 | def __init__(self, root, fopen, os_path): |
| 37 | """Args: |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 38 | root: the path to the root of the Repository |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 39 | open: function callback to open a text file for reading |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 40 | os_path: module/object callback with fields for 'abspath', 'dirname', |
| 41 | 'exists', and 'join' |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 42 | """ |
| 43 | self.root = root |
| 44 | self.fopen = fopen |
| 45 | self.os_path = os_path |
| 46 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 47 | # TODO: Figure out how to share the owners email addr format w/ |
| 48 | # tools/commit-queue/projects.py, especially for per-repo whitelists. |
| 49 | self.email_regexp = re.compile(BASIC_EMAIL_REGEXP) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 50 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 51 | # Mapping of owners to the paths they own. |
| 52 | self.owned_by = {EVERYONE: set()} |
| 53 | |
| 54 | # Mapping of paths to authorized owners. |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 55 | self.owners_for = {} |
| 56 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 57 | # Set of paths that stop us from looking above them for owners. |
| 58 | # (This is implicitly true for the root directory). |
| 59 | self.stop_looking = set(['']) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 60 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 61 | def reviewers_for(self, files): |
dpranke@chromium.org | 898a10e | 2011-03-04 21:54:43 +0000 | [diff] [blame] | 62 | """Returns a suggested set of reviewers that will cover the set of files. |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 63 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 64 | files is a set of paths relative to (and under) self.root.""" |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 65 | self._check_paths(files) |
| 66 | self._load_data_needed_for(files) |
| 67 | return self._covering_set_of_owners_for(files) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 68 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 69 | def files_are_covered_by(self, files, reviewers): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 70 | """Returns whether every file is owned by at least one reviewer.""" |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 71 | return not self.files_not_covered_by(files, reviewers) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 72 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 73 | def files_not_covered_by(self, files, reviewers): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 74 | """Returns the set of files that are not owned by at least one reviewer.""" |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 75 | self._check_paths(files) |
| 76 | self._check_reviewers(reviewers) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 77 | if not reviewers: |
| 78 | return files |
| 79 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 80 | self._load_data_needed_for(files) |
| 81 | files_by_dir = self._files_by_dir(files) |
| 82 | covered_dirs = self._dirs_covered_by(reviewers) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 83 | uncovered_files = [] |
| 84 | for d, files_in_d in files_by_dir.iteritems(): |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 85 | if not self._is_dir_covered_by(d, covered_dirs): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 86 | uncovered_files.extend(files_in_d) |
| 87 | return set(uncovered_files) |
| 88 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 89 | def _check_paths(self, files): |
| 90 | def _is_under(f, pfx): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 91 | return self.os_path.abspath(self.os_path.join(pfx, f)).startswith(pfx) |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 92 | assert all(_is_under(f, self.os_path.abspath(self.root)) for f in files) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 93 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 94 | def _check_reviewers(self, reviewers): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 95 | """Verifies each reviewer is a valid email address.""" |
| 96 | assert all(self.email_regexp.match(r) for r in reviewers) |
| 97 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 98 | def _files_by_dir(self, files): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 99 | dirs = {} |
| 100 | for f in files: |
| 101 | dirs.setdefault(self.os_path.dirname(f), []).append(f) |
| 102 | return dirs |
| 103 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 104 | def _dirs_covered_by(self, reviewers): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 105 | dirs = self.owned_by[EVERYONE] |
| 106 | for r in reviewers: |
| 107 | dirs = dirs | self.owned_by.get(r, set()) |
| 108 | return dirs |
| 109 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 110 | def _stop_looking(self, dirname): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 111 | return dirname in self.stop_looking |
| 112 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 113 | def _is_dir_covered_by(self, dirname, covered_dirs): |
| 114 | while not dirname in covered_dirs and not self._stop_looking(dirname): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 115 | dirname = self.os_path.dirname(dirname) |
| 116 | return dirname in covered_dirs |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 117 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 118 | def _load_data_needed_for(self, files): |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 119 | for f in files: |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 120 | dirpath = self.os_path.dirname(f) |
| 121 | while not dirpath in self.owners_for: |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 122 | self._read_owners_in_dir(dirpath) |
| 123 | if self._stop_looking(dirpath): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 124 | break |
| 125 | dirpath = self.os_path.dirname(dirpath) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 126 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 127 | def _read_owners_in_dir(self, dirpath): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 128 | owners_path = self.os_path.join(self.root, dirpath, 'OWNERS') |
| 129 | if not self.os_path.exists(owners_path): |
| 130 | return |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 131 | |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 132 | lineno = 0 |
| 133 | for line in self.fopen(owners_path): |
| 134 | lineno += 1 |
| 135 | line = line.strip() |
| 136 | if line.startswith('#'): |
| 137 | continue |
| 138 | if line == 'set noparent': |
| 139 | self.stop_looking.add(dirpath) |
| 140 | continue |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 141 | if line.startswith('set '): |
| 142 | raise SyntaxErrorInOwnersFile(owners_path, lineno, |
| 143 | 'unknown option: "%s"' % line[4:].strip()) |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 144 | if self.email_regexp.match(line) or line == EVERYONE: |
| 145 | self.owned_by.setdefault(line, set()).add(dirpath) |
| 146 | self.owners_for.setdefault(dirpath, set()).add(line) |
| 147 | continue |
dpranke@chromium.org | 86bbf19 | 2011-03-09 21:37:06 +0000 | [diff] [blame] | 148 | raise SyntaxErrorInOwnersFile(owners_path, lineno, |
| 149 | ('line is not a comment, a "set" directive, ' |
| 150 | 'or an email address: "%s"' % line)) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 151 | |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 152 | def _covering_set_of_owners_for(self, files): |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 153 | # TODO(dpranke): implement the greedy algorithm for covering sets, and |
| 154 | # consider returning multiple options in case there are several equally |
| 155 | # short combinations of owners. |
| 156 | every_owner = set() |
| 157 | for f in files: |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 158 | dirname = self.os_path.dirname(f) |
| 159 | while dirname in self.owners_for: |
| 160 | every_owner |= self.owners_for[dirname] |
dpranke@chromium.org | 7eea259 | 2011-03-09 21:35:46 +0000 | [diff] [blame] | 161 | if self._stop_looking(dirname): |
dpranke@chromium.org | 6dada4e | 2011-03-08 22:32:40 +0000 | [diff] [blame] | 162 | break |
| 163 | dirname = self.os_path.dirname(dirname) |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 164 | return every_owner |