perkj | 9c16fe8 | 2016-07-12 15:04:07 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
kwiberg | ac9f876 | 2016-09-30 22:29:43 -0700 | [diff] [blame] | 10 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 11 | #include "rtc_base/sequenced_task_checker.h" |
Tommi | 10b40ce | 2018-02-19 13:34:00 +0100 | [diff] [blame] | 12 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 13 | #include "rtc_base/checks.h" |
| 14 | #include "rtc_base/constructormagic.h" |
| 15 | #include "rtc_base/platform_thread.h" |
| 16 | #include "rtc_base/task_queue.h" |
Tommi | 10b40ce | 2018-02-19 13:34:00 +0100 | [diff] [blame] | 17 | #include "rtc_base/thread_checker.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 18 | #include "test/gtest.h" |
perkj | 9c16fe8 | 2016-07-12 15:04:07 -0700 | [diff] [blame] | 19 | |
| 20 | namespace rtc { |
| 21 | |
| 22 | namespace { |
Tommi | 10b40ce | 2018-02-19 13:34:00 +0100 | [diff] [blame] | 23 | |
| 24 | // This class is dead code, but its purpose is to make sure that |
| 25 | // SequencedTaskChecker is compatible with the RTC_GUARDED_BY and RTC_RUN_ON |
| 26 | // attributes that are checked at compile-time. |
| 27 | class CompileTimeTestForGuardedBy { |
| 28 | public: |
| 29 | int CalledOnSequence() RTC_RUN_ON(sequence_checker_) { |
| 30 | return guarded_; |
| 31 | } |
| 32 | |
| 33 | void CallMeFromSequence() { |
| 34 | RTC_DCHECK_RUN_ON(&sequence_checker_) |
| 35 | << "Should be called on sequence"; |
| 36 | } |
| 37 | |
| 38 | private: |
| 39 | int guarded_ RTC_GUARDED_BY(sequence_checker_); |
| 40 | rtc::SequencedTaskChecker sequence_checker_; |
| 41 | }; |
| 42 | |
| 43 | |
perkj | 9c16fe8 | 2016-07-12 15:04:07 -0700 | [diff] [blame] | 44 | // Calls SequencedTaskChecker::CalledSequentially on another thread. |
| 45 | class CallCalledSequentiallyOnThread { |
| 46 | public: |
| 47 | CallCalledSequentiallyOnThread(bool expect_true, |
| 48 | SequencedTaskChecker* sequenced_task_checker) |
| 49 | : expect_true_(expect_true), |
| 50 | thread_has_run_event_(false, false), |
| 51 | thread_(&Run, this, "call_do_stuff_on_thread"), |
| 52 | sequenced_task_checker_(sequenced_task_checker) { |
| 53 | thread_.Start(); |
| 54 | } |
| 55 | ~CallCalledSequentiallyOnThread() { |
| 56 | EXPECT_TRUE(thread_has_run_event_.Wait(1000)); |
| 57 | thread_.Stop(); |
| 58 | } |
| 59 | |
| 60 | private: |
tommi | 0f8b403 | 2017-02-22 11:22:05 -0800 | [diff] [blame] | 61 | static void Run(void* obj) { |
perkj | 9c16fe8 | 2016-07-12 15:04:07 -0700 | [diff] [blame] | 62 | CallCalledSequentiallyOnThread* call_stuff_on_thread = |
| 63 | static_cast<CallCalledSequentiallyOnThread*>(obj); |
| 64 | EXPECT_EQ( |
| 65 | call_stuff_on_thread->expect_true_, |
| 66 | call_stuff_on_thread->sequenced_task_checker_->CalledSequentially()); |
| 67 | call_stuff_on_thread->thread_has_run_event_.Set(); |
perkj | 9c16fe8 | 2016-07-12 15:04:07 -0700 | [diff] [blame] | 68 | } |
| 69 | |
| 70 | const bool expect_true_; |
| 71 | Event thread_has_run_event_; |
| 72 | PlatformThread thread_; |
| 73 | SequencedTaskChecker* const sequenced_task_checker_; |
| 74 | |
| 75 | RTC_DISALLOW_COPY_AND_ASSIGN(CallCalledSequentiallyOnThread); |
| 76 | }; |
| 77 | |
| 78 | // Deletes SequencedTaskChecker on a different thread. |
| 79 | class DeleteSequencedCheckerOnThread { |
| 80 | public: |
| 81 | explicit DeleteSequencedCheckerOnThread( |
| 82 | std::unique_ptr<SequencedTaskChecker> sequenced_task_checker) |
| 83 | : thread_(&Run, this, "delete_sequenced_task_checker_on_thread"), |
| 84 | thread_has_run_event_(false, false), |
| 85 | sequenced_task_checker_(std::move(sequenced_task_checker)) { |
| 86 | thread_.Start(); |
| 87 | } |
| 88 | |
| 89 | ~DeleteSequencedCheckerOnThread() { |
| 90 | EXPECT_TRUE(thread_has_run_event_.Wait(1000)); |
| 91 | thread_.Stop(); |
| 92 | } |
| 93 | |
| 94 | private: |
| 95 | static bool Run(void* obj) { |
| 96 | DeleteSequencedCheckerOnThread* instance = |
| 97 | static_cast<DeleteSequencedCheckerOnThread*>(obj); |
| 98 | instance->sequenced_task_checker_.reset(); |
| 99 | instance->thread_has_run_event_.Set(); |
| 100 | return false; |
| 101 | } |
| 102 | |
| 103 | private: |
| 104 | PlatformThread thread_; |
| 105 | Event thread_has_run_event_; |
| 106 | std::unique_ptr<SequencedTaskChecker> sequenced_task_checker_; |
| 107 | |
| 108 | RTC_DISALLOW_COPY_AND_ASSIGN(DeleteSequencedCheckerOnThread); |
| 109 | }; |
| 110 | |
| 111 | void RunMethodOnDifferentThread(bool expect_true) { |
| 112 | std::unique_ptr<SequencedTaskChecker> sequenced_task_checker( |
| 113 | new SequencedTaskChecker()); |
| 114 | |
| 115 | CallCalledSequentiallyOnThread call_on_thread(expect_true, |
| 116 | sequenced_task_checker.get()); |
| 117 | } |
| 118 | |
| 119 | void RunMethodOnDifferentTaskQueue(bool expect_true) { |
| 120 | std::unique_ptr<SequencedTaskChecker> sequenced_task_checker( |
| 121 | new SequencedTaskChecker()); |
| 122 | |
| 123 | static const char kQueueName[] = "MethodNotAllowedOnDifferentTq"; |
| 124 | TaskQueue queue(kQueueName); |
| 125 | Event done_event(false, false); |
| 126 | queue.PostTask([&sequenced_task_checker, &done_event, expect_true] { |
| 127 | if (expect_true) |
| 128 | EXPECT_TRUE(sequenced_task_checker->CalledSequentially()); |
| 129 | else |
| 130 | EXPECT_FALSE(sequenced_task_checker->CalledSequentially()); |
| 131 | done_event.Set(); |
| 132 | }); |
| 133 | EXPECT_TRUE(done_event.Wait(1000)); |
| 134 | } |
| 135 | |
| 136 | void DetachThenCallFromDifferentTaskQueue(bool expect_true) { |
| 137 | std::unique_ptr<SequencedTaskChecker> sequenced_task_checker( |
| 138 | new SequencedTaskChecker()); |
| 139 | |
| 140 | sequenced_task_checker->Detach(); |
| 141 | |
| 142 | Event done_event(false, false); |
| 143 | TaskQueue queue1("DetachThenCallFromDifferentTaskQueueImpl1"); |
| 144 | queue1.PostTask([&sequenced_task_checker, &done_event] { |
| 145 | EXPECT_TRUE(sequenced_task_checker->CalledSequentially()); |
| 146 | done_event.Set(); |
| 147 | }); |
| 148 | EXPECT_TRUE(done_event.Wait(1000)); |
| 149 | |
| 150 | // CalledSequentially should return false in debug builds after moving to |
| 151 | // another task queue. |
| 152 | TaskQueue queue2("DetachThenCallFromDifferentTaskQueueImpl2"); |
| 153 | queue2.PostTask([&sequenced_task_checker, &done_event, expect_true] { |
| 154 | if (expect_true) |
| 155 | EXPECT_TRUE(sequenced_task_checker->CalledSequentially()); |
| 156 | else |
| 157 | EXPECT_FALSE(sequenced_task_checker->CalledSequentially()); |
| 158 | done_event.Set(); |
| 159 | }); |
| 160 | EXPECT_TRUE(done_event.Wait(1000)); |
| 161 | } |
| 162 | } // namespace |
| 163 | |
| 164 | TEST(SequencedTaskCheckerTest, CallsAllowedOnSameThread) { |
| 165 | std::unique_ptr<SequencedTaskChecker> sequenced_task_checker( |
| 166 | new SequencedTaskChecker()); |
| 167 | |
| 168 | EXPECT_TRUE(sequenced_task_checker->CalledSequentially()); |
| 169 | |
| 170 | // Verify that the destructor doesn't assert. |
| 171 | sequenced_task_checker.reset(); |
| 172 | } |
| 173 | |
| 174 | TEST(SequencedTaskCheckerTest, DestructorAllowedOnDifferentThread) { |
| 175 | std::unique_ptr<SequencedTaskChecker> sequenced_task_checker( |
| 176 | new SequencedTaskChecker()); |
| 177 | |
| 178 | // Verify that the destructor doesn't assert when called on a different |
| 179 | // thread. |
| 180 | DeleteSequencedCheckerOnThread delete_on_thread( |
| 181 | std::move(sequenced_task_checker)); |
| 182 | } |
| 183 | |
| 184 | TEST(SequencedTaskCheckerTest, DetachFromThread) { |
| 185 | std::unique_ptr<SequencedTaskChecker> sequenced_task_checker( |
| 186 | new SequencedTaskChecker()); |
| 187 | |
| 188 | sequenced_task_checker->Detach(); |
| 189 | CallCalledSequentiallyOnThread call_on_thread(true, |
| 190 | sequenced_task_checker.get()); |
| 191 | } |
| 192 | |
| 193 | TEST(SequencedTaskCheckerTest, DetachFromThreadAndUseOnTaskQueue) { |
| 194 | std::unique_ptr<SequencedTaskChecker> sequenced_task_checker( |
| 195 | new SequencedTaskChecker()); |
| 196 | |
| 197 | sequenced_task_checker->Detach(); |
| 198 | static const char kQueueName[] = "DetachFromThreadAndUseOnTaskQueue"; |
| 199 | TaskQueue queue(kQueueName); |
| 200 | Event done_event(false, false); |
| 201 | queue.PostTask([&sequenced_task_checker, &done_event] { |
| 202 | EXPECT_TRUE(sequenced_task_checker->CalledSequentially()); |
| 203 | done_event.Set(); |
| 204 | }); |
| 205 | EXPECT_TRUE(done_event.Wait(1000)); |
| 206 | } |
| 207 | |
| 208 | TEST(SequencedTaskCheckerTest, DetachFromTaskQueueAndUseOnThread) { |
| 209 | TaskQueue queue("DetachFromTaskQueueAndUseOnThread"); |
| 210 | Event done_event(false, false); |
| 211 | queue.PostTask([&done_event] { |
| 212 | std::unique_ptr<SequencedTaskChecker> sequenced_task_checker( |
| 213 | new SequencedTaskChecker()); |
| 214 | |
| 215 | sequenced_task_checker->Detach(); |
| 216 | CallCalledSequentiallyOnThread call_on_thread(true, |
| 217 | sequenced_task_checker.get()); |
| 218 | done_event.Set(); |
| 219 | }); |
| 220 | EXPECT_TRUE(done_event.Wait(1000)); |
| 221 | } |
| 222 | |
kwiberg | 5377bc7 | 2016-10-04 13:46:56 -0700 | [diff] [blame] | 223 | #if RTC_DCHECK_IS_ON |
perkj | 9c16fe8 | 2016-07-12 15:04:07 -0700 | [diff] [blame] | 224 | TEST(SequencedTaskCheckerTest, MethodNotAllowedOnDifferentThreadInDebug) { |
| 225 | RunMethodOnDifferentThread(false); |
| 226 | } |
| 227 | #else |
| 228 | TEST(SequencedTaskCheckerTest, MethodAllowedOnDifferentThreadInRelease) { |
| 229 | RunMethodOnDifferentThread(true); |
| 230 | } |
| 231 | #endif |
| 232 | |
kwiberg | 5377bc7 | 2016-10-04 13:46:56 -0700 | [diff] [blame] | 233 | #if RTC_DCHECK_IS_ON |
perkj | 9c16fe8 | 2016-07-12 15:04:07 -0700 | [diff] [blame] | 234 | TEST(SequencedTaskCheckerTest, MethodNotAllowedOnDifferentTaskQueueInDebug) { |
| 235 | RunMethodOnDifferentTaskQueue(false); |
| 236 | } |
| 237 | #else |
| 238 | TEST(SequencedTaskCheckerTest, MethodAllowedOnDifferentTaskQueueInRelease) { |
| 239 | RunMethodOnDifferentTaskQueue(true); |
| 240 | } |
| 241 | #endif |
| 242 | |
kwiberg | 5377bc7 | 2016-10-04 13:46:56 -0700 | [diff] [blame] | 243 | #if RTC_DCHECK_IS_ON |
perkj | 9c16fe8 | 2016-07-12 15:04:07 -0700 | [diff] [blame] | 244 | TEST(SequencedTaskCheckerTest, DetachFromTaskQueueInDebug) { |
| 245 | DetachThenCallFromDifferentTaskQueue(false); |
| 246 | } |
| 247 | #else |
| 248 | TEST(SequencedTaskCheckerTest, DetachFromTaskQueueInRelease) { |
| 249 | DetachThenCallFromDifferentTaskQueue(true); |
| 250 | } |
| 251 | #endif |
| 252 | |
| 253 | class TestAnnotations { |
| 254 | public: |
| 255 | TestAnnotations() : test_var_(false) {} |
| 256 | |
| 257 | void ModifyTestVar() { |
| 258 | RTC_DCHECK_CALLED_SEQUENTIALLY(&checker_); |
| 259 | test_var_ = true; |
| 260 | } |
| 261 | |
| 262 | private: |
danilchap | 3c6abd2 | 2017-09-06 05:46:29 -0700 | [diff] [blame] | 263 | bool test_var_ RTC_GUARDED_BY(&checker_); |
perkj | 9c16fe8 | 2016-07-12 15:04:07 -0700 | [diff] [blame] | 264 | SequencedTaskChecker checker_; |
| 265 | }; |
| 266 | |
| 267 | TEST(SequencedTaskCheckerTest, TestAnnotations) { |
| 268 | TestAnnotations annotations; |
| 269 | annotations.ModifyTestVar(); |
| 270 | } |
| 271 | |
| 272 | #if GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) |
| 273 | |
| 274 | void TestAnnotationsOnWrongQueue() { |
| 275 | TestAnnotations annotations; |
| 276 | static const char kQueueName[] = "TestAnnotationsOnWrongQueueDebug"; |
| 277 | TaskQueue queue(kQueueName); |
| 278 | Event done_event(false, false); |
| 279 | queue.PostTask([&annotations, &done_event] { |
| 280 | annotations.ModifyTestVar(); |
| 281 | done_event.Set(); |
| 282 | }); |
| 283 | EXPECT_TRUE(done_event.Wait(1000)); |
| 284 | } |
| 285 | |
| 286 | #if RTC_DCHECK_IS_ON |
| 287 | TEST(SequencedTaskCheckerTest, TestAnnotationsOnWrongQueueDebug) { |
| 288 | ASSERT_DEATH({ TestAnnotationsOnWrongQueue(); }, ""); |
| 289 | } |
| 290 | #else |
| 291 | TEST(SequencedTaskCheckerTest, TestAnnotationsOnWrongQueueRelease) { |
| 292 | TestAnnotationsOnWrongQueue(); |
| 293 | } |
| 294 | #endif |
| 295 | #endif // GTEST_HAS_DEATH_TEST |
| 296 | } // namespace rtc |