blob: 715546b2ea3d51dee066592c697efa944e0e1350 [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Yves Gerey3e707812018-11-28 16:47:49 +010011#include <stdint.h>
Jonas Olssona4d87372019-07-05 19:08:33 +020012
Henrik Boström933d8b02017-10-10 10:05:16 -070013#include <memory>
Yves Gerey3e707812018-11-28 16:47:49 +010014#include <string>
15#include <utility>
Henrik Boström933d8b02017-10-10 10:05:16 -070016#include <vector>
17
Yves Gerey3e707812018-11-28 16:47:49 +010018#include "absl/types/optional.h"
19#include "api/audio/audio_mixer.h"
20#include "api/audio_codecs/audio_decoder_factory.h"
21#include "api/audio_codecs/audio_encoder_factory.h"
Karl Wiberg1b0eae32017-10-17 14:48:54 +020022#include "api/audio_codecs/builtin_audio_decoder_factory.h"
23#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Mirko Bonadei2ff3f492018-11-22 09:00:13 +010024#include "api/create_peerconnection_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070025#include "api/jsep.h"
Steve Anton10542f22019-01-11 09:11:00 -080026#include "api/media_stream_interface.h"
27#include "api/media_types.h"
28#include "api/peer_connection_interface.h"
29#include "api/rtc_error.h"
30#include "api/rtp_parameters.h"
31#include "api/rtp_receiver_interface.h"
32#include "api/rtp_sender_interface.h"
33#include "api/rtp_transceiver_interface.h"
Mirko Bonadeid9708072019-01-25 20:26:48 +010034#include "api/scoped_refptr.h"
Steve Anton10542f22019-01-11 09:11:00 -080035#include "api/set_remote_description_observer_interface.h"
36#include "api/uma_metrics.h"
Anders Carlsson67537952018-05-03 11:28:29 +020037#include "api/video_codecs/builtin_video_decoder_factory.h"
38#include "api/video_codecs/builtin_video_encoder_factory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010039#include "api/video_codecs/video_decoder_factory.h"
40#include "api/video_codecs/video_encoder_factory.h"
Steve Anton10542f22019-01-11 09:11:00 -080041#include "media/base/stream_params.h"
Yves Gerey3e707812018-11-28 16:47:49 +010042#include "modules/audio_device/include/audio_device.h"
43#include "modules/audio_processing/include/audio_processing.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "p2p/base/port_allocator.h"
45#include "pc/media_session.h"
46#include "pc/peer_connection_wrapper.h"
47#include "pc/sdp_utils.h"
48#include "pc/session_description.h"
49#include "pc/test/fake_audio_capture_module.h"
50#include "pc/test/mock_peer_connection_observers.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070051#include "rtc_base/checks.h"
52#include "rtc_base/gunit.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "rtc_base/ref_counted_object.h"
54#include "rtc_base/rtc_certificate_generator.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070055#include "rtc_base/thread.h"
Mirko Bonadei17f48782018-09-28 08:51:10 +020056#include "system_wrappers/include/metrics.h"
Steve Anton9158ef62017-11-27 13:01:52 -080057#include "test/gmock.h"
Yves Gerey3e707812018-11-28 16:47:49 +010058#include "test/gtest.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070059
60// This file contains tests for RTP Media API-related behavior of
Artem Titovcfea2182021-08-10 01:22:31 +020061// `webrtc::PeerConnection`, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
Henrik Boström933d8b02017-10-10 10:05:16 -070062
Steve Anton9158ef62017-11-27 13:01:52 -080063namespace webrtc {
64
65using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
66using ::testing::ElementsAre;
Steve Antonc1e6e862019-03-04 14:43:44 -080067using ::testing::Pair;
Steve Anton9158ef62017-11-27 13:01:52 -080068using ::testing::UnorderedElementsAre;
Steve Anton3172c032018-05-03 15:30:18 -070069using ::testing::Values;
Henrik Boström933d8b02017-10-10 10:05:16 -070070
Henrik Boström31638672017-11-23 17:48:32 +010071const uint32_t kDefaultTimeout = 10000u;
72
73template <typename MethodFunctor>
74class OnSuccessObserver : public rtc::RefCountedObject<
75 webrtc::SetRemoteDescriptionObserverInterface> {
76 public:
77 explicit OnSuccessObserver(MethodFunctor on_success)
78 : on_success_(std::move(on_success)) {}
79
80 // webrtc::SetRemoteDescriptionObserverInterface implementation.
81 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
82 RTC_CHECK(error.ok());
83 on_success_();
84 }
85
86 private:
87 MethodFunctor on_success_;
88};
89
Mirko Bonadei6a489f22019-04-09 15:11:12 +020090class PeerConnectionRtpBaseTest : public ::testing::Test {
Henrik Boström933d8b02017-10-10 10:05:16 -070091 public:
Steve Anton3172c032018-05-03 15:30:18 -070092 explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics)
93 : sdp_semantics_(sdp_semantics),
94 pc_factory_(
Steve Anton9158ef62017-11-27 13:01:52 -080095 CreatePeerConnectionFactory(rtc::Thread::Current(),
96 rtc::Thread::Current(),
97 rtc::Thread::Current(),
98 FakeAudioCaptureModule::Create(),
99 CreateBuiltinAudioEncoderFactory(),
100 CreateBuiltinAudioDecoderFactory(),
Anders Carlsson67537952018-05-03 11:28:29 +0200101 CreateBuiltinVideoEncoderFactory(),
102 CreateBuiltinVideoDecoderFactory(),
103 nullptr /* audio_mixer */,
Qingsi Wang7fc821d2018-07-12 12:54:53 -0700104 nullptr /* audio_processing */)) {
105 webrtc::metrics::Reset();
106 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700107
Steve Anton9158ef62017-11-27 13:01:52 -0800108 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
109 return CreatePeerConnection(RTCConfiguration());
110 }
111
Steve Antone831b8c2018-02-01 12:22:16 -0800112 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
113 RTCConfiguration config;
114 config.sdp_semantics = SdpSemantics::kPlanB;
Steve Anton3172c032018-05-03 15:30:18 -0700115 return CreatePeerConnectionInternal(config);
Steve Antone831b8c2018-02-01 12:22:16 -0800116 }
117
Steve Anton9158ef62017-11-27 13:01:52 -0800118 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
119 RTCConfiguration config;
120 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
Steve Anton3172c032018-05-03 15:30:18 -0700121 return CreatePeerConnectionInternal(config);
Steve Anton9158ef62017-11-27 13:01:52 -0800122 }
123
124 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
125 const RTCConfiguration& config) {
Steve Anton3172c032018-05-03 15:30:18 -0700126 RTCConfiguration modified_config = config;
127 modified_config.sdp_semantics = sdp_semantics_;
128 return CreatePeerConnectionInternal(modified_config);
129 }
130
131 protected:
132 const SdpSemantics sdp_semantics_;
133 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
134
135 private:
136 // Private so that tests don't accidentally bypass the SdpSemantics
137 // adjustment.
138 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal(
139 const RTCConfiguration& config) {
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200140 auto observer = std::make_unique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -0700141 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
142 observer.get());
Yves Gerey4e933292018-10-31 15:36:05 +0100143 EXPECT_TRUE(pc.get());
144 observer->SetPeerConnectionInterface(pc.get());
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200145 return std::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
146 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -0700147 }
Steve Anton3172c032018-05-03 15:30:18 -0700148};
Henrik Boström933d8b02017-10-10 10:05:16 -0700149
Steve Anton3172c032018-05-03 15:30:18 -0700150class PeerConnectionRtpTest
151 : public PeerConnectionRtpBaseTest,
152 public ::testing::WithParamInterface<SdpSemantics> {
Henrik Boström933d8b02017-10-10 10:05:16 -0700153 protected:
Steve Anton3172c032018-05-03 15:30:18 -0700154 PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {}
155};
156
157class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest {
158 protected:
159 PeerConnectionRtpTestPlanB()
160 : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {}
161};
162
163class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest {
164 protected:
165 PeerConnectionRtpTestUnifiedPlan()
166 : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {}
Harald Alvestrand09bd9ba2020-10-09 08:13:30 +0000167
168 // Helper to emulate an SFU that rejects an offered media section
169 // in answer.
170 bool ExchangeOfferAnswerWhereRemoteStopsTransceiver(
171 PeerConnectionWrapper* caller,
172 PeerConnectionWrapper* callee,
173 size_t mid_to_stop) {
174 auto offer = caller->CreateOffer();
175 caller->SetLocalDescription(CloneSessionDescription(offer.get()));
176 callee->SetRemoteDescription(std::move(offer));
177 EXPECT_LT(mid_to_stop, callee->pc()->GetTransceivers().size());
178 // Must use StopInternal in order to do instant reject.
179 callee->pc()->GetTransceivers()[mid_to_stop]->StopInternal();
180 auto answer = callee->CreateAnswer();
181 EXPECT_TRUE(answer);
182 bool set_local_answer =
183 callee->SetLocalDescription(CloneSessionDescription(answer.get()));
184 EXPECT_TRUE(set_local_answer);
185 bool set_remote_answer = caller->SetRemoteDescription(std::move(answer));
186 EXPECT_TRUE(set_remote_answer);
187 return set_remote_answer;
188 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700189};
190
Artem Titovcfea2182021-08-10 01:22:31 +0200191// These tests cover `webrtc::PeerConnectionObserver` callbacks firing upon
Henrik Boström31638672017-11-23 17:48:32 +0100192// setting the remote description.
Henrik Boström31638672017-11-23 17:48:32 +0100193
Steve Anton3172c032018-05-03 15:30:18 -0700194TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700195 auto caller = CreatePeerConnection();
196 auto callee = CreatePeerConnection();
197
Steve Anton3172c032018-05-03 15:30:18 -0700198 ASSERT_TRUE(caller->AddAudioTrack("audio_track"));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700199 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700200
Henrik Boström31638672017-11-23 17:48:32 +0100201 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700202 const auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100203 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Steve Anton3172c032018-05-03 15:30:18 -0700204
205 if (sdp_semantics_ == SdpSemantics::kPlanB) {
206 // Since we are not supporting the no stream case with Plan B, there should
207 // be a generated stream, even though we didn't set one with AddTrack.
208 ASSERT_EQ(1u, add_track_event.streams.size());
209 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
210 } else {
211 EXPECT_EQ(0u, add_track_event.streams.size());
212 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700213}
214
Steve Anton3172c032018-05-03 15:30:18 -0700215TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700216 auto caller = CreatePeerConnection();
217 auto callee = CreatePeerConnection();
218
Steve Anton3172c032018-05-03 15:30:18 -0700219 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700220 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700221
Henrik Boström31638672017-11-23 17:48:32 +0100222 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100223 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100224 ASSERT_EQ(add_track_event.streams.size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700225 EXPECT_EQ("audio_stream", add_track_event.streams[0]->id());
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100226 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
227 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700228}
229
Steve Anton3172c032018-05-03 15:30:18 -0700230TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700231 auto caller = CreatePeerConnection();
232 auto callee = CreatePeerConnection();
233
Steve Anton3172c032018-05-03 15:30:18 -0700234 auto sender = caller->AddAudioTrack("audio_track", {});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700235 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100236 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700237 ASSERT_TRUE(
238 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
239
Henrik Boström933d8b02017-10-10 10:05:16 -0700240 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700241 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700242
Henrik Boström31638672017-11-23 17:48:32 +0100243 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700244 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
245 callee->observer()->remove_track_events_);
246}
247
Steve Anton3172c032018-05-03 15:30:18 -0700248TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700249 auto caller = CreatePeerConnection();
250 auto callee = CreatePeerConnection();
251
Steve Anton3172c032018-05-03 15:30:18 -0700252 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700253 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100254 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700255 ASSERT_TRUE(
256 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
257
Henrik Boström933d8b02017-10-10 10:05:16 -0700258 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700259 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700260
Henrik Boström31638672017-11-23 17:48:32 +0100261 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700262 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
263 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700264 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700265}
266
Steve Anton3172c032018-05-03 15:30:18 -0700267TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700268 auto caller = CreatePeerConnection();
269 auto callee = CreatePeerConnection();
270
Seth Hampson845e8782018-03-02 11:34:10 -0800271 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700272 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
273 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700274 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100275 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Steve Anton3172c032018-05-03 15:30:18 -0700276 ASSERT_TRUE(
277 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700278
279 // Remove "audio_track1".
280 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700281 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100282 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700283 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800284 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700285 callee->observer()->add_track_events_[0].receiver},
286 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700287 ASSERT_EQ(1u, callee->observer()->remote_streams()->count());
288 ASSERT_TRUE(
289 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700290
291 // Remove "audio_track2".
292 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700293 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100294 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700295 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
296 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700297 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700298}
299
Seth Hampson5b4f0752018-04-02 16:31:36 -0700300// Tests the edge case that if a stream ID changes for a given track that both
301// OnRemoveTrack and OnAddTrack is fired.
Steve Anton3172c032018-05-03 15:30:18 -0700302TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700303 RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) {
304 auto caller = CreatePeerConnection();
305 auto callee = CreatePeerConnection();
306
307 const char kStreamId1[] = "stream1";
308 const char kStreamId2[] = "stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700309 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700310 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700311 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
312
313 // Change the stream ID of the sender in the session description.
314 auto offer = caller->CreateOfferAndSetAsLocal();
Steve Anton3172c032018-05-03 15:30:18 -0700315 auto* audio_desc =
316 cricket::GetFirstAudioContentDescription(offer->description());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700317 ASSERT_EQ(audio_desc->mutable_streams().size(), 1u);
318 audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2});
Steve Anton3172c032018-05-03 15:30:18 -0700319 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700320
321 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
322 EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(),
323 kStreamId2);
324 ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u);
325 EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(),
326 kStreamId1);
327}
328
Steve Anton8b815cd2018-02-16 16:14:42 -0800329// Tests that setting a remote description with sending transceivers will fire
330// the OnTrack callback for each transceiver and setting a remote description
Seth Hampson5b4f0752018-04-02 16:31:36 -0700331// with receive only transceivers will not call OnTrack. One transceiver is
332// created without any stream_ids, while the other is created with multiple
333// stream_ids.
Steve Anton3172c032018-05-03 15:30:18 -0700334TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) {
Seth Hampson5b4f0752018-04-02 16:31:36 -0700335 const std::string kStreamId1 = "video_stream1";
336 const std::string kStreamId2 = "video_stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700337 auto caller = CreatePeerConnection();
338 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800339
340 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Seth Hampson5b4f0752018-04-02 16:31:36 -0700341 RtpTransceiverInit video_transceiver_init;
342 video_transceiver_init.stream_ids = {kStreamId1, kStreamId2};
343 auto video_transceiver =
344 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init);
Steve Anton8b815cd2018-02-16 16:14:42 -0800345
346 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
347
348 ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size());
349 ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size());
350 EXPECT_EQ(audio_transceiver->mid(),
351 callee->pc()->GetTransceivers()[0]->mid());
352 EXPECT_EQ(video_transceiver->mid(),
353 callee->pc()->GetTransceivers()[1]->mid());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700354 std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams =
355 callee->pc()->GetTransceivers()[0]->receiver()->streams();
356 std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams =
357 callee->pc()->GetTransceivers()[1]->receiver()->streams();
358 ASSERT_EQ(0u, audio_streams.size());
359 ASSERT_EQ(2u, video_streams.size());
360 EXPECT_EQ(kStreamId1, video_streams[0]->id());
361 EXPECT_EQ(kStreamId2, video_streams[1]->id());
Steve Anton8b815cd2018-02-16 16:14:42 -0800362}
363
364// Test that doing additional offer/answer exchanges with no changes to tracks
365// will cause no additional OnTrack calls after the tracks have been negotiated.
Steve Anton3172c032018-05-03 15:30:18 -0700366TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) {
367 auto caller = CreatePeerConnection();
368 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800369
370 caller->AddAudioTrack("audio");
371 callee->AddAudioTrack("audio");
372
373 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
374 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
375 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
376
377 // If caller reoffers with no changes expect no additional OnTrack calls.
378 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
379 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
380 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
381
382 // Also if callee reoffers with no changes expect no additional OnTrack calls.
383 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
384 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
385 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
386}
387
388// Test that OnTrack is called when the transceiver direction changes to send
389// the track.
Steve Anton3172c032018-05-03 15:30:18 -0700390TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) {
391 auto caller = CreatePeerConnection();
392 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800393
394 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Harald Alvestrand6060df52020-08-11 09:54:02 +0200395 EXPECT_TRUE(
396 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive)
397 .ok());
Steve Anton8b815cd2018-02-16 16:14:42 -0800398 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
399 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
400 EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size());
401
Harald Alvestrand6060df52020-08-11 09:54:02 +0200402 EXPECT_TRUE(
403 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendOnly)
404 .ok());
Steve Anton8b815cd2018-02-16 16:14:42 -0800405 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
406 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
407 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
408
409 // If the direction changes but it is still receiving on the remote side, then
410 // OnTrack should not be fired again.
Harald Alvestrand6060df52020-08-11 09:54:02 +0200411 EXPECT_TRUE(
412 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendRecv)
413 .ok());
Steve Anton8b815cd2018-02-16 16:14:42 -0800414 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
415 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
416 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
417}
418
419// Test that OnTrack is called twice when a sendrecv call is started, the callee
420// changes the direction to inactive, then changes it back to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -0700421TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) {
422 auto caller = CreatePeerConnection();
423 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800424
425 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
426
427 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
428 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
429 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
430
431 // Put the call on hold by no longer receiving the track.
Harald Alvestrand6060df52020-08-11 09:54:02 +0200432 EXPECT_TRUE(callee->pc()
433 ->GetTransceivers()[0]
434 ->SetDirectionWithError(RtpTransceiverDirection::kInactive)
435 .ok());
Steve Anton8b815cd2018-02-16 16:14:42 -0800436
437 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
438 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
439 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
440
441 // Resume the call by changing the direction to recvonly. This should call
442 // OnTrack again on the callee side.
Harald Alvestrand6060df52020-08-11 09:54:02 +0200443 EXPECT_TRUE(callee->pc()
444 ->GetTransceivers()[0]
445 ->SetDirectionWithError(RtpTransceiverDirection::kRecvOnly)
446 .ok());
Steve Anton8b815cd2018-02-16 16:14:42 -0800447
448 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
449 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
450 EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size());
451}
452
Steve Anton3172c032018-05-03 15:30:18 -0700453// Test that setting a remote offer twice with no answer in the middle results
Steve Anton0f5400a2018-07-17 14:25:36 -0700454// in OnAddTrack being fired only once.
Steve Anton3172c032018-05-03 15:30:18 -0700455TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700456 ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) {
Henrik Boström31638672017-11-23 17:48:32 +0100457 auto caller = CreatePeerConnection();
458 auto callee = CreatePeerConnection();
459
Steve Anton3172c032018-05-03 15:30:18 -0700460 caller->AddAudioTrack("audio_track", {});
461
Amit Hilbuchae3df542019-01-07 12:13:08 -0800462 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700463 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
464
Amit Hilbuchae3df542019-01-07 12:13:08 -0800465 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton0f5400a2018-07-17 14:25:36 -0700466 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700467}
468
469// Test that setting a remote offer twice with no answer in the middle and the
470// track being removed between the two offers results in OnAddTrack being called
Steve Anton0f5400a2018-07-17 14:25:36 -0700471// once the first time and OnRemoveTrack being called once the second time.
Steve Anton3172c032018-05-03 15:30:18 -0700472TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700473 ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) {
Steve Anton3172c032018-05-03 15:30:18 -0700474 auto caller = CreatePeerConnection();
475 auto callee = CreatePeerConnection();
476
477 auto sender = caller->AddAudioTrack("audio_track", {});
478
Amit Hilbuchae3df542019-01-07 12:13:08 -0800479 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700480 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700481 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700482
483 caller->pc()->RemoveTrack(sender);
484
Amit Hilbuchae3df542019-01-07 12:13:08 -0800485 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700486 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700487 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
488}
489
490// Test that changing the direction from receiving to not receiving between
491// setting the remote offer and creating / setting the local answer results in
492// a remove track event when SetLocalDescription is called.
493TEST_F(PeerConnectionRtpTestUnifiedPlan,
494 ChangeDirectionInAnswerResultsInRemoveTrackEvent) {
495 auto caller = CreatePeerConnection();
496 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
497 auto callee = CreatePeerConnection();
498 callee->AddAudioTrack("audio_track", {});
499
500 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
501 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700502 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700503
504 auto callee_transceiver = callee->pc()->GetTransceivers()[0];
Harald Alvestrand6060df52020-08-11 09:54:02 +0200505 EXPECT_TRUE(callee_transceiver
506 ->SetDirectionWithError(RtpTransceiverDirection::kSendOnly)
507 .ok());
Steve Anton0f5400a2018-07-17 14:25:36 -0700508
509 ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer()));
510 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
511 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700512}
513
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100514TEST_F(PeerConnectionRtpTestUnifiedPlan, ChangeMsidWhileReceiving) {
515 auto caller = CreatePeerConnection();
516 caller->AddAudioTrack("audio_track", {"stream1"});
517 auto callee = CreatePeerConnection();
Amit Hilbuchae3df542019-01-07 12:13:08 -0800518 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100519
520 ASSERT_EQ(1u, callee->observer()->on_track_transceivers_.size());
521 auto transceiver = callee->observer()->on_track_transceivers_[0];
522 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
523 EXPECT_EQ("stream1", transceiver->receiver()->streams()[0]->id());
524
Amit Hilbuchae3df542019-01-07 12:13:08 -0800525 ASSERT_TRUE(callee->CreateAnswerAndSetAsLocal());
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100526
527 // Change the stream ID in the offer.
Guido Urdaneta1ff16c82019-05-20 19:31:53 +0200528 caller->pc()->GetSenders()[0]->SetStreams({"stream2"});
529 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100530 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
531 EXPECT_EQ("stream2", transceiver->receiver()->streams()[0]->id());
532}
533
Steve Anton3172c032018-05-03 15:30:18 -0700534// These tests examine the state of the peer connection as a result of
535// performing SetRemoteDescription().
536
537TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) {
538 auto caller = CreatePeerConnection();
539 auto callee = CreatePeerConnection();
540
541 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700542 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100543
544 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
545 auto receiver_added = callee->pc()->GetReceivers()[0];
546 EXPECT_EQ("audio_track", receiver_added->track()->id());
Steve Anton3172c032018-05-03 15:30:18 -0700547
548 if (sdp_semantics_ == SdpSemantics::kPlanB) {
549 // Since we are not supporting the no stream case with Plan B, there should
550 // be a generated stream, even though we didn't set one with AddTrack.
551 ASSERT_EQ(1u, receiver_added->streams().size());
552 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
553 } else {
554 EXPECT_EQ(0u, receiver_added->streams().size());
555 }
Henrik Boström31638672017-11-23 17:48:32 +0100556}
557
Steve Anton3172c032018-05-03 15:30:18 -0700558TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100559 auto caller = CreatePeerConnection();
560 auto callee = CreatePeerConnection();
561
Steve Anton3172c032018-05-03 15:30:18 -0700562 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700563 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100564
565 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
566 auto receiver_added = callee->pc()->GetReceivers()[0];
567 EXPECT_EQ("audio_track", receiver_added->track()->id());
568 EXPECT_EQ(receiver_added->streams().size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700569 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id());
Henrik Boström31638672017-11-23 17:48:32 +0100570 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
571}
572
Steve Anton3172c032018-05-03 15:30:18 -0700573TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100574 auto caller = CreatePeerConnection();
575 auto callee = CreatePeerConnection();
576
Steve Anton3172c032018-05-03 15:30:18 -0700577 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100578 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700579 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
580
Henrik Boström31638672017-11-23 17:48:32 +0100581 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
582 auto receiver = callee->pc()->GetReceivers()[0];
583 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700584 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100585
Steve Anton3172c032018-05-03 15:30:18 -0700586 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
587 // With Unified Plan the receiver stays but the transceiver transitions to
588 // inactive.
589 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
590 EXPECT_EQ(RtpTransceiverDirection::kInactive,
591 callee->pc()->GetTransceivers()[0]->current_direction());
592 } else {
593 // With Plan B the receiver is removed.
594 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
595 }
Henrik Boström31638672017-11-23 17:48:32 +0100596}
597
Steve Anton3172c032018-05-03 15:30:18 -0700598TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100599 auto caller = CreatePeerConnection();
600 auto callee = CreatePeerConnection();
601
Steve Anton3172c032018-05-03 15:30:18 -0700602 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100603 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700604 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100605 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
606 auto receiver = callee->pc()->GetReceivers()[0];
607 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700608 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100609
Steve Anton3172c032018-05-03 15:30:18 -0700610 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
611 // With Unified Plan the receiver stays but the transceiver transitions to
612 // inactive.
613 EXPECT_EQ(1u, callee->pc()->GetReceivers().size());
614 EXPECT_EQ(RtpTransceiverDirection::kInactive,
615 callee->pc()->GetTransceivers()[0]->current_direction());
616 } else {
617 // With Plan B the receiver is removed.
618 EXPECT_EQ(0u, callee->pc()->GetReceivers().size());
619 }
Henrik Boström31638672017-11-23 17:48:32 +0100620}
621
Steve Anton3172c032018-05-03 15:30:18 -0700622TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100623 auto caller = CreatePeerConnection();
624 auto callee = CreatePeerConnection();
625
Seth Hampson845e8782018-03-02 11:34:10 -0800626 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700627 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
628 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
629 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
630 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
Henrik Boström31638672017-11-23 17:48:32 +0100631
632 // Remove "audio_track1".
633 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Steve Anton3172c032018-05-03 15:30:18 -0700634 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
635
636 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
637 // With Unified Plan the receiver stays but the transceiver transitions to
638 // inactive.
639 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
640 auto transceiver = callee->pc()->GetTransceivers()[0];
641 EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id());
642 EXPECT_EQ(RtpTransceiverDirection::kInactive,
643 transceiver->current_direction());
644 } else {
645 // With Plan B the receiver is removed.
646 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
647 EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id());
648 }
Henrik Boström31638672017-11-23 17:48:32 +0100649
650 // Remove "audio_track2".
651 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Steve Anton3172c032018-05-03 15:30:18 -0700652 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
653
654 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
655 // With Unified Plan the receiver stays but the transceiver transitions to
656 // inactive.
657 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
658 auto transceiver = callee->pc()->GetTransceivers()[1];
659 EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id());
660 EXPECT_EQ(RtpTransceiverDirection::kInactive,
661 transceiver->current_direction());
662 } else {
663 // With Plan B the receiver is removed.
664 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
665 }
Henrik Boström31638672017-11-23 17:48:32 +0100666}
667
Florent Castelliabe301f2018-06-12 18:33:49 +0200668TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) {
669 auto caller = CreatePeerConnection();
670 auto callee = CreatePeerConnection();
671 auto sender = caller->AddAudioTrack("audio_track");
672 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
673
674 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
675 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
676
677 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
678 auto receiver = callee->pc()->GetReceivers()[0];
679 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
680}
681
682TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) {
683 auto caller = CreatePeerConnection();
684 auto callee = CreatePeerConnection();
685 auto sender = caller->AddVideoTrack("video_track");
686 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
687
688 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
689 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
690
691 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
692 auto receiver = callee->pc()->GetReceivers()[0];
693 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
694}
695
Henrik Boström31638672017-11-23 17:48:32 +0100696// Invokes SetRemoteDescription() twice in a row without synchronizing the two
697// calls and examine the state of the peer connection inside the callbacks to
698// ensure that the second call does not occur prematurely, contaminating the
699// state of the peer connection of the first callback.
Steve Anton3172c032018-05-03 15:30:18 -0700700TEST_F(PeerConnectionRtpTestPlanB,
Henrik Boström31638672017-11-23 17:48:32 +0100701 StatesCorrelateWithSetRemoteDescriptionCall) {
702 auto caller = CreatePeerConnection();
703 auto callee = CreatePeerConnection();
704
Henrik Boström31638672017-11-23 17:48:32 +0100705 // Create SDP for adding a track and for removing it. This will be used in the
706 // first and second SetRemoteDescription() calls.
Steve Anton3172c032018-05-03 15:30:18 -0700707 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100708 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
709 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
710 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
711
712 // In the first SetRemoteDescription() callback, check that we have a
713 // receiver for the track.
714 auto pc = callee->pc();
715 bool srd1_callback_called = false;
716 auto srd1_callback = [&srd1_callback_called, &pc]() {
717 EXPECT_EQ(pc->GetReceivers().size(), 1u);
718 srd1_callback_called = true;
719 };
720
721 // In the second SetRemoteDescription() callback, check that the receiver has
722 // been removed.
723 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
724 // Instead, the transceiver owning the receiver will become inactive.
725 // https://crbug.com/webrtc/7600
726 bool srd2_callback_called = false;
727 auto srd2_callback = [&srd2_callback_called, &pc]() {
728 EXPECT_TRUE(pc->GetReceivers().empty());
729 srd2_callback_called = true;
730 };
731
732 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
733 // calls. The callbacks verify that the two calls are synchronized, as in, the
734 // effects of the second SetRemoteDescription() call must not have happened by
735 // the time the first callback is invoked. If it has then the receiver that is
736 // added as a result of the first SetRemoteDescription() call will already
737 // have been removed as a result of the second SetRemoteDescription() call
738 // when the first callback is invoked.
739 callee->pc()->SetRemoteDescription(
740 std::move(srd1_sdp),
741 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
742 callee->pc()->SetRemoteDescription(
743 std::move(srd2_sdp),
744 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
745 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
746 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
747}
748
Seth Hampson5897a6e2018-04-03 11:16:33 -0700749// Tests that a remote track is created with the signaled MSIDs when they are
750// communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc
751// lines).
Steve Anton3172c032018-05-03 15:30:18 -0700752TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) {
753 auto caller = CreatePeerConnection();
754 auto callee = CreatePeerConnection();
Seth Hampson5897a6e2018-04-03 11:16:33 -0700755 const char kStreamId1[] = "stream1";
756 const char kStreamId2[] = "stream2";
757 caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
758 {kStreamId1, kStreamId2});
759
760 auto offer = caller->CreateOfferAndSetAsLocal();
761 // Munge the offer to take out everything but the stream_ids.
762 auto contents = offer->description()->contents();
763 ASSERT_TRUE(!contents.empty());
764 ASSERT_TRUE(!contents[0].media_description()->streams().empty());
765 std::vector<std::string> stream_ids =
766 contents[0].media_description()->streams()[0].stream_ids();
767 contents[0].media_description()->mutable_streams().clear();
768 cricket::StreamParams new_stream;
769 new_stream.set_stream_ids(stream_ids);
770 contents[0].media_description()->AddStream(new_stream);
771
772 // Set the remote description and verify that the streams were added to the
773 // receiver correctly.
774 ASSERT_TRUE(
775 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
776 auto receivers = callee->pc()->GetReceivers();
777 ASSERT_EQ(receivers.size(), 1u);
778 ASSERT_EQ(receivers[0]->streams().size(), 2u);
779 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1);
780 EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2);
781}
Henrik Boströmc335b0e2021-04-08 07:25:38 +0200782TEST_F(PeerConnectionRtpTestUnifiedPlan, TracksDoNotEndWhenSsrcChanges) {
783 constexpr uint32_t kFirstMungedSsrc = 1337u;
784
785 auto caller = CreatePeerConnection();
786 auto callee = CreatePeerConnection();
787
788 // Caller offers to receive audio and video.
789 RtpTransceiverInit init;
790 init.direction = RtpTransceiverDirection::kRecvOnly;
791 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
792 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
793
794 // Callee wants to send audio and video tracks.
795 callee->AddTrack(callee->CreateAudioTrack("audio_track"), {});
796 callee->AddTrack(callee->CreateVideoTrack("video_track"), {});
797
798 // Do inittial offer/answer exchange.
799 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
800 ASSERT_TRUE(
801 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
802 ASSERT_EQ(caller->observer()->add_track_events_.size(), 2u);
803 ASSERT_EQ(caller->pc()->GetReceivers().size(), 2u);
804
805 // Do a follow-up offer/answer exchange where the SSRCs are modified.
806 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
807 auto answer = callee->CreateAnswer();
808 auto& contents = answer->description()->contents();
809 ASSERT_TRUE(!contents.empty());
810 for (size_t i = 0; i < contents.size(); ++i) {
811 auto& mutable_streams = contents[i].media_description()->mutable_streams();
812 ASSERT_EQ(mutable_streams.size(), 1u);
813 mutable_streams[0].ssrcs = {kFirstMungedSsrc + static_cast<uint32_t>(i)};
814 }
815 ASSERT_TRUE(
816 callee->SetLocalDescription(CloneSessionDescription(answer.get())));
817 ASSERT_TRUE(
818 caller->SetRemoteDescription(CloneSessionDescription(answer.get())));
819
820 // No furher track events should fire because we never changed direction, only
821 // SSRCs.
822 ASSERT_EQ(caller->observer()->add_track_events_.size(), 2u);
823 // We should have the same number of receivers as before.
824 auto receivers = caller->pc()->GetReceivers();
825 ASSERT_EQ(receivers.size(), 2u);
826 // The tracks are still alive.
827 EXPECT_EQ(receivers[0]->track()->state(),
828 MediaStreamTrackInterface::TrackState::kLive);
829 EXPECT_EQ(receivers[1]->track()->state(),
830 MediaStreamTrackInterface::TrackState::kLive);
831}
Seth Hampson5897a6e2018-04-03 11:16:33 -0700832
Seth Hampson5b4f0752018-04-02 16:31:36 -0700833// Tests that with Unified Plan if the the stream id changes for a track when
834// when setting a new remote description, that the media stream is updated
835// appropriately for the receiver.
Steve Anton0f5400a2018-07-17 14:25:36 -0700836// TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix
837// test.
838TEST_F(PeerConnectionRtpTestUnifiedPlan,
839 DISABLED_RemoteStreamIdChangesUpdatesReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700840 auto caller = CreatePeerConnection();
841 auto callee = CreatePeerConnection();
Seth Hampson5b4f0752018-04-02 16:31:36 -0700842
843 const char kStreamId1[] = "stream1";
844 const char kStreamId2[] = "stream2";
Steve Anton0f5400a2018-07-17 14:25:36 -0700845 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700846 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700847 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
848
849 // Change the stream id of the sender in the session description.
850 auto offer = caller->CreateOfferAndSetAsLocal();
851 auto contents = offer->description()->contents();
852 ASSERT_EQ(contents.size(), 1u);
853 ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u);
854 contents[0].media_description()->mutable_streams()[0].set_stream_ids(
855 {kStreamId2});
856
Steve Anton0f5400a2018-07-17 14:25:36 -0700857 // Set the remote description and verify that the stream was updated
858 // properly.
859 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700860 auto receivers = callee->pc()->GetReceivers();
861 ASSERT_EQ(receivers.size(), 1u);
862 ASSERT_EQ(receivers[0]->streams().size(), 1u);
863 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2);
864}
865
866// This tests a regression caught by a downstream client, that occured when
867// applying a remote description with a SessionDescription object that
868// contained StreamParams that didn't have ids. Although there were multiple
869// remote audio senders, FindSenderInfo didn't find them as unique, because
870// it looked up by StreamParam.id, which none had. This meant only one
871// AudioRtpReceiver was created, as opposed to one for each remote sender.
Steve Anton3172c032018-05-03 15:30:18 -0700872TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700873 MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) {
874 auto caller = CreatePeerConnection();
875 auto callee = CreatePeerConnection();
876
877 const char kStreamId1[] = "stream1";
878 const char kStreamId2[] = "stream2";
879 caller->AddAudioTrack("audio_track1", {kStreamId1});
880 caller->AddAudioTrack("audio_track2", {kStreamId2});
881
882 auto offer = caller->CreateOfferAndSetAsLocal();
883 auto mutable_streams =
884 cricket::GetFirstAudioContentDescription(offer->description())
885 ->mutable_streams();
886 ASSERT_EQ(mutable_streams.size(), 2u);
887 // Clear the IDs in the StreamParams.
888 mutable_streams[0].id.clear();
889 mutable_streams[1].id.clear();
890 ASSERT_TRUE(
891 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
892
893 auto receivers = callee->pc()->GetReceivers();
894 ASSERT_EQ(receivers.size(), 2u);
895 ASSERT_EQ(receivers[0]->streams().size(), 1u);
896 EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id());
897 ASSERT_EQ(receivers[1]->streams().size(), 1u);
898 EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id());
899}
900
Henrik Boström31638672017-11-23 17:48:32 +0100901// Tests for the legacy SetRemoteDescription() function signature.
Henrik Boström31638672017-11-23 17:48:32 +0100902
903// Sanity test making sure the callback is invoked.
Steve Anton3172c032018-05-03 15:30:18 -0700904TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) {
Henrik Boström31638672017-11-23 17:48:32 +0100905 auto caller = CreatePeerConnection();
906 auto callee = CreatePeerConnection();
907
908 std::string error;
909 ASSERT_TRUE(
910 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
911}
912
913// Verifies legacy behavior: The observer is not called if if the peer
914// connection is destroyed because the asynchronous callback is executed in the
915// peer connection's message handler.
Steve Anton3172c032018-05-03 15:30:18 -0700916TEST_P(PeerConnectionRtpTest,
917 LegacyObserverNotCalledIfPeerConnectionDereferenced) {
Henrik Boström31638672017-11-23 17:48:32 +0100918 auto caller = CreatePeerConnection();
919 auto callee = CreatePeerConnection();
920
921 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
Tommi87f70902021-04-27 14:43:08 +0200922 rtc::make_ref_counted<webrtc::MockSetSessionDescriptionObserver>();
Henrik Boström31638672017-11-23 17:48:32 +0100923
924 auto offer = caller->CreateOfferAndSetAsLocal();
925 callee->pc()->SetRemoteDescription(observer, offer.release());
926 callee = nullptr;
927 rtc::Thread::Current()->ProcessMessages(0);
928 EXPECT_FALSE(observer->called());
929}
930
Steve Antonf9381f02017-12-14 10:23:57 -0800931// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800932
933// Test that by default there are no transceivers with Unified Plan.
Steve Anton3172c032018-05-03 15:30:18 -0700934TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) {
935 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800936 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
937}
938
939// Test that a transceiver created with the audio kind has the correct initial
940// properties.
Steve Anton3172c032018-05-03 15:30:18 -0700941TEST_F(PeerConnectionRtpTestUnifiedPlan,
942 AddTransceiverHasCorrectInitProperties) {
943 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800944
945 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200946 EXPECT_EQ(absl::nullopt, transceiver->mid());
Steve Anton9158ef62017-11-27 13:01:52 -0800947 EXPECT_FALSE(transceiver->stopped());
948 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200949 EXPECT_EQ(absl::nullopt, transceiver->current_direction());
Steve Anton9158ef62017-11-27 13:01:52 -0800950}
951
952// Test that adding a transceiver with the audio kind creates an audio sender
953// and audio receiver with the receiver having a live audio track.
Steve Anton3172c032018-05-03 15:30:18 -0700954TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800955 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700956 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800957
958 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Steve Anton69470252018-02-09 11:43:08 -0800959 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800960
961 ASSERT_TRUE(transceiver->sender());
962 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
963
964 ASSERT_TRUE(transceiver->receiver());
965 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
966
967 auto track = transceiver->receiver()->track();
968 ASSERT_TRUE(track);
969 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
970 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
971}
972
973// Test that adding a transceiver with the video kind creates an video sender
974// and video receiver with the receiver having a live video track.
Steve Anton3172c032018-05-03 15:30:18 -0700975TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800976 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700977 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800978
979 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
Steve Anton69470252018-02-09 11:43:08 -0800980 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800981
982 ASSERT_TRUE(transceiver->sender());
983 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
984
985 ASSERT_TRUE(transceiver->receiver());
986 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
987
988 auto track = transceiver->receiver()->track();
989 ASSERT_TRUE(track);
990 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
991 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
992}
993
994// Test that after a call to AddTransceiver, the transceiver shows in
995// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
996// transceiver's receiver shows in GetReceivers().
Steve Anton3172c032018-05-03 15:30:18 -0700997TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) {
998 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800999
1000 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1001 EXPECT_EQ(
1002 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
1003 caller->pc()->GetTransceivers());
1004 EXPECT_EQ(
1005 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
1006 transceiver->sender()},
1007 caller->pc()->GetSenders());
1008 EXPECT_EQ(
1009 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
1010 transceiver->receiver()},
1011 caller->pc()->GetReceivers());
1012}
1013
1014// Test that the direction passed in through the AddTransceiver init parameter
1015// is set in the returned transceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001016TEST_F(PeerConnectionRtpTestUnifiedPlan,
1017 AddTransceiverWithDirectionIsReflected) {
1018 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -08001019
1020 RtpTransceiverInit init;
1021 init.direction = RtpTransceiverDirection::kSendOnly;
1022 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1023 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1024}
1025
Steve Anton9158ef62017-11-27 13:01:52 -08001026// Test that calling AddTransceiver with a track creates a transceiver which has
1027// its sender's track set to the passed-in track.
Steve Anton3172c032018-05-03 15:30:18 -07001028TEST_F(PeerConnectionRtpTestUnifiedPlan,
1029 AddTransceiverWithTrackCreatesSenderWithTrack) {
1030 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -08001031
1032 auto audio_track = caller->CreateAudioTrack("audio track");
1033 auto transceiver = caller->AddTransceiver(audio_track);
1034
1035 auto sender = transceiver->sender();
1036 ASSERT_TRUE(sender->track());
1037 EXPECT_EQ(audio_track, sender->track());
1038
1039 auto receiver = transceiver->receiver();
1040 ASSERT_TRUE(receiver->track());
1041 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
1042 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
1043 receiver->track()->state());
1044}
1045
1046// Test that calling AddTransceiver twice with the same track creates distinct
1047// transceivers, senders with the same track.
Steve Anton3172c032018-05-03 15:30:18 -07001048TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -08001049 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
Steve Anton3172c032018-05-03 15:30:18 -07001050 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -08001051
1052 auto audio_track = caller->CreateAudioTrack("audio track");
1053
1054 auto transceiver1 = caller->AddTransceiver(audio_track);
1055 auto transceiver2 = caller->AddTransceiver(audio_track);
1056
1057 EXPECT_NE(transceiver1, transceiver2);
1058
1059 auto sender1 = transceiver1->sender();
1060 auto sender2 = transceiver2->sender();
1061 EXPECT_NE(sender1, sender2);
1062 EXPECT_EQ(audio_track, sender1->track());
1063 EXPECT_EQ(audio_track, sender2->track());
1064
1065 EXPECT_THAT(caller->pc()->GetTransceivers(),
1066 UnorderedElementsAre(transceiver1, transceiver2));
1067 EXPECT_THAT(caller->pc()->GetSenders(),
1068 UnorderedElementsAre(sender1, sender2));
1069}
1070
Steve Anton3fe1b152017-12-12 10:20:08 -08001071// RtpTransceiver error handling tests.
1072
Steve Anton3172c032018-05-03 15:30:18 -07001073TEST_F(PeerConnectionRtpTestUnifiedPlan,
1074 AddTransceiverWithInvalidKindReturnsError) {
1075 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -08001076
1077 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
1078 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
1079}
1080
Steve Anton3172c032018-05-03 15:30:18 -07001081TEST_F(PeerConnectionRtpTestUnifiedPlan,
1082 CanClosePeerConnectionWithoutCrashing) {
1083 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -08001084
1085 caller->pc()->Close();
1086}
1087
Steve Antonf9381f02017-12-14 10:23:57 -08001088// Unified Plan AddTrack tests.
1089
Steve Antonf9381f02017-12-14 10:23:57 -08001090// Test that adding an audio track creates a new audio RtpSender with the given
1091// track.
Steve Anton3172c032018-05-03 15:30:18 -07001092TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) {
1093 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001094
1095 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001096 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001097 ASSERT_TRUE(sender);
1098
1099 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
1100 EXPECT_EQ(audio_track, sender->track());
1101}
1102
1103// Test that adding a video track creates a new video RtpSender with the given
1104// track.
Steve Anton3172c032018-05-03 15:30:18 -07001105TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) {
1106 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001107
1108 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001109 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001110 ASSERT_TRUE(sender);
1111
1112 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
1113 EXPECT_EQ(video_track, sender->track());
1114}
1115
1116// Test that adding a track to a new PeerConnection creates an RtpTransceiver
1117// with the sender that AddTrack returns and in the sendrecv direction.
Steve Anton3172c032018-05-03 15:30:18 -07001118TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) {
1119 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001120
1121 auto sender = caller->AddAudioTrack("a");
1122 ASSERT_TRUE(sender);
1123
1124 auto transceivers = caller->pc()->GetTransceivers();
1125 ASSERT_EQ(1u, transceivers.size());
1126 EXPECT_EQ(sender, transceivers[0]->sender());
1127 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
1128}
1129
1130// Test that if a transceiver of the same type but no track had been added to
1131// the PeerConnection and later a call to AddTrack is made, the resulting sender
1132// is the transceiver's sender and the sender's track is the newly-added track.
Steve Anton3172c032018-05-03 15:30:18 -07001133TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) {
1134 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001135
1136 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1137 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001138 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001139 ASSERT_TRUE(sender);
1140
1141 auto transceivers = caller->pc()->GetTransceivers();
1142 ASSERT_EQ(1u, transceivers.size());
1143 EXPECT_EQ(transceiver, transceivers[0]);
1144 EXPECT_EQ(sender, transceiver->sender());
1145 EXPECT_EQ(audio_track, sender->track());
1146}
1147
1148// Test that adding two tracks to a new PeerConnection creates two
1149// RtpTransceivers in the same order.
Steve Anton3172c032018-05-03 15:30:18 -07001150TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) {
1151 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001152
1153 auto sender1 = caller->AddAudioTrack("a");
1154 auto sender2 = caller->AddVideoTrack("v");
1155 ASSERT_TRUE(sender2);
1156
1157 auto transceivers = caller->pc()->GetTransceivers();
1158 ASSERT_EQ(2u, transceivers.size());
1159 EXPECT_EQ(sender1, transceivers[0]->sender());
1160 EXPECT_EQ(sender2, transceivers[1]->sender());
1161}
1162
1163// Test that if there are multiple transceivers with no sending track then a
1164// later call to AddTrack will use the one of the same type as the newly-added
1165// track.
Steve Anton3172c032018-05-03 15:30:18 -07001166TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) {
1167 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001168
1169 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1170 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
1171 auto sender = caller->AddVideoTrack("v");
1172
1173 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
1174 EXPECT_NE(sender, audio_transceiver->sender());
1175 EXPECT_EQ(sender, video_transceiver->sender());
1176}
1177
1178// Test that if the only transceivers that do not have a sending track have a
1179// different type from the added track, then AddTrack will create a new
1180// transceiver for the track.
Steve Anton3172c032018-05-03 15:30:18 -07001181TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001182 AddTrackDoesNotReuseTransceiverOfWrongType) {
Steve Anton3172c032018-05-03 15:30:18 -07001183 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001184
1185 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1186 auto sender = caller->AddVideoTrack("v");
1187
1188 auto transceivers = caller->pc()->GetTransceivers();
1189 ASSERT_EQ(2u, transceivers.size());
1190 EXPECT_NE(sender, transceivers[0]->sender());
1191 EXPECT_EQ(sender, transceivers[1]->sender());
1192}
1193
1194// Test that the first available transceiver is reused by AddTrack when multiple
1195// are available.
Steve Anton3172c032018-05-03 15:30:18 -07001196TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001197 AddTrackReusesFirstMatchingTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001198 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001199
1200 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1201 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1202 auto sender = caller->AddAudioTrack("a");
1203
1204 auto transceivers = caller->pc()->GetTransceivers();
1205 ASSERT_EQ(2u, transceivers.size());
1206 EXPECT_EQ(sender, transceivers[0]->sender());
1207 EXPECT_NE(sender, transceivers[1]->sender());
1208}
1209
1210// Test that a call to AddTrack that reuses a transceiver will change the
1211// direction from inactive to sendonly.
Steve Anton3172c032018-05-03 15:30:18 -07001212TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001213 AddTrackChangesDirectionFromInactiveToSendOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001214 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001215 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001216
1217 RtpTransceiverInit init;
1218 init.direction = RtpTransceiverDirection::kInactive;
1219 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
Henrik Boströme574a312020-08-25 10:20:11 +02001220 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1221 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001222
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001223 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02001224 caller->observer()->clear_legacy_renegotiation_needed();
1225 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 10:23:57 -08001226 ASSERT_TRUE(caller->AddAudioTrack("a"));
Henrik Boströme574a312020-08-25 10:20:11 +02001227 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1228 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001229
1230 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1231}
1232
1233// Test that a call to AddTrack that reuses a transceiver will change the
1234// direction from recvonly to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -07001235TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001236 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
Steve Anton3172c032018-05-03 15:30:18 -07001237 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001238 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001239
1240 RtpTransceiverInit init;
1241 init.direction = RtpTransceiverDirection::kRecvOnly;
1242 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
Henrik Boströme574a312020-08-25 10:20:11 +02001243 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1244 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001245
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001246 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02001247 caller->observer()->clear_legacy_renegotiation_needed();
1248 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 10:23:57 -08001249 ASSERT_TRUE(caller->AddAudioTrack("a"));
Henrik Boströme574a312020-08-25 10:20:11 +02001250 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1251 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001252
1253 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1254}
1255
Steve Anton3172c032018-05-03 15:30:18 -07001256TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) {
Steve Anton02ee47c2018-01-10 16:26:06 -08001257 const std::string kTrackId = "audio_track";
1258
Steve Anton3172c032018-05-03 15:30:18 -07001259 auto caller = CreatePeerConnection();
Steve Anton02ee47c2018-01-10 16:26:06 -08001260
1261 auto audio_track = caller->CreateAudioTrack(kTrackId);
1262 auto sender = caller->AddTrack(audio_track);
1263
1264 EXPECT_EQ(kTrackId, sender->id());
1265}
1266
Steve Antonf9381f02017-12-14 10:23:57 -08001267// Unified Plan AddTrack error handling.
1268
Steve Anton3172c032018-05-03 15:30:18 -07001269TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) {
1270 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001271
1272 auto audio_track = caller->CreateAudioTrack("a");
1273 caller->pc()->Close();
1274
Henrik Boströme574a312020-08-25 10:20:11 +02001275 caller->observer()->clear_legacy_renegotiation_needed();
1276 caller->observer()->clear_latest_negotiation_needed_event();
Yves Gerey665174f2018-06-19 15:03:05 +02001277 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001278 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Henrik Boströme574a312020-08-25 10:20:11 +02001279 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1280 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001281}
1282
Steve Anton3172c032018-05-03 15:30:18 -07001283TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) {
1284 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001285
1286 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001287 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 10:23:57 -08001288
Henrik Boströme574a312020-08-25 10:20:11 +02001289 caller->observer()->clear_legacy_renegotiation_needed();
1290 caller->observer()->clear_latest_negotiation_needed_event();
Yves Gerey665174f2018-06-19 15:03:05 +02001291 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001292 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Henrik Boströme574a312020-08-25 10:20:11 +02001293 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1294 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001295}
1296
1297// Unified Plan RemoveTrack tests.
1298
1299// Test that calling RemoveTrack on a sender with a previously-added track
1300// clears the sender's track.
Steve Anton3172c032018-05-03 15:30:18 -07001301TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) {
1302 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001303
1304 auto sender = caller->AddAudioTrack("a");
1305 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1306
1307 EXPECT_FALSE(sender->track());
1308}
1309
1310// Test that calling RemoveTrack on a sender where the transceiver is configured
1311// in the sendrecv direction changes the transceiver's direction to recvonly.
Steve Anton3172c032018-05-03 15:30:18 -07001312TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001313 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001314 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001315 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001316
1317 RtpTransceiverInit init;
1318 init.direction = RtpTransceiverDirection::kSendRecv;
1319 auto transceiver =
1320 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Henrik Boströme574a312020-08-25 10:20:11 +02001321 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1322 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001323
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001324 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02001325 caller->observer()->clear_legacy_renegotiation_needed();
1326 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001327
Steve Antonf9381f02017-12-14 10:23:57 -08001328 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
Henrik Boströme574a312020-08-25 10:20:11 +02001329 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1330 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001331
1332 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
Steve Antonf9381f02017-12-14 10:23:57 -08001333}
1334
1335// Test that calling RemoveTrack on a sender where the transceiver is configured
1336// in the sendonly direction changes the transceiver's direction to inactive.
Steve Anton3172c032018-05-03 15:30:18 -07001337TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001338 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
Steve Anton3172c032018-05-03 15:30:18 -07001339 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001340 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001341
1342 RtpTransceiverInit init;
1343 init.direction = RtpTransceiverDirection::kSendOnly;
1344 auto transceiver =
1345 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Henrik Boströme574a312020-08-25 10:20:11 +02001346 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1347 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001348
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001349 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02001350 caller->observer()->clear_legacy_renegotiation_needed();
1351 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001352
Steve Antonf9381f02017-12-14 10:23:57 -08001353 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
Henrik Boströme574a312020-08-25 10:20:11 +02001354 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1355 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001356
1357 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
1358}
1359
1360// Test that calling RemoveTrack with a sender that has a null track results in
1361// no change in state.
Steve Anton3172c032018-05-03 15:30:18 -07001362TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) {
1363 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001364
1365 auto sender = caller->AddAudioTrack("a");
1366 auto transceiver = caller->pc()->GetTransceivers()[0];
1367 ASSERT_TRUE(sender->SetTrack(nullptr));
1368
Henrik Boströme574a312020-08-25 10:20:11 +02001369 caller->observer()->clear_legacy_renegotiation_needed();
1370 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 10:23:57 -08001371 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Henrik Boströme574a312020-08-25 10:20:11 +02001372 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1373 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001374
1375 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1376}
1377
1378// Unified Plan RemoveTrack error handling.
1379
Steve Anton3172c032018-05-03 15:30:18 -07001380TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) {
1381 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001382
1383 auto sender = caller->AddAudioTrack("a");
1384 caller->pc()->Close();
1385
Henrik Boströme574a312020-08-25 10:20:11 +02001386 caller->observer()->clear_legacy_renegotiation_needed();
1387 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 10:23:57 -08001388 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
Henrik Boströme574a312020-08-25 10:20:11 +02001389 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1390 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001391}
1392
Steve Anton3172c032018-05-03 15:30:18 -07001393TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001394 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
Steve Anton3172c032018-05-03 15:30:18 -07001395 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001396
1397 auto sender = caller->AddAudioTrack("a");
1398 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1399
Henrik Boströme574a312020-08-25 10:20:11 +02001400 caller->observer()->clear_legacy_renegotiation_needed();
1401 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 10:23:57 -08001402 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Henrik Boströme574a312020-08-25 10:20:11 +02001403 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1404 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001405}
1406
Steve Anton60b6c1d2018-06-13 11:32:27 -07001407// Test that setting offers that add/remove/add a track repeatedly without
1408// setting the appropriate answer in between works.
1409// These are regression tests for bugs.webrtc.org/9401
1410TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) {
1411 auto caller = CreatePeerConnection();
1412
1413 auto sender1 = caller->AddAudioTrack("audio1");
1414 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1415
1416 caller->pc()->RemoveTrack(sender1);
1417 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1418
1419 // This will re-use the transceiver created by the first AddTrack.
1420 auto sender2 = caller->AddAudioTrack("audio2");
1421 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1422
1423 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1424 EXPECT_EQ(sender1, sender2);
1425}
1426TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) {
1427 auto caller = CreatePeerConnection();
1428
1429 auto sender1 = caller->AddVideoTrack("video1");
1430 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1431
1432 caller->pc()->RemoveTrack(sender1);
1433 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1434
1435 // This will re-use the transceiver created by the first AddTrack.
1436 auto sender2 = caller->AddVideoTrack("video2");
1437 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1438
1439 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1440 EXPECT_EQ(sender1, sender2);
1441}
1442
Steve Anton07563732018-06-26 11:13:50 -07001443// Test that CreateOffer succeeds if two tracks with the same label are added.
1444TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) {
1445 auto caller = CreatePeerConnection();
1446
1447 auto audio_sender = caller->AddAudioTrack("track", {});
1448 auto video_sender = caller->AddVideoTrack("track", {});
1449
1450 EXPECT_TRUE(caller->CreateOffer());
1451
1452 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1453 EXPECT_NE(audio_sender->id(), video_sender->id());
1454}
1455
1456// Test that CreateAnswer succeeds if two tracks with the same label are added.
1457TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) {
1458 auto caller = CreatePeerConnection();
1459 auto callee = CreatePeerConnection();
1460
1461 RtpTransceiverInit recvonly;
1462 recvonly.direction = RtpTransceiverDirection::kRecvOnly;
1463 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly);
1464 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly);
1465
1466 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1467
1468 auto audio_sender = callee->AddAudioTrack("track", {});
1469 auto video_sender = callee->AddVideoTrack("track", {});
1470
1471 EXPECT_TRUE(callee->CreateAnswer());
1472
1473 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1474 EXPECT_NE(audio_sender->id(), video_sender->id());
1475}
1476
1477// Test that calling AddTrack, RemoveTrack and AddTrack again creates a second
1478// m= section with a random sender id (different from the first, now rejected,
1479// m= section).
1480TEST_F(PeerConnectionRtpTestUnifiedPlan,
1481 AddRemoveAddTrackGeneratesNewSenderId) {
1482 auto caller = CreatePeerConnection();
1483 auto callee = CreatePeerConnection();
1484
1485 auto track = caller->CreateVideoTrack("video");
1486 auto sender1 = caller->AddTrack(track);
1487 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1488
1489 caller->pc()->RemoveTrack(sender1);
1490 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1491
1492 auto sender2 = caller->AddTrack(track);
1493
1494 EXPECT_NE(sender1, sender2);
1495 EXPECT_NE(sender1->id(), sender2->id());
1496 std::string sender2_id = sender2->id();
1497
1498 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1499
1500 // The sender's ID should not change after negotiation.
1501 EXPECT_EQ(sender2_id, sender2->id());
1502}
1503
Steve Anton52d86772018-02-20 15:48:12 -08001504// Test that OnRenegotiationNeeded is fired if SetDirection is called on an
1505// active RtpTransceiver with a new direction.
Steve Anton3172c032018-05-03 15:30:18 -07001506TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001507 RenegotiationNeededAfterTransceiverSetDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001508 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001509 auto callee = CreatePeerConnection();
Henrik Boströme574a312020-08-25 10:20:11 +02001510 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1511 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 15:48:12 -08001512
1513 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Henrik Boströme574a312020-08-25 10:20:11 +02001514 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1515 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 15:48:12 -08001516
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001517 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02001518 caller->observer()->clear_legacy_renegotiation_needed();
1519 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001520
Harald Alvestrand6060df52020-08-11 09:54:02 +02001521 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive);
Henrik Boströme574a312020-08-25 10:20:11 +02001522 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1523 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 15:48:12 -08001524}
1525
1526// Test that OnRenegotiationNeeded is not fired if SetDirection is called on an
1527// active RtpTransceiver with current direction.
Steve Anton3172c032018-05-03 15:30:18 -07001528TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001529 NoRenegotiationNeededAfterTransceiverSetSameDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001530 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001531
1532 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1533
Henrik Boströme574a312020-08-25 10:20:11 +02001534 caller->observer()->clear_legacy_renegotiation_needed();
1535 caller->observer()->clear_latest_negotiation_needed_event();
Harald Alvestrand6060df52020-08-11 09:54:02 +02001536 transceiver->SetDirectionWithError(transceiver->direction());
Henrik Boströme574a312020-08-25 10:20:11 +02001537 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1538 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 15:48:12 -08001539}
1540
1541// Test that OnRenegotiationNeeded is not fired if SetDirection is called on a
1542// stopped RtpTransceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001543TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001544 NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001545 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001546
1547 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Harald Alvestrand6060df52020-08-11 09:54:02 +02001548 transceiver->StopInternal();
Steve Anton52d86772018-02-20 15:48:12 -08001549
Henrik Boströme574a312020-08-25 10:20:11 +02001550 caller->observer()->clear_legacy_renegotiation_needed();
1551 caller->observer()->clear_latest_negotiation_needed_event();
Harald Alvestrand6060df52020-08-11 09:54:02 +02001552 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive);
Henrik Boströme574a312020-08-25 10:20:11 +02001553 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1554 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 15:48:12 -08001555}
1556
Harald Alvestrand6060df52020-08-11 09:54:02 +02001557// Test that currentDirection returnes "stopped" if the transceiver was stopped.
1558TEST_F(PeerConnectionRtpTestUnifiedPlan,
1559 CheckStoppedCurrentDirectionOnStoppedTransceiver) {
1560 auto caller = CreatePeerConnection();
1561
1562 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1563 transceiver->StopInternal();
1564
1565 EXPECT_TRUE(transceiver->stopping());
1566 EXPECT_TRUE(transceiver->stopped());
1567 EXPECT_EQ(RtpTransceiverDirection::kStopped,
1568 transceiver->current_direction());
1569}
1570
1571// Test that InvalidState is thrown on a stopping transceiver.
1572TEST_F(PeerConnectionRtpTestUnifiedPlan,
1573 CheckForInvalidStateOnStoppingTransceiver) {
1574 auto caller = CreatePeerConnection();
1575
1576 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1577 transceiver->StopStandard();
1578
1579 EXPECT_TRUE(transceiver->stopping());
1580 EXPECT_FALSE(transceiver->stopped());
1581 EXPECT_EQ(
1582 RTCErrorType::INVALID_STATE,
1583 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive)
1584 .type());
1585}
1586
1587// Test that InvalidState is thrown on a stopped transceiver.
1588TEST_F(PeerConnectionRtpTestUnifiedPlan,
1589 CheckForInvalidStateOnStoppedTransceiver) {
1590 auto caller = CreatePeerConnection();
1591
1592 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1593 transceiver->StopInternal();
1594
1595 EXPECT_TRUE(transceiver->stopping());
1596 EXPECT_TRUE(transceiver->stopped());
1597 EXPECT_EQ(
1598 RTCErrorType::INVALID_STATE,
1599 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive)
1600 .type());
1601}
1602
1603// Test that TypeError is thrown if the direction is set to "stopped".
1604TEST_F(PeerConnectionRtpTestUnifiedPlan,
1605 CheckForTypeErrorForStoppedOnTransceiver) {
1606 auto caller = CreatePeerConnection();
1607
1608 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1609 EXPECT_EQ(
1610 RTCErrorType::INVALID_PARAMETER,
1611 transceiver->SetDirectionWithError(RtpTransceiverDirection::kStopped)
1612 .type());
1613}
1614
Harald Alvestrand198cd732020-09-16 12:41:23 +00001615// Test that you can do createOffer/setLocalDescription with a stopped
1616// media section.
1617TEST_F(PeerConnectionRtpTestUnifiedPlan,
1618 SetLocalDescriptionWithStoppedMediaSection) {
1619 auto caller = CreatePeerConnection();
1620 auto callee = CreatePeerConnection();
1621 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1622 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1623 callee->pc()->GetTransceivers()[0]->StopStandard();
1624 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
1625 EXPECT_EQ(RtpTransceiverDirection::kStopped,
1626 transceiver->current_direction());
1627 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1628}
1629
Harald Alvestrand936f1af2020-09-22 07:41:50 +00001630TEST_F(PeerConnectionRtpTestUnifiedPlan,
1631 StopAndNegotiateCausesTransceiverToDisappear) {
1632 auto caller = CreatePeerConnection();
1633 auto callee = CreatePeerConnection();
1634 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1635 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1636 callee->pc()->GetTransceivers()[0]->StopStandard();
1637 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
1638 EXPECT_EQ(RtpTransceiverDirection::kStopped,
1639 transceiver->current_direction());
1640 EXPECT_EQ(0U, caller->pc()->GetTransceivers().size());
1641 EXPECT_EQ(0U, callee->pc()->GetTransceivers().size());
1642 EXPECT_EQ(0U, caller->pc()->GetSenders().size());
1643 EXPECT_EQ(0U, callee->pc()->GetSenders().size());
1644 EXPECT_EQ(0U, caller->pc()->GetReceivers().size());
1645 EXPECT_EQ(0U, callee->pc()->GetReceivers().size());
1646}
1647
Harald Alvestrand09bd9ba2020-10-09 08:13:30 +00001648TEST_F(PeerConnectionRtpTestUnifiedPlan,
1649 SetLocalDescriptionWorksAfterRepeatedAddRemove) {
1650 auto caller = CreatePeerConnection();
1651 auto callee = CreatePeerConnection();
1652 auto video_track = caller->CreateVideoTrack("v");
1653 auto track = caller->CreateAudioTrack("a");
1654 caller->AddTransceiver(video_track);
1655 auto transceiver = caller->AddTransceiver(track);
1656 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1657 caller->pc()->RemoveTrack(transceiver->sender());
1658 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1659 caller->AddTrack(track);
1660 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1661 caller->pc()->RemoveTrack(transceiver->sender());
1662 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1663}
1664
1665// This is a repro of Chromium bug https://crbug.com/1134686
1666TEST_F(PeerConnectionRtpTestUnifiedPlan,
1667 SetLocalDescriptionWorksAfterRepeatedAddRemoveWithRemoteReject) {
1668 auto caller = CreatePeerConnection();
1669 auto callee = CreatePeerConnection();
1670 auto video_track = caller->CreateVideoTrack("v");
1671 auto track = caller->CreateAudioTrack("a");
1672 caller->AddTransceiver(video_track);
1673 auto transceiver = caller->AddTransceiver(track);
1674 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1675 caller->pc()->RemoveTrack(transceiver->sender());
1676 ExchangeOfferAnswerWhereRemoteStopsTransceiver(caller.get(), callee.get(), 1);
1677 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1678 caller->AddTrack(track);
1679 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1680 caller->pc()->RemoveTrack(transceiver->sender());
1681 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1682}
1683
Florent Castelli892acf02018-10-01 22:47:20 +02001684// Test that AddTransceiver fails if trying to use unimplemented RTP encoding
1685// parameters with the send_encodings parameters.
1686TEST_F(PeerConnectionRtpTestUnifiedPlan,
1687 CheckForUnsupportedEncodingParameters) {
1688 auto caller = CreatePeerConnection();
1689
1690 RtpTransceiverInit init;
1691 init.send_encodings.emplace_back();
1692
1693 auto default_send_encodings = init.send_encodings;
1694
Henrik Grunelle1301a82018-12-13 12:13:22 +00001695 // Unimplemented RtpParameters: ssrc, codec_payload_type, fec, rtx, dtx,
Amit Hilbuchaa584152019-02-06 17:09:52 -08001696 // ptime, scale_framerate_down_by, dependency_rids.
Florent Castelli892acf02018-10-01 22:47:20 +02001697 init.send_encodings[0].ssrc = 1;
1698 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1699 caller->pc()
1700 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1701 .error()
1702 .type());
1703 init.send_encodings = default_send_encodings;
Florent Castelli892acf02018-10-01 22:47:20 +02001704}
1705
Florent Castellic1a0bcb2019-01-29 14:26:48 +01001706// Test that AddTransceiver fails if trying to use invalid RTP encoding
1707// parameters with the send_encodings parameters.
1708TEST_F(PeerConnectionRtpTestUnifiedPlan, CheckForInvalidEncodingParameters) {
1709 auto caller = CreatePeerConnection();
1710
1711 RtpTransceiverInit init;
1712 init.send_encodings.emplace_back();
1713
1714 auto default_send_encodings = init.send_encodings;
1715
1716 init.send_encodings[0].scale_resolution_down_by = 0.5;
1717 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1718 caller->pc()
1719 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1720 .error()
1721 .type());
1722 init.send_encodings = default_send_encodings;
1723
1724 init.send_encodings[0].bitrate_priority = 0;
1725 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1726 caller->pc()
1727 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1728 .error()
1729 .type());
1730 init.send_encodings = default_send_encodings;
1731
1732 init.send_encodings[0].min_bitrate_bps = 200000;
1733 init.send_encodings[0].max_bitrate_bps = 100000;
1734 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1735 caller->pc()
1736 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1737 .error()
1738 .type());
1739 init.send_encodings = default_send_encodings;
1740
1741 init.send_encodings[0].num_temporal_layers = 0;
1742 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1743 caller->pc()
1744 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1745 .error()
1746 .type());
1747 init.send_encodings = default_send_encodings;
1748
1749 init.send_encodings[0].num_temporal_layers = 5;
1750 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1751 caller->pc()
1752 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1753 .error()
1754 .type());
1755 init.send_encodings = default_send_encodings;
1756}
1757
Florent Castelli892acf02018-10-01 22:47:20 +02001758// Test that AddTransceiver transfers the send_encodings to the sender and they
1759// are retained after SetLocalDescription().
1760TEST_F(PeerConnectionRtpTestUnifiedPlan, SendEncodingsPassedToSender) {
1761 auto caller = CreatePeerConnection();
1762
1763 RtpTransceiverInit init;
1764 init.send_encodings.emplace_back();
1765 init.send_encodings[0].active = false;
1766 init.send_encodings[0].max_bitrate_bps = 180000;
1767
1768 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1769 ASSERT_TRUE(result.ok());
1770
1771 auto init_send_encodings = result.value()->sender()->init_send_encodings();
1772 EXPECT_FALSE(init_send_encodings[0].active);
1773 EXPECT_EQ(init_send_encodings[0].max_bitrate_bps, 180000);
1774
1775 auto parameters = result.value()->sender()->GetParameters();
1776 EXPECT_FALSE(parameters.encodings[0].active);
1777 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1778
1779 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1780
1781 parameters = result.value()->sender()->GetParameters();
1782 EXPECT_FALSE(parameters.encodings[0].active);
1783 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1784}
1785
Steve Antone831b8c2018-02-01 12:22:16 -08001786// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
1787// options for this kind of signaling: media section based (a=msid) and ssrc
1788// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
1789// we want to ensure compatibility with older Plan B endpoints that might expect
1790// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
1791// types but answers with the same type as the offer.
1792
Steve Anton3172c032018-05-03 15:30:18 -07001793class PeerConnectionMsidSignalingTest
1794 : public PeerConnectionRtpTestUnifiedPlan {};
Steve Antone831b8c2018-02-01 12:22:16 -08001795
1796TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
1797 auto caller = CreatePeerConnectionWithUnifiedPlan();
1798 caller->AddAudioTrack("caller_audio");
1799 auto callee = CreatePeerConnectionWithUnifiedPlan();
1800 callee->AddAudioTrack("callee_audio");
1801
1802 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1803
1804 // Offer should have had both a=msid and a=ssrc MSID lines.
1805 auto* offer = callee->pc()->remote_description();
1806 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1807 cricket::kMsidSignalingSsrcAttribute),
1808 offer->description()->msid_signaling());
1809
1810 // Answer should have had only a=msid lines.
1811 auto* answer = caller->pc()->remote_description();
1812 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1813 answer->description()->msid_signaling());
Harald Alvestrand5dbb5862018-02-13 23:48:00 +01001814 // Check that this is counted correctly
Ying Wangef3998f2019-12-09 13:06:53 +01001815 EXPECT_METRIC_THAT(
1816 metrics::Samples("WebRTC.PeerConnection.SdpSemanticNegotiated"),
1817 ElementsAre(Pair(kSdpSemanticNegotiatedUnifiedPlan, 2)));
Steve Antone831b8c2018-02-01 12:22:16 -08001818}
1819
1820TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
1821 auto caller = CreatePeerConnectionWithPlanB();
1822 caller->AddAudioTrack("caller_audio");
1823 auto callee = CreatePeerConnectionWithUnifiedPlan();
1824 callee->AddAudioTrack("callee_audio");
1825
1826 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1827
1828 // Offer should have only a=ssrc MSID lines.
1829 auto* offer = callee->pc()->remote_description();
1830 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1831 offer->description()->msid_signaling());
1832
1833 // Answer should have only a=ssrc MSID lines to match the offer.
1834 auto* answer = caller->pc()->remote_description();
1835 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1836 answer->description()->msid_signaling());
1837}
1838
Seth Hampson5b4f0752018-04-02 16:31:36 -07001839// This tests that a Plan B endpoint appropriately sets the remote description
1840// from a Unified Plan offer. When the Unified Plan offer contains a=msid lines
1841// that signal no stream ids or multiple stream ids we expect that the Plan B
1842// endpoint always has exactly one media stream per track.
1843TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) {
1844 const std::string kStreamId1 = "audio_stream_1";
1845 const std::string kStreamId2 = "audio_stream_2";
1846
1847 auto caller = CreatePeerConnectionWithUnifiedPlan();
1848 caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2});
1849 caller->AddVideoTrack("caller_video", {});
1850 auto callee = CreatePeerConnectionWithPlanB();
1851 callee->AddAudioTrack("callee_audio");
1852 caller->AddVideoTrack("callee_video");
1853
1854 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1855
1856 // Offer should have had both a=msid and a=ssrc MSID lines.
1857 auto* offer = callee->pc()->remote_description();
1858 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1859 cricket::kMsidSignalingSsrcAttribute),
1860 offer->description()->msid_signaling());
1861
1862 // Callee should always have 1 stream for all of it's receivers.
1863 const auto& track_events = callee->observer()->add_track_events_;
1864 ASSERT_EQ(2u, track_events.size());
1865 ASSERT_EQ(1u, track_events[0].streams.size());
1866 EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id());
1867 ASSERT_EQ(1u, track_events[1].streams.size());
1868 // This autogenerated a stream id for the empty one signalled.
1869 EXPECT_FALSE(track_events[1].streams[0]->id().empty());
1870}
1871
Steve Antone831b8c2018-02-01 12:22:16 -08001872TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
1873 auto caller = CreatePeerConnectionWithUnifiedPlan();
1874 caller->AddAudioTrack("caller_audio");
1875 auto callee = CreatePeerConnectionWithUnifiedPlan();
1876 callee->AddAudioTrack("callee_audio");
1877
1878 auto offer = caller->CreateOffer();
1879 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
1880 // section only.
1881 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
1882
1883 ASSERT_TRUE(
1884 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
1885 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
1886
1887 // Answer should have only a=msid to match the offer.
1888 auto answer = callee->CreateAnswer();
1889 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1890 answer->description()->msid_signaling());
1891}
1892
Steve Anton8e20f172018-03-06 10:55:04 -08001893// Test that the correct UMA metrics are reported for simple/complex SDP.
1894
Steve Anton3172c032018-05-03 15:30:18 -07001895class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {};
Steve Anton8e20f172018-03-06 10:55:04 -08001896
Mirko Bonadei5eb43b42021-01-18 13:24:40 +01001897#ifdef WEBRTC_HAVE_SCTP
Steve Anton8e20f172018-03-06 10:55:04 -08001898TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) {
1899 auto caller = CreatePeerConnectionWithUnifiedPlan();
1900 caller->CreateDataChannel("dc");
1901 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001902
1903 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001904 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001905 EXPECT_METRIC_THAT(
1906 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1907 ElementsAre(Pair(kSdpFormatReceivedNoTracks, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001908}
Mirko Bonadei5eb43b42021-01-18 13:24:40 +01001909#endif // WEBRTC_HAVE_SCTP
Steve Anton8e20f172018-03-06 10:55:04 -08001910
1911TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) {
1912 auto caller = CreatePeerConnectionWithUnifiedPlan();
1913 caller->AddAudioTrack("audio");
1914 caller->AddVideoTrack("video");
1915 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001916
1917 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001918 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001919 EXPECT_METRIC_THAT(
1920 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1921 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001922}
1923
1924TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) {
1925 auto caller = CreatePeerConnectionWithPlanB();
1926 caller->AddVideoTrack("video"); // Video only.
1927 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001928
1929 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Steve Antonc1e6e862019-03-04 14:43:44 -08001930 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001931 EXPECT_METRIC_THAT(
1932 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1933 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001934}
1935
1936TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) {
1937 auto caller = CreatePeerConnectionWithUnifiedPlan();
1938 caller->AddAudioTrack("audio1");
1939 caller->AddAudioTrack("audio2");
1940 caller->AddVideoTrack("video");
1941 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001942
1943 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001944 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001945 EXPECT_METRIC_THAT(
1946 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1947 ElementsAre(Pair(kSdpFormatReceivedComplexUnifiedPlan, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001948}
1949
1950TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) {
1951 auto caller = CreatePeerConnectionWithPlanB();
1952 caller->AddVideoTrack("video1");
1953 caller->AddVideoTrack("video2");
1954 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001955
Steve Antonba42e992018-04-09 14:10:01 -07001956 // This fails since Unified Plan cannot set a session description with
1957 // multiple "Plan B tracks" in the same media section. But we still expect the
1958 // SDP Format to be recorded.
1959 ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001960 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001961 EXPECT_METRIC_THAT(
1962 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1963 ElementsAre(Pair(kSdpFormatReceivedComplexPlanB, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001964}
1965
Philipp Hanckeb8ca2a12020-10-07 12:47:10 +02001966TEST_F(SdpFormatReceivedTest, AnswerIsReported) {
1967 auto caller = CreatePeerConnectionWithPlanB();
1968 caller->AddAudioTrack("audio");
1969 caller->AddVideoTrack("video");
1970 auto callee = CreatePeerConnectionWithUnifiedPlan();
1971
1972 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
1973 ASSERT_TRUE(caller->SetRemoteDescription(callee->CreateAnswer()));
1974 EXPECT_METRIC_THAT(
1975 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceivedAnswer"),
1976 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
1977}
1978
Henrik Boström91d039b2018-01-11 17:43:30 +01001979// Sender setups in a call.
1980
Steve Anton3172c032018-05-03 15:30:18 -07001981TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) {
Henrik Boström91d039b2018-01-11 17:43:30 +01001982 auto caller = CreatePeerConnection();
1983 auto callee = CreatePeerConnection();
1984
1985 auto track = caller->CreateAudioTrack("audio_track");
1986 auto sender1 = caller->AddTrack(track);
1987 ASSERT_TRUE(sender1);
1988 // We need to temporarily reset the track for the subsequent AddTrack() to
1989 // succeed.
1990 EXPECT_TRUE(sender1->SetTrack(nullptr));
1991 auto sender2 = caller->AddTrack(track);
1992 EXPECT_TRUE(sender2);
1993 EXPECT_TRUE(sender1->SetTrack(track));
1994
Steve Anton3172c032018-05-03 15:30:18 -07001995 if (sdp_semantics_ == SdpSemantics::kPlanB) {
1996 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
Artem Titovcfea2182021-08-10 01:22:31 +02001997 // return true, and doing `callee->SetRemoteDescription()` should work.
Steve Anton3172c032018-05-03 15:30:18 -07001998 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
1999 } else {
2000 EXPECT_TRUE(caller->CreateOfferAndSetAsLocal());
2001 }
Henrik Boström91d039b2018-01-11 17:43:30 +01002002}
2003
Guido Urdaneta70c2db12019-04-16 12:24:14 +02002004// This test exercises the code path that fires a NegotiationNeeded
2005// notification when the stream IDs of the local description differ from
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02002006// the ones in the transceiver.
Guido Urdaneta70c2db12019-04-16 12:24:14 +02002007TEST_F(PeerConnectionRtpTestUnifiedPlan,
2008 ChangeAssociatedStreamsTriggersRenegotiation) {
2009 auto caller = CreatePeerConnection();
2010 auto callee = CreatePeerConnection();
2011
2012 RtpTransceiverInit init;
2013 init.direction = RtpTransceiverDirection::kSendRecv;
2014 auto transceiver =
2015 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Henrik Boströme574a312020-08-25 10:20:11 +02002016 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
2017 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Guido Urdaneta70c2db12019-04-16 12:24:14 +02002018
2019 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02002020 caller->observer()->clear_legacy_renegotiation_needed();
2021 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02002022
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02002023 transceiver->sender()->SetStreams({"stream3", "stream4", "stream5"});
Henrik Boströme574a312020-08-25 10:20:11 +02002024 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
2025 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02002026
2027 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
2028 auto callee_streams = callee->pc()->GetReceivers()[0]->streams();
2029 ASSERT_EQ(3u, callee_streams.size());
2030 EXPECT_EQ("stream3", callee_streams[0]->id());
2031 EXPECT_EQ("stream4", callee_streams[1]->id());
2032 EXPECT_EQ("stream5", callee_streams[2]->id());
Guido Urdaneta70c2db12019-04-16 12:24:14 +02002033}
2034
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002035INSTANTIATE_TEST_SUITE_P(PeerConnectionRtpTest,
2036 PeerConnectionRtpTest,
2037 Values(SdpSemantics::kPlanB,
2038 SdpSemantics::kUnifiedPlan));
Steve Anton3172c032018-05-03 15:30:18 -07002039
Steve Anton9158ef62017-11-27 13:01:52 -08002040} // namespace webrtc