danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 11 | #include "modules/rtp_rtcp/source/rtp_packet.h" |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 12 | |
Yves Gerey | 988cc08 | 2018-10-23 12:03:01 +0200 | [diff] [blame] | 13 | #include <cstdint> |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 14 | #include <cstring> |
Danil Chapovalov | a64a2fb | 2016-09-12 11:41:35 +0200 | [diff] [blame] | 15 | #include <utility> |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 16 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 17 | #include "modules/rtp_rtcp/source/byte_io.h" |
| 18 | #include "rtc_base/checks.h" |
| 19 | #include "rtc_base/logging.h" |
Karl Wiberg | e40468b | 2017-11-22 10:42:26 +0100 | [diff] [blame] | 20 | #include "rtc_base/numerics/safe_conversions.h" |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 21 | |
| 22 | namespace webrtc { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 23 | namespace { |
| 24 | constexpr size_t kFixedHeaderSize = 12; |
| 25 | constexpr uint8_t kRtpVersion = 2; |
Johannes Kron | 07ba2b9 | 2018-09-26 13:33:35 +0200 | [diff] [blame] | 26 | constexpr uint16_t kOneByteExtensionProfileId = 0xBEDE; |
| 27 | constexpr uint16_t kTwoByteExtensionProfileId = 0x1000; |
| 28 | constexpr size_t kOneByteExtensionHeaderLength = 1; |
| 29 | constexpr size_t kTwoByteExtensionHeaderLength = 2; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 30 | constexpr size_t kDefaultPacketSize = 1500; |
| 31 | } // namespace |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 32 | |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 33 | // 0 1 2 3 |
| 34 | // 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 |
| 35 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ |
| 36 | // |V=2|P|X| CC |M| PT | sequence number | |
| 37 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ |
| 38 | // | timestamp | |
| 39 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ |
| 40 | // | synchronization source (SSRC) identifier | |
| 41 | // +=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+ |
| 42 | // | Contributing source (CSRC) identifiers | |
| 43 | // | .... | |
| 44 | // +=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+ |
Johannes Kron | 07ba2b9 | 2018-09-26 13:33:35 +0200 | [diff] [blame] | 45 | // | header eXtension profile id | length in 32bits | |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 46 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ |
| 47 | // | Extensions | |
| 48 | // | .... | |
| 49 | // +=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+ |
| 50 | // | Payload | |
| 51 | // | .... : padding... | |
| 52 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ |
| 53 | // | padding | Padding size | |
| 54 | // +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 55 | RtpPacket::RtpPacket() : RtpPacket(nullptr, kDefaultPacketSize) {} |
danilchap | 70f39a3 | 2016-12-16 05:48:18 -0800 | [diff] [blame] | 56 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 57 | RtpPacket::RtpPacket(const ExtensionManager* extensions) |
| 58 | : RtpPacket(extensions, kDefaultPacketSize) {} |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 59 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 60 | RtpPacket::RtpPacket(const RtpPacket&) = default; |
nisse | 76e62b0 | 2017-05-31 02:24:52 -0700 | [diff] [blame] | 61 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 62 | RtpPacket::RtpPacket(const ExtensionManager* extensions, size_t capacity) |
Johannes Kron | 3dd473b | 2018-10-29 14:42:36 +0100 | [diff] [blame] | 63 | : extensions_(extensions ? *extensions : ExtensionManager()), |
| 64 | buffer_(capacity) { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 65 | RTC_DCHECK_GE(capacity, kFixedHeaderSize); |
| 66 | Clear(); |
| 67 | } |
| 68 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 69 | RtpPacket::~RtpPacket() {} |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 70 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 71 | void RtpPacket::IdentifyExtensions(const ExtensionManager& extensions) { |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 72 | extensions_ = extensions; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 73 | } |
| 74 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 75 | bool RtpPacket::Parse(const uint8_t* buffer, size_t buffer_size) { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 76 | if (!ParseBuffer(buffer, buffer_size)) { |
| 77 | Clear(); |
| 78 | return false; |
| 79 | } |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 80 | buffer_.SetData(buffer, buffer_size); |
Danil Chapovalov | 31e4e80 | 2016-08-03 18:27:40 +0200 | [diff] [blame] | 81 | RTC_DCHECK_EQ(size(), buffer_size); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 82 | return true; |
| 83 | } |
| 84 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 85 | bool RtpPacket::Parse(rtc::ArrayView<const uint8_t> packet) { |
brandtr | b29e652 | 2016-12-21 06:37:18 -0800 | [diff] [blame] | 86 | return Parse(packet.data(), packet.size()); |
| 87 | } |
| 88 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 89 | bool RtpPacket::Parse(rtc::CopyOnWriteBuffer buffer) { |
Danil Chapovalov | 31e4e80 | 2016-08-03 18:27:40 +0200 | [diff] [blame] | 90 | if (!ParseBuffer(buffer.cdata(), buffer.size())) { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 91 | Clear(); |
| 92 | return false; |
| 93 | } |
Danil Chapovalov | 31e4e80 | 2016-08-03 18:27:40 +0200 | [diff] [blame] | 94 | size_t buffer_size = buffer.size(); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 95 | buffer_ = std::move(buffer); |
Danil Chapovalov | 31e4e80 | 2016-08-03 18:27:40 +0200 | [diff] [blame] | 96 | RTC_DCHECK_EQ(size(), buffer_size); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 97 | return true; |
| 98 | } |
| 99 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 100 | std::vector<uint32_t> RtpPacket::Csrcs() const { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 101 | size_t num_csrc = data()[0] & 0x0F; |
| 102 | RTC_DCHECK_GE(capacity(), kFixedHeaderSize + num_csrc * 4); |
| 103 | std::vector<uint32_t> csrcs(num_csrc); |
| 104 | for (size_t i = 0; i < num_csrc; ++i) { |
| 105 | csrcs[i] = |
| 106 | ByteReader<uint32_t>::ReadBigEndian(&data()[kFixedHeaderSize + i * 4]); |
| 107 | } |
| 108 | return csrcs; |
| 109 | } |
| 110 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 111 | void RtpPacket::CopyHeaderFrom(const RtpPacket& packet) { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 112 | RTC_DCHECK_GE(capacity(), packet.headers_size()); |
| 113 | |
| 114 | marker_ = packet.marker_; |
| 115 | payload_type_ = packet.payload_type_; |
| 116 | sequence_number_ = packet.sequence_number_; |
| 117 | timestamp_ = packet.timestamp_; |
| 118 | ssrc_ = packet.ssrc_; |
| 119 | payload_offset_ = packet.payload_offset_; |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 120 | extensions_ = packet.extensions_; |
| 121 | extension_entries_ = packet.extension_entries_; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 122 | extensions_size_ = packet.extensions_size_; |
| 123 | buffer_.SetData(packet.data(), packet.headers_size()); |
| 124 | // Reset payload and padding. |
| 125 | payload_size_ = 0; |
| 126 | padding_size_ = 0; |
| 127 | } |
| 128 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 129 | void RtpPacket::SetMarker(bool marker_bit) { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 130 | marker_ = marker_bit; |
| 131 | if (marker_) { |
| 132 | WriteAt(1, data()[1] | 0x80); |
| 133 | } else { |
| 134 | WriteAt(1, data()[1] & 0x7F); |
| 135 | } |
| 136 | } |
| 137 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 138 | void RtpPacket::SetPayloadType(uint8_t payload_type) { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 139 | RTC_DCHECK_LE(payload_type, 0x7Fu); |
| 140 | payload_type_ = payload_type; |
| 141 | WriteAt(1, (data()[1] & 0x80) | payload_type); |
| 142 | } |
| 143 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 144 | void RtpPacket::SetSequenceNumber(uint16_t seq_no) { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 145 | sequence_number_ = seq_no; |
| 146 | ByteWriter<uint16_t>::WriteBigEndian(WriteAt(2), seq_no); |
| 147 | } |
| 148 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 149 | void RtpPacket::SetTimestamp(uint32_t timestamp) { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 150 | timestamp_ = timestamp; |
| 151 | ByteWriter<uint32_t>::WriteBigEndian(WriteAt(4), timestamp); |
| 152 | } |
| 153 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 154 | void RtpPacket::SetSsrc(uint32_t ssrc) { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 155 | ssrc_ = ssrc; |
| 156 | ByteWriter<uint32_t>::WriteBigEndian(WriteAt(8), ssrc); |
| 157 | } |
| 158 | |
Danil Chapovalov | 7d2df3f | 2018-08-14 17:18:07 +0200 | [diff] [blame] | 159 | void RtpPacket::SetCsrcs(rtc::ArrayView<const uint32_t> csrcs) { |
danilchap | 70f39a3 | 2016-12-16 05:48:18 -0800 | [diff] [blame] | 160 | RTC_DCHECK_EQ(extensions_size_, 0); |
kwiberg | af476c7 | 2016-11-28 15:21:39 -0800 | [diff] [blame] | 161 | RTC_DCHECK_EQ(payload_size_, 0); |
| 162 | RTC_DCHECK_EQ(padding_size_, 0); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 163 | RTC_DCHECK_LE(csrcs.size(), 0x0fu); |
| 164 | RTC_DCHECK_LE(kFixedHeaderSize + 4 * csrcs.size(), capacity()); |
| 165 | payload_offset_ = kFixedHeaderSize + 4 * csrcs.size(); |
danilchap | 772bd8b | 2017-09-13 03:24:28 -0700 | [diff] [blame] | 166 | WriteAt(0, (data()[0] & 0xF0) | rtc::dchecked_cast<uint8_t>(csrcs.size())); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 167 | size_t offset = kFixedHeaderSize; |
| 168 | for (uint32_t csrc : csrcs) { |
| 169 | ByteWriter<uint32_t>::WriteBigEndian(WriteAt(offset), csrc); |
| 170 | offset += 4; |
| 171 | } |
Danil Chapovalov | 31e4e80 | 2016-08-03 18:27:40 +0200 | [diff] [blame] | 172 | buffer_.SetSize(payload_offset_); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 173 | } |
| 174 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 175 | rtc::ArrayView<uint8_t> RtpPacket::AllocateRawExtension(int id, size_t length) { |
Johannes Kron | 07ba2b9 | 2018-09-26 13:33:35 +0200 | [diff] [blame] | 176 | RTC_DCHECK_GE(id, RtpExtension::kMinId); |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 177 | RTC_DCHECK_LE(id, RtpExtension::kMaxId); |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 178 | RTC_DCHECK_GE(length, 1); |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 179 | RTC_DCHECK_LE(length, RtpExtension::kMaxValueSize); |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 180 | const ExtensionInfo* extension_entry = FindExtensionInfo(id); |
| 181 | if (extension_entry != nullptr) { |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 182 | // Extension already reserved. Check if same length is used. |
| 183 | if (extension_entry->length == length) |
| 184 | return rtc::MakeArrayView(WriteAt(extension_entry->offset), length); |
| 185 | |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 186 | RTC_LOG(LS_ERROR) << "Length mismatch for extension id " << id |
Mirko Bonadei | 675513b | 2017-11-09 11:09:25 +0100 | [diff] [blame] | 187 | << ": expected " |
| 188 | << static_cast<int>(extension_entry->length) |
| 189 | << ". received " << length; |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 190 | return nullptr; |
| 191 | } |
| 192 | if (payload_size_ > 0) { |
Mirko Bonadei | 675513b | 2017-11-09 11:09:25 +0100 | [diff] [blame] | 193 | RTC_LOG(LS_ERROR) << "Can't add new extension id " << id |
| 194 | << " after payload was set."; |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 195 | return nullptr; |
| 196 | } |
| 197 | if (padding_size_ > 0) { |
Mirko Bonadei | 675513b | 2017-11-09 11:09:25 +0100 | [diff] [blame] | 198 | RTC_LOG(LS_ERROR) << "Can't add new extension id " << id |
| 199 | << " after padding was set."; |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 200 | return nullptr; |
| 201 | } |
| 202 | |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 203 | const size_t num_csrc = data()[0] & 0x0F; |
| 204 | const size_t extensions_offset = kFixedHeaderSize + (num_csrc * 4) + 4; |
| 205 | // Determine if two-byte header is required for the extension based on id and |
| 206 | // length. Please note that a length of 0 also requires two-byte header |
| 207 | // extension. See RFC8285 Section 4.2-4.3. |
| 208 | const bool two_byte_header_required = |
| 209 | id > RtpExtension::kOneByteHeaderExtensionMaxId || |
| 210 | length > RtpExtension::kOneByteHeaderExtensionMaxValueSize || length == 0; |
Johannes Kron | 9581bc4 | 2018-10-23 10:17:39 +0200 | [diff] [blame] | 211 | RTC_CHECK(!two_byte_header_required || extensions_.ExtmapAllowMixed()); |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 212 | |
| 213 | uint16_t profile_id; |
| 214 | if (extensions_size_ > 0) { |
| 215 | profile_id = |
| 216 | ByteReader<uint16_t>::ReadBigEndian(data() + extensions_offset - 4); |
| 217 | if (profile_id == kOneByteExtensionProfileId && two_byte_header_required) { |
| 218 | // Is buffer size big enough to fit promotion and new data field? |
| 219 | // The header extension will grow with one byte per already allocated |
| 220 | // extension + the size of the extension that is about to be allocated. |
| 221 | size_t expected_new_extensions_size = |
| 222 | extensions_size_ + extension_entries_.size() + |
| 223 | kTwoByteExtensionHeaderLength + length; |
| 224 | if (extensions_offset + expected_new_extensions_size > capacity()) { |
| 225 | RTC_LOG(LS_ERROR) |
| 226 | << "Extension cannot be registered: Not enough space left in " |
| 227 | "buffer to change to two-byte header extension and add new " |
| 228 | "extension."; |
| 229 | return nullptr; |
| 230 | } |
| 231 | // Promote already written data to two-byte header format. |
| 232 | PromoteToTwoByteHeaderExtension(); |
| 233 | profile_id = kTwoByteExtensionProfileId; |
| 234 | } |
| 235 | } else { |
| 236 | // Profile specific ID, set to OneByteExtensionHeader unless |
| 237 | // TwoByteExtensionHeader is required. |
| 238 | profile_id = two_byte_header_required ? kTwoByteExtensionProfileId |
| 239 | : kOneByteExtensionProfileId; |
| 240 | } |
| 241 | |
| 242 | const size_t extension_header_size = profile_id == kOneByteExtensionProfileId |
| 243 | ? kOneByteExtensionHeaderLength |
| 244 | : kTwoByteExtensionHeaderLength; |
Johannes Kron | 07ba2b9 | 2018-09-26 13:33:35 +0200 | [diff] [blame] | 245 | size_t new_extensions_size = |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 246 | extensions_size_ + extension_header_size + length; |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 247 | if (extensions_offset + new_extensions_size > capacity()) { |
Mirko Bonadei | 675513b | 2017-11-09 11:09:25 +0100 | [diff] [blame] | 248 | RTC_LOG(LS_ERROR) |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 249 | << "Extension cannot be registered: Not enough space left in buffer."; |
| 250 | return nullptr; |
| 251 | } |
| 252 | |
| 253 | // All checks passed, write down the extension headers. |
| 254 | if (extensions_size_ == 0) { |
| 255 | RTC_DCHECK_EQ(payload_offset_, kFixedHeaderSize + (num_csrc * 4)); |
| 256 | WriteAt(0, data()[0] | 0x10); // Set extension bit. |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 257 | ByteWriter<uint16_t>::WriteBigEndian(WriteAt(extensions_offset - 4), |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 258 | profile_id); |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 259 | } |
| 260 | |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 261 | if (profile_id == kOneByteExtensionProfileId) { |
| 262 | uint8_t one_byte_header = rtc::dchecked_cast<uint8_t>(id) << 4; |
| 263 | one_byte_header |= rtc::dchecked_cast<uint8_t>(length - 1); |
| 264 | WriteAt(extensions_offset + extensions_size_, one_byte_header); |
| 265 | } else { |
| 266 | // TwoByteHeaderExtension. |
| 267 | uint8_t extension_id = rtc::dchecked_cast<uint8_t>(id); |
| 268 | WriteAt(extensions_offset + extensions_size_, extension_id); |
| 269 | uint8_t extension_length = rtc::dchecked_cast<uint8_t>(length); |
| 270 | WriteAt(extensions_offset + extensions_size_ + 1, extension_length); |
| 271 | } |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 272 | |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 273 | const uint16_t extension_info_offset = rtc::dchecked_cast<uint16_t>( |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 274 | extensions_offset + extensions_size_ + extension_header_size); |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 275 | const uint8_t extension_info_length = rtc::dchecked_cast<uint8_t>(length); |
| 276 | extension_entries_.emplace_back(id, extension_info_length, |
| 277 | extension_info_offset); |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 278 | |
Danil Chapovalov | 61405bc | 2018-02-13 13:55:30 +0100 | [diff] [blame] | 279 | extensions_size_ = new_extensions_size; |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 280 | |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 281 | uint16_t extensions_size_padded = |
| 282 | SetExtensionLengthMaybeAddZeroPadding(extensions_offset); |
| 283 | payload_offset_ = extensions_offset + extensions_size_padded; |
| 284 | buffer_.SetSize(payload_offset_); |
| 285 | return rtc::MakeArrayView(WriteAt(extension_info_offset), |
| 286 | extension_info_length); |
| 287 | } |
| 288 | |
| 289 | void RtpPacket::PromoteToTwoByteHeaderExtension() { |
| 290 | size_t num_csrc = data()[0] & 0x0F; |
| 291 | size_t extensions_offset = kFixedHeaderSize + (num_csrc * 4) + 4; |
| 292 | |
| 293 | RTC_CHECK_GT(extension_entries_.size(), 0); |
| 294 | RTC_CHECK_EQ(payload_size_, 0); |
| 295 | RTC_CHECK_EQ(kOneByteExtensionProfileId, ByteReader<uint16_t>::ReadBigEndian( |
| 296 | data() + extensions_offset - 4)); |
| 297 | // Rewrite data. |
| 298 | // Each extension adds one to the offset. The write-read delta for the last |
| 299 | // extension is therefore the same as the number of extension entries. |
| 300 | size_t write_read_delta = extension_entries_.size(); |
| 301 | for (auto extension_entry = extension_entries_.rbegin(); |
| 302 | extension_entry != extension_entries_.rend(); ++extension_entry) { |
| 303 | size_t read_index = extension_entry->offset; |
| 304 | size_t write_index = read_index + write_read_delta; |
| 305 | // Update offset. |
| 306 | extension_entry->offset = rtc::dchecked_cast<uint16_t>(write_index); |
| 307 | // Copy data. Use memmove since read/write regions may overlap. |
| 308 | memmove(WriteAt(write_index), data() + read_index, extension_entry->length); |
| 309 | // Rewrite id and length. |
| 310 | WriteAt(--write_index, extension_entry->length); |
| 311 | WriteAt(--write_index, extension_entry->id); |
| 312 | --write_read_delta; |
| 313 | } |
| 314 | |
| 315 | // Update profile header, extensions length, and zero padding. |
| 316 | ByteWriter<uint16_t>::WriteBigEndian(WriteAt(extensions_offset - 4), |
| 317 | kTwoByteExtensionProfileId); |
| 318 | extensions_size_ += extension_entries_.size(); |
| 319 | uint16_t extensions_size_padded = |
| 320 | SetExtensionLengthMaybeAddZeroPadding(extensions_offset); |
| 321 | payload_offset_ = extensions_offset + extensions_size_padded; |
| 322 | buffer_.SetSize(payload_offset_); |
| 323 | } |
| 324 | |
| 325 | uint16_t RtpPacket::SetExtensionLengthMaybeAddZeroPadding( |
| 326 | size_t extensions_offset) { |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 327 | // Update header length field. |
Danil Chapovalov | 61405bc | 2018-02-13 13:55:30 +0100 | [diff] [blame] | 328 | uint16_t extensions_words = rtc::dchecked_cast<uint16_t>( |
| 329 | (extensions_size_ + 3) / 4); // Wrap up to 32bit. |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 330 | ByteWriter<uint16_t>::WriteBigEndian(WriteAt(extensions_offset - 2), |
| 331 | extensions_words); |
| 332 | // Fill extension padding place with zeroes. |
| 333 | size_t extension_padding_size = 4 * extensions_words - extensions_size_; |
| 334 | memset(WriteAt(extensions_offset + extensions_size_), 0, |
| 335 | extension_padding_size); |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 336 | return 4 * extensions_words; |
danilchap | 653063f | 2017-04-03 06:16:30 -0700 | [diff] [blame] | 337 | } |
| 338 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 339 | uint8_t* RtpPacket::AllocatePayload(size_t size_bytes) { |
danilchap | 07a01b3 | 2017-03-29 07:33:13 -0700 | [diff] [blame] | 340 | // Reset payload size to 0. If CopyOnWrite buffer_ was shared, this will cause |
| 341 | // reallocation and memcpy. Keeping just header reduces memcpy size. |
| 342 | SetPayloadSize(0); |
| 343 | return SetPayloadSize(size_bytes); |
| 344 | } |
| 345 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 346 | uint8_t* RtpPacket::SetPayloadSize(size_t size_bytes) { |
kwiberg | af476c7 | 2016-11-28 15:21:39 -0800 | [diff] [blame] | 347 | RTC_DCHECK_EQ(padding_size_, 0); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 348 | if (payload_offset_ + size_bytes > capacity()) { |
Mirko Bonadei | 675513b | 2017-11-09 11:09:25 +0100 | [diff] [blame] | 349 | RTC_LOG(LS_WARNING) << "Cannot set payload, not enough space in buffer."; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 350 | return nullptr; |
| 351 | } |
| 352 | payload_size_ = size_bytes; |
Danil Chapovalov | 31e4e80 | 2016-08-03 18:27:40 +0200 | [diff] [blame] | 353 | buffer_.SetSize(payload_offset_ + payload_size_); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 354 | return WriteAt(payload_offset_); |
| 355 | } |
| 356 | |
Danil Chapovalov | f7fcaf0 | 2018-10-10 14:56:01 +0200 | [diff] [blame] | 357 | bool RtpPacket::SetPadding(size_t padding_bytes) { |
| 358 | if (payload_offset_ + payload_size_ + padding_bytes > capacity()) { |
| 359 | RTC_LOG(LS_WARNING) << "Cannot set padding size " << padding_bytes |
| 360 | << ", only " |
Mirko Bonadei | 675513b | 2017-11-09 11:09:25 +0100 | [diff] [blame] | 361 | << (capacity() - payload_offset_ - payload_size_) |
| 362 | << " bytes left in buffer."; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 363 | return false; |
| 364 | } |
Danil Chapovalov | f7fcaf0 | 2018-10-10 14:56:01 +0200 | [diff] [blame] | 365 | padding_size_ = rtc::dchecked_cast<uint8_t>(padding_bytes); |
Danil Chapovalov | 31e4e80 | 2016-08-03 18:27:40 +0200 | [diff] [blame] | 366 | buffer_.SetSize(payload_offset_ + payload_size_ + padding_size_); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 367 | if (padding_size_ > 0) { |
| 368 | size_t padding_offset = payload_offset_ + payload_size_; |
| 369 | size_t padding_end = padding_offset + padding_size_; |
Danil Chapovalov | f7fcaf0 | 2018-10-10 14:56:01 +0200 | [diff] [blame] | 370 | memset(WriteAt(padding_offset), 0, padding_size_ - 1); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 371 | WriteAt(padding_end - 1, padding_size_); |
| 372 | WriteAt(0, data()[0] | 0x20); // Set padding bit. |
| 373 | } else { |
| 374 | WriteAt(0, data()[0] & ~0x20); // Clear padding bit. |
| 375 | } |
| 376 | return true; |
| 377 | } |
| 378 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 379 | void RtpPacket::Clear() { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 380 | marker_ = false; |
| 381 | payload_type_ = 0; |
| 382 | sequence_number_ = 0; |
| 383 | timestamp_ = 0; |
| 384 | ssrc_ = 0; |
| 385 | payload_offset_ = kFixedHeaderSize; |
| 386 | payload_size_ = 0; |
| 387 | padding_size_ = 0; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 388 | extensions_size_ = 0; |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 389 | extension_entries_.clear(); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 390 | |
| 391 | memset(WriteAt(0), 0, kFixedHeaderSize); |
Danil Chapovalov | 31e4e80 | 2016-08-03 18:27:40 +0200 | [diff] [blame] | 392 | buffer_.SetSize(kFixedHeaderSize); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 393 | WriteAt(0, kRtpVersion << 6); |
| 394 | } |
| 395 | |
Danil Chapovalov | 8769e17 | 2017-09-14 14:08:22 +0200 | [diff] [blame] | 396 | bool RtpPacket::ParseBuffer(const uint8_t* buffer, size_t size) { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 397 | if (size < kFixedHeaderSize) { |
| 398 | return false; |
| 399 | } |
| 400 | const uint8_t version = buffer[0] >> 6; |
| 401 | if (version != kRtpVersion) { |
| 402 | return false; |
| 403 | } |
| 404 | const bool has_padding = (buffer[0] & 0x20) != 0; |
| 405 | const bool has_extension = (buffer[0] & 0x10) != 0; |
| 406 | const uint8_t number_of_crcs = buffer[0] & 0x0f; |
| 407 | marker_ = (buffer[1] & 0x80) != 0; |
| 408 | payload_type_ = buffer[1] & 0x7f; |
| 409 | |
| 410 | sequence_number_ = ByteReader<uint16_t>::ReadBigEndian(&buffer[2]); |
| 411 | timestamp_ = ByteReader<uint32_t>::ReadBigEndian(&buffer[4]); |
| 412 | ssrc_ = ByteReader<uint32_t>::ReadBigEndian(&buffer[8]); |
| 413 | if (size < kFixedHeaderSize + number_of_crcs * 4) { |
| 414 | return false; |
| 415 | } |
| 416 | payload_offset_ = kFixedHeaderSize + number_of_crcs * 4; |
| 417 | |
| 418 | if (has_padding) { |
| 419 | padding_size_ = buffer[size - 1]; |
| 420 | if (padding_size_ == 0) { |
Mirko Bonadei | 675513b | 2017-11-09 11:09:25 +0100 | [diff] [blame] | 421 | RTC_LOG(LS_WARNING) << "Padding was set, but padding size is zero"; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 422 | return false; |
| 423 | } |
| 424 | } else { |
| 425 | padding_size_ = 0; |
| 426 | } |
| 427 | |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 428 | extensions_size_ = 0; |
Johannes Kron | 6ea7719 | 2018-09-24 17:19:52 +0200 | [diff] [blame] | 429 | extension_entries_.clear(); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 430 | if (has_extension) { |
| 431 | /* RTP header extension, RFC 3550. |
| 432 | 0 1 2 3 |
| 433 | 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 |
| 434 | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ |
| 435 | | defined by profile | length | |
| 436 | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ |
| 437 | | header extension | |
| 438 | | .... | |
| 439 | */ |
| 440 | size_t extension_offset = payload_offset_ + 4; |
| 441 | if (extension_offset > size) { |
| 442 | return false; |
| 443 | } |
| 444 | uint16_t profile = |
| 445 | ByteReader<uint16_t>::ReadBigEndian(&buffer[payload_offset_]); |
| 446 | size_t extensions_capacity = |
| 447 | ByteReader<uint16_t>::ReadBigEndian(&buffer[payload_offset_ + 2]); |
| 448 | extensions_capacity *= 4; |
| 449 | if (extension_offset + extensions_capacity > size) { |
| 450 | return false; |
| 451 | } |
Johannes Kron | 07ba2b9 | 2018-09-26 13:33:35 +0200 | [diff] [blame] | 452 | if (profile != kOneByteExtensionProfileId && |
| 453 | profile != kTwoByteExtensionProfileId) { |
Mirko Bonadei | 675513b | 2017-11-09 11:09:25 +0100 | [diff] [blame] | 454 | RTC_LOG(LS_WARNING) << "Unsupported rtp extension " << profile; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 455 | } else { |
Johannes Kron | 07ba2b9 | 2018-09-26 13:33:35 +0200 | [diff] [blame] | 456 | size_t extension_header_length = profile == kOneByteExtensionProfileId |
| 457 | ? kOneByteExtensionHeaderLength |
| 458 | : kTwoByteExtensionHeaderLength; |
| 459 | constexpr uint8_t kPaddingByte = 0; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 460 | constexpr uint8_t kPaddingId = 0; |
Johannes Kron | 07ba2b9 | 2018-09-26 13:33:35 +0200 | [diff] [blame] | 461 | constexpr uint8_t kOneByteHeaderExtensionReservedId = 15; |
| 462 | while (extensions_size_ + extension_header_length < extensions_capacity) { |
| 463 | if (buffer[extension_offset + extensions_size_] == kPaddingByte) { |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 464 | extensions_size_++; |
| 465 | continue; |
| 466 | } |
Johannes Kron | 07ba2b9 | 2018-09-26 13:33:35 +0200 | [diff] [blame] | 467 | int id; |
| 468 | uint8_t length; |
| 469 | if (profile == kOneByteExtensionProfileId) { |
| 470 | id = buffer[extension_offset + extensions_size_] >> 4; |
| 471 | length = 1 + (buffer[extension_offset + extensions_size_] & 0xf); |
| 472 | if (id == kOneByteHeaderExtensionReservedId || |
| 473 | (id == kPaddingId && length != 1)) { |
| 474 | break; |
| 475 | } |
| 476 | } else { |
| 477 | id = buffer[extension_offset + extensions_size_]; |
| 478 | length = buffer[extension_offset + extensions_size_ + 1]; |
| 479 | } |
| 480 | |
| 481 | if (extensions_size_ + extension_header_length + length > |
Danil Chapovalov | a64a2fb | 2016-09-12 11:41:35 +0200 | [diff] [blame] | 482 | extensions_capacity) { |
Mirko Bonadei | 675513b | 2017-11-09 11:09:25 +0100 | [diff] [blame] | 483 | RTC_LOG(LS_WARNING) << "Oversized rtp header extension."; |
Danil Chapovalov | a64a2fb | 2016-09-12 11:41:35 +0200 | [diff] [blame] | 484 | break; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 485 | } |
danilchap | 70f39a3 | 2016-12-16 05:48:18 -0800 | [diff] [blame] | 486 | |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 487 | ExtensionInfo& extension_info = FindOrCreateExtensionInfo(id); |
| 488 | if (extension_info.length != 0) { |
Mirko Bonadei | 675513b | 2017-11-09 11:09:25 +0100 | [diff] [blame] | 489 | RTC_LOG(LS_VERBOSE) |
| 490 | << "Duplicate rtp header extension id " << id << ". Overwriting."; |
Danil Chapovalov | a64a2fb | 2016-09-12 11:41:35 +0200 | [diff] [blame] | 491 | } |
danilchap | 70f39a3 | 2016-12-16 05:48:18 -0800 | [diff] [blame] | 492 | |
Danil Chapovalov | c2dd59c | 2018-02-06 11:29:35 +0100 | [diff] [blame] | 493 | size_t offset = |
Johannes Kron | 07ba2b9 | 2018-09-26 13:33:35 +0200 | [diff] [blame] | 494 | extension_offset + extensions_size_ + extension_header_length; |
Danil Chapovalov | c2dd59c | 2018-02-06 11:29:35 +0100 | [diff] [blame] | 495 | if (!rtc::IsValueInRangeForNumericType<uint16_t>(offset)) { |
| 496 | RTC_DLOG(LS_WARNING) << "Oversized rtp header extension."; |
| 497 | break; |
| 498 | } |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 499 | extension_info.offset = static_cast<uint16_t>(offset); |
| 500 | extension_info.length = length; |
Johannes Kron | 07ba2b9 | 2018-09-26 13:33:35 +0200 | [diff] [blame] | 501 | extensions_size_ += extension_header_length + length; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 502 | } |
| 503 | } |
| 504 | payload_offset_ = extension_offset + extensions_capacity; |
| 505 | } |
| 506 | |
| 507 | if (payload_offset_ + padding_size_ > size) { |
| 508 | return false; |
| 509 | } |
| 510 | payload_size_ = size - payload_offset_ - padding_size_; |
| 511 | return true; |
| 512 | } |
| 513 | |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 514 | const RtpPacket::ExtensionInfo* RtpPacket::FindExtensionInfo(int id) const { |
danilchap | 70f39a3 | 2016-12-16 05:48:18 -0800 | [diff] [blame] | 515 | for (const ExtensionInfo& extension : extension_entries_) { |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 516 | if (extension.id == id) { |
| 517 | return &extension; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 518 | } |
| 519 | } |
danilchap | 978504e | 2017-04-06 01:03:53 -0700 | [diff] [blame] | 520 | return nullptr; |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 521 | } |
| 522 | |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 523 | RtpPacket::ExtensionInfo& RtpPacket::FindOrCreateExtensionInfo(int id) { |
| 524 | for (ExtensionInfo& extension : extension_entries_) { |
| 525 | if (extension.id == id) { |
| 526 | return extension; |
danilchap | 70f39a3 | 2016-12-16 05:48:18 -0800 | [diff] [blame] | 527 | } |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 528 | } |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 529 | extension_entries_.emplace_back(id); |
| 530 | return extension_entries_.back(); |
| 531 | } |
| 532 | |
| 533 | rtc::ArrayView<const uint8_t> RtpPacket::FindExtension( |
| 534 | ExtensionType type) const { |
| 535 | uint8_t id = extensions_.GetId(type); |
| 536 | if (id == ExtensionManager::kInvalidId) { |
| 537 | // Extension not registered. |
| 538 | return nullptr; |
| 539 | } |
| 540 | ExtensionInfo const* extension_info = FindExtensionInfo(id); |
| 541 | if (extension_info == nullptr) { |
| 542 | return nullptr; |
| 543 | } |
| 544 | return rtc::MakeArrayView(data() + extension_info->offset, |
| 545 | extension_info->length); |
| 546 | } |
| 547 | |
| 548 | rtc::ArrayView<uint8_t> RtpPacket::AllocateExtension(ExtensionType type, |
| 549 | size_t length) { |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 550 | // TODO(webrtc:7990): Add support for empty extensions (length==0). |
| 551 | if (length == 0 || length > RtpExtension::kMaxValueSize || |
Johannes Kron | 9581bc4 | 2018-10-23 10:17:39 +0200 | [diff] [blame] | 552 | (!extensions_.ExtmapAllowMixed() && |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 553 | length > RtpExtension::kOneByteHeaderExtensionMaxValueSize)) { |
| 554 | return nullptr; |
| 555 | } |
| 556 | |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 557 | uint8_t id = extensions_.GetId(type); |
| 558 | if (id == ExtensionManager::kInvalidId) { |
| 559 | // Extension not registered. |
| 560 | return nullptr; |
| 561 | } |
Johannes Kron | 9581bc4 | 2018-10-23 10:17:39 +0200 | [diff] [blame] | 562 | if (!extensions_.ExtmapAllowMixed() && |
Johannes Kron | 78cdde3 | 2018-10-05 10:00:46 +0200 | [diff] [blame] | 563 | id > RtpExtension::kOneByteHeaderExtensionMaxId) { |
| 564 | return nullptr; |
| 565 | } |
Johannes Kron | c5744b8 | 2018-09-24 14:50:48 +0200 | [diff] [blame] | 566 | return AllocateRawExtension(id, length); |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 567 | } |
| 568 | |
Amit Hilbuch | 77938e6 | 2018-12-21 09:23:38 -0800 | [diff] [blame] | 569 | bool RtpPacket::HasExtension(ExtensionType type) const { |
| 570 | // TODO(webrtc:7990): Add support for empty extensions (length==0). |
| 571 | return !FindExtension(type).empty(); |
| 572 | } |
| 573 | |
danilchap | 1edb7ab | 2016-04-20 05:25:10 -0700 | [diff] [blame] | 574 | } // namespace webrtc |