blob: b39b0c24486ea87f8aff2e658feafb5c26da4a0b [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Yves Gerey3e707812018-11-28 16:47:49 +010011#include <stdint.h>
Henrik Boström933d8b02017-10-10 10:05:16 -070012#include <memory>
Yves Gerey3e707812018-11-28 16:47:49 +010013#include <string>
14#include <utility>
Henrik Boström933d8b02017-10-10 10:05:16 -070015#include <vector>
16
Karl Wiberg918f50c2018-07-05 11:40:33 +020017#include "absl/memory/memory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010018#include "absl/types/optional.h"
19#include "api/audio/audio_mixer.h"
20#include "api/audio_codecs/audio_decoder_factory.h"
21#include "api/audio_codecs/audio_encoder_factory.h"
Karl Wiberg1b0eae32017-10-17 14:48:54 +020022#include "api/audio_codecs/builtin_audio_decoder_factory.h"
23#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Mirko Bonadei2ff3f492018-11-22 09:00:13 +010024#include "api/create_peerconnection_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070025#include "api/jsep.h"
26#include "api/mediastreaminterface.h"
Yves Gerey3e707812018-11-28 16:47:49 +010027#include "api/mediatypes.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070028#include "api/peerconnectioninterface.h"
Yves Gerey3e707812018-11-28 16:47:49 +010029#include "api/rtcerror.h"
30#include "api/rtpparameters.h"
31#include "api/rtpreceiverinterface.h"
32#include "api/rtpsenderinterface.h"
33#include "api/rtptransceiverinterface.h"
34#include "api/setremotedescriptionobserverinterface.h"
Yves Gerey2e00abc2018-10-05 15:39:24 +020035#include "api/umametrics.h"
Anders Carlsson67537952018-05-03 11:28:29 +020036#include "api/video_codecs/builtin_video_decoder_factory.h"
37#include "api/video_codecs/builtin_video_encoder_factory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010038#include "api/video_codecs/video_decoder_factory.h"
39#include "api/video_codecs/video_encoder_factory.h"
40#include "media/base/streamparams.h"
41#include "modules/audio_device/include/audio_device.h"
42#include "modules/audio_processing/include/audio_processing.h"
43#include "p2p/base/portallocator.h"
Seth Hampson5b4f0752018-04-02 16:31:36 -070044#include "pc/mediasession.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070045#include "pc/peerconnectionwrapper.h"
Steve Antone831b8c2018-02-01 12:22:16 -080046#include "pc/sdputils.h"
Yves Gerey3e707812018-11-28 16:47:49 +010047#include "pc/sessiondescription.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070048#include "pc/test/fakeaudiocapturemodule.h"
49#include "pc/test/mockpeerconnectionobservers.h"
50#include "rtc_base/checks.h"
51#include "rtc_base/gunit.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070052#include "rtc_base/refcountedobject.h"
Yves Gerey3e707812018-11-28 16:47:49 +010053#include "rtc_base/rtccertificategenerator.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070054#include "rtc_base/scoped_ref_ptr.h"
55#include "rtc_base/thread.h"
Mirko Bonadei17f48782018-09-28 08:51:10 +020056#include "system_wrappers/include/metrics.h"
Steve Anton9158ef62017-11-27 13:01:52 -080057#include "test/gmock.h"
Yves Gerey3e707812018-11-28 16:47:49 +010058#include "test/gtest.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070059
60// This file contains tests for RTP Media API-related behavior of
61// |webrtc::PeerConnection|, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
62
Steve Anton9158ef62017-11-27 13:01:52 -080063namespace webrtc {
64
65using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
66using ::testing::ElementsAre;
67using ::testing::UnorderedElementsAre;
Steve Anton3172c032018-05-03 15:30:18 -070068using ::testing::Values;
Henrik Boström933d8b02017-10-10 10:05:16 -070069
Henrik Boström31638672017-11-23 17:48:32 +010070const uint32_t kDefaultTimeout = 10000u;
71
72template <typename MethodFunctor>
73class OnSuccessObserver : public rtc::RefCountedObject<
74 webrtc::SetRemoteDescriptionObserverInterface> {
75 public:
76 explicit OnSuccessObserver(MethodFunctor on_success)
77 : on_success_(std::move(on_success)) {}
78
79 // webrtc::SetRemoteDescriptionObserverInterface implementation.
80 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
81 RTC_CHECK(error.ok());
82 on_success_();
83 }
84
85 private:
86 MethodFunctor on_success_;
87};
88
Steve Anton3172c032018-05-03 15:30:18 -070089class PeerConnectionRtpBaseTest : public testing::Test {
Henrik Boström933d8b02017-10-10 10:05:16 -070090 public:
Steve Anton3172c032018-05-03 15:30:18 -070091 explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics)
92 : sdp_semantics_(sdp_semantics),
93 pc_factory_(
Steve Anton9158ef62017-11-27 13:01:52 -080094 CreatePeerConnectionFactory(rtc::Thread::Current(),
95 rtc::Thread::Current(),
96 rtc::Thread::Current(),
97 FakeAudioCaptureModule::Create(),
98 CreateBuiltinAudioEncoderFactory(),
99 CreateBuiltinAudioDecoderFactory(),
Anders Carlsson67537952018-05-03 11:28:29 +0200100 CreateBuiltinVideoEncoderFactory(),
101 CreateBuiltinVideoDecoderFactory(),
102 nullptr /* audio_mixer */,
Qingsi Wang7fc821d2018-07-12 12:54:53 -0700103 nullptr /* audio_processing */)) {
104 webrtc::metrics::Reset();
105 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700106
Steve Anton9158ef62017-11-27 13:01:52 -0800107 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
108 return CreatePeerConnection(RTCConfiguration());
109 }
110
Steve Antone831b8c2018-02-01 12:22:16 -0800111 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
112 RTCConfiguration config;
113 config.sdp_semantics = SdpSemantics::kPlanB;
Steve Anton3172c032018-05-03 15:30:18 -0700114 return CreatePeerConnectionInternal(config);
Steve Antone831b8c2018-02-01 12:22:16 -0800115 }
116
Steve Anton9158ef62017-11-27 13:01:52 -0800117 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
118 RTCConfiguration config;
119 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
Steve Anton3172c032018-05-03 15:30:18 -0700120 return CreatePeerConnectionInternal(config);
Steve Anton9158ef62017-11-27 13:01:52 -0800121 }
122
123 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
124 const RTCConfiguration& config) {
Steve Anton3172c032018-05-03 15:30:18 -0700125 RTCConfiguration modified_config = config;
126 modified_config.sdp_semantics = sdp_semantics_;
127 return CreatePeerConnectionInternal(modified_config);
128 }
129
130 protected:
131 const SdpSemantics sdp_semantics_;
132 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
133
134 private:
135 // Private so that tests don't accidentally bypass the SdpSemantics
136 // adjustment.
137 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal(
138 const RTCConfiguration& config) {
Karl Wiberg918f50c2018-07-05 11:40:33 +0200139 auto observer = absl::make_unique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -0700140 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
141 observer.get());
Yves Gerey4e933292018-10-31 15:36:05 +0100142 EXPECT_TRUE(pc.get());
143 observer->SetPeerConnectionInterface(pc.get());
Karl Wiberg918f50c2018-07-05 11:40:33 +0200144 return absl::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
145 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -0700146 }
Steve Anton3172c032018-05-03 15:30:18 -0700147};
Henrik Boström933d8b02017-10-10 10:05:16 -0700148
Steve Anton3172c032018-05-03 15:30:18 -0700149class PeerConnectionRtpTest
150 : public PeerConnectionRtpBaseTest,
151 public ::testing::WithParamInterface<SdpSemantics> {
Henrik Boström933d8b02017-10-10 10:05:16 -0700152 protected:
Steve Anton3172c032018-05-03 15:30:18 -0700153 PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {}
154};
155
156class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest {
157 protected:
158 PeerConnectionRtpTestPlanB()
159 : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {}
160};
161
162class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest {
163 protected:
164 PeerConnectionRtpTestUnifiedPlan()
165 : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {}
Henrik Boström933d8b02017-10-10 10:05:16 -0700166};
167
Henrik Boström31638672017-11-23 17:48:32 +0100168// These tests cover |webrtc::PeerConnectionObserver| callbacks firing upon
169// setting the remote description.
Henrik Boström31638672017-11-23 17:48:32 +0100170
Steve Anton3172c032018-05-03 15:30:18 -0700171TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700172 auto caller = CreatePeerConnection();
173 auto callee = CreatePeerConnection();
174
Steve Anton3172c032018-05-03 15:30:18 -0700175 ASSERT_TRUE(caller->AddAudioTrack("audio_track"));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700176 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700177
Henrik Boström31638672017-11-23 17:48:32 +0100178 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700179 const auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100180 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Steve Anton3172c032018-05-03 15:30:18 -0700181
182 if (sdp_semantics_ == SdpSemantics::kPlanB) {
183 // Since we are not supporting the no stream case with Plan B, there should
184 // be a generated stream, even though we didn't set one with AddTrack.
185 ASSERT_EQ(1u, add_track_event.streams.size());
186 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
187 } else {
188 EXPECT_EQ(0u, add_track_event.streams.size());
189 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700190}
191
Steve Anton3172c032018-05-03 15:30:18 -0700192TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700193 auto caller = CreatePeerConnection();
194 auto callee = CreatePeerConnection();
195
Steve Anton3172c032018-05-03 15:30:18 -0700196 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700197 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700198
Henrik Boström31638672017-11-23 17:48:32 +0100199 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100200 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100201 ASSERT_EQ(add_track_event.streams.size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700202 EXPECT_EQ("audio_stream", add_track_event.streams[0]->id());
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100203 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
204 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700205}
206
Steve Anton3172c032018-05-03 15:30:18 -0700207TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700208 auto caller = CreatePeerConnection();
209 auto callee = CreatePeerConnection();
210
Steve Anton3172c032018-05-03 15:30:18 -0700211 auto sender = caller->AddAudioTrack("audio_track", {});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700212 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100213 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700214 ASSERT_TRUE(
215 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
216
Henrik Boström933d8b02017-10-10 10:05:16 -0700217 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700218 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700219
Henrik Boström31638672017-11-23 17:48:32 +0100220 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700221 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
222 callee->observer()->remove_track_events_);
223}
224
Steve Anton3172c032018-05-03 15:30:18 -0700225TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700226 auto caller = CreatePeerConnection();
227 auto callee = CreatePeerConnection();
228
Steve Anton3172c032018-05-03 15:30:18 -0700229 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700230 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100231 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700232 ASSERT_TRUE(
233 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
234
Henrik Boström933d8b02017-10-10 10:05:16 -0700235 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700236 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700237
Henrik Boström31638672017-11-23 17:48:32 +0100238 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700239 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
240 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700241 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700242}
243
Steve Anton3172c032018-05-03 15:30:18 -0700244TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700245 auto caller = CreatePeerConnection();
246 auto callee = CreatePeerConnection();
247
Seth Hampson845e8782018-03-02 11:34:10 -0800248 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700249 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
250 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700251 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100252 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Steve Anton3172c032018-05-03 15:30:18 -0700253 ASSERT_TRUE(
254 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700255
256 // Remove "audio_track1".
257 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700258 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100259 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700260 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800261 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700262 callee->observer()->add_track_events_[0].receiver},
263 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700264 ASSERT_EQ(1u, callee->observer()->remote_streams()->count());
265 ASSERT_TRUE(
266 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700267
268 // Remove "audio_track2".
269 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700270 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100271 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700272 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
273 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700274 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700275}
276
Seth Hampson5b4f0752018-04-02 16:31:36 -0700277// Tests the edge case that if a stream ID changes for a given track that both
278// OnRemoveTrack and OnAddTrack is fired.
Steve Anton3172c032018-05-03 15:30:18 -0700279TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700280 RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) {
281 auto caller = CreatePeerConnection();
282 auto callee = CreatePeerConnection();
283
284 const char kStreamId1[] = "stream1";
285 const char kStreamId2[] = "stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700286 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700287 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700288 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
289
290 // Change the stream ID of the sender in the session description.
291 auto offer = caller->CreateOfferAndSetAsLocal();
Steve Anton3172c032018-05-03 15:30:18 -0700292 auto* audio_desc =
293 cricket::GetFirstAudioContentDescription(offer->description());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700294 ASSERT_EQ(audio_desc->mutable_streams().size(), 1u);
295 audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2});
Steve Anton3172c032018-05-03 15:30:18 -0700296 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700297
298 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
299 EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(),
300 kStreamId2);
301 ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u);
302 EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(),
303 kStreamId1);
304}
305
Steve Anton8b815cd2018-02-16 16:14:42 -0800306// Tests that setting a remote description with sending transceivers will fire
307// the OnTrack callback for each transceiver and setting a remote description
Seth Hampson5b4f0752018-04-02 16:31:36 -0700308// with receive only transceivers will not call OnTrack. One transceiver is
309// created without any stream_ids, while the other is created with multiple
310// stream_ids.
Steve Anton3172c032018-05-03 15:30:18 -0700311TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) {
Seth Hampson5b4f0752018-04-02 16:31:36 -0700312 const std::string kStreamId1 = "video_stream1";
313 const std::string kStreamId2 = "video_stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700314 auto caller = CreatePeerConnection();
315 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800316
317 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Seth Hampson5b4f0752018-04-02 16:31:36 -0700318 RtpTransceiverInit video_transceiver_init;
319 video_transceiver_init.stream_ids = {kStreamId1, kStreamId2};
320 auto video_transceiver =
321 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init);
Steve Anton8b815cd2018-02-16 16:14:42 -0800322
323 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
324
325 ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size());
326 ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size());
327 EXPECT_EQ(audio_transceiver->mid(),
328 callee->pc()->GetTransceivers()[0]->mid());
329 EXPECT_EQ(video_transceiver->mid(),
330 callee->pc()->GetTransceivers()[1]->mid());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700331 std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams =
332 callee->pc()->GetTransceivers()[0]->receiver()->streams();
333 std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams =
334 callee->pc()->GetTransceivers()[1]->receiver()->streams();
335 ASSERT_EQ(0u, audio_streams.size());
336 ASSERT_EQ(2u, video_streams.size());
337 EXPECT_EQ(kStreamId1, video_streams[0]->id());
338 EXPECT_EQ(kStreamId2, video_streams[1]->id());
Steve Anton8b815cd2018-02-16 16:14:42 -0800339}
340
341// Test that doing additional offer/answer exchanges with no changes to tracks
342// will cause no additional OnTrack calls after the tracks have been negotiated.
Steve Anton3172c032018-05-03 15:30:18 -0700343TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) {
344 auto caller = CreatePeerConnection();
345 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800346
347 caller->AddAudioTrack("audio");
348 callee->AddAudioTrack("audio");
349
350 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
351 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
352 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
353
354 // If caller reoffers with no changes expect no additional OnTrack calls.
355 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
356 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
357 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
358
359 // Also if callee reoffers with no changes expect no additional OnTrack calls.
360 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
361 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
362 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
363}
364
365// Test that OnTrack is called when the transceiver direction changes to send
366// the track.
Steve Anton3172c032018-05-03 15:30:18 -0700367TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) {
368 auto caller = CreatePeerConnection();
369 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800370
371 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
372 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
373 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
374 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
375 EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size());
376
377 transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
378 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
379 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
380 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
381
382 // If the direction changes but it is still receiving on the remote side, then
383 // OnTrack should not be fired again.
384 transceiver->SetDirection(RtpTransceiverDirection::kSendRecv);
385 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
386 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
387 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
388}
389
390// Test that OnTrack is called twice when a sendrecv call is started, the callee
391// changes the direction to inactive, then changes it back to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -0700392TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) {
393 auto caller = CreatePeerConnection();
394 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800395
396 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
397
398 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
399 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
400 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
401
402 // Put the call on hold by no longer receiving the track.
403 callee->pc()->GetTransceivers()[0]->SetDirection(
404 RtpTransceiverDirection::kInactive);
405
406 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
407 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
408 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
409
410 // Resume the call by changing the direction to recvonly. This should call
411 // OnTrack again on the callee side.
412 callee->pc()->GetTransceivers()[0]->SetDirection(
413 RtpTransceiverDirection::kRecvOnly);
414
415 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
416 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
417 EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size());
418}
419
Steve Anton3172c032018-05-03 15:30:18 -0700420// Test that setting a remote offer twice with no answer in the middle results
Steve Anton0f5400a2018-07-17 14:25:36 -0700421// in OnAddTrack being fired only once.
Steve Anton3172c032018-05-03 15:30:18 -0700422TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700423 ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) {
Henrik Boström31638672017-11-23 17:48:32 +0100424 auto caller = CreatePeerConnection();
425 auto callee = CreatePeerConnection();
426
Steve Anton3172c032018-05-03 15:30:18 -0700427 caller->AddAudioTrack("audio_track", {});
428
429 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
430 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
431
432 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Steve Anton0f5400a2018-07-17 14:25:36 -0700433 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700434}
435
436// Test that setting a remote offer twice with no answer in the middle and the
437// track being removed between the two offers results in OnAddTrack being called
Steve Anton0f5400a2018-07-17 14:25:36 -0700438// once the first time and OnRemoveTrack being called once the second time.
Steve Anton3172c032018-05-03 15:30:18 -0700439TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700440 ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) {
Steve Anton3172c032018-05-03 15:30:18 -0700441 auto caller = CreatePeerConnection();
442 auto callee = CreatePeerConnection();
443
444 auto sender = caller->AddAudioTrack("audio_track", {});
445
446 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
447 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700448 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700449
450 caller->pc()->RemoveTrack(sender);
451
452 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
453 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700454 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
455}
456
457// Test that changing the direction from receiving to not receiving between
458// setting the remote offer and creating / setting the local answer results in
459// a remove track event when SetLocalDescription is called.
460TEST_F(PeerConnectionRtpTestUnifiedPlan,
461 ChangeDirectionInAnswerResultsInRemoveTrackEvent) {
462 auto caller = CreatePeerConnection();
463 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
464 auto callee = CreatePeerConnection();
465 callee->AddAudioTrack("audio_track", {});
466
467 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
468 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700469 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700470
471 auto callee_transceiver = callee->pc()->GetTransceivers()[0];
472 callee_transceiver->SetDirection(RtpTransceiverDirection::kSendOnly);
473
474 ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer()));
475 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
476 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700477}
478
479// These tests examine the state of the peer connection as a result of
480// performing SetRemoteDescription().
481
482TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) {
483 auto caller = CreatePeerConnection();
484 auto callee = CreatePeerConnection();
485
486 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700487 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100488
489 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
490 auto receiver_added = callee->pc()->GetReceivers()[0];
491 EXPECT_EQ("audio_track", receiver_added->track()->id());
Steve Anton3172c032018-05-03 15:30:18 -0700492
493 if (sdp_semantics_ == SdpSemantics::kPlanB) {
494 // Since we are not supporting the no stream case with Plan B, there should
495 // be a generated stream, even though we didn't set one with AddTrack.
496 ASSERT_EQ(1u, receiver_added->streams().size());
497 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
498 } else {
499 EXPECT_EQ(0u, receiver_added->streams().size());
500 }
Henrik Boström31638672017-11-23 17:48:32 +0100501}
502
Steve Anton3172c032018-05-03 15:30:18 -0700503TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100504 auto caller = CreatePeerConnection();
505 auto callee = CreatePeerConnection();
506
Steve Anton3172c032018-05-03 15:30:18 -0700507 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700508 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100509
510 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
511 auto receiver_added = callee->pc()->GetReceivers()[0];
512 EXPECT_EQ("audio_track", receiver_added->track()->id());
513 EXPECT_EQ(receiver_added->streams().size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700514 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id());
Henrik Boström31638672017-11-23 17:48:32 +0100515 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
516}
517
Steve Anton3172c032018-05-03 15:30:18 -0700518TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100519 auto caller = CreatePeerConnection();
520 auto callee = CreatePeerConnection();
521
Steve Anton3172c032018-05-03 15:30:18 -0700522 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100523 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700524 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
525
Henrik Boström31638672017-11-23 17:48:32 +0100526 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
527 auto receiver = callee->pc()->GetReceivers()[0];
528 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700529 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100530
Steve Anton3172c032018-05-03 15:30:18 -0700531 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
532 // With Unified Plan the receiver stays but the transceiver transitions to
533 // inactive.
534 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
535 EXPECT_EQ(RtpTransceiverDirection::kInactive,
536 callee->pc()->GetTransceivers()[0]->current_direction());
537 } else {
538 // With Plan B the receiver is removed.
539 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
540 }
Henrik Boström31638672017-11-23 17:48:32 +0100541}
542
Steve Anton3172c032018-05-03 15:30:18 -0700543TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100544 auto caller = CreatePeerConnection();
545 auto callee = CreatePeerConnection();
546
Steve Anton3172c032018-05-03 15:30:18 -0700547 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100548 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700549 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100550 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
551 auto receiver = callee->pc()->GetReceivers()[0];
552 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
Steve Anton3172c032018-05-03 15:30:18 -0700553 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100554
Steve Anton3172c032018-05-03 15:30:18 -0700555 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
556 // With Unified Plan the receiver stays but the transceiver transitions to
557 // inactive.
558 EXPECT_EQ(1u, callee->pc()->GetReceivers().size());
559 EXPECT_EQ(RtpTransceiverDirection::kInactive,
560 callee->pc()->GetTransceivers()[0]->current_direction());
561 } else {
562 // With Plan B the receiver is removed.
563 EXPECT_EQ(0u, callee->pc()->GetReceivers().size());
564 }
Henrik Boström31638672017-11-23 17:48:32 +0100565}
566
Steve Anton3172c032018-05-03 15:30:18 -0700567TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100568 auto caller = CreatePeerConnection();
569 auto callee = CreatePeerConnection();
570
Seth Hampson845e8782018-03-02 11:34:10 -0800571 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700572 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
573 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
574 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
575 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
Henrik Boström31638672017-11-23 17:48:32 +0100576
577 // Remove "audio_track1".
578 EXPECT_TRUE(caller->pc()->RemoveTrack(sender1));
Steve Anton3172c032018-05-03 15:30:18 -0700579 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
580
581 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
582 // With Unified Plan the receiver stays but the transceiver transitions to
583 // inactive.
584 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
585 auto transceiver = callee->pc()->GetTransceivers()[0];
586 EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id());
587 EXPECT_EQ(RtpTransceiverDirection::kInactive,
588 transceiver->current_direction());
589 } else {
590 // With Plan B the receiver is removed.
591 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
592 EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id());
593 }
Henrik Boström31638672017-11-23 17:48:32 +0100594
595 // Remove "audio_track2".
596 EXPECT_TRUE(caller->pc()->RemoveTrack(sender2));
Steve Anton3172c032018-05-03 15:30:18 -0700597 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
598
599 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
600 // With Unified Plan the receiver stays but the transceiver transitions to
601 // inactive.
602 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
603 auto transceiver = callee->pc()->GetTransceivers()[1];
604 EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id());
605 EXPECT_EQ(RtpTransceiverDirection::kInactive,
606 transceiver->current_direction());
607 } else {
608 // With Plan B the receiver is removed.
609 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
610 }
Henrik Boström31638672017-11-23 17:48:32 +0100611}
612
Florent Castelliabe301f2018-06-12 18:33:49 +0200613TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) {
614 auto caller = CreatePeerConnection();
615 auto callee = CreatePeerConnection();
616 auto sender = caller->AddAudioTrack("audio_track");
617 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
618
619 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
620 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
621
622 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
623 auto receiver = callee->pc()->GetReceivers()[0];
624 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
625}
626
627TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) {
628 auto caller = CreatePeerConnection();
629 auto callee = CreatePeerConnection();
630 auto sender = caller->AddVideoTrack("video_track");
631 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
632
633 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
634 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
635
636 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
637 auto receiver = callee->pc()->GetReceivers()[0];
638 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
639}
640
Henrik Boström31638672017-11-23 17:48:32 +0100641// Invokes SetRemoteDescription() twice in a row without synchronizing the two
642// calls and examine the state of the peer connection inside the callbacks to
643// ensure that the second call does not occur prematurely, contaminating the
644// state of the peer connection of the first callback.
Steve Anton3172c032018-05-03 15:30:18 -0700645TEST_F(PeerConnectionRtpTestPlanB,
Henrik Boström31638672017-11-23 17:48:32 +0100646 StatesCorrelateWithSetRemoteDescriptionCall) {
647 auto caller = CreatePeerConnection();
648 auto callee = CreatePeerConnection();
649
Henrik Boström31638672017-11-23 17:48:32 +0100650 // Create SDP for adding a track and for removing it. This will be used in the
651 // first and second SetRemoteDescription() calls.
Steve Anton3172c032018-05-03 15:30:18 -0700652 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100653 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
654 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
655 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
656
657 // In the first SetRemoteDescription() callback, check that we have a
658 // receiver for the track.
659 auto pc = callee->pc();
660 bool srd1_callback_called = false;
661 auto srd1_callback = [&srd1_callback_called, &pc]() {
662 EXPECT_EQ(pc->GetReceivers().size(), 1u);
663 srd1_callback_called = true;
664 };
665
666 // In the second SetRemoteDescription() callback, check that the receiver has
667 // been removed.
668 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
669 // Instead, the transceiver owning the receiver will become inactive.
670 // https://crbug.com/webrtc/7600
671 bool srd2_callback_called = false;
672 auto srd2_callback = [&srd2_callback_called, &pc]() {
673 EXPECT_TRUE(pc->GetReceivers().empty());
674 srd2_callback_called = true;
675 };
676
677 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
678 // calls. The callbacks verify that the two calls are synchronized, as in, the
679 // effects of the second SetRemoteDescription() call must not have happened by
680 // the time the first callback is invoked. If it has then the receiver that is
681 // added as a result of the first SetRemoteDescription() call will already
682 // have been removed as a result of the second SetRemoteDescription() call
683 // when the first callback is invoked.
684 callee->pc()->SetRemoteDescription(
685 std::move(srd1_sdp),
686 new OnSuccessObserver<decltype(srd1_callback)>(srd1_callback));
687 callee->pc()->SetRemoteDescription(
688 std::move(srd2_sdp),
689 new OnSuccessObserver<decltype(srd2_callback)>(srd2_callback));
690 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
691 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
692}
693
Seth Hampson5897a6e2018-04-03 11:16:33 -0700694// Tests that a remote track is created with the signaled MSIDs when they are
695// communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc
696// lines).
Steve Anton3172c032018-05-03 15:30:18 -0700697TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) {
698 auto caller = CreatePeerConnection();
699 auto callee = CreatePeerConnection();
Seth Hampson5897a6e2018-04-03 11:16:33 -0700700 const char kStreamId1[] = "stream1";
701 const char kStreamId2[] = "stream2";
702 caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
703 {kStreamId1, kStreamId2});
704
705 auto offer = caller->CreateOfferAndSetAsLocal();
706 // Munge the offer to take out everything but the stream_ids.
707 auto contents = offer->description()->contents();
708 ASSERT_TRUE(!contents.empty());
709 ASSERT_TRUE(!contents[0].media_description()->streams().empty());
710 std::vector<std::string> stream_ids =
711 contents[0].media_description()->streams()[0].stream_ids();
712 contents[0].media_description()->mutable_streams().clear();
713 cricket::StreamParams new_stream;
714 new_stream.set_stream_ids(stream_ids);
715 contents[0].media_description()->AddStream(new_stream);
716
717 // Set the remote description and verify that the streams were added to the
718 // receiver correctly.
719 ASSERT_TRUE(
720 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
721 auto receivers = callee->pc()->GetReceivers();
722 ASSERT_EQ(receivers.size(), 1u);
723 ASSERT_EQ(receivers[0]->streams().size(), 2u);
724 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1);
725 EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2);
726}
727
Seth Hampson5b4f0752018-04-02 16:31:36 -0700728// Tests that with Unified Plan if the the stream id changes for a track when
729// when setting a new remote description, that the media stream is updated
730// appropriately for the receiver.
Steve Anton0f5400a2018-07-17 14:25:36 -0700731// TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix
732// test.
733TEST_F(PeerConnectionRtpTestUnifiedPlan,
734 DISABLED_RemoteStreamIdChangesUpdatesReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700735 auto caller = CreatePeerConnection();
736 auto callee = CreatePeerConnection();
Seth Hampson5b4f0752018-04-02 16:31:36 -0700737
738 const char kStreamId1[] = "stream1";
739 const char kStreamId2[] = "stream2";
Steve Anton0f5400a2018-07-17 14:25:36 -0700740 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700741 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700742 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
743
744 // Change the stream id of the sender in the session description.
745 auto offer = caller->CreateOfferAndSetAsLocal();
746 auto contents = offer->description()->contents();
747 ASSERT_EQ(contents.size(), 1u);
748 ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u);
749 contents[0].media_description()->mutable_streams()[0].set_stream_ids(
750 {kStreamId2});
751
Steve Anton0f5400a2018-07-17 14:25:36 -0700752 // Set the remote description and verify that the stream was updated
753 // properly.
754 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700755 auto receivers = callee->pc()->GetReceivers();
756 ASSERT_EQ(receivers.size(), 1u);
757 ASSERT_EQ(receivers[0]->streams().size(), 1u);
758 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2);
759}
760
761// This tests a regression caught by a downstream client, that occured when
762// applying a remote description with a SessionDescription object that
763// contained StreamParams that didn't have ids. Although there were multiple
764// remote audio senders, FindSenderInfo didn't find them as unique, because
765// it looked up by StreamParam.id, which none had. This meant only one
766// AudioRtpReceiver was created, as opposed to one for each remote sender.
Steve Anton3172c032018-05-03 15:30:18 -0700767TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700768 MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) {
769 auto caller = CreatePeerConnection();
770 auto callee = CreatePeerConnection();
771
772 const char kStreamId1[] = "stream1";
773 const char kStreamId2[] = "stream2";
774 caller->AddAudioTrack("audio_track1", {kStreamId1});
775 caller->AddAudioTrack("audio_track2", {kStreamId2});
776
777 auto offer = caller->CreateOfferAndSetAsLocal();
778 auto mutable_streams =
779 cricket::GetFirstAudioContentDescription(offer->description())
780 ->mutable_streams();
781 ASSERT_EQ(mutable_streams.size(), 2u);
782 // Clear the IDs in the StreamParams.
783 mutable_streams[0].id.clear();
784 mutable_streams[1].id.clear();
785 ASSERT_TRUE(
786 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
787
788 auto receivers = callee->pc()->GetReceivers();
789 ASSERT_EQ(receivers.size(), 2u);
790 ASSERT_EQ(receivers[0]->streams().size(), 1u);
791 EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id());
792 ASSERT_EQ(receivers[1]->streams().size(), 1u);
793 EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id());
794}
795
Henrik Boström31638672017-11-23 17:48:32 +0100796// Tests for the legacy SetRemoteDescription() function signature.
Henrik Boström31638672017-11-23 17:48:32 +0100797
798// Sanity test making sure the callback is invoked.
Steve Anton3172c032018-05-03 15:30:18 -0700799TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) {
Henrik Boström31638672017-11-23 17:48:32 +0100800 auto caller = CreatePeerConnection();
801 auto callee = CreatePeerConnection();
802
803 std::string error;
804 ASSERT_TRUE(
805 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
806}
807
808// Verifies legacy behavior: The observer is not called if if the peer
809// connection is destroyed because the asynchronous callback is executed in the
810// peer connection's message handler.
Steve Anton3172c032018-05-03 15:30:18 -0700811TEST_P(PeerConnectionRtpTest,
812 LegacyObserverNotCalledIfPeerConnectionDereferenced) {
Henrik Boström31638672017-11-23 17:48:32 +0100813 auto caller = CreatePeerConnection();
814 auto callee = CreatePeerConnection();
815
816 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
817 new rtc::RefCountedObject<webrtc::MockSetSessionDescriptionObserver>();
818
819 auto offer = caller->CreateOfferAndSetAsLocal();
820 callee->pc()->SetRemoteDescription(observer, offer.release());
821 callee = nullptr;
822 rtc::Thread::Current()->ProcessMessages(0);
823 EXPECT_FALSE(observer->called());
824}
825
Steve Antonf9381f02017-12-14 10:23:57 -0800826// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800827
828// Test that by default there are no transceivers with Unified Plan.
Steve Anton3172c032018-05-03 15:30:18 -0700829TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) {
830 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800831 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
832}
833
834// Test that a transceiver created with the audio kind has the correct initial
835// properties.
Steve Anton3172c032018-05-03 15:30:18 -0700836TEST_F(PeerConnectionRtpTestUnifiedPlan,
837 AddTransceiverHasCorrectInitProperties) {
838 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800839
840 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200841 EXPECT_EQ(absl::nullopt, transceiver->mid());
Steve Anton9158ef62017-11-27 13:01:52 -0800842 EXPECT_FALSE(transceiver->stopped());
843 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200844 EXPECT_EQ(absl::nullopt, transceiver->current_direction());
Steve Anton9158ef62017-11-27 13:01:52 -0800845}
846
847// Test that adding a transceiver with the audio kind creates an audio sender
848// and audio receiver with the receiver having a live audio track.
Steve Anton3172c032018-05-03 15:30:18 -0700849TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800850 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700851 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800852
853 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Steve Anton69470252018-02-09 11:43:08 -0800854 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800855
856 ASSERT_TRUE(transceiver->sender());
857 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
858
859 ASSERT_TRUE(transceiver->receiver());
860 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
861
862 auto track = transceiver->receiver()->track();
863 ASSERT_TRUE(track);
864 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
865 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
866}
867
868// Test that adding a transceiver with the video kind creates an video sender
869// and video receiver with the receiver having a live video track.
Steve Anton3172c032018-05-03 15:30:18 -0700870TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800871 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700872 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800873
874 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
Steve Anton69470252018-02-09 11:43:08 -0800875 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800876
877 ASSERT_TRUE(transceiver->sender());
878 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
879
880 ASSERT_TRUE(transceiver->receiver());
881 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
882
883 auto track = transceiver->receiver()->track();
884 ASSERT_TRUE(track);
885 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
886 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
887}
888
889// Test that after a call to AddTransceiver, the transceiver shows in
890// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
891// transceiver's receiver shows in GetReceivers().
Steve Anton3172c032018-05-03 15:30:18 -0700892TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) {
893 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800894
895 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
896 EXPECT_EQ(
897 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
898 caller->pc()->GetTransceivers());
899 EXPECT_EQ(
900 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
901 transceiver->sender()},
902 caller->pc()->GetSenders());
903 EXPECT_EQ(
904 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
905 transceiver->receiver()},
906 caller->pc()->GetReceivers());
907}
908
909// Test that the direction passed in through the AddTransceiver init parameter
910// is set in the returned transceiver.
Steve Anton3172c032018-05-03 15:30:18 -0700911TEST_F(PeerConnectionRtpTestUnifiedPlan,
912 AddTransceiverWithDirectionIsReflected) {
913 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800914
915 RtpTransceiverInit init;
916 init.direction = RtpTransceiverDirection::kSendOnly;
917 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
918 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
919}
920
Steve Anton9158ef62017-11-27 13:01:52 -0800921// Test that calling AddTransceiver with a track creates a transceiver which has
922// its sender's track set to the passed-in track.
Steve Anton3172c032018-05-03 15:30:18 -0700923TEST_F(PeerConnectionRtpTestUnifiedPlan,
924 AddTransceiverWithTrackCreatesSenderWithTrack) {
925 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800926
927 auto audio_track = caller->CreateAudioTrack("audio track");
928 auto transceiver = caller->AddTransceiver(audio_track);
929
930 auto sender = transceiver->sender();
931 ASSERT_TRUE(sender->track());
932 EXPECT_EQ(audio_track, sender->track());
933
934 auto receiver = transceiver->receiver();
935 ASSERT_TRUE(receiver->track());
936 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
937 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
938 receiver->track()->state());
939}
940
941// Test that calling AddTransceiver twice with the same track creates distinct
942// transceivers, senders with the same track.
Steve Anton3172c032018-05-03 15:30:18 -0700943TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800944 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
Steve Anton3172c032018-05-03 15:30:18 -0700945 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800946
947 auto audio_track = caller->CreateAudioTrack("audio track");
948
949 auto transceiver1 = caller->AddTransceiver(audio_track);
950 auto transceiver2 = caller->AddTransceiver(audio_track);
951
952 EXPECT_NE(transceiver1, transceiver2);
953
954 auto sender1 = transceiver1->sender();
955 auto sender2 = transceiver2->sender();
956 EXPECT_NE(sender1, sender2);
957 EXPECT_EQ(audio_track, sender1->track());
958 EXPECT_EQ(audio_track, sender2->track());
959
960 EXPECT_THAT(caller->pc()->GetTransceivers(),
961 UnorderedElementsAre(transceiver1, transceiver2));
962 EXPECT_THAT(caller->pc()->GetSenders(),
963 UnorderedElementsAre(sender1, sender2));
964}
965
Steve Anton3fe1b152017-12-12 10:20:08 -0800966// RtpTransceiver error handling tests.
967
Steve Anton3172c032018-05-03 15:30:18 -0700968TEST_F(PeerConnectionRtpTestUnifiedPlan,
969 AddTransceiverWithInvalidKindReturnsError) {
970 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800971
972 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
973 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
974}
975
Steve Anton3172c032018-05-03 15:30:18 -0700976TEST_F(PeerConnectionRtpTestUnifiedPlan,
977 CanClosePeerConnectionWithoutCrashing) {
978 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -0800979
980 caller->pc()->Close();
981}
982
Steve Antonf9381f02017-12-14 10:23:57 -0800983// Unified Plan AddTrack tests.
984
Steve Antonf9381f02017-12-14 10:23:57 -0800985// Test that adding an audio track creates a new audio RtpSender with the given
986// track.
Steve Anton3172c032018-05-03 15:30:18 -0700987TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) {
988 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -0800989
990 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -0800991 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -0800992 ASSERT_TRUE(sender);
993
994 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
995 EXPECT_EQ(audio_track, sender->track());
996}
997
998// Test that adding a video track creates a new video RtpSender with the given
999// track.
Steve Anton3172c032018-05-03 15:30:18 -07001000TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) {
1001 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001002
1003 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001004 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001005 ASSERT_TRUE(sender);
1006
1007 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
1008 EXPECT_EQ(video_track, sender->track());
1009}
1010
1011// Test that adding a track to a new PeerConnection creates an RtpTransceiver
1012// with the sender that AddTrack returns and in the sendrecv direction.
Steve Anton3172c032018-05-03 15:30:18 -07001013TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) {
1014 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001015
1016 auto sender = caller->AddAudioTrack("a");
1017 ASSERT_TRUE(sender);
1018
1019 auto transceivers = caller->pc()->GetTransceivers();
1020 ASSERT_EQ(1u, transceivers.size());
1021 EXPECT_EQ(sender, transceivers[0]->sender());
1022 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
1023}
1024
1025// Test that if a transceiver of the same type but no track had been added to
1026// the PeerConnection and later a call to AddTrack is made, the resulting sender
1027// is the transceiver's sender and the sender's track is the newly-added track.
Steve Anton3172c032018-05-03 15:30:18 -07001028TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) {
1029 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001030
1031 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1032 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001033 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001034 ASSERT_TRUE(sender);
1035
1036 auto transceivers = caller->pc()->GetTransceivers();
1037 ASSERT_EQ(1u, transceivers.size());
1038 EXPECT_EQ(transceiver, transceivers[0]);
1039 EXPECT_EQ(sender, transceiver->sender());
1040 EXPECT_EQ(audio_track, sender->track());
1041}
1042
1043// Test that adding two tracks to a new PeerConnection creates two
1044// RtpTransceivers in the same order.
Steve Anton3172c032018-05-03 15:30:18 -07001045TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) {
1046 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001047
1048 auto sender1 = caller->AddAudioTrack("a");
1049 auto sender2 = caller->AddVideoTrack("v");
1050 ASSERT_TRUE(sender2);
1051
1052 auto transceivers = caller->pc()->GetTransceivers();
1053 ASSERT_EQ(2u, transceivers.size());
1054 EXPECT_EQ(sender1, transceivers[0]->sender());
1055 EXPECT_EQ(sender2, transceivers[1]->sender());
1056}
1057
1058// Test that if there are multiple transceivers with no sending track then a
1059// later call to AddTrack will use the one of the same type as the newly-added
1060// track.
Steve Anton3172c032018-05-03 15:30:18 -07001061TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) {
1062 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001063
1064 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1065 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
1066 auto sender = caller->AddVideoTrack("v");
1067
1068 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
1069 EXPECT_NE(sender, audio_transceiver->sender());
1070 EXPECT_EQ(sender, video_transceiver->sender());
1071}
1072
1073// Test that if the only transceivers that do not have a sending track have a
1074// different type from the added track, then AddTrack will create a new
1075// transceiver for the track.
Steve Anton3172c032018-05-03 15:30:18 -07001076TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001077 AddTrackDoesNotReuseTransceiverOfWrongType) {
Steve Anton3172c032018-05-03 15:30:18 -07001078 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001079
1080 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1081 auto sender = caller->AddVideoTrack("v");
1082
1083 auto transceivers = caller->pc()->GetTransceivers();
1084 ASSERT_EQ(2u, transceivers.size());
1085 EXPECT_NE(sender, transceivers[0]->sender());
1086 EXPECT_EQ(sender, transceivers[1]->sender());
1087}
1088
1089// Test that the first available transceiver is reused by AddTrack when multiple
1090// are available.
Steve Anton3172c032018-05-03 15:30:18 -07001091TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001092 AddTrackReusesFirstMatchingTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001093 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001094
1095 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1096 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1097 auto sender = caller->AddAudioTrack("a");
1098
1099 auto transceivers = caller->pc()->GetTransceivers();
1100 ASSERT_EQ(2u, transceivers.size());
1101 EXPECT_EQ(sender, transceivers[0]->sender());
1102 EXPECT_NE(sender, transceivers[1]->sender());
1103}
1104
1105// Test that a call to AddTrack that reuses a transceiver will change the
1106// direction from inactive to sendonly.
Steve Anton3172c032018-05-03 15:30:18 -07001107TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001108 AddTrackChangesDirectionFromInactiveToSendOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001109 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001110
1111 RtpTransceiverInit init;
1112 init.direction = RtpTransceiverDirection::kInactive;
1113 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1114
1115 caller->observer()->clear_negotiation_needed();
1116 ASSERT_TRUE(caller->AddAudioTrack("a"));
1117 EXPECT_TRUE(caller->observer()->negotiation_needed());
1118
1119 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1120}
1121
1122// Test that a call to AddTrack that reuses a transceiver will change the
1123// direction from recvonly to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -07001124TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001125 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
Steve Anton3172c032018-05-03 15:30:18 -07001126 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001127
1128 RtpTransceiverInit init;
1129 init.direction = RtpTransceiverDirection::kRecvOnly;
1130 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1131
1132 caller->observer()->clear_negotiation_needed();
1133 ASSERT_TRUE(caller->AddAudioTrack("a"));
1134 EXPECT_TRUE(caller->observer()->negotiation_needed());
1135
1136 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1137}
1138
Steve Anton3172c032018-05-03 15:30:18 -07001139TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) {
Steve Anton02ee47c2018-01-10 16:26:06 -08001140 const std::string kTrackId = "audio_track";
1141
Steve Anton3172c032018-05-03 15:30:18 -07001142 auto caller = CreatePeerConnection();
Steve Anton02ee47c2018-01-10 16:26:06 -08001143
1144 auto audio_track = caller->CreateAudioTrack(kTrackId);
1145 auto sender = caller->AddTrack(audio_track);
1146
1147 EXPECT_EQ(kTrackId, sender->id());
1148}
1149
Steve Antonf9381f02017-12-14 10:23:57 -08001150// Unified Plan AddTrack error handling.
1151
Steve Anton3172c032018-05-03 15:30:18 -07001152TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) {
1153 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001154
1155 auto audio_track = caller->CreateAudioTrack("a");
1156 caller->pc()->Close();
1157
1158 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001159 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001160 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001161 EXPECT_FALSE(caller->observer()->negotiation_needed());
1162}
1163
Steve Anton3172c032018-05-03 15:30:18 -07001164TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) {
1165 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001166
1167 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001168 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 10:23:57 -08001169
1170 caller->observer()->clear_negotiation_needed();
Yves Gerey665174f2018-06-19 15:03:05 +02001171 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001172 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Steve Antonf9381f02017-12-14 10:23:57 -08001173 EXPECT_FALSE(caller->observer()->negotiation_needed());
1174}
1175
1176// Unified Plan RemoveTrack tests.
1177
1178// Test that calling RemoveTrack on a sender with a previously-added track
1179// clears the sender's track.
Steve Anton3172c032018-05-03 15:30:18 -07001180TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) {
1181 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001182
1183 auto sender = caller->AddAudioTrack("a");
1184 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1185
1186 EXPECT_FALSE(sender->track());
1187}
1188
1189// Test that calling RemoveTrack on a sender where the transceiver is configured
1190// in the sendrecv direction changes the transceiver's direction to recvonly.
Steve Anton3172c032018-05-03 15:30:18 -07001191TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001192 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001193 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001194
1195 RtpTransceiverInit init;
1196 init.direction = RtpTransceiverDirection::kSendRecv;
1197 auto transceiver =
1198 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1199
1200 caller->observer()->clear_negotiation_needed();
1201 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1202 EXPECT_TRUE(caller->observer()->negotiation_needed());
1203
1204 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
1205 EXPECT_TRUE(caller->observer()->renegotiation_needed_);
1206}
1207
1208// Test that calling RemoveTrack on a sender where the transceiver is configured
1209// in the sendonly direction changes the transceiver's direction to inactive.
Steve Anton3172c032018-05-03 15:30:18 -07001210TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001211 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
Steve Anton3172c032018-05-03 15:30:18 -07001212 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001213
1214 RtpTransceiverInit init;
1215 init.direction = RtpTransceiverDirection::kSendOnly;
1216 auto transceiver =
1217 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
1218
1219 caller->observer()->clear_negotiation_needed();
1220 ASSERT_TRUE(caller->pc()->RemoveTrack(transceiver->sender()));
1221 EXPECT_TRUE(caller->observer()->negotiation_needed());
1222
1223 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
1224}
1225
1226// Test that calling RemoveTrack with a sender that has a null track results in
1227// no change in state.
Steve Anton3172c032018-05-03 15:30:18 -07001228TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) {
1229 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001230
1231 auto sender = caller->AddAudioTrack("a");
1232 auto transceiver = caller->pc()->GetTransceivers()[0];
1233 ASSERT_TRUE(sender->SetTrack(nullptr));
1234
1235 caller->observer()->clear_negotiation_needed();
1236 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1237 EXPECT_FALSE(caller->observer()->negotiation_needed());
1238
1239 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1240}
1241
1242// Unified Plan RemoveTrack error handling.
1243
Steve Anton3172c032018-05-03 15:30:18 -07001244TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) {
1245 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001246
1247 auto sender = caller->AddAudioTrack("a");
1248 caller->pc()->Close();
1249
1250 caller->observer()->clear_negotiation_needed();
1251 EXPECT_FALSE(caller->pc()->RemoveTrack(sender));
1252 EXPECT_FALSE(caller->observer()->negotiation_needed());
1253}
1254
Steve Anton3172c032018-05-03 15:30:18 -07001255TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001256 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
Steve Anton3172c032018-05-03 15:30:18 -07001257 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001258
1259 auto sender = caller->AddAudioTrack("a");
1260 ASSERT_TRUE(caller->pc()->RemoveTrack(sender));
1261
1262 caller->observer()->clear_negotiation_needed();
1263 EXPECT_TRUE(caller->pc()->RemoveTrack(sender));
1264 EXPECT_FALSE(caller->observer()->negotiation_needed());
1265}
1266
Steve Anton60b6c1d2018-06-13 11:32:27 -07001267// Test that setting offers that add/remove/add a track repeatedly without
1268// setting the appropriate answer in between works.
1269// These are regression tests for bugs.webrtc.org/9401
1270TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) {
1271 auto caller = CreatePeerConnection();
1272
1273 auto sender1 = caller->AddAudioTrack("audio1");
1274 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1275
1276 caller->pc()->RemoveTrack(sender1);
1277 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1278
1279 // This will re-use the transceiver created by the first AddTrack.
1280 auto sender2 = caller->AddAudioTrack("audio2");
1281 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1282
1283 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1284 EXPECT_EQ(sender1, sender2);
1285}
1286TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) {
1287 auto caller = CreatePeerConnection();
1288
1289 auto sender1 = caller->AddVideoTrack("video1");
1290 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1291
1292 caller->pc()->RemoveTrack(sender1);
1293 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1294
1295 // This will re-use the transceiver created by the first AddTrack.
1296 auto sender2 = caller->AddVideoTrack("video2");
1297 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1298
1299 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1300 EXPECT_EQ(sender1, sender2);
1301}
1302
Steve Anton07563732018-06-26 11:13:50 -07001303// Test that CreateOffer succeeds if two tracks with the same label are added.
1304TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) {
1305 auto caller = CreatePeerConnection();
1306
1307 auto audio_sender = caller->AddAudioTrack("track", {});
1308 auto video_sender = caller->AddVideoTrack("track", {});
1309
1310 EXPECT_TRUE(caller->CreateOffer());
1311
1312 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1313 EXPECT_NE(audio_sender->id(), video_sender->id());
1314}
1315
1316// Test that CreateAnswer succeeds if two tracks with the same label are added.
1317TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) {
1318 auto caller = CreatePeerConnection();
1319 auto callee = CreatePeerConnection();
1320
1321 RtpTransceiverInit recvonly;
1322 recvonly.direction = RtpTransceiverDirection::kRecvOnly;
1323 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly);
1324 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly);
1325
1326 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1327
1328 auto audio_sender = callee->AddAudioTrack("track", {});
1329 auto video_sender = callee->AddVideoTrack("track", {});
1330
1331 EXPECT_TRUE(callee->CreateAnswer());
1332
1333 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1334 EXPECT_NE(audio_sender->id(), video_sender->id());
1335}
1336
1337// Test that calling AddTrack, RemoveTrack and AddTrack again creates a second
1338// m= section with a random sender id (different from the first, now rejected,
1339// m= section).
1340TEST_F(PeerConnectionRtpTestUnifiedPlan,
1341 AddRemoveAddTrackGeneratesNewSenderId) {
1342 auto caller = CreatePeerConnection();
1343 auto callee = CreatePeerConnection();
1344
1345 auto track = caller->CreateVideoTrack("video");
1346 auto sender1 = caller->AddTrack(track);
1347 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1348
1349 caller->pc()->RemoveTrack(sender1);
1350 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1351
1352 auto sender2 = caller->AddTrack(track);
1353
1354 EXPECT_NE(sender1, sender2);
1355 EXPECT_NE(sender1->id(), sender2->id());
1356 std::string sender2_id = sender2->id();
1357
1358 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1359
1360 // The sender's ID should not change after negotiation.
1361 EXPECT_EQ(sender2_id, sender2->id());
1362}
1363
Steve Anton52d86772018-02-20 15:48:12 -08001364// Test that OnRenegotiationNeeded is fired if SetDirection is called on an
1365// active RtpTransceiver with a new direction.
Steve Anton3172c032018-05-03 15:30:18 -07001366TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001367 RenegotiationNeededAfterTransceiverSetDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001368 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001369
1370 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1371
1372 caller->observer()->clear_negotiation_needed();
1373 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1374 EXPECT_TRUE(caller->observer()->negotiation_needed());
1375}
1376
1377// Test that OnRenegotiationNeeded is not fired if SetDirection is called on an
1378// active RtpTransceiver with current direction.
Steve Anton3172c032018-05-03 15:30:18 -07001379TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001380 NoRenegotiationNeededAfterTransceiverSetSameDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001381 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001382
1383 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1384
1385 caller->observer()->clear_negotiation_needed();
1386 transceiver->SetDirection(transceiver->direction());
1387 EXPECT_FALSE(caller->observer()->negotiation_needed());
1388}
1389
1390// Test that OnRenegotiationNeeded is not fired if SetDirection is called on a
1391// stopped RtpTransceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001392TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001393 NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001394 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001395
1396 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1397 transceiver->Stop();
1398
1399 caller->observer()->clear_negotiation_needed();
1400 transceiver->SetDirection(RtpTransceiverDirection::kInactive);
1401 EXPECT_FALSE(caller->observer()->negotiation_needed());
1402}
1403
Florent Castelli892acf02018-10-01 22:47:20 +02001404// Test that AddTransceiver fails if trying to use simulcast using
1405// send_encodings as it isn't currently supported.
1406TEST_F(PeerConnectionRtpTestUnifiedPlan, CheckForUnsupportedSimulcast) {
1407 auto caller = CreatePeerConnection();
1408
1409 RtpTransceiverInit init;
1410 init.send_encodings.emplace_back();
1411 init.send_encodings.emplace_back();
1412 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
1413 EXPECT_EQ(result.error().type(), RTCErrorType::UNSUPPORTED_PARAMETER);
1414}
1415
1416// Test that AddTransceiver fails if trying to use unimplemented RTP encoding
1417// parameters with the send_encodings parameters.
1418TEST_F(PeerConnectionRtpTestUnifiedPlan,
1419 CheckForUnsupportedEncodingParameters) {
1420 auto caller = CreatePeerConnection();
1421
1422 RtpTransceiverInit init;
1423 init.send_encodings.emplace_back();
1424
1425 auto default_send_encodings = init.send_encodings;
1426
Florent Castelli806e06d2018-12-12 11:56:42 +01001427 // Unimplemented RtpParameters: ssrc, fec, rtx, dtx,
Florent Castelli892acf02018-10-01 22:47:20 +02001428 // ptime, scale_resolution_down_by, scale_framerate_down_by, rid,
1429 // dependency_rids.
1430 init.send_encodings[0].ssrc = 1;
1431 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1432 caller->pc()
1433 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1434 .error()
1435 .type());
1436 init.send_encodings = default_send_encodings;
1437
Florent Castelli892acf02018-10-01 22:47:20 +02001438 init.send_encodings[0].fec = RtpFecParameters();
1439 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1440 caller->pc()
1441 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1442 .error()
1443 .type());
1444 init.send_encodings = default_send_encodings;
1445
1446 init.send_encodings[0].rtx = RtpRtxParameters();
1447 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1448 caller->pc()
1449 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1450 .error()
1451 .type());
1452 init.send_encodings = default_send_encodings;
1453
1454 init.send_encodings[0].dtx = DtxStatus::ENABLED;
1455 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1456 caller->pc()
1457 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1458 .error()
1459 .type());
1460 init.send_encodings = default_send_encodings;
1461
1462 init.send_encodings[0].ptime = 1;
1463 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1464 caller->pc()
1465 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1466 .error()
1467 .type());
1468 init.send_encodings = default_send_encodings;
1469
1470 init.send_encodings[0].scale_resolution_down_by = 2.0;
1471 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1472 caller->pc()
1473 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1474 .error()
1475 .type());
1476 init.send_encodings = default_send_encodings;
1477
1478 init.send_encodings[0].rid = "dummy_rid";
1479 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1480 caller->pc()
1481 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1482 .error()
1483 .type());
1484 init.send_encodings = default_send_encodings;
1485
1486 init.send_encodings[0].dependency_rids.push_back("dummy_rid");
1487 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1488 caller->pc()
1489 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1490 .error()
1491 .type());
1492}
1493
1494// Test that AddTransceiver transfers the send_encodings to the sender and they
1495// are retained after SetLocalDescription().
1496TEST_F(PeerConnectionRtpTestUnifiedPlan, SendEncodingsPassedToSender) {
1497 auto caller = CreatePeerConnection();
1498
1499 RtpTransceiverInit init;
1500 init.send_encodings.emplace_back();
1501 init.send_encodings[0].active = false;
1502 init.send_encodings[0].max_bitrate_bps = 180000;
1503
1504 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1505 ASSERT_TRUE(result.ok());
1506
1507 auto init_send_encodings = result.value()->sender()->init_send_encodings();
1508 EXPECT_FALSE(init_send_encodings[0].active);
1509 EXPECT_EQ(init_send_encodings[0].max_bitrate_bps, 180000);
1510
1511 auto parameters = result.value()->sender()->GetParameters();
1512 EXPECT_FALSE(parameters.encodings[0].active);
1513 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1514
1515 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1516
1517 parameters = result.value()->sender()->GetParameters();
1518 EXPECT_FALSE(parameters.encodings[0].active);
1519 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1520}
1521
Steve Antone831b8c2018-02-01 12:22:16 -08001522// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
1523// options for this kind of signaling: media section based (a=msid) and ssrc
1524// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
1525// we want to ensure compatibility with older Plan B endpoints that might expect
1526// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
1527// types but answers with the same type as the offer.
1528
Steve Anton3172c032018-05-03 15:30:18 -07001529class PeerConnectionMsidSignalingTest
1530 : public PeerConnectionRtpTestUnifiedPlan {};
Steve Antone831b8c2018-02-01 12:22:16 -08001531
1532TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
1533 auto caller = CreatePeerConnectionWithUnifiedPlan();
1534 caller->AddAudioTrack("caller_audio");
1535 auto callee = CreatePeerConnectionWithUnifiedPlan();
1536 callee->AddAudioTrack("callee_audio");
1537
1538 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1539
1540 // Offer should have had both a=msid and a=ssrc MSID lines.
1541 auto* offer = callee->pc()->remote_description();
1542 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1543 cricket::kMsidSignalingSsrcAttribute),
1544 offer->description()->msid_signaling());
1545
1546 // Answer should have had only a=msid lines.
1547 auto* answer = caller->pc()->remote_description();
1548 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1549 answer->description()->msid_signaling());
Harald Alvestrand5dbb5862018-02-13 23:48:00 +01001550 // Check that this is counted correctly
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001551 EXPECT_EQ(2, webrtc::metrics::NumSamples(
1552 "WebRTC.PeerConnection.SdpSemanticNegotiated"));
1553 EXPECT_EQ(2, webrtc::metrics::NumEvents(
1554 "WebRTC.PeerConnection.SdpSemanticNegotiated",
1555 kSdpSemanticNegotiatedUnifiedPlan));
Steve Antone831b8c2018-02-01 12:22:16 -08001556}
1557
1558TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
1559 auto caller = CreatePeerConnectionWithPlanB();
1560 caller->AddAudioTrack("caller_audio");
1561 auto callee = CreatePeerConnectionWithUnifiedPlan();
1562 callee->AddAudioTrack("callee_audio");
1563
1564 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1565
1566 // Offer should have only a=ssrc MSID lines.
1567 auto* offer = callee->pc()->remote_description();
1568 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1569 offer->description()->msid_signaling());
1570
1571 // Answer should have only a=ssrc MSID lines to match the offer.
1572 auto* answer = caller->pc()->remote_description();
1573 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1574 answer->description()->msid_signaling());
1575}
1576
Seth Hampson5b4f0752018-04-02 16:31:36 -07001577// This tests that a Plan B endpoint appropriately sets the remote description
1578// from a Unified Plan offer. When the Unified Plan offer contains a=msid lines
1579// that signal no stream ids or multiple stream ids we expect that the Plan B
1580// endpoint always has exactly one media stream per track.
1581TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) {
1582 const std::string kStreamId1 = "audio_stream_1";
1583 const std::string kStreamId2 = "audio_stream_2";
1584
1585 auto caller = CreatePeerConnectionWithUnifiedPlan();
1586 caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2});
1587 caller->AddVideoTrack("caller_video", {});
1588 auto callee = CreatePeerConnectionWithPlanB();
1589 callee->AddAudioTrack("callee_audio");
1590 caller->AddVideoTrack("callee_video");
1591
1592 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1593
1594 // Offer should have had both a=msid and a=ssrc MSID lines.
1595 auto* offer = callee->pc()->remote_description();
1596 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1597 cricket::kMsidSignalingSsrcAttribute),
1598 offer->description()->msid_signaling());
1599
1600 // Callee should always have 1 stream for all of it's receivers.
1601 const auto& track_events = callee->observer()->add_track_events_;
1602 ASSERT_EQ(2u, track_events.size());
1603 ASSERT_EQ(1u, track_events[0].streams.size());
1604 EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id());
1605 ASSERT_EQ(1u, track_events[1].streams.size());
1606 // This autogenerated a stream id for the empty one signalled.
1607 EXPECT_FALSE(track_events[1].streams[0]->id().empty());
1608}
1609
Steve Antone831b8c2018-02-01 12:22:16 -08001610TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
1611 auto caller = CreatePeerConnectionWithUnifiedPlan();
1612 caller->AddAudioTrack("caller_audio");
1613 auto callee = CreatePeerConnectionWithUnifiedPlan();
1614 callee->AddAudioTrack("callee_audio");
1615
1616 auto offer = caller->CreateOffer();
1617 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
1618 // section only.
1619 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
1620
1621 ASSERT_TRUE(
1622 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
1623 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
1624
1625 // Answer should have only a=msid to match the offer.
1626 auto answer = callee->CreateAnswer();
1627 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1628 answer->description()->msid_signaling());
1629}
1630
Steve Anton8e20f172018-03-06 10:55:04 -08001631// Test that the correct UMA metrics are reported for simple/complex SDP.
1632
Steve Anton3172c032018-05-03 15:30:18 -07001633class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {};
Steve Anton8e20f172018-03-06 10:55:04 -08001634
1635#ifdef HAVE_SCTP
1636TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) {
1637 auto caller = CreatePeerConnectionWithUnifiedPlan();
1638 caller->CreateDataChannel("dc");
1639 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001640
1641 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001642 // Note that only the callee does ReportSdpFormatReceived.
1643 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1644 "WebRTC.PeerConnection.SdpFormatReceived"));
1645 EXPECT_EQ(
1646 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1647 kSdpFormatReceivedNoTracks));
Steve Anton8e20f172018-03-06 10:55:04 -08001648}
1649#endif // HAVE_SCTP
1650
1651TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) {
1652 auto caller = CreatePeerConnectionWithUnifiedPlan();
1653 caller->AddAudioTrack("audio");
1654 caller->AddVideoTrack("video");
1655 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001656
1657 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001658 // Note that only the callee does ReportSdpFormatReceived.
1659 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1660 "WebRTC.PeerConnection.SdpFormatReceived"));
1661 EXPECT_EQ(
1662 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1663 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001664}
1665
1666TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) {
1667 auto caller = CreatePeerConnectionWithPlanB();
1668 caller->AddVideoTrack("video"); // Video only.
1669 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001670
1671 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1672
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001673 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1674 "WebRTC.PeerConnection.SdpFormatReceived"));
1675 EXPECT_EQ(
1676 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1677 kSdpFormatReceivedSimple));
Steve Anton8e20f172018-03-06 10:55:04 -08001678}
1679
1680TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) {
1681 auto caller = CreatePeerConnectionWithUnifiedPlan();
1682 caller->AddAudioTrack("audio1");
1683 caller->AddAudioTrack("audio2");
1684 caller->AddVideoTrack("video");
1685 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001686
1687 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001688 // Note that only the callee does ReportSdpFormatReceived.
1689 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1690 "WebRTC.PeerConnection.SdpFormatReceived"));
1691 EXPECT_EQ(
1692 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1693 kSdpFormatReceivedComplexUnifiedPlan));
Steve Anton8e20f172018-03-06 10:55:04 -08001694}
1695
1696TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) {
1697 auto caller = CreatePeerConnectionWithPlanB();
1698 caller->AddVideoTrack("video1");
1699 caller->AddVideoTrack("video2");
1700 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001701
Steve Antonba42e992018-04-09 14:10:01 -07001702 // This fails since Unified Plan cannot set a session description with
1703 // multiple "Plan B tracks" in the same media section. But we still expect the
1704 // SDP Format to be recorded.
1705 ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001706 // Note that only the callee does ReportSdpFormatReceived.
1707 EXPECT_EQ(1, webrtc::metrics::NumSamples(
1708 "WebRTC.PeerConnection.SdpFormatReceived"));
1709 EXPECT_EQ(
1710 1, webrtc::metrics::NumEvents("WebRTC.PeerConnection.SdpFormatReceived",
1711 kSdpFormatReceivedComplexPlanB));
Steve Anton8e20f172018-03-06 10:55:04 -08001712}
1713
Henrik Boström91d039b2018-01-11 17:43:30 +01001714// Sender setups in a call.
1715
Steve Anton3172c032018-05-03 15:30:18 -07001716TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) {
Henrik Boström91d039b2018-01-11 17:43:30 +01001717 auto caller = CreatePeerConnection();
1718 auto callee = CreatePeerConnection();
1719
1720 auto track = caller->CreateAudioTrack("audio_track");
1721 auto sender1 = caller->AddTrack(track);
1722 ASSERT_TRUE(sender1);
1723 // We need to temporarily reset the track for the subsequent AddTrack() to
1724 // succeed.
1725 EXPECT_TRUE(sender1->SetTrack(nullptr));
1726 auto sender2 = caller->AddTrack(track);
1727 EXPECT_TRUE(sender2);
1728 EXPECT_TRUE(sender1->SetTrack(track));
1729
Steve Anton3172c032018-05-03 15:30:18 -07001730 if (sdp_semantics_ == SdpSemantics::kPlanB) {
1731 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
1732 // return true, and doing |callee->SetRemoteDescription()| should work.
1733 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
1734 } else {
1735 EXPECT_TRUE(caller->CreateOfferAndSetAsLocal());
1736 }
Henrik Boström91d039b2018-01-11 17:43:30 +01001737}
1738
Steve Anton3172c032018-05-03 15:30:18 -07001739INSTANTIATE_TEST_CASE_P(PeerConnectionRtpTest,
1740 PeerConnectionRtpTest,
1741 Values(SdpSemantics::kPlanB,
1742 SdpSemantics::kUnifiedPlan));
1743
Steve Anton9158ef62017-11-27 13:01:52 -08001744} // namespace webrtc