zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #include <string> |
| 12 | |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 13 | #include "webrtc/p2p/base/fakepackettransport.h" |
| 14 | #include "webrtc/pc/rtptransport.h" |
zstein | 398c3fd | 2017-07-19 13:38:02 -0700 | [diff] [blame] | 15 | #include "webrtc/pc/rtptransporttestutil.h" |
Edward Lemur | c20978e | 2017-07-06 19:44:34 +0200 | [diff] [blame] | 16 | #include "webrtc/rtc_base/gunit.h" |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 17 | |
| 18 | namespace webrtc { |
| 19 | |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 20 | constexpr bool kMuxDisabled = false; |
| 21 | constexpr bool kMuxEnabled = true; |
| 22 | |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 23 | TEST(RtpTransportTest, SetRtcpParametersCantDisableRtcpMux) { |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 24 | RtpTransport transport(kMuxDisabled); |
| 25 | RtcpParameters params; |
| 26 | transport.SetRtcpParameters(params); |
| 27 | params.mux = false; |
| 28 | EXPECT_FALSE(transport.SetRtcpParameters(params).ok()); |
| 29 | } |
| 30 | |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 31 | TEST(RtpTransportTest, SetRtcpParametersEmptyCnameUsesExisting) { |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 32 | static const char kName[] = "name"; |
| 33 | RtpTransport transport(kMuxDisabled); |
| 34 | RtcpParameters params_with_name; |
| 35 | params_with_name.cname = kName; |
| 36 | transport.SetRtcpParameters(params_with_name); |
| 37 | EXPECT_EQ(transport.GetRtcpParameters().cname, kName); |
| 38 | |
| 39 | RtcpParameters params_without_name; |
| 40 | transport.SetRtcpParameters(params_without_name); |
| 41 | EXPECT_EQ(transport.GetRtcpParameters().cname, kName); |
| 42 | } |
| 43 | |
| 44 | class SignalObserver : public sigslot::has_slots<> { |
| 45 | public: |
| 46 | explicit SignalObserver(RtpTransport* transport) { |
| 47 | transport->SignalReadyToSend.connect(this, &SignalObserver::OnReadyToSend); |
| 48 | } |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 49 | bool ready() const { return ready_; } |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 50 | void OnReadyToSend(bool ready) { ready_ = ready; } |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 51 | |
| 52 | private: |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 53 | bool ready_ = false; |
| 54 | }; |
| 55 | |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 56 | TEST(RtpTransportTest, SettingRtcpAndRtpSignalsReady) { |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 57 | RtpTransport transport(kMuxDisabled); |
| 58 | SignalObserver observer(&transport); |
| 59 | rtc::FakePacketTransport fake_rtcp("fake_rtcp"); |
| 60 | fake_rtcp.SetWritable(true); |
| 61 | rtc::FakePacketTransport fake_rtp("fake_rtp"); |
| 62 | fake_rtp.SetWritable(true); |
| 63 | |
| 64 | transport.SetRtcpPacketTransport(&fake_rtcp); // rtcp ready |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 65 | EXPECT_FALSE(observer.ready()); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 66 | transport.SetRtpPacketTransport(&fake_rtp); // rtp ready |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 67 | EXPECT_TRUE(observer.ready()); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 68 | } |
| 69 | |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 70 | TEST(RtpTransportTest, SettingRtpAndRtcpSignalsReady) { |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 71 | RtpTransport transport(kMuxDisabled); |
| 72 | SignalObserver observer(&transport); |
| 73 | rtc::FakePacketTransport fake_rtcp("fake_rtcp"); |
| 74 | fake_rtcp.SetWritable(true); |
| 75 | rtc::FakePacketTransport fake_rtp("fake_rtp"); |
| 76 | fake_rtp.SetWritable(true); |
| 77 | |
| 78 | transport.SetRtpPacketTransport(&fake_rtp); // rtp ready |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 79 | EXPECT_FALSE(observer.ready()); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 80 | transport.SetRtcpPacketTransport(&fake_rtcp); // rtcp ready |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 81 | EXPECT_TRUE(observer.ready()); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 82 | } |
| 83 | |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 84 | TEST(RtpTransportTest, SettingRtpWithRtcpMuxEnabledSignalsReady) { |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 85 | RtpTransport transport(kMuxEnabled); |
| 86 | SignalObserver observer(&transport); |
| 87 | rtc::FakePacketTransport fake_rtp("fake_rtp"); |
| 88 | fake_rtp.SetWritable(true); |
| 89 | |
| 90 | transport.SetRtpPacketTransport(&fake_rtp); // rtp ready |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 91 | EXPECT_TRUE(observer.ready()); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 92 | } |
| 93 | |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 94 | TEST(RtpTransportTest, DisablingRtcpMuxSignalsNotReady) { |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 95 | RtpTransport transport(kMuxEnabled); |
| 96 | SignalObserver observer(&transport); |
| 97 | rtc::FakePacketTransport fake_rtp("fake_rtp"); |
| 98 | fake_rtp.SetWritable(true); |
| 99 | |
| 100 | transport.SetRtpPacketTransport(&fake_rtp); // rtp ready |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 101 | EXPECT_TRUE(observer.ready()); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 102 | |
| 103 | transport.SetRtcpMuxEnabled(false); |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 104 | EXPECT_FALSE(observer.ready()); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 105 | } |
| 106 | |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 107 | TEST(RtpTransportTest, EnablingRtcpMuxSignalsReady) { |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 108 | RtpTransport transport(kMuxDisabled); |
| 109 | SignalObserver observer(&transport); |
| 110 | rtc::FakePacketTransport fake_rtp("fake_rtp"); |
| 111 | fake_rtp.SetWritable(true); |
| 112 | |
| 113 | transport.SetRtpPacketTransport(&fake_rtp); // rtp ready |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 114 | EXPECT_FALSE(observer.ready()); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 115 | |
| 116 | transport.SetRtcpMuxEnabled(true); |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 117 | EXPECT_TRUE(observer.ready()); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 118 | } |
| 119 | |
| 120 | class SignalCounter : public sigslot::has_slots<> { |
| 121 | public: |
| 122 | explicit SignalCounter(RtpTransport* transport) { |
| 123 | transport->SignalReadyToSend.connect(this, &SignalCounter::OnReadyToSend); |
| 124 | } |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 125 | int count() const { return count_; } |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 126 | void OnReadyToSend(bool ready) { ++count_; } |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 127 | |
| 128 | private: |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 129 | int count_ = 0; |
| 130 | }; |
| 131 | |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 132 | TEST(RtpTransportTest, ChangingReadyToSendStateOnlySignalsWhenChanged) { |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 133 | RtpTransport transport(kMuxEnabled); |
| 134 | SignalCounter observer(&transport); |
| 135 | rtc::FakePacketTransport fake_rtp("fake_rtp"); |
| 136 | fake_rtp.SetWritable(true); |
| 137 | |
| 138 | // State changes, so we should signal. |
| 139 | transport.SetRtpPacketTransport(&fake_rtp); |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 140 | EXPECT_EQ(observer.count(), 1); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 141 | |
| 142 | // State does not change, so we should not signal. |
| 143 | transport.SetRtpPacketTransport(&fake_rtp); |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 144 | EXPECT_EQ(observer.count(), 1); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 145 | |
| 146 | // State does not change, so we should not signal. |
| 147 | transport.SetRtcpMuxEnabled(true); |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 148 | EXPECT_EQ(observer.count(), 1); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 149 | |
| 150 | // State changes, so we should signal. |
| 151 | transport.SetRtcpMuxEnabled(false); |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 152 | EXPECT_EQ(observer.count(), 2); |
| 153 | } |
| 154 | |
zstein | 3dcf0e9 | 2017-06-01 13:22:42 -0700 | [diff] [blame] | 155 | // Test that SignalPacketReceived fires with rtcp=true when a RTCP packet is |
| 156 | // received. |
| 157 | TEST(RtpTransportTest, SignalDemuxedRtcp) { |
| 158 | RtpTransport transport(kMuxDisabled); |
| 159 | SignalPacketReceivedCounter observer(&transport); |
| 160 | rtc::FakePacketTransport fake_rtp("fake_rtp"); |
| 161 | fake_rtp.SetDestination(&fake_rtp, true); |
| 162 | transport.SetRtpPacketTransport(&fake_rtp); |
| 163 | |
| 164 | // An rtcp packet. |
| 165 | const char data[] = {0, 73, 0, 0}; |
| 166 | const int len = 4; |
| 167 | const rtc::PacketOptions options; |
| 168 | const int flags = 0; |
| 169 | fake_rtp.SendPacket(data, len, options, flags); |
| 170 | EXPECT_EQ(0, observer.rtp_count()); |
| 171 | EXPECT_EQ(1, observer.rtcp_count()); |
| 172 | } |
| 173 | |
| 174 | static const unsigned char kRtpData[] = {0x80, 0x11, 0, 0, 0, 0, |
| 175 | 0, 0, 0, 0, 0, 0}; |
| 176 | static const int kRtpLen = 12; |
| 177 | |
| 178 | // Test that SignalPacketReceived fires with rtcp=false when a RTP packet with a |
| 179 | // handled payload type is received. |
| 180 | TEST(RtpTransportTest, SignalHandledRtpPayloadType) { |
| 181 | RtpTransport transport(kMuxDisabled); |
| 182 | SignalPacketReceivedCounter observer(&transport); |
| 183 | rtc::FakePacketTransport fake_rtp("fake_rtp"); |
| 184 | fake_rtp.SetDestination(&fake_rtp, true); |
| 185 | transport.SetRtpPacketTransport(&fake_rtp); |
| 186 | transport.AddHandledPayloadType(0x11); |
| 187 | |
| 188 | // An rtp packet. |
| 189 | const rtc::PacketOptions options; |
| 190 | const int flags = 0; |
| 191 | rtc::Buffer rtp_data(kRtpData, kRtpLen); |
| 192 | fake_rtp.SendPacket(rtp_data.data<char>(), kRtpLen, options, flags); |
| 193 | EXPECT_EQ(1, observer.rtp_count()); |
| 194 | EXPECT_EQ(0, observer.rtcp_count()); |
| 195 | } |
| 196 | |
| 197 | // Test that SignalPacketReceived does not fire when a RTP packet with an |
| 198 | // unhandled payload type is received. |
| 199 | TEST(RtpTransportTest, DontSignalUnhandledRtpPayloadType) { |
| 200 | RtpTransport transport(kMuxDisabled); |
| 201 | SignalPacketReceivedCounter observer(&transport); |
| 202 | rtc::FakePacketTransport fake_rtp("fake_rtp"); |
| 203 | fake_rtp.SetDestination(&fake_rtp, true); |
| 204 | transport.SetRtpPacketTransport(&fake_rtp); |
| 205 | |
| 206 | const rtc::PacketOptions options; |
| 207 | const int flags = 0; |
| 208 | rtc::Buffer rtp_data(kRtpData, kRtpLen); |
| 209 | fake_rtp.SendPacket(rtp_data.data<char>(), kRtpLen, options, flags); |
| 210 | EXPECT_EQ(0, observer.rtp_count()); |
| 211 | EXPECT_EQ(0, observer.rtcp_count()); |
zstein | 56162b9 | 2017-04-24 16:54:35 -0700 | [diff] [blame] | 212 | } |
| 213 | |
| 214 | } // namespace webrtc |