aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 11 | #include "modules/audio_mixer/frame_combiner.h" |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 12 | |
Yves Gerey | 3e70781 | 2018-11-28 16:47:49 +0100 | [diff] [blame] | 13 | #include <cstdint> |
| 14 | #include <initializer_list> |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 15 | #include <numeric> |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 16 | #include <string> |
Yves Gerey | 3e70781 | 2018-11-28 16:47:49 +0100 | [diff] [blame] | 17 | #include <type_traits> |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 18 | #include <vector> |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 19 | |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 20 | #include "absl/types/optional.h" |
Yves Gerey | 3e70781 | 2018-11-28 16:47:49 +0100 | [diff] [blame] | 21 | #include "api/array_view.h" |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 22 | #include "api/rtp_packet_info.h" |
| 23 | #include "api/rtp_packet_infos.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 24 | #include "audio/utility/audio_frame_operations.h" |
| 25 | #include "modules/audio_mixer/gain_change_calculator.h" |
| 26 | #include "modules/audio_mixer/sine_wave_generator.h" |
| 27 | #include "rtc_base/checks.h" |
Jonas Olsson | 366a50c | 2018-09-06 13:41:30 +0200 | [diff] [blame] | 28 | #include "rtc_base/strings/string_builder.h" |
Alex Loiko | b4977de | 2019-01-28 16:38:38 +0100 | [diff] [blame] | 29 | #include "test/gmock.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 30 | #include "test/gtest.h" |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 31 | |
| 32 | namespace webrtc { |
| 33 | |
| 34 | namespace { |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 35 | |
| 36 | using ::testing::ElementsAreArray; |
| 37 | using ::testing::IsEmpty; |
| 38 | using ::testing::UnorderedElementsAreArray; |
| 39 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 40 | using LimiterType = FrameCombiner::LimiterType; |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 41 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 42 | struct FrameCombinerConfig { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 43 | bool use_limiter; |
| 44 | int sample_rate_hz; |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 45 | int number_of_channels; |
| 46 | float wave_frequency; |
| 47 | }; |
| 48 | |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 49 | std::string ProduceDebugText(int sample_rate_hz, |
| 50 | int number_of_channels, |
| 51 | int number_of_sources) { |
Jonas Olsson | 366a50c | 2018-09-06 13:41:30 +0200 | [diff] [blame] | 52 | rtc::StringBuilder ss; |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 53 | ss << "Sample rate: " << sample_rate_hz << " ,"; |
| 54 | ss << "number of channels: " << number_of_channels << " ,"; |
| 55 | ss << "number of sources: " << number_of_sources; |
Jonas Olsson | 84df1c7 | 2018-09-14 16:59:32 +0200 | [diff] [blame] | 56 | return ss.Release(); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 57 | } |
| 58 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 59 | std::string ProduceDebugText(const FrameCombinerConfig& config) { |
Jonas Olsson | 366a50c | 2018-09-06 13:41:30 +0200 | [diff] [blame] | 60 | rtc::StringBuilder ss; |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 61 | ss << "Sample rate: " << config.sample_rate_hz << " ,"; |
| 62 | ss << "number of channels: " << config.number_of_channels << " ,"; |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 63 | ss << "limiter active: " << (config.use_limiter ? "on" : "off") << " ,"; |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 64 | ss << "wave frequency: " << config.wave_frequency << " ,"; |
Jonas Olsson | 84df1c7 | 2018-09-14 16:59:32 +0200 | [diff] [blame] | 65 | return ss.Release(); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 66 | } |
| 67 | |
| 68 | AudioFrame frame1; |
| 69 | AudioFrame frame2; |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 70 | |
| 71 | void SetUpFrames(int sample_rate_hz, int number_of_channels) { |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 72 | RtpPacketInfo packet_info1( |
| 73 | /*ssrc=*/1001, /*csrcs=*/{}, /*rtp_timestamp=*/1000, |
| 74 | /*audio_level=*/absl::nullopt, /*absolute_capture_time=*/absl::nullopt, |
| 75 | /*receive_time_ms=*/1); |
| 76 | RtpPacketInfo packet_info2( |
| 77 | /*ssrc=*/4004, /*csrcs=*/{}, /*rtp_timestamp=*/1234, |
| 78 | /*audio_level=*/absl::nullopt, /*absolute_capture_time=*/absl::nullopt, |
| 79 | /*receive_time_ms=*/2); |
| 80 | RtpPacketInfo packet_info3( |
| 81 | /*ssrc=*/7007, /*csrcs=*/{}, /*rtp_timestamp=*/1333, |
| 82 | /*audio_level=*/absl::nullopt, /*absolute_capture_time=*/absl::nullopt, |
| 83 | /*receive_time_ms=*/2); |
| 84 | |
| 85 | frame1.packet_infos_ = RtpPacketInfos({packet_info1}); |
| 86 | frame2.packet_infos_ = RtpPacketInfos({packet_info2, packet_info3}); |
| 87 | |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 88 | for (auto* frame : {&frame1, &frame2}) { |
solenberg | c7b4a45 | 2017-09-28 07:37:11 -0700 | [diff] [blame] | 89 | frame->UpdateFrame(0, nullptr, rtc::CheckedDivExact(sample_rate_hz, 100), |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 90 | sample_rate_hz, AudioFrame::kNormalSpeech, |
| 91 | AudioFrame::kVadActive, number_of_channels); |
| 92 | } |
| 93 | } |
| 94 | } // namespace |
| 95 | |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 96 | // The limiter requires sample rate divisible by 2000. |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 97 | TEST(FrameCombiner, BasicApiCallsLimiter) { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 98 | FrameCombiner combiner(true); |
| 99 | for (const int rate : {8000, 18000, 34000, 48000}) { |
Alex Loiko | b4977de | 2019-01-28 16:38:38 +0100 | [diff] [blame] | 100 | for (const int number_of_channels : {1, 2, 4, 8}) { |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 101 | const std::vector<AudioFrame*> all_frames = {&frame1, &frame2}; |
| 102 | SetUpFrames(rate, number_of_channels); |
| 103 | |
| 104 | for (const int number_of_frames : {0, 1, 2}) { |
| 105 | SCOPED_TRACE( |
| 106 | ProduceDebugText(rate, number_of_channels, number_of_frames)); |
| 107 | const std::vector<AudioFrame*> frames_to_combine( |
| 108 | all_frames.begin(), all_frames.begin() + number_of_frames); |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 109 | AudioFrame audio_frame_for_mixing; |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 110 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 111 | frames_to_combine.size(), &audio_frame_for_mixing); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 112 | } |
| 113 | } |
| 114 | } |
| 115 | } |
| 116 | |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 117 | // The RtpPacketInfos field of the mixed packet should contain the union of the |
| 118 | // RtpPacketInfos from the frames that were actually mixed. |
| 119 | TEST(FrameCombiner, ContainsAllRtpPacketInfos) { |
| 120 | static constexpr int kSampleRateHz = 48000; |
| 121 | static constexpr int kNumChannels = 1; |
| 122 | FrameCombiner combiner(true); |
| 123 | const std::vector<AudioFrame*> all_frames = {&frame1, &frame2}; |
| 124 | SetUpFrames(kSampleRateHz, kNumChannels); |
| 125 | |
| 126 | for (const int number_of_frames : {0, 1, 2}) { |
| 127 | SCOPED_TRACE( |
| 128 | ProduceDebugText(kSampleRateHz, kNumChannels, number_of_frames)); |
| 129 | const std::vector<AudioFrame*> frames_to_combine( |
| 130 | all_frames.begin(), all_frames.begin() + number_of_frames); |
| 131 | |
| 132 | std::vector<RtpPacketInfo> packet_infos; |
| 133 | for (const auto& frame : frames_to_combine) { |
| 134 | packet_infos.insert(packet_infos.end(), frame->packet_infos_.begin(), |
| 135 | frame->packet_infos_.end()); |
| 136 | } |
| 137 | |
| 138 | AudioFrame audio_frame_for_mixing; |
| 139 | combiner.Combine(frames_to_combine, kNumChannels, kSampleRateHz, |
| 140 | frames_to_combine.size(), &audio_frame_for_mixing); |
| 141 | EXPECT_THAT(audio_frame_for_mixing.packet_infos_, |
| 142 | UnorderedElementsAreArray(packet_infos)); |
| 143 | } |
| 144 | } |
| 145 | |
Alex Loiko | b4977de | 2019-01-28 16:38:38 +0100 | [diff] [blame] | 146 | // There are DCHECKs in place to check for invalid parameters. |
Tommi | a5e07cc | 2020-05-26 21:40:37 +0200 | [diff] [blame] | 147 | TEST(FrameCombinerDeathTest, DebugBuildCrashesWithManyChannels) { |
Alex Loiko | b4977de | 2019-01-28 16:38:38 +0100 | [diff] [blame] | 148 | FrameCombiner combiner(true); |
| 149 | for (const int rate : {8000, 18000, 34000, 48000}) { |
| 150 | for (const int number_of_channels : {10, 20, 21}) { |
| 151 | if (static_cast<size_t>(rate / 100 * number_of_channels) > |
| 152 | AudioFrame::kMaxDataSizeSamples) { |
| 153 | continue; |
| 154 | } |
| 155 | const std::vector<AudioFrame*> all_frames = {&frame1, &frame2}; |
| 156 | SetUpFrames(rate, number_of_channels); |
| 157 | |
| 158 | const int number_of_frames = 2; |
| 159 | SCOPED_TRACE( |
| 160 | ProduceDebugText(rate, number_of_channels, number_of_frames)); |
| 161 | const std::vector<AudioFrame*> frames_to_combine( |
| 162 | all_frames.begin(), all_frames.begin() + number_of_frames); |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 163 | AudioFrame audio_frame_for_mixing; |
Alex Loiko | b4977de | 2019-01-28 16:38:38 +0100 | [diff] [blame] | 164 | #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) |
| 165 | EXPECT_DEATH( |
| 166 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
| 167 | frames_to_combine.size(), &audio_frame_for_mixing), |
| 168 | ""); |
| 169 | #elif !RTC_DCHECK_IS_ON |
| 170 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
| 171 | frames_to_combine.size(), &audio_frame_for_mixing); |
| 172 | #endif |
| 173 | } |
| 174 | } |
| 175 | } |
| 176 | |
Tommi | a5e07cc | 2020-05-26 21:40:37 +0200 | [diff] [blame] | 177 | TEST(FrameCombinerDeathTest, DebugBuildCrashesWithHighRate) { |
Alex Loiko | b4977de | 2019-01-28 16:38:38 +0100 | [diff] [blame] | 178 | FrameCombiner combiner(true); |
| 179 | for (const int rate : {50000, 96000, 128000, 196000}) { |
| 180 | for (const int number_of_channels : {1, 2, 3}) { |
| 181 | if (static_cast<size_t>(rate / 100 * number_of_channels) > |
| 182 | AudioFrame::kMaxDataSizeSamples) { |
| 183 | continue; |
| 184 | } |
| 185 | const std::vector<AudioFrame*> all_frames = {&frame1, &frame2}; |
| 186 | SetUpFrames(rate, number_of_channels); |
| 187 | |
| 188 | const int number_of_frames = 2; |
| 189 | SCOPED_TRACE( |
| 190 | ProduceDebugText(rate, number_of_channels, number_of_frames)); |
| 191 | const std::vector<AudioFrame*> frames_to_combine( |
| 192 | all_frames.begin(), all_frames.begin() + number_of_frames); |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 193 | AudioFrame audio_frame_for_mixing; |
Alex Loiko | b4977de | 2019-01-28 16:38:38 +0100 | [diff] [blame] | 194 | #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) |
| 195 | EXPECT_DEATH( |
| 196 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
| 197 | frames_to_combine.size(), &audio_frame_for_mixing), |
| 198 | ""); |
| 199 | #elif !RTC_DCHECK_IS_ON |
| 200 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
| 201 | frames_to_combine.size(), &audio_frame_for_mixing); |
| 202 | #endif |
| 203 | } |
| 204 | } |
| 205 | } |
| 206 | |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 207 | // With no limiter, the rate has to be divisible by 100 since we use |
| 208 | // 10 ms frames. |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 209 | TEST(FrameCombiner, BasicApiCallsNoLimiter) { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 210 | FrameCombiner combiner(false); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 211 | for (const int rate : {8000, 10000, 11000, 32000, 44100}) { |
Alex Loiko | b4977de | 2019-01-28 16:38:38 +0100 | [diff] [blame] | 212 | for (const int number_of_channels : {1, 2, 4, 8}) { |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 213 | const std::vector<AudioFrame*> all_frames = {&frame1, &frame2}; |
| 214 | SetUpFrames(rate, number_of_channels); |
| 215 | |
| 216 | for (const int number_of_frames : {0, 1, 2}) { |
| 217 | SCOPED_TRACE( |
| 218 | ProduceDebugText(rate, number_of_channels, number_of_frames)); |
| 219 | const std::vector<AudioFrame*> frames_to_combine( |
| 220 | all_frames.begin(), all_frames.begin() + number_of_frames); |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 221 | AudioFrame audio_frame_for_mixing; |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 222 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 223 | frames_to_combine.size(), &audio_frame_for_mixing); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 224 | } |
| 225 | } |
| 226 | } |
| 227 | } |
| 228 | |
| 229 | TEST(FrameCombiner, CombiningZeroFramesShouldProduceSilence) { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 230 | FrameCombiner combiner(false); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 231 | for (const int rate : {8000, 10000, 11000, 32000, 44100}) { |
| 232 | for (const int number_of_channels : {1, 2}) { |
| 233 | SCOPED_TRACE(ProduceDebugText(rate, number_of_channels, 0)); |
| 234 | |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 235 | AudioFrame audio_frame_for_mixing; |
| 236 | |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 237 | const std::vector<AudioFrame*> frames_to_combine; |
| 238 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 239 | frames_to_combine.size(), &audio_frame_for_mixing); |
yujo | 36b1a5f | 2017-06-12 12:45:32 -0700 | [diff] [blame] | 240 | const int16_t* audio_frame_for_mixing_data = |
| 241 | audio_frame_for_mixing.data(); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 242 | const std::vector<int16_t> mixed_data( |
yujo | 36b1a5f | 2017-06-12 12:45:32 -0700 | [diff] [blame] | 243 | audio_frame_for_mixing_data, |
| 244 | audio_frame_for_mixing_data + number_of_channels * rate / 100); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 245 | |
| 246 | const std::vector<int16_t> expected(number_of_channels * rate / 100, 0); |
| 247 | EXPECT_EQ(mixed_data, expected); |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 248 | EXPECT_THAT(audio_frame_for_mixing.packet_infos_, IsEmpty()); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 249 | } |
| 250 | } |
| 251 | } |
| 252 | |
| 253 | TEST(FrameCombiner, CombiningOneFrameShouldNotChangeFrame) { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 254 | FrameCombiner combiner(false); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 255 | for (const int rate : {8000, 10000, 11000, 32000, 44100}) { |
Alex Loiko | b4977de | 2019-01-28 16:38:38 +0100 | [diff] [blame] | 256 | for (const int number_of_channels : {1, 2, 4, 8, 10}) { |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 257 | SCOPED_TRACE(ProduceDebugText(rate, number_of_channels, 1)); |
| 258 | |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 259 | AudioFrame audio_frame_for_mixing; |
| 260 | |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 261 | SetUpFrames(rate, number_of_channels); |
yujo | 36b1a5f | 2017-06-12 12:45:32 -0700 | [diff] [blame] | 262 | int16_t* frame1_data = frame1.mutable_data(); |
| 263 | std::iota(frame1_data, frame1_data + number_of_channels * rate / 100, 0); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 264 | const std::vector<AudioFrame*> frames_to_combine = {&frame1}; |
| 265 | combiner.Combine(frames_to_combine, number_of_channels, rate, |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 266 | frames_to_combine.size(), &audio_frame_for_mixing); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 267 | |
yujo | 36b1a5f | 2017-06-12 12:45:32 -0700 | [diff] [blame] | 268 | const int16_t* audio_frame_for_mixing_data = |
| 269 | audio_frame_for_mixing.data(); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 270 | const std::vector<int16_t> mixed_data( |
yujo | 36b1a5f | 2017-06-12 12:45:32 -0700 | [diff] [blame] | 271 | audio_frame_for_mixing_data, |
| 272 | audio_frame_for_mixing_data + number_of_channels * rate / 100); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 273 | |
| 274 | std::vector<int16_t> expected(number_of_channels * rate / 100); |
| 275 | std::iota(expected.begin(), expected.end(), 0); |
| 276 | EXPECT_EQ(mixed_data, expected); |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 277 | EXPECT_THAT(audio_frame_for_mixing.packet_infos_, |
| 278 | ElementsAreArray(frame1.packet_infos_)); |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 279 | } |
| 280 | } |
| 281 | } |
| 282 | |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 283 | // Send a sine wave through the FrameCombiner, and check that the |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 284 | // difference between input and output varies smoothly. Also check |
| 285 | // that it is inside reasonable bounds. This is to catch issues like |
| 286 | // chromium:695993 and chromium:816875. |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 287 | TEST(FrameCombiner, GainCurveIsSmoothForAlternatingNumberOfStreams) { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 288 | // Rates are divisible by 2000 when limiter is active. |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 289 | std::vector<FrameCombinerConfig> configs = { |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 290 | {false, 30100, 2, 50.f}, {false, 16500, 1, 3200.f}, |
| 291 | {true, 8000, 1, 3200.f}, {true, 16000, 1, 50.f}, |
Alex Loiko | b4977de | 2019-01-28 16:38:38 +0100 | [diff] [blame] | 292 | {true, 18000, 8, 3200.f}, {true, 10000, 2, 50.f}, |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 293 | }; |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 294 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 295 | for (const auto& config : configs) { |
| 296 | SCOPED_TRACE(ProduceDebugText(config)); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 297 | |
Alex Loiko | 8396e34 | 2018-06-21 12:04:05 +0200 | [diff] [blame] | 298 | FrameCombiner combiner(config.use_limiter); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 299 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 300 | constexpr int16_t wave_amplitude = 30000; |
| 301 | SineWaveGenerator wave_generator(config.wave_frequency, wave_amplitude); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 302 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 303 | GainChangeCalculator change_calculator; |
| 304 | float cumulative_change = 0.f; |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 305 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 306 | constexpr size_t iterations = 100; |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 307 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 308 | for (size_t i = 0; i < iterations; ++i) { |
| 309 | SetUpFrames(config.sample_rate_hz, config.number_of_channels); |
| 310 | wave_generator.GenerateNextFrame(&frame1); |
| 311 | AudioFrameOperations::Mute(&frame2); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 312 | |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 313 | std::vector<AudioFrame*> frames_to_combine = {&frame1}; |
| 314 | if (i % 2 == 0) { |
| 315 | frames_to_combine.push_back(&frame2); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 316 | } |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 317 | const size_t number_of_samples = |
| 318 | frame1.samples_per_channel_ * config.number_of_channels; |
| 319 | |
| 320 | // Ensures limiter is on if 'use_limiter'. |
| 321 | constexpr size_t number_of_streams = 2; |
Doudou Kisabaka | fe6595f | 2021-05-18 11:50:01 +0200 | [diff] [blame] | 322 | AudioFrame audio_frame_for_mixing; |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 323 | combiner.Combine(frames_to_combine, config.number_of_channels, |
| 324 | config.sample_rate_hz, number_of_streams, |
| 325 | &audio_frame_for_mixing); |
| 326 | cumulative_change += change_calculator.CalculateGainChange( |
| 327 | rtc::ArrayView<const int16_t>(frame1.data(), number_of_samples), |
| 328 | rtc::ArrayView<const int16_t>(audio_frame_for_mixing.data(), |
| 329 | number_of_samples)); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 330 | } |
Alex Loiko | 507e8d1 | 2018-02-27 13:51:47 +0100 | [diff] [blame] | 331 | |
| 332 | // Check that the gain doesn't vary too much. |
| 333 | EXPECT_LT(cumulative_change, 10); |
| 334 | |
| 335 | // Check that the latest gain is within reasonable bounds. It |
| 336 | // should be slightly less that 1. |
| 337 | EXPECT_LT(0.9f, change_calculator.LatestGain()); |
| 338 | EXPECT_LT(change_calculator.LatestGain(), 1.01f); |
aleloi | 2c9306e | 2017-03-29 04:25:16 -0700 | [diff] [blame] | 339 | } |
| 340 | } |
aleloi | 24899e5 | 2017-02-21 05:06:29 -0800 | [diff] [blame] | 341 | } // namespace webrtc |