Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2020 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #include <stddef.h> |
| 12 | #include <stdint.h> |
| 13 | |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 14 | #include <memory> |
| 15 | #include <ostream> |
| 16 | #include <string> |
| 17 | |
| 18 | #include "absl/types/optional.h" |
Danil Chapovalov | 09867d3 | 2020-06-18 17:03:57 +0200 | [diff] [blame] | 19 | #include "api/transport/rtp/dependency_descriptor.h" |
Danil Chapovalov | da7fe39 | 2020-10-15 15:57:17 +0200 | [diff] [blame] | 20 | #include "modules/video_coding/svc/create_scalability_structure.h" |
| 21 | #include "modules/video_coding/svc/scalability_structure_test_helpers.h" |
| 22 | #include "modules/video_coding/svc/scalable_video_controller.h" |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 23 | #include "test/gmock.h" |
| 24 | #include "test/gtest.h" |
| 25 | |
| 26 | namespace webrtc { |
| 27 | namespace { |
| 28 | |
| 29 | using ::testing::AllOf; |
Danil Chapovalov | aa40b89 | 2020-06-03 18:13:20 +0200 | [diff] [blame] | 30 | using ::testing::Contains; |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 31 | using ::testing::Each; |
| 32 | using ::testing::Field; |
| 33 | using ::testing::Ge; |
| 34 | using ::testing::IsEmpty; |
| 35 | using ::testing::Le; |
| 36 | using ::testing::Lt; |
| 37 | using ::testing::Not; |
| 38 | using ::testing::SizeIs; |
| 39 | using ::testing::TestWithParam; |
| 40 | using ::testing::Values; |
| 41 | |
| 42 | struct SvcTestParam { |
| 43 | friend std::ostream& operator<<(std::ostream& os, const SvcTestParam& param) { |
| 44 | return os << param.name; |
| 45 | } |
| 46 | |
| 47 | std::string name; |
Danil Chapovalov | aa40b89 | 2020-06-03 18:13:20 +0200 | [diff] [blame] | 48 | int num_temporal_units; |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 49 | }; |
| 50 | |
Danil Chapovalov | 294729f | 2020-10-09 18:58:42 +0200 | [diff] [blame] | 51 | class ScalabilityStructureTest : public TestWithParam<SvcTestParam> {}; |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 52 | |
| 53 | TEST_P(ScalabilityStructureTest, |
| 54 | NumberOfDecodeTargetsAndChainsAreInRangeAndConsistent) { |
| 55 | FrameDependencyStructure structure = |
Danil Chapovalov | a13e7a1 | 2020-07-14 12:34:36 +0200 | [diff] [blame] | 56 | CreateScalabilityStructure(GetParam().name)->DependencyStructure(); |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 57 | EXPECT_GT(structure.num_decode_targets, 0); |
Danil Chapovalov | 09867d3 | 2020-06-18 17:03:57 +0200 | [diff] [blame] | 58 | EXPECT_LE(structure.num_decode_targets, |
| 59 | DependencyDescriptor::kMaxDecodeTargets); |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 60 | EXPECT_GE(structure.num_chains, 0); |
| 61 | EXPECT_LE(structure.num_chains, structure.num_decode_targets); |
| 62 | if (structure.num_chains == 0) { |
| 63 | EXPECT_THAT(structure.decode_target_protected_by_chain, IsEmpty()); |
| 64 | } else { |
| 65 | EXPECT_THAT(structure.decode_target_protected_by_chain, |
| 66 | AllOf(SizeIs(structure.num_decode_targets), Each(Ge(0)), |
Danil Chapovalov | a5d9c1a | 2020-07-14 18:00:17 +0200 | [diff] [blame] | 67 | Each(Lt(structure.num_chains)))); |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 68 | } |
Danil Chapovalov | 09867d3 | 2020-06-18 17:03:57 +0200 | [diff] [blame] | 69 | EXPECT_THAT(structure.templates, |
| 70 | SizeIs(Lt(size_t{DependencyDescriptor::kMaxTemplates}))); |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 71 | } |
| 72 | |
| 73 | TEST_P(ScalabilityStructureTest, TemplatesAreSortedByLayerId) { |
| 74 | FrameDependencyStructure structure = |
Danil Chapovalov | a13e7a1 | 2020-07-14 12:34:36 +0200 | [diff] [blame] | 75 | CreateScalabilityStructure(GetParam().name)->DependencyStructure(); |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 76 | ASSERT_THAT(structure.templates, Not(IsEmpty())); |
| 77 | const auto& first_templates = structure.templates.front(); |
| 78 | EXPECT_EQ(first_templates.spatial_id, 0); |
| 79 | EXPECT_EQ(first_templates.temporal_id, 0); |
| 80 | for (size_t i = 1; i < structure.templates.size(); ++i) { |
| 81 | const auto& prev_template = structure.templates[i - 1]; |
| 82 | const auto& next_template = structure.templates[i]; |
| 83 | if (next_template.spatial_id == prev_template.spatial_id && |
| 84 | next_template.temporal_id == prev_template.temporal_id) { |
| 85 | // Same layer, next_layer_idc == 0 |
| 86 | } else if (next_template.spatial_id == prev_template.spatial_id && |
| 87 | next_template.temporal_id == prev_template.temporal_id + 1) { |
| 88 | // Next temporal layer, next_layer_idc == 1 |
| 89 | } else if (next_template.spatial_id == prev_template.spatial_id + 1 && |
| 90 | next_template.temporal_id == 0) { |
| 91 | // Next spatial layer, next_layer_idc == 2 |
| 92 | } else { |
| 93 | // everything else is invalid. |
| 94 | ADD_FAILURE() << "Invalid templates order. Template #" << i |
| 95 | << " with layer (" << next_template.spatial_id << "," |
| 96 | << next_template.temporal_id |
| 97 | << ") follows template with layer (" |
| 98 | << prev_template.spatial_id << "," |
| 99 | << prev_template.temporal_id << ")."; |
| 100 | } |
| 101 | } |
| 102 | } |
| 103 | |
| 104 | TEST_P(ScalabilityStructureTest, TemplatesMatchNumberOfDecodeTargetsAndChains) { |
| 105 | FrameDependencyStructure structure = |
Danil Chapovalov | a13e7a1 | 2020-07-14 12:34:36 +0200 | [diff] [blame] | 106 | CreateScalabilityStructure(GetParam().name)->DependencyStructure(); |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 107 | EXPECT_THAT( |
| 108 | structure.templates, |
| 109 | Each(AllOf(Field(&FrameDependencyTemplate::decode_target_indications, |
| 110 | SizeIs(structure.num_decode_targets)), |
| 111 | Field(&FrameDependencyTemplate::chain_diffs, |
| 112 | SizeIs(structure.num_chains))))); |
| 113 | } |
| 114 | |
Danil Chapovalov | aa40b89 | 2020-06-03 18:13:20 +0200 | [diff] [blame] | 115 | TEST_P(ScalabilityStructureTest, FrameInfoMatchesFrameDependencyStructure) { |
Danil Chapovalov | b6103ff | 2020-09-28 12:32:41 +0200 | [diff] [blame] | 116 | std::unique_ptr<ScalableVideoController> svc_controller = |
| 117 | CreateScalabilityStructure(GetParam().name); |
| 118 | FrameDependencyStructure structure = svc_controller->DependencyStructure(); |
| 119 | std::vector<GenericFrameInfo> frame_infos = |
Danil Chapovalov | 294729f | 2020-10-09 18:58:42 +0200 | [diff] [blame] | 120 | ScalabilityStructureWrapper(*svc_controller) |
| 121 | .GenerateFrames(GetParam().num_temporal_units); |
Danil Chapovalov | aa40b89 | 2020-06-03 18:13:20 +0200 | [diff] [blame] | 122 | for (size_t frame_id = 0; frame_id < frame_infos.size(); ++frame_id) { |
| 123 | const auto& frame = frame_infos[frame_id]; |
| 124 | EXPECT_GE(frame.spatial_id, 0) << " for frame " << frame_id; |
| 125 | EXPECT_GE(frame.temporal_id, 0) << " for frame " << frame_id; |
| 126 | EXPECT_THAT(frame.decode_target_indications, |
| 127 | SizeIs(structure.num_decode_targets)) |
| 128 | << " for frame " << frame_id; |
| 129 | EXPECT_THAT(frame.part_of_chain, SizeIs(structure.num_chains)) |
| 130 | << " for frame " << frame_id; |
| 131 | } |
| 132 | } |
| 133 | |
| 134 | TEST_P(ScalabilityStructureTest, ThereIsAPerfectTemplateForEachFrame) { |
Danil Chapovalov | b6103ff | 2020-09-28 12:32:41 +0200 | [diff] [blame] | 135 | std::unique_ptr<ScalableVideoController> svc_controller = |
| 136 | CreateScalabilityStructure(GetParam().name); |
| 137 | FrameDependencyStructure structure = svc_controller->DependencyStructure(); |
| 138 | std::vector<GenericFrameInfo> frame_infos = |
Danil Chapovalov | 294729f | 2020-10-09 18:58:42 +0200 | [diff] [blame] | 139 | ScalabilityStructureWrapper(*svc_controller) |
| 140 | .GenerateFrames(GetParam().num_temporal_units); |
Danil Chapovalov | aa40b89 | 2020-06-03 18:13:20 +0200 | [diff] [blame] | 141 | for (size_t frame_id = 0; frame_id < frame_infos.size(); ++frame_id) { |
| 142 | EXPECT_THAT(structure.templates, Contains(frame_infos[frame_id])) |
| 143 | << " for frame " << frame_id; |
| 144 | } |
| 145 | } |
| 146 | |
| 147 | TEST_P(ScalabilityStructureTest, FrameDependsOnSameOrLowerLayer) { |
Danil Chapovalov | b6103ff | 2020-09-28 12:32:41 +0200 | [diff] [blame] | 148 | std::unique_ptr<ScalableVideoController> svc_controller = |
| 149 | CreateScalabilityStructure(GetParam().name); |
| 150 | std::vector<GenericFrameInfo> frame_infos = |
Danil Chapovalov | 294729f | 2020-10-09 18:58:42 +0200 | [diff] [blame] | 151 | ScalabilityStructureWrapper(*svc_controller) |
| 152 | .GenerateFrames(GetParam().num_temporal_units); |
Danil Chapovalov | aa40b89 | 2020-06-03 18:13:20 +0200 | [diff] [blame] | 153 | int64_t num_frames = frame_infos.size(); |
| 154 | |
| 155 | for (int64_t frame_id = 0; frame_id < num_frames; ++frame_id) { |
| 156 | const auto& frame = frame_infos[frame_id]; |
| 157 | for (int frame_diff : frame.frame_diffs) { |
| 158 | int64_t base_frame_id = frame_id - frame_diff; |
| 159 | const auto& base_frame = frame_infos[base_frame_id]; |
| 160 | EXPECT_GE(frame.spatial_id, base_frame.spatial_id) |
| 161 | << "Frame " << frame_id << " depends on frame " << base_frame_id; |
| 162 | EXPECT_GE(frame.temporal_id, base_frame.temporal_id) |
| 163 | << "Frame " << frame_id << " depends on frame " << base_frame_id; |
| 164 | } |
| 165 | } |
| 166 | } |
| 167 | |
| 168 | TEST_P(ScalabilityStructureTest, NoFrameDependsOnDiscardableOrNotPresent) { |
Danil Chapovalov | b6103ff | 2020-09-28 12:32:41 +0200 | [diff] [blame] | 169 | std::unique_ptr<ScalableVideoController> svc_controller = |
| 170 | CreateScalabilityStructure(GetParam().name); |
| 171 | std::vector<GenericFrameInfo> frame_infos = |
Danil Chapovalov | 294729f | 2020-10-09 18:58:42 +0200 | [diff] [blame] | 172 | ScalabilityStructureWrapper(*svc_controller) |
| 173 | .GenerateFrames(GetParam().num_temporal_units); |
Danil Chapovalov | aa40b89 | 2020-06-03 18:13:20 +0200 | [diff] [blame] | 174 | int64_t num_frames = frame_infos.size(); |
Danil Chapovalov | b6103ff | 2020-09-28 12:32:41 +0200 | [diff] [blame] | 175 | FrameDependencyStructure structure = svc_controller->DependencyStructure(); |
Danil Chapovalov | aa40b89 | 2020-06-03 18:13:20 +0200 | [diff] [blame] | 176 | |
| 177 | for (int dt = 0; dt < structure.num_decode_targets; ++dt) { |
| 178 | for (int64_t frame_id = 0; frame_id < num_frames; ++frame_id) { |
| 179 | const auto& frame = frame_infos[frame_id]; |
| 180 | if (frame.decode_target_indications[dt] == |
| 181 | DecodeTargetIndication::kNotPresent) { |
| 182 | continue; |
| 183 | } |
| 184 | for (int frame_diff : frame.frame_diffs) { |
| 185 | int64_t base_frame_id = frame_id - frame_diff; |
| 186 | const auto& base_frame = frame_infos[base_frame_id]; |
| 187 | EXPECT_NE(base_frame.decode_target_indications[dt], |
| 188 | DecodeTargetIndication::kNotPresent) |
| 189 | << "Frame " << frame_id << " depends on frame " << base_frame_id |
| 190 | << " that is not part of decode target#" << dt; |
| 191 | EXPECT_NE(base_frame.decode_target_indications[dt], |
| 192 | DecodeTargetIndication::kDiscardable) |
| 193 | << "Frame " << frame_id << " depends on frame " << base_frame_id |
| 194 | << " that is discardable for decode target#" << dt; |
| 195 | } |
| 196 | } |
| 197 | } |
| 198 | } |
| 199 | |
| 200 | TEST_P(ScalabilityStructureTest, NoFrameDependsThroughSwitchIndication) { |
Danil Chapovalov | b6103ff | 2020-09-28 12:32:41 +0200 | [diff] [blame] | 201 | std::unique_ptr<ScalableVideoController> svc_controller = |
| 202 | CreateScalabilityStructure(GetParam().name); |
| 203 | FrameDependencyStructure structure = svc_controller->DependencyStructure(); |
| 204 | std::vector<GenericFrameInfo> frame_infos = |
Danil Chapovalov | 294729f | 2020-10-09 18:58:42 +0200 | [diff] [blame] | 205 | ScalabilityStructureWrapper(*svc_controller) |
| 206 | .GenerateFrames(GetParam().num_temporal_units); |
Danil Chapovalov | aa40b89 | 2020-06-03 18:13:20 +0200 | [diff] [blame] | 207 | int64_t num_frames = frame_infos.size(); |
| 208 | std::vector<std::set<int64_t>> full_deps(num_frames); |
| 209 | |
| 210 | // For each frame calculate set of all frames it depends on, both directly and |
| 211 | // indirectly. |
| 212 | for (int64_t frame_id = 0; frame_id < num_frames; ++frame_id) { |
| 213 | std::set<int64_t> all_base_frames; |
| 214 | for (int frame_diff : frame_infos[frame_id].frame_diffs) { |
| 215 | int64_t base_frame_id = frame_id - frame_diff; |
| 216 | all_base_frames.insert(base_frame_id); |
| 217 | const auto& indirect = full_deps[base_frame_id]; |
| 218 | all_base_frames.insert(indirect.begin(), indirect.end()); |
| 219 | } |
| 220 | full_deps[frame_id] = std::move(all_base_frames); |
| 221 | } |
| 222 | |
| 223 | // Now check the switch indication: frames after the switch indication mustn't |
| 224 | // depend on any addition frames before the switch indications. |
| 225 | for (int dt = 0; dt < structure.num_decode_targets; ++dt) { |
| 226 | for (int64_t switch_frame_id = 0; switch_frame_id < num_frames; |
| 227 | ++switch_frame_id) { |
| 228 | if (frame_infos[switch_frame_id].decode_target_indications[dt] != |
| 229 | DecodeTargetIndication::kSwitch) { |
| 230 | continue; |
| 231 | } |
| 232 | for (int64_t later_frame_id = switch_frame_id + 1; |
| 233 | later_frame_id < num_frames; ++later_frame_id) { |
| 234 | if (frame_infos[later_frame_id].decode_target_indications[dt] == |
| 235 | DecodeTargetIndication::kNotPresent) { |
| 236 | continue; |
| 237 | } |
| 238 | for (int frame_diff : frame_infos[later_frame_id].frame_diffs) { |
| 239 | int64_t early_frame_id = later_frame_id - frame_diff; |
| 240 | if (early_frame_id < switch_frame_id) { |
| 241 | EXPECT_THAT(full_deps[switch_frame_id], Contains(early_frame_id)) |
| 242 | << "For decode target #" << dt << " frame " << later_frame_id |
| 243 | << " depends on the frame " << early_frame_id |
| 244 | << " that switch indication frame " << switch_frame_id |
| 245 | << " doesn't directly on indirectly depend on."; |
| 246 | } |
| 247 | } |
| 248 | } |
| 249 | } |
| 250 | } |
| 251 | } |
| 252 | |
Danil Chapovalov | 71002a2 | 2020-10-23 19:04:11 +0200 | [diff] [blame] | 253 | TEST_P(ScalabilityStructureTest, ProduceNoFrameForDisabledLayers) { |
Danil Chapovalov | b6103ff | 2020-09-28 12:32:41 +0200 | [diff] [blame] | 254 | std::unique_ptr<ScalableVideoController> svc_controller = |
| 255 | CreateScalabilityStructure(GetParam().name); |
| 256 | ScalableVideoController::StreamLayersConfig structure = |
| 257 | svc_controller->StreamConfig(); |
| 258 | |
| 259 | VideoBitrateAllocation all_bitrates; |
| 260 | for (int sid = 0; sid < structure.num_spatial_layers; ++sid) { |
| 261 | for (int tid = 0; tid < structure.num_temporal_layers; ++tid) { |
| 262 | all_bitrates.SetBitrate(sid, tid, 100'000); |
| 263 | } |
| 264 | } |
| 265 | |
| 266 | svc_controller->OnRatesUpdated(all_bitrates); |
Danil Chapovalov | 294729f | 2020-10-09 18:58:42 +0200 | [diff] [blame] | 267 | ScalabilityStructureWrapper wrapper(*svc_controller); |
| 268 | std::vector<GenericFrameInfo> frames = |
| 269 | wrapper.GenerateFrames(GetParam().num_temporal_units); |
Danil Chapovalov | b6103ff | 2020-09-28 12:32:41 +0200 | [diff] [blame] | 270 | |
| 271 | for (int sid = 0; sid < structure.num_spatial_layers; ++sid) { |
| 272 | for (int tid = 0; tid < structure.num_temporal_layers; ++tid) { |
| 273 | // When all layers were enabled, expect there was a frame for each layer. |
| 274 | EXPECT_THAT(frames, |
| 275 | Contains(AllOf(Field(&GenericFrameInfo::spatial_id, sid), |
| 276 | Field(&GenericFrameInfo::temporal_id, tid)))) |
| 277 | << "For layer (" << sid << "," << tid << ")"; |
| 278 | // Restore bitrates for all layers before disabling single layer. |
| 279 | VideoBitrateAllocation bitrates = all_bitrates; |
| 280 | bitrates.SetBitrate(sid, tid, 0); |
| 281 | svc_controller->OnRatesUpdated(bitrates); |
| 282 | // With layer (sid, tid) disabled, expect no frames are produced for it. |
| 283 | EXPECT_THAT( |
Danil Chapovalov | 294729f | 2020-10-09 18:58:42 +0200 | [diff] [blame] | 284 | wrapper.GenerateFrames(GetParam().num_temporal_units), |
Danil Chapovalov | b6103ff | 2020-09-28 12:32:41 +0200 | [diff] [blame] | 285 | Not(Contains(AllOf(Field(&GenericFrameInfo::spatial_id, sid), |
| 286 | Field(&GenericFrameInfo::temporal_id, tid))))) |
| 287 | << "For layer (" << sid << "," << tid << ")"; |
| 288 | } |
| 289 | } |
| 290 | } |
| 291 | |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 292 | INSTANTIATE_TEST_SUITE_P( |
| 293 | Svc, |
| 294 | ScalabilityStructureTest, |
Danil Chapovalov | 45d2234 | 2021-02-11 14:58:29 +0100 | [diff] [blame] | 295 | Values(SvcTestParam{"NONE", /*num_temporal_units=*/3}, |
| 296 | SvcTestParam{"L1T2", /*num_temporal_units=*/4}, |
Danil Chapovalov | a13e7a1 | 2020-07-14 12:34:36 +0200 | [diff] [blame] | 297 | SvcTestParam{"L1T3", /*num_temporal_units=*/8}, |
| 298 | SvcTestParam{"L2T1", /*num_temporal_units=*/3}, |
| 299 | SvcTestParam{"L2T1_KEY", /*num_temporal_units=*/3}, |
| 300 | SvcTestParam{"L3T1", /*num_temporal_units=*/3}, |
| 301 | SvcTestParam{"L3T3", /*num_temporal_units=*/8}, |
| 302 | SvcTestParam{"S2T1", /*num_temporal_units=*/3}, |
Danil Chapovalov | 735e33f | 2021-02-18 14:39:52 +0100 | [diff] [blame] | 303 | SvcTestParam{"S3T3", /*num_temporal_units=*/8}, |
Danil Chapovalov | a13e7a1 | 2020-07-14 12:34:36 +0200 | [diff] [blame] | 304 | SvcTestParam{"L2T2", /*num_temporal_units=*/4}, |
| 305 | SvcTestParam{"L2T2_KEY", /*num_temporal_units=*/4}, |
Danil Chapovalov | 4b18e24 | 2020-10-16 16:14:58 +0200 | [diff] [blame] | 306 | SvcTestParam{"L2T2_KEY_SHIFT", /*num_temporal_units=*/4}, |
Emil Lundmark | c9b9930 | 2021-02-18 16:51:05 +0100 | [diff] [blame^] | 307 | SvcTestParam{"L2T3_KEY", /*num_temporal_units=*/8}, |
Danil Chapovalov | 4b18e24 | 2020-10-16 16:14:58 +0200 | [diff] [blame] | 308 | SvcTestParam{"L3T3_KEY", /*num_temporal_units=*/8}), |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 309 | [](const testing::TestParamInfo<SvcTestParam>& info) { |
| 310 | return info.param.name; |
| 311 | }); |
| 312 | |
Danil Chapovalov | 40f1fe9 | 2020-06-03 12:01:41 +0200 | [diff] [blame] | 313 | } // namespace |
| 314 | } // namespace webrtc |