blob: 31385754b7db532cc770d97ba7969aff2dda32f6 [file] [log] [blame]
Amit Hilbuchaa584152019-02-06 17:09:52 -08001/*
2 * Copyright 2019 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Mirko Bonadei317a1f02019-09-17 17:06:18 +020011#include <memory>
Amit Hilbuchaa584152019-02-06 17:09:52 -080012#include <ostream> // no-presubmit-check TODO(webrtc:8982)
13
14#include "absl/algorithm/container.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080015#include "api/audio_codecs/builtin_audio_decoder_factory.h"
16#include "api/audio_codecs/builtin_audio_encoder_factory.h"
17#include "api/create_peerconnection_factory.h"
Amit Hilbuchf4770402019-04-08 14:11:57 -070018#include "api/media_types.h"
19#include "api/rtc_error.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080020#include "api/rtp_transceiver_interface.h"
Amit Hilbuche2a284d2019-03-05 12:36:31 -080021#include "api/uma_metrics.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080022#include "api/video_codecs/builtin_video_decoder_factory.h"
23#include "api/video_codecs/builtin_video_encoder_factory.h"
24#include "pc/peer_connection.h"
25#include "pc/peer_connection_wrapper.h"
26#include "pc/test/fake_audio_capture_module.h"
27#include "pc/test/mock_peer_connection_observers.h"
28#include "rtc_base/gunit.h"
Amit Hilbuche2a284d2019-03-05 12:36:31 -080029#include "system_wrappers/include/metrics.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080030#include "test/gmock.h"
31
32using ::testing::Contains;
33using ::testing::Each;
34using ::testing::ElementsAre;
35using ::testing::ElementsAreArray;
36using ::testing::Eq;
37using ::testing::Field;
38using ::testing::IsEmpty;
39using ::testing::Ne;
Amit Hilbuche2a284d2019-03-05 12:36:31 -080040using ::testing::Pair;
Amit Hilbuchaa584152019-02-06 17:09:52 -080041using ::testing::Property;
42using ::testing::SizeIs;
43
44using cricket::MediaContentDescription;
45using cricket::RidDescription;
46using cricket::SimulcastDescription;
47using cricket::SimulcastLayer;
48using cricket::StreamParams;
49
50namespace cricket {
51
52std::ostream& operator<<( // no-presubmit-check TODO(webrtc:8982)
53 std::ostream& os, // no-presubmit-check TODO(webrtc:8982)
54 const SimulcastLayer& layer) {
55 if (layer.is_paused) {
56 os << "~";
57 }
58 return os << layer.rid;
59}
60
61} // namespace cricket
62
63namespace {
64
65std::vector<SimulcastLayer> CreateLayers(const std::vector<std::string>& rids,
66 const std::vector<bool>& active) {
67 RTC_DCHECK_EQ(rids.size(), active.size());
68 std::vector<SimulcastLayer> result;
69 absl::c_transform(rids, active, std::back_inserter(result),
70 [](const std::string& rid, bool is_active) {
71 return SimulcastLayer(rid, !is_active);
72 });
73 return result;
74}
75std::vector<SimulcastLayer> CreateLayers(const std::vector<std::string>& rids,
76 bool active) {
77 return CreateLayers(rids, std::vector<bool>(rids.size(), active));
78}
79
Ying Wangef3998f2019-12-09 13:06:53 +010080#if RTC_METRICS_ENABLED
Amit Hilbuche2a284d2019-03-05 12:36:31 -080081std::vector<SimulcastLayer> CreateLayers(int num_layers, bool active) {
82 rtc::UniqueStringGenerator rid_generator;
83 std::vector<std::string> rids;
84 for (int i = 0; i < num_layers; ++i) {
85 rids.push_back(rid_generator());
86 }
87 return CreateLayers(rids, active);
88}
Ying Wangef3998f2019-12-09 13:06:53 +010089#endif
Amit Hilbuche2a284d2019-03-05 12:36:31 -080090
Amit Hilbuchaa584152019-02-06 17:09:52 -080091} // namespace
Ying Wangef3998f2019-12-09 13:06:53 +010092
Amit Hilbuchaa584152019-02-06 17:09:52 -080093namespace webrtc {
94
Mirko Bonadei6a489f22019-04-09 15:11:12 +020095class PeerConnectionSimulcastTests : public ::testing::Test {
Amit Hilbuchaa584152019-02-06 17:09:52 -080096 public:
97 PeerConnectionSimulcastTests()
98 : pc_factory_(
99 CreatePeerConnectionFactory(rtc::Thread::Current(),
100 rtc::Thread::Current(),
101 rtc::Thread::Current(),
102 FakeAudioCaptureModule::Create(),
103 CreateBuiltinAudioEncoderFactory(),
104 CreateBuiltinAudioDecoderFactory(),
105 CreateBuiltinVideoEncoderFactory(),
106 CreateBuiltinVideoDecoderFactory(),
107 nullptr,
108 nullptr)) {}
109
110 rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection(
111 MockPeerConnectionObserver* observer) {
112 PeerConnectionInterface::RTCConfiguration config;
113 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
114 PeerConnectionDependencies pcd(observer);
115 auto pc = pc_factory_->CreatePeerConnection(config, std::move(pcd));
116 EXPECT_TRUE(pc);
117 observer->SetPeerConnectionInterface(pc);
118 return pc;
119 }
120
121 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWrapper() {
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200122 auto observer = std::make_unique<MockPeerConnectionObserver>();
Amit Hilbuchaa584152019-02-06 17:09:52 -0800123 auto pc = CreatePeerConnection(observer.get());
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200124 return std::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
125 std::move(observer));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800126 }
127
Amit Hilbuch619b2942019-02-26 15:55:19 -0800128 void ExchangeOfferAnswer(PeerConnectionWrapper* local,
129 PeerConnectionWrapper* remote,
130 const std::vector<SimulcastLayer>& answer_layers) {
131 auto offer = local->CreateOfferAndSetAsLocal();
132 // Remove simulcast as the second peer connection won't support it.
Amit Hilbuchaabd0362019-03-01 13:14:46 -0800133 RemoveSimulcast(offer.get());
Amit Hilbuch619b2942019-02-26 15:55:19 -0800134 std::string err;
135 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &err)) << err;
136 auto answer = remote->CreateAnswerAndSetAsLocal();
137 // Setup the answer to look like a server response.
138 auto mcd_answer = answer->description()->contents()[0].media_description();
139 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
140 for (const SimulcastLayer& layer : answer_layers) {
141 receive_layers.AddLayer(layer);
142 }
143 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &err)) << err;
144 }
145
Amit Hilbuchaa584152019-02-06 17:09:52 -0800146 RtpTransceiverInit CreateTransceiverInit(
147 const std::vector<SimulcastLayer>& layers) {
148 RtpTransceiverInit init;
149 for (const SimulcastLayer& layer : layers) {
150 RtpEncodingParameters encoding;
151 encoding.rid = layer.rid;
152 encoding.active = !layer.is_paused;
153 init.send_encodings.push_back(encoding);
154 }
155 return init;
156 }
157
158 rtc::scoped_refptr<RtpTransceiverInterface> AddTransceiver(
159 PeerConnectionWrapper* pc,
Florent Castellie1b685a2021-04-30 19:11:37 +0200160 const std::vector<SimulcastLayer>& layers,
161 cricket::MediaType media_type = cricket::MEDIA_TYPE_VIDEO) {
Amit Hilbuchaa584152019-02-06 17:09:52 -0800162 auto init = CreateTransceiverInit(layers);
Florent Castellie1b685a2021-04-30 19:11:37 +0200163 return pc->AddTransceiver(media_type, init);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800164 }
165
166 SimulcastDescription RemoveSimulcast(SessionDescriptionInterface* sd) {
167 auto mcd = sd->description()->contents()[0].media_description();
168 auto result = mcd->simulcast_description();
169 mcd->set_simulcast_description(SimulcastDescription());
170 return result;
171 }
172
173 void AddRequestToReceiveSimulcast(const std::vector<SimulcastLayer>& layers,
174 SessionDescriptionInterface* sd) {
175 auto mcd = sd->description()->contents()[0].media_description();
176 SimulcastDescription simulcast;
177 auto& receive_layers = simulcast.receive_layers();
178 for (const SimulcastLayer& layer : layers) {
179 receive_layers.AddLayer(layer);
180 }
181 mcd->set_simulcast_description(simulcast);
182 }
183
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800184 void ValidateTransceiverParameters(
Amit Hilbuchaa584152019-02-06 17:09:52 -0800185 rtc::scoped_refptr<RtpTransceiverInterface> transceiver,
186 const std::vector<SimulcastLayer>& layers) {
Amit Hilbuchaa584152019-02-06 17:09:52 -0800187 auto parameters = transceiver->sender()->GetParameters();
188 std::vector<SimulcastLayer> result_layers;
189 absl::c_transform(parameters.encodings, std::back_inserter(result_layers),
190 [](const RtpEncodingParameters& encoding) {
191 return SimulcastLayer(encoding.rid, !encoding.active);
192 });
193 EXPECT_THAT(result_layers, ElementsAreArray(layers));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800194 }
195
196 private:
197 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
198};
199
Ying Wangef3998f2019-12-09 13:06:53 +0100200#if RTC_METRICS_ENABLED
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800201// This class is used to test the metrics emitted for simulcast.
202class PeerConnectionSimulcastMetricsTests
203 : public PeerConnectionSimulcastTests,
204 public ::testing::WithParamInterface<int> {
205 protected:
206 PeerConnectionSimulcastMetricsTests() { webrtc::metrics::Reset(); }
207
208 std::map<int, int> LocalDescriptionSamples() {
209 return metrics::Samples(
210 "WebRTC.PeerConnection.Simulcast.ApplyLocalDescription");
211 }
212 std::map<int, int> RemoteDescriptionSamples() {
213 return metrics::Samples(
214 "WebRTC.PeerConnection.Simulcast.ApplyRemoteDescription");
215 }
216};
Ying Wangef3998f2019-12-09 13:06:53 +0100217#endif
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800218
Amit Hilbuchaa584152019-02-06 17:09:52 -0800219// Validates that RIDs are supported arguments when adding a transceiver.
220TEST_F(PeerConnectionSimulcastTests, CanCreateTransceiverWithRid) {
221 auto pc = CreatePeerConnectionWrapper();
222 auto layers = CreateLayers({"f"}, true);
223 auto transceiver = AddTransceiver(pc.get(), layers);
224 ASSERT_TRUE(transceiver);
225 auto parameters = transceiver->sender()->GetParameters();
226 // Single RID should be removed.
227 EXPECT_THAT(parameters.encodings,
Amit Hilbuch2297d332019-02-19 12:49:22 -0800228 ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq(""))));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800229}
230
231TEST_F(PeerConnectionSimulcastTests, CanCreateTransceiverWithSimulcast) {
232 auto pc = CreatePeerConnectionWrapper();
233 auto layers = CreateLayers({"f", "h", "q"}, true);
234 auto transceiver = AddTransceiver(pc.get(), layers);
235 ASSERT_TRUE(transceiver);
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800236 ValidateTransceiverParameters(transceiver, layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800237}
238
239TEST_F(PeerConnectionSimulcastTests, RidsAreAutogeneratedIfNotProvided) {
240 auto pc = CreatePeerConnectionWrapper();
241 auto init = CreateTransceiverInit(CreateLayers({"f", "h", "q"}, true));
242 for (RtpEncodingParameters& parameters : init.send_encodings) {
243 parameters.rid = "";
244 }
245 auto transceiver = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
246 auto parameters = transceiver->sender()->GetParameters();
247 ASSERT_EQ(3u, parameters.encodings.size());
248 EXPECT_THAT(parameters.encodings,
Amit Hilbuch2297d332019-02-19 12:49:22 -0800249 Each(Field("rid", &RtpEncodingParameters::rid, Ne(""))));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800250}
251
252// Validates that an error is returned when there is a mix of supplied and not
253// supplied RIDs in a call to AddTransceiver.
254TEST_F(PeerConnectionSimulcastTests, MustSupplyAllOrNoRidsInSimulcast) {
255 auto pc_wrapper = CreatePeerConnectionWrapper();
256 auto pc = pc_wrapper->pc();
257 // Cannot create a layer with empty RID. Remove the RID after init is created.
258 auto layers = CreateLayers({"f", "h", "remove"}, true);
259 auto init = CreateTransceiverInit(layers);
260 init.send_encodings[2].rid = "";
261 auto error = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
262 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, error.error().type());
263}
264
Amit Hilbuchf4770402019-04-08 14:11:57 -0700265// Validates that an error is returned when illegal RIDs are supplied.
266TEST_F(PeerConnectionSimulcastTests, ChecksForIllegalRidValues) {
267 auto pc_wrapper = CreatePeerConnectionWrapper();
268 auto pc = pc_wrapper->pc();
269 auto layers = CreateLayers({"f", "h", "~q"}, true);
270 auto init = CreateTransceiverInit(layers);
271 auto error = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
272 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, error.error().type());
273}
274
Amit Hilbuch2297d332019-02-19 12:49:22 -0800275// Validates that a single RID is removed from the encoding layer.
Amit Hilbuchaa584152019-02-06 17:09:52 -0800276TEST_F(PeerConnectionSimulcastTests, SingleRidIsRemovedFromSessionDescription) {
277 auto pc = CreatePeerConnectionWrapper();
278 auto transceiver = AddTransceiver(pc.get(), CreateLayers({"1"}, true));
279 auto offer = pc->CreateOfferAndSetAsLocal();
280 ASSERT_TRUE(offer);
281 auto contents = offer->description()->contents();
282 ASSERT_EQ(1u, contents.size());
283 EXPECT_THAT(contents[0].media_description()->streams(),
284 ElementsAre(Property(&StreamParams::has_rids, false)));
285}
286
287TEST_F(PeerConnectionSimulcastTests, SimulcastLayersRemovedFromTail) {
288 static_assert(
289 kMaxSimulcastStreams < 8,
290 "Test assumes that the platform does not allow 8 simulcast layers");
291 auto pc = CreatePeerConnectionWrapper();
292 auto layers = CreateLayers({"1", "2", "3", "4", "5", "6", "7", "8"}, true);
293 std::vector<SimulcastLayer> expected_layers;
294 std::copy_n(layers.begin(), kMaxSimulcastStreams,
295 std::back_inserter(expected_layers));
296 auto transceiver = AddTransceiver(pc.get(), layers);
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800297 ValidateTransceiverParameters(transceiver, expected_layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800298}
299
300// Checks that an offfer to send simulcast contains a SimulcastDescription.
301TEST_F(PeerConnectionSimulcastTests, SimulcastAppearsInSessionDescription) {
302 auto pc = CreatePeerConnectionWrapper();
303 std::vector<std::string> rids({"f", "h", "q"});
304 auto layers = CreateLayers(rids, true);
305 auto transceiver = AddTransceiver(pc.get(), layers);
306 auto offer = pc->CreateOffer();
307 ASSERT_TRUE(offer);
308 auto contents = offer->description()->contents();
309 ASSERT_EQ(1u, contents.size());
310 auto content = contents[0];
311 auto mcd = content.media_description();
312 ASSERT_TRUE(mcd->HasSimulcast());
313 auto simulcast = mcd->simulcast_description();
314 EXPECT_THAT(simulcast.receive_layers(), IsEmpty());
315 // The size is validated separately because GetAllLayers() flattens the list.
316 EXPECT_THAT(simulcast.send_layers(), SizeIs(3));
317 std::vector<SimulcastLayer> result = simulcast.send_layers().GetAllLayers();
318 EXPECT_THAT(result, ElementsAreArray(layers));
319 auto streams = mcd->streams();
320 ASSERT_EQ(1u, streams.size());
321 auto stream = streams[0];
322 EXPECT_FALSE(stream.has_ssrcs());
323 EXPECT_TRUE(stream.has_rids());
324 std::vector<std::string> result_rids;
325 absl::c_transform(stream.rids(), std::back_inserter(result_rids),
326 [](const RidDescription& rid) { return rid.rid; });
327 EXPECT_THAT(result_rids, ElementsAreArray(rids));
328}
329
330// Checks that Simulcast layers propagate to the sender parameters.
331TEST_F(PeerConnectionSimulcastTests, SimulcastLayersAreSetInSender) {
332 auto local = CreatePeerConnectionWrapper();
333 auto remote = CreatePeerConnectionWrapper();
334 auto layers = CreateLayers({"f", "h", "q"}, true);
335 auto transceiver = AddTransceiver(local.get(), layers);
336 auto offer = local->CreateOfferAndSetAsLocal();
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800337 {
338 SCOPED_TRACE("after create offer");
339 ValidateTransceiverParameters(transceiver, layers);
340 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800341 // Remove simulcast as the second peer connection won't support it.
342 auto simulcast = RemoveSimulcast(offer.get());
343 std::string error;
344 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
345 auto answer = remote->CreateAnswerAndSetAsLocal();
346
347 // Setup an answer that mimics a server accepting simulcast.
348 auto mcd_answer = answer->description()->contents()[0].media_description();
349 mcd_answer->mutable_streams().clear();
350 auto simulcast_layers = simulcast.send_layers().GetAllLayers();
351 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
352 for (const auto& layer : simulcast_layers) {
353 receive_layers.AddLayer(layer);
354 }
355 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800356 {
357 SCOPED_TRACE("after set remote");
358 ValidateTransceiverParameters(transceiver, layers);
359 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800360}
361
362// Checks that paused Simulcast layers propagate to the sender parameters.
363TEST_F(PeerConnectionSimulcastTests, PausedSimulcastLayersAreDisabledInSender) {
364 auto local = CreatePeerConnectionWrapper();
365 auto remote = CreatePeerConnectionWrapper();
366 auto layers = CreateLayers({"f", "h", "q"}, {true, false, true});
367 auto server_layers = CreateLayers({"f", "h", "q"}, {true, false, false});
368 RTC_DCHECK_EQ(layers.size(), server_layers.size());
369 auto transceiver = AddTransceiver(local.get(), layers);
370 auto offer = local->CreateOfferAndSetAsLocal();
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800371 {
372 SCOPED_TRACE("after create offer");
373 ValidateTransceiverParameters(transceiver, layers);
374 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800375
376 // Remove simulcast as the second peer connection won't support it.
377 RemoveSimulcast(offer.get());
378 std::string error;
379 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
380 auto answer = remote->CreateAnswerAndSetAsLocal();
381
382 // Setup an answer that mimics a server accepting simulcast.
383 auto mcd_answer = answer->description()->contents()[0].media_description();
384 mcd_answer->mutable_streams().clear();
385 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
386 for (const SimulcastLayer& layer : server_layers) {
387 receive_layers.AddLayer(layer);
388 }
389 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800390 {
391 SCOPED_TRACE("after set remote");
392 ValidateTransceiverParameters(transceiver, server_layers);
393 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800394}
395
396// Checks that when Simulcast is not supported by the remote party, then all
Amit Hilbuch2297d332019-02-19 12:49:22 -0800397// the layers (except the first) are removed.
398TEST_F(PeerConnectionSimulcastTests, SimulcastRejectedRemovesExtraLayers) {
Amit Hilbuchaa584152019-02-06 17:09:52 -0800399 auto local = CreatePeerConnectionWrapper();
400 auto remote = CreatePeerConnectionWrapper();
401 auto layers = CreateLayers({"1", "2", "3", "4"}, true);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800402 auto transceiver = AddTransceiver(local.get(), layers);
Amit Hilbuch619b2942019-02-26 15:55:19 -0800403 ExchangeOfferAnswer(local.get(), remote.get(), {});
Amit Hilbuch2297d332019-02-19 12:49:22 -0800404 auto parameters = transceiver->sender()->GetParameters();
405 // Should only have the first layer.
406 EXPECT_THAT(parameters.encodings,
407 ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq("1"))));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800408}
409
Amit Hilbuch2297d332019-02-19 12:49:22 -0800410// Checks that if Simulcast is supported by remote party, but some layers are
411// rejected, then only rejected layers are removed from the sender.
Amit Hilbuchaa584152019-02-06 17:09:52 -0800412TEST_F(PeerConnectionSimulcastTests, RejectedSimulcastLayersAreDeactivated) {
413 auto local = CreatePeerConnectionWrapper();
414 auto remote = CreatePeerConnectionWrapper();
Florent Castelli3fbf1e22019-07-04 17:09:05 +0200415 auto layers = CreateLayers({"1", "2", "3"}, true);
416 auto expected_layers = CreateLayers({"2", "3"}, true);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800417 auto transceiver = AddTransceiver(local.get(), layers);
418 auto offer = local->CreateOfferAndSetAsLocal();
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800419 {
420 SCOPED_TRACE("after create offer");
421 ValidateTransceiverParameters(transceiver, layers);
422 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800423 // Remove simulcast as the second peer connection won't support it.
424 auto removed_simulcast = RemoveSimulcast(offer.get());
425 std::string error;
426 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
427 auto answer = remote->CreateAnswerAndSetAsLocal();
428 auto mcd_answer = answer->description()->contents()[0].media_description();
429 // Setup the answer to look like a server response.
430 // Remove one of the layers to reject it in the answer.
431 auto simulcast_layers = removed_simulcast.send_layers().GetAllLayers();
432 simulcast_layers.erase(simulcast_layers.begin());
433 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
434 for (const auto& layer : simulcast_layers) {
435 receive_layers.AddLayer(layer);
436 }
437 ASSERT_TRUE(mcd_answer->HasSimulcast());
438 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800439 {
440 SCOPED_TRACE("after set remote");
441 ValidateTransceiverParameters(transceiver, expected_layers);
442 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800443}
444
445// Checks that simulcast is set up correctly when the server sends an offer
446// requesting to receive simulcast.
447TEST_F(PeerConnectionSimulcastTests, ServerSendsOfferToReceiveSimulcast) {
448 auto local = CreatePeerConnectionWrapper();
449 auto remote = CreatePeerConnectionWrapper();
450 auto layers = CreateLayers({"f", "h", "q"}, true);
451 AddTransceiver(local.get(), layers);
452 auto offer = local->CreateOfferAndSetAsLocal();
453 // Remove simulcast as a sender and set it up as a receiver.
454 RemoveSimulcast(offer.get());
455 AddRequestToReceiveSimulcast(layers, offer.get());
456 std::string error;
457 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
458 auto transceiver = remote->pc()->GetTransceivers()[0];
Harald Alvestrand6060df52020-08-11 09:54:02 +0200459 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendRecv);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800460 EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal());
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800461 ValidateTransceiverParameters(transceiver, layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800462}
463
464// Checks that SetRemoteDescription doesn't attempt to associate a transceiver
465// when simulcast is requested by the server.
466TEST_F(PeerConnectionSimulcastTests, TransceiverIsNotRecycledWithSimulcast) {
467 auto local = CreatePeerConnectionWrapper();
468 auto remote = CreatePeerConnectionWrapper();
469 auto layers = CreateLayers({"f", "h", "q"}, true);
470 AddTransceiver(local.get(), layers);
471 auto offer = local->CreateOfferAndSetAsLocal();
472 // Remove simulcast as a sender and set it up as a receiver.
473 RemoveSimulcast(offer.get());
474 AddRequestToReceiveSimulcast(layers, offer.get());
475 // Call AddTrack so that a transceiver is created.
476 remote->AddVideoTrack("fake_track");
477 std::string error;
478 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
479 auto transceivers = remote->pc()->GetTransceivers();
480 ASSERT_EQ(2u, transceivers.size());
481 auto transceiver = transceivers[1];
Harald Alvestrand6060df52020-08-11 09:54:02 +0200482 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendRecv);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800483 EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal());
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800484 ValidateTransceiverParameters(transceiver, layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800485}
486
Amit Hilbuch619b2942019-02-26 15:55:19 -0800487// Checks that if the number of layers changes during negotiation, then any
488// outstanding get/set parameters transaction is invalidated.
489TEST_F(PeerConnectionSimulcastTests, ParametersAreInvalidatedWhenLayersChange) {
490 auto local = CreatePeerConnectionWrapper();
491 auto remote = CreatePeerConnectionWrapper();
492 auto layers = CreateLayers({"1", "2", "3"}, true);
493 auto transceiver = AddTransceiver(local.get(), layers);
494 auto parameters = transceiver->sender()->GetParameters();
495 ASSERT_EQ(3u, parameters.encodings.size());
496 // Response will reject simulcast altogether.
497 ExchangeOfferAnswer(local.get(), remote.get(), {});
498 auto result = transceiver->sender()->SetParameters(parameters);
499 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.type());
500}
501
502// Checks that even though negotiation modifies the sender's parameters, an
503// outstanding get/set parameters transaction is not invalidated.
504// This test negotiates twice because initial parameters before negotiation
505// is missing critical information and cannot be set on the sender.
506TEST_F(PeerConnectionSimulcastTests,
507 NegotiationDoesNotInvalidateParameterTransactions) {
508 auto local = CreatePeerConnectionWrapper();
509 auto remote = CreatePeerConnectionWrapper();
510 auto layers = CreateLayers({"1", "2", "3"}, true);
511 auto expected_layers = CreateLayers({"1", "2", "3"}, false);
512 auto transceiver = AddTransceiver(local.get(), layers);
513 ExchangeOfferAnswer(local.get(), remote.get(), expected_layers);
514
515 // Verify that negotiation does not invalidate the parameters.
516 auto parameters = transceiver->sender()->GetParameters();
517 ExchangeOfferAnswer(local.get(), remote.get(), expected_layers);
518
519 auto result = transceiver->sender()->SetParameters(parameters);
520 EXPECT_TRUE(result.ok());
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800521 ValidateTransceiverParameters(transceiver, expected_layers);
Amit Hilbuch619b2942019-02-26 15:55:19 -0800522}
523
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800524// Tests that simulcast is disabled if the RID extension is not negotiated
525// regardless of if the RIDs and simulcast attribute were negotiated properly.
Amit Hilbuchaabd0362019-03-01 13:14:46 -0800526TEST_F(PeerConnectionSimulcastTests, NegotiationDoesNotHaveRidExtension) {
527 auto local = CreatePeerConnectionWrapper();
528 auto remote = CreatePeerConnectionWrapper();
529 auto layers = CreateLayers({"1", "2", "3"}, true);
530 auto expected_layers = CreateLayers({"1"}, true);
531 auto transceiver = AddTransceiver(local.get(), layers);
532 auto offer = local->CreateOfferAndSetAsLocal();
533 // Remove simulcast as the second peer connection won't support it.
534 RemoveSimulcast(offer.get());
535 std::string err;
536 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &err)) << err;
537 auto answer = remote->CreateAnswerAndSetAsLocal();
538 // Setup the answer to look like a server response.
539 // Drop the RID header extension.
540 auto mcd_answer = answer->description()->contents()[0].media_description();
541 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
542 for (const SimulcastLayer& layer : layers) {
543 receive_layers.AddLayer(layer);
544 }
545 cricket::RtpHeaderExtensions extensions;
546 for (auto extension : mcd_answer->rtp_header_extensions()) {
547 if (extension.uri != RtpExtension::kRidUri) {
548 extensions.push_back(extension);
549 }
550 }
551 mcd_answer->set_rtp_header_extensions(extensions);
552 EXPECT_EQ(layers.size(), mcd_answer->simulcast_description()
553 .receive_layers()
554 .GetAllLayers()
555 .size());
556 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &err)) << err;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800557 ValidateTransceiverParameters(transceiver, expected_layers);
Amit Hilbuchaabd0362019-03-01 13:14:46 -0800558}
Ying Wangef3998f2019-12-09 13:06:53 +0100559
Florent Castellie1b685a2021-04-30 19:11:37 +0200560TEST_F(PeerConnectionSimulcastTests, SimulcastAudioRejected) {
561 auto local = CreatePeerConnectionWrapper();
562 auto remote = CreatePeerConnectionWrapper();
563 auto layers = CreateLayers({"1", "2", "3", "4"}, true);
564 auto transceiver =
565 AddTransceiver(local.get(), layers, cricket::MEDIA_TYPE_AUDIO);
566 // Should only have the first layer.
567 auto parameters = transceiver->sender()->GetParameters();
568 EXPECT_EQ(1u, parameters.encodings.size());
569 EXPECT_THAT(parameters.encodings,
570 ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq(""))));
571 ExchangeOfferAnswer(local.get(), remote.get(), {});
572 // Still have a single layer after negotiation
573 parameters = transceiver->sender()->GetParameters();
574 EXPECT_EQ(1u, parameters.encodings.size());
575 EXPECT_THAT(parameters.encodings,
576 ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq(""))));
577}
578
Ying Wangef3998f2019-12-09 13:06:53 +0100579#if RTC_METRICS_ENABLED
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800580//
581// Checks the logged metrics when simulcast is not used.
582TEST_F(PeerConnectionSimulcastMetricsTests, NoSimulcastUsageIsLogged) {
583 auto local = CreatePeerConnectionWrapper();
584 auto remote = CreatePeerConnectionWrapper();
585 auto layers = CreateLayers(0, true);
586 AddTransceiver(local.get(), layers);
587 ExchangeOfferAnswer(local.get(), remote.get(), layers);
588
589 EXPECT_THAT(LocalDescriptionSamples(),
590 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
591 EXPECT_THAT(RemoteDescriptionSamples(),
592 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
593}
594
595// Checks the logged metrics when spec-compliant simulcast is used.
596TEST_F(PeerConnectionSimulcastMetricsTests, SpecComplianceIsLogged) {
597 auto local = CreatePeerConnectionWrapper();
598 auto remote = CreatePeerConnectionWrapper();
599 auto layers = CreateLayers(3, true);
600 AddTransceiver(local.get(), layers);
601 ExchangeOfferAnswer(local.get(), remote.get(), layers);
602
603 // Expecting 2 invocations of each, because we have 2 peer connections.
604 // Only the local peer connection will be aware of simulcast.
605 // The remote peer connection will think that there is no simulcast.
606 EXPECT_THAT(LocalDescriptionSamples(),
607 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
608 Pair(kSimulcastApiVersionSpecCompliant, 1)));
609 EXPECT_THAT(RemoteDescriptionSamples(),
610 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
611 Pair(kSimulcastApiVersionSpecCompliant, 1)));
612}
613
614// Checks the logged metrics when and incoming request to send spec-compliant
615// simulcast is received from the remote party.
616TEST_F(PeerConnectionSimulcastMetricsTests, IncomingSimulcastIsLogged) {
617 auto local = CreatePeerConnectionWrapper();
618 auto remote = CreatePeerConnectionWrapper();
619 auto layers = CreateLayers(3, true);
620 AddTransceiver(local.get(), layers);
621 auto offer = local->CreateOfferAndSetAsLocal();
622 EXPECT_THAT(LocalDescriptionSamples(),
623 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1)));
624
625 // Remove simulcast as a sender and set it up as a receiver.
626 RemoveSimulcast(offer.get());
627 AddRequestToReceiveSimulcast(layers, offer.get());
628 std::string error;
629 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
630 EXPECT_THAT(RemoteDescriptionSamples(),
631 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1)));
632
633 auto transceiver = remote->pc()->GetTransceivers()[0];
Harald Alvestrand6060df52020-08-11 09:54:02 +0200634 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendRecv);
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800635 EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal());
636 EXPECT_THAT(LocalDescriptionSamples(),
637 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 2)));
638}
639
640// Checks that a spec-compliant simulcast offer that is rejected is logged.
641TEST_F(PeerConnectionSimulcastMetricsTests, RejectedSimulcastIsLogged) {
642 auto local = CreatePeerConnectionWrapper();
643 auto remote = CreatePeerConnectionWrapper();
644 auto layers = CreateLayers({"1", "2", "3"}, true);
645 AddTransceiver(local.get(), layers);
646 auto offer = local->CreateOfferAndSetAsLocal();
647 EXPECT_THAT(LocalDescriptionSamples(),
648 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1)));
649 RemoveSimulcast(offer.get());
650 std::string error;
651 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
652 EXPECT_THAT(RemoteDescriptionSamples(),
653 ElementsAre(Pair(kSimulcastApiVersionNone, 1)));
654
655 auto answer = remote->CreateAnswerAndSetAsLocal();
656 EXPECT_THAT(LocalDescriptionSamples(),
657 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
658 Pair(kSimulcastApiVersionSpecCompliant, 1)));
659 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
660 EXPECT_THAT(RemoteDescriptionSamples(),
661 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
662}
663
664// Checks the logged metrics when legacy munging simulcast technique is used.
665TEST_F(PeerConnectionSimulcastMetricsTests, LegacySimulcastIsLogged) {
666 auto local = CreatePeerConnectionWrapper();
667 auto remote = CreatePeerConnectionWrapper();
668 auto layers = CreateLayers(0, true);
669 AddTransceiver(local.get(), layers);
670 auto offer = local->CreateOffer();
671 // Munge the SDP to set up legacy simulcast.
672 const std::string end_line = "\r\n";
673 std::string sdp;
674 offer->ToString(&sdp);
675 rtc::StringBuilder builder(sdp);
676 builder << "a=ssrc:1111 cname:slimshady" << end_line;
677 builder << "a=ssrc:2222 cname:slimshady" << end_line;
678 builder << "a=ssrc:3333 cname:slimshady" << end_line;
679 builder << "a=ssrc-group:SIM 1111 2222 3333" << end_line;
680
681 SdpParseError parse_error;
682 auto sd =
683 CreateSessionDescription(SdpType::kOffer, builder.str(), &parse_error);
684 ASSERT_TRUE(sd) << parse_error.line << parse_error.description;
685 std::string error;
686 EXPECT_TRUE(local->SetLocalDescription(std::move(sd), &error)) << error;
687 EXPECT_THAT(LocalDescriptionSamples(),
688 ElementsAre(Pair(kSimulcastApiVersionLegacy, 1)));
689 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
690 EXPECT_THAT(RemoteDescriptionSamples(),
691 ElementsAre(Pair(kSimulcastApiVersionNone, 1)));
692 auto answer = remote->CreateAnswerAndSetAsLocal();
693 EXPECT_THAT(LocalDescriptionSamples(),
694 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
695 Pair(kSimulcastApiVersionLegacy, 1)));
696 // Legacy simulcast is not signaled in remote description.
697 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
698 EXPECT_THAT(RemoteDescriptionSamples(),
699 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
700}
701
702// Checks that disabling simulcast is logged in the metrics.
703TEST_F(PeerConnectionSimulcastMetricsTests, SimulcastDisabledIsLogged) {
704 auto local = CreatePeerConnectionWrapper();
705 auto remote = CreatePeerConnectionWrapper();
706 auto layers = CreateLayers({"1", "2", "3"}, true);
707 AddTransceiver(local.get(), layers);
708 auto offer = local->CreateOfferAndSetAsLocal();
709 RemoveSimulcast(offer.get());
710 std::string error;
711 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
712 auto answer = remote->CreateAnswerAndSetAsLocal();
713 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
714
715 EXPECT_EQ(1, metrics::NumSamples("WebRTC.PeerConnection.Simulcast.Disabled"));
716 EXPECT_EQ(1,
717 metrics::NumEvents("WebRTC.PeerConnection.Simulcast.Disabled", 1));
718}
719
720// Checks that the disabled metric is not logged if simulcast is not disabled.
721TEST_F(PeerConnectionSimulcastMetricsTests, SimulcastDisabledIsNotLogged) {
722 auto local = CreatePeerConnectionWrapper();
723 auto remote = CreatePeerConnectionWrapper();
724 auto layers = CreateLayers({"1", "2", "3"}, true);
725 AddTransceiver(local.get(), layers);
726 ExchangeOfferAnswer(local.get(), remote.get(), layers);
727
728 EXPECT_EQ(0, metrics::NumSamples("WebRTC.PeerConnection.Simulcast.Disabled"));
729}
730
731const int kMaxLayersInMetricsTest = 8;
732
733// Checks that the number of send encodings is logged in a metric.
734TEST_P(PeerConnectionSimulcastMetricsTests, NumberOfSendEncodingsIsLogged) {
735 auto local = CreatePeerConnectionWrapper();
736 auto num_layers = GetParam();
737 auto layers = CreateLayers(num_layers, true);
738 AddTransceiver(local.get(), layers);
739 EXPECT_EQ(1, metrics::NumSamples(
740 "WebRTC.PeerConnection.Simulcast.NumberOfSendEncodings"));
741 EXPECT_EQ(1, metrics::NumEvents(
742 "WebRTC.PeerConnection.Simulcast.NumberOfSendEncodings",
743 num_layers));
744}
745
746INSTANTIATE_TEST_SUITE_P(NumberOfSendEncodings,
747 PeerConnectionSimulcastMetricsTests,
748 ::testing::Range(0, kMaxLayersInMetricsTest));
Ying Wangef3998f2019-12-09 13:06:53 +0100749#endif
Amit Hilbuchaa584152019-02-06 17:09:52 -0800750} // namespace webrtc