blob: fac738b7bab042056224d3dbb487c6d1eba92ec0 [file] [log] [blame]
Henrik Boström933d8b02017-10-10 10:05:16 -07001/*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
Yves Gerey3e707812018-11-28 16:47:49 +010011#include <stdint.h>
Jonas Olssona4d87372019-07-05 19:08:33 +020012
Henrik Boström933d8b02017-10-10 10:05:16 -070013#include <memory>
Yves Gerey3e707812018-11-28 16:47:49 +010014#include <string>
15#include <utility>
Henrik Boström933d8b02017-10-10 10:05:16 -070016#include <vector>
17
Yves Gerey3e707812018-11-28 16:47:49 +010018#include "absl/types/optional.h"
19#include "api/audio/audio_mixer.h"
20#include "api/audio_codecs/audio_decoder_factory.h"
21#include "api/audio_codecs/audio_encoder_factory.h"
Karl Wiberg1b0eae32017-10-17 14:48:54 +020022#include "api/audio_codecs/builtin_audio_decoder_factory.h"
23#include "api/audio_codecs/builtin_audio_encoder_factory.h"
Mirko Bonadei2ff3f492018-11-22 09:00:13 +010024#include "api/create_peerconnection_factory.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070025#include "api/jsep.h"
Steve Anton10542f22019-01-11 09:11:00 -080026#include "api/media_stream_interface.h"
27#include "api/media_types.h"
28#include "api/peer_connection_interface.h"
29#include "api/rtc_error.h"
30#include "api/rtp_parameters.h"
31#include "api/rtp_receiver_interface.h"
32#include "api/rtp_sender_interface.h"
33#include "api/rtp_transceiver_interface.h"
Mirko Bonadeid9708072019-01-25 20:26:48 +010034#include "api/scoped_refptr.h"
Steve Anton10542f22019-01-11 09:11:00 -080035#include "api/set_remote_description_observer_interface.h"
36#include "api/uma_metrics.h"
Anders Carlsson67537952018-05-03 11:28:29 +020037#include "api/video_codecs/builtin_video_decoder_factory.h"
38#include "api/video_codecs/builtin_video_encoder_factory.h"
Yves Gerey3e707812018-11-28 16:47:49 +010039#include "api/video_codecs/video_decoder_factory.h"
40#include "api/video_codecs/video_encoder_factory.h"
Steve Anton10542f22019-01-11 09:11:00 -080041#include "media/base/stream_params.h"
Yves Gerey3e707812018-11-28 16:47:49 +010042#include "modules/audio_device/include/audio_device.h"
43#include "modules/audio_processing/include/audio_processing.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "p2p/base/port_allocator.h"
45#include "pc/media_session.h"
46#include "pc/peer_connection_wrapper.h"
47#include "pc/sdp_utils.h"
48#include "pc/session_description.h"
49#include "pc/test/fake_audio_capture_module.h"
50#include "pc/test/mock_peer_connection_observers.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070051#include "rtc_base/checks.h"
52#include "rtc_base/gunit.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "rtc_base/ref_counted_object.h"
54#include "rtc_base/rtc_certificate_generator.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070055#include "rtc_base/thread.h"
Mirko Bonadei17f48782018-09-28 08:51:10 +020056#include "system_wrappers/include/metrics.h"
Steve Anton9158ef62017-11-27 13:01:52 -080057#include "test/gmock.h"
Yves Gerey3e707812018-11-28 16:47:49 +010058#include "test/gtest.h"
Henrik Boström933d8b02017-10-10 10:05:16 -070059
60// This file contains tests for RTP Media API-related behavior of
Artem Titovcfea2182021-08-10 01:22:31 +020061// `webrtc::PeerConnection`, see https://w3c.github.io/webrtc-pc/#rtp-media-api.
Henrik Boström933d8b02017-10-10 10:05:16 -070062
Steve Anton9158ef62017-11-27 13:01:52 -080063namespace webrtc {
64
65using RTCConfiguration = PeerConnectionInterface::RTCConfiguration;
66using ::testing::ElementsAre;
Steve Antonc1e6e862019-03-04 14:43:44 -080067using ::testing::Pair;
Steve Anton9158ef62017-11-27 13:01:52 -080068using ::testing::UnorderedElementsAre;
Steve Anton3172c032018-05-03 15:30:18 -070069using ::testing::Values;
Henrik Boström933d8b02017-10-10 10:05:16 -070070
Henrik Boström31638672017-11-23 17:48:32 +010071const uint32_t kDefaultTimeout = 10000u;
72
73template <typename MethodFunctor>
74class OnSuccessObserver : public rtc::RefCountedObject<
75 webrtc::SetRemoteDescriptionObserverInterface> {
76 public:
77 explicit OnSuccessObserver(MethodFunctor on_success)
78 : on_success_(std::move(on_success)) {}
79
80 // webrtc::SetRemoteDescriptionObserverInterface implementation.
81 void OnSetRemoteDescriptionComplete(webrtc::RTCError error) override {
82 RTC_CHECK(error.ok());
83 on_success_();
84 }
85
86 private:
87 MethodFunctor on_success_;
88};
89
Mirko Bonadei6a489f22019-04-09 15:11:12 +020090class PeerConnectionRtpBaseTest : public ::testing::Test {
Henrik Boström933d8b02017-10-10 10:05:16 -070091 public:
Steve Anton3172c032018-05-03 15:30:18 -070092 explicit PeerConnectionRtpBaseTest(SdpSemantics sdp_semantics)
93 : sdp_semantics_(sdp_semantics),
94 pc_factory_(
Steve Anton9158ef62017-11-27 13:01:52 -080095 CreatePeerConnectionFactory(rtc::Thread::Current(),
96 rtc::Thread::Current(),
97 rtc::Thread::Current(),
98 FakeAudioCaptureModule::Create(),
99 CreateBuiltinAudioEncoderFactory(),
100 CreateBuiltinAudioDecoderFactory(),
Anders Carlsson67537952018-05-03 11:28:29 +0200101 CreateBuiltinVideoEncoderFactory(),
102 CreateBuiltinVideoDecoderFactory(),
103 nullptr /* audio_mixer */,
Qingsi Wang7fc821d2018-07-12 12:54:53 -0700104 nullptr /* audio_processing */)) {
105 webrtc::metrics::Reset();
106 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700107
Steve Anton9158ef62017-11-27 13:01:52 -0800108 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection() {
109 return CreatePeerConnection(RTCConfiguration());
110 }
111
Steve Antone831b8c2018-02-01 12:22:16 -0800112 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithPlanB() {
113 RTCConfiguration config;
114 config.sdp_semantics = SdpSemantics::kPlanB;
Steve Anton3172c032018-05-03 15:30:18 -0700115 return CreatePeerConnectionInternal(config);
Steve Antone831b8c2018-02-01 12:22:16 -0800116 }
117
Steve Anton9158ef62017-11-27 13:01:52 -0800118 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWithUnifiedPlan() {
119 RTCConfiguration config;
120 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
Steve Anton3172c032018-05-03 15:30:18 -0700121 return CreatePeerConnectionInternal(config);
Steve Anton9158ef62017-11-27 13:01:52 -0800122 }
123
124 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnection(
125 const RTCConfiguration& config) {
Steve Anton3172c032018-05-03 15:30:18 -0700126 RTCConfiguration modified_config = config;
127 modified_config.sdp_semantics = sdp_semantics_;
128 return CreatePeerConnectionInternal(modified_config);
129 }
130
131 protected:
132 const SdpSemantics sdp_semantics_;
133 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
134
135 private:
136 // Private so that tests don't accidentally bypass the SdpSemantics
137 // adjustment.
138 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionInternal(
139 const RTCConfiguration& config) {
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200140 auto observer = std::make_unique<MockPeerConnectionObserver>();
Henrik Boström933d8b02017-10-10 10:05:16 -0700141 auto pc = pc_factory_->CreatePeerConnection(config, nullptr, nullptr,
142 observer.get());
Yves Gerey4e933292018-10-31 15:36:05 +0100143 EXPECT_TRUE(pc.get());
144 observer->SetPeerConnectionInterface(pc.get());
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200145 return std::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
146 std::move(observer));
Henrik Boström933d8b02017-10-10 10:05:16 -0700147 }
Steve Anton3172c032018-05-03 15:30:18 -0700148};
Henrik Boström933d8b02017-10-10 10:05:16 -0700149
Steve Anton3172c032018-05-03 15:30:18 -0700150class PeerConnectionRtpTest
151 : public PeerConnectionRtpBaseTest,
152 public ::testing::WithParamInterface<SdpSemantics> {
Henrik Boström933d8b02017-10-10 10:05:16 -0700153 protected:
Steve Anton3172c032018-05-03 15:30:18 -0700154 PeerConnectionRtpTest() : PeerConnectionRtpBaseTest(GetParam()) {}
155};
156
157class PeerConnectionRtpTestPlanB : public PeerConnectionRtpBaseTest {
158 protected:
159 PeerConnectionRtpTestPlanB()
160 : PeerConnectionRtpBaseTest(SdpSemantics::kPlanB) {}
161};
162
163class PeerConnectionRtpTestUnifiedPlan : public PeerConnectionRtpBaseTest {
164 protected:
165 PeerConnectionRtpTestUnifiedPlan()
166 : PeerConnectionRtpBaseTest(SdpSemantics::kUnifiedPlan) {}
Harald Alvestrand09bd9ba2020-10-09 08:13:30 +0000167
168 // Helper to emulate an SFU that rejects an offered media section
169 // in answer.
170 bool ExchangeOfferAnswerWhereRemoteStopsTransceiver(
171 PeerConnectionWrapper* caller,
172 PeerConnectionWrapper* callee,
173 size_t mid_to_stop) {
174 auto offer = caller->CreateOffer();
175 caller->SetLocalDescription(CloneSessionDescription(offer.get()));
176 callee->SetRemoteDescription(std::move(offer));
177 EXPECT_LT(mid_to_stop, callee->pc()->GetTransceivers().size());
178 // Must use StopInternal in order to do instant reject.
179 callee->pc()->GetTransceivers()[mid_to_stop]->StopInternal();
180 auto answer = callee->CreateAnswer();
181 EXPECT_TRUE(answer);
182 bool set_local_answer =
183 callee->SetLocalDescription(CloneSessionDescription(answer.get()));
184 EXPECT_TRUE(set_local_answer);
185 bool set_remote_answer = caller->SetRemoteDescription(std::move(answer));
186 EXPECT_TRUE(set_remote_answer);
187 return set_remote_answer;
188 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700189};
190
Artem Titovcfea2182021-08-10 01:22:31 +0200191// These tests cover `webrtc::PeerConnectionObserver` callbacks firing upon
Henrik Boström31638672017-11-23 17:48:32 +0100192// setting the remote description.
Henrik Boström31638672017-11-23 17:48:32 +0100193
Steve Anton3172c032018-05-03 15:30:18 -0700194TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700195 auto caller = CreatePeerConnection();
196 auto callee = CreatePeerConnection();
197
Steve Anton3172c032018-05-03 15:30:18 -0700198 ASSERT_TRUE(caller->AddAudioTrack("audio_track"));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700199 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700200
Henrik Boström31638672017-11-23 17:48:32 +0100201 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700202 const auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100203 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Steve Anton3172c032018-05-03 15:30:18 -0700204
205 if (sdp_semantics_ == SdpSemantics::kPlanB) {
206 // Since we are not supporting the no stream case with Plan B, there should
207 // be a generated stream, even though we didn't set one with AddTrack.
208 ASSERT_EQ(1u, add_track_event.streams.size());
209 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
210 } else {
211 EXPECT_EQ(0u, add_track_event.streams.size());
212 }
Henrik Boström933d8b02017-10-10 10:05:16 -0700213}
214
Steve Anton3172c032018-05-03 15:30:18 -0700215TEST_P(PeerConnectionRtpTest, AddTrackWithStreamFiresOnAddTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700216 auto caller = CreatePeerConnection();
217 auto callee = CreatePeerConnection();
218
Steve Anton3172c032018-05-03 15:30:18 -0700219 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700220 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700221
Henrik Boström31638672017-11-23 17:48:32 +0100222 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100223 auto& add_track_event = callee->observer()->add_track_events_[0];
Henrik Boström31638672017-11-23 17:48:32 +0100224 ASSERT_EQ(add_track_event.streams.size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700225 EXPECT_EQ("audio_stream", add_track_event.streams[0]->id());
Henrik Boström9e6fd2b2017-11-21 13:41:51 +0100226 EXPECT_TRUE(add_track_event.streams[0]->FindAudioTrack("audio_track"));
227 EXPECT_EQ(add_track_event.streams, add_track_event.receiver->streams());
Henrik Boström933d8b02017-10-10 10:05:16 -0700228}
229
Steve Anton3172c032018-05-03 15:30:18 -0700230TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700231 auto caller = CreatePeerConnection();
232 auto callee = CreatePeerConnection();
233
Steve Anton3172c032018-05-03 15:30:18 -0700234 auto sender = caller->AddAudioTrack("audio_track", {});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700235 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100236 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700237 ASSERT_TRUE(
238 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
239
Harald Alvestrand93dd7632022-01-19 12:28:45 +0000240 EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok());
Seth Hampson5897a6e2018-04-03 11:16:33 -0700241 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700242
Henrik Boström31638672017-11-23 17:48:32 +0100243 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700244 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
245 callee->observer()->remove_track_events_);
246}
247
Steve Anton3172c032018-05-03 15:30:18 -0700248TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700249 auto caller = CreatePeerConnection();
250 auto callee = CreatePeerConnection();
251
Steve Anton3172c032018-05-03 15:30:18 -0700252 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700253 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100254 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Steve Anton3172c032018-05-03 15:30:18 -0700255 ASSERT_TRUE(
256 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
257
Harald Alvestrand93dd7632022-01-19 12:28:45 +0000258 EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok());
Seth Hampson5897a6e2018-04-03 11:16:33 -0700259 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700260
Henrik Boström31638672017-11-23 17:48:32 +0100261 ASSERT_EQ(callee->observer()->add_track_events_.size(), 1u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700262 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
263 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700264 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700265}
266
Steve Anton3172c032018-05-03 15:30:18 -0700267TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamFiresOnRemoveTrack) {
Henrik Boström933d8b02017-10-10 10:05:16 -0700268 auto caller = CreatePeerConnection();
269 auto callee = CreatePeerConnection();
270
Seth Hampson845e8782018-03-02 11:34:10 -0800271 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700272 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
273 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700274 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100275 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Steve Anton3172c032018-05-03 15:30:18 -0700276 ASSERT_TRUE(
277 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700278
279 // Remove "audio_track1".
Harald Alvestrand93dd7632022-01-19 12:28:45 +0000280 EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender1).ok());
Seth Hampson5897a6e2018-04-03 11:16:33 -0700281 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100282 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700283 EXPECT_EQ(
Steve Anton9158ef62017-11-27 13:01:52 -0800284 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
Henrik Boström933d8b02017-10-10 10:05:16 -0700285 callee->observer()->add_track_events_[0].receiver},
286 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700287 ASSERT_EQ(1u, callee->observer()->remote_streams()->count());
288 ASSERT_TRUE(
289 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
Henrik Boström933d8b02017-10-10 10:05:16 -0700290
291 // Remove "audio_track2".
Harald Alvestrand93dd7632022-01-19 12:28:45 +0000292 EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender2).ok());
Seth Hampson5897a6e2018-04-03 11:16:33 -0700293 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100294 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
Henrik Boström933d8b02017-10-10 10:05:16 -0700295 EXPECT_EQ(callee->observer()->GetAddTrackReceivers(),
296 callee->observer()->remove_track_events_);
Steve Anton3172c032018-05-03 15:30:18 -0700297 EXPECT_EQ(0u, callee->observer()->remote_streams()->count());
Henrik Boström933d8b02017-10-10 10:05:16 -0700298}
299
Seth Hampson5b4f0752018-04-02 16:31:36 -0700300// Tests the edge case that if a stream ID changes for a given track that both
301// OnRemoveTrack and OnAddTrack is fired.
Steve Anton3172c032018-05-03 15:30:18 -0700302TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700303 RemoteStreamIdChangesFiresOnRemoveAndOnAddTrack) {
304 auto caller = CreatePeerConnection();
305 auto callee = CreatePeerConnection();
306
307 const char kStreamId1[] = "stream1";
308 const char kStreamId2[] = "stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700309 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700310 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700311 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
312
313 // Change the stream ID of the sender in the session description.
314 auto offer = caller->CreateOfferAndSetAsLocal();
Steve Anton3172c032018-05-03 15:30:18 -0700315 auto* audio_desc =
316 cricket::GetFirstAudioContentDescription(offer->description());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700317 ASSERT_EQ(audio_desc->mutable_streams().size(), 1u);
318 audio_desc->mutable_streams()[0].set_stream_ids({kStreamId2});
Steve Anton3172c032018-05-03 15:30:18 -0700319 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700320
321 ASSERT_EQ(callee->observer()->add_track_events_.size(), 2u);
322 EXPECT_EQ(callee->observer()->add_track_events_[1].streams[0]->id(),
323 kStreamId2);
324 ASSERT_EQ(callee->observer()->remove_track_events_.size(), 1u);
325 EXPECT_EQ(callee->observer()->remove_track_events_[0]->streams()[0]->id(),
326 kStreamId1);
327}
328
Steve Anton8b815cd2018-02-16 16:14:42 -0800329// Tests that setting a remote description with sending transceivers will fire
330// the OnTrack callback for each transceiver and setting a remote description
Seth Hampson5b4f0752018-04-02 16:31:36 -0700331// with receive only transceivers will not call OnTrack. One transceiver is
332// created without any stream_ids, while the other is created with multiple
333// stream_ids.
Steve Anton3172c032018-05-03 15:30:18 -0700334TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverCallsOnTrack) {
Seth Hampson5b4f0752018-04-02 16:31:36 -0700335 const std::string kStreamId1 = "video_stream1";
336 const std::string kStreamId2 = "video_stream2";
Steve Anton3172c032018-05-03 15:30:18 -0700337 auto caller = CreatePeerConnection();
338 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800339
340 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Seth Hampson5b4f0752018-04-02 16:31:36 -0700341 RtpTransceiverInit video_transceiver_init;
342 video_transceiver_init.stream_ids = {kStreamId1, kStreamId2};
343 auto video_transceiver =
344 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, video_transceiver_init);
Steve Anton8b815cd2018-02-16 16:14:42 -0800345
346 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
347
348 ASSERT_EQ(0u, caller->observer()->on_track_transceivers_.size());
349 ASSERT_EQ(2u, callee->observer()->on_track_transceivers_.size());
350 EXPECT_EQ(audio_transceiver->mid(),
351 callee->pc()->GetTransceivers()[0]->mid());
352 EXPECT_EQ(video_transceiver->mid(),
353 callee->pc()->GetTransceivers()[1]->mid());
Seth Hampson5b4f0752018-04-02 16:31:36 -0700354 std::vector<rtc::scoped_refptr<MediaStreamInterface>> audio_streams =
355 callee->pc()->GetTransceivers()[0]->receiver()->streams();
356 std::vector<rtc::scoped_refptr<MediaStreamInterface>> video_streams =
357 callee->pc()->GetTransceivers()[1]->receiver()->streams();
358 ASSERT_EQ(0u, audio_streams.size());
359 ASSERT_EQ(2u, video_streams.size());
360 EXPECT_EQ(kStreamId1, video_streams[0]->id());
361 EXPECT_EQ(kStreamId2, video_streams[1]->id());
Steve Anton8b815cd2018-02-16 16:14:42 -0800362}
363
364// Test that doing additional offer/answer exchanges with no changes to tracks
365// will cause no additional OnTrack calls after the tracks have been negotiated.
Steve Anton3172c032018-05-03 15:30:18 -0700366TEST_F(PeerConnectionRtpTestUnifiedPlan, ReofferDoesNotCallOnTrack) {
367 auto caller = CreatePeerConnection();
368 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800369
370 caller->AddAudioTrack("audio");
371 callee->AddAudioTrack("audio");
372
373 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
374 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
375 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
376
377 // If caller reoffers with no changes expect no additional OnTrack calls.
378 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
379 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
380 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
381
382 // Also if callee reoffers with no changes expect no additional OnTrack calls.
383 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
384 EXPECT_EQ(1u, caller->observer()->on_track_transceivers_.size());
385 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
386}
387
388// Test that OnTrack is called when the transceiver direction changes to send
389// the track.
Steve Anton3172c032018-05-03 15:30:18 -0700390TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionCallsOnTrack) {
391 auto caller = CreatePeerConnection();
392 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800393
394 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Harald Alvestrand6060df52020-08-11 09:54:02 +0200395 EXPECT_TRUE(
396 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive)
397 .ok());
Steve Anton8b815cd2018-02-16 16:14:42 -0800398 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
399 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
400 EXPECT_EQ(0u, callee->observer()->on_track_transceivers_.size());
401
Harald Alvestrand6060df52020-08-11 09:54:02 +0200402 EXPECT_TRUE(
403 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendOnly)
404 .ok());
Steve Anton8b815cd2018-02-16 16:14:42 -0800405 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
406 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
407 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
408
409 // If the direction changes but it is still receiving on the remote side, then
410 // OnTrack should not be fired again.
Harald Alvestrand6060df52020-08-11 09:54:02 +0200411 EXPECT_TRUE(
412 transceiver->SetDirectionWithError(RtpTransceiverDirection::kSendRecv)
413 .ok());
Steve Anton8b815cd2018-02-16 16:14:42 -0800414 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
415 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
416 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
417}
418
419// Test that OnTrack is called twice when a sendrecv call is started, the callee
420// changes the direction to inactive, then changes it back to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -0700421TEST_F(PeerConnectionRtpTestUnifiedPlan, SetDirectionHoldCallsOnTrackTwice) {
422 auto caller = CreatePeerConnection();
423 auto callee = CreatePeerConnection();
Steve Anton8b815cd2018-02-16 16:14:42 -0800424
425 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
426
427 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
428 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
429 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
430
431 // Put the call on hold by no longer receiving the track.
Harald Alvestrand6060df52020-08-11 09:54:02 +0200432 EXPECT_TRUE(callee->pc()
433 ->GetTransceivers()[0]
434 ->SetDirectionWithError(RtpTransceiverDirection::kInactive)
435 .ok());
Steve Anton8b815cd2018-02-16 16:14:42 -0800436
437 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
438 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
439 EXPECT_EQ(1u, callee->observer()->on_track_transceivers_.size());
440
441 // Resume the call by changing the direction to recvonly. This should call
442 // OnTrack again on the callee side.
Harald Alvestrand6060df52020-08-11 09:54:02 +0200443 EXPECT_TRUE(callee->pc()
444 ->GetTransceivers()[0]
445 ->SetDirectionWithError(RtpTransceiverDirection::kRecvOnly)
446 .ok());
Steve Anton8b815cd2018-02-16 16:14:42 -0800447
448 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
449 EXPECT_EQ(0u, caller->observer()->on_track_transceivers_.size());
450 EXPECT_EQ(2u, callee->observer()->on_track_transceivers_.size());
451}
452
Steve Anton3172c032018-05-03 15:30:18 -0700453// Test that setting a remote offer twice with no answer in the middle results
Steve Anton0f5400a2018-07-17 14:25:36 -0700454// in OnAddTrack being fired only once.
Steve Anton3172c032018-05-03 15:30:18 -0700455TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700456 ApplyTwoRemoteOffersWithNoAnswerResultsInOneAddTrackEvent) {
Henrik Boström31638672017-11-23 17:48:32 +0100457 auto caller = CreatePeerConnection();
458 auto callee = CreatePeerConnection();
459
Steve Anton3172c032018-05-03 15:30:18 -0700460 caller->AddAudioTrack("audio_track", {});
461
Amit Hilbuchae3df542019-01-07 12:13:08 -0800462 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700463 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
464
Amit Hilbuchae3df542019-01-07 12:13:08 -0800465 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton0f5400a2018-07-17 14:25:36 -0700466 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700467}
468
469// Test that setting a remote offer twice with no answer in the middle and the
470// track being removed between the two offers results in OnAddTrack being called
Steve Anton0f5400a2018-07-17 14:25:36 -0700471// once the first time and OnRemoveTrack being called once the second time.
Steve Anton3172c032018-05-03 15:30:18 -0700472TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton0f5400a2018-07-17 14:25:36 -0700473 ApplyRemoteOfferAddThenRemoteOfferRemoveResultsInOneRemoveTrackEvent) {
Steve Anton3172c032018-05-03 15:30:18 -0700474 auto caller = CreatePeerConnection();
475 auto callee = CreatePeerConnection();
476
477 auto sender = caller->AddAudioTrack("audio_track", {});
478
Amit Hilbuchae3df542019-01-07 12:13:08 -0800479 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700480 ASSERT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700481 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700482
Harald Alvestrand93dd7632022-01-19 12:28:45 +0000483 caller->pc()->RemoveTrackOrError(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700484
Amit Hilbuchae3df542019-01-07 12:13:08 -0800485 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Steve Anton3172c032018-05-03 15:30:18 -0700486 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700487 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
488}
489
490// Test that changing the direction from receiving to not receiving between
491// setting the remote offer and creating / setting the local answer results in
492// a remove track event when SetLocalDescription is called.
493TEST_F(PeerConnectionRtpTestUnifiedPlan,
494 ChangeDirectionInAnswerResultsInRemoveTrackEvent) {
495 auto caller = CreatePeerConnection();
496 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
497 auto callee = CreatePeerConnection();
498 callee->AddAudioTrack("audio_track", {});
499
500 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
501 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700502 EXPECT_EQ(0u, callee->observer()->remove_track_events_.size());
Steve Anton0f5400a2018-07-17 14:25:36 -0700503
504 auto callee_transceiver = callee->pc()->GetTransceivers()[0];
Harald Alvestrand6060df52020-08-11 09:54:02 +0200505 EXPECT_TRUE(callee_transceiver
506 ->SetDirectionWithError(RtpTransceiverDirection::kSendOnly)
507 .ok());
Steve Anton0f5400a2018-07-17 14:25:36 -0700508
509 ASSERT_TRUE(callee->SetLocalDescription(callee->CreateAnswer()));
510 EXPECT_EQ(1u, callee->observer()->add_track_events_.size());
511 EXPECT_EQ(1u, callee->observer()->remove_track_events_.size());
Steve Anton3172c032018-05-03 15:30:18 -0700512}
513
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100514TEST_F(PeerConnectionRtpTestUnifiedPlan, ChangeMsidWhileReceiving) {
515 auto caller = CreatePeerConnection();
516 caller->AddAudioTrack("audio_track", {"stream1"});
517 auto callee = CreatePeerConnection();
Amit Hilbuchae3df542019-01-07 12:13:08 -0800518 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100519
520 ASSERT_EQ(1u, callee->observer()->on_track_transceivers_.size());
521 auto transceiver = callee->observer()->on_track_transceivers_[0];
522 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
523 EXPECT_EQ("stream1", transceiver->receiver()->streams()[0]->id());
524
Amit Hilbuchae3df542019-01-07 12:13:08 -0800525 ASSERT_TRUE(callee->CreateAnswerAndSetAsLocal());
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100526
527 // Change the stream ID in the offer.
Guido Urdaneta1ff16c82019-05-20 19:31:53 +0200528 caller->pc()->GetSenders()[0]->SetStreams({"stream2"});
529 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boströmafa07dd2018-12-20 11:06:02 +0100530 ASSERT_EQ(1u, transceiver->receiver()->streams().size());
531 EXPECT_EQ("stream2", transceiver->receiver()->streams()[0]->id());
532}
533
Steve Anton3172c032018-05-03 15:30:18 -0700534// These tests examine the state of the peer connection as a result of
535// performing SetRemoteDescription().
536
537TEST_P(PeerConnectionRtpTest, AddTrackWithoutStreamAddsReceiver) {
538 auto caller = CreatePeerConnection();
539 auto callee = CreatePeerConnection();
540
541 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700542 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100543
544 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
545 auto receiver_added = callee->pc()->GetReceivers()[0];
546 EXPECT_EQ("audio_track", receiver_added->track()->id());
Steve Anton3172c032018-05-03 15:30:18 -0700547
548 if (sdp_semantics_ == SdpSemantics::kPlanB) {
549 // Since we are not supporting the no stream case with Plan B, there should
550 // be a generated stream, even though we didn't set one with AddTrack.
551 ASSERT_EQ(1u, receiver_added->streams().size());
552 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
553 } else {
554 EXPECT_EQ(0u, receiver_added->streams().size());
555 }
Henrik Boström31638672017-11-23 17:48:32 +0100556}
557
Steve Anton3172c032018-05-03 15:30:18 -0700558TEST_P(PeerConnectionRtpTest, AddTrackWithStreamAddsReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100559 auto caller = CreatePeerConnection();
560 auto callee = CreatePeerConnection();
561
Steve Anton3172c032018-05-03 15:30:18 -0700562 ASSERT_TRUE(caller->AddAudioTrack("audio_track", {"audio_stream"}));
Seth Hampson5897a6e2018-04-03 11:16:33 -0700563 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Henrik Boström31638672017-11-23 17:48:32 +0100564
565 EXPECT_EQ(callee->pc()->GetReceivers().size(), 1u);
566 auto receiver_added = callee->pc()->GetReceivers()[0];
567 EXPECT_EQ("audio_track", receiver_added->track()->id());
568 EXPECT_EQ(receiver_added->streams().size(), 1u);
Seth Hampson13b8bad2018-03-13 16:05:28 -0700569 EXPECT_EQ("audio_stream", receiver_added->streams()[0]->id());
Henrik Boström31638672017-11-23 17:48:32 +0100570 EXPECT_TRUE(receiver_added->streams()[0]->FindAudioTrack("audio_track"));
571}
572
Steve Anton3172c032018-05-03 15:30:18 -0700573TEST_P(PeerConnectionRtpTest, RemoveTrackWithoutStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100574 auto caller = CreatePeerConnection();
575 auto callee = CreatePeerConnection();
576
Steve Anton3172c032018-05-03 15:30:18 -0700577 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100578 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700579 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
580
Henrik Boström31638672017-11-23 17:48:32 +0100581 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
582 auto receiver = callee->pc()->GetReceivers()[0];
Harald Alvestrand93dd7632022-01-19 12:28:45 +0000583 ASSERT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok());
Steve Anton3172c032018-05-03 15:30:18 -0700584 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100585
Steve Anton3172c032018-05-03 15:30:18 -0700586 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
587 // With Unified Plan the receiver stays but the transceiver transitions to
588 // inactive.
589 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
590 EXPECT_EQ(RtpTransceiverDirection::kInactive,
591 callee->pc()->GetTransceivers()[0]->current_direction());
592 } else {
593 // With Plan B the receiver is removed.
594 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
595 }
Henrik Boström31638672017-11-23 17:48:32 +0100596}
597
Steve Anton3172c032018-05-03 15:30:18 -0700598TEST_P(PeerConnectionRtpTest, RemoveTrackWithStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100599 auto caller = CreatePeerConnection();
600 auto callee = CreatePeerConnection();
601
Steve Anton3172c032018-05-03 15:30:18 -0700602 auto sender = caller->AddAudioTrack("audio_track", {"audio_stream"});
Henrik Boström31638672017-11-23 17:48:32 +0100603 ASSERT_TRUE(sender);
Steve Anton3172c032018-05-03 15:30:18 -0700604 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100605 ASSERT_EQ(callee->pc()->GetReceivers().size(), 1u);
606 auto receiver = callee->pc()->GetReceivers()[0];
Harald Alvestrand93dd7632022-01-19 12:28:45 +0000607 ASSERT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok());
Steve Anton3172c032018-05-03 15:30:18 -0700608 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boström31638672017-11-23 17:48:32 +0100609
Steve Anton3172c032018-05-03 15:30:18 -0700610 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
611 // With Unified Plan the receiver stays but the transceiver transitions to
612 // inactive.
613 EXPECT_EQ(1u, callee->pc()->GetReceivers().size());
614 EXPECT_EQ(RtpTransceiverDirection::kInactive,
615 callee->pc()->GetTransceivers()[0]->current_direction());
616 } else {
617 // With Plan B the receiver is removed.
618 EXPECT_EQ(0u, callee->pc()->GetReceivers().size());
619 }
Henrik Boström31638672017-11-23 17:48:32 +0100620}
621
Steve Anton3172c032018-05-03 15:30:18 -0700622TEST_P(PeerConnectionRtpTest, RemoveTrackWithSharedStreamRemovesReceiver) {
Henrik Boström31638672017-11-23 17:48:32 +0100623 auto caller = CreatePeerConnection();
624 auto callee = CreatePeerConnection();
625
Seth Hampson845e8782018-03-02 11:34:10 -0800626 const char kSharedStreamId[] = "shared_audio_stream";
Steve Anton3172c032018-05-03 15:30:18 -0700627 auto sender1 = caller->AddAudioTrack("audio_track1", {kSharedStreamId});
628 auto sender2 = caller->AddAudioTrack("audio_track2", {kSharedStreamId});
629 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
630 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
Henrik Boström31638672017-11-23 17:48:32 +0100631
632 // Remove "audio_track1".
Harald Alvestrand93dd7632022-01-19 12:28:45 +0000633 EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender1).ok());
Steve Anton3172c032018-05-03 15:30:18 -0700634 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
635
636 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
637 // With Unified Plan the receiver stays but the transceiver transitions to
638 // inactive.
639 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
640 auto transceiver = callee->pc()->GetTransceivers()[0];
641 EXPECT_EQ("audio_track1", transceiver->receiver()->track()->id());
642 EXPECT_EQ(RtpTransceiverDirection::kInactive,
643 transceiver->current_direction());
644 } else {
645 // With Plan B the receiver is removed.
646 ASSERT_EQ(1u, callee->pc()->GetReceivers().size());
647 EXPECT_EQ("audio_track2", callee->pc()->GetReceivers()[0]->track()->id());
648 }
Henrik Boström31638672017-11-23 17:48:32 +0100649
650 // Remove "audio_track2".
Harald Alvestrand93dd7632022-01-19 12:28:45 +0000651 EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender2).ok());
Steve Anton3172c032018-05-03 15:30:18 -0700652 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
653
654 if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
655 // With Unified Plan the receiver stays but the transceiver transitions to
656 // inactive.
657 ASSERT_EQ(2u, callee->pc()->GetReceivers().size());
658 auto transceiver = callee->pc()->GetTransceivers()[1];
659 EXPECT_EQ("audio_track2", transceiver->receiver()->track()->id());
660 EXPECT_EQ(RtpTransceiverDirection::kInactive,
661 transceiver->current_direction());
662 } else {
663 // With Plan B the receiver is removed.
664 ASSERT_EQ(0u, callee->pc()->GetReceivers().size());
665 }
Henrik Boström31638672017-11-23 17:48:32 +0100666}
667
Florent Castelliabe301f2018-06-12 18:33:49 +0200668TEST_P(PeerConnectionRtpTest, AudioGetParametersHasHeaderExtensions) {
669 auto caller = CreatePeerConnection();
670 auto callee = CreatePeerConnection();
671 auto sender = caller->AddAudioTrack("audio_track");
672 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
673
674 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
675 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
676
677 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
678 auto receiver = callee->pc()->GetReceivers()[0];
679 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
680}
681
682TEST_P(PeerConnectionRtpTest, VideoGetParametersHasHeaderExtensions) {
683 auto caller = CreatePeerConnection();
684 auto callee = CreatePeerConnection();
685 auto sender = caller->AddVideoTrack("video_track");
686 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
687
688 ASSERT_GT(caller->pc()->GetSenders().size(), 0u);
689 EXPECT_GT(sender->GetParameters().header_extensions.size(), 0u);
690
691 ASSERT_GT(callee->pc()->GetReceivers().size(), 0u);
692 auto receiver = callee->pc()->GetReceivers()[0];
693 EXPECT_GT(receiver->GetParameters().header_extensions.size(), 0u);
694}
695
Henrik Boström31638672017-11-23 17:48:32 +0100696// Invokes SetRemoteDescription() twice in a row without synchronizing the two
697// calls and examine the state of the peer connection inside the callbacks to
698// ensure that the second call does not occur prematurely, contaminating the
699// state of the peer connection of the first callback.
Steve Anton3172c032018-05-03 15:30:18 -0700700TEST_F(PeerConnectionRtpTestPlanB,
Henrik Boström31638672017-11-23 17:48:32 +0100701 StatesCorrelateWithSetRemoteDescriptionCall) {
702 auto caller = CreatePeerConnection();
703 auto callee = CreatePeerConnection();
704
Henrik Boström31638672017-11-23 17:48:32 +0100705 // Create SDP for adding a track and for removing it. This will be used in the
706 // first and second SetRemoteDescription() calls.
Steve Anton3172c032018-05-03 15:30:18 -0700707 auto sender = caller->AddAudioTrack("audio_track", {});
Henrik Boström31638672017-11-23 17:48:32 +0100708 auto srd1_sdp = caller->CreateOfferAndSetAsLocal();
Harald Alvestrand93dd7632022-01-19 12:28:45 +0000709 EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok());
Henrik Boström31638672017-11-23 17:48:32 +0100710 auto srd2_sdp = caller->CreateOfferAndSetAsLocal();
711
712 // In the first SetRemoteDescription() callback, check that we have a
713 // receiver for the track.
714 auto pc = callee->pc();
715 bool srd1_callback_called = false;
716 auto srd1_callback = [&srd1_callback_called, &pc]() {
717 EXPECT_EQ(pc->GetReceivers().size(), 1u);
718 srd1_callback_called = true;
719 };
720
721 // In the second SetRemoteDescription() callback, check that the receiver has
722 // been removed.
723 // TODO(hbos): When we implement Unified Plan, receivers will not be removed.
724 // Instead, the transceiver owning the receiver will become inactive.
725 // https://crbug.com/webrtc/7600
726 bool srd2_callback_called = false;
727 auto srd2_callback = [&srd2_callback_called, &pc]() {
728 EXPECT_TRUE(pc->GetReceivers().empty());
729 srd2_callback_called = true;
730 };
731
732 // Invoke SetRemoteDescription() twice in a row without synchronizing the two
733 // calls. The callbacks verify that the two calls are synchronized, as in, the
734 // effects of the second SetRemoteDescription() call must not have happened by
735 // the time the first callback is invoked. If it has then the receiver that is
736 // added as a result of the first SetRemoteDescription() call will already
737 // have been removed as a result of the second SetRemoteDescription() call
738 // when the first callback is invoked.
739 callee->pc()->SetRemoteDescription(
740 std::move(srd1_sdp),
Niels Möllere7cc8832022-01-04 15:20:03 +0100741 rtc::make_ref_counted<OnSuccessObserver<decltype(srd1_callback)>>(
742 srd1_callback));
Henrik Boström31638672017-11-23 17:48:32 +0100743 callee->pc()->SetRemoteDescription(
744 std::move(srd2_sdp),
Niels Möllere7cc8832022-01-04 15:20:03 +0100745 rtc::make_ref_counted<OnSuccessObserver<decltype(srd2_callback)>>(
746 srd2_callback));
Henrik Boström31638672017-11-23 17:48:32 +0100747 EXPECT_TRUE_WAIT(srd1_callback_called, kDefaultTimeout);
748 EXPECT_TRUE_WAIT(srd2_callback_called, kDefaultTimeout);
749}
750
Seth Hampson5897a6e2018-04-03 11:16:33 -0700751// Tests that a remote track is created with the signaled MSIDs when they are
752// communicated with a=msid and no SSRCs are signaled at all (i.e., no a=ssrc
753// lines).
Steve Anton3172c032018-05-03 15:30:18 -0700754TEST_F(PeerConnectionRtpTestUnifiedPlan, UnsignaledSsrcCreatesReceiverStreams) {
755 auto caller = CreatePeerConnection();
756 auto callee = CreatePeerConnection();
Seth Hampson5897a6e2018-04-03 11:16:33 -0700757 const char kStreamId1[] = "stream1";
758 const char kStreamId2[] = "stream2";
759 caller->AddTrack(caller->CreateAudioTrack("audio_track1"),
760 {kStreamId1, kStreamId2});
761
762 auto offer = caller->CreateOfferAndSetAsLocal();
763 // Munge the offer to take out everything but the stream_ids.
764 auto contents = offer->description()->contents();
765 ASSERT_TRUE(!contents.empty());
766 ASSERT_TRUE(!contents[0].media_description()->streams().empty());
767 std::vector<std::string> stream_ids =
768 contents[0].media_description()->streams()[0].stream_ids();
769 contents[0].media_description()->mutable_streams().clear();
770 cricket::StreamParams new_stream;
771 new_stream.set_stream_ids(stream_ids);
772 contents[0].media_description()->AddStream(new_stream);
773
774 // Set the remote description and verify that the streams were added to the
775 // receiver correctly.
776 ASSERT_TRUE(
777 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
778 auto receivers = callee->pc()->GetReceivers();
779 ASSERT_EQ(receivers.size(), 1u);
780 ASSERT_EQ(receivers[0]->streams().size(), 2u);
781 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId1);
782 EXPECT_EQ(receivers[0]->streams()[1]->id(), kStreamId2);
783}
Henrik Boströmc335b0e2021-04-08 07:25:38 +0200784TEST_F(PeerConnectionRtpTestUnifiedPlan, TracksDoNotEndWhenSsrcChanges) {
785 constexpr uint32_t kFirstMungedSsrc = 1337u;
786
787 auto caller = CreatePeerConnection();
788 auto callee = CreatePeerConnection();
789
790 // Caller offers to receive audio and video.
791 RtpTransceiverInit init;
792 init.direction = RtpTransceiverDirection::kRecvOnly;
793 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
794 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
795
796 // Callee wants to send audio and video tracks.
797 callee->AddTrack(callee->CreateAudioTrack("audio_track"), {});
798 callee->AddTrack(callee->CreateVideoTrack("video_track"), {});
799
800 // Do inittial offer/answer exchange.
801 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
802 ASSERT_TRUE(
803 caller->SetRemoteDescription(callee->CreateAnswerAndSetAsLocal()));
804 ASSERT_EQ(caller->observer()->add_track_events_.size(), 2u);
805 ASSERT_EQ(caller->pc()->GetReceivers().size(), 2u);
806
807 // Do a follow-up offer/answer exchange where the SSRCs are modified.
808 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
809 auto answer = callee->CreateAnswer();
810 auto& contents = answer->description()->contents();
811 ASSERT_TRUE(!contents.empty());
812 for (size_t i = 0; i < contents.size(); ++i) {
813 auto& mutable_streams = contents[i].media_description()->mutable_streams();
814 ASSERT_EQ(mutable_streams.size(), 1u);
815 mutable_streams[0].ssrcs = {kFirstMungedSsrc + static_cast<uint32_t>(i)};
816 }
817 ASSERT_TRUE(
818 callee->SetLocalDescription(CloneSessionDescription(answer.get())));
819 ASSERT_TRUE(
820 caller->SetRemoteDescription(CloneSessionDescription(answer.get())));
821
822 // No furher track events should fire because we never changed direction, only
823 // SSRCs.
824 ASSERT_EQ(caller->observer()->add_track_events_.size(), 2u);
825 // We should have the same number of receivers as before.
826 auto receivers = caller->pc()->GetReceivers();
827 ASSERT_EQ(receivers.size(), 2u);
828 // The tracks are still alive.
829 EXPECT_EQ(receivers[0]->track()->state(),
830 MediaStreamTrackInterface::TrackState::kLive);
831 EXPECT_EQ(receivers[1]->track()->state(),
832 MediaStreamTrackInterface::TrackState::kLive);
833}
Seth Hampson5897a6e2018-04-03 11:16:33 -0700834
Seth Hampson5b4f0752018-04-02 16:31:36 -0700835// Tests that with Unified Plan if the the stream id changes for a track when
836// when setting a new remote description, that the media stream is updated
837// appropriately for the receiver.
Steve Anton0f5400a2018-07-17 14:25:36 -0700838// TODO(https://github.com/w3c/webrtc-pc/issues/1937): Resolve spec issue or fix
839// test.
840TEST_F(PeerConnectionRtpTestUnifiedPlan,
841 DISABLED_RemoteStreamIdChangesUpdatesReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700842 auto caller = CreatePeerConnection();
843 auto callee = CreatePeerConnection();
Seth Hampson5b4f0752018-04-02 16:31:36 -0700844
845 const char kStreamId1[] = "stream1";
846 const char kStreamId2[] = "stream2";
Steve Anton0f5400a2018-07-17 14:25:36 -0700847 caller->AddAudioTrack("audio_track1", {kStreamId1});
Seth Hampson5897a6e2018-04-03 11:16:33 -0700848 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700849 EXPECT_EQ(callee->observer()->add_track_events_.size(), 1u);
850
851 // Change the stream id of the sender in the session description.
852 auto offer = caller->CreateOfferAndSetAsLocal();
853 auto contents = offer->description()->contents();
854 ASSERT_EQ(contents.size(), 1u);
855 ASSERT_EQ(contents[0].media_description()->mutable_streams().size(), 1u);
856 contents[0].media_description()->mutable_streams()[0].set_stream_ids(
857 {kStreamId2});
858
Steve Anton0f5400a2018-07-17 14:25:36 -0700859 // Set the remote description and verify that the stream was updated
860 // properly.
861 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
Seth Hampson5b4f0752018-04-02 16:31:36 -0700862 auto receivers = callee->pc()->GetReceivers();
863 ASSERT_EQ(receivers.size(), 1u);
864 ASSERT_EQ(receivers[0]->streams().size(), 1u);
865 EXPECT_EQ(receivers[0]->streams()[0]->id(), kStreamId2);
866}
867
868// This tests a regression caught by a downstream client, that occured when
869// applying a remote description with a SessionDescription object that
870// contained StreamParams that didn't have ids. Although there were multiple
871// remote audio senders, FindSenderInfo didn't find them as unique, because
872// it looked up by StreamParam.id, which none had. This meant only one
873// AudioRtpReceiver was created, as opposed to one for each remote sender.
Steve Anton3172c032018-05-03 15:30:18 -0700874TEST_F(PeerConnectionRtpTestPlanB,
Seth Hampson5b4f0752018-04-02 16:31:36 -0700875 MultipleRemoteSendersWithoutStreamParamIdAddsMultipleReceivers) {
876 auto caller = CreatePeerConnection();
877 auto callee = CreatePeerConnection();
878
879 const char kStreamId1[] = "stream1";
880 const char kStreamId2[] = "stream2";
881 caller->AddAudioTrack("audio_track1", {kStreamId1});
882 caller->AddAudioTrack("audio_track2", {kStreamId2});
883
884 auto offer = caller->CreateOfferAndSetAsLocal();
885 auto mutable_streams =
886 cricket::GetFirstAudioContentDescription(offer->description())
887 ->mutable_streams();
888 ASSERT_EQ(mutable_streams.size(), 2u);
889 // Clear the IDs in the StreamParams.
890 mutable_streams[0].id.clear();
891 mutable_streams[1].id.clear();
892 ASSERT_TRUE(
893 callee->SetRemoteDescription(CloneSessionDescription(offer.get())));
894
895 auto receivers = callee->pc()->GetReceivers();
896 ASSERT_EQ(receivers.size(), 2u);
897 ASSERT_EQ(receivers[0]->streams().size(), 1u);
898 EXPECT_EQ(kStreamId1, receivers[0]->streams()[0]->id());
899 ASSERT_EQ(receivers[1]->streams().size(), 1u);
900 EXPECT_EQ(kStreamId2, receivers[1]->streams()[0]->id());
901}
902
Henrik Boström31638672017-11-23 17:48:32 +0100903// Tests for the legacy SetRemoteDescription() function signature.
Henrik Boström31638672017-11-23 17:48:32 +0100904
905// Sanity test making sure the callback is invoked.
Steve Anton3172c032018-05-03 15:30:18 -0700906TEST_P(PeerConnectionRtpTest, LegacyObserverOnSuccess) {
Henrik Boström31638672017-11-23 17:48:32 +0100907 auto caller = CreatePeerConnection();
908 auto callee = CreatePeerConnection();
909
910 std::string error;
911 ASSERT_TRUE(
912 callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal(), &error));
913}
914
915// Verifies legacy behavior: The observer is not called if if the peer
916// connection is destroyed because the asynchronous callback is executed in the
917// peer connection's message handler.
Steve Anton3172c032018-05-03 15:30:18 -0700918TEST_P(PeerConnectionRtpTest,
919 LegacyObserverNotCalledIfPeerConnectionDereferenced) {
Henrik Boström31638672017-11-23 17:48:32 +0100920 auto caller = CreatePeerConnection();
921 auto callee = CreatePeerConnection();
922
923 rtc::scoped_refptr<webrtc::MockSetSessionDescriptionObserver> observer =
Tommi87f70902021-04-27 14:43:08 +0200924 rtc::make_ref_counted<webrtc::MockSetSessionDescriptionObserver>();
Henrik Boström31638672017-11-23 17:48:32 +0100925
926 auto offer = caller->CreateOfferAndSetAsLocal();
927 callee->pc()->SetRemoteDescription(observer, offer.release());
928 callee = nullptr;
929 rtc::Thread::Current()->ProcessMessages(0);
930 EXPECT_FALSE(observer->called());
931}
932
Steve Antonf9381f02017-12-14 10:23:57 -0800933// RtpTransceiver Tests.
Steve Anton9158ef62017-11-27 13:01:52 -0800934
935// Test that by default there are no transceivers with Unified Plan.
Steve Anton3172c032018-05-03 15:30:18 -0700936TEST_F(PeerConnectionRtpTestUnifiedPlan, PeerConnectionHasNoTransceivers) {
937 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800938 EXPECT_THAT(caller->pc()->GetTransceivers(), ElementsAre());
939}
940
941// Test that a transceiver created with the audio kind has the correct initial
942// properties.
Steve Anton3172c032018-05-03 15:30:18 -0700943TEST_F(PeerConnectionRtpTestUnifiedPlan,
944 AddTransceiverHasCorrectInitProperties) {
945 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800946
947 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200948 EXPECT_EQ(absl::nullopt, transceiver->mid());
Steve Anton9158ef62017-11-27 13:01:52 -0800949 EXPECT_FALSE(transceiver->stopped());
950 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
Danil Chapovalov66cadcc2018-06-19 16:47:43 +0200951 EXPECT_EQ(absl::nullopt, transceiver->current_direction());
Steve Anton9158ef62017-11-27 13:01:52 -0800952}
953
954// Test that adding a transceiver with the audio kind creates an audio sender
955// and audio receiver with the receiver having a live audio track.
Steve Anton3172c032018-05-03 15:30:18 -0700956TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800957 AddAudioTransceiverCreatesAudioSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700958 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800959
960 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Steve Anton69470252018-02-09 11:43:08 -0800961 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800962
963 ASSERT_TRUE(transceiver->sender());
964 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->sender()->media_type());
965
966 ASSERT_TRUE(transceiver->receiver());
967 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, transceiver->receiver()->media_type());
968
969 auto track = transceiver->receiver()->track();
970 ASSERT_TRUE(track);
971 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, track->kind());
972 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
973}
974
975// Test that adding a transceiver with the video kind creates an video sender
976// and video receiver with the receiver having a live video track.
Steve Anton3172c032018-05-03 15:30:18 -0700977TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -0800978 AddAudioTransceiverCreatesVideoSenderAndReceiver) {
Steve Anton3172c032018-05-03 15:30:18 -0700979 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -0800980
981 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
Steve Anton69470252018-02-09 11:43:08 -0800982 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->media_type());
Steve Anton9158ef62017-11-27 13:01:52 -0800983
984 ASSERT_TRUE(transceiver->sender());
985 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->sender()->media_type());
986
987 ASSERT_TRUE(transceiver->receiver());
988 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, transceiver->receiver()->media_type());
989
990 auto track = transceiver->receiver()->track();
991 ASSERT_TRUE(track);
992 EXPECT_EQ(MediaStreamTrackInterface::kVideoKind, track->kind());
993 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive, track->state());
994}
995
996// Test that after a call to AddTransceiver, the transceiver shows in
997// GetTransceivers(), the transceiver's sender shows in GetSenders(), and the
998// transceiver's receiver shows in GetReceivers().
Steve Anton3172c032018-05-03 15:30:18 -0700999TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTransceiverShowsInLists) {
1000 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -08001001
1002 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1003 EXPECT_EQ(
1004 std::vector<rtc::scoped_refptr<RtpTransceiverInterface>>{transceiver},
1005 caller->pc()->GetTransceivers());
1006 EXPECT_EQ(
1007 std::vector<rtc::scoped_refptr<RtpSenderInterface>>{
1008 transceiver->sender()},
1009 caller->pc()->GetSenders());
1010 EXPECT_EQ(
1011 std::vector<rtc::scoped_refptr<RtpReceiverInterface>>{
1012 transceiver->receiver()},
1013 caller->pc()->GetReceivers());
1014}
1015
1016// Test that the direction passed in through the AddTransceiver init parameter
1017// is set in the returned transceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001018TEST_F(PeerConnectionRtpTestUnifiedPlan,
1019 AddTransceiverWithDirectionIsReflected) {
1020 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -08001021
1022 RtpTransceiverInit init;
1023 init.direction = RtpTransceiverDirection::kSendOnly;
1024 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1025 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1026}
1027
Steve Anton9158ef62017-11-27 13:01:52 -08001028// Test that calling AddTransceiver with a track creates a transceiver which has
1029// its sender's track set to the passed-in track.
Steve Anton3172c032018-05-03 15:30:18 -07001030TEST_F(PeerConnectionRtpTestUnifiedPlan,
1031 AddTransceiverWithTrackCreatesSenderWithTrack) {
1032 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -08001033
1034 auto audio_track = caller->CreateAudioTrack("audio track");
1035 auto transceiver = caller->AddTransceiver(audio_track);
1036
1037 auto sender = transceiver->sender();
1038 ASSERT_TRUE(sender->track());
1039 EXPECT_EQ(audio_track, sender->track());
1040
1041 auto receiver = transceiver->receiver();
1042 ASSERT_TRUE(receiver->track());
1043 EXPECT_EQ(MediaStreamTrackInterface::kAudioKind, receiver->track()->kind());
1044 EXPECT_EQ(MediaStreamTrackInterface::TrackState::kLive,
1045 receiver->track()->state());
1046}
1047
1048// Test that calling AddTransceiver twice with the same track creates distinct
1049// transceivers, senders with the same track.
Steve Anton3172c032018-05-03 15:30:18 -07001050TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton9158ef62017-11-27 13:01:52 -08001051 AddTransceiverTwiceWithSameTrackCreatesMultipleTransceivers) {
Steve Anton3172c032018-05-03 15:30:18 -07001052 auto caller = CreatePeerConnection();
Steve Anton9158ef62017-11-27 13:01:52 -08001053
1054 auto audio_track = caller->CreateAudioTrack("audio track");
1055
1056 auto transceiver1 = caller->AddTransceiver(audio_track);
1057 auto transceiver2 = caller->AddTransceiver(audio_track);
1058
1059 EXPECT_NE(transceiver1, transceiver2);
1060
1061 auto sender1 = transceiver1->sender();
1062 auto sender2 = transceiver2->sender();
1063 EXPECT_NE(sender1, sender2);
1064 EXPECT_EQ(audio_track, sender1->track());
1065 EXPECT_EQ(audio_track, sender2->track());
1066
1067 EXPECT_THAT(caller->pc()->GetTransceivers(),
1068 UnorderedElementsAre(transceiver1, transceiver2));
1069 EXPECT_THAT(caller->pc()->GetSenders(),
1070 UnorderedElementsAre(sender1, sender2));
1071}
1072
Steve Anton3fe1b152017-12-12 10:20:08 -08001073// RtpTransceiver error handling tests.
1074
Steve Anton3172c032018-05-03 15:30:18 -07001075TEST_F(PeerConnectionRtpTestUnifiedPlan,
1076 AddTransceiverWithInvalidKindReturnsError) {
1077 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -08001078
1079 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_DATA);
1080 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
1081}
1082
Steve Anton3172c032018-05-03 15:30:18 -07001083TEST_F(PeerConnectionRtpTestUnifiedPlan,
1084 CanClosePeerConnectionWithoutCrashing) {
1085 auto caller = CreatePeerConnection();
Steve Anton3fe1b152017-12-12 10:20:08 -08001086
1087 caller->pc()->Close();
1088}
1089
Steve Antonf9381f02017-12-14 10:23:57 -08001090// Unified Plan AddTrack tests.
1091
Steve Antonf9381f02017-12-14 10:23:57 -08001092// Test that adding an audio track creates a new audio RtpSender with the given
1093// track.
Steve Anton3172c032018-05-03 15:30:18 -07001094TEST_F(PeerConnectionRtpTestUnifiedPlan, AddAudioTrackCreatesAudioSender) {
1095 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001096
1097 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001098 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001099 ASSERT_TRUE(sender);
1100
1101 EXPECT_EQ(cricket::MEDIA_TYPE_AUDIO, sender->media_type());
1102 EXPECT_EQ(audio_track, sender->track());
1103}
1104
1105// Test that adding a video track creates a new video RtpSender with the given
1106// track.
Steve Anton3172c032018-05-03 15:30:18 -07001107TEST_F(PeerConnectionRtpTestUnifiedPlan, AddVideoTrackCreatesVideoSender) {
1108 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001109
1110 auto video_track = caller->CreateVideoTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001111 auto sender = caller->AddTrack(video_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001112 ASSERT_TRUE(sender);
1113
1114 EXPECT_EQ(cricket::MEDIA_TYPE_VIDEO, sender->media_type());
1115 EXPECT_EQ(video_track, sender->track());
1116}
1117
1118// Test that adding a track to a new PeerConnection creates an RtpTransceiver
1119// with the sender that AddTrack returns and in the sendrecv direction.
Steve Anton3172c032018-05-03 15:30:18 -07001120TEST_F(PeerConnectionRtpTestUnifiedPlan, AddFirstTrackCreatesTransceiver) {
1121 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001122
1123 auto sender = caller->AddAudioTrack("a");
1124 ASSERT_TRUE(sender);
1125
1126 auto transceivers = caller->pc()->GetTransceivers();
1127 ASSERT_EQ(1u, transceivers.size());
1128 EXPECT_EQ(sender, transceivers[0]->sender());
1129 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceivers[0]->direction());
1130}
1131
1132// Test that if a transceiver of the same type but no track had been added to
1133// the PeerConnection and later a call to AddTrack is made, the resulting sender
1134// is the transceiver's sender and the sender's track is the newly-added track.
Steve Anton3172c032018-05-03 15:30:18 -07001135TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiver) {
1136 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001137
1138 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1139 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001140 auto sender = caller->AddTrack(audio_track);
Steve Antonf9381f02017-12-14 10:23:57 -08001141 ASSERT_TRUE(sender);
1142
1143 auto transceivers = caller->pc()->GetTransceivers();
1144 ASSERT_EQ(1u, transceivers.size());
1145 EXPECT_EQ(transceiver, transceivers[0]);
1146 EXPECT_EQ(sender, transceiver->sender());
1147 EXPECT_EQ(audio_track, sender->track());
1148}
1149
1150// Test that adding two tracks to a new PeerConnection creates two
1151// RtpTransceivers in the same order.
Steve Anton3172c032018-05-03 15:30:18 -07001152TEST_F(PeerConnectionRtpTestUnifiedPlan, TwoAddTrackCreatesTwoTransceivers) {
1153 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001154
1155 auto sender1 = caller->AddAudioTrack("a");
1156 auto sender2 = caller->AddVideoTrack("v");
1157 ASSERT_TRUE(sender2);
1158
1159 auto transceivers = caller->pc()->GetTransceivers();
1160 ASSERT_EQ(2u, transceivers.size());
1161 EXPECT_EQ(sender1, transceivers[0]->sender());
1162 EXPECT_EQ(sender2, transceivers[1]->sender());
1163}
1164
1165// Test that if there are multiple transceivers with no sending track then a
1166// later call to AddTrack will use the one of the same type as the newly-added
1167// track.
Steve Anton3172c032018-05-03 15:30:18 -07001168TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackReusesTransceiverOfType) {
1169 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001170
1171 auto audio_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1172 auto video_transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO);
1173 auto sender = caller->AddVideoTrack("v");
1174
1175 ASSERT_EQ(2u, caller->pc()->GetTransceivers().size());
1176 EXPECT_NE(sender, audio_transceiver->sender());
1177 EXPECT_EQ(sender, video_transceiver->sender());
1178}
1179
1180// Test that if the only transceivers that do not have a sending track have a
1181// different type from the added track, then AddTrack will create a new
1182// transceiver for the track.
Steve Anton3172c032018-05-03 15:30:18 -07001183TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001184 AddTrackDoesNotReuseTransceiverOfWrongType) {
Steve Anton3172c032018-05-03 15:30:18 -07001185 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001186
1187 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1188 auto sender = caller->AddVideoTrack("v");
1189
1190 auto transceivers = caller->pc()->GetTransceivers();
1191 ASSERT_EQ(2u, transceivers.size());
1192 EXPECT_NE(sender, transceivers[0]->sender());
1193 EXPECT_EQ(sender, transceivers[1]->sender());
1194}
1195
1196// Test that the first available transceiver is reused by AddTrack when multiple
1197// are available.
Steve Anton3172c032018-05-03 15:30:18 -07001198TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001199 AddTrackReusesFirstMatchingTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001200 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001201
1202 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1203 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1204 auto sender = caller->AddAudioTrack("a");
1205
1206 auto transceivers = caller->pc()->GetTransceivers();
1207 ASSERT_EQ(2u, transceivers.size());
1208 EXPECT_EQ(sender, transceivers[0]->sender());
1209 EXPECT_NE(sender, transceivers[1]->sender());
1210}
1211
1212// Test that a call to AddTrack that reuses a transceiver will change the
1213// direction from inactive to sendonly.
Steve Anton3172c032018-05-03 15:30:18 -07001214TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001215 AddTrackChangesDirectionFromInactiveToSendOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001216 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001217 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001218
1219 RtpTransceiverInit init;
1220 init.direction = RtpTransceiverDirection::kInactive;
1221 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
Henrik Boströme574a312020-08-25 10:20:11 +02001222 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1223 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001224
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001225 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02001226 caller->observer()->clear_legacy_renegotiation_needed();
1227 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 10:23:57 -08001228 ASSERT_TRUE(caller->AddAudioTrack("a"));
Henrik Boströme574a312020-08-25 10:20:11 +02001229 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1230 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001231
1232 EXPECT_EQ(RtpTransceiverDirection::kSendOnly, transceiver->direction());
1233}
1234
1235// Test that a call to AddTrack that reuses a transceiver will change the
1236// direction from recvonly to sendrecv.
Steve Anton3172c032018-05-03 15:30:18 -07001237TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001238 AddTrackChangesDirectionFromRecvOnlyToSendRecv) {
Steve Anton3172c032018-05-03 15:30:18 -07001239 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001240 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001241
1242 RtpTransceiverInit init;
1243 init.direction = RtpTransceiverDirection::kRecvOnly;
1244 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
Henrik Boströme574a312020-08-25 10:20:11 +02001245 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1246 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001247
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001248 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02001249 caller->observer()->clear_legacy_renegotiation_needed();
1250 caller->observer()->clear_latest_negotiation_needed_event();
Steve Antonf9381f02017-12-14 10:23:57 -08001251 ASSERT_TRUE(caller->AddAudioTrack("a"));
Henrik Boströme574a312020-08-25 10:20:11 +02001252 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1253 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001254
1255 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1256}
1257
Steve Anton3172c032018-05-03 15:30:18 -07001258TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackCreatesSenderWithTrackId) {
Steve Anton02ee47c2018-01-10 16:26:06 -08001259 const std::string kTrackId = "audio_track";
1260
Steve Anton3172c032018-05-03 15:30:18 -07001261 auto caller = CreatePeerConnection();
Steve Anton02ee47c2018-01-10 16:26:06 -08001262
1263 auto audio_track = caller->CreateAudioTrack(kTrackId);
1264 auto sender = caller->AddTrack(audio_track);
1265
1266 EXPECT_EQ(kTrackId, sender->id());
1267}
1268
Steve Antonf9381f02017-12-14 10:23:57 -08001269// Unified Plan AddTrack error handling.
1270
Steve Anton3172c032018-05-03 15:30:18 -07001271TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfClosed) {
1272 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001273
1274 auto audio_track = caller->CreateAudioTrack("a");
1275 caller->pc()->Close();
1276
Henrik Boströme574a312020-08-25 10:20:11 +02001277 caller->observer()->clear_legacy_renegotiation_needed();
1278 caller->observer()->clear_latest_negotiation_needed_event();
Yves Gerey665174f2018-06-19 15:03:05 +02001279 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001280 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.error().type());
Henrik Boströme574a312020-08-25 10:20:11 +02001281 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1282 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001283}
1284
Steve Anton3172c032018-05-03 15:30:18 -07001285TEST_F(PeerConnectionRtpTestUnifiedPlan, AddTrackErrorIfTrackAlreadyHasSender) {
1286 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001287
1288 auto audio_track = caller->CreateAudioTrack("a");
Steve Anton2d6c76a2018-01-05 17:10:52 -08001289 ASSERT_TRUE(caller->AddTrack(audio_track));
Steve Antonf9381f02017-12-14 10:23:57 -08001290
Henrik Boströme574a312020-08-25 10:20:11 +02001291 caller->observer()->clear_legacy_renegotiation_needed();
1292 caller->observer()->clear_latest_negotiation_needed_event();
Yves Gerey665174f2018-06-19 15:03:05 +02001293 auto result = caller->pc()->AddTrack(audio_track, std::vector<std::string>());
Steve Anton2d6c76a2018-01-05 17:10:52 -08001294 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, result.error().type());
Henrik Boströme574a312020-08-25 10:20:11 +02001295 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1296 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001297}
1298
1299// Unified Plan RemoveTrack tests.
1300
1301// Test that calling RemoveTrack on a sender with a previously-added track
1302// clears the sender's track.
Steve Anton3172c032018-05-03 15:30:18 -07001303TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackClearsSenderTrack) {
1304 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001305
1306 auto sender = caller->AddAudioTrack("a");
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001307 ASSERT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok());
Steve Antonf9381f02017-12-14 10:23:57 -08001308
1309 EXPECT_FALSE(sender->track());
1310}
1311
1312// Test that calling RemoveTrack on a sender where the transceiver is configured
1313// in the sendrecv direction changes the transceiver's direction to recvonly.
Steve Anton3172c032018-05-03 15:30:18 -07001314TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001315 RemoveTrackChangesDirectionFromSendRecvToRecvOnly) {
Steve Anton3172c032018-05-03 15:30:18 -07001316 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001317 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001318
1319 RtpTransceiverInit init;
1320 init.direction = RtpTransceiverDirection::kSendRecv;
1321 auto transceiver =
1322 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Henrik Boströme574a312020-08-25 10:20:11 +02001323 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1324 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001325
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001326 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02001327 caller->observer()->clear_legacy_renegotiation_needed();
1328 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001329
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001330 ASSERT_TRUE(caller->pc()->RemoveTrackOrError(transceiver->sender()).ok());
Henrik Boströme574a312020-08-25 10:20:11 +02001331 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1332 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001333
1334 EXPECT_EQ(RtpTransceiverDirection::kRecvOnly, transceiver->direction());
Steve Antonf9381f02017-12-14 10:23:57 -08001335}
1336
1337// Test that calling RemoveTrack on a sender where the transceiver is configured
1338// in the sendonly direction changes the transceiver's direction to inactive.
Steve Anton3172c032018-05-03 15:30:18 -07001339TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001340 RemoveTrackChangesDirectionFromSendOnlyToInactive) {
Steve Anton3172c032018-05-03 15:30:18 -07001341 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001342 auto callee = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001343
1344 RtpTransceiverInit init;
1345 init.direction = RtpTransceiverDirection::kSendOnly;
1346 auto transceiver =
1347 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Henrik Boströme574a312020-08-25 10:20:11 +02001348 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1349 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001350
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001351 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02001352 caller->observer()->clear_legacy_renegotiation_needed();
1353 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001354
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001355 ASSERT_TRUE(caller->pc()->RemoveTrackOrError(transceiver->sender()).ok());
Henrik Boströme574a312020-08-25 10:20:11 +02001356 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1357 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001358
1359 EXPECT_EQ(RtpTransceiverDirection::kInactive, transceiver->direction());
1360}
1361
1362// Test that calling RemoveTrack with a sender that has a null track results in
1363// no change in state.
Steve Anton3172c032018-05-03 15:30:18 -07001364TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackWithNullSenderTrackIsNoOp) {
1365 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001366
1367 auto sender = caller->AddAudioTrack("a");
1368 auto transceiver = caller->pc()->GetTransceivers()[0];
1369 ASSERT_TRUE(sender->SetTrack(nullptr));
1370
Henrik Boströme574a312020-08-25 10:20:11 +02001371 caller->observer()->clear_legacy_renegotiation_needed();
1372 caller->observer()->clear_latest_negotiation_needed_event();
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001373 ASSERT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok());
Henrik Boströme574a312020-08-25 10:20:11 +02001374 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1375 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001376
1377 EXPECT_EQ(RtpTransceiverDirection::kSendRecv, transceiver->direction());
1378}
1379
1380// Unified Plan RemoveTrack error handling.
1381
Steve Anton3172c032018-05-03 15:30:18 -07001382TEST_F(PeerConnectionRtpTestUnifiedPlan, RemoveTrackErrorIfClosed) {
1383 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001384
1385 auto sender = caller->AddAudioTrack("a");
1386 caller->pc()->Close();
1387
Henrik Boströme574a312020-08-25 10:20:11 +02001388 caller->observer()->clear_legacy_renegotiation_needed();
1389 caller->observer()->clear_latest_negotiation_needed_event();
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001390 EXPECT_FALSE(caller->pc()->RemoveTrackOrError(sender).ok());
Henrik Boströme574a312020-08-25 10:20:11 +02001391 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1392 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001393}
1394
Steve Anton3172c032018-05-03 15:30:18 -07001395TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Antonf9381f02017-12-14 10:23:57 -08001396 RemoveTrackNoErrorIfTrackAlreadyRemoved) {
Steve Anton3172c032018-05-03 15:30:18 -07001397 auto caller = CreatePeerConnection();
Steve Antonf9381f02017-12-14 10:23:57 -08001398
1399 auto sender = caller->AddAudioTrack("a");
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001400 ASSERT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok());
Steve Antonf9381f02017-12-14 10:23:57 -08001401
Henrik Boströme574a312020-08-25 10:20:11 +02001402 caller->observer()->clear_legacy_renegotiation_needed();
1403 caller->observer()->clear_latest_negotiation_needed_event();
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001404 EXPECT_TRUE(caller->pc()->RemoveTrackOrError(sender).ok());
Henrik Boströme574a312020-08-25 10:20:11 +02001405 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1406 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Antonf9381f02017-12-14 10:23:57 -08001407}
1408
Steve Anton60b6c1d2018-06-13 11:32:27 -07001409// Test that setting offers that add/remove/add a track repeatedly without
1410// setting the appropriate answer in between works.
1411// These are regression tests for bugs.webrtc.org/9401
1412TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksAudio) {
1413 auto caller = CreatePeerConnection();
1414
1415 auto sender1 = caller->AddAudioTrack("audio1");
1416 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1417
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001418 caller->pc()->RemoveTrackOrError(sender1);
Steve Anton60b6c1d2018-06-13 11:32:27 -07001419 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1420
1421 // This will re-use the transceiver created by the first AddTrack.
1422 auto sender2 = caller->AddAudioTrack("audio2");
1423 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1424
1425 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1426 EXPECT_EQ(sender1, sender2);
1427}
1428TEST_F(PeerConnectionRtpTestUnifiedPlan, AddRemoveAddTrackOffersWorksVideo) {
1429 auto caller = CreatePeerConnection();
1430
1431 auto sender1 = caller->AddVideoTrack("video1");
1432 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1433
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001434 caller->pc()->RemoveTrackOrError(sender1);
Steve Anton60b6c1d2018-06-13 11:32:27 -07001435 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1436
1437 // This will re-use the transceiver created by the first AddTrack.
1438 auto sender2 = caller->AddVideoTrack("video2");
1439 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1440
1441 EXPECT_EQ(1u, caller->pc()->GetTransceivers().size());
1442 EXPECT_EQ(sender1, sender2);
1443}
1444
Steve Anton07563732018-06-26 11:13:50 -07001445// Test that CreateOffer succeeds if two tracks with the same label are added.
1446TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateOfferSameTrackLabel) {
1447 auto caller = CreatePeerConnection();
1448
1449 auto audio_sender = caller->AddAudioTrack("track", {});
1450 auto video_sender = caller->AddVideoTrack("track", {});
1451
1452 EXPECT_TRUE(caller->CreateOffer());
1453
1454 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1455 EXPECT_NE(audio_sender->id(), video_sender->id());
1456}
1457
1458// Test that CreateAnswer succeeds if two tracks with the same label are added.
1459TEST_F(PeerConnectionRtpTestUnifiedPlan, CreateAnswerSameTrackLabel) {
1460 auto caller = CreatePeerConnection();
1461 auto callee = CreatePeerConnection();
1462
1463 RtpTransceiverInit recvonly;
1464 recvonly.direction = RtpTransceiverDirection::kRecvOnly;
1465 caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, recvonly);
1466 caller->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, recvonly);
1467
1468 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
1469
1470 auto audio_sender = callee->AddAudioTrack("track", {});
1471 auto video_sender = callee->AddVideoTrack("track", {});
1472
1473 EXPECT_TRUE(callee->CreateAnswer());
1474
1475 EXPECT_EQ(audio_sender->track()->id(), video_sender->track()->id());
1476 EXPECT_NE(audio_sender->id(), video_sender->id());
1477}
1478
1479// Test that calling AddTrack, RemoveTrack and AddTrack again creates a second
1480// m= section with a random sender id (different from the first, now rejected,
1481// m= section).
1482TEST_F(PeerConnectionRtpTestUnifiedPlan,
1483 AddRemoveAddTrackGeneratesNewSenderId) {
1484 auto caller = CreatePeerConnection();
1485 auto callee = CreatePeerConnection();
1486
1487 auto track = caller->CreateVideoTrack("video");
1488 auto sender1 = caller->AddTrack(track);
1489 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1490
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001491 caller->pc()->RemoveTrackOrError(sender1);
Steve Anton07563732018-06-26 11:13:50 -07001492 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1493
1494 auto sender2 = caller->AddTrack(track);
1495
1496 EXPECT_NE(sender1, sender2);
1497 EXPECT_NE(sender1->id(), sender2->id());
1498 std::string sender2_id = sender2->id();
1499
1500 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1501
1502 // The sender's ID should not change after negotiation.
1503 EXPECT_EQ(sender2_id, sender2->id());
1504}
1505
Steve Anton52d86772018-02-20 15:48:12 -08001506// Test that OnRenegotiationNeeded is fired if SetDirection is called on an
1507// active RtpTransceiver with a new direction.
Steve Anton3172c032018-05-03 15:30:18 -07001508TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001509 RenegotiationNeededAfterTransceiverSetDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001510 auto caller = CreatePeerConnection();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001511 auto callee = CreatePeerConnection();
Henrik Boströme574a312020-08-25 10:20:11 +02001512 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1513 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 15:48:12 -08001514
1515 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Henrik Boströme574a312020-08-25 10:20:11 +02001516 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1517 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 15:48:12 -08001518
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001519 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02001520 caller->observer()->clear_legacy_renegotiation_needed();
1521 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02001522
Harald Alvestrand6060df52020-08-11 09:54:02 +02001523 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive);
Henrik Boströme574a312020-08-25 10:20:11 +02001524 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
1525 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 15:48:12 -08001526}
1527
1528// Test that OnRenegotiationNeeded is not fired if SetDirection is called on an
1529// active RtpTransceiver with current direction.
Steve Anton3172c032018-05-03 15:30:18 -07001530TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001531 NoRenegotiationNeededAfterTransceiverSetSameDirection) {
Steve Anton3172c032018-05-03 15:30:18 -07001532 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001533
1534 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1535
Henrik Boströme574a312020-08-25 10:20:11 +02001536 caller->observer()->clear_legacy_renegotiation_needed();
1537 caller->observer()->clear_latest_negotiation_needed_event();
Harald Alvestrand6060df52020-08-11 09:54:02 +02001538 transceiver->SetDirectionWithError(transceiver->direction());
Henrik Boströme574a312020-08-25 10:20:11 +02001539 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1540 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 15:48:12 -08001541}
1542
1543// Test that OnRenegotiationNeeded is not fired if SetDirection is called on a
1544// stopped RtpTransceiver.
Steve Anton3172c032018-05-03 15:30:18 -07001545TEST_F(PeerConnectionRtpTestUnifiedPlan,
Steve Anton52d86772018-02-20 15:48:12 -08001546 NoRenegotiationNeededAfterSetDirectionOnStoppedTransceiver) {
Steve Anton3172c032018-05-03 15:30:18 -07001547 auto caller = CreatePeerConnection();
Steve Anton52d86772018-02-20 15:48:12 -08001548
1549 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
Harald Alvestrand6060df52020-08-11 09:54:02 +02001550 transceiver->StopInternal();
Steve Anton52d86772018-02-20 15:48:12 -08001551
Henrik Boströme574a312020-08-25 10:20:11 +02001552 caller->observer()->clear_legacy_renegotiation_needed();
1553 caller->observer()->clear_latest_negotiation_needed_event();
Harald Alvestrand6060df52020-08-11 09:54:02 +02001554 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive);
Henrik Boströme574a312020-08-25 10:20:11 +02001555 EXPECT_FALSE(caller->observer()->legacy_renegotiation_needed());
1556 EXPECT_FALSE(caller->observer()->has_negotiation_needed_event());
Steve Anton52d86772018-02-20 15:48:12 -08001557}
1558
Harald Alvestrand6060df52020-08-11 09:54:02 +02001559// Test that currentDirection returnes "stopped" if the transceiver was stopped.
1560TEST_F(PeerConnectionRtpTestUnifiedPlan,
1561 CheckStoppedCurrentDirectionOnStoppedTransceiver) {
1562 auto caller = CreatePeerConnection();
1563
1564 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1565 transceiver->StopInternal();
1566
1567 EXPECT_TRUE(transceiver->stopping());
1568 EXPECT_TRUE(transceiver->stopped());
1569 EXPECT_EQ(RtpTransceiverDirection::kStopped,
1570 transceiver->current_direction());
1571}
1572
1573// Test that InvalidState is thrown on a stopping transceiver.
1574TEST_F(PeerConnectionRtpTestUnifiedPlan,
1575 CheckForInvalidStateOnStoppingTransceiver) {
1576 auto caller = CreatePeerConnection();
1577
1578 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1579 transceiver->StopStandard();
1580
1581 EXPECT_TRUE(transceiver->stopping());
1582 EXPECT_FALSE(transceiver->stopped());
1583 EXPECT_EQ(
1584 RTCErrorType::INVALID_STATE,
1585 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive)
1586 .type());
1587}
1588
1589// Test that InvalidState is thrown on a stopped transceiver.
1590TEST_F(PeerConnectionRtpTestUnifiedPlan,
1591 CheckForInvalidStateOnStoppedTransceiver) {
1592 auto caller = CreatePeerConnection();
1593
1594 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1595 transceiver->StopInternal();
1596
1597 EXPECT_TRUE(transceiver->stopping());
1598 EXPECT_TRUE(transceiver->stopped());
1599 EXPECT_EQ(
1600 RTCErrorType::INVALID_STATE,
1601 transceiver->SetDirectionWithError(RtpTransceiverDirection::kInactive)
1602 .type());
1603}
1604
1605// Test that TypeError is thrown if the direction is set to "stopped".
1606TEST_F(PeerConnectionRtpTestUnifiedPlan,
1607 CheckForTypeErrorForStoppedOnTransceiver) {
1608 auto caller = CreatePeerConnection();
1609
1610 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1611 EXPECT_EQ(
1612 RTCErrorType::INVALID_PARAMETER,
1613 transceiver->SetDirectionWithError(RtpTransceiverDirection::kStopped)
1614 .type());
1615}
1616
Harald Alvestrand198cd732020-09-16 12:41:23 +00001617// Test that you can do createOffer/setLocalDescription with a stopped
1618// media section.
1619TEST_F(PeerConnectionRtpTestUnifiedPlan,
1620 SetLocalDescriptionWithStoppedMediaSection) {
1621 auto caller = CreatePeerConnection();
1622 auto callee = CreatePeerConnection();
1623 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1624 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1625 callee->pc()->GetTransceivers()[0]->StopStandard();
1626 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
1627 EXPECT_EQ(RtpTransceiverDirection::kStopped,
1628 transceiver->current_direction());
1629 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1630}
1631
Harald Alvestrand936f1af2020-09-22 07:41:50 +00001632TEST_F(PeerConnectionRtpTestUnifiedPlan,
1633 StopAndNegotiateCausesTransceiverToDisappear) {
1634 auto caller = CreatePeerConnection();
1635 auto callee = CreatePeerConnection();
1636 auto transceiver = caller->AddTransceiver(cricket::MEDIA_TYPE_AUDIO);
1637 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1638 callee->pc()->GetTransceivers()[0]->StopStandard();
1639 ASSERT_TRUE(callee->ExchangeOfferAnswerWith(caller.get()));
1640 EXPECT_EQ(RtpTransceiverDirection::kStopped,
1641 transceiver->current_direction());
1642 EXPECT_EQ(0U, caller->pc()->GetTransceivers().size());
1643 EXPECT_EQ(0U, callee->pc()->GetTransceivers().size());
1644 EXPECT_EQ(0U, caller->pc()->GetSenders().size());
1645 EXPECT_EQ(0U, callee->pc()->GetSenders().size());
1646 EXPECT_EQ(0U, caller->pc()->GetReceivers().size());
1647 EXPECT_EQ(0U, callee->pc()->GetReceivers().size());
1648}
1649
Harald Alvestrand09bd9ba2020-10-09 08:13:30 +00001650TEST_F(PeerConnectionRtpTestUnifiedPlan,
1651 SetLocalDescriptionWorksAfterRepeatedAddRemove) {
1652 auto caller = CreatePeerConnection();
1653 auto callee = CreatePeerConnection();
1654 auto video_track = caller->CreateVideoTrack("v");
1655 auto track = caller->CreateAudioTrack("a");
1656 caller->AddTransceiver(video_track);
1657 auto transceiver = caller->AddTransceiver(track);
1658 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001659 caller->pc()->RemoveTrackOrError(transceiver->sender());
Harald Alvestrand09bd9ba2020-10-09 08:13:30 +00001660 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1661 caller->AddTrack(track);
1662 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001663 caller->pc()->RemoveTrackOrError(transceiver->sender());
Harald Alvestrand09bd9ba2020-10-09 08:13:30 +00001664 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1665}
1666
1667// This is a repro of Chromium bug https://crbug.com/1134686
1668TEST_F(PeerConnectionRtpTestUnifiedPlan,
1669 SetLocalDescriptionWorksAfterRepeatedAddRemoveWithRemoteReject) {
1670 auto caller = CreatePeerConnection();
1671 auto callee = CreatePeerConnection();
1672 auto video_track = caller->CreateVideoTrack("v");
1673 auto track = caller->CreateAudioTrack("a");
1674 caller->AddTransceiver(video_track);
1675 auto transceiver = caller->AddTransceiver(track);
1676 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001677 caller->pc()->RemoveTrackOrError(transceiver->sender());
Harald Alvestrand09bd9ba2020-10-09 08:13:30 +00001678 ExchangeOfferAnswerWhereRemoteStopsTransceiver(caller.get(), callee.get(), 1);
1679 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1680 caller->AddTrack(track);
1681 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Harald Alvestrand93dd7632022-01-19 12:28:45 +00001682 caller->pc()->RemoveTrackOrError(transceiver->sender());
Harald Alvestrand09bd9ba2020-10-09 08:13:30 +00001683 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1684}
1685
Florent Castelli892acf02018-10-01 22:47:20 +02001686// Test that AddTransceiver fails if trying to use unimplemented RTP encoding
1687// parameters with the send_encodings parameters.
1688TEST_F(PeerConnectionRtpTestUnifiedPlan,
1689 CheckForUnsupportedEncodingParameters) {
1690 auto caller = CreatePeerConnection();
1691
1692 RtpTransceiverInit init;
1693 init.send_encodings.emplace_back();
1694
1695 auto default_send_encodings = init.send_encodings;
1696
Henrik Grunelle1301a82018-12-13 12:13:22 +00001697 // Unimplemented RtpParameters: ssrc, codec_payload_type, fec, rtx, dtx,
Amit Hilbuchaa584152019-02-06 17:09:52 -08001698 // ptime, scale_framerate_down_by, dependency_rids.
Florent Castelli892acf02018-10-01 22:47:20 +02001699 init.send_encodings[0].ssrc = 1;
1700 EXPECT_EQ(RTCErrorType::UNSUPPORTED_PARAMETER,
1701 caller->pc()
1702 ->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init)
1703 .error()
1704 .type());
1705 init.send_encodings = default_send_encodings;
Florent Castelli892acf02018-10-01 22:47:20 +02001706}
1707
Florent Castellic1a0bcb2019-01-29 14:26:48 +01001708// Test that AddTransceiver fails if trying to use invalid RTP encoding
1709// parameters with the send_encodings parameters.
1710TEST_F(PeerConnectionRtpTestUnifiedPlan, CheckForInvalidEncodingParameters) {
1711 auto caller = CreatePeerConnection();
1712
1713 RtpTransceiverInit init;
1714 init.send_encodings.emplace_back();
1715
1716 auto default_send_encodings = init.send_encodings;
1717
1718 init.send_encodings[0].scale_resolution_down_by = 0.5;
1719 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1720 caller->pc()
1721 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1722 .error()
1723 .type());
1724 init.send_encodings = default_send_encodings;
1725
1726 init.send_encodings[0].bitrate_priority = 0;
1727 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1728 caller->pc()
1729 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1730 .error()
1731 .type());
1732 init.send_encodings = default_send_encodings;
1733
1734 init.send_encodings[0].min_bitrate_bps = 200000;
1735 init.send_encodings[0].max_bitrate_bps = 100000;
1736 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1737 caller->pc()
1738 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1739 .error()
1740 .type());
1741 init.send_encodings = default_send_encodings;
1742
1743 init.send_encodings[0].num_temporal_layers = 0;
1744 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1745 caller->pc()
1746 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1747 .error()
1748 .type());
1749 init.send_encodings = default_send_encodings;
1750
1751 init.send_encodings[0].num_temporal_layers = 5;
1752 EXPECT_EQ(RTCErrorType::INVALID_RANGE,
1753 caller->pc()
1754 ->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init)
1755 .error()
1756 .type());
1757 init.send_encodings = default_send_encodings;
1758}
1759
Florent Castelli892acf02018-10-01 22:47:20 +02001760// Test that AddTransceiver transfers the send_encodings to the sender and they
1761// are retained after SetLocalDescription().
1762TEST_F(PeerConnectionRtpTestUnifiedPlan, SendEncodingsPassedToSender) {
1763 auto caller = CreatePeerConnection();
1764
1765 RtpTransceiverInit init;
1766 init.send_encodings.emplace_back();
1767 init.send_encodings[0].active = false;
1768 init.send_encodings[0].max_bitrate_bps = 180000;
1769
1770 auto result = caller->pc()->AddTransceiver(cricket::MEDIA_TYPE_AUDIO, init);
1771 ASSERT_TRUE(result.ok());
1772
1773 auto init_send_encodings = result.value()->sender()->init_send_encodings();
1774 EXPECT_FALSE(init_send_encodings[0].active);
1775 EXPECT_EQ(init_send_encodings[0].max_bitrate_bps, 180000);
1776
1777 auto parameters = result.value()->sender()->GetParameters();
1778 EXPECT_FALSE(parameters.encodings[0].active);
1779 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1780
1781 ASSERT_TRUE(caller->SetLocalDescription(caller->CreateOffer()));
1782
1783 parameters = result.value()->sender()->GetParameters();
1784 EXPECT_FALSE(parameters.encodings[0].active);
1785 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps, 180000);
1786}
1787
Steve Antone831b8c2018-02-01 12:22:16 -08001788// Test MSID signaling between Unified Plan and Plan B endpoints. There are two
1789// options for this kind of signaling: media section based (a=msid) and ssrc
1790// based (a=ssrc MSID). While JSEP only specifies media section MSID signaling,
1791// we want to ensure compatibility with older Plan B endpoints that might expect
1792// ssrc based MSID signaling. Thus we test here that Unified Plan offers both
1793// types but answers with the same type as the offer.
1794
Steve Anton3172c032018-05-03 15:30:18 -07001795class PeerConnectionMsidSignalingTest
1796 : public PeerConnectionRtpTestUnifiedPlan {};
Steve Antone831b8c2018-02-01 12:22:16 -08001797
1798TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanTalkingToOurself) {
1799 auto caller = CreatePeerConnectionWithUnifiedPlan();
1800 caller->AddAudioTrack("caller_audio");
1801 auto callee = CreatePeerConnectionWithUnifiedPlan();
1802 callee->AddAudioTrack("callee_audio");
1803
1804 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1805
1806 // Offer should have had both a=msid and a=ssrc MSID lines.
1807 auto* offer = callee->pc()->remote_description();
1808 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1809 cricket::kMsidSignalingSsrcAttribute),
1810 offer->description()->msid_signaling());
1811
1812 // Answer should have had only a=msid lines.
1813 auto* answer = caller->pc()->remote_description();
1814 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1815 answer->description()->msid_signaling());
Harald Alvestrand5dbb5862018-02-13 23:48:00 +01001816 // Check that this is counted correctly
Ying Wangef3998f2019-12-09 13:06:53 +01001817 EXPECT_METRIC_THAT(
1818 metrics::Samples("WebRTC.PeerConnection.SdpSemanticNegotiated"),
1819 ElementsAre(Pair(kSdpSemanticNegotiatedUnifiedPlan, 2)));
Steve Antone831b8c2018-02-01 12:22:16 -08001820}
1821
1822TEST_F(PeerConnectionMsidSignalingTest, PlanBOfferToUnifiedPlanAnswer) {
1823 auto caller = CreatePeerConnectionWithPlanB();
1824 caller->AddAudioTrack("caller_audio");
1825 auto callee = CreatePeerConnectionWithUnifiedPlan();
1826 callee->AddAudioTrack("callee_audio");
1827
1828 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1829
1830 // Offer should have only a=ssrc MSID lines.
1831 auto* offer = callee->pc()->remote_description();
1832 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1833 offer->description()->msid_signaling());
1834
1835 // Answer should have only a=ssrc MSID lines to match the offer.
1836 auto* answer = caller->pc()->remote_description();
1837 EXPECT_EQ(cricket::kMsidSignalingSsrcAttribute,
1838 answer->description()->msid_signaling());
1839}
1840
Seth Hampson5b4f0752018-04-02 16:31:36 -07001841// This tests that a Plan B endpoint appropriately sets the remote description
1842// from a Unified Plan offer. When the Unified Plan offer contains a=msid lines
1843// that signal no stream ids or multiple stream ids we expect that the Plan B
1844// endpoint always has exactly one media stream per track.
1845TEST_F(PeerConnectionMsidSignalingTest, UnifiedPlanToPlanBAnswer) {
1846 const std::string kStreamId1 = "audio_stream_1";
1847 const std::string kStreamId2 = "audio_stream_2";
1848
1849 auto caller = CreatePeerConnectionWithUnifiedPlan();
1850 caller->AddAudioTrack("caller_audio", {kStreamId1, kStreamId2});
1851 caller->AddVideoTrack("caller_video", {});
1852 auto callee = CreatePeerConnectionWithPlanB();
1853 callee->AddAudioTrack("callee_audio");
1854 caller->AddVideoTrack("callee_video");
1855
1856 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
1857
1858 // Offer should have had both a=msid and a=ssrc MSID lines.
1859 auto* offer = callee->pc()->remote_description();
1860 EXPECT_EQ((cricket::kMsidSignalingMediaSection |
1861 cricket::kMsidSignalingSsrcAttribute),
1862 offer->description()->msid_signaling());
1863
1864 // Callee should always have 1 stream for all of it's receivers.
1865 const auto& track_events = callee->observer()->add_track_events_;
1866 ASSERT_EQ(2u, track_events.size());
1867 ASSERT_EQ(1u, track_events[0].streams.size());
1868 EXPECT_EQ(kStreamId1, track_events[0].streams[0]->id());
1869 ASSERT_EQ(1u, track_events[1].streams.size());
1870 // This autogenerated a stream id for the empty one signalled.
1871 EXPECT_FALSE(track_events[1].streams[0]->id().empty());
1872}
1873
Steve Antone831b8c2018-02-01 12:22:16 -08001874TEST_F(PeerConnectionMsidSignalingTest, PureUnifiedPlanToUs) {
1875 auto caller = CreatePeerConnectionWithUnifiedPlan();
1876 caller->AddAudioTrack("caller_audio");
1877 auto callee = CreatePeerConnectionWithUnifiedPlan();
1878 callee->AddAudioTrack("callee_audio");
1879
1880 auto offer = caller->CreateOffer();
1881 // Simulate a pure Unified Plan offerer by setting the MSID signaling to media
1882 // section only.
1883 offer->description()->set_msid_signaling(cricket::kMsidSignalingMediaSection);
1884
1885 ASSERT_TRUE(
1886 caller->SetLocalDescription(CloneSessionDescription(offer.get())));
1887 ASSERT_TRUE(callee->SetRemoteDescription(std::move(offer)));
1888
1889 // Answer should have only a=msid to match the offer.
1890 auto answer = callee->CreateAnswer();
1891 EXPECT_EQ(cricket::kMsidSignalingMediaSection,
1892 answer->description()->msid_signaling());
1893}
1894
Steve Anton8e20f172018-03-06 10:55:04 -08001895// Test that the correct UMA metrics are reported for simple/complex SDP.
1896
Steve Anton3172c032018-05-03 15:30:18 -07001897class SdpFormatReceivedTest : public PeerConnectionRtpTestUnifiedPlan {};
Steve Anton8e20f172018-03-06 10:55:04 -08001898
Mirko Bonadei5eb43b42021-01-18 13:24:40 +01001899#ifdef WEBRTC_HAVE_SCTP
Steve Anton8e20f172018-03-06 10:55:04 -08001900TEST_F(SdpFormatReceivedTest, DataChannelOnlyIsReportedAsNoTracks) {
1901 auto caller = CreatePeerConnectionWithUnifiedPlan();
1902 caller->CreateDataChannel("dc");
1903 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001904
1905 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001906 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001907 EXPECT_METRIC_THAT(
1908 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1909 ElementsAre(Pair(kSdpFormatReceivedNoTracks, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001910}
Mirko Bonadei5eb43b42021-01-18 13:24:40 +01001911#endif // WEBRTC_HAVE_SCTP
Steve Anton8e20f172018-03-06 10:55:04 -08001912
1913TEST_F(SdpFormatReceivedTest, SimpleUnifiedPlanIsReportedAsSimple) {
1914 auto caller = CreatePeerConnectionWithUnifiedPlan();
1915 caller->AddAudioTrack("audio");
1916 caller->AddVideoTrack("video");
1917 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001918
1919 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001920 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001921 EXPECT_METRIC_THAT(
1922 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1923 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001924}
1925
1926TEST_F(SdpFormatReceivedTest, SimplePlanBIsReportedAsSimple) {
1927 auto caller = CreatePeerConnectionWithPlanB();
1928 caller->AddVideoTrack("video"); // Video only.
1929 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001930
1931 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Steve Antonc1e6e862019-03-04 14:43:44 -08001932 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001933 EXPECT_METRIC_THAT(
1934 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1935 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001936}
1937
1938TEST_F(SdpFormatReceivedTest, ComplexUnifiedIsReportedAsComplexUnifiedPlan) {
1939 auto caller = CreatePeerConnectionWithUnifiedPlan();
1940 caller->AddAudioTrack("audio1");
1941 caller->AddAudioTrack("audio2");
1942 caller->AddVideoTrack("video");
1943 auto callee = CreatePeerConnectionWithPlanB();
Steve Anton8e20f172018-03-06 10:55:04 -08001944
1945 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001946 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001947 EXPECT_METRIC_THAT(
1948 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1949 ElementsAre(Pair(kSdpFormatReceivedComplexUnifiedPlan, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001950}
1951
1952TEST_F(SdpFormatReceivedTest, ComplexPlanBIsReportedAsComplexPlanB) {
1953 auto caller = CreatePeerConnectionWithPlanB();
1954 caller->AddVideoTrack("video1");
1955 caller->AddVideoTrack("video2");
1956 auto callee = CreatePeerConnectionWithUnifiedPlan();
Steve Anton8e20f172018-03-06 10:55:04 -08001957
Steve Antonba42e992018-04-09 14:10:01 -07001958 // This fails since Unified Plan cannot set a session description with
1959 // multiple "Plan B tracks" in the same media section. But we still expect the
1960 // SDP Format to be recorded.
1961 ASSERT_FALSE(callee->SetRemoteDescription(caller->CreateOffer()));
Qingsi Wang7fc821d2018-07-12 12:54:53 -07001962 // Note that only the callee does ReportSdpFormatReceived.
Ying Wangef3998f2019-12-09 13:06:53 +01001963 EXPECT_METRIC_THAT(
1964 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceived"),
1965 ElementsAre(Pair(kSdpFormatReceivedComplexPlanB, 1)));
Steve Anton8e20f172018-03-06 10:55:04 -08001966}
1967
Philipp Hanckeb8ca2a12020-10-07 12:47:10 +02001968TEST_F(SdpFormatReceivedTest, AnswerIsReported) {
1969 auto caller = CreatePeerConnectionWithPlanB();
1970 caller->AddAudioTrack("audio");
1971 caller->AddVideoTrack("video");
1972 auto callee = CreatePeerConnectionWithUnifiedPlan();
1973
1974 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
1975 ASSERT_TRUE(caller->SetRemoteDescription(callee->CreateAnswer()));
1976 EXPECT_METRIC_THAT(
1977 metrics::Samples("WebRTC.PeerConnection.SdpFormatReceivedAnswer"),
1978 ElementsAre(Pair(kSdpFormatReceivedSimple, 1)));
1979}
1980
Henrik Boström91d039b2018-01-11 17:43:30 +01001981// Sender setups in a call.
1982
Steve Anton3172c032018-05-03 15:30:18 -07001983TEST_P(PeerConnectionRtpTest, CreateTwoSendersWithSameTrack) {
Henrik Boström91d039b2018-01-11 17:43:30 +01001984 auto caller = CreatePeerConnection();
1985 auto callee = CreatePeerConnection();
1986
1987 auto track = caller->CreateAudioTrack("audio_track");
1988 auto sender1 = caller->AddTrack(track);
1989 ASSERT_TRUE(sender1);
1990 // We need to temporarily reset the track for the subsequent AddTrack() to
1991 // succeed.
1992 EXPECT_TRUE(sender1->SetTrack(nullptr));
1993 auto sender2 = caller->AddTrack(track);
1994 EXPECT_TRUE(sender2);
1995 EXPECT_TRUE(sender1->SetTrack(track));
1996
Steve Anton3172c032018-05-03 15:30:18 -07001997 if (sdp_semantics_ == SdpSemantics::kPlanB) {
1998 // TODO(hbos): When https://crbug.com/webrtc/8734 is resolved, this should
Artem Titovcfea2182021-08-10 01:22:31 +02001999 // return true, and doing `callee->SetRemoteDescription()` should work.
Steve Anton3172c032018-05-03 15:30:18 -07002000 EXPECT_FALSE(caller->CreateOfferAndSetAsLocal());
2001 } else {
2002 EXPECT_TRUE(caller->CreateOfferAndSetAsLocal());
2003 }
Henrik Boström91d039b2018-01-11 17:43:30 +01002004}
2005
Guido Urdaneta70c2db12019-04-16 12:24:14 +02002006// This test exercises the code path that fires a NegotiationNeeded
2007// notification when the stream IDs of the local description differ from
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02002008// the ones in the transceiver.
Guido Urdaneta70c2db12019-04-16 12:24:14 +02002009TEST_F(PeerConnectionRtpTestUnifiedPlan,
2010 ChangeAssociatedStreamsTriggersRenegotiation) {
2011 auto caller = CreatePeerConnection();
2012 auto callee = CreatePeerConnection();
2013
2014 RtpTransceiverInit init;
2015 init.direction = RtpTransceiverDirection::kSendRecv;
2016 auto transceiver =
2017 caller->AddTransceiver(caller->CreateAudioTrack("a"), init);
Henrik Boströme574a312020-08-25 10:20:11 +02002018 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
2019 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Guido Urdaneta70c2db12019-04-16 12:24:14 +02002020
2021 ASSERT_TRUE(caller->ExchangeOfferAnswerWith(callee.get()));
Henrik Boströme574a312020-08-25 10:20:11 +02002022 caller->observer()->clear_legacy_renegotiation_needed();
2023 caller->observer()->clear_latest_negotiation_needed_event();
Guido Urdaneta70c2db12019-04-16 12:24:14 +02002024
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02002025 transceiver->sender()->SetStreams({"stream3", "stream4", "stream5"});
Henrik Boströme574a312020-08-25 10:20:11 +02002026 EXPECT_TRUE(caller->observer()->legacy_renegotiation_needed());
2027 EXPECT_TRUE(caller->observer()->has_negotiation_needed_event());
Guido Urdaneta1ff16c82019-05-20 19:31:53 +02002028
2029 ASSERT_TRUE(callee->SetRemoteDescription(caller->CreateOfferAndSetAsLocal()));
2030 auto callee_streams = callee->pc()->GetReceivers()[0]->streams();
2031 ASSERT_EQ(3u, callee_streams.size());
2032 EXPECT_EQ("stream3", callee_streams[0]->id());
2033 EXPECT_EQ("stream4", callee_streams[1]->id());
2034 EXPECT_EQ("stream5", callee_streams[2]->id());
Guido Urdaneta70c2db12019-04-16 12:24:14 +02002035}
2036
Mirko Bonadeic84f6612019-01-31 12:20:57 +01002037INSTANTIATE_TEST_SUITE_P(PeerConnectionRtpTest,
2038 PeerConnectionRtpTest,
2039 Values(SdpSemantics::kPlanB,
2040 SdpSemantics::kUnifiedPlan));
Steve Anton3172c032018-05-03 15:30:18 -07002041
Steve Anton9158ef62017-11-27 13:01:52 -08002042} // namespace webrtc