pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 11 | #include <list> |
kwiberg | 22feaa3 | 2016-03-17 09:17:43 -0700 | [diff] [blame] | 12 | #include <memory> |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 13 | #include <string> |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 14 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 15 | #include "modules/pacing/paced_sender.h" |
| 16 | #include "system_wrappers/include/clock.h" |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 17 | #include "system_wrappers/include/field_trial.h" |
| 18 | #include "test/field_trial.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 19 | #include "test/gmock.h" |
| 20 | #include "test/gtest.h" |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 21 | |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 22 | using testing::_; |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 23 | using testing::Field; |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 24 | using testing::Return; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 25 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 26 | namespace { |
| 27 | constexpr unsigned kFirstClusterBps = 900000; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 28 | constexpr unsigned kSecondClusterBps = 1800000; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 29 | |
| 30 | // The error stems from truncating the time interval of probe packets to integer |
| 31 | // values. This results in probing slightly higher than the target bitrate. |
| 32 | // For 1.8 Mbps, this comes to be about 120 kbps with 1200 probe packets. |
| 33 | constexpr int kBitrateProbingError = 150000; |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 34 | |
| 35 | const float kPaceMultiplier = 2.5f; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 36 | } // namespace |
| 37 | |
Danil Chapovalov | 74a369c | 2018-02-14 10:48:49 +0000 | [diff] [blame] | 38 | namespace webrtc { |
| 39 | namespace test { |
| 40 | |
| 41 | static const int kTargetBitrateBps = 800000; |
| 42 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 43 | class MockPacedSenderCallback : public PacedSender::PacketSender { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 44 | public: |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 45 | MOCK_METHOD5(TimeToSendPacket, |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 46 | bool(uint32_t ssrc, |
| 47 | uint16_t sequence_number, |
| 48 | int64_t capture_time_ms, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 49 | bool retransmission, |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 50 | const PacedPacketInfo& pacing_info)); |
| 51 | MOCK_METHOD2(TimeToSendPadding, |
| 52 | size_t(size_t bytes, const PacedPacketInfo& pacing_info)); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 53 | }; |
| 54 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 55 | class PacedSenderPadding : public PacedSender::PacketSender { |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 56 | public: |
| 57 | PacedSenderPadding() : padding_sent_(0) {} |
| 58 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 59 | bool TimeToSendPacket(uint32_t ssrc, |
| 60 | uint16_t sequence_number, |
| 61 | int64_t capture_time_ms, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 62 | bool retransmission, |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 63 | const PacedPacketInfo& pacing_info) override { |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 64 | return true; |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 65 | } |
| 66 | |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 67 | size_t TimeToSendPadding(size_t bytes, |
| 68 | const PacedPacketInfo& pacing_info) override { |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 69 | const size_t kPaddingPacketSize = 224; |
| 70 | size_t num_packets = (bytes + kPaddingPacketSize - 1) / kPaddingPacketSize; |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 71 | padding_sent_ += kPaddingPacketSize * num_packets; |
| 72 | return kPaddingPacketSize * num_packets; |
| 73 | } |
| 74 | |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 75 | size_t padding_sent() { return padding_sent_; } |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 76 | |
| 77 | private: |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 78 | size_t padding_sent_; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 79 | }; |
| 80 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 81 | class PacedSenderProbing : public PacedSender::PacketSender { |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 82 | public: |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 83 | PacedSenderProbing() : packets_sent_(0), padding_sent_(0) {} |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 84 | |
| 85 | bool TimeToSendPacket(uint32_t ssrc, |
| 86 | uint16_t sequence_number, |
| 87 | int64_t capture_time_ms, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 88 | bool retransmission, |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 89 | const PacedPacketInfo& pacing_info) override { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 90 | packets_sent_++; |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 91 | return true; |
| 92 | } |
| 93 | |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 94 | size_t TimeToSendPadding(size_t bytes, |
| 95 | const PacedPacketInfo& pacing_info) override { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 96 | padding_sent_ += bytes; |
| 97 | return padding_sent_; |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 98 | } |
| 99 | |
| 100 | int packets_sent() const { return packets_sent_; } |
| 101 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 102 | int padding_sent() const { return padding_sent_; } |
| 103 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 104 | private: |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 105 | int packets_sent_; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 106 | int padding_sent_; |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 107 | }; |
| 108 | |
philipel | ccdfcca | 2017-10-23 12:42:17 +0200 | [diff] [blame] | 109 | class PacedSenderTest : public testing::TestWithParam<std::string> { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 110 | protected: |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 111 | PacedSenderTest() : clock_(123456) { |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 112 | srand(0); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 113 | // Need to initialize PacedSender after we initialize clock. |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 114 | send_bucket_.reset(new PacedSender(&clock_, &callback_, nullptr)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 115 | send_bucket_->CreateProbeCluster(kFirstClusterBps); |
| 116 | send_bucket_->CreateProbeCluster(kSecondClusterBps); |
stefan@webrtc.org | e9f0f59 | 2015-02-16 15:47:51 +0000 | [diff] [blame] | 117 | // Default to bitrate probing disabled for testing purposes. Probing tests |
| 118 | // have to enable probing, either by creating a new PacedSender instance or |
| 119 | // by calling SetProbingEnabled(true). |
| 120 | send_bucket_->SetProbingEnabled(false); |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 121 | send_bucket_->SetPacingRates(kTargetBitrateBps * kPaceMultiplier, 0); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 122 | |
| 123 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 124 | } |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 125 | |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 126 | void SendAndExpectPacket(PacedSender::Priority priority, |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 127 | uint32_t ssrc, |
| 128 | uint16_t sequence_number, |
| 129 | int64_t capture_time_ms, |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 130 | size_t size, |
stefan@webrtc.org | 9b82f5a | 2013-11-13 15:29:21 +0000 | [diff] [blame] | 131 | bool retransmission) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 132 | send_bucket_->InsertPacket(priority, ssrc, sequence_number, capture_time_ms, |
| 133 | size, retransmission); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 134 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
terelius | f39f7d9 | 2016-07-20 03:36:19 -0700 | [diff] [blame] | 135 | capture_time_ms, retransmission, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 136 | .Times(1) |
| 137 | .WillRepeatedly(Return(true)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 138 | } |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 139 | SimulatedClock clock_; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 140 | MockPacedSenderCallback callback_; |
kwiberg | 22feaa3 | 2016-03-17 09:17:43 -0700 | [diff] [blame] | 141 | std::unique_ptr<PacedSender> send_bucket_; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 142 | }; |
| 143 | |
Sebastian Jansson | c235a8d | 2018-06-15 14:46:11 +0200 | [diff] [blame] | 144 | class PacedSenderFieldTrialTest : public testing::Test { |
| 145 | protected: |
| 146 | struct MediaStream { |
| 147 | const RtpPacketSender::Priority priority; |
| 148 | const uint32_t ssrc; |
| 149 | const size_t packet_size; |
| 150 | uint16_t seq_num; |
| 151 | }; |
| 152 | |
| 153 | const int kProcessIntervalsPerSecond = 1000 / 5; |
| 154 | |
| 155 | PacedSenderFieldTrialTest() : clock_(123456) {} |
| 156 | void InsertPacket(PacedSender* pacer, MediaStream* stream) { |
| 157 | pacer->InsertPacket(stream->priority, stream->ssrc, stream->seq_num++, |
| 158 | clock_.TimeInMilliseconds(), stream->packet_size, |
| 159 | false); |
| 160 | } |
| 161 | void ProcessNext(PacedSender* pacer) { |
| 162 | clock_.AdvanceTimeMilliseconds(5); |
| 163 | pacer->Process(); |
| 164 | } |
| 165 | MediaStream audio{/*priority*/ PacedSender::kHighPriority, |
| 166 | /*ssrc*/ 3333, /*packet_size*/ 100, /*seq_num*/ 1000}; |
| 167 | MediaStream video{/*priority*/ PacedSender::kNormalPriority, |
| 168 | /*ssrc*/ 4444, /*packet_size*/ 1000, /*seq_num*/ 1000}; |
| 169 | SimulatedClock clock_; |
| 170 | MockPacedSenderCallback callback_; |
| 171 | }; |
| 172 | |
| 173 | TEST_F(PacedSenderFieldTrialTest, DefaultNoPaddingInSilence) { |
| 174 | PacedSender pacer(&clock_, &callback_, nullptr); |
| 175 | pacer.SetPacingRates(kTargetBitrateBps, 0); |
| 176 | // Video packet to reset last send time and provide padding data. |
| 177 | InsertPacket(&pacer, &video); |
| 178 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 179 | clock_.AdvanceTimeMilliseconds(5); |
| 180 | pacer.Process(); |
| 181 | EXPECT_CALL(callback_, TimeToSendPadding).Times(0); |
| 182 | // Waiting 500 ms should not trigger sending of padding. |
| 183 | clock_.AdvanceTimeMilliseconds(500); |
| 184 | pacer.Process(); |
| 185 | } |
| 186 | |
| 187 | TEST_F(PacedSenderFieldTrialTest, PaddingInSilenceWithTrial) { |
| 188 | ScopedFieldTrials trial("WebRTC-Pacer-PadInSilence/Enabled/"); |
| 189 | PacedSender pacer(&clock_, &callback_, nullptr); |
| 190 | pacer.SetPacingRates(kTargetBitrateBps, 0); |
| 191 | // Video packet to reset last send time and provide padding data. |
| 192 | InsertPacket(&pacer, &video); |
| 193 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 194 | clock_.AdvanceTimeMilliseconds(5); |
| 195 | pacer.Process(); |
| 196 | EXPECT_CALL(callback_, TimeToSendPadding).WillOnce(Return(1000)); |
| 197 | // Waiting 500 ms should trigger sending of padding. |
| 198 | clock_.AdvanceTimeMilliseconds(500); |
| 199 | pacer.Process(); |
| 200 | } |
| 201 | |
Sebastian Jansson | ce4829a | 2018-06-15 14:47:35 +0200 | [diff] [blame] | 202 | TEST_F(PacedSenderFieldTrialTest, DefaultCongestionWindowAffectsAudio) { |
| 203 | EXPECT_CALL(callback_, TimeToSendPadding).Times(0); |
| 204 | PacedSender pacer(&clock_, &callback_, nullptr); |
| 205 | pacer.SetPacingRates(10000000, 0); |
| 206 | pacer.SetCongestionWindow(800); |
| 207 | pacer.UpdateOutstandingData(0); |
| 208 | // Video packet fills congestion window. |
| 209 | InsertPacket(&pacer, &video); |
| 210 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 211 | ProcessNext(&pacer); |
| 212 | // Audio packet blocked due to congestion. |
| 213 | InsertPacket(&pacer, &audio); |
| 214 | EXPECT_CALL(callback_, TimeToSendPacket).Times(0); |
| 215 | ProcessNext(&pacer); |
| 216 | ProcessNext(&pacer); |
| 217 | // Audio packet unblocked when congestion window clear. |
| 218 | testing::Mock::VerifyAndClearExpectations(&callback_); |
| 219 | pacer.UpdateOutstandingData(0); |
| 220 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 221 | ProcessNext(&pacer); |
| 222 | } |
| 223 | |
| 224 | TEST_F(PacedSenderFieldTrialTest, CongestionWindowDoesNotAffectAudioInTrial) { |
| 225 | ScopedFieldTrials trial("WebRTC-Pacer-BlockAudio/Disabled/"); |
| 226 | EXPECT_CALL(callback_, TimeToSendPadding).Times(0); |
| 227 | PacedSender pacer(&clock_, &callback_, nullptr); |
| 228 | pacer.SetPacingRates(10000000, 0); |
| 229 | pacer.SetCongestionWindow(800); |
| 230 | pacer.UpdateOutstandingData(0); |
| 231 | // Video packet fills congestion window. |
| 232 | InsertPacket(&pacer, &video); |
| 233 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 234 | ProcessNext(&pacer); |
| 235 | // Audio not blocked due to congestion. |
| 236 | InsertPacket(&pacer, &audio); |
| 237 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 238 | ProcessNext(&pacer); |
| 239 | } |
| 240 | |
| 241 | TEST_F(PacedSenderFieldTrialTest, DefaultBudgetAffectsAudio) { |
| 242 | PacedSender pacer(&clock_, &callback_, nullptr); |
| 243 | pacer.SetPacingRates(video.packet_size / 3 * 8 * kProcessIntervalsPerSecond, |
| 244 | 0); |
| 245 | // Video fills budget for following process periods. |
| 246 | InsertPacket(&pacer, &video); |
| 247 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 248 | ProcessNext(&pacer); |
| 249 | // Audio packet blocked due to budget limit. |
| 250 | EXPECT_CALL(callback_, TimeToSendPacket).Times(0); |
| 251 | InsertPacket(&pacer, &audio); |
| 252 | ProcessNext(&pacer); |
| 253 | ProcessNext(&pacer); |
| 254 | testing::Mock::VerifyAndClearExpectations(&callback_); |
| 255 | // Audio packet unblocked when the budget has recovered. |
| 256 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 257 | ProcessNext(&pacer); |
| 258 | ProcessNext(&pacer); |
| 259 | } |
| 260 | |
| 261 | TEST_F(PacedSenderFieldTrialTest, BudgetDoesNotAffectAudioInTrial) { |
| 262 | ScopedFieldTrials trial("WebRTC-Pacer-BlockAudio/Disabled/"); |
| 263 | EXPECT_CALL(callback_, TimeToSendPadding).Times(0); |
| 264 | PacedSender pacer(&clock_, &callback_, nullptr); |
| 265 | pacer.SetPacingRates(video.packet_size / 3 * 8 * kProcessIntervalsPerSecond, |
| 266 | 0); |
| 267 | // Video fills budget for following process periods. |
| 268 | InsertPacket(&pacer, &video); |
| 269 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 270 | ProcessNext(&pacer); |
| 271 | // Audio packet not blocked due to budget limit. |
| 272 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 273 | InsertPacket(&pacer, &audio); |
| 274 | ProcessNext(&pacer); |
| 275 | } |
| 276 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 277 | TEST_F(PacedSenderTest, FirstSentPacketTimeIsSet) { |
asapersson | fc5e81c | 2017-04-19 23:28:53 -0700 | [diff] [blame] | 278 | uint16_t sequence_number = 1234; |
| 279 | const uint32_t kSsrc = 12345; |
| 280 | const size_t kSizeBytes = 250; |
| 281 | const size_t kPacketToSend = 3; |
| 282 | const int64_t kStartMs = clock_.TimeInMilliseconds(); |
| 283 | |
| 284 | // No packet sent. |
| 285 | EXPECT_EQ(-1, send_bucket_->FirstSentPacketTimeMs()); |
| 286 | |
| 287 | for (size_t i = 0; i < kPacketToSend; ++i) { |
| 288 | SendAndExpectPacket(PacedSender::kNormalPriority, kSsrc, sequence_number++, |
| 289 | clock_.TimeInMilliseconds(), kSizeBytes, false); |
| 290 | send_bucket_->Process(); |
| 291 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
| 292 | } |
| 293 | EXPECT_EQ(kStartMs, send_bucket_->FirstSentPacketTimeMs()); |
| 294 | } |
| 295 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 296 | TEST_F(PacedSenderTest, QueuePacket) { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 297 | uint32_t ssrc = 12345; |
| 298 | uint16_t sequence_number = 1234; |
Danil Chapovalov | 74a369c | 2018-02-14 10:48:49 +0000 | [diff] [blame] | 299 | // Due to the multiplicative factor we can send 5 packets during a send |
| 300 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 301 | // (packet size * #send intervals per second) |
| 302 | const size_t packets_to_send = |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 303 | kTargetBitrateBps * kPaceMultiplier / (8 * 250 * 200); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 304 | for (size_t i = 0; i < packets_to_send; ++i) { |
| 305 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 306 | clock_.TimeInMilliseconds(), 250, false); |
| 307 | } |
| 308 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 309 | int64_t queued_packet_timestamp = clock_.TimeInMilliseconds(); |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 310 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 311 | sequence_number, queued_packet_timestamp, 250, |
| 312 | false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 313 | EXPECT_EQ(packets_to_send + 1, send_bucket_->QueueSizePackets()); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 314 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 315 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 316 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 317 | clock_.AdvanceTimeMilliseconds(4); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 318 | EXPECT_EQ(1, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 319 | clock_.AdvanceTimeMilliseconds(1); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 320 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 321 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 322 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number++, |
| 323 | queued_packet_timestamp, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 324 | .Times(1) |
| 325 | .WillRepeatedly(Return(true)); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 326 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 327 | sequence_number++; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 328 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 329 | |
| 330 | // We can send packets_to_send -1 packets of size 250 during the current |
| 331 | // interval since one packet has already been sent. |
| 332 | for (size_t i = 0; i < packets_to_send - 1; ++i) { |
| 333 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 334 | clock_.TimeInMilliseconds(), 250, false); |
| 335 | } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 336 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 337 | sequence_number++, clock_.TimeInMilliseconds(), |
| 338 | 250, false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 339 | EXPECT_EQ(packets_to_send, send_bucket_->QueueSizePackets()); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 340 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 341 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 342 | } |
| 343 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 344 | TEST_F(PacedSenderTest, PaceQueuedPackets) { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 345 | uint32_t ssrc = 12345; |
| 346 | uint16_t sequence_number = 1234; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 347 | |
Danil Chapovalov | 74a369c | 2018-02-14 10:48:49 +0000 | [diff] [blame] | 348 | // Due to the multiplicative factor we can send 5 packets during a send |
| 349 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 350 | // (packet size * #send intervals per second) |
| 351 | const size_t packets_to_send_per_interval = |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 352 | kTargetBitrateBps * kPaceMultiplier / (8 * 250 * 200); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 353 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 354 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 355 | clock_.TimeInMilliseconds(), 250, false); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 356 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 357 | |
| 358 | for (size_t j = 0; j < packets_to_send_per_interval * 10; ++j) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 359 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 360 | sequence_number++, clock_.TimeInMilliseconds(), |
| 361 | 250, false); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 362 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 363 | EXPECT_EQ(packets_to_send_per_interval + packets_to_send_per_interval * 10, |
| 364 | send_bucket_->QueueSizePackets()); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 365 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 366 | EXPECT_EQ(packets_to_send_per_interval * 10, |
| 367 | send_bucket_->QueueSizePackets()); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 368 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 369 | for (int k = 0; k < 10; ++k) { |
| 370 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 371 | clock_.AdvanceTimeMilliseconds(5); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 372 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, _, false, _)) |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 373 | .Times(packets_to_send_per_interval) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 374 | .WillRepeatedly(Return(true)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 375 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 376 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 377 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 378 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 379 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 380 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 381 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 382 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 383 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 384 | |
| 385 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 386 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 387 | clock_.TimeInMilliseconds(), 250, false); |
| 388 | } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 389 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 390 | sequence_number, clock_.TimeInMilliseconds(), 250, |
| 391 | false); |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 392 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 393 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 394 | } |
| 395 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 396 | TEST_F(PacedSenderTest, RepeatedRetransmissionsAllowed) { |
philipel | 7dc719a | 2017-09-29 16:15:25 +0200 | [diff] [blame] | 397 | // Send one packet, then two retransmissions of that packet. |
| 398 | for (size_t i = 0; i < 3; i++) { |
| 399 | constexpr uint32_t ssrc = 333; |
| 400 | constexpr uint16_t sequence_number = 444; |
| 401 | constexpr size_t bytes = 250; |
| 402 | bool is_retransmission = (i != 0); // Original followed by retransmissions. |
| 403 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number, |
| 404 | clock_.TimeInMilliseconds(), bytes, is_retransmission); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 405 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | 52aa019 | 2013-04-25 17:35:56 +0000 | [diff] [blame] | 406 | } |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 407 | send_bucket_->Process(); |
pwestin@webrtc.org | 52aa019 | 2013-04-25 17:35:56 +0000 | [diff] [blame] | 408 | } |
| 409 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 410 | TEST_F(PacedSenderTest, CanQueuePacketsWithSameSequenceNumberOnDifferentSsrcs) { |
pbos@webrtc.org | 03c817e | 2014-07-07 10:20:35 +0000 | [diff] [blame] | 411 | uint32_t ssrc = 12345; |
| 412 | uint16_t sequence_number = 1234; |
| 413 | |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 414 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number, |
| 415 | clock_.TimeInMilliseconds(), 250, false); |
pbos@webrtc.org | 03c817e | 2014-07-07 10:20:35 +0000 | [diff] [blame] | 416 | |
| 417 | // Expect packet on second ssrc to be queued and sent as well. |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 418 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc + 1, sequence_number, |
| 419 | clock_.TimeInMilliseconds(), 250, false); |
pbos@webrtc.org | 03c817e | 2014-07-07 10:20:35 +0000 | [diff] [blame] | 420 | |
| 421 | clock_.AdvanceTimeMilliseconds(1000); |
pbos@webrtc.org | 03c817e | 2014-07-07 10:20:35 +0000 | [diff] [blame] | 422 | send_bucket_->Process(); |
| 423 | } |
| 424 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 425 | TEST_F(PacedSenderTest, Padding) { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 426 | uint32_t ssrc = 12345; |
| 427 | uint16_t sequence_number = 1234; |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 428 | |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 429 | send_bucket_->SetPacingRates(kTargetBitrateBps * kPaceMultiplier, |
| 430 | kTargetBitrateBps); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 431 | |
Danil Chapovalov | 74a369c | 2018-02-14 10:48:49 +0000 | [diff] [blame] | 432 | // Due to the multiplicative factor we can send 5 packets during a send |
| 433 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 434 | // (packet size * #send intervals per second) |
| 435 | const size_t packets_to_send_per_interval = |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 436 | kTargetBitrateBps * kPaceMultiplier / (8 * 250 * 200); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 437 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 438 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 439 | clock_.TimeInMilliseconds(), 250, false); |
| 440 | } |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 441 | // No padding is expected since we have sent too much already. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 442 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 443 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 444 | send_bucket_->Process(); |
| 445 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 446 | |
| 447 | // 5 milliseconds later should not send padding since we filled the buffers |
| 448 | // initially. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 449 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)).Times(0); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 450 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 451 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 452 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 453 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 454 | |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 455 | // 5 milliseconds later we have enough budget to send some padding. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 456 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)) |
| 457 | .Times(1) |
| 458 | .WillOnce(Return(250)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 459 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 460 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 461 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 462 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 463 | } |
| 464 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 465 | TEST_F(PacedSenderTest, NoPaddingBeforeNormalPacket) { |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 466 | send_bucket_->SetPacingRates(kTargetBitrateBps * kPaceMultiplier, |
| 467 | kTargetBitrateBps); |
perkj | 71ee44c | 2016-06-15 00:47:53 -0700 | [diff] [blame] | 468 | |
| 469 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
| 470 | send_bucket_->Process(); |
| 471 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
| 472 | |
| 473 | send_bucket_->Process(); |
| 474 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
| 475 | |
| 476 | uint32_t ssrc = 12345; |
| 477 | uint16_t sequence_number = 1234; |
| 478 | int64_t capture_time_ms = 56789; |
| 479 | |
| 480 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 481 | capture_time_ms, 250, false); |
| 482 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)) |
| 483 | .Times(1) |
| 484 | .WillOnce(Return(250)); |
| 485 | send_bucket_->Process(); |
| 486 | } |
| 487 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 488 | TEST_F(PacedSenderTest, VerifyPaddingUpToBitrate) { |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 489 | uint32_t ssrc = 12345; |
| 490 | uint16_t sequence_number = 1234; |
| 491 | int64_t capture_time_ms = 56789; |
| 492 | const int kTimeStep = 5; |
| 493 | const int64_t kBitrateWindow = 100; |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 494 | send_bucket_->SetPacingRates(kTargetBitrateBps * kPaceMultiplier, |
| 495 | kTargetBitrateBps); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 496 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 497 | int64_t start_time = clock_.TimeInMilliseconds(); |
| 498 | while (clock_.TimeInMilliseconds() - start_time < kBitrateWindow) { |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 499 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 500 | capture_time_ms, 250, false); |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 501 | EXPECT_CALL(callback_, TimeToSendPadding(250, _)) |
| 502 | .Times(1) |
| 503 | .WillOnce(Return(250)); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 504 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 505 | clock_.AdvanceTimeMilliseconds(kTimeStep); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 506 | } |
| 507 | } |
| 508 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 509 | TEST_F(PacedSenderTest, VerifyAverageBitrateVaryingMediaPayload) { |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 510 | uint32_t ssrc = 12345; |
| 511 | uint16_t sequence_number = 1234; |
| 512 | int64_t capture_time_ms = 56789; |
| 513 | const int kTimeStep = 5; |
| 514 | const int64_t kBitrateWindow = 10000; |
| 515 | PacedSenderPadding callback; |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 516 | send_bucket_.reset(new PacedSender(&clock_, &callback, nullptr)); |
stefan@webrtc.org | e9f0f59 | 2015-02-16 15:47:51 +0000 | [diff] [blame] | 517 | send_bucket_->SetProbingEnabled(false); |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 518 | send_bucket_->SetPacingRates(kTargetBitrateBps * kPaceMultiplier, |
| 519 | kTargetBitrateBps); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 520 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 521 | int64_t start_time = clock_.TimeInMilliseconds(); |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 522 | size_t media_bytes = 0; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 523 | while (clock_.TimeInMilliseconds() - start_time < kBitrateWindow) { |
jbauch | d2a2296 | 2016-02-08 23:18:25 -0800 | [diff] [blame] | 524 | int rand_value = rand(); // NOLINT (rand_r instead of rand) |
| 525 | size_t media_payload = rand_value % 100 + 200; // [200, 300] bytes. |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 526 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 527 | sequence_number++, capture_time_ms, |
| 528 | media_payload, false); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 529 | media_bytes += media_payload; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 530 | clock_.AdvanceTimeMilliseconds(kTimeStep); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 531 | send_bucket_->Process(); |
| 532 | } |
Danil Chapovalov | 74a369c | 2018-02-14 10:48:49 +0000 | [diff] [blame] | 533 | EXPECT_NEAR(kTargetBitrateBps / 1000, |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 534 | static_cast<int>(8 * (media_bytes + callback.padding_sent()) / |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 535 | kBitrateWindow), |
| 536 | 1); |
stefan@webrtc.org | c3cc375 | 2013-06-04 09:36:56 +0000 | [diff] [blame] | 537 | } |
| 538 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 539 | TEST_F(PacedSenderTest, Priority) { |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 540 | uint32_t ssrc_low_priority = 12345; |
| 541 | uint32_t ssrc = 12346; |
| 542 | uint16_t sequence_number = 1234; |
| 543 | int64_t capture_time_ms = 56789; |
| 544 | int64_t capture_time_ms_low_priority = 1234567; |
| 545 | |
Danil Chapovalov | 74a369c | 2018-02-14 10:48:49 +0000 | [diff] [blame] | 546 | // Due to the multiplicative factor we can send 5 packets during a send |
| 547 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 548 | // (packet size * #send intervals per second) |
| 549 | const size_t packets_to_send_per_interval = |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 550 | kTargetBitrateBps * kPaceMultiplier / (8 * 250 * 200); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 551 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 552 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 553 | clock_.TimeInMilliseconds(), 250, false); |
| 554 | } |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 555 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 556 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 557 | |
| 558 | // Expect normal and low priority to be queued and high to pass through. |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 559 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc_low_priority, |
| 560 | sequence_number++, capture_time_ms_low_priority, |
| 561 | 250, false); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 562 | |
| 563 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 564 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 565 | sequence_number++, capture_time_ms, 250, false); |
| 566 | } |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 567 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc, |
| 568 | sequence_number++, capture_time_ms, 250, false); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 569 | |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 570 | // Expect all high and normal priority to be sent out first. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 571 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 572 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, capture_time_ms, false, _)) |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 573 | .Times(packets_to_send_per_interval + 1) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 574 | .WillRepeatedly(Return(true)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 575 | |
| 576 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 577 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 578 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 579 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 580 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 581 | |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 582 | EXPECT_CALL(callback_, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 583 | TimeToSendPacket(ssrc_low_priority, _, |
| 584 | capture_time_ms_low_priority, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 585 | .Times(1) |
| 586 | .WillRepeatedly(Return(true)); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 587 | |
| 588 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 589 | clock_.AdvanceTimeMilliseconds(5); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 590 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
pbos | a26ac92 | 2016-02-25 04:50:01 -0800 | [diff] [blame] | 591 | send_bucket_->Process(); |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 592 | } |
| 593 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 594 | TEST_F(PacedSenderTest, RetransmissionPriority) { |
terelius | f39f7d9 | 2016-07-20 03:36:19 -0700 | [diff] [blame] | 595 | uint32_t ssrc = 12345; |
| 596 | uint16_t sequence_number = 1234; |
| 597 | int64_t capture_time_ms = 45678; |
| 598 | int64_t capture_time_ms_retransmission = 56789; |
| 599 | |
Danil Chapovalov | 74a369c | 2018-02-14 10:48:49 +0000 | [diff] [blame] | 600 | // Due to the multiplicative factor we can send 5 packets during a send |
| 601 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 602 | // (packet size * #send intervals per second) |
| 603 | const size_t packets_to_send_per_interval = |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 604 | kTargetBitrateBps * kPaceMultiplier / (8 * 250 * 200); |
terelius | f39f7d9 | 2016-07-20 03:36:19 -0700 | [diff] [blame] | 605 | send_bucket_->Process(); |
| 606 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 607 | |
| 608 | // Alternate retransmissions and normal packets. |
| 609 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 610 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 611 | sequence_number++, |
| 612 | capture_time_ms_retransmission, 250, true); |
| 613 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 614 | sequence_number++, capture_time_ms, 250, false); |
| 615 | } |
| 616 | EXPECT_EQ(2 * packets_to_send_per_interval, send_bucket_->QueueSizePackets()); |
| 617 | |
| 618 | // Expect all retransmissions to be sent out first despite having a later |
| 619 | // capture time. |
| 620 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
| 621 | EXPECT_CALL(callback_, TimeToSendPacket(_, _, _, false, _)).Times(0); |
| 622 | EXPECT_CALL(callback_, TimeToSendPacket( |
| 623 | ssrc, _, capture_time_ms_retransmission, true, _)) |
| 624 | .Times(packets_to_send_per_interval) |
| 625 | .WillRepeatedly(Return(true)); |
| 626 | |
| 627 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 628 | clock_.AdvanceTimeMilliseconds(5); |
| 629 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 630 | send_bucket_->Process(); |
| 631 | EXPECT_EQ(packets_to_send_per_interval, send_bucket_->QueueSizePackets()); |
| 632 | |
| 633 | // Expect the remaining (non-retransmission) packets to be sent. |
| 634 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
| 635 | EXPECT_CALL(callback_, TimeToSendPacket(_, _, _, true, _)).Times(0); |
| 636 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, capture_time_ms, false, _)) |
| 637 | .Times(packets_to_send_per_interval) |
| 638 | .WillRepeatedly(Return(true)); |
| 639 | |
| 640 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 641 | clock_.AdvanceTimeMilliseconds(5); |
| 642 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 643 | send_bucket_->Process(); |
| 644 | |
| 645 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
| 646 | } |
| 647 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 648 | TEST_F(PacedSenderTest, HighPrioDoesntAffectBudget) { |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 649 | uint32_t ssrc = 12346; |
| 650 | uint16_t sequence_number = 1234; |
| 651 | int64_t capture_time_ms = 56789; |
| 652 | |
| 653 | // As high prio packets doesn't affect the budget, we should be able to send |
| 654 | // a high number of them at once. |
| 655 | for (int i = 0; i < 25; ++i) { |
| 656 | SendAndExpectPacket(PacedSender::kHighPriority, ssrc, sequence_number++, |
| 657 | capture_time_ms, 250, false); |
| 658 | } |
| 659 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 660 | // Low prio packets does affect the budget. |
Danil Chapovalov | 74a369c | 2018-02-14 10:48:49 +0000 | [diff] [blame] | 661 | // Due to the multiplicative factor we can send 5 packets during a send |
| 662 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 663 | // (packet size * #send intervals per second) |
| 664 | const size_t packets_to_send_per_interval = |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 665 | kTargetBitrateBps * kPaceMultiplier / (8 * 250 * 200); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 666 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 667 | SendAndExpectPacket(PacedSender::kLowPriority, ssrc, sequence_number++, |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 668 | clock_.TimeInMilliseconds(), 250, false); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 669 | } |
| 670 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc, sequence_number, |
| 671 | capture_time_ms, 250, false); |
| 672 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 673 | clock_.AdvanceTimeMilliseconds(5); |
| 674 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 675 | EXPECT_EQ(1u, send_bucket_->QueueSizePackets()); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 676 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number++, |
| 677 | capture_time_ms, false, _)) |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 678 | .Times(1) |
| 679 | .WillRepeatedly(Return(true)); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 680 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 681 | clock_.AdvanceTimeMilliseconds(5); |
| 682 | send_bucket_->Process(); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 683 | EXPECT_EQ(0u, send_bucket_->QueueSizePackets()); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 684 | } |
| 685 | |
Sebastian Jansson | 45d9c1d | 2018-03-09 12:48:01 +0100 | [diff] [blame] | 686 | TEST_F(PacedSenderTest, SendsOnlyPaddingWhenCongested) { |
| 687 | uint32_t ssrc = 202020; |
| 688 | uint16_t sequence_number = 1000; |
| 689 | int kPacketSize = 250; |
| 690 | int kCongestionWindow = kPacketSize * 10; |
| 691 | |
| 692 | send_bucket_->UpdateOutstandingData(0); |
| 693 | send_bucket_->SetCongestionWindow(kCongestionWindow); |
| 694 | int sent_data = 0; |
| 695 | while (sent_data < kCongestionWindow) { |
| 696 | sent_data += kPacketSize; |
| 697 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 698 | clock_.TimeInMilliseconds(), kPacketSize, false); |
| 699 | clock_.AdvanceTimeMilliseconds(5); |
| 700 | send_bucket_->Process(); |
| 701 | } |
| 702 | testing::Mock::VerifyAndClearExpectations(&callback_); |
| 703 | EXPECT_CALL(callback_, TimeToSendPacket(_, _, _, _, _)).Times(0); |
| 704 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
| 705 | |
| 706 | size_t blocked_packets = 0; |
| 707 | int64_t expected_time_until_padding = 500; |
| 708 | while (expected_time_until_padding > 5) { |
| 709 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 710 | sequence_number++, clock_.TimeInMilliseconds(), |
| 711 | kPacketSize, false); |
| 712 | blocked_packets++; |
| 713 | clock_.AdvanceTimeMilliseconds(5); |
| 714 | send_bucket_->Process(); |
| 715 | expected_time_until_padding -= 5; |
| 716 | } |
| 717 | testing::Mock::VerifyAndClearExpectations(&callback_); |
| 718 | EXPECT_CALL(callback_, TimeToSendPadding(1, _)).Times(1); |
| 719 | clock_.AdvanceTimeMilliseconds(5); |
| 720 | send_bucket_->Process(); |
| 721 | EXPECT_EQ(blocked_packets, send_bucket_->QueueSizePackets()); |
| 722 | } |
| 723 | |
Sebastian Jansson | b544f6c | 2018-06-04 19:02:41 +0200 | [diff] [blame] | 724 | TEST_F(PacedSenderTest, DoesNotAllowOveruseAfterCongestion) { |
| 725 | uint32_t ssrc = 202020; |
| 726 | uint16_t seq_num = 1000; |
| 727 | RtpPacketSender::Priority prio = PacedSender::kNormalPriority; |
| 728 | int size = 1000; |
| 729 | auto now_ms = [this] { return clock_.TimeInMilliseconds(); }; |
| 730 | EXPECT_CALL(callback_, TimeToSendPadding).Times(0); |
| 731 | // The pacing rate is low enough that the budget should not allow two packets |
| 732 | // to be sent in a row. |
| 733 | send_bucket_->SetPacingRates(400 * 8 * 1000 / 5, 0); |
| 734 | // The congestion window is small enough to only let one packet through. |
| 735 | send_bucket_->SetCongestionWindow(800); |
| 736 | send_bucket_->UpdateOutstandingData(0); |
| 737 | // Not yet budget limited or congested, packet is sent. |
| 738 | send_bucket_->InsertPacket(prio, ssrc, seq_num++, now_ms(), size, false); |
| 739 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 740 | clock_.AdvanceTimeMilliseconds(5); |
| 741 | send_bucket_->Process(); |
| 742 | // Packet blocked due to congestion. |
| 743 | send_bucket_->InsertPacket(prio, ssrc, seq_num++, now_ms(), size, false); |
| 744 | EXPECT_CALL(callback_, TimeToSendPacket).Times(0); |
| 745 | clock_.AdvanceTimeMilliseconds(5); |
| 746 | send_bucket_->Process(); |
| 747 | // Packet blocked due to congestion. |
| 748 | send_bucket_->InsertPacket(prio, ssrc, seq_num++, now_ms(), size, false); |
| 749 | EXPECT_CALL(callback_, TimeToSendPacket).Times(0); |
| 750 | clock_.AdvanceTimeMilliseconds(5); |
| 751 | send_bucket_->Process(); |
| 752 | send_bucket_->UpdateOutstandingData(0); |
| 753 | // Congestion removed and budget has recovered, packet is sent. |
| 754 | send_bucket_->InsertPacket(prio, ssrc, seq_num++, now_ms(), size, false); |
| 755 | EXPECT_CALL(callback_, TimeToSendPacket).WillOnce(Return(true)); |
| 756 | clock_.AdvanceTimeMilliseconds(5); |
| 757 | send_bucket_->Process(); |
| 758 | send_bucket_->UpdateOutstandingData(0); |
| 759 | // Should be blocked due to budget limitation as congestion has be removed. |
| 760 | send_bucket_->InsertPacket(prio, ssrc, seq_num++, now_ms(), size, false); |
| 761 | EXPECT_CALL(callback_, TimeToSendPacket).Times(0); |
| 762 | clock_.AdvanceTimeMilliseconds(5); |
| 763 | send_bucket_->Process(); |
| 764 | } |
| 765 | |
Sebastian Jansson | 45d9c1d | 2018-03-09 12:48:01 +0100 | [diff] [blame] | 766 | TEST_F(PacedSenderTest, ResumesSendingWhenCongestionEnds) { |
| 767 | uint32_t ssrc = 202020; |
| 768 | uint16_t sequence_number = 1000; |
| 769 | int64_t kPacketSize = 250; |
| 770 | int64_t kCongestionCount = 10; |
| 771 | int64_t kCongestionWindow = kPacketSize * kCongestionCount; |
| 772 | int64_t kCongestionTimeMs = 1000; |
| 773 | |
| 774 | send_bucket_->UpdateOutstandingData(0); |
| 775 | send_bucket_->SetCongestionWindow(kCongestionWindow); |
| 776 | int sent_data = 0; |
| 777 | while (sent_data < kCongestionWindow) { |
| 778 | sent_data += kPacketSize; |
| 779 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 780 | clock_.TimeInMilliseconds(), kPacketSize, false); |
| 781 | clock_.AdvanceTimeMilliseconds(5); |
| 782 | send_bucket_->Process(); |
| 783 | } |
| 784 | testing::Mock::VerifyAndClearExpectations(&callback_); |
| 785 | EXPECT_CALL(callback_, TimeToSendPacket(_, _, _, _, _)).Times(0); |
| 786 | int unacked_packets = 0; |
| 787 | for (int duration = 0; duration < kCongestionTimeMs; duration += 5) { |
| 788 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 789 | sequence_number++, clock_.TimeInMilliseconds(), |
| 790 | kPacketSize, false); |
| 791 | unacked_packets++; |
| 792 | clock_.AdvanceTimeMilliseconds(5); |
| 793 | send_bucket_->Process(); |
| 794 | } |
| 795 | testing::Mock::VerifyAndClearExpectations(&callback_); |
| 796 | |
| 797 | // First mark half of the congested packets as cleared and make sure that just |
| 798 | // as many are sent |
| 799 | int ack_count = kCongestionCount / 2; |
| 800 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, _, false, _)) |
| 801 | .Times(ack_count) |
| 802 | .WillRepeatedly(Return(true)); |
| 803 | send_bucket_->UpdateOutstandingData(kCongestionWindow - |
| 804 | kPacketSize * ack_count); |
| 805 | |
| 806 | for (int duration = 0; duration < kCongestionTimeMs; duration += 5) { |
| 807 | clock_.AdvanceTimeMilliseconds(5); |
| 808 | send_bucket_->Process(); |
| 809 | } |
| 810 | unacked_packets -= ack_count; |
| 811 | testing::Mock::VerifyAndClearExpectations(&callback_); |
| 812 | |
| 813 | // Second make sure all packets are sent if sent packets are continuously |
| 814 | // marked as acked. |
| 815 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, _, false, _)) |
| 816 | .Times(unacked_packets) |
| 817 | .WillRepeatedly(Return(true)); |
| 818 | for (int duration = 0; duration < kCongestionTimeMs; duration += 5) { |
| 819 | send_bucket_->UpdateOutstandingData(0); |
| 820 | clock_.AdvanceTimeMilliseconds(5); |
| 821 | send_bucket_->Process(); |
| 822 | } |
| 823 | } |
| 824 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 825 | TEST_F(PacedSenderTest, Pause) { |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 826 | uint32_t ssrc_low_priority = 12345; |
| 827 | uint32_t ssrc = 12346; |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 828 | uint32_t ssrc_high_priority = 12347; |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 829 | uint16_t sequence_number = 1234; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 830 | int64_t capture_time_ms = clock_.TimeInMilliseconds(); |
stefan@webrtc.org | bfacda6 | 2013-03-27 16:36:01 +0000 | [diff] [blame] | 831 | |
| 832 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 833 | |
Danil Chapovalov | 74a369c | 2018-02-14 10:48:49 +0000 | [diff] [blame] | 834 | // Due to the multiplicative factor we can send 5 packets during a send |
| 835 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 836 | // (packet size * #send intervals per second) |
| 837 | const size_t packets_to_send_per_interval = |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 838 | kTargetBitrateBps * kPaceMultiplier / (8 * 250 * 200); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 839 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 840 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 841 | clock_.TimeInMilliseconds(), 250, false); |
| 842 | } |
| 843 | |
stefan@webrtc.org | 8ccb9f9 | 2013-06-19 14:13:42 +0000 | [diff] [blame] | 844 | send_bucket_->Process(); |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 845 | |
| 846 | send_bucket_->Pause(); |
| 847 | |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 848 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 849 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc_low_priority, |
| 850 | sequence_number++, capture_time_ms, 250, false); |
| 851 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 852 | sequence_number++, capture_time_ms, 250, false); |
| 853 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc_high_priority, |
| 854 | sequence_number++, capture_time_ms, 250, false); |
| 855 | } |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 856 | clock_.AdvanceTimeMilliseconds(10000); |
| 857 | int64_t second_capture_time_ms = clock_.TimeInMilliseconds(); |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 858 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 859 | send_bucket_->InsertPacket(PacedSender::kLowPriority, ssrc_low_priority, |
| 860 | sequence_number++, second_capture_time_ms, 250, |
| 861 | false); |
| 862 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 863 | sequence_number++, second_capture_time_ms, 250, |
| 864 | false); |
| 865 | send_bucket_->InsertPacket(PacedSender::kHighPriority, ssrc_high_priority, |
| 866 | sequence_number++, second_capture_time_ms, 250, |
| 867 | false); |
| 868 | } |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 869 | |
| 870 | // Expect everything to be queued. |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 871 | EXPECT_EQ(second_capture_time_ms - capture_time_ms, |
stefan@webrtc.org | bfacda6 | 2013-03-27 16:36:01 +0000 | [diff] [blame] | 872 | send_bucket_->QueueInMs()); |
| 873 | |
stefan | 9e117c5e1 | 2017-08-16 08:16:25 -0700 | [diff] [blame] | 874 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 875 | EXPECT_CALL(callback_, TimeToSendPadding(1, _)).Times(1); |
| 876 | send_bucket_->Process(); |
| 877 | |
| 878 | int64_t expected_time_until_send = 500; |
Sebastian Jansson | a1630f8 | 2018-02-21 13:39:26 +0100 | [diff] [blame] | 879 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
| 880 | while (expected_time_until_send >= 5) { |
| 881 | send_bucket_->Process(); |
stefan | 9e117c5e1 | 2017-08-16 08:16:25 -0700 | [diff] [blame] | 882 | clock_.AdvanceTimeMilliseconds(5); |
| 883 | expected_time_until_send -= 5; |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 884 | } |
Sebastian Jansson | a1630f8 | 2018-02-21 13:39:26 +0100 | [diff] [blame] | 885 | testing::Mock::VerifyAndClearExpectations(&callback_); |
| 886 | EXPECT_CALL(callback_, TimeToSendPadding(1, _)).Times(1); |
| 887 | clock_.AdvanceTimeMilliseconds(5); |
| 888 | send_bucket_->Process(); |
| 889 | testing::Mock::VerifyAndClearExpectations(&callback_); |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 890 | |
stefan | 099110c | 2017-02-01 03:57:42 -0800 | [diff] [blame] | 891 | // Expect high prio packets to come out first followed by normal |
| 892 | // prio packets and low prio packets (all in capture order). |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 893 | { |
| 894 | ::testing::InSequence sequence; |
stefan | 099110c | 2017-02-01 03:57:42 -0800 | [diff] [blame] | 895 | EXPECT_CALL(callback_, |
| 896 | TimeToSendPacket(ssrc_high_priority, _, capture_time_ms, _, _)) |
| 897 | .Times(packets_to_send_per_interval) |
| 898 | .WillRepeatedly(Return(true)); |
| 899 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc_high_priority, _, |
| 900 | second_capture_time_ms, _, _)) |
| 901 | .Times(packets_to_send_per_interval) |
| 902 | .WillRepeatedly(Return(true)); |
| 903 | |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 904 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 905 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, _, capture_time_ms, _, _)) |
| 906 | .Times(1) |
| 907 | .WillRepeatedly(Return(true)); |
| 908 | } |
| 909 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 910 | EXPECT_CALL(callback_, |
| 911 | TimeToSendPacket(ssrc, _, second_capture_time_ms, _, _)) |
| 912 | .Times(1) |
| 913 | .WillRepeatedly(Return(true)); |
| 914 | } |
| 915 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 916 | EXPECT_CALL(callback_, |
| 917 | TimeToSendPacket(ssrc_low_priority, _, capture_time_ms, _, _)) |
| 918 | .Times(1) |
| 919 | .WillRepeatedly(Return(true)); |
| 920 | } |
| 921 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 922 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc_low_priority, _, |
| 923 | second_capture_time_ms, _, _)) |
| 924 | .Times(1) |
| 925 | .WillRepeatedly(Return(true)); |
| 926 | } |
| 927 | } |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 928 | send_bucket_->Resume(); |
| 929 | |
Sebastian Jansson | a1630f8 | 2018-02-21 13:39:26 +0100 | [diff] [blame] | 930 | // The pacer was resumed directly after the previous process call finished. It |
| 931 | // will therefore wait 5 ms until next process. |
| 932 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 933 | clock_.AdvanceTimeMilliseconds(5); |
| 934 | |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 935 | for (size_t i = 0; i < 4; i++) { |
stefan | 64136af | 2017-08-14 08:03:17 -0700 | [diff] [blame] | 936 | EXPECT_EQ(0, send_bucket_->TimeUntilNextProcess()); |
| 937 | send_bucket_->Process(); |
stefan | 9e117c5e1 | 2017-08-16 08:16:25 -0700 | [diff] [blame] | 938 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 939 | clock_.AdvanceTimeMilliseconds(5); |
terelius | 8b70faf | 2016-08-01 09:47:31 -0700 | [diff] [blame] | 940 | } |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 941 | |
stefan@webrtc.org | bfacda6 | 2013-03-27 16:36:01 +0000 | [diff] [blame] | 942 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 943 | } |
| 944 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 945 | TEST_F(PacedSenderTest, ResendPacket) { |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 946 | uint32_t ssrc = 12346; |
| 947 | uint16_t sequence_number = 1234; |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 948 | int64_t capture_time_ms = clock_.TimeInMilliseconds(); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 949 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 950 | |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 951 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 952 | sequence_number, capture_time_ms, 250, false); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 953 | clock_.AdvanceTimeMilliseconds(1); |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 954 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 955 | sequence_number + 1, capture_time_ms + 1, 250, |
| 956 | false); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 957 | clock_.AdvanceTimeMilliseconds(9999); |
| 958 | EXPECT_EQ(clock_.TimeInMilliseconds() - capture_time_ms, |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 959 | send_bucket_->QueueInMs()); |
| 960 | // Fails to send first packet so only one call. |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 961 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
| 962 | capture_time_ms, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 963 | .Times(1) |
| 964 | .WillOnce(Return(false)); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 965 | clock_.AdvanceTimeMilliseconds(10000); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 966 | send_bucket_->Process(); |
| 967 | |
| 968 | // Queue remains unchanged. |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 969 | EXPECT_EQ(clock_.TimeInMilliseconds() - capture_time_ms, |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 970 | send_bucket_->QueueInMs()); |
| 971 | |
| 972 | // Fails to send second packet. |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 973 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
| 974 | capture_time_ms, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 975 | .Times(1) |
| 976 | .WillOnce(Return(true)); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 977 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number + 1, |
| 978 | capture_time_ms + 1, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 979 | .Times(1) |
| 980 | .WillOnce(Return(false)); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 981 | clock_.AdvanceTimeMilliseconds(10000); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 982 | send_bucket_->Process(); |
| 983 | |
| 984 | // Queue is reduced by 1 packet. |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 985 | EXPECT_EQ(clock_.TimeInMilliseconds() - capture_time_ms - 1, |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 986 | send_bucket_->QueueInMs()); |
| 987 | |
| 988 | // Send second packet and queue becomes empty. |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 989 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number + 1, |
| 990 | capture_time_ms + 1, false, _)) |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 991 | .Times(1) |
| 992 | .WillOnce(Return(true)); |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 993 | clock_.AdvanceTimeMilliseconds(10000); |
hclam@chromium.org | 2e402ce | 2013-06-20 20:18:31 +0000 | [diff] [blame] | 994 | send_bucket_->Process(); |
| 995 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 996 | } |
| 997 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 998 | TEST_F(PacedSenderTest, ExpectedQueueTimeMs) { |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 999 | uint32_t ssrc = 12346; |
| 1000 | uint16_t sequence_number = 1234; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 1001 | const size_t kNumPackets = 60; |
| 1002 | const size_t kPacketSize = 1200; |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 1003 | const int32_t kMaxBitrate = kPaceMultiplier * 30000; |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1004 | EXPECT_EQ(0, send_bucket_->ExpectedQueueTimeMs()); |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 1005 | |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 1006 | send_bucket_->SetPacingRates(30000 * kPaceMultiplier, 0); |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 1007 | for (size_t i = 0; i < kNumPackets; ++i) { |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1008 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 1009 | clock_.TimeInMilliseconds(), kPacketSize, false); |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 1010 | } |
| 1011 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 1012 | // Queue in ms = 1000 * (bytes in queue) *8 / (bits per second) |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 1013 | int64_t queue_in_ms = |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 1014 | static_cast<int64_t>(1000 * kNumPackets * kPacketSize * 8 / kMaxBitrate); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1015 | EXPECT_EQ(queue_in_ms, send_bucket_->ExpectedQueueTimeMs()); |
stefan@webrtc.org | 168f23f | 2014-07-11 13:44:02 +0000 | [diff] [blame] | 1016 | |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1017 | int64_t time_start = clock_.TimeInMilliseconds(); |
| 1018 | while (send_bucket_->QueueSizePackets() > 0) { |
| 1019 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
| 1020 | if (time_until_process <= 0) { |
| 1021 | send_bucket_->Process(); |
| 1022 | } else { |
| 1023 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 1024 | } |
| 1025 | } |
| 1026 | int64_t duration = clock_.TimeInMilliseconds() - time_start; |
| 1027 | |
| 1028 | EXPECT_EQ(0, send_bucket_->ExpectedQueueTimeMs()); |
| 1029 | |
sprang | 0a43fef | 2015-11-20 09:00:37 -0800 | [diff] [blame] | 1030 | // Allow for aliasing, duration should be within one pack of max time limit. |
| 1031 | EXPECT_NEAR(duration, PacedSender::kMaxQueueLengthMs, |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 1032 | static_cast<int64_t>(1000 * kPacketSize * 8 / kMaxBitrate)); |
stefan@webrtc.org | 19a40ff | 2013-11-27 14:16:20 +0000 | [diff] [blame] | 1033 | } |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 1034 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 1035 | TEST_F(PacedSenderTest, QueueTimeGrowsOverTime) { |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 1036 | uint32_t ssrc = 12346; |
| 1037 | uint16_t sequence_number = 1234; |
| 1038 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 1039 | |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 1040 | send_bucket_->SetPacingRates(30000 * kPaceMultiplier, 0); |
Yves Gerey | 665174f | 2018-06-19 15:03:05 +0200 | [diff] [blame] | 1041 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number, |
| 1042 | clock_.TimeInMilliseconds(), 1200, false); |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 1043 | |
stefan@webrtc.org | 88e0dda | 2014-07-04 09:20:42 +0000 | [diff] [blame] | 1044 | clock_.AdvanceTimeMilliseconds(500); |
stefan@webrtc.org | dd393e7 | 2013-12-13 22:03:27 +0000 | [diff] [blame] | 1045 | EXPECT_EQ(500, send_bucket_->QueueInMs()); |
| 1046 | send_bucket_->Process(); |
| 1047 | EXPECT_EQ(0, send_bucket_->QueueInMs()); |
| 1048 | } |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 1049 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 1050 | TEST_F(PacedSenderTest, ProbingWithInsertedPackets) { |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 1051 | const size_t kPacketSize = 1200; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 1052 | const int kInitialBitrateBps = 300000; |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 1053 | uint32_t ssrc = 12346; |
| 1054 | uint16_t sequence_number = 1234; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 1055 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 1056 | PacedSenderProbing packet_sender; |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 1057 | send_bucket_.reset(new PacedSender(&clock_, &packet_sender, nullptr)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1058 | send_bucket_->CreateProbeCluster(kFirstClusterBps); |
| 1059 | send_bucket_->CreateProbeCluster(kSecondClusterBps); |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 1060 | send_bucket_->SetPacingRates(kInitialBitrateBps * kPaceMultiplier, 0); |
stefan@webrtc.org | e9f0f59 | 2015-02-16 15:47:51 +0000 | [diff] [blame] | 1061 | |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1062 | for (int i = 0; i < 10; ++i) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 1063 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 1064 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1065 | kPacketSize, false); |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 1066 | } |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 1067 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 1068 | int64_t start = clock_.TimeInMilliseconds(); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1069 | while (packet_sender.packets_sent() < 5) { |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 1070 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 1071 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 1072 | send_bucket_->Process(); |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 1073 | } |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 1074 | int packets_sent = packet_sender.packets_sent(); |
| 1075 | // Validate first cluster bitrate. Note that we have to account for number |
| 1076 | // of intervals and hence (packets_sent - 1) on the first cluster. |
| 1077 | EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 / |
| 1078 | (clock_.TimeInMilliseconds() - start), |
| 1079 | kFirstClusterBps, kBitrateProbingError); |
| 1080 | EXPECT_EQ(0, packet_sender.padding_sent()); |
| 1081 | |
sergeyu | 6dbbd89 | 2017-01-17 15:07:59 -0800 | [diff] [blame] | 1082 | clock_.AdvanceTimeMilliseconds(send_bucket_->TimeUntilNextProcess()); |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 1083 | start = clock_.TimeInMilliseconds(); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1084 | while (packet_sender.packets_sent() < 10) { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 1085 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
| 1086 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 1087 | send_bucket_->Process(); |
| 1088 | } |
| 1089 | packets_sent = packet_sender.packets_sent() - packets_sent; |
| 1090 | // Validate second cluster bitrate. |
sergeyu | 6dbbd89 | 2017-01-17 15:07:59 -0800 | [diff] [blame] | 1091 | EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 / |
| 1092 | (clock_.TimeInMilliseconds() - start), |
| 1093 | kSecondClusterBps, kBitrateProbingError); |
stefan@webrtc.org | 82462aa | 2014-10-23 11:57:05 +0000 | [diff] [blame] | 1094 | } |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1095 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 1096 | TEST_F(PacedSenderTest, ProbingWithPaddingSupport) { |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 1097 | const size_t kPacketSize = 1200; |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 1098 | const int kInitialBitrateBps = 300000; |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 1099 | uint32_t ssrc = 12346; |
| 1100 | uint16_t sequence_number = 1234; |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 1101 | |
| 1102 | PacedSenderProbing packet_sender; |
philipel | c3b3f7a | 2017-03-29 01:23:13 -0700 | [diff] [blame] | 1103 | send_bucket_.reset(new PacedSender(&clock_, &packet_sender, nullptr)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1104 | send_bucket_->CreateProbeCluster(kFirstClusterBps); |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 1105 | send_bucket_->SetPacingRates(kInitialBitrateBps * kPaceMultiplier, 0); |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 1106 | |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1107 | for (int i = 0; i < 3; ++i) { |
Peter Boström | e23e737 | 2015-10-08 11:44:14 +0200 | [diff] [blame] | 1108 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 1109 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1110 | kPacketSize, false); |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 1111 | } |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 1112 | |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 1113 | int64_t start = clock_.TimeInMilliseconds(); |
| 1114 | int process_count = 0; |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1115 | while (process_count < 5) { |
isheriff | cc5903e | 2016-10-04 08:29:38 -0700 | [diff] [blame] | 1116 | int time_until_process = send_bucket_->TimeUntilNextProcess(); |
| 1117 | clock_.AdvanceTimeMilliseconds(time_until_process); |
| 1118 | send_bucket_->Process(); |
| 1119 | ++process_count; |
| 1120 | } |
| 1121 | int packets_sent = packet_sender.packets_sent(); |
| 1122 | int padding_sent = packet_sender.padding_sent(); |
| 1123 | EXPECT_GT(packets_sent, 0); |
| 1124 | EXPECT_GT(padding_sent, 0); |
| 1125 | // Note that the number of intervals here for kPacketSize is |
| 1126 | // packets_sent due to padding in the same cluster. |
| 1127 | EXPECT_NEAR((packets_sent * kPacketSize * 8000 + padding_sent) / |
| 1128 | (clock_.TimeInMilliseconds() - start), |
| 1129 | kFirstClusterBps, kBitrateProbingError); |
Stefan Holmer | 01b4888 | 2015-05-05 10:21:24 +0200 | [diff] [blame] | 1130 | } |
| 1131 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 1132 | TEST_F(PacedSenderTest, PaddingOveruse) { |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1133 | uint32_t ssrc = 12346; |
| 1134 | uint16_t sequence_number = 1234; |
pkasting@chromium.org | 4591fbd | 2014-11-20 22:28:14 +0000 | [diff] [blame] | 1135 | const size_t kPacketSize = 1200; |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1136 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 1137 | send_bucket_->Process(); |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 1138 | send_bucket_->SetPacingRates(60000 * kPaceMultiplier, 0); |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 1139 | |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1140 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 1141 | clock_.TimeInMilliseconds(), kPacketSize, false); |
| 1142 | send_bucket_->Process(); |
| 1143 | |
| 1144 | // Add 30kbit padding. When increasing budget, media budget will increase from |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 1145 | // negative (overuse) while padding budget will increase from 0. |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1146 | clock_.AdvanceTimeMilliseconds(5); |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 1147 | send_bucket_->SetPacingRates(60000 * kPaceMultiplier, 30000); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1148 | |
perkj | ec81bcd | 2016-05-11 06:01:13 -0700 | [diff] [blame] | 1149 | SendAndExpectPacket(PacedSender::kNormalPriority, ssrc, sequence_number++, |
| 1150 | clock_.TimeInMilliseconds(), kPacketSize, false); |
| 1151 | EXPECT_LT(5u, send_bucket_->ExpectedQueueTimeMs()); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1152 | // Don't send padding if queue is non-empty, even if padding budget > 0. |
philipel | a1ed0b3 | 2016-06-01 06:31:17 -0700 | [diff] [blame] | 1153 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)).Times(0); |
sprang@webrtc.org | dcebf2d | 2014-11-04 16:27:16 +0000 | [diff] [blame] | 1154 | send_bucket_->Process(); |
| 1155 | } |
| 1156 | |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame] | 1157 | // TODO(philipel): Move to PacketQueue2 unittests. |
| 1158 | #if 0 |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 1159 | TEST_F(PacedSenderTest, AverageQueueTime) { |
| 1160 | uint32_t ssrc = 12346; |
| 1161 | uint16_t sequence_number = 1234; |
| 1162 | const size_t kPacketSize = 1200; |
| 1163 | const int kBitrateBps = 10 * kPacketSize * 8; // 10 packets per second. |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 1164 | |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 1165 | send_bucket_->SetPacingRates(kBitrateBps * kPaceMultiplier, 0); |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 1166 | |
| 1167 | EXPECT_EQ(0, send_bucket_->AverageQueueTimeMs()); |
| 1168 | |
| 1169 | int64_t first_capture_time = clock_.TimeInMilliseconds(); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 1170 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 1171 | sequence_number, first_capture_time, kPacketSize, |
| 1172 | false); |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 1173 | clock_.AdvanceTimeMilliseconds(10); |
Stefan Holmer | c482eb3 | 2015-12-16 16:55:03 +0100 | [diff] [blame] | 1174 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 1175 | sequence_number + 1, clock_.TimeInMilliseconds(), |
| 1176 | kPacketSize, false); |
| 1177 | clock_.AdvanceTimeMilliseconds(10); |
| 1178 | |
| 1179 | EXPECT_EQ((20 + 10) / 2, send_bucket_->AverageQueueTimeMs()); |
| 1180 | |
| 1181 | // Only first packet (queued for 20ms) should be removed, leave the second |
| 1182 | // packet (queued for 10ms) alone in the queue. |
| 1183 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1184 | first_capture_time, false, _)) |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 1185 | .Times(1) |
| 1186 | .WillRepeatedly(Return(true)); |
| 1187 | send_bucket_->Process(); |
| 1188 | |
| 1189 | EXPECT_EQ(10, send_bucket_->AverageQueueTimeMs()); |
| 1190 | |
| 1191 | clock_.AdvanceTimeMilliseconds(10); |
| 1192 | EXPECT_CALL(callback_, TimeToSendPacket(ssrc, sequence_number + 1, |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1193 | first_capture_time + 10, false, _)) |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 1194 | .Times(1) |
| 1195 | .WillRepeatedly(Return(true)); |
| 1196 | for (int i = 0; i < 3; ++i) { |
| 1197 | clock_.AdvanceTimeMilliseconds(30); // Max delta. |
| 1198 | send_bucket_->Process(); |
| 1199 | } |
| 1200 | |
| 1201 | EXPECT_EQ(0, send_bucket_->AverageQueueTimeMs()); |
| 1202 | } |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame] | 1203 | #endif |
Erik Språng | ad113e5 | 2015-11-26 16:26:12 +0100 | [diff] [blame] | 1204 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 1205 | TEST_F(PacedSenderTest, ProbeClusterId) { |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1206 | uint32_t ssrc = 12346; |
| 1207 | uint16_t sequence_number = 1234; |
| 1208 | const size_t kPacketSize = 1200; |
| 1209 | |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 1210 | send_bucket_->SetPacingRates(kTargetBitrateBps * kPaceMultiplier, |
| 1211 | kTargetBitrateBps); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1212 | send_bucket_->SetProbingEnabled(true); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1213 | for (int i = 0; i < 10; ++i) { |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1214 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 1215 | sequence_number + i, clock_.TimeInMilliseconds(), |
| 1216 | kPacketSize, false); |
| 1217 | } |
| 1218 | |
| 1219 | // First probing cluster. |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1220 | EXPECT_CALL(callback_, |
| 1221 | TimeToSendPacket(_, _, _, _, |
| 1222 | Field(&PacedPacketInfo::probe_cluster_id, 0))) |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1223 | .Times(5) |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1224 | .WillRepeatedly(Return(true)); |
philipel | fd58b61 | 2017-01-04 07:05:25 -0800 | [diff] [blame] | 1225 | for (int i = 0; i < 5; ++i) { |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1226 | clock_.AdvanceTimeMilliseconds(20); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1227 | send_bucket_->Process(); |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1228 | } |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1229 | |
| 1230 | // Second probing cluster. |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1231 | EXPECT_CALL(callback_, |
| 1232 | TimeToSendPacket(_, _, _, _, |
| 1233 | Field(&PacedPacketInfo::probe_cluster_id, 1))) |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1234 | .Times(5) |
| 1235 | .WillRepeatedly(Return(true)); |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1236 | for (int i = 0; i < 5; ++i) { |
| 1237 | clock_.AdvanceTimeMilliseconds(20); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1238 | send_bucket_->Process(); |
philipel | 1a93cde | 2016-06-03 01:41:45 -0700 | [diff] [blame] | 1239 | } |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1240 | |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1241 | // Needed for the Field comparer below. |
| 1242 | const int kNotAProbe = PacedPacketInfo::kNotAProbe; |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1243 | // No more probing packets. |
philipel | c7bf32a | 2017-02-17 03:59:43 -0800 | [diff] [blame] | 1244 | EXPECT_CALL(callback_, |
| 1245 | TimeToSendPadding( |
| 1246 | _, Field(&PacedPacketInfo::probe_cluster_id, kNotAProbe))) |
| 1247 | .Times(1) |
| 1248 | .WillRepeatedly(Return(500)); |
philipel | 29dca2c | 2016-05-13 11:13:05 +0200 | [diff] [blame] | 1249 | send_bucket_->Process(); |
| 1250 | } |
| 1251 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 1252 | TEST_F(PacedSenderTest, AvoidBusyLoopOnSendFailure) { |
philipel | b61927c | 2017-02-28 07:05:23 -0800 | [diff] [blame] | 1253 | uint32_t ssrc = 12346; |
| 1254 | uint16_t sequence_number = 1234; |
| 1255 | const size_t kPacketSize = kFirstClusterBps / (8000 / 10); |
| 1256 | |
Sebastian Jansson | 439f0bc | 2018-02-20 10:46:39 +0100 | [diff] [blame] | 1257 | send_bucket_->SetPacingRates(kTargetBitrateBps * kPaceMultiplier, |
| 1258 | kTargetBitrateBps); |
philipel | b61927c | 2017-02-28 07:05:23 -0800 | [diff] [blame] | 1259 | send_bucket_->SetProbingEnabled(true); |
| 1260 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, ssrc, |
| 1261 | sequence_number, clock_.TimeInMilliseconds(), |
| 1262 | kPacketSize, false); |
| 1263 | |
| 1264 | EXPECT_CALL(callback_, TimeToSendPacket(_, _, _, _, _)) |
| 1265 | .WillOnce(Return(true)); |
| 1266 | send_bucket_->Process(); |
| 1267 | EXPECT_EQ(10, send_bucket_->TimeUntilNextProcess()); |
| 1268 | clock_.AdvanceTimeMilliseconds(9); |
| 1269 | |
| 1270 | EXPECT_CALL(callback_, TimeToSendPadding(_, _)) |
| 1271 | .Times(2) |
| 1272 | .WillRepeatedly(Return(0)); |
| 1273 | send_bucket_->Process(); |
| 1274 | EXPECT_EQ(1, send_bucket_->TimeUntilNextProcess()); |
| 1275 | clock_.AdvanceTimeMilliseconds(1); |
| 1276 | send_bucket_->Process(); |
| 1277 | EXPECT_EQ(5, send_bucket_->TimeUntilNextProcess()); |
| 1278 | } |
| 1279 | |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame] | 1280 | // TODO(philipel): Move to PacketQueue2 unittests. |
| 1281 | #if 0 |
sprang | ddcfb9f | 2017-08-16 05:38:49 -0700 | [diff] [blame] | 1282 | TEST_F(PacedSenderTest, QueueTimeWithPause) { |
| 1283 | const size_t kPacketSize = 1200; |
| 1284 | const uint32_t kSsrc = 12346; |
| 1285 | uint16_t sequence_number = 1234; |
| 1286 | |
| 1287 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1288 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1289 | kPacketSize, false); |
| 1290 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1291 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1292 | kPacketSize, false); |
| 1293 | |
| 1294 | clock_.AdvanceTimeMilliseconds(100); |
| 1295 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1296 | |
| 1297 | send_bucket_->Pause(); |
| 1298 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1299 | |
| 1300 | // In paused state, queue time should not increase. |
| 1301 | clock_.AdvanceTimeMilliseconds(100); |
| 1302 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1303 | |
| 1304 | send_bucket_->Resume(); |
| 1305 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1306 | |
| 1307 | clock_.AdvanceTimeMilliseconds(100); |
| 1308 | EXPECT_EQ(200, send_bucket_->AverageQueueTimeMs()); |
| 1309 | } |
| 1310 | |
Ilya Nikolaevskiy | 9406569 | 2018-03-02 12:32:05 +0100 | [diff] [blame] | 1311 | TEST_F(PacedSenderTest, QueueTimePausedDuringPush) { |
sprang | ddcfb9f | 2017-08-16 05:38:49 -0700 | [diff] [blame] | 1312 | const size_t kPacketSize = 1200; |
| 1313 | const uint32_t kSsrc = 12346; |
| 1314 | uint16_t sequence_number = 1234; |
| 1315 | |
| 1316 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1317 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1318 | kPacketSize, false); |
| 1319 | clock_.AdvanceTimeMilliseconds(100); |
| 1320 | send_bucket_->Pause(); |
| 1321 | clock_.AdvanceTimeMilliseconds(100); |
| 1322 | EXPECT_EQ(100, send_bucket_->AverageQueueTimeMs()); |
| 1323 | |
| 1324 | // Add a new packet during paused phase. |
| 1325 | send_bucket_->InsertPacket(PacedSender::kNormalPriority, kSsrc, |
| 1326 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1327 | kPacketSize, false); |
| 1328 | // From a queue time perspective, packet inserted during pause will have zero |
| 1329 | // queue time. Average queue time will then be (0 + 100) / 2 = 50. |
| 1330 | EXPECT_EQ(50, send_bucket_->AverageQueueTimeMs()); |
| 1331 | |
| 1332 | clock_.AdvanceTimeMilliseconds(100); |
| 1333 | EXPECT_EQ(50, send_bucket_->AverageQueueTimeMs()); |
| 1334 | |
| 1335 | send_bucket_->Resume(); |
| 1336 | EXPECT_EQ(50, send_bucket_->AverageQueueTimeMs()); |
| 1337 | |
| 1338 | clock_.AdvanceTimeMilliseconds(100); |
| 1339 | EXPECT_EQ(150, send_bucket_->AverageQueueTimeMs()); |
| 1340 | } |
Niels Möller | d6314d9 | 2017-10-23 09:08:22 +0200 | [diff] [blame] | 1341 | #endif |
sprang | ddcfb9f | 2017-08-16 05:38:49 -0700 | [diff] [blame] | 1342 | |
| 1343 | // TODO(sprang): Extract PacketQueue from PacedSender so that we can test |
| 1344 | // removing elements while paused. (This is possible, but only because of semi- |
| 1345 | // racy condition so can't easily be tested). |
| 1346 | |
pwestin@webrtc.org | db41856 | 2013-03-22 23:39:29 +0000 | [diff] [blame] | 1347 | } // namespace test |
pwestin@webrtc.org | b518017 | 2012-11-09 20:56:23 +0000 | [diff] [blame] | 1348 | } // namespace webrtc |