blob: 68c25be4145682c9e6bbb61163f1d172b2051255 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "media/engine/webrtc_video_engine.h"
12
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000013#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080014#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020015#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070016#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000017#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000018
Steve Anton2c9ebef2019-01-28 17:27:58 -080019#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010020#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020021#include "absl/strings/match.h"
Anton Sukhanov4f08faa2019-05-21 11:12:57 -070022#include "api/media_transport_config.h"
Steve Anton10542f22019-01-11 09:11:00 -080023#include "api/rtp_parameters.h"
Danil Chapovalov53d45ba2019-07-03 14:56:33 +020024#include "api/task_queue/default_task_queue_factory.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070025#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080026#include "api/test/mock_video_bitrate_allocator.h"
27#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070028#include "api/test/mock_video_decoder_factory.h"
29#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020030#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080031#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010032#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020033#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020034#include "api/video_codecs/builtin_video_decoder_factory.h"
35#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020036#include "api/video_codecs/sdp_video_format.h"
37#include "api/video_codecs/video_decoder_factory.h"
38#include "api/video_codecs/video_encoder.h"
39#include "api/video_codecs/video_encoder_factory.h"
40#include "call/flexfec_receive_stream.h"
41#include "common_video/h264/profile_level_id.h"
42#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010043#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/base/fake_video_renderer.h"
46#include "media/base/media_constants.h"
47#include "media/base/rtp_utils.h"
48#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/fake_webrtc_call.h"
51#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020054#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080056#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020057#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020058#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080059#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020060#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010061#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020062#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000063
Mirko Bonadei6a489f22019-04-09 15:11:12 +020064using ::testing::Field;
Chen Xing90f3b892019-06-25 10:16:14 +020065using ::testing::IsEmpty;
66using ::testing::SizeIs;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010067using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070068using webrtc::RtpExtension;
69
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000070namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000071static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000072
noahricd10a68e2015-07-10 11:27:55 -070073static const uint8_t kRedRtxPayloadType = 125;
74
Niels Möller6557d0c2018-04-11 15:18:34 +020075static const uint32_t kTimeout = 5000U;
76static const uint32_t kDefaultReceiveSsrc = 0;
77static const uint32_t kSsrc = 1234u;
78static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
79static const int kVideoWidth = 640;
80static const int kVideoHeight = 360;
81static const int kFramerate = 30;
82
Peter Boström0c4e06b2015-10-07 12:23:21 +020083static const uint32_t kSsrcs1[] = {1};
84static const uint32_t kSsrcs3[] = {1, 2, 3};
85static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080086static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020087static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080088static const uint32_t kDefaultRecvSsrc = 0;
89
Bjorn A Mellem74a1b4b2019-07-23 06:18:24 -070090constexpr uint32_t kRtpHeaderSize = 12;
91
pbos@webrtc.org3c107582014-07-20 15:27:35 +000092static const char kUnsupportedExtensionName[] =
93 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000094
magjed509e4fe2016-11-18 01:34:11 -080095cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
96 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020097 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080098}
99
Elad Alonfadb1812019-05-24 13:40:02 +0200100void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
101 bool lntf_expected) {
102 EXPECT_EQ(lntf_expected,
103 codec.HasFeedbackParam(cricket::FeedbackParam(
104 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000105 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
106 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
107 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
108 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
109 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
110 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
111 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800112 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
113 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000114 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
115}
116
magjed725e4842016-11-16 00:48:13 -0800117// Return true if any codec in |codecs| is an RTX codec with associated payload
118// type |payload_type|.
119bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
120 int payload_type) {
121 for (const cricket::VideoCodec& codec : codecs) {
122 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200123 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800124 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
125 &associated_payload_type) &&
126 associated_payload_type == payload_type) {
127 return true;
128 }
129 }
130 return false;
131}
132
nisseca5706d2017-09-11 02:32:16 -0700133// TODO(nisse): Duplicated in call.cc.
134const int* FindKeyByValue(const std::map<int, int>& m, int v) {
135 for (const auto& kv : m) {
136 if (kv.second == v)
137 return &kv.first;
138 }
139 return nullptr;
140}
141
Yves Gerey665174f2018-06-19 15:03:05 +0200142bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
143 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700144 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
145 payload_type) != nullptr;
146}
147
148// Check that there's an Rtx payload type for each decoder.
149bool VerifyRtxReceiveAssociations(
150 const webrtc::VideoReceiveStream::Config& config) {
151 for (const auto& decoder : config.decoders) {
152 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
153 return false;
154 }
155 return true;
156}
157
brandtrffc61182016-11-28 06:02:22 -0800158rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700159 int width,
160 int height) {
161 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
162 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800163 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700164 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000165}
166
Shao Changbine62202f2015-04-21 20:24:50 +0800167void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
168 const std::map<int, int>& rtx_types) {
169 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200170 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800171 EXPECT_TRUE(it != rtx_types.end() &&
172 it->second == config.rtp.rtx.payload_type);
173
brandtrb5f2c3f2016-10-04 23:28:39 -0700174 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
175 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800176 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700177 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800178 }
179}
kthelgason2bc68642017-02-07 07:02:22 -0800180
181cricket::MediaConfig GetMediaConfig() {
182 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100183 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800184 return media_config;
185}
nisse26e3abb2017-08-25 04:44:25 -0700186
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200187// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
188int GetMaxDefaultBitrateBps(size_t width, size_t height) {
189 if (width * height <= 320 * 240) {
190 return 600000;
191 } else if (width * height <= 640 * 480) {
192 return 1700000;
193 } else if (width * height <= 960 * 540) {
194 return 2000000;
195 } else {
196 return 2500000;
197 }
198}
199
Niels Möller731a2c22018-07-30 15:08:07 +0200200class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
201 public:
202 MOCK_METHOD2(AddOrUpdateSink,
203 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
204 const rtc::VideoSinkWants& wants));
205 MOCK_METHOD1(RemoveSink,
206 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
207};
208
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000209} // namespace
210
Yves Gerey665174f2018-06-19 15:03:05 +0200211#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200212 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200213 EXPECT_EQ((w), renderer_.width()); \
214 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200215 EXPECT_EQ(0, renderer_.errors());
216
Yves Gerey665174f2018-06-19 15:03:05 +0200217#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200218 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200219 EXPECT_EQ((w), (r).width()); \
220 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200221 EXPECT_EQ(0, (r).errors());
222
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000223namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700224class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000225 public:
eladalonf1841382017-06-12 01:16:46 -0700226 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200227 explicit WebRtcVideoEngineTest(const std::string& field_trials)
228 : override_field_trials_(
229 field_trials.empty()
230 ? nullptr
231 : absl::make_unique<webrtc::test::ScopedFieldTrials>(
232 field_trials)),
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200233 task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
234 call_(webrtc::Call::Create([&] {
235 webrtc::Call::Config call_config(&event_log_);
236 call_config.task_queue_factory = task_queue_factory_.get();
237 return call_config;
238 }())),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200239 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
240 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200241 video_bitrate_allocator_factory_(
242 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200243 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200244 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200245 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200246 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200247 // Ensure fake clock doesn't return 0, which will cause some initializations
248 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200249 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200250 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000251
252 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200253 void AssignDefaultAptRtxTypes();
254 void AssignDefaultCodec();
255
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100256 // Find the index of the codec in the engine with the given name. The codec
257 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100258 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100259
magjed509e4fe2016-11-18 01:34:11 -0800260 // Find the codec in the engine with the given name. The codec must be
261 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100262 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800263
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200264 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000265
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200266 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000267 const std::vector<VideoCodec>& codecs);
268
Elad Alon157540a2019-02-08 23:37:52 +0100269 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100270
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200271 // Has to be the first one, so it is initialized before the call or there is a
272 // race condition in the clock access.
273 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200274 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700275 webrtc::RtcEventLogNullImpl event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200276 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
eladalonf1841382017-06-12 01:16:46 -0700277 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000278 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800279 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200280 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
281 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200282 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
283 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700284 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000285 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800286 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000287};
288
eladalonf1841382017-06-12 01:16:46 -0700289TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200290 encoder_factory_->AddSupportedVideoCodecType("VP8");
291 AssignDefaultCodec();
292
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000293 std::vector<VideoCodec> engine_codecs = engine_.codecs();
294 for (size_t i = 0; i < engine_codecs.size(); ++i) {
295 if (engine_codecs[i].name != kRtxCodecName)
296 continue;
297 int associated_payload_type;
298 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000299 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000300 EXPECT_EQ(default_codec_.id, associated_payload_type);
301 return;
302 }
303 FAIL() << "No RTX codec found among default codecs.";
304}
305
eladalonf1841382017-06-12 01:16:46 -0700306TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100307 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000308}
309
eladalonf1841382017-06-12 01:16:46 -0700310TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100311 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000312}
313
eladalonf1841382017-06-12 01:16:46 -0700314TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100315 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700316}
317
eladalonf1841382017-06-12 01:16:46 -0700318TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100319 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
320}
321
322TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
323 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
324}
325
326TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
327 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
328}
329
330TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
331 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
332}
333
334TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
335 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100336}
337
338TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100339 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
340}
341
Elad Alonccb9b752019-02-19 13:01:31 +0100342TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
343 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
344}
345
346TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
347 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700348}
349
philipel1e054862018-10-08 16:13:53 +0200350class WebRtcVideoEngineTestWithGenericDescriptor
351 : public WebRtcVideoEngineTest {
352 public:
353 WebRtcVideoEngineTestWithGenericDescriptor()
354 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
355};
356
Elad Alonccb9b752019-02-19 13:01:31 +0100357TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
358 AdvertiseGenericDescriptor00) {
359 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
360}
361
362TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
363 AdvertiseGenericDescriptor01) {
364 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200365}
366
eladalonf1841382017-06-12 01:16:46 -0700367TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200368 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700369 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200370 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700371
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200372 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200374 std::unique_ptr<VideoMediaChannel> channel(
375 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700376 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
377
378 // Add CVO extension.
379 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800380 cricket::VideoSendParameters parameters;
381 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200382 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700383 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200384 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700385
Niels Möller731a2c22018-07-30 15:08:07 +0200386 EXPECT_CALL(
387 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200388 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200389 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700390 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200391 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700392
393 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200394 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700395
396 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200397 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200398 EXPECT_CALL(
399 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200400 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200401 Field(&rtc::VideoSinkWants::rotation_applied, true)));
402
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200403 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700404}
405
eladalonf1841382017-06-12 01:16:46 -0700406TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200407 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800408 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200409 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800410
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200411 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800412
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200413 std::unique_ptr<VideoMediaChannel> channel(
414 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800415 // Add CVO extension.
416 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800417 cricket::VideoSendParameters parameters;
418 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800419 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700420 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800421 EXPECT_TRUE(channel->SetSendParameters(parameters));
422 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
423
Niels Möller731a2c22018-07-30 15:08:07 +0200424 // Set source.
425 EXPECT_CALL(
426 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200427 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200428 Field(&rtc::VideoSinkWants::rotation_applied, false)));
429 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800430}
431
eladalonf1841382017-06-12 01:16:46 -0700432TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200433 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700434
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200435 encoder_factory_->AddSupportedVideoCodecType("VP8");
436 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700437
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200438 std::unique_ptr<VideoMediaChannel> channel(
439 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700440 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
441
442 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200443 EXPECT_CALL(
444 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200445 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200446 Field(&rtc::VideoSinkWants::rotation_applied, true)));
447 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700448
perkjcaafdba2016-03-20 07:34:29 -0700449 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200450 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700451
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700452 // Add CVO extension.
453 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800454 cricket::VideoSendParameters parameters;
455 parameters.codecs.push_back(GetEngineCodec("VP8"));
456 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200457 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700458 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700459 // Also remove the first codec to trigger a codec change as well.
460 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200461 EXPECT_CALL(
462 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200463 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200464 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200465 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700466
467 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200468 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700469
470 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200471 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200472 EXPECT_CALL(
473 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200474 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200475 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200476 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700477}
478
eladalonf1841382017-06-12 01:16:46 -0700479TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200480 encoder_factory_->AddSupportedVideoCodecType("VP8");
481
Sebastian Jansson84848f22018-11-16 10:40:36 +0100482 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200483 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
484 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000485
486 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
487
488 EXPECT_FALSE(channel->SetSend(true))
489 << "Channel should not start without codecs.";
490 EXPECT_TRUE(channel->SetSend(false))
491 << "Channel should be stoppable even without set codecs.";
492}
493
eladalonf1841382017-06-12 01:16:46 -0700494TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200495 encoder_factory_->AddSupportedVideoCodecType("VP8");
496
Sebastian Jansson84848f22018-11-16 10:40:36 +0100497 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200498 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
499 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000500 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
501 VideoMediaInfo info;
502 channel->GetStats(&info);
503}
504
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200505TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200506 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000507
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200508 std::unique_ptr<VideoMediaChannel> channel(
509 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800510 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511
512 EXPECT_TRUE(
513 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200514 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000515 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100516 webrtc::test::FrameForwarder frame_forwarder;
517 cricket::FakeFrameSource frame_source(1280, 720,
518 rtc::kNumMicrosecsPerSec / 30);
519 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
520 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100521 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200522 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
523 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000524 kTimeout);
525
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200526 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100527 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000528
529 // Setting codecs of the same type should not reallocate any encoders
530 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800531 cricket::VideoSendParameters parameters;
532 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200533 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200534 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000535
536 // Remove stream previously added to free the external encoder instance.
537 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200538 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000539}
540
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200541// Test that when an encoder factory supports H264, we add an RTX
542// codec for it.
543// TODO(deadbeef): This test should be updated if/when we start
544// adding RTX codecs for unrecognized codec names.
545TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800546 using webrtc::H264::kLevel1;
Jonas Olssona4d87372019-07-05 19:08:33 +0200547 using webrtc::H264::ProfileLevelId;
548 using webrtc::H264::ProfileLevelIdToString;
Anders Carlsson67537952018-05-03 11:28:29 +0200549 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
550 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800551 *ProfileLevelIdToString(
552 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200553 webrtc::SdpVideoFormat h264_constrained_high("H264");
554 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800555 *ProfileLevelIdToString(
556 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200557 webrtc::SdpVideoFormat h264_high("H264");
558 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800559 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
560
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200561 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
562 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
563 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700564
magjed725e4842016-11-16 00:48:13 -0800565 // First figure out what payload types the test codecs got assigned.
566 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800567 // Now search for RTX codecs for them. Expect that they all have associated
568 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800569 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200570 codecs,
571 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
572 ->id));
magjed725e4842016-11-16 00:48:13 -0800573 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200574 codecs,
575 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
576 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800577 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200578 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700579}
580
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100581#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700582TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200583 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100584
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200585 std::unique_ptr<VideoMediaChannel> channel(
586 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100587
588 EXPECT_TRUE(
589 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
590}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100591#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100592
eladalonf1841382017-06-12 01:16:46 -0700593TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200594 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100595 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200596 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200597 std::unique_ptr<VideoMediaChannel> channel(
598 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700599
600 EXPECT_TRUE(
601 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
602
Niels Möllerd0f0f682019-01-14 09:09:53 +0100603 webrtc::test::FrameForwarder frame_forwarder;
604 cricket::FakeFrameSource frame_source(1280, 720,
605 rtc::kNumMicrosecsPerSec / 60);
606 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700607 channel->SetSend(true);
608
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200609 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700610
Niels Möllerd0f0f682019-01-14 09:09:53 +0100611 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700612 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700613 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100614 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700615 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700616 int64_t interval = timestamp - last_timestamp;
617
618 // Precision changes from nanosecond to millisecond.
619 // Allow error to be no more than 1.
620 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
621
622 last_timestamp = timestamp;
623 }
624
Niels Möllerd0f0f682019-01-14 09:09:53 +0100625 frame_forwarder.IncomingCapturedFrame(
626 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
627 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700628 last_timestamp = stream->GetLastTimestamp();
629 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100630 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
631 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
632 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700633 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700634 int64_t interval = timestamp - last_timestamp;
635
636 // Precision changes from nanosecond to millisecond.
637 // Allow error to be no more than 1.
638 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
639
640 last_timestamp = timestamp;
641 }
642
643 // Remove stream previously added to free the external encoder instance.
644 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
645}
646
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200647void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
648 std::vector<VideoCodec> engine_codecs = engine_.codecs();
649 RTC_DCHECK(!engine_codecs.empty());
650 for (const cricket::VideoCodec& codec : engine_codecs) {
651 if (codec.name == "rtx") {
652 int associated_payload_type;
653 if (codec.GetParam(kCodecParamAssociatedPayloadType,
654 &associated_payload_type)) {
655 default_apt_rtx_types_[associated_payload_type] = codec.id;
656 }
657 }
658 }
659}
660
661void WebRtcVideoEngineTest::AssignDefaultCodec() {
662 std::vector<VideoCodec> engine_codecs = engine_.codecs();
663 RTC_DCHECK(!engine_codecs.empty());
664 bool codec_set = false;
665 for (const cricket::VideoCodec& codec : engine_codecs) {
666 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
667 codec.name != "ulpfec") {
668 default_codec_ = codec;
669 codec_set = true;
670 }
671 }
672
673 RTC_DCHECK(codec_set);
674}
675
Oleh Prypina40f8242017-12-21 13:32:23 +0100676size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
677 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100678 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
679 for (size_t i = 0; i < codecs.size(); ++i) {
680 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200681 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200682 continue;
683 // The tests only use H264 Constrained Baseline. Make sure we don't return
684 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200685 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200686 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200687 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
688 if (profile_level_id->profile !=
689 webrtc::H264::kProfileConstrainedBaseline) {
690 continue;
691 }
692 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100693 return i;
magjed509e4fe2016-11-18 01:34:11 -0800694 }
695 // This point should never be reached.
696 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100697 return -1;
698}
699
700cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
701 const std::string& name) const {
702 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800703}
704
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200705VideoMediaChannel*
706WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100707 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200708 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
709 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200710 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800711 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200712 for (const webrtc::SdpVideoFormat& format :
713 encoder_factory_->GetSupportedFormats()) {
714 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800715 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200716 parameters.codecs.push_back(engine_codec);
717 }
718 }
magjed509e4fe2016-11-18 01:34:11 -0800719
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200720 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000721
722 return channel;
723}
724
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200725VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000726 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100727 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200728 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
729 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200730 cricket::VideoRecvParameters parameters;
731 parameters.codecs = codecs;
732 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000733
734 return channel;
735}
736
Elad Alon157540a2019-02-08 23:37:52 +0100737void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
738 bool supported) const {
739 const RtpCapabilities capabilities = engine_.GetCapabilities();
740 if (supported) {
741 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200742 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100743 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200744 EXPECT_THAT(capabilities.header_extensions,
745 ::testing::Each(::testing::Field(&RtpExtension::uri,
746 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100747 }
748}
749
eladalonf1841382017-06-12 01:16:46 -0700750TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200751 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000752
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200753 std::unique_ptr<VideoMediaChannel> channel(
754 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000755
Peter Boström0c4e06b2015-10-07 12:23:21 +0200756 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000757
Yves Gerey665174f2018-06-19 15:03:05 +0200758 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000759 EXPECT_TRUE(channel->SetSend(true));
760
Niels Möller805a27e2019-01-21 12:21:27 +0100761 webrtc::test::FrameForwarder frame_forwarder;
762 cricket::FakeFrameSource frame_source(1280, 720,
763 rtc::kNumMicrosecsPerSec / 60);
764 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
765 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000766
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200767 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000768
769 // Verify that encoders are configured for simulcast through adapter
770 // (increasing resolution and only configured to send one stream each).
771 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200772 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
773 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000774 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200775 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000776 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
777 EXPECT_GT(codec_settings.width, prev_width);
778 prev_width = codec_settings.width;
779 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000780
Niels Möllerff40b142018-04-09 08:49:14 +0200781 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000782
783 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200784 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000785}
786
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200787TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
788 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200789 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000790
Niels Möllerd0f0f682019-01-14 09:09:53 +0100791 // Frame source.
792 webrtc::test::FrameForwarder frame_forwarder;
793 cricket::FakeFrameSource frame_source(1280, 720,
794 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200795
Sebastian Jansson84848f22018-11-16 10:40:36 +0100796 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200797 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
798 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200799 cricket::VideoSendParameters parameters;
800 parameters.codecs.push_back(GetEngineCodec("H264"));
801 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000802
803 EXPECT_TRUE(
804 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100805 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200806 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100807 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200808
809 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000810
Anders Carlsson67537952018-05-03 11:28:29 +0200811 cricket::VideoSendParameters new_parameters;
812 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
813 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200814
815 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100816 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200817
Anders Carlsson8a150d92018-05-14 12:40:04 +0200818 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000819}
820
eladalonf1841382017-06-12 01:16:46 -0700821TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000822 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200823 encoder_factory_->AddSupportedVideoCodecType("VP8");
824 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000825
Sebastian Jansson84848f22018-11-16 10:40:36 +0100826 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200827 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
828 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800829 cricket::VideoSendParameters parameters;
830 parameters.codecs.push_back(GetEngineCodec("VP8"));
831 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000832
Peter Boström0c4e06b2015-10-07 12:23:21 +0200833 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000834
Yves Gerey665174f2018-06-19 15:03:05 +0200835 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836 EXPECT_TRUE(channel->SetSend(true));
837
838 // Send a fake frame, or else the media engine will configure the simulcast
839 // encoder adapter at a low-enough size that it'll only create a single
840 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100841 webrtc::test::FrameForwarder frame_forwarder;
842 cricket::FakeFrameSource frame_source(1280, 720,
843 rtc::kNumMicrosecsPerSec / 30);
844 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
845 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000846
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200847 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
848 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000849 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200850 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000851
852 channel.reset();
853 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200854 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000855}
856
eladalonf1841382017-06-12 01:16:46 -0700857TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000858 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200859 encoder_factory_->AddSupportedVideoCodecType("VP8");
860 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000861
Sebastian Jansson84848f22018-11-16 10:40:36 +0100862 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200863 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
864 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800865 cricket::VideoSendParameters parameters;
866 parameters.codecs.push_back(GetEngineCodec("H264"));
867 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000868
869 EXPECT_TRUE(
870 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100871
872 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100873 webrtc::test::FrameForwarder frame_forwarder;
874 cricket::FakeFrameSource frame_source(1280, 720,
875 rtc::kNumMicrosecsPerSec / 30);
876 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
877 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200878 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
879 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200880 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000881 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200882 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000883
884 channel.reset();
885 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200886 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000887}
888
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200889TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200890 RTC_DCHECK(!override_field_trials_);
891 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200892 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200893 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700894
Sebastian Jansson84848f22018-11-16 10:40:36 +0100895 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200896 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
897 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200898 cricket::VideoSendParameters parameters;
899 parameters.codecs.push_back(GetEngineCodec("H264"));
900 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700901
Peter Boström0c4e06b2015-10-07 12:23:21 +0200902 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700903 EXPECT_TRUE(
904 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100905
906 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100907 webrtc::test::FrameForwarder frame_forwarder;
908 cricket::FakeFrameSource frame_source(1280, 720,
909 rtc::kNumMicrosecsPerSec / 30);
910 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
911 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100912
Niels Möller4db138e2018-04-19 09:04:13 +0200913 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200914 ASSERT_EQ(1u, encoder_factory_->encoders().size());
915 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
916 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700917 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200918 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200919 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700920}
921
brandtrffc61182016-11-28 06:02:22 -0800922// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700923// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800924//
925// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700926TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800927 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200928 encoder_factory_->AddSupportedVideoCodecType("VP8");
929
Steve Anton2c9ebef2019-01-28 17:27:58 -0800930 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800931
932 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800933 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800934
935 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200936 RTC_DCHECK(!override_field_trials_);
937 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800938 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800939 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800940}
941
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200942// Test that codecs are added in the order they are reported from the factory.
943TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
944 encoder_factory_->AddSupportedVideoCodecType("VP8");
945 const char* kFakeCodecName = "FakeCodec";
946 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000947
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200948 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100949 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200950 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
951 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000952}
953
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200954// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800955// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200956TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100957 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
958 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100959
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100960 // Set up external encoder factory with first codec, and initialize engine.
961 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
962
brandtrffc61182016-11-28 06:02:22 -0800963 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800964
965 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100966 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800967 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200968 // The codec itself and RTX should have been added.
969 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100970
971 // Check that both fake codecs are present and that the second fake codec
972 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100973 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
974 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100975 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800976}
977
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200978TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
979 const char* kFakeCodecName = "FakeCodec";
980 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
981
982 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
983 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
984}
985
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200986TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
987 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200988 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200989 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800990 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000991
kwiberg686a8ef2016-02-26 03:00:35 -0800992 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200993 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000994
995 EXPECT_TRUE(
996 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200997 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000998
999 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001000 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001001 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001002
1003 // Remove stream previously added to free the external decoder instance.
1004 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001005 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001006}
1007
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001008// Verifies that we can set up decoders.
1009TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001010 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
1011 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1012 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1013 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001014 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001015 webrtc::SdpVideoFormat supported_h264("H264");
1016 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1017 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001018 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001019 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001020
kwiberg686a8ef2016-02-26 03:00:35 -08001021 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001022 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001023
1024 EXPECT_TRUE(
1025 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001026 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001027}
1028
Jonas Oreland49ac5952018-09-26 16:04:32 +02001029// Tests when GetSources is called with non-existing ssrc, it will return an
1030// empty list of RtpSource without crashing.
1031TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1032 // Setup an recv stream with |kSsrc|.
1033 encoder_factory_->AddSupportedVideoCodecType("VP8");
1034 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1035 cricket::VideoRecvParameters parameters;
1036 parameters.codecs.push_back(GetEngineCodec("VP8"));
1037 std::unique_ptr<VideoMediaChannel> channel(
1038 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1039
1040 EXPECT_TRUE(
1041 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1042
1043 // Call GetSources with |kSsrc + 1| which doesn't exist.
1044 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1045 EXPECT_EQ(0u, sources.size());
1046}
1047
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001048TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1049 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1050 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1051 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001052 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001053 EXPECT_EQ(0u, engine.codecs().size());
1054}
1055
1056TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1057 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001058 webrtc::MockVideoEncoderFactory* encoder_factory =
1059 new webrtc::MockVideoEncoderFactory();
1060 webrtc::MockVideoDecoderFactory* decoder_factory =
1061 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001062 WebRtcVideoEngine engine(
1063 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001064 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001065 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1066 EXPECT_EQ(0u, engine.codecs().size());
1067 EXPECT_CALL(*encoder_factory, Die());
1068 EXPECT_CALL(*decoder_factory, Die());
1069}
1070
1071// Test full behavior in the video engine when video codec factories of the new
1072// type are injected supporting the single codec Vp8. Check the returned codecs
1073// from the engine and that we will create a Vp8 encoder and decoder using the
1074// new factories.
1075TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1076 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001077 webrtc::MockVideoEncoderFactory* encoder_factory =
1078 new webrtc::MockVideoEncoderFactory();
1079 webrtc::MockVideoDecoderFactory* decoder_factory =
1080 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001081 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1082 rate_allocator_factory =
1083 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001084 EXPECT_CALL(*rate_allocator_factory,
1085 CreateVideoBitrateAllocatorProxy(Field(
1086 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001087 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001088 WebRtcVideoEngine engine(
1089 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001090 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001091 const webrtc::SdpVideoFormat vp8_format("VP8");
1092 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1093 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001094 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001095
1096 // Verify the codecs from the engine.
1097 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001098 // Verify default codecs has been added correctly.
1099 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001100 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001101
1102 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001103 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001104 int vp8_associated_payload;
1105 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1106 &vp8_associated_payload));
1107 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1108
1109 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1110
1111 // RTX codec for RED.
1112 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1113 int red_associated_payload;
1114 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1115 &red_associated_payload));
1116 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1117
1118 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1119
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001120 int associated_payload_type;
1121 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1122 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1123 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1124 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001125 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1126 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001127
1128 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001129 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1130 codec_info.is_hardware_accelerated = false;
1131 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001132 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001133 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001134 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001135 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001136 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001137 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001138 .WillOnce(
1139 ::testing::DoAll(::testing::InvokeWithoutArgs(
1140 [&encoder_created]() { encoder_created.Set(); }),
1141 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001142
1143 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001144 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001145 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001146 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001147
1148 // Create a call.
1149 webrtc::RtcEventLogNullImpl event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001150 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1151 webrtc::Call::Config call_config(&event_log);
1152 call_config.task_queue_factory = task_queue_factory.get();
1153 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001154
1155 // Create send channel.
1156 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001157 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001158 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1159 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001160 cricket::VideoSendParameters send_parameters;
1161 send_parameters.codecs.push_back(engine_codecs.at(0));
1162 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1163 send_channel->OnReadyToSend(true);
1164 EXPECT_TRUE(
1165 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1166 EXPECT_TRUE(send_channel->SetSend(true));
1167
Niels Möller4db138e2018-04-19 09:04:13 +02001168 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001169 webrtc::test::FrameForwarder frame_forwarder;
1170 cricket::FakeFrameSource frame_source(1280, 720,
1171 rtc::kNumMicrosecsPerSec / 30);
1172 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001173 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001174 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001175 encoder_created.Wait(kTimeout);
1176
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001177 // Create recv channel.
1178 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001179 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001180 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1181 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001182 cricket::VideoRecvParameters recv_parameters;
1183 recv_parameters.codecs.push_back(engine_codecs.at(0));
1184 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1185 EXPECT_TRUE(recv_channel->AddRecvStream(
1186 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1187
1188 // Remove streams previously added to free the encoder and decoder instance.
1189 EXPECT_CALL(*encoder_factory, Die());
1190 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001191 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001192 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1193 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1194}
1195
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001196// Test behavior when decoder factory fails to create a decoder (returns null).
1197TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1198 // |engine| take ownership of the factories.
1199 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001200 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001201 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001202 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001203 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1204 rate_allocator_factory =
1205 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001206 WebRtcVideoEngine engine(
1207 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001208 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001209 const webrtc::SdpVideoFormat vp8_format("VP8");
1210 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1211 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001212 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001213
1214 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001215 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1216 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001217
1218 // Create a call.
1219 webrtc::RtcEventLogNullImpl event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001220 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1221 webrtc::Call::Config call_config(&event_log);
1222 call_config.task_queue_factory = task_queue_factory.get();
1223 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001224
1225 // Create recv channel.
1226 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001227 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001228 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1229 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001230 cricket::VideoRecvParameters recv_parameters;
1231 recv_parameters.codecs.push_back(engine.codecs().front());
1232 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1233 EXPECT_TRUE(recv_channel->AddRecvStream(
1234 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1235
1236 // Remove streams previously added to free the encoder and decoder instance.
1237 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1238}
1239
eladalonf1841382017-06-12 01:16:46 -07001240TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001241 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001242 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001243 std::unique_ptr<VideoMediaChannel> channel(
1244 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001245 ASSERT_TRUE(
1246 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1247 cricket::VideoCodec codec = GetEngineCodec("VP8");
1248 cricket::VideoSendParameters parameters;
1249 parameters.codecs.push_back(codec);
1250 channel->OnReadyToSend(true);
1251 channel->SetSend(true);
1252 ASSERT_TRUE(channel->SetSendParameters(parameters));
1253
Niels Möller805a27e2019-01-21 12:21:27 +01001254 webrtc::test::FrameForwarder frame_forwarder;
1255 cricket::FakeFrameSource frame_source(1280, 720,
1256 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001257 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001258 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001259
Niels Möller805a27e2019-01-21 12:21:27 +01001260 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001261 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001262 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001263 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001264
Niels Möller805a27e2019-01-21 12:21:27 +01001265 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1266 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001267 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001268 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001269
1270 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001271 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1272 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001273 // Change to screen content, recreate encoder. For the simulcast encoder
1274 // adapter case, this will result in two calls since InitEncode triggers a
1275 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001276 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001277 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001278 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001279
Niels Möller805a27e2019-01-21 12:21:27 +01001280 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1281 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001282 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001283 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001284
1285 options.is_screencast.emplace(false);
1286 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001287 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001288 // Change back to regular video content, update encoder. Also change
1289 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001290 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001291 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001292 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001293 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001294
1295 // Remove stream previously added to free the external encoder instance.
1296 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001297 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001298}
1299
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001300class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001301 protected:
1302 WebRtcVideoChannelBaseTest()
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001303 : task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
1304 video_bitrate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001305 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1306 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1307 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001308
1309 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001310 // One testcase calls SetUp in a loop, only create call_ once.
1311 if (!call_) {
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001312 webrtc::Call::Config call_config(&event_log_);
1313 call_config.task_queue_factory = task_queue_factory_.get();
1314 call_.reset(webrtc::Call::Create(call_config));
Jonas Oreland49ac5952018-09-26 16:04:32 +02001315 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001316 cricket::MediaConfig media_config;
1317 // Disabling cpu overuse detection actually disables quality scaling too; it
1318 // implies DegradationPreference kMaintainResolution. Automatic scaling
1319 // needs to be disabled, otherwise, tests which check the size of received
1320 // frames become flaky.
1321 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001322 channel_.reset(
1323 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1324 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001325 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001326 channel_->OnReadyToSend(true);
1327 EXPECT_TRUE(channel_.get() != NULL);
1328 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001329 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001330 cricket::VideoRecvParameters parameters;
1331 parameters.codecs = engine_.codecs();
1332 channel_->SetRecvParameters(parameters);
1333 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001334 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1335 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1336 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1337 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001338 }
1339
1340 // Utility method to setup an additional stream to send and receive video.
1341 // Used to test send and recv between two streams.
1342 void SetUpSecondStream() {
1343 SetUpSecondStreamWithNoRecv();
1344 // Setup recv for second stream.
1345 EXPECT_TRUE(channel_->AddRecvStream(
1346 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1347 // Make the second renderer available for use by a new stream.
1348 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1349 }
1350 // Setup an additional stream just to send video. Defer add recv stream.
1351 // This is required if you want to test unsignalled recv of video rtp packets.
1352 void SetUpSecondStreamWithNoRecv() {
1353 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001354 EXPECT_TRUE(
1355 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001356 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001357 EXPECT_FALSE(
1358 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001359 EXPECT_TRUE(channel_->AddSendStream(
1360 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1361 // We dont add recv for the second stream.
1362
1363 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001364 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001365 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001366 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001367 }
Yves Gerey665174f2018-06-19 15:03:05 +02001368 virtual void TearDown() { channel_.reset(); }
1369 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001370
1371 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001372 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1373 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001374
1375 bool sending = channel_->sending();
1376 bool success = SetSend(false);
1377 if (success) {
1378 cricket::VideoSendParameters parameters;
1379 parameters.codecs.push_back(codec);
1380 success = channel_->SetSendParameters(parameters);
1381 }
1382 if (success) {
1383 success = SetSend(sending);
1384 }
1385 return success;
1386 }
Yves Gerey665174f2018-06-19 15:03:05 +02001387 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001388 void SendFrame() {
1389 if (frame_forwarder_2_) {
1390 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001391 }
Niels Möller805a27e2019-01-21 12:21:27 +01001392 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001393 }
1394 bool WaitAndSendFrame(int wait_ms) {
1395 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001396 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001397 return ret;
1398 }
Yves Gerey665174f2018-06-19 15:03:05 +02001399 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001400 int NumRtpBytes(uint32_t ssrc) {
1401 return network_interface_.NumRtpBytes(ssrc);
1402 }
Yves Gerey665174f2018-06-19 15:03:05 +02001403 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001404 int NumRtpPackets(uint32_t ssrc) {
1405 return network_interface_.NumRtpPackets(ssrc);
1406 }
Yves Gerey665174f2018-06-19 15:03:05 +02001407 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001408 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1409 return network_interface_.GetRtpPacket(index);
1410 }
1411 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001412 webrtc::RTPHeader header;
1413 EXPECT_TRUE(ParseRtpPacket(p, &header));
1414 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001415 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001416
Niels Möller6557d0c2018-04-11 15:18:34 +02001417 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001418 webrtc::RTPHeader* header) {
1419 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1420 webrtc::RtpHeaderParser::Create());
1421 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001422 }
1423
1424 // Tests that we can send and receive frames.
1425 void SendAndReceive(const cricket::VideoCodec& codec) {
1426 EXPECT_TRUE(SetOneCodec(codec));
1427 EXPECT_TRUE(SetSend(true));
1428 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1429 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001430 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001431 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1432 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1433 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1434 }
1435
1436 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001437 int duration_sec,
1438 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001439 EXPECT_TRUE(SetOneCodec(codec));
1440 EXPECT_TRUE(SetSend(true));
1441 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1442 EXPECT_EQ(0, renderer_.num_rendered_frames());
1443 for (int i = 0; i < duration_sec; ++i) {
1444 for (int frame = 1; frame <= fps; ++frame) {
1445 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1446 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1447 }
1448 }
1449 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1450 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1451 }
1452
Niels Möller6557d0c2018-04-11 15:18:34 +02001453 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1454 cricket::VideoMediaInfo info;
1455 EXPECT_TRUE(channel_->GetStats(&info));
1456 return info.senders[i];
1457 }
1458
1459 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1460 cricket::VideoMediaInfo info;
1461 EXPECT_TRUE(channel_->GetStats(&info));
1462 return info.receivers[i];
1463 }
1464
1465 // Two streams one channel tests.
1466
1467 // Tests that we can send and receive frames.
1468 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1469 SetUpSecondStream();
1470 // Test sending and receiving on first stream.
1471 SendAndReceive(codec);
1472 // Test sending and receiving on second stream.
1473 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1474 EXPECT_GT(NumRtpPackets(), 0);
1475 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1476 }
1477
1478 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1479 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001480 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001481 return engine_codec;
1482 }
1483 // This point should never be reached.
1484 ADD_FAILURE() << "Unrecognized codec name: " << name;
1485 return cricket::VideoCodec();
1486 }
1487
1488 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1489
1490 cricket::StreamParams DefaultSendStreamParams() {
1491 return cricket::StreamParams::CreateLegacy(kSsrc);
1492 }
1493
1494 webrtc::RtcEventLogNullImpl event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001495 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001496 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001497 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1498 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001499 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001500
1501 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1502 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1503 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1504
Niels Möller6557d0c2018-04-11 15:18:34 +02001505 std::unique_ptr<WebRtcVideoChannel> channel_;
1506 cricket::FakeNetworkInterface network_interface_;
1507 cricket::FakeVideoRenderer renderer_;
1508
1509 // Used by test cases where 2 streams are run on the same channel.
1510 cricket::FakeVideoRenderer renderer2_;
1511};
1512
1513// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001514TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001515 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001516 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001517 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1518 EXPECT_FALSE(channel_->sending());
1519 EXPECT_TRUE(SetSend(true));
1520 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001521 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001522 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1523 EXPECT_TRUE(SetSend(false));
1524 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001525}
Niels Möller6557d0c2018-04-11 15:18:34 +02001526
1527// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001528TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001529 EXPECT_FALSE(channel_->sending());
1530 EXPECT_FALSE(SetSend(true));
1531 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001532}
Niels Möller6557d0c2018-04-11 15:18:34 +02001533
1534// Test that we properly set the send and recv buffer sizes by the time
1535// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001536TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001537 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1538 EXPECT_TRUE(SetSend(true));
1539 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001540 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001541}
1542
Johannes Kron5a0665b2019-04-08 10:35:50 +02001543// Test that we properly set the send and recv buffer sizes when overriding
1544// via field trials.
1545TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1546 // Set field trial to override the default recv buffer size, and then re-run
1547 // setup where the interface is created and configured.
1548 const int kCustomRecvBufferSize = 123456;
1549 webrtc::test::ScopedFieldTrials field_trial(
1550 "WebRTC-IncreasedReceivebuffers/123456/");
1551 SetUp();
1552
1553 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1554 EXPECT_TRUE(SetSend(true));
1555 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1556 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1557}
1558
1559// Test that we properly set the send and recv buffer sizes when overriding
1560// via field trials with suffix.
1561TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1562 // Set field trial to override the default recv buffer size, and then re-run
1563 // setup where the interface is created and configured.
1564 const int kCustomRecvBufferSize = 123456;
1565 webrtc::test::ScopedFieldTrials field_trial(
1566 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1567 SetUp();
1568
1569 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1570 EXPECT_TRUE(SetSend(true));
1571 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1572 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1573}
1574
1575// Test that we properly set the send and recv buffer sizes when overriding
1576// via field trials that don't make any sense.
1577TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1578 // Set bogus field trial values to override the default recv buffer size, and
1579 // then re-run setup where the interface is created and configured. The
1580 // default value should still be used.
1581
1582 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1583 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1584 field_trial_string += group;
1585 field_trial_string += "/";
1586 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1587 SetUp();
1588
1589 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1590 EXPECT_TRUE(SetSend(true));
1591 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1592 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1593 }
1594}
1595
Niels Möller6557d0c2018-04-11 15:18:34 +02001596// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001597TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001598 const int kDurationSec = 3;
1599 const int kFps = 10;
1600 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1601
1602 cricket::VideoMediaInfo info;
1603 EXPECT_TRUE(channel_->GetStats(&info));
1604
1605 ASSERT_EQ(1U, info.senders.size());
1606 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1607 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn A Mellem74a1b4b2019-07-23 06:18:24 -07001608 EXPECT_EQ(info.senders[0].bytes_sent,
1609 NumRtpBytes() - kRtpHeaderSize * NumRtpPackets());
Niels Möller6557d0c2018-04-11 15:18:34 +02001610 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1611 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1612 ASSERT_TRUE(info.senders[0].codec_payload_type);
1613 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1614 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1615 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1616 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1617 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1618 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1619 EXPECT_GT(info.senders[0].framerate_input, 0);
1620 EXPECT_GT(info.senders[0].framerate_sent, 0);
1621
1622 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1623 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1624 info.send_codecs[DefaultCodec().id]);
1625
1626 ASSERT_EQ(1U, info.receivers.size());
1627 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1628 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1629 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1630 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1631 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
Bjorn A Mellem74a1b4b2019-07-23 06:18:24 -07001632 EXPECT_EQ(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1633 info.receivers[0].bytes_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001634 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001635 EXPECT_EQ(0, info.receivers[0].packets_lost);
1636 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1637 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1638 EXPECT_EQ(0, info.receivers[0].firs_sent);
1639 EXPECT_EQ(0, info.receivers[0].plis_sent);
1640 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1641 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1642 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1643 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1644 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1645 EXPECT_GT(info.receivers[0].framerate_output, 0);
1646
1647 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1648 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1649 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001650}
Niels Möller6557d0c2018-04-11 15:18:34 +02001651
1652// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001653TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001654 cricket::FakeVideoRenderer renderer1, renderer2;
1655 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1656 cricket::VideoSendParameters parameters;
1657 parameters.codecs.push_back(DefaultCodec());
1658 parameters.conference_mode = true;
1659 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1660 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001661 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1662 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001663 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1664 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1665 EXPECT_EQ(0, renderer1.num_rendered_frames());
1666 EXPECT_EQ(0, renderer2.num_rendered_frames());
1667 std::vector<uint32_t> ssrcs;
1668 ssrcs.push_back(1);
1669 ssrcs.push_back(2);
1670 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001671 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001672 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1673 kTimeout);
1674 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1675 kTimeout);
1676
1677 EXPECT_TRUE(channel_->SetSend(false));
1678
1679 cricket::VideoMediaInfo info;
1680 EXPECT_TRUE(channel_->GetStats(&info));
1681 ASSERT_EQ(1U, info.senders.size());
1682 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1683 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn A Mellem74a1b4b2019-07-23 06:18:24 -07001684 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1685 GetSenderStats(0).bytes_sent, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001686 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1687 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1688 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1689
1690 ASSERT_EQ(2U, info.receivers.size());
1691 for (size_t i = 0; i < info.receivers.size(); ++i) {
1692 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1693 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
Bjorn A Mellem74a1b4b2019-07-23 06:18:24 -07001694 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1695 GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001696 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001697 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1698 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1699 }
srtee0c2eea2017-12-15 17:44:33 +01001700}
Niels Möller6557d0c2018-04-11 15:18:34 +02001701
1702// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001703TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001704 // Normal setup; note that we set the SSRC explicitly to ensure that
1705 // it will come first in the senders map.
1706 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1707 cricket::VideoSendParameters parameters;
1708 parameters.codecs.push_back(DefaultCodec());
1709 parameters.conference_mode = true;
1710 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001711 EXPECT_TRUE(
1712 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001713 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1714 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001715 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001716 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1717 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1718
1719 // Add an additional capturer, and hook up a renderer to receive it.
1720 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001721 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001722 const int kTestWidth = 160;
1723 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001724 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1725 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001726 EXPECT_TRUE(
1727 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001728 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001729 EXPECT_TRUE(
1730 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001731 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001732 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001733 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1734 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001735
1736 // Get stats, and make sure they are correct for two senders. We wait until
1737 // the number of expected packets have been sent to avoid races where we
1738 // check stats before it has been updated.
1739 cricket::VideoMediaInfo info;
1740 for (uint32_t i = 0; i < kTimeout; ++i) {
1741 rtc::Thread::Current()->ProcessMessages(1);
1742 EXPECT_TRUE(channel_->GetStats(&info));
1743 ASSERT_EQ(2U, info.senders.size());
1744 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1745 NumRtpPackets()) {
1746 // Stats have been updated for both sent frames, expectations can be
1747 // checked now.
1748 break;
1749 }
1750 }
1751 EXPECT_EQ(NumRtpPackets(),
1752 info.senders[0].packets_sent + info.senders[1].packets_sent)
1753 << "Timed out while waiting for packet counts for all sent packets.";
1754 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1755 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1756 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1757 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1758 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1759 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1760 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1761 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1762 // The capturer must be unregistered here as it runs out of it's scope next.
1763 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001764}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001765
Niels Möller6557d0c2018-04-11 15:18:34 +02001766// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001767TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001768 cricket::VideoSendParameters parameters;
1769 parameters.codecs.push_back(DefaultCodec());
1770 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1771 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1772 parameters.max_bandwidth_bps = 128 * 1024;
1773 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001774}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001775
Niels Möller6557d0c2018-04-11 15:18:34 +02001776// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001777TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001778 EXPECT_TRUE(SetDefaultCodec());
1779 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001780 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001781 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001782 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001783 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001784 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1785 EXPECT_EQ(kSsrc, header.ssrc);
1786
Niels Möller6557d0c2018-04-11 15:18:34 +02001787 // Packets are being paced out, so these can mismatch between the first and
1788 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001789 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1790 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001791 EXPECT_EQ(1, NumSentSsrcs());
1792 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1793 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001794}
Niels Möller6557d0c2018-04-11 15:18:34 +02001795
1796// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001797TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001798 // Remove stream added in Setup.
1799 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1800 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001801 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001802 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001803 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001804 EXPECT_TRUE(SetSend(true));
1805 EXPECT_TRUE(WaitAndSendFrame(0));
1806 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001807 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001808 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001809 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1810 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001811 // Packets are being paced out, so these can mismatch between the first and
1812 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001813 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1814 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001815 EXPECT_EQ(1, NumSentSsrcs());
1816 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1817 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001818}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001819
Niels Möller6557d0c2018-04-11 15:18:34 +02001820// Test that we can set the default video renderer before and after
1821// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001822TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001823 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1824 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001825
1826 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1827 rtc::SetBE32(packet1.data() + 8, kSsrc);
1828 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1829 EXPECT_TRUE(SetDefaultCodec());
1830 EXPECT_TRUE(SetSend(true));
1831 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001832 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001833 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001834 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001835 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001836}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001837
Niels Möller6557d0c2018-04-11 15:18:34 +02001838// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001839TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001840 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1841 EXPECT_TRUE(SetSend(true));
1842 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001843 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001844 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1845 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001846 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001847 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001848 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1849 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001850 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1851 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001852
1853 // Remove the send stream that was added during Setup.
1854 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1855 int rtp_packets = NumRtpPackets();
1856
Niels Möller6557d0c2018-04-11 15:18:34 +02001857 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001858 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001859 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001860 EXPECT_EQ(rtp_packets, NumRtpPackets());
1861 // Wait 30ms to guarantee the engine does not drop the frame.
1862 EXPECT_TRUE(WaitAndSendFrame(30));
1863 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1864
1865 last_packet = NumRtpPackets() - 1;
1866 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001867 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1868 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001869}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001870
Niels Möller6557d0c2018-04-11 15:18:34 +02001871// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001872TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001873 cricket::FakeVideoRenderer renderer1, renderer2;
1874 EXPECT_TRUE(SetDefaultCodec());
1875 cricket::VideoSendParameters parameters;
1876 parameters.codecs.push_back(DefaultCodec());
1877 parameters.conference_mode = true;
1878 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1879 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001880 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1881 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001882 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1883 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1884 EXPECT_EQ(0, renderer1.num_rendered_frames());
1885 EXPECT_EQ(0, renderer2.num_rendered_frames());
1886 std::vector<uint32_t> ssrcs;
1887 ssrcs.push_back(1);
1888 ssrcs.push_back(2);
1889 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001890 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001891 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1892 kTimeout);
1893 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1894 kTimeout);
1895
1896 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1897 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1898 EXPECT_EQ(kVideoWidth, renderer1.width());
1899 EXPECT_EQ(kVideoHeight, renderer1.height());
1900 EXPECT_EQ(kVideoWidth, renderer2.width());
1901 EXPECT_EQ(kVideoHeight, renderer2.height());
1902 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1903 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001904}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001905
Niels Möller6557d0c2018-04-11 15:18:34 +02001906// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001907TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001908 using cricket::FOURCC_I420;
Jonas Olssona4d87372019-07-05 19:08:33 +02001909 using cricket::VideoCodec;
1910 using cricket::VideoFormat;
1911 using cricket::VideoOptions;
Niels Möller6557d0c2018-04-11 15:18:34 +02001912
1913 VideoCodec codec = DefaultCodec();
1914 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1915 EXPECT_TRUE(SetOneCodec(codec));
1916 EXPECT_TRUE(SetSend(true));
1917 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1918 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001919 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001920 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001921
1922 webrtc::test::FrameForwarder frame_forwarder;
1923 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1924 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001925
1926 // TODO(nisse): This testcase fails if we don't configure
1927 // screencast. It's unclear why, I see nothing obvious in this
1928 // test which is related to screencast logic.
1929 VideoOptions video_options;
1930 video_options.is_screencast = true;
1931 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1932
Niels Möller6557d0c2018-04-11 15:18:34 +02001933 int captured_frames = 1;
1934 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001935 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001936 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001937 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1938
Niels Möller6557d0c2018-04-11 15:18:34 +02001939 ++captured_frames;
1940 // Wait until frame of right size is captured.
1941 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001942 480 == renderer_.width() &&
1943 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001944 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001945 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001946 EXPECT_EQ(480, renderer_.width());
1947 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001948 captured_frames = renderer_.num_rendered_frames() + 1;
1949 EXPECT_FALSE(renderer_.black_frame());
1950 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1951 // Make sure a black frame is generated within the specified timeout.
1952 // The black frame should be the resolution of the previous frame to
1953 // prevent expensive encoder reconfigurations.
1954 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001955 480 == renderer_.width() &&
1956 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001957 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001958 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001959 EXPECT_EQ(480, renderer_.width());
1960 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001961 EXPECT_TRUE(renderer_.black_frame());
1962
1963 // The black frame has the same timestamp as the next frame since it's
1964 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1965 // not render a frame with the same timestamp so capture another frame
1966 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001967 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001968 }
srtee0c2eea2017-12-15 17:44:33 +01001969}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001970
Niels Möller6557d0c2018-04-11 15:18:34 +02001971// Tests that if SetVideoSend is called with a NULL capturer after the
1972// capturer was already removed, the application doesn't crash (and no black
1973// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001974TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001975 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1976 EXPECT_TRUE(SetSend(true));
1977 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1978 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001979 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001980 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1981 // Wait for one frame so they don't get dropped because we send frames too
1982 // tightly.
1983 rtc::Thread::Current()->ProcessMessages(30);
1984 // Remove the capturer.
1985 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1986
1987 // No capturer was added, so this SetVideoSend shouldn't do anything.
1988 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1989 rtc::Thread::Current()->ProcessMessages(300);
1990 // Verify no more frames were sent.
1991 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001992}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001993
Niels Möller6557d0c2018-04-11 15:18:34 +02001994// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001995TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001996 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1997 // interval time to avoid that.
1998 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1999 // interval time to avoid that.
2000 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02002001 EXPECT_TRUE(
2002 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002003 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
2004 cricket::VideoFormat capture_format(
2005 kVideoWidth, kVideoHeight,
2006 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
2007 // Set up additional stream 1.
2008 cricket::FakeVideoRenderer renderer1;
2009 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002010 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002011 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002012 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01002013
2014 webrtc::test::FrameForwarder frame_forwarder1;
2015 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
2016 rtc::kNumMicrosecsPerSec / kFramerate);
2017
Niels Möller6557d0c2018-04-11 15:18:34 +02002018 // Set up additional stream 2.
2019 cricket::FakeVideoRenderer renderer2;
2020 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002021 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002022 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002023 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002024 webrtc::test::FrameForwarder frame_forwarder2;
2025
Niels Möller6557d0c2018-04-11 15:18:34 +02002026 // State for all the streams.
2027 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2028 // A limitation in the lmi implementation requires that SetVideoSend() is
2029 // called after SetOneCodec().
2030 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002031 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2032 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002033 EXPECT_TRUE(SetSend(true));
2034 // Test capturer associated with engine.
2035 const int kTestWidth = 160;
2036 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002037 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2038 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2039 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002040 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2041 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002042 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002043 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2044 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2045 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002046 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2047 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002048 // Successfully remove the capturer.
2049 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2050 // The capturers must be unregistered here as it runs out of it's scope
2051 // next.
2052 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2053 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002054}
Niels Möller6557d0c2018-04-11 15:18:34 +02002055
2056// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002057TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002058 // Remove the send stream that was added during Setup.
2059 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2060
2061 cricket::StreamParams empty;
2062 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002063 EXPECT_TRUE(
2064 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002065}
Niels Möller6557d0c2018-04-11 15:18:34 +02002066
2067// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002068TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002069 // Remove stream added in Setup. I.e. remove stream corresponding to default
2070 // channel.
2071 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002072 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002073 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2074 EXPECT_TRUE(channel_->AddSendStream(
2075 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2076 }
2077 // Delete one of the non default channel streams, let the destructor delete
2078 // the remaining ones.
2079 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2080 // Stream should already be deleted.
2081 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002082}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002083
eladalonf1841382017-06-12 01:16:46 -07002084TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002085 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002086}
2087
eladalonf1841382017-06-12 01:16:46 -07002088TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002089 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002090}
2091
eladalonf1841382017-06-12 01:16:46 -07002092TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002093 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002094}
2095
eladalonf1841382017-06-12 01:16:46 -07002096TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002097 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2098 // bitrates. This currently happens at <250k, and two streams sharing 300k
2099 // initially will use QVGA instead of VGA.
2100 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2101 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002102 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002103 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002104 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002105}
2106
philipele8ed8302019-07-03 11:53:48 +02002107TEST_F(WebRtcVideoChannelBaseTest, OnEncoderFailure) {
2108 cricket::VideoSendParameters parameters;
2109 parameters.codecs.push_back(GetEngineCodec("VP9"));
2110 parameters.codecs.push_back(GetEngineCodec("VP8"));
2111 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2112
2113 VideoCodec codec;
2114 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2115 EXPECT_EQ("VP9", codec.name);
2116
2117 // OnEncoderFailure will post a task to the worker thread (which is also
2118 // the current thread), hence the ProcessMessages call.
2119 channel_->OnEncoderFailure();
2120 rtc::Thread::Current()->ProcessMessages(30);
2121 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2122 EXPECT_EQ("VP8", codec.name);
2123
2124 // No other codec to fall back to, keep using VP8.
2125 channel_->OnEncoderFailure();
2126 rtc::Thread::Current()->ProcessMessages(30);
2127 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2128 EXPECT_EQ("VP8", codec.name);
2129}
2130
eladalonf1841382017-06-12 01:16:46 -07002131class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002132 public:
eladalonf1841382017-06-12 01:16:46 -07002133 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2134 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002135 : WebRtcVideoEngineTest(field_trials),
2136 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2137 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002138 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002139 encoder_factory_->AddSupportedVideoCodecType("VP8");
2140 encoder_factory_->AddSupportedVideoCodecType("VP9");
2141#if defined(WEBRTC_USE_H264)
2142 encoder_factory_->AddSupportedVideoCodecType("H264");
2143#endif
2144
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002145 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002146 channel_.reset(engine_.CreateMediaChannel(
2147 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2148 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002149 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002150 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002151 send_parameters_.codecs = engine_.codecs();
2152 recv_parameters_.codecs = engine_.codecs();
2153 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002154 }
2155
2156 protected:
2157 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002158 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002159 }
2160
2161 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002162 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002163 EXPECT_TRUE(channel_->AddSendStream(sp));
2164 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002165 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002166 EXPECT_EQ(num_streams + 1, streams.size());
2167 return streams[streams.size() - 1];
2168 }
2169
2170 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002171 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002172 }
2173
2174 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002175 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002176 }
2177
2178 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002179 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002180 EXPECT_TRUE(channel_->AddRecvStream(sp));
2181 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002182 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002183 EXPECT_EQ(num_streams + 1, streams.size());
2184 return streams[streams.size() - 1];
2185 }
2186
pbos@webrtc.org00873182014-11-25 14:03:34 +00002187 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2188 int expected_min_bitrate_bps,
2189 const char* start_bitrate_kbps,
2190 int expected_start_bitrate_bps,
2191 const char* max_bitrate_kbps,
2192 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002193 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2194 expected_start_bitrate_bps,
2195 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002196 auto& codecs = send_parameters_.codecs;
2197 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002198 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002199 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2200 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2201 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002202 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002203 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002204
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002205 void ExpectSetBitrateParameters(int min_bitrate_bps,
2206 int start_bitrate_bps,
2207 int max_bitrate_bps) {
2208 EXPECT_CALL(
2209 *fake_call_->GetMockTransportControllerSend(),
2210 SetSdpBitrateParameters(AllOf(
2211 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2212 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2213 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2214 }
2215
2216 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2217 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2218 SetSdpBitrateParameters(Field(
2219 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002220 }
2221
Johannes Kron9190b822018-10-29 11:22:05 +01002222 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2223 // For a caller, the answer will be applied in set remote description
2224 // where SetSendParameters() is called.
2225 EXPECT_TRUE(
2226 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2227 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2228 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2229 const webrtc::VideoSendStream::Config& config =
2230 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2231 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2232 }
2233
2234 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2235 // For a callee, the answer will be applied in set local description
2236 // where SetExtmapAllowMixed() and AddSendStream() are called.
2237 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2238 EXPECT_TRUE(
2239 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2240 const webrtc::VideoSendStream::Config& config =
2241 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2242 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2243 }
2244
isheriff6f8d6862016-05-26 11:24:55 -07002245 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002246 // Enable extension.
2247 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002248 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002249 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002250 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002251 FakeVideoSendStream* send_stream =
2252 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2253
2254 // Verify the send extension id.
2255 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2256 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002257 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002258 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002259 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002260 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2261 // receivers.
2262 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2263 ->GetConfig()
2264 .rtp.extensions.empty());
2265
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002266 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002267 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002268 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2269 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002270 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2271
2272 // Verify that adding receive RTP header extensions adds them for existing
2273 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002274 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002275 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002276 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2277 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002278 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002279 }
2280
isheriff6f8d6862016-05-26 11:24:55 -07002281 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002282 // Enable extension.
2283 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002284 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002285 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002286 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002287
2288 FakeVideoReceiveStream* recv_stream =
2289 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2290
2291 // Verify the recv extension id.
2292 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2293 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002294 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002295 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002296 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002297
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002298 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2299 // senders.
2300 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2301 ->GetConfig()
2302 .rtp.extensions.empty());
2303
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002304 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002305 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002306 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2307 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002308 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2309
2310 // Verify that adding receive RTP header extensions adds them for existing
2311 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002312 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002313 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002314 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2315 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002316 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002317 }
2318
Elad Alonfadb1812019-05-24 13:40:02 +02002319 void TestLossNotificationState(bool expect_lntf_enabled) {
2320 AssignDefaultCodec();
2321 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2322
2323 cricket::VideoSendParameters parameters;
2324 parameters.codecs = engine_.codecs();
2325 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2326 EXPECT_TRUE(channel_->SetSend(true));
2327
2328 // Send side.
2329 FakeVideoSendStream* send_stream =
2330 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2331 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2332
2333 // Receiver side.
2334 FakeVideoReceiveStream* recv_stream =
2335 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2336 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2337 }
2338
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002339 void TestExtensionFilter(const std::vector<std::string>& extensions,
2340 const std::string& expected_extension) {
2341 cricket::VideoSendParameters parameters = send_parameters_;
2342 int expected_id = -1;
2343 int id = 1;
2344 for (const std::string& extension : extensions) {
2345 if (extension == expected_extension)
2346 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002347 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002348 }
2349 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2350 FakeVideoSendStream* send_stream =
2351 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2352
2353 // Verify that only one of them has been set, and that it is the one with
2354 // highest priority (transport sequence number).
2355 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2356 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2357 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002358 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002359 }
2360
asapersson3c81a1a2017-06-14 05:52:21 -07002361 void TestDegradationPreference(bool resolution_scaling_enabled,
2362 bool fps_scaling_enabled);
2363
Erik Språngefbde372015-04-29 16:21:28 +02002364 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002365 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002366 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2367 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002368
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002369 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002370 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002371 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002372 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002373 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002374 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002375 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002376 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002377 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002378
Erik Språng143cec12015-04-28 10:01:41 +02002379 return fake_call_->GetVideoSendStreams().back();
2380 }
2381
Peter Boström2feafdb2015-09-09 14:32:14 +02002382 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2383 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002384 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002385 std::vector<uint32_t> ssrcs;
2386 std::vector<uint32_t> rtx_ssrcs;
2387 uint32_t num_streams = enabled ? 3 : 1;
2388 for (uint32_t i = 0; i < num_streams; ++i) {
2389 uint32_t ssrc = last_ssrc_ + i;
2390 ssrcs.push_back(ssrc);
2391 if (with_rtx) {
2392 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2393 }
Erik Språng143cec12015-04-28 10:01:41 +02002394 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002395 if (with_rtx) {
2396 return AddSendStream(
2397 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2398 }
2399 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002400 }
2401
perkjfa10b552016-10-02 23:45:26 -07002402 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002403 std::vector<FakeVideoSendStream*> streams =
2404 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002405 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002406 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002407 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002408 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002409 }
2410
perkjfa10b552016-10-02 23:45:26 -07002411 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002412 int stream_max,
2413 int expected_encoder_bitrate) {
2414 VideoSendParameters limited_send_params = send_parameters_;
2415 limited_send_params.max_bandwidth_bps = global_max;
2416 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002417 webrtc::RtpParameters parameters =
2418 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002419 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002420 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002421 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002422 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002423 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002424 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002425 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002426 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002427 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002428 }
2429
Åsa Persson55659812018-06-18 17:51:32 +02002430 // Values from kSimulcastConfigs in simulcast.cc.
2431 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2432 std::vector<webrtc::VideoStream> layers(3);
2433 layers[0].min_bitrate_bps = 30000;
2434 layers[0].target_bitrate_bps = 150000;
2435 layers[0].max_bitrate_bps = 200000;
2436 layers[1].min_bitrate_bps = 150000;
2437 layers[1].target_bitrate_bps = 500000;
2438 layers[1].max_bitrate_bps = 700000;
2439 layers[2].min_bitrate_bps = 600000;
2440 layers[2].target_bitrate_bps = 2500000;
2441 layers[2].max_bitrate_bps = 2500000;
2442 return layers;
2443 }
2444
Niels Möller805a27e2019-01-21 12:21:27 +01002445 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002446 std::unique_ptr<FakeCall> fake_call_;
2447 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002448 cricket::VideoSendParameters send_parameters_;
2449 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002450 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002451};
2452
eladalonf1841382017-06-12 01:16:46 -07002453TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002454 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002455 const std::string kSyncLabel = "AvSyncLabel";
2456
2457 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002458 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002459 EXPECT_TRUE(channel_->AddRecvStream(sp));
2460
Mirko Bonadeif859e552018-05-30 15:31:29 +02002461 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002462 EXPECT_EQ(kSyncLabel,
2463 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2464 << "SyncGroup should be set based on sync_label";
2465}
2466
eladalonf1841382017-06-12 01:16:46 -07002467TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002468 cricket::VideoSendParameters parameters;
2469 parameters.codecs = engine_.codecs();
2470 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002471 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002472 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002473 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002474
2475 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002476 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2477 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002478 FakeVideoSendStream* send_stream = AddSendStream(
2479 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2480
2481 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2482 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2483 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2484
2485 // Receiver side.
2486 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2487 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002488 EXPECT_FALSE(
2489 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002490 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002491 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002492 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002493 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002494 << "RTX should be mapped for the RED payload type";
2495
brandtr14742122017-01-27 04:53:07 -08002496 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002497}
2498
eladalonf1841382017-06-12 01:16:46 -07002499TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002500 // Setup one channel with an associated RTX stream.
2501 cricket::StreamParams params =
2502 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2503 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2504 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002505 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002506
2507 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2508 << "RTX should be mapped for all decoders/payload types.";
2509 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002510 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002511 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002512}
2513
eladalonf1841382017-06-12 01:16:46 -07002514TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002515 // Setup one channel without an associated RTX stream.
2516 cricket::StreamParams params =
2517 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2518 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002519 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002520}
2521
Johannes Kron9190b822018-10-29 11:22:05 +01002522// Test propagation of extmap allow mixed setting.
2523TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2524 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2525}
2526TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2527 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2528}
2529TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2530 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2531}
2532TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2533 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2534}
2535
eladalonf1841382017-06-12 01:16:46 -07002536TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002537 FakeVideoSendStream* send_stream =
2538 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2539 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2540
2541 FakeVideoReceiveStream* recv_stream =
2542 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2543 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002544}
2545
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002546// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002547TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002548 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002549}
isheriff6f8d6862016-05-26 11:24:55 -07002550
eladalonf1841382017-06-12 01:16:46 -07002551TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002552 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002553}
2554
2555// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002556TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002557 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002558}
isheriff6f8d6862016-05-26 11:24:55 -07002559
eladalonf1841382017-06-12 01:16:46 -07002560TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002561 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002562}
2563
eladalonf1841382017-06-12 01:16:46 -07002564TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002565 // Enable three redundant extensions.
2566 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002567 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2568 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2569 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2570 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002571}
2572
eladalonf1841382017-06-12 01:16:46 -07002573TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002574 // Enable two redundant extensions.
2575 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002576 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2577 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2578 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002579}
2580
stefanc1aeaf02015-10-15 07:26:07 -07002581// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002582TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002583 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002584}
eladalonf1841382017-06-12 01:16:46 -07002585TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002586 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002587}
2588
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002589// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002590TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002591 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002592}
eladalonf1841382017-06-12 01:16:46 -07002593TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002594 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002595}
2596
eladalonf1841382017-06-12 01:16:46 -07002597TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002598 const int kAbsSendTimeId = 1;
2599 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002600 send_parameters_.extensions.push_back(
2601 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2602 send_parameters_.extensions.push_back(
2603 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002604
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002605 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002606 FakeVideoSendStream* send_stream =
2607 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2608
2609 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002610 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002611
2612 // Setting the same extensions (even if in different order) shouldn't
2613 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002614 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002615 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002616
2617 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2618
2619 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002620 send_parameters_.extensions.resize(1);
2621 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002622
2623 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2624}
2625
eladalonf1841382017-06-12 01:16:46 -07002626TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002627 const int kTOffsetId = 1;
2628 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002629 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002630 recv_parameters_.extensions.push_back(
2631 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2632 recv_parameters_.extensions.push_back(
2633 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2634 recv_parameters_.extensions.push_back(
2635 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002636
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002637 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002638 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002639 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2640
2641 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002642 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002643
2644 // Setting the same extensions (even if in different order) shouldn't
2645 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002646 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002647 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002648
2649 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2650
2651 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002652 recv_parameters_.extensions.resize(1);
2653 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002654
2655 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2656}
2657
eladalonf1841382017-06-12 01:16:46 -07002658TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002659 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002660 const int kUnsupportedId = 1;
2661 const int kTOffsetId = 2;
2662
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002663 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002664 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002665 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002666 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002667 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002668 FakeVideoSendStream* send_stream =
2669 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2670
2671 // Only timestamp offset extension is set to send stream,
2672 // unsupported rtp extension is ignored.
2673 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002674 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2675 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002676}
2677
eladalonf1841382017-06-12 01:16:46 -07002678TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002679 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002680 const int kUnsupportedId = 1;
2681 const int kTOffsetId = 2;
2682
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002683 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002684 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002685 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002686 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002687 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002688 FakeVideoReceiveStream* recv_stream =
2689 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2690
2691 // Only timestamp offset extension is set to receive stream,
2692 // unsupported rtp extension is ignored.
2693 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002694 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2695 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002696}
2697
eladalonf1841382017-06-12 01:16:46 -07002698TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002699 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002700 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002701 send_parameters_.extensions.push_back(
2702 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002703 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002704 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2705 }
2706}
2707
eladalonf1841382017-06-12 01:16:46 -07002708TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002709 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002710 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002711 recv_parameters_.extensions.push_back(
2712 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002713 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002714 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2715 }
2716}
2717
eladalonf1841382017-06-12 01:16:46 -07002718TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002719 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002720 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002721 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002722 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002723 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002724 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002725
2726 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002727 send_parameters_.extensions.clear();
2728 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002729 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002730 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2731 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002732}
2733
eladalonf1841382017-06-12 01:16:46 -07002734TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002735 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002736 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002737 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002738 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002739 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002740 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002741
2742 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002743 recv_parameters_.extensions.clear();
2744 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002745 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002746 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2747 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002748}
2749
eladalonf1841382017-06-12 01:16:46 -07002750TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002751 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002752 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002753}
2754
eladalonf1841382017-06-12 01:16:46 -07002755TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002756 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002757 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002758}
2759
eladalonf1841382017-06-12 01:16:46 -07002760TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002761 FakeVideoReceiveStream* stream = AddRecvStream();
2762 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002763}
2764
eladalonf1841382017-06-12 01:16:46 -07002765TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002766 FakeVideoReceiveStream* stream = AddRecvStream();
2767 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2768}
2769
eladalonf1841382017-06-12 01:16:46 -07002770TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002771 FakeVideoReceiveStream* stream = AddRecvStream();
2772 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2773
Peter Boström126c03e2015-05-11 12:48:12 +02002774 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002775 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002776 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002777 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2778 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002779 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002780 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2781
2782 // Verify that REMB is turned on when setting default codecs since the
2783 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002784 parameters.codecs = engine_.codecs();
2785 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002786 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002787 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002788}
2789
eladalonf1841382017-06-12 01:16:46 -07002790TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002791 FakeVideoReceiveStream* stream = AddRecvStream();
2792 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2793
2794 // Verify that transport cc feedback is turned off when send(!) codecs without
2795 // transport cc feedback are set.
2796 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002797 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002798 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2799 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2800 stream = fake_call_->GetVideoReceiveStreams()[0];
2801 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2802
2803 // Verify that transport cc feedback is turned on when setting default codecs
2804 // since the default codecs have transport cc feedback enabled.
2805 parameters.codecs = engine_.codecs();
2806 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2807 stream = fake_call_->GetVideoReceiveStreams()[0];
2808 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2809}
2810
Elad Alonfadb1812019-05-24 13:40:02 +02002811TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2812 TestLossNotificationState(false);
2813}
2814
2815TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2816 RTC_DCHECK(!override_field_trials_);
2817 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2818 "WebRTC-RtcpLossNotification/Enabled/");
2819 SetUp();
2820 TestLossNotificationState(true);
2821}
2822
2823TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2824 RTC_DCHECK(!override_field_trials_);
2825 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2826 "WebRTC-RtcpLossNotification/Enabled/");
2827 SetUp();
2828
2829 AssignDefaultCodec();
2830 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2831
2832 {
2833 cricket::VideoSendParameters parameters;
2834 parameters.codecs = engine_.codecs();
2835 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2836 EXPECT_TRUE(channel_->SetSend(true));
2837 }
2838
2839 // Start with LNTF enabled.
2840 FakeVideoSendStream* send_stream =
2841 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2842 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2843 FakeVideoReceiveStream* recv_stream =
2844 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2845 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2846
2847 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2848 cricket::VideoSendParameters parameters;
2849 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2850 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2851 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2852 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2853 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2854 send_stream = fake_call_->GetVideoSendStreams()[0];
2855 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2856
2857 // Setting the default codecs again, including VP8, turns LNTF back on.
2858 parameters.codecs = engine_.codecs();
2859 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2860 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2861 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2862 send_stream = fake_call_->GetVideoSendStreams()[0];
2863 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2864}
2865
eladalonf1841382017-06-12 01:16:46 -07002866TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002867 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002868 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002869
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002870 cricket::VideoSendParameters parameters;
2871 parameters.codecs = engine_.codecs();
2872 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002873 EXPECT_TRUE(channel_->SetSend(true));
2874
2875 // Send side.
2876 FakeVideoSendStream* send_stream =
2877 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2878 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2879
2880 // Receiver side.
2881 FakeVideoReceiveStream* recv_stream =
2882 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2883 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2884
2885 // Nack history size should match between sender and receiver.
2886 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2887 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002888}
2889
eladalonf1841382017-06-12 01:16:46 -07002890TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002891 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002892 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002893
2894 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2895 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2896
2897 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002898 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002899 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002900 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2901 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002902 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2903 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2904 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002905 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2906
Peter Boström67c9df72015-05-11 14:34:58 +02002907 // Verify that NACK is turned on when setting default codecs since the
2908 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002909 parameters.codecs = engine_.codecs();
2910 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002911 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2912 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2913 send_stream = fake_call_->GetVideoSendStreams()[0];
2914 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002915}
2916
Peter Boströme7ba0862016-03-12 00:02:28 +01002917// This test verifies that new frame sizes reconfigures encoders even though not
2918// (yet) sending. The purpose of this is to permit encoding as quickly as
2919// possible once we start sending. Likely the frames being input are from the
2920// same source that will be sent later, which just means that we're ready
2921// earlier.
eladalonf1841382017-06-12 01:16:46 -07002922TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002923 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002924 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002925 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2926 channel_->SetSend(false);
2927
2928 FakeVideoSendStream* stream = AddSendStream();
2929
perkjfa10b552016-10-02 23:45:26 -07002930 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002931 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002932 EXPECT_EQ(0u, streams[0].width);
2933 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002934
Niels Möller805a27e2019-01-21 12:21:27 +01002935 webrtc::test::FrameForwarder frame_forwarder;
2936 cricket::FakeFrameSource frame_source(1280, 720,
2937 rtc::kNumMicrosecsPerSec / 30);
2938
2939 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2940 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002941
2942 // Frame entered, should be reconfigured to new dimensions.
2943 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002944 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2945 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002946
Niels Möllerff40b142018-04-09 08:49:14 +02002947 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002948}
2949
eladalonf1841382017-06-12 01:16:46 -07002950TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002951 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002952 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002953 cricket::VideoSendParameters parameters;
2954 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002955 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002956 AddSendStream();
2957
Niels Möller805a27e2019-01-21 12:21:27 +01002958 webrtc::test::FrameForwarder frame_forwarder;
2959 cricket::FakeFrameSource frame_source(1280, 720,
2960 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002961 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002962 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002963 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2964 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002965
2966 EXPECT_TRUE(channel_->SetSend(true));
2967
Niels Möller805a27e2019-01-21 12:21:27 +01002968 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002969 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2970 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2971
2972 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2973
2974 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002975 webrtc::VideoEncoderConfig encoder_config =
2976 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002977 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002978 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002979 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002980 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2981 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002982 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2983 << "Non-screenshare shouldn't use min-transmit bitrate.";
2984
Niels Möllerff40b142018-04-09 08:49:14 +02002985 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002986 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002987 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002988 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002989 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2990 &frame_forwarder));
2991 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002992 // Send stream recreated after option change.
2993 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2994 send_stream = fake_call_->GetVideoSendStreams().front();
2995 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002996
2997 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002998 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002999 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003000 encoder_config.content_type);
3001 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
3002 encoder_config.min_transmit_bitrate_bps);
3003
perkjfa10b552016-10-02 23:45:26 -07003004 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003005 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
3006 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01003007 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02003008 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003009}
3010
eladalonf1841382017-06-12 01:16:46 -07003011TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003012 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02003013 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08003014 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003015 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003016
3017 AddSendStream();
nisse05103312016-03-16 02:22:50 -07003018 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003019 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003020 webrtc::test::FrameForwarder frame_forwarder;
3021 cricket::FakeFrameSource frame_source(1280, 720,
3022 rtc::kNumMicrosecsPerSec / 30);
3023 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003024 EXPECT_TRUE(channel_->SetSend(true));
3025
Niels Möller805a27e2019-01-21 12:21:27 +01003026 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003027 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3028 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3029
perkj26091b12016-09-01 01:17:40 -07003030 webrtc::VideoEncoderConfig encoder_config =
3031 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003032
3033 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003034 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003035 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003036 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003037
3038 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
3039 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01003040 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003041 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01003042 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003043
Niels Möllerff40b142018-04-09 08:49:14 +02003044 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003045}
3046
eladalonf1841382017-06-12 01:16:46 -07003047TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003048 FakeVideoSendStream* stream = AddSendStream();
3049 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3050}
3051
eladalonf1841382017-06-12 01:16:46 -07003052TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003053 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003054 media_config.video.suspend_below_min_bitrate = true;
3055
Sebastian Jansson84848f22018-11-16 10:40:36 +01003056 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003057 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3058 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003059 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003060
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003061 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003062
3063 FakeVideoSendStream* stream = AddSendStream();
3064 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3065
nisse0db023a2016-03-01 04:29:59 -08003066 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003067 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003068 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3069 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003070 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003071
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003072 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003073
nisse0db023a2016-03-01 04:29:59 -08003074 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003075 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3076}
3077
eladalonf1841382017-06-12 01:16:46 -07003078TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003079 FakeVideoSendStream* stream = AddSendStream();
3080 webrtc::VideoCodecVP8 vp8_settings;
3081 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3082 EXPECT_TRUE(vp8_settings.denoisingOn);
3083}
3084
eladalonf1841382017-06-12 01:16:46 -07003085TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003086 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003087 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003088 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003089
Peter Boström2feafdb2015-09-09 14:32:14 +02003090 // Single-stream settings should apply with RTX as well (verifies that we
3091 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3092 // both RTX and regular SSRCs).
3093 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003094
Niels Möller805a27e2019-01-21 12:21:27 +01003095 webrtc::test::FrameForwarder frame_forwarder;
3096 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003097 channel_->SetSend(true);
3098
Niels Möller805a27e2019-01-21 12:21:27 +01003099 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003100
pbos4cba4eb2015-10-26 11:18:18 -07003101 webrtc::VideoCodecVP8 vp8_settings;
3102 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3103 EXPECT_TRUE(vp8_settings.denoisingOn)
3104 << "VP8 denoising should be on by default.";
3105
Niels Möller805a27e2019-01-21 12:21:27 +01003106 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003107
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003108 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3109 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003110 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3111 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003112
Niels Möller805a27e2019-01-21 12:21:27 +01003113 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003114
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003115 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3116 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003117 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3118 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3119
Niels Möllerff40b142018-04-09 08:49:14 +02003120 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003121 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003122 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003123 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003124 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003125
Mirko Bonadeif859e552018-05-30 15:31:29 +02003126 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003127 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3128 // Autmatic resize off when using simulcast.
3129 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3130 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3131
Florent Castelli66b38602019-07-10 16:57:57 +02003132 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003133 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003134 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003135 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003136
Niels Möller805a27e2019-01-21 12:21:27 +01003137 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003138
Florent Castelli66b38602019-07-10 16:57:57 +02003139 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003140 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3141 EXPECT_FALSE(vp8_settings.denoisingOn);
3142 // Resizing and frame dropping always off for screen sharing.
3143 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3144 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3145
Niels Möller805a27e2019-01-21 12:21:27 +01003146 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003147
3148 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3149 EXPECT_FALSE(vp8_settings.denoisingOn);
3150 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3151 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3152
Niels Möllerff40b142018-04-09 08:49:14 +02003153 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003154}
3155
deadbeef119760a2016-04-04 11:43:27 -07003156// Test that setting the same options doesn't result in the encoder being
3157// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003158TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003159 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003160 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003161
perkjfa10b552016-10-02 23:45:26 -07003162 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003163 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003164 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003165 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3166 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3167
Niels Möller805a27e2019-01-21 12:21:27 +01003168 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3169 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3170 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003171 // Expect 1 reconfigurations at this point from the initial configuration.
3172 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003173
3174 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003175 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003176 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3177
3178 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003179 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003180 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003181 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3182
Niels Möllerff40b142018-04-09 08:49:14 +02003183 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003184}
3185
eladalonf1841382017-06-12 01:16:46 -07003186class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003187 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003188 Vp9SettingsTest() : Vp9SettingsTest("") {}
3189 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003190 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003191 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003192 }
3193 virtual ~Vp9SettingsTest() {}
3194
3195 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003196 void TearDown() override {
3197 // Remove references to encoder_factory_ since this will be destroyed
3198 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003199 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003200 }
Erik Språng143cec12015-04-28 10:01:41 +02003201};
3202
3203TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003204 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003205 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003206 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003207
Peter Boström2feafdb2015-09-09 14:32:14 +02003208 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003209
Niels Möller805a27e2019-01-21 12:21:27 +01003210 webrtc::test::FrameForwarder frame_forwarder;
3211 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003212 channel_->SetSend(true);
3213
Niels Möller805a27e2019-01-21 12:21:27 +01003214 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003215
pbos4cba4eb2015-10-26 11:18:18 -07003216 webrtc::VideoCodecVP9 vp9_settings;
3217 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003218 EXPECT_TRUE(vp9_settings.denoisingOn)
3219 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003220
Niels Möller805a27e2019-01-21 12:21:27 +01003221 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003222
Erik Språng143cec12015-04-28 10:01:41 +02003223 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3224 EXPECT_FALSE(vp9_settings.denoisingOn);
3225 // Frame dropping always on for real time video.
3226 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3227
Niels Möller805a27e2019-01-21 12:21:27 +01003228 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003229
3230 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3231 EXPECT_TRUE(vp9_settings.denoisingOn);
3232 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3233
3234 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003235 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003236 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003237 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003238
Niels Möller805a27e2019-01-21 12:21:27 +01003239 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003240
3241 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3242 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003243 // Frame dropping always on for screen sharing.
3244 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003245
Niels Möller805a27e2019-01-21 12:21:27 +01003246 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003247
3248 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3249 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003250 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003251
Niels Möllerff40b142018-04-09 08:49:14 +02003252 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003253}
3254
Sergey Silkinf18072e2018-03-14 10:35:35 +01003255TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3256 cricket::VideoSendParameters parameters;
3257 parameters.codecs.push_back(GetEngineCodec("VP9"));
3258 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3259
3260 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3261
3262 FakeVideoSendStream* stream =
3263 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3264
3265 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003266
Niels Möller805a27e2019-01-21 12:21:27 +01003267 webrtc::test::FrameForwarder frame_forwarder;
3268 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003269 channel_->SetSend(true);
3270
Niels Möller805a27e2019-01-21 12:21:27 +01003271 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003272
3273 webrtc::VideoCodecVP9 vp9_settings;
3274 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3275
3276 const size_t kNumSpatialLayers = ssrcs.size();
3277 const size_t kNumTemporalLayers = 3;
3278 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3279 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3280
Niels Möllerff40b142018-04-09 08:49:14 +02003281 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003282}
3283
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003284TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3285 cricket::VideoSendParameters parameters;
3286 parameters.codecs.push_back(GetEngineCodec("VP9"));
3287 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3288
3289 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3290
3291 FakeVideoSendStream* stream =
3292 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3293
3294 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3295
3296 // Despite 3 ssrcs provided, single layer is used.
3297 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3298
3299 webrtc::test::FrameForwarder frame_forwarder;
3300 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3301 channel_->SetSend(true);
3302
3303 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3304
3305 webrtc::VideoCodecVP9 vp9_settings;
3306 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3307
3308 const size_t kNumSpatialLayers = ssrcs.size();
3309 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3310
3311 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3312}
3313
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003314TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3315 cricket::VideoSendParameters send_parameters;
3316 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3317 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3318
3319 const size_t kNumSpatialLayers = 3;
3320 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3321
3322 FakeVideoSendStream* stream =
3323 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3324
3325 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3326 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3327 ASSERT_TRUE(parameters.encodings[0].active);
3328 ASSERT_TRUE(parameters.encodings[1].active);
3329 ASSERT_TRUE(parameters.encodings[2].active);
3330 // Invert value to verify copying.
3331 parameters.encodings[1].active = false;
3332 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3333
3334 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3335
3336 // number_of_streams should be 1 since all spatial layers are sent on the
3337 // same SSRC. But encoding parameters of all layers is supposed to be copied
3338 // and stored in simulcast_layers[].
3339 EXPECT_EQ(1u, encoder_config.number_of_streams);
3340 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3341 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3342 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3343 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3344}
3345
Sergey Silkincf267052019-04-09 11:40:09 +02003346class Vp9SettingsTestWithFieldTrial
3347 : public Vp9SettingsTest,
3348 public ::testing::WithParamInterface<
3349 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003350 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003351 Vp9SettingsTestWithFieldTrial()
3352 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3353 num_spatial_layers_(::testing::get<1>(GetParam())),
3354 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003355 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003356
3357 void VerifySettings(int num_spatial_layers,
3358 int num_temporal_layers,
3359 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003360 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003361 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003362 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3363
3364 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3365
Niels Möller805a27e2019-01-21 12:21:27 +01003366 webrtc::test::FrameForwarder frame_forwarder;
3367 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003368 channel_->SetSend(true);
3369
Niels Möller805a27e2019-01-21 12:21:27 +01003370 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003371
3372 webrtc::VideoCodecVP9 vp9_settings;
3373 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3374 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3375 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003376 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003377
Niels Möllerff40b142018-04-09 08:49:14 +02003378 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003379 }
Sergey Silkincf267052019-04-09 11:40:09 +02003380
3381 const uint8_t num_spatial_layers_;
3382 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003383 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003384};
3385
Sergey Silkincf267052019-04-09 11:40:09 +02003386TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003387 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3388 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003389}
3390
Sergey Silkincf267052019-04-09 11:40:09 +02003391INSTANTIATE_TEST_SUITE_P(
3392 ,
3393 Vp9SettingsTestWithFieldTrial,
3394 ::testing::Values(
3395 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3396 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3397 1,
3398 1,
3399 webrtc::InterLayerPredMode::kOnKeyPic),
3400 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3401 2,
3402 3,
3403 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003404 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003405 1,
3406 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003407 webrtc::InterLayerPredMode::kOnKeyPic),
3408 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003409 1,
3410 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003411 webrtc::InterLayerPredMode::kOnKeyPic),
3412 std::make_tuple(
3413 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3414 1,
3415 1,
3416 webrtc::InterLayerPredMode::kOff),
3417 std::make_tuple(
3418 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3419 1,
3420 1,
3421 webrtc::InterLayerPredMode::kOn),
3422 std::make_tuple(
3423 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3424 1,
3425 1,
3426 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003427
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003428TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3429 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3430 ASSERT_EQ(1u, streams.size());
3431 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3432}
3433
3434TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003435 RTC_DCHECK(!override_field_trials_);
3436 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003437 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3438 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3439 ASSERT_EQ(1u, streams.size());
3440 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3441}
3442
asapersson3c81a1a2017-06-14 05:52:21 -07003443TEST_F(WebRtcVideoChannelTest,
3444 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003445 RTC_DCHECK(!override_field_trials_);
3446 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003447 "WebRTC-Video-BalancedDegradation/Disabled/");
3448 const bool kResolutionScalingEnabled = true;
3449 const bool kFpsScalingEnabled = false;
3450 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3451}
3452
3453TEST_F(WebRtcVideoChannelTest,
3454 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003455 RTC_DCHECK(!override_field_trials_);
3456 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003457 "WebRTC-Video-BalancedDegradation/Enabled/");
3458 const bool kResolutionScalingEnabled = true;
3459 const bool kFpsScalingEnabled = true;
3460 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3461}
3462
eladalonf1841382017-06-12 01:16:46 -07003463TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003464 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003465}
3466
eladalonf1841382017-06-12 01:16:46 -07003467TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003468 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003469}
3470
Niels Möller3de32e62019-01-18 08:42:18 +01003471TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3472 TestCpuAdaptation(false, true);
3473}
3474
eladalonf1841382017-06-12 01:16:46 -07003475TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003476 TestCpuAdaptation(true, true);
3477}
3478
eladalonf1841382017-06-12 01:16:46 -07003479TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003480 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003481 cricket::VideoSendParameters parameters;
3482 parameters.codecs.push_back(codec);
3483
kthelgason2bc68642017-02-07 07:02:22 -08003484 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003485 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003486 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003487 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3488 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003489 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003490 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3491
3492 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003493 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003494
Per766ad3b2016-04-05 15:23:49 +02003495 ASSERT_TRUE(channel_->SetSend(true));
3496 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003497 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003498 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003499
3500 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3501 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003502
Niels Möllerdcc70292019-01-15 16:32:38 +01003503 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3504 // Dont' expect anything on framerate_scaling_enabled, since the default is
3505 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003506
Niels Möllerdcc70292019-01-15 16:32:38 +01003507 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003508 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003509 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003510 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003511 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3512 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003513 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003514
Niels Möllerdcc70292019-01-15 16:32:38 +01003515 // Switch back to the normal capturer. Expect resolution scaling to be
3516 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003517 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3518 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003519 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3520 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003521 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003522
Niels Möllerff40b142018-04-09 08:49:14 +02003523 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003524}
3525
asapersson3c81a1a2017-06-14 05:52:21 -07003526// TODO(asapersson): Remove this test when the balanced field trial is removed.
3527void WebRtcVideoChannelTest::TestDegradationPreference(
3528 bool resolution_scaling_enabled,
3529 bool fps_scaling_enabled) {
3530 cricket::VideoCodec codec = GetEngineCodec("VP8");
3531 cricket::VideoSendParameters parameters;
3532 parameters.codecs.push_back(codec);
3533
3534 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003535 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003536 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003537 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3538 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003539 channel_->OnReadyToSend(true);
3540
3541 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3542
3543 AddSendStream();
3544
Niels Möller805a27e2019-01-21 12:21:27 +01003545 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003546 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003547 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003548
3549 EXPECT_TRUE(channel_->SetSend(true));
3550
3551 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3552 EXPECT_EQ(resolution_scaling_enabled,
3553 send_stream->resolution_scaling_enabled());
3554 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3555
Niels Möllerff40b142018-04-09 08:49:14 +02003556 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003557}
3558
eladalonf1841382017-06-12 01:16:46 -07003559void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3560 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003561 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003562 cricket::VideoSendParameters parameters;
3563 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003564
kthelgason2bc68642017-02-07 07:02:22 -08003565 MediaConfig media_config = GetMediaConfig();
3566 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003567 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003568 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003569 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003570 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3571 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003572 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003573
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003574 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003575
3576 AddSendStream();
3577
Niels Möller805a27e2019-01-21 12:21:27 +01003578 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003579 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003580 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003581 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003582
3583 EXPECT_TRUE(channel_->SetSend(true));
3584
solenberge5269742015-09-08 05:13:22 -07003585 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003586
sprangc5d62e22017-04-02 23:53:04 -07003587 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003588 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003589 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003590 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003591 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3592 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3593 } else {
3594 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3595 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3596 }
Niels Möllerff40b142018-04-09 08:49:14 +02003597 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003598}
3599
eladalonf1841382017-06-12 01:16:46 -07003600TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003601 // Start at last timestamp to verify that wraparounds are estimated correctly.
3602 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3603 static const int64_t kInitialNtpTimeMs = 1247891230;
3604 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003605 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003606
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003607 FakeVideoReceiveStream* stream = AddRecvStream();
3608 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003609 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003610
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003611 webrtc::VideoFrame video_frame =
3612 webrtc::VideoFrame::Builder()
3613 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3614 .set_timestamp_rtp(kInitialTimestamp)
3615 .set_timestamp_us(0)
3616 .set_rotation(webrtc::kVideoRotation_0)
3617 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003618 // Initial NTP time is not available on the first frame, but should still be
3619 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003620 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003621
3622 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003623
3624 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3625 // triggers a constant-overflow warning, hence we're calculating it explicitly
3626 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003627 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003628 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3629 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003630 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003631
3632 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003633
3634 // Verify that NTP time has been correctly deduced.
3635 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003636 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003637 ASSERT_EQ(1u, info.receivers.size());
3638 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003639}
3640
eladalonf1841382017-06-12 01:16:46 -07003641TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003642 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003643 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003644
3645 VideoCodec codec;
3646 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003647 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003648
3649 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003650 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3651 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003652 FakeVideoSendStream* stream = AddSendStream(
3653 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003654 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003655
3656 // Make sure NACK and FEC are enabled on the correct payload types.
3657 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003658 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3659 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003660
3661 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3662 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003663 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003664 // TODO(juberti): Check RTCP, PLI, TMMBR.
3665}
3666
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003667TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3668 cricket::VideoSendParameters parameters;
3669 parameters.codecs.push_back(GetEngineCodec("VP8"));
3670 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3671
3672 FakeVideoSendStream* stream = AddSendStream();
3673 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3674 EXPECT_FALSE(config.rtp.raw_payload);
3675}
3676
3677TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3678 cricket::VideoSendParameters parameters;
3679 parameters.codecs.push_back(GetEngineCodec("VP8"));
3680 parameters.codecs.back().packetization = kPacketizationParamRaw;
3681 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3682
3683 FakeVideoSendStream* stream = AddSendStream();
3684 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3685 EXPECT_TRUE(config.rtp.raw_payload);
3686}
3687
brandtr31bd2242017-05-19 05:47:46 -07003688// The following four tests ensures that FlexFEC is not activated by default
3689// when the field trials are not enabled.
3690// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3691// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003692TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003693 FakeVideoSendStream* stream = AddSendStream();
3694 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3695
brandtr3d200bd2017-01-16 06:59:19 -08003696 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003697 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3698 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003699}
3700
eladalonf1841382017-06-12 01:16:46 -07003701TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003702 FakeVideoSendStream* stream = AddSendStream(
3703 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3704 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3705
brandtr3d200bd2017-01-16 06:59:19 -08003706 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003707 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3708 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3709}
3710
Yves Gerey665174f2018-06-19 15:03:05 +02003711TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003712 AddRecvStream();
3713
3714 const std::vector<FakeFlexfecReceiveStream*>& streams =
3715 fake_call_->GetFlexfecReceiveStreams();
3716 EXPECT_TRUE(streams.empty());
3717}
3718
eladalonf1841382017-06-12 01:16:46 -07003719TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003720 AddRecvStream(
3721 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3722
3723 const std::vector<FakeFlexfecReceiveStream*>& streams =
3724 fake_call_->GetFlexfecReceiveStreams();
3725 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003726}
3727
3728// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3729// tests that use this test fixture into the corresponding "non-field trial"
3730// tests.
eladalonf1841382017-06-12 01:16:46 -07003731class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003732 public:
eladalonf1841382017-06-12 01:16:46 -07003733 WebRtcVideoChannelFlexfecRecvTest()
3734 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003735};
3736
eladalonf1841382017-06-12 01:16:46 -07003737TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003738 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3739 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3740 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3741}
3742
eladalonf1841382017-06-12 01:16:46 -07003743TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003744 AddRecvStream();
3745
3746 const std::vector<FakeFlexfecReceiveStream*>& streams =
3747 fake_call_->GetFlexfecReceiveStreams();
3748 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003749
3750 const std::vector<FakeVideoReceiveStream*>& video_streams =
3751 fake_call_->GetVideoReceiveStreams();
3752 ASSERT_EQ(1U, video_streams.size());
3753 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3754 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3755 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003756}
3757
eladalonf1841382017-06-12 01:16:46 -07003758TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003759 AddRecvStream(
3760 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3761
3762 const std::vector<FakeFlexfecReceiveStream*>& streams =
3763 fake_call_->GetFlexfecReceiveStreams();
3764 ASSERT_EQ(1U, streams.size());
3765 const FakeFlexfecReceiveStream* stream = streams.front();
3766 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3767 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3768 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3769 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3770 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003771
3772 const std::vector<FakeVideoReceiveStream*>& video_streams =
3773 fake_call_->GetVideoReceiveStreams();
3774 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003775 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3776 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003777 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003778 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003779 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003780}
3781
eladalonf1841382017-06-12 01:16:46 -07003782TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003783 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3784 cricket::VideoRecvParameters recv_parameters;
3785 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3786 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3787
3788 AddRecvStream(
3789 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3790 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003791 const std::vector<FakeVideoReceiveStream*>& video_streams =
3792 fake_call_->GetVideoReceiveStreams();
3793 ASSERT_EQ(1U, video_streams.size());
3794 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3795 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3796 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003797
3798 // Enable FlexFEC.
3799 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3800 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3801 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3802 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3803 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3804 << "Enabling FlexFEC should not create VideoReceiveStream.";
3805 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3806 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003807 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3808 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003809}
3810
eladalonf1841382017-06-12 01:16:46 -07003811TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003812 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3813 cricket::VideoRecvParameters recv_parameters;
3814 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3815 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3816 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3817
3818 AddRecvStream(
3819 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3820 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003821 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003822 const std::vector<FakeVideoReceiveStream*>& video_streams =
3823 fake_call_->GetVideoReceiveStreams();
3824 ASSERT_EQ(1U, video_streams.size());
3825 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3826 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3827 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003828
3829 // Disable FlexFEC.
3830 recv_parameters.codecs.clear();
3831 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3832 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3833 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3834 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3835 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3836 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3837 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3838 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003839 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3840 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003841}
3842
brandtr31bd2242017-05-19 05:47:46 -07003843// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3844// tests that use this test fixture into the corresponding "non-field trial"
3845// tests.
eladalonf1841382017-06-12 01:16:46 -07003846class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003847 public:
eladalonf1841382017-06-12 01:16:46 -07003848 WebRtcVideoChannelFlexfecSendRecvTest()
3849 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003850 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3851 }
3852};
3853
Yves Gerey665174f2018-06-19 15:03:05 +02003854TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003855 FakeVideoSendStream* stream = AddSendStream();
3856 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3857
brandtr3d200bd2017-01-16 06:59:19 -08003858 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3859 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3860 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003861}
3862
eladalonf1841382017-06-12 01:16:46 -07003863TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003864 FakeVideoSendStream* stream = AddSendStream(
3865 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3866 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3867
brandtr3d200bd2017-01-16 06:59:19 -08003868 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3869 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3870 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3871 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003872}
3873
eladalonf1841382017-06-12 01:16:46 -07003874TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003875 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003876 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003877 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003878
3879 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003880 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003881
brandtrb5f2c3f2016-10-04 23:28:39 -07003882 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3883 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003884}
3885
eladalonf1841382017-06-12 01:16:46 -07003886TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003887 cricket::VideoSendParameters parameters;
3888 parameters.codecs.push_back(GetEngineCodec("VP8"));
3889 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3890
3891 FakeVideoSendStream* stream = AddSendStream();
3892 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3893
brandtr3d200bd2017-01-16 06:59:19 -08003894 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003895}
3896
eladalonf1841382017-06-12 01:16:46 -07003897TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003898 AddRecvStream(
3899 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003900
3901 cricket::VideoRecvParameters recv_parameters;
3902 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3903 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3904 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003905
3906 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3907 fake_call_->GetFlexfecReceiveStreams();
3908 ASSERT_EQ(1U, flexfec_streams.size());
3909 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3910 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3911 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003912 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003913 flexfec_stream_config.payload_type);
3914 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3915 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3916 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3917 const std::vector<FakeVideoReceiveStream*>& video_streams =
3918 fake_call_->GetVideoReceiveStreams();
3919 const FakeVideoReceiveStream* video_stream = video_streams.front();
3920 const webrtc::VideoReceiveStream::Config& video_stream_config =
3921 video_stream->GetConfig();
3922 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3923 flexfec_stream_config.local_ssrc);
3924 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3925 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3926 flexfec_stream_config.rtcp_send_transport);
3927 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3928 // spec-compliant way.
3929 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3930 flexfec_stream_config.transport_cc);
3931 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3932 EXPECT_EQ(video_stream_config.rtp.extensions,
3933 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003934}
3935
brandtr31bd2242017-05-19 05:47:46 -07003936// We should not send FlexFEC, even if we advertise it, unless the right
3937// field trial is set.
3938// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003939TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003940 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3941 cricket::VideoSendParameters parameters;
3942 parameters.codecs.push_back(GetEngineCodec("VP8"));
3943 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3944 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3945
3946 FakeVideoSendStream* stream = AddSendStream();
3947 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3948
3949 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003950 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003951 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3952}
3953
eladalonf1841382017-06-12 01:16:46 -07003954TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003955 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3956 cricket::VideoSendParameters parameters;
3957 parameters.codecs.push_back(GetEngineCodec("VP8"));
3958 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3959 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3960
3961 FakeVideoSendStream* stream = AddSendStream(
3962 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3963 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3964
3965 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003966 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003967 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3968}
3969
eladalonf1841382017-06-12 01:16:46 -07003970TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003971 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003972 const int kUnusedPayloadType = 127;
3973 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3974
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003975 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003976 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003977 parameters.codecs.push_back(rtx_codec);
3978 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003979 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003980}
3981
eladalonf1841382017-06-12 01:16:46 -07003982TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003983 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003984 const int kUnusedPayloadType1 = 126;
3985 const int kUnusedPayloadType2 = 127;
3986 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3987 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3988 {
3989 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3990 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3991 cricket::VideoSendParameters parameters;
3992 parameters.codecs.push_back(GetEngineCodec("VP8"));
3993 parameters.codecs.push_back(rtx_codec);
3994 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3995 }
3996 {
3997 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3998 kUnusedPayloadType1, kUnusedPayloadType2);
3999 cricket::VideoSendParameters parameters;
4000 parameters.codecs.push_back(GetEngineCodec("VP8"));
4001 parameters.codecs.push_back(rtx_codec);
4002 EXPECT_FALSE(channel_->SetSendParameters(parameters))
4003 << "RTX without matching video codec should be rejected.";
4004 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004005}
4006
eladalonf1841382017-06-12 01:16:46 -07004007TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004008 const int kUnusedPayloadType1 = 126;
4009 const int kUnusedPayloadType2 = 127;
4010 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4011 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4012
4013 // SSRCs for RTX.
4014 cricket::StreamParams params =
4015 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4016 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4017 AddSendStream(params);
4018
4019 // Original payload type for RTX.
4020 cricket::VideoSendParameters parameters;
4021 parameters.codecs.push_back(GetEngineCodec("VP8"));
4022 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4023 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4024 parameters.codecs.push_back(rtx_codec);
4025 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4026 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4027 const webrtc::VideoSendStream::Config& config_before =
4028 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4029 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
4030 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
4031 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
4032
4033 // Change payload type for RTX.
4034 parameters.codecs[1].id = kUnusedPayloadType2;
4035 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4036 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4037 const webrtc::VideoSendStream::Config& config_after =
4038 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4039 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
4040 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
4041 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
4042}
4043
eladalonf1841382017-06-12 01:16:46 -07004044TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004045 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004046 parameters.codecs.push_back(GetEngineCodec("VP8"));
4047 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004048 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004049
4050 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004051 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004052
magjed509e4fe2016-11-18 01:34:11 -08004053 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004054
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004055 parameters.codecs.pop_back();
4056 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004057 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004058 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004059 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004060 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004061 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4062}
4063
eladalonf1841382017-06-12 01:16:46 -07004064TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004065 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004066 cricket::VideoSendParameters parameters;
4067 parameters.codecs.push_back(GetEngineCodec("VP8"));
4068 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4069 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4070
4071 FakeVideoSendStream* stream = AddSendStream(
4072 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4073 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4074
brandtr3d200bd2017-01-16 06:59:19 -08004075 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4076 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004077 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4078 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4079
4080 parameters.codecs.pop_back();
4081 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4082 stream = fake_call_->GetVideoSendStreams()[0];
4083 ASSERT_TRUE(stream != nullptr);
4084 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004085 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004086 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004087}
4088
eladalonf1841382017-06-12 01:16:46 -07004089TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004090 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004091 cricket::VideoCodec codec(100, "VP8");
4092 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4093 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004094
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004095 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004096 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004097
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004098 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004099 webrtc::test::FrameForwarder frame_forwarder;
4100 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004101
4102 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004103 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004104
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004105 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004106 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4107 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004108 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004109 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004110 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004111 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004112}
4113
eladalonf1841382017-06-12 01:16:46 -07004114TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004115 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4116 200000);
4117}
4118
eladalonf1841382017-06-12 01:16:46 -07004119TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004120 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4121 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4122 ASSERT_EQ(1u, streams.size());
4123 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4124}
4125
eladalonf1841382017-06-12 01:16:46 -07004126TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004127 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004128 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004129}
4130
eladalonf1841382017-06-12 01:16:46 -07004131TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004132 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004133}
4134
eladalonf1841382017-06-12 01:16:46 -07004135TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004136 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4137 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4138 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004139}
4140
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004141// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4142// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004143TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004144 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4145 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4146 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4147 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004148 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004149 ExpectSetBitrateParameters(100000, 200000, 400000);
4150 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4151 // Since the codec isn't changing, start_bitrate_bps should be -1.
4152 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004153
4154 // Decrease max_bandwidth_bps.
4155 send_parameters_.max_bandwidth_bps = 350000;
4156 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004157
4158 // Now try again with the values flipped around.
4159 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4160 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004161 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004162 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004163
4164 // If we change the codec max, max_bandwidth_bps should still apply.
4165 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004166 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004167 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004168}
4169
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004170// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4171// are present in the same send parameters, the settings are combined correctly.
4172TEST_F(WebRtcVideoChannelTest,
4173 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4174 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4175 // Transport.
4176 webrtc::MediaTransportSettings settings;
4177 settings.is_caller = true;
4178 webrtc::FakeMediaTransport fake_media_transport(settings);
4179 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4180 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004181 channel_->SetInterface(network_interface.get(),
4182 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004183
4184 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4185 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4186 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4187 send_parameters_.max_bandwidth_bps = 400000;
4188 {
4189 // We expect max_bandwidth_bps to take priority, if set.
4190 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4191 ASSERT_EQ(1u,
4192 fake_media_transport.target_rate_constraints_in_order().size());
4193 const webrtc::MediaTransportTargetRateConstraints& constraint =
4194 fake_media_transport.target_rate_constraints_in_order()[0];
4195 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4196 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4197 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4198 }
4199
4200 {
4201 // Decrease max_bandwidth_bps.
4202 send_parameters_.max_bandwidth_bps = 350000;
4203 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4204 ASSERT_EQ(2u,
4205 fake_media_transport.target_rate_constraints_in_order().size());
4206 const webrtc::MediaTransportTargetRateConstraints& constraint =
4207 fake_media_transport.target_rate_constraints_in_order()[1];
4208
4209 // Since the codec isn't changing, start_bitrate_bps should be 0.
4210 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4211 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4212 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4213 }
4214
4215 {
4216 // Now try again with the values flipped around.
4217 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4218 send_parameters_.max_bandwidth_bps = 300000;
4219 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4220 ASSERT_EQ(3u,
4221 fake_media_transport.target_rate_constraints_in_order().size());
4222 const webrtc::MediaTransportTargetRateConstraints& constraint =
4223 fake_media_transport.target_rate_constraints_in_order()[2];
4224
4225 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4226 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4227 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4228 }
4229
4230 {
4231 // Now try again with the values flipped around.
4232 // If we change the codec max, max_bandwidth_bps should still apply.
4233 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4234 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4235 ASSERT_EQ(4u,
4236 fake_media_transport.target_rate_constraints_in_order().size());
4237 const webrtc::MediaTransportTargetRateConstraints& constraint =
4238 fake_media_transport.target_rate_constraints_in_order()[3];
4239
4240 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4241 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4242 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4243 }
4244}
4245
Yves Gerey665174f2018-06-19 15:03:05 +02004246TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004247 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4248 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004249 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004250 // Setting max bitrate should keep previous min bitrate.
4251 // Setting max bitrate should not reset start bitrate.
4252 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004253 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004254}
4255
eladalonf1841382017-06-12 01:16:46 -07004256TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004257 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004258 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004259 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004260 // -1 means to disable max bitrate (set infinite).
4261 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004262 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004263 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004264}
4265
eladalonf1841382017-06-12 01:16:46 -07004266TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004267 send_parameters_.max_bandwidth_bps = 99999;
4268 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004269 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004270 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004271 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4272 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4273 stream->GetVideoStreams()[0].max_bitrate_bps);
4274
4275 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004276 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004277 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4278 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004279 stream->GetVideoStreams()[0].max_bitrate_bps);
4280}
4281
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004282// Tests that when the codec specific max bitrate and VideoSendParameters
4283// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4284// appropriately.
4285TEST_F(WebRtcVideoChannelTest,
4286 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4287 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4288 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4289 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4290 send_parameters_.max_bandwidth_bps = -1;
4291 AddSendStream();
4292 ExpectSetMaxBitrate(300000);
4293 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4294
4295 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4296 ASSERT_EQ(1u, video_send_streams.size());
4297 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4298 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4299 // First the max bitrate is set based upon the codec param.
4300 EXPECT_EQ(300000,
4301 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4302
4303 // The VideoSendParameters max bitrate overrides the codec's.
4304 send_parameters_.max_bandwidth_bps = 500000;
4305 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4306 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4307 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4308 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4309}
4310
4311// Tests that when the codec specific max bitrate and RtpParameters
4312// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4313// appropriately.
4314TEST_F(WebRtcVideoChannelTest,
4315 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4316 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4317 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4318 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4319 send_parameters_.max_bandwidth_bps = -1;
4320 AddSendStream();
4321 ExpectSetMaxBitrate(300000);
4322 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4323
4324 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4325 ASSERT_EQ(1u, video_send_streams.size());
4326 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4327 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4328 // First the max bitrate is set based upon the codec param.
4329 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4330
4331 // The RtpParameter max bitrate overrides the codec's.
4332 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4333 ASSERT_EQ(1u, parameters.encodings.size());
4334 parameters.encodings[0].max_bitrate_bps = 500000;
4335 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4336 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4337 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4338 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4339}
4340
Åsa Persson55659812018-06-18 17:51:32 +02004341TEST_F(WebRtcVideoChannelTest,
4342 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4343 send_parameters_.max_bandwidth_bps = 99999;
4344 FakeVideoSendStream* stream = AddSendStream();
4345 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4346 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4347 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4348 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4349 stream->GetVideoStreams()[0].max_bitrate_bps);
4350
4351 // Get and set the rtp encoding parameters.
4352 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4353 EXPECT_EQ(1u, parameters.encodings.size());
4354
4355 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4356 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4357 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4358 stream->GetVideoStreams()[0].max_bitrate_bps);
4359
4360 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4361 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4362 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4363 stream->GetVideoStreams()[0].max_bitrate_bps);
4364}
4365
eladalonf1841382017-06-12 01:16:46 -07004366TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004367 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004368 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004369 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004370 channel_->SetSend(true);
4371
4372 FakeVideoSendStream* stream = AddSendStream();
4373
Niels Möller805a27e2019-01-21 12:21:27 +01004374 webrtc::test::FrameForwarder frame_forwarder;
4375 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004376
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004377 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4378 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4379 EXPECT_GT(initial_max_bitrate_bps, 0);
4380
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004381 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4382 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004383 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004384 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004385 streams = stream->GetVideoStreams();
4386 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004387 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004388}
4389
eladalonf1841382017-06-12 01:16:46 -07004390TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004391 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004392 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004393 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004394 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004395 channel_->SetSend(true);
4396
4397 FakeVideoSendStream* stream = AddSendStream(
4398 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4399
4400 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004401 webrtc::test::FrameForwarder frame_forwarder;
4402 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4403 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004404
4405 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4406 ASSERT_GT(streams.size(), 1u)
4407 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004408 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004409 EXPECT_GT(initial_max_bitrate_bps, 0);
4410
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004411 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4412 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004413 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004414 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004415 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004416 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004417 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4418
Niels Möllerff40b142018-04-09 08:49:14 +02004419 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004420}
4421
eladalonf1841382017-06-12 01:16:46 -07004422TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004423 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004424 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004425 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004426 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4427 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004428 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004429 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004430
4431 VideoCodec codec;
4432 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4433 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4434}
4435
eladalonf1841382017-06-12 01:16:46 -07004436TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004437 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004438 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004439 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004440 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004441 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004442 parameters.codecs[0].id = kIncorrectPayloads[i];
4443 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004444 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004445 }
4446}
4447
eladalonf1841382017-06-12 01:16:46 -07004448TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004449 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004450 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004451 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004452 parameters.codecs[0].id = payload_type;
4453 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004454 << "Payload type '" << payload_type << "' rejected.";
4455 }
4456}
4457
deadbeef67cf2c12016-04-13 10:07:16 -07004458// Test that setting the a different set of codecs but with an identical front
4459// codec doesn't result in the stream being recreated.
4460// This may happen when a subsequent negotiation includes fewer codecs, as a
4461// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004462TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004463 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4464 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004465 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4466 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004467 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4468
4469 AddSendStream();
4470 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4471
4472 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004473 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004474 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4475 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4476}
4477
eladalonf1841382017-06-12 01:16:46 -07004478TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004479 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004480 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004481 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004482}
4483
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004484// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004485TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004486 const int kUnusedPayloadType1 = 126;
4487 const int kUnusedPayloadType2 = 127;
4488 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4489 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4490
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004491 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004492 parameters.codecs.push_back(GetEngineCodec("VP8"));
4493 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004494 parameters.codecs.push_back(rtx_codec);
4495 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004496 << "RTX codec without associated payload should be rejected.";
4497
magjed509e4fe2016-11-18 01:34:11 -08004498 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004499 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004500 << "RTX codec with invalid associated payload type should be rejected.";
4501
magjed509e4fe2016-11-18 01:34:11 -08004502 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004503 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004504
magjed509e4fe2016-11-18 01:34:11 -08004505 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004506 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004507 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004508
Yves Gerey665174f2018-06-19 15:03:05 +02004509 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4510 << "RTX codec with another RTX as associated payload type should be "
4511 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004512}
4513
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004514TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4515 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4516 vp8_codec.packetization = kPacketizationParamRaw;
4517
4518 cricket::VideoRecvParameters parameters;
4519 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4520 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4521
4522 const cricket::StreamParams params =
4523 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4524 AddRecvStream(params);
4525 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4526
4527 const webrtc::VideoReceiveStream::Config& config =
4528 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4529 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4530 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4531}
4532
4533TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4534 cricket::VideoRecvParameters parameters;
4535 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4536 parameters.codecs.back().packetization = kPacketizationParamRaw;
4537 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4538
4539 const cricket::StreamParams params =
4540 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4541 AddRecvStream(params);
4542 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4543 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4544
4545 parameters.codecs.back().packetization.reset();
4546 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4547 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4548}
4549
eladalonf1841382017-06-12 01:16:46 -07004550TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004551 const int kUnusedPayloadType1 = 126;
4552 const int kUnusedPayloadType2 = 127;
4553 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4554 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4555
4556 // SSRCs for RTX.
4557 cricket::StreamParams params =
4558 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4559 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4560 AddRecvStream(params);
4561
4562 // Original payload type for RTX.
4563 cricket::VideoRecvParameters parameters;
4564 parameters.codecs.push_back(GetEngineCodec("VP8"));
4565 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4566 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4567 parameters.codecs.push_back(rtx_codec);
4568 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4569 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4570 const webrtc::VideoReceiveStream::Config& config_before =
4571 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004572 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4573 const int* payload_type_before = FindKeyByValue(
4574 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4575 ASSERT_NE(payload_type_before, nullptr);
4576 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004577 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4578
4579 // Change payload type for RTX.
4580 parameters.codecs[1].id = kUnusedPayloadType2;
4581 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4582 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4583 const webrtc::VideoReceiveStream::Config& config_after =
4584 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004585 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4586 const int* payload_type_after = FindKeyByValue(
4587 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4588 ASSERT_NE(payload_type_after, nullptr);
4589 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004590 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4591}
4592
eladalonf1841382017-06-12 01:16:46 -07004593TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004594 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004595 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004596 parameters.codecs[0].id = 99;
4597 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004598}
4599
eladalonf1841382017-06-12 01:16:46 -07004600TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004601 cricket::VideoRecvParameters parameters;
4602 parameters.codecs = engine_.codecs();
4603 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004604
4605 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004606 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004607 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004608 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004609}
4610
eladalonf1841382017-06-12 01:16:46 -07004611TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004612 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004613 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004614 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004615 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004616}
4617
eladalonf1841382017-06-12 01:16:46 -07004618TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004619 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004620 parameters.codecs.push_back(GetEngineCodec("VP8"));
4621 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004622 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004623}
4624
eladalonf1841382017-06-12 01:16:46 -07004625TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004626 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004627 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4628 send_parameters.codecs.push_back(GetEngineCodec("red"));
4629 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004630 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004631
4632 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004633
magjed509e4fe2016-11-18 01:34:11 -08004634 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004635 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004636
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004637 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004638 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004639 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004640 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004641 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004642 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004643 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4644}
4645
eladalonf1841382017-06-12 01:16:46 -07004646TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004647 AddRecvStream(
4648 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004649 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004650 fake_call_->GetFlexfecReceiveStreams();
4651
4652 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004653 const FakeFlexfecReceiveStream* stream = streams.front();
4654 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4655 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4656 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4657 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004658
4659 cricket::VideoRecvParameters recv_parameters;
4660 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4661 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4662 EXPECT_TRUE(streams.empty())
4663 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004664}
4665
eladalonf1841382017-06-12 01:16:46 -07004666TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004667 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004668 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004669 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004670
4671 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004672 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4673 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4674 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004675 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4676 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004677 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004678 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004679 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004680 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004681
4682 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004683 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4684 send_parameters.codecs.push_back(GetEngineCodec("red"));
4685 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004686 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4687 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004688 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004689 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004690 << "ULPFEC should be enabled on the receive stream.";
4691}
4692
eladalonf1841382017-06-12 01:16:46 -07004693TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004694 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004695 AddRecvStream(
4696 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004697 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004698 fake_call_->GetFlexfecReceiveStreams();
4699
4700 cricket::VideoRecvParameters recv_parameters;
4701 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4702 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4703 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4704 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004705 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004706 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004707 stream_with_recv_params->GetConfig().payload_type);
4708 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004709 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004710 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004711 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004712 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004713
4714 cricket::VideoSendParameters send_parameters;
4715 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4716 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4717 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4718 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004719 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004720 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004721 stream_with_send_params->GetConfig().payload_type);
4722 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004723 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004724 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004725 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004726 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004727}
4728
eladalonf1841382017-06-12 01:16:46 -07004729TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004730 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004731 parameters.codecs.push_back(GetEngineCodec("VP8"));
4732 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004733 parameters.codecs[1].id = parameters.codecs[0].id;
4734 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004735}
4736
eladalonf1841382017-06-12 01:16:46 -07004737TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004738 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004739 cricket::VideoRecvParameters parameters;
4740 parameters.codecs.push_back(GetEngineCodec("VP8"));
4741 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4742 parameters.codecs[1].id = parameters.codecs[0].id;
4743 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4744}
4745
eladalonf1841382017-06-12 01:16:46 -07004746TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004747 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004748 parameters.codecs.push_back(GetEngineCodec("VP8"));
4749 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004750 parameters.codecs[1].id = parameters.codecs[0].id;
4751 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004752}
4753
eladalonf1841382017-06-12 01:16:46 -07004754TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004755 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004756 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004757 parameters.codecs.push_back(GetEngineCodec("VP8"));
4758 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004759 parameters.codecs[1].id += 1;
4760 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004761}
4762
deadbeef67cf2c12016-04-13 10:07:16 -07004763// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004764// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004765TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004766 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004767 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004768 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4769 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004770 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004771
4772 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4773 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4774
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004775 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004776 parameters2.codecs.push_back(GetEngineCodec("red"));
4777 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004778 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004779 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4780}
4781
eladalonf1841382017-06-12 01:16:46 -07004782TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004783 EXPECT_FALSE(AddSendStream()->IsSending());
4784}
4785
eladalonf1841382017-06-12 01:16:46 -07004786TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004787 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004788}
4789
eladalonf1841382017-06-12 01:16:46 -07004790TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004791 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004792 EXPECT_FALSE(stream->IsSending());
4793
4794 // false->true
4795 EXPECT_TRUE(channel_->SetSend(true));
4796 EXPECT_TRUE(stream->IsSending());
4797 // true->true
4798 EXPECT_TRUE(channel_->SetSend(true));
4799 EXPECT_TRUE(stream->IsSending());
4800 // true->false
4801 EXPECT_TRUE(channel_->SetSend(false));
4802 EXPECT_FALSE(stream->IsSending());
4803 // false->false
4804 EXPECT_TRUE(channel_->SetSend(false));
4805 EXPECT_FALSE(stream->IsSending());
4806
4807 EXPECT_TRUE(channel_->SetSend(true));
4808 FakeVideoSendStream* new_stream = AddSendStream();
4809 EXPECT_TRUE(new_stream->IsSending())
4810 << "Send stream created after SetSend(true) not sending initially.";
4811}
4812
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004813// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004814TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004815 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004816 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004817 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004818 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004819 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004820
Sebastian Jansson84848f22018-11-16 10:40:36 +01004821 channel.reset(
4822 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004823 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4824 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004825 channel->SetInterface(network_interface.get(),
4826 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004827 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004828 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004829
Tim Haloun648d28a2018-10-18 16:52:22 -07004830 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4831 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004832 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004833 channel.reset(
4834 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004835 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4836 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004837 channel->SetInterface(network_interface.get(),
4838 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004839 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4840
4841 // Create a send stream to configure
4842 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4843 parameters = channel->GetRtpSendParameters(kSsrc);
4844 ASSERT_FALSE(parameters.encodings.empty());
4845
4846 // Various priorities map to various dscp values.
4847 parameters.encodings[0].network_priority = 4.0;
4848 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004849 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004850 parameters.encodings[0].network_priority = 0.5;
4851 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4852 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4853
4854 // A bad priority does not change the dscp value.
4855 parameters.encodings[0].network_priority = 0.0;
4856 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4857 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004858
Tim Haloun6ca98362018-09-17 17:06:08 -07004859 // Packets should also self-identify their dscp in PacketOptions.
4860 const uint8_t kData[10] = {0};
4861 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4862 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004863 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004864
nisse51542be2016-02-12 02:27:06 -08004865 // Verify that setting the option to false resets the
4866 // DiffServCodePoint.
4867 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004868 channel.reset(
4869 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004870 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4871 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004872 channel->SetInterface(network_interface.get(),
4873 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004874 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004875}
4876
deadbeef13871492015-12-09 12:37:51 -08004877// This test verifies that the RTCP reduced size mode is properly applied to
4878// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004879TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004880 // Create stream, expecting that default mode is "compound".
4881 FakeVideoSendStream* stream1 = AddSendStream();
4882 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004883 webrtc::RtpParameters rtp_parameters =
4884 channel_->GetRtpSendParameters(last_ssrc_);
4885 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004886
4887 // Now enable reduced size mode.
4888 send_parameters_.rtcp.reduced_size = true;
4889 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4890 stream1 = fake_call_->GetVideoSendStreams()[0];
4891 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004892 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4893 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004894
4895 // Create a new stream and ensure it picks up the reduced size mode.
4896 FakeVideoSendStream* stream2 = AddSendStream();
4897 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4898}
4899
4900// This test verifies that the RTCP reduced size mode is properly applied to
4901// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004902TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004903 // Create stream, expecting that default mode is "compound".
4904 FakeVideoReceiveStream* stream1 = AddRecvStream();
4905 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4906
4907 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004908 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4909 // the reduced_size flag should come from that.
4910 send_parameters_.rtcp.reduced_size = true;
4911 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004912 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4913 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4914
4915 // Create a new stream and ensure it picks up the reduced size mode.
4916 FakeVideoReceiveStream* stream2 = AddRecvStream();
4917 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4918}
4919
eladalonf1841382017-06-12 01:16:46 -07004920TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004921 EXPECT_EQ(webrtc::kNetworkUp,
4922 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4923 EXPECT_EQ(webrtc::kNetworkUp,
4924 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004925
4926 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004927 EXPECT_EQ(webrtc::kNetworkDown,
4928 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4929 EXPECT_EQ(webrtc::kNetworkUp,
4930 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004931
4932 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004933 EXPECT_EQ(webrtc::kNetworkUp,
4934 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4935 EXPECT_EQ(webrtc::kNetworkUp,
4936 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004937}
4938
eladalonf1841382017-06-12 01:16:46 -07004939TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004940 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004941 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004942 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004943
4944 AddSendStream();
4945
4946 cricket::VideoMediaInfo info;
4947 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004948 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004949}
4950
eladalonf1841382017-06-12 01:16:46 -07004951TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004952 FakeVideoSendStream* stream = AddSendStream();
4953 webrtc::VideoSendStream::Stats stats;
4954 stats.encoder_implementation_name = "encoder_implementation_name";
4955 stream->SetStats(stats);
4956
4957 cricket::VideoMediaInfo info;
4958 ASSERT_TRUE(channel_->GetStats(&info));
4959 EXPECT_EQ(stats.encoder_implementation_name,
4960 info.senders[0].encoder_implementation_name);
4961}
4962
eladalonf1841382017-06-12 01:16:46 -07004963TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004964 FakeVideoSendStream* stream = AddSendStream();
4965 webrtc::VideoSendStream::Stats stats;
4966 stats.avg_encode_time_ms = 13;
4967 stats.encode_usage_percent = 42;
4968 stream->SetStats(stats);
4969
4970 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004971 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004972 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4973 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4974}
4975
eladalonf1841382017-06-12 01:16:46 -07004976TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004977 FakeVideoSendStream* stream = AddSendStream();
4978 webrtc::VideoSendStream::Stats stats;
4979 stats.frames_encoded = 13;
4980 stream->SetStats(stats);
4981
4982 cricket::VideoMediaInfo info;
4983 ASSERT_TRUE(channel_->GetStats(&info));
4984 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4985}
4986
Rasmus Brandt2efae772019-06-27 14:29:34 +02004987TEST_F(WebRtcVideoChannelTest, GetStatsReportsKeyFramesEncoded) {
4988 FakeVideoSendStream* stream = AddSendStream();
4989 webrtc::VideoSendStream::Stats stats;
4990 stats.substreams[123].frame_counts.key_frames = 10;
4991 stats.substreams[456].frame_counts.key_frames = 87;
4992 stream->SetStats(stats);
4993
4994 cricket::VideoMediaInfo info;
4995 ASSERT_TRUE(channel_->GetStats(&info));
4996 // TODO(bugs.webrtc.org/9547): Populate individual outbound-rtp stats objects
4997 // for each simulcast stream, instead of accumulating all keyframes encoded
4998 // over all simulcast streams in the same outbound-rtp stats object.
4999 EXPECT_EQ(97u, info.senders[0].key_frames_encoded);
5000}
5001
eladalonf1841382017-06-12 01:16:46 -07005002TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07005003 FakeVideoSendStream* stream = AddSendStream();
5004 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01005005 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07005006 stream->SetStats(stats);
5007
5008 cricket::VideoMediaInfo info;
5009 ASSERT_TRUE(channel_->GetStats(&info));
5010 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
5011}
5012
eladalonf1841382017-06-12 01:16:46 -07005013TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005014 FakeVideoSendStream* stream = AddSendStream();
5015 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005016 stats.substreams[17].width = 123;
5017 stats.substreams[17].height = 40;
5018 stats.substreams[42].width = 80;
5019 stats.substreams[42].height = 31;
5020 stats.substreams[11].width = 20;
5021 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005022 stream->SetStats(stats);
5023
5024 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005025 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005026 ASSERT_EQ(1u, info.senders.size());
5027 EXPECT_EQ(123, info.senders[0].send_frame_width);
5028 EXPECT_EQ(90, info.senders[0].send_frame_height);
5029}
5030
eladalonf1841382017-06-12 01:16:46 -07005031TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07005032 FakeVideoSendStream* stream = AddSendStream();
5033 webrtc::VideoSendStream::Stats stats;
5034 stats.number_of_cpu_adapt_changes = 2;
5035 stats.cpu_limited_resolution = true;
5036 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005037
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005038 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005039 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005040 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005041 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005042 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005043}
5044
eladalonf1841382017-06-12 01:16:46 -07005045TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07005046 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08005047 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07005048 stats.number_of_cpu_adapt_changes = 2;
5049 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08005050 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07005051 stream->SetStats(stats);
5052
5053 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08005054 EXPECT_TRUE(channel_->GetStats(&info));
5055 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005056 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
5057 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005058 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005059 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08005060}
5061
eladalonf1841382017-06-12 01:16:46 -07005062TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005063 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5064 FakeVideoSendStream* stream = AddSendStream();
5065 webrtc::VideoSendStream::Stats stats;
5066 stats.bw_limited_resolution = true;
5067 stream->SetStats(stats);
5068
5069 cricket::VideoMediaInfo info;
5070 EXPECT_TRUE(channel_->GetStats(&info));
5071 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005072 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005073 info.senders[0].adapt_reason);
5074}
5075
Yves Gerey665174f2018-06-19 15:03:05 +02005076TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005077 FakeVideoSendStream* stream = AddSendStream();
5078 webrtc::VideoSendStream::Stats stats;
5079 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5080 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5081 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5082
5083 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5084 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5085 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5086
5087 stream->SetStats(stats);
5088
5089 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005090 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005091 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5092 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5093 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5094}
5095
eladalonf1841382017-06-12 01:16:46 -07005096TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005097 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5098 FakeVideoReceiveStream* stream = AddRecvStream();
5099 webrtc::VideoReceiveStream::Stats stats;
5100 stats.rtcp_packet_type_counts.fir_packets = 2;
5101 stats.rtcp_packet_type_counts.nack_packets = 3;
5102 stats.rtcp_packet_type_counts.pli_packets = 4;
5103 stream->SetStats(stats);
5104
5105 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005106 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005107 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005108 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005109 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005110 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005111 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005112 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005113}
5114
eladalonf1841382017-06-12 01:16:46 -07005115TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005116 FakeVideoReceiveStream* stream = AddRecvStream();
5117 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005118 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005119 stats.decode_ms = 2;
5120 stats.max_decode_ms = 3;
5121 stats.current_delay_ms = 4;
5122 stats.target_delay_ms = 5;
5123 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005124 stats.jitter_buffer_delay_seconds = 60;
5125 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005126 stats.min_playout_delay_ms = 7;
5127 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005128 stats.width = 9;
5129 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005130 stats.frame_counts.key_frames = 11;
5131 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005132 stats.frames_rendered = 13;
5133 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005134 stats.qp_sum = 15;
Johannes Kronbfd343b2019-07-01 10:07:50 +02005135 stats.total_decode_time_ms = 16;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005136 stream->SetStats(stats);
5137
5138 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005139 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005140 EXPECT_EQ(stats.decoder_implementation_name,
5141 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005142 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5143 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5144 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5145 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5146 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005147 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5148 info.receivers[0].jitter_buffer_delay_seconds);
5149 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5150 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005151 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5152 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005153 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5154 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005155 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5156 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005157 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005158 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005159 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
Rasmus Brandt2efae772019-06-27 14:29:34 +02005160 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames),
5161 info.receivers[0].key_frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005162 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
Johannes Kronbfd343b2019-07-01 10:07:50 +02005163 EXPECT_EQ(stats.total_decode_time_ms, info.receivers[0].total_decode_time_ms);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005164}
5165
eladalonf1841382017-06-12 01:16:46 -07005166TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02005167 FakeVideoReceiveStream* stream = AddRecvStream();
5168 webrtc::VideoReceiveStream::Stats stats;
5169 stats.rtp_stats.transmitted.payload_bytes = 2;
5170 stats.rtp_stats.transmitted.header_bytes = 3;
5171 stats.rtp_stats.transmitted.padding_bytes = 4;
5172 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07005173 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005174 stats.rtcp_stats.fraction_lost = 7;
5175 stream->SetStats(stats);
5176
5177 cricket::VideoMediaInfo info;
5178 ASSERT_TRUE(channel_->GetStats(&info));
Bjorn A Mellem74a1b4b2019-07-23 06:18:24 -07005179 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005180 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02005181 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005182 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07005183 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02005184}
5185
eladalonf1841382017-06-12 01:16:46 -07005186TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005187 AddSendStream();
5188 AddSendStream();
5189 webrtc::Call::Stats stats;
5190 stats.rtt_ms = 123;
5191 fake_call_->SetStats(stats);
5192
5193 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005194 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005195 ASSERT_EQ(2u, info.senders.size());
5196 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5197 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5198}
5199
eladalonf1841382017-06-12 01:16:46 -07005200TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005201 FakeVideoSendStream* stream = AddSendStream();
5202 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005203 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005204 stats.media_bitrate_bps = 123;
5205 stats.substreams[17].total_bitrate_bps = 1;
5206 stats.substreams[17].retransmit_bitrate_bps = 2;
5207 stats.substreams[42].total_bitrate_bps = 3;
5208 stats.substreams[42].retransmit_bitrate_bps = 4;
5209 stream->SetStats(stats);
5210
5211 FakeVideoSendStream* stream2 = AddSendStream();
5212 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005213 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005214 stats2.media_bitrate_bps = 321;
5215 stats2.substreams[13].total_bitrate_bps = 5;
5216 stats2.substreams[13].retransmit_bitrate_bps = 6;
5217 stats2.substreams[21].total_bitrate_bps = 7;
5218 stats2.substreams[21].retransmit_bitrate_bps = 8;
5219 stream2->SetStats(stats2);
5220
5221 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005222 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005223 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005224 BandwidthEstimationInfo bwe_info;
5225 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005226 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5227 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5228 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5229 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005230 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005231 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005232 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005233 bwe_info.actual_enc_bitrate);
5234 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005235 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005236 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005237 << "Bandwidth stats should take all streams into account.";
5238}
5239
eladalonf1841382017-06-12 01:16:46 -07005240TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005241 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005242
Peter Boström0c4e06b2015-10-07 12:23:21 +02005243 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5244 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005245
5246 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5247 const size_t kDataLength = 12;
5248 uint8_t data[kDataLength];
5249 memset(data, 0, sizeof(data));
5250 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005251 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005252 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005253
5254 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5255 << "No default receive stream created.";
5256 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005257 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005258 << "Default receive stream should not have configured RTX";
5259
5260 EXPECT_TRUE(channel_->AddRecvStream(
5261 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5262 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005263 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005264 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005265 EXPECT_FALSE(
5266 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005267 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005268 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005269 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005270 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005271 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005272 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005273}
5274
eladalonf1841382017-06-12 01:16:46 -07005275TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005276 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005277
Peter Boström0c4e06b2015-10-07 12:23:21 +02005278 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5279 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005280
5281 StreamParams sp =
5282 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5283 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5284
5285 EXPECT_FALSE(channel_->AddSendStream(sp));
5286 EXPECT_FALSE(channel_->AddRecvStream(sp));
5287}
5288
eladalonf1841382017-06-12 01:16:46 -07005289TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005290 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005291
Peter Boström0c4e06b2015-10-07 12:23:21 +02005292 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5293 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005294
5295 StreamParams sp =
5296 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5297
5298 EXPECT_TRUE(channel_->AddSendStream(sp));
5299 EXPECT_TRUE(channel_->AddRecvStream(sp));
5300
5301 // The RTX SSRC is already used in previous streams, using it should fail.
5302 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5303 EXPECT_FALSE(channel_->AddSendStream(sp));
5304 EXPECT_FALSE(channel_->AddRecvStream(sp));
5305
5306 // After removing the original stream this should be fine to add (makes sure
5307 // that RTX ssrcs are not forever taken).
5308 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5309 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5310 EXPECT_TRUE(channel_->AddSendStream(sp));
5311 EXPECT_TRUE(channel_->AddRecvStream(sp));
5312}
5313
eladalonf1841382017-06-12 01:16:46 -07005314TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005315 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005316 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5317 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005318 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005319
Peter Boströmd6f4c252015-03-26 16:23:04 +01005320 StreamParams sp =
5321 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5322
5323 EXPECT_TRUE(channel_->AddSendStream(sp));
5324 EXPECT_TRUE(channel_->AddRecvStream(sp));
5325
5326 // One of the SSRCs is already used in previous streams, using it should fail.
5327 sp = cricket::CreateSimStreamParams("cname",
5328 MAKE_VECTOR(kOverlappingStreamSsrcs));
5329 EXPECT_FALSE(channel_->AddSendStream(sp));
5330 EXPECT_FALSE(channel_->AddRecvStream(sp));
5331
5332 // After removing the original stream this should be fine to add (makes sure
5333 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005334 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5335 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005336 EXPECT_TRUE(channel_->AddSendStream(sp));
5337 EXPECT_TRUE(channel_->AddRecvStream(sp));
5338}
5339
eladalonf1841382017-06-12 01:16:46 -07005340TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005341 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005342
5343 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5344 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5345
5346 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5347 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5348
5349 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5350
5351 static const uint32_t kReceiverSsrcs[] = {3};
5352 static const uint32_t kReceiverRtxSsrcs[] = {2};
5353
5354 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5355 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5356 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5357
5358 cricket::VideoMediaInfo info;
5359 ASSERT_TRUE(channel_->GetStats(&info));
5360
5361 ASSERT_EQ(1u, info.senders.size());
5362 ASSERT_EQ(1u, info.receivers.size());
5363
5364 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5365 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5366 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5367}
5368
eladalonf1841382017-06-12 01:16:46 -07005369TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005370 FakeVideoReceiveStream* stream = AddRecvStream();
5371 webrtc::VideoReceiveStream::Stats stats;
5372 cricket::VideoMediaInfo info;
5373
5374 // Report no codec name before receiving.
5375 stream->SetStats(stats);
5376 ASSERT_TRUE(channel_->GetStats(&info));
5377 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5378
5379 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005380 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005381 stream->SetStats(stats);
5382 ASSERT_TRUE(channel_->GetStats(&info));
5383 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5384
5385 // Report no codec name for unknown playload types.
5386 stats.current_payload_type = 3;
5387 stream->SetStats(stats);
5388 ASSERT_TRUE(channel_->GetStats(&info));
5389 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5390}
5391
Seth Hampson5897a6e2018-04-03 11:16:33 -07005392// Tests that when we add a stream without SSRCs, but contains a stream_id
5393// that it is stored and its stream id is later used when the first packet
5394// arrives to properly create a receive stream with a sync label.
5395TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5396 const char kSyncLabel[] = "sync_label";
5397 cricket::StreamParams unsignaled_stream;
5398 unsignaled_stream.set_stream_ids({kSyncLabel});
5399 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5400 // The stream shouldn't have been created at this point because it doesn't
5401 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005402 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005403
5404 // Create and deliver packet.
5405 const size_t kDataLength = 12;
5406 uint8_t data[kDataLength];
5407 memset(data, 0, sizeof(data));
5408 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5409 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005410 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005411
5412 // The stream should now be created with the appropriate sync label.
5413 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5414 EXPECT_EQ(kSyncLabel,
5415 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5416
5417 // Removing the unsignaled stream should clear the cache. This time when
5418 // a default video receive stream is created it won't have a sync_group.
5419 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5420 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5421 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5422
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005423 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005424 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5425 EXPECT_TRUE(
5426 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5427}
5428
Ruslan Burakov493a6502019-02-27 15:32:48 +01005429// Test BaseMinimumPlayoutDelayMs on receive streams.
5430TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5431 // Test that set won't work for non-existing receive streams.
5432 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5433 // Test that get won't work for non-existing receive streams.
5434 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5435
5436 EXPECT_TRUE(AddRecvStream());
5437 // Test that set works for the existing receive stream.
5438 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5439 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5440 EXPECT_TRUE(recv_stream);
5441 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5442 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5443 200);
5444}
5445
5446// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5447TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5448 absl::optional<int> delay_ms;
5449 const FakeVideoReceiveStream* recv_stream;
5450
5451 // Set default stream with SSRC 0
5452 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5453 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5454
5455 // Spawn an unsignaled stream by sending a packet, it should inherit
5456 // default delay 200.
5457 const size_t kDataLength = 12;
5458 uint8_t data[kDataLength];
5459 memset(data, 0, sizeof(data));
5460 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5461 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005462 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005463
5464 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5465 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5466 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5467 EXPECT_EQ(200, delay_ms.value_or(0));
5468
5469 // Check that now if we change delay for SSRC 0 it will change delay for the
5470 // default receiving stream as well.
5471 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5472 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5473 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5474 EXPECT_EQ(300, delay_ms.value_or(0));
5475 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5476 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5477}
5478
eladalonf1841382017-06-12 01:16:46 -07005479void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005480 uint8_t payload_type,
5481 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005482 // kRedRtxPayloadType must currently be unused.
5483 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5484
noahricd10a68e2015-07-10 11:27:55 -07005485 // Add a RED RTX codec.
5486 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005487 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005488 recv_parameters_.codecs.push_back(red_rtx_codec);
5489 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005490
5491 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5492 const size_t kDataLength = 12;
5493 uint8_t data[kDataLength];
5494 memset(data, 0, sizeof(data));
5495
5496 rtc::Set8(data, 1, payload_type);
5497 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005498 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005499 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005500
5501 if (expect_created_receive_stream) {
5502 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5503 << "Should have created a receive stream for payload type: "
5504 << payload_type;
5505 } else {
5506 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5507 << "Shouldn't have created a receive stream for payload type: "
5508 << payload_type;
5509 }
5510}
5511
Åsa Persson2c7149b2018-10-15 09:36:10 +02005512class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5513 public:
5514 WebRtcVideoChannelDiscardUnknownSsrcTest()
5515 : WebRtcVideoChannelTest(
5516 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5517};
5518
5519TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5520 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5521 false /* expect_created_receive_stream */);
5522}
5523
eladalonf1841382017-06-12 01:16:46 -07005524TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005525 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5526 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005527}
5528
eladalonf1841382017-06-12 01:16:46 -07005529TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005530 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5531 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005532}
5533
eladalonf1841382017-06-12 01:16:46 -07005534TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005535 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005536 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5537 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5538 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5539 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005540}
5541
eladalonf1841382017-06-12 01:16:46 -07005542TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005543 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5544 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005545}
5546
eladalonf1841382017-06-12 01:16:46 -07005547TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005548 FlexfecPacketDoesntCreateUnsignalledStream) {
5549 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5550 false /* expect_created_receive_stream */);
5551}
5552
eladalonf1841382017-06-12 01:16:46 -07005553TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005554 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5555 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005556}
5557
mzanaty8a855d62017-02-17 15:46:43 -08005558// Test that receiving any unsignalled SSRC works even if it changes.
5559// The first unsignalled SSRC received will create a default receive stream.
5560// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005561TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005562 // Allow receiving VP8, VP9, H264 (if enabled).
5563 cricket::VideoRecvParameters parameters;
5564 parameters.codecs.push_back(GetEngineCodec("VP8"));
5565 parameters.codecs.push_back(GetEngineCodec("VP9"));
5566
5567#if defined(WEBRTC_USE_H264)
5568 cricket::VideoCodec H264codec(126, "H264");
5569 parameters.codecs.push_back(H264codec);
5570#endif
5571
5572 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5573 // No receive streams yet.
5574 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5575 cricket::FakeVideoRenderer renderer;
5576 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5577
5578 // Receive VP8 packet on first SSRC.
5579 uint8_t data[kMinRtpPacketLen];
5580 cricket::RtpHeader rtpHeader;
5581 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5582 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005583 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005584 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5585 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005586 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005587 // VP8 packet should create default receive stream.
5588 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005589 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005590 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5591 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005592 webrtc::VideoFrame video_frame =
5593 webrtc::VideoFrame::Builder()
5594 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5595 .set_timestamp_rtp(100)
5596 .set_timestamp_us(0)
5597 .set_rotation(webrtc::kVideoRotation_0)
5598 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005599 recv_stream->InjectFrame(video_frame);
5600 EXPECT_EQ(1, renderer.num_rendered_frames());
5601
5602 // Receive VP9 packet on second SSRC.
5603 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005604 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005605 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5606 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005607 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005608 // VP9 packet should replace the default receive SSRC.
5609 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5610 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5611 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5612 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005613 webrtc::VideoFrame video_frame2 =
5614 webrtc::VideoFrame::Builder()
5615 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5616 .set_timestamp_rtp(200)
5617 .set_timestamp_us(0)
5618 .set_rotation(webrtc::kVideoRotation_0)
5619 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005620 recv_stream->InjectFrame(video_frame2);
5621 EXPECT_EQ(2, renderer.num_rendered_frames());
5622
5623#if defined(WEBRTC_USE_H264)
5624 // Receive H264 packet on third SSRC.
5625 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005626 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005627 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5628 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005629 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005630 // H264 packet should replace the default receive SSRC.
5631 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5632 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5633 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5634 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005635 webrtc::VideoFrame video_frame3 =
5636 webrtc::VideoFrame::Builder()
5637 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5638 .set_timestamp_rtp(300)
5639 .set_timestamp_us(0)
5640 .set_rotation(webrtc::kVideoRotation_0)
5641 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005642 recv_stream->InjectFrame(video_frame3);
5643 EXPECT_EQ(3, renderer.num_rendered_frames());
5644#endif
5645}
5646
brandtr0dc57ea2017-05-29 23:33:31 -07005647// This test verifies that when a new default stream is created for a new
5648// unsignaled SSRC, the new stream does not overwrite any old stream that had
5649// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005650TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005651 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5652 cricket::VideoRecvParameters parameters;
5653 parameters.codecs.push_back(GetEngineCodec("VP8"));
5654 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5655
5656 // No streams signaled and no packets received, so we should not have any
5657 // stream objects created yet.
5658 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5659
5660 // Receive packet on an unsignaled SSRC.
5661 uint8_t data[kMinRtpPacketLen];
5662 cricket::RtpHeader rtp_header;
5663 rtp_header.payload_type = GetEngineCodec("VP8").id;
5664 rtp_header.seq_num = rtp_header.timestamp = 0;
5665 rtp_header.ssrc = kSsrcs3[0];
5666 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5667 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005668 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005669 // Default receive stream should be created.
5670 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5671 FakeVideoReceiveStream* recv_stream0 =
5672 fake_call_->GetVideoReceiveStreams()[0];
5673 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5674
5675 // Signal the SSRC.
5676 EXPECT_TRUE(
5677 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5678 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5679 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5680 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5681
5682 // Receive packet on a different unsignaled SSRC.
5683 rtp_header.ssrc = kSsrcs3[1];
5684 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5685 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005686 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005687 // New default receive stream should be created, but old stream should remain.
5688 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5689 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5690 FakeVideoReceiveStream* recv_stream1 =
5691 fake_call_->GetVideoReceiveStreams()[1];
5692 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5693}
5694
Seth Hampson7c682e02018-05-04 16:28:15 -07005695TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005696 AddSendStream();
5697
Niels Möller805a27e2019-01-21 12:21:27 +01005698 webrtc::test::FrameForwarder frame_forwarder;
5699 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005700 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005701 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005702
perkjfa10b552016-10-02 23:45:26 -07005703 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005704 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005705
5706 // TODO(skvlad): Resolve the inconsistency between the interpretation
5707 // of the global bitrate limit for audio and video:
5708 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5709 // max_bandwidth_bps = -1 - remove the bandwidth limit
5710 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005711 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005712
perkjfa10b552016-10-02 23:45:26 -07005713 SetAndExpectMaxBitrate(1000, 0, 1000);
5714 SetAndExpectMaxBitrate(1000, 800, 800);
5715 SetAndExpectMaxBitrate(600, 800, 600);
5716 SetAndExpectMaxBitrate(0, 800, 800);
5717 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005718
Niels Möllerff40b142018-04-09 08:49:14 +02005719 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005720}
5721
eladalonf1841382017-06-12 01:16:46 -07005722TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005723 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005724 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005725 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005726
5727 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005728 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005729 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005730}
5731
eladalonf1841382017-06-12 01:16:46 -07005732TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005733 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005734 FakeVideoSendStream* stream = AddSendStream();
5735
Seth Hampson7c682e02018-05-04 16:28:15 -07005736 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5737 EXPECT_EQ(1UL, parameters.encodings.size());
5738 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5739 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5740
5741 // Note that this is testing the behavior of the FakeVideoSendStream, which
5742 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5743 // we are just testing the behavior of
5744 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005745 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5746 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005747
5748 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5749 // by this amount.
5750 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5751 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5752 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5753 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5754
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005755 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5756 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5757 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5758}
5759
5760TEST_F(WebRtcVideoChannelTest,
5761 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5762 FakeVideoSendStream* stream = AddSendStream();
5763
5764 // Note that this is testing the behavior of the FakeVideoSendStream, which
5765 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5766 // we are just testing the behavior of
5767 // EncoderStreamFactory::CreateEncoderStreams.
5768 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5769 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5770
5771 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5772 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5773 EXPECT_EQ(1UL, parameters.encodings.size());
5774 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5775 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5776
5777 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5778 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5779 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5780}
5781
5782TEST_F(WebRtcVideoChannelTest,
5783 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5784 send_parameters_.max_bandwidth_bps = 99999;
5785 FakeVideoSendStream* stream = AddSendStream();
5786 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5787 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5788 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5789 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5790 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5791 stream->GetVideoStreams()[0].max_bitrate_bps);
5792
5793 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5794 // adjusted down.
5795 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5796 EXPECT_EQ(1UL, parameters.encodings.size());
5797 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5798 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5799 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5800 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5801 stream->GetVideoStreams()[0].min_bitrate_bps);
5802 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5803 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005804}
5805
Åsa Persson8c1bf952018-09-13 10:42:19 +02005806TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5807 FakeVideoSendStream* stream = AddSendStream();
5808
5809 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5810 EXPECT_EQ(1UL, parameters.encodings.size());
5811 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5812 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5813
5814 // Note that this is testing the behavior of the FakeVideoSendStream, which
5815 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5816 // we are just testing the behavior of
5817 // EncoderStreamFactory::CreateEncoderStreams.
5818 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5819 EXPECT_EQ(kDefaultVideoMaxFramerate,
5820 stream->GetVideoStreams()[0].max_framerate);
5821
5822 // Set max framerate and check that VideoStream.max_framerate is set.
5823 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5824 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5825 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5826 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5827
5828 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5829 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5830}
5831
Åsa Persson23eba222018-10-02 14:47:06 +02005832TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5833 FakeVideoSendStream* stream = AddSendStream();
5834
5835 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5836 EXPECT_EQ(1UL, parameters.encodings.size());
5837 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5838 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5839
5840 // Note that this is testing the behavior of the FakeVideoSendStream, which
5841 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5842 // we are just testing the behavior of
5843 // EncoderStreamFactory::CreateEncoderStreams.
5844 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5845 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5846
5847 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5848 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5849 parameters.encodings[0].num_temporal_layers = 2;
5850 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5851
5852 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5853 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5854}
5855
Seth Hampson7c682e02018-05-04 16:28:15 -07005856TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005857 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005858 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005859 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005860 // Two or more encodings should result in failure.
5861 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005862 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005863 // Zero encodings should also fail.
5864 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005865 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005866}
5867
Zach Stein3ca452b2018-01-18 10:01:24 -08005868TEST_F(WebRtcVideoChannelTest,
5869 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5870 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5871 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5872 AddSendStream(sp);
5873
5874 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5875
5876 // Additional encodings should result in failure.
5877 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005878 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005879 // Zero encodings should also fail.
5880 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005881 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005882}
5883
deadbeeffb2aced2017-01-06 23:05:37 -08005884// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005885TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005886 AddSendStream();
5887 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005888 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005889 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005890}
5891
Seth Hampson24722b32017-12-22 09:36:42 -08005892// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5893// a value <= 0, setting the parameters returns false.
5894TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5895 AddSendStream();
5896 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5897 EXPECT_EQ(1UL, parameters.encodings.size());
5898 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5899 parameters.encodings[0].bitrate_priority);
5900
5901 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005902 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005903 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005904 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005905}
5906
5907// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5908// properly on the VideoChannel and propogates down to the video encoder.
5909TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5910 AddSendStream();
5911 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5912 EXPECT_EQ(1UL, parameters.encodings.size());
5913 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5914 parameters.encodings[0].bitrate_priority);
5915
5916 // Change the value and set it on the VideoChannel.
5917 double new_bitrate_priority = 2.0;
5918 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005919 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005920
5921 // Verify that the encoding parameters bitrate_priority is set for the
5922 // VideoChannel.
5923 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5924 EXPECT_EQ(1UL, parameters.encodings.size());
5925 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5926
5927 // Verify that the new value propagated down to the encoder.
5928 std::vector<FakeVideoSendStream*> video_send_streams =
5929 fake_call_->GetVideoSendStreams();
5930 EXPECT_EQ(1UL, video_send_streams.size());
5931 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5932 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5933 // appropriately.
5934 EXPECT_EQ(new_bitrate_priority,
5935 video_send_stream->GetEncoderConfig().bitrate_priority);
5936 // Check that the vector of VideoStreams also was propagated correctly. Note
5937 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5938 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005939 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005940 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5941}
5942
5943// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5944// VideoChannel and the value propogates to the video encoder with all simulcast
5945// streams.
5946TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5947 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005948 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005949 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5950 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5951 AddSendStream(stream_params);
5952 uint32_t primary_ssrc = stream_params.first_ssrc();
5953
Niels Möller805a27e2019-01-21 12:21:27 +01005954 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005955 // frame. This creates multiple VideoStreams for all simulcast layers when
5956 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005957 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005958 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005959 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005960 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005961 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5962 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5963 rtc::kNumMicrosecsPerSec / 30));
5964
Seth Hampson24722b32017-12-22 09:36:42 -08005965 // Get and set the rtp encoding parameters.
5966 webrtc::RtpParameters parameters =
5967 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005968 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005969 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5970 parameters.encodings[0].bitrate_priority);
5971 // Change the value and set it on the VideoChannel.
5972 double new_bitrate_priority = 2.0;
5973 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005974 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005975
5976 // Verify that the encoding parameters priority is set on the VideoChannel.
5977 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005978 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005979 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5980
5981 // Verify that the new value propagated down to the encoder.
5982 std::vector<FakeVideoSendStream*> video_send_streams =
5983 fake_call_->GetVideoSendStreams();
5984 EXPECT_EQ(1UL, video_send_streams.size());
5985 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5986 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5987 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005988 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005989 video_send_stream->GetEncoderConfig().number_of_streams);
5990 EXPECT_EQ(new_bitrate_priority,
5991 video_send_stream->GetEncoderConfig().bitrate_priority);
5992 // Check that the vector of VideoStreams also propagated correctly. The
5993 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5994 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005995 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005996 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005997 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5998 // Since we are only setting bitrate priority per-sender, the other
5999 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02006000 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006001 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02006002 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006003 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02006004 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08006005}
6006
Tim Haloun648d28a2018-10-18 16:52:22 -07006007// RTCRtpEncodingParameters.network_priority must be one of a few values
6008// derived from the default priority, corresponding to very-low, low, medium,
6009// or high.
6010TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
6011 AddSendStream();
6012 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6013 EXPECT_EQ(1UL, parameters.encodings.size());
6014 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6015 parameters.encodings[0].network_priority);
6016
6017 double good_values[] = {0.5, 1.0, 2.0, 4.0};
6018 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
6019 for (auto it : good_values) {
6020 parameters.encodings[0].network_priority = it;
6021 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6022 }
6023 for (auto it : bad_values) {
6024 parameters.encodings[0].network_priority = it;
6025 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6026 }
6027}
6028
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006029TEST_F(WebRtcVideoChannelTest,
6030 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006031 VideoSendParameters parameters;
6032 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006033 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6034 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6035
6036 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006037 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006038
6039 VideoOptions options;
6040 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6041 channel_->SetSend(true);
6042
6043 // Try layers in natural order (smallest to largest).
6044 {
6045 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6046 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6047 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6048 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6049 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6050 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6051 ASSERT_TRUE(result.ok());
6052
6053 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6054
6055 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6056 ASSERT_EQ(3u, video_streams.size());
6057 EXPECT_EQ(320u, video_streams[0].width);
6058 EXPECT_EQ(180u, video_streams[0].height);
6059 EXPECT_EQ(640u, video_streams[1].width);
6060 EXPECT_EQ(360u, video_streams[1].height);
6061 EXPECT_EQ(1280u, video_streams[2].width);
6062 EXPECT_EQ(720u, video_streams[2].height);
6063 }
6064
6065 // Try layers in reverse natural order (largest to smallest).
6066 {
6067 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6068 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6069 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6070 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6071 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6072 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6073 ASSERT_TRUE(result.ok());
6074
6075 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6076
6077 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6078 ASSERT_EQ(3u, video_streams.size());
6079 EXPECT_EQ(1280u, video_streams[0].width);
6080 EXPECT_EQ(720u, video_streams[0].height);
6081 EXPECT_EQ(640u, video_streams[1].width);
6082 EXPECT_EQ(360u, video_streams[1].height);
6083 EXPECT_EQ(320u, video_streams[2].width);
6084 EXPECT_EQ(180u, video_streams[2].height);
6085 }
6086
6087 // Try layers in mixed order.
6088 {
6089 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6090 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6091 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6092 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6093 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6094 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6095 ASSERT_TRUE(result.ok());
6096
6097 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6098
6099 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6100 ASSERT_EQ(3u, video_streams.size());
6101 EXPECT_EQ(128u, video_streams[0].width);
6102 EXPECT_EQ(72u, video_streams[0].height);
6103 EXPECT_EQ(640u, video_streams[1].width);
6104 EXPECT_EQ(360u, video_streams[1].height);
6105 EXPECT_EQ(320u, video_streams[2].width);
6106 EXPECT_EQ(180u, video_streams[2].height);
6107 }
6108
6109 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6110 {
6111 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6112 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6113 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6114 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6115 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6116 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6117 ASSERT_TRUE(result.ok());
6118
6119 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6120
6121 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6122 ASSERT_EQ(3u, video_streams.size());
6123 EXPECT_EQ(1280u, video_streams[0].width);
6124 EXPECT_EQ(720u, video_streams[0].height);
6125 EXPECT_EQ(1280u, video_streams[1].width);
6126 EXPECT_EQ(720u, video_streams[1].height);
6127 EXPECT_EQ(320u, video_streams[2].width);
6128 EXPECT_EQ(180u, video_streams[2].height);
6129 }
6130
6131 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6132}
6133
6134TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006135 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6136 // Ensure that the top layer has width and height divisible by 2^3,
6137 // so that the bottom layer has width and height divisible by 2.
6138 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6139 // the number of simulcast layers set by the app.
6140 webrtc::test::ScopedFieldTrials field_trial(
6141 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6142
6143 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6144 VideoSendParameters parameters;
6145 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6146 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6147 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6148 webrtc::test::FrameForwarder frame_forwarder;
6149 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6150 &frame_forwarder));
6151 channel_->SetSend(true);
6152
6153 // Set |scale_resolution_down_by|'s.
6154 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6155 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6156 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6157 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6158 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6159 const auto result =
6160 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6161 ASSERT_TRUE(result.ok());
6162
6163 // Use a capture resolution whose width and height are not divisible by 2^3.
6164 // (See field trial set at the top of the test.)
6165 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6166 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6167
6168 // Ensure the scaling is correct.
6169 const auto video_streams = stream->GetVideoStreams();
6170 ASSERT_EQ(video_streams.size(), 3u);
6171 // Ensure that we round the capture resolution down for the top layer...
6172 EXPECT_EQ(video_streams[0].width, 2000u);
6173 EXPECT_EQ(video_streams[0].height, 1200u);
6174 EXPECT_EQ(video_streams[1].width, 1000u);
6175 EXPECT_EQ(video_streams[1].height, 600u);
6176 // ...and that the bottom layer has a width/height divisible by 2.
6177 EXPECT_EQ(video_streams[2].width, 500u);
6178 EXPECT_EQ(video_streams[2].height, 300u);
6179
6180 // Tear down.
6181 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6182}
6183
6184TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006185 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006186 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6187 VideoSendParameters parameters;
6188 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006189 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6190 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6191
6192 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006193 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006194
6195 VideoOptions options;
6196 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6197 channel_->SetSend(true);
6198
6199 // Try layers in natural order (smallest to largest).
6200 {
6201 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6202 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6203 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6204 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6205 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6206 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6207 ASSERT_TRUE(result.ok());
6208
6209 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6210
6211 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6212 ASSERT_EQ(3u, video_streams.size());
6213 EXPECT_EQ(320u, video_streams[0].width);
6214 EXPECT_EQ(180u, video_streams[0].height);
6215 EXPECT_EQ(640u, video_streams[1].width);
6216 EXPECT_EQ(360u, video_streams[1].height);
6217 EXPECT_EQ(1280u, video_streams[2].width);
6218 EXPECT_EQ(720u, video_streams[2].height);
6219 }
6220
6221 // Try layers in reverse natural order (largest to smallest).
6222 {
6223 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6224 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6225 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6226 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6227 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6228 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6229 ASSERT_TRUE(result.ok());
6230
6231 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6232
6233 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6234 ASSERT_EQ(3u, video_streams.size());
6235 EXPECT_EQ(1280u, video_streams[0].width);
6236 EXPECT_EQ(720u, video_streams[0].height);
6237 EXPECT_EQ(640u, video_streams[1].width);
6238 EXPECT_EQ(360u, video_streams[1].height);
6239 EXPECT_EQ(320u, video_streams[2].width);
6240 EXPECT_EQ(180u, video_streams[2].height);
6241 }
6242
6243 // Try layers in mixed order.
6244 {
6245 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6246 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6247 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6248 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6249 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6250 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6251 ASSERT_TRUE(result.ok());
6252
6253 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6254
6255 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6256 ASSERT_EQ(3u, video_streams.size());
6257 EXPECT_EQ(128u, video_streams[0].width);
6258 EXPECT_EQ(72u, video_streams[0].height);
6259 EXPECT_EQ(640u, video_streams[1].width);
6260 EXPECT_EQ(360u, video_streams[1].height);
6261 EXPECT_EQ(320u, video_streams[2].width);
6262 EXPECT_EQ(180u, video_streams[2].height);
6263 }
6264
6265 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6266 {
6267 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6268 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6269 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6270 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6271 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6272 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6273 ASSERT_TRUE(result.ok());
6274
6275 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6276
6277 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6278 ASSERT_EQ(3u, video_streams.size());
6279 EXPECT_EQ(1280u, video_streams[0].width);
6280 EXPECT_EQ(720u, video_streams[0].height);
6281 EXPECT_EQ(1280u, video_streams[1].width);
6282 EXPECT_EQ(720u, video_streams[1].height);
6283 EXPECT_EQ(320u, video_streams[2].width);
6284 EXPECT_EQ(180u, video_streams[2].height);
6285 }
6286 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6287}
6288
Rasmus Brandt9387b522019-02-05 14:23:26 +01006289TEST_F(WebRtcVideoChannelTest,
6290 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6291 // Ensure that the top layer has width and height divisible by 2^3,
6292 // so that the bottom layer has width and height divisible by 2.
6293 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6294 // the number of simulcast layers set by the app.
6295 webrtc::test::ScopedFieldTrials field_trial(
6296 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6297
6298 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6299 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6300 VideoSendParameters parameters;
6301 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6302 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6303 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6304 webrtc::test::FrameForwarder frame_forwarder;
6305 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6306 &frame_forwarder));
6307 channel_->SetSend(true);
6308
6309 // Set |scale_resolution_down_by|'s.
6310 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6311 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6312 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6313 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6314 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6315 const auto result =
6316 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6317 ASSERT_TRUE(result.ok());
6318
6319 // Use a capture resolution whose width and height are not divisible by 2^3.
6320 // (See field trial set at the top of the test.)
6321 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6322 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6323
6324 // Ensure the scaling is correct.
6325 const auto video_streams = stream->GetVideoStreams();
6326 ASSERT_EQ(video_streams.size(), 3u);
6327 // Ensure that we round the capture resolution down for the top layer...
6328 EXPECT_EQ(video_streams[0].width, 2000u);
6329 EXPECT_EQ(video_streams[0].height, 1200u);
6330 EXPECT_EQ(video_streams[1].width, 1000u);
6331 EXPECT_EQ(video_streams[1].height, 600u);
6332 // ...and that the bottom layer has a width/height divisible by 2.
6333 EXPECT_EQ(video_streams[2].width, 500u);
6334 EXPECT_EQ(video_streams[2].height, 300u);
6335
6336 // Tear down.
6337 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6338}
6339
Åsa Persson8c1bf952018-09-13 10:42:19 +02006340TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6341 const size_t kNumSimulcastStreams = 3;
6342 SetUpSimulcast(true, false);
6343
6344 // Get and set the rtp encoding parameters.
6345 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6346 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6347 for (const auto& encoding : parameters.encodings) {
6348 EXPECT_FALSE(encoding.max_framerate);
6349 }
6350
6351 // Change the value and set it on the VideoChannel.
6352 parameters.encodings[0].max_framerate = 10;
6353 parameters.encodings[1].max_framerate = 20;
6354 parameters.encodings[2].max_framerate = 25;
6355 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6356
6357 // Verify that the bitrates are set on the VideoChannel.
6358 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6359 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6360 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6361 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6362 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6363}
6364
Åsa Persson23eba222018-10-02 14:47:06 +02006365TEST_F(WebRtcVideoChannelTest,
6366 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6367 const size_t kNumSimulcastStreams = 3;
6368 SetUpSimulcast(true, false);
6369
6370 // Get and set the rtp encoding parameters.
6371 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6372 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6373
6374 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6375 parameters.encodings[0].num_temporal_layers = 0;
6376 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6377 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6378 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6379 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6380 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6381}
6382
6383TEST_F(WebRtcVideoChannelTest,
6384 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6385 const size_t kNumSimulcastStreams = 3;
6386 SetUpSimulcast(true, false);
6387
6388 // Get and set the rtp encoding parameters.
6389 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6390 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6391
6392 // No/all layers should be set.
6393 parameters.encodings[0].num_temporal_layers = 1;
6394 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6395 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6396
6397 // Different values not supported.
6398 parameters.encodings[0].num_temporal_layers = 1;
6399 parameters.encodings[1].num_temporal_layers = 2;
6400 parameters.encodings[2].num_temporal_layers = 2;
6401 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6402 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6403}
6404
6405TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6406 const size_t kNumSimulcastStreams = 3;
6407 SetUpSimulcast(true, false);
6408
6409 // Get and set the rtp encoding parameters.
6410 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6411 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6412 for (const auto& encoding : parameters.encodings)
6413 EXPECT_FALSE(encoding.num_temporal_layers);
6414
6415 // Change the value and set it on the VideoChannel.
6416 parameters.encodings[0].num_temporal_layers = 3;
6417 parameters.encodings[1].num_temporal_layers = 3;
6418 parameters.encodings[2].num_temporal_layers = 3;
6419 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6420
6421 // Verify that the number of temporal layers are set on the VideoChannel.
6422 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6423 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6424 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6425 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6426 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6427}
6428
6429TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6430 const size_t kNumSimulcastStreams = 3;
6431 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6432
6433 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006434 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006435 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006436 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006437 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006438 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006439
6440 // Get and set the rtp encoding parameters.
6441 // Change the value and set it on the VideoChannel.
6442 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6443 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6444 parameters.encodings[0].num_temporal_layers = 2;
6445 parameters.encodings[1].num_temporal_layers = 2;
6446 parameters.encodings[2].num_temporal_layers = 2;
6447 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6448
6449 // Verify that the new value is propagated down to the encoder.
6450 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6451 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6452 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6453 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6454 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6455 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6456 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6457 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6458
6459 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6460 // VideoStreams are created appropriately for the simulcast case.
6461 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6462 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6463 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6464 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6465
6466 // No parameter changed, encoder should not be reconfigured.
6467 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6468 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6469
6470 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6471}
6472
6473TEST_F(WebRtcVideoChannelTest,
6474 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6475 const size_t kDefaultNumTemporalLayers = 3;
6476 const size_t kNumSimulcastStreams = 3;
6477 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6478
6479 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006480 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006481 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006482 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006483 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006484 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006485
6486 // Change rtp encoding parameters, num_temporal_layers not changed.
6487 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6488 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6489 parameters.encodings[0].min_bitrate_bps = 33000;
6490 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6491
6492 // Verify that no value is propagated down to the encoder.
6493 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6494 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6495 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6496 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6497 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6498 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6499
6500 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6501 // VideoStreams are created appropriately for the simulcast case.
6502 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6503 EXPECT_EQ(kDefaultNumTemporalLayers,
6504 stream->GetVideoStreams()[0].num_temporal_layers);
6505 EXPECT_EQ(kDefaultNumTemporalLayers,
6506 stream->GetVideoStreams()[1].num_temporal_layers);
6507 EXPECT_EQ(kDefaultNumTemporalLayers,
6508 stream->GetVideoStreams()[2].num_temporal_layers);
6509
6510 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6511}
6512
Åsa Persson8c1bf952018-09-13 10:42:19 +02006513TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6514 const size_t kNumSimulcastStreams = 3;
6515 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6516
6517 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006518 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006519 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006520 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006521 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006522 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006523
6524 // Get and set the rtp encoding parameters.
6525 // Change the value and set it on the VideoChannel.
6526 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6527 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6528 parameters.encodings[0].max_framerate = 15;
6529 parameters.encodings[1].max_framerate = 25;
6530 parameters.encodings[2].max_framerate = 20;
6531 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6532
6533 // Verify that the new value propagated down to the encoder.
6534 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6535 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6536 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6537 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6538 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6539 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6540 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6541 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6542
6543 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6544 // VideoStreams are created appropriately for the simulcast case.
6545 // Currently the maximum |max_framerate| is used.
6546 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6547 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6548 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6549 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6550
6551 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6552}
6553
6554TEST_F(WebRtcVideoChannelTest,
6555 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6556 const size_t kNumSimulcastStreams = 3;
6557 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6558 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6559
6560 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006561 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006562 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006563 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006564 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006565 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006566
6567 // Get and set the rtp encoding parameters.
6568 // Change the value and set it on the VideoChannel.
6569 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6570 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6571 parameters.encodings[0].max_framerate = 15;
6572 parameters.encodings[2].max_framerate = 20;
6573 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6574
6575 // Verify that the new value propagated down to the encoder.
6576 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6577 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6578 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6579 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6580 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6581 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6582 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6583
6584 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6585 // VideoStreams are created appropriately for the simulcast case.
6586 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6587 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6588 EXPECT_EQ(kDefaultVideoMaxFramerate,
6589 stream->GetVideoStreams()[0].max_framerate);
6590 EXPECT_EQ(kDefaultVideoMaxFramerate,
6591 stream->GetVideoStreams()[1].max_framerate);
6592 EXPECT_EQ(kDefaultVideoMaxFramerate,
6593 stream->GetVideoStreams()[2].max_framerate);
6594
6595 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6596}
6597
Åsa Persson55659812018-06-18 17:51:32 +02006598TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6599 const size_t kNumSimulcastStreams = 3;
6600 SetUpSimulcast(true, false);
6601
6602 // Get and set the rtp encoding parameters.
6603 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6604 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6605 for (const auto& encoding : parameters.encodings) {
6606 EXPECT_FALSE(encoding.min_bitrate_bps);
6607 EXPECT_FALSE(encoding.max_bitrate_bps);
6608 }
6609
6610 // Change the value and set it on the VideoChannel.
6611 parameters.encodings[0].min_bitrate_bps = 100000;
6612 parameters.encodings[0].max_bitrate_bps = 200000;
6613 parameters.encodings[1].min_bitrate_bps = 300000;
6614 parameters.encodings[1].max_bitrate_bps = 400000;
6615 parameters.encodings[2].min_bitrate_bps = 500000;
6616 parameters.encodings[2].max_bitrate_bps = 600000;
6617 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6618
6619 // Verify that the bitrates are set on the VideoChannel.
6620 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6621 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6622 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6623 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6624 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6625 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6626 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6627 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6628}
6629
6630TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6631 const size_t kNumSimulcastStreams = 3;
6632 SetUpSimulcast(true, false);
6633
6634 // Get and set the rtp encoding parameters.
6635 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6636 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6637
6638 // Max bitrate lower than min bitrate should fail.
6639 parameters.encodings[2].min_bitrate_bps = 100000;
6640 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6641 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6642 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6643}
6644
6645// Test that min and max bitrate values set via RtpParameters are correctly
6646// propagated to the underlying encoder, and that the target is set to 3/4 of
6647// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6648// that are used if no min/max are specified).
6649TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6650 const size_t kNumSimulcastStreams = 3;
6651 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6652
6653 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006654 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006655 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006656 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006657 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006658 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006659
6660 // Get and set the rtp encoding parameters.
6661 // Change the value and set it on the VideoChannel.
6662 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6663 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6664 parameters.encodings[0].min_bitrate_bps = 100000;
6665 parameters.encodings[0].max_bitrate_bps = 200000;
6666 parameters.encodings[1].min_bitrate_bps = 300000;
6667 parameters.encodings[1].max_bitrate_bps = 400000;
6668 parameters.encodings[2].min_bitrate_bps = 500000;
6669 parameters.encodings[2].max_bitrate_bps = 600000;
6670 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6671
6672 // Verify that the new value propagated down to the encoder.
6673 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6674 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6675 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6676 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6677 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6678 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6679 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6680 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6681 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6682 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6683 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6684
6685 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6686 // VideoStreams are created appropriately for the simulcast case.
6687 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6688 // Target bitrate: 200000 * 3 / 4 = 150000.
6689 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6690 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6691 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6692 // Target bitrate: 400000 * 3 / 4 = 300000.
6693 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6694 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6695 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6696 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6697 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6698 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6699 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6700
6701 // No parameter changed, encoder should not be reconfigured.
6702 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6703 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6704
6705 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6706}
6707
6708// Test to only specify the min or max bitrate value for a layer via
6709// RtpParameters. The unspecified min/max and target value should be set to the
6710// simulcast default that is used if no min/max are specified.
6711TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6712 const size_t kNumSimulcastStreams = 3;
6713 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6714 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6715
6716 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006717 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006718 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006719 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006720 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006721 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006722
6723 // Get and set the rtp encoding parameters.
6724 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6725 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6726
6727 // Change the value and set it on the VideoChannel.
6728 // Layer 0: only configure min bitrate.
6729 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6730 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6731 // Layer 1: only configure max bitrate.
6732 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6733 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6734 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6735
6736 // Verify that the new value propagated down to the encoder.
6737 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6738 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6739 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6740 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6741 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6742 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6743 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6744 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6745 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6746 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6747
6748 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6749 // VideoStreams are created appropriately for the simulcast case.
6750 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6751 // Layer 0: min configured bitrate should overwrite min default.
6752 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6753 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6754 stream->GetVideoStreams()[0].target_bitrate_bps);
6755 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6756 stream->GetVideoStreams()[0].max_bitrate_bps);
6757 // Layer 1: max configured bitrate should overwrite max default.
6758 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6759 stream->GetVideoStreams()[1].min_bitrate_bps);
6760 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6761 stream->GetVideoStreams()[1].target_bitrate_bps);
6762 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6763 // Layer 2: min and max bitrate not configured, default expected.
6764 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6765 stream->GetVideoStreams()[2].min_bitrate_bps);
6766 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6767 stream->GetVideoStreams()[2].target_bitrate_bps);
6768 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6769 stream->GetVideoStreams()[2].max_bitrate_bps);
6770
6771 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6772}
6773
6774// Test that specifying the min (or max) bitrate value for a layer via
6775// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6776// unspecified values accordingly.
6777TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6778 const size_t kNumSimulcastStreams = 3;
6779 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6780 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6781
6782 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006783 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006784 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006785 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006786 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006787 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006788
6789 // Get and set the rtp encoding parameters.
6790 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6791 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6792
6793 // Change the value and set it on the VideoChannel.
6794 // For layer 0, set the min bitrate above the default max.
6795 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6796 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6797 // For layer 1, set the max bitrate below the default min.
6798 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6799 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6800 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6801
6802 // Verify that the new value propagated down to the encoder.
6803 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6804 // VideoStreams are created appropriately for the simulcast case.
6805 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6806 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6807 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6808 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6809 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6810 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6811 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6812 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6813 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6814 // Layer 2: min and max bitrate not configured, default expected.
6815 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6816 stream->GetVideoStreams()[2].min_bitrate_bps);
6817 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6818 stream->GetVideoStreams()[2].target_bitrate_bps);
6819 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6820 stream->GetVideoStreams()[2].max_bitrate_bps);
6821
6822 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6823}
6824
6825TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6826 const size_t kNumSimulcastStreams = 3;
6827 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6828 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6829
6830 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006831 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006832 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006833 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006834 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006835 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006836
6837 // Set max bitrate for all but the highest layer.
6838 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6839 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6840 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6841 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6842 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6843
6844 // Set max bandwidth equal to total max bitrate.
6845 send_parameters_.max_bandwidth_bps =
6846 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6847 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6848 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6849
6850 // No bitrate above the total max to give to the highest layer.
6851 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6852 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6853 stream->GetVideoStreams()[2].max_bitrate_bps);
6854
6855 // Set max bandwidth above the total max bitrate.
6856 send_parameters_.max_bandwidth_bps =
6857 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6858 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6859 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6860
6861 // The highest layer has no max bitrate set -> the bitrate above the total
6862 // max should be given to the highest layer.
6863 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6864 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6865 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6866 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6867 stream->GetVideoStreams()[2].max_bitrate_bps);
6868
6869 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6870}
6871
6872TEST_F(WebRtcVideoChannelTest,
6873 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6874 const size_t kNumSimulcastStreams = 3;
6875 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6876 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6877 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6878
6879 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006880 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006881 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006882 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006883 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006884 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006885
6886 // Set max bitrate for the highest layer.
6887 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6888 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6889 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6890 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6891
6892 // Set max bandwidth above the total max bitrate.
6893 send_parameters_.max_bandwidth_bps =
6894 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6895 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6896 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6897
6898 // The highest layer has the max bitrate set -> the bitrate above the total
6899 // max should not be given to the highest layer.
6900 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6901 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6902 stream->GetVideoStreams()[2].max_bitrate_bps);
6903
6904 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6905}
6906
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006907// Test that min and max bitrate values set via RtpParameters are correctly
6908// propagated to the underlying encoder for a single stream.
6909TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6910 FakeVideoSendStream* stream = AddSendStream();
6911 EXPECT_TRUE(channel_->SetSend(true));
6912 EXPECT_TRUE(stream->IsSending());
6913
6914 // Set min and max bitrate.
6915 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6916 EXPECT_EQ(1u, parameters.encodings.size());
6917 parameters.encodings[0].min_bitrate_bps = 80000;
6918 parameters.encodings[0].max_bitrate_bps = 150000;
6919 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6920
6921 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6922 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6923 EXPECT_EQ(1u, encoder_config.number_of_streams);
6924 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6925 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6926 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6927
6928 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6929 // VideoStreams are created appropriately.
6930 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6931 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6932 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6933 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6934}
6935
6936// Test the default min and max bitrate value are correctly propagated to the
6937// underlying encoder for a single stream (when the values are not set via
6938// RtpParameters).
6939TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6940 FakeVideoSendStream* stream = AddSendStream();
6941 EXPECT_TRUE(channel_->SetSend(true));
6942 EXPECT_TRUE(stream->IsSending());
6943
6944 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6945 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6946 EXPECT_EQ(1u, encoder_config.number_of_streams);
6947 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6948 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6949 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6950
6951 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6952 // VideoStreams are created appropriately.
6953 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6954 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6955 stream->GetVideoStreams()[0].min_bitrate_bps);
6956 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6957 stream->GetVideoStreams()[0].min_bitrate_bps);
6958 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6959 stream->GetVideoStreams()[0].target_bitrate_bps);
6960}
6961
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006962// Test that a stream will not be sending if its encoding is made inactive
6963// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006964TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006965 FakeVideoSendStream* stream = AddSendStream();
6966 EXPECT_TRUE(channel_->SetSend(true));
6967 EXPECT_TRUE(stream->IsSending());
6968
6969 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006970 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006971 ASSERT_EQ(1u, parameters.encodings.size());
6972 ASSERT_TRUE(parameters.encodings[0].active);
6973 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006974 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006975 EXPECT_FALSE(stream->IsSending());
6976
6977 // Now change it back to active and verify we resume sending.
6978 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006979 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006980 EXPECT_TRUE(stream->IsSending());
6981}
6982
Seth Hampson8234ead2018-02-02 15:16:24 -08006983// Tests that when active is updated for any simulcast layer then the send
6984// stream's sending state will be updated and it will be reconfigured with the
6985// new appropriate active simulcast streams.
6986TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6987 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006988 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006989 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6990 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6991 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6992 uint32_t primary_ssrc = stream_params.first_ssrc();
6993
Niels Möller805a27e2019-01-21 12:21:27 +01006994 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006995 // frame. This allows us to test that ReconfigureEncoder is called
6996 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006997 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006998 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006999 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08007000 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007001 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
7002 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
7003 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08007004
7005 // Check that all encodings are initially active.
7006 webrtc::RtpParameters parameters =
7007 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007008 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007009 EXPECT_TRUE(parameters.encodings[0].active);
7010 EXPECT_TRUE(parameters.encodings[1].active);
7011 EXPECT_TRUE(parameters.encodings[2].active);
7012 EXPECT_TRUE(fake_video_send_stream->IsSending());
7013
7014 // Only turn on only the middle stream.
7015 parameters.encodings[0].active = false;
7016 parameters.encodings[1].active = true;
7017 parameters.encodings[2].active = false;
7018 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7019 // Verify that the active fields are set on the VideoChannel.
7020 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007021 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007022 EXPECT_FALSE(parameters.encodings[0].active);
7023 EXPECT_TRUE(parameters.encodings[1].active);
7024 EXPECT_FALSE(parameters.encodings[2].active);
7025 // Check that the VideoSendStream is updated appropriately. This means its
7026 // send state was updated and it was reconfigured.
7027 EXPECT_TRUE(fake_video_send_stream->IsSending());
7028 std::vector<webrtc::VideoStream> simulcast_streams =
7029 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007030 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007031 EXPECT_FALSE(simulcast_streams[0].active);
7032 EXPECT_TRUE(simulcast_streams[1].active);
7033 EXPECT_FALSE(simulcast_streams[2].active);
7034
7035 // Turn off all streams.
7036 parameters.encodings[0].active = false;
7037 parameters.encodings[1].active = false;
7038 parameters.encodings[2].active = false;
7039 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7040 // Verify that the active fields are set on the VideoChannel.
7041 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007042 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007043 EXPECT_FALSE(parameters.encodings[0].active);
7044 EXPECT_FALSE(parameters.encodings[1].active);
7045 EXPECT_FALSE(parameters.encodings[2].active);
7046 // Check that the VideoSendStream is off.
7047 EXPECT_FALSE(fake_video_send_stream->IsSending());
7048 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007049 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007050 EXPECT_FALSE(simulcast_streams[0].active);
7051 EXPECT_FALSE(simulcast_streams[1].active);
7052 EXPECT_FALSE(simulcast_streams[2].active);
7053
Niels Möllerff40b142018-04-09 08:49:14 +02007054 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08007055}
7056
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007057// Test that if a stream is reconfigured (due to a codec change or other
7058// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07007059TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007060 InactiveStreamDoesntStartSendingWhenReconfigured) {
7061 // Set an initial codec list, which will be modified later.
7062 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007063 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7064 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007065 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7066
7067 FakeVideoSendStream* stream = AddSendStream();
7068 EXPECT_TRUE(channel_->SetSend(true));
7069 EXPECT_TRUE(stream->IsSending());
7070
7071 // Get current parameters and change "active" to false.
7072 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7073 ASSERT_EQ(1u, parameters.encodings.size());
7074 ASSERT_TRUE(parameters.encodings[0].active);
7075 parameters.encodings[0].active = false;
7076 EXPECT_EQ(1u, GetFakeSendStreams().size());
7077 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007078 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007079 EXPECT_FALSE(stream->IsSending());
7080
7081 // Reorder the codec list, causing the stream to be reconfigured.
7082 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007083 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7084 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007085 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7086 auto new_streams = GetFakeSendStreams();
7087 // Assert that a new underlying stream was created due to the codec change.
7088 // Otherwise, this test isn't testing what it set out to test.
7089 EXPECT_EQ(1u, GetFakeSendStreams().size());
7090 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7091
7092 // Verify that we still are not sending anything, due to the inactive
7093 // encoding.
7094 EXPECT_FALSE(new_streams[0]->IsSending());
7095}
7096
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007097// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007098TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007099 AddSendStream();
7100 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007101 parameters.codecs.push_back(GetEngineCodec("VP8"));
7102 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007103 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7104
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007105 webrtc::RtpParameters rtp_parameters =
7106 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007107 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007108 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7109 rtp_parameters.codecs[0]);
7110 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7111 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007112}
7113
Florent Castellidacec712018-05-24 16:24:21 +02007114// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7115TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7116 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7117 params.cname = "rtcpcname";
7118 AddSendStream(params);
7119
7120 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7121 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7122}
7123
deadbeeffb2aced2017-01-06 23:05:37 -08007124// Test that RtpParameters for send stream has one encoding and it has
7125// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007126TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007127 AddSendStream();
7128
7129 webrtc::RtpParameters rtp_parameters =
7130 channel_->GetRtpSendParameters(last_ssrc_);
7131 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007132 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007133}
7134
Florent Castelliabe301f2018-06-12 18:33:49 +02007135TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7136 AddSendStream();
7137
7138 webrtc::RtpParameters rtp_parameters =
7139 channel_->GetRtpSendParameters(last_ssrc_);
7140 rtp_parameters.header_extensions.emplace_back();
7141
7142 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7143
7144 webrtc::RTCError result =
7145 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7146 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7147}
7148
Florent Castelli87b3c512018-07-18 16:00:28 +02007149TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7150 AddSendStream();
7151
Niels Möller805a27e2019-01-21 12:21:27 +01007152 webrtc::test::FrameForwarder frame_forwarder;
7153 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007154
7155 webrtc::RtpParameters rtp_parameters =
7156 channel_->GetRtpSendParameters(last_ssrc_);
7157 EXPECT_EQ(rtp_parameters.degradation_preference,
7158 webrtc::DegradationPreference::BALANCED);
7159 rtp_parameters.degradation_preference =
7160 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7161
7162 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7163
7164 webrtc::RtpParameters updated_rtp_parameters =
7165 channel_->GetRtpSendParameters(last_ssrc_);
7166 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7167 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7168
7169 // Remove the source since it will be destroyed before the channel
7170 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7171}
7172
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007173// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007174TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007175 AddSendStream();
7176 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007177 parameters.codecs.push_back(GetEngineCodec("VP8"));
7178 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007179 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7180
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007181 webrtc::RtpParameters initial_params =
7182 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007183
7184 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007185 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007186
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007187 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7188 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7189}
7190
7191// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007192TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007193 AddRecvStream();
7194 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007195 parameters.codecs.push_back(GetEngineCodec("VP8"));
7196 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007197 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7198
7199 webrtc::RtpParameters rtp_parameters =
7200 channel_->GetRtpReceiveParameters(last_ssrc_);
7201 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007202 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7203 rtp_parameters.codecs[0]);
7204 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7205 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007206}
7207
johan073ece42016-08-26 02:59:47 -07007208#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007209TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007210#else
eladalonf1841382017-06-12 01:16:46 -07007211TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007212#endif
johan3859c892016-08-05 09:19:25 -07007213 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007214 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007215 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007216 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007217 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007218 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007219 parameters.codecs.push_back(kH264sprop2);
7220 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7221
7222 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7223 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7224 webrtc::RtpParameters rtp_parameters =
7225 channel_->GetRtpReceiveParameters(last_ssrc_);
7226 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7227 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7228 ASSERT_EQ(2u, cfg.decoders.size());
7229 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007230 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007231 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007232 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7233 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007234 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007235
7236 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007237 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007238 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007239 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7240 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007241 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007242}
7243
sakal1fd95952016-06-22 00:46:15 -07007244// Test that RtpParameters for receive stream has one encoding and it has
7245// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007246TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007247 AddRecvStream();
7248
7249 webrtc::RtpParameters rtp_parameters =
7250 channel_->GetRtpReceiveParameters(last_ssrc_);
7251 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007252 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007253}
7254
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007255// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007256TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007257 AddRecvStream();
7258 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007259 parameters.codecs.push_back(GetEngineCodec("VP8"));
7260 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007261 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7262
7263 webrtc::RtpParameters initial_params =
7264 channel_->GetRtpReceiveParameters(last_ssrc_);
7265
7266 // We should be able to set the params we just got.
7267 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7268
7269 // ... And this shouldn't change the params returned by
7270 // GetRtpReceiveParameters.
7271 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007272}
7273
deadbeef3bc15102017-04-20 19:25:07 -07007274// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7275// aren't signaled. It should always return an empty "RtpEncodingParameters",
7276// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007277TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007278 // Call necessary methods to configure receiving a default stream as
7279 // soon as it arrives.
7280 cricket::VideoRecvParameters parameters;
7281 parameters.codecs.push_back(GetEngineCodec("VP8"));
7282 parameters.codecs.push_back(GetEngineCodec("VP9"));
7283 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7284
7285 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7286 // stream. Should return nothing.
7287 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7288
7289 // Set a sink for an unsignaled stream.
7290 cricket::FakeVideoRenderer renderer;
7291 // Value of "0" means "unsignaled stream".
7292 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7293
7294 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7295 // in this method means "unsignaled stream".
7296 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7297 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7298 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7299
7300 // Receive VP8 packet.
7301 uint8_t data[kMinRtpPacketLen];
7302 cricket::RtpHeader rtpHeader;
7303 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7304 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7305 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7306 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7307 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007308 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007309
7310 // The |ssrc| member should still be unset.
7311 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7312 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7313 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7314}
7315
eladalonf1841382017-06-12 01:16:46 -07007316void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007317 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007318 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007319
7320 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007321 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007322 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007323 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007324
7325 if (receiver_first) {
7326 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7327 std::vector<FakeVideoReceiveStream*> receive_streams =
7328 fake_call_->GetVideoReceiveStreams();
7329 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007330 // Default local SSRC when we have no sender.
7331 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7332 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007333 }
7334 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7335 if (!receiver_first)
7336 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7337 std::vector<FakeVideoReceiveStream*> receive_streams =
7338 fake_call_->GetVideoReceiveStreams();
7339 ASSERT_EQ(1u, receive_streams.size());
7340 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007341
7342 // Removing first sender should fall back to another (in this case the second)
7343 // local send stream's SSRC.
7344 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7345 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007346 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007347 ASSERT_EQ(1u, receive_streams.size());
7348 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7349
7350 // Removing the last sender should fall back to default local SSRC.
7351 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007352 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007353 ASSERT_EQ(1u, receive_streams.size());
7354 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7355 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007356}
7357
eladalonf1841382017-06-12 01:16:46 -07007358TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007359 TestReceiverLocalSsrcConfiguration(false);
7360}
7361
eladalonf1841382017-06-12 01:16:46 -07007362TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007363 TestReceiverLocalSsrcConfiguration(true);
7364}
7365
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007366class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007367 public:
eladalonf1841382017-06-12 01:16:46 -07007368 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007369 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007370 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7371 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007372 mock_rate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007373 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007374 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007375 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007376 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007377 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007378 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007379
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007380 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007381 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007382 channel_.reset(engine_.CreateMediaChannel(
7383 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7384 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007385 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007386 last_ssrc_ = 123;
7387 }
7388
7389 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007390 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007391 int capture_width,
7392 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007393 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007394 size_t expected_num_streams,
7395 bool screenshare,
7396 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007397 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007398 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007399 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007400 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007401
Peter Boström0c4e06b2015-10-07 12:23:21 +02007402 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007403 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007404 ssrcs.resize(num_configured_streams);
7405
sprangf24a0642017-02-28 13:23:26 -08007406 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007407 // Send a full-size frame to trigger a stream reconfiguration to use all
7408 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007409 webrtc::test::FrameForwarder frame_forwarder;
7410 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7411 rtc::kNumMicrosecsPerSec / 30);
7412
sprangf24a0642017-02-28 13:23:26 -08007413 VideoOptions options;
7414 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007415 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007416 EXPECT_TRUE(
7417 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007418 // Fetch the latest stream since SetVideoSend() may recreate it if the
7419 // screen content setting is changed.
7420 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007421 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007422 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007423
Zach Stein3ca452b2018-01-18 10:01:24 -08007424 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7425 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7426
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007427 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7428 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007429 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007430
sprang429600d2017-01-26 06:12:26 -08007431 std::vector<webrtc::VideoStream> expected_streams;
Florent Castelli66b38602019-07-10 16:57:57 +02007432 if (num_configured_streams > 1 || conference_mode) {
sprang429600d2017-01-26 06:12:26 -08007433 expected_streams = GetSimulcastConfig(
Florent Castelli668ce0c2019-07-04 17:06:04 +02007434 num_configured_streams, capture_width, capture_height,
Florent Castelli66b38602019-07-10 16:57:57 +02007435 webrtc::kDefaultBitratePriority, kDefaultQpMax,
7436 screenshare && conference_mode, true);
7437 if (screenshare && conference_mode) {
sprang3ebabf12017-02-16 07:35:22 -08007438 for (const webrtc::VideoStream& stream : expected_streams) {
7439 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007440 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7441 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007442 }
7443 }
sprang429600d2017-01-26 06:12:26 -08007444 } else {
7445 webrtc::VideoStream stream;
7446 stream.width = capture_width;
7447 stream.height = capture_height;
7448 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007449 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007450 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007451 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007452 stream.max_qp = kDefaultQpMax;
7453 expected_streams.push_back(stream);
7454 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007455
7456 ASSERT_EQ(expected_streams.size(), video_streams.size());
7457
7458 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007459 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007460 for (size_t i = 0; i < num_streams; ++i) {
7461 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7462 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7463
7464 EXPECT_GT(video_streams[i].max_framerate, 0);
7465 EXPECT_EQ(expected_streams[i].max_framerate,
7466 video_streams[i].max_framerate);
7467
7468 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7469 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7470 video_streams[i].min_bitrate_bps);
7471
7472 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7473 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7474 video_streams[i].target_bitrate_bps);
7475
7476 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7477 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7478 video_streams[i].max_bitrate_bps);
7479
7480 EXPECT_GT(video_streams[i].max_qp, 0);
7481 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7482
Florent Castelli66b38602019-07-10 16:57:57 +02007483 EXPECT_EQ(num_configured_streams > 1 || conference_mode,
Sergey Silkina796a7e2018-03-01 15:11:29 +01007484 expected_streams[i].num_temporal_layers.has_value());
7485
7486 if (conference_mode) {
7487 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7488 video_streams[i].num_temporal_layers);
7489 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007490
7491 if (i == num_streams - 1) {
7492 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7493 } else {
7494 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7495 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007496 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007497
Niels Möllerff40b142018-04-09 08:49:14 +02007498 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007499 }
7500
7501 FakeVideoSendStream* AddSendStream() {
7502 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7503 }
7504
7505 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007506 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007507 EXPECT_TRUE(channel_->AddSendStream(sp));
7508 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007509 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007510 EXPECT_EQ(num_streams + 1, streams.size());
7511 return streams[streams.size() - 1];
7512 }
7513
7514 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007515 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007516 }
7517
7518 FakeVideoReceiveStream* AddRecvStream() {
7519 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7520 }
7521
7522 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007523 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007524 EXPECT_TRUE(channel_->AddRecvStream(sp));
7525 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007526 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007527 EXPECT_EQ(num_streams + 1, streams.size());
7528 return streams[streams.size() - 1];
7529 }
7530
skvlad11a9cbf2016-10-07 11:53:05 -07007531 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007532 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007533 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7534 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007535 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7536 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007537 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007538 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007539 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007540};
7541
eladalonf1841382017-06-12 01:16:46 -07007542TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007543 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7544 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007545}
7546
eladalonf1841382017-06-12 01:16:46 -07007547TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007548 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7549 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007550}
7551
7552// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007553TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007554 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7555 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007556}
sprang429600d2017-01-26 06:12:26 -08007557
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007558TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Florent Castelli66b38602019-07-10 16:57:57 +02007559 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007560 false);
7561}
7562
eladalonf1841382017-06-12 01:16:46 -07007563TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007564 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7565 true);
7566}
7567
Florent Castelli66b38602019-07-10 16:57:57 +02007568TEST_F(WebRtcVideoChannelSimulcastTest, SimulcastScreenshareWithoutConference) {
7569 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
sprangfe627f32017-03-29 08:24:59 -07007570 false);
7571}
7572
Chen Xing90f3b892019-06-25 10:16:14 +02007573TEST_F(WebRtcVideoChannelBaseTest, GetSources) {
7574 EXPECT_THAT(channel_->GetSources(kSsrc), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007575
Chen Xing90f3b892019-06-25 10:16:14 +02007576 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007577 EXPECT_TRUE(SetDefaultCodec());
7578 EXPECT_TRUE(SetSend(true));
Chen Xing90f3b892019-06-25 10:16:14 +02007579 EXPECT_EQ(renderer_.num_rendered_frames(), 0);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007580
Chen Xing90f3b892019-06-25 10:16:14 +02007581 // Send and receive one frame.
7582 SendFrame();
7583 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007584
Chen Xing90f3b892019-06-25 10:16:14 +02007585 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7586 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7587 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007588
Chen Xing90f3b892019-06-25 10:16:14 +02007589 webrtc::RtpSource source = channel_->GetSources(kSsrc)[0];
7590 EXPECT_EQ(source.source_id(), kSsrc);
7591 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7592 int64_t rtp_timestamp_1 = source.rtp_timestamp();
7593 int64_t timestamp_ms_1 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007594
Chen Xing90f3b892019-06-25 10:16:14 +02007595 // Send and receive another frame.
7596 SendFrame();
7597 EXPECT_FRAME_WAIT(2, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007598
Chen Xing90f3b892019-06-25 10:16:14 +02007599 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7600 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7601 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007602
Chen Xing90f3b892019-06-25 10:16:14 +02007603 source = channel_->GetSources(kSsrc)[0];
7604 EXPECT_EQ(source.source_id(), kSsrc);
7605 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7606 int64_t rtp_timestamp_2 = source.rtp_timestamp();
7607 int64_t timestamp_ms_2 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007608
Chen Xing90f3b892019-06-25 10:16:14 +02007609 EXPECT_GT(rtp_timestamp_2, rtp_timestamp_1);
7610 EXPECT_GT(timestamp_ms_2, timestamp_ms_1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007611}
7612
Amit Hilbuchb000b712019-02-25 10:22:14 -08007613TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7614 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7615
7616 std::vector<std::string> rids = {"f", "h", "q"};
7617 std::vector<cricket::RidDescription> rid_descriptions;
7618 for (const auto& rid : rids) {
7619 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7620 }
7621 sp.set_rids(rid_descriptions);
7622
7623 ASSERT_TRUE(channel_->AddSendStream(sp));
7624 const auto& streams = fake_call_->GetVideoSendStreams();
7625 ASSERT_EQ(1u, streams.size());
7626 auto stream = streams[0];
7627 ASSERT_NE(stream, nullptr);
7628 const auto& config = stream->GetConfig();
7629 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7630}
7631
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007632} // namespace cricket