blob: 3efc6cbf4425cda6c77b6b1a4b674185cca0008e [file] [log] [blame]
Amit Hilbuchaa584152019-02-06 17:09:52 -08001/*
2 * Copyright 2019 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11#include <ostream> // no-presubmit-check TODO(webrtc:8982)
12
13#include "absl/algorithm/container.h"
14#include "absl/memory/memory.h"
15#include "api/audio_codecs/builtin_audio_decoder_factory.h"
16#include "api/audio_codecs/builtin_audio_encoder_factory.h"
17#include "api/create_peerconnection_factory.h"
18#include "api/rtp_transceiver_interface.h"
Amit Hilbuche2a284d2019-03-05 12:36:31 -080019#include "api/uma_metrics.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080020#include "api/video_codecs/builtin_video_decoder_factory.h"
21#include "api/video_codecs/builtin_video_encoder_factory.h"
22#include "pc/peer_connection.h"
23#include "pc/peer_connection_wrapper.h"
24#include "pc/test/fake_audio_capture_module.h"
25#include "pc/test/mock_peer_connection_observers.h"
26#include "rtc_base/gunit.h"
Amit Hilbuche2a284d2019-03-05 12:36:31 -080027#include "system_wrappers/include/metrics.h"
Amit Hilbuchaa584152019-02-06 17:09:52 -080028#include "test/gmock.h"
29
30using ::testing::Contains;
31using ::testing::Each;
32using ::testing::ElementsAre;
33using ::testing::ElementsAreArray;
34using ::testing::Eq;
35using ::testing::Field;
36using ::testing::IsEmpty;
37using ::testing::Ne;
Amit Hilbuche2a284d2019-03-05 12:36:31 -080038using ::testing::Pair;
Amit Hilbuchaa584152019-02-06 17:09:52 -080039using ::testing::Property;
40using ::testing::SizeIs;
41
42using cricket::MediaContentDescription;
43using cricket::RidDescription;
44using cricket::SimulcastDescription;
45using cricket::SimulcastLayer;
46using cricket::StreamParams;
47
48namespace cricket {
49
50std::ostream& operator<<( // no-presubmit-check TODO(webrtc:8982)
51 std::ostream& os, // no-presubmit-check TODO(webrtc:8982)
52 const SimulcastLayer& layer) {
53 if (layer.is_paused) {
54 os << "~";
55 }
56 return os << layer.rid;
57}
58
59} // namespace cricket
60
61namespace {
62
63std::vector<SimulcastLayer> CreateLayers(const std::vector<std::string>& rids,
64 const std::vector<bool>& active) {
65 RTC_DCHECK_EQ(rids.size(), active.size());
66 std::vector<SimulcastLayer> result;
67 absl::c_transform(rids, active, std::back_inserter(result),
68 [](const std::string& rid, bool is_active) {
69 return SimulcastLayer(rid, !is_active);
70 });
71 return result;
72}
73std::vector<SimulcastLayer> CreateLayers(const std::vector<std::string>& rids,
74 bool active) {
75 return CreateLayers(rids, std::vector<bool>(rids.size(), active));
76}
77
Amit Hilbuche2a284d2019-03-05 12:36:31 -080078std::vector<SimulcastLayer> CreateLayers(int num_layers, bool active) {
79 rtc::UniqueStringGenerator rid_generator;
80 std::vector<std::string> rids;
81 for (int i = 0; i < num_layers; ++i) {
82 rids.push_back(rid_generator());
83 }
84 return CreateLayers(rids, active);
85}
86
Amit Hilbuchaa584152019-02-06 17:09:52 -080087} // namespace
88namespace webrtc {
89
90class PeerConnectionSimulcastTests : public testing::Test {
91 public:
92 PeerConnectionSimulcastTests()
93 : pc_factory_(
94 CreatePeerConnectionFactory(rtc::Thread::Current(),
95 rtc::Thread::Current(),
96 rtc::Thread::Current(),
97 FakeAudioCaptureModule::Create(),
98 CreateBuiltinAudioEncoderFactory(),
99 CreateBuiltinAudioDecoderFactory(),
100 CreateBuiltinVideoEncoderFactory(),
101 CreateBuiltinVideoDecoderFactory(),
102 nullptr,
103 nullptr)) {}
104
105 rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection(
106 MockPeerConnectionObserver* observer) {
107 PeerConnectionInterface::RTCConfiguration config;
108 config.sdp_semantics = SdpSemantics::kUnifiedPlan;
109 PeerConnectionDependencies pcd(observer);
110 auto pc = pc_factory_->CreatePeerConnection(config, std::move(pcd));
111 EXPECT_TRUE(pc);
112 observer->SetPeerConnectionInterface(pc);
113 return pc;
114 }
115
116 std::unique_ptr<PeerConnectionWrapper> CreatePeerConnectionWrapper() {
117 auto observer = absl::make_unique<MockPeerConnectionObserver>();
118 auto pc = CreatePeerConnection(observer.get());
119 return absl::make_unique<PeerConnectionWrapper>(pc_factory_, pc,
120 std::move(observer));
121 }
122
Amit Hilbuch619b2942019-02-26 15:55:19 -0800123 void ExchangeOfferAnswer(PeerConnectionWrapper* local,
124 PeerConnectionWrapper* remote,
125 const std::vector<SimulcastLayer>& answer_layers) {
126 auto offer = local->CreateOfferAndSetAsLocal();
127 // Remove simulcast as the second peer connection won't support it.
Amit Hilbuchaabd0362019-03-01 13:14:46 -0800128 RemoveSimulcast(offer.get());
Amit Hilbuch619b2942019-02-26 15:55:19 -0800129 std::string err;
130 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &err)) << err;
131 auto answer = remote->CreateAnswerAndSetAsLocal();
132 // Setup the answer to look like a server response.
133 auto mcd_answer = answer->description()->contents()[0].media_description();
134 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
135 for (const SimulcastLayer& layer : answer_layers) {
136 receive_layers.AddLayer(layer);
137 }
138 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &err)) << err;
139 }
140
Amit Hilbuchaa584152019-02-06 17:09:52 -0800141 RtpTransceiverInit CreateTransceiverInit(
142 const std::vector<SimulcastLayer>& layers) {
143 RtpTransceiverInit init;
144 for (const SimulcastLayer& layer : layers) {
145 RtpEncodingParameters encoding;
146 encoding.rid = layer.rid;
147 encoding.active = !layer.is_paused;
148 init.send_encodings.push_back(encoding);
149 }
150 return init;
151 }
152
153 rtc::scoped_refptr<RtpTransceiverInterface> AddTransceiver(
154 PeerConnectionWrapper* pc,
155 const std::vector<SimulcastLayer>& layers) {
156 auto init = CreateTransceiverInit(layers);
157 return pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
158 }
159
160 SimulcastDescription RemoveSimulcast(SessionDescriptionInterface* sd) {
161 auto mcd = sd->description()->contents()[0].media_description();
162 auto result = mcd->simulcast_description();
163 mcd->set_simulcast_description(SimulcastDescription());
164 return result;
165 }
166
167 void AddRequestToReceiveSimulcast(const std::vector<SimulcastLayer>& layers,
168 SessionDescriptionInterface* sd) {
169 auto mcd = sd->description()->contents()[0].media_description();
170 SimulcastDescription simulcast;
171 auto& receive_layers = simulcast.receive_layers();
172 for (const SimulcastLayer& layer : layers) {
173 receive_layers.AddLayer(layer);
174 }
175 mcd->set_simulcast_description(simulcast);
176 }
177
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800178 void ValidateTransceiverParameters(
Amit Hilbuchaa584152019-02-06 17:09:52 -0800179 rtc::scoped_refptr<RtpTransceiverInterface> transceiver,
180 const std::vector<SimulcastLayer>& layers) {
Amit Hilbuchaa584152019-02-06 17:09:52 -0800181 auto parameters = transceiver->sender()->GetParameters();
182 std::vector<SimulcastLayer> result_layers;
183 absl::c_transform(parameters.encodings, std::back_inserter(result_layers),
184 [](const RtpEncodingParameters& encoding) {
185 return SimulcastLayer(encoding.rid, !encoding.active);
186 });
187 EXPECT_THAT(result_layers, ElementsAreArray(layers));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800188 }
189
190 private:
191 rtc::scoped_refptr<PeerConnectionFactoryInterface> pc_factory_;
192};
193
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800194// This class is used to test the metrics emitted for simulcast.
195class PeerConnectionSimulcastMetricsTests
196 : public PeerConnectionSimulcastTests,
197 public ::testing::WithParamInterface<int> {
198 protected:
199 PeerConnectionSimulcastMetricsTests() { webrtc::metrics::Reset(); }
200
201 std::map<int, int> LocalDescriptionSamples() {
202 return metrics::Samples(
203 "WebRTC.PeerConnection.Simulcast.ApplyLocalDescription");
204 }
205 std::map<int, int> RemoteDescriptionSamples() {
206 return metrics::Samples(
207 "WebRTC.PeerConnection.Simulcast.ApplyRemoteDescription");
208 }
209};
210
Amit Hilbuchaa584152019-02-06 17:09:52 -0800211// Validates that RIDs are supported arguments when adding a transceiver.
212TEST_F(PeerConnectionSimulcastTests, CanCreateTransceiverWithRid) {
213 auto pc = CreatePeerConnectionWrapper();
214 auto layers = CreateLayers({"f"}, true);
215 auto transceiver = AddTransceiver(pc.get(), layers);
216 ASSERT_TRUE(transceiver);
217 auto parameters = transceiver->sender()->GetParameters();
218 // Single RID should be removed.
219 EXPECT_THAT(parameters.encodings,
Amit Hilbuch2297d332019-02-19 12:49:22 -0800220 ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq(""))));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800221}
222
223TEST_F(PeerConnectionSimulcastTests, CanCreateTransceiverWithSimulcast) {
224 auto pc = CreatePeerConnectionWrapper();
225 auto layers = CreateLayers({"f", "h", "q"}, true);
226 auto transceiver = AddTransceiver(pc.get(), layers);
227 ASSERT_TRUE(transceiver);
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800228 ValidateTransceiverParameters(transceiver, layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800229}
230
231TEST_F(PeerConnectionSimulcastTests, RidsAreAutogeneratedIfNotProvided) {
232 auto pc = CreatePeerConnectionWrapper();
233 auto init = CreateTransceiverInit(CreateLayers({"f", "h", "q"}, true));
234 for (RtpEncodingParameters& parameters : init.send_encodings) {
235 parameters.rid = "";
236 }
237 auto transceiver = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
238 auto parameters = transceiver->sender()->GetParameters();
239 ASSERT_EQ(3u, parameters.encodings.size());
240 EXPECT_THAT(parameters.encodings,
Amit Hilbuch2297d332019-02-19 12:49:22 -0800241 Each(Field("rid", &RtpEncodingParameters::rid, Ne(""))));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800242}
243
244// Validates that an error is returned when there is a mix of supplied and not
245// supplied RIDs in a call to AddTransceiver.
246TEST_F(PeerConnectionSimulcastTests, MustSupplyAllOrNoRidsInSimulcast) {
247 auto pc_wrapper = CreatePeerConnectionWrapper();
248 auto pc = pc_wrapper->pc();
249 // Cannot create a layer with empty RID. Remove the RID after init is created.
250 auto layers = CreateLayers({"f", "h", "remove"}, true);
251 auto init = CreateTransceiverInit(layers);
252 init.send_encodings[2].rid = "";
253 auto error = pc->AddTransceiver(cricket::MEDIA_TYPE_VIDEO, init);
254 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, error.error().type());
255}
256
Amit Hilbuch2297d332019-02-19 12:49:22 -0800257// Validates that a single RID is removed from the encoding layer.
Amit Hilbuchaa584152019-02-06 17:09:52 -0800258TEST_F(PeerConnectionSimulcastTests, SingleRidIsRemovedFromSessionDescription) {
259 auto pc = CreatePeerConnectionWrapper();
260 auto transceiver = AddTransceiver(pc.get(), CreateLayers({"1"}, true));
261 auto offer = pc->CreateOfferAndSetAsLocal();
262 ASSERT_TRUE(offer);
263 auto contents = offer->description()->contents();
264 ASSERT_EQ(1u, contents.size());
265 EXPECT_THAT(contents[0].media_description()->streams(),
266 ElementsAre(Property(&StreamParams::has_rids, false)));
267}
268
269TEST_F(PeerConnectionSimulcastTests, SimulcastLayersRemovedFromTail) {
270 static_assert(
271 kMaxSimulcastStreams < 8,
272 "Test assumes that the platform does not allow 8 simulcast layers");
273 auto pc = CreatePeerConnectionWrapper();
274 auto layers = CreateLayers({"1", "2", "3", "4", "5", "6", "7", "8"}, true);
275 std::vector<SimulcastLayer> expected_layers;
276 std::copy_n(layers.begin(), kMaxSimulcastStreams,
277 std::back_inserter(expected_layers));
278 auto transceiver = AddTransceiver(pc.get(), layers);
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800279 ValidateTransceiverParameters(transceiver, expected_layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800280}
281
282// Checks that an offfer to send simulcast contains a SimulcastDescription.
283TEST_F(PeerConnectionSimulcastTests, SimulcastAppearsInSessionDescription) {
284 auto pc = CreatePeerConnectionWrapper();
285 std::vector<std::string> rids({"f", "h", "q"});
286 auto layers = CreateLayers(rids, true);
287 auto transceiver = AddTransceiver(pc.get(), layers);
288 auto offer = pc->CreateOffer();
289 ASSERT_TRUE(offer);
290 auto contents = offer->description()->contents();
291 ASSERT_EQ(1u, contents.size());
292 auto content = contents[0];
293 auto mcd = content.media_description();
294 ASSERT_TRUE(mcd->HasSimulcast());
295 auto simulcast = mcd->simulcast_description();
296 EXPECT_THAT(simulcast.receive_layers(), IsEmpty());
297 // The size is validated separately because GetAllLayers() flattens the list.
298 EXPECT_THAT(simulcast.send_layers(), SizeIs(3));
299 std::vector<SimulcastLayer> result = simulcast.send_layers().GetAllLayers();
300 EXPECT_THAT(result, ElementsAreArray(layers));
301 auto streams = mcd->streams();
302 ASSERT_EQ(1u, streams.size());
303 auto stream = streams[0];
304 EXPECT_FALSE(stream.has_ssrcs());
305 EXPECT_TRUE(stream.has_rids());
306 std::vector<std::string> result_rids;
307 absl::c_transform(stream.rids(), std::back_inserter(result_rids),
308 [](const RidDescription& rid) { return rid.rid; });
309 EXPECT_THAT(result_rids, ElementsAreArray(rids));
310}
311
312// Checks that Simulcast layers propagate to the sender parameters.
313TEST_F(PeerConnectionSimulcastTests, SimulcastLayersAreSetInSender) {
314 auto local = CreatePeerConnectionWrapper();
315 auto remote = CreatePeerConnectionWrapper();
316 auto layers = CreateLayers({"f", "h", "q"}, true);
317 auto transceiver = AddTransceiver(local.get(), layers);
318 auto offer = local->CreateOfferAndSetAsLocal();
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800319 {
320 SCOPED_TRACE("after create offer");
321 ValidateTransceiverParameters(transceiver, layers);
322 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800323 // Remove simulcast as the second peer connection won't support it.
324 auto simulcast = RemoveSimulcast(offer.get());
325 std::string error;
326 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
327 auto answer = remote->CreateAnswerAndSetAsLocal();
328
329 // Setup an answer that mimics a server accepting simulcast.
330 auto mcd_answer = answer->description()->contents()[0].media_description();
331 mcd_answer->mutable_streams().clear();
332 auto simulcast_layers = simulcast.send_layers().GetAllLayers();
333 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
334 for (const auto& layer : simulcast_layers) {
335 receive_layers.AddLayer(layer);
336 }
337 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800338 {
339 SCOPED_TRACE("after set remote");
340 ValidateTransceiverParameters(transceiver, layers);
341 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800342}
343
344// Checks that paused Simulcast layers propagate to the sender parameters.
345TEST_F(PeerConnectionSimulcastTests, PausedSimulcastLayersAreDisabledInSender) {
346 auto local = CreatePeerConnectionWrapper();
347 auto remote = CreatePeerConnectionWrapper();
348 auto layers = CreateLayers({"f", "h", "q"}, {true, false, true});
349 auto server_layers = CreateLayers({"f", "h", "q"}, {true, false, false});
350 RTC_DCHECK_EQ(layers.size(), server_layers.size());
351 auto transceiver = AddTransceiver(local.get(), layers);
352 auto offer = local->CreateOfferAndSetAsLocal();
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800353 {
354 SCOPED_TRACE("after create offer");
355 ValidateTransceiverParameters(transceiver, layers);
356 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800357
358 // Remove simulcast as the second peer connection won't support it.
359 RemoveSimulcast(offer.get());
360 std::string error;
361 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
362 auto answer = remote->CreateAnswerAndSetAsLocal();
363
364 // Setup an answer that mimics a server accepting simulcast.
365 auto mcd_answer = answer->description()->contents()[0].media_description();
366 mcd_answer->mutable_streams().clear();
367 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
368 for (const SimulcastLayer& layer : server_layers) {
369 receive_layers.AddLayer(layer);
370 }
371 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800372 {
373 SCOPED_TRACE("after set remote");
374 ValidateTransceiverParameters(transceiver, server_layers);
375 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800376}
377
378// Checks that when Simulcast is not supported by the remote party, then all
Amit Hilbuch2297d332019-02-19 12:49:22 -0800379// the layers (except the first) are removed.
380TEST_F(PeerConnectionSimulcastTests, SimulcastRejectedRemovesExtraLayers) {
Amit Hilbuchaa584152019-02-06 17:09:52 -0800381 auto local = CreatePeerConnectionWrapper();
382 auto remote = CreatePeerConnectionWrapper();
383 auto layers = CreateLayers({"1", "2", "3", "4"}, true);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800384 auto transceiver = AddTransceiver(local.get(), layers);
Amit Hilbuch619b2942019-02-26 15:55:19 -0800385 ExchangeOfferAnswer(local.get(), remote.get(), {});
Amit Hilbuch2297d332019-02-19 12:49:22 -0800386 auto parameters = transceiver->sender()->GetParameters();
387 // Should only have the first layer.
388 EXPECT_THAT(parameters.encodings,
389 ElementsAre(Field("rid", &RtpEncodingParameters::rid, Eq("1"))));
Amit Hilbuchaa584152019-02-06 17:09:52 -0800390}
391
Amit Hilbuch2297d332019-02-19 12:49:22 -0800392// Checks that if Simulcast is supported by remote party, but some layers are
393// rejected, then only rejected layers are removed from the sender.
Amit Hilbuchaa584152019-02-06 17:09:52 -0800394TEST_F(PeerConnectionSimulcastTests, RejectedSimulcastLayersAreDeactivated) {
395 auto local = CreatePeerConnectionWrapper();
396 auto remote = CreatePeerConnectionWrapper();
397 auto layers = CreateLayers({"1", "2", "3", "4"}, true);
Amit Hilbuch2297d332019-02-19 12:49:22 -0800398 auto expected_layers = CreateLayers({"2", "3", "4"}, true);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800399 auto transceiver = AddTransceiver(local.get(), layers);
400 auto offer = local->CreateOfferAndSetAsLocal();
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800401 {
402 SCOPED_TRACE("after create offer");
403 ValidateTransceiverParameters(transceiver, layers);
404 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800405 // Remove simulcast as the second peer connection won't support it.
406 auto removed_simulcast = RemoveSimulcast(offer.get());
407 std::string error;
408 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
409 auto answer = remote->CreateAnswerAndSetAsLocal();
410 auto mcd_answer = answer->description()->contents()[0].media_description();
411 // Setup the answer to look like a server response.
412 // Remove one of the layers to reject it in the answer.
413 auto simulcast_layers = removed_simulcast.send_layers().GetAllLayers();
414 simulcast_layers.erase(simulcast_layers.begin());
415 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
416 for (const auto& layer : simulcast_layers) {
417 receive_layers.AddLayer(layer);
418 }
419 ASSERT_TRUE(mcd_answer->HasSimulcast());
420 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800421 {
422 SCOPED_TRACE("after set remote");
423 ValidateTransceiverParameters(transceiver, expected_layers);
424 }
Amit Hilbuchaa584152019-02-06 17:09:52 -0800425}
426
427// Checks that simulcast is set up correctly when the server sends an offer
428// requesting to receive simulcast.
429TEST_F(PeerConnectionSimulcastTests, ServerSendsOfferToReceiveSimulcast) {
430 auto local = CreatePeerConnectionWrapper();
431 auto remote = CreatePeerConnectionWrapper();
432 auto layers = CreateLayers({"f", "h", "q"}, true);
433 AddTransceiver(local.get(), layers);
434 auto offer = local->CreateOfferAndSetAsLocal();
435 // Remove simulcast as a sender and set it up as a receiver.
436 RemoveSimulcast(offer.get());
437 AddRequestToReceiveSimulcast(layers, offer.get());
438 std::string error;
439 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
440 auto transceiver = remote->pc()->GetTransceivers()[0];
441 transceiver->SetDirection(RtpTransceiverDirection::kSendRecv);
442 EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal());
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800443 ValidateTransceiverParameters(transceiver, layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800444}
445
446// Checks that SetRemoteDescription doesn't attempt to associate a transceiver
447// when simulcast is requested by the server.
448TEST_F(PeerConnectionSimulcastTests, TransceiverIsNotRecycledWithSimulcast) {
449 auto local = CreatePeerConnectionWrapper();
450 auto remote = CreatePeerConnectionWrapper();
451 auto layers = CreateLayers({"f", "h", "q"}, true);
452 AddTransceiver(local.get(), layers);
453 auto offer = local->CreateOfferAndSetAsLocal();
454 // Remove simulcast as a sender and set it up as a receiver.
455 RemoveSimulcast(offer.get());
456 AddRequestToReceiveSimulcast(layers, offer.get());
457 // Call AddTrack so that a transceiver is created.
458 remote->AddVideoTrack("fake_track");
459 std::string error;
460 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
461 auto transceivers = remote->pc()->GetTransceivers();
462 ASSERT_EQ(2u, transceivers.size());
463 auto transceiver = transceivers[1];
464 transceiver->SetDirection(RtpTransceiverDirection::kSendRecv);
465 EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal());
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800466 ValidateTransceiverParameters(transceiver, layers);
Amit Hilbuchaa584152019-02-06 17:09:52 -0800467}
468
Amit Hilbuch619b2942019-02-26 15:55:19 -0800469// Checks that if the number of layers changes during negotiation, then any
470// outstanding get/set parameters transaction is invalidated.
471TEST_F(PeerConnectionSimulcastTests, ParametersAreInvalidatedWhenLayersChange) {
472 auto local = CreatePeerConnectionWrapper();
473 auto remote = CreatePeerConnectionWrapper();
474 auto layers = CreateLayers({"1", "2", "3"}, true);
475 auto transceiver = AddTransceiver(local.get(), layers);
476 auto parameters = transceiver->sender()->GetParameters();
477 ASSERT_EQ(3u, parameters.encodings.size());
478 // Response will reject simulcast altogether.
479 ExchangeOfferAnswer(local.get(), remote.get(), {});
480 auto result = transceiver->sender()->SetParameters(parameters);
481 EXPECT_EQ(RTCErrorType::INVALID_STATE, result.type());
482}
483
484// Checks that even though negotiation modifies the sender's parameters, an
485// outstanding get/set parameters transaction is not invalidated.
486// This test negotiates twice because initial parameters before negotiation
487// is missing critical information and cannot be set on the sender.
488TEST_F(PeerConnectionSimulcastTests,
489 NegotiationDoesNotInvalidateParameterTransactions) {
490 auto local = CreatePeerConnectionWrapper();
491 auto remote = CreatePeerConnectionWrapper();
492 auto layers = CreateLayers({"1", "2", "3"}, true);
493 auto expected_layers = CreateLayers({"1", "2", "3"}, false);
494 auto transceiver = AddTransceiver(local.get(), layers);
495 ExchangeOfferAnswer(local.get(), remote.get(), expected_layers);
496
497 // Verify that negotiation does not invalidate the parameters.
498 auto parameters = transceiver->sender()->GetParameters();
499 ExchangeOfferAnswer(local.get(), remote.get(), expected_layers);
500
501 auto result = transceiver->sender()->SetParameters(parameters);
502 EXPECT_TRUE(result.ok());
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800503 ValidateTransceiverParameters(transceiver, expected_layers);
Amit Hilbuch619b2942019-02-26 15:55:19 -0800504}
505
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800506// Tests that simulcast is disabled if the RID extension is not negotiated
507// regardless of if the RIDs and simulcast attribute were negotiated properly.
Amit Hilbuchaabd0362019-03-01 13:14:46 -0800508TEST_F(PeerConnectionSimulcastTests, NegotiationDoesNotHaveRidExtension) {
509 auto local = CreatePeerConnectionWrapper();
510 auto remote = CreatePeerConnectionWrapper();
511 auto layers = CreateLayers({"1", "2", "3"}, true);
512 auto expected_layers = CreateLayers({"1"}, true);
513 auto transceiver = AddTransceiver(local.get(), layers);
514 auto offer = local->CreateOfferAndSetAsLocal();
515 // Remove simulcast as the second peer connection won't support it.
516 RemoveSimulcast(offer.get());
517 std::string err;
518 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &err)) << err;
519 auto answer = remote->CreateAnswerAndSetAsLocal();
520 // Setup the answer to look like a server response.
521 // Drop the RID header extension.
522 auto mcd_answer = answer->description()->contents()[0].media_description();
523 auto& receive_layers = mcd_answer->simulcast_description().receive_layers();
524 for (const SimulcastLayer& layer : layers) {
525 receive_layers.AddLayer(layer);
526 }
527 cricket::RtpHeaderExtensions extensions;
528 for (auto extension : mcd_answer->rtp_header_extensions()) {
529 if (extension.uri != RtpExtension::kRidUri) {
530 extensions.push_back(extension);
531 }
532 }
533 mcd_answer->set_rtp_header_extensions(extensions);
534 EXPECT_EQ(layers.size(), mcd_answer->simulcast_description()
535 .receive_layers()
536 .GetAllLayers()
537 .size());
538 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &err)) << err;
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800539 ValidateTransceiverParameters(transceiver, expected_layers);
Amit Hilbuchaabd0362019-03-01 13:14:46 -0800540}
Amit Hilbuche2a284d2019-03-05 12:36:31 -0800541//
542// Checks the logged metrics when simulcast is not used.
543TEST_F(PeerConnectionSimulcastMetricsTests, NoSimulcastUsageIsLogged) {
544 auto local = CreatePeerConnectionWrapper();
545 auto remote = CreatePeerConnectionWrapper();
546 auto layers = CreateLayers(0, true);
547 AddTransceiver(local.get(), layers);
548 ExchangeOfferAnswer(local.get(), remote.get(), layers);
549
550 EXPECT_THAT(LocalDescriptionSamples(),
551 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
552 EXPECT_THAT(RemoteDescriptionSamples(),
553 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
554}
555
556// Checks the logged metrics when spec-compliant simulcast is used.
557TEST_F(PeerConnectionSimulcastMetricsTests, SpecComplianceIsLogged) {
558 auto local = CreatePeerConnectionWrapper();
559 auto remote = CreatePeerConnectionWrapper();
560 auto layers = CreateLayers(3, true);
561 AddTransceiver(local.get(), layers);
562 ExchangeOfferAnswer(local.get(), remote.get(), layers);
563
564 // Expecting 2 invocations of each, because we have 2 peer connections.
565 // Only the local peer connection will be aware of simulcast.
566 // The remote peer connection will think that there is no simulcast.
567 EXPECT_THAT(LocalDescriptionSamples(),
568 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
569 Pair(kSimulcastApiVersionSpecCompliant, 1)));
570 EXPECT_THAT(RemoteDescriptionSamples(),
571 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
572 Pair(kSimulcastApiVersionSpecCompliant, 1)));
573}
574
575// Checks the logged metrics when and incoming request to send spec-compliant
576// simulcast is received from the remote party.
577TEST_F(PeerConnectionSimulcastMetricsTests, IncomingSimulcastIsLogged) {
578 auto local = CreatePeerConnectionWrapper();
579 auto remote = CreatePeerConnectionWrapper();
580 auto layers = CreateLayers(3, true);
581 AddTransceiver(local.get(), layers);
582 auto offer = local->CreateOfferAndSetAsLocal();
583 EXPECT_THAT(LocalDescriptionSamples(),
584 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1)));
585
586 // Remove simulcast as a sender and set it up as a receiver.
587 RemoveSimulcast(offer.get());
588 AddRequestToReceiveSimulcast(layers, offer.get());
589 std::string error;
590 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
591 EXPECT_THAT(RemoteDescriptionSamples(),
592 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1)));
593
594 auto transceiver = remote->pc()->GetTransceivers()[0];
595 transceiver->SetDirection(RtpTransceiverDirection::kSendRecv);
596 EXPECT_TRUE(remote->CreateAnswerAndSetAsLocal());
597 EXPECT_THAT(LocalDescriptionSamples(),
598 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 2)));
599}
600
601// Checks that a spec-compliant simulcast offer that is rejected is logged.
602TEST_F(PeerConnectionSimulcastMetricsTests, RejectedSimulcastIsLogged) {
603 auto local = CreatePeerConnectionWrapper();
604 auto remote = CreatePeerConnectionWrapper();
605 auto layers = CreateLayers({"1", "2", "3"}, true);
606 AddTransceiver(local.get(), layers);
607 auto offer = local->CreateOfferAndSetAsLocal();
608 EXPECT_THAT(LocalDescriptionSamples(),
609 ElementsAre(Pair(kSimulcastApiVersionSpecCompliant, 1)));
610 RemoveSimulcast(offer.get());
611 std::string error;
612 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
613 EXPECT_THAT(RemoteDescriptionSamples(),
614 ElementsAre(Pair(kSimulcastApiVersionNone, 1)));
615
616 auto answer = remote->CreateAnswerAndSetAsLocal();
617 EXPECT_THAT(LocalDescriptionSamples(),
618 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
619 Pair(kSimulcastApiVersionSpecCompliant, 1)));
620 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
621 EXPECT_THAT(RemoteDescriptionSamples(),
622 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
623}
624
625// Checks the logged metrics when legacy munging simulcast technique is used.
626TEST_F(PeerConnectionSimulcastMetricsTests, LegacySimulcastIsLogged) {
627 auto local = CreatePeerConnectionWrapper();
628 auto remote = CreatePeerConnectionWrapper();
629 auto layers = CreateLayers(0, true);
630 AddTransceiver(local.get(), layers);
631 auto offer = local->CreateOffer();
632 // Munge the SDP to set up legacy simulcast.
633 const std::string end_line = "\r\n";
634 std::string sdp;
635 offer->ToString(&sdp);
636 rtc::StringBuilder builder(sdp);
637 builder << "a=ssrc:1111 cname:slimshady" << end_line;
638 builder << "a=ssrc:2222 cname:slimshady" << end_line;
639 builder << "a=ssrc:3333 cname:slimshady" << end_line;
640 builder << "a=ssrc-group:SIM 1111 2222 3333" << end_line;
641
642 SdpParseError parse_error;
643 auto sd =
644 CreateSessionDescription(SdpType::kOffer, builder.str(), &parse_error);
645 ASSERT_TRUE(sd) << parse_error.line << parse_error.description;
646 std::string error;
647 EXPECT_TRUE(local->SetLocalDescription(std::move(sd), &error)) << error;
648 EXPECT_THAT(LocalDescriptionSamples(),
649 ElementsAre(Pair(kSimulcastApiVersionLegacy, 1)));
650 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
651 EXPECT_THAT(RemoteDescriptionSamples(),
652 ElementsAre(Pair(kSimulcastApiVersionNone, 1)));
653 auto answer = remote->CreateAnswerAndSetAsLocal();
654 EXPECT_THAT(LocalDescriptionSamples(),
655 ElementsAre(Pair(kSimulcastApiVersionNone, 1),
656 Pair(kSimulcastApiVersionLegacy, 1)));
657 // Legacy simulcast is not signaled in remote description.
658 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
659 EXPECT_THAT(RemoteDescriptionSamples(),
660 ElementsAre(Pair(kSimulcastApiVersionNone, 2)));
661}
662
663// Checks that disabling simulcast is logged in the metrics.
664TEST_F(PeerConnectionSimulcastMetricsTests, SimulcastDisabledIsLogged) {
665 auto local = CreatePeerConnectionWrapper();
666 auto remote = CreatePeerConnectionWrapper();
667 auto layers = CreateLayers({"1", "2", "3"}, true);
668 AddTransceiver(local.get(), layers);
669 auto offer = local->CreateOfferAndSetAsLocal();
670 RemoveSimulcast(offer.get());
671 std::string error;
672 EXPECT_TRUE(remote->SetRemoteDescription(std::move(offer), &error)) << error;
673 auto answer = remote->CreateAnswerAndSetAsLocal();
674 EXPECT_TRUE(local->SetRemoteDescription(std::move(answer), &error)) << error;
675
676 EXPECT_EQ(1, metrics::NumSamples("WebRTC.PeerConnection.Simulcast.Disabled"));
677 EXPECT_EQ(1,
678 metrics::NumEvents("WebRTC.PeerConnection.Simulcast.Disabled", 1));
679}
680
681// Checks that the disabled metric is not logged if simulcast is not disabled.
682TEST_F(PeerConnectionSimulcastMetricsTests, SimulcastDisabledIsNotLogged) {
683 auto local = CreatePeerConnectionWrapper();
684 auto remote = CreatePeerConnectionWrapper();
685 auto layers = CreateLayers({"1", "2", "3"}, true);
686 AddTransceiver(local.get(), layers);
687 ExchangeOfferAnswer(local.get(), remote.get(), layers);
688
689 EXPECT_EQ(0, metrics::NumSamples("WebRTC.PeerConnection.Simulcast.Disabled"));
690}
691
692const int kMaxLayersInMetricsTest = 8;
693
694// Checks that the number of send encodings is logged in a metric.
695TEST_P(PeerConnectionSimulcastMetricsTests, NumberOfSendEncodingsIsLogged) {
696 auto local = CreatePeerConnectionWrapper();
697 auto num_layers = GetParam();
698 auto layers = CreateLayers(num_layers, true);
699 AddTransceiver(local.get(), layers);
700 EXPECT_EQ(1, metrics::NumSamples(
701 "WebRTC.PeerConnection.Simulcast.NumberOfSendEncodings"));
702 EXPECT_EQ(1, metrics::NumEvents(
703 "WebRTC.PeerConnection.Simulcast.NumberOfSendEncodings",
704 num_layers));
705}
706
707INSTANTIATE_TEST_SUITE_P(NumberOfSendEncodings,
708 PeerConnectionSimulcastMetricsTests,
709 ::testing::Range(0, kMaxLayersInMetricsTest));
Amit Hilbuchaabd0362019-03-01 13:14:46 -0800710
Amit Hilbuchaa584152019-02-06 17:09:52 -0800711} // namespace webrtc