blob: 39dc3b422c072e8a4ed73e0a3abceb41d866e53d [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
11#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080012#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020013#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Steve Anton2c9ebef2019-01-28 17:27:58 -080017#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010018#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020019#include "absl/strings/match.h"
Anton Sukhanov4f08faa2019-05-21 11:12:57 -070020#include "api/media_transport_config.h"
Steve Anton10542f22019-01-11 09:11:00 -080021#include "api/rtp_parameters.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070022#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080023#include "api/test/mock_video_bitrate_allocator.h"
24#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070025#include "api/test/mock_video_decoder_factory.h"
26#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020027#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080028#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010029#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020030#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020031#include "api/video_codecs/builtin_video_decoder_factory.h"
32#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020033#include "api/video_codecs/sdp_video_format.h"
34#include "api/video_codecs/video_decoder_factory.h"
35#include "api/video_codecs/video_encoder.h"
36#include "api/video_codecs/video_encoder_factory.h"
37#include "call/flexfec_receive_stream.h"
38#include "common_video/h264/profile_level_id.h"
39#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010040#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080041#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080042#include "media/base/fake_video_renderer.h"
43#include "media/base/media_constants.h"
44#include "media/base/rtp_utils.h"
45#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080047#include "media/engine/fake_webrtc_call.h"
48#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/webrtc_video_engine.h"
51#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020052#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020053#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080054#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020056#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080057#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020058#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010059#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020060#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000061
Mirko Bonadei6a489f22019-04-09 15:11:12 +020062using ::testing::Field;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010063using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070064using webrtc::RtpExtension;
65
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000066namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000067static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000068
noahricd10a68e2015-07-10 11:27:55 -070069static const uint8_t kRedRtxPayloadType = 125;
70
Niels Möller6557d0c2018-04-11 15:18:34 +020071static const uint32_t kTimeout = 5000U;
72static const uint32_t kDefaultReceiveSsrc = 0;
73static const uint32_t kSsrc = 1234u;
74static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
75static const int kVideoWidth = 640;
76static const int kVideoHeight = 360;
77static const int kFramerate = 30;
78
Peter Boström0c4e06b2015-10-07 12:23:21 +020079static const uint32_t kSsrcs1[] = {1};
80static const uint32_t kSsrcs3[] = {1, 2, 3};
81static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080082static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020083static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080084static const uint32_t kDefaultRecvSsrc = 0;
85
pbos@webrtc.org3c107582014-07-20 15:27:35 +000086static const char kUnsupportedExtensionName[] =
87 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000088
magjed509e4fe2016-11-18 01:34:11 -080089cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
90 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020091 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080092}
93
Elad Alonfadb1812019-05-24 13:40:02 +020094void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
95 bool lntf_expected) {
96 EXPECT_EQ(lntf_expected,
97 codec.HasFeedbackParam(cricket::FeedbackParam(
98 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000099 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
100 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
101 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
102 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
103 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
104 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
105 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800106 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
107 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000108 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
109}
110
magjed725e4842016-11-16 00:48:13 -0800111// Return true if any codec in |codecs| is an RTX codec with associated payload
112// type |payload_type|.
113bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
114 int payload_type) {
115 for (const cricket::VideoCodec& codec : codecs) {
116 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200117 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800118 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
119 &associated_payload_type) &&
120 associated_payload_type == payload_type) {
121 return true;
122 }
123 }
124 return false;
125}
126
nisseca5706d2017-09-11 02:32:16 -0700127// TODO(nisse): Duplicated in call.cc.
128const int* FindKeyByValue(const std::map<int, int>& m, int v) {
129 for (const auto& kv : m) {
130 if (kv.second == v)
131 return &kv.first;
132 }
133 return nullptr;
134}
135
Yves Gerey665174f2018-06-19 15:03:05 +0200136bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
137 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700138 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
139 payload_type) != nullptr;
140}
141
142// Check that there's an Rtx payload type for each decoder.
143bool VerifyRtxReceiveAssociations(
144 const webrtc::VideoReceiveStream::Config& config) {
145 for (const auto& decoder : config.decoders) {
146 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
147 return false;
148 }
149 return true;
150}
151
brandtrffc61182016-11-28 06:02:22 -0800152rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700153 int width,
154 int height) {
155 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
156 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800157 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700158 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000159}
160
Shao Changbine62202f2015-04-21 20:24:50 +0800161void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
162 const std::map<int, int>& rtx_types) {
163 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200164 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800165 EXPECT_TRUE(it != rtx_types.end() &&
166 it->second == config.rtp.rtx.payload_type);
167
brandtrb5f2c3f2016-10-04 23:28:39 -0700168 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
169 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800170 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700171 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800172 }
173}
kthelgason2bc68642017-02-07 07:02:22 -0800174
175cricket::MediaConfig GetMediaConfig() {
176 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100177 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800178 return media_config;
179}
nisse26e3abb2017-08-25 04:44:25 -0700180
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200181// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
182int GetMaxDefaultBitrateBps(size_t width, size_t height) {
183 if (width * height <= 320 * 240) {
184 return 600000;
185 } else if (width * height <= 640 * 480) {
186 return 1700000;
187 } else if (width * height <= 960 * 540) {
188 return 2000000;
189 } else {
190 return 2500000;
191 }
192}
193
Niels Möller731a2c22018-07-30 15:08:07 +0200194class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
195 public:
196 MOCK_METHOD2(AddOrUpdateSink,
197 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
198 const rtc::VideoSinkWants& wants));
199 MOCK_METHOD1(RemoveSink,
200 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
201};
202
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000203} // namespace
204
Yves Gerey665174f2018-06-19 15:03:05 +0200205#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200206 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200207 EXPECT_EQ((w), renderer_.width()); \
208 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200209 EXPECT_EQ(0, renderer_.errors());
210
Yves Gerey665174f2018-06-19 15:03:05 +0200211#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200212 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200213 EXPECT_EQ((w), (r).width()); \
214 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200215 EXPECT_EQ(0, (r).errors());
216
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000217namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700218class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000219 public:
eladalonf1841382017-06-12 01:16:46 -0700220 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200221 explicit WebRtcVideoEngineTest(const std::string& field_trials)
222 : override_field_trials_(
223 field_trials.empty()
224 ? nullptr
225 : absl::make_unique<webrtc::test::ScopedFieldTrials>(
226 field_trials)),
skvlad11a9cbf2016-10-07 11:53:05 -0700227 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200228 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
229 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200230 video_bitrate_allocator_factory_(
231 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200232 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200233 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200234 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200235 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200236 // Ensure fake clock doesn't return 0, which will cause some initializations
237 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200238 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200239 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000240
241 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200242 void AssignDefaultAptRtxTypes();
243 void AssignDefaultCodec();
244
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100245 // Find the index of the codec in the engine with the given name. The codec
246 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100247 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100248
magjed509e4fe2016-11-18 01:34:11 -0800249 // Find the codec in the engine with the given name. The codec must be
250 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100251 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800252
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200253 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000254
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200255 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000256 const std::vector<VideoCodec>& codecs);
257
Elad Alon157540a2019-02-08 23:37:52 +0100258 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100259
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200260 // Has to be the first one, so it is initialized before the call or there is a
261 // race condition in the clock access.
262 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200263 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700264 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700265 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000266 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800267 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200268 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
269 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200270 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
271 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700272 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000273 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800274 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000275};
276
eladalonf1841382017-06-12 01:16:46 -0700277TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200278 encoder_factory_->AddSupportedVideoCodecType("VP8");
279 AssignDefaultCodec();
280
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000281 std::vector<VideoCodec> engine_codecs = engine_.codecs();
282 for (size_t i = 0; i < engine_codecs.size(); ++i) {
283 if (engine_codecs[i].name != kRtxCodecName)
284 continue;
285 int associated_payload_type;
286 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000287 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000288 EXPECT_EQ(default_codec_.id, associated_payload_type);
289 return;
290 }
291 FAIL() << "No RTX codec found among default codecs.";
292}
293
eladalonf1841382017-06-12 01:16:46 -0700294TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100295 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000296}
297
eladalonf1841382017-06-12 01:16:46 -0700298TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100299 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000300}
301
eladalonf1841382017-06-12 01:16:46 -0700302TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100303 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700304}
305
eladalonf1841382017-06-12 01:16:46 -0700306TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100307 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
308}
309
310TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
311 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
312}
313
314TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
315 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
316}
317
318TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
319 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
320}
321
322TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
323 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100324}
325
326TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100327 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
328}
329
Elad Alonccb9b752019-02-19 13:01:31 +0100330TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
331 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
332}
333
334TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
335 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700336}
337
philipel1e054862018-10-08 16:13:53 +0200338class WebRtcVideoEngineTestWithGenericDescriptor
339 : public WebRtcVideoEngineTest {
340 public:
341 WebRtcVideoEngineTestWithGenericDescriptor()
342 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
343};
344
Elad Alonccb9b752019-02-19 13:01:31 +0100345TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
346 AdvertiseGenericDescriptor00) {
347 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
348}
349
350TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
351 AdvertiseGenericDescriptor01) {
352 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200353}
354
eladalonf1841382017-06-12 01:16:46 -0700355TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200356 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700357 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200358 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700359
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200360 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700361
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200362 std::unique_ptr<VideoMediaChannel> channel(
363 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700364 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
365
366 // Add CVO extension.
367 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800368 cricket::VideoSendParameters parameters;
369 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200370 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700371 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200372 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373
Niels Möller731a2c22018-07-30 15:08:07 +0200374 EXPECT_CALL(
375 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200376 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200377 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700378 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200379 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700380
381 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200382 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700383
384 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200385 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200386 EXPECT_CALL(
387 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200388 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200389 Field(&rtc::VideoSinkWants::rotation_applied, true)));
390
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200391 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700392}
393
eladalonf1841382017-06-12 01:16:46 -0700394TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200395 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800396 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200397 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800398
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200399 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800400
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200401 std::unique_ptr<VideoMediaChannel> channel(
402 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800403 // Add CVO extension.
404 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800405 cricket::VideoSendParameters parameters;
406 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800407 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700408 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800409 EXPECT_TRUE(channel->SetSendParameters(parameters));
410 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
411
Niels Möller731a2c22018-07-30 15:08:07 +0200412 // Set source.
413 EXPECT_CALL(
414 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200415 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200416 Field(&rtc::VideoSinkWants::rotation_applied, false)));
417 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800418}
419
eladalonf1841382017-06-12 01:16:46 -0700420TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200421 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700422
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200423 encoder_factory_->AddSupportedVideoCodecType("VP8");
424 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700425
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200426 std::unique_ptr<VideoMediaChannel> channel(
427 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700428 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
429
430 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200431 EXPECT_CALL(
432 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200433 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200434 Field(&rtc::VideoSinkWants::rotation_applied, true)));
435 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700436
perkjcaafdba2016-03-20 07:34:29 -0700437 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200438 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700439
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700440 // Add CVO extension.
441 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800442 cricket::VideoSendParameters parameters;
443 parameters.codecs.push_back(GetEngineCodec("VP8"));
444 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200445 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700446 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700447 // Also remove the first codec to trigger a codec change as well.
448 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200449 EXPECT_CALL(
450 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200451 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200452 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200453 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700454
455 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200456 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700457
458 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200459 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200460 EXPECT_CALL(
461 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200462 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200463 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200464 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700465}
466
eladalonf1841382017-06-12 01:16:46 -0700467TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200468 encoder_factory_->AddSupportedVideoCodecType("VP8");
469
Sebastian Jansson84848f22018-11-16 10:40:36 +0100470 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200471 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
472 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000473
474 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
475
476 EXPECT_FALSE(channel->SetSend(true))
477 << "Channel should not start without codecs.";
478 EXPECT_TRUE(channel->SetSend(false))
479 << "Channel should be stoppable even without set codecs.";
480}
481
eladalonf1841382017-06-12 01:16:46 -0700482TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200483 encoder_factory_->AddSupportedVideoCodecType("VP8");
484
Sebastian Jansson84848f22018-11-16 10:40:36 +0100485 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200486 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
487 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000488 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
489 VideoMediaInfo info;
490 channel->GetStats(&info);
491}
492
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200493TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200494 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000495
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200496 std::unique_ptr<VideoMediaChannel> channel(
497 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800498 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000499
500 EXPECT_TRUE(
501 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200502 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000503 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100504 webrtc::test::FrameForwarder frame_forwarder;
505 cricket::FakeFrameSource frame_source(1280, 720,
506 rtc::kNumMicrosecsPerSec / 30);
507 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
508 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100509 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200510 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
511 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000512 kTimeout);
513
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200514 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100515 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000516
517 // Setting codecs of the same type should not reallocate any encoders
518 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800519 cricket::VideoSendParameters parameters;
520 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200521 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200522 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000523
524 // Remove stream previously added to free the external encoder instance.
525 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200526 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000527}
528
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200529// Test that when an encoder factory supports H264, we add an RTX
530// codec for it.
531// TODO(deadbeef): This test should be updated if/when we start
532// adding RTX codecs for unrecognized codec names.
533TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800534 using webrtc::H264::ProfileLevelIdToString;
535 using webrtc::H264::ProfileLevelId;
536 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200537 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
538 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800539 *ProfileLevelIdToString(
540 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200541 webrtc::SdpVideoFormat h264_constrained_high("H264");
542 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800543 *ProfileLevelIdToString(
544 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200545 webrtc::SdpVideoFormat h264_high("H264");
546 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800547 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
548
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200549 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
550 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
551 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700552
magjed725e4842016-11-16 00:48:13 -0800553 // First figure out what payload types the test codecs got assigned.
554 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800555 // Now search for RTX codecs for them. Expect that they all have associated
556 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800557 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200558 codecs,
559 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
560 ->id));
magjed725e4842016-11-16 00:48:13 -0800561 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200562 codecs,
563 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
564 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800565 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200566 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700567}
568
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100569#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700570TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200571 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100572
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200573 std::unique_ptr<VideoMediaChannel> channel(
574 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100575
576 EXPECT_TRUE(
577 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
578}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100579#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100580
eladalonf1841382017-06-12 01:16:46 -0700581TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200582 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100583 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200584 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200585 std::unique_ptr<VideoMediaChannel> channel(
586 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700587
588 EXPECT_TRUE(
589 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
590
Niels Möllerd0f0f682019-01-14 09:09:53 +0100591 webrtc::test::FrameForwarder frame_forwarder;
592 cricket::FakeFrameSource frame_source(1280, 720,
593 rtc::kNumMicrosecsPerSec / 60);
594 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700595 channel->SetSend(true);
596
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200597 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700598
Niels Möllerd0f0f682019-01-14 09:09:53 +0100599 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700600 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700601 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100602 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700603 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700604 int64_t interval = timestamp - last_timestamp;
605
606 // Precision changes from nanosecond to millisecond.
607 // Allow error to be no more than 1.
608 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
609
610 last_timestamp = timestamp;
611 }
612
Niels Möllerd0f0f682019-01-14 09:09:53 +0100613 frame_forwarder.IncomingCapturedFrame(
614 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
615 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700616 last_timestamp = stream->GetLastTimestamp();
617 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100618 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
619 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
620 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700621 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700622 int64_t interval = timestamp - last_timestamp;
623
624 // Precision changes from nanosecond to millisecond.
625 // Allow error to be no more than 1.
626 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
627
628 last_timestamp = timestamp;
629 }
630
631 // Remove stream previously added to free the external encoder instance.
632 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
633}
634
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200635void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
636 std::vector<VideoCodec> engine_codecs = engine_.codecs();
637 RTC_DCHECK(!engine_codecs.empty());
638 for (const cricket::VideoCodec& codec : engine_codecs) {
639 if (codec.name == "rtx") {
640 int associated_payload_type;
641 if (codec.GetParam(kCodecParamAssociatedPayloadType,
642 &associated_payload_type)) {
643 default_apt_rtx_types_[associated_payload_type] = codec.id;
644 }
645 }
646 }
647}
648
649void WebRtcVideoEngineTest::AssignDefaultCodec() {
650 std::vector<VideoCodec> engine_codecs = engine_.codecs();
651 RTC_DCHECK(!engine_codecs.empty());
652 bool codec_set = false;
653 for (const cricket::VideoCodec& codec : engine_codecs) {
654 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
655 codec.name != "ulpfec") {
656 default_codec_ = codec;
657 codec_set = true;
658 }
659 }
660
661 RTC_DCHECK(codec_set);
662}
663
Oleh Prypina40f8242017-12-21 13:32:23 +0100664size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
665 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100666 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
667 for (size_t i = 0; i < codecs.size(); ++i) {
668 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200669 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200670 continue;
671 // The tests only use H264 Constrained Baseline. Make sure we don't return
672 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200673 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200674 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200675 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
676 if (profile_level_id->profile !=
677 webrtc::H264::kProfileConstrainedBaseline) {
678 continue;
679 }
680 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100681 return i;
magjed509e4fe2016-11-18 01:34:11 -0800682 }
683 // This point should never be reached.
684 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100685 return -1;
686}
687
688cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
689 const std::string& name) const {
690 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800691}
692
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200693VideoMediaChannel*
694WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100695 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200696 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
697 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200698 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800699 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200700 for (const webrtc::SdpVideoFormat& format :
701 encoder_factory_->GetSupportedFormats()) {
702 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800703 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200704 parameters.codecs.push_back(engine_codec);
705 }
706 }
magjed509e4fe2016-11-18 01:34:11 -0800707
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200708 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000709
710 return channel;
711}
712
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200713VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000714 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100715 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200716 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
717 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200718 cricket::VideoRecvParameters parameters;
719 parameters.codecs = codecs;
720 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000721
722 return channel;
723}
724
Elad Alon157540a2019-02-08 23:37:52 +0100725void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
726 bool supported) const {
727 const RtpCapabilities capabilities = engine_.GetCapabilities();
728 if (supported) {
729 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200730 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100731 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200732 EXPECT_THAT(capabilities.header_extensions,
733 ::testing::Each(::testing::Field(&RtpExtension::uri,
734 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100735 }
736}
737
eladalonf1841382017-06-12 01:16:46 -0700738TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200739 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000740
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200741 std::unique_ptr<VideoMediaChannel> channel(
742 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000743
Peter Boström0c4e06b2015-10-07 12:23:21 +0200744 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000745
Yves Gerey665174f2018-06-19 15:03:05 +0200746 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000747 EXPECT_TRUE(channel->SetSend(true));
748
Niels Möller805a27e2019-01-21 12:21:27 +0100749 webrtc::test::FrameForwarder frame_forwarder;
750 cricket::FakeFrameSource frame_source(1280, 720,
751 rtc::kNumMicrosecsPerSec / 60);
752 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
753 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000754
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200755 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000756
757 // Verify that encoders are configured for simulcast through adapter
758 // (increasing resolution and only configured to send one stream each).
759 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200760 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
761 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000762 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200763 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000764 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
765 EXPECT_GT(codec_settings.width, prev_width);
766 prev_width = codec_settings.width;
767 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000768
Niels Möllerff40b142018-04-09 08:49:14 +0200769 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000770
771 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200772 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000773}
774
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200775TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
776 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200777 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000778
Niels Möllerd0f0f682019-01-14 09:09:53 +0100779 // Frame source.
780 webrtc::test::FrameForwarder frame_forwarder;
781 cricket::FakeFrameSource frame_source(1280, 720,
782 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200783
Sebastian Jansson84848f22018-11-16 10:40:36 +0100784 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200785 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
786 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200787 cricket::VideoSendParameters parameters;
788 parameters.codecs.push_back(GetEngineCodec("H264"));
789 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000790
791 EXPECT_TRUE(
792 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100793 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200794 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100795 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200796
797 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000798
Anders Carlsson67537952018-05-03 11:28:29 +0200799 cricket::VideoSendParameters new_parameters;
800 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
801 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200802
803 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100804 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200805
Anders Carlsson8a150d92018-05-14 12:40:04 +0200806 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000807}
808
eladalonf1841382017-06-12 01:16:46 -0700809TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000810 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200811 encoder_factory_->AddSupportedVideoCodecType("VP8");
812 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000813
Sebastian Jansson84848f22018-11-16 10:40:36 +0100814 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200815 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
816 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800817 cricket::VideoSendParameters parameters;
818 parameters.codecs.push_back(GetEngineCodec("VP8"));
819 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000820
Peter Boström0c4e06b2015-10-07 12:23:21 +0200821 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000822
Yves Gerey665174f2018-06-19 15:03:05 +0200823 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000824 EXPECT_TRUE(channel->SetSend(true));
825
826 // Send a fake frame, or else the media engine will configure the simulcast
827 // encoder adapter at a low-enough size that it'll only create a single
828 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100829 webrtc::test::FrameForwarder frame_forwarder;
830 cricket::FakeFrameSource frame_source(1280, 720,
831 rtc::kNumMicrosecsPerSec / 30);
832 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
833 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000834
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200835 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
836 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000837 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200838 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000839
840 channel.reset();
841 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200842 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000843}
844
eladalonf1841382017-06-12 01:16:46 -0700845TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000846 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200847 encoder_factory_->AddSupportedVideoCodecType("VP8");
848 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000849
Sebastian Jansson84848f22018-11-16 10:40:36 +0100850 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200851 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
852 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800853 cricket::VideoSendParameters parameters;
854 parameters.codecs.push_back(GetEngineCodec("H264"));
855 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000856
857 EXPECT_TRUE(
858 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100859
860 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100861 webrtc::test::FrameForwarder frame_forwarder;
862 cricket::FakeFrameSource frame_source(1280, 720,
863 rtc::kNumMicrosecsPerSec / 30);
864 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
865 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200866 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
867 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200868 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000869 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200870 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000871
872 channel.reset();
873 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200874 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000875}
876
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200877TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200878 RTC_DCHECK(!override_field_trials_);
879 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200880 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200881 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700882
Sebastian Jansson84848f22018-11-16 10:40:36 +0100883 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200884 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
885 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200886 cricket::VideoSendParameters parameters;
887 parameters.codecs.push_back(GetEngineCodec("H264"));
888 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700889
Peter Boström0c4e06b2015-10-07 12:23:21 +0200890 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700891 EXPECT_TRUE(
892 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100893
894 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100895 webrtc::test::FrameForwarder frame_forwarder;
896 cricket::FakeFrameSource frame_source(1280, 720,
897 rtc::kNumMicrosecsPerSec / 30);
898 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
899 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100900
Niels Möller4db138e2018-04-19 09:04:13 +0200901 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200902 ASSERT_EQ(1u, encoder_factory_->encoders().size());
903 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
904 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700905 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200906 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200907 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700908}
909
brandtrffc61182016-11-28 06:02:22 -0800910// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700911// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800912//
913// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700914TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800915 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200916 encoder_factory_->AddSupportedVideoCodecType("VP8");
917
Steve Anton2c9ebef2019-01-28 17:27:58 -0800918 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800919
920 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800921 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800922
923 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200924 RTC_DCHECK(!override_field_trials_);
925 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800926 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800927 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800928}
929
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200930// Test that codecs are added in the order they are reported from the factory.
931TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
932 encoder_factory_->AddSupportedVideoCodecType("VP8");
933 const char* kFakeCodecName = "FakeCodec";
934 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000935
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200936 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100937 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200938 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
939 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000940}
941
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200942// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800943// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200944TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100945 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
946 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100947
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100948 // Set up external encoder factory with first codec, and initialize engine.
949 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
950
brandtrffc61182016-11-28 06:02:22 -0800951 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800952
953 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100954 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800955 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200956 // The codec itself and RTX should have been added.
957 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100958
959 // Check that both fake codecs are present and that the second fake codec
960 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100961 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
962 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100963 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800964}
965
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200966TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
967 const char* kFakeCodecName = "FakeCodec";
968 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
969
970 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
971 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
972}
973
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200974TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
975 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200976 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200977 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800978 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000979
kwiberg686a8ef2016-02-26 03:00:35 -0800980 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200981 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000982
983 EXPECT_TRUE(
984 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200985 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000986
987 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200988 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200989 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000990
991 // Remove stream previously added to free the external decoder instance.
992 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200993 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000994}
995
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200996// Verifies that we can set up decoders.
997TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000998 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
999 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1000 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1001 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001002 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +02001003 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001004 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001005 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001006
kwiberg686a8ef2016-02-26 03:00:35 -08001007 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001008 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001009
1010 EXPECT_TRUE(
1011 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001012 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001013}
1014
Jonas Oreland49ac5952018-09-26 16:04:32 +02001015// Tests when GetSources is called with non-existing ssrc, it will return an
1016// empty list of RtpSource without crashing.
1017TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1018 // Setup an recv stream with |kSsrc|.
1019 encoder_factory_->AddSupportedVideoCodecType("VP8");
1020 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1021 cricket::VideoRecvParameters parameters;
1022 parameters.codecs.push_back(GetEngineCodec("VP8"));
1023 std::unique_ptr<VideoMediaChannel> channel(
1024 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1025
1026 EXPECT_TRUE(
1027 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1028
1029 // Call GetSources with |kSsrc + 1| which doesn't exist.
1030 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1031 EXPECT_EQ(0u, sources.size());
1032}
1033
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001034TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1035 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1036 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1037 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001038 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001039 EXPECT_EQ(0u, engine.codecs().size());
1040}
1041
1042TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1043 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001044 webrtc::MockVideoEncoderFactory* encoder_factory =
1045 new webrtc::MockVideoEncoderFactory();
1046 webrtc::MockVideoDecoderFactory* decoder_factory =
1047 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001048 WebRtcVideoEngine engine(
1049 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001050 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001051 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1052 EXPECT_EQ(0u, engine.codecs().size());
1053 EXPECT_CALL(*encoder_factory, Die());
1054 EXPECT_CALL(*decoder_factory, Die());
1055}
1056
1057// Test full behavior in the video engine when video codec factories of the new
1058// type are injected supporting the single codec Vp8. Check the returned codecs
1059// from the engine and that we will create a Vp8 encoder and decoder using the
1060// new factories.
1061TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1062 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001063 webrtc::MockVideoEncoderFactory* encoder_factory =
1064 new webrtc::MockVideoEncoderFactory();
1065 webrtc::MockVideoDecoderFactory* decoder_factory =
1066 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001067 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1068 rate_allocator_factory =
1069 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001070 EXPECT_CALL(*rate_allocator_factory,
1071 CreateVideoBitrateAllocatorProxy(Field(
1072 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001073 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001074 WebRtcVideoEngine engine(
1075 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001076 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001077 const webrtc::SdpVideoFormat vp8_format("VP8");
1078 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1079 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001080 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001081
1082 // Verify the codecs from the engine.
1083 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001084 // Verify default codecs has been added correctly.
1085 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001086 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001087
1088 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001089 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001090 int vp8_associated_payload;
1091 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1092 &vp8_associated_payload));
1093 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1094
1095 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1096
1097 // RTX codec for RED.
1098 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1099 int red_associated_payload;
1100 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1101 &red_associated_payload));
1102 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1103
1104 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1105
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001106 int associated_payload_type;
1107 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1108 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1109 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1110 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001111 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1112 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001113
1114 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001115 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1116 codec_info.is_hardware_accelerated = false;
1117 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001118 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001119 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001120 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001121 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001122 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001123 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001124 .WillOnce(
1125 ::testing::DoAll(::testing::InvokeWithoutArgs(
1126 [&encoder_created]() { encoder_created.Set(); }),
1127 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001128
1129 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001130 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001131 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001132 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001133
1134 // Create a call.
1135 webrtc::RtcEventLogNullImpl event_log;
1136 std::unique_ptr<webrtc::Call> call(
1137 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1138
1139 // Create send channel.
1140 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001141 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001142 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1143 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001144 cricket::VideoSendParameters send_parameters;
1145 send_parameters.codecs.push_back(engine_codecs.at(0));
1146 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1147 send_channel->OnReadyToSend(true);
1148 EXPECT_TRUE(
1149 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1150 EXPECT_TRUE(send_channel->SetSend(true));
1151
Niels Möller4db138e2018-04-19 09:04:13 +02001152 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001153 webrtc::test::FrameForwarder frame_forwarder;
1154 cricket::FakeFrameSource frame_source(1280, 720,
1155 rtc::kNumMicrosecsPerSec / 30);
1156 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001157 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001158 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001159 encoder_created.Wait(kTimeout);
1160
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001161 // Create recv channel.
1162 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001163 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001164 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1165 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001166 cricket::VideoRecvParameters recv_parameters;
1167 recv_parameters.codecs.push_back(engine_codecs.at(0));
1168 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1169 EXPECT_TRUE(recv_channel->AddRecvStream(
1170 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1171
1172 // Remove streams previously added to free the encoder and decoder instance.
1173 EXPECT_CALL(*encoder_factory, Die());
1174 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001175 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001176 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1177 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1178}
1179
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001180// Test behavior when decoder factory fails to create a decoder (returns null).
1181TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1182 // |engine| take ownership of the factories.
1183 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001184 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001185 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001186 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001187 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1188 rate_allocator_factory =
1189 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001190 WebRtcVideoEngine engine(
1191 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001192 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001193 const webrtc::SdpVideoFormat vp8_format("VP8");
1194 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1195 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001196 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001197
1198 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001199 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1200 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001201
1202 // Create a call.
1203 webrtc::RtcEventLogNullImpl event_log;
1204 std::unique_ptr<webrtc::Call> call(
1205 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1206
1207 // Create recv channel.
1208 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001209 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001210 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1211 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001212 cricket::VideoRecvParameters recv_parameters;
1213 recv_parameters.codecs.push_back(engine.codecs().front());
1214 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1215 EXPECT_TRUE(recv_channel->AddRecvStream(
1216 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1217
1218 // Remove streams previously added to free the encoder and decoder instance.
1219 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1220}
1221
eladalonf1841382017-06-12 01:16:46 -07001222TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001223 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001224 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001225 std::unique_ptr<VideoMediaChannel> channel(
1226 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001227 ASSERT_TRUE(
1228 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1229 cricket::VideoCodec codec = GetEngineCodec("VP8");
1230 cricket::VideoSendParameters parameters;
1231 parameters.codecs.push_back(codec);
1232 channel->OnReadyToSend(true);
1233 channel->SetSend(true);
1234 ASSERT_TRUE(channel->SetSendParameters(parameters));
1235
Niels Möller805a27e2019-01-21 12:21:27 +01001236 webrtc::test::FrameForwarder frame_forwarder;
1237 cricket::FakeFrameSource frame_source(1280, 720,
1238 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001239 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001240 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001241
Niels Möller805a27e2019-01-21 12:21:27 +01001242 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001243 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001244 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001245 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001246
Niels Möller805a27e2019-01-21 12:21:27 +01001247 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1248 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001249 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001250 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001251
1252 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001253 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1254 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001255 // Change to screen content, recreate encoder. For the simulcast encoder
1256 // adapter case, this will result in two calls since InitEncode triggers a
1257 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001258 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001259 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001260 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001261
Niels Möller805a27e2019-01-21 12:21:27 +01001262 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1263 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001264 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001265 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001266
1267 options.is_screencast.emplace(false);
1268 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001269 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001270 // Change back to regular video content, update encoder. Also change
1271 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001272 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001273 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001274 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001275 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001276
1277 // Remove stream previously added to free the external encoder instance.
1278 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001279 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001280}
1281
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001282class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001283 protected:
1284 WebRtcVideoChannelBaseTest()
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001285 : video_bitrate_allocator_factory_(
1286 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1287 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1288 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001289
1290 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001291 // One testcase calls SetUp in a loop, only create call_ once.
1292 if (!call_) {
1293 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1294 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001295 cricket::MediaConfig media_config;
1296 // Disabling cpu overuse detection actually disables quality scaling too; it
1297 // implies DegradationPreference kMaintainResolution. Automatic scaling
1298 // needs to be disabled, otherwise, tests which check the size of received
1299 // frames become flaky.
1300 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001301 channel_.reset(
1302 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1303 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001304 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001305 channel_->OnReadyToSend(true);
1306 EXPECT_TRUE(channel_.get() != NULL);
1307 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001308 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001309 cricket::VideoRecvParameters parameters;
1310 parameters.codecs = engine_.codecs();
1311 channel_->SetRecvParameters(parameters);
1312 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001313 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1314 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1315 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1316 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001317 }
1318
1319 // Utility method to setup an additional stream to send and receive video.
1320 // Used to test send and recv between two streams.
1321 void SetUpSecondStream() {
1322 SetUpSecondStreamWithNoRecv();
1323 // Setup recv for second stream.
1324 EXPECT_TRUE(channel_->AddRecvStream(
1325 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1326 // Make the second renderer available for use by a new stream.
1327 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1328 }
1329 // Setup an additional stream just to send video. Defer add recv stream.
1330 // This is required if you want to test unsignalled recv of video rtp packets.
1331 void SetUpSecondStreamWithNoRecv() {
1332 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001333 EXPECT_TRUE(
1334 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001335 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001336 EXPECT_FALSE(
1337 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001338 EXPECT_TRUE(channel_->AddSendStream(
1339 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1340 // We dont add recv for the second stream.
1341
1342 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001343 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001344 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001345 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001346 }
Yves Gerey665174f2018-06-19 15:03:05 +02001347 virtual void TearDown() { channel_.reset(); }
1348 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001349
1350 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001351 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1352 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001353
1354 bool sending = channel_->sending();
1355 bool success = SetSend(false);
1356 if (success) {
1357 cricket::VideoSendParameters parameters;
1358 parameters.codecs.push_back(codec);
1359 success = channel_->SetSendParameters(parameters);
1360 }
1361 if (success) {
1362 success = SetSend(sending);
1363 }
1364 return success;
1365 }
Yves Gerey665174f2018-06-19 15:03:05 +02001366 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001367 void SendFrame() {
1368 if (frame_forwarder_2_) {
1369 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001370 }
Niels Möller805a27e2019-01-21 12:21:27 +01001371 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001372 }
1373 bool WaitAndSendFrame(int wait_ms) {
1374 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001375 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001376 return ret;
1377 }
Yves Gerey665174f2018-06-19 15:03:05 +02001378 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001379 int NumRtpBytes(uint32_t ssrc) {
1380 return network_interface_.NumRtpBytes(ssrc);
1381 }
Yves Gerey665174f2018-06-19 15:03:05 +02001382 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001383 int NumRtpPackets(uint32_t ssrc) {
1384 return network_interface_.NumRtpPackets(ssrc);
1385 }
Yves Gerey665174f2018-06-19 15:03:05 +02001386 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001387 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1388 return network_interface_.GetRtpPacket(index);
1389 }
1390 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001391 webrtc::RTPHeader header;
1392 EXPECT_TRUE(ParseRtpPacket(p, &header));
1393 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001394 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001395
Niels Möller6557d0c2018-04-11 15:18:34 +02001396 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001397 webrtc::RTPHeader* header) {
1398 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1399 webrtc::RtpHeaderParser::Create());
1400 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001401 }
1402
1403 // Tests that we can send and receive frames.
1404 void SendAndReceive(const cricket::VideoCodec& codec) {
1405 EXPECT_TRUE(SetOneCodec(codec));
1406 EXPECT_TRUE(SetSend(true));
1407 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1408 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001409 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001410 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1411 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1412 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1413 }
1414
1415 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001416 int duration_sec,
1417 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001418 EXPECT_TRUE(SetOneCodec(codec));
1419 EXPECT_TRUE(SetSend(true));
1420 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1421 EXPECT_EQ(0, renderer_.num_rendered_frames());
1422 for (int i = 0; i < duration_sec; ++i) {
1423 for (int frame = 1; frame <= fps; ++frame) {
1424 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1425 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1426 }
1427 }
1428 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1429 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1430 }
1431
Niels Möller6557d0c2018-04-11 15:18:34 +02001432 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1433 cricket::VideoMediaInfo info;
1434 EXPECT_TRUE(channel_->GetStats(&info));
1435 return info.senders[i];
1436 }
1437
1438 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1439 cricket::VideoMediaInfo info;
1440 EXPECT_TRUE(channel_->GetStats(&info));
1441 return info.receivers[i];
1442 }
1443
1444 // Two streams one channel tests.
1445
1446 // Tests that we can send and receive frames.
1447 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1448 SetUpSecondStream();
1449 // Test sending and receiving on first stream.
1450 SendAndReceive(codec);
1451 // Test sending and receiving on second stream.
1452 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1453 EXPECT_GT(NumRtpPackets(), 0);
1454 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1455 }
1456
1457 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1458 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001459 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001460 return engine_codec;
1461 }
1462 // This point should never be reached.
1463 ADD_FAILURE() << "Unrecognized codec name: " << name;
1464 return cricket::VideoCodec();
1465 }
1466
1467 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1468
1469 cricket::StreamParams DefaultSendStreamParams() {
1470 return cricket::StreamParams::CreateLegacy(kSsrc);
1471 }
1472
1473 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001474 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001475 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1476 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001477 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001478
1479 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1480 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1481 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1482
Niels Möller6557d0c2018-04-11 15:18:34 +02001483 std::unique_ptr<WebRtcVideoChannel> channel_;
1484 cricket::FakeNetworkInterface network_interface_;
1485 cricket::FakeVideoRenderer renderer_;
1486
1487 // Used by test cases where 2 streams are run on the same channel.
1488 cricket::FakeVideoRenderer renderer2_;
1489};
1490
1491// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001492TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001493 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001494 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001495 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1496 EXPECT_FALSE(channel_->sending());
1497 EXPECT_TRUE(SetSend(true));
1498 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001499 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001500 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1501 EXPECT_TRUE(SetSend(false));
1502 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001503}
Niels Möller6557d0c2018-04-11 15:18:34 +02001504
1505// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001506TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001507 EXPECT_FALSE(channel_->sending());
1508 EXPECT_FALSE(SetSend(true));
1509 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001510}
Niels Möller6557d0c2018-04-11 15:18:34 +02001511
1512// Test that we properly set the send and recv buffer sizes by the time
1513// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001514TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001515 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1516 EXPECT_TRUE(SetSend(true));
1517 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001518 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001519}
1520
Johannes Kron5a0665b2019-04-08 10:35:50 +02001521// Test that we properly set the send and recv buffer sizes when overriding
1522// via field trials.
1523TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1524 // Set field trial to override the default recv buffer size, and then re-run
1525 // setup where the interface is created and configured.
1526 const int kCustomRecvBufferSize = 123456;
1527 webrtc::test::ScopedFieldTrials field_trial(
1528 "WebRTC-IncreasedReceivebuffers/123456/");
1529 SetUp();
1530
1531 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1532 EXPECT_TRUE(SetSend(true));
1533 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1534 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1535}
1536
1537// Test that we properly set the send and recv buffer sizes when overriding
1538// via field trials with suffix.
1539TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1540 // Set field trial to override the default recv buffer size, and then re-run
1541 // setup where the interface is created and configured.
1542 const int kCustomRecvBufferSize = 123456;
1543 webrtc::test::ScopedFieldTrials field_trial(
1544 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1545 SetUp();
1546
1547 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1548 EXPECT_TRUE(SetSend(true));
1549 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1550 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1551}
1552
1553// Test that we properly set the send and recv buffer sizes when overriding
1554// via field trials that don't make any sense.
1555TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1556 // Set bogus field trial values to override the default recv buffer size, and
1557 // then re-run setup where the interface is created and configured. The
1558 // default value should still be used.
1559
1560 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1561 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1562 field_trial_string += group;
1563 field_trial_string += "/";
1564 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1565 SetUp();
1566
1567 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1568 EXPECT_TRUE(SetSend(true));
1569 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1570 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1571 }
1572}
1573
Niels Möller6557d0c2018-04-11 15:18:34 +02001574// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001575TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001576 const int kDurationSec = 3;
1577 const int kFps = 10;
1578 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1579
1580 cricket::VideoMediaInfo info;
1581 EXPECT_TRUE(channel_->GetStats(&info));
1582
1583 ASSERT_EQ(1U, info.senders.size());
1584 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1585 // For webrtc, bytes_sent does not include the RTP header length.
1586 EXPECT_GT(info.senders[0].bytes_sent, 0);
1587 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1588 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1589 ASSERT_TRUE(info.senders[0].codec_payload_type);
1590 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1591 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1592 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1593 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1594 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1595 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1596 EXPECT_GT(info.senders[0].framerate_input, 0);
1597 EXPECT_GT(info.senders[0].framerate_sent, 0);
1598
1599 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1600 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1601 info.send_codecs[DefaultCodec().id]);
1602
1603 ASSERT_EQ(1U, info.receivers.size());
1604 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1605 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1606 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1607 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1608 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1609 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1610 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1611 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1612 EXPECT_EQ(0, info.receivers[0].packets_lost);
1613 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1614 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1615 EXPECT_EQ(0, info.receivers[0].firs_sent);
1616 EXPECT_EQ(0, info.receivers[0].plis_sent);
1617 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1618 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1619 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1620 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1621 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1622 EXPECT_GT(info.receivers[0].framerate_output, 0);
1623
1624 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1625 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1626 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001627}
Niels Möller6557d0c2018-04-11 15:18:34 +02001628
1629// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001630TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001631 cricket::FakeVideoRenderer renderer1, renderer2;
1632 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1633 cricket::VideoSendParameters parameters;
1634 parameters.codecs.push_back(DefaultCodec());
1635 parameters.conference_mode = true;
1636 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1637 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001638 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1639 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001640 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1641 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1642 EXPECT_EQ(0, renderer1.num_rendered_frames());
1643 EXPECT_EQ(0, renderer2.num_rendered_frames());
1644 std::vector<uint32_t> ssrcs;
1645 ssrcs.push_back(1);
1646 ssrcs.push_back(2);
1647 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001648 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001649 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1650 kTimeout);
1651 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1652 kTimeout);
1653
1654 EXPECT_TRUE(channel_->SetSend(false));
1655
1656 cricket::VideoMediaInfo info;
1657 EXPECT_TRUE(channel_->GetStats(&info));
1658 ASSERT_EQ(1U, info.senders.size());
1659 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1660 // For webrtc, bytes_sent does not include the RTP header length.
1661 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1662 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1663 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1664 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1665
1666 ASSERT_EQ(2U, info.receivers.size());
1667 for (size_t i = 0; i < info.receivers.size(); ++i) {
1668 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1669 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1670 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001671 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001672 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1673 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1674 }
srtee0c2eea2017-12-15 17:44:33 +01001675}
Niels Möller6557d0c2018-04-11 15:18:34 +02001676
1677// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001678TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001679 // Normal setup; note that we set the SSRC explicitly to ensure that
1680 // it will come first in the senders map.
1681 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1682 cricket::VideoSendParameters parameters;
1683 parameters.codecs.push_back(DefaultCodec());
1684 parameters.conference_mode = true;
1685 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001686 EXPECT_TRUE(
1687 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001688 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1689 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001690 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001691 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1692 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1693
1694 // Add an additional capturer, and hook up a renderer to receive it.
1695 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001696 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001697 const int kTestWidth = 160;
1698 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001699 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1700 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001701 EXPECT_TRUE(
1702 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001703 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001704 EXPECT_TRUE(
1705 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001706 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001707 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001708 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1709 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001710
1711 // Get stats, and make sure they are correct for two senders. We wait until
1712 // the number of expected packets have been sent to avoid races where we
1713 // check stats before it has been updated.
1714 cricket::VideoMediaInfo info;
1715 for (uint32_t i = 0; i < kTimeout; ++i) {
1716 rtc::Thread::Current()->ProcessMessages(1);
1717 EXPECT_TRUE(channel_->GetStats(&info));
1718 ASSERT_EQ(2U, info.senders.size());
1719 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1720 NumRtpPackets()) {
1721 // Stats have been updated for both sent frames, expectations can be
1722 // checked now.
1723 break;
1724 }
1725 }
1726 EXPECT_EQ(NumRtpPackets(),
1727 info.senders[0].packets_sent + info.senders[1].packets_sent)
1728 << "Timed out while waiting for packet counts for all sent packets.";
1729 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1730 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1731 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1732 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1733 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1734 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1735 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1736 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1737 // The capturer must be unregistered here as it runs out of it's scope next.
1738 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001739}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001740
Niels Möller6557d0c2018-04-11 15:18:34 +02001741// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001742TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001743 cricket::VideoSendParameters parameters;
1744 parameters.codecs.push_back(DefaultCodec());
1745 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1746 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1747 parameters.max_bandwidth_bps = 128 * 1024;
1748 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001749}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001750
Niels Möller6557d0c2018-04-11 15:18:34 +02001751// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001752TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001753 EXPECT_TRUE(SetDefaultCodec());
1754 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001755 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001756 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001757 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001758 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001759 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1760 EXPECT_EQ(kSsrc, header.ssrc);
1761
Niels Möller6557d0c2018-04-11 15:18:34 +02001762 // Packets are being paced out, so these can mismatch between the first and
1763 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001764 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1765 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001766 EXPECT_EQ(1, NumSentSsrcs());
1767 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1768 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001769}
Niels Möller6557d0c2018-04-11 15:18:34 +02001770
1771// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001772TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001773 // Remove stream added in Setup.
1774 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1775 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001776 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001777 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001778 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001779 EXPECT_TRUE(SetSend(true));
1780 EXPECT_TRUE(WaitAndSendFrame(0));
1781 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001782 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001783 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001784 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1785 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001786 // Packets are being paced out, so these can mismatch between the first and
1787 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001788 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1789 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001790 EXPECT_EQ(1, NumSentSsrcs());
1791 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1792 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001793}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001794
Niels Möller6557d0c2018-04-11 15:18:34 +02001795// Test that we can set the default video renderer before and after
1796// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001797TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001798 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1799 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001800
1801 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1802 rtc::SetBE32(packet1.data() + 8, kSsrc);
1803 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1804 EXPECT_TRUE(SetDefaultCodec());
1805 EXPECT_TRUE(SetSend(true));
1806 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001807 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001808 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001809 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001810 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001811}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001812
Niels Möller6557d0c2018-04-11 15:18:34 +02001813// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001814TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001815 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1816 EXPECT_TRUE(SetSend(true));
1817 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001818 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001819 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1820 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001821 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001822 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001823 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1824 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001825 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1826 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001827
1828 // Remove the send stream that was added during Setup.
1829 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1830 int rtp_packets = NumRtpPackets();
1831
Niels Möller6557d0c2018-04-11 15:18:34 +02001832 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001833 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001834 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001835 EXPECT_EQ(rtp_packets, NumRtpPackets());
1836 // Wait 30ms to guarantee the engine does not drop the frame.
1837 EXPECT_TRUE(WaitAndSendFrame(30));
1838 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1839
1840 last_packet = NumRtpPackets() - 1;
1841 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001842 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1843 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001844}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001845
Niels Möller6557d0c2018-04-11 15:18:34 +02001846// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001847TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001848 cricket::FakeVideoRenderer renderer1, renderer2;
1849 EXPECT_TRUE(SetDefaultCodec());
1850 cricket::VideoSendParameters parameters;
1851 parameters.codecs.push_back(DefaultCodec());
1852 parameters.conference_mode = true;
1853 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1854 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001855 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1856 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001857 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1858 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1859 EXPECT_EQ(0, renderer1.num_rendered_frames());
1860 EXPECT_EQ(0, renderer2.num_rendered_frames());
1861 std::vector<uint32_t> ssrcs;
1862 ssrcs.push_back(1);
1863 ssrcs.push_back(2);
1864 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001865 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001866 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1867 kTimeout);
1868 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1869 kTimeout);
1870
1871 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1872 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1873 EXPECT_EQ(kVideoWidth, renderer1.width());
1874 EXPECT_EQ(kVideoHeight, renderer1.height());
1875 EXPECT_EQ(kVideoWidth, renderer2.width());
1876 EXPECT_EQ(kVideoHeight, renderer2.height());
1877 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1878 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001879}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001880
Niels Möller6557d0c2018-04-11 15:18:34 +02001881// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001882TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001883 using cricket::VideoCodec;
1884 using cricket::VideoOptions;
1885 using cricket::VideoFormat;
1886 using cricket::FOURCC_I420;
1887
1888 VideoCodec codec = DefaultCodec();
1889 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1890 EXPECT_TRUE(SetOneCodec(codec));
1891 EXPECT_TRUE(SetSend(true));
1892 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1893 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001894 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001895 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001896
1897 webrtc::test::FrameForwarder frame_forwarder;
1898 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1899 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001900
1901 // TODO(nisse): This testcase fails if we don't configure
1902 // screencast. It's unclear why, I see nothing obvious in this
1903 // test which is related to screencast logic.
1904 VideoOptions video_options;
1905 video_options.is_screencast = true;
1906 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1907
Niels Möller6557d0c2018-04-11 15:18:34 +02001908 int captured_frames = 1;
1909 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001910 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001911 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001912 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1913
Niels Möller6557d0c2018-04-11 15:18:34 +02001914 ++captured_frames;
1915 // Wait until frame of right size is captured.
1916 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001917 480 == renderer_.width() &&
1918 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001919 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001920 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001921 EXPECT_EQ(480, renderer_.width());
1922 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001923 captured_frames = renderer_.num_rendered_frames() + 1;
1924 EXPECT_FALSE(renderer_.black_frame());
1925 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1926 // Make sure a black frame is generated within the specified timeout.
1927 // The black frame should be the resolution of the previous frame to
1928 // prevent expensive encoder reconfigurations.
1929 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001930 480 == renderer_.width() &&
1931 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001932 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001933 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001934 EXPECT_EQ(480, renderer_.width());
1935 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001936 EXPECT_TRUE(renderer_.black_frame());
1937
1938 // The black frame has the same timestamp as the next frame since it's
1939 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1940 // not render a frame with the same timestamp so capture another frame
1941 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001942 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001943 }
srtee0c2eea2017-12-15 17:44:33 +01001944}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001945
Niels Möller6557d0c2018-04-11 15:18:34 +02001946// Tests that if SetVideoSend is called with a NULL capturer after the
1947// capturer was already removed, the application doesn't crash (and no black
1948// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001949TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001950 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1951 EXPECT_TRUE(SetSend(true));
1952 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1953 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001954 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001955 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1956 // Wait for one frame so they don't get dropped because we send frames too
1957 // tightly.
1958 rtc::Thread::Current()->ProcessMessages(30);
1959 // Remove the capturer.
1960 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1961
1962 // No capturer was added, so this SetVideoSend shouldn't do anything.
1963 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1964 rtc::Thread::Current()->ProcessMessages(300);
1965 // Verify no more frames were sent.
1966 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001967}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001968
Niels Möller6557d0c2018-04-11 15:18:34 +02001969// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001970TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001971 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1972 // interval time to avoid that.
1973 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1974 // interval time to avoid that.
1975 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001976 EXPECT_TRUE(
1977 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001978 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1979 cricket::VideoFormat capture_format(
1980 kVideoWidth, kVideoHeight,
1981 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1982 // Set up additional stream 1.
1983 cricket::FakeVideoRenderer renderer1;
1984 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001985 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001986 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001987 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01001988
1989 webrtc::test::FrameForwarder frame_forwarder1;
1990 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
1991 rtc::kNumMicrosecsPerSec / kFramerate);
1992
Niels Möller6557d0c2018-04-11 15:18:34 +02001993 // Set up additional stream 2.
1994 cricket::FakeVideoRenderer renderer2;
1995 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001996 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001997 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001998 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01001999 webrtc::test::FrameForwarder frame_forwarder2;
2000
Niels Möller6557d0c2018-04-11 15:18:34 +02002001 // State for all the streams.
2002 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2003 // A limitation in the lmi implementation requires that SetVideoSend() is
2004 // called after SetOneCodec().
2005 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002006 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2007 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002008 EXPECT_TRUE(SetSend(true));
2009 // Test capturer associated with engine.
2010 const int kTestWidth = 160;
2011 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002012 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2013 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2014 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002015 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2016 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002017 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002018 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2019 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2020 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002021 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2022 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002023 // Successfully remove the capturer.
2024 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2025 // The capturers must be unregistered here as it runs out of it's scope
2026 // next.
2027 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2028 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002029}
Niels Möller6557d0c2018-04-11 15:18:34 +02002030
2031// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002032TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002033 // Remove the send stream that was added during Setup.
2034 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2035
2036 cricket::StreamParams empty;
2037 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002038 EXPECT_TRUE(
2039 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002040}
Niels Möller6557d0c2018-04-11 15:18:34 +02002041
2042// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002043TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002044 // Remove stream added in Setup. I.e. remove stream corresponding to default
2045 // channel.
2046 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002047 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002048 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2049 EXPECT_TRUE(channel_->AddSendStream(
2050 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2051 }
2052 // Delete one of the non default channel streams, let the destructor delete
2053 // the remaining ones.
2054 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2055 // Stream should already be deleted.
2056 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002057}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002058
eladalonf1841382017-06-12 01:16:46 -07002059TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002060 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002061}
2062
eladalonf1841382017-06-12 01:16:46 -07002063TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002064 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002065}
2066
eladalonf1841382017-06-12 01:16:46 -07002067TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002068 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002069}
2070
eladalonf1841382017-06-12 01:16:46 -07002071TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002072 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2073 // bitrates. This currently happens at <250k, and two streams sharing 300k
2074 // initially will use QVGA instead of VGA.
2075 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2076 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002077 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002078 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002079 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002080}
2081
eladalonf1841382017-06-12 01:16:46 -07002082class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002083 public:
eladalonf1841382017-06-12 01:16:46 -07002084 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2085 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002086 : WebRtcVideoEngineTest(field_trials),
2087 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2088 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002089 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002090 encoder_factory_->AddSupportedVideoCodecType("VP8");
2091 encoder_factory_->AddSupportedVideoCodecType("VP9");
2092#if defined(WEBRTC_USE_H264)
2093 encoder_factory_->AddSupportedVideoCodecType("H264");
2094#endif
2095
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002096 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002097 channel_.reset(engine_.CreateMediaChannel(
2098 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2099 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002100 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002101 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002102 send_parameters_.codecs = engine_.codecs();
2103 recv_parameters_.codecs = engine_.codecs();
2104 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002105 }
2106
2107 protected:
2108 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002109 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002110 }
2111
2112 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002113 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002114 EXPECT_TRUE(channel_->AddSendStream(sp));
2115 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002116 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002117 EXPECT_EQ(num_streams + 1, streams.size());
2118 return streams[streams.size() - 1];
2119 }
2120
2121 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002122 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002123 }
2124
2125 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002126 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002127 }
2128
2129 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002130 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002131 EXPECT_TRUE(channel_->AddRecvStream(sp));
2132 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002133 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002134 EXPECT_EQ(num_streams + 1, streams.size());
2135 return streams[streams.size() - 1];
2136 }
2137
pbos@webrtc.org00873182014-11-25 14:03:34 +00002138 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2139 int expected_min_bitrate_bps,
2140 const char* start_bitrate_kbps,
2141 int expected_start_bitrate_bps,
2142 const char* max_bitrate_kbps,
2143 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002144 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2145 expected_start_bitrate_bps,
2146 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002147 auto& codecs = send_parameters_.codecs;
2148 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002149 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002150 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2151 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2152 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002153 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002154 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002155
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002156 void ExpectSetBitrateParameters(int min_bitrate_bps,
2157 int start_bitrate_bps,
2158 int max_bitrate_bps) {
2159 EXPECT_CALL(
2160 *fake_call_->GetMockTransportControllerSend(),
2161 SetSdpBitrateParameters(AllOf(
2162 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2163 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2164 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2165 }
2166
2167 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2168 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2169 SetSdpBitrateParameters(Field(
2170 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002171 }
2172
Johannes Kron9190b822018-10-29 11:22:05 +01002173 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2174 // For a caller, the answer will be applied in set remote description
2175 // where SetSendParameters() is called.
2176 EXPECT_TRUE(
2177 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2178 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2179 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2180 const webrtc::VideoSendStream::Config& config =
2181 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2182 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2183 }
2184
2185 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2186 // For a callee, the answer will be applied in set local description
2187 // where SetExtmapAllowMixed() and AddSendStream() are called.
2188 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2189 EXPECT_TRUE(
2190 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2191 const webrtc::VideoSendStream::Config& config =
2192 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2193 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2194 }
2195
isheriff6f8d6862016-05-26 11:24:55 -07002196 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002197 // Enable extension.
2198 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002199 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002200 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002201 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002202 FakeVideoSendStream* send_stream =
2203 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2204
2205 // Verify the send extension id.
2206 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2207 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002208 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002209 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002210 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002211 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2212 // receivers.
2213 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2214 ->GetConfig()
2215 .rtp.extensions.empty());
2216
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002217 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002218 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002219 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2220 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002221 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2222
2223 // Verify that adding receive RTP header extensions adds them for existing
2224 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002225 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002226 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002227 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2228 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002229 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002230 }
2231
isheriff6f8d6862016-05-26 11:24:55 -07002232 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002233 // Enable extension.
2234 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002235 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002236 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002237 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002238
2239 FakeVideoReceiveStream* recv_stream =
2240 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2241
2242 // Verify the recv extension id.
2243 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2244 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002245 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002246 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002247 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002248
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002249 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2250 // senders.
2251 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2252 ->GetConfig()
2253 .rtp.extensions.empty());
2254
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002255 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002256 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002257 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2258 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002259 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2260
2261 // Verify that adding receive RTP header extensions adds them for existing
2262 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002263 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002264 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002265 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2266 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002267 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002268 }
2269
Elad Alonfadb1812019-05-24 13:40:02 +02002270 void TestLossNotificationState(bool expect_lntf_enabled) {
2271 AssignDefaultCodec();
2272 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2273
2274 cricket::VideoSendParameters parameters;
2275 parameters.codecs = engine_.codecs();
2276 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2277 EXPECT_TRUE(channel_->SetSend(true));
2278
2279 // Send side.
2280 FakeVideoSendStream* send_stream =
2281 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2282 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2283
2284 // Receiver side.
2285 FakeVideoReceiveStream* recv_stream =
2286 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2287 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2288 }
2289
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002290 void TestExtensionFilter(const std::vector<std::string>& extensions,
2291 const std::string& expected_extension) {
2292 cricket::VideoSendParameters parameters = send_parameters_;
2293 int expected_id = -1;
2294 int id = 1;
2295 for (const std::string& extension : extensions) {
2296 if (extension == expected_extension)
2297 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002298 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002299 }
2300 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2301 FakeVideoSendStream* send_stream =
2302 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2303
2304 // Verify that only one of them has been set, and that it is the one with
2305 // highest priority (transport sequence number).
2306 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2307 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2308 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002309 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002310 }
2311
asapersson3c81a1a2017-06-14 05:52:21 -07002312 void TestDegradationPreference(bool resolution_scaling_enabled,
2313 bool fps_scaling_enabled);
2314
Erik Språngefbde372015-04-29 16:21:28 +02002315 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002316 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002317 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2318 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002319
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002320 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002321 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002322 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002323 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002324 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002325 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002326 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002327 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002328 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002329
Erik Språng143cec12015-04-28 10:01:41 +02002330 return fake_call_->GetVideoSendStreams().back();
2331 }
2332
Peter Boström2feafdb2015-09-09 14:32:14 +02002333 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2334 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002335 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002336 std::vector<uint32_t> ssrcs;
2337 std::vector<uint32_t> rtx_ssrcs;
2338 uint32_t num_streams = enabled ? 3 : 1;
2339 for (uint32_t i = 0; i < num_streams; ++i) {
2340 uint32_t ssrc = last_ssrc_ + i;
2341 ssrcs.push_back(ssrc);
2342 if (with_rtx) {
2343 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2344 }
Erik Språng143cec12015-04-28 10:01:41 +02002345 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002346 if (with_rtx) {
2347 return AddSendStream(
2348 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2349 }
2350 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002351 }
2352
perkjfa10b552016-10-02 23:45:26 -07002353 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002354 std::vector<FakeVideoSendStream*> streams =
2355 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002356 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002357 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002358 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002359 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002360 }
2361
perkjfa10b552016-10-02 23:45:26 -07002362 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002363 int stream_max,
2364 int expected_encoder_bitrate) {
2365 VideoSendParameters limited_send_params = send_parameters_;
2366 limited_send_params.max_bandwidth_bps = global_max;
2367 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002368 webrtc::RtpParameters parameters =
2369 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002370 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002371 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002372 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002373 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002374 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002375 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002376 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002377 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002378 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002379 }
2380
Åsa Persson55659812018-06-18 17:51:32 +02002381 // Values from kSimulcastConfigs in simulcast.cc.
2382 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2383 std::vector<webrtc::VideoStream> layers(3);
2384 layers[0].min_bitrate_bps = 30000;
2385 layers[0].target_bitrate_bps = 150000;
2386 layers[0].max_bitrate_bps = 200000;
2387 layers[1].min_bitrate_bps = 150000;
2388 layers[1].target_bitrate_bps = 500000;
2389 layers[1].max_bitrate_bps = 700000;
2390 layers[2].min_bitrate_bps = 600000;
2391 layers[2].target_bitrate_bps = 2500000;
2392 layers[2].max_bitrate_bps = 2500000;
2393 return layers;
2394 }
2395
Niels Möller805a27e2019-01-21 12:21:27 +01002396 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002397 std::unique_ptr<FakeCall> fake_call_;
2398 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002399 cricket::VideoSendParameters send_parameters_;
2400 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002401 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002402};
2403
eladalonf1841382017-06-12 01:16:46 -07002404TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002405 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002406 const std::string kSyncLabel = "AvSyncLabel";
2407
2408 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002409 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002410 EXPECT_TRUE(channel_->AddRecvStream(sp));
2411
Mirko Bonadeif859e552018-05-30 15:31:29 +02002412 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002413 EXPECT_EQ(kSyncLabel,
2414 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2415 << "SyncGroup should be set based on sync_label";
2416}
2417
eladalonf1841382017-06-12 01:16:46 -07002418TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002419 cricket::VideoSendParameters parameters;
2420 parameters.codecs = engine_.codecs();
2421 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002422 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002423 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002424 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002425
2426 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002427 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2428 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002429 FakeVideoSendStream* send_stream = AddSendStream(
2430 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2431
2432 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2433 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2434 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2435
2436 // Receiver side.
2437 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2438 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002439 EXPECT_FALSE(
2440 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002441 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002442 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002443 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002444 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002445 << "RTX should be mapped for the RED payload type";
2446
brandtr14742122017-01-27 04:53:07 -08002447 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002448}
2449
eladalonf1841382017-06-12 01:16:46 -07002450TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002451 // Setup one channel with an associated RTX stream.
2452 cricket::StreamParams params =
2453 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2454 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2455 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002456 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002457
2458 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2459 << "RTX should be mapped for all decoders/payload types.";
2460 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002461 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002462 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002463}
2464
eladalonf1841382017-06-12 01:16:46 -07002465TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002466 // Setup one channel without an associated RTX stream.
2467 cricket::StreamParams params =
2468 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2469 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002470 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002471}
2472
Johannes Kron9190b822018-10-29 11:22:05 +01002473// Test propagation of extmap allow mixed setting.
2474TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2475 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2476}
2477TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2478 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2479}
2480TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2481 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2482}
2483TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2484 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2485}
2486
eladalonf1841382017-06-12 01:16:46 -07002487TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002488 FakeVideoSendStream* send_stream =
2489 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2490 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2491
2492 FakeVideoReceiveStream* recv_stream =
2493 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2494 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002495}
2496
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002497// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002498TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002499 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002500}
isheriff6f8d6862016-05-26 11:24:55 -07002501
eladalonf1841382017-06-12 01:16:46 -07002502TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002503 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002504}
2505
2506// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002507TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002508 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002509}
isheriff6f8d6862016-05-26 11:24:55 -07002510
eladalonf1841382017-06-12 01:16:46 -07002511TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002512 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002513}
2514
eladalonf1841382017-06-12 01:16:46 -07002515TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002516 // Enable three redundant extensions.
2517 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002518 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2519 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2520 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2521 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002522}
2523
eladalonf1841382017-06-12 01:16:46 -07002524TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002525 // Enable two redundant extensions.
2526 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002527 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2528 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2529 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002530}
2531
stefanc1aeaf02015-10-15 07:26:07 -07002532// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002533TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002534 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002535}
eladalonf1841382017-06-12 01:16:46 -07002536TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002537 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002538}
2539
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002540// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002541TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002542 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002543}
eladalonf1841382017-06-12 01:16:46 -07002544TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002545 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002546}
2547
eladalonf1841382017-06-12 01:16:46 -07002548TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002549 const int kAbsSendTimeId = 1;
2550 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002551 send_parameters_.extensions.push_back(
2552 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2553 send_parameters_.extensions.push_back(
2554 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002555
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002556 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002557 FakeVideoSendStream* send_stream =
2558 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2559
2560 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002561 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002562
2563 // Setting the same extensions (even if in different order) shouldn't
2564 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002565 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002566 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002567
2568 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2569
2570 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002571 send_parameters_.extensions.resize(1);
2572 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002573
2574 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2575}
2576
eladalonf1841382017-06-12 01:16:46 -07002577TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002578 const int kTOffsetId = 1;
2579 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002580 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002581 recv_parameters_.extensions.push_back(
2582 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2583 recv_parameters_.extensions.push_back(
2584 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2585 recv_parameters_.extensions.push_back(
2586 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002587
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002588 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002589 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002590 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2591
2592 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002593 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002594
2595 // Setting the same extensions (even if in different order) shouldn't
2596 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002597 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002598 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002599
2600 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2601
2602 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002603 recv_parameters_.extensions.resize(1);
2604 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002605
2606 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2607}
2608
eladalonf1841382017-06-12 01:16:46 -07002609TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002610 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002611 const int kUnsupportedId = 1;
2612 const int kTOffsetId = 2;
2613
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002614 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002615 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002616 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002617 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002618 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002619 FakeVideoSendStream* send_stream =
2620 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2621
2622 // Only timestamp offset extension is set to send stream,
2623 // unsupported rtp extension is ignored.
2624 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002625 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2626 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002627}
2628
eladalonf1841382017-06-12 01:16:46 -07002629TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002630 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002631 const int kUnsupportedId = 1;
2632 const int kTOffsetId = 2;
2633
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002634 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002635 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002636 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002637 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002638 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002639 FakeVideoReceiveStream* recv_stream =
2640 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2641
2642 // Only timestamp offset extension is set to receive stream,
2643 // unsupported rtp extension is ignored.
2644 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002645 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2646 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002647}
2648
eladalonf1841382017-06-12 01:16:46 -07002649TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002650 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002651 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002652 send_parameters_.extensions.push_back(
2653 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002654 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002655 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2656 }
2657}
2658
eladalonf1841382017-06-12 01:16:46 -07002659TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002660 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002661 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002662 recv_parameters_.extensions.push_back(
2663 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002664 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002665 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2666 }
2667}
2668
eladalonf1841382017-06-12 01:16:46 -07002669TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002670 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002671 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002672 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002673 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002674 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002675 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002676
2677 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002678 send_parameters_.extensions.clear();
2679 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002680 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002681 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2682 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002683}
2684
eladalonf1841382017-06-12 01:16:46 -07002685TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002686 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002687 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002688 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002689 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002690 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002691 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002692
2693 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002694 recv_parameters_.extensions.clear();
2695 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002696 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002697 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2698 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002699}
2700
eladalonf1841382017-06-12 01:16:46 -07002701TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002702 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002703 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002704}
2705
eladalonf1841382017-06-12 01:16:46 -07002706TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002707 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002708 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002709}
2710
eladalonf1841382017-06-12 01:16:46 -07002711TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002712 FakeVideoReceiveStream* stream = AddRecvStream();
2713 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002714}
2715
eladalonf1841382017-06-12 01:16:46 -07002716TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002717 FakeVideoReceiveStream* stream = AddRecvStream();
2718 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2719}
2720
eladalonf1841382017-06-12 01:16:46 -07002721TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002722 FakeVideoReceiveStream* stream = AddRecvStream();
2723 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2724
Peter Boström126c03e2015-05-11 12:48:12 +02002725 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002726 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002727 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002728 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2729 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002730 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002731 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2732
2733 // Verify that REMB is turned on when setting default codecs since the
2734 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002735 parameters.codecs = engine_.codecs();
2736 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002737 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002738 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002739}
2740
eladalonf1841382017-06-12 01:16:46 -07002741TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002742 FakeVideoReceiveStream* stream = AddRecvStream();
2743 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2744
2745 // Verify that transport cc feedback is turned off when send(!) codecs without
2746 // transport cc feedback are set.
2747 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002748 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002749 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2750 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2751 stream = fake_call_->GetVideoReceiveStreams()[0];
2752 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2753
2754 // Verify that transport cc feedback is turned on when setting default codecs
2755 // since the default codecs have transport cc feedback enabled.
2756 parameters.codecs = engine_.codecs();
2757 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2758 stream = fake_call_->GetVideoReceiveStreams()[0];
2759 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2760}
2761
Elad Alonfadb1812019-05-24 13:40:02 +02002762TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2763 TestLossNotificationState(false);
2764}
2765
2766TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2767 RTC_DCHECK(!override_field_trials_);
2768 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2769 "WebRTC-RtcpLossNotification/Enabled/");
2770 SetUp();
2771 TestLossNotificationState(true);
2772}
2773
2774TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2775 RTC_DCHECK(!override_field_trials_);
2776 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2777 "WebRTC-RtcpLossNotification/Enabled/");
2778 SetUp();
2779
2780 AssignDefaultCodec();
2781 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2782
2783 {
2784 cricket::VideoSendParameters parameters;
2785 parameters.codecs = engine_.codecs();
2786 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2787 EXPECT_TRUE(channel_->SetSend(true));
2788 }
2789
2790 // Start with LNTF enabled.
2791 FakeVideoSendStream* send_stream =
2792 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2793 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2794 FakeVideoReceiveStream* recv_stream =
2795 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2796 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2797
2798 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2799 cricket::VideoSendParameters parameters;
2800 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2801 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2802 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2803 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2804 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2805 send_stream = fake_call_->GetVideoSendStreams()[0];
2806 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2807
2808 // Setting the default codecs again, including VP8, turns LNTF back on.
2809 parameters.codecs = engine_.codecs();
2810 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2811 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2812 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2813 send_stream = fake_call_->GetVideoSendStreams()[0];
2814 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2815}
2816
eladalonf1841382017-06-12 01:16:46 -07002817TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002818 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002819 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002820
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002821 cricket::VideoSendParameters parameters;
2822 parameters.codecs = engine_.codecs();
2823 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002824 EXPECT_TRUE(channel_->SetSend(true));
2825
2826 // Send side.
2827 FakeVideoSendStream* send_stream =
2828 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2829 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2830
2831 // Receiver side.
2832 FakeVideoReceiveStream* recv_stream =
2833 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2834 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2835
2836 // Nack history size should match between sender and receiver.
2837 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2838 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002839}
2840
eladalonf1841382017-06-12 01:16:46 -07002841TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002842 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002843 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002844
2845 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2846 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2847
2848 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002849 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002850 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002851 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2852 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002853 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2854 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2855 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002856 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2857
Peter Boström67c9df72015-05-11 14:34:58 +02002858 // Verify that NACK is turned on when setting default codecs since the
2859 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002860 parameters.codecs = engine_.codecs();
2861 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002862 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2863 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2864 send_stream = fake_call_->GetVideoSendStreams()[0];
2865 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002866}
2867
Peter Boströme7ba0862016-03-12 00:02:28 +01002868// This test verifies that new frame sizes reconfigures encoders even though not
2869// (yet) sending. The purpose of this is to permit encoding as quickly as
2870// possible once we start sending. Likely the frames being input are from the
2871// same source that will be sent later, which just means that we're ready
2872// earlier.
eladalonf1841382017-06-12 01:16:46 -07002873TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002874 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002875 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002876 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2877 channel_->SetSend(false);
2878
2879 FakeVideoSendStream* stream = AddSendStream();
2880
perkjfa10b552016-10-02 23:45:26 -07002881 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002882 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002883 EXPECT_EQ(0u, streams[0].width);
2884 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002885
Niels Möller805a27e2019-01-21 12:21:27 +01002886 webrtc::test::FrameForwarder frame_forwarder;
2887 cricket::FakeFrameSource frame_source(1280, 720,
2888 rtc::kNumMicrosecsPerSec / 30);
2889
2890 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2891 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002892
2893 // Frame entered, should be reconfigured to new dimensions.
2894 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002895 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2896 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002897
Niels Möllerff40b142018-04-09 08:49:14 +02002898 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002899}
2900
eladalonf1841382017-06-12 01:16:46 -07002901TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002902 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002903 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002904 cricket::VideoSendParameters parameters;
2905 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002906 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002907 AddSendStream();
2908
Niels Möller805a27e2019-01-21 12:21:27 +01002909 webrtc::test::FrameForwarder frame_forwarder;
2910 cricket::FakeFrameSource frame_source(1280, 720,
2911 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002912 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002913 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002914 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2915 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002916
2917 EXPECT_TRUE(channel_->SetSend(true));
2918
Niels Möller805a27e2019-01-21 12:21:27 +01002919 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002920 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2921 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2922
2923 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2924
2925 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002926 webrtc::VideoEncoderConfig encoder_config =
2927 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002928 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002929 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002930 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002931 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2932 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002933 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2934 << "Non-screenshare shouldn't use min-transmit bitrate.";
2935
Niels Möllerff40b142018-04-09 08:49:14 +02002936 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002937 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002938 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002939 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002940 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2941 &frame_forwarder));
2942 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002943 // Send stream recreated after option change.
2944 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2945 send_stream = fake_call_->GetVideoSendStreams().front();
2946 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002947
2948 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002949 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002950 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002951 encoder_config.content_type);
2952 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2953 encoder_config.min_transmit_bitrate_bps);
2954
perkjfa10b552016-10-02 23:45:26 -07002955 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002956 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2957 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002958 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002959 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002960}
2961
eladalonf1841382017-06-12 01:16:46 -07002962TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002963 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002964 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002965 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002966 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002967
2968 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002969 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002970 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002971 webrtc::test::FrameForwarder frame_forwarder;
2972 cricket::FakeFrameSource frame_source(1280, 720,
2973 rtc::kNumMicrosecsPerSec / 30);
2974 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002975 EXPECT_TRUE(channel_->SetSend(true));
2976
Niels Möller805a27e2019-01-21 12:21:27 +01002977 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002978 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2979 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2980
perkj26091b12016-09-01 01:17:40 -07002981 webrtc::VideoEncoderConfig encoder_config =
2982 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002983
2984 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002985 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002986 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002987 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002988
2989 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2990 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002991 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002992 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002993 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002994
Niels Möllerff40b142018-04-09 08:49:14 +02002995 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002996}
2997
eladalonf1841382017-06-12 01:16:46 -07002998TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002999 FakeVideoSendStream* stream = AddSendStream();
3000 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3001}
3002
eladalonf1841382017-06-12 01:16:46 -07003003TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003004 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003005 media_config.video.suspend_below_min_bitrate = true;
3006
Sebastian Jansson84848f22018-11-16 10:40:36 +01003007 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003008 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3009 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003010 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003011
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003012 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003013
3014 FakeVideoSendStream* stream = AddSendStream();
3015 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3016
nisse0db023a2016-03-01 04:29:59 -08003017 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003018 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003019 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3020 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003021 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003022
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003023 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003024
nisse0db023a2016-03-01 04:29:59 -08003025 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003026 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3027}
3028
eladalonf1841382017-06-12 01:16:46 -07003029TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003030 FakeVideoSendStream* stream = AddSendStream();
3031 webrtc::VideoCodecVP8 vp8_settings;
3032 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3033 EXPECT_TRUE(vp8_settings.denoisingOn);
3034}
3035
eladalonf1841382017-06-12 01:16:46 -07003036TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003037 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003038 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003039 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003040
Peter Boström2feafdb2015-09-09 14:32:14 +02003041 // Single-stream settings should apply with RTX as well (verifies that we
3042 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3043 // both RTX and regular SSRCs).
3044 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003045
Niels Möller805a27e2019-01-21 12:21:27 +01003046 webrtc::test::FrameForwarder frame_forwarder;
3047 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003048 channel_->SetSend(true);
3049
Niels Möller805a27e2019-01-21 12:21:27 +01003050 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003051
pbos4cba4eb2015-10-26 11:18:18 -07003052 webrtc::VideoCodecVP8 vp8_settings;
3053 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3054 EXPECT_TRUE(vp8_settings.denoisingOn)
3055 << "VP8 denoising should be on by default.";
3056
Niels Möller805a27e2019-01-21 12:21:27 +01003057 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003058
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003059 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3060 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003061 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3062 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003063
Niels Möller805a27e2019-01-21 12:21:27 +01003064 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003065
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003066 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3067 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003068 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3069 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3070
Niels Möllerff40b142018-04-09 08:49:14 +02003071 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003072 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003073 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003074 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003075 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003076
Mirko Bonadeif859e552018-05-30 15:31:29 +02003077 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003078 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3079 // Autmatic resize off when using simulcast.
3080 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3081 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3082
3083 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07003084 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003085 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003086 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003087
Niels Möller805a27e2019-01-21 12:21:27 +01003088 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003089
Mirko Bonadeif859e552018-05-30 15:31:29 +02003090 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003091 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3092 EXPECT_FALSE(vp8_settings.denoisingOn);
3093 // Resizing and frame dropping always off for screen sharing.
3094 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3095 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3096
Niels Möller805a27e2019-01-21 12:21:27 +01003097 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003098
3099 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3100 EXPECT_FALSE(vp8_settings.denoisingOn);
3101 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3102 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3103
Niels Möllerff40b142018-04-09 08:49:14 +02003104 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003105}
3106
deadbeef119760a2016-04-04 11:43:27 -07003107// Test that setting the same options doesn't result in the encoder being
3108// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003109TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003110 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003111 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003112
perkjfa10b552016-10-02 23:45:26 -07003113 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003114 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003115 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003116 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3117 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3118
Niels Möller805a27e2019-01-21 12:21:27 +01003119 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3120 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3121 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003122 // Expect 1 reconfigurations at this point from the initial configuration.
3123 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003124
3125 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003126 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003127 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3128
3129 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003130 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003131 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003132 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3133
Niels Möllerff40b142018-04-09 08:49:14 +02003134 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003135}
3136
eladalonf1841382017-06-12 01:16:46 -07003137class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003138 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003139 Vp9SettingsTest() : Vp9SettingsTest("") {}
3140 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003141 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003142 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003143 }
3144 virtual ~Vp9SettingsTest() {}
3145
3146 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003147 void TearDown() override {
3148 // Remove references to encoder_factory_ since this will be destroyed
3149 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003150 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003151 }
Erik Språng143cec12015-04-28 10:01:41 +02003152};
3153
3154TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003155 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003156 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003157 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003158
Peter Boström2feafdb2015-09-09 14:32:14 +02003159 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003160
Niels Möller805a27e2019-01-21 12:21:27 +01003161 webrtc::test::FrameForwarder frame_forwarder;
3162 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003163 channel_->SetSend(true);
3164
Niels Möller805a27e2019-01-21 12:21:27 +01003165 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003166
pbos4cba4eb2015-10-26 11:18:18 -07003167 webrtc::VideoCodecVP9 vp9_settings;
3168 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003169 EXPECT_TRUE(vp9_settings.denoisingOn)
3170 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003171
Niels Möller805a27e2019-01-21 12:21:27 +01003172 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003173
Erik Språng143cec12015-04-28 10:01:41 +02003174 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3175 EXPECT_FALSE(vp9_settings.denoisingOn);
3176 // Frame dropping always on for real time video.
3177 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3178
Niels Möller805a27e2019-01-21 12:21:27 +01003179 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003180
3181 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3182 EXPECT_TRUE(vp9_settings.denoisingOn);
3183 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3184
3185 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003186 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003187 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003188 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003189
Niels Möller805a27e2019-01-21 12:21:27 +01003190 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003191
3192 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3193 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003194 // Frame dropping always on for screen sharing.
3195 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003196
Niels Möller805a27e2019-01-21 12:21:27 +01003197 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003198
3199 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3200 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003201 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003202
Niels Möllerff40b142018-04-09 08:49:14 +02003203 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003204}
3205
Sergey Silkinf18072e2018-03-14 10:35:35 +01003206TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3207 cricket::VideoSendParameters parameters;
3208 parameters.codecs.push_back(GetEngineCodec("VP9"));
3209 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3210
3211 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3212
3213 FakeVideoSendStream* stream =
3214 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3215
3216 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003217
Niels Möller805a27e2019-01-21 12:21:27 +01003218 webrtc::test::FrameForwarder frame_forwarder;
3219 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003220 channel_->SetSend(true);
3221
Niels Möller805a27e2019-01-21 12:21:27 +01003222 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003223
3224 webrtc::VideoCodecVP9 vp9_settings;
3225 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3226
3227 const size_t kNumSpatialLayers = ssrcs.size();
3228 const size_t kNumTemporalLayers = 3;
3229 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3230 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3231
Niels Möllerff40b142018-04-09 08:49:14 +02003232 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003233}
3234
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003235TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3236 cricket::VideoSendParameters parameters;
3237 parameters.codecs.push_back(GetEngineCodec("VP9"));
3238 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3239
3240 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3241
3242 FakeVideoSendStream* stream =
3243 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3244
3245 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3246
3247 // Despite 3 ssrcs provided, single layer is used.
3248 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3249
3250 webrtc::test::FrameForwarder frame_forwarder;
3251 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3252 channel_->SetSend(true);
3253
3254 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3255
3256 webrtc::VideoCodecVP9 vp9_settings;
3257 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3258
3259 const size_t kNumSpatialLayers = ssrcs.size();
3260 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3261
3262 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3263}
3264
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003265TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3266 cricket::VideoSendParameters send_parameters;
3267 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3268 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3269
3270 const size_t kNumSpatialLayers = 3;
3271 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3272
3273 FakeVideoSendStream* stream =
3274 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3275
3276 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3277 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3278 ASSERT_TRUE(parameters.encodings[0].active);
3279 ASSERT_TRUE(parameters.encodings[1].active);
3280 ASSERT_TRUE(parameters.encodings[2].active);
3281 // Invert value to verify copying.
3282 parameters.encodings[1].active = false;
3283 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3284
3285 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3286
3287 // number_of_streams should be 1 since all spatial layers are sent on the
3288 // same SSRC. But encoding parameters of all layers is supposed to be copied
3289 // and stored in simulcast_layers[].
3290 EXPECT_EQ(1u, encoder_config.number_of_streams);
3291 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3292 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3293 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3294 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3295}
3296
Sergey Silkincf267052019-04-09 11:40:09 +02003297class Vp9SettingsTestWithFieldTrial
3298 : public Vp9SettingsTest,
3299 public ::testing::WithParamInterface<
3300 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003301 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003302 Vp9SettingsTestWithFieldTrial()
3303 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3304 num_spatial_layers_(::testing::get<1>(GetParam())),
3305 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003306 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003307
3308 void VerifySettings(int num_spatial_layers,
3309 int num_temporal_layers,
3310 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003311 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003312 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003313 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3314
3315 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3316
Niels Möller805a27e2019-01-21 12:21:27 +01003317 webrtc::test::FrameForwarder frame_forwarder;
3318 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003319 channel_->SetSend(true);
3320
Niels Möller805a27e2019-01-21 12:21:27 +01003321 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003322
3323 webrtc::VideoCodecVP9 vp9_settings;
3324 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3325 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3326 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003327 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003328
Niels Möllerff40b142018-04-09 08:49:14 +02003329 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003330 }
Sergey Silkincf267052019-04-09 11:40:09 +02003331
3332 const uint8_t num_spatial_layers_;
3333 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003334 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003335};
3336
Sergey Silkincf267052019-04-09 11:40:09 +02003337TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003338 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3339 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003340}
3341
Sergey Silkincf267052019-04-09 11:40:09 +02003342INSTANTIATE_TEST_SUITE_P(
3343 ,
3344 Vp9SettingsTestWithFieldTrial,
3345 ::testing::Values(
3346 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3347 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3348 1,
3349 1,
3350 webrtc::InterLayerPredMode::kOnKeyPic),
3351 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3352 2,
3353 3,
3354 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003355 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003356 1,
3357 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003358 webrtc::InterLayerPredMode::kOnKeyPic),
3359 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003360 1,
3361 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003362 webrtc::InterLayerPredMode::kOnKeyPic),
3363 std::make_tuple(
3364 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3365 1,
3366 1,
3367 webrtc::InterLayerPredMode::kOff),
3368 std::make_tuple(
3369 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3370 1,
3371 1,
3372 webrtc::InterLayerPredMode::kOn),
3373 std::make_tuple(
3374 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3375 1,
3376 1,
3377 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003378
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003379TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3380 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3381 ASSERT_EQ(1u, streams.size());
3382 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3383}
3384
3385TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003386 RTC_DCHECK(!override_field_trials_);
3387 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003388 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3389 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3390 ASSERT_EQ(1u, streams.size());
3391 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3392}
3393
asapersson3c81a1a2017-06-14 05:52:21 -07003394TEST_F(WebRtcVideoChannelTest,
3395 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003396 RTC_DCHECK(!override_field_trials_);
3397 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003398 "WebRTC-Video-BalancedDegradation/Disabled/");
3399 const bool kResolutionScalingEnabled = true;
3400 const bool kFpsScalingEnabled = false;
3401 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3402}
3403
3404TEST_F(WebRtcVideoChannelTest,
3405 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003406 RTC_DCHECK(!override_field_trials_);
3407 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003408 "WebRTC-Video-BalancedDegradation/Enabled/");
3409 const bool kResolutionScalingEnabled = true;
3410 const bool kFpsScalingEnabled = true;
3411 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3412}
3413
eladalonf1841382017-06-12 01:16:46 -07003414TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003415 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003416}
3417
eladalonf1841382017-06-12 01:16:46 -07003418TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003419 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003420}
3421
Niels Möller3de32e62019-01-18 08:42:18 +01003422TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3423 TestCpuAdaptation(false, true);
3424}
3425
eladalonf1841382017-06-12 01:16:46 -07003426TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003427 TestCpuAdaptation(true, true);
3428}
3429
eladalonf1841382017-06-12 01:16:46 -07003430TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003431 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003432 cricket::VideoSendParameters parameters;
3433 parameters.codecs.push_back(codec);
3434
kthelgason2bc68642017-02-07 07:02:22 -08003435 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003436 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003437 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003438 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3439 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003440 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003441 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3442
3443 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003444 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003445
Per766ad3b2016-04-05 15:23:49 +02003446 ASSERT_TRUE(channel_->SetSend(true));
3447 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003448 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003449 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003450
3451 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3452 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003453
Niels Möllerdcc70292019-01-15 16:32:38 +01003454 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3455 // Dont' expect anything on framerate_scaling_enabled, since the default is
3456 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003457
Niels Möllerdcc70292019-01-15 16:32:38 +01003458 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003459 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003460 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003461 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003462 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3463 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003464 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003465
Niels Möllerdcc70292019-01-15 16:32:38 +01003466 // Switch back to the normal capturer. Expect resolution scaling to be
3467 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003468 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3469 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003470 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3471 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003472 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003473
Niels Möllerff40b142018-04-09 08:49:14 +02003474 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003475}
3476
asapersson3c81a1a2017-06-14 05:52:21 -07003477// TODO(asapersson): Remove this test when the balanced field trial is removed.
3478void WebRtcVideoChannelTest::TestDegradationPreference(
3479 bool resolution_scaling_enabled,
3480 bool fps_scaling_enabled) {
3481 cricket::VideoCodec codec = GetEngineCodec("VP8");
3482 cricket::VideoSendParameters parameters;
3483 parameters.codecs.push_back(codec);
3484
3485 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003486 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003487 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003488 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3489 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003490 channel_->OnReadyToSend(true);
3491
3492 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3493
3494 AddSendStream();
3495
Niels Möller805a27e2019-01-21 12:21:27 +01003496 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003497 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003498 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003499
3500 EXPECT_TRUE(channel_->SetSend(true));
3501
3502 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3503 EXPECT_EQ(resolution_scaling_enabled,
3504 send_stream->resolution_scaling_enabled());
3505 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3506
Niels Möllerff40b142018-04-09 08:49:14 +02003507 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003508}
3509
eladalonf1841382017-06-12 01:16:46 -07003510void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3511 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003512 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003513 cricket::VideoSendParameters parameters;
3514 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003515
kthelgason2bc68642017-02-07 07:02:22 -08003516 MediaConfig media_config = GetMediaConfig();
3517 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003518 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003519 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003520 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003521 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3522 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003523 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003524
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003525 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003526
3527 AddSendStream();
3528
Niels Möller805a27e2019-01-21 12:21:27 +01003529 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003530 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003531 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003532 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003533
3534 EXPECT_TRUE(channel_->SetSend(true));
3535
solenberge5269742015-09-08 05:13:22 -07003536 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003537
sprangc5d62e22017-04-02 23:53:04 -07003538 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003539 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003540 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003541 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003542 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3543 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3544 } else {
3545 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3546 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3547 }
Niels Möllerff40b142018-04-09 08:49:14 +02003548 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003549}
3550
eladalonf1841382017-06-12 01:16:46 -07003551TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003552 // Start at last timestamp to verify that wraparounds are estimated correctly.
3553 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3554 static const int64_t kInitialNtpTimeMs = 1247891230;
3555 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003556 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003557
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003558 FakeVideoReceiveStream* stream = AddRecvStream();
3559 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003560 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003561
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003562 webrtc::VideoFrame video_frame =
3563 webrtc::VideoFrame::Builder()
3564 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3565 .set_timestamp_rtp(kInitialTimestamp)
3566 .set_timestamp_us(0)
3567 .set_rotation(webrtc::kVideoRotation_0)
3568 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003569 // Initial NTP time is not available on the first frame, but should still be
3570 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003571 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003572
3573 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003574
3575 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3576 // triggers a constant-overflow warning, hence we're calculating it explicitly
3577 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003578 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003579 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3580 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003581 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003582
3583 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003584
3585 // Verify that NTP time has been correctly deduced.
3586 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003587 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003588 ASSERT_EQ(1u, info.receivers.size());
3589 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003590}
3591
eladalonf1841382017-06-12 01:16:46 -07003592TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003593 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003594 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003595
3596 VideoCodec codec;
3597 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003598 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003599
3600 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003601 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3602 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003603 FakeVideoSendStream* stream = AddSendStream(
3604 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003605 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003606
3607 // Make sure NACK and FEC are enabled on the correct payload types.
3608 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003609 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3610 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003611
3612 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3613 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003614 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003615 // TODO(juberti): Check RTCP, PLI, TMMBR.
3616}
3617
brandtr31bd2242017-05-19 05:47:46 -07003618// The following four tests ensures that FlexFEC is not activated by default
3619// when the field trials are not enabled.
3620// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3621// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003622TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003623 FakeVideoSendStream* stream = AddSendStream();
3624 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3625
brandtr3d200bd2017-01-16 06:59:19 -08003626 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003627 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3628 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003629}
3630
eladalonf1841382017-06-12 01:16:46 -07003631TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003632 FakeVideoSendStream* stream = AddSendStream(
3633 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3634 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3635
brandtr3d200bd2017-01-16 06:59:19 -08003636 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003637 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3638 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3639}
3640
Yves Gerey665174f2018-06-19 15:03:05 +02003641TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003642 AddRecvStream();
3643
3644 const std::vector<FakeFlexfecReceiveStream*>& streams =
3645 fake_call_->GetFlexfecReceiveStreams();
3646 EXPECT_TRUE(streams.empty());
3647}
3648
eladalonf1841382017-06-12 01:16:46 -07003649TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003650 AddRecvStream(
3651 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3652
3653 const std::vector<FakeFlexfecReceiveStream*>& streams =
3654 fake_call_->GetFlexfecReceiveStreams();
3655 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003656}
3657
3658// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3659// tests that use this test fixture into the corresponding "non-field trial"
3660// tests.
eladalonf1841382017-06-12 01:16:46 -07003661class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003662 public:
eladalonf1841382017-06-12 01:16:46 -07003663 WebRtcVideoChannelFlexfecRecvTest()
3664 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003665};
3666
eladalonf1841382017-06-12 01:16:46 -07003667TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003668 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3669 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3670 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3671}
3672
eladalonf1841382017-06-12 01:16:46 -07003673TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003674 AddRecvStream();
3675
3676 const std::vector<FakeFlexfecReceiveStream*>& streams =
3677 fake_call_->GetFlexfecReceiveStreams();
3678 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003679
3680 const std::vector<FakeVideoReceiveStream*>& video_streams =
3681 fake_call_->GetVideoReceiveStreams();
3682 ASSERT_EQ(1U, video_streams.size());
3683 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3684 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3685 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003686}
3687
eladalonf1841382017-06-12 01:16:46 -07003688TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003689 AddRecvStream(
3690 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3691
3692 const std::vector<FakeFlexfecReceiveStream*>& streams =
3693 fake_call_->GetFlexfecReceiveStreams();
3694 ASSERT_EQ(1U, streams.size());
3695 const FakeFlexfecReceiveStream* stream = streams.front();
3696 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3697 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3698 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3699 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3700 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003701
3702 const std::vector<FakeVideoReceiveStream*>& video_streams =
3703 fake_call_->GetVideoReceiveStreams();
3704 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003705 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3706 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003707 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003708 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003709 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003710}
3711
eladalonf1841382017-06-12 01:16:46 -07003712TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003713 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3714 cricket::VideoRecvParameters recv_parameters;
3715 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3716 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3717
3718 AddRecvStream(
3719 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3720 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003721 const std::vector<FakeVideoReceiveStream*>& video_streams =
3722 fake_call_->GetVideoReceiveStreams();
3723 ASSERT_EQ(1U, video_streams.size());
3724 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3725 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3726 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003727
3728 // Enable FlexFEC.
3729 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3730 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3731 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3732 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3733 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3734 << "Enabling FlexFEC should not create VideoReceiveStream.";
3735 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3736 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003737 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3738 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003739}
3740
eladalonf1841382017-06-12 01:16:46 -07003741TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003742 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3743 cricket::VideoRecvParameters recv_parameters;
3744 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3745 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3746 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3747
3748 AddRecvStream(
3749 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3750 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003751 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003752 const std::vector<FakeVideoReceiveStream*>& video_streams =
3753 fake_call_->GetVideoReceiveStreams();
3754 ASSERT_EQ(1U, video_streams.size());
3755 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3756 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3757 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003758
3759 // Disable FlexFEC.
3760 recv_parameters.codecs.clear();
3761 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3762 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3763 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3764 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3765 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3766 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3767 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3768 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003769 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3770 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003771}
3772
brandtr31bd2242017-05-19 05:47:46 -07003773// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3774// tests that use this test fixture into the corresponding "non-field trial"
3775// tests.
eladalonf1841382017-06-12 01:16:46 -07003776class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003777 public:
eladalonf1841382017-06-12 01:16:46 -07003778 WebRtcVideoChannelFlexfecSendRecvTest()
3779 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003780 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3781 }
3782};
3783
Yves Gerey665174f2018-06-19 15:03:05 +02003784TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003785 FakeVideoSendStream* stream = AddSendStream();
3786 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3787
brandtr3d200bd2017-01-16 06:59:19 -08003788 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3789 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3790 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003791}
3792
eladalonf1841382017-06-12 01:16:46 -07003793TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003794 FakeVideoSendStream* stream = AddSendStream(
3795 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3796 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3797
brandtr3d200bd2017-01-16 06:59:19 -08003798 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3799 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3800 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3801 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003802}
3803
eladalonf1841382017-06-12 01:16:46 -07003804TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003805 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003806 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003807 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003808
3809 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003810 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003811
brandtrb5f2c3f2016-10-04 23:28:39 -07003812 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3813 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003814}
3815
eladalonf1841382017-06-12 01:16:46 -07003816TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003817 cricket::VideoSendParameters parameters;
3818 parameters.codecs.push_back(GetEngineCodec("VP8"));
3819 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3820
3821 FakeVideoSendStream* stream = AddSendStream();
3822 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3823
brandtr3d200bd2017-01-16 06:59:19 -08003824 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003825}
3826
eladalonf1841382017-06-12 01:16:46 -07003827TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003828 AddRecvStream(
3829 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003830
3831 cricket::VideoRecvParameters recv_parameters;
3832 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3833 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3834 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003835
3836 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3837 fake_call_->GetFlexfecReceiveStreams();
3838 ASSERT_EQ(1U, flexfec_streams.size());
3839 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3840 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3841 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003842 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003843 flexfec_stream_config.payload_type);
3844 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3845 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3846 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3847 const std::vector<FakeVideoReceiveStream*>& video_streams =
3848 fake_call_->GetVideoReceiveStreams();
3849 const FakeVideoReceiveStream* video_stream = video_streams.front();
3850 const webrtc::VideoReceiveStream::Config& video_stream_config =
3851 video_stream->GetConfig();
3852 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3853 flexfec_stream_config.local_ssrc);
3854 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3855 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3856 flexfec_stream_config.rtcp_send_transport);
3857 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3858 // spec-compliant way.
3859 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3860 flexfec_stream_config.transport_cc);
3861 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3862 EXPECT_EQ(video_stream_config.rtp.extensions,
3863 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003864}
3865
brandtr31bd2242017-05-19 05:47:46 -07003866// We should not send FlexFEC, even if we advertise it, unless the right
3867// field trial is set.
3868// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003869TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003870 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3871 cricket::VideoSendParameters parameters;
3872 parameters.codecs.push_back(GetEngineCodec("VP8"));
3873 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3874 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3875
3876 FakeVideoSendStream* stream = AddSendStream();
3877 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3878
3879 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003880 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003881 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3882}
3883
eladalonf1841382017-06-12 01:16:46 -07003884TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003885 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3886 cricket::VideoSendParameters parameters;
3887 parameters.codecs.push_back(GetEngineCodec("VP8"));
3888 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3889 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3890
3891 FakeVideoSendStream* stream = AddSendStream(
3892 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3893 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3894
3895 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003896 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003897 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3898}
3899
eladalonf1841382017-06-12 01:16:46 -07003900TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003901 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003902 const int kUnusedPayloadType = 127;
3903 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3904
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003905 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003906 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003907 parameters.codecs.push_back(rtx_codec);
3908 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003909 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003910}
3911
eladalonf1841382017-06-12 01:16:46 -07003912TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003913 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003914 const int kUnusedPayloadType1 = 126;
3915 const int kUnusedPayloadType2 = 127;
3916 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3917 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3918 {
3919 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3920 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3921 cricket::VideoSendParameters parameters;
3922 parameters.codecs.push_back(GetEngineCodec("VP8"));
3923 parameters.codecs.push_back(rtx_codec);
3924 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3925 }
3926 {
3927 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3928 kUnusedPayloadType1, kUnusedPayloadType2);
3929 cricket::VideoSendParameters parameters;
3930 parameters.codecs.push_back(GetEngineCodec("VP8"));
3931 parameters.codecs.push_back(rtx_codec);
3932 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3933 << "RTX without matching video codec should be rejected.";
3934 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003935}
3936
eladalonf1841382017-06-12 01:16:46 -07003937TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003938 const int kUnusedPayloadType1 = 126;
3939 const int kUnusedPayloadType2 = 127;
3940 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3941 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3942
3943 // SSRCs for RTX.
3944 cricket::StreamParams params =
3945 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3946 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3947 AddSendStream(params);
3948
3949 // Original payload type for RTX.
3950 cricket::VideoSendParameters parameters;
3951 parameters.codecs.push_back(GetEngineCodec("VP8"));
3952 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3953 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3954 parameters.codecs.push_back(rtx_codec);
3955 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3956 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3957 const webrtc::VideoSendStream::Config& config_before =
3958 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3959 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3960 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3961 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3962
3963 // Change payload type for RTX.
3964 parameters.codecs[1].id = kUnusedPayloadType2;
3965 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3966 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3967 const webrtc::VideoSendStream::Config& config_after =
3968 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3969 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3970 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3971 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3972}
3973
eladalonf1841382017-06-12 01:16:46 -07003974TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003975 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003976 parameters.codecs.push_back(GetEngineCodec("VP8"));
3977 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003978 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003979
3980 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003981 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003982
magjed509e4fe2016-11-18 01:34:11 -08003983 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003984
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003985 parameters.codecs.pop_back();
3986 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003987 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003988 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003989 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003990 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003991 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3992}
3993
eladalonf1841382017-06-12 01:16:46 -07003994TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003995 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003996 cricket::VideoSendParameters parameters;
3997 parameters.codecs.push_back(GetEngineCodec("VP8"));
3998 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3999 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4000
4001 FakeVideoSendStream* stream = AddSendStream(
4002 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4003 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4004
brandtr3d200bd2017-01-16 06:59:19 -08004005 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4006 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004007 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4008 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4009
4010 parameters.codecs.pop_back();
4011 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4012 stream = fake_call_->GetVideoSendStreams()[0];
4013 ASSERT_TRUE(stream != nullptr);
4014 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004015 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004016 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004017}
4018
eladalonf1841382017-06-12 01:16:46 -07004019TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004020 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004021 cricket::VideoCodec codec(100, "VP8");
4022 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4023 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004024
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004025 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004026 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004027
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004028 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004029 webrtc::test::FrameForwarder frame_forwarder;
4030 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004031
4032 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004033 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004034
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004035 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004036 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4037 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004038 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004039 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004040 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004041 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004042}
4043
eladalonf1841382017-06-12 01:16:46 -07004044TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004045 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4046 200000);
4047}
4048
eladalonf1841382017-06-12 01:16:46 -07004049TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004050 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4051 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4052 ASSERT_EQ(1u, streams.size());
4053 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4054}
4055
eladalonf1841382017-06-12 01:16:46 -07004056TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004057 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004058 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004059}
4060
eladalonf1841382017-06-12 01:16:46 -07004061TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004062 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004063}
4064
eladalonf1841382017-06-12 01:16:46 -07004065TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004066 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4067 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4068 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004069}
4070
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004071// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4072// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004073TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004074 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4075 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4076 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4077 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004078 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004079 ExpectSetBitrateParameters(100000, 200000, 400000);
4080 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4081 // Since the codec isn't changing, start_bitrate_bps should be -1.
4082 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004083
4084 // Decrease max_bandwidth_bps.
4085 send_parameters_.max_bandwidth_bps = 350000;
4086 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004087
4088 // Now try again with the values flipped around.
4089 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4090 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004091 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004092 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004093
4094 // If we change the codec max, max_bandwidth_bps should still apply.
4095 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004096 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004097 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004098}
4099
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004100// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4101// are present in the same send parameters, the settings are combined correctly.
4102TEST_F(WebRtcVideoChannelTest,
4103 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4104 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4105 // Transport.
4106 webrtc::MediaTransportSettings settings;
4107 settings.is_caller = true;
4108 webrtc::FakeMediaTransport fake_media_transport(settings);
4109 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4110 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004111 channel_->SetInterface(network_interface.get(),
4112 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004113
4114 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4115 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4116 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4117 send_parameters_.max_bandwidth_bps = 400000;
4118 {
4119 // We expect max_bandwidth_bps to take priority, if set.
4120 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4121 ASSERT_EQ(1u,
4122 fake_media_transport.target_rate_constraints_in_order().size());
4123 const webrtc::MediaTransportTargetRateConstraints& constraint =
4124 fake_media_transport.target_rate_constraints_in_order()[0];
4125 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4126 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4127 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4128 }
4129
4130 {
4131 // Decrease max_bandwidth_bps.
4132 send_parameters_.max_bandwidth_bps = 350000;
4133 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4134 ASSERT_EQ(2u,
4135 fake_media_transport.target_rate_constraints_in_order().size());
4136 const webrtc::MediaTransportTargetRateConstraints& constraint =
4137 fake_media_transport.target_rate_constraints_in_order()[1];
4138
4139 // Since the codec isn't changing, start_bitrate_bps should be 0.
4140 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4141 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4142 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4143 }
4144
4145 {
4146 // Now try again with the values flipped around.
4147 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4148 send_parameters_.max_bandwidth_bps = 300000;
4149 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4150 ASSERT_EQ(3u,
4151 fake_media_transport.target_rate_constraints_in_order().size());
4152 const webrtc::MediaTransportTargetRateConstraints& constraint =
4153 fake_media_transport.target_rate_constraints_in_order()[2];
4154
4155 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4156 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4157 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4158 }
4159
4160 {
4161 // Now try again with the values flipped around.
4162 // If we change the codec max, max_bandwidth_bps should still apply.
4163 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4164 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4165 ASSERT_EQ(4u,
4166 fake_media_transport.target_rate_constraints_in_order().size());
4167 const webrtc::MediaTransportTargetRateConstraints& constraint =
4168 fake_media_transport.target_rate_constraints_in_order()[3];
4169
4170 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4171 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4172 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4173 }
4174}
4175
Yves Gerey665174f2018-06-19 15:03:05 +02004176TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004177 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4178 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004179 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004180 // Setting max bitrate should keep previous min bitrate.
4181 // Setting max bitrate should not reset start bitrate.
4182 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004183 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004184}
4185
eladalonf1841382017-06-12 01:16:46 -07004186TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004187 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004188 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004189 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004190 // -1 means to disable max bitrate (set infinite).
4191 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004192 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004193 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004194}
4195
eladalonf1841382017-06-12 01:16:46 -07004196TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004197 send_parameters_.max_bandwidth_bps = 99999;
4198 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004199 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004200 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004201 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4202 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4203 stream->GetVideoStreams()[0].max_bitrate_bps);
4204
4205 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004206 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004207 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4208 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004209 stream->GetVideoStreams()[0].max_bitrate_bps);
4210}
4211
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004212// Tests that when the codec specific max bitrate and VideoSendParameters
4213// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4214// appropriately.
4215TEST_F(WebRtcVideoChannelTest,
4216 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4217 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4218 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4219 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4220 send_parameters_.max_bandwidth_bps = -1;
4221 AddSendStream();
4222 ExpectSetMaxBitrate(300000);
4223 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4224
4225 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4226 ASSERT_EQ(1u, video_send_streams.size());
4227 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4228 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4229 // First the max bitrate is set based upon the codec param.
4230 EXPECT_EQ(300000,
4231 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4232
4233 // The VideoSendParameters max bitrate overrides the codec's.
4234 send_parameters_.max_bandwidth_bps = 500000;
4235 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4236 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4237 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4238 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4239}
4240
4241// Tests that when the codec specific max bitrate and RtpParameters
4242// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4243// appropriately.
4244TEST_F(WebRtcVideoChannelTest,
4245 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4246 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4247 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4248 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4249 send_parameters_.max_bandwidth_bps = -1;
4250 AddSendStream();
4251 ExpectSetMaxBitrate(300000);
4252 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4253
4254 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4255 ASSERT_EQ(1u, video_send_streams.size());
4256 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4257 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4258 // First the max bitrate is set based upon the codec param.
4259 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4260
4261 // The RtpParameter max bitrate overrides the codec's.
4262 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4263 ASSERT_EQ(1u, parameters.encodings.size());
4264 parameters.encodings[0].max_bitrate_bps = 500000;
4265 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4266 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4267 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4268 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4269}
4270
Åsa Persson55659812018-06-18 17:51:32 +02004271TEST_F(WebRtcVideoChannelTest,
4272 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4273 send_parameters_.max_bandwidth_bps = 99999;
4274 FakeVideoSendStream* stream = AddSendStream();
4275 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4276 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4277 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4278 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4279 stream->GetVideoStreams()[0].max_bitrate_bps);
4280
4281 // Get and set the rtp encoding parameters.
4282 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4283 EXPECT_EQ(1u, parameters.encodings.size());
4284
4285 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4286 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4287 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4288 stream->GetVideoStreams()[0].max_bitrate_bps);
4289
4290 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4291 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4292 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4293 stream->GetVideoStreams()[0].max_bitrate_bps);
4294}
4295
eladalonf1841382017-06-12 01:16:46 -07004296TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004297 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004298 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004299 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004300 channel_->SetSend(true);
4301
4302 FakeVideoSendStream* stream = AddSendStream();
4303
Niels Möller805a27e2019-01-21 12:21:27 +01004304 webrtc::test::FrameForwarder frame_forwarder;
4305 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004306
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004307 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4308 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4309 EXPECT_GT(initial_max_bitrate_bps, 0);
4310
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004311 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4312 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004313 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004314 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004315 streams = stream->GetVideoStreams();
4316 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004317 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004318}
4319
eladalonf1841382017-06-12 01:16:46 -07004320TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004321 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004322 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004323 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004324 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004325 channel_->SetSend(true);
4326
4327 FakeVideoSendStream* stream = AddSendStream(
4328 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4329
4330 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004331 webrtc::test::FrameForwarder frame_forwarder;
4332 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4333 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004334
4335 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4336 ASSERT_GT(streams.size(), 1u)
4337 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004338 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004339 EXPECT_GT(initial_max_bitrate_bps, 0);
4340
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004341 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4342 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004343 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004344 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004345 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004346 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004347 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4348
Niels Möllerff40b142018-04-09 08:49:14 +02004349 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004350}
4351
eladalonf1841382017-06-12 01:16:46 -07004352TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004353 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004354 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004355 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004356 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4357 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004358 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004359 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004360
4361 VideoCodec codec;
4362 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4363 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4364}
4365
eladalonf1841382017-06-12 01:16:46 -07004366TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004367 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004368 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004369 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004370 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004371 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004372 parameters.codecs[0].id = kIncorrectPayloads[i];
4373 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004374 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004375 }
4376}
4377
eladalonf1841382017-06-12 01:16:46 -07004378TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004379 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004380 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004381 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004382 parameters.codecs[0].id = payload_type;
4383 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004384 << "Payload type '" << payload_type << "' rejected.";
4385 }
4386}
4387
deadbeef67cf2c12016-04-13 10:07:16 -07004388// Test that setting the a different set of codecs but with an identical front
4389// codec doesn't result in the stream being recreated.
4390// This may happen when a subsequent negotiation includes fewer codecs, as a
4391// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004392TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004393 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4394 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004395 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4396 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004397 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4398
4399 AddSendStream();
4400 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4401
4402 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004403 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004404 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4405 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4406}
4407
eladalonf1841382017-06-12 01:16:46 -07004408TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004409 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004410 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004411 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004412}
4413
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004414// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004415TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004416 const int kUnusedPayloadType1 = 126;
4417 const int kUnusedPayloadType2 = 127;
4418 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4419 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4420
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004421 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004422 parameters.codecs.push_back(GetEngineCodec("VP8"));
4423 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004424 parameters.codecs.push_back(rtx_codec);
4425 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004426 << "RTX codec without associated payload should be rejected.";
4427
magjed509e4fe2016-11-18 01:34:11 -08004428 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004429 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004430 << "RTX codec with invalid associated payload type should be rejected.";
4431
magjed509e4fe2016-11-18 01:34:11 -08004432 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004433 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004434
magjed509e4fe2016-11-18 01:34:11 -08004435 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004436 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004437 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004438
Yves Gerey665174f2018-06-19 15:03:05 +02004439 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4440 << "RTX codec with another RTX as associated payload type should be "
4441 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004442}
4443
eladalonf1841382017-06-12 01:16:46 -07004444TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004445 const int kUnusedPayloadType1 = 126;
4446 const int kUnusedPayloadType2 = 127;
4447 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4448 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4449
4450 // SSRCs for RTX.
4451 cricket::StreamParams params =
4452 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4453 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4454 AddRecvStream(params);
4455
4456 // Original payload type for RTX.
4457 cricket::VideoRecvParameters parameters;
4458 parameters.codecs.push_back(GetEngineCodec("VP8"));
4459 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4460 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4461 parameters.codecs.push_back(rtx_codec);
4462 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4463 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4464 const webrtc::VideoReceiveStream::Config& config_before =
4465 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004466 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4467 const int* payload_type_before = FindKeyByValue(
4468 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4469 ASSERT_NE(payload_type_before, nullptr);
4470 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004471 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4472
4473 // Change payload type for RTX.
4474 parameters.codecs[1].id = kUnusedPayloadType2;
4475 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4476 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4477 const webrtc::VideoReceiveStream::Config& config_after =
4478 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004479 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4480 const int* payload_type_after = FindKeyByValue(
4481 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4482 ASSERT_NE(payload_type_after, nullptr);
4483 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004484 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4485}
4486
eladalonf1841382017-06-12 01:16:46 -07004487TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004488 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004489 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004490 parameters.codecs[0].id = 99;
4491 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004492}
4493
eladalonf1841382017-06-12 01:16:46 -07004494TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004495 cricket::VideoRecvParameters parameters;
4496 parameters.codecs = engine_.codecs();
4497 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004498
4499 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004500 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004501 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004502 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004503}
4504
eladalonf1841382017-06-12 01:16:46 -07004505TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004506 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004507 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004508 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004509 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004510}
4511
eladalonf1841382017-06-12 01:16:46 -07004512TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004513 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004514 parameters.codecs.push_back(GetEngineCodec("VP8"));
4515 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004516 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004517}
4518
eladalonf1841382017-06-12 01:16:46 -07004519TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004520 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004521 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4522 send_parameters.codecs.push_back(GetEngineCodec("red"));
4523 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004524 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004525
4526 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004527
magjed509e4fe2016-11-18 01:34:11 -08004528 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004529 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004530
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004531 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004532 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004533 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004534 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004535 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004536 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004537 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4538}
4539
eladalonf1841382017-06-12 01:16:46 -07004540TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004541 AddRecvStream(
4542 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004543 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004544 fake_call_->GetFlexfecReceiveStreams();
4545
4546 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004547 const FakeFlexfecReceiveStream* stream = streams.front();
4548 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4549 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4550 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4551 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004552
4553 cricket::VideoRecvParameters recv_parameters;
4554 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4555 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4556 EXPECT_TRUE(streams.empty())
4557 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004558}
4559
eladalonf1841382017-06-12 01:16:46 -07004560TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004561 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004562 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004563 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004564
4565 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004566 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4567 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4568 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004569 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4570 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004571 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004572 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004573 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004574 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004575
4576 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004577 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4578 send_parameters.codecs.push_back(GetEngineCodec("red"));
4579 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004580 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4581 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004582 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004583 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004584 << "ULPFEC should be enabled on the receive stream.";
4585}
4586
eladalonf1841382017-06-12 01:16:46 -07004587TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004588 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004589 AddRecvStream(
4590 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004591 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004592 fake_call_->GetFlexfecReceiveStreams();
4593
4594 cricket::VideoRecvParameters recv_parameters;
4595 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4596 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4597 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4598 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004599 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004600 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004601 stream_with_recv_params->GetConfig().payload_type);
4602 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004603 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004604 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004605 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004606 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004607
4608 cricket::VideoSendParameters send_parameters;
4609 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4610 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4611 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4612 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004613 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004614 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004615 stream_with_send_params->GetConfig().payload_type);
4616 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004617 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004618 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004619 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004620 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004621}
4622
eladalonf1841382017-06-12 01:16:46 -07004623TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004624 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004625 parameters.codecs.push_back(GetEngineCodec("VP8"));
4626 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004627 parameters.codecs[1].id = parameters.codecs[0].id;
4628 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004629}
4630
eladalonf1841382017-06-12 01:16:46 -07004631TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004632 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004633 cricket::VideoRecvParameters parameters;
4634 parameters.codecs.push_back(GetEngineCodec("VP8"));
4635 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4636 parameters.codecs[1].id = parameters.codecs[0].id;
4637 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4638}
4639
eladalonf1841382017-06-12 01:16:46 -07004640TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004641 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004642 parameters.codecs.push_back(GetEngineCodec("VP8"));
4643 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004644 parameters.codecs[1].id = parameters.codecs[0].id;
4645 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004646}
4647
eladalonf1841382017-06-12 01:16:46 -07004648TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004649 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004650 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004651 parameters.codecs.push_back(GetEngineCodec("VP8"));
4652 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004653 parameters.codecs[1].id += 1;
4654 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004655}
4656
deadbeef67cf2c12016-04-13 10:07:16 -07004657// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004658// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004659TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004660 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004661 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004662 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4663 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004664 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004665
4666 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4667 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4668
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004669 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004670 parameters2.codecs.push_back(GetEngineCodec("red"));
4671 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004672 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004673 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4674}
4675
eladalonf1841382017-06-12 01:16:46 -07004676TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004677 EXPECT_FALSE(AddSendStream()->IsSending());
4678}
4679
eladalonf1841382017-06-12 01:16:46 -07004680TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004681 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004682}
4683
eladalonf1841382017-06-12 01:16:46 -07004684TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004685 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004686 EXPECT_FALSE(stream->IsSending());
4687
4688 // false->true
4689 EXPECT_TRUE(channel_->SetSend(true));
4690 EXPECT_TRUE(stream->IsSending());
4691 // true->true
4692 EXPECT_TRUE(channel_->SetSend(true));
4693 EXPECT_TRUE(stream->IsSending());
4694 // true->false
4695 EXPECT_TRUE(channel_->SetSend(false));
4696 EXPECT_FALSE(stream->IsSending());
4697 // false->false
4698 EXPECT_TRUE(channel_->SetSend(false));
4699 EXPECT_FALSE(stream->IsSending());
4700
4701 EXPECT_TRUE(channel_->SetSend(true));
4702 FakeVideoSendStream* new_stream = AddSendStream();
4703 EXPECT_TRUE(new_stream->IsSending())
4704 << "Send stream created after SetSend(true) not sending initially.";
4705}
4706
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004707// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004708TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004709 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004710 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004711 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004712 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004713 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004714
Sebastian Jansson84848f22018-11-16 10:40:36 +01004715 channel.reset(
4716 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004717 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4718 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004719 channel->SetInterface(network_interface.get(),
4720 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004721 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004722 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004723
Tim Haloun648d28a2018-10-18 16:52:22 -07004724 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4725 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004726 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004727 channel.reset(
4728 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004729 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4730 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004731 channel->SetInterface(network_interface.get(),
4732 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004733 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4734
4735 // Create a send stream to configure
4736 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4737 parameters = channel->GetRtpSendParameters(kSsrc);
4738 ASSERT_FALSE(parameters.encodings.empty());
4739
4740 // Various priorities map to various dscp values.
4741 parameters.encodings[0].network_priority = 4.0;
4742 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004743 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004744 parameters.encodings[0].network_priority = 0.5;
4745 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4746 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4747
4748 // A bad priority does not change the dscp value.
4749 parameters.encodings[0].network_priority = 0.0;
4750 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4751 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004752
Tim Haloun6ca98362018-09-17 17:06:08 -07004753 // Packets should also self-identify their dscp in PacketOptions.
4754 const uint8_t kData[10] = {0};
4755 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4756 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004757 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004758
nisse51542be2016-02-12 02:27:06 -08004759 // Verify that setting the option to false resets the
4760 // DiffServCodePoint.
4761 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004762 channel.reset(
4763 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004764 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4765 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004766 channel->SetInterface(network_interface.get(),
4767 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004768 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004769}
4770
deadbeef13871492015-12-09 12:37:51 -08004771// This test verifies that the RTCP reduced size mode is properly applied to
4772// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004773TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004774 // Create stream, expecting that default mode is "compound".
4775 FakeVideoSendStream* stream1 = AddSendStream();
4776 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004777 webrtc::RtpParameters rtp_parameters =
4778 channel_->GetRtpSendParameters(last_ssrc_);
4779 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004780
4781 // Now enable reduced size mode.
4782 send_parameters_.rtcp.reduced_size = true;
4783 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4784 stream1 = fake_call_->GetVideoSendStreams()[0];
4785 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004786 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4787 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004788
4789 // Create a new stream and ensure it picks up the reduced size mode.
4790 FakeVideoSendStream* stream2 = AddSendStream();
4791 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4792}
4793
4794// This test verifies that the RTCP reduced size mode is properly applied to
4795// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004796TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004797 // Create stream, expecting that default mode is "compound".
4798 FakeVideoReceiveStream* stream1 = AddRecvStream();
4799 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4800
4801 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004802 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4803 // the reduced_size flag should come from that.
4804 send_parameters_.rtcp.reduced_size = true;
4805 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004806 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4807 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4808
4809 // Create a new stream and ensure it picks up the reduced size mode.
4810 FakeVideoReceiveStream* stream2 = AddRecvStream();
4811 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4812}
4813
eladalonf1841382017-06-12 01:16:46 -07004814TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004815 EXPECT_EQ(webrtc::kNetworkUp,
4816 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4817 EXPECT_EQ(webrtc::kNetworkUp,
4818 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004819
4820 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004821 EXPECT_EQ(webrtc::kNetworkDown,
4822 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4823 EXPECT_EQ(webrtc::kNetworkUp,
4824 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004825
4826 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004827 EXPECT_EQ(webrtc::kNetworkUp,
4828 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4829 EXPECT_EQ(webrtc::kNetworkUp,
4830 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004831}
4832
eladalonf1841382017-06-12 01:16:46 -07004833TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004834 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004835 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004836 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004837
4838 AddSendStream();
4839
4840 cricket::VideoMediaInfo info;
4841 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004842 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004843}
4844
eladalonf1841382017-06-12 01:16:46 -07004845TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004846 FakeVideoSendStream* stream = AddSendStream();
4847 webrtc::VideoSendStream::Stats stats;
4848 stats.encoder_implementation_name = "encoder_implementation_name";
4849 stream->SetStats(stats);
4850
4851 cricket::VideoMediaInfo info;
4852 ASSERT_TRUE(channel_->GetStats(&info));
4853 EXPECT_EQ(stats.encoder_implementation_name,
4854 info.senders[0].encoder_implementation_name);
4855}
4856
eladalonf1841382017-06-12 01:16:46 -07004857TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004858 FakeVideoSendStream* stream = AddSendStream();
4859 webrtc::VideoSendStream::Stats stats;
4860 stats.avg_encode_time_ms = 13;
4861 stats.encode_usage_percent = 42;
4862 stream->SetStats(stats);
4863
4864 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004865 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004866 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4867 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4868}
4869
eladalonf1841382017-06-12 01:16:46 -07004870TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004871 FakeVideoSendStream* stream = AddSendStream();
4872 webrtc::VideoSendStream::Stats stats;
4873 stats.frames_encoded = 13;
4874 stream->SetStats(stats);
4875
4876 cricket::VideoMediaInfo info;
4877 ASSERT_TRUE(channel_->GetStats(&info));
4878 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4879}
4880
eladalonf1841382017-06-12 01:16:46 -07004881TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004882 FakeVideoSendStream* stream = AddSendStream();
4883 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004884 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004885 stream->SetStats(stats);
4886
4887 cricket::VideoMediaInfo info;
4888 ASSERT_TRUE(channel_->GetStats(&info));
4889 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4890}
4891
eladalonf1841382017-06-12 01:16:46 -07004892TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004893 FakeVideoSendStream* stream = AddSendStream();
4894 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004895 stats.substreams[17].width = 123;
4896 stats.substreams[17].height = 40;
4897 stats.substreams[42].width = 80;
4898 stats.substreams[42].height = 31;
4899 stats.substreams[11].width = 20;
4900 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004901 stream->SetStats(stats);
4902
4903 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004904 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004905 ASSERT_EQ(1u, info.senders.size());
4906 EXPECT_EQ(123, info.senders[0].send_frame_width);
4907 EXPECT_EQ(90, info.senders[0].send_frame_height);
4908}
4909
eladalonf1841382017-06-12 01:16:46 -07004910TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004911 FakeVideoSendStream* stream = AddSendStream();
4912 webrtc::VideoSendStream::Stats stats;
4913 stats.number_of_cpu_adapt_changes = 2;
4914 stats.cpu_limited_resolution = true;
4915 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004916
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004917 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004918 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004919 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004920 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004921 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004922}
4923
eladalonf1841382017-06-12 01:16:46 -07004924TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004925 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004926 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004927 stats.number_of_cpu_adapt_changes = 2;
4928 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004929 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004930 stream->SetStats(stats);
4931
4932 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004933 EXPECT_TRUE(channel_->GetStats(&info));
4934 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004935 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4936 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004937 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004938 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004939}
4940
eladalonf1841382017-06-12 01:16:46 -07004941TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004942 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4943 FakeVideoSendStream* stream = AddSendStream();
4944 webrtc::VideoSendStream::Stats stats;
4945 stats.bw_limited_resolution = true;
4946 stream->SetStats(stats);
4947
4948 cricket::VideoMediaInfo info;
4949 EXPECT_TRUE(channel_->GetStats(&info));
4950 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004951 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004952 info.senders[0].adapt_reason);
4953}
4954
Yves Gerey665174f2018-06-19 15:03:05 +02004955TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004956 FakeVideoSendStream* stream = AddSendStream();
4957 webrtc::VideoSendStream::Stats stats;
4958 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4959 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4960 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4961
4962 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4963 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4964 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4965
4966 stream->SetStats(stats);
4967
4968 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004969 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004970 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4971 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4972 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4973}
4974
eladalonf1841382017-06-12 01:16:46 -07004975TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004976 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4977 FakeVideoReceiveStream* stream = AddRecvStream();
4978 webrtc::VideoReceiveStream::Stats stats;
4979 stats.rtcp_packet_type_counts.fir_packets = 2;
4980 stats.rtcp_packet_type_counts.nack_packets = 3;
4981 stats.rtcp_packet_type_counts.pli_packets = 4;
4982 stream->SetStats(stats);
4983
4984 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004985 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004986 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004987 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004988 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004989 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004990 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004991 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004992}
4993
eladalonf1841382017-06-12 01:16:46 -07004994TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004995 FakeVideoReceiveStream* stream = AddRecvStream();
4996 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004997 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004998 stats.decode_ms = 2;
4999 stats.max_decode_ms = 3;
5000 stats.current_delay_ms = 4;
5001 stats.target_delay_ms = 5;
5002 stats.jitter_buffer_ms = 6;
5003 stats.min_playout_delay_ms = 7;
5004 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005005 stats.width = 9;
5006 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005007 stats.frame_counts.key_frames = 11;
5008 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005009 stats.frames_rendered = 13;
5010 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005011 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005012 stream->SetStats(stats);
5013
5014 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005015 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005016 EXPECT_EQ(stats.decoder_implementation_name,
5017 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005018 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5019 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5020 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5021 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5022 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
5023 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5024 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005025 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5026 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005027 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5028 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005029 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005030 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005031 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005032 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005033}
5034
eladalonf1841382017-06-12 01:16:46 -07005035TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02005036 FakeVideoReceiveStream* stream = AddRecvStream();
5037 webrtc::VideoReceiveStream::Stats stats;
5038 stats.rtp_stats.transmitted.payload_bytes = 2;
5039 stats.rtp_stats.transmitted.header_bytes = 3;
5040 stats.rtp_stats.transmitted.padding_bytes = 4;
5041 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07005042 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005043 stats.rtcp_stats.fraction_lost = 7;
5044 stream->SetStats(stats);
5045
5046 cricket::VideoMediaInfo info;
5047 ASSERT_TRUE(channel_->GetStats(&info));
5048 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
5049 stats.rtp_stats.transmitted.header_bytes +
5050 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005051 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02005052 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005053 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07005054 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005055 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02005056 info.receivers[0].fraction_lost);
5057}
5058
eladalonf1841382017-06-12 01:16:46 -07005059TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005060 AddSendStream();
5061 AddSendStream();
5062 webrtc::Call::Stats stats;
5063 stats.rtt_ms = 123;
5064 fake_call_->SetStats(stats);
5065
5066 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005067 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005068 ASSERT_EQ(2u, info.senders.size());
5069 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5070 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5071}
5072
eladalonf1841382017-06-12 01:16:46 -07005073TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005074 FakeVideoSendStream* stream = AddSendStream();
5075 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005076 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005077 stats.media_bitrate_bps = 123;
5078 stats.substreams[17].total_bitrate_bps = 1;
5079 stats.substreams[17].retransmit_bitrate_bps = 2;
5080 stats.substreams[42].total_bitrate_bps = 3;
5081 stats.substreams[42].retransmit_bitrate_bps = 4;
5082 stream->SetStats(stats);
5083
5084 FakeVideoSendStream* stream2 = AddSendStream();
5085 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005086 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005087 stats2.media_bitrate_bps = 321;
5088 stats2.substreams[13].total_bitrate_bps = 5;
5089 stats2.substreams[13].retransmit_bitrate_bps = 6;
5090 stats2.substreams[21].total_bitrate_bps = 7;
5091 stats2.substreams[21].retransmit_bitrate_bps = 8;
5092 stream2->SetStats(stats2);
5093
5094 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005095 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005096 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005097 BandwidthEstimationInfo bwe_info;
5098 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005099 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5100 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5101 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5102 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005103 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005104 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005105 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005106 bwe_info.actual_enc_bitrate);
5107 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005108 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005109 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005110 << "Bandwidth stats should take all streams into account.";
5111}
5112
eladalonf1841382017-06-12 01:16:46 -07005113TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005114 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005115
Peter Boström0c4e06b2015-10-07 12:23:21 +02005116 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5117 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005118
5119 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5120 const size_t kDataLength = 12;
5121 uint8_t data[kDataLength];
5122 memset(data, 0, sizeof(data));
5123 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005124 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005125 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005126
5127 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5128 << "No default receive stream created.";
5129 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005130 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005131 << "Default receive stream should not have configured RTX";
5132
5133 EXPECT_TRUE(channel_->AddRecvStream(
5134 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5135 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005136 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005137 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005138 EXPECT_FALSE(
5139 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005140 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005141 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005142 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005143 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005144 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005145 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005146}
5147
eladalonf1841382017-06-12 01:16:46 -07005148TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005149 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005150
Peter Boström0c4e06b2015-10-07 12:23:21 +02005151 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5152 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005153
5154 StreamParams sp =
5155 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5156 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5157
5158 EXPECT_FALSE(channel_->AddSendStream(sp));
5159 EXPECT_FALSE(channel_->AddRecvStream(sp));
5160}
5161
eladalonf1841382017-06-12 01:16:46 -07005162TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005163 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005164
Peter Boström0c4e06b2015-10-07 12:23:21 +02005165 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5166 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005167
5168 StreamParams sp =
5169 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5170
5171 EXPECT_TRUE(channel_->AddSendStream(sp));
5172 EXPECT_TRUE(channel_->AddRecvStream(sp));
5173
5174 // The RTX SSRC is already used in previous streams, using it should fail.
5175 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5176 EXPECT_FALSE(channel_->AddSendStream(sp));
5177 EXPECT_FALSE(channel_->AddRecvStream(sp));
5178
5179 // After removing the original stream this should be fine to add (makes sure
5180 // that RTX ssrcs are not forever taken).
5181 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5182 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5183 EXPECT_TRUE(channel_->AddSendStream(sp));
5184 EXPECT_TRUE(channel_->AddRecvStream(sp));
5185}
5186
eladalonf1841382017-06-12 01:16:46 -07005187TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005188 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005189 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5190 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005191 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005192
Peter Boströmd6f4c252015-03-26 16:23:04 +01005193 StreamParams sp =
5194 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5195
5196 EXPECT_TRUE(channel_->AddSendStream(sp));
5197 EXPECT_TRUE(channel_->AddRecvStream(sp));
5198
5199 // One of the SSRCs is already used in previous streams, using it should fail.
5200 sp = cricket::CreateSimStreamParams("cname",
5201 MAKE_VECTOR(kOverlappingStreamSsrcs));
5202 EXPECT_FALSE(channel_->AddSendStream(sp));
5203 EXPECT_FALSE(channel_->AddRecvStream(sp));
5204
5205 // After removing the original stream this should be fine to add (makes sure
5206 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005207 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5208 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005209 EXPECT_TRUE(channel_->AddSendStream(sp));
5210 EXPECT_TRUE(channel_->AddRecvStream(sp));
5211}
5212
eladalonf1841382017-06-12 01:16:46 -07005213TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005214 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005215
5216 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5217 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5218
5219 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5220 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5221
5222 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5223
5224 static const uint32_t kReceiverSsrcs[] = {3};
5225 static const uint32_t kReceiverRtxSsrcs[] = {2};
5226
5227 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5228 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5229 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5230
5231 cricket::VideoMediaInfo info;
5232 ASSERT_TRUE(channel_->GetStats(&info));
5233
5234 ASSERT_EQ(1u, info.senders.size());
5235 ASSERT_EQ(1u, info.receivers.size());
5236
5237 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5238 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5239 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5240}
5241
eladalonf1841382017-06-12 01:16:46 -07005242TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005243 FakeVideoReceiveStream* stream = AddRecvStream();
5244 webrtc::VideoReceiveStream::Stats stats;
5245 cricket::VideoMediaInfo info;
5246
5247 // Report no codec name before receiving.
5248 stream->SetStats(stats);
5249 ASSERT_TRUE(channel_->GetStats(&info));
5250 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5251
5252 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005253 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005254 stream->SetStats(stats);
5255 ASSERT_TRUE(channel_->GetStats(&info));
5256 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5257
5258 // Report no codec name for unknown playload types.
5259 stats.current_payload_type = 3;
5260 stream->SetStats(stats);
5261 ASSERT_TRUE(channel_->GetStats(&info));
5262 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5263}
5264
Seth Hampson5897a6e2018-04-03 11:16:33 -07005265// Tests that when we add a stream without SSRCs, but contains a stream_id
5266// that it is stored and its stream id is later used when the first packet
5267// arrives to properly create a receive stream with a sync label.
5268TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5269 const char kSyncLabel[] = "sync_label";
5270 cricket::StreamParams unsignaled_stream;
5271 unsignaled_stream.set_stream_ids({kSyncLabel});
5272 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5273 // The stream shouldn't have been created at this point because it doesn't
5274 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005275 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005276
5277 // Create and deliver packet.
5278 const size_t kDataLength = 12;
5279 uint8_t data[kDataLength];
5280 memset(data, 0, sizeof(data));
5281 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5282 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005283 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005284
5285 // The stream should now be created with the appropriate sync label.
5286 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5287 EXPECT_EQ(kSyncLabel,
5288 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5289
5290 // Removing the unsignaled stream should clear the cache. This time when
5291 // a default video receive stream is created it won't have a sync_group.
5292 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5293 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5294 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5295
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005296 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005297 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5298 EXPECT_TRUE(
5299 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5300}
5301
Ruslan Burakov493a6502019-02-27 15:32:48 +01005302// Test BaseMinimumPlayoutDelayMs on receive streams.
5303TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5304 // Test that set won't work for non-existing receive streams.
5305 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5306 // Test that get won't work for non-existing receive streams.
5307 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5308
5309 EXPECT_TRUE(AddRecvStream());
5310 // Test that set works for the existing receive stream.
5311 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5312 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5313 EXPECT_TRUE(recv_stream);
5314 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5315 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5316 200);
5317}
5318
5319// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5320TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5321 absl::optional<int> delay_ms;
5322 const FakeVideoReceiveStream* recv_stream;
5323
5324 // Set default stream with SSRC 0
5325 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5326 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5327
5328 // Spawn an unsignaled stream by sending a packet, it should inherit
5329 // default delay 200.
5330 const size_t kDataLength = 12;
5331 uint8_t data[kDataLength];
5332 memset(data, 0, sizeof(data));
5333 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5334 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005335 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005336
5337 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5338 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5339 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5340 EXPECT_EQ(200, delay_ms.value_or(0));
5341
5342 // Check that now if we change delay for SSRC 0 it will change delay for the
5343 // default receiving stream as well.
5344 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5345 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5346 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5347 EXPECT_EQ(300, delay_ms.value_or(0));
5348 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5349 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5350}
5351
eladalonf1841382017-06-12 01:16:46 -07005352void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005353 uint8_t payload_type,
5354 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005355 // kRedRtxPayloadType must currently be unused.
5356 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5357
noahricd10a68e2015-07-10 11:27:55 -07005358 // Add a RED RTX codec.
5359 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005360 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005361 recv_parameters_.codecs.push_back(red_rtx_codec);
5362 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005363
5364 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5365 const size_t kDataLength = 12;
5366 uint8_t data[kDataLength];
5367 memset(data, 0, sizeof(data));
5368
5369 rtc::Set8(data, 1, payload_type);
5370 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005371 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005372 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005373
5374 if (expect_created_receive_stream) {
5375 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5376 << "Should have created a receive stream for payload type: "
5377 << payload_type;
5378 } else {
5379 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5380 << "Shouldn't have created a receive stream for payload type: "
5381 << payload_type;
5382 }
5383}
5384
Åsa Persson2c7149b2018-10-15 09:36:10 +02005385class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5386 public:
5387 WebRtcVideoChannelDiscardUnknownSsrcTest()
5388 : WebRtcVideoChannelTest(
5389 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5390};
5391
5392TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5393 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5394 false /* expect_created_receive_stream */);
5395}
5396
eladalonf1841382017-06-12 01:16:46 -07005397TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005398 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5399 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005400}
5401
eladalonf1841382017-06-12 01:16:46 -07005402TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005403 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5404 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005405}
5406
eladalonf1841382017-06-12 01:16:46 -07005407TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005408 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005409 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5410 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5411 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5412 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005413}
5414
eladalonf1841382017-06-12 01:16:46 -07005415TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005416 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5417 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005418}
5419
eladalonf1841382017-06-12 01:16:46 -07005420TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005421 FlexfecPacketDoesntCreateUnsignalledStream) {
5422 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5423 false /* expect_created_receive_stream */);
5424}
5425
eladalonf1841382017-06-12 01:16:46 -07005426TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005427 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5428 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005429}
5430
mzanaty8a855d62017-02-17 15:46:43 -08005431// Test that receiving any unsignalled SSRC works even if it changes.
5432// The first unsignalled SSRC received will create a default receive stream.
5433// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005434TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005435 // Allow receiving VP8, VP9, H264 (if enabled).
5436 cricket::VideoRecvParameters parameters;
5437 parameters.codecs.push_back(GetEngineCodec("VP8"));
5438 parameters.codecs.push_back(GetEngineCodec("VP9"));
5439
5440#if defined(WEBRTC_USE_H264)
5441 cricket::VideoCodec H264codec(126, "H264");
5442 parameters.codecs.push_back(H264codec);
5443#endif
5444
5445 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5446 // No receive streams yet.
5447 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5448 cricket::FakeVideoRenderer renderer;
5449 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5450
5451 // Receive VP8 packet on first SSRC.
5452 uint8_t data[kMinRtpPacketLen];
5453 cricket::RtpHeader rtpHeader;
5454 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5455 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005456 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005457 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5458 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005459 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005460 // VP8 packet should create default receive stream.
5461 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005462 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005463 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5464 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005465 webrtc::VideoFrame video_frame =
5466 webrtc::VideoFrame::Builder()
5467 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5468 .set_timestamp_rtp(100)
5469 .set_timestamp_us(0)
5470 .set_rotation(webrtc::kVideoRotation_0)
5471 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005472 recv_stream->InjectFrame(video_frame);
5473 EXPECT_EQ(1, renderer.num_rendered_frames());
5474
5475 // Receive VP9 packet on second SSRC.
5476 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005477 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005478 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5479 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005480 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005481 // VP9 packet should replace the default receive SSRC.
5482 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5483 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5484 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5485 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005486 webrtc::VideoFrame video_frame2 =
5487 webrtc::VideoFrame::Builder()
5488 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5489 .set_timestamp_rtp(200)
5490 .set_timestamp_us(0)
5491 .set_rotation(webrtc::kVideoRotation_0)
5492 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005493 recv_stream->InjectFrame(video_frame2);
5494 EXPECT_EQ(2, renderer.num_rendered_frames());
5495
5496#if defined(WEBRTC_USE_H264)
5497 // Receive H264 packet on third SSRC.
5498 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005499 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005500 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5501 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005502 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005503 // H264 packet should replace the default receive SSRC.
5504 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5505 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5506 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5507 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005508 webrtc::VideoFrame video_frame3 =
5509 webrtc::VideoFrame::Builder()
5510 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5511 .set_timestamp_rtp(300)
5512 .set_timestamp_us(0)
5513 .set_rotation(webrtc::kVideoRotation_0)
5514 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005515 recv_stream->InjectFrame(video_frame3);
5516 EXPECT_EQ(3, renderer.num_rendered_frames());
5517#endif
5518}
5519
brandtr0dc57ea2017-05-29 23:33:31 -07005520// This test verifies that when a new default stream is created for a new
5521// unsignaled SSRC, the new stream does not overwrite any old stream that had
5522// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005523TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005524 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5525 cricket::VideoRecvParameters parameters;
5526 parameters.codecs.push_back(GetEngineCodec("VP8"));
5527 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5528
5529 // No streams signaled and no packets received, so we should not have any
5530 // stream objects created yet.
5531 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5532
5533 // Receive packet on an unsignaled SSRC.
5534 uint8_t data[kMinRtpPacketLen];
5535 cricket::RtpHeader rtp_header;
5536 rtp_header.payload_type = GetEngineCodec("VP8").id;
5537 rtp_header.seq_num = rtp_header.timestamp = 0;
5538 rtp_header.ssrc = kSsrcs3[0];
5539 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5540 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005541 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005542 // Default receive stream should be created.
5543 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5544 FakeVideoReceiveStream* recv_stream0 =
5545 fake_call_->GetVideoReceiveStreams()[0];
5546 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5547
5548 // Signal the SSRC.
5549 EXPECT_TRUE(
5550 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5551 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5552 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5553 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5554
5555 // Receive packet on a different unsignaled SSRC.
5556 rtp_header.ssrc = kSsrcs3[1];
5557 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5558 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005559 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005560 // New default receive stream should be created, but old stream should remain.
5561 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5562 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5563 FakeVideoReceiveStream* recv_stream1 =
5564 fake_call_->GetVideoReceiveStreams()[1];
5565 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5566}
5567
Seth Hampson7c682e02018-05-04 16:28:15 -07005568TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005569 AddSendStream();
5570
Niels Möller805a27e2019-01-21 12:21:27 +01005571 webrtc::test::FrameForwarder frame_forwarder;
5572 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005573 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005574 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005575
perkjfa10b552016-10-02 23:45:26 -07005576 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005577 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005578
5579 // TODO(skvlad): Resolve the inconsistency between the interpretation
5580 // of the global bitrate limit for audio and video:
5581 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5582 // max_bandwidth_bps = -1 - remove the bandwidth limit
5583 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005584 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005585
perkjfa10b552016-10-02 23:45:26 -07005586 SetAndExpectMaxBitrate(1000, 0, 1000);
5587 SetAndExpectMaxBitrate(1000, 800, 800);
5588 SetAndExpectMaxBitrate(600, 800, 600);
5589 SetAndExpectMaxBitrate(0, 800, 800);
5590 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005591
Niels Möllerff40b142018-04-09 08:49:14 +02005592 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005593}
5594
eladalonf1841382017-06-12 01:16:46 -07005595TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005596 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005597 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005598 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005599
5600 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005601 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005602 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005603}
5604
eladalonf1841382017-06-12 01:16:46 -07005605TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005606 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005607 FakeVideoSendStream* stream = AddSendStream();
5608
Seth Hampson7c682e02018-05-04 16:28:15 -07005609 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5610 EXPECT_EQ(1UL, parameters.encodings.size());
5611 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5612 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5613
5614 // Note that this is testing the behavior of the FakeVideoSendStream, which
5615 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5616 // we are just testing the behavior of
5617 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005618 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5619 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005620
5621 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5622 // by this amount.
5623 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5624 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5625 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5626 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5627
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005628 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5629 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5630 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5631}
5632
5633TEST_F(WebRtcVideoChannelTest,
5634 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5635 FakeVideoSendStream* stream = AddSendStream();
5636
5637 // Note that this is testing the behavior of the FakeVideoSendStream, which
5638 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5639 // we are just testing the behavior of
5640 // EncoderStreamFactory::CreateEncoderStreams.
5641 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5642 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5643
5644 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5645 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5646 EXPECT_EQ(1UL, parameters.encodings.size());
5647 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5648 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5649
5650 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5651 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5652 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5653}
5654
5655TEST_F(WebRtcVideoChannelTest,
5656 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5657 send_parameters_.max_bandwidth_bps = 99999;
5658 FakeVideoSendStream* stream = AddSendStream();
5659 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5660 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5661 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5662 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5663 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5664 stream->GetVideoStreams()[0].max_bitrate_bps);
5665
5666 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5667 // adjusted down.
5668 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5669 EXPECT_EQ(1UL, parameters.encodings.size());
5670 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5671 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5672 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5673 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5674 stream->GetVideoStreams()[0].min_bitrate_bps);
5675 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5676 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005677}
5678
Åsa Persson8c1bf952018-09-13 10:42:19 +02005679TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5680 FakeVideoSendStream* stream = AddSendStream();
5681
5682 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5683 EXPECT_EQ(1UL, parameters.encodings.size());
5684 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5685 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5686
5687 // Note that this is testing the behavior of the FakeVideoSendStream, which
5688 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5689 // we are just testing the behavior of
5690 // EncoderStreamFactory::CreateEncoderStreams.
5691 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5692 EXPECT_EQ(kDefaultVideoMaxFramerate,
5693 stream->GetVideoStreams()[0].max_framerate);
5694
5695 // Set max framerate and check that VideoStream.max_framerate is set.
5696 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5697 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5698 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5699 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5700
5701 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5702 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5703}
5704
Åsa Persson23eba222018-10-02 14:47:06 +02005705TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5706 FakeVideoSendStream* stream = AddSendStream();
5707
5708 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5709 EXPECT_EQ(1UL, parameters.encodings.size());
5710 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5711 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5712
5713 // Note that this is testing the behavior of the FakeVideoSendStream, which
5714 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5715 // we are just testing the behavior of
5716 // EncoderStreamFactory::CreateEncoderStreams.
5717 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5718 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5719
5720 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5721 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5722 parameters.encodings[0].num_temporal_layers = 2;
5723 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5724
5725 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5726 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5727}
5728
Seth Hampson7c682e02018-05-04 16:28:15 -07005729TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005730 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005731 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005732 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005733 // Two or more encodings should result in failure.
5734 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005735 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005736 // Zero encodings should also fail.
5737 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005738 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005739}
5740
Zach Stein3ca452b2018-01-18 10:01:24 -08005741TEST_F(WebRtcVideoChannelTest,
5742 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5743 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5744 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5745 AddSendStream(sp);
5746
5747 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5748
5749 // Additional encodings should result in failure.
5750 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005751 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005752 // Zero encodings should also fail.
5753 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005754 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005755}
5756
deadbeeffb2aced2017-01-06 23:05:37 -08005757// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005758TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005759 AddSendStream();
5760 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005761 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005762 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005763}
5764
Seth Hampson24722b32017-12-22 09:36:42 -08005765// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5766// a value <= 0, setting the parameters returns false.
5767TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5768 AddSendStream();
5769 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5770 EXPECT_EQ(1UL, parameters.encodings.size());
5771 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5772 parameters.encodings[0].bitrate_priority);
5773
5774 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005775 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005776 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005777 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005778}
5779
5780// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5781// properly on the VideoChannel and propogates down to the video encoder.
5782TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5783 AddSendStream();
5784 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5785 EXPECT_EQ(1UL, parameters.encodings.size());
5786 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5787 parameters.encodings[0].bitrate_priority);
5788
5789 // Change the value and set it on the VideoChannel.
5790 double new_bitrate_priority = 2.0;
5791 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005792 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005793
5794 // Verify that the encoding parameters bitrate_priority is set for the
5795 // VideoChannel.
5796 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5797 EXPECT_EQ(1UL, parameters.encodings.size());
5798 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5799
5800 // Verify that the new value propagated down to the encoder.
5801 std::vector<FakeVideoSendStream*> video_send_streams =
5802 fake_call_->GetVideoSendStreams();
5803 EXPECT_EQ(1UL, video_send_streams.size());
5804 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5805 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5806 // appropriately.
5807 EXPECT_EQ(new_bitrate_priority,
5808 video_send_stream->GetEncoderConfig().bitrate_priority);
5809 // Check that the vector of VideoStreams also was propagated correctly. Note
5810 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5811 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005812 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005813 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5814}
5815
5816// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5817// VideoChannel and the value propogates to the video encoder with all simulcast
5818// streams.
5819TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5820 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005821 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005822 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5823 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5824 AddSendStream(stream_params);
5825 uint32_t primary_ssrc = stream_params.first_ssrc();
5826
Niels Möller805a27e2019-01-21 12:21:27 +01005827 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005828 // frame. This creates multiple VideoStreams for all simulcast layers when
5829 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005830 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005831 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005832 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005833 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005834 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5835 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5836 rtc::kNumMicrosecsPerSec / 30));
5837
Seth Hampson24722b32017-12-22 09:36:42 -08005838 // Get and set the rtp encoding parameters.
5839 webrtc::RtpParameters parameters =
5840 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005841 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005842 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5843 parameters.encodings[0].bitrate_priority);
5844 // Change the value and set it on the VideoChannel.
5845 double new_bitrate_priority = 2.0;
5846 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005847 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005848
5849 // Verify that the encoding parameters priority is set on the VideoChannel.
5850 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005851 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005852 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5853
5854 // Verify that the new value propagated down to the encoder.
5855 std::vector<FakeVideoSendStream*> video_send_streams =
5856 fake_call_->GetVideoSendStreams();
5857 EXPECT_EQ(1UL, video_send_streams.size());
5858 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5859 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5860 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005861 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005862 video_send_stream->GetEncoderConfig().number_of_streams);
5863 EXPECT_EQ(new_bitrate_priority,
5864 video_send_stream->GetEncoderConfig().bitrate_priority);
5865 // Check that the vector of VideoStreams also propagated correctly. The
5866 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5867 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005868 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005869 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005870 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5871 // Since we are only setting bitrate priority per-sender, the other
5872 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005873 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005874 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005875 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005876 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005877 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005878}
5879
Tim Haloun648d28a2018-10-18 16:52:22 -07005880// RTCRtpEncodingParameters.network_priority must be one of a few values
5881// derived from the default priority, corresponding to very-low, low, medium,
5882// or high.
5883TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5884 AddSendStream();
5885 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5886 EXPECT_EQ(1UL, parameters.encodings.size());
5887 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5888 parameters.encodings[0].network_priority);
5889
5890 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5891 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5892 for (auto it : good_values) {
5893 parameters.encodings[0].network_priority = it;
5894 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5895 }
5896 for (auto it : bad_values) {
5897 parameters.encodings[0].network_priority = it;
5898 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5899 }
5900}
5901
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005902TEST_F(WebRtcVideoChannelTest,
5903 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005904 VideoSendParameters parameters;
5905 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005906 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5907 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5908
5909 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005910 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005911
5912 VideoOptions options;
5913 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5914 channel_->SetSend(true);
5915
5916 // Try layers in natural order (smallest to largest).
5917 {
5918 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5919 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5920 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5921 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5922 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5923 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5924 ASSERT_TRUE(result.ok());
5925
5926 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5927
5928 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5929 ASSERT_EQ(3u, video_streams.size());
5930 EXPECT_EQ(320u, video_streams[0].width);
5931 EXPECT_EQ(180u, video_streams[0].height);
5932 EXPECT_EQ(640u, video_streams[1].width);
5933 EXPECT_EQ(360u, video_streams[1].height);
5934 EXPECT_EQ(1280u, video_streams[2].width);
5935 EXPECT_EQ(720u, video_streams[2].height);
5936 }
5937
5938 // Try layers in reverse natural order (largest to smallest).
5939 {
5940 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5941 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5942 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5943 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5944 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5945 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5946 ASSERT_TRUE(result.ok());
5947
5948 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5949
5950 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5951 ASSERT_EQ(3u, video_streams.size());
5952 EXPECT_EQ(1280u, video_streams[0].width);
5953 EXPECT_EQ(720u, video_streams[0].height);
5954 EXPECT_EQ(640u, video_streams[1].width);
5955 EXPECT_EQ(360u, video_streams[1].height);
5956 EXPECT_EQ(320u, video_streams[2].width);
5957 EXPECT_EQ(180u, video_streams[2].height);
5958 }
5959
5960 // Try layers in mixed order.
5961 {
5962 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5963 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5964 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
5965 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5966 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5967 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5968 ASSERT_TRUE(result.ok());
5969
5970 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5971
5972 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5973 ASSERT_EQ(3u, video_streams.size());
5974 EXPECT_EQ(128u, video_streams[0].width);
5975 EXPECT_EQ(72u, video_streams[0].height);
5976 EXPECT_EQ(640u, video_streams[1].width);
5977 EXPECT_EQ(360u, video_streams[1].height);
5978 EXPECT_EQ(320u, video_streams[2].width);
5979 EXPECT_EQ(180u, video_streams[2].height);
5980 }
5981
5982 // Try with a missing scale setting, defaults to 1.0 if any other is set.
5983 {
5984 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5985 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5986 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5987 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
5988 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5989 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5990 ASSERT_TRUE(result.ok());
5991
5992 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5993
5994 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5995 ASSERT_EQ(3u, video_streams.size());
5996 EXPECT_EQ(1280u, video_streams[0].width);
5997 EXPECT_EQ(720u, video_streams[0].height);
5998 EXPECT_EQ(1280u, video_streams[1].width);
5999 EXPECT_EQ(720u, video_streams[1].height);
6000 EXPECT_EQ(320u, video_streams[2].width);
6001 EXPECT_EQ(180u, video_streams[2].height);
6002 }
6003
6004 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6005}
6006
6007TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006008 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6009 // Ensure that the top layer has width and height divisible by 2^3,
6010 // so that the bottom layer has width and height divisible by 2.
6011 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6012 // the number of simulcast layers set by the app.
6013 webrtc::test::ScopedFieldTrials field_trial(
6014 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6015
6016 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6017 VideoSendParameters parameters;
6018 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6019 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6020 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6021 webrtc::test::FrameForwarder frame_forwarder;
6022 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6023 &frame_forwarder));
6024 channel_->SetSend(true);
6025
6026 // Set |scale_resolution_down_by|'s.
6027 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6028 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6029 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6030 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6031 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6032 const auto result =
6033 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6034 ASSERT_TRUE(result.ok());
6035
6036 // Use a capture resolution whose width and height are not divisible by 2^3.
6037 // (See field trial set at the top of the test.)
6038 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6039 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6040
6041 // Ensure the scaling is correct.
6042 const auto video_streams = stream->GetVideoStreams();
6043 ASSERT_EQ(video_streams.size(), 3u);
6044 // Ensure that we round the capture resolution down for the top layer...
6045 EXPECT_EQ(video_streams[0].width, 2000u);
6046 EXPECT_EQ(video_streams[0].height, 1200u);
6047 EXPECT_EQ(video_streams[1].width, 1000u);
6048 EXPECT_EQ(video_streams[1].height, 600u);
6049 // ...and that the bottom layer has a width/height divisible by 2.
6050 EXPECT_EQ(video_streams[2].width, 500u);
6051 EXPECT_EQ(video_streams[2].height, 300u);
6052
6053 // Tear down.
6054 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6055}
6056
6057TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006058 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006059 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6060 VideoSendParameters parameters;
6061 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006062 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6063 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6064
6065 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006066 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006067
6068 VideoOptions options;
6069 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6070 channel_->SetSend(true);
6071
6072 // Try layers in natural order (smallest to largest).
6073 {
6074 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6075 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6076 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6077 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6078 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6079 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6080 ASSERT_TRUE(result.ok());
6081
6082 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6083
6084 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6085 ASSERT_EQ(3u, video_streams.size());
6086 EXPECT_EQ(320u, video_streams[0].width);
6087 EXPECT_EQ(180u, video_streams[0].height);
6088 EXPECT_EQ(640u, video_streams[1].width);
6089 EXPECT_EQ(360u, video_streams[1].height);
6090 EXPECT_EQ(1280u, video_streams[2].width);
6091 EXPECT_EQ(720u, video_streams[2].height);
6092 }
6093
6094 // Try layers in reverse natural order (largest to smallest).
6095 {
6096 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6097 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6098 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6099 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6100 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6101 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6102 ASSERT_TRUE(result.ok());
6103
6104 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6105
6106 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6107 ASSERT_EQ(3u, video_streams.size());
6108 EXPECT_EQ(1280u, video_streams[0].width);
6109 EXPECT_EQ(720u, video_streams[0].height);
6110 EXPECT_EQ(640u, video_streams[1].width);
6111 EXPECT_EQ(360u, video_streams[1].height);
6112 EXPECT_EQ(320u, video_streams[2].width);
6113 EXPECT_EQ(180u, video_streams[2].height);
6114 }
6115
6116 // Try layers in mixed order.
6117 {
6118 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6119 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6120 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6121 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6122 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6123 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6124 ASSERT_TRUE(result.ok());
6125
6126 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6127
6128 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6129 ASSERT_EQ(3u, video_streams.size());
6130 EXPECT_EQ(128u, video_streams[0].width);
6131 EXPECT_EQ(72u, video_streams[0].height);
6132 EXPECT_EQ(640u, video_streams[1].width);
6133 EXPECT_EQ(360u, video_streams[1].height);
6134 EXPECT_EQ(320u, video_streams[2].width);
6135 EXPECT_EQ(180u, video_streams[2].height);
6136 }
6137
6138 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6139 {
6140 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6141 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6142 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6143 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6144 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6145 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6146 ASSERT_TRUE(result.ok());
6147
6148 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6149
6150 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6151 ASSERT_EQ(3u, video_streams.size());
6152 EXPECT_EQ(1280u, video_streams[0].width);
6153 EXPECT_EQ(720u, video_streams[0].height);
6154 EXPECT_EQ(1280u, video_streams[1].width);
6155 EXPECT_EQ(720u, video_streams[1].height);
6156 EXPECT_EQ(320u, video_streams[2].width);
6157 EXPECT_EQ(180u, video_streams[2].height);
6158 }
6159 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6160}
6161
Rasmus Brandt9387b522019-02-05 14:23:26 +01006162TEST_F(WebRtcVideoChannelTest,
6163 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6164 // Ensure that the top layer has width and height divisible by 2^3,
6165 // so that the bottom layer has width and height divisible by 2.
6166 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6167 // the number of simulcast layers set by the app.
6168 webrtc::test::ScopedFieldTrials field_trial(
6169 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6170
6171 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6172 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6173 VideoSendParameters parameters;
6174 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6175 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6176 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6177 webrtc::test::FrameForwarder frame_forwarder;
6178 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6179 &frame_forwarder));
6180 channel_->SetSend(true);
6181
6182 // Set |scale_resolution_down_by|'s.
6183 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6184 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6185 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6186 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6187 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6188 const auto result =
6189 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6190 ASSERT_TRUE(result.ok());
6191
6192 // Use a capture resolution whose width and height are not divisible by 2^3.
6193 // (See field trial set at the top of the test.)
6194 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6195 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6196
6197 // Ensure the scaling is correct.
6198 const auto video_streams = stream->GetVideoStreams();
6199 ASSERT_EQ(video_streams.size(), 3u);
6200 // Ensure that we round the capture resolution down for the top layer...
6201 EXPECT_EQ(video_streams[0].width, 2000u);
6202 EXPECT_EQ(video_streams[0].height, 1200u);
6203 EXPECT_EQ(video_streams[1].width, 1000u);
6204 EXPECT_EQ(video_streams[1].height, 600u);
6205 // ...and that the bottom layer has a width/height divisible by 2.
6206 EXPECT_EQ(video_streams[2].width, 500u);
6207 EXPECT_EQ(video_streams[2].height, 300u);
6208
6209 // Tear down.
6210 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6211}
6212
Åsa Persson8c1bf952018-09-13 10:42:19 +02006213TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6214 const size_t kNumSimulcastStreams = 3;
6215 SetUpSimulcast(true, false);
6216
6217 // Get and set the rtp encoding parameters.
6218 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6219 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6220 for (const auto& encoding : parameters.encodings) {
6221 EXPECT_FALSE(encoding.max_framerate);
6222 }
6223
6224 // Change the value and set it on the VideoChannel.
6225 parameters.encodings[0].max_framerate = 10;
6226 parameters.encodings[1].max_framerate = 20;
6227 parameters.encodings[2].max_framerate = 25;
6228 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6229
6230 // Verify that the bitrates are set on the VideoChannel.
6231 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6232 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6233 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6234 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6235 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6236}
6237
Åsa Persson23eba222018-10-02 14:47:06 +02006238TEST_F(WebRtcVideoChannelTest,
6239 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6240 const size_t kNumSimulcastStreams = 3;
6241 SetUpSimulcast(true, false);
6242
6243 // Get and set the rtp encoding parameters.
6244 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6245 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6246
6247 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6248 parameters.encodings[0].num_temporal_layers = 0;
6249 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6250 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6251 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6252 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6253 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6254}
6255
6256TEST_F(WebRtcVideoChannelTest,
6257 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6258 const size_t kNumSimulcastStreams = 3;
6259 SetUpSimulcast(true, false);
6260
6261 // Get and set the rtp encoding parameters.
6262 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6263 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6264
6265 // No/all layers should be set.
6266 parameters.encodings[0].num_temporal_layers = 1;
6267 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6268 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6269
6270 // Different values not supported.
6271 parameters.encodings[0].num_temporal_layers = 1;
6272 parameters.encodings[1].num_temporal_layers = 2;
6273 parameters.encodings[2].num_temporal_layers = 2;
6274 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6275 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6276}
6277
6278TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6279 const size_t kNumSimulcastStreams = 3;
6280 SetUpSimulcast(true, false);
6281
6282 // Get and set the rtp encoding parameters.
6283 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6284 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6285 for (const auto& encoding : parameters.encodings)
6286 EXPECT_FALSE(encoding.num_temporal_layers);
6287
6288 // Change the value and set it on the VideoChannel.
6289 parameters.encodings[0].num_temporal_layers = 3;
6290 parameters.encodings[1].num_temporal_layers = 3;
6291 parameters.encodings[2].num_temporal_layers = 3;
6292 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6293
6294 // Verify that the number of temporal layers are set on the VideoChannel.
6295 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6296 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6297 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6298 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6299 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6300}
6301
6302TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6303 const size_t kNumSimulcastStreams = 3;
6304 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6305
6306 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006307 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006308 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006309 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006310 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006311 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006312
6313 // Get and set the rtp encoding parameters.
6314 // Change the value and set it on the VideoChannel.
6315 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6316 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6317 parameters.encodings[0].num_temporal_layers = 2;
6318 parameters.encodings[1].num_temporal_layers = 2;
6319 parameters.encodings[2].num_temporal_layers = 2;
6320 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6321
6322 // Verify that the new value is propagated down to the encoder.
6323 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6324 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6325 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6326 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6327 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6328 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6329 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6330 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6331
6332 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6333 // VideoStreams are created appropriately for the simulcast case.
6334 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6335 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6336 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6337 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6338
6339 // No parameter changed, encoder should not be reconfigured.
6340 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6341 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6342
6343 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6344}
6345
6346TEST_F(WebRtcVideoChannelTest,
6347 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6348 const size_t kDefaultNumTemporalLayers = 3;
6349 const size_t kNumSimulcastStreams = 3;
6350 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6351
6352 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006353 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006354 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006355 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006356 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006357 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006358
6359 // Change rtp encoding parameters, num_temporal_layers not changed.
6360 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6361 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6362 parameters.encodings[0].min_bitrate_bps = 33000;
6363 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6364
6365 // Verify that no value is propagated down to the encoder.
6366 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6367 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6368 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6369 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6370 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6371 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6372
6373 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6374 // VideoStreams are created appropriately for the simulcast case.
6375 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6376 EXPECT_EQ(kDefaultNumTemporalLayers,
6377 stream->GetVideoStreams()[0].num_temporal_layers);
6378 EXPECT_EQ(kDefaultNumTemporalLayers,
6379 stream->GetVideoStreams()[1].num_temporal_layers);
6380 EXPECT_EQ(kDefaultNumTemporalLayers,
6381 stream->GetVideoStreams()[2].num_temporal_layers);
6382
6383 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6384}
6385
Åsa Persson8c1bf952018-09-13 10:42:19 +02006386TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6387 const size_t kNumSimulcastStreams = 3;
6388 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6389
6390 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006391 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006392 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006393 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006394 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006395 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006396
6397 // Get and set the rtp encoding parameters.
6398 // Change the value and set it on the VideoChannel.
6399 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6400 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6401 parameters.encodings[0].max_framerate = 15;
6402 parameters.encodings[1].max_framerate = 25;
6403 parameters.encodings[2].max_framerate = 20;
6404 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6405
6406 // Verify that the new value propagated down to the encoder.
6407 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6408 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6409 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6410 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6411 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6412 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6413 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6414 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6415
6416 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6417 // VideoStreams are created appropriately for the simulcast case.
6418 // Currently the maximum |max_framerate| is used.
6419 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6420 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6421 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6422 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6423
6424 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6425}
6426
6427TEST_F(WebRtcVideoChannelTest,
6428 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6429 const size_t kNumSimulcastStreams = 3;
6430 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6431 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6432
6433 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006434 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006435 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006436 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006437 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006438 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006439
6440 // Get and set the rtp encoding parameters.
6441 // Change the value and set it on the VideoChannel.
6442 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6443 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6444 parameters.encodings[0].max_framerate = 15;
6445 parameters.encodings[2].max_framerate = 20;
6446 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6447
6448 // Verify that the new value propagated down to the encoder.
6449 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6450 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6451 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6452 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6453 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6454 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6455 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6456
6457 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6458 // VideoStreams are created appropriately for the simulcast case.
6459 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6460 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6461 EXPECT_EQ(kDefaultVideoMaxFramerate,
6462 stream->GetVideoStreams()[0].max_framerate);
6463 EXPECT_EQ(kDefaultVideoMaxFramerate,
6464 stream->GetVideoStreams()[1].max_framerate);
6465 EXPECT_EQ(kDefaultVideoMaxFramerate,
6466 stream->GetVideoStreams()[2].max_framerate);
6467
6468 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6469}
6470
Åsa Persson55659812018-06-18 17:51:32 +02006471TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6472 const size_t kNumSimulcastStreams = 3;
6473 SetUpSimulcast(true, false);
6474
6475 // Get and set the rtp encoding parameters.
6476 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6477 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6478 for (const auto& encoding : parameters.encodings) {
6479 EXPECT_FALSE(encoding.min_bitrate_bps);
6480 EXPECT_FALSE(encoding.max_bitrate_bps);
6481 }
6482
6483 // Change the value and set it on the VideoChannel.
6484 parameters.encodings[0].min_bitrate_bps = 100000;
6485 parameters.encodings[0].max_bitrate_bps = 200000;
6486 parameters.encodings[1].min_bitrate_bps = 300000;
6487 parameters.encodings[1].max_bitrate_bps = 400000;
6488 parameters.encodings[2].min_bitrate_bps = 500000;
6489 parameters.encodings[2].max_bitrate_bps = 600000;
6490 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6491
6492 // Verify that the bitrates are set on the VideoChannel.
6493 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6494 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6495 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6496 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6497 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6498 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6499 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6500 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6501}
6502
6503TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6504 const size_t kNumSimulcastStreams = 3;
6505 SetUpSimulcast(true, false);
6506
6507 // Get and set the rtp encoding parameters.
6508 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6509 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6510
6511 // Max bitrate lower than min bitrate should fail.
6512 parameters.encodings[2].min_bitrate_bps = 100000;
6513 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6514 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6515 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6516}
6517
6518// Test that min and max bitrate values set via RtpParameters are correctly
6519// propagated to the underlying encoder, and that the target is set to 3/4 of
6520// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6521// that are used if no min/max are specified).
6522TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6523 const size_t kNumSimulcastStreams = 3;
6524 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6525
6526 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006527 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006528 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006529 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006530 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006531 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006532
6533 // Get and set the rtp encoding parameters.
6534 // Change the value and set it on the VideoChannel.
6535 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6536 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6537 parameters.encodings[0].min_bitrate_bps = 100000;
6538 parameters.encodings[0].max_bitrate_bps = 200000;
6539 parameters.encodings[1].min_bitrate_bps = 300000;
6540 parameters.encodings[1].max_bitrate_bps = 400000;
6541 parameters.encodings[2].min_bitrate_bps = 500000;
6542 parameters.encodings[2].max_bitrate_bps = 600000;
6543 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6544
6545 // Verify that the new value propagated down to the encoder.
6546 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6547 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6548 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6549 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6550 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6551 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6552 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6553 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6554 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6555 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6556 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6557
6558 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6559 // VideoStreams are created appropriately for the simulcast case.
6560 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6561 // Target bitrate: 200000 * 3 / 4 = 150000.
6562 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6563 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6564 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6565 // Target bitrate: 400000 * 3 / 4 = 300000.
6566 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6567 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6568 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6569 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6570 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6571 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6572 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6573
6574 // No parameter changed, encoder should not be reconfigured.
6575 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6576 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6577
6578 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6579}
6580
6581// Test to only specify the min or max bitrate value for a layer via
6582// RtpParameters. The unspecified min/max and target value should be set to the
6583// simulcast default that is used if no min/max are specified.
6584TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6585 const size_t kNumSimulcastStreams = 3;
6586 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6587 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6588
6589 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006590 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006591 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006592 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006593 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006594 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006595
6596 // Get and set the rtp encoding parameters.
6597 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6598 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6599
6600 // Change the value and set it on the VideoChannel.
6601 // Layer 0: only configure min bitrate.
6602 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6603 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6604 // Layer 1: only configure max bitrate.
6605 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6606 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6607 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6608
6609 // Verify that the new value propagated down to the encoder.
6610 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6611 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6612 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6613 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6614 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6615 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6616 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6617 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6618 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6619 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6620
6621 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6622 // VideoStreams are created appropriately for the simulcast case.
6623 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6624 // Layer 0: min configured bitrate should overwrite min default.
6625 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6626 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6627 stream->GetVideoStreams()[0].target_bitrate_bps);
6628 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6629 stream->GetVideoStreams()[0].max_bitrate_bps);
6630 // Layer 1: max configured bitrate should overwrite max default.
6631 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6632 stream->GetVideoStreams()[1].min_bitrate_bps);
6633 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6634 stream->GetVideoStreams()[1].target_bitrate_bps);
6635 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6636 // Layer 2: min and max bitrate not configured, default expected.
6637 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6638 stream->GetVideoStreams()[2].min_bitrate_bps);
6639 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6640 stream->GetVideoStreams()[2].target_bitrate_bps);
6641 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6642 stream->GetVideoStreams()[2].max_bitrate_bps);
6643
6644 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6645}
6646
6647// Test that specifying the min (or max) bitrate value for a layer via
6648// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6649// unspecified values accordingly.
6650TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6651 const size_t kNumSimulcastStreams = 3;
6652 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6653 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6654
6655 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006656 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006657 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006658 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006659 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006660 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006661
6662 // Get and set the rtp encoding parameters.
6663 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6664 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6665
6666 // Change the value and set it on the VideoChannel.
6667 // For layer 0, set the min bitrate above the default max.
6668 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6669 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6670 // For layer 1, set the max bitrate below the default min.
6671 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6672 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6673 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6674
6675 // Verify that the new value propagated down to the encoder.
6676 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6677 // VideoStreams are created appropriately for the simulcast case.
6678 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6679 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6680 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6681 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6682 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6683 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6684 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6685 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6686 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6687 // Layer 2: min and max bitrate not configured, default expected.
6688 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6689 stream->GetVideoStreams()[2].min_bitrate_bps);
6690 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6691 stream->GetVideoStreams()[2].target_bitrate_bps);
6692 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6693 stream->GetVideoStreams()[2].max_bitrate_bps);
6694
6695 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6696}
6697
6698TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6699 const size_t kNumSimulcastStreams = 3;
6700 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6701 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6702
6703 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006704 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006705 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006706 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006707 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006708 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006709
6710 // Set max bitrate for all but the highest layer.
6711 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6712 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6713 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6714 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6715 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6716
6717 // Set max bandwidth equal to total max bitrate.
6718 send_parameters_.max_bandwidth_bps =
6719 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6720 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6721 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6722
6723 // No bitrate above the total max to give to the highest layer.
6724 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6725 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6726 stream->GetVideoStreams()[2].max_bitrate_bps);
6727
6728 // Set max bandwidth above the total max bitrate.
6729 send_parameters_.max_bandwidth_bps =
6730 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6731 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6732 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6733
6734 // The highest layer has no max bitrate set -> the bitrate above the total
6735 // max should be given to the highest layer.
6736 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6737 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6738 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6739 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6740 stream->GetVideoStreams()[2].max_bitrate_bps);
6741
6742 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6743}
6744
6745TEST_F(WebRtcVideoChannelTest,
6746 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6747 const size_t kNumSimulcastStreams = 3;
6748 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6749 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6750 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6751
6752 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006753 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006754 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006755 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006756 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006757 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006758
6759 // Set max bitrate for the highest layer.
6760 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6761 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6762 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6763 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6764
6765 // Set max bandwidth above the total max bitrate.
6766 send_parameters_.max_bandwidth_bps =
6767 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6768 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6769 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6770
6771 // The highest layer has the max bitrate set -> the bitrate above the total
6772 // max should not be given to the highest layer.
6773 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6774 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6775 stream->GetVideoStreams()[2].max_bitrate_bps);
6776
6777 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6778}
6779
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006780// Test that min and max bitrate values set via RtpParameters are correctly
6781// propagated to the underlying encoder for a single stream.
6782TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6783 FakeVideoSendStream* stream = AddSendStream();
6784 EXPECT_TRUE(channel_->SetSend(true));
6785 EXPECT_TRUE(stream->IsSending());
6786
6787 // Set min and max bitrate.
6788 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6789 EXPECT_EQ(1u, parameters.encodings.size());
6790 parameters.encodings[0].min_bitrate_bps = 80000;
6791 parameters.encodings[0].max_bitrate_bps = 150000;
6792 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6793
6794 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6795 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6796 EXPECT_EQ(1u, encoder_config.number_of_streams);
6797 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6798 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6799 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6800
6801 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6802 // VideoStreams are created appropriately.
6803 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6804 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6805 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6806 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6807}
6808
6809// Test the default min and max bitrate value are correctly propagated to the
6810// underlying encoder for a single stream (when the values are not set via
6811// RtpParameters).
6812TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6813 FakeVideoSendStream* stream = AddSendStream();
6814 EXPECT_TRUE(channel_->SetSend(true));
6815 EXPECT_TRUE(stream->IsSending());
6816
6817 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6818 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6819 EXPECT_EQ(1u, encoder_config.number_of_streams);
6820 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6821 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6822 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6823
6824 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6825 // VideoStreams are created appropriately.
6826 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6827 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6828 stream->GetVideoStreams()[0].min_bitrate_bps);
6829 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6830 stream->GetVideoStreams()[0].min_bitrate_bps);
6831 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6832 stream->GetVideoStreams()[0].target_bitrate_bps);
6833}
6834
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006835// Test that a stream will not be sending if its encoding is made inactive
6836// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006837TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006838 FakeVideoSendStream* stream = AddSendStream();
6839 EXPECT_TRUE(channel_->SetSend(true));
6840 EXPECT_TRUE(stream->IsSending());
6841
6842 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006843 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006844 ASSERT_EQ(1u, parameters.encodings.size());
6845 ASSERT_TRUE(parameters.encodings[0].active);
6846 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006847 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006848 EXPECT_FALSE(stream->IsSending());
6849
6850 // Now change it back to active and verify we resume sending.
6851 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006852 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006853 EXPECT_TRUE(stream->IsSending());
6854}
6855
Seth Hampson8234ead2018-02-02 15:16:24 -08006856// Tests that when active is updated for any simulcast layer then the send
6857// stream's sending state will be updated and it will be reconfigured with the
6858// new appropriate active simulcast streams.
6859TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6860 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006861 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006862 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6863 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6864 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6865 uint32_t primary_ssrc = stream_params.first_ssrc();
6866
Niels Möller805a27e2019-01-21 12:21:27 +01006867 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006868 // frame. This allows us to test that ReconfigureEncoder is called
6869 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006870 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006871 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006872 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006873 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006874 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6875 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6876 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08006877
6878 // Check that all encodings are initially active.
6879 webrtc::RtpParameters parameters =
6880 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006881 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006882 EXPECT_TRUE(parameters.encodings[0].active);
6883 EXPECT_TRUE(parameters.encodings[1].active);
6884 EXPECT_TRUE(parameters.encodings[2].active);
6885 EXPECT_TRUE(fake_video_send_stream->IsSending());
6886
6887 // Only turn on only the middle stream.
6888 parameters.encodings[0].active = false;
6889 parameters.encodings[1].active = true;
6890 parameters.encodings[2].active = false;
6891 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6892 // Verify that the active fields are set on the VideoChannel.
6893 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006894 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006895 EXPECT_FALSE(parameters.encodings[0].active);
6896 EXPECT_TRUE(parameters.encodings[1].active);
6897 EXPECT_FALSE(parameters.encodings[2].active);
6898 // Check that the VideoSendStream is updated appropriately. This means its
6899 // send state was updated and it was reconfigured.
6900 EXPECT_TRUE(fake_video_send_stream->IsSending());
6901 std::vector<webrtc::VideoStream> simulcast_streams =
6902 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006903 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006904 EXPECT_FALSE(simulcast_streams[0].active);
6905 EXPECT_TRUE(simulcast_streams[1].active);
6906 EXPECT_FALSE(simulcast_streams[2].active);
6907
6908 // Turn off all streams.
6909 parameters.encodings[0].active = false;
6910 parameters.encodings[1].active = false;
6911 parameters.encodings[2].active = false;
6912 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6913 // Verify that the active fields are set on the VideoChannel.
6914 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006915 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006916 EXPECT_FALSE(parameters.encodings[0].active);
6917 EXPECT_FALSE(parameters.encodings[1].active);
6918 EXPECT_FALSE(parameters.encodings[2].active);
6919 // Check that the VideoSendStream is off.
6920 EXPECT_FALSE(fake_video_send_stream->IsSending());
6921 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006922 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006923 EXPECT_FALSE(simulcast_streams[0].active);
6924 EXPECT_FALSE(simulcast_streams[1].active);
6925 EXPECT_FALSE(simulcast_streams[2].active);
6926
Niels Möllerff40b142018-04-09 08:49:14 +02006927 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006928}
6929
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006930// Test that if a stream is reconfigured (due to a codec change or other
6931// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006932TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006933 InactiveStreamDoesntStartSendingWhenReconfigured) {
6934 // Set an initial codec list, which will be modified later.
6935 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006936 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6937 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006938 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6939
6940 FakeVideoSendStream* stream = AddSendStream();
6941 EXPECT_TRUE(channel_->SetSend(true));
6942 EXPECT_TRUE(stream->IsSending());
6943
6944 // Get current parameters and change "active" to false.
6945 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6946 ASSERT_EQ(1u, parameters.encodings.size());
6947 ASSERT_TRUE(parameters.encodings[0].active);
6948 parameters.encodings[0].active = false;
6949 EXPECT_EQ(1u, GetFakeSendStreams().size());
6950 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006951 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006952 EXPECT_FALSE(stream->IsSending());
6953
6954 // Reorder the codec list, causing the stream to be reconfigured.
6955 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006956 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6957 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006958 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6959 auto new_streams = GetFakeSendStreams();
6960 // Assert that a new underlying stream was created due to the codec change.
6961 // Otherwise, this test isn't testing what it set out to test.
6962 EXPECT_EQ(1u, GetFakeSendStreams().size());
6963 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6964
6965 // Verify that we still are not sending anything, due to the inactive
6966 // encoding.
6967 EXPECT_FALSE(new_streams[0]->IsSending());
6968}
6969
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006970// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006971TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006972 AddSendStream();
6973 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006974 parameters.codecs.push_back(GetEngineCodec("VP8"));
6975 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006976 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6977
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006978 webrtc::RtpParameters rtp_parameters =
6979 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006980 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006981 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6982 rtp_parameters.codecs[0]);
6983 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6984 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006985}
6986
Florent Castellidacec712018-05-24 16:24:21 +02006987// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6988TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6989 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6990 params.cname = "rtcpcname";
6991 AddSendStream(params);
6992
6993 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6994 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6995}
6996
deadbeeffb2aced2017-01-06 23:05:37 -08006997// Test that RtpParameters for send stream has one encoding and it has
6998// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006999TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007000 AddSendStream();
7001
7002 webrtc::RtpParameters rtp_parameters =
7003 channel_->GetRtpSendParameters(last_ssrc_);
7004 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007005 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007006}
7007
Florent Castelliabe301f2018-06-12 18:33:49 +02007008TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7009 AddSendStream();
7010
7011 webrtc::RtpParameters rtp_parameters =
7012 channel_->GetRtpSendParameters(last_ssrc_);
7013 rtp_parameters.header_extensions.emplace_back();
7014
7015 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7016
7017 webrtc::RTCError result =
7018 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7019 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7020}
7021
Florent Castelli87b3c512018-07-18 16:00:28 +02007022TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7023 AddSendStream();
7024
Niels Möller805a27e2019-01-21 12:21:27 +01007025 webrtc::test::FrameForwarder frame_forwarder;
7026 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007027
7028 webrtc::RtpParameters rtp_parameters =
7029 channel_->GetRtpSendParameters(last_ssrc_);
7030 EXPECT_EQ(rtp_parameters.degradation_preference,
7031 webrtc::DegradationPreference::BALANCED);
7032 rtp_parameters.degradation_preference =
7033 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7034
7035 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7036
7037 webrtc::RtpParameters updated_rtp_parameters =
7038 channel_->GetRtpSendParameters(last_ssrc_);
7039 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7040 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7041
7042 // Remove the source since it will be destroyed before the channel
7043 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7044}
7045
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007046// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007047TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007048 AddSendStream();
7049 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007050 parameters.codecs.push_back(GetEngineCodec("VP8"));
7051 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007052 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7053
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007054 webrtc::RtpParameters initial_params =
7055 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007056
7057 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007058 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007059
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007060 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7061 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7062}
7063
7064// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007065TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007066 AddRecvStream();
7067 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007068 parameters.codecs.push_back(GetEngineCodec("VP8"));
7069 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007070 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7071
7072 webrtc::RtpParameters rtp_parameters =
7073 channel_->GetRtpReceiveParameters(last_ssrc_);
7074 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007075 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7076 rtp_parameters.codecs[0]);
7077 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7078 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007079}
7080
johan073ece42016-08-26 02:59:47 -07007081#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007082TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007083#else
eladalonf1841382017-06-12 01:16:46 -07007084TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007085#endif
johan3859c892016-08-05 09:19:25 -07007086 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007087 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007088 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007089 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007090 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007091 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007092 parameters.codecs.push_back(kH264sprop2);
7093 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7094
7095 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7096 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7097 webrtc::RtpParameters rtp_parameters =
7098 channel_->GetRtpReceiveParameters(last_ssrc_);
7099 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7100 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7101 ASSERT_EQ(2u, cfg.decoders.size());
7102 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007103 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007104 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007105 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7106 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007107 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007108
7109 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007110 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007111 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007112 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7113 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007114 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007115}
7116
sakal1fd95952016-06-22 00:46:15 -07007117// Test that RtpParameters for receive stream has one encoding and it has
7118// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007119TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007120 AddRecvStream();
7121
7122 webrtc::RtpParameters rtp_parameters =
7123 channel_->GetRtpReceiveParameters(last_ssrc_);
7124 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007125 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007126}
7127
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007128// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007129TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007130 AddRecvStream();
7131 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007132 parameters.codecs.push_back(GetEngineCodec("VP8"));
7133 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007134 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7135
7136 webrtc::RtpParameters initial_params =
7137 channel_->GetRtpReceiveParameters(last_ssrc_);
7138
7139 // We should be able to set the params we just got.
7140 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7141
7142 // ... And this shouldn't change the params returned by
7143 // GetRtpReceiveParameters.
7144 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007145}
7146
deadbeef3bc15102017-04-20 19:25:07 -07007147// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7148// aren't signaled. It should always return an empty "RtpEncodingParameters",
7149// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007150TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007151 // Call necessary methods to configure receiving a default stream as
7152 // soon as it arrives.
7153 cricket::VideoRecvParameters parameters;
7154 parameters.codecs.push_back(GetEngineCodec("VP8"));
7155 parameters.codecs.push_back(GetEngineCodec("VP9"));
7156 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7157
7158 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7159 // stream. Should return nothing.
7160 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7161
7162 // Set a sink for an unsignaled stream.
7163 cricket::FakeVideoRenderer renderer;
7164 // Value of "0" means "unsignaled stream".
7165 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7166
7167 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7168 // in this method means "unsignaled stream".
7169 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7170 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7171 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7172
7173 // Receive VP8 packet.
7174 uint8_t data[kMinRtpPacketLen];
7175 cricket::RtpHeader rtpHeader;
7176 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7177 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7178 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7179 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7180 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007181 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007182
7183 // The |ssrc| member should still be unset.
7184 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7185 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7186 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7187}
7188
eladalonf1841382017-06-12 01:16:46 -07007189void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007190 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007191 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007192
7193 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007194 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007195 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007196 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007197
7198 if (receiver_first) {
7199 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7200 std::vector<FakeVideoReceiveStream*> receive_streams =
7201 fake_call_->GetVideoReceiveStreams();
7202 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007203 // Default local SSRC when we have no sender.
7204 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7205 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007206 }
7207 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7208 if (!receiver_first)
7209 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7210 std::vector<FakeVideoReceiveStream*> receive_streams =
7211 fake_call_->GetVideoReceiveStreams();
7212 ASSERT_EQ(1u, receive_streams.size());
7213 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007214
7215 // Removing first sender should fall back to another (in this case the second)
7216 // local send stream's SSRC.
7217 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7218 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007219 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007220 ASSERT_EQ(1u, receive_streams.size());
7221 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7222
7223 // Removing the last sender should fall back to default local SSRC.
7224 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007225 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007226 ASSERT_EQ(1u, receive_streams.size());
7227 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7228 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007229}
7230
eladalonf1841382017-06-12 01:16:46 -07007231TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007232 TestReceiverLocalSsrcConfiguration(false);
7233}
7234
eladalonf1841382017-06-12 01:16:46 -07007235TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007236 TestReceiverLocalSsrcConfiguration(true);
7237}
7238
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007239class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007240 public:
eladalonf1841382017-06-12 01:16:46 -07007241 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007242 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007243 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7244 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007245 mock_rate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007246 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007247 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007248 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007249 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007250 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007251 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007252
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007253 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007254 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007255 channel_.reset(engine_.CreateMediaChannel(
7256 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7257 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007258 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007259 last_ssrc_ = 123;
7260 }
7261
7262 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007263 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007264 int capture_width,
7265 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007266 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007267 size_t expected_num_streams,
7268 bool screenshare,
7269 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007270 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007271 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007272 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007273 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007274
Peter Boström0c4e06b2015-10-07 12:23:21 +02007275 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007276 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007277 ssrcs.resize(num_configured_streams);
7278
sprangf24a0642017-02-28 13:23:26 -08007279 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007280 // Send a full-size frame to trigger a stream reconfiguration to use all
7281 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007282 webrtc::test::FrameForwarder frame_forwarder;
7283 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7284 rtc::kNumMicrosecsPerSec / 30);
7285
sprangf24a0642017-02-28 13:23:26 -08007286 VideoOptions options;
7287 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007288 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007289 EXPECT_TRUE(
7290 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007291 // Fetch the latest stream since SetVideoSend() may recreate it if the
7292 // screen content setting is changed.
7293 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007294 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007295 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007296
Zach Stein3ca452b2018-01-18 10:01:24 -08007297 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7298 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7299
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007300 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7301 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007302 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007303
sprang429600d2017-01-26 06:12:26 -08007304 std::vector<webrtc::VideoStream> expected_streams;
7305 if (conference_mode) {
7306 expected_streams = GetSimulcastConfig(
7307 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08007308 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02007309 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08007310 if (screenshare) {
7311 for (const webrtc::VideoStream& stream : expected_streams) {
7312 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007313 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7314 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007315 }
7316 }
sprang429600d2017-01-26 06:12:26 -08007317 } else {
7318 webrtc::VideoStream stream;
7319 stream.width = capture_width;
7320 stream.height = capture_height;
7321 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007322 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007323 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007324 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007325 stream.max_qp = kDefaultQpMax;
7326 expected_streams.push_back(stream);
7327 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007328
7329 ASSERT_EQ(expected_streams.size(), video_streams.size());
7330
7331 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007332 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007333 for (size_t i = 0; i < num_streams; ++i) {
7334 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7335 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7336
7337 EXPECT_GT(video_streams[i].max_framerate, 0);
7338 EXPECT_EQ(expected_streams[i].max_framerate,
7339 video_streams[i].max_framerate);
7340
7341 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7342 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7343 video_streams[i].min_bitrate_bps);
7344
7345 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7346 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7347 video_streams[i].target_bitrate_bps);
7348
7349 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7350 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7351 video_streams[i].max_bitrate_bps);
7352
7353 EXPECT_GT(video_streams[i].max_qp, 0);
7354 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7355
Sergey Silkina796a7e2018-03-01 15:11:29 +01007356 EXPECT_EQ(conference_mode,
7357 expected_streams[i].num_temporal_layers.has_value());
7358
7359 if (conference_mode) {
7360 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7361 video_streams[i].num_temporal_layers);
7362 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007363
7364 if (i == num_streams - 1) {
7365 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7366 } else {
7367 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7368 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007369 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007370
Niels Möllerff40b142018-04-09 08:49:14 +02007371 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007372 }
7373
7374 FakeVideoSendStream* AddSendStream() {
7375 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7376 }
7377
7378 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007379 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007380 EXPECT_TRUE(channel_->AddSendStream(sp));
7381 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007382 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007383 EXPECT_EQ(num_streams + 1, streams.size());
7384 return streams[streams.size() - 1];
7385 }
7386
7387 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007388 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007389 }
7390
7391 FakeVideoReceiveStream* AddRecvStream() {
7392 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7393 }
7394
7395 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007396 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007397 EXPECT_TRUE(channel_->AddRecvStream(sp));
7398 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007399 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007400 EXPECT_EQ(num_streams + 1, streams.size());
7401 return streams[streams.size() - 1];
7402 }
7403
skvlad11a9cbf2016-10-07 11:53:05 -07007404 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007405 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007406 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7407 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007408 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7409 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007410 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007411 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007412 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007413};
7414
eladalonf1841382017-06-12 01:16:46 -07007415TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007416 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7417 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007418}
7419
eladalonf1841382017-06-12 01:16:46 -07007420TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007421 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7422 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007423}
7424
7425// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007426TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007427 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7428 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007429}
sprang429600d2017-01-26 06:12:26 -08007430
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007431TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007432 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7433 false);
7434}
7435
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007436TEST_F(WebRtcVideoChannelSimulcastTest,
7437 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01007438 webrtc::test::ScopedFieldTrials field_trials(
7439 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007440 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7441 true);
7442}
7443
eladalonf1841382017-06-12 01:16:46 -07007444TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007445 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7446 true);
7447}
7448
eladalonf1841382017-06-12 01:16:46 -07007449TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07007450 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07007451 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7452 false);
7453}
7454
Yves Gereyb6a89422018-10-08 10:08:32 +02007455class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007456 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02007457 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007458 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
7459 }
7460 rtc::ScopedFakeClock fake_clock_;
7461};
7462
Yves Gereyb6a89422018-10-08 10:08:32 +02007463// The fake clock needs to be initialized before the call, and not
7464// destroyed until after all threads spawned by the test have been stopped.
7465// This mixin ensures that.
7466class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
7467 public WebRtcVideoChannelBaseTest {};
7468
Jonas Oreland49ac5952018-09-26 16:04:32 +02007469TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7470 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7471 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7472
7473 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7474
7475 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7476 rtc::SetBE32(packet1.data() + 8, kSsrc);
7477 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7478 EXPECT_TRUE(SetDefaultCodec());
7479 EXPECT_TRUE(SetSend(true));
7480 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007481 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007482
7483 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7484 EXPECT_EQ(1u, sources.size());
7485 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7486 int64_t timestamp1 = sources[0].timestamp_ms();
7487
7488 // a new packet.
7489 int64_t timeDeltaMs = 1;
7490 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007491 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007492 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7493 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7494
7495 // It only keeps 10s of history.
7496 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7497 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7498 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7499}
7500
7501TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7502 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7503 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7504
7505 uint32_t kCsrc = 4321u;
7506 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7507 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7508
7509 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7510 rtc::SetBE32(packet1.data() + 8, kSsrc);
7511 rtc::SetBE32(packet1.data() + 12, kCsrc);
7512 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7513 EXPECT_TRUE(SetDefaultCodec());
7514 EXPECT_TRUE(SetSend(true));
7515 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007516 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007517
7518 {
7519 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7520 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7521 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7522 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7523 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007524 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7525 return source.source_type() == webrtc::RtpSourceType::SSRC;
7526 }));
7527 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7528 return source.source_type() == webrtc::RtpSourceType::CSRC;
7529 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007530 }
7531 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7532
7533 // a new packet with only ssrc (i.e no csrc).
7534 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7535 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7536 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7537 rtc::SetBE32(packet2.data() + 8, kSsrc);
7538
7539 int64_t timeDeltaMs = 1;
7540 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007541 channel_->OnPacketReceived(packet2, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007542
7543 {
7544 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7545 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7546 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7547 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7548 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007549 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7550 return source.source_type() == webrtc::RtpSourceType::SSRC;
7551 }));
7552 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7553 return source.source_type() == webrtc::RtpSourceType::CSRC;
7554 }));
7555 auto ssrcSource =
7556 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007557 return source.source_type() == webrtc::RtpSourceType::SSRC;
7558 });
Steve Anton2c9ebef2019-01-28 17:27:58 -08007559 auto csrcSource =
7560 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007561 return source.source_type() == webrtc::RtpSourceType::CSRC;
7562 });
7563
7564 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7565 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7566 }
7567
7568 // It only keeps 10s of history.
7569 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7570
7571 {
7572 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7573 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7574 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
Steve Anton2c9ebef2019-01-28 17:27:58 -08007575 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7576 return source.source_type() == webrtc::RtpSourceType::SSRC;
7577 }));
7578 EXPECT_EQ(0, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7579 return source.source_type() == webrtc::RtpSourceType::CSRC;
7580 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007581 }
7582
7583 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7584 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7585 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7586}
7587
Amit Hilbuchb000b712019-02-25 10:22:14 -08007588TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7589 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7590
7591 std::vector<std::string> rids = {"f", "h", "q"};
7592 std::vector<cricket::RidDescription> rid_descriptions;
7593 for (const auto& rid : rids) {
7594 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7595 }
7596 sp.set_rids(rid_descriptions);
7597
7598 ASSERT_TRUE(channel_->AddSendStream(sp));
7599 const auto& streams = fake_call_->GetVideoSendStreams();
7600 ASSERT_EQ(1u, streams.size());
7601 auto stream = streams[0];
7602 ASSERT_NE(stream, nullptr);
7603 const auto& config = stream->GetConfig();
7604 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7605}
7606
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007607} // namespace cricket