blob: e87f63ff4a65f2a14546ab1af79a540a4d5ba4c0 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Seth Hampson24722b32017-12-22 09:36:42 -080017#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070018#include "api/test/mock_video_decoder_factory.h"
19#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020020#include "api/units/time_delta.h"
Åsa Persson23eba222018-10-02 14:47:06 +020021#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020022#include "api/video_codecs/builtin_video_decoder_factory.h"
23#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020024#include "api/video_codecs/sdp_video_format.h"
25#include "api/video_codecs/video_decoder_factory.h"
26#include "api/video_codecs/video_encoder.h"
27#include "api/video_codecs/video_encoder_factory.h"
28#include "call/flexfec_receive_stream.h"
29#include "common_video/h264/profile_level_id.h"
30#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020031#include "media/base/fakenetworkinterface.h"
32#include "media/base/fakevideocapturer.h"
33#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "media/base/mediaconstants.h"
35#include "media/base/rtputils.h"
36#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020037#include "media/engine/constants.h"
38#include "media/engine/fakewebrtccall.h"
39#include "media/engine/fakewebrtcvideoengine.h"
40#include "media/engine/simulcast.h"
41#include "media/engine/webrtcvideoengine.h"
42#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020043#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020044#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020045#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020047#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020048#include "rtc_base/stringutils.h"
49#include "test/field_trial.h"
50#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000051
Tommi85959932018-02-07 19:26:06 +010052using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010053using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070054using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010055using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070056
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000057namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000058static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000059
noahricd10a68e2015-07-10 11:27:55 -070060static const uint8_t kRedRtxPayloadType = 125;
61
Niels Möller6557d0c2018-04-11 15:18:34 +020062static const uint32_t kTimeout = 5000U;
63static const uint32_t kDefaultReceiveSsrc = 0;
64static const uint32_t kSsrc = 1234u;
65static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
66static const int kVideoWidth = 640;
67static const int kVideoHeight = 360;
68static const int kFramerate = 30;
69
Peter Boström0c4e06b2015-10-07 12:23:21 +020070static const uint32_t kSsrcs1[] = {1};
71static const uint32_t kSsrcs3[] = {1, 2, 3};
72static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080073static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020074static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080075static const uint32_t kDefaultRecvSsrc = 0;
76
pbos@webrtc.org3c107582014-07-20 15:27:35 +000077static const char kUnsupportedExtensionName[] =
78 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000079
magjed509e4fe2016-11-18 01:34:11 -080080cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
81 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020082 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080083}
84
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000085void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
86 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
87 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
88 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
89 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
90 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
91 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080093 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
94 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000095 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
96}
97
magjed725e4842016-11-16 00:48:13 -080098// Return true if any codec in |codecs| is an RTX codec with associated payload
99// type |payload_type|.
100bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
101 int payload_type) {
102 for (const cricket::VideoCodec& codec : codecs) {
103 int associated_payload_type;
104 if (cricket::CodecNamesEq(codec.name.c_str(), "rtx") &&
105 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
106 &associated_payload_type) &&
107 associated_payload_type == payload_type) {
108 return true;
109 }
110 }
111 return false;
112}
113
nisseca5706d2017-09-11 02:32:16 -0700114// TODO(nisse): Duplicated in call.cc.
115const int* FindKeyByValue(const std::map<int, int>& m, int v) {
116 for (const auto& kv : m) {
117 if (kv.second == v)
118 return &kv.first;
119 }
120 return nullptr;
121}
122
Yves Gerey665174f2018-06-19 15:03:05 +0200123bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
124 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700125 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
126 payload_type) != nullptr;
127}
128
129// Check that there's an Rtx payload type for each decoder.
130bool VerifyRtxReceiveAssociations(
131 const webrtc::VideoReceiveStream::Config& config) {
132 for (const auto& decoder : config.decoders) {
133 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
134 return false;
135 }
136 return true;
137}
138
brandtrffc61182016-11-28 06:02:22 -0800139rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700140 int width,
141 int height) {
142 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
143 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800144 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700145 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000146}
147
Shao Changbine62202f2015-04-21 20:24:50 +0800148void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
149 const std::map<int, int>& rtx_types) {
150 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200151 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800152 EXPECT_TRUE(it != rtx_types.end() &&
153 it->second == config.rtp.rtx.payload_type);
154
brandtrb5f2c3f2016-10-04 23:28:39 -0700155 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
156 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800157 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700158 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800159 }
160}
kthelgason2bc68642017-02-07 07:02:22 -0800161
162cricket::MediaConfig GetMediaConfig() {
163 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100164 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800165 return media_config;
166}
nisse26e3abb2017-08-25 04:44:25 -0700167
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200168// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
169int GetMaxDefaultBitrateBps(size_t width, size_t height) {
170 if (width * height <= 320 * 240) {
171 return 600000;
172 } else if (width * height <= 640 * 480) {
173 return 1700000;
174 } else if (width * height <= 960 * 540) {
175 return 2000000;
176 } else {
177 return 2500000;
178 }
179}
180
Niels Möller731a2c22018-07-30 15:08:07 +0200181class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
182 public:
183 MOCK_METHOD2(AddOrUpdateSink,
184 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
185 const rtc::VideoSinkWants& wants));
186 MOCK_METHOD1(RemoveSink,
187 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
188};
189
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000190} // namespace
191
Yves Gerey665174f2018-06-19 15:03:05 +0200192#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200193 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200194 EXPECT_EQ((w), renderer_.width()); \
195 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200196 EXPECT_EQ(0, renderer_.errors());
197
Yves Gerey665174f2018-06-19 15:03:05 +0200198#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200199 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200200 EXPECT_EQ((w), (r).width()); \
201 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200202 EXPECT_EQ(0, (r).errors());
203
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000204namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700205class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000206 public:
eladalonf1841382017-06-12 01:16:46 -0700207 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
208 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700209 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700210 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200211 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
212 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200213 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200214 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200215 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200216 decoder_factory_)) {
217 // Ensure fake clock doesn't return 0, which will cause some initializations
218 // fail inside RTP senders.
219 fake_clock_.AdvanceTimeMicros(1);
220 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000221
222 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200223 void AssignDefaultAptRtxTypes();
224 void AssignDefaultCodec();
225
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100226 // Find the index of the codec in the engine with the given name. The codec
227 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100228 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100229
magjed509e4fe2016-11-18 01:34:11 -0800230 // Find the codec in the engine with the given name. The codec must be
231 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100232 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800233
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200234 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000235
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200236 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000237 const std::vector<VideoCodec>& codecs);
238
Peter Boströme4499152016-02-05 11:13:28 +0100239 void TestExtendedEncoderOveruse(bool use_external_encoder);
240
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200241 // Has to be the first one, so it is initialized before the call or there is a
242 // race condition in the clock access.
243 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700244 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700245 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700246 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000247 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800248 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200249 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
250 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700251 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000252 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800253 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000254};
255
eladalonf1841382017-06-12 01:16:46 -0700256TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200257 encoder_factory_->AddSupportedVideoCodecType("VP8");
258 AssignDefaultCodec();
259
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000260 std::vector<VideoCodec> engine_codecs = engine_.codecs();
261 for (size_t i = 0; i < engine_codecs.size(); ++i) {
262 if (engine_codecs[i].name != kRtxCodecName)
263 continue;
264 int associated_payload_type;
265 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000266 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000267 EXPECT_EQ(default_codec_.id, associated_payload_type);
268 return;
269 }
270 FAIL() << "No RTX codec found among default codecs.";
271}
272
eladalonf1841382017-06-12 01:16:46 -0700273TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100274 RtpCapabilities capabilities = engine_.GetCapabilities();
275 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700276 for (const RtpExtension& extension : capabilities.header_extensions) {
277 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
278 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000279 return;
280 }
281 }
282 FAIL() << "Timestamp offset extension not in header-extension list.";
283}
284
eladalonf1841382017-06-12 01:16:46 -0700285TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100286 RtpCapabilities capabilities = engine_.GetCapabilities();
287 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700288 for (const RtpExtension& extension : capabilities.header_extensions) {
289 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
290 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000291 return;
292 }
293 }
294 FAIL() << "Absolute Sender Time extension not in header-extension list.";
295}
296
eladalonf1841382017-06-12 01:16:46 -0700297TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100298 RtpCapabilities capabilities = engine_.GetCapabilities();
299 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700300 for (const RtpExtension& extension : capabilities.header_extensions) {
301 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
302 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700303 return;
304 }
305 }
306 FAIL() << "Transport sequence number extension not in header-extension list.";
307}
308
eladalonf1841382017-06-12 01:16:46 -0700309TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100310 RtpCapabilities capabilities = engine_.GetCapabilities();
311 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700312 for (const RtpExtension& extension : capabilities.header_extensions) {
313 if (extension.uri == RtpExtension::kVideoRotationUri) {
314 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700315 return;
316 }
317 }
318 FAIL() << "Video Rotation extension not in header-extension list.";
319}
320
eladalonf1841382017-06-12 01:16:46 -0700321TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200322 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700323 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200324 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700325
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200326 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700327
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200328 std::unique_ptr<VideoMediaChannel> channel(
329 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700330 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
331
332 // Add CVO extension.
333 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800334 cricket::VideoSendParameters parameters;
335 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200336 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700337 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200338 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700339
Niels Möller731a2c22018-07-30 15:08:07 +0200340 EXPECT_CALL(
341 video_source,
342 AddOrUpdateSink(testing::_,
343 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700344 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200345 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700346
347 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200348 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700349
350 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200351 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200352 EXPECT_CALL(
353 video_source,
354 AddOrUpdateSink(testing::_,
355 Field(&rtc::VideoSinkWants::rotation_applied, true)));
356
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200357 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700358}
359
eladalonf1841382017-06-12 01:16:46 -0700360TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200361 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800362 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200363 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800364
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200365 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800366
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200367 std::unique_ptr<VideoMediaChannel> channel(
368 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800369 // Add CVO extension.
370 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800371 cricket::VideoSendParameters parameters;
372 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800373 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700374 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800375 EXPECT_TRUE(channel->SetSendParameters(parameters));
376 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
377
Niels Möller731a2c22018-07-30 15:08:07 +0200378 // Set source.
379 EXPECT_CALL(
380 video_source,
381 AddOrUpdateSink(testing::_,
382 Field(&rtc::VideoSinkWants::rotation_applied, false)));
383 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800384}
385
eladalonf1841382017-06-12 01:16:46 -0700386TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200387 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700388
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200389 encoder_factory_->AddSupportedVideoCodecType("VP8");
390 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700391
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200392 std::unique_ptr<VideoMediaChannel> channel(
393 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700394 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
395
396 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200397 EXPECT_CALL(
398 video_source,
399 AddOrUpdateSink(testing::_,
400 Field(&rtc::VideoSinkWants::rotation_applied, true)));
401 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700402
perkjcaafdba2016-03-20 07:34:29 -0700403 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200404 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700405
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700406 // Add CVO extension.
407 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800408 cricket::VideoSendParameters parameters;
409 parameters.codecs.push_back(GetEngineCodec("VP8"));
410 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200411 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700412 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700413 // Also remove the first codec to trigger a codec change as well.
414 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200415 EXPECT_CALL(
416 video_source,
417 AddOrUpdateSink(testing::_,
418 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200419 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700420
421 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200422 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700423
424 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200425 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200426 EXPECT_CALL(
427 video_source,
428 AddOrUpdateSink(testing::_,
429 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200430 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700431}
432
eladalonf1841382017-06-12 01:16:46 -0700433TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200434 encoder_factory_->AddSupportedVideoCodecType("VP8");
435
kwiberg686a8ef2016-02-26 03:00:35 -0800436 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800437 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000438
439 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
440
441 EXPECT_FALSE(channel->SetSend(true))
442 << "Channel should not start without codecs.";
443 EXPECT_TRUE(channel->SetSend(false))
444 << "Channel should be stoppable even without set codecs.";
445}
446
eladalonf1841382017-06-12 01:16:46 -0700447TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200448 encoder_factory_->AddSupportedVideoCodecType("VP8");
449
kwiberg686a8ef2016-02-26 03:00:35 -0800450 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800451 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000452 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
453 VideoMediaInfo info;
454 channel->GetStats(&info);
455}
456
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200457TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200458 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000459
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200460 std::unique_ptr<VideoMediaChannel> channel(
461 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800462 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000463
464 EXPECT_TRUE(
465 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200466 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000467 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100468 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200469 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000470 EXPECT_EQ(cricket::CS_RUNNING,
471 capturer.Start(capturer.GetSupportedFormats()->front()));
472 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100473 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200474 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
475 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000476 kTimeout);
477
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200478 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100479 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000480
481 // Setting codecs of the same type should not reallocate any encoders
482 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800483 cricket::VideoSendParameters parameters;
484 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200485 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200486 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000487
488 // Remove stream previously added to free the external encoder instance.
489 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200490 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000491}
492
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200493// Test that when an encoder factory supports H264, we add an RTX
494// codec for it.
495// TODO(deadbeef): This test should be updated if/when we start
496// adding RTX codecs for unrecognized codec names.
497TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800498 using webrtc::H264::ProfileLevelIdToString;
499 using webrtc::H264::ProfileLevelId;
500 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200501 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
502 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800503 *ProfileLevelIdToString(
504 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200505 webrtc::SdpVideoFormat h264_constrained_high("H264");
506 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800507 *ProfileLevelIdToString(
508 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200509 webrtc::SdpVideoFormat h264_high("H264");
510 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800511 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
512
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200513 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
514 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
515 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700516
magjed725e4842016-11-16 00:48:13 -0800517 // First figure out what payload types the test codecs got assigned.
518 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800519 // Now search for RTX codecs for them. Expect that they all have associated
520 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800521 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200522 codecs,
523 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
524 ->id));
magjed725e4842016-11-16 00:48:13 -0800525 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200526 codecs,
527 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
528 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800529 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200530 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700531}
532
Peter Boström12996152016-05-14 02:03:18 +0200533#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700534TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200535 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100536
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200537 std::unique_ptr<VideoMediaChannel> channel(
538 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100539
540 EXPECT_TRUE(
541 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
542}
Peter Boström12996152016-05-14 02:03:18 +0200543#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100544
eladalonf1841382017-06-12 01:16:46 -0700545TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200546 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100547 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200548 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200549 std::unique_ptr<VideoMediaChannel> channel(
550 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700551
552 EXPECT_TRUE(
553 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
554
Tommi85959932018-02-07 19:26:06 +0100555 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200556 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700557 capturer.Start(cricket::VideoFormat(1280, 720,
558 cricket::VideoFormat::FpsToInterval(60),
559 cricket::FOURCC_I420));
560 channel->SetSend(true);
561
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200562 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700563
564 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700565 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700566 for (int i = 0; i < 10; i++) {
567 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700568 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700569 int64_t interval = timestamp - last_timestamp;
570
571 // Precision changes from nanosecond to millisecond.
572 // Allow error to be no more than 1.
573 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
574
575 last_timestamp = timestamp;
576 }
577
578 capturer.Start(cricket::VideoFormat(1280, 720,
579 cricket::VideoFormat::FpsToInterval(30),
580 cricket::FOURCC_I420));
581
582 EXPECT_TRUE(capturer.CaptureFrame());
583 last_timestamp = stream->GetLastTimestamp();
584 for (int i = 0; i < 10; i++) {
585 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700586 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700587 int64_t interval = timestamp - last_timestamp;
588
589 // Precision changes from nanosecond to millisecond.
590 // Allow error to be no more than 1.
591 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
592
593 last_timestamp = timestamp;
594 }
595
596 // Remove stream previously added to free the external encoder instance.
597 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
598}
599
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200600void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
601 std::vector<VideoCodec> engine_codecs = engine_.codecs();
602 RTC_DCHECK(!engine_codecs.empty());
603 for (const cricket::VideoCodec& codec : engine_codecs) {
604 if (codec.name == "rtx") {
605 int associated_payload_type;
606 if (codec.GetParam(kCodecParamAssociatedPayloadType,
607 &associated_payload_type)) {
608 default_apt_rtx_types_[associated_payload_type] = codec.id;
609 }
610 }
611 }
612}
613
614void WebRtcVideoEngineTest::AssignDefaultCodec() {
615 std::vector<VideoCodec> engine_codecs = engine_.codecs();
616 RTC_DCHECK(!engine_codecs.empty());
617 bool codec_set = false;
618 for (const cricket::VideoCodec& codec : engine_codecs) {
619 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
620 codec.name != "ulpfec") {
621 default_codec_ = codec;
622 codec_set = true;
623 }
624 }
625
626 RTC_DCHECK(codec_set);
627}
628
Oleh Prypina40f8242017-12-21 13:32:23 +0100629size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
630 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100631 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
632 for (size_t i = 0; i < codecs.size(); ++i) {
633 const cricket::VideoCodec engine_codec = codecs[i];
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200634 if (!CodecNamesEq(name, engine_codec.name))
635 continue;
636 // The tests only use H264 Constrained Baseline. Make sure we don't return
637 // an internal H264 codec from the engine with a different H264 profile.
638 if (CodecNamesEq(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200639 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200640 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
641 if (profile_level_id->profile !=
642 webrtc::H264::kProfileConstrainedBaseline) {
643 continue;
644 }
645 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100646 return i;
magjed509e4fe2016-11-18 01:34:11 -0800647 }
648 // This point should never be reached.
649 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100650 return -1;
651}
652
653cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
654 const std::string& name) const {
655 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800656}
657
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200658VideoMediaChannel*
659WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
buildbot@webrtc.org1ecbe452014-10-14 20:29:28 +0000660 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800661 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200662 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800663 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200664 for (const webrtc::SdpVideoFormat& format :
665 encoder_factory_->GetSupportedFormats()) {
666 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
667 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
668 engine_codec) == parameters.codecs.end()) {
669 parameters.codecs.push_back(engine_codec);
670 }
671 }
magjed509e4fe2016-11-18 01:34:11 -0800672
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200673 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000674
675 return channel;
676}
677
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200678VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000679 const std::vector<VideoCodec>& codecs) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000680 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800681 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200682 cricket::VideoRecvParameters parameters;
683 parameters.codecs = codecs;
684 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000685
686 return channel;
687}
688
eladalonf1841382017-06-12 01:16:46 -0700689TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200690 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000691
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200692 std::unique_ptr<VideoMediaChannel> channel(
693 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000694
Peter Boström0c4e06b2015-10-07 12:23:21 +0200695 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000696
Yves Gerey665174f2018-06-19 15:03:05 +0200697 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000698 EXPECT_TRUE(channel->SetSend(true));
699
Tommi85959932018-02-07 19:26:06 +0100700 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200701 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000702 EXPECT_EQ(cricket::CS_RUNNING,
703 capturer.Start(capturer.GetSupportedFormats()->front()));
704 EXPECT_TRUE(capturer.CaptureFrame());
705
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200706 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000707
708 // Verify that encoders are configured for simulcast through adapter
709 // (increasing resolution and only configured to send one stream each).
710 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200711 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
712 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000713 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200714 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000715 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
716 EXPECT_GT(codec_settings.width, prev_width);
717 prev_width = codec_settings.width;
718 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000719
Niels Möllerff40b142018-04-09 08:49:14 +0200720 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000721
722 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200723 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000724}
725
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200726TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
727 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200728 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000729
Niels Möller4db138e2018-04-19 09:04:13 +0200730 // Set capturer.
731 FakeVideoCapturerWithTaskQueue capturer;
732 EXPECT_EQ(cricket::CS_RUNNING,
733 capturer.Start(capturer.GetSupportedFormats()->front()));
734
Anders Carlsson67537952018-05-03 11:28:29 +0200735 std::unique_ptr<VideoMediaChannel> channel(
736 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
737 cricket::VideoSendParameters parameters;
738 parameters.codecs.push_back(GetEngineCodec("H264"));
739 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000740
741 EXPECT_TRUE(
742 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200743 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
744 // Sending one frame will have allocate the encoder.
745 EXPECT_TRUE(capturer.CaptureFrame());
746
747 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000748
Anders Carlsson67537952018-05-03 11:28:29 +0200749 cricket::VideoSendParameters new_parameters;
750 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
751 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200752
753 // Sending one frame will switch encoder.
754 EXPECT_TRUE(capturer.CaptureFrame());
755
Anders Carlsson8a150d92018-05-14 12:40:04 +0200756 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000757}
758
eladalonf1841382017-06-12 01:16:46 -0700759TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000760 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200761 encoder_factory_->AddSupportedVideoCodecType("VP8");
762 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000763
kwiberg686a8ef2016-02-26 03:00:35 -0800764 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800765 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800766 cricket::VideoSendParameters parameters;
767 parameters.codecs.push_back(GetEngineCodec("VP8"));
768 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000769
Peter Boström0c4e06b2015-10-07 12:23:21 +0200770 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000771
Yves Gerey665174f2018-06-19 15:03:05 +0200772 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000773 EXPECT_TRUE(channel->SetSend(true));
774
775 // Send a fake frame, or else the media engine will configure the simulcast
776 // encoder adapter at a low-enough size that it'll only create a single
777 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100778 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200779 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000780 EXPECT_EQ(cricket::CS_RUNNING,
781 capturer.Start(capturer.GetSupportedFormats()->front()));
782 EXPECT_TRUE(capturer.CaptureFrame());
783
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200784 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
785 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000786 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200787 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000788
789 channel.reset();
790 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200791 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000792}
793
eladalonf1841382017-06-12 01:16:46 -0700794TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000795 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200796 encoder_factory_->AddSupportedVideoCodecType("VP8");
797 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000798
kwiberg686a8ef2016-02-26 03:00:35 -0800799 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800800 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800801 cricket::VideoSendParameters parameters;
802 parameters.codecs.push_back(GetEngineCodec("H264"));
803 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000804
805 EXPECT_TRUE(
806 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100807
808 // Send a frame of 720p. This should trigger a "real" encoder initialization.
809 cricket::VideoFormat format(
810 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100811 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200812 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100813 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
814 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200815 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
816 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200817 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000818 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200819 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000820
821 channel.reset();
822 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200823 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000824}
825
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200826TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
827 webrtc::test::ScopedFieldTrials override_field_trials_(
828 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200829 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700830
Anders Carlsson67537952018-05-03 11:28:29 +0200831 std::unique_ptr<VideoMediaChannel> channel(
832 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
833 cricket::VideoSendParameters parameters;
834 parameters.codecs.push_back(GetEngineCodec("H264"));
835 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700836
Peter Boström0c4e06b2015-10-07 12:23:21 +0200837 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700838 EXPECT_TRUE(
839 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100840
841 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700842 cricket::VideoFormat format(
843 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100844 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200845 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100846 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
847 EXPECT_TRUE(capturer.CaptureFrame());
848
Niels Möller4db138e2018-04-19 09:04:13 +0200849 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200850 ASSERT_EQ(1u, encoder_factory_->encoders().size());
851 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
852 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700853 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200854 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200855 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700856}
857
brandtrffc61182016-11-28 06:02:22 -0800858// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700859// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800860//
861// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700862TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800863 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200864 encoder_factory_->AddSupportedVideoCodecType("VP8");
865
brandtrffc61182016-11-28 06:02:22 -0800866 auto is_flexfec = [](const VideoCodec& codec) {
867 if (codec.name == "flexfec-03")
868 return true;
869 return false;
870 };
871
872 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800873 const std::vector<VideoCodec> codecs_before = engine_.codecs();
874 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
875 codecs_before.end(), is_flexfec));
876
877 // FlexFEC is active with field trial.
878 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800879 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800880 const std::vector<VideoCodec> codecs_after = engine_.codecs();
881 EXPECT_NE(codecs_after.end(),
882 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
883}
884
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200885// Test that codecs are added in the order they are reported from the factory.
886TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
887 encoder_factory_->AddSupportedVideoCodecType("VP8");
888 const char* kFakeCodecName = "FakeCodec";
889 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000890
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200891 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100892 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200893 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
894 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000895}
896
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200897// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800898// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200899TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100900 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
901 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100902
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100903 // Set up external encoder factory with first codec, and initialize engine.
904 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
905
brandtrffc61182016-11-28 06:02:22 -0800906 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800907
908 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100909 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800910 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200911 // The codec itself and RTX should have been added.
912 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100913
914 // Check that both fake codecs are present and that the second fake codec
915 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100916 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
917 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100918 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800919}
920
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200921TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
922 const char* kFakeCodecName = "FakeCodec";
923 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
924
925 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
926 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
927}
928
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200929TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
930 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200931 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200932 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800933 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000934
kwiberg686a8ef2016-02-26 03:00:35 -0800935 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200936 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000937
938 EXPECT_TRUE(
939 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200940 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000941
942 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200943 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200944 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000945
946 // Remove stream previously added to free the external decoder instance.
947 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200948 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000949}
950
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200951// Verifies that we can set up decoders.
952TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000953 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
954 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
955 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
956 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200957 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200958 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000959 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800960 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000961
kwiberg686a8ef2016-02-26 03:00:35 -0800962 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200963 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000964
965 EXPECT_TRUE(
966 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200967 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000968}
969
Jonas Oreland49ac5952018-09-26 16:04:32 +0200970// Tests when GetSources is called with non-existing ssrc, it will return an
971// empty list of RtpSource without crashing.
972TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
973 // Setup an recv stream with |kSsrc|.
974 encoder_factory_->AddSupportedVideoCodecType("VP8");
975 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
976 cricket::VideoRecvParameters parameters;
977 parameters.codecs.push_back(GetEngineCodec("VP8"));
978 std::unique_ptr<VideoMediaChannel> channel(
979 SetRecvParamsWithSupportedCodecs(parameters.codecs));
980
981 EXPECT_TRUE(
982 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
983
984 // Call GetSources with |kSsrc + 1| which doesn't exist.
985 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
986 EXPECT_EQ(0u, sources.size());
987}
988
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200989TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
990 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
991 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
992 WebRtcVideoEngine engine(std::move(encoder_factory),
993 std::move(decoder_factory));
994 EXPECT_EQ(0u, engine.codecs().size());
995}
996
997TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
998 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700999 webrtc::MockVideoEncoderFactory* encoder_factory =
1000 new webrtc::MockVideoEncoderFactory();
1001 webrtc::MockVideoDecoderFactory* decoder_factory =
1002 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001003 WebRtcVideoEngine engine(
1004 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1005 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1006 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1007 EXPECT_EQ(0u, engine.codecs().size());
1008 EXPECT_CALL(*encoder_factory, Die());
1009 EXPECT_CALL(*decoder_factory, Die());
1010}
1011
1012// Test full behavior in the video engine when video codec factories of the new
1013// type are injected supporting the single codec Vp8. Check the returned codecs
1014// from the engine and that we will create a Vp8 encoder and decoder using the
1015// new factories.
1016TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1017 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001018 webrtc::MockVideoEncoderFactory* encoder_factory =
1019 new webrtc::MockVideoEncoderFactory();
1020 webrtc::MockVideoDecoderFactory* decoder_factory =
1021 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001022 WebRtcVideoEngine engine(
1023 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1024 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1025 const webrtc::SdpVideoFormat vp8_format("VP8");
1026 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1027 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1028 .WillRepeatedly(testing::Return(supported_formats));
1029
1030 // Verify the codecs from the engine.
1031 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001032 // Verify default codecs has been added correctly.
1033 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001034 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001035
1036 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001037 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001038 int vp8_associated_payload;
1039 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1040 &vp8_associated_payload));
1041 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1042
1043 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1044
1045 // RTX codec for RED.
1046 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1047 int red_associated_payload;
1048 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1049 &red_associated_payload));
1050 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1051
1052 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1053
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001054 int associated_payload_type;
1055 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1056 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1057 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1058 // Verify default parameters has been added to the VP8 codec.
1059 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1060
1061 // Mock encoder creation. |engine| take ownership of the encoder.
1062 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1063 codec_info.is_hardware_accelerated = false;
1064 codec_info.has_internal_source = false;
1065 const webrtc::SdpVideoFormat format("VP8");
1066 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1067 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001068 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001069 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001070 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001071 .WillOnce(
1072 ::testing::DoAll(::testing::InvokeWithoutArgs(
1073 [&encoder_created]() { encoder_created.Set(); }),
1074 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001075
1076 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001077 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001078 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1079 .WillOnce(testing::Return(decoder));
1080
1081 // Create a call.
1082 webrtc::RtcEventLogNullImpl event_log;
1083 std::unique_ptr<webrtc::Call> call(
1084 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1085
1086 // Create send channel.
1087 const int send_ssrc = 123;
1088 std::unique_ptr<VideoMediaChannel> send_channel(
1089 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1090 cricket::VideoSendParameters send_parameters;
1091 send_parameters.codecs.push_back(engine_codecs.at(0));
1092 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1093 send_channel->OnReadyToSend(true);
1094 EXPECT_TRUE(
1095 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1096 EXPECT_TRUE(send_channel->SetSend(true));
1097
Niels Möller4db138e2018-04-19 09:04:13 +02001098 // Set capturer.
1099 FakeVideoCapturerWithTaskQueue capturer;
1100 EXPECT_EQ(cricket::CS_RUNNING,
1101 capturer.Start(capturer.GetSupportedFormats()->front()));
1102 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1103 // Sending one frame will allocate the encoder.
1104 EXPECT_TRUE(capturer.CaptureFrame());
1105 encoder_created.Wait(kTimeout);
1106
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001107 // Create recv channel.
1108 const int recv_ssrc = 321;
1109 std::unique_ptr<VideoMediaChannel> recv_channel(
1110 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1111 cricket::VideoRecvParameters recv_parameters;
1112 recv_parameters.codecs.push_back(engine_codecs.at(0));
1113 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1114 EXPECT_TRUE(recv_channel->AddRecvStream(
1115 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1116
1117 // Remove streams previously added to free the encoder and decoder instance.
1118 EXPECT_CALL(*encoder_factory, Die());
1119 EXPECT_CALL(*decoder_factory, Die());
1120 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1121 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1122}
1123
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001124// Test behavior when decoder factory fails to create a decoder (returns null).
1125TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1126 // |engine| take ownership of the factories.
1127 webrtc::MockVideoEncoderFactory* encoder_factory =
1128 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1129 webrtc::MockVideoDecoderFactory* decoder_factory =
1130 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1131 WebRtcVideoEngine engine(
1132 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1133 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1134 const webrtc::SdpVideoFormat vp8_format("VP8");
1135 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1136 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1137 .WillRepeatedly(testing::Return(supported_formats));
1138
1139 // Decoder creation fails.
1140 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1141 .WillOnce(testing::Return(nullptr));
1142
1143 // Create a call.
1144 webrtc::RtcEventLogNullImpl event_log;
1145 std::unique_ptr<webrtc::Call> call(
1146 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1147
1148 // Create recv channel.
1149 const int recv_ssrc = 321;
1150 std::unique_ptr<VideoMediaChannel> recv_channel(
1151 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1152 cricket::VideoRecvParameters recv_parameters;
1153 recv_parameters.codecs.push_back(engine.codecs().front());
1154 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1155 EXPECT_TRUE(recv_channel->AddRecvStream(
1156 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1157
1158 // Remove streams previously added to free the encoder and decoder instance.
1159 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1160}
1161
eladalonf1841382017-06-12 01:16:46 -07001162TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001163 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001164 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001165 std::unique_ptr<VideoMediaChannel> channel(
1166 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001167 ASSERT_TRUE(
1168 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1169 cricket::VideoCodec codec = GetEngineCodec("VP8");
1170 cricket::VideoSendParameters parameters;
1171 parameters.codecs.push_back(codec);
1172 channel->OnReadyToSend(true);
1173 channel->SetSend(true);
1174 ASSERT_TRUE(channel->SetSendParameters(parameters));
1175
Tommi85959932018-02-07 19:26:06 +01001176 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001177 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001178 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001179
1180 EXPECT_EQ(cricket::CS_RUNNING,
1181 capturer.Start(capturer.GetSupportedFormats()->front()));
1182 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001183 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001184 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001185 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001186
Niels Möllerff40b142018-04-09 08:49:14 +02001187 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001188 EXPECT_TRUE(capturer.CaptureFrame());
1189 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001190 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001191
1192 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001193 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001194 EXPECT_TRUE(capturer.CaptureFrame());
1195 // Change to screen content, recreate encoder. For the simulcast encoder
1196 // adapter case, this will result in two calls since InitEncode triggers a
1197 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001198 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001199 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001200 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001201
Niels Möllerff40b142018-04-09 08:49:14 +02001202 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001203 EXPECT_TRUE(capturer.CaptureFrame());
1204 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001205 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001206
1207 options.is_screencast.emplace(false);
1208 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001209 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001210 // Change back to regular video content, update encoder. Also change
1211 // a non |is_screencast| option just to verify it doesn't affect recreation.
1212 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001213 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001214 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001215 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001216
1217 // Remove stream previously added to free the external encoder instance.
1218 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001219 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001220}
1221
Niels Möller6557d0c2018-04-11 15:18:34 +02001222class WebRtcVideoChannelBaseTest : public testing::Test {
1223 protected:
1224 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001225 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001226 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001227
1228 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001229 // One testcase calls SetUp in a loop, only create call_ once.
1230 if (!call_) {
1231 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1232 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001233 cricket::MediaConfig media_config;
1234 // Disabling cpu overuse detection actually disables quality scaling too; it
1235 // implies DegradationPreference kMaintainResolution. Automatic scaling
1236 // needs to be disabled, otherwise, tests which check the size of received
1237 // frames become flaky.
1238 media_config.video.enable_cpu_adaptation = false;
1239 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
1240 cricket::VideoOptions()));
1241 channel_->OnReadyToSend(true);
1242 EXPECT_TRUE(channel_.get() != NULL);
1243 network_interface_.SetDestination(channel_.get());
1244 channel_->SetInterface(&network_interface_);
1245 cricket::VideoRecvParameters parameters;
1246 parameters.codecs = engine_.codecs();
1247 channel_->SetRecvParameters(parameters);
1248 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1249 video_capturer_.reset(CreateFakeVideoCapturer());
1250 cricket::VideoFormat format(640, 480,
1251 cricket::VideoFormat::FpsToInterval(kFramerate),
1252 cricket::FOURCC_I420);
1253 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001254 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001255 }
1256
1257 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1258 return new cricket::FakeVideoCapturerWithTaskQueue();
1259 }
1260
1261 // Utility method to setup an additional stream to send and receive video.
1262 // Used to test send and recv between two streams.
1263 void SetUpSecondStream() {
1264 SetUpSecondStreamWithNoRecv();
1265 // Setup recv for second stream.
1266 EXPECT_TRUE(channel_->AddRecvStream(
1267 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1268 // Make the second renderer available for use by a new stream.
1269 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1270 }
1271 // Setup an additional stream just to send video. Defer add recv stream.
1272 // This is required if you want to test unsignalled recv of video rtp packets.
1273 void SetUpSecondStreamWithNoRecv() {
1274 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001275 EXPECT_TRUE(
1276 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001277 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001278 EXPECT_FALSE(
1279 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001280 EXPECT_TRUE(channel_->AddSendStream(
1281 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1282 // We dont add recv for the second stream.
1283
1284 // Setup the receive and renderer for second stream after send.
1285 video_capturer_2_.reset(CreateFakeVideoCapturer());
1286 cricket::VideoFormat format(640, 480,
1287 cricket::VideoFormat::FpsToInterval(kFramerate),
1288 cricket::FOURCC_I420);
1289 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1290
Yves Gerey665174f2018-06-19 15:03:05 +02001291 EXPECT_TRUE(
1292 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001293 }
Yves Gerey665174f2018-06-19 15:03:05 +02001294 virtual void TearDown() { channel_.reset(); }
1295 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001296
1297 bool SetOneCodec(const cricket::VideoCodec& codec) {
1298 cricket::VideoFormat capture_format(
1299 kVideoWidth, kVideoHeight,
1300 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1301
1302 if (video_capturer_) {
1303 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1304 }
1305 if (video_capturer_2_) {
1306 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1307 }
1308
1309 bool sending = channel_->sending();
1310 bool success = SetSend(false);
1311 if (success) {
1312 cricket::VideoSendParameters parameters;
1313 parameters.codecs.push_back(codec);
1314 success = channel_->SetSendParameters(parameters);
1315 }
1316 if (success) {
1317 success = SetSend(sending);
1318 }
1319 return success;
1320 }
Yves Gerey665174f2018-06-19 15:03:05 +02001321 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001322 bool SendFrame() {
1323 if (video_capturer_2_) {
1324 video_capturer_2_->CaptureFrame();
1325 }
1326 return video_capturer_.get() && video_capturer_->CaptureFrame();
1327 }
1328 bool WaitAndSendFrame(int wait_ms) {
1329 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1330 ret &= SendFrame();
1331 return ret;
1332 }
Yves Gerey665174f2018-06-19 15:03:05 +02001333 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001334 int NumRtpBytes(uint32_t ssrc) {
1335 return network_interface_.NumRtpBytes(ssrc);
1336 }
Yves Gerey665174f2018-06-19 15:03:05 +02001337 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001338 int NumRtpPackets(uint32_t ssrc) {
1339 return network_interface_.NumRtpPackets(ssrc);
1340 }
Yves Gerey665174f2018-06-19 15:03:05 +02001341 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001342 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1343 return network_interface_.GetRtpPacket(index);
1344 }
1345 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001346 webrtc::RTPHeader header;
1347 EXPECT_TRUE(ParseRtpPacket(p, &header));
1348 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001349 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001350
Niels Möller6557d0c2018-04-11 15:18:34 +02001351 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001352 webrtc::RTPHeader* header) {
1353 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1354 webrtc::RtpHeaderParser::Create());
1355 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001356 }
1357
1358 // Tests that we can send and receive frames.
1359 void SendAndReceive(const cricket::VideoCodec& codec) {
1360 EXPECT_TRUE(SetOneCodec(codec));
1361 EXPECT_TRUE(SetSend(true));
1362 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1363 EXPECT_EQ(0, renderer_.num_rendered_frames());
1364 EXPECT_TRUE(SendFrame());
1365 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1366 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1367 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1368 }
1369
1370 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001371 int duration_sec,
1372 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001373 EXPECT_TRUE(SetOneCodec(codec));
1374 EXPECT_TRUE(SetSend(true));
1375 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1376 EXPECT_EQ(0, renderer_.num_rendered_frames());
1377 for (int i = 0; i < duration_sec; ++i) {
1378 for (int frame = 1; frame <= fps; ++frame) {
1379 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1380 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1381 }
1382 }
1383 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1384 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1385 }
1386
Niels Möller6557d0c2018-04-11 15:18:34 +02001387 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1388 cricket::VideoMediaInfo info;
1389 EXPECT_TRUE(channel_->GetStats(&info));
1390 return info.senders[i];
1391 }
1392
1393 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1394 cricket::VideoMediaInfo info;
1395 EXPECT_TRUE(channel_->GetStats(&info));
1396 return info.receivers[i];
1397 }
1398
1399 // Two streams one channel tests.
1400
1401 // Tests that we can send and receive frames.
1402 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1403 SetUpSecondStream();
1404 // Test sending and receiving on first stream.
1405 SendAndReceive(codec);
1406 // Test sending and receiving on second stream.
1407 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1408 EXPECT_GT(NumRtpPackets(), 0);
1409 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1410 }
1411
1412 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1413 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
1414 if (CodecNamesEq(name, engine_codec.name))
1415 return engine_codec;
1416 }
1417 // This point should never be reached.
1418 ADD_FAILURE() << "Unrecognized codec name: " << name;
1419 return cricket::VideoCodec();
1420 }
1421
1422 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1423
1424 cricket::StreamParams DefaultSendStreamParams() {
1425 return cricket::StreamParams::CreateLegacy(kSsrc);
1426 }
1427
1428 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001429 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001430 WebRtcVideoEngine engine_;
1431 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1432 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1433 std::unique_ptr<WebRtcVideoChannel> channel_;
1434 cricket::FakeNetworkInterface network_interface_;
1435 cricket::FakeVideoRenderer renderer_;
1436
1437 // Used by test cases where 2 streams are run on the same channel.
1438 cricket::FakeVideoRenderer renderer2_;
1439};
1440
1441// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001442TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001443 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001444 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001445 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1446 EXPECT_FALSE(channel_->sending());
1447 EXPECT_TRUE(SetSend(true));
1448 EXPECT_TRUE(channel_->sending());
1449 EXPECT_TRUE(SendFrame());
1450 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1451 EXPECT_TRUE(SetSend(false));
1452 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001453}
Niels Möller6557d0c2018-04-11 15:18:34 +02001454
1455// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001456TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001457 EXPECT_FALSE(channel_->sending());
1458 EXPECT_FALSE(SetSend(true));
1459 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001460}
Niels Möller6557d0c2018-04-11 15:18:34 +02001461
1462// Test that we properly set the send and recv buffer sizes by the time
1463// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001464TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001465 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1466 EXPECT_TRUE(SetSend(true));
1467 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1468 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
srtee0c2eea2017-12-15 17:44:33 +01001469}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001470
Erik Språng820ebd02018-08-20 17:14:25 +02001471// Test that we properly set the send and recv buffer sizes when overriding
1472// via field trials.
1473TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1474 // Set field trial to override the default recv buffer size, and then re-run
1475 // setup where the interface is created and configured.
1476 const int kCustomRecvBufferSize = 123456;
1477 webrtc::test::ScopedFieldTrials field_trial(
1478 "WebRTC-IncreasedReceivebuffers/123456/");
1479 SetUp();
1480
1481 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1482 EXPECT_TRUE(SetSend(true));
1483 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1484 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1485}
1486
1487// Test that we properly set the send and recv buffer sizes when overriding
1488// via field trials with suffix.
1489TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1490 // Set field trial to override the default recv buffer size, and then re-run
1491 // setup where the interface is created and configured.
1492 const int kCustomRecvBufferSize = 123456;
1493 webrtc::test::ScopedFieldTrials field_trial(
1494 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1495 SetUp();
1496
1497 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1498 EXPECT_TRUE(SetSend(true));
1499 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1500 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1501}
1502
1503// Test that we properly set the send and recv buffer sizes when overriding
1504// via field trials that don't make any sense.
1505TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1506 // Set bogus field trial values to override the default recv buffer size, and
1507 // then re-run setup where the interface is created and configured. The
1508 // default value should still be used.
1509
1510 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1511 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1512 field_trial_string += group;
1513 field_trial_string += "/";
1514 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1515 SetUp();
1516
1517 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1518 EXPECT_TRUE(SetSend(true));
1519 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1520 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
1521 }
1522}
1523
Niels Möller6557d0c2018-04-11 15:18:34 +02001524// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001525TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001526 const int kDurationSec = 3;
1527 const int kFps = 10;
1528 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1529
1530 cricket::VideoMediaInfo info;
1531 EXPECT_TRUE(channel_->GetStats(&info));
1532
1533 ASSERT_EQ(1U, info.senders.size());
1534 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1535 // For webrtc, bytes_sent does not include the RTP header length.
1536 EXPECT_GT(info.senders[0].bytes_sent, 0);
1537 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1538 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1539 ASSERT_TRUE(info.senders[0].codec_payload_type);
1540 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1541 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1542 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1543 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1544 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1545 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1546 EXPECT_GT(info.senders[0].framerate_input, 0);
1547 EXPECT_GT(info.senders[0].framerate_sent, 0);
1548
1549 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1550 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1551 info.send_codecs[DefaultCodec().id]);
1552
1553 ASSERT_EQ(1U, info.receivers.size());
1554 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1555 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1556 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1557 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1558 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1559 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1560 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1561 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1562 EXPECT_EQ(0, info.receivers[0].packets_lost);
1563 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1564 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1565 EXPECT_EQ(0, info.receivers[0].firs_sent);
1566 EXPECT_EQ(0, info.receivers[0].plis_sent);
1567 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1568 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1569 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1570 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1571 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1572 EXPECT_GT(info.receivers[0].framerate_output, 0);
1573
1574 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1575 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1576 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001577}
Niels Möller6557d0c2018-04-11 15:18:34 +02001578
1579// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001580TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001581 cricket::FakeVideoRenderer renderer1, renderer2;
1582 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1583 cricket::VideoSendParameters parameters;
1584 parameters.codecs.push_back(DefaultCodec());
1585 parameters.conference_mode = true;
1586 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1587 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001588 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1589 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001590 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1591 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1592 EXPECT_EQ(0, renderer1.num_rendered_frames());
1593 EXPECT_EQ(0, renderer2.num_rendered_frames());
1594 std::vector<uint32_t> ssrcs;
1595 ssrcs.push_back(1);
1596 ssrcs.push_back(2);
1597 network_interface_.SetConferenceMode(true, ssrcs);
1598 EXPECT_TRUE(SendFrame());
1599 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1600 kTimeout);
1601 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1602 kTimeout);
1603
1604 EXPECT_TRUE(channel_->SetSend(false));
1605
1606 cricket::VideoMediaInfo info;
1607 EXPECT_TRUE(channel_->GetStats(&info));
1608 ASSERT_EQ(1U, info.senders.size());
1609 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1610 // For webrtc, bytes_sent does not include the RTP header length.
1611 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1612 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1613 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1614 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1615
1616 ASSERT_EQ(2U, info.receivers.size());
1617 for (size_t i = 0; i < info.receivers.size(); ++i) {
1618 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1619 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1620 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001621 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001622 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1623 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1624 }
srtee0c2eea2017-12-15 17:44:33 +01001625}
Niels Möller6557d0c2018-04-11 15:18:34 +02001626
1627// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001628TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001629 // Normal setup; note that we set the SSRC explicitly to ensure that
1630 // it will come first in the senders map.
1631 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1632 cricket::VideoSendParameters parameters;
1633 parameters.codecs.push_back(DefaultCodec());
1634 parameters.conference_mode = true;
1635 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001636 EXPECT_TRUE(
1637 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001638 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1639 EXPECT_TRUE(SetSend(true));
1640 EXPECT_TRUE(SendFrame());
1641 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1642 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1643
1644 // Add an additional capturer, and hook up a renderer to receive it.
1645 cricket::FakeVideoRenderer renderer2;
1646 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1647 CreateFakeVideoCapturer());
1648 const int kTestWidth = 160;
1649 const int kTestHeight = 120;
1650 cricket::VideoFormat format(kTestWidth, kTestHeight,
1651 cricket::VideoFormat::FpsToInterval(5),
1652 cricket::FOURCC_I420);
1653 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001654 EXPECT_TRUE(
1655 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001656 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001657 EXPECT_TRUE(
1658 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001659 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1660 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001661 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1662 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001663
1664 // Get stats, and make sure they are correct for two senders. We wait until
1665 // the number of expected packets have been sent to avoid races where we
1666 // check stats before it has been updated.
1667 cricket::VideoMediaInfo info;
1668 for (uint32_t i = 0; i < kTimeout; ++i) {
1669 rtc::Thread::Current()->ProcessMessages(1);
1670 EXPECT_TRUE(channel_->GetStats(&info));
1671 ASSERT_EQ(2U, info.senders.size());
1672 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1673 NumRtpPackets()) {
1674 // Stats have been updated for both sent frames, expectations can be
1675 // checked now.
1676 break;
1677 }
1678 }
1679 EXPECT_EQ(NumRtpPackets(),
1680 info.senders[0].packets_sent + info.senders[1].packets_sent)
1681 << "Timed out while waiting for packet counts for all sent packets.";
1682 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1683 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1684 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1685 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1686 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1687 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1688 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1689 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1690 // The capturer must be unregistered here as it runs out of it's scope next.
1691 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001692}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001693
Niels Möller6557d0c2018-04-11 15:18:34 +02001694// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001695TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001696 cricket::VideoSendParameters parameters;
1697 parameters.codecs.push_back(DefaultCodec());
1698 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1699 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1700 parameters.max_bandwidth_bps = 128 * 1024;
1701 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001702}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001703
Niels Möller6557d0c2018-04-11 15:18:34 +02001704// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001705TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001706 EXPECT_TRUE(SetDefaultCodec());
1707 EXPECT_TRUE(SetSend(true));
1708 EXPECT_TRUE(SendFrame());
1709 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001710 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001711 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001712 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1713 EXPECT_EQ(kSsrc, header.ssrc);
1714
Niels Möller6557d0c2018-04-11 15:18:34 +02001715 // Packets are being paced out, so these can mismatch between the first and
1716 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001717 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1718 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001719 EXPECT_EQ(1, NumSentSsrcs());
1720 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1721 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001722}
Niels Möller6557d0c2018-04-11 15:18:34 +02001723
1724// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001725TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001726 // Remove stream added in Setup.
1727 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1728 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001729 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001730 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1731 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001732 EXPECT_TRUE(SetSend(true));
1733 EXPECT_TRUE(WaitAndSendFrame(0));
1734 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001735 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001736 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001737 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1738 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001739 // Packets are being paced out, so these can mismatch between the first and
1740 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001741 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1742 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001743 EXPECT_EQ(1, NumSentSsrcs());
1744 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1745 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001746}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001747
Niels Möller6557d0c2018-04-11 15:18:34 +02001748// Test that we can set the default video renderer before and after
1749// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001750TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001751 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1752 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001753
1754 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1755 rtc::SetBE32(packet1.data() + 8, kSsrc);
1756 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1757 EXPECT_TRUE(SetDefaultCodec());
1758 EXPECT_TRUE(SetSend(true));
1759 EXPECT_EQ(0, renderer_.num_rendered_frames());
1760 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1761 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1762 EXPECT_TRUE(SendFrame());
1763 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001764}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001765
Niels Möller6557d0c2018-04-11 15:18:34 +02001766// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001767TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001768 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1769 EXPECT_TRUE(SetSend(true));
1770 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1771 EXPECT_TRUE(SendFrame());
1772 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1773 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001774 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001775 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001776 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1777 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001778 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1779 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001780
1781 // Remove the send stream that was added during Setup.
1782 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1783 int rtp_packets = NumRtpPackets();
1784
Niels Möller6557d0c2018-04-11 15:18:34 +02001785 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001786 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1787 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001788 EXPECT_EQ(rtp_packets, NumRtpPackets());
1789 // Wait 30ms to guarantee the engine does not drop the frame.
1790 EXPECT_TRUE(WaitAndSendFrame(30));
1791 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1792
1793 last_packet = NumRtpPackets() - 1;
1794 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001795 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1796 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001797}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001798
Niels Möller6557d0c2018-04-11 15:18:34 +02001799// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001800TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001801 cricket::FakeVideoRenderer renderer1, renderer2;
1802 EXPECT_TRUE(SetDefaultCodec());
1803 cricket::VideoSendParameters parameters;
1804 parameters.codecs.push_back(DefaultCodec());
1805 parameters.conference_mode = true;
1806 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1807 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001808 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1809 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001810 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1811 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1812 EXPECT_EQ(0, renderer1.num_rendered_frames());
1813 EXPECT_EQ(0, renderer2.num_rendered_frames());
1814 std::vector<uint32_t> ssrcs;
1815 ssrcs.push_back(1);
1816 ssrcs.push_back(2);
1817 network_interface_.SetConferenceMode(true, ssrcs);
1818 EXPECT_TRUE(SendFrame());
1819 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1820 kTimeout);
1821 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1822 kTimeout);
1823
1824 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1825 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1826 EXPECT_EQ(kVideoWidth, renderer1.width());
1827 EXPECT_EQ(kVideoHeight, renderer1.height());
1828 EXPECT_EQ(kVideoWidth, renderer2.width());
1829 EXPECT_EQ(kVideoHeight, renderer2.height());
1830 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1831 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001832}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001833
Niels Möller6557d0c2018-04-11 15:18:34 +02001834// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001835TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001836 using cricket::VideoCodec;
1837 using cricket::VideoOptions;
1838 using cricket::VideoFormat;
1839 using cricket::FOURCC_I420;
1840
1841 VideoCodec codec = DefaultCodec();
1842 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1843 EXPECT_TRUE(SetOneCodec(codec));
1844 EXPECT_TRUE(SetSend(true));
1845 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1846 EXPECT_EQ(0, renderer_.num_rendered_frames());
1847 EXPECT_TRUE(SendFrame());
1848 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1849 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1850 CreateFakeVideoCapturer());
1851
1852 // TODO(nisse): This testcase fails if we don't configure
1853 // screencast. It's unclear why, I see nothing obvious in this
1854 // test which is related to screencast logic.
1855 VideoOptions video_options;
1856 video_options.is_screencast = true;
1857 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1858
1859 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1860 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1861 // All capturers start generating frames with the same timestamp. ViE does
1862 // not allow the same timestamp to be used. Capture one frame before
1863 // associating the capturer with the channel.
1864 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1865
1866 int captured_frames = 1;
1867 for (int iterations = 0; iterations < 2; ++iterations) {
1868 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1869 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1870 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1871 ++captured_frames;
1872 // Wait until frame of right size is captured.
1873 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001874 format.width == renderer_.width() &&
1875 format.height == renderer_.height() &&
1876 !renderer_.black_frame(),
1877 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001878 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1879 EXPECT_EQ(format.width, renderer_.width());
1880 EXPECT_EQ(format.height, renderer_.height());
1881 captured_frames = renderer_.num_rendered_frames() + 1;
1882 EXPECT_FALSE(renderer_.black_frame());
1883 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1884 // Make sure a black frame is generated within the specified timeout.
1885 // The black frame should be the resolution of the previous frame to
1886 // prevent expensive encoder reconfigurations.
1887 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001888 format.width == renderer_.width() &&
1889 format.height == renderer_.height() &&
1890 renderer_.black_frame(),
1891 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001892 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1893 EXPECT_EQ(format.width, renderer_.width());
1894 EXPECT_EQ(format.height, renderer_.height());
1895 EXPECT_TRUE(renderer_.black_frame());
1896
1897 // The black frame has the same timestamp as the next frame since it's
1898 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1899 // not render a frame with the same timestamp so capture another frame
1900 // with the frame capturer to increment the next frame's timestamp.
1901 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1902 }
srtee0c2eea2017-12-15 17:44:33 +01001903}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001904
Niels Möller6557d0c2018-04-11 15:18:34 +02001905// Tests that if SetVideoSend is called with a NULL capturer after the
1906// capturer was already removed, the application doesn't crash (and no black
1907// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001908TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001909 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1910 EXPECT_TRUE(SetSend(true));
1911 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1912 EXPECT_EQ(0, renderer_.num_rendered_frames());
1913 EXPECT_TRUE(SendFrame());
1914 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1915 // Wait for one frame so they don't get dropped because we send frames too
1916 // tightly.
1917 rtc::Thread::Current()->ProcessMessages(30);
1918 // Remove the capturer.
1919 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1920
1921 // No capturer was added, so this SetVideoSend shouldn't do anything.
1922 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1923 rtc::Thread::Current()->ProcessMessages(300);
1924 // Verify no more frames were sent.
1925 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001926}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001927
Niels Möller6557d0c2018-04-11 15:18:34 +02001928// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001929TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001930 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1931 // interval time to avoid that.
1932 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1933 // interval time to avoid that.
1934 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001935 EXPECT_TRUE(
1936 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001937 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1938 cricket::VideoFormat capture_format(
1939 kVideoWidth, kVideoHeight,
1940 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1941 // Set up additional stream 1.
1942 cricket::FakeVideoRenderer renderer1;
1943 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001944 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001945 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001946 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001947 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1948 CreateFakeVideoCapturer());
1949 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1950 // Set up additional stream 2.
1951 cricket::FakeVideoRenderer renderer2;
1952 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001953 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001954 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001955 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001956 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1957 CreateFakeVideoCapturer());
1958 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1959 // State for all the streams.
1960 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1961 // A limitation in the lmi implementation requires that SetVideoSend() is
1962 // called after SetOneCodec().
1963 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1964 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1965 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1966 EXPECT_TRUE(SetSend(true));
1967 // Test capturer associated with engine.
1968 const int kTestWidth = 160;
1969 const int kTestHeight = 120;
1970 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001971 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1972 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001973 // Capture a frame with additional capturer2, frames should be received
1974 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001975 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1976 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001977 // Successfully remove the capturer.
1978 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1979 // The capturers must be unregistered here as it runs out of it's scope
1980 // next.
1981 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1982 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001983}
Niels Möller6557d0c2018-04-11 15:18:34 +02001984
1985// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001986TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001987 // Remove the send stream that was added during Setup.
1988 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1989
1990 cricket::StreamParams empty;
1991 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001992 EXPECT_TRUE(
1993 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001994}
Niels Möller6557d0c2018-04-11 15:18:34 +02001995
1996// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001997TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001998 // Remove stream added in Setup. I.e. remove stream corresponding to default
1999 // channel.
2000 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002001 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002002 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2003 EXPECT_TRUE(channel_->AddSendStream(
2004 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2005 }
2006 // Delete one of the non default channel streams, let the destructor delete
2007 // the remaining ones.
2008 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2009 // Stream should already be deleted.
2010 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002011}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002012
eladalonf1841382017-06-12 01:16:46 -07002013TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002014 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002015}
2016
eladalonf1841382017-06-12 01:16:46 -07002017TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002018 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002019}
2020
eladalonf1841382017-06-12 01:16:46 -07002021TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002022 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002023}
2024
eladalonf1841382017-06-12 01:16:46 -07002025TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002026 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2027 // bitrates. This currently happens at <250k, and two streams sharing 300k
2028 // initially will use QVGA instead of VGA.
2029 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2030 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002031 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002032 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002033 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002034}
2035
eladalonf1841382017-06-12 01:16:46 -07002036class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002037 public:
eladalonf1841382017-06-12 01:16:46 -07002038 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2039 explicit WebRtcVideoChannelTest(const char* field_trials)
2040 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002041 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002042 encoder_factory_->AddSupportedVideoCodecType("VP8");
2043 encoder_factory_->AddSupportedVideoCodecType("VP9");
2044#if defined(WEBRTC_USE_H264)
2045 encoder_factory_->AddSupportedVideoCodecType("H264");
2046#endif
2047
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002048 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08002049 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
2050 VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002051 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002052 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002053 send_parameters_.codecs = engine_.codecs();
2054 recv_parameters_.codecs = engine_.codecs();
2055 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002056 }
2057
2058 protected:
2059 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002060 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002061 }
2062
2063 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002064 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002065 EXPECT_TRUE(channel_->AddSendStream(sp));
2066 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002067 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002068 EXPECT_EQ(num_streams + 1, streams.size());
2069 return streams[streams.size() - 1];
2070 }
2071
2072 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002073 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002074 }
2075
2076 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002077 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002078 }
2079
2080 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002081 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002082 EXPECT_TRUE(channel_->AddRecvStream(sp));
2083 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002084 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002085 EXPECT_EQ(num_streams + 1, streams.size());
2086 return streams[streams.size() - 1];
2087 }
2088
pbos@webrtc.org00873182014-11-25 14:03:34 +00002089 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2090 int expected_min_bitrate_bps,
2091 const char* start_bitrate_kbps,
2092 int expected_start_bitrate_bps,
2093 const char* max_bitrate_kbps,
2094 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002095 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2096 expected_start_bitrate_bps,
2097 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002098 auto& codecs = send_parameters_.codecs;
2099 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002100 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002101 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2102 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2103 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002104 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002105 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002106
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002107 void ExpectSetBitrateParameters(int min_bitrate_bps,
2108 int start_bitrate_bps,
2109 int max_bitrate_bps) {
2110 EXPECT_CALL(
2111 *fake_call_->GetMockTransportControllerSend(),
2112 SetSdpBitrateParameters(AllOf(
2113 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2114 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2115 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2116 }
2117
2118 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2119 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2120 SetSdpBitrateParameters(Field(
2121 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002122 }
2123
isheriff6f8d6862016-05-26 11:24:55 -07002124 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002125 // Enable extension.
2126 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002127 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002128 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002129 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002130 FakeVideoSendStream* send_stream =
2131 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2132
2133 // Verify the send extension id.
2134 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2135 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002136 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002137 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002138 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002139 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2140 // receivers.
2141 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2142 ->GetConfig()
2143 .rtp.extensions.empty());
2144
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002145 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002146 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002147 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2148 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002149 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2150
2151 // Verify that adding receive RTP header extensions adds them for existing
2152 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002153 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002154 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002155 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2156 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002157 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002158 }
2159
isheriff6f8d6862016-05-26 11:24:55 -07002160 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002161 // Enable extension.
2162 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002163 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002164 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002165 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002166
2167 FakeVideoReceiveStream* recv_stream =
2168 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2169
2170 // Verify the recv extension id.
2171 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2172 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002173 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002174 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002175 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002176
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002177 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2178 // senders.
2179 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2180 ->GetConfig()
2181 .rtp.extensions.empty());
2182
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002183 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002184 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002185 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2186 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002187 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2188
2189 // Verify that adding receive RTP header extensions adds them for existing
2190 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002191 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002192 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002193 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2194 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002195 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002196 }
2197
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002198 void TestExtensionFilter(const std::vector<std::string>& extensions,
2199 const std::string& expected_extension) {
2200 cricket::VideoSendParameters parameters = send_parameters_;
2201 int expected_id = -1;
2202 int id = 1;
2203 for (const std::string& extension : extensions) {
2204 if (extension == expected_extension)
2205 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002206 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002207 }
2208 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2209 FakeVideoSendStream* send_stream =
2210 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2211
2212 // Verify that only one of them has been set, and that it is the one with
2213 // highest priority (transport sequence number).
2214 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2215 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2216 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002217 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002218 }
2219
asapersson3c81a1a2017-06-14 05:52:21 -07002220 void TestDegradationPreference(bool resolution_scaling_enabled,
2221 bool fps_scaling_enabled);
2222
Erik Språngefbde372015-04-29 16:21:28 +02002223 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002224 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002225 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2226 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002227
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002228 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002229 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002230 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002231 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002232 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002233 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002234 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002235 // Options only take effect on the next frame.
2236 EXPECT_TRUE(capturer->CaptureFrame());
2237
Erik Språng143cec12015-04-28 10:01:41 +02002238 return fake_call_->GetVideoSendStreams().back();
2239 }
2240
Peter Boström2feafdb2015-09-09 14:32:14 +02002241 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2242 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002243 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002244 std::vector<uint32_t> ssrcs;
2245 std::vector<uint32_t> rtx_ssrcs;
2246 uint32_t num_streams = enabled ? 3 : 1;
2247 for (uint32_t i = 0; i < num_streams; ++i) {
2248 uint32_t ssrc = last_ssrc_ + i;
2249 ssrcs.push_back(ssrc);
2250 if (with_rtx) {
2251 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2252 }
Erik Språng143cec12015-04-28 10:01:41 +02002253 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002254 if (with_rtx) {
2255 return AddSendStream(
2256 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2257 }
2258 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002259 }
2260
perkjfa10b552016-10-02 23:45:26 -07002261 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002262 std::vector<FakeVideoSendStream*> streams =
2263 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002264 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002265 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002266 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002267 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002268 }
2269
perkjfa10b552016-10-02 23:45:26 -07002270 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002271 int stream_max,
2272 int expected_encoder_bitrate) {
2273 VideoSendParameters limited_send_params = send_parameters_;
2274 limited_send_params.max_bandwidth_bps = global_max;
2275 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002276 webrtc::RtpParameters parameters =
2277 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002278 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002279 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002280 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002281 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002282 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002283 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002284 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002285 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002286 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002287 }
2288
Åsa Persson55659812018-06-18 17:51:32 +02002289 // Values from kSimulcastConfigs in simulcast.cc.
2290 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2291 std::vector<webrtc::VideoStream> layers(3);
2292 layers[0].min_bitrate_bps = 30000;
2293 layers[0].target_bitrate_bps = 150000;
2294 layers[0].max_bitrate_bps = 200000;
2295 layers[1].min_bitrate_bps = 150000;
2296 layers[1].target_bitrate_bps = 500000;
2297 layers[1].max_bitrate_bps = 700000;
2298 layers[2].min_bitrate_bps = 600000;
2299 layers[2].target_bitrate_bps = 2500000;
2300 layers[2].max_bitrate_bps = 2500000;
2301 return layers;
2302 }
2303
kwiberg686a8ef2016-02-26 03:00:35 -08002304 std::unique_ptr<FakeCall> fake_call_;
2305 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002306 cricket::VideoSendParameters send_parameters_;
2307 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002308 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002309};
2310
eladalonf1841382017-06-12 01:16:46 -07002311TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002312 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002313 const std::string kSyncLabel = "AvSyncLabel";
2314
2315 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002316 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002317 EXPECT_TRUE(channel_->AddRecvStream(sp));
2318
Mirko Bonadeif859e552018-05-30 15:31:29 +02002319 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002320 EXPECT_EQ(kSyncLabel,
2321 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2322 << "SyncGroup should be set based on sync_label";
2323}
2324
eladalonf1841382017-06-12 01:16:46 -07002325TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002326 cricket::VideoSendParameters parameters;
2327 parameters.codecs = engine_.codecs();
2328 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002329 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002330 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002331 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002332
2333 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002334 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2335 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002336 FakeVideoSendStream* send_stream = AddSendStream(
2337 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2338
2339 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2340 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2341 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2342
2343 // Receiver side.
2344 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2345 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002346 EXPECT_FALSE(
2347 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002348 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002349 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002350 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002351 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002352 << "RTX should be mapped for the RED payload type";
2353
brandtr14742122017-01-27 04:53:07 -08002354 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002355}
2356
eladalonf1841382017-06-12 01:16:46 -07002357TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002358 // Setup one channel with an associated RTX stream.
2359 cricket::StreamParams params =
2360 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2361 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2362 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002363 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002364
2365 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2366 << "RTX should be mapped for all decoders/payload types.";
2367 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002368 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002369 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002370}
2371
eladalonf1841382017-06-12 01:16:46 -07002372TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002373 // Setup one channel without an associated RTX stream.
2374 cricket::StreamParams params =
2375 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2376 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002377 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002378}
2379
eladalonf1841382017-06-12 01:16:46 -07002380TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002381 FakeVideoSendStream* send_stream =
2382 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2383 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2384
2385 FakeVideoReceiveStream* recv_stream =
2386 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2387 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002388}
2389
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002390// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002391TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002392 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002393}
isheriff6f8d6862016-05-26 11:24:55 -07002394
eladalonf1841382017-06-12 01:16:46 -07002395TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002396 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002397}
2398
2399// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002400TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002401 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002402}
isheriff6f8d6862016-05-26 11:24:55 -07002403
eladalonf1841382017-06-12 01:16:46 -07002404TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002405 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002406}
2407
eladalonf1841382017-06-12 01:16:46 -07002408TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002409 // Enable three redundant extensions.
2410 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002411 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2412 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2413 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2414 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002415}
2416
eladalonf1841382017-06-12 01:16:46 -07002417TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002418 // Enable two redundant extensions.
2419 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002420 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2421 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2422 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002423}
2424
stefanc1aeaf02015-10-15 07:26:07 -07002425// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002426TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002427 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002428}
eladalonf1841382017-06-12 01:16:46 -07002429TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002430 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002431}
2432
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002433// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002434TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002435 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002436}
eladalonf1841382017-06-12 01:16:46 -07002437TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002438 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002439}
2440
eladalonf1841382017-06-12 01:16:46 -07002441TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002442 const int kAbsSendTimeId = 1;
2443 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002444 send_parameters_.extensions.push_back(
2445 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2446 send_parameters_.extensions.push_back(
2447 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002448
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002449 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002450 FakeVideoSendStream* send_stream =
2451 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2452
2453 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002454 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002455
2456 // Setting the same extensions (even if in different order) shouldn't
2457 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002458 std::reverse(send_parameters_.extensions.begin(),
2459 send_parameters_.extensions.end());
2460 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002461
2462 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2463
2464 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002465 send_parameters_.extensions.resize(1);
2466 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002467
2468 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2469}
2470
eladalonf1841382017-06-12 01:16:46 -07002471TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002472 const int kTOffsetId = 1;
2473 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002474 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002475 recv_parameters_.extensions.push_back(
2476 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2477 recv_parameters_.extensions.push_back(
2478 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2479 recv_parameters_.extensions.push_back(
2480 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002481
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002482 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002483 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002484 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2485
2486 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002487 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002488
2489 // Setting the same extensions (even if in different order) shouldn't
2490 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002491 std::reverse(recv_parameters_.extensions.begin(),
2492 recv_parameters_.extensions.end());
2493 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002494
2495 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2496
2497 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002498 recv_parameters_.extensions.resize(1);
2499 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002500
2501 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2502}
2503
eladalonf1841382017-06-12 01:16:46 -07002504TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002505 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002506 const int kUnsupportedId = 1;
2507 const int kTOffsetId = 2;
2508
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002509 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002510 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002511 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002512 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002513 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002514 FakeVideoSendStream* send_stream =
2515 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2516
2517 // Only timestamp offset extension is set to send stream,
2518 // unsupported rtp extension is ignored.
2519 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002520 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2521 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002522}
2523
eladalonf1841382017-06-12 01:16:46 -07002524TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002525 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002526 const int kUnsupportedId = 1;
2527 const int kTOffsetId = 2;
2528
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002529 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002530 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002531 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002532 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002533 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002534 FakeVideoReceiveStream* recv_stream =
2535 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2536
2537 // Only timestamp offset extension is set to receive stream,
2538 // unsupported rtp extension is ignored.
2539 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002540 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2541 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002542}
2543
eladalonf1841382017-06-12 01:16:46 -07002544TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002545 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002546 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002547 send_parameters_.extensions.push_back(
2548 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002549 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002550 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2551 }
2552}
2553
eladalonf1841382017-06-12 01:16:46 -07002554TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002555 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002556 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002557 recv_parameters_.extensions.push_back(
2558 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002559 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002560 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2561 }
2562}
2563
eladalonf1841382017-06-12 01:16:46 -07002564TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002565 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002566 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002567 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002568 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002569 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002570 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002571
2572 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002573 send_parameters_.extensions.clear();
2574 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002575 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002576 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2577 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002578}
2579
eladalonf1841382017-06-12 01:16:46 -07002580TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002581 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002582 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002583 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002584 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002585 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002586 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002587
2588 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002589 recv_parameters_.extensions.clear();
2590 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002591 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002592 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2593 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002594}
2595
eladalonf1841382017-06-12 01:16:46 -07002596TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002597 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002598 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002599}
2600
eladalonf1841382017-06-12 01:16:46 -07002601TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002602 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002603 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002604}
2605
eladalonf1841382017-06-12 01:16:46 -07002606TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002607 FakeVideoReceiveStream* stream = AddRecvStream();
2608 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002609}
2610
eladalonf1841382017-06-12 01:16:46 -07002611TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002612 FakeVideoReceiveStream* stream = AddRecvStream();
2613 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2614}
2615
eladalonf1841382017-06-12 01:16:46 -07002616TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002617 FakeVideoReceiveStream* stream = AddRecvStream();
2618 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2619
Peter Boström126c03e2015-05-11 12:48:12 +02002620 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002621 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002622 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002623 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2624 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002625 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002626 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2627
2628 // Verify that REMB is turned on when setting default codecs since the
2629 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002630 parameters.codecs = engine_.codecs();
2631 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002632 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002633 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002634}
2635
eladalonf1841382017-06-12 01:16:46 -07002636TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002637 FakeVideoReceiveStream* stream = AddRecvStream();
2638 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2639
2640 // Verify that transport cc feedback is turned off when send(!) codecs without
2641 // transport cc feedback are set.
2642 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002643 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002644 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2645 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2646 stream = fake_call_->GetVideoReceiveStreams()[0];
2647 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2648
2649 // Verify that transport cc feedback is turned on when setting default codecs
2650 // since the default codecs have transport cc feedback enabled.
2651 parameters.codecs = engine_.codecs();
2652 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2653 stream = fake_call_->GetVideoReceiveStreams()[0];
2654 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2655}
2656
eladalonf1841382017-06-12 01:16:46 -07002657TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002658 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002659 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2660
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002661 cricket::VideoSendParameters parameters;
2662 parameters.codecs = engine_.codecs();
2663 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002664 EXPECT_TRUE(channel_->SetSend(true));
2665
2666 // Send side.
2667 FakeVideoSendStream* send_stream =
2668 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2669 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2670
2671 // Receiver side.
2672 FakeVideoReceiveStream* recv_stream =
2673 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2674 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2675
2676 // Nack history size should match between sender and receiver.
2677 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2678 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002679}
2680
eladalonf1841382017-06-12 01:16:46 -07002681TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002682 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002683 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002684
2685 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2686 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2687
2688 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002689 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002690 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002691 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2692 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002693 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2694 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2695 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002696 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2697
Peter Boström67c9df72015-05-11 14:34:58 +02002698 // Verify that NACK is turned on when setting default codecs since the
2699 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002700 parameters.codecs = engine_.codecs();
2701 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002702 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2703 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2704 send_stream = fake_call_->GetVideoSendStreams()[0];
2705 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002706}
2707
Peter Boströme7ba0862016-03-12 00:02:28 +01002708// This test verifies that new frame sizes reconfigures encoders even though not
2709// (yet) sending. The purpose of this is to permit encoding as quickly as
2710// possible once we start sending. Likely the frames being input are from the
2711// same source that will be sent later, which just means that we're ready
2712// earlier.
eladalonf1841382017-06-12 01:16:46 -07002713TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002714 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002715 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002716 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2717 channel_->SetSend(false);
2718
2719 FakeVideoSendStream* stream = AddSendStream();
2720
perkjfa10b552016-10-02 23:45:26 -07002721 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002722 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002723 EXPECT_EQ(0u, streams[0].width);
2724 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002725
Tommi85959932018-02-07 19:26:06 +01002726 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002727 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002728 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2729 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002730 EXPECT_TRUE(capturer.CaptureFrame());
2731
2732 // Frame entered, should be reconfigured to new dimensions.
2733 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002734 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2735 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2736 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002737
Niels Möllerff40b142018-04-09 08:49:14 +02002738 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002739}
2740
eladalonf1841382017-06-12 01:16:46 -07002741TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002742 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002743 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002744 cricket::VideoSendParameters parameters;
2745 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002746 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002747 AddSendStream();
2748
Tommi85959932018-02-07 19:26:06 +01002749 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002750 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002751 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002752 EXPECT_TRUE(
2753 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002754 cricket::VideoFormat capture_format_hd =
2755 capturer.GetSupportedFormats()->front();
2756 EXPECT_EQ(1280, capture_format_hd.width);
2757 EXPECT_EQ(720, capture_format_hd.height);
2758 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2759
2760 EXPECT_TRUE(channel_->SetSend(true));
2761
2762 EXPECT_TRUE(capturer.CaptureFrame());
2763 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2764 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2765
2766 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2767
2768 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002769 webrtc::VideoEncoderConfig encoder_config =
2770 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002771 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002772 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002773 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002774 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2775 streams.front().width);
2776 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2777 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002778 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2779 << "Non-screenshare shouldn't use min-transmit bitrate.";
2780
Niels Möllerff40b142018-04-09 08:49:14 +02002781 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002782 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002783 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002784 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002785 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002786 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002787 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002788 // Send stream recreated after option change.
2789 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2790 send_stream = fake_call_->GetVideoSendStreams().front();
2791 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002792
2793 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002794 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002795 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002796 encoder_config.content_type);
2797 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2798 encoder_config.min_transmit_bitrate_bps);
2799
perkjfa10b552016-10-02 23:45:26 -07002800 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002801 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2802 streams.front().width);
2803 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2804 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002805 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002806 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002807}
2808
eladalonf1841382017-06-12 01:16:46 -07002809TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002810 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002811 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002812 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002813 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002814
2815 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002816 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002817 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002818 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002819 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002820 cricket::VideoFormat capture_format_hd =
2821 capturer.GetSupportedFormats()->front();
2822 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2823
2824 EXPECT_TRUE(channel_->SetSend(true));
2825
2826 EXPECT_TRUE(capturer.CaptureFrame());
2827 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2828 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2829
perkj26091b12016-09-01 01:17:40 -07002830 webrtc::VideoEncoderConfig encoder_config =
2831 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002832
2833 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002834 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002835 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002836 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002837
2838 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2839 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002840 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002841 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002842 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002843
Niels Möllerff40b142018-04-09 08:49:14 +02002844 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002845}
2846
eladalonf1841382017-06-12 01:16:46 -07002847TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002848 FakeVideoSendStream* stream = AddSendStream();
2849 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2850}
2851
eladalonf1841382017-06-12 01:16:46 -07002852TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002853 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002854 media_config.video.suspend_below_min_bitrate = true;
2855
2856 channel_.reset(
2857 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002858 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002859
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002860 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002861
2862 FakeVideoSendStream* stream = AddSendStream();
2863 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2864
nisse0db023a2016-03-01 04:29:59 -08002865 media_config.video.suspend_below_min_bitrate = false;
2866 channel_.reset(
2867 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002868 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002869
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002870 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002871
nisse0db023a2016-03-01 04:29:59 -08002872 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002873 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2874}
2875
eladalonf1841382017-06-12 01:16:46 -07002876TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002877 FakeVideoSendStream* stream = AddSendStream();
2878 webrtc::VideoCodecVP8 vp8_settings;
2879 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2880 EXPECT_TRUE(vp8_settings.denoisingOn);
2881}
2882
eladalonf1841382017-06-12 01:16:46 -07002883TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002884 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002885 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002886 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002887
Peter Boström2feafdb2015-09-09 14:32:14 +02002888 // Single-stream settings should apply with RTX as well (verifies that we
2889 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2890 // both RTX and regular SSRCs).
2891 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002892
Tommi85959932018-02-07 19:26:06 +01002893 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002894 EXPECT_EQ(cricket::CS_RUNNING,
2895 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002896 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002897 channel_->SetSend(true);
2898
2899 EXPECT_TRUE(capturer.CaptureFrame());
2900
pbos4cba4eb2015-10-26 11:18:18 -07002901 webrtc::VideoCodecVP8 vp8_settings;
2902 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2903 EXPECT_TRUE(vp8_settings.denoisingOn)
2904 << "VP8 denoising should be on by default.";
2905
nisse05103312016-03-16 02:22:50 -07002906 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002907
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002908 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2909 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002910 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2911 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002912
nisse05103312016-03-16 02:22:50 -07002913 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002914
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002915 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2916 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002917 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2918 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2919
Niels Möllerff40b142018-04-09 08:49:14 +02002920 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002921 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002922 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002923 channel_->SetSend(true);
2924 EXPECT_TRUE(capturer.CaptureFrame());
2925
Mirko Bonadeif859e552018-05-30 15:31:29 +02002926 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002927 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2928 // Autmatic resize off when using simulcast.
2929 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2930 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2931
2932 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002933 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002934 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002935 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002936
nisse05103312016-03-16 02:22:50 -07002937 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002938
Mirko Bonadeif859e552018-05-30 15:31:29 +02002939 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002940 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2941 EXPECT_FALSE(vp8_settings.denoisingOn);
2942 // Resizing and frame dropping always off for screen sharing.
2943 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2944 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2945
nisse05103312016-03-16 02:22:50 -07002946 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002947
2948 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2949 EXPECT_FALSE(vp8_settings.denoisingOn);
2950 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2951 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2952
Niels Möllerff40b142018-04-09 08:49:14 +02002953 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002954}
2955
deadbeef119760a2016-04-04 11:43:27 -07002956// Test that setting the same options doesn't result in the encoder being
2957// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002958TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002959 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002960 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002961
perkjfa10b552016-10-02 23:45:26 -07002962 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002963 EXPECT_EQ(cricket::CS_RUNNING,
2964 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002965 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002966 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002967 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2968 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2969
Niels Möllerff40b142018-04-09 08:49:14 +02002970 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2971 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002972 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002973 // Expect 1 reconfigurations at this point from the initial configuration.
2974 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002975
2976 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002977 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002978 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2979
2980 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002981 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002982 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002983 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2984
Niels Möllerff40b142018-04-09 08:49:14 +02002985 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002986}
2987
eladalonf1841382017-06-12 01:16:46 -07002988class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002989 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002990 Vp9SettingsTest() : Vp9SettingsTest("") {}
2991 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002992 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002993 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002994 }
2995 virtual ~Vp9SettingsTest() {}
2996
2997 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002998 void TearDown() override {
2999 // Remove references to encoder_factory_ since this will be destroyed
3000 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003001 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003002 }
Erik Språng143cec12015-04-28 10:01:41 +02003003};
3004
3005TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003006 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003007 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003008 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003009
Peter Boström2feafdb2015-09-09 14:32:14 +02003010 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003011
Tommi85959932018-02-07 19:26:06 +01003012 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02003013 EXPECT_EQ(cricket::CS_RUNNING,
3014 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003015 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02003016 channel_->SetSend(true);
3017
3018 EXPECT_TRUE(capturer.CaptureFrame());
3019
pbos4cba4eb2015-10-26 11:18:18 -07003020 webrtc::VideoCodecVP9 vp9_settings;
3021 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003022 EXPECT_TRUE(vp9_settings.denoisingOn)
3023 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003024
nisse05103312016-03-16 02:22:50 -07003025 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003026
Erik Språng143cec12015-04-28 10:01:41 +02003027 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3028 EXPECT_FALSE(vp9_settings.denoisingOn);
3029 // Frame dropping always on for real time video.
3030 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3031
nisse05103312016-03-16 02:22:50 -07003032 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003033
3034 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3035 EXPECT_TRUE(vp9_settings.denoisingOn);
3036 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3037
3038 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003039 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003040 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003041 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003042
nisse05103312016-03-16 02:22:50 -07003043 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003044
3045 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3046 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003047 // Frame dropping always on for screen sharing.
3048 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003049
nisse05103312016-03-16 02:22:50 -07003050 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003051
3052 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3053 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003054 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003055
Niels Möllerff40b142018-04-09 08:49:14 +02003056 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003057}
3058
Sergey Silkinf18072e2018-03-14 10:35:35 +01003059TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3060 cricket::VideoSendParameters parameters;
3061 parameters.codecs.push_back(GetEngineCodec("VP9"));
3062 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3063
3064 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3065
3066 FakeVideoSendStream* stream =
3067 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3068
3069 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3070 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3071
3072 FakeVideoCapturerWithTaskQueue capturer;
3073 EXPECT_EQ(cricket::CS_RUNNING,
3074 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003075 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003076 channel_->SetSend(true);
3077
3078 EXPECT_TRUE(capturer.CaptureFrame());
3079
3080 webrtc::VideoCodecVP9 vp9_settings;
3081 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3082
3083 const size_t kNumSpatialLayers = ssrcs.size();
3084 const size_t kNumTemporalLayers = 3;
3085 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3086 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3087
Niels Möllerff40b142018-04-09 08:49:14 +02003088 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003089}
3090
asaperssonc5dabdd2016-03-21 04:15:50 -07003091class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3092 public:
brandtr468da7c2016-11-22 02:16:47 -08003093 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003094 : Vp9SettingsTest(field_trials) {}
3095
3096 protected:
3097 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3098 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003099 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003100 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3101
3102 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3103
Tommi85959932018-02-07 19:26:06 +01003104 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003105 EXPECT_EQ(cricket::CS_RUNNING,
3106 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003107 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003108 channel_->SetSend(true);
3109
3110 EXPECT_TRUE(capturer.CaptureFrame());
3111
3112 webrtc::VideoCodecVP9 vp9_settings;
3113 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3114 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3115 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3116
Niels Möllerff40b142018-04-09 08:49:14 +02003117 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003118 }
3119};
3120
3121class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3122 public:
3123 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3124};
3125
3126TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3127 const int kNumSpatialLayers = 1;
3128 const int kNumTemporalLayers = 1;
3129 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3130}
3131
3132class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3133 public:
3134 Vp9SettingsTestWithInvalidFlag()
3135 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3136};
3137
3138TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3139 const int kNumSpatialLayers = 1;
3140 const int kNumTemporalLayers = 1;
3141 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3142}
3143
3144class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3145 public:
3146 Vp9SettingsTestWith2SL3TLFlag()
3147 : Vp9SettingsTestWithFieldTrial(
3148 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3149};
3150
3151TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3152 const int kNumSpatialLayers = 2;
3153 const int kNumTemporalLayers = 3;
3154 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3155}
3156
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003157TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3158 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3159 ASSERT_EQ(1u, streams.size());
3160 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3161}
3162
3163TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3164 webrtc::test::ScopedFieldTrials override_field_trials_(
3165 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3166 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3167 ASSERT_EQ(1u, streams.size());
3168 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3169}
3170
asapersson3c81a1a2017-06-14 05:52:21 -07003171TEST_F(WebRtcVideoChannelTest,
3172 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3173 webrtc::test::ScopedFieldTrials override_field_trials_(
3174 "WebRTC-Video-BalancedDegradation/Disabled/");
3175 const bool kResolutionScalingEnabled = true;
3176 const bool kFpsScalingEnabled = false;
3177 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3178}
3179
3180TEST_F(WebRtcVideoChannelTest,
3181 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3182 webrtc::test::ScopedFieldTrials override_field_trials_(
3183 "WebRTC-Video-BalancedDegradation/Enabled/");
3184 const bool kResolutionScalingEnabled = true;
3185 const bool kFpsScalingEnabled = true;
3186 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3187}
3188
eladalonf1841382017-06-12 01:16:46 -07003189TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003190 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003191}
3192
eladalonf1841382017-06-12 01:16:46 -07003193TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003194 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003195}
3196
eladalonf1841382017-06-12 01:16:46 -07003197TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003198 TestCpuAdaptation(true, true);
3199}
3200
eladalonf1841382017-06-12 01:16:46 -07003201TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003202 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003203 cricket::VideoSendParameters parameters;
3204 parameters.codecs.push_back(codec);
3205
kthelgason2bc68642017-02-07 07:02:22 -08003206 MediaConfig media_config = GetMediaConfig();
perkj2d5f0912016-02-29 00:04:41 -08003207 channel_.reset(
3208 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003209 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003210 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3211
3212 AddSendStream();
3213
Tommi85959932018-02-07 19:26:06 +01003214 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003215 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003216 ASSERT_EQ(cricket::CS_RUNNING,
3217 capturer.Start(capturer.GetSupportedFormats()->front()));
3218 ASSERT_TRUE(channel_->SetSend(true));
3219
3220 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3221 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003222
Niels Möllera6cc0f92018-02-12 17:14:55 +01003223 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003224 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3225 EXPECT_EQ(1280, send_stream->GetLastWidth());
3226 EXPECT_EQ(720, send_stream->GetLastHeight());
3227
3228 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003229 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003230 wants.max_pixel_count =
3231 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003232 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003233 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003234 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3235 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3236 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3237
3238 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003239 wants.max_pixel_count =
3240 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003241 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003242 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003243 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3244 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3245 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3246
3247 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003248 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003249 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003250 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3251 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3252
3253 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003254 int current_pixel_count =
3255 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3256 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3257 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003258 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003259 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003260 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003261 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003262 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003263 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003264 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3265 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3266
sprang84a37592017-02-10 07:04:27 -08003267 // Trigger underuse again, should go back up to full resolution.
3268 current_pixel_count =
3269 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003270 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003271 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003272 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003273 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003274 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003275 EXPECT_EQ(1284, send_stream->GetLastWidth());
3276 EXPECT_EQ(724, send_stream->GetLastHeight());
3277
Niels Möllerff40b142018-04-09 08:49:14 +02003278 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003279}
3280
eladalonf1841382017-06-12 01:16:46 -07003281TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003282 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003283 cricket::VideoSendParameters parameters;
3284 parameters.codecs.push_back(codec);
3285
kthelgason2bc68642017-02-07 07:02:22 -08003286 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003287 media_config.video.enable_cpu_adaptation = true;
Per766ad3b2016-04-05 15:23:49 +02003288 channel_.reset(
3289 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003290 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003291 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3292
3293 AddSendStream();
3294
Tommi85959932018-02-07 19:26:06 +01003295 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003296 ASSERT_EQ(cricket::CS_RUNNING,
3297 capturer.Start(capturer.GetSupportedFormats()->front()));
3298 ASSERT_TRUE(channel_->SetSend(true));
3299 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003300 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003301 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003302
3303 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3304 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003305
Niels Möllera6cc0f92018-02-12 17:14:55 +01003306 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003307 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3308 EXPECT_EQ(1280, send_stream->GetLastWidth());
3309 EXPECT_EQ(720, send_stream->GetLastHeight());
3310
3311 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003312 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003313 wants.max_pixel_count =
3314 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003315 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003316 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003317 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3318 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3319 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3320
3321 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003322 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003323 ASSERT_EQ(cricket::CS_RUNNING,
3324 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003325 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003326 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003327 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003328 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003329 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3330 send_stream = fake_call_->GetVideoSendStreams().front();
3331 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003332 EXPECT_EQ(1284, send_stream->GetLastWidth());
3333 EXPECT_EQ(724, send_stream->GetLastHeight());
3334
3335 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003336 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003337 send_stream = fake_call_->GetVideoSendStreams().front();
3338 // We have a new fake send stream, so it doesn't remember the old sink wants.
3339 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003340 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003341 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003342 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003343 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3344 send_stream = fake_call_->GetVideoSendStreams().front();
3345 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003346 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3347 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3348
Niels Möllerff40b142018-04-09 08:49:14 +02003349 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003350}
3351
asapersson3c81a1a2017-06-14 05:52:21 -07003352// TODO(asapersson): Remove this test when the balanced field trial is removed.
3353void WebRtcVideoChannelTest::TestDegradationPreference(
3354 bool resolution_scaling_enabled,
3355 bool fps_scaling_enabled) {
3356 cricket::VideoCodec codec = GetEngineCodec("VP8");
3357 cricket::VideoSendParameters parameters;
3358 parameters.codecs.push_back(codec);
3359
3360 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003361 media_config.video.enable_cpu_adaptation = true;
asapersson3c81a1a2017-06-14 05:52:21 -07003362 channel_.reset(
3363 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
3364 channel_->OnReadyToSend(true);
3365
3366 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3367
3368 AddSendStream();
3369
Tommi85959932018-02-07 19:26:06 +01003370 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003371 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003372 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003373 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3374 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3375
3376 EXPECT_TRUE(channel_->SetSend(true));
3377
3378 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3379 EXPECT_EQ(resolution_scaling_enabled,
3380 send_stream->resolution_scaling_enabled());
3381 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3382
Niels Möllerff40b142018-04-09 08:49:14 +02003383 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003384}
3385
eladalonf1841382017-06-12 01:16:46 -07003386void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3387 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003388 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003389 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003390 cricket::VideoSendParameters parameters;
3391 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003392
kthelgason2bc68642017-02-07 07:02:22 -08003393 MediaConfig media_config = GetMediaConfig();
3394 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003395 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003396 }
nisse51542be2016-02-12 02:27:06 -08003397 channel_.reset(
3398 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003399 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003400
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003401 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003402
3403 AddSendStream();
3404
Tommi85959932018-02-07 19:26:06 +01003405 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003406 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003407 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003408 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003409 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003410 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003411 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003412
3413 EXPECT_TRUE(channel_->SetSend(true));
3414
solenberge5269742015-09-08 05:13:22 -07003415 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003416
sprangc5d62e22017-04-02 23:53:04 -07003417 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003418 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003419 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3420 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003421
3422 EXPECT_TRUE(capturer.CaptureFrame());
3423 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3424
perkj26752742016-10-24 01:21:16 -07003425 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3426 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003427
Niels Möllerff40b142018-04-09 08:49:14 +02003428 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003429 return;
3430 }
3431
sprangc5d62e22017-04-02 23:53:04 -07003432 if (is_screenshare) {
3433 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3434 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3435 } else {
3436 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3437 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3438 }
3439
perkj803d97f2016-11-01 11:45:46 -07003440 // Trigger overuse.
3441 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3442
3443 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003444 if (is_screenshare) {
3445 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3446 } else {
3447 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3448 }
perkj803d97f2016-11-01 11:45:46 -07003449 send_stream->InjectVideoSinkWants(wants);
3450
sprangc5d62e22017-04-02 23:53:04 -07003451 for (int i = 0; i < kDefaultFps; ++i)
3452 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003453
sprangc5d62e22017-04-02 23:53:04 -07003454 if (is_screenshare) {
3455 // Drops every third frame.
3456 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3457 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3458 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3459 } else {
3460 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3461 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3462 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3463 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003464
3465 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003466 int last_pixel_count =
3467 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003468 if (is_screenshare) {
3469 wants.max_framerate_fps = kDefaultFps;
3470 } else {
3471 wants.max_pixel_count = last_pixel_count * 4;
3472 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3473 }
perkj803d97f2016-11-01 11:45:46 -07003474 send_stream->InjectVideoSinkWants(wants);
3475
sprangc5d62e22017-04-02 23:53:04 -07003476 for (int i = 0; i < kDefaultFps; ++i)
3477 EXPECT_TRUE(capturer.CaptureFrame());
3478
3479 if (is_screenshare) {
3480 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3481 send_stream->GetNumberOfSwappedFrames());
3482 } else {
3483 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3484 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003485
perkj26752742016-10-24 01:21:16 -07003486 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3487 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003488
Niels Möllerff40b142018-04-09 08:49:14 +02003489 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003490}
3491
eladalonf1841382017-06-12 01:16:46 -07003492TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003493 // Start at last timestamp to verify that wraparounds are estimated correctly.
3494 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3495 static const int64_t kInitialNtpTimeMs = 1247891230;
3496 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003497 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003498
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003499 FakeVideoReceiveStream* stream = AddRecvStream();
3500 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003501 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003502
nisse64ec8f82016-09-27 00:17:25 -07003503 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3504 kInitialTimestamp, 0,
3505 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003506 // Initial NTP time is not available on the first frame, but should still be
3507 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003508 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003509
3510 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003511
3512 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3513 // triggers a constant-overflow warning, hence we're calculating it explicitly
3514 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003515 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003516 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3517 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003518 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003519
3520 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003521
3522 // Verify that NTP time has been correctly deduced.
3523 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003524 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003525 ASSERT_EQ(1u, info.receivers.size());
3526 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003527}
3528
eladalonf1841382017-06-12 01:16:46 -07003529TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003530 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003531 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003532
3533 VideoCodec codec;
3534 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003535 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003536
3537 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003538 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3539 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003540 FakeVideoSendStream* stream = AddSendStream(
3541 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003542 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003543
3544 // Make sure NACK and FEC are enabled on the correct payload types.
3545 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003546 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3547 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003548
3549 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3550 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003551 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003552 // TODO(juberti): Check RTCP, PLI, TMMBR.
3553}
3554
brandtr31bd2242017-05-19 05:47:46 -07003555// The following four tests ensures that FlexFEC is not activated by default
3556// when the field trials are not enabled.
3557// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3558// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003559TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003560 FakeVideoSendStream* stream = AddSendStream();
3561 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3562
brandtr3d200bd2017-01-16 06:59:19 -08003563 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003564 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3565 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003566}
3567
eladalonf1841382017-06-12 01:16:46 -07003568TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003569 FakeVideoSendStream* stream = AddSendStream(
3570 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3571 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3572
brandtr3d200bd2017-01-16 06:59:19 -08003573 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003574 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3575 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3576}
3577
Yves Gerey665174f2018-06-19 15:03:05 +02003578TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003579 AddRecvStream();
3580
3581 const std::vector<FakeFlexfecReceiveStream*>& streams =
3582 fake_call_->GetFlexfecReceiveStreams();
3583 EXPECT_TRUE(streams.empty());
3584}
3585
eladalonf1841382017-06-12 01:16:46 -07003586TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003587 AddRecvStream(
3588 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3589
3590 const std::vector<FakeFlexfecReceiveStream*>& streams =
3591 fake_call_->GetFlexfecReceiveStreams();
3592 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003593}
3594
3595// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3596// tests that use this test fixture into the corresponding "non-field trial"
3597// tests.
eladalonf1841382017-06-12 01:16:46 -07003598class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003599 public:
eladalonf1841382017-06-12 01:16:46 -07003600 WebRtcVideoChannelFlexfecRecvTest()
3601 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003602};
3603
eladalonf1841382017-06-12 01:16:46 -07003604TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003605 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3606 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3607 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3608}
3609
eladalonf1841382017-06-12 01:16:46 -07003610TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003611 AddRecvStream();
3612
3613 const std::vector<FakeFlexfecReceiveStream*>& streams =
3614 fake_call_->GetFlexfecReceiveStreams();
3615 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003616
3617 const std::vector<FakeVideoReceiveStream*>& video_streams =
3618 fake_call_->GetVideoReceiveStreams();
3619 ASSERT_EQ(1U, video_streams.size());
3620 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3621 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3622 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003623}
3624
eladalonf1841382017-06-12 01:16:46 -07003625TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003626 AddRecvStream(
3627 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3628
3629 const std::vector<FakeFlexfecReceiveStream*>& streams =
3630 fake_call_->GetFlexfecReceiveStreams();
3631 ASSERT_EQ(1U, streams.size());
3632 const FakeFlexfecReceiveStream* stream = streams.front();
3633 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3634 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3635 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3636 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3637 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003638
3639 const std::vector<FakeVideoReceiveStream*>& video_streams =
3640 fake_call_->GetVideoReceiveStreams();
3641 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003642 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3643 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003644 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003645 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003646 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003647}
3648
eladalonf1841382017-06-12 01:16:46 -07003649TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003650 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3651 cricket::VideoRecvParameters recv_parameters;
3652 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3653 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3654
3655 AddRecvStream(
3656 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3657 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003658 const std::vector<FakeVideoReceiveStream*>& video_streams =
3659 fake_call_->GetVideoReceiveStreams();
3660 ASSERT_EQ(1U, video_streams.size());
3661 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3662 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3663 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003664
3665 // Enable FlexFEC.
3666 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3667 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3668 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3669 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3670 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3671 << "Enabling FlexFEC should not create VideoReceiveStream.";
3672 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3673 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003674 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3675 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003676}
3677
eladalonf1841382017-06-12 01:16:46 -07003678TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003679 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3680 cricket::VideoRecvParameters recv_parameters;
3681 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3682 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3683 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3684
3685 AddRecvStream(
3686 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3687 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003688 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003689 const std::vector<FakeVideoReceiveStream*>& video_streams =
3690 fake_call_->GetVideoReceiveStreams();
3691 ASSERT_EQ(1U, video_streams.size());
3692 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3693 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3694 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003695
3696 // Disable FlexFEC.
3697 recv_parameters.codecs.clear();
3698 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3699 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3700 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3701 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3702 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3703 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3704 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3705 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003706 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3707 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003708}
3709
brandtr31bd2242017-05-19 05:47:46 -07003710// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3711// tests that use this test fixture into the corresponding "non-field trial"
3712// tests.
eladalonf1841382017-06-12 01:16:46 -07003713class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003714 public:
eladalonf1841382017-06-12 01:16:46 -07003715 WebRtcVideoChannelFlexfecSendRecvTest()
3716 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003717 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3718 }
3719};
3720
Yves Gerey665174f2018-06-19 15:03:05 +02003721TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003722 FakeVideoSendStream* stream = AddSendStream();
3723 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3724
brandtr3d200bd2017-01-16 06:59:19 -08003725 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3726 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3727 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003728}
3729
eladalonf1841382017-06-12 01:16:46 -07003730TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003731 FakeVideoSendStream* stream = AddSendStream(
3732 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3733 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3734
brandtr3d200bd2017-01-16 06:59:19 -08003735 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3736 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3737 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3738 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003739}
3740
eladalonf1841382017-06-12 01:16:46 -07003741TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003742 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003743 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003744 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003745
3746 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003747 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003748
brandtrb5f2c3f2016-10-04 23:28:39 -07003749 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3750 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003751}
3752
eladalonf1841382017-06-12 01:16:46 -07003753TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003754 cricket::VideoSendParameters parameters;
3755 parameters.codecs.push_back(GetEngineCodec("VP8"));
3756 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3757
3758 FakeVideoSendStream* stream = AddSendStream();
3759 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3760
brandtr3d200bd2017-01-16 06:59:19 -08003761 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003762}
3763
eladalonf1841382017-06-12 01:16:46 -07003764TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003765 AddRecvStream(
3766 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003767
3768 cricket::VideoRecvParameters recv_parameters;
3769 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3770 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3771 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003772
3773 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3774 fake_call_->GetFlexfecReceiveStreams();
3775 ASSERT_EQ(1U, flexfec_streams.size());
3776 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3777 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3778 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003779 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003780 flexfec_stream_config.payload_type);
3781 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3782 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3783 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3784 const std::vector<FakeVideoReceiveStream*>& video_streams =
3785 fake_call_->GetVideoReceiveStreams();
3786 const FakeVideoReceiveStream* video_stream = video_streams.front();
3787 const webrtc::VideoReceiveStream::Config& video_stream_config =
3788 video_stream->GetConfig();
3789 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3790 flexfec_stream_config.local_ssrc);
3791 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3792 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3793 flexfec_stream_config.rtcp_send_transport);
3794 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3795 // spec-compliant way.
3796 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3797 flexfec_stream_config.transport_cc);
3798 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3799 EXPECT_EQ(video_stream_config.rtp.extensions,
3800 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003801}
3802
brandtr31bd2242017-05-19 05:47:46 -07003803// We should not send FlexFEC, even if we advertise it, unless the right
3804// field trial is set.
3805// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003806TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003807 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3808 cricket::VideoSendParameters parameters;
3809 parameters.codecs.push_back(GetEngineCodec("VP8"));
3810 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3811 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3812
3813 FakeVideoSendStream* stream = AddSendStream();
3814 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3815
3816 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003817 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003818 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3819}
3820
eladalonf1841382017-06-12 01:16:46 -07003821TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003822 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3823 cricket::VideoSendParameters parameters;
3824 parameters.codecs.push_back(GetEngineCodec("VP8"));
3825 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3826 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3827
3828 FakeVideoSendStream* stream = AddSendStream(
3829 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3830 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3831
3832 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003833 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003834 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3835}
3836
eladalonf1841382017-06-12 01:16:46 -07003837TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003838 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003839 const int kUnusedPayloadType = 127;
3840 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3841
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003842 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003843 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003844 parameters.codecs.push_back(rtx_codec);
3845 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003846 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003847}
3848
eladalonf1841382017-06-12 01:16:46 -07003849TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003850 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003851 const int kUnusedPayloadType1 = 126;
3852 const int kUnusedPayloadType2 = 127;
3853 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3854 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3855 {
3856 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3857 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3858 cricket::VideoSendParameters parameters;
3859 parameters.codecs.push_back(GetEngineCodec("VP8"));
3860 parameters.codecs.push_back(rtx_codec);
3861 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3862 }
3863 {
3864 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3865 kUnusedPayloadType1, kUnusedPayloadType2);
3866 cricket::VideoSendParameters parameters;
3867 parameters.codecs.push_back(GetEngineCodec("VP8"));
3868 parameters.codecs.push_back(rtx_codec);
3869 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3870 << "RTX without matching video codec should be rejected.";
3871 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003872}
3873
eladalonf1841382017-06-12 01:16:46 -07003874TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003875 const int kUnusedPayloadType1 = 126;
3876 const int kUnusedPayloadType2 = 127;
3877 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3878 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3879
3880 // SSRCs for RTX.
3881 cricket::StreamParams params =
3882 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3883 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3884 AddSendStream(params);
3885
3886 // Original payload type for RTX.
3887 cricket::VideoSendParameters parameters;
3888 parameters.codecs.push_back(GetEngineCodec("VP8"));
3889 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3890 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3891 parameters.codecs.push_back(rtx_codec);
3892 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3893 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3894 const webrtc::VideoSendStream::Config& config_before =
3895 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3896 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3897 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3898 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3899
3900 // Change payload type for RTX.
3901 parameters.codecs[1].id = kUnusedPayloadType2;
3902 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3903 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3904 const webrtc::VideoSendStream::Config& config_after =
3905 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3906 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3907 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3908 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3909}
3910
eladalonf1841382017-06-12 01:16:46 -07003911TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003912 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003913 parameters.codecs.push_back(GetEngineCodec("VP8"));
3914 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003915 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003916
3917 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003918 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003919
magjed509e4fe2016-11-18 01:34:11 -08003920 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003921
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003922 parameters.codecs.pop_back();
3923 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003924 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003925 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003926 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003927 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003928 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3929}
3930
eladalonf1841382017-06-12 01:16:46 -07003931TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003932 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003933 cricket::VideoSendParameters parameters;
3934 parameters.codecs.push_back(GetEngineCodec("VP8"));
3935 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3936 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3937
3938 FakeVideoSendStream* stream = AddSendStream(
3939 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3940 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3941
brandtr3d200bd2017-01-16 06:59:19 -08003942 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3943 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003944 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3945 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3946
3947 parameters.codecs.pop_back();
3948 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3949 stream = fake_call_->GetVideoSendStreams()[0];
3950 ASSERT_TRUE(stream != nullptr);
3951 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003952 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003953 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003954}
3955
eladalonf1841382017-06-12 01:16:46 -07003956TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003957 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003958 cricket::VideoCodec codec(100, "VP8");
3959 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3960 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003961
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003962 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003963 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003964
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003965 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003966 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003967 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003968
3969 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003970 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003971
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003972 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003973 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3974 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003975 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003976 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003977 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003978 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003979}
3980
eladalonf1841382017-06-12 01:16:46 -07003981TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003982 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3983 200000);
3984}
3985
eladalonf1841382017-06-12 01:16:46 -07003986TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003987 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3988 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3989 ASSERT_EQ(1u, streams.size());
3990 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3991}
3992
eladalonf1841382017-06-12 01:16:46 -07003993TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003994 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003995 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003996}
3997
eladalonf1841382017-06-12 01:16:46 -07003998TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003999 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004000}
4001
eladalonf1841382017-06-12 01:16:46 -07004002TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004003 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4004 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4005 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004006}
4007
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004008// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4009// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004010TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004011 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4012 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4013 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4014 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004015 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004016 ExpectSetBitrateParameters(100000, 200000, 400000);
4017 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4018 // Since the codec isn't changing, start_bitrate_bps should be -1.
4019 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004020
4021 // Decrease max_bandwidth_bps.
4022 send_parameters_.max_bandwidth_bps = 350000;
4023 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004024
4025 // Now try again with the values flipped around.
4026 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4027 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004028 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004029 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004030
4031 // If we change the codec max, max_bandwidth_bps should still apply.
4032 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004033 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004034 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004035}
4036
Yves Gerey665174f2018-06-19 15:03:05 +02004037TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004038 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4039 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004040 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004041 // Setting max bitrate should keep previous min bitrate.
4042 // Setting max bitrate should not reset start bitrate.
4043 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004044 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004045}
4046
eladalonf1841382017-06-12 01:16:46 -07004047TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004048 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004049 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004050 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004051 // -1 means to disable max bitrate (set infinite).
4052 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004053 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004054 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004055}
4056
eladalonf1841382017-06-12 01:16:46 -07004057TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004058 send_parameters_.max_bandwidth_bps = 99999;
4059 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004060 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004061 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004062 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4063 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4064 stream->GetVideoStreams()[0].max_bitrate_bps);
4065
4066 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004067 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004068 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4069 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004070 stream->GetVideoStreams()[0].max_bitrate_bps);
4071}
4072
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004073// Tests that when the codec specific max bitrate and VideoSendParameters
4074// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4075// appropriately.
4076TEST_F(WebRtcVideoChannelTest,
4077 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4078 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4079 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4080 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4081 send_parameters_.max_bandwidth_bps = -1;
4082 AddSendStream();
4083 ExpectSetMaxBitrate(300000);
4084 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4085
4086 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4087 ASSERT_EQ(1u, video_send_streams.size());
4088 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4089 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4090 // First the max bitrate is set based upon the codec param.
4091 EXPECT_EQ(300000,
4092 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4093
4094 // The VideoSendParameters max bitrate overrides the codec's.
4095 send_parameters_.max_bandwidth_bps = 500000;
4096 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4097 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4098 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4099 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4100}
4101
4102// Tests that when the codec specific max bitrate and RtpParameters
4103// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4104// appropriately.
4105TEST_F(WebRtcVideoChannelTest,
4106 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4107 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4108 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4109 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4110 send_parameters_.max_bandwidth_bps = -1;
4111 AddSendStream();
4112 ExpectSetMaxBitrate(300000);
4113 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4114
4115 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4116 ASSERT_EQ(1u, video_send_streams.size());
4117 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4118 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4119 // First the max bitrate is set based upon the codec param.
4120 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4121
4122 // The RtpParameter max bitrate overrides the codec's.
4123 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4124 ASSERT_EQ(1u, parameters.encodings.size());
4125 parameters.encodings[0].max_bitrate_bps = 500000;
4126 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4127 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4128 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4129 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4130}
4131
Åsa Persson55659812018-06-18 17:51:32 +02004132TEST_F(WebRtcVideoChannelTest,
4133 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4134 send_parameters_.max_bandwidth_bps = 99999;
4135 FakeVideoSendStream* stream = AddSendStream();
4136 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4137 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4138 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4139 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4140 stream->GetVideoStreams()[0].max_bitrate_bps);
4141
4142 // Get and set the rtp encoding parameters.
4143 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4144 EXPECT_EQ(1u, parameters.encodings.size());
4145
4146 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4147 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4148 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4149 stream->GetVideoStreams()[0].max_bitrate_bps);
4150
4151 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4152 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4153 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4154 stream->GetVideoStreams()[0].max_bitrate_bps);
4155}
4156
eladalonf1841382017-06-12 01:16:46 -07004157TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004158 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004159 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004160 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004161 channel_->SetSend(true);
4162
4163 FakeVideoSendStream* stream = AddSendStream();
4164
Tommi85959932018-02-07 19:26:06 +01004165 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004166 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004167 EXPECT_EQ(cricket::CS_RUNNING,
4168 capturer.Start(capturer.GetSupportedFormats()->front()));
4169
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004170 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4171 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4172 EXPECT_GT(initial_max_bitrate_bps, 0);
4173
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004174 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4175 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004176 // Insert a frame to update the encoder config.
4177 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004178 streams = stream->GetVideoStreams();
4179 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004180 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004181}
4182
eladalonf1841382017-06-12 01:16:46 -07004183TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004184 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004185 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004186 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004187 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004188 channel_->SetSend(true);
4189
4190 FakeVideoSendStream* stream = AddSendStream(
4191 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4192
4193 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004194 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004195 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004196 EXPECT_EQ(cricket::CS_RUNNING,
4197 capturer.Start(capturer.GetSupportedFormats()->front()));
4198 EXPECT_TRUE(capturer.CaptureFrame());
4199
4200 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4201 ASSERT_GT(streams.size(), 1u)
4202 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004203 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004204 EXPECT_GT(initial_max_bitrate_bps, 0);
4205
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004206 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4207 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004208 // Insert a frame to update the encoder config.
4209 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004210 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004211 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004212 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4213
Niels Möllerff40b142018-04-09 08:49:14 +02004214 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004215}
4216
eladalonf1841382017-06-12 01:16:46 -07004217TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004218 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004219 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004220 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004221 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4222 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004223 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004224 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004225
4226 VideoCodec codec;
4227 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4228 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4229}
4230
eladalonf1841382017-06-12 01:16:46 -07004231TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004232 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004233 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004234 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004235 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004236 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004237 parameters.codecs[0].id = kIncorrectPayloads[i];
4238 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004239 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004240 }
4241}
4242
eladalonf1841382017-06-12 01:16:46 -07004243TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004244 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004245 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004246 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004247 parameters.codecs[0].id = payload_type;
4248 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004249 << "Payload type '" << payload_type << "' rejected.";
4250 }
4251}
4252
deadbeef67cf2c12016-04-13 10:07:16 -07004253// Test that setting the a different set of codecs but with an identical front
4254// codec doesn't result in the stream being recreated.
4255// This may happen when a subsequent negotiation includes fewer codecs, as a
4256// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004257TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004258 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4259 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004260 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4261 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004262 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4263
4264 AddSendStream();
4265 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4266
4267 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004268 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004269 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4270 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4271}
4272
eladalonf1841382017-06-12 01:16:46 -07004273TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004274 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004275 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004276 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004277}
4278
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004279// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004280TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004281 const int kUnusedPayloadType1 = 126;
4282 const int kUnusedPayloadType2 = 127;
4283 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4284 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4285
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004286 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004287 parameters.codecs.push_back(GetEngineCodec("VP8"));
4288 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004289 parameters.codecs.push_back(rtx_codec);
4290 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004291 << "RTX codec without associated payload should be rejected.";
4292
magjed509e4fe2016-11-18 01:34:11 -08004293 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004294 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004295 << "RTX codec with invalid associated payload type should be rejected.";
4296
magjed509e4fe2016-11-18 01:34:11 -08004297 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004298 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004299
magjed509e4fe2016-11-18 01:34:11 -08004300 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004301 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004302 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004303
Yves Gerey665174f2018-06-19 15:03:05 +02004304 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4305 << "RTX codec with another RTX as associated payload type should be "
4306 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004307}
4308
eladalonf1841382017-06-12 01:16:46 -07004309TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004310 const int kUnusedPayloadType1 = 126;
4311 const int kUnusedPayloadType2 = 127;
4312 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4313 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4314
4315 // SSRCs for RTX.
4316 cricket::StreamParams params =
4317 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4318 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4319 AddRecvStream(params);
4320
4321 // Original payload type for RTX.
4322 cricket::VideoRecvParameters parameters;
4323 parameters.codecs.push_back(GetEngineCodec("VP8"));
4324 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4325 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4326 parameters.codecs.push_back(rtx_codec);
4327 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4328 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4329 const webrtc::VideoReceiveStream::Config& config_before =
4330 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004331 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4332 const int* payload_type_before = FindKeyByValue(
4333 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4334 ASSERT_NE(payload_type_before, nullptr);
4335 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004336 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4337
4338 // Change payload type for RTX.
4339 parameters.codecs[1].id = kUnusedPayloadType2;
4340 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4341 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4342 const webrtc::VideoReceiveStream::Config& config_after =
4343 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004344 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4345 const int* payload_type_after = FindKeyByValue(
4346 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4347 ASSERT_NE(payload_type_after, nullptr);
4348 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004349 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4350}
4351
eladalonf1841382017-06-12 01:16:46 -07004352TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004353 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004354 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004355 parameters.codecs[0].id = 99;
4356 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004357}
4358
eladalonf1841382017-06-12 01:16:46 -07004359TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004360 cricket::VideoRecvParameters parameters;
4361 parameters.codecs = engine_.codecs();
4362 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004363
4364 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004365 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004366 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004367 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004368}
4369
eladalonf1841382017-06-12 01:16:46 -07004370TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004371 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004372 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004373 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004374 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004375}
4376
eladalonf1841382017-06-12 01:16:46 -07004377TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004378 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004379 parameters.codecs.push_back(GetEngineCodec("VP8"));
4380 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004381 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004382}
4383
eladalonf1841382017-06-12 01:16:46 -07004384TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004385 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004386 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4387 send_parameters.codecs.push_back(GetEngineCodec("red"));
4388 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004389 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004390
4391 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004392
magjed509e4fe2016-11-18 01:34:11 -08004393 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004394 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004395
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004396 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004397 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004398 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004399 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004400 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004401 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004402 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4403}
4404
eladalonf1841382017-06-12 01:16:46 -07004405TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004406 AddRecvStream(
4407 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004408 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004409 fake_call_->GetFlexfecReceiveStreams();
4410
4411 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004412 const FakeFlexfecReceiveStream* stream = streams.front();
4413 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4414 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4415 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4416 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004417
4418 cricket::VideoRecvParameters recv_parameters;
4419 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4420 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4421 EXPECT_TRUE(streams.empty())
4422 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004423}
4424
eladalonf1841382017-06-12 01:16:46 -07004425TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004426 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004427 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004428 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004429
4430 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004431 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4432 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4433 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004434 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4435 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004436 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004437 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004438 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004439 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004440
4441 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004442 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4443 send_parameters.codecs.push_back(GetEngineCodec("red"));
4444 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004445 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4446 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004447 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004448 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004449 << "ULPFEC should be enabled on the receive stream.";
4450}
4451
eladalonf1841382017-06-12 01:16:46 -07004452TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004453 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004454 AddRecvStream(
4455 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004456 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004457 fake_call_->GetFlexfecReceiveStreams();
4458
4459 cricket::VideoRecvParameters recv_parameters;
4460 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4461 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4462 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4463 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004464 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004465 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004466 stream_with_recv_params->GetConfig().payload_type);
4467 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004468 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004469 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004470 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004471 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004472
4473 cricket::VideoSendParameters send_parameters;
4474 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4475 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4476 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4477 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004478 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004479 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004480 stream_with_send_params->GetConfig().payload_type);
4481 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004482 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004483 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004484 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004485 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004486}
4487
eladalonf1841382017-06-12 01:16:46 -07004488TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004489 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004490 parameters.codecs.push_back(GetEngineCodec("VP8"));
4491 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004492 parameters.codecs[1].id = parameters.codecs[0].id;
4493 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004494}
4495
eladalonf1841382017-06-12 01:16:46 -07004496TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004497 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004498 cricket::VideoRecvParameters parameters;
4499 parameters.codecs.push_back(GetEngineCodec("VP8"));
4500 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4501 parameters.codecs[1].id = parameters.codecs[0].id;
4502 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4503}
4504
eladalonf1841382017-06-12 01:16:46 -07004505TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004506 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004507 parameters.codecs.push_back(GetEngineCodec("VP8"));
4508 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004509 parameters.codecs[1].id = parameters.codecs[0].id;
4510 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004511}
4512
eladalonf1841382017-06-12 01:16:46 -07004513TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004514 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004515 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004516 parameters.codecs.push_back(GetEngineCodec("VP8"));
4517 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004518 parameters.codecs[1].id += 1;
4519 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004520}
4521
deadbeef67cf2c12016-04-13 10:07:16 -07004522// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004523// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004524TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004525 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004526 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004527 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4528 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004529 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004530
4531 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4532 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4533
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004534 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004535 parameters2.codecs.push_back(GetEngineCodec("red"));
4536 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004537 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004538 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4539}
4540
eladalonf1841382017-06-12 01:16:46 -07004541TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004542 EXPECT_FALSE(AddSendStream()->IsSending());
4543}
4544
eladalonf1841382017-06-12 01:16:46 -07004545TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004546 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004547}
4548
eladalonf1841382017-06-12 01:16:46 -07004549TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004550 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004551 EXPECT_FALSE(stream->IsSending());
4552
4553 // false->true
4554 EXPECT_TRUE(channel_->SetSend(true));
4555 EXPECT_TRUE(stream->IsSending());
4556 // true->true
4557 EXPECT_TRUE(channel_->SetSend(true));
4558 EXPECT_TRUE(stream->IsSending());
4559 // true->false
4560 EXPECT_TRUE(channel_->SetSend(false));
4561 EXPECT_FALSE(stream->IsSending());
4562 // false->false
4563 EXPECT_TRUE(channel_->SetSend(false));
4564 EXPECT_FALSE(stream->IsSending());
4565
4566 EXPECT_TRUE(channel_->SetSend(true));
4567 FakeVideoSendStream* new_stream = AddSendStream();
4568 EXPECT_TRUE(new_stream->IsSending())
4569 << "Send stream created after SetSend(true) not sending initially.";
4570}
4571
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004572// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004573TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004574 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004575 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004576 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004577 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
nisse51542be2016-02-12 02:27:06 -08004578
Tim Haloun6ca98362018-09-17 17:06:08 -07004579 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(
4580 engine_.CreateChannel(call_.get(), config, VideoOptions())));
nisse51542be2016-02-12 02:27:06 -08004581 channel->SetInterface(network_interface.get());
4582 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004583 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004584
4585 config.enable_dscp = true;
Tim Haloun6ca98362018-09-17 17:06:08 -07004586 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(
4587 engine_.CreateChannel(call_.get(), config, VideoOptions())));
nisse51542be2016-02-12 02:27:06 -08004588 channel->SetInterface(network_interface.get());
4589 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
4590
Tim Haloun6ca98362018-09-17 17:06:08 -07004591 // Packets should also self-identify their dscp in PacketOptions.
4592 const uint8_t kData[10] = {0};
4593 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4594 ->SendRtcp(kData, sizeof(kData)));
4595 EXPECT_EQ(rtc::DSCP_AF41, network_interface->options().dscp);
4596
nisse51542be2016-02-12 02:27:06 -08004597 // Verify that setting the option to false resets the
4598 // DiffServCodePoint.
4599 config.enable_dscp = false;
Tim Haloun6ca98362018-09-17 17:06:08 -07004600 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(
4601 engine_.CreateChannel(call_.get(), config, VideoOptions())));
nisse51542be2016-02-12 02:27:06 -08004602 channel->SetInterface(network_interface.get());
4603 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004604}
4605
deadbeef13871492015-12-09 12:37:51 -08004606// This test verifies that the RTCP reduced size mode is properly applied to
4607// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004608TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004609 // Create stream, expecting that default mode is "compound".
4610 FakeVideoSendStream* stream1 = AddSendStream();
4611 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004612 webrtc::RtpParameters rtp_parameters =
4613 channel_->GetRtpSendParameters(last_ssrc_);
4614 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004615
4616 // Now enable reduced size mode.
4617 send_parameters_.rtcp.reduced_size = true;
4618 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4619 stream1 = fake_call_->GetVideoSendStreams()[0];
4620 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004621 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4622 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004623
4624 // Create a new stream and ensure it picks up the reduced size mode.
4625 FakeVideoSendStream* stream2 = AddSendStream();
4626 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4627}
4628
4629// This test verifies that the RTCP reduced size mode is properly applied to
4630// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004631TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004632 // Create stream, expecting that default mode is "compound".
4633 FakeVideoReceiveStream* stream1 = AddRecvStream();
4634 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4635
4636 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004637 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4638 // the reduced_size flag should come from that.
4639 send_parameters_.rtcp.reduced_size = true;
4640 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004641 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4642 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4643
4644 // Create a new stream and ensure it picks up the reduced size mode.
4645 FakeVideoReceiveStream* stream2 = AddRecvStream();
4646 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4647}
4648
eladalonf1841382017-06-12 01:16:46 -07004649TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004650 EXPECT_EQ(webrtc::kNetworkUp,
4651 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4652 EXPECT_EQ(webrtc::kNetworkUp,
4653 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004654
4655 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004656 EXPECT_EQ(webrtc::kNetworkDown,
4657 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4658 EXPECT_EQ(webrtc::kNetworkUp,
4659 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004660
4661 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004662 EXPECT_EQ(webrtc::kNetworkUp,
4663 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4664 EXPECT_EQ(webrtc::kNetworkUp,
4665 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004666}
4667
eladalonf1841382017-06-12 01:16:46 -07004668TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004669 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004670 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004671 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004672
4673 AddSendStream();
4674
4675 cricket::VideoMediaInfo info;
4676 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004677 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004678}
4679
eladalonf1841382017-06-12 01:16:46 -07004680TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004681 FakeVideoSendStream* stream = AddSendStream();
4682 webrtc::VideoSendStream::Stats stats;
4683 stats.encoder_implementation_name = "encoder_implementation_name";
4684 stream->SetStats(stats);
4685
4686 cricket::VideoMediaInfo info;
4687 ASSERT_TRUE(channel_->GetStats(&info));
4688 EXPECT_EQ(stats.encoder_implementation_name,
4689 info.senders[0].encoder_implementation_name);
4690}
4691
eladalonf1841382017-06-12 01:16:46 -07004692TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004693 FakeVideoSendStream* stream = AddSendStream();
4694 webrtc::VideoSendStream::Stats stats;
4695 stats.avg_encode_time_ms = 13;
4696 stats.encode_usage_percent = 42;
4697 stream->SetStats(stats);
4698
4699 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004700 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004701 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4702 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4703}
4704
eladalonf1841382017-06-12 01:16:46 -07004705TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004706 FakeVideoSendStream* stream = AddSendStream();
4707 webrtc::VideoSendStream::Stats stats;
4708 stats.frames_encoded = 13;
4709 stream->SetStats(stats);
4710
4711 cricket::VideoMediaInfo info;
4712 ASSERT_TRUE(channel_->GetStats(&info));
4713 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4714}
4715
eladalonf1841382017-06-12 01:16:46 -07004716TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004717 FakeVideoSendStream* stream = AddSendStream();
4718 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004719 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004720 stream->SetStats(stats);
4721
4722 cricket::VideoMediaInfo info;
4723 ASSERT_TRUE(channel_->GetStats(&info));
4724 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4725}
4726
eladalonf1841382017-06-12 01:16:46 -07004727TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004728 FakeVideoSendStream* stream = AddSendStream();
4729 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004730 stats.substreams[17].width = 123;
4731 stats.substreams[17].height = 40;
4732 stats.substreams[42].width = 80;
4733 stats.substreams[42].height = 31;
4734 stats.substreams[11].width = 20;
4735 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004736 stream->SetStats(stats);
4737
4738 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004739 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004740 ASSERT_EQ(1u, info.senders.size());
4741 EXPECT_EQ(123, info.senders[0].send_frame_width);
4742 EXPECT_EQ(90, info.senders[0].send_frame_height);
4743}
4744
eladalonf1841382017-06-12 01:16:46 -07004745TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004746 FakeVideoSendStream* stream = AddSendStream();
4747 webrtc::VideoSendStream::Stats stats;
4748 stats.number_of_cpu_adapt_changes = 2;
4749 stats.cpu_limited_resolution = true;
4750 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004751
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004752 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004753 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004754 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004755 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004756 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004757}
4758
eladalonf1841382017-06-12 01:16:46 -07004759TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004760 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004761 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004762 stats.number_of_cpu_adapt_changes = 2;
4763 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004764 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004765 stream->SetStats(stats);
4766
4767 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004768 EXPECT_TRUE(channel_->GetStats(&info));
4769 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004770 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4771 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004772 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004773 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004774}
4775
eladalonf1841382017-06-12 01:16:46 -07004776TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004777 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4778 FakeVideoSendStream* stream = AddSendStream();
4779 webrtc::VideoSendStream::Stats stats;
4780 stats.bw_limited_resolution = true;
4781 stream->SetStats(stats);
4782
4783 cricket::VideoMediaInfo info;
4784 EXPECT_TRUE(channel_->GetStats(&info));
4785 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004786 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004787 info.senders[0].adapt_reason);
4788}
4789
Yves Gerey665174f2018-06-19 15:03:05 +02004790TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004791 FakeVideoSendStream* stream = AddSendStream();
4792 webrtc::VideoSendStream::Stats stats;
4793 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4794 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4795 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4796
4797 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4798 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4799 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4800
4801 stream->SetStats(stats);
4802
4803 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004804 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004805 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4806 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4807 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4808}
4809
eladalonf1841382017-06-12 01:16:46 -07004810TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004811 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4812 FakeVideoReceiveStream* stream = AddRecvStream();
4813 webrtc::VideoReceiveStream::Stats stats;
4814 stats.rtcp_packet_type_counts.fir_packets = 2;
4815 stats.rtcp_packet_type_counts.nack_packets = 3;
4816 stats.rtcp_packet_type_counts.pli_packets = 4;
4817 stream->SetStats(stats);
4818
4819 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004820 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004821 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004822 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004823 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004824 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004825 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004826 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004827}
4828
eladalonf1841382017-06-12 01:16:46 -07004829TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004830 FakeVideoReceiveStream* stream = AddRecvStream();
4831 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004832 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004833 stats.decode_ms = 2;
4834 stats.max_decode_ms = 3;
4835 stats.current_delay_ms = 4;
4836 stats.target_delay_ms = 5;
4837 stats.jitter_buffer_ms = 6;
4838 stats.min_playout_delay_ms = 7;
4839 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004840 stats.width = 9;
4841 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004842 stats.frame_counts.key_frames = 11;
4843 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004844 stats.frames_rendered = 13;
4845 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004846 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004847 stream->SetStats(stats);
4848
4849 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004850 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004851 EXPECT_EQ(stats.decoder_implementation_name,
4852 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004853 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4854 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4855 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4856 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4857 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4858 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4859 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004860 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4861 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004862 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4863 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004864 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004865 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004866 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004867 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004868}
4869
eladalonf1841382017-06-12 01:16:46 -07004870TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004871 FakeVideoReceiveStream* stream = AddRecvStream();
4872 webrtc::VideoReceiveStream::Stats stats;
4873 stats.rtp_stats.transmitted.payload_bytes = 2;
4874 stats.rtp_stats.transmitted.header_bytes = 3;
4875 stats.rtp_stats.transmitted.padding_bytes = 4;
4876 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004877 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004878 stats.rtcp_stats.fraction_lost = 7;
4879 stream->SetStats(stats);
4880
4881 cricket::VideoMediaInfo info;
4882 ASSERT_TRUE(channel_->GetStats(&info));
4883 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4884 stats.rtp_stats.transmitted.header_bytes +
4885 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004886 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004887 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004888 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004889 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004890 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004891 info.receivers[0].fraction_lost);
4892}
4893
eladalonf1841382017-06-12 01:16:46 -07004894TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004895 AddSendStream();
4896 AddSendStream();
4897 webrtc::Call::Stats stats;
4898 stats.rtt_ms = 123;
4899 fake_call_->SetStats(stats);
4900
4901 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004902 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004903 ASSERT_EQ(2u, info.senders.size());
4904 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4905 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4906}
4907
eladalonf1841382017-06-12 01:16:46 -07004908TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004909 FakeVideoSendStream* stream = AddSendStream();
4910 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004911 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004912 stats.media_bitrate_bps = 123;
4913 stats.substreams[17].total_bitrate_bps = 1;
4914 stats.substreams[17].retransmit_bitrate_bps = 2;
4915 stats.substreams[42].total_bitrate_bps = 3;
4916 stats.substreams[42].retransmit_bitrate_bps = 4;
4917 stream->SetStats(stats);
4918
4919 FakeVideoSendStream* stream2 = AddSendStream();
4920 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004921 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004922 stats2.media_bitrate_bps = 321;
4923 stats2.substreams[13].total_bitrate_bps = 5;
4924 stats2.substreams[13].retransmit_bitrate_bps = 6;
4925 stats2.substreams[21].total_bitrate_bps = 7;
4926 stats2.substreams[21].retransmit_bitrate_bps = 8;
4927 stream2->SetStats(stats2);
4928
4929 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004930 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004931 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004932 BandwidthEstimationInfo bwe_info;
4933 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004934 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4935 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4936 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4937 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004938 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004939 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004940 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004941 bwe_info.actual_enc_bitrate);
4942 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004943 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004944 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004945 << "Bandwidth stats should take all streams into account.";
4946}
4947
eladalonf1841382017-06-12 01:16:46 -07004948TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004949 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004950
Peter Boström0c4e06b2015-10-07 12:23:21 +02004951 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4952 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004953
4954 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4955 const size_t kDataLength = 12;
4956 uint8_t data[kDataLength];
4957 memset(data, 0, sizeof(data));
4958 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004959 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004960 rtc::PacketTime packet_time;
4961 channel_->OnPacketReceived(&packet, packet_time);
4962
4963 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4964 << "No default receive stream created.";
4965 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004966 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004967 << "Default receive stream should not have configured RTX";
4968
4969 EXPECT_TRUE(channel_->AddRecvStream(
4970 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4971 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004972 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004973 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004974 EXPECT_FALSE(
4975 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004976 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004977 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004978 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004979 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004980 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004981 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004982}
4983
eladalonf1841382017-06-12 01:16:46 -07004984TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004985 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004986
Peter Boström0c4e06b2015-10-07 12:23:21 +02004987 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4988 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004989
4990 StreamParams sp =
4991 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4992 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4993
4994 EXPECT_FALSE(channel_->AddSendStream(sp));
4995 EXPECT_FALSE(channel_->AddRecvStream(sp));
4996}
4997
eladalonf1841382017-06-12 01:16:46 -07004998TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004999 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005000
Peter Boström0c4e06b2015-10-07 12:23:21 +02005001 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5002 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005003
5004 StreamParams sp =
5005 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5006
5007 EXPECT_TRUE(channel_->AddSendStream(sp));
5008 EXPECT_TRUE(channel_->AddRecvStream(sp));
5009
5010 // The RTX SSRC is already used in previous streams, using it should fail.
5011 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5012 EXPECT_FALSE(channel_->AddSendStream(sp));
5013 EXPECT_FALSE(channel_->AddRecvStream(sp));
5014
5015 // After removing the original stream this should be fine to add (makes sure
5016 // that RTX ssrcs are not forever taken).
5017 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5018 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5019 EXPECT_TRUE(channel_->AddSendStream(sp));
5020 EXPECT_TRUE(channel_->AddRecvStream(sp));
5021}
5022
eladalonf1841382017-06-12 01:16:46 -07005023TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005024 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005025 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5026 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005027 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005028
Peter Boströmd6f4c252015-03-26 16:23:04 +01005029 StreamParams sp =
5030 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5031
5032 EXPECT_TRUE(channel_->AddSendStream(sp));
5033 EXPECT_TRUE(channel_->AddRecvStream(sp));
5034
5035 // One of the SSRCs is already used in previous streams, using it should fail.
5036 sp = cricket::CreateSimStreamParams("cname",
5037 MAKE_VECTOR(kOverlappingStreamSsrcs));
5038 EXPECT_FALSE(channel_->AddSendStream(sp));
5039 EXPECT_FALSE(channel_->AddRecvStream(sp));
5040
5041 // After removing the original stream this should be fine to add (makes sure
5042 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005043 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5044 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005045 EXPECT_TRUE(channel_->AddSendStream(sp));
5046 EXPECT_TRUE(channel_->AddRecvStream(sp));
5047}
5048
eladalonf1841382017-06-12 01:16:46 -07005049TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005050 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005051
5052 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5053 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5054
5055 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5056 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5057
5058 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5059
5060 static const uint32_t kReceiverSsrcs[] = {3};
5061 static const uint32_t kReceiverRtxSsrcs[] = {2};
5062
5063 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5064 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5065 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5066
5067 cricket::VideoMediaInfo info;
5068 ASSERT_TRUE(channel_->GetStats(&info));
5069
5070 ASSERT_EQ(1u, info.senders.size());
5071 ASSERT_EQ(1u, info.receivers.size());
5072
5073 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5074 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5075 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5076}
5077
eladalonf1841382017-06-12 01:16:46 -07005078TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005079 FakeVideoReceiveStream* stream = AddRecvStream();
5080 webrtc::VideoReceiveStream::Stats stats;
5081 cricket::VideoMediaInfo info;
5082
5083 // Report no codec name before receiving.
5084 stream->SetStats(stats);
5085 ASSERT_TRUE(channel_->GetStats(&info));
5086 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5087
5088 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005089 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005090 stream->SetStats(stats);
5091 ASSERT_TRUE(channel_->GetStats(&info));
5092 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5093
5094 // Report no codec name for unknown playload types.
5095 stats.current_payload_type = 3;
5096 stream->SetStats(stats);
5097 ASSERT_TRUE(channel_->GetStats(&info));
5098 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5099}
5100
Seth Hampson5897a6e2018-04-03 11:16:33 -07005101// Tests that when we add a stream without SSRCs, but contains a stream_id
5102// that it is stored and its stream id is later used when the first packet
5103// arrives to properly create a receive stream with a sync label.
5104TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5105 const char kSyncLabel[] = "sync_label";
5106 cricket::StreamParams unsignaled_stream;
5107 unsignaled_stream.set_stream_ids({kSyncLabel});
5108 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5109 // The stream shouldn't have been created at this point because it doesn't
5110 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005111 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005112
5113 // Create and deliver packet.
5114 const size_t kDataLength = 12;
5115 uint8_t data[kDataLength];
5116 memset(data, 0, sizeof(data));
5117 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5118 rtc::CopyOnWriteBuffer packet(data, kDataLength);
5119 rtc::PacketTime packet_time;
5120 channel_->OnPacketReceived(&packet, packet_time);
5121
5122 // The stream should now be created with the appropriate sync label.
5123 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5124 EXPECT_EQ(kSyncLabel,
5125 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5126
5127 // Removing the unsignaled stream should clear the cache. This time when
5128 // a default video receive stream is created it won't have a sync_group.
5129 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5130 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5131 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5132
5133 channel_->OnPacketReceived(&packet, packet_time);
5134 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5135 EXPECT_TRUE(
5136 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5137}
5138
eladalonf1841382017-06-12 01:16:46 -07005139void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005140 uint8_t payload_type,
5141 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005142 // kRedRtxPayloadType must currently be unused.
5143 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5144
noahricd10a68e2015-07-10 11:27:55 -07005145 // Add a RED RTX codec.
5146 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005147 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005148 recv_parameters_.codecs.push_back(red_rtx_codec);
5149 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005150
5151 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5152 const size_t kDataLength = 12;
5153 uint8_t data[kDataLength];
5154 memset(data, 0, sizeof(data));
5155
5156 rtc::Set8(data, 1, payload_type);
5157 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005158 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07005159 rtc::PacketTime packet_time;
5160 channel_->OnPacketReceived(&packet, packet_time);
5161
5162 if (expect_created_receive_stream) {
5163 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5164 << "Should have created a receive stream for payload type: "
5165 << payload_type;
5166 } else {
5167 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5168 << "Shouldn't have created a receive stream for payload type: "
5169 << payload_type;
5170 }
5171}
5172
eladalonf1841382017-06-12 01:16:46 -07005173TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005174 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5175 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005176}
5177
eladalonf1841382017-06-12 01:16:46 -07005178TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005179 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5180 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005181}
5182
eladalonf1841382017-06-12 01:16:46 -07005183TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005184 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005185 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5186 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5187 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5188 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005189}
5190
eladalonf1841382017-06-12 01:16:46 -07005191TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005192 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5193 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005194}
5195
eladalonf1841382017-06-12 01:16:46 -07005196TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005197 FlexfecPacketDoesntCreateUnsignalledStream) {
5198 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5199 false /* expect_created_receive_stream */);
5200}
5201
eladalonf1841382017-06-12 01:16:46 -07005202TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005203 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5204 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005205}
5206
mzanaty8a855d62017-02-17 15:46:43 -08005207// Test that receiving any unsignalled SSRC works even if it changes.
5208// The first unsignalled SSRC received will create a default receive stream.
5209// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005210TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005211 // Allow receiving VP8, VP9, H264 (if enabled).
5212 cricket::VideoRecvParameters parameters;
5213 parameters.codecs.push_back(GetEngineCodec("VP8"));
5214 parameters.codecs.push_back(GetEngineCodec("VP9"));
5215
5216#if defined(WEBRTC_USE_H264)
5217 cricket::VideoCodec H264codec(126, "H264");
5218 parameters.codecs.push_back(H264codec);
5219#endif
5220
5221 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5222 // No receive streams yet.
5223 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5224 cricket::FakeVideoRenderer renderer;
5225 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5226
5227 // Receive VP8 packet on first SSRC.
5228 uint8_t data[kMinRtpPacketLen];
5229 cricket::RtpHeader rtpHeader;
5230 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5231 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005232 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005233 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5234 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5235 rtc::PacketTime packet_time;
5236 channel_->OnPacketReceived(&packet, packet_time);
5237 // VP8 packet should create default receive stream.
5238 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005239 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005240 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5241 // Verify that the receive stream sinks to a renderer.
5242 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5243 webrtc::kVideoRotation_0);
5244 recv_stream->InjectFrame(video_frame);
5245 EXPECT_EQ(1, renderer.num_rendered_frames());
5246
5247 // Receive VP9 packet on second SSRC.
5248 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005249 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005250 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5251 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5252 channel_->OnPacketReceived(&packet2, packet_time);
5253 // VP9 packet should replace the default receive SSRC.
5254 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5255 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5256 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5257 // Verify that the receive stream sinks to a renderer.
5258 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005259 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005260 recv_stream->InjectFrame(video_frame2);
5261 EXPECT_EQ(2, renderer.num_rendered_frames());
5262
5263#if defined(WEBRTC_USE_H264)
5264 // Receive H264 packet on third SSRC.
5265 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005266 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005267 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5268 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5269 channel_->OnPacketReceived(&packet3, packet_time);
5270 // H264 packet should replace the default receive SSRC.
5271 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5272 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5273 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5274 // Verify that the receive stream sinks to a renderer.
5275 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005276 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005277 recv_stream->InjectFrame(video_frame3);
5278 EXPECT_EQ(3, renderer.num_rendered_frames());
5279#endif
5280}
5281
brandtr0dc57ea2017-05-29 23:33:31 -07005282// This test verifies that when a new default stream is created for a new
5283// unsignaled SSRC, the new stream does not overwrite any old stream that had
5284// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005285TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005286 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5287 cricket::VideoRecvParameters parameters;
5288 parameters.codecs.push_back(GetEngineCodec("VP8"));
5289 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5290
5291 // No streams signaled and no packets received, so we should not have any
5292 // stream objects created yet.
5293 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5294
5295 // Receive packet on an unsignaled SSRC.
5296 uint8_t data[kMinRtpPacketLen];
5297 cricket::RtpHeader rtp_header;
5298 rtp_header.payload_type = GetEngineCodec("VP8").id;
5299 rtp_header.seq_num = rtp_header.timestamp = 0;
5300 rtp_header.ssrc = kSsrcs3[0];
5301 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5302 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5303 rtc::PacketTime packet_time;
5304 channel_->OnPacketReceived(&packet, packet_time);
5305 // Default receive stream should be created.
5306 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5307 FakeVideoReceiveStream* recv_stream0 =
5308 fake_call_->GetVideoReceiveStreams()[0];
5309 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5310
5311 // Signal the SSRC.
5312 EXPECT_TRUE(
5313 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5314 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5315 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5316 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5317
5318 // Receive packet on a different unsignaled SSRC.
5319 rtp_header.ssrc = kSsrcs3[1];
5320 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5321 packet.SetData(data, sizeof(data));
5322 channel_->OnPacketReceived(&packet, packet_time);
5323 // New default receive stream should be created, but old stream should remain.
5324 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5325 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5326 FakeVideoReceiveStream* recv_stream1 =
5327 fake_call_->GetVideoReceiveStreams()[1];
5328 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5329}
5330
Seth Hampson7c682e02018-05-04 16:28:15 -07005331TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005332 AddSendStream();
5333
Tommi85959932018-02-07 19:26:06 +01005334 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005335 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005336 cricket::VideoFormat capture_format_hd =
5337 capturer.GetSupportedFormats()->front();
5338 EXPECT_EQ(1280, capture_format_hd.width);
5339 EXPECT_EQ(720, capture_format_hd.height);
5340 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5341 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005342 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005343
perkjfa10b552016-10-02 23:45:26 -07005344 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005345 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005346
5347 // TODO(skvlad): Resolve the inconsistency between the interpretation
5348 // of the global bitrate limit for audio and video:
5349 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5350 // max_bandwidth_bps = -1 - remove the bandwidth limit
5351 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005352 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005353
perkjfa10b552016-10-02 23:45:26 -07005354 SetAndExpectMaxBitrate(1000, 0, 1000);
5355 SetAndExpectMaxBitrate(1000, 800, 800);
5356 SetAndExpectMaxBitrate(600, 800, 600);
5357 SetAndExpectMaxBitrate(0, 800, 800);
5358 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005359
Niels Möllerff40b142018-04-09 08:49:14 +02005360 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005361}
5362
eladalonf1841382017-06-12 01:16:46 -07005363TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005364 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005365 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005366 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005367
5368 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005369 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005370 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005371}
5372
eladalonf1841382017-06-12 01:16:46 -07005373TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005374 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005375 FakeVideoSendStream* stream = AddSendStream();
5376
Seth Hampson7c682e02018-05-04 16:28:15 -07005377 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5378 EXPECT_EQ(1UL, parameters.encodings.size());
5379 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5380 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5381
5382 // Note that this is testing the behavior of the FakeVideoSendStream, which
5383 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5384 // we are just testing the behavior of
5385 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005386 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5387 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005388
5389 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5390 // by this amount.
5391 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5392 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5393 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5394 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5395
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005396 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5397 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5398 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5399}
5400
5401TEST_F(WebRtcVideoChannelTest,
5402 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5403 FakeVideoSendStream* stream = AddSendStream();
5404
5405 // Note that this is testing the behavior of the FakeVideoSendStream, which
5406 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5407 // we are just testing the behavior of
5408 // EncoderStreamFactory::CreateEncoderStreams.
5409 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5410 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5411
5412 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5413 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5414 EXPECT_EQ(1UL, parameters.encodings.size());
5415 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5416 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5417
5418 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5419 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5420 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5421}
5422
5423TEST_F(WebRtcVideoChannelTest,
5424 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5425 send_parameters_.max_bandwidth_bps = 99999;
5426 FakeVideoSendStream* stream = AddSendStream();
5427 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5428 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5429 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5430 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5431 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5432 stream->GetVideoStreams()[0].max_bitrate_bps);
5433
5434 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5435 // adjusted down.
5436 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5437 EXPECT_EQ(1UL, parameters.encodings.size());
5438 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5439 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5440 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5441 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5442 stream->GetVideoStreams()[0].min_bitrate_bps);
5443 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5444 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005445}
5446
Åsa Persson8c1bf952018-09-13 10:42:19 +02005447TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5448 FakeVideoSendStream* stream = AddSendStream();
5449
5450 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5451 EXPECT_EQ(1UL, parameters.encodings.size());
5452 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5453 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5454
5455 // Note that this is testing the behavior of the FakeVideoSendStream, which
5456 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5457 // we are just testing the behavior of
5458 // EncoderStreamFactory::CreateEncoderStreams.
5459 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5460 EXPECT_EQ(kDefaultVideoMaxFramerate,
5461 stream->GetVideoStreams()[0].max_framerate);
5462
5463 // Set max framerate and check that VideoStream.max_framerate is set.
5464 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5465 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5466 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5467 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5468
5469 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5470 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5471}
5472
Åsa Persson23eba222018-10-02 14:47:06 +02005473TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5474 FakeVideoSendStream* stream = AddSendStream();
5475
5476 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5477 EXPECT_EQ(1UL, parameters.encodings.size());
5478 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5479 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5480
5481 // Note that this is testing the behavior of the FakeVideoSendStream, which
5482 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5483 // we are just testing the behavior of
5484 // EncoderStreamFactory::CreateEncoderStreams.
5485 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5486 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5487
5488 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5489 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5490 parameters.encodings[0].num_temporal_layers = 2;
5491 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5492
5493 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5494 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5495}
5496
Seth Hampson7c682e02018-05-04 16:28:15 -07005497TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005498 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005499 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005500 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005501 // Two or more encodings should result in failure.
5502 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005503 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005504 // Zero encodings should also fail.
5505 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005506 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005507}
5508
Zach Stein3ca452b2018-01-18 10:01:24 -08005509TEST_F(WebRtcVideoChannelTest,
5510 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5511 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5512 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5513 AddSendStream(sp);
5514
5515 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5516
5517 // Additional encodings should result in failure.
5518 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005519 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005520 // Zero encodings should also fail.
5521 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005522 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005523}
5524
deadbeeffb2aced2017-01-06 23:05:37 -08005525// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005526TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005527 AddSendStream();
5528 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005529 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005530 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005531}
5532
Seth Hampson24722b32017-12-22 09:36:42 -08005533// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5534// a value <= 0, setting the parameters returns false.
5535TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5536 AddSendStream();
5537 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5538 EXPECT_EQ(1UL, parameters.encodings.size());
5539 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5540 parameters.encodings[0].bitrate_priority);
5541
5542 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005543 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005544 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005545 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005546}
5547
5548// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5549// properly on the VideoChannel and propogates down to the video encoder.
5550TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5551 AddSendStream();
5552 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5553 EXPECT_EQ(1UL, parameters.encodings.size());
5554 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5555 parameters.encodings[0].bitrate_priority);
5556
5557 // Change the value and set it on the VideoChannel.
5558 double new_bitrate_priority = 2.0;
5559 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005560 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005561
5562 // Verify that the encoding parameters bitrate_priority is set for the
5563 // VideoChannel.
5564 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5565 EXPECT_EQ(1UL, parameters.encodings.size());
5566 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5567
5568 // Verify that the new value propagated down to the encoder.
5569 std::vector<FakeVideoSendStream*> video_send_streams =
5570 fake_call_->GetVideoSendStreams();
5571 EXPECT_EQ(1UL, video_send_streams.size());
5572 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5573 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5574 // appropriately.
5575 EXPECT_EQ(new_bitrate_priority,
5576 video_send_stream->GetEncoderConfig().bitrate_priority);
5577 // Check that the vector of VideoStreams also was propagated correctly. Note
5578 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5579 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005580 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005581 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5582}
5583
5584// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5585// VideoChannel and the value propogates to the video encoder with all simulcast
5586// streams.
5587TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5588 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005589 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005590 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5591 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5592 AddSendStream(stream_params);
5593 uint32_t primary_ssrc = stream_params.first_ssrc();
5594
Tommi85959932018-02-07 19:26:06 +01005595 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5596 // frame. This creates multiple VideoStreams for all simulcast layers when
5597 // reconfiguring, and allows us to test this behavior.
5598 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005599 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005600 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005601 EXPECT_EQ(cricket::CS_RUNNING,
5602 capturer.Start(cricket::VideoFormat(
5603 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5604 cricket::FOURCC_I420)));
5605 channel_->SetSend(true);
5606 EXPECT_TRUE(capturer.CaptureFrame());
5607 // Get and set the rtp encoding parameters.
5608 webrtc::RtpParameters parameters =
5609 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005610 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005611 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5612 parameters.encodings[0].bitrate_priority);
5613 // Change the value and set it on the VideoChannel.
5614 double new_bitrate_priority = 2.0;
5615 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005616 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005617
5618 // Verify that the encoding parameters priority is set on the VideoChannel.
5619 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005620 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005621 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5622
5623 // Verify that the new value propagated down to the encoder.
5624 std::vector<FakeVideoSendStream*> video_send_streams =
5625 fake_call_->GetVideoSendStreams();
5626 EXPECT_EQ(1UL, video_send_streams.size());
5627 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5628 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5629 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005630 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005631 video_send_stream->GetEncoderConfig().number_of_streams);
5632 EXPECT_EQ(new_bitrate_priority,
5633 video_send_stream->GetEncoderConfig().bitrate_priority);
5634 // Check that the vector of VideoStreams also propagated correctly. The
5635 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5636 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005637 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005638 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005639 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5640 // Since we are only setting bitrate priority per-sender, the other
5641 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005642 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005643 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005644 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005645 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005646 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005647}
5648
Åsa Persson8c1bf952018-09-13 10:42:19 +02005649TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5650 const size_t kNumSimulcastStreams = 3;
5651 SetUpSimulcast(true, false);
5652
5653 // Get and set the rtp encoding parameters.
5654 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5655 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5656 for (const auto& encoding : parameters.encodings) {
5657 EXPECT_FALSE(encoding.max_framerate);
5658 }
5659
5660 // Change the value and set it on the VideoChannel.
5661 parameters.encodings[0].max_framerate = 10;
5662 parameters.encodings[1].max_framerate = 20;
5663 parameters.encodings[2].max_framerate = 25;
5664 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5665
5666 // Verify that the bitrates are set on the VideoChannel.
5667 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5668 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5669 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5670 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5671 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5672}
5673
Åsa Persson23eba222018-10-02 14:47:06 +02005674TEST_F(WebRtcVideoChannelTest,
5675 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5676 const size_t kNumSimulcastStreams = 3;
5677 SetUpSimulcast(true, false);
5678
5679 // Get and set the rtp encoding parameters.
5680 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5681 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5682
5683 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5684 parameters.encodings[0].num_temporal_layers = 0;
5685 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5686 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5687 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5688 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5689 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5690}
5691
5692TEST_F(WebRtcVideoChannelTest,
5693 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5694 const size_t kNumSimulcastStreams = 3;
5695 SetUpSimulcast(true, false);
5696
5697 // Get and set the rtp encoding parameters.
5698 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5699 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5700
5701 // No/all layers should be set.
5702 parameters.encodings[0].num_temporal_layers = 1;
5703 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5704 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5705
5706 // Different values not supported.
5707 parameters.encodings[0].num_temporal_layers = 1;
5708 parameters.encodings[1].num_temporal_layers = 2;
5709 parameters.encodings[2].num_temporal_layers = 2;
5710 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5711 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5712}
5713
5714TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5715 const size_t kNumSimulcastStreams = 3;
5716 SetUpSimulcast(true, false);
5717
5718 // Get and set the rtp encoding parameters.
5719 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5720 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5721 for (const auto& encoding : parameters.encodings)
5722 EXPECT_FALSE(encoding.num_temporal_layers);
5723
5724 // Change the value and set it on the VideoChannel.
5725 parameters.encodings[0].num_temporal_layers = 3;
5726 parameters.encodings[1].num_temporal_layers = 3;
5727 parameters.encodings[2].num_temporal_layers = 3;
5728 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5729
5730 // Verify that the number of temporal layers are set on the VideoChannel.
5731 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5732 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5733 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5734 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5735 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5736}
5737
5738TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5739 const size_t kNumSimulcastStreams = 3;
5740 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5741
5742 // Send a full size frame so all simulcast layers are used when reconfiguring.
5743 FakeVideoCapturerWithTaskQueue capturer;
5744 VideoOptions options;
5745 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5746 EXPECT_EQ(cricket::CS_RUNNING,
5747 capturer.Start(capturer.GetSupportedFormats()->front()));
5748 channel_->SetSend(true);
5749 EXPECT_TRUE(capturer.CaptureFrame());
5750
5751 // Get and set the rtp encoding parameters.
5752 // Change the value and set it on the VideoChannel.
5753 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5754 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5755 parameters.encodings[0].num_temporal_layers = 2;
5756 parameters.encodings[1].num_temporal_layers = 2;
5757 parameters.encodings[2].num_temporal_layers = 2;
5758 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5759
5760 // Verify that the new value is propagated down to the encoder.
5761 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5762 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5763 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5764 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5765 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5766 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5767 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5768 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5769
5770 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5771 // VideoStreams are created appropriately for the simulcast case.
5772 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5773 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5774 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5775 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5776
5777 // No parameter changed, encoder should not be reconfigured.
5778 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5779 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5780
5781 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5782}
5783
5784TEST_F(WebRtcVideoChannelTest,
5785 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5786 const size_t kDefaultNumTemporalLayers = 3;
5787 const size_t kNumSimulcastStreams = 3;
5788 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5789
5790 // Send a full size frame so all simulcast layers are used when reconfiguring.
5791 FakeVideoCapturerWithTaskQueue capturer;
5792 VideoOptions options;
5793 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5794 EXPECT_EQ(cricket::CS_RUNNING,
5795 capturer.Start(capturer.GetSupportedFormats()->front()));
5796 channel_->SetSend(true);
5797 EXPECT_TRUE(capturer.CaptureFrame());
5798
5799 // Change rtp encoding parameters, num_temporal_layers not changed.
5800 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5801 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5802 parameters.encodings[0].min_bitrate_bps = 33000;
5803 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5804
5805 // Verify that no value is propagated down to the encoder.
5806 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5807 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5808 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5809 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5810 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5811 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5812
5813 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5814 // VideoStreams are created appropriately for the simulcast case.
5815 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5816 EXPECT_EQ(kDefaultNumTemporalLayers,
5817 stream->GetVideoStreams()[0].num_temporal_layers);
5818 EXPECT_EQ(kDefaultNumTemporalLayers,
5819 stream->GetVideoStreams()[1].num_temporal_layers);
5820 EXPECT_EQ(kDefaultNumTemporalLayers,
5821 stream->GetVideoStreams()[2].num_temporal_layers);
5822
5823 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5824}
5825
Åsa Persson8c1bf952018-09-13 10:42:19 +02005826TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5827 const size_t kNumSimulcastStreams = 3;
5828 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5829
5830 // Send a full size frame so all simulcast layers are used when reconfiguring.
5831 FakeVideoCapturerWithTaskQueue capturer;
5832 VideoOptions options;
5833 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5834 EXPECT_EQ(cricket::CS_RUNNING,
5835 capturer.Start(capturer.GetSupportedFormats()->front()));
5836 channel_->SetSend(true);
5837 EXPECT_TRUE(capturer.CaptureFrame());
5838
5839 // Get and set the rtp encoding parameters.
5840 // Change the value and set it on the VideoChannel.
5841 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5842 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5843 parameters.encodings[0].max_framerate = 15;
5844 parameters.encodings[1].max_framerate = 25;
5845 parameters.encodings[2].max_framerate = 20;
5846 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5847
5848 // Verify that the new value propagated down to the encoder.
5849 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5850 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5851 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5852 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5853 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5854 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5855 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5856 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5857
5858 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5859 // VideoStreams are created appropriately for the simulcast case.
5860 // Currently the maximum |max_framerate| is used.
5861 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5862 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5863 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5864 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5865
5866 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5867}
5868
5869TEST_F(WebRtcVideoChannelTest,
5870 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5871 const size_t kNumSimulcastStreams = 3;
5872 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5873 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5874
5875 // Send a full size frame so all simulcast layers are used when reconfiguring.
5876 FakeVideoCapturerWithTaskQueue capturer;
5877 VideoOptions options;
5878 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5879 EXPECT_EQ(cricket::CS_RUNNING,
5880 capturer.Start(capturer.GetSupportedFormats()->front()));
5881 channel_->SetSend(true);
5882 EXPECT_TRUE(capturer.CaptureFrame());
5883
5884 // Get and set the rtp encoding parameters.
5885 // Change the value and set it on the VideoChannel.
5886 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5887 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5888 parameters.encodings[0].max_framerate = 15;
5889 parameters.encodings[2].max_framerate = 20;
5890 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5891
5892 // Verify that the new value propagated down to the encoder.
5893 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5894 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5895 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5896 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5897 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5898 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5899 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5900
5901 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5902 // VideoStreams are created appropriately for the simulcast case.
5903 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5904 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5905 EXPECT_EQ(kDefaultVideoMaxFramerate,
5906 stream->GetVideoStreams()[0].max_framerate);
5907 EXPECT_EQ(kDefaultVideoMaxFramerate,
5908 stream->GetVideoStreams()[1].max_framerate);
5909 EXPECT_EQ(kDefaultVideoMaxFramerate,
5910 stream->GetVideoStreams()[2].max_framerate);
5911
5912 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5913}
5914
Åsa Persson55659812018-06-18 17:51:32 +02005915TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5916 const size_t kNumSimulcastStreams = 3;
5917 SetUpSimulcast(true, false);
5918
5919 // Get and set the rtp encoding parameters.
5920 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5921 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5922 for (const auto& encoding : parameters.encodings) {
5923 EXPECT_FALSE(encoding.min_bitrate_bps);
5924 EXPECT_FALSE(encoding.max_bitrate_bps);
5925 }
5926
5927 // Change the value and set it on the VideoChannel.
5928 parameters.encodings[0].min_bitrate_bps = 100000;
5929 parameters.encodings[0].max_bitrate_bps = 200000;
5930 parameters.encodings[1].min_bitrate_bps = 300000;
5931 parameters.encodings[1].max_bitrate_bps = 400000;
5932 parameters.encodings[2].min_bitrate_bps = 500000;
5933 parameters.encodings[2].max_bitrate_bps = 600000;
5934 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5935
5936 // Verify that the bitrates are set on the VideoChannel.
5937 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5938 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5939 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
5940 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
5941 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
5942 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
5943 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
5944 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
5945}
5946
5947TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
5948 const size_t kNumSimulcastStreams = 3;
5949 SetUpSimulcast(true, false);
5950
5951 // Get and set the rtp encoding parameters.
5952 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5953 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5954
5955 // Max bitrate lower than min bitrate should fail.
5956 parameters.encodings[2].min_bitrate_bps = 100000;
5957 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
5958 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5959 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5960}
5961
5962// Test that min and max bitrate values set via RtpParameters are correctly
5963// propagated to the underlying encoder, and that the target is set to 3/4 of
5964// the maximum (3/4 was chosen because it's similar to the simulcast defaults
5965// that are used if no min/max are specified).
5966TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
5967 const size_t kNumSimulcastStreams = 3;
5968 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5969
5970 // Send a full size frame so all simulcast layers are used when reconfiguring.
5971 FakeVideoCapturerWithTaskQueue capturer;
5972 VideoOptions options;
5973 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5974 EXPECT_EQ(cricket::CS_RUNNING,
5975 capturer.Start(capturer.GetSupportedFormats()->front()));
5976 channel_->SetSend(true);
5977 EXPECT_TRUE(capturer.CaptureFrame());
5978
5979 // Get and set the rtp encoding parameters.
5980 // Change the value and set it on the VideoChannel.
5981 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5982 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5983 parameters.encodings[0].min_bitrate_bps = 100000;
5984 parameters.encodings[0].max_bitrate_bps = 200000;
5985 parameters.encodings[1].min_bitrate_bps = 300000;
5986 parameters.encodings[1].max_bitrate_bps = 400000;
5987 parameters.encodings[2].min_bitrate_bps = 500000;
5988 parameters.encodings[2].max_bitrate_bps = 600000;
5989 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5990
5991 // Verify that the new value propagated down to the encoder.
5992 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5993 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5994 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5995 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5996 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5997 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
5998 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
5999 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6000 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6001 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6002 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6003
6004 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6005 // VideoStreams are created appropriately for the simulcast case.
6006 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6007 // Target bitrate: 200000 * 3 / 4 = 150000.
6008 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6009 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6010 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6011 // Target bitrate: 400000 * 3 / 4 = 300000.
6012 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6013 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6014 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6015 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6016 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6017 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6018 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6019
6020 // No parameter changed, encoder should not be reconfigured.
6021 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6022 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6023
6024 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6025}
6026
6027// Test to only specify the min or max bitrate value for a layer via
6028// RtpParameters. The unspecified min/max and target value should be set to the
6029// simulcast default that is used if no min/max are specified.
6030TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6031 const size_t kNumSimulcastStreams = 3;
6032 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6033 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6034
6035 // Send a full size frame so all simulcast layers are used when reconfiguring.
6036 FakeVideoCapturerWithTaskQueue capturer;
6037 VideoOptions options;
6038 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6039 EXPECT_EQ(cricket::CS_RUNNING,
6040 capturer.Start(capturer.GetSupportedFormats()->front()));
6041 channel_->SetSend(true);
6042 EXPECT_TRUE(capturer.CaptureFrame());
6043
6044 // Get and set the rtp encoding parameters.
6045 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6046 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6047
6048 // Change the value and set it on the VideoChannel.
6049 // Layer 0: only configure min bitrate.
6050 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6051 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6052 // Layer 1: only configure max bitrate.
6053 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6054 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6055 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6056
6057 // Verify that the new value propagated down to the encoder.
6058 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6059 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6060 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6061 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6062 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6063 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6064 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6065 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6066 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6067 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6068
6069 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6070 // VideoStreams are created appropriately for the simulcast case.
6071 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6072 // Layer 0: min configured bitrate should overwrite min default.
6073 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6074 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6075 stream->GetVideoStreams()[0].target_bitrate_bps);
6076 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6077 stream->GetVideoStreams()[0].max_bitrate_bps);
6078 // Layer 1: max configured bitrate should overwrite max default.
6079 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6080 stream->GetVideoStreams()[1].min_bitrate_bps);
6081 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6082 stream->GetVideoStreams()[1].target_bitrate_bps);
6083 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6084 // Layer 2: min and max bitrate not configured, default expected.
6085 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6086 stream->GetVideoStreams()[2].min_bitrate_bps);
6087 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6088 stream->GetVideoStreams()[2].target_bitrate_bps);
6089 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6090 stream->GetVideoStreams()[2].max_bitrate_bps);
6091
6092 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6093}
6094
6095// Test that specifying the min (or max) bitrate value for a layer via
6096// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6097// unspecified values accordingly.
6098TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6099 const size_t kNumSimulcastStreams = 3;
6100 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6101 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6102
6103 // Send a full size frame so all simulcast layers are used when reconfiguring.
6104 FakeVideoCapturerWithTaskQueue capturer;
6105 VideoOptions options;
6106 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6107 EXPECT_EQ(cricket::CS_RUNNING,
6108 capturer.Start(capturer.GetSupportedFormats()->front()));
6109 channel_->SetSend(true);
6110 EXPECT_TRUE(capturer.CaptureFrame());
6111
6112 // Get and set the rtp encoding parameters.
6113 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6114 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6115
6116 // Change the value and set it on the VideoChannel.
6117 // For layer 0, set the min bitrate above the default max.
6118 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6119 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6120 // For layer 1, set the max bitrate below the default min.
6121 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6122 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6123 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6124
6125 // Verify that the new value propagated down to the encoder.
6126 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6127 // VideoStreams are created appropriately for the simulcast case.
6128 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6129 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6130 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6131 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6132 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6133 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6134 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6135 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6136 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6137 // Layer 2: min and max bitrate not configured, default expected.
6138 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6139 stream->GetVideoStreams()[2].min_bitrate_bps);
6140 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6141 stream->GetVideoStreams()[2].target_bitrate_bps);
6142 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6143 stream->GetVideoStreams()[2].max_bitrate_bps);
6144
6145 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6146}
6147
6148TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6149 const size_t kNumSimulcastStreams = 3;
6150 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6151 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6152
6153 // Send a full size frame so all simulcast layers are used when reconfiguring.
6154 FakeVideoCapturerWithTaskQueue capturer;
6155 VideoOptions options;
6156 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6157 EXPECT_EQ(cricket::CS_RUNNING,
6158 capturer.Start(capturer.GetSupportedFormats()->front()));
6159 channel_->SetSend(true);
6160 EXPECT_TRUE(capturer.CaptureFrame());
6161
6162 // Set max bitrate for all but the highest layer.
6163 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6164 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6165 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6166 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6167 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6168
6169 // Set max bandwidth equal to total max bitrate.
6170 send_parameters_.max_bandwidth_bps =
6171 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6172 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6173 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6174
6175 // No bitrate above the total max to give to the highest layer.
6176 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6177 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6178 stream->GetVideoStreams()[2].max_bitrate_bps);
6179
6180 // Set max bandwidth above the total max bitrate.
6181 send_parameters_.max_bandwidth_bps =
6182 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6183 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6184 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6185
6186 // The highest layer has no max bitrate set -> the bitrate above the total
6187 // max should be given to the highest layer.
6188 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6189 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6190 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6191 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6192 stream->GetVideoStreams()[2].max_bitrate_bps);
6193
6194 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6195}
6196
6197TEST_F(WebRtcVideoChannelTest,
6198 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6199 const size_t kNumSimulcastStreams = 3;
6200 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6201 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6202 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6203
6204 // Send a full size frame so all simulcast layers are used when reconfiguring.
6205 FakeVideoCapturerWithTaskQueue capturer;
6206 VideoOptions options;
6207 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6208 EXPECT_EQ(cricket::CS_RUNNING,
6209 capturer.Start(capturer.GetSupportedFormats()->front()));
6210 channel_->SetSend(true);
6211 EXPECT_TRUE(capturer.CaptureFrame());
6212
6213 // Set max bitrate for the highest layer.
6214 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6215 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6216 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6217 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6218
6219 // Set max bandwidth above the total max bitrate.
6220 send_parameters_.max_bandwidth_bps =
6221 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6222 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6223 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6224
6225 // The highest layer has the max bitrate set -> the bitrate above the total
6226 // max should not be given to the highest layer.
6227 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6228 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6229 stream->GetVideoStreams()[2].max_bitrate_bps);
6230
6231 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6232}
6233
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006234// Test that min and max bitrate values set via RtpParameters are correctly
6235// propagated to the underlying encoder for a single stream.
6236TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6237 FakeVideoSendStream* stream = AddSendStream();
6238 EXPECT_TRUE(channel_->SetSend(true));
6239 EXPECT_TRUE(stream->IsSending());
6240
6241 // Set min and max bitrate.
6242 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6243 EXPECT_EQ(1u, parameters.encodings.size());
6244 parameters.encodings[0].min_bitrate_bps = 80000;
6245 parameters.encodings[0].max_bitrate_bps = 150000;
6246 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6247
6248 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6249 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6250 EXPECT_EQ(1u, encoder_config.number_of_streams);
6251 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6252 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6253 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6254
6255 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6256 // VideoStreams are created appropriately.
6257 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6258 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6259 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6260 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6261}
6262
6263// Test the default min and max bitrate value are correctly propagated to the
6264// underlying encoder for a single stream (when the values are not set via
6265// RtpParameters).
6266TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6267 FakeVideoSendStream* stream = AddSendStream();
6268 EXPECT_TRUE(channel_->SetSend(true));
6269 EXPECT_TRUE(stream->IsSending());
6270
6271 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6272 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6273 EXPECT_EQ(1u, encoder_config.number_of_streams);
6274 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6275 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6276 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6277
6278 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6279 // VideoStreams are created appropriately.
6280 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6281 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6282 stream->GetVideoStreams()[0].min_bitrate_bps);
6283 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6284 stream->GetVideoStreams()[0].min_bitrate_bps);
6285 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6286 stream->GetVideoStreams()[0].target_bitrate_bps);
6287}
6288
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006289// Test that a stream will not be sending if its encoding is made inactive
6290// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006291TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006292 FakeVideoSendStream* stream = AddSendStream();
6293 EXPECT_TRUE(channel_->SetSend(true));
6294 EXPECT_TRUE(stream->IsSending());
6295
6296 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006297 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006298 ASSERT_EQ(1u, parameters.encodings.size());
6299 ASSERT_TRUE(parameters.encodings[0].active);
6300 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006301 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006302 EXPECT_FALSE(stream->IsSending());
6303
6304 // Now change it back to active and verify we resume sending.
6305 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006306 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006307 EXPECT_TRUE(stream->IsSending());
6308}
6309
Seth Hampson8234ead2018-02-02 15:16:24 -08006310// Tests that when active is updated for any simulcast layer then the send
6311// stream's sending state will be updated and it will be reconfigured with the
6312// new appropriate active simulcast streams.
6313TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6314 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006315 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006316 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6317 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6318 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6319 uint32_t primary_ssrc = stream_params.first_ssrc();
6320
Tommi85959932018-02-07 19:26:06 +01006321 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6322 // frame. This allows us to test that ReconfigureEncoder is called
6323 // appropriately.
6324 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006325 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006326 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006327 EXPECT_EQ(cricket::CS_RUNNING,
6328 capturer.Start(cricket::VideoFormat(
6329 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6330 cricket::FOURCC_I420)));
6331 channel_->SetSend(true);
6332 EXPECT_TRUE(capturer.CaptureFrame());
6333
6334 // Check that all encodings are initially active.
6335 webrtc::RtpParameters parameters =
6336 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006337 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006338 EXPECT_TRUE(parameters.encodings[0].active);
6339 EXPECT_TRUE(parameters.encodings[1].active);
6340 EXPECT_TRUE(parameters.encodings[2].active);
6341 EXPECT_TRUE(fake_video_send_stream->IsSending());
6342
6343 // Only turn on only the middle stream.
6344 parameters.encodings[0].active = false;
6345 parameters.encodings[1].active = true;
6346 parameters.encodings[2].active = false;
6347 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6348 // Verify that the active fields are set on the VideoChannel.
6349 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006350 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006351 EXPECT_FALSE(parameters.encodings[0].active);
6352 EXPECT_TRUE(parameters.encodings[1].active);
6353 EXPECT_FALSE(parameters.encodings[2].active);
6354 // Check that the VideoSendStream is updated appropriately. This means its
6355 // send state was updated and it was reconfigured.
6356 EXPECT_TRUE(fake_video_send_stream->IsSending());
6357 std::vector<webrtc::VideoStream> simulcast_streams =
6358 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006359 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006360 EXPECT_FALSE(simulcast_streams[0].active);
6361 EXPECT_TRUE(simulcast_streams[1].active);
6362 EXPECT_FALSE(simulcast_streams[2].active);
6363
6364 // Turn off all streams.
6365 parameters.encodings[0].active = false;
6366 parameters.encodings[1].active = false;
6367 parameters.encodings[2].active = false;
6368 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6369 // Verify that the active fields are set on the VideoChannel.
6370 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006371 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006372 EXPECT_FALSE(parameters.encodings[0].active);
6373 EXPECT_FALSE(parameters.encodings[1].active);
6374 EXPECT_FALSE(parameters.encodings[2].active);
6375 // Check that the VideoSendStream is off.
6376 EXPECT_FALSE(fake_video_send_stream->IsSending());
6377 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006378 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006379 EXPECT_FALSE(simulcast_streams[0].active);
6380 EXPECT_FALSE(simulcast_streams[1].active);
6381 EXPECT_FALSE(simulcast_streams[2].active);
6382
Niels Möllerff40b142018-04-09 08:49:14 +02006383 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006384}
6385
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006386// Test that if a stream is reconfigured (due to a codec change or other
6387// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006388TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006389 InactiveStreamDoesntStartSendingWhenReconfigured) {
6390 // Set an initial codec list, which will be modified later.
6391 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006392 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6393 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006394 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6395
6396 FakeVideoSendStream* stream = AddSendStream();
6397 EXPECT_TRUE(channel_->SetSend(true));
6398 EXPECT_TRUE(stream->IsSending());
6399
6400 // Get current parameters and change "active" to false.
6401 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6402 ASSERT_EQ(1u, parameters.encodings.size());
6403 ASSERT_TRUE(parameters.encodings[0].active);
6404 parameters.encodings[0].active = false;
6405 EXPECT_EQ(1u, GetFakeSendStreams().size());
6406 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006407 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006408 EXPECT_FALSE(stream->IsSending());
6409
6410 // Reorder the codec list, causing the stream to be reconfigured.
6411 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006412 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6413 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006414 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6415 auto new_streams = GetFakeSendStreams();
6416 // Assert that a new underlying stream was created due to the codec change.
6417 // Otherwise, this test isn't testing what it set out to test.
6418 EXPECT_EQ(1u, GetFakeSendStreams().size());
6419 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6420
6421 // Verify that we still are not sending anything, due to the inactive
6422 // encoding.
6423 EXPECT_FALSE(new_streams[0]->IsSending());
6424}
6425
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006426// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006427TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006428 AddSendStream();
6429 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006430 parameters.codecs.push_back(GetEngineCodec("VP8"));
6431 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006432 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6433
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006434 webrtc::RtpParameters rtp_parameters =
6435 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006436 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006437 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6438 rtp_parameters.codecs[0]);
6439 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6440 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006441}
6442
Florent Castellidacec712018-05-24 16:24:21 +02006443// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6444TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6445 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6446 params.cname = "rtcpcname";
6447 AddSendStream(params);
6448
6449 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6450 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6451}
6452
deadbeeffb2aced2017-01-06 23:05:37 -08006453// Test that RtpParameters for send stream has one encoding and it has
6454// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006455TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006456 AddSendStream();
6457
6458 webrtc::RtpParameters rtp_parameters =
6459 channel_->GetRtpSendParameters(last_ssrc_);
6460 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006461 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006462}
6463
Florent Castelliabe301f2018-06-12 18:33:49 +02006464TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6465 AddSendStream();
6466
6467 webrtc::RtpParameters rtp_parameters =
6468 channel_->GetRtpSendParameters(last_ssrc_);
6469 rtp_parameters.header_extensions.emplace_back();
6470
6471 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6472
6473 webrtc::RTCError result =
6474 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6475 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6476}
6477
Florent Castelli87b3c512018-07-18 16:00:28 +02006478TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6479 AddSendStream();
6480
6481 FakeVideoCapturerWithTaskQueue capturer;
6482 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6483
6484 webrtc::RtpParameters rtp_parameters =
6485 channel_->GetRtpSendParameters(last_ssrc_);
6486 EXPECT_EQ(rtp_parameters.degradation_preference,
6487 webrtc::DegradationPreference::BALANCED);
6488 rtp_parameters.degradation_preference =
6489 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6490
6491 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6492
6493 webrtc::RtpParameters updated_rtp_parameters =
6494 channel_->GetRtpSendParameters(last_ssrc_);
6495 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6496 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6497
6498 // Remove the source since it will be destroyed before the channel
6499 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6500}
6501
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006502// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006503TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006504 AddSendStream();
6505 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006506 parameters.codecs.push_back(GetEngineCodec("VP8"));
6507 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006508 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6509
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006510 webrtc::RtpParameters initial_params =
6511 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006512
6513 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006514 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006515
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006516 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6517 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6518}
6519
6520// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006521TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006522 AddRecvStream();
6523 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006524 parameters.codecs.push_back(GetEngineCodec("VP8"));
6525 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006526 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6527
6528 webrtc::RtpParameters rtp_parameters =
6529 channel_->GetRtpReceiveParameters(last_ssrc_);
6530 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006531 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6532 rtp_parameters.codecs[0]);
6533 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6534 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006535}
6536
johan073ece42016-08-26 02:59:47 -07006537#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006538TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006539#else
eladalonf1841382017-06-12 01:16:46 -07006540TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006541#endif
johan3859c892016-08-05 09:19:25 -07006542 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006543 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006544 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006545 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006546 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006547 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006548 parameters.codecs.push_back(kH264sprop2);
6549 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6550
6551 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6552 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6553 webrtc::RtpParameters rtp_parameters =
6554 channel_->GetRtpReceiveParameters(last_ssrc_);
6555 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6556 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6557 ASSERT_EQ(2u, cfg.decoders.size());
6558 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006559 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006560 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006561 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6562 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006563 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006564
6565 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006566 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006567 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006568 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6569 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006570 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006571}
6572
sakal1fd95952016-06-22 00:46:15 -07006573// Test that RtpParameters for receive stream has one encoding and it has
6574// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006575TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006576 AddRecvStream();
6577
6578 webrtc::RtpParameters rtp_parameters =
6579 channel_->GetRtpReceiveParameters(last_ssrc_);
6580 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006581 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006582}
6583
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006584// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006585TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006586 AddRecvStream();
6587 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006588 parameters.codecs.push_back(GetEngineCodec("VP8"));
6589 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006590 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6591
6592 webrtc::RtpParameters initial_params =
6593 channel_->GetRtpReceiveParameters(last_ssrc_);
6594
6595 // We should be able to set the params we just got.
6596 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6597
6598 // ... And this shouldn't change the params returned by
6599 // GetRtpReceiveParameters.
6600 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006601}
6602
deadbeef3bc15102017-04-20 19:25:07 -07006603// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6604// aren't signaled. It should always return an empty "RtpEncodingParameters",
6605// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006606TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006607 // Call necessary methods to configure receiving a default stream as
6608 // soon as it arrives.
6609 cricket::VideoRecvParameters parameters;
6610 parameters.codecs.push_back(GetEngineCodec("VP8"));
6611 parameters.codecs.push_back(GetEngineCodec("VP9"));
6612 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6613
6614 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6615 // stream. Should return nothing.
6616 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6617
6618 // Set a sink for an unsignaled stream.
6619 cricket::FakeVideoRenderer renderer;
6620 // Value of "0" means "unsignaled stream".
6621 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6622
6623 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6624 // in this method means "unsignaled stream".
6625 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6626 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6627 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6628
6629 // Receive VP8 packet.
6630 uint8_t data[kMinRtpPacketLen];
6631 cricket::RtpHeader rtpHeader;
6632 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6633 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6634 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6635 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6636 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6637 rtc::PacketTime packet_time;
6638 channel_->OnPacketReceived(&packet, packet_time);
6639
6640 // The |ssrc| member should still be unset.
6641 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6642 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6643 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6644}
6645
eladalonf1841382017-06-12 01:16:46 -07006646void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006647 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006648 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006649
6650 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006651 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006652 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006653 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006654
6655 if (receiver_first) {
6656 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6657 std::vector<FakeVideoReceiveStream*> receive_streams =
6658 fake_call_->GetVideoReceiveStreams();
6659 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006660 // Default local SSRC when we have no sender.
6661 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6662 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006663 }
6664 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6665 if (!receiver_first)
6666 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6667 std::vector<FakeVideoReceiveStream*> receive_streams =
6668 fake_call_->GetVideoReceiveStreams();
6669 ASSERT_EQ(1u, receive_streams.size());
6670 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006671
6672 // Removing first sender should fall back to another (in this case the second)
6673 // local send stream's SSRC.
6674 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6675 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006676 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006677 ASSERT_EQ(1u, receive_streams.size());
6678 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6679
6680 // Removing the last sender should fall back to default local SSRC.
6681 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006682 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006683 ASSERT_EQ(1u, receive_streams.size());
6684 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6685 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006686}
6687
eladalonf1841382017-06-12 01:16:46 -07006688TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006689 TestReceiverLocalSsrcConfiguration(false);
6690}
6691
eladalonf1841382017-06-12 01:16:46 -07006692TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006693 TestReceiverLocalSsrcConfiguration(true);
6694}
6695
eladalonf1841382017-06-12 01:16:46 -07006696class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006697 public:
eladalonf1841382017-06-12 01:16:46 -07006698 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006699 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006700 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6701 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006702 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006703 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006704 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006705 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006706 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006707
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006708 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006709 encoder_factory_->AddSupportedVideoCodecType("VP8");
nisse51542be2016-02-12 02:27:06 -08006710 channel_.reset(
kthelgason2bc68642017-02-07 07:02:22 -08006711 engine_.CreateChannel(&fake_call_, GetMediaConfig(), VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006712 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006713 last_ssrc_ = 123;
6714 }
6715
6716 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006717 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006718 int capture_width,
6719 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006720 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006721 size_t expected_num_streams,
6722 bool screenshare,
6723 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006724 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006725 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006726 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006727 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006728
Peter Boström0c4e06b2015-10-07 12:23:21 +02006729 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006730 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006731 ssrcs.resize(num_configured_streams);
6732
sprangf24a0642017-02-28 13:23:26 -08006733 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006734 // Send a full-size frame to trigger a stream reconfiguration to use all
6735 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006736 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006737 VideoOptions options;
6738 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006739 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006740 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006741 // Fetch the latest stream since SetVideoSend() may recreate it if the
6742 // screen content setting is changed.
6743 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006744 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006745 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006746 cricket::VideoFormat::FpsToInterval(30),
6747 cricket::FOURCC_I420)));
6748 channel_->SetSend(true);
6749 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006750
Zach Stein3ca452b2018-01-18 10:01:24 -08006751 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6752 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6753
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006754 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6755 ASSERT_EQ(expected_num_streams, video_streams.size());
6756
sprang429600d2017-01-26 06:12:26 -08006757 std::vector<webrtc::VideoStream> expected_streams;
6758 if (conference_mode) {
6759 expected_streams = GetSimulcastConfig(
6760 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006761 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006762 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006763 if (screenshare) {
6764 for (const webrtc::VideoStream& stream : expected_streams) {
6765 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006766 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6767 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006768 }
6769 }
sprang429600d2017-01-26 06:12:26 -08006770 } else {
6771 webrtc::VideoStream stream;
6772 stream.width = capture_width;
6773 stream.height = capture_height;
6774 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006775 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006776 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006777 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006778 stream.max_qp = kDefaultQpMax;
6779 expected_streams.push_back(stream);
6780 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006781
6782 ASSERT_EQ(expected_streams.size(), video_streams.size());
6783
6784 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006785 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006786 for (size_t i = 0; i < num_streams; ++i) {
6787 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6788 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6789
6790 EXPECT_GT(video_streams[i].max_framerate, 0);
6791 EXPECT_EQ(expected_streams[i].max_framerate,
6792 video_streams[i].max_framerate);
6793
6794 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6795 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6796 video_streams[i].min_bitrate_bps);
6797
6798 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6799 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6800 video_streams[i].target_bitrate_bps);
6801
6802 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6803 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6804 video_streams[i].max_bitrate_bps);
6805
6806 EXPECT_GT(video_streams[i].max_qp, 0);
6807 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6808
Sergey Silkina796a7e2018-03-01 15:11:29 +01006809 EXPECT_EQ(conference_mode,
6810 expected_streams[i].num_temporal_layers.has_value());
6811
6812 if (conference_mode) {
6813 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6814 video_streams[i].num_temporal_layers);
6815 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006816
6817 if (i == num_streams - 1) {
6818 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6819 } else {
6820 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6821 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006822 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006823
Niels Möllerff40b142018-04-09 08:49:14 +02006824 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006825 }
6826
6827 FakeVideoSendStream* AddSendStream() {
6828 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6829 }
6830
6831 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006832 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006833 EXPECT_TRUE(channel_->AddSendStream(sp));
6834 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006835 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006836 EXPECT_EQ(num_streams + 1, streams.size());
6837 return streams[streams.size() - 1];
6838 }
6839
6840 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006841 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006842 }
6843
6844 FakeVideoReceiveStream* AddRecvStream() {
6845 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6846 }
6847
6848 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006849 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006850 EXPECT_TRUE(channel_->AddRecvStream(sp));
6851 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006852 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006853 EXPECT_EQ(num_streams + 1, streams.size());
6854 return streams[streams.size() - 1];
6855 }
6856
skvlad11a9cbf2016-10-07 11:53:05 -07006857 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006858 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006859 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6860 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006861 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006862 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006863 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006864};
6865
eladalonf1841382017-06-12 01:16:46 -07006866TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006867 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6868 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006869}
6870
eladalonf1841382017-06-12 01:16:46 -07006871TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006872 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6873 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006874}
6875
6876// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006877TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006878 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6879 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006880}
sprang429600d2017-01-26 06:12:26 -08006881
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006882TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006883 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6884 false);
6885}
6886
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006887TEST_F(WebRtcVideoChannelSimulcastTest,
6888 SetSendCodecsForConferenceModeScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006889 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6890 true);
6891}
6892
eladalonf1841382017-06-12 01:16:46 -07006893TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
Erik Språngb65aa012018-09-24 11:35:19 +02006894 webrtc::test::ScopedFieldTrials override_field_trials_(
6895 "WebRTC-SimulcastScreenshare/Enabled/");
sprang429600d2017-01-26 06:12:26 -08006896 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6897 true);
6898}
6899
eladalonf1841382017-06-12 01:16:46 -07006900TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006901 NoSimulcastScreenshareWithoutConference) {
Erik Språngb65aa012018-09-24 11:35:19 +02006902 webrtc::test::ScopedFieldTrials override_field_trials_(
6903 "WebRTC-SimulcastScreenshare/Enabled/");
sprangfe627f32017-03-29 08:24:59 -07006904 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6905 false);
6906}
6907
Jonas Oreland49ac5952018-09-26 16:04:32 +02006908// The fake clock needs to be initialize before the call.
6909// So defer creating call in base class.
6910class WebRtcVideoChannelTestWithClock : public WebRtcVideoChannelBaseTest {
6911 public:
6912 WebRtcVideoChannelTestWithClock() {
6913 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6914 }
6915 rtc::ScopedFakeClock fake_clock_;
6916};
6917
6918TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
6919 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
6920 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6921
6922 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6923
6924 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6925 rtc::SetBE32(packet1.data() + 8, kSsrc);
6926 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6927 EXPECT_TRUE(SetDefaultCodec());
6928 EXPECT_TRUE(SetSend(true));
6929 EXPECT_EQ(0, renderer_.num_rendered_frames());
6930 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6931
6932 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6933 EXPECT_EQ(1u, sources.size());
6934 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
6935 int64_t timestamp1 = sources[0].timestamp_ms();
6936
6937 // a new packet.
6938 int64_t timeDeltaMs = 1;
6939 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
6940 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6941 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
6942 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
6943
6944 // It only keeps 10s of history.
6945 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
6946 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
6947 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6948}
6949
6950TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
6951 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
6952 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6953
6954 uint32_t kCsrc = 4321u;
6955 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6956 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6957
6958 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6959 rtc::SetBE32(packet1.data() + 8, kSsrc);
6960 rtc::SetBE32(packet1.data() + 12, kCsrc);
6961 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6962 EXPECT_TRUE(SetDefaultCodec());
6963 EXPECT_TRUE(SetSend(true));
6964 EXPECT_EQ(0, renderer_.num_rendered_frames());
6965 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6966
6967 {
6968 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
6969 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6970 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6971 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
6972 // 1 SSRC and 1 CSRC.
6973 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
6974 [](const webrtc::RtpSource& source) {
6975 return source.source_type() ==
6976 webrtc::RtpSourceType::SSRC;
6977 }));
6978 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
6979 [](const webrtc::RtpSource& source) {
6980 return source.source_type() ==
6981 webrtc::RtpSourceType::CSRC;
6982 }));
6983 }
6984 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
6985
6986 // a new packet with only ssrc (i.e no csrc).
6987 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
6988 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6989 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
6990 rtc::SetBE32(packet2.data() + 8, kSsrc);
6991
6992 int64_t timeDeltaMs = 1;
6993 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
6994 channel_->OnPacketReceived(&packet2, rtc::PacketTime());
6995
6996 {
6997 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
6998 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
6999 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7000 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7001 // 1 SSRC and 1 CSRC.
7002 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7003 [](const webrtc::RtpSource& source) {
7004 return source.source_type() ==
7005 webrtc::RtpSourceType::SSRC;
7006 }));
7007 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7008 [](const webrtc::RtpSource& source) {
7009 return source.source_type() ==
7010 webrtc::RtpSourceType::CSRC;
7011 }));
7012 auto ssrcSource = std::find_if(
7013 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7014 return source.source_type() == webrtc::RtpSourceType::SSRC;
7015 });
7016 auto csrcSource = std::find_if(
7017 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7018 return source.source_type() == webrtc::RtpSourceType::CSRC;
7019 });
7020
7021 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7022 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7023 }
7024
7025 // It only keeps 10s of history.
7026 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7027
7028 {
7029 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7030 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7031 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7032 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7033 [](const webrtc::RtpSource& source) {
7034 return source.source_type() ==
7035 webrtc::RtpSourceType::SSRC;
7036 }));
7037 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7038 [](const webrtc::RtpSource& source) {
7039 return source.source_type() ==
7040 webrtc::RtpSourceType::CSRC;
7041 }));
7042 }
7043
7044 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7045 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7046 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7047}
7048
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007049} // namespace cricket