blob: e40406cb3baf623d9a4ea159610477c56f373372 [file] [log] [blame]
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00001/*
phoglund@webrtc.org78088c22012-02-07 14:56:45 +00002 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +00003 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
kwiberg84be5112016-04-27 01:19:58 -070011#include <memory>
danilchapb8b6fbb2015-12-10 05:05:27 -080012#include <vector>
13
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020014#include "api/video/video_timing.h"
15#include "logging/rtc_event_log/mock/mock_rtc_event_log.h"
16#include "modules/rtp_rtcp/include/rtp_cvo.h"
17#include "modules/rtp_rtcp/include/rtp_header_extension_map.h"
18#include "modules/rtp_rtcp/include/rtp_header_parser.h"
19#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
20#include "modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
21#include "modules/rtp_rtcp/source/rtp_format_video_generic.h"
22#include "modules/rtp_rtcp/source/rtp_header_extensions.h"
23#include "modules/rtp_rtcp/source/rtp_packet_received.h"
24#include "modules/rtp_rtcp/source/rtp_packet_to_send.h"
25#include "modules/rtp_rtcp/source/rtp_sender.h"
26#include "modules/rtp_rtcp/source/rtp_sender_video.h"
27#include "modules/rtp_rtcp/source/rtp_utility.h"
28#include "rtc_base/arraysize.h"
29#include "rtc_base/buffer.h"
30#include "rtc_base/ptr_util.h"
31#include "rtc_base/rate_limiter.h"
32#include "test/field_trial.h"
33#include "test/gmock.h"
34#include "test/gtest.h"
35#include "test/mock_transport.h"
Mirko Bonadei71207422017-09-15 13:58:09 +020036#include "typedefs.h" // NOLINT(build/include)
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +000037
38namespace webrtc {
39
andrew@webrtc.org8a442592011-12-16 21:24:30 +000040namespace {
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +000041const int kTransmissionTimeOffsetExtensionId = 1;
42const int kAbsoluteSendTimeExtensionId = 14;
sprang@webrtc.org30933902015-03-17 14:33:12 +000043const int kTransportSequenceNumberExtensionId = 13;
ilnik04f4d122017-06-19 07:18:55 -070044const int kVideoTimingExtensionId = 12;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000045const int kPayload = 100;
Shao Changbine62202f2015-04-21 20:24:50 +080046const int kRtxPayload = 98;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000047const uint32_t kTimestamp = 10;
48const uint16_t kSeqNum = 33;
brandtr9dfff292016-11-14 05:14:50 -080049const uint32_t kSsrc = 725242;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000050const int kMaxPacketLength = 1500;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000051const uint8_t kAudioLevel = 0x5a;
sprang@webrtc.org30933902015-03-17 14:33:12 +000052const uint16_t kTransportSequenceNumber = 0xaabbu;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +000053const uint8_t kAudioLevelExtensionId = 9;
54const int kAudioPayload = 103;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +000055const uint64_t kStartTime = 123456789;
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +000056const size_t kMaxPaddingSize = 224u;
guoweis@webrtc.org45362892015-03-04 22:55:15 +000057const int kVideoRotationExtensionId = 5;
Stefan Holmera246cfb2016-08-23 17:51:42 +020058const size_t kGenericHeaderLength = 1;
59const uint8_t kPayloadData[] = {47, 11, 32, 93, 89};
spranga8ae6f22017-09-04 07:23:56 -070060const int64_t kDefaultExpectedRetransmissionTimeMs = 125;
andrew@webrtc.org8a442592011-12-16 21:24:30 +000061
Danil Chapovalov5e57b172016-09-02 19:15:59 +020062using ::testing::_;
63using ::testing::ElementsAreArray;
sprang168794c2017-07-06 04:38:06 -070064using ::testing::Invoke;
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +000065
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000066uint64_t ConvertMsToAbsSendTime(int64_t time_ms) {
Stefan Holmer0a87ffc2015-10-21 13:41:48 +020067 return (((time_ms << 18) + 500) / 1000) & 0x00ffffff;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +000068}
69
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000070class LoopbackTransportTest : public webrtc::Transport {
71 public:
danilchap12ba1862016-10-26 02:41:55 -070072 LoopbackTransportTest() : total_bytes_sent_(0), last_packet_id_(-1) {
73 receivers_extensions_.Register(kRtpExtensionTransmissionTimeOffset,
74 kTransmissionTimeOffsetExtensionId);
75 receivers_extensions_.Register(kRtpExtensionAbsoluteSendTime,
76 kAbsoluteSendTimeExtensionId);
77 receivers_extensions_.Register(kRtpExtensionTransportSequenceNumber,
78 kTransportSequenceNumberExtensionId);
79 receivers_extensions_.Register(kRtpExtensionVideoRotation,
80 kVideoRotationExtensionId);
81 receivers_extensions_.Register(kRtpExtensionAudioLevel,
82 kAudioLevelExtensionId);
ilnik04f4d122017-06-19 07:18:55 -070083 receivers_extensions_.Register(kRtpExtensionVideoTiming,
84 kVideoTimingExtensionId);
guoweis@webrtc.org45362892015-03-04 22:55:15 +000085 }
danilchap12ba1862016-10-26 02:41:55 -070086
stefan1d8a5062015-10-02 03:39:33 -070087 bool SendRtp(const uint8_t* data,
88 size_t len,
89 const PacketOptions& options) override {
Stefan Holmerf5dca482016-01-27 12:58:51 +010090 last_packet_id_ = options.packet_id;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +000091 total_bytes_sent_ += len;
danilchap12ba1862016-10-26 02:41:55 -070092 sent_packets_.push_back(RtpPacketReceived(&receivers_extensions_));
93 EXPECT_TRUE(sent_packets_.back().Parse(data, len));
pbos2d566682015-09-28 09:59:31 -070094 return true;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +000095 }
danilchap162abd32015-12-10 02:39:40 -080096 bool SendRtcp(const uint8_t* data, size_t len) override { return false; }
danilchap12ba1862016-10-26 02:41:55 -070097 const RtpPacketReceived& last_sent_packet() { return sent_packets_.back(); }
98 int packets_sent() { return sent_packets_.size(); }
99
pbos@webrtc.org72491b92014-07-10 16:24:54 +0000100 size_t total_bytes_sent_;
Stefan Holmerf5dca482016-01-27 12:58:51 +0100101 int last_packet_id_;
danilchap12ba1862016-10-26 02:41:55 -0700102 std::vector<RtpPacketReceived> sent_packets_;
103
104 private:
105 RtpHeaderExtensionMap receivers_extensions_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000106};
107
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000108} // namespace
109
sprangebbf8a82015-09-21 15:11:14 -0700110class MockRtpPacketSender : public RtpPacketSender {
111 public:
112 MockRtpPacketSender() {}
113 virtual ~MockRtpPacketSender() {}
114
Peter Boströme23e7372015-10-08 11:44:14 +0200115 MOCK_METHOD6(InsertPacket,
116 void(Priority priority,
sprangebbf8a82015-09-21 15:11:14 -0700117 uint32_t ssrc,
118 uint16_t sequence_number,
119 int64_t capture_time_ms,
120 size_t bytes,
121 bool retransmission));
122};
123
Stefan Holmerf5dca482016-01-27 12:58:51 +0100124class MockTransportSequenceNumberAllocator
125 : public TransportSequenceNumberAllocator {
126 public:
127 MOCK_METHOD0(AllocateSequenceNumber, uint16_t());
128};
129
asapersson35151f32016-05-02 23:44:01 -0700130class MockSendPacketObserver : public SendPacketObserver {
131 public:
132 MOCK_METHOD3(OnSendPacket, void(uint16_t, int64_t, uint32_t));
133};
134
Stefan Holmera246cfb2016-08-23 17:51:42 +0200135class MockTransportFeedbackObserver : public TransportFeedbackObserver {
136 public:
elad.alond12a8e12017-03-23 11:04:48 -0700137 MOCK_METHOD4(AddPacket,
138 void(uint32_t, uint16_t, size_t, const PacedPacketInfo&));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200139 MOCK_METHOD1(OnTransportFeedback, void(const rtcp::TransportFeedback&));
elad.alonf9490002017-03-06 05:32:21 -0800140 MOCK_CONST_METHOD0(GetTransportFeedbackVector, std::vector<PacketFeedback>());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200141};
142
minyue3a407ee2017-04-03 01:10:33 -0700143class MockOverheadObserver : public OverheadObserver {
144 public:
145 MOCK_METHOD1(OnOverheadChanged, void(size_t overhead_bytes_per_packet));
146};
147
148class RtpSenderTest : public ::testing::TestWithParam<bool> {
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000149 protected:
150 RtpSenderTest()
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000151 : fake_clock_(kStartTime),
terelius429c3452016-01-21 05:42:04 -0800152 mock_rtc_event_log_(),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000153 mock_paced_sender_(),
sprangcd349d92016-07-13 09:11:28 -0700154 retransmission_rate_limiter_(&fake_clock_, 1000),
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +0000155 rtp_sender_(),
156 payload_(kPayload),
157 transport_(),
minyue3a407ee2017-04-03 01:10:33 -0700158 kMarkerBit(true),
159 field_trials_(GetParam() ? "WebRTC-SendSideBwe-WithOverhead/Enabled/"
160 : "") {}
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000161
Peter Boströme23e7372015-10-08 11:44:14 +0200162 void SetUp() override { SetUpRtpSender(true); }
163
164 void SetUpRtpSender(bool pacer) {
asapersson35151f32016-05-02 23:44:01 -0700165 rtp_sender_.reset(new RTPSender(
166 false, &fake_clock_, &transport_, pacer ? &mock_paced_sender_ : nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800167 nullptr, &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
sprangcd349d92016-07-13 09:11:28 -0700168 &mock_rtc_event_log_, &send_packet_observer_,
michaelt4da30442016-11-17 01:38:43 -0800169 &retransmission_rate_limiter_, nullptr));
Danil Chapovalov31e4e802016-08-03 18:27:40 +0200170 rtp_sender_->SetSendPayloadType(kPayload);
brandtr9dfff292016-11-14 05:14:50 -0800171 rtp_sender_->SetSequenceNumber(kSeqNum);
danilchap71fead22016-08-18 02:01:49 -0700172 rtp_sender_->SetTimestampOffset(0);
brandtr9dfff292016-11-14 05:14:50 -0800173 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000174 }
175
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000176 SimulatedClock fake_clock_;
stefana23fc622016-07-28 07:56:38 -0700177 testing::NiceMock<MockRtcEventLog> mock_rtc_event_log_;
sprangebbf8a82015-09-21 15:11:14 -0700178 MockRtpPacketSender mock_paced_sender_;
stefana23fc622016-07-28 07:56:38 -0700179 testing::StrictMock<MockTransportSequenceNumberAllocator> seq_num_allocator_;
180 testing::StrictMock<MockSendPacketObserver> send_packet_observer_;
Stefan Holmera246cfb2016-08-23 17:51:42 +0200181 testing::StrictMock<MockTransportFeedbackObserver> feedback_observer_;
sprangcd349d92016-07-13 09:11:28 -0700182 RateLimiter retransmission_rate_limiter_;
kwiberg84be5112016-04-27 01:19:58 -0700183 std::unique_ptr<RTPSender> rtp_sender_;
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +0000184 int payload_;
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000185 LoopbackTransportTest transport_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000186 const bool kMarkerBit;
minyue3a407ee2017-04-03 01:10:33 -0700187 test::ScopedFieldTrials field_trials_;
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000188
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000189 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header) {
danilchapd9e62f52016-01-14 14:55:19 -0800190 VerifyRTPHeaderCommon(rtp_header, kMarkerBit, 0);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000191 }
192
193 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header, bool marker_bit) {
danilchapd9e62f52016-01-14 14:55:19 -0800194 VerifyRTPHeaderCommon(rtp_header, marker_bit, 0);
195 }
196
197 void VerifyRTPHeaderCommon(const RTPHeader& rtp_header,
198 bool marker_bit,
199 uint8_t number_of_csrcs) {
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000200 EXPECT_EQ(marker_bit, rtp_header.markerBit);
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000201 EXPECT_EQ(payload_, rtp_header.payloadType);
202 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
203 EXPECT_EQ(kTimestamp, rtp_header.timestamp);
204 EXPECT_EQ(rtp_sender_->SSRC(), rtp_header.ssrc);
danilchapd9e62f52016-01-14 14:55:19 -0800205 EXPECT_EQ(number_of_csrcs, rtp_header.numCSRCs);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000206 EXPECT_EQ(0U, rtp_header.paddingLength);
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000207 }
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000208
danilchapb6f1fb52016-10-19 06:11:39 -0700209 std::unique_ptr<RtpPacketToSend> BuildRtpPacket(int payload_type,
210 bool marker_bit,
211 uint32_t timestamp,
212 int64_t capture_time_ms) {
213 auto packet = rtp_sender_->AllocatePacket();
214 packet->SetPayloadType(payload_type);
215 packet->SetMarker(marker_bit);
216 packet->SetTimestamp(timestamp);
217 packet->set_capture_time_ms(capture_time_ms);
218 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
219 return packet;
220 }
221
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000222 void SendPacket(int64_t capture_time_ms, int payload_length) {
223 uint32_t timestamp = capture_time_ms * 90;
danilchapb6f1fb52016-10-19 06:11:39 -0700224 auto packet =
225 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
226 packet->AllocatePayload(payload_length);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000227
228 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700229 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
230 kAllowRetransmission,
231 RtpPacketSender::kNormalPriority));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000232 }
asapersson35151f32016-05-02 23:44:01 -0700233
234 void SendGenericPayload() {
asapersson35151f32016-05-02 23:44:01 -0700235 const uint32_t kTimestamp = 1234;
236 const uint8_t kPayloadType = 127;
237 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
238 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
239 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
240 0, 1500));
241
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700242 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
Stefan Holmera246cfb2016-08-23 17:51:42 +0200243 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -0700244 sizeof(kPayloadData), nullptr, nullptr, nullptr,
245 kDefaultExpectedRetransmissionTimeMs));
asapersson35151f32016-05-02 23:44:01 -0700246 }
asapersson@webrtc.org5249cc82011-12-16 14:31:37 +0000247};
248
Peter Boströme23e7372015-10-08 11:44:14 +0200249// TODO(pbos): Move tests over from WithoutPacer to RtpSenderTest as this is our
250// default code path.
251class RtpSenderTestWithoutPacer : public RtpSenderTest {
252 public:
253 void SetUp() override { SetUpRtpSender(false); }
254};
255
spranga8ae6f22017-09-04 07:23:56 -0700256class TestRtpSenderVideo : public RTPSenderVideo {
257 public:
258 TestRtpSenderVideo(Clock* clock,
259 RTPSender* rtp_sender,
260 FlexfecSender* flexfec_sender)
261 : RTPSenderVideo(clock, rtp_sender, flexfec_sender) {}
262 ~TestRtpSenderVideo() override {}
263
264 StorageType GetStorageType(const RTPVideoHeader& header,
265 int32_t retransmission_settings,
266 int64_t expected_retransmission_time_ms) {
267 return RTPSenderVideo::GetStorageType(GetTemporalId(header),
268 retransmission_settings,
269 expected_retransmission_time_ms);
270 }
271};
272
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000273class RtpSenderVideoTest : public RtpSenderTest {
274 protected:
danilchap162abd32015-12-10 02:39:40 -0800275 void SetUp() override {
Peter Boströme23e7372015-10-08 11:44:14 +0200276 // TODO(pbos): Set up to use pacer.
277 SetUpRtpSender(false);
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000278 rtp_sender_video_.reset(
spranga8ae6f22017-09-04 07:23:56 -0700279 new TestRtpSenderVideo(&fake_clock_, rtp_sender_.get(), nullptr));
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000280 }
spranga8ae6f22017-09-04 07:23:56 -0700281 std::unique_ptr<TestRtpSenderVideo> rtp_sender_video_;
guoweis@webrtc.org45362892015-03-04 22:55:15 +0000282};
283
minyue3a407ee2017-04-03 01:10:33 -0700284TEST_P(RtpSenderTestWithoutPacer, AllocatePacketSetCsrc) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200285 // Configure rtp_sender with csrc.
286 std::vector<uint32_t> csrcs;
287 csrcs.push_back(0x23456789);
288 rtp_sender_->SetCsrcs(csrcs);
289
290 auto packet = rtp_sender_->AllocatePacket();
291
292 ASSERT_TRUE(packet);
293 EXPECT_EQ(rtp_sender_->SSRC(), packet->Ssrc());
294 EXPECT_EQ(csrcs, packet->Csrcs());
295}
296
minyue3a407ee2017-04-03 01:10:33 -0700297TEST_P(RtpSenderTestWithoutPacer, AllocatePacketReserveExtensions) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200298 // Configure rtp_sender with extensions.
299 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
300 kRtpExtensionTransmissionTimeOffset,
301 kTransmissionTimeOffsetExtensionId));
302 ASSERT_EQ(
303 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
304 kAbsoluteSendTimeExtensionId));
305 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
306 kAudioLevelExtensionId));
307 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
308 kRtpExtensionTransportSequenceNumber,
309 kTransportSequenceNumberExtensionId));
310 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
311 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
312
313 auto packet = rtp_sender_->AllocatePacket();
314
315 ASSERT_TRUE(packet);
316 // Preallocate BWE extensions RtpSender set itself.
317 EXPECT_TRUE(packet->HasExtension<TransmissionOffset>());
318 EXPECT_TRUE(packet->HasExtension<AbsoluteSendTime>());
319 EXPECT_TRUE(packet->HasExtension<TransportSequenceNumber>());
320 // Do not allocate media specific extensions.
321 EXPECT_FALSE(packet->HasExtension<AudioLevel>());
322 EXPECT_FALSE(packet->HasExtension<VideoOrientation>());
323}
324
minyue3a407ee2017-04-03 01:10:33 -0700325TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberAdvanceSequenceNumber) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200326 auto packet = rtp_sender_->AllocatePacket();
327 ASSERT_TRUE(packet);
328 const uint16_t sequence_number = rtp_sender_->SequenceNumber();
329
330 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
331
332 EXPECT_EQ(sequence_number, packet->SequenceNumber());
333 EXPECT_EQ(sequence_number + 1, rtp_sender_->SequenceNumber());
334}
335
minyue3a407ee2017-04-03 01:10:33 -0700336TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberFailsOnNotSending) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200337 auto packet = rtp_sender_->AllocatePacket();
338 ASSERT_TRUE(packet);
339
340 rtp_sender_->SetSendingMediaStatus(false);
341 EXPECT_FALSE(rtp_sender_->AssignSequenceNumber(packet.get()));
342}
343
minyue3a407ee2017-04-03 01:10:33 -0700344TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberMayAllowPadding) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200345 constexpr size_t kPaddingSize = 100;
346 auto packet = rtp_sender_->AllocatePacket();
347 ASSERT_TRUE(packet);
348
philipel8aadd502017-02-23 02:56:13 -0800349 ASSERT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200350 packet->SetMarker(false);
351 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
352 // Packet without marker bit doesn't allow padding.
philipel8aadd502017-02-23 02:56:13 -0800353 EXPECT_FALSE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200354
355 packet->SetMarker(true);
356 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
357 // Packet with marker bit allows send padding.
philipel8aadd502017-02-23 02:56:13 -0800358 EXPECT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200359}
360
minyue3a407ee2017-04-03 01:10:33 -0700361TEST_P(RtpSenderTestWithoutPacer, AssignSequenceNumberSetPaddingTimestamps) {
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200362 constexpr size_t kPaddingSize = 100;
363 auto packet = rtp_sender_->AllocatePacket();
364 ASSERT_TRUE(packet);
365 packet->SetMarker(true);
366 packet->SetTimestamp(kTimestamp);
367
368 ASSERT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
philipel8aadd502017-02-23 02:56:13 -0800369 ASSERT_TRUE(rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200370
371 ASSERT_EQ(1u, transport_.sent_packets_.size());
danilchap12ba1862016-10-26 02:41:55 -0700372 // Verify padding packet timestamp.
373 EXPECT_EQ(kTimestamp, transport_.last_sent_packet().Timestamp());
Danil Chapovalov5e57b172016-09-02 19:15:59 +0200374}
375
minyue3a407ee2017-04-03 01:10:33 -0700376TEST_P(RtpSenderTestWithoutPacer,
377 TransportFeedbackObserverGetsCorrectByteCount) {
378 constexpr int kRtpOverheadBytesPerPacket = 12 + 8;
379 testing::NiceMock<MockOverheadObserver> mock_overhead_observer;
380 rtp_sender_.reset(new RTPSender(
381 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
382 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
383 nullptr, &retransmission_rate_limiter_, &mock_overhead_observer));
384 rtp_sender_->SetSSRC(kSsrc);
385 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
386 kRtpExtensionTransportSequenceNumber,
387 kTransportSequenceNumberExtensionId));
388 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
389 .WillOnce(testing::Return(kTransportSequenceNumber));
390
391 const size_t expected_bytes =
392 GetParam() ? sizeof(kPayloadData) + kGenericHeaderLength +
393 kRtpOverheadBytesPerPacket
394 : sizeof(kPayloadData) + kGenericHeaderLength;
395
396 EXPECT_CALL(feedback_observer_,
397 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber,
398 expected_bytes, PacedPacketInfo()))
399 .Times(1);
400 EXPECT_CALL(mock_overhead_observer,
401 OnOverheadChanged(kRtpOverheadBytesPerPacket))
402 .Times(1);
403 SendGenericPayload();
404}
405
406TEST_P(RtpSenderTestWithoutPacer, SendsPacketsWithTransportSequenceNumber) {
Stefan Holmera246cfb2016-08-23 17:51:42 +0200407 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800408 false, &fake_clock_, &transport_, nullptr, nullptr, &seq_num_allocator_,
409 &feedback_observer_, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
michaelt4da30442016-11-17 01:38:43 -0800410 &send_packet_observer_, &retransmission_rate_limiter_, nullptr));
nisse7d59f6b2017-02-21 03:40:24 -0800411 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100412 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
413 kRtpExtensionTransportSequenceNumber,
414 kTransportSequenceNumberExtensionId));
415
Stefan Holmerf5dca482016-01-27 12:58:51 +0100416 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
417 .WillOnce(testing::Return(kTransportSequenceNumber));
asapersson35151f32016-05-02 23:44:01 -0700418 EXPECT_CALL(send_packet_observer_,
419 OnSendPacket(kTransportSequenceNumber, _, _))
420 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700421
422 EXPECT_CALL(feedback_observer_,
423 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
424 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200425 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700426
427 SendGenericPayload();
Stefan Holmerf5dca482016-01-27 12:58:51 +0100428
danilchap12ba1862016-10-26 02:41:55 -0700429 const auto& packet = transport_.last_sent_packet();
430 uint16_t transport_seq_no;
431 ASSERT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
432 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
433 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no);
Stefan Holmerf5dca482016-01-27 12:58:51 +0100434}
435
minyue3a407ee2017-04-03 01:10:33 -0700436TEST_P(RtpSenderTestWithoutPacer, NoAllocationIfNotRegistered) {
stefana23fc622016-07-28 07:56:38 -0700437 SendGenericPayload();
438}
asapersson35151f32016-05-02 23:44:01 -0700439
minyue3a407ee2017-04-03 01:10:33 -0700440TEST_P(RtpSenderTestWithoutPacer, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700441 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
442 kRtpExtensionTransportSequenceNumber,
443 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700444 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
445 .WillOnce(testing::Return(kTransportSequenceNumber));
446 EXPECT_CALL(send_packet_observer_,
447 OnSendPacket(kTransportSequenceNumber, _, _))
448 .Times(1);
449
450 SendGenericPayload();
451}
452
minyue3a407ee2017-04-03 01:10:33 -0700453TEST_P(RtpSenderTest, SendsPacketsWithTransportSequenceNumber) {
michaelt4da30442016-11-17 01:38:43 -0800454 rtp_sender_.reset(new RTPSender(
455 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
456 &seq_num_allocator_, &feedback_observer_, nullptr, nullptr, nullptr,
457 &mock_rtc_event_log_, &send_packet_observer_,
458 &retransmission_rate_limiter_, nullptr));
brandtr9dfff292016-11-14 05:14:50 -0800459 rtp_sender_->SetSequenceNumber(kSeqNum);
460 rtp_sender_->SetSSRC(kSsrc);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200461 rtp_sender_->SetStorePacketsStatus(true, 10);
462 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
463 kRtpExtensionTransportSequenceNumber,
464 kTransportSequenceNumberExtensionId));
465
brandtr9dfff292016-11-14 05:14:50 -0800466 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _));
Stefan Holmera246cfb2016-08-23 17:51:42 +0200467 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
468 .WillOnce(testing::Return(kTransportSequenceNumber));
469 EXPECT_CALL(send_packet_observer_,
470 OnSendPacket(kTransportSequenceNumber, _, _))
471 .Times(1);
minyue3a407ee2017-04-03 01:10:33 -0700472 EXPECT_CALL(feedback_observer_,
473 AddPacket(rtp_sender_->SSRC(), kTransportSequenceNumber, _,
474 PacedPacketInfo()))
Stefan Holmera246cfb2016-08-23 17:51:42 +0200475 .Times(1);
476
477 SendGenericPayload();
philipel8aadd502017-02-23 02:56:13 -0800478 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
479 fake_clock_.TimeInMilliseconds(), false,
480 PacedPacketInfo());
Stefan Holmera246cfb2016-08-23 17:51:42 +0200481
danilchap12ba1862016-10-26 02:41:55 -0700482 const auto& packet = transport_.last_sent_packet();
483 uint16_t transport_seq_no;
484 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
485 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
486 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no);
Stefan Holmera246cfb2016-08-23 17:51:42 +0200487}
488
ilnik10894992017-06-21 08:23:19 -0700489TEST_P(RtpSenderTestWithoutPacer, WritesTimestampToTimingExtension) {
ilnik04f4d122017-06-19 07:18:55 -0700490 rtp_sender_->SetStorePacketsStatus(true, 10);
491 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
492 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
493 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
494 auto packet = rtp_sender_->AllocatePacket();
495 packet->SetPayloadType(kPayload);
496 packet->SetMarker(true);
497 packet->SetTimestamp(kTimestamp);
498 packet->set_capture_time_ms(capture_time_ms);
ilnik2edc6842017-07-06 03:06:50 -0700499 const VideoSendTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
ilnik04f4d122017-06-19 07:18:55 -0700500 packet->SetExtension<VideoTimingExtension>(kVideoTiming);
501 EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
502 size_t packet_size = packet->size();
ilnik04f4d122017-06-19 07:18:55 -0700503
504 const int kStoredTimeInMs = 100;
505 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
506
507 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
508 kAllowRetransmission,
509 RtpPacketSender::kNormalPriority));
510 EXPECT_EQ(1, transport_.packets_sent());
511 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
512
danilchapce251812017-09-11 12:24:41 -0700513 VideoSendTiming video_timing;
514 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
515 &video_timing));
516 EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700517
518 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
519 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
520 PacedPacketInfo());
521
522 EXPECT_EQ(2, transport_.packets_sent());
523 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
524
danilchapce251812017-09-11 12:24:41 -0700525 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
526 &video_timing));
527 EXPECT_EQ(kStoredTimeInMs * 2, video_timing.pacer_exit_delta_ms);
ilnik04f4d122017-06-19 07:18:55 -0700528}
529
minyue3a407ee2017-04-03 01:10:33 -0700530TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
Peter Boströme23e7372015-10-08 11:44:14 +0200531 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800532 kSsrc, kSeqNum, _, _, _));
Bjorn Terelius440216f2017-09-29 21:01:42 +0200533 EXPECT_CALL(mock_rtc_event_log_, LogOutgoingRtpHeader(_, _));
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000534
pwestin@webrtc.orgc66e8b32012-11-07 17:01:04 +0000535 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000536 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800537 kRtpExtensionTransmissionTimeOffset,
538 kTransmissionTimeOffsetExtensionId));
539 EXPECT_EQ(
540 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
541 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000542 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700543 auto packet =
544 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
545 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000546
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000547 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700548 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
549 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700550 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000551
danilchap12ba1862016-10-26 02:41:55 -0700552 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000553
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000554 const int kStoredTimeInMs = 100;
stefan@webrtc.orga678a3b2013-01-21 07:42:11 +0000555 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000556
brandtr9dfff292016-11-14 05:14:50 -0800557 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800558 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000559
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000560 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700561 EXPECT_EQ(1, transport_.packets_sent());
562 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
563
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000564 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700565 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000566
567 // Verify transmission time offset.
568 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000569 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000570 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000571 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000572}
573
minyue3a407ee2017-04-03 01:10:33 -0700574TEST_P(RtpSenderTest, TrafficSmoothingRetransmits) {
Peter Boströme23e7372015-10-08 11:44:14 +0200575 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800576 kSsrc, kSeqNum, _, _, _));
Bjorn Terelius440216f2017-09-29 21:01:42 +0200577 EXPECT_CALL(mock_rtc_event_log_, LogOutgoingRtpHeader(_, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000578
579 rtp_sender_->SetStorePacketsStatus(true, 10);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000580 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800581 kRtpExtensionTransmissionTimeOffset,
582 kTransmissionTimeOffsetExtensionId));
583 EXPECT_EQ(
584 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
585 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org8ccb9f92013-06-19 14:13:42 +0000586 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700587 auto packet =
588 BuildRtpPacket(kPayload, kMarkerBit, kTimestamp, capture_time_ms);
589 size_t packet_size = packet->size();
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000590
591 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700592 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
593 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700594 RtpPacketSender::kNormalPriority));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000595
danilchap12ba1862016-10-26 02:41:55 -0700596 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000597
terelius5d332ac2016-01-14 14:37:39 -0800598 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800599 kSsrc, kSeqNum, _, _, _));
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000600
601 const int kStoredTimeInMs = 100;
602 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
603
danilchapb6f1fb52016-10-19 06:11:39 -0700604 EXPECT_EQ(static_cast<int>(packet_size), rtp_sender_->ReSendPacket(kSeqNum));
danilchap12ba1862016-10-26 02:41:55 -0700605 EXPECT_EQ(0, transport_.packets_sent());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000606
brandtr9dfff292016-11-14 05:14:50 -0800607 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800608 PacedPacketInfo());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000609
610 // Process send bucket. Packet should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700611 EXPECT_EQ(1, transport_.packets_sent());
612 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000613
stefan@webrtc.orga5cb98c2013-05-29 12:12:51 +0000614 webrtc::RTPHeader rtp_header;
danilchap12ba1862016-10-26 02:41:55 -0700615 transport_.last_sent_packet().GetHeader(&rtp_header);
pwestin@webrtc.orgb0061f92013-04-27 00:41:08 +0000616
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000617 // Verify transmission time offset.
618 EXPECT_EQ(kStoredTimeInMs * 90, rtp_header.extension.transmissionTimeOffset);
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000619 uint64_t expected_send_time =
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000620 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
621 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
622}
623
624// This test sends 1 regular video packet, then 4 padding packets, and then
625// 1 more regular packet.
minyue3a407ee2017-04-03 01:10:33 -0700626TEST_P(RtpSenderTest, SendPadding) {
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000627 // Make all (non-padding) packets go to send queue.
terelius5d332ac2016-01-14 14:37:39 -0800628 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
brandtr9dfff292016-11-14 05:14:50 -0800629 kSsrc, kSeqNum, _, _, _));
Bjorn Terelius440216f2017-09-29 21:01:42 +0200630 EXPECT_CALL(mock_rtc_event_log_, LogOutgoingRtpHeader(_, _)).Times(1 + 4 + 1);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000631
632 uint16_t seq_num = kSeqNum;
633 uint32_t timestamp = kTimestamp;
634 rtp_sender_->SetStorePacketsStatus(true, 10);
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000635 size_t rtp_header_len = kRtpHeaderSize;
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000636 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
danilchap162abd32015-12-10 02:39:40 -0800637 kRtpExtensionTransmissionTimeOffset,
638 kTransmissionTimeOffsetExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000639 rtp_header_len += 4; // 4 bytes extension.
danilchap162abd32015-12-10 02:39:40 -0800640 EXPECT_EQ(
641 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
642 kAbsoluteSendTimeExtensionId));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000643 rtp_header_len += 4; // 4 bytes extension.
644 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
645
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000646 webrtc::RTPHeader rtp_header;
647
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000648 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700649 auto packet =
650 BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200651 const uint32_t media_packet_timestamp = timestamp;
danilchapb6f1fb52016-10-19 06:11:39 -0700652 size_t packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000653
654 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700655 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
656 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700657 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000658
659 int total_packets_sent = 0;
danilchap12ba1862016-10-26 02:41:55 -0700660 EXPECT_EQ(total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000661
662 const int kStoredTimeInMs = 100;
663 fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
brandtr9dfff292016-11-14 05:14:50 -0800664 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800665 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000666 // Packet should now be sent. This test doesn't verify the regular video
667 // packet, since it is tested in another test.
danilchap12ba1862016-10-26 02:41:55 -0700668 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000669 timestamp += 90 * kStoredTimeInMs;
670
671 // Send padding 4 times, waiting 50 ms between each.
672 for (int i = 0; i < 4; ++i) {
673 const int kPaddingPeriodMs = 50;
pkasting@chromium.org4591fbd2014-11-20 22:28:14 +0000674 const size_t kPaddingBytes = 100;
675 const size_t kMaxPaddingLength = 224; // Value taken from rtp_sender.cc.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000676 // Padding will be forced to full packets.
philipelc7bf32a2017-02-17 03:59:43 -0800677 EXPECT_EQ(kMaxPaddingLength,
philipel8aadd502017-02-23 02:56:13 -0800678 rtp_sender_->TimeToSendPadding(kPaddingBytes, PacedPacketInfo()));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000679
680 // Process send bucket. Padding should now be sent.
danilchap12ba1862016-10-26 02:41:55 -0700681 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000682 EXPECT_EQ(kMaxPaddingLength + rtp_header_len,
danilchap12ba1862016-10-26 02:41:55 -0700683 transport_.last_sent_packet().size());
684
685 transport_.last_sent_packet().GetHeader(&rtp_header);
pbosbd2522a2015-07-01 05:35:53 -0700686 EXPECT_EQ(kMaxPaddingLength, rtp_header.paddingLength);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000687
Stefan Holmer586b19b2015-09-18 11:14:31 +0200688 // Verify sequence number and timestamp. The timestamp should be the same
689 // as the last media packet.
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000690 EXPECT_EQ(seq_num++, rtp_header.sequenceNumber);
Stefan Holmer586b19b2015-09-18 11:14:31 +0200691 EXPECT_EQ(media_packet_timestamp, rtp_header.timestamp);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000692 // Verify transmission time offset.
Stefan Holmer586b19b2015-09-18 11:14:31 +0200693 int offset = timestamp - media_packet_timestamp;
694 EXPECT_EQ(offset, rtp_header.extension.transmissionTimeOffset);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000695 uint64_t expected_send_time =
696 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
697 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
698 fake_clock_.AdvanceTimeMilliseconds(kPaddingPeriodMs);
699 timestamp += 90 * kPaddingPeriodMs;
700 }
701
702 // Send a regular video packet again.
703 capture_time_ms = fake_clock_.TimeInMilliseconds();
danilchapb6f1fb52016-10-19 06:11:39 -0700704 packet = BuildRtpPacket(kPayload, kMarkerBit, timestamp, capture_time_ms);
705 packet_size = packet->size();
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000706
brandtr9dfff292016-11-14 05:14:50 -0800707 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kNormalPriority,
708 kSsrc, seq_num, _, _, _));
terelius5d332ac2016-01-14 14:37:39 -0800709
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000710 // Packet should be stored in a send bucket.
danilchapb6f1fb52016-10-19 06:11:39 -0700711 EXPECT_TRUE(rtp_sender_->SendToNetwork(std::move(packet),
712 kAllowRetransmission,
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700713 RtpPacketSender::kNormalPriority));
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000714
brandtr9dfff292016-11-14 05:14:50 -0800715 rtp_sender_->TimeToSendPacket(kSsrc, seq_num, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800716 PacedPacketInfo());
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000717 // Process send bucket.
danilchap12ba1862016-10-26 02:41:55 -0700718 EXPECT_EQ(++total_packets_sent, transport_.packets_sent());
719 EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
720 transport_.last_sent_packet().GetHeader(&rtp_header);
henrik.lundin@webrtc.org6e95d7a2013-11-15 08:59:19 +0000721
722 // Verify sequence number and timestamp.
723 EXPECT_EQ(seq_num, rtp_header.sequenceNumber);
724 EXPECT_EQ(timestamp, rtp_header.timestamp);
725 // Verify transmission time offset. This packet is sent without delay.
726 EXPECT_EQ(0, rtp_header.extension.transmissionTimeOffset);
727 uint64_t expected_send_time =
728 ConvertMsToAbsSendTime(fake_clock_.TimeInMilliseconds());
solenberg@webrtc.org7ebbea12013-05-16 11:10:31 +0000729 EXPECT_EQ(expected_send_time, rtp_header.extension.absoluteSendTime);
asapersson@webrtc.org0b3c35a2012-01-16 11:06:31 +0000730}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000731
minyue3a407ee2017-04-03 01:10:33 -0700732TEST_P(RtpSenderTest, OnSendPacketUpdated) {
stefana23fc622016-07-28 07:56:38 -0700733 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
734 kRtpExtensionTransportSequenceNumber,
735 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700736 rtp_sender_->SetStorePacketsStatus(true, 10);
737
738 EXPECT_CALL(send_packet_observer_,
739 OnSendPacket(kTransportSequenceNumber, _, _))
740 .Times(1);
741 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
742 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800743 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
744 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700745
746 SendGenericPayload(); // Packet passed to pacer.
747 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800748 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
749 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800750 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700751 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700752}
753
minyue3a407ee2017-04-03 01:10:33 -0700754TEST_P(RtpSenderTest, OnSendPacketNotUpdatedForRetransmits) {
stefana23fc622016-07-28 07:56:38 -0700755 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
756 kRtpExtensionTransportSequenceNumber,
757 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700758 rtp_sender_->SetStorePacketsStatus(true, 10);
759
760 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
761 EXPECT_CALL(seq_num_allocator_, AllocateSequenceNumber())
762 .WillOnce(testing::Return(kTransportSequenceNumber));
brandtr9dfff292016-11-14 05:14:50 -0800763 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
764 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700765
766 SendGenericPayload(); // Packet passed to pacer.
767 const bool kIsRetransmit = true;
brandtr9dfff292016-11-14 05:14:50 -0800768 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
769 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800770 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700771 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700772}
773
minyue3a407ee2017-04-03 01:10:33 -0700774TEST_P(RtpSenderTest, OnSendPacketNotUpdatedWithoutSeqNumAllocator) {
asapersson35151f32016-05-02 23:44:01 -0700775 rtp_sender_.reset(new RTPSender(
brandtrdbdb3f12016-11-10 05:04:48 -0800776 false, &fake_clock_, &transport_, &mock_paced_sender_, nullptr,
asapersson35151f32016-05-02 23:44:01 -0700777 nullptr /* TransportSequenceNumberAllocator */, nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800778 nullptr, nullptr, &send_packet_observer_, &retransmission_rate_limiter_,
779 nullptr));
brandtr9dfff292016-11-14 05:14:50 -0800780 rtp_sender_->SetSequenceNumber(kSeqNum);
781 rtp_sender_->SetSSRC(kSsrc);
stefana23fc622016-07-28 07:56:38 -0700782 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
783 kRtpExtensionTransportSequenceNumber,
784 kTransportSequenceNumberExtensionId));
asapersson35151f32016-05-02 23:44:01 -0700785 rtp_sender_->SetSequenceNumber(kSeqNum);
786 rtp_sender_->SetStorePacketsStatus(true, 10);
787
788 EXPECT_CALL(send_packet_observer_, OnSendPacket(_, _, _)).Times(0);
brandtr9dfff292016-11-14 05:14:50 -0800789 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, kSsrc, kSeqNum, _, _, _))
790 .Times(1);
asapersson35151f32016-05-02 23:44:01 -0700791
792 SendGenericPayload(); // Packet passed to pacer.
793 const bool kIsRetransmit = false;
brandtr9dfff292016-11-14 05:14:50 -0800794 rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum,
795 fake_clock_.TimeInMilliseconds(), kIsRetransmit,
philipel8aadd502017-02-23 02:56:13 -0800796 PacedPacketInfo());
danilchap12ba1862016-10-26 02:41:55 -0700797 EXPECT_EQ(1, transport_.packets_sent());
asapersson35151f32016-05-02 23:44:01 -0700798}
799
minyue3a407ee2017-04-03 01:10:33 -0700800TEST_P(RtpSenderTest, SendRedundantPayloads) {
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000801 MockTransport transport;
terelius429c3452016-01-21 05:42:04 -0800802 rtp_sender_.reset(new RTPSender(
asapersson35151f32016-05-02 23:44:01 -0700803 false, &fake_clock_, &transport, &mock_paced_sender_, nullptr, nullptr,
brandtrdbdb3f12016-11-10 05:04:48 -0800804 nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_, nullptr,
michaelt4da30442016-11-17 01:38:43 -0800805 &retransmission_rate_limiter_, nullptr));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000806 rtp_sender_->SetSequenceNumber(kSeqNum);
brandtr9dfff292016-11-14 05:14:50 -0800807 rtp_sender_->SetSSRC(kSsrc);
Shao Changbine62202f2015-04-21 20:24:50 +0800808 rtp_sender_->SetRtxPayloadType(kRtxPayload, kPayload);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000809
810 uint16_t seq_num = kSeqNum;
811 rtp_sender_->SetStorePacketsStatus(true, 10);
wu@webrtc.orgebdb0e32014-03-06 23:49:08 +0000812 int32_t rtp_header_len = kRtpHeaderSize;
danilchap162abd32015-12-10 02:39:40 -0800813 EXPECT_EQ(
814 0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAbsoluteSendTime,
815 kAbsoluteSendTimeExtensionId));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000816 rtp_header_len += 4; // 4 bytes extension.
817 rtp_header_len += 4; // 4 extra bytes common to all extension headers.
818
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +0000819 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
stefan@webrtc.orgef927552014-06-05 08:25:29 +0000820 rtp_sender_->SetRtxSsrc(1234);
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000821
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000822 const size_t kNumPayloadSizes = 10;
danilchap162abd32015-12-10 02:39:40 -0800823 const size_t kPayloadSizes[kNumPayloadSizes] = {500, 550, 600, 650, 700,
824 750, 800, 850, 900, 950};
terelius5d332ac2016-01-14 14:37:39 -0800825 // Expect all packets go through the pacer.
826 EXPECT_CALL(mock_paced_sender_,
brandtr9dfff292016-11-14 05:14:50 -0800827 InsertPacket(RtpPacketSender::kNormalPriority, kSsrc, _, _, _, _))
terelius5d332ac2016-01-14 14:37:39 -0800828 .Times(kNumPayloadSizes);
Bjorn Terelius440216f2017-09-29 21:01:42 +0200829 EXPECT_CALL(mock_rtc_event_log_, LogOutgoingRtpHeader(_, _))
terelius429c3452016-01-21 05:42:04 -0800830 .Times(kNumPayloadSizes);
831
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000832 // Send 10 packets of increasing size.
833 for (size_t i = 0; i < kNumPayloadSizes; ++i) {
834 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
stefan1d8a5062015-10-02 03:39:33 -0700835 EXPECT_CALL(transport, SendRtp(_, _, _)).WillOnce(testing::Return(true));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000836 SendPacket(capture_time_ms, kPayloadSizes[i]);
brandtr9dfff292016-11-14 05:14:50 -0800837 rtp_sender_->TimeToSendPacket(kSsrc, seq_num++, capture_time_ms, false,
philipel8aadd502017-02-23 02:56:13 -0800838 PacedPacketInfo());
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000839 fake_clock_.AdvanceTimeMilliseconds(33);
840 }
terelius429c3452016-01-21 05:42:04 -0800841
Bjorn Terelius440216f2017-09-29 21:01:42 +0200842 EXPECT_CALL(mock_rtc_event_log_, LogOutgoingRtpHeader(_, _))
terelius429c3452016-01-21 05:42:04 -0800843 .Times(::testing::AtLeast(4));
844
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000845 // The amount of padding to send it too small to send a payload packet.
stefan1d8a5062015-10-02 03:39:33 -0700846 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700847 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700848 EXPECT_EQ(kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800849 rtp_sender_->TimeToSendPadding(49, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000850
Peter Boströmac547a62015-09-17 23:03:57 +0200851 EXPECT_CALL(transport,
stefan1d8a5062015-10-02 03:39:33 -0700852 SendRtp(_, kPayloadSizes[0] + rtp_header_len + kRtxHeaderSize, _))
pbos2d566682015-09-28 09:59:31 -0700853 .WillOnce(testing::Return(true));
philipela1ed0b32016-06-01 06:31:17 -0700854 EXPECT_EQ(kPayloadSizes[0],
philipel8aadd502017-02-23 02:56:13 -0800855 rtp_sender_->TimeToSendPadding(500, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000856
pbos2d566682015-09-28 09:59:31 -0700857 EXPECT_CALL(transport, SendRtp(_, kPayloadSizes[kNumPayloadSizes - 1] +
stefan1d8a5062015-10-02 03:39:33 -0700858 rtp_header_len + kRtxHeaderSize,
859 _))
pbos2d566682015-09-28 09:59:31 -0700860 .WillOnce(testing::Return(true));
stefan1d8a5062015-10-02 03:39:33 -0700861 EXPECT_CALL(transport, SendRtp(_, kMaxPaddingSize + rtp_header_len, _))
pbos2d566682015-09-28 09:59:31 -0700862 .WillOnce(testing::Return(true));
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +0000863 EXPECT_EQ(kPayloadSizes[kNumPayloadSizes - 1] + kMaxPaddingSize,
philipel8aadd502017-02-23 02:56:13 -0800864 rtp_sender_->TimeToSendPadding(999, PacedPacketInfo()));
stefan@webrtc.org7e9315b2013-12-04 10:24:26 +0000865}
866
minyue3a407ee2017-04-03 01:10:33 -0700867TEST_P(RtpSenderTestWithoutPacer, SendGenericVideo) {
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000868 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
869 const uint8_t payload_type = 127;
870 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
871 0, 1500));
872 uint8_t payload[] = {47, 11, 32, 93, 89};
873
874 // Send keyframe
spranga8ae6f22017-09-04 07:23:56 -0700875 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
876 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
877 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000878
danilchap96c15872016-11-21 01:35:29 -0800879 auto sent_payload = transport_.last_sent_packet().payload();
880 uint8_t generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000881 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
882 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800883 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000884
885 // Send delta frame
886 payload[0] = 13;
887 payload[1] = 42;
888 payload[4] = 13;
889
Sergey Ulanov525df3f2016-08-02 17:46:41 -0700890 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
891 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -0700892 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000893
danilchap96c15872016-11-21 01:35:29 -0800894 sent_payload = transport_.last_sent_packet().payload();
895 generic_header = sent_payload[0];
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000896 EXPECT_FALSE(generic_header & RtpFormatVideoGeneric::kKeyFrameBit);
897 EXPECT_TRUE(generic_header & RtpFormatVideoGeneric::kFirstPacketBit);
danilchap96c15872016-11-21 01:35:29 -0800898 EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload));
pbos@webrtc.org8911ce42013-03-18 16:39:03 +0000899}
900
minyue3a407ee2017-04-03 01:10:33 -0700901TEST_P(RtpSenderTest, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -0800902 constexpr int kMediaPayloadType = 127;
903 constexpr int kFlexfecPayloadType = 118;
904 constexpr uint32_t kMediaSsrc = 1234;
905 constexpr uint32_t kFlexfecSsrc = 5678;
906 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -0700907 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -0800908 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -0700909 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -0700910 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -0800911
912 // Reset |rtp_sender_| to use FlexFEC.
michaelt4da30442016-11-17 01:38:43 -0800913 rtp_sender_.reset(new RTPSender(
914 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
915 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
916 &mock_rtc_event_log_, &send_packet_observer_,
917 &retransmission_rate_limiter_, nullptr));
brandtrdbdb3f12016-11-10 05:04:48 -0800918 rtp_sender_->SetSSRC(kMediaSsrc);
919 rtp_sender_->SetSequenceNumber(kSeqNum);
920 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
921 rtp_sender_->SetStorePacketsStatus(true, 10);
922
923 // Parameters selected to generate a single FEC packet per media packet.
924 FecProtectionParams params;
925 params.fec_rate = 15;
926 params.max_fec_frames = 1;
927 params.fec_mask_type = kFecMaskRandom;
928 rtp_sender_->SetFecParameters(params, params);
929
brandtr9dfff292016-11-14 05:14:50 -0800930 EXPECT_CALL(mock_paced_sender_,
931 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
932 _, _, false));
933 uint16_t flexfec_seq_num;
brandtrdbdb3f12016-11-10 05:04:48 -0800934 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
brandtr9dfff292016-11-14 05:14:50 -0800935 kFlexfecSsrc, _, _, _, false))
936 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
brandtrdbdb3f12016-11-10 05:04:48 -0800937 SendGenericPayload();
Bjorn Terelius440216f2017-09-29 21:01:42 +0200938 EXPECT_CALL(mock_rtc_event_log_, LogOutgoingRtpHeader(_, _)).Times(2);
philipel8aadd502017-02-23 02:56:13 -0800939 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
940 fake_clock_.TimeInMilliseconds(),
941 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -0800942 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
943 fake_clock_.TimeInMilliseconds(),
philipel8aadd502017-02-23 02:56:13 -0800944 false, PacedPacketInfo()));
brandtr9dfff292016-11-14 05:14:50 -0800945 ASSERT_EQ(2, transport_.packets_sent());
brandtrdbdb3f12016-11-10 05:04:48 -0800946 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
947 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
brandtr9dfff292016-11-14 05:14:50 -0800948 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
brandtrdbdb3f12016-11-10 05:04:48 -0800949 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
brandtr9dfff292016-11-14 05:14:50 -0800950 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
951 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
952 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
953 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
brandtrdbdb3f12016-11-10 05:04:48 -0800954}
955
ilnik10894992017-06-21 08:23:19 -0700956// TODO(ilnik): because of webrtc:7859. Once FEC moved below pacer, this test
957// should be removed.
958TEST_P(RtpSenderTest, NoFlexfecForTimingFrames) {
959 constexpr int kMediaPayloadType = 127;
960 constexpr int kFlexfecPayloadType = 118;
961 constexpr uint32_t kMediaSsrc = 1234;
962 constexpr uint32_t kFlexfecSsrc = 5678;
963 const std::vector<RtpExtension> kNoRtpExtensions;
964 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
ilnike4350192017-06-29 02:27:44 -0700965
ilnik10894992017-06-21 08:23:19 -0700966 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
967 kNoRtpExtensions, kNoRtpExtensionSizes,
968 nullptr /* rtp_state */, &fake_clock_);
969
970 // Reset |rtp_sender_| to use FlexFEC.
971 rtp_sender_.reset(new RTPSender(
972 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
973 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
974 &mock_rtc_event_log_, &send_packet_observer_,
975 &retransmission_rate_limiter_, nullptr));
976 rtp_sender_->SetSSRC(kMediaSsrc);
977 rtp_sender_->SetSequenceNumber(kSeqNum);
978 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
979 rtp_sender_->SetStorePacketsStatus(true, 10);
980
ilnike4350192017-06-29 02:27:44 -0700981 // Need extension to be registered for timing frames to be sent.
982 ASSERT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
983 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
984
ilnik10894992017-06-21 08:23:19 -0700985 // Parameters selected to generate a single FEC packet per media packet.
986 FecProtectionParams params;
987 params.fec_rate = 15;
988 params.max_fec_frames = 1;
989 params.fec_mask_type = kFecMaskRandom;
990 rtp_sender_->SetFecParameters(params, params);
991
992 EXPECT_CALL(mock_paced_sender_,
993 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc, kSeqNum,
994 _, _, false));
995 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
996 kFlexfecSsrc, _, _, _, false))
997 .Times(0); // Not called because packet should not be protected.
998
999 const uint32_t kTimestamp = 1234;
1000 const uint8_t kPayloadType = 127;
1001 const int64_t kCaptureTimeMs = fake_clock_.TimeInMilliseconds();
1002 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1003 EXPECT_EQ(0, rtp_sender_->RegisterPayload(payload_name, kPayloadType, 90000,
1004 0, 1500));
1005 RTPVideoHeader video_header;
1006 memset(&video_header, 0, sizeof(RTPVideoHeader));
sprangba050a62017-08-18 02:51:12 -07001007 video_header.video_timing.flags = TimingFrameFlags::kTriggeredByTimer;
ilnik10894992017-06-21 08:23:19 -07001008 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1009 kVideoFrameKey, kPayloadType, kTimestamp, kCaptureTimeMs, kPayloadData,
spranga8ae6f22017-09-04 07:23:56 -07001010 sizeof(kPayloadData), nullptr, &video_header, nullptr,
1011 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001012
Bjorn Terelius440216f2017-09-29 21:01:42 +02001013 EXPECT_CALL(mock_rtc_event_log_, LogOutgoingRtpHeader(_, _)).Times(1);
ilnik10894992017-06-21 08:23:19 -07001014 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum,
1015 fake_clock_.TimeInMilliseconds(),
1016 false, PacedPacketInfo()));
1017 ASSERT_EQ(1, transport_.packets_sent());
1018 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1019 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1020 EXPECT_EQ(kSeqNum, media_packet.SequenceNumber());
1021 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1022
1023 // Now try to send not a timing frame.
1024 uint16_t flexfec_seq_num;
1025 EXPECT_CALL(mock_paced_sender_, InsertPacket(RtpPacketSender::kLowPriority,
1026 kFlexfecSsrc, _, _, _, false))
1027 .WillOnce(testing::SaveArg<2>(&flexfec_seq_num));
1028 EXPECT_CALL(mock_paced_sender_,
1029 InsertPacket(RtpPacketSender::kLowPriority, kMediaSsrc,
1030 kSeqNum + 1, _, _, false));
sprangba050a62017-08-18 02:51:12 -07001031 video_header.video_timing.flags = TimingFrameFlags::kInvalid;
ilnik10894992017-06-21 08:23:19 -07001032 EXPECT_TRUE(rtp_sender_->SendOutgoingData(
1033 kVideoFrameKey, kPayloadType, kTimestamp + 1, kCaptureTimeMs + 1,
spranga8ae6f22017-09-04 07:23:56 -07001034 kPayloadData, sizeof(kPayloadData), nullptr, &video_header, nullptr,
1035 kDefaultExpectedRetransmissionTimeMs));
ilnik10894992017-06-21 08:23:19 -07001036
Bjorn Terelius440216f2017-09-29 21:01:42 +02001037 EXPECT_CALL(mock_rtc_event_log_, LogOutgoingRtpHeader(_, _)).Times(2);
ilnik10894992017-06-21 08:23:19 -07001038 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kMediaSsrc, kSeqNum + 1,
1039 fake_clock_.TimeInMilliseconds(),
1040 false, PacedPacketInfo()));
1041 EXPECT_TRUE(rtp_sender_->TimeToSendPacket(kFlexfecSsrc, flexfec_seq_num,
1042 fake_clock_.TimeInMilliseconds(),
1043 false, PacedPacketInfo()));
1044 ASSERT_EQ(3, transport_.packets_sent());
1045 const RtpPacketReceived& media_packet2 = transport_.sent_packets_[1];
1046 EXPECT_EQ(kMediaPayloadType, media_packet2.PayloadType());
1047 EXPECT_EQ(kSeqNum + 1, media_packet2.SequenceNumber());
1048 EXPECT_EQ(kMediaSsrc, media_packet2.Ssrc());
1049 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[2];
1050 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1051 EXPECT_EQ(flexfec_seq_num, flexfec_packet.SequenceNumber());
1052 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1053}
1054
minyue3a407ee2017-04-03 01:10:33 -07001055TEST_P(RtpSenderTestWithoutPacer, SendFlexfecPackets) {
brandtrdbdb3f12016-11-10 05:04:48 -08001056 constexpr int kMediaPayloadType = 127;
1057 constexpr int kFlexfecPayloadType = 118;
1058 constexpr uint32_t kMediaSsrc = 1234;
1059 constexpr uint32_t kFlexfecSsrc = 5678;
1060 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001061 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtrdbdb3f12016-11-10 05:04:48 -08001062 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -07001063 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001064 nullptr /* rtp_state */, &fake_clock_);
brandtrdbdb3f12016-11-10 05:04:48 -08001065
1066 // Reset |rtp_sender_| to use FlexFEC.
1067 rtp_sender_.reset(new RTPSender(false, &fake_clock_, &transport_, nullptr,
1068 &flexfec_sender, &seq_num_allocator_, nullptr,
1069 nullptr, nullptr, nullptr,
1070 &mock_rtc_event_log_, &send_packet_observer_,
michaelt4da30442016-11-17 01:38:43 -08001071 &retransmission_rate_limiter_, nullptr));
brandtrdbdb3f12016-11-10 05:04:48 -08001072 rtp_sender_->SetSSRC(kMediaSsrc);
1073 rtp_sender_->SetSequenceNumber(kSeqNum);
1074 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
1075
1076 // Parameters selected to generate a single FEC packet per media packet.
1077 FecProtectionParams params;
1078 params.fec_rate = 15;
1079 params.max_fec_frames = 1;
1080 params.fec_mask_type = kFecMaskRandom;
1081 rtp_sender_->SetFecParameters(params, params);
1082
Bjorn Terelius440216f2017-09-29 21:01:42 +02001083 EXPECT_CALL(mock_rtc_event_log_, LogOutgoingRtpHeader(_, _)).Times(2);
brandtrdbdb3f12016-11-10 05:04:48 -08001084 SendGenericPayload();
1085 ASSERT_EQ(2, transport_.packets_sent());
1086 const RtpPacketReceived& media_packet = transport_.sent_packets_[0];
1087 EXPECT_EQ(kMediaPayloadType, media_packet.PayloadType());
1088 EXPECT_EQ(kMediaSsrc, media_packet.Ssrc());
1089 const RtpPacketReceived& flexfec_packet = transport_.sent_packets_[1];
1090 EXPECT_EQ(kFlexfecPayloadType, flexfec_packet.PayloadType());
1091 EXPECT_EQ(kFlexfecSsrc, flexfec_packet.Ssrc());
1092}
1093
minyue3a407ee2017-04-03 01:10:33 -07001094TEST_P(RtpSenderTest, FecOverheadRate) {
brandtr81eab612017-01-24 04:06:09 -08001095 constexpr int kMediaPayloadType = 127;
1096 constexpr int kFlexfecPayloadType = 118;
1097 constexpr uint32_t kMediaSsrc = 1234;
1098 constexpr uint32_t kFlexfecSsrc = 5678;
1099 const std::vector<RtpExtension> kNoRtpExtensions;
erikvarga27883732017-05-17 05:08:38 -07001100 const std::vector<RtpExtensionSize> kNoRtpExtensionSizes;
brandtr81eab612017-01-24 04:06:09 -08001101 FlexfecSender flexfec_sender(kFlexfecPayloadType, kFlexfecSsrc, kMediaSsrc,
erikvarga27883732017-05-17 05:08:38 -07001102 kNoRtpExtensions, kNoRtpExtensionSizes,
brandtr48d21a22017-05-30 02:32:12 -07001103 nullptr /* rtp_state */, &fake_clock_);
brandtr81eab612017-01-24 04:06:09 -08001104
1105 // Reset |rtp_sender_| to use FlexFEC.
1106 rtp_sender_.reset(new RTPSender(
1107 false, &fake_clock_, &transport_, &mock_paced_sender_, &flexfec_sender,
1108 &seq_num_allocator_, nullptr, nullptr, nullptr, nullptr,
1109 &mock_rtc_event_log_, &send_packet_observer_,
1110 &retransmission_rate_limiter_, nullptr));
1111 rtp_sender_->SetSSRC(kMediaSsrc);
1112 rtp_sender_->SetSequenceNumber(kSeqNum);
1113 rtp_sender_->SetSendPayloadType(kMediaPayloadType);
1114
1115 // Parameters selected to generate a single FEC packet per media packet.
1116 FecProtectionParams params;
1117 params.fec_rate = 15;
1118 params.max_fec_frames = 1;
1119 params.fec_mask_type = kFecMaskRandom;
1120 rtp_sender_->SetFecParameters(params, params);
1121
1122 constexpr size_t kNumMediaPackets = 10;
1123 constexpr size_t kNumFecPackets = kNumMediaPackets;
1124 constexpr int64_t kTimeBetweenPacketsMs = 10;
1125 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, false))
1126 .Times(kNumMediaPackets + kNumFecPackets);
1127 for (size_t i = 0; i < kNumMediaPackets; ++i) {
1128 SendGenericPayload();
1129 fake_clock_.AdvanceTimeMilliseconds(kTimeBetweenPacketsMs);
1130 }
1131 constexpr size_t kRtpHeaderLength = 12;
1132 constexpr size_t kFlexfecHeaderLength = 20;
1133 constexpr size_t kGenericCodecHeaderLength = 1;
1134 constexpr size_t kPayloadLength = sizeof(kPayloadData);
1135 constexpr size_t kPacketLength = kRtpHeaderLength + kFlexfecHeaderLength +
1136 kGenericCodecHeaderLength + kPayloadLength;
1137 EXPECT_NEAR(kNumFecPackets * kPacketLength * 8 /
1138 (kNumFecPackets * kTimeBetweenPacketsMs / 1000.0f),
1139 rtp_sender_->FecOverheadRate(), 500);
1140}
1141
minyue3a407ee2017-04-03 01:10:33 -07001142TEST_P(RtpSenderTest, FrameCountCallbacks) {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001143 class TestCallback : public FrameCountObserver {
1144 public:
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001145 TestCallback() : FrameCountObserver(), num_calls_(0), ssrc_(0) {}
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001146 virtual ~TestCallback() {}
1147
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001148 void FrameCountUpdated(const FrameCounts& frame_counts,
1149 uint32_t ssrc) override {
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001150 ++num_calls_;
1151 ssrc_ = ssrc;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001152 frame_counts_ = frame_counts;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001153 }
1154
1155 uint32_t num_calls_;
1156 uint32_t ssrc_;
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001157 FrameCounts frame_counts_;
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001158 } callback;
1159
michaelt4da30442016-11-17 01:38:43 -08001160 rtp_sender_.reset(
1161 new RTPSender(false, &fake_clock_, &transport_, &mock_paced_sender_,
1162 nullptr, nullptr, nullptr, nullptr, &callback, nullptr,
1163 nullptr, nullptr, &retransmission_rate_limiter_, nullptr));
nisse7d59f6b2017-02-21 03:40:24 -08001164 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001165 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1166 const uint8_t payload_type = 127;
1167 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1168 0, 1500));
1169 uint8_t payload[] = {47, 11, 32, 93, 89};
1170 rtp_sender_->SetStorePacketsStatus(true, 1);
1171 uint32_t ssrc = rtp_sender_->SSRC();
1172
terelius5d332ac2016-01-14 14:37:39 -08001173 EXPECT_CALL(mock_paced_sender_, InsertPacket(_, _, _, _, _, _))
1174 .Times(::testing::AtLeast(2));
1175
spranga8ae6f22017-09-04 07:23:56 -07001176 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1177 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1178 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001179
1180 EXPECT_EQ(1U, callback.num_calls_);
1181 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001182 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1183 EXPECT_EQ(0, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001184
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001185 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1186 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001187 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001188
1189 EXPECT_EQ(2U, callback.num_calls_);
1190 EXPECT_EQ(ssrc, callback.ssrc_);
pbos@webrtc.orgce4e9a32014-12-18 13:50:16 +00001191 EXPECT_EQ(1, callback.frame_counts_.key_frames);
1192 EXPECT_EQ(1, callback.frame_counts_.delta_frames);
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001193
andresp@webrtc.org8f151212014-07-10 09:39:23 +00001194 rtp_sender_.reset();
sprang@webrtc.org71f055f2013-12-04 15:09:27 +00001195}
1196
minyue3a407ee2017-04-03 01:10:33 -07001197TEST_P(RtpSenderTest, BitrateCallbacks) {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001198 class TestCallback : public BitrateStatisticsObserver {
1199 public:
sprangcd349d92016-07-13 09:11:28 -07001200 TestCallback()
1201 : BitrateStatisticsObserver(),
1202 num_calls_(0),
1203 ssrc_(0),
1204 total_bitrate_(0),
1205 retransmit_bitrate_(0) {}
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001206 virtual ~TestCallback() {}
1207
sprangcd349d92016-07-13 09:11:28 -07001208 void Notify(uint32_t total_bitrate,
1209 uint32_t retransmit_bitrate,
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001210 uint32_t ssrc) override {
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001211 ++num_calls_;
1212 ssrc_ = ssrc;
sprangcd349d92016-07-13 09:11:28 -07001213 total_bitrate_ = total_bitrate;
1214 retransmit_bitrate_ = retransmit_bitrate;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001215 }
1216
1217 uint32_t num_calls_;
1218 uint32_t ssrc_;
sprangcd349d92016-07-13 09:11:28 -07001219 uint32_t total_bitrate_;
1220 uint32_t retransmit_bitrate_;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001221 } callback;
brandtrdbdb3f12016-11-10 05:04:48 -08001222 rtp_sender_.reset(new RTPSender(false, &fake_clock_, &transport_, nullptr,
1223 nullptr, nullptr, nullptr, &callback, nullptr,
1224 nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -08001225 &retransmission_rate_limiter_, nullptr));
nisse7d59f6b2017-02-21 03:40:24 -08001226 rtp_sender_->SetSSRC(kSsrc);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001227
sprangcd349d92016-07-13 09:11:28 -07001228 // Simulate kNumPackets sent with kPacketInterval ms intervals, with the
1229 // number of packets selected so that we fill (but don't overflow) the one
1230 // second averaging window.
1231 const uint32_t kWindowSizeMs = 1000;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001232 const uint32_t kPacketInterval = 20;
sprangcd349d92016-07-13 09:11:28 -07001233 const uint32_t kNumPackets =
1234 (kWindowSizeMs - kPacketInterval) / kPacketInterval;
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001235 // Overhead = 12 bytes RTP header + 1 byte generic header.
1236 const uint32_t kPacketOverhead = 13;
1237
1238 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1239 const uint8_t payload_type = 127;
danilchap162abd32015-12-10 02:39:40 -08001240 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1241 0, 1500));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001242 uint8_t payload[] = {47, 11, 32, 93, 89};
1243 rtp_sender_->SetStorePacketsStatus(true, 1);
1244 uint32_t ssrc = rtp_sender_->SSRC();
1245
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001246 // Initial process call so we get a new time window.
1247 rtp_sender_->ProcessBitrate();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001248
1249 // Send a few frames.
1250 for (uint32_t i = 0; i < kNumPackets; ++i) {
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001251 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1252 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
spranga8ae6f22017-09-04 07:23:56 -07001253 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001254 fake_clock_.AdvanceTimeMilliseconds(kPacketInterval);
1255 }
1256
1257 rtp_sender_->ProcessBitrate();
1258
stefan@webrtc.org0bae1fa2014-11-05 14:05:29 +00001259 // We get one call for every stats updated, thus two calls since both the
1260 // stream stats and the retransmit stats are updated once.
1261 EXPECT_EQ(2u, callback.num_calls_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001262 EXPECT_EQ(ssrc, callback.ssrc_);
sprangcd349d92016-07-13 09:11:28 -07001263 const uint32_t kTotalPacketSize = kPacketOverhead + sizeof(payload);
1264 // Bitrate measured over delta between last and first timestamp, plus one.
1265 const uint32_t kExpectedWindowMs = kNumPackets * kPacketInterval + 1;
1266 const uint32_t kExpectedBitsAccumulated = kTotalPacketSize * kNumPackets * 8;
1267 const uint32_t kExpectedRateBps =
1268 (kExpectedBitsAccumulated * 1000 + (kExpectedWindowMs / 2)) /
1269 kExpectedWindowMs;
1270 EXPECT_EQ(kExpectedRateBps, callback.total_bitrate_);
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001271
andresp@webrtc.orgd11bec42014-07-08 14:32:58 +00001272 rtp_sender_.reset();
sprang@webrtc.org6811b6e2013-12-13 09:46:59 +00001273}
1274
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001275class RtpSenderAudioTest : public RtpSenderTest {
1276 protected:
1277 RtpSenderAudioTest() {}
pbos@webrtc.org8911ce42013-03-18 16:39:03 +00001278
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001279 void SetUp() override {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001280 payload_ = kAudioPayload;
brandtrdbdb3f12016-11-10 05:04:48 -08001281 rtp_sender_.reset(new RTPSender(true, &fake_clock_, &transport_, nullptr,
1282 nullptr, nullptr, nullptr, nullptr, nullptr,
1283 nullptr, nullptr, nullptr,
michaelt4da30442016-11-17 01:38:43 -08001284 &retransmission_rate_limiter_, nullptr));
nisse7d59f6b2017-02-21 03:40:24 -08001285 rtp_sender_->SetSSRC(kSsrc);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001286 rtp_sender_->SetSequenceNumber(kSeqNum);
1287 }
1288};
1289
minyue3a407ee2017-04-03 01:10:33 -07001290TEST_P(RtpSenderTestWithoutPacer, StreamDataCountersCallbacks) {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001291 class TestCallback : public StreamDataCountersCallback {
1292 public:
danilchap162abd32015-12-10 02:39:40 -08001293 TestCallback() : StreamDataCountersCallback(), ssrc_(0), counters_() {}
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001294 virtual ~TestCallback() {}
1295
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001296 void DataCountersUpdated(const StreamDataCounters& counters,
1297 uint32_t ssrc) override {
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001298 ssrc_ = ssrc;
1299 counters_ = counters;
1300 }
1301
1302 uint32_t ssrc_;
1303 StreamDataCounters counters_;
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001304
1305 void MatchPacketCounter(const RtpPacketCounter& expected,
1306 const RtpPacketCounter& actual) {
1307 EXPECT_EQ(expected.payload_bytes, actual.payload_bytes);
1308 EXPECT_EQ(expected.header_bytes, actual.header_bytes);
1309 EXPECT_EQ(expected.padding_bytes, actual.padding_bytes);
1310 EXPECT_EQ(expected.packets, actual.packets);
1311 }
1312
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001313 void Matches(uint32_t ssrc, const StreamDataCounters& counters) {
1314 EXPECT_EQ(ssrc, ssrc_);
asapersson@webrtc.org44149392015-02-04 08:34:47 +00001315 MatchPacketCounter(counters.transmitted, counters_.transmitted);
1316 MatchPacketCounter(counters.retransmitted, counters_.retransmitted);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001317 EXPECT_EQ(counters.fec.packets, counters_.fec.packets);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001318 }
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001319 } callback;
1320
1321 const uint8_t kRedPayloadType = 96;
1322 const uint8_t kUlpfecPayloadType = 97;
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001323 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "GENERIC";
1324 const uint8_t payload_type = 127;
1325 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 90000,
1326 0, 1500));
1327 uint8_t payload[] = {47, 11, 32, 93, 89};
1328 rtp_sender_->SetStorePacketsStatus(true, 1);
1329 uint32_t ssrc = rtp_sender_->SSRC();
1330
1331 rtp_sender_->RegisterRtpStatisticsCallback(&callback);
1332
1333 // Send a frame.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001334 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001335 kVideoFrameKey, payload_type, 1234, 4321, payload, sizeof(payload),
1336 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001337 StreamDataCounters expected;
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001338 expected.transmitted.payload_bytes = 6;
1339 expected.transmitted.header_bytes = 12;
1340 expected.transmitted.padding_bytes = 0;
1341 expected.transmitted.packets = 1;
1342 expected.retransmitted.payload_bytes = 0;
1343 expected.retransmitted.header_bytes = 0;
1344 expected.retransmitted.padding_bytes = 0;
1345 expected.retransmitted.packets = 0;
1346 expected.fec.packets = 0;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001347 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001348
1349 // Retransmit a frame.
1350 uint16_t seqno = rtp_sender_->SequenceNumber() - 1;
1351 rtp_sender_->ReSendPacket(seqno, 0);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001352 expected.transmitted.payload_bytes = 12;
1353 expected.transmitted.header_bytes = 24;
1354 expected.transmitted.packets = 2;
1355 expected.retransmitted.payload_bytes = 6;
1356 expected.retransmitted.header_bytes = 12;
1357 expected.retransmitted.padding_bytes = 0;
1358 expected.retransmitted.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001359 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001360
1361 // Send padding.
philipel8aadd502017-02-23 02:56:13 -08001362 rtp_sender_->TimeToSendPadding(kMaxPaddingSize, PacedPacketInfo());
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001363 expected.transmitted.payload_bytes = 12;
1364 expected.transmitted.header_bytes = 36;
1365 expected.transmitted.padding_bytes = kMaxPaddingSize;
1366 expected.transmitted.packets = 3;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001367 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001368
brandtrf1bb4762016-11-07 03:05:06 -08001369 // Send ULPFEC.
1370 rtp_sender_->SetUlpfecConfig(kRedPayloadType, kUlpfecPayloadType);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001371 FecProtectionParams fec_params;
1372 fec_params.fec_mask_type = kFecMaskRandom;
1373 fec_params.fec_rate = 1;
1374 fec_params.max_fec_frames = 1;
brandtr1743a192016-11-07 03:36:05 -08001375 rtp_sender_->SetFecParameters(fec_params, fec_params);
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001376 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001377 kVideoFrameDelta, payload_type, 1234, 4321, payload, sizeof(payload),
1378 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001379 expected.transmitted.payload_bytes = 40;
1380 expected.transmitted.header_bytes = 60;
1381 expected.transmitted.packets = 5;
1382 expected.fec.packets = 1;
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001383 callback.Matches(ssrc, expected);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001384
sprang867fb522015-08-03 04:38:41 -07001385 rtp_sender_->RegisterRtpStatisticsCallback(nullptr);
sprang@webrtc.orgebad7652013-12-05 14:29:02 +00001386}
1387
minyue3a407ee2017-04-03 01:10:33 -07001388TEST_P(RtpSenderAudioTest, SendAudio) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001389 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1390 const uint8_t payload_type = 127;
1391 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1392 0, 1500));
1393 uint8_t payload[] = {47, 11, 32, 93, 89};
1394
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001395 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001396 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1397 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001398
danilchap96c15872016-11-21 01:35:29 -08001399 auto sent_payload = transport_.last_sent_packet().payload();
1400 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001401}
1402
minyue3a407ee2017-04-03 01:10:33 -07001403TEST_P(RtpSenderAudioTest, SendAudioWithAudioLevelExtension) {
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001404 EXPECT_EQ(0, rtp_sender_->SetAudioLevel(kAudioLevel));
danilchap162abd32015-12-10 02:39:40 -08001405 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionAudioLevel,
1406 kAudioLevelExtensionId));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001407
1408 char payload_name[RTP_PAYLOAD_NAME_SIZE] = "PAYLOAD_NAME";
1409 const uint8_t payload_type = 127;
1410 ASSERT_EQ(0, rtp_sender_->RegisterPayload(payload_name, payload_type, 48000,
1411 0, 1500));
1412 uint8_t payload[] = {47, 11, 32, 93, 89};
1413
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001414 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001415 kAudioFrameCN, payload_type, 1234, 4321, payload, sizeof(payload),
1416 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001417
danilchap96c15872016-11-21 01:35:29 -08001418 auto sent_payload = transport_.last_sent_packet().payload();
1419 EXPECT_THAT(sent_payload, ElementsAreArray(payload));
danilchap12ba1862016-10-26 02:41:55 -07001420 // Verify AudioLevel extension.
1421 bool voice_activity;
1422 uint8_t audio_level;
1423 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<AudioLevel>(
1424 &voice_activity, &audio_level));
1425 EXPECT_EQ(kAudioLevel, audio_level);
1426 EXPECT_FALSE(voice_activity);
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001427}
1428
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001429// As RFC4733, named telephone events are carried as part of the audio stream
1430// and must use the same sequence number and timestamp base as the regular
1431// audio channel.
1432// This test checks the marker bit for the first packet and the consequent
1433// packets of the same telephone event. Since it is specifically for DTMF
pbos22993e12015-10-19 02:39:06 -07001434// events, ignoring audio packets and sending kEmptyFrame instead of those.
minyue3a407ee2017-04-03 01:10:33 -07001435TEST_P(RtpSenderAudioTest, CheckMarkerBitForTelephoneEvents) {
solenbergffbbcac2016-11-17 05:25:37 -08001436 const char* kDtmfPayloadName = "telephone-event";
1437 const uint32_t kPayloadFrequency = 8000;
1438 const uint8_t kPayloadType = 126;
1439 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kDtmfPayloadName, kPayloadType,
1440 kPayloadFrequency, 0, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001441 // For Telephone events, payload is not added to the registered payload list,
1442 // it will register only the payload used for audio stream.
1443 // Registering the payload again for audio stream with different payload name.
solenbergffbbcac2016-11-17 05:25:37 -08001444 const char* kPayloadName = "payload_name";
1445 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType,
1446 kPayloadFrequency, 1, 0));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001447 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
1448 // DTMF event key=9, duration=500 and attenuationdB=10
1449 rtp_sender_->SendTelephoneEvent(9, 500, 10);
1450 // During start, it takes the starting timestamp as last sent timestamp.
1451 // The duration is calculated as the difference of current and last sent
1452 // timestamp. So for first call it will skip since the duration is zero.
spranga8ae6f22017-09-04 07:23:56 -07001453 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
1454 kEmptyFrame, kPayloadType, capture_time_ms, 0, nullptr, 0, nullptr,
1455 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001456 // DTMF Sample Length is (Frequency/1000) * Duration.
1457 // So in this case, it is (8000/1000) * 500 = 4000.
1458 // Sending it as two packets.
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001459 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001460 kEmptyFrame, kPayloadType, capture_time_ms + 2000, 0, nullptr, 0, nullptr,
1461 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
danilchap12ba1862016-10-26 02:41:55 -07001462
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001463 // Marker Bit should be set to 1 for first packet.
danilchap12ba1862016-10-26 02:41:55 -07001464 EXPECT_TRUE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001465
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001466 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001467 kEmptyFrame, kPayloadType, capture_time_ms + 4000, 0, nullptr, 0, nullptr,
1468 nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001469 // Marker Bit should be set to 0 for rest of the packets.
danilchap12ba1862016-10-26 02:41:55 -07001470 EXPECT_FALSE(transport_.last_sent_packet().Marker());
stefan@webrtc.org0a214ff2014-09-03 11:46:54 +00001471}
1472
minyue3a407ee2017-04-03 01:10:33 -07001473TEST_P(RtpSenderTestWithoutPacer, BytesReportedCorrectly) {
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001474 const char* kPayloadName = "GENERIC";
1475 const uint8_t kPayloadType = 127;
1476 rtp_sender_->SetSSRC(1234);
1477 rtp_sender_->SetRtxSsrc(4321);
Shao Changbine62202f2015-04-21 20:24:50 +08001478 rtp_sender_->SetRtxPayloadType(kPayloadType - 1, kPayloadType);
pbos@webrtc.org0b0c2412015-01-13 14:15:15 +00001479 rtp_sender_->SetRtxStatus(kRtxRetransmitted | kRtxRedundantPayloads);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001480
danilchap162abd32015-12-10 02:39:40 -08001481 ASSERT_EQ(0, rtp_sender_->RegisterPayload(kPayloadName, kPayloadType, 90000,
1482 0, 1500));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001483 uint8_t payload[] = {47, 11, 32, 93, 89};
1484
Sergey Ulanov525df3f2016-08-02 17:46:41 -07001485 ASSERT_TRUE(rtp_sender_->SendOutgoingData(
spranga8ae6f22017-09-04 07:23:56 -07001486 kVideoFrameKey, kPayloadType, 1234, 4321, payload, sizeof(payload),
1487 nullptr, nullptr, nullptr, kDefaultExpectedRetransmissionTimeMs));
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001488
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001489 // Will send 2 full-size padding packets.
philipel8aadd502017-02-23 02:56:13 -08001490 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
1491 rtp_sender_->TimeToSendPadding(1, PacedPacketInfo());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001492
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001493 StreamDataCounters rtp_stats;
1494 StreamDataCounters rtx_stats;
1495 rtp_sender_->GetDataCounters(&rtp_stats, &rtx_stats);
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001496
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001497 // Payload + 1-byte generic header.
asapersson@webrtc.orgd08d3892014-12-16 12:03:11 +00001498 EXPECT_GT(rtp_stats.first_packet_time_ms, -1);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001499 EXPECT_EQ(rtp_stats.transmitted.payload_bytes, sizeof(payload) + 1);
1500 EXPECT_EQ(rtp_stats.transmitted.header_bytes, 12u);
1501 EXPECT_EQ(rtp_stats.transmitted.padding_bytes, 0u);
1502 EXPECT_EQ(rtx_stats.transmitted.payload_bytes, 0u);
1503 EXPECT_EQ(rtx_stats.transmitted.header_bytes, 24u);
1504 EXPECT_EQ(rtx_stats.transmitted.padding_bytes, 2 * kMaxPaddingSize);
pbos@webrtc.org2f4b14e2014-07-15 15:25:39 +00001505
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001506 EXPECT_EQ(rtp_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001507 rtp_stats.transmitted.payload_bytes +
1508 rtp_stats.transmitted.header_bytes +
1509 rtp_stats.transmitted.padding_bytes);
asapersson@webrtc.orgcfd82df2015-01-22 09:39:59 +00001510 EXPECT_EQ(rtx_stats.transmitted.TotalBytes(),
danilchap162abd32015-12-10 02:39:40 -08001511 rtx_stats.transmitted.payload_bytes +
1512 rtx_stats.transmitted.header_bytes +
1513 rtx_stats.transmitted.padding_bytes);
asapersson@webrtc.org97d04892014-12-09 09:47:53 +00001514
danilchap162abd32015-12-10 02:39:40 -08001515 EXPECT_EQ(
1516 transport_.total_bytes_sent_,
1517 rtp_stats.transmitted.TotalBytes() + rtx_stats.transmitted.TotalBytes());
pbos@webrtc.org72491b92014-07-10 16:24:54 +00001518}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001519
minyue3a407ee2017-04-03 01:10:33 -07001520TEST_P(RtpSenderTestWithoutPacer, RespectsNackBitrateLimit) {
sprang38778b02015-09-29 09:48:22 -07001521 const int32_t kPacketSize = 1400;
1522 const int32_t kNumPackets = 30;
1523
sprangcd349d92016-07-13 09:11:28 -07001524 retransmission_rate_limiter_.SetMaxRate(kPacketSize * kNumPackets * 8);
1525
sprang38778b02015-09-29 09:48:22 -07001526 rtp_sender_->SetStorePacketsStatus(true, kNumPackets);
sprang38778b02015-09-29 09:48:22 -07001527 const uint16_t kStartSequenceNumber = rtp_sender_->SequenceNumber();
Danil Chapovalov2800d742016-08-26 18:48:46 +02001528 std::vector<uint16_t> sequence_numbers;
sprang38778b02015-09-29 09:48:22 -07001529 for (int32_t i = 0; i < kNumPackets; ++i) {
1530 sequence_numbers.push_back(kStartSequenceNumber + i);
1531 fake_clock_.AdvanceTimeMilliseconds(1);
1532 SendPacket(fake_clock_.TimeInMilliseconds(), kPacketSize);
1533 }
danilchap12ba1862016-10-26 02:41:55 -07001534 EXPECT_EQ(kNumPackets, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001535
1536 fake_clock_.AdvanceTimeMilliseconds(1000 - kNumPackets);
1537
1538 // Resending should work - brings the bandwidth up to the limit.
1539 // NACK bitrate is capped to the same bitrate as the encoder, since the max
1540 // protection overhead is 50% (see MediaOptimization::SetTargetRates).
Danil Chapovalov2800d742016-08-26 18:48:46 +02001541 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001542 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001543
sprangcd349d92016-07-13 09:11:28 -07001544 // Must be at least 5ms in between retransmission attempts.
1545 fake_clock_.AdvanceTimeMilliseconds(5);
1546
sprang38778b02015-09-29 09:48:22 -07001547 // Resending should not work, bandwidth exceeded.
Danil Chapovalov2800d742016-08-26 18:48:46 +02001548 rtp_sender_->OnReceivedNack(sequence_numbers, 0);
danilchap12ba1862016-10-26 02:41:55 -07001549 EXPECT_EQ(kNumPackets * 2, transport_.packets_sent());
sprang38778b02015-09-29 09:48:22 -07001550}
1551
minyue3a407ee2017-04-03 01:10:33 -07001552TEST_P(RtpSenderVideoTest, KeyFrameHasCVO) {
danilchapb6f1fb52016-10-19 06:11:39 -07001553 uint8_t kFrame[kMaxPacketLength];
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001554 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1555 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001556
danilchapc1600c52016-10-26 03:33:11 -07001557 RTPVideoHeader hdr = {0};
1558 hdr.rotation = kVideoRotation_0;
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001559 rtp_sender_video_->SendVideo(kRtpVideoGeneric, kVideoFrameKey, kPayload,
danilchapb6f1fb52016-10-19 06:11:39 -07001560 kTimestamp, 0, kFrame, sizeof(kFrame), nullptr,
spranga8ae6f22017-09-04 07:23:56 -07001561 &hdr, kDefaultExpectedRetransmissionTimeMs);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001562
danilchapc1600c52016-10-26 03:33:11 -07001563 VideoRotation rotation;
1564 EXPECT_TRUE(
1565 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1566 EXPECT_EQ(kVideoRotation_0, rotation);
1567}
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001568
ilnik04f4d122017-06-19 07:18:55 -07001569TEST_P(RtpSenderVideoTest, TimingFrameHasPacketizationTimstampSet) {
1570 uint8_t kFrame[kMaxPacketLength];
1571 const int64_t kPacketizationTimeMs = 100;
1572 const int64_t kEncodeStartDeltaMs = 10;
1573 const int64_t kEncodeFinishDeltaMs = 50;
1574 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1575 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
1576
1577 const int64_t kCaptureTimestamp = fake_clock_.TimeInMilliseconds();
1578
1579 RTPVideoHeader hdr = {0};
sprangba050a62017-08-18 02:51:12 -07001580 hdr.video_timing.flags = TimingFrameFlags::kTriggeredByTimer;
ilnik04f4d122017-06-19 07:18:55 -07001581 hdr.video_timing.encode_start_delta_ms = kEncodeStartDeltaMs;
1582 hdr.video_timing.encode_finish_delta_ms = kEncodeFinishDeltaMs;
1583
1584 fake_clock_.AdvanceTimeMilliseconds(kPacketizationTimeMs);
1585 rtp_sender_video_->SendVideo(kRtpVideoGeneric, kVideoFrameKey, kPayload,
1586 kTimestamp, kCaptureTimestamp, kFrame,
spranga8ae6f22017-09-04 07:23:56 -07001587 sizeof(kFrame), nullptr, &hdr,
1588 kDefaultExpectedRetransmissionTimeMs);
ilnik2edc6842017-07-06 03:06:50 -07001589 VideoSendTiming timing;
ilnik04f4d122017-06-19 07:18:55 -07001590 EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
1591 &timing));
1592 EXPECT_EQ(kPacketizationTimeMs, timing.packetization_finish_delta_ms);
1593 EXPECT_EQ(kEncodeStartDeltaMs, timing.encode_start_delta_ms);
1594 EXPECT_EQ(kEncodeFinishDeltaMs, timing.encode_finish_delta_ms);
1595}
1596
minyue3a407ee2017-04-03 01:10:33 -07001597TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenChanged) {
danilchapc1600c52016-10-26 03:33:11 -07001598 uint8_t kFrame[kMaxPacketLength];
1599 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1600 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1601
1602 RTPVideoHeader hdr = {0};
1603 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001604 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1605 kRtpVideoGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1606 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001607
1608 hdr.rotation = kVideoRotation_0;
spranga8ae6f22017-09-04 07:23:56 -07001609 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1610 kRtpVideoGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1611 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001612
1613 VideoRotation rotation;
1614 EXPECT_TRUE(
1615 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1616 EXPECT_EQ(kVideoRotation_0, rotation);
1617}
1618
minyue3a407ee2017-04-03 01:10:33 -07001619TEST_P(RtpSenderVideoTest, DeltaFrameHasCVOWhenNonZero) {
danilchapc1600c52016-10-26 03:33:11 -07001620 uint8_t kFrame[kMaxPacketLength];
1621 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
1622 kRtpExtensionVideoRotation, kVideoRotationExtensionId));
1623
1624 RTPVideoHeader hdr = {0};
1625 hdr.rotation = kVideoRotation_90;
spranga8ae6f22017-09-04 07:23:56 -07001626 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1627 kRtpVideoGeneric, kVideoFrameKey, kPayload, kTimestamp, 0, kFrame,
1628 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001629
spranga8ae6f22017-09-04 07:23:56 -07001630 EXPECT_TRUE(rtp_sender_video_->SendVideo(
1631 kRtpVideoGeneric, kVideoFrameDelta, kPayload, kTimestamp + 1, 0, kFrame,
1632 sizeof(kFrame), nullptr, &hdr, kDefaultExpectedRetransmissionTimeMs));
danilchapc1600c52016-10-26 03:33:11 -07001633
1634 VideoRotation rotation;
1635 EXPECT_TRUE(
1636 transport_.last_sent_packet().GetExtension<VideoOrientation>(&rotation));
1637 EXPECT_EQ(kVideoRotation_90, rotation);
guoweis@webrtc.org45362892015-03-04 22:55:15 +00001638}
magjed71eb61c2016-09-08 03:24:58 -07001639
1640// Make sure rotation is parsed correctly when the Camera (C) and Flip (F) bits
1641// are set in the CVO byte.
minyue3a407ee2017-04-03 01:10:33 -07001642TEST_P(RtpSenderVideoTest, SendVideoWithCameraAndFlipCVO) {
magjed71eb61c2016-09-08 03:24:58 -07001643 // Test extracting rotation when Camera (C) and Flip (F) bits are zero.
1644 EXPECT_EQ(kVideoRotation_0, ConvertCVOByteToVideoRotation(0));
1645 EXPECT_EQ(kVideoRotation_90, ConvertCVOByteToVideoRotation(1));
1646 EXPECT_EQ(kVideoRotation_180, ConvertCVOByteToVideoRotation(2));
1647 EXPECT_EQ(kVideoRotation_270, ConvertCVOByteToVideoRotation(3));
1648 // Test extracting rotation when Camera (C) and Flip (F) bits are set.
1649 const int flip_bit = 1 << 2;
1650 const int camera_bit = 1 << 3;
1651 EXPECT_EQ(kVideoRotation_0,
1652 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 0));
1653 EXPECT_EQ(kVideoRotation_90,
1654 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 1));
1655 EXPECT_EQ(kVideoRotation_180,
1656 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 2));
1657 EXPECT_EQ(kVideoRotation_270,
1658 ConvertCVOByteToVideoRotation(flip_bit | camera_bit | 3));
1659}
1660
spranga8ae6f22017-09-04 07:23:56 -07001661TEST_P(RtpSenderVideoTest, RetransmissionTypesGeneric) {
1662 RTPVideoHeader header;
1663 header.codec = kRtpVideoGeneric;
1664
1665 EXPECT_EQ(kDontRetransmit,
1666 rtp_sender_video_->GetStorageType(
1667 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1668 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1669 header, kRetransmitBaseLayer,
1670 kDefaultExpectedRetransmissionTimeMs));
1671 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1672 header, kRetransmitHigherLayers,
1673 kDefaultExpectedRetransmissionTimeMs));
1674 EXPECT_EQ(kAllowRetransmission,
1675 rtp_sender_video_->GetStorageType(
1676 header, kConditionallyRetransmitHigherLayers,
1677 kDefaultExpectedRetransmissionTimeMs));
1678 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1679 header, kRetransmitAllPackets,
1680 kDefaultExpectedRetransmissionTimeMs));
1681}
1682
1683TEST_P(RtpSenderVideoTest, RetransmissionTypesH264) {
1684 RTPVideoHeader header;
1685 header.codec = kRtpVideoH264;
1686 header.codecHeader.H264.packetization_mode =
1687 H264PacketizationMode::NonInterleaved;
1688
1689 EXPECT_EQ(kDontRetransmit,
1690 rtp_sender_video_->GetStorageType(
1691 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1692 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1693 header, kRetransmitBaseLayer,
1694 kDefaultExpectedRetransmissionTimeMs));
1695 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1696 header, kRetransmitHigherLayers,
1697 kDefaultExpectedRetransmissionTimeMs));
1698 EXPECT_EQ(kAllowRetransmission,
1699 rtp_sender_video_->GetStorageType(
1700 header, kConditionallyRetransmitHigherLayers,
1701 kDefaultExpectedRetransmissionTimeMs));
1702 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1703 header, kRetransmitAllPackets,
1704 kDefaultExpectedRetransmissionTimeMs));
1705}
1706
1707TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8BaseLayer) {
1708 RTPVideoHeader header;
1709 header.codec = kRtpVideoVp8;
1710 header.codecHeader.VP8.temporalIdx = 0;
1711
1712 EXPECT_EQ(kDontRetransmit,
1713 rtp_sender_video_->GetStorageType(
1714 header, kRetransmitOff, kDefaultExpectedRetransmissionTimeMs));
1715 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1716 header, kRetransmitBaseLayer,
1717 kDefaultExpectedRetransmissionTimeMs));
1718 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1719 header, kRetransmitHigherLayers,
1720 kDefaultExpectedRetransmissionTimeMs));
1721 EXPECT_EQ(kAllowRetransmission,
1722 rtp_sender_video_->GetStorageType(
1723 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1724 kDefaultExpectedRetransmissionTimeMs));
1725 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1726 header, kConditionallyRetransmitHigherLayers,
1727 kDefaultExpectedRetransmissionTimeMs));
1728 EXPECT_EQ(
1729 kAllowRetransmission,
1730 rtp_sender_video_->GetStorageType(
1731 header, kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers,
1732 kDefaultExpectedRetransmissionTimeMs));
1733 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1734 header, kRetransmitAllPackets,
1735 kDefaultExpectedRetransmissionTimeMs));
1736}
1737
1738TEST_P(RtpSenderVideoTest, RetransmissionTypesVP8HigherLayers) {
1739 RTPVideoHeader header;
1740 header.codec = kRtpVideoVp8;
1741
1742 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
1743 header.codecHeader.VP8.temporalIdx = tid;
1744
1745 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1746 header, kRetransmitOff,
1747 kDefaultExpectedRetransmissionTimeMs));
1748 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1749 header, kRetransmitBaseLayer,
1750 kDefaultExpectedRetransmissionTimeMs));
1751 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1752 header, kRetransmitHigherLayers,
1753 kDefaultExpectedRetransmissionTimeMs));
1754 EXPECT_EQ(kAllowRetransmission,
1755 rtp_sender_video_->GetStorageType(
1756 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1757 kDefaultExpectedRetransmissionTimeMs));
1758 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1759 header, kRetransmitAllPackets,
1760 kDefaultExpectedRetransmissionTimeMs));
1761 }
1762}
1763
1764TEST_P(RtpSenderVideoTest, RetransmissionTypesVP9) {
1765 RTPVideoHeader header;
1766 header.codec = kRtpVideoVp9;
1767
1768 for (int tid = 1; tid <= kMaxTemporalStreams; ++tid) {
1769 header.codecHeader.VP9.temporal_idx = tid;
1770
1771 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1772 header, kRetransmitOff,
1773 kDefaultExpectedRetransmissionTimeMs));
1774 EXPECT_EQ(kDontRetransmit, rtp_sender_video_->GetStorageType(
1775 header, kRetransmitBaseLayer,
1776 kDefaultExpectedRetransmissionTimeMs));
1777 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1778 header, kRetransmitHigherLayers,
1779 kDefaultExpectedRetransmissionTimeMs));
1780 EXPECT_EQ(kAllowRetransmission,
1781 rtp_sender_video_->GetStorageType(
1782 header, kRetransmitHigherLayers | kRetransmitBaseLayer,
1783 kDefaultExpectedRetransmissionTimeMs));
1784 EXPECT_EQ(kAllowRetransmission, rtp_sender_video_->GetStorageType(
1785 header, kRetransmitAllPackets,
1786 kDefaultExpectedRetransmissionTimeMs));
1787 }
1788}
1789
1790TEST_P(RtpSenderVideoTest, ConditionalRetransmit) {
1791 const int64_t kFrameIntervalMs = 33;
1792 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1793 const uint8_t kSettings =
1794 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1795
1796 // Insert VP8 frames for all temporal layers, but stop before the final index.
1797 RTPVideoHeader header;
1798 header.codec = kRtpVideoVp8;
1799
1800 // Fill averaging window to prevent rounding errors.
1801 constexpr int kNumRepetitions =
1802 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1803 kFrameIntervalMs;
1804 constexpr int kPattern[] = {0, 2, 1, 2};
1805 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
1806 header.codecHeader.VP8.temporalIdx = kPattern[i % arraysize(kPattern)];
1807 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1808 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1809 }
1810
1811 // Since we're at the start of the pattern, the next expected frame in TL0 is
1812 // right now. We will wait at most one expected retransmission time before
1813 // acknowledging that it did not arrive, which means this frame and the next
1814 // will not be retransmitted.
1815 header.codecHeader.VP8.temporalIdx = 1;
1816 EXPECT_EQ(StorageType::kDontRetransmit,
1817 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1818 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1819 EXPECT_EQ(StorageType::kDontRetransmit,
1820 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1821 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1822
1823 // The TL0 frame did not arrive. So allow retransmission.
1824 EXPECT_EQ(StorageType::kAllowRetransmission,
1825 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1826 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1827
1828 // Insert a frame for TL2. We just had frame in TL1, so the next one there is
1829 // in three frames away. TL0 is still too far in the past. So, allow
1830 // retransmission.
1831 header.codecHeader.VP8.temporalIdx = 2;
1832 EXPECT_EQ(StorageType::kAllowRetransmission,
1833 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1834 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1835
1836 // Another TL2, next in TL1 is two frames away. Allow again.
1837 EXPECT_EQ(StorageType::kAllowRetransmission,
1838 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1839 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1840
1841 // Yet another TL2, next in TL1 is now only one frame away, so don't store
1842 // for retransmission.
1843 EXPECT_EQ(StorageType::kDontRetransmit,
1844 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1845}
1846
1847TEST_P(RtpSenderVideoTest, ConditionalRetransmitLimit) {
1848 const int64_t kFrameIntervalMs = 200;
1849 const int64_t kRttMs = (kFrameIntervalMs * 3) / 2;
1850 const int32_t kSettings =
1851 kRetransmitBaseLayer | kConditionallyRetransmitHigherLayers;
1852
1853 // Insert VP8 frames for all temporal layers, but stop before the final index.
1854 RTPVideoHeader header;
1855 header.codec = kRtpVideoVp8;
1856
1857 // Fill averaging window to prevent rounding errors.
1858 constexpr int kNumRepetitions =
1859 (RTPSenderVideo::kTLRateWindowSizeMs + (kFrameIntervalMs / 2)) /
1860 kFrameIntervalMs;
1861 constexpr int kPattern[] = {0, 2, 2, 2};
1862 for (size_t i = 0; i < arraysize(kPattern) * kNumRepetitions; ++i) {
1863 header.codecHeader.VP8.temporalIdx = kPattern[i % arraysize(kPattern)];
1864
1865 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs);
1866 fake_clock_.AdvanceTimeMilliseconds(kFrameIntervalMs);
1867 }
1868
1869 // Since we're at the start of the pattern, the next expected frame will be
1870 // right now in TL0. Put it in TL1 instead. Regular rules would dictate that
1871 // we don't store for retransmission because we expect a frame in a lower
1872 // layer, but that last frame in TL1 was a long time ago in absolute terms,
1873 // so allow retransmission anyway.
1874 header.codecHeader.VP8.temporalIdx = 1;
1875 EXPECT_EQ(StorageType::kAllowRetransmission,
1876 rtp_sender_video_->GetStorageType(header, kSettings, kRttMs));
1877}
1878
minyue3a407ee2017-04-03 01:10:33 -07001879TEST_P(RtpSenderTest, OnOverheadChanged) {
michaelt4da30442016-11-17 01:38:43 -08001880 MockOverheadObserver mock_overhead_observer;
1881 rtp_sender_.reset(
1882 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1883 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1884 &retransmission_rate_limiter_, &mock_overhead_observer));
nisse7d59f6b2017-02-21 03:40:24 -08001885 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08001886
michaelt4da30442016-11-17 01:38:43 -08001887 // RTP overhead is 12B.
nisse284542b2017-01-10 08:58:32 -08001888 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(12)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001889 SendGenericPayload();
1890
1891 rtp_sender_->RegisterRtpHeaderExtension(kRtpExtensionTransmissionTimeOffset,
1892 kTransmissionTimeOffsetExtensionId);
1893
1894 // TransmissionTimeOffset extension has a size of 8B.
nisse284542b2017-01-10 08:58:32 -08001895 // 12B + 8B = 20B
1896 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(20)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001897 SendGenericPayload();
1898}
1899
minyue3a407ee2017-04-03 01:10:33 -07001900TEST_P(RtpSenderTest, DoesNotUpdateOverheadOnEqualSize) {
michaelt4da30442016-11-17 01:38:43 -08001901 MockOverheadObserver mock_overhead_observer;
1902 rtp_sender_.reset(
1903 new RTPSender(false, &fake_clock_, &transport_, nullptr, nullptr, nullptr,
1904 nullptr, nullptr, nullptr, nullptr, nullptr, nullptr,
1905 &retransmission_rate_limiter_, &mock_overhead_observer));
nisse7d59f6b2017-02-21 03:40:24 -08001906 rtp_sender_->SetSSRC(kSsrc);
michaelt4da30442016-11-17 01:38:43 -08001907
1908 EXPECT_CALL(mock_overhead_observer, OnOverheadChanged(_)).Times(1);
michaelt4da30442016-11-17 01:38:43 -08001909 SendGenericPayload();
1910 SendGenericPayload();
1911}
1912
minyue3a407ee2017-04-03 01:10:33 -07001913TEST_P(RtpSenderTest, SendAudioPadding) {
stefan53b6cc32017-02-03 08:13:57 -08001914 MockTransport transport;
1915 const bool kEnableAudio = true;
1916 rtp_sender_.reset(new RTPSender(
1917 kEnableAudio, &fake_clock_, &transport, &mock_paced_sender_, nullptr,
1918 nullptr, nullptr, nullptr, nullptr, nullptr, &mock_rtc_event_log_,
1919 nullptr, &retransmission_rate_limiter_, nullptr));
1920 rtp_sender_->SetSendPayloadType(kPayload);
1921 rtp_sender_->SetSequenceNumber(kSeqNum);
1922 rtp_sender_->SetTimestampOffset(0);
1923 rtp_sender_->SetSSRC(kSsrc);
1924
1925 const size_t kPaddingSize = 59;
1926 EXPECT_CALL(transport, SendRtp(_, kPaddingSize + kRtpHeaderSize, _))
1927 .WillOnce(testing::Return(true));
philipelc7bf32a2017-02-17 03:59:43 -08001928 EXPECT_EQ(kPaddingSize,
philipel8aadd502017-02-23 02:56:13 -08001929 rtp_sender_->TimeToSendPadding(kPaddingSize, PacedPacketInfo()));
stefan53b6cc32017-02-03 08:13:57 -08001930
1931 // Requested padding size is too small, will send a larger one.
1932 const size_t kMinPaddingSize = 50;
1933 EXPECT_CALL(transport, SendRtp(_, kMinPaddingSize + kRtpHeaderSize, _))
1934 .WillOnce(testing::Return(true));
philipel8aadd502017-02-23 02:56:13 -08001935 EXPECT_EQ(
1936 kMinPaddingSize,
1937 rtp_sender_->TimeToSendPadding(kMinPaddingSize - 5, PacedPacketInfo()));
stefan53b6cc32017-02-03 08:13:57 -08001938}
minyue3a407ee2017-04-03 01:10:33 -07001939
sprang168794c2017-07-06 04:38:06 -07001940TEST_P(RtpSenderTest, SendsKeepAlive) {
1941 MockTransport transport;
1942 rtp_sender_.reset(new RTPSender(false, &fake_clock_, &transport, nullptr,
1943 nullptr, nullptr, nullptr, nullptr, nullptr,
1944 nullptr, &mock_rtc_event_log_, nullptr,
1945 &retransmission_rate_limiter_, nullptr));
1946 rtp_sender_->SetSendPayloadType(kPayload);
1947 rtp_sender_->SetSequenceNumber(kSeqNum);
1948 rtp_sender_->SetTimestampOffset(0);
1949 rtp_sender_->SetSSRC(kSsrc);
1950
1951 const uint8_t kKeepalivePayloadType = 20;
1952 RTC_CHECK_NE(kKeepalivePayloadType, kPayload);
1953
1954 EXPECT_CALL(transport, SendRtp(_, _, _))
1955 .WillOnce(
1956 Invoke([&kKeepalivePayloadType](const uint8_t* packet, size_t len,
1957 const PacketOptions& options) {
1958 webrtc::RTPHeader rtp_header;
1959 RtpUtility::RtpHeaderParser parser(packet, len);
1960 EXPECT_TRUE(parser.Parse(&rtp_header, nullptr));
1961 EXPECT_FALSE(rtp_header.markerBit);
1962 EXPECT_EQ(0U, rtp_header.paddingLength);
1963 EXPECT_EQ(kKeepalivePayloadType, rtp_header.payloadType);
1964 EXPECT_EQ(kSeqNum, rtp_header.sequenceNumber);
1965 EXPECT_EQ(kSsrc, rtp_header.ssrc);
1966 EXPECT_EQ(0u, len - rtp_header.headerLength);
1967 return true;
1968 }));
1969
1970 rtp_sender_->SendKeepAlive(kKeepalivePayloadType);
1971 EXPECT_EQ(kSeqNum + 1, rtp_sender_->SequenceNumber());
1972}
1973
minyue3a407ee2017-04-03 01:10:33 -07001974INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
1975 RtpSenderTest,
1976 ::testing::Bool());
1977INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
1978 RtpSenderTestWithoutPacer,
1979 ::testing::Bool());
1980INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
1981 RtpSenderVideoTest,
1982 ::testing::Bool());
1983INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
1984 RtpSenderAudioTest,
1985 ::testing::Bool());
solenberg@webrtc.orgc0352d52013-05-20 20:55:07 +00001986} // namespace webrtc