mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
kwiberg | 27f982b | 2016-03-01 11:52:33 -0800 | [diff] [blame] | 11 | #include <memory> |
| 12 | |
Henrik Kjellander | ff761fb | 2015-11-04 08:31:52 +0100 | [diff] [blame] | 13 | #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h" |
sprang | e2d83d6 | 2016-02-19 09:03:26 -0800 | [diff] [blame] | 14 | #include "webrtc/system_wrappers/include/metrics.h" |
asapersson | 01d70a3 | 2016-05-20 06:29:46 -0700 | [diff] [blame] | 15 | #include "webrtc/system_wrappers/include/metrics_default.h" |
kwiberg | ac9f876 | 2016-09-30 22:29:43 -0700 | [diff] [blame] | 16 | #include "webrtc/test/gmock.h" |
| 17 | #include "webrtc/test/gtest.h" |
Peter Boström | 7623ce4 | 2015-12-09 12:13:30 +0100 | [diff] [blame] | 18 | #include "webrtc/video/call_stats.h" |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 19 | |
| 20 | using ::testing::_; |
| 21 | using ::testing::AnyNumber; |
| 22 | using ::testing::Return; |
| 23 | |
| 24 | namespace webrtc { |
| 25 | |
fischman@webrtc.org | aea96d3 | 2013-02-19 22:09:36 +0000 | [diff] [blame] | 26 | class MockStatsObserver : public CallStatsObserver { |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 27 | public: |
| 28 | MockStatsObserver() {} |
| 29 | virtual ~MockStatsObserver() {} |
| 30 | |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 31 | MOCK_METHOD2(OnRttUpdate, void(int64_t, int64_t)); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 32 | }; |
| 33 | |
| 34 | class CallStatsTest : public ::testing::Test { |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 35 | public: |
| 36 | CallStatsTest() : fake_clock_(12345) {} |
| 37 | |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 38 | protected: |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 39 | virtual void SetUp() { call_stats_.reset(new CallStats(&fake_clock_)); } |
| 40 | SimulatedClock fake_clock_; |
kwiberg | 27f982b | 2016-03-01 11:52:33 -0800 | [diff] [blame] | 41 | std::unique_ptr<CallStats> call_stats_; |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 42 | }; |
| 43 | |
| 44 | TEST_F(CallStatsTest, AddAndTriggerCallback) { |
| 45 | MockStatsObserver stats_observer; |
asapersson@webrtc.org | 1ae1d0c | 2013-11-20 12:46:11 +0000 | [diff] [blame] | 46 | RtcpRttStats* rtcp_rtt_stats = call_stats_->rtcp_rtt_stats(); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 47 | call_stats_->RegisterStatsObserver(&stats_observer); |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 48 | fake_clock_.AdvanceTimeMilliseconds(1000); |
sprang | e2d83d6 | 2016-02-19 09:03:26 -0800 | [diff] [blame] | 49 | EXPECT_EQ(-1, rtcp_rtt_stats->LastProcessedRtt()); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 50 | |
pkasting@chromium.org | 16825b1 | 2015-01-12 21:51:21 +0000 | [diff] [blame] | 51 | const int64_t kRtt = 25; |
asapersson@webrtc.org | 1ae1d0c | 2013-11-20 12:46:11 +0000 | [diff] [blame] | 52 | rtcp_rtt_stats->OnRttUpdate(kRtt); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 53 | EXPECT_CALL(stats_observer, OnRttUpdate(kRtt, kRtt)).Times(1); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 54 | call_stats_->Process(); |
asapersson@webrtc.org | 1ae1d0c | 2013-11-20 12:46:11 +0000 | [diff] [blame] | 55 | EXPECT_EQ(kRtt, rtcp_rtt_stats->LastProcessedRtt()); |
| 56 | |
pkasting@chromium.org | 16825b1 | 2015-01-12 21:51:21 +0000 | [diff] [blame] | 57 | const int64_t kRttTimeOutMs = 1500 + 10; |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 58 | fake_clock_.AdvanceTimeMilliseconds(kRttTimeOutMs); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 59 | EXPECT_CALL(stats_observer, OnRttUpdate(_, _)).Times(0); |
asapersson@webrtc.org | 1ae1d0c | 2013-11-20 12:46:11 +0000 | [diff] [blame] | 60 | call_stats_->Process(); |
sprang | e2d83d6 | 2016-02-19 09:03:26 -0800 | [diff] [blame] | 61 | EXPECT_EQ(-1, rtcp_rtt_stats->LastProcessedRtt()); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 62 | |
| 63 | call_stats_->DeregisterStatsObserver(&stats_observer); |
| 64 | } |
| 65 | |
| 66 | TEST_F(CallStatsTest, ProcessTime) { |
| 67 | MockStatsObserver stats_observer; |
| 68 | call_stats_->RegisterStatsObserver(&stats_observer); |
asapersson@webrtc.org | 1ae1d0c | 2013-11-20 12:46:11 +0000 | [diff] [blame] | 69 | RtcpRttStats* rtcp_rtt_stats = call_stats_->rtcp_rtt_stats(); |
| 70 | rtcp_rtt_stats->OnRttUpdate(100); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 71 | |
| 72 | // Time isn't updated yet. |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 73 | EXPECT_CALL(stats_observer, OnRttUpdate(_, _)).Times(0); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 74 | call_stats_->Process(); |
| 75 | |
| 76 | // Advance clock and verify we get an update. |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 77 | fake_clock_.AdvanceTimeMilliseconds(1000); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 78 | EXPECT_CALL(stats_observer, OnRttUpdate(_, _)).Times(1); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 79 | call_stats_->Process(); |
| 80 | |
| 81 | // Advance clock just too little to get an update. |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 82 | fake_clock_.AdvanceTimeMilliseconds(999); |
asapersson@webrtc.org | 1ae1d0c | 2013-11-20 12:46:11 +0000 | [diff] [blame] | 83 | rtcp_rtt_stats->OnRttUpdate(100); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 84 | EXPECT_CALL(stats_observer, OnRttUpdate(_, _)).Times(0); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 85 | call_stats_->Process(); |
| 86 | |
| 87 | // Advance enough to trigger a new update. |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 88 | fake_clock_.AdvanceTimeMilliseconds(1); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 89 | EXPECT_CALL(stats_observer, OnRttUpdate(_, _)).Times(1); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 90 | call_stats_->Process(); |
| 91 | |
| 92 | call_stats_->DeregisterStatsObserver(&stats_observer); |
| 93 | } |
| 94 | |
| 95 | // Verify all observers get correct estimates and observers can be added and |
| 96 | // removed. |
| 97 | TEST_F(CallStatsTest, MultipleObservers) { |
| 98 | MockStatsObserver stats_observer_1; |
| 99 | call_stats_->RegisterStatsObserver(&stats_observer_1); |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 100 | // Add the second observer twice, there should still be only one report to the |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 101 | // observer. |
| 102 | MockStatsObserver stats_observer_2; |
| 103 | call_stats_->RegisterStatsObserver(&stats_observer_2); |
| 104 | call_stats_->RegisterStatsObserver(&stats_observer_2); |
| 105 | |
asapersson@webrtc.org | 1ae1d0c | 2013-11-20 12:46:11 +0000 | [diff] [blame] | 106 | RtcpRttStats* rtcp_rtt_stats = call_stats_->rtcp_rtt_stats(); |
pkasting@chromium.org | 16825b1 | 2015-01-12 21:51:21 +0000 | [diff] [blame] | 107 | const int64_t kRtt = 100; |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 108 | rtcp_rtt_stats->OnRttUpdate(kRtt); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 109 | |
| 110 | // Verify both observers are updated. |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 111 | fake_clock_.AdvanceTimeMilliseconds(1000); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 112 | EXPECT_CALL(stats_observer_1, OnRttUpdate(kRtt, kRtt)).Times(1); |
| 113 | EXPECT_CALL(stats_observer_2, OnRttUpdate(kRtt, kRtt)).Times(1); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 114 | call_stats_->Process(); |
| 115 | |
| 116 | // Deregister the second observer and verify update is only sent to the first |
| 117 | // observer. |
| 118 | call_stats_->DeregisterStatsObserver(&stats_observer_2); |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 119 | rtcp_rtt_stats->OnRttUpdate(kRtt); |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 120 | fake_clock_.AdvanceTimeMilliseconds(1000); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 121 | EXPECT_CALL(stats_observer_1, OnRttUpdate(kRtt, kRtt)).Times(1); |
| 122 | EXPECT_CALL(stats_observer_2, OnRttUpdate(kRtt, kRtt)).Times(0); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 123 | call_stats_->Process(); |
| 124 | |
| 125 | // Deregister the first observer. |
| 126 | call_stats_->DeregisterStatsObserver(&stats_observer_1); |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 127 | rtcp_rtt_stats->OnRttUpdate(kRtt); |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 128 | fake_clock_.AdvanceTimeMilliseconds(1000); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 129 | EXPECT_CALL(stats_observer_1, OnRttUpdate(kRtt, kRtt)).Times(0); |
| 130 | EXPECT_CALL(stats_observer_2, OnRttUpdate(kRtt, kRtt)).Times(0); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 131 | call_stats_->Process(); |
| 132 | } |
| 133 | |
| 134 | // Verify increasing and decreasing rtt triggers callbacks with correct values. |
| 135 | TEST_F(CallStatsTest, ChangeRtt) { |
| 136 | MockStatsObserver stats_observer; |
| 137 | call_stats_->RegisterStatsObserver(&stats_observer); |
asapersson@webrtc.org | 1ae1d0c | 2013-11-20 12:46:11 +0000 | [diff] [blame] | 138 | RtcpRttStats* rtcp_rtt_stats = call_stats_->rtcp_rtt_stats(); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 139 | |
| 140 | // Advance clock to be ready for an update. |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 141 | fake_clock_.AdvanceTimeMilliseconds(1000); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 142 | |
| 143 | // Set a first value and verify the callback is triggered. |
pkasting@chromium.org | 16825b1 | 2015-01-12 21:51:21 +0000 | [diff] [blame] | 144 | const int64_t kFirstRtt = 100; |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 145 | rtcp_rtt_stats->OnRttUpdate(kFirstRtt); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 146 | EXPECT_CALL(stats_observer, OnRttUpdate(kFirstRtt, kFirstRtt)).Times(1); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 147 | call_stats_->Process(); |
| 148 | |
| 149 | // Increase rtt and verify the new value is reported. |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 150 | fake_clock_.AdvanceTimeMilliseconds(1000); |
pkasting@chromium.org | 16825b1 | 2015-01-12 21:51:21 +0000 | [diff] [blame] | 151 | const int64_t kHighRtt = kFirstRtt + 20; |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 152 | const int64_t kAvgRtt1 = 103; |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 153 | rtcp_rtt_stats->OnRttUpdate(kHighRtt); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 154 | EXPECT_CALL(stats_observer, OnRttUpdate(kAvgRtt1, kHighRtt)).Times(1); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 155 | call_stats_->Process(); |
| 156 | |
| 157 | // Increase time enough for a new update, but not too much to make the |
| 158 | // rtt invalid. Report a lower rtt and verify the old/high value still is sent |
| 159 | // in the callback. |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 160 | fake_clock_.AdvanceTimeMilliseconds(1000); |
pkasting@chromium.org | 16825b1 | 2015-01-12 21:51:21 +0000 | [diff] [blame] | 161 | const int64_t kLowRtt = kFirstRtt - 20; |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 162 | const int64_t kAvgRtt2 = 102; |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 163 | rtcp_rtt_stats->OnRttUpdate(kLowRtt); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 164 | EXPECT_CALL(stats_observer, OnRttUpdate(kAvgRtt2, kHighRtt)).Times(1); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 165 | call_stats_->Process(); |
| 166 | |
asapersson@webrtc.org | 1ae1d0c | 2013-11-20 12:46:11 +0000 | [diff] [blame] | 167 | // Advance time to make the high report invalid, the lower rtt should now be |
| 168 | // in the callback. |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 169 | fake_clock_.AdvanceTimeMilliseconds(1000); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 170 | const int64_t kAvgRtt3 = 95; |
| 171 | EXPECT_CALL(stats_observer, OnRttUpdate(kAvgRtt3, kLowRtt)).Times(1); |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 172 | call_stats_->Process(); |
| 173 | |
| 174 | call_stats_->DeregisterStatsObserver(&stats_observer); |
| 175 | } |
| 176 | |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 177 | TEST_F(CallStatsTest, LastProcessedRtt) { |
| 178 | MockStatsObserver stats_observer; |
| 179 | call_stats_->RegisterStatsObserver(&stats_observer); |
| 180 | RtcpRttStats* rtcp_rtt_stats = call_stats_->rtcp_rtt_stats(); |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 181 | fake_clock_.AdvanceTimeMilliseconds(1000); |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 182 | |
| 183 | // Set a first values and verify that LastProcessedRtt initially returns the |
| 184 | // average rtt. |
pkasting@chromium.org | 16825b1 | 2015-01-12 21:51:21 +0000 | [diff] [blame] | 185 | const int64_t kRttLow = 10; |
| 186 | const int64_t kRttHigh = 30; |
| 187 | const int64_t kAvgRtt = 20; |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 188 | rtcp_rtt_stats->OnRttUpdate(kRttLow); |
| 189 | rtcp_rtt_stats->OnRttUpdate(kRttHigh); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 190 | EXPECT_CALL(stats_observer, OnRttUpdate(kAvgRtt, kRttHigh)).Times(1); |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 191 | call_stats_->Process(); |
| 192 | EXPECT_EQ(kAvgRtt, rtcp_rtt_stats->LastProcessedRtt()); |
| 193 | |
| 194 | // Update values and verify LastProcessedRtt. |
Peter Boström | d3c9447 | 2015-12-09 11:20:58 +0100 | [diff] [blame] | 195 | fake_clock_.AdvanceTimeMilliseconds(1000); |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 196 | rtcp_rtt_stats->OnRttUpdate(kRttLow); |
| 197 | rtcp_rtt_stats->OnRttUpdate(kRttHigh); |
stefan | 2328a94 | 2015-08-07 04:27:51 -0700 | [diff] [blame] | 198 | EXPECT_CALL(stats_observer, OnRttUpdate(kAvgRtt, kRttHigh)).Times(1); |
asapersson@webrtc.org | 8084f95 | 2014-12-10 11:04:13 +0000 | [diff] [blame] | 199 | call_stats_->Process(); |
| 200 | EXPECT_EQ(kAvgRtt, rtcp_rtt_stats->LastProcessedRtt()); |
| 201 | |
| 202 | call_stats_->DeregisterStatsObserver(&stats_observer); |
| 203 | } |
| 204 | |
sprang | e2d83d6 | 2016-02-19 09:03:26 -0800 | [diff] [blame] | 205 | TEST_F(CallStatsTest, ProducesHistogramMetrics) { |
asapersson | 01d70a3 | 2016-05-20 06:29:46 -0700 | [diff] [blame] | 206 | metrics::Reset(); |
sprang | e2d83d6 | 2016-02-19 09:03:26 -0800 | [diff] [blame] | 207 | const int64_t kRtt = 123; |
| 208 | RtcpRttStats* rtcp_rtt_stats = call_stats_->rtcp_rtt_stats(); |
| 209 | rtcp_rtt_stats->OnRttUpdate(kRtt); |
| 210 | fake_clock_.AdvanceTimeMilliseconds(metrics::kMinRunTimeInSeconds * 1000); |
| 211 | rtcp_rtt_stats->OnRttUpdate(kRtt); |
| 212 | call_stats_->Process(); |
| 213 | call_stats_.reset(); |
| 214 | |
asapersson | 01d70a3 | 2016-05-20 06:29:46 -0700 | [diff] [blame] | 215 | EXPECT_EQ(1, metrics::NumSamples( |
sprang | e2d83d6 | 2016-02-19 09:03:26 -0800 | [diff] [blame] | 216 | "WebRTC.Video.AverageRoundTripTimeInMilliseconds")); |
asapersson | 01d70a3 | 2016-05-20 06:29:46 -0700 | [diff] [blame] | 217 | EXPECT_EQ(1, metrics::NumEvents( |
| 218 | "WebRTC.Video.AverageRoundTripTimeInMilliseconds", kRtt)); |
sprang | e2d83d6 | 2016-02-19 09:03:26 -0800 | [diff] [blame] | 219 | } |
| 220 | |
mflodman@webrtc.org | b2f474e | 2012-11-16 13:57:26 +0000 | [diff] [blame] | 221 | } // namespace webrtc |