peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 11 | #include "modules/audio_processing/aec3/subtractor.h" |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 12 | |
| 13 | #include <algorithm> |
| 14 | #include <numeric> |
| 15 | #include <string> |
| 16 | |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 17 | #include "modules/audio_processing/aec3/aec_state.h" |
Per Åhgren | 8ba5861 | 2017-12-01 23:01:44 +0100 | [diff] [blame] | 18 | #include "modules/audio_processing/aec3/render_delay_buffer.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 19 | #include "modules/audio_processing/test/echo_canceller_test_tools.h" |
| 20 | #include "rtc_base/random.h" |
Jonas Olsson | 366a50c | 2018-09-06 13:41:30 +0200 | [diff] [blame^] | 21 | #include "rtc_base/strings/string_builder.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 06:47:31 +0200 | [diff] [blame] | 22 | #include "test/gtest.h" |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 23 | |
| 24 | namespace webrtc { |
| 25 | namespace { |
| 26 | |
| 27 | float RunSubtractorTest(int num_blocks_to_process, |
| 28 | int delay_samples, |
Per Åhgren | ee8ad5f | 2018-08-10 21:15:48 +0200 | [diff] [blame] | 29 | int main_filter_length_blocks, |
| 30 | int shadow_filter_length_blocks, |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 31 | bool uncorrelated_inputs, |
| 32 | const std::vector<int>& blocks_with_echo_path_changes) { |
| 33 | ApmDataDumper data_dumper(42); |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 34 | EchoCanceller3Config config; |
Per Åhgren | ee8ad5f | 2018-08-10 21:15:48 +0200 | [diff] [blame] | 35 | config.filter.main.length_blocks = main_filter_length_blocks; |
| 36 | config.filter.shadow.length_blocks = shadow_filter_length_blocks; |
| 37 | |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 38 | Subtractor subtractor(config, &data_dumper, DetectOptimization()); |
Danil Chapovalov | db9f7ab | 2018-06-19 10:50:11 +0200 | [diff] [blame] | 39 | absl::optional<DelayEstimate> delay_estimate; |
peah | 86afe9d | 2017-04-06 15:45:32 -0700 | [diff] [blame] | 40 | std::vector<std::vector<float>> x(3, std::vector<float>(kBlockSize, 0.f)); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 41 | std::vector<float> y(kBlockSize, 0.f); |
| 42 | std::array<float, kBlockSize> x_old; |
| 43 | SubtractorOutput output; |
Per Åhgren | 8ba5861 | 2017-12-01 23:01:44 +0100 | [diff] [blame] | 44 | config.delay.min_echo_path_delay_blocks = 0; |
Per Åhgren | c59a576 | 2017-12-11 21:34:19 +0100 | [diff] [blame] | 45 | config.delay.default_delay = 1; |
Per Åhgren | 8ba5861 | 2017-12-01 23:01:44 +0100 | [diff] [blame] | 46 | std::unique_ptr<RenderDelayBuffer> render_delay_buffer( |
| 47 | RenderDelayBuffer::Create(config, 3)); |
Per Åhgren | 971de07 | 2018-03-14 23:23:47 +0100 | [diff] [blame] | 48 | RenderSignalAnalyzer render_signal_analyzer(config); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 49 | Random random_generator(42U); |
| 50 | Aec3Fft fft; |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 51 | std::array<float, kFftLengthBy2Plus1> Y2; |
| 52 | std::array<float, kFftLengthBy2Plus1> E2_main; |
| 53 | std::array<float, kFftLengthBy2Plus1> E2_shadow; |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 54 | AecState aec_state(config); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 55 | x_old.fill(0.f); |
| 56 | Y2.fill(0.f); |
| 57 | E2_main.fill(0.f); |
| 58 | E2_shadow.fill(0.f); |
| 59 | |
| 60 | DelayBuffer<float> delay_buffer(delay_samples); |
| 61 | for (int k = 0; k < num_blocks_to_process; ++k) { |
peah | 86afe9d | 2017-04-06 15:45:32 -0700 | [diff] [blame] | 62 | RandomizeSampleVector(&random_generator, x[0]); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 63 | if (uncorrelated_inputs) { |
| 64 | RandomizeSampleVector(&random_generator, y); |
| 65 | } else { |
peah | 86afe9d | 2017-04-06 15:45:32 -0700 | [diff] [blame] | 66 | delay_buffer.Delay(x[0], y); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 67 | } |
Per Åhgren | 8ba5861 | 2017-12-01 23:01:44 +0100 | [diff] [blame] | 68 | render_delay_buffer->Insert(x); |
| 69 | if (k == 0) { |
| 70 | render_delay_buffer->Reset(); |
| 71 | } |
Per Åhgren | c59a576 | 2017-12-11 21:34:19 +0100 | [diff] [blame] | 72 | render_delay_buffer->PrepareCaptureProcessing(); |
Per Åhgren | c59a576 | 2017-12-11 21:34:19 +0100 | [diff] [blame] | 73 | render_signal_analyzer.Update(*render_delay_buffer->GetRenderBuffer(), |
Per Åhgren | 5c532d3 | 2018-03-22 00:29:25 +0100 | [diff] [blame] | 74 | aec_state.FilterDelayBlocks()); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 75 | |
| 76 | // Handle echo path changes. |
| 77 | if (std::find(blocks_with_echo_path_changes.begin(), |
| 78 | blocks_with_echo_path_changes.end(), |
| 79 | k) != blocks_with_echo_path_changes.end()) { |
Per Åhgren | 8ba5861 | 2017-12-01 23:01:44 +0100 | [diff] [blame] | 80 | subtractor.HandleEchoPathChange(EchoPathVariability( |
| 81 | true, EchoPathVariability::DelayAdjustment::kNewDetectedDelay, |
| 82 | false)); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 83 | } |
Per Åhgren | c59a576 | 2017-12-11 21:34:19 +0100 | [diff] [blame] | 84 | subtractor.Process(*render_delay_buffer->GetRenderBuffer(), y, |
Per Åhgren | 8ba5861 | 2017-12-01 23:01:44 +0100 | [diff] [blame] | 85 | render_signal_analyzer, aec_state, &output); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 86 | |
Per Åhgren | 8ba5861 | 2017-12-01 23:01:44 +0100 | [diff] [blame] | 87 | aec_state.HandleEchoPathChange(EchoPathVariability( |
| 88 | false, EchoPathVariability::DelayAdjustment::kNone, false)); |
Per Åhgren | 3ab308f | 2018-02-21 08:46:03 +0100 | [diff] [blame] | 89 | aec_state.Update(delay_estimate, subtractor.FilterFrequencyResponse(), |
peah | 2910357 | 2017-07-11 02:54:02 -0700 | [diff] [blame] | 90 | subtractor.FilterImpulseResponse(), |
Per Åhgren | 0e6d2f5 | 2017-12-20 22:19:56 +0100 | [diff] [blame] | 91 | *render_delay_buffer->GetRenderBuffer(), E2_main, Y2, |
Per Åhgren | b20b937 | 2018-07-13 00:22:54 +0200 | [diff] [blame] | 92 | output, y); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 93 | } |
| 94 | |
| 95 | const float output_power = std::inner_product( |
| 96 | output.e_main.begin(), output.e_main.end(), output.e_main.begin(), 0.f); |
| 97 | const float y_power = std::inner_product(y.begin(), y.end(), y.begin(), 0.f); |
| 98 | if (y_power == 0.f) { |
| 99 | ADD_FAILURE(); |
| 100 | return -1.0; |
| 101 | } |
| 102 | return output_power / y_power; |
| 103 | } |
| 104 | |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 105 | std::string ProduceDebugText(size_t delay, int filter_length_blocks) { |
Jonas Olsson | 366a50c | 2018-09-06 13:41:30 +0200 | [diff] [blame^] | 106 | rtc::StringBuilder ss; |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 107 | ss << "Delay: " << delay << ", "; |
| 108 | ss << "Length: " << filter_length_blocks; |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 109 | return ss.str(); |
| 110 | } |
| 111 | |
| 112 | } // namespace |
| 113 | |
| 114 | #if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID) |
| 115 | |
| 116 | // Verifies that the check for non data dumper works. |
| 117 | TEST(Subtractor, NullDataDumper) { |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 118 | EXPECT_DEATH( |
| 119 | Subtractor(EchoCanceller3Config(), nullptr, DetectOptimization()), ""); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 120 | } |
| 121 | |
| 122 | // Verifies the check for null subtractor output. |
| 123 | // TODO(peah): Re-enable the test once the issue with memory leaks during DEATH |
| 124 | // tests on test bots has been fixed. |
| 125 | TEST(Subtractor, DISABLED_NullOutput) { |
| 126 | ApmDataDumper data_dumper(42); |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 127 | EchoCanceller3Config config; |
| 128 | Subtractor subtractor(config, &data_dumper, DetectOptimization()); |
Per Åhgren | 8ba5861 | 2017-12-01 23:01:44 +0100 | [diff] [blame] | 129 | std::unique_ptr<RenderDelayBuffer> render_delay_buffer( |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 130 | RenderDelayBuffer::Create(config, 3)); |
Per Åhgren | 971de07 | 2018-03-14 23:23:47 +0100 | [diff] [blame] | 131 | RenderSignalAnalyzer render_signal_analyzer(config); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 132 | std::vector<float> y(kBlockSize, 0.f); |
| 133 | |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 134 | EXPECT_DEATH( |
| 135 | subtractor.Process(*render_delay_buffer->GetRenderBuffer(), y, |
| 136 | render_signal_analyzer, AecState(config), nullptr), |
| 137 | ""); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 138 | } |
| 139 | |
| 140 | // Verifies the check for the capture signal size. |
| 141 | TEST(Subtractor, WrongCaptureSize) { |
| 142 | ApmDataDumper data_dumper(42); |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 143 | EchoCanceller3Config config; |
| 144 | Subtractor subtractor(config, &data_dumper, DetectOptimization()); |
Per Åhgren | 8ba5861 | 2017-12-01 23:01:44 +0100 | [diff] [blame] | 145 | std::unique_ptr<RenderDelayBuffer> render_delay_buffer( |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 146 | RenderDelayBuffer::Create(config, 3)); |
Per Åhgren | 971de07 | 2018-03-14 23:23:47 +0100 | [diff] [blame] | 147 | RenderSignalAnalyzer render_signal_analyzer(config); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 148 | std::vector<float> y(kBlockSize - 1, 0.f); |
| 149 | SubtractorOutput output; |
| 150 | |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 151 | EXPECT_DEATH( |
| 152 | subtractor.Process(*render_delay_buffer->GetRenderBuffer(), y, |
| 153 | render_signal_analyzer, AecState(config), &output), |
| 154 | ""); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 155 | } |
| 156 | |
| 157 | #endif |
| 158 | |
| 159 | // Verifies that the subtractor is able to converge on correlated data. |
| 160 | TEST(Subtractor, Convergence) { |
| 161 | std::vector<int> blocks_with_echo_path_changes; |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 162 | for (size_t filter_length_blocks : {12, 20, 30}) { |
| 163 | for (size_t delay_samples : {0, 64, 150, 200, 301}) { |
| 164 | SCOPED_TRACE(ProduceDebugText(delay_samples, filter_length_blocks)); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 165 | |
Per Åhgren | ee8ad5f | 2018-08-10 21:15:48 +0200 | [diff] [blame] | 166 | float echo_to_nearend_power = RunSubtractorTest( |
| 167 | 400, delay_samples, filter_length_blocks, filter_length_blocks, false, |
| 168 | blocks_with_echo_path_changes); |
Per Åhgren | 019008b | 2017-12-18 11:38:39 +0100 | [diff] [blame] | 169 | |
| 170 | // Use different criteria to take overmodelling into account. |
| 171 | if (filter_length_blocks == 12) { |
| 172 | EXPECT_GT(0.1f, echo_to_nearend_power); |
| 173 | } else { |
| 174 | EXPECT_GT(1.f, echo_to_nearend_power); |
| 175 | } |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 176 | } |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 177 | } |
| 178 | } |
| 179 | |
Per Åhgren | ee8ad5f | 2018-08-10 21:15:48 +0200 | [diff] [blame] | 180 | // Verifies that the subtractor is able to handle the case when the main filter |
| 181 | // is longer than the shadow filter. |
| 182 | TEST(Subtractor, MainFilterLongerThanShadowFilter) { |
| 183 | std::vector<int> blocks_with_echo_path_changes; |
| 184 | float echo_to_nearend_power = |
| 185 | RunSubtractorTest(400, 64, 20, 15, false, blocks_with_echo_path_changes); |
| 186 | EXPECT_GT(0.5f, echo_to_nearend_power); |
| 187 | } |
| 188 | |
| 189 | // Verifies that the subtractor is able to handle the case when the shadow |
| 190 | // filter is longer than the main filter. |
| 191 | TEST(Subtractor, ShadowFilterLongerThanMainFilter) { |
| 192 | std::vector<int> blocks_with_echo_path_changes; |
| 193 | float echo_to_nearend_power = |
| 194 | RunSubtractorTest(400, 64, 15, 20, false, blocks_with_echo_path_changes); |
| 195 | EXPECT_GT(0.5f, echo_to_nearend_power); |
| 196 | } |
| 197 | |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 198 | // Verifies that the subtractor does not converge on uncorrelated signals. |
| 199 | TEST(Subtractor, NonConvergenceOnUncorrelatedSignals) { |
| 200 | std::vector<int> blocks_with_echo_path_changes; |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 201 | for (size_t filter_length_blocks : {12, 20, 30}) { |
| 202 | for (size_t delay_samples : {0, 64, 150, 200, 301}) { |
| 203 | SCOPED_TRACE(ProduceDebugText(delay_samples, filter_length_blocks)); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 204 | |
Per Åhgren | ee8ad5f | 2018-08-10 21:15:48 +0200 | [diff] [blame] | 205 | float echo_to_nearend_power = RunSubtractorTest( |
| 206 | 300, delay_samples, filter_length_blocks, filter_length_blocks, true, |
| 207 | blocks_with_echo_path_changes); |
Per Åhgren | 019008b | 2017-12-18 11:38:39 +0100 | [diff] [blame] | 208 | EXPECT_NEAR(1.f, echo_to_nearend_power, 0.1); |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 209 | } |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 210 | } |
| 211 | } |
| 212 | |
| 213 | // Verifies that the subtractor is properly reset when there is an echo path |
| 214 | // change. |
| 215 | TEST(Subtractor, EchoPathChangeReset) { |
| 216 | std::vector<int> blocks_with_echo_path_changes; |
| 217 | blocks_with_echo_path_changes.push_back(99); |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 218 | for (size_t filter_length_blocks : {12, 20, 30}) { |
| 219 | for (size_t delay_samples : {0, 64, 150, 200, 301}) { |
| 220 | SCOPED_TRACE(ProduceDebugText(delay_samples, filter_length_blocks)); |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 221 | |
Per Åhgren | ee8ad5f | 2018-08-10 21:15:48 +0200 | [diff] [blame] | 222 | float echo_to_nearend_power = RunSubtractorTest( |
| 223 | 100, delay_samples, filter_length_blocks, filter_length_blocks, false, |
| 224 | blocks_with_echo_path_changes); |
Per Åhgren | 09a718a | 2017-12-11 22:28:45 +0100 | [diff] [blame] | 225 | EXPECT_NEAR(1.f, echo_to_nearend_power, 0.0000001f); |
| 226 | } |
peah | 522d71b | 2017-02-23 05:16:26 -0800 | [diff] [blame] | 227 | } |
| 228 | } |
| 229 | |
| 230 | } // namespace webrtc |