blob: beca1c1dc3854dfffceab11bfc85725f07b9ac46 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Seth Hampson24722b32017-12-22 09:36:42 -080017#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070018#include "api/test/mock_video_decoder_factory.h"
19#include "api/test/mock_video_encoder_factory.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020020#include "api/video_codecs/builtin_video_decoder_factory.h"
21#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020022#include "api/video_codecs/sdp_video_format.h"
23#include "api/video_codecs/video_decoder_factory.h"
24#include "api/video_codecs/video_encoder.h"
25#include "api/video_codecs/video_encoder_factory.h"
26#include "call/flexfec_receive_stream.h"
27#include "common_video/h264/profile_level_id.h"
28#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020029#include "media/base/fakenetworkinterface.h"
30#include "media/base/fakevideocapturer.h"
31#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020032#include "media/base/mediaconstants.h"
33#include "media/base/rtputils.h"
34#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "media/engine/constants.h"
36#include "media/engine/fakewebrtccall.h"
37#include "media/engine/fakewebrtcvideoengine.h"
38#include "media/engine/simulcast.h"
39#include "media/engine/webrtcvideoengine.h"
40#include "media/engine/webrtcvoiceengine.h"
41#include "rtc_base/arraysize.h"
Mirko Bonadeif859e552018-05-30 15:31:29 +020042#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020043#include "rtc_base/gunit.h"
44#include "rtc_base/stringutils.h"
45#include "test/field_trial.h"
46#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000047
Tommi85959932018-02-07 19:26:06 +010048using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010049using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070050using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010051using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070052
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000053namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000054static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000055
noahricd10a68e2015-07-10 11:27:55 -070056static const uint8_t kRedRtxPayloadType = 125;
57
Niels Möller6557d0c2018-04-11 15:18:34 +020058static const uint32_t kTimeout = 5000U;
59static const uint32_t kDefaultReceiveSsrc = 0;
60static const uint32_t kSsrc = 1234u;
61static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
62static const int kVideoWidth = 640;
63static const int kVideoHeight = 360;
64static const int kFramerate = 30;
65
Peter Boström0c4e06b2015-10-07 12:23:21 +020066static const uint32_t kSsrcs1[] = {1};
67static const uint32_t kSsrcs3[] = {1, 2, 3};
68static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080069static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020070static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080071static const uint32_t kDefaultRecvSsrc = 0;
72
pbos@webrtc.org3c107582014-07-20 15:27:35 +000073static const char kUnsupportedExtensionName[] =
74 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000075
magjed509e4fe2016-11-18 01:34:11 -080076cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
77 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020078 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080079}
80
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000081void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
82 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
83 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
84 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
85 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
86 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
87 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
88 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080089 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
90 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000091 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
92}
93
magjed725e4842016-11-16 00:48:13 -080094// Return true if any codec in |codecs| is an RTX codec with associated payload
95// type |payload_type|.
96bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
97 int payload_type) {
98 for (const cricket::VideoCodec& codec : codecs) {
99 int associated_payload_type;
100 if (cricket::CodecNamesEq(codec.name.c_str(), "rtx") &&
101 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
102 &associated_payload_type) &&
103 associated_payload_type == payload_type) {
104 return true;
105 }
106 }
107 return false;
108}
109
nisseca5706d2017-09-11 02:32:16 -0700110// TODO(nisse): Duplicated in call.cc.
111const int* FindKeyByValue(const std::map<int, int>& m, int v) {
112 for (const auto& kv : m) {
113 if (kv.second == v)
114 return &kv.first;
115 }
116 return nullptr;
117}
118
119bool HasRtxReceiveAssociation(
120 const webrtc::VideoReceiveStream::Config& config,
121 int payload_type) {
122 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
123 payload_type) != nullptr;
124}
125
126// Check that there's an Rtx payload type for each decoder.
127bool VerifyRtxReceiveAssociations(
128 const webrtc::VideoReceiveStream::Config& config) {
129 for (const auto& decoder : config.decoders) {
130 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
131 return false;
132 }
133 return true;
134}
135
brandtrffc61182016-11-28 06:02:22 -0800136rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700137 int width,
138 int height) {
139 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
140 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800141 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700142 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000143}
144
Shao Changbine62202f2015-04-21 20:24:50 +0800145void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
146 const std::map<int, int>& rtx_types) {
147 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200148 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800149 EXPECT_TRUE(it != rtx_types.end() &&
150 it->second == config.rtp.rtx.payload_type);
151
brandtrb5f2c3f2016-10-04 23:28:39 -0700152 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
153 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800154 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700155 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800156 }
157}
kthelgason2bc68642017-02-07 07:02:22 -0800158
159cricket::MediaConfig GetMediaConfig() {
160 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100161 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800162 return media_config;
163}
nisse26e3abb2017-08-25 04:44:25 -0700164
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000165} // namespace
166
Niels Möller6557d0c2018-04-11 15:18:34 +0200167#define EXPECT_FRAME_WAIT(c, w, h, t) \
168 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
169 EXPECT_EQ((w), renderer_.width()); \
170 EXPECT_EQ((h), renderer_.height()); \
171 EXPECT_EQ(0, renderer_.errors());
172
173#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
174 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
175 EXPECT_EQ((w), (r).width()); \
176 EXPECT_EQ((h), (r).height()); \
177 EXPECT_EQ(0, (r).errors());
178
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000179namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700180class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000181 public:
eladalonf1841382017-06-12 01:16:46 -0700182 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
183 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700184 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700185 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200186 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
187 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200188 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200189 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200190 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200191 decoder_factory_)) {}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000192
193 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200194 void AssignDefaultAptRtxTypes();
195 void AssignDefaultCodec();
196
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100197 // Find the index of the codec in the engine with the given name. The codec
198 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100199 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100200
magjed509e4fe2016-11-18 01:34:11 -0800201 // Find the codec in the engine with the given name. The codec must be
202 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100203 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800204
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200205 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000206
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200207 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000208 const std::vector<VideoCodec>& codecs);
209
Peter Boströme4499152016-02-05 11:13:28 +0100210 void TestExtendedEncoderOveruse(bool use_external_encoder);
211
stefanc1aeaf02015-10-15 07:26:07 -0700212 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700213 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700214 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000215 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800216 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200217 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
218 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700219 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000220 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800221 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000222};
223
eladalonf1841382017-06-12 01:16:46 -0700224TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200225 encoder_factory_->AddSupportedVideoCodecType("VP8");
226 AssignDefaultCodec();
227
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000228 std::vector<VideoCodec> engine_codecs = engine_.codecs();
229 for (size_t i = 0; i < engine_codecs.size(); ++i) {
230 if (engine_codecs[i].name != kRtxCodecName)
231 continue;
232 int associated_payload_type;
233 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000234 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000235 EXPECT_EQ(default_codec_.id, associated_payload_type);
236 return;
237 }
238 FAIL() << "No RTX codec found among default codecs.";
239}
240
eladalonf1841382017-06-12 01:16:46 -0700241TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100242 RtpCapabilities capabilities = engine_.GetCapabilities();
243 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700244 for (const RtpExtension& extension : capabilities.header_extensions) {
245 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
246 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000247 return;
248 }
249 }
250 FAIL() << "Timestamp offset extension not in header-extension list.";
251}
252
eladalonf1841382017-06-12 01:16:46 -0700253TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100254 RtpCapabilities capabilities = engine_.GetCapabilities();
255 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700256 for (const RtpExtension& extension : capabilities.header_extensions) {
257 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
258 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000259 return;
260 }
261 }
262 FAIL() << "Absolute Sender Time extension not in header-extension list.";
263}
264
eladalonf1841382017-06-12 01:16:46 -0700265TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100266 RtpCapabilities capabilities = engine_.GetCapabilities();
267 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700268 for (const RtpExtension& extension : capabilities.header_extensions) {
269 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
270 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700271 return;
272 }
273 }
274 FAIL() << "Transport sequence number extension not in header-extension list.";
275}
276
eladalonf1841382017-06-12 01:16:46 -0700277TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100278 RtpCapabilities capabilities = engine_.GetCapabilities();
279 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700280 for (const RtpExtension& extension : capabilities.header_extensions) {
281 if (extension.uri == RtpExtension::kVideoRotationUri) {
282 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700283 return;
284 }
285 }
286 FAIL() << "Video Rotation extension not in header-extension list.";
287}
288
eladalonf1841382017-06-12 01:16:46 -0700289TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700290 // Allocate the capturer first to prevent early destruction before channel's
291 // dtor is called.
Tommi85959932018-02-07 19:26:06 +0100292 FakeVideoCapturerWithTaskQueue capturer;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700293
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200294 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700295
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200296 std::unique_ptr<VideoMediaChannel> channel(
297 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700298 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
299
300 // Add CVO extension.
301 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800302 cricket::VideoSendParameters parameters;
303 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200304 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700305 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200306 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700307
308 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200309 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700310
311 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700312 EXPECT_FALSE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700313
314 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200315 parameters.extensions.clear();
316 EXPECT_TRUE(channel->SetSendParameters(parameters));
nisse47ac4622016-05-25 08:47:01 -0700317 EXPECT_TRUE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700318}
319
eladalonf1841382017-06-12 01:16:46 -0700320TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
perkj91e1c152016-03-02 05:34:00 -0800321 // Allocate the capturer first to prevent early destruction before channel's
322 // dtor is called.
Tommi85959932018-02-07 19:26:06 +0100323 FakeVideoCapturerWithTaskQueue capturer;
perkj91e1c152016-03-02 05:34:00 -0800324
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200325 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800326
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200327 std::unique_ptr<VideoMediaChannel> channel(
328 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800329 // Add CVO extension.
330 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800331 cricket::VideoSendParameters parameters;
332 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800333 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700334 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800335 EXPECT_TRUE(channel->SetSendParameters(parameters));
336 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
337
338 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200339 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
perkj91e1c152016-03-02 05:34:00 -0800340
341 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700342 EXPECT_FALSE(capturer.apply_rotation());
perkj91e1c152016-03-02 05:34:00 -0800343}
344
eladalonf1841382017-06-12 01:16:46 -0700345TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Tommi85959932018-02-07 19:26:06 +0100346 FakeVideoCapturerWithTaskQueue capturer;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700347
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200348 encoder_factory_->AddSupportedVideoCodecType("VP8");
349 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700350
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200351 std::unique_ptr<VideoMediaChannel> channel(
352 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700353 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
354
355 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200356 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700357
perkjcaafdba2016-03-20 07:34:29 -0700358 // Verify capturer has turned on applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700359 EXPECT_TRUE(capturer.apply_rotation());
perkjcaafdba2016-03-20 07:34:29 -0700360
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700361 // Add CVO extension.
362 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800363 cricket::VideoSendParameters parameters;
364 parameters.codecs.push_back(GetEngineCodec("VP8"));
365 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200366 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700367 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700368 // Also remove the first codec to trigger a codec change as well.
369 parameters.codecs.erase(parameters.codecs.begin());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200370 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700371
372 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700373 EXPECT_FALSE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700374
375 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200376 parameters.extensions.clear();
377 EXPECT_TRUE(channel->SetSendParameters(parameters));
nisse47ac4622016-05-25 08:47:01 -0700378 EXPECT_TRUE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700379}
380
eladalonf1841382017-06-12 01:16:46 -0700381TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200382 encoder_factory_->AddSupportedVideoCodecType("VP8");
383
kwiberg686a8ef2016-02-26 03:00:35 -0800384 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800385 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000386
387 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
388
389 EXPECT_FALSE(channel->SetSend(true))
390 << "Channel should not start without codecs.";
391 EXPECT_TRUE(channel->SetSend(false))
392 << "Channel should be stoppable even without set codecs.";
393}
394
eladalonf1841382017-06-12 01:16:46 -0700395TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200396 encoder_factory_->AddSupportedVideoCodecType("VP8");
397
kwiberg686a8ef2016-02-26 03:00:35 -0800398 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800399 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000400 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
401 VideoMediaInfo info;
402 channel->GetStats(&info);
403}
404
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200405TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200406 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000407
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200408 std::unique_ptr<VideoMediaChannel> channel(
409 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800410 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000411
412 EXPECT_TRUE(
413 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200414 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000415 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100416 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200417 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000418 EXPECT_EQ(cricket::CS_RUNNING,
419 capturer.Start(capturer.GetSupportedFormats()->front()));
420 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100421 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200422 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
423 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000424 kTimeout);
425
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200426 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100427 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000428
429 // Setting codecs of the same type should not reallocate any encoders
430 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800431 cricket::VideoSendParameters parameters;
432 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200433 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200434 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000435
436 // Remove stream previously added to free the external encoder instance.
437 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200438 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000439}
440
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200441// Test that when an encoder factory supports H264, we add an RTX
442// codec for it.
443// TODO(deadbeef): This test should be updated if/when we start
444// adding RTX codecs for unrecognized codec names.
445TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800446 using webrtc::H264::ProfileLevelIdToString;
447 using webrtc::H264::ProfileLevelId;
448 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200449 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
450 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800451 *ProfileLevelIdToString(
452 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200453 webrtc::SdpVideoFormat h264_constrained_high("H264");
454 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800455 *ProfileLevelIdToString(
456 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200457 webrtc::SdpVideoFormat h264_high("H264");
458 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800459 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
460
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200461 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
462 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
463 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700464
magjed725e4842016-11-16 00:48:13 -0800465 // First figure out what payload types the test codecs got assigned.
466 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800467 // Now search for RTX codecs for them. Expect that they all have associated
468 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800469 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200470 codecs,
471 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
472 ->id));
magjed725e4842016-11-16 00:48:13 -0800473 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200474 codecs,
475 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
476 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800477 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200478 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700479}
480
Peter Boström12996152016-05-14 02:03:18 +0200481#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700482TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200483 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100484
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200485 std::unique_ptr<VideoMediaChannel> channel(
486 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100487
488 EXPECT_TRUE(
489 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
490}
Peter Boström12996152016-05-14 02:03:18 +0200491#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100492
eladalonf1841382017-06-12 01:16:46 -0700493TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200494 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100495 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200496 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200497 std::unique_ptr<VideoMediaChannel> channel(
498 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700499
500 EXPECT_TRUE(
501 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
502
Tommi85959932018-02-07 19:26:06 +0100503 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200504 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700505 capturer.Start(cricket::VideoFormat(1280, 720,
506 cricket::VideoFormat::FpsToInterval(60),
507 cricket::FOURCC_I420));
508 channel->SetSend(true);
509
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200510 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700511
512 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700513 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700514 for (int i = 0; i < 10; i++) {
515 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700516 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700517 int64_t interval = timestamp - last_timestamp;
518
519 // Precision changes from nanosecond to millisecond.
520 // Allow error to be no more than 1.
521 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
522
523 last_timestamp = timestamp;
524 }
525
526 capturer.Start(cricket::VideoFormat(1280, 720,
527 cricket::VideoFormat::FpsToInterval(30),
528 cricket::FOURCC_I420));
529
530 EXPECT_TRUE(capturer.CaptureFrame());
531 last_timestamp = stream->GetLastTimestamp();
532 for (int i = 0; i < 10; i++) {
533 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700534 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700535 int64_t interval = timestamp - last_timestamp;
536
537 // Precision changes from nanosecond to millisecond.
538 // Allow error to be no more than 1.
539 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
540
541 last_timestamp = timestamp;
542 }
543
544 // Remove stream previously added to free the external encoder instance.
545 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
546}
547
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200548void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
549 std::vector<VideoCodec> engine_codecs = engine_.codecs();
550 RTC_DCHECK(!engine_codecs.empty());
551 for (const cricket::VideoCodec& codec : engine_codecs) {
552 if (codec.name == "rtx") {
553 int associated_payload_type;
554 if (codec.GetParam(kCodecParamAssociatedPayloadType,
555 &associated_payload_type)) {
556 default_apt_rtx_types_[associated_payload_type] = codec.id;
557 }
558 }
559 }
560}
561
562void WebRtcVideoEngineTest::AssignDefaultCodec() {
563 std::vector<VideoCodec> engine_codecs = engine_.codecs();
564 RTC_DCHECK(!engine_codecs.empty());
565 bool codec_set = false;
566 for (const cricket::VideoCodec& codec : engine_codecs) {
567 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
568 codec.name != "ulpfec") {
569 default_codec_ = codec;
570 codec_set = true;
571 }
572 }
573
574 RTC_DCHECK(codec_set);
575}
576
Oleh Prypina40f8242017-12-21 13:32:23 +0100577size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
578 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100579 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
580 for (size_t i = 0; i < codecs.size(); ++i) {
581 const cricket::VideoCodec engine_codec = codecs[i];
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200582 if (!CodecNamesEq(name, engine_codec.name))
583 continue;
584 // The tests only use H264 Constrained Baseline. Make sure we don't return
585 // an internal H264 codec from the engine with a different H264 profile.
586 if (CodecNamesEq(name.c_str(), kH264CodecName)) {
587 const rtc::Optional<webrtc::H264::ProfileLevelId> profile_level_id =
588 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
589 if (profile_level_id->profile !=
590 webrtc::H264::kProfileConstrainedBaseline) {
591 continue;
592 }
593 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100594 return i;
magjed509e4fe2016-11-18 01:34:11 -0800595 }
596 // This point should never be reached.
597 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100598 return -1;
599}
600
601cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
602 const std::string& name) const {
603 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800604}
605
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200606VideoMediaChannel*
607WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
buildbot@webrtc.org1ecbe452014-10-14 20:29:28 +0000608 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800609 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200610 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800611 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200612 for (const webrtc::SdpVideoFormat& format :
613 encoder_factory_->GetSupportedFormats()) {
614 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
615 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
616 engine_codec) == parameters.codecs.end()) {
617 parameters.codecs.push_back(engine_codec);
618 }
619 }
magjed509e4fe2016-11-18 01:34:11 -0800620
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200621 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000622
623 return channel;
624}
625
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200626VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000627 const std::vector<VideoCodec>& codecs) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000628 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800629 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200630 cricket::VideoRecvParameters parameters;
631 parameters.codecs = codecs;
632 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000633
634 return channel;
635}
636
eladalonf1841382017-06-12 01:16:46 -0700637TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200638 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000639
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200640 std::unique_ptr<VideoMediaChannel> channel(
641 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000642
Peter Boström0c4e06b2015-10-07 12:23:21 +0200643 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000644
645 EXPECT_TRUE(
646 channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
647 EXPECT_TRUE(channel->SetSend(true));
648
Tommi85959932018-02-07 19:26:06 +0100649 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200650 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000651 EXPECT_EQ(cricket::CS_RUNNING,
652 capturer.Start(capturer.GetSupportedFormats()->front()));
653 EXPECT_TRUE(capturer.CaptureFrame());
654
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200655 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000656
657 // Verify that encoders are configured for simulcast through adapter
658 // (increasing resolution and only configured to send one stream each).
659 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200660 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
661 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000662 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200663 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000664 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
665 EXPECT_GT(codec_settings.width, prev_width);
666 prev_width = codec_settings.width;
667 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000668
Niels Möllerff40b142018-04-09 08:49:14 +0200669 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000670
671 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200672 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000673}
674
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200675TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
676 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200677 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000678
Niels Möller4db138e2018-04-19 09:04:13 +0200679 // Set capturer.
680 FakeVideoCapturerWithTaskQueue capturer;
681 EXPECT_EQ(cricket::CS_RUNNING,
682 capturer.Start(capturer.GetSupportedFormats()->front()));
683
Anders Carlsson67537952018-05-03 11:28:29 +0200684 std::unique_ptr<VideoMediaChannel> channel(
685 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
686 cricket::VideoSendParameters parameters;
687 parameters.codecs.push_back(GetEngineCodec("H264"));
688 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000689
690 EXPECT_TRUE(
691 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200692 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
693 // Sending one frame will have allocate the encoder.
694 EXPECT_TRUE(capturer.CaptureFrame());
695
696 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000697
Anders Carlsson67537952018-05-03 11:28:29 +0200698 cricket::VideoSendParameters new_parameters;
699 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
700 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200701
702 // Sending one frame will switch encoder.
703 EXPECT_TRUE(capturer.CaptureFrame());
704
Anders Carlsson8a150d92018-05-14 12:40:04 +0200705 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000706}
707
eladalonf1841382017-06-12 01:16:46 -0700708TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000709 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200710 encoder_factory_->AddSupportedVideoCodecType("VP8");
711 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000712
kwiberg686a8ef2016-02-26 03:00:35 -0800713 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800714 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800715 cricket::VideoSendParameters parameters;
716 parameters.codecs.push_back(GetEngineCodec("VP8"));
717 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000718
Peter Boström0c4e06b2015-10-07 12:23:21 +0200719 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000720
721 EXPECT_TRUE(
722 channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
723 EXPECT_TRUE(channel->SetSend(true));
724
725 // Send a fake frame, or else the media engine will configure the simulcast
726 // encoder adapter at a low-enough size that it'll only create a single
727 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100728 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200729 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000730 EXPECT_EQ(cricket::CS_RUNNING,
731 capturer.Start(capturer.GetSupportedFormats()->front()));
732 EXPECT_TRUE(capturer.CaptureFrame());
733
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200734 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
735 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000736 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200737 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000738
739 channel.reset();
740 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200741 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000742}
743
eladalonf1841382017-06-12 01:16:46 -0700744TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000745 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200746 encoder_factory_->AddSupportedVideoCodecType("VP8");
747 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000748
kwiberg686a8ef2016-02-26 03:00:35 -0800749 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800750 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800751 cricket::VideoSendParameters parameters;
752 parameters.codecs.push_back(GetEngineCodec("H264"));
753 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000754
755 EXPECT_TRUE(
756 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100757
758 // Send a frame of 720p. This should trigger a "real" encoder initialization.
759 cricket::VideoFormat format(
760 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100761 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200762 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100763 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
764 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200765 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
766 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200767 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000768 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200769 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000770
771 channel.reset();
772 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200773 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000774}
775
eladalonf1841382017-06-12 01:16:46 -0700776TEST_F(WebRtcVideoEngineTest, SimulcastDisabledForH264) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200777 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700778
Anders Carlsson67537952018-05-03 11:28:29 +0200779 std::unique_ptr<VideoMediaChannel> channel(
780 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
781 cricket::VideoSendParameters parameters;
782 parameters.codecs.push_back(GetEngineCodec("H264"));
783 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700784
Peter Boström0c4e06b2015-10-07 12:23:21 +0200785 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700786 EXPECT_TRUE(
787 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100788
789 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700790 cricket::VideoFormat format(
791 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100792 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200793 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100794 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
795 EXPECT_TRUE(capturer.CaptureFrame());
796
Niels Möller4db138e2018-04-19 09:04:13 +0200797 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200798 ASSERT_EQ(1u, encoder_factory_->encoders().size());
799 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
800 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700801 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
802 EXPECT_EQ(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200803 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700804}
805
brandtrffc61182016-11-28 06:02:22 -0800806// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700807// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800808//
809// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700810TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800811 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200812 encoder_factory_->AddSupportedVideoCodecType("VP8");
813
brandtrffc61182016-11-28 06:02:22 -0800814 auto is_flexfec = [](const VideoCodec& codec) {
815 if (codec.name == "flexfec-03")
816 return true;
817 return false;
818 };
819
820 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800821 const std::vector<VideoCodec> codecs_before = engine_.codecs();
822 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
823 codecs_before.end(), is_flexfec));
824
825 // FlexFEC is active with field trial.
826 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800827 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800828 const std::vector<VideoCodec> codecs_after = engine_.codecs();
829 EXPECT_NE(codecs_after.end(),
830 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
831}
832
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200833// Test that codecs are added in the order they are reported from the factory.
834TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
835 encoder_factory_->AddSupportedVideoCodecType("VP8");
836 const char* kFakeCodecName = "FakeCodec";
837 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000838
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200839 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100840 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200841 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
842 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000843}
844
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200845// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800846// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200847TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100848 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
849 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100850
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100851 // Set up external encoder factory with first codec, and initialize engine.
852 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
853
brandtrffc61182016-11-28 06:02:22 -0800854 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800855
856 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100857 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800858 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
859 EXPECT_EQ(codecs_before.size() + 1, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100860
861 // Check that both fake codecs are present and that the second fake codec
862 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100863 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
864 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100865 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800866}
867
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200868TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
869 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200870 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200871 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800872 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000873
kwiberg686a8ef2016-02-26 03:00:35 -0800874 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200875 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000876
877 EXPECT_TRUE(
878 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200879 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000880
881 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200882 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200883 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000884
885 // Remove stream previously added to free the external decoder instance.
886 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200887 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000888}
889
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200890// Verifies that we can set up decoders.
891TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000892 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
893 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
894 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
895 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200896 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200897 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000898 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800899 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000900
kwiberg686a8ef2016-02-26 03:00:35 -0800901 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200902 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000903
904 EXPECT_TRUE(
905 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200906 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000907}
908
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200909TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
910 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
911 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
912 WebRtcVideoEngine engine(std::move(encoder_factory),
913 std::move(decoder_factory));
914 EXPECT_EQ(0u, engine.codecs().size());
915}
916
917TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
918 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700919 webrtc::MockVideoEncoderFactory* encoder_factory =
920 new webrtc::MockVideoEncoderFactory();
921 webrtc::MockVideoDecoderFactory* decoder_factory =
922 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200923 WebRtcVideoEngine engine(
924 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
925 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
926 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
927 EXPECT_EQ(0u, engine.codecs().size());
928 EXPECT_CALL(*encoder_factory, Die());
929 EXPECT_CALL(*decoder_factory, Die());
930}
931
932// Test full behavior in the video engine when video codec factories of the new
933// type are injected supporting the single codec Vp8. Check the returned codecs
934// from the engine and that we will create a Vp8 encoder and decoder using the
935// new factories.
936TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
937 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700938 webrtc::MockVideoEncoderFactory* encoder_factory =
939 new webrtc::MockVideoEncoderFactory();
940 webrtc::MockVideoDecoderFactory* decoder_factory =
941 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200942 WebRtcVideoEngine engine(
943 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
944 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
945 const webrtc::SdpVideoFormat vp8_format("VP8");
946 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
947 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
948 .WillRepeatedly(testing::Return(supported_formats));
949
950 // Verify the codecs from the engine.
951 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100952 // Verify default codecs has been added correctly.
953 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200954 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100955
956 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200957 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100958 int vp8_associated_payload;
959 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
960 &vp8_associated_payload));
961 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
962
963 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
964
965 // RTX codec for RED.
966 EXPECT_EQ("rtx", engine_codecs.at(3).name);
967 int red_associated_payload;
968 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
969 &red_associated_payload));
970 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
971
972 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
973
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200974 int associated_payload_type;
975 EXPECT_TRUE(engine_codecs.at(1).GetParam(
976 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
977 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
978 // Verify default parameters has been added to the VP8 codec.
979 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
980
981 // Mock encoder creation. |engine| take ownership of the encoder.
982 webrtc::VideoEncoderFactory::CodecInfo codec_info;
983 codec_info.is_hardware_accelerated = false;
984 codec_info.has_internal_source = false;
985 const webrtc::SdpVideoFormat format("VP8");
986 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
987 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +0200988 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +0200989 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200990 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +0200991 .WillOnce(
992 ::testing::DoAll(::testing::InvokeWithoutArgs(
993 [&encoder_created]() { encoder_created.Set(); }),
994 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200995
996 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +0200997 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200998 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
999 .WillOnce(testing::Return(decoder));
1000
1001 // Create a call.
1002 webrtc::RtcEventLogNullImpl event_log;
1003 std::unique_ptr<webrtc::Call> call(
1004 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1005
1006 // Create send channel.
1007 const int send_ssrc = 123;
1008 std::unique_ptr<VideoMediaChannel> send_channel(
1009 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1010 cricket::VideoSendParameters send_parameters;
1011 send_parameters.codecs.push_back(engine_codecs.at(0));
1012 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1013 send_channel->OnReadyToSend(true);
1014 EXPECT_TRUE(
1015 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1016 EXPECT_TRUE(send_channel->SetSend(true));
1017
Niels Möller4db138e2018-04-19 09:04:13 +02001018 // Set capturer.
1019 FakeVideoCapturerWithTaskQueue capturer;
1020 EXPECT_EQ(cricket::CS_RUNNING,
1021 capturer.Start(capturer.GetSupportedFormats()->front()));
1022 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1023 // Sending one frame will allocate the encoder.
1024 EXPECT_TRUE(capturer.CaptureFrame());
1025 encoder_created.Wait(kTimeout);
1026
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001027 // Create recv channel.
1028 const int recv_ssrc = 321;
1029 std::unique_ptr<VideoMediaChannel> recv_channel(
1030 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1031 cricket::VideoRecvParameters recv_parameters;
1032 recv_parameters.codecs.push_back(engine_codecs.at(0));
1033 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1034 EXPECT_TRUE(recv_channel->AddRecvStream(
1035 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1036
1037 // Remove streams previously added to free the encoder and decoder instance.
1038 EXPECT_CALL(*encoder_factory, Die());
1039 EXPECT_CALL(*decoder_factory, Die());
1040 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1041 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1042}
1043
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001044// Test behavior when decoder factory fails to create a decoder (returns null).
1045TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1046 // |engine| take ownership of the factories.
1047 webrtc::MockVideoEncoderFactory* encoder_factory =
1048 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1049 webrtc::MockVideoDecoderFactory* decoder_factory =
1050 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1051 WebRtcVideoEngine engine(
1052 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1053 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1054 const webrtc::SdpVideoFormat vp8_format("VP8");
1055 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1056 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1057 .WillRepeatedly(testing::Return(supported_formats));
1058
1059 // Decoder creation fails.
1060 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1061 .WillOnce(testing::Return(nullptr));
1062
1063 // Create a call.
1064 webrtc::RtcEventLogNullImpl event_log;
1065 std::unique_ptr<webrtc::Call> call(
1066 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1067
1068 // Create recv channel.
1069 const int recv_ssrc = 321;
1070 std::unique_ptr<VideoMediaChannel> recv_channel(
1071 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1072 cricket::VideoRecvParameters recv_parameters;
1073 recv_parameters.codecs.push_back(engine.codecs().front());
1074 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1075 EXPECT_TRUE(recv_channel->AddRecvStream(
1076 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1077
1078 // Remove streams previously added to free the encoder and decoder instance.
1079 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1080}
1081
eladalonf1841382017-06-12 01:16:46 -07001082TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001083 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001084 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001085 std::unique_ptr<VideoMediaChannel> channel(
1086 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001087 ASSERT_TRUE(
1088 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1089 cricket::VideoCodec codec = GetEngineCodec("VP8");
1090 cricket::VideoSendParameters parameters;
1091 parameters.codecs.push_back(codec);
1092 channel->OnReadyToSend(true);
1093 channel->SetSend(true);
1094 ASSERT_TRUE(channel->SetSendParameters(parameters));
1095
Tommi85959932018-02-07 19:26:06 +01001096 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001097 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001098 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001099
1100 EXPECT_EQ(cricket::CS_RUNNING,
1101 capturer.Start(capturer.GetSupportedFormats()->front()));
1102 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001103 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
sprangf24a0642017-02-28 13:23:26 -08001104 EXPECT_EQ(webrtc::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001105 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001106
Niels Möllerff40b142018-04-09 08:49:14 +02001107 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001108 EXPECT_TRUE(capturer.CaptureFrame());
1109 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001110 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001111
1112 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001113 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001114 EXPECT_TRUE(capturer.CaptureFrame());
1115 // Change to screen content, recreate encoder. For the simulcast encoder
1116 // adapter case, this will result in two calls since InitEncode triggers a
1117 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001118 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
sprangf24a0642017-02-28 13:23:26 -08001119 EXPECT_EQ(webrtc::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001120 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001121
Niels Möllerff40b142018-04-09 08:49:14 +02001122 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001123 EXPECT_TRUE(capturer.CaptureFrame());
1124 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001125 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001126
1127 options.is_screencast.emplace(false);
1128 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001129 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001130 // Change back to regular video content, update encoder. Also change
1131 // a non |is_screencast| option just to verify it doesn't affect recreation.
1132 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001133 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
sprangf24a0642017-02-28 13:23:26 -08001134 EXPECT_EQ(webrtc::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001135 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001136
1137 // Remove stream previously added to free the external encoder instance.
1138 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001139 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001140}
1141
Niels Möller6557d0c2018-04-11 15:18:34 +02001142class WebRtcVideoChannelBaseTest : public testing::Test {
1143 protected:
1144 WebRtcVideoChannelBaseTest()
1145 : call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001146 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1147 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001148
1149 virtual void SetUp() {
1150 cricket::MediaConfig media_config;
1151 // Disabling cpu overuse detection actually disables quality scaling too; it
1152 // implies DegradationPreference kMaintainResolution. Automatic scaling
1153 // needs to be disabled, otherwise, tests which check the size of received
1154 // frames become flaky.
1155 media_config.video.enable_cpu_adaptation = false;
1156 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
1157 cricket::VideoOptions()));
1158 channel_->OnReadyToSend(true);
1159 EXPECT_TRUE(channel_.get() != NULL);
1160 network_interface_.SetDestination(channel_.get());
1161 channel_->SetInterface(&network_interface_);
1162 cricket::VideoRecvParameters parameters;
1163 parameters.codecs = engine_.codecs();
1164 channel_->SetRecvParameters(parameters);
1165 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1166 video_capturer_.reset(CreateFakeVideoCapturer());
1167 cricket::VideoFormat format(640, 480,
1168 cricket::VideoFormat::FpsToInterval(kFramerate),
1169 cricket::FOURCC_I420);
1170 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
1171 EXPECT_TRUE(
1172 channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
1173 }
1174
1175 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1176 return new cricket::FakeVideoCapturerWithTaskQueue();
1177 }
1178
1179 // Utility method to setup an additional stream to send and receive video.
1180 // Used to test send and recv between two streams.
1181 void SetUpSecondStream() {
1182 SetUpSecondStreamWithNoRecv();
1183 // Setup recv for second stream.
1184 EXPECT_TRUE(channel_->AddRecvStream(
1185 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1186 // Make the second renderer available for use by a new stream.
1187 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1188 }
1189 // Setup an additional stream just to send video. Defer add recv stream.
1190 // This is required if you want to test unsignalled recv of video rtp packets.
1191 void SetUpSecondStreamWithNoRecv() {
1192 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
1193 EXPECT_TRUE(channel_->AddRecvStream(
1194 cricket::StreamParams::CreateLegacy(kSsrc)));
1195 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1196 EXPECT_FALSE(channel_->AddSendStream(
1197 cricket::StreamParams::CreateLegacy(kSsrc)));
1198 EXPECT_TRUE(channel_->AddSendStream(
1199 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1200 // We dont add recv for the second stream.
1201
1202 // Setup the receive and renderer for second stream after send.
1203 video_capturer_2_.reset(CreateFakeVideoCapturer());
1204 cricket::VideoFormat format(640, 480,
1205 cricket::VideoFormat::FpsToInterval(kFramerate),
1206 cricket::FOURCC_I420);
1207 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1208
1209 EXPECT_TRUE(channel_->SetVideoSend(kSsrc + 2, nullptr,
1210 video_capturer_2_.get()));
1211 }
1212 virtual void TearDown() {
1213 channel_.reset();
1214 }
1215 bool SetDefaultCodec() {
1216 return SetOneCodec(DefaultCodec());
1217 }
1218
1219 bool SetOneCodec(const cricket::VideoCodec& codec) {
1220 cricket::VideoFormat capture_format(
1221 kVideoWidth, kVideoHeight,
1222 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1223
1224 if (video_capturer_) {
1225 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1226 }
1227 if (video_capturer_2_) {
1228 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1229 }
1230
1231 bool sending = channel_->sending();
1232 bool success = SetSend(false);
1233 if (success) {
1234 cricket::VideoSendParameters parameters;
1235 parameters.codecs.push_back(codec);
1236 success = channel_->SetSendParameters(parameters);
1237 }
1238 if (success) {
1239 success = SetSend(sending);
1240 }
1241 return success;
1242 }
1243 bool SetSend(bool send) {
1244 return channel_->SetSend(send);
1245 }
1246 bool SendFrame() {
1247 if (video_capturer_2_) {
1248 video_capturer_2_->CaptureFrame();
1249 }
1250 return video_capturer_.get() && video_capturer_->CaptureFrame();
1251 }
1252 bool WaitAndSendFrame(int wait_ms) {
1253 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1254 ret &= SendFrame();
1255 return ret;
1256 }
1257 int NumRtpBytes() {
1258 return network_interface_.NumRtpBytes();
1259 }
1260 int NumRtpBytes(uint32_t ssrc) {
1261 return network_interface_.NumRtpBytes(ssrc);
1262 }
1263 int NumRtpPackets() {
1264 return network_interface_.NumRtpPackets();
1265 }
1266 int NumRtpPackets(uint32_t ssrc) {
1267 return network_interface_.NumRtpPackets(ssrc);
1268 }
1269 int NumSentSsrcs() {
1270 return network_interface_.NumSentSsrcs();
1271 }
1272 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1273 return network_interface_.GetRtpPacket(index);
1274 }
1275 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
1276 int pt = -1;
1277 ParseRtpPacket(p, NULL, &pt, NULL, NULL, NULL, NULL);
1278 return pt;
1279 }
1280 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
1281 bool* x,
1282 int* pt,
1283 int* seqnum,
1284 uint32_t* tstamp,
1285 uint32_t* ssrc,
1286 std::string* payload) {
1287 rtc::ByteBufferReader buf(p->data<char>(), p->size());
1288 uint8_t u08 = 0;
1289 uint16_t u16 = 0;
1290 uint32_t u32 = 0;
1291
1292 // Read X and CC fields.
1293 if (!buf.ReadUInt8(&u08)) return false;
1294 bool extension = ((u08 & 0x10) != 0);
1295 uint8_t cc = (u08 & 0x0F);
1296 if (x) *x = extension;
1297
1298 // Read PT field.
1299 if (!buf.ReadUInt8(&u08)) return false;
1300 if (pt) *pt = (u08 & 0x7F);
1301
1302 // Read Sequence Number field.
1303 if (!buf.ReadUInt16(&u16)) return false;
1304 if (seqnum) *seqnum = u16;
1305
1306 // Read Timestamp field.
1307 if (!buf.ReadUInt32(&u32)) return false;
1308 if (tstamp) *tstamp = u32;
1309
1310 // Read SSRC field.
1311 if (!buf.ReadUInt32(&u32)) return false;
1312 if (ssrc) *ssrc = u32;
1313
1314 // Skip CSRCs.
1315 for (uint8_t i = 0; i < cc; ++i) {
1316 if (!buf.ReadUInt32(&u32)) return false;
1317 }
1318
1319 // Skip extension header.
1320 if (extension) {
1321 // Read Profile-specific extension header ID
1322 if (!buf.ReadUInt16(&u16)) return false;
1323
1324 // Read Extension header length
1325 if (!buf.ReadUInt16(&u16)) return false;
1326 uint16_t ext_header_len = u16;
1327
1328 // Read Extension header
1329 for (uint16_t i = 0; i < ext_header_len; ++i) {
1330 if (!buf.ReadUInt32(&u32)) return false;
1331 }
1332 }
1333
1334 if (payload) {
1335 return buf.ReadString(payload, buf.Length());
1336 }
1337 return true;
1338 }
1339
1340 // Tests that we can send and receive frames.
1341 void SendAndReceive(const cricket::VideoCodec& codec) {
1342 EXPECT_TRUE(SetOneCodec(codec));
1343 EXPECT_TRUE(SetSend(true));
1344 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1345 EXPECT_EQ(0, renderer_.num_rendered_frames());
1346 EXPECT_TRUE(SendFrame());
1347 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1348 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1349 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1350 }
1351
1352 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
1353 int duration_sec, int fps) {
1354 EXPECT_TRUE(SetOneCodec(codec));
1355 EXPECT_TRUE(SetSend(true));
1356 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1357 EXPECT_EQ(0, renderer_.num_rendered_frames());
1358 for (int i = 0; i < duration_sec; ++i) {
1359 for (int frame = 1; frame <= fps; ++frame) {
1360 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1361 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1362 }
1363 }
1364 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1365 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1366 }
1367
1368
1369 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1370 cricket::VideoMediaInfo info;
1371 EXPECT_TRUE(channel_->GetStats(&info));
1372 return info.senders[i];
1373 }
1374
1375 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1376 cricket::VideoMediaInfo info;
1377 EXPECT_TRUE(channel_->GetStats(&info));
1378 return info.receivers[i];
1379 }
1380
1381 // Two streams one channel tests.
1382
1383 // Tests that we can send and receive frames.
1384 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1385 SetUpSecondStream();
1386 // Test sending and receiving on first stream.
1387 SendAndReceive(codec);
1388 // Test sending and receiving on second stream.
1389 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1390 EXPECT_GT(NumRtpPackets(), 0);
1391 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1392 }
1393
1394 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1395 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
1396 if (CodecNamesEq(name, engine_codec.name))
1397 return engine_codec;
1398 }
1399 // This point should never be reached.
1400 ADD_FAILURE() << "Unrecognized codec name: " << name;
1401 return cricket::VideoCodec();
1402 }
1403
1404 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1405
1406 cricket::StreamParams DefaultSendStreamParams() {
1407 return cricket::StreamParams::CreateLegacy(kSsrc);
1408 }
1409
1410 webrtc::RtcEventLogNullImpl event_log_;
1411 const std::unique_ptr<webrtc::Call> call_;
1412 WebRtcVideoEngine engine_;
1413 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1414 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1415 std::unique_ptr<WebRtcVideoChannel> channel_;
1416 cricket::FakeNetworkInterface network_interface_;
1417 cricket::FakeVideoRenderer renderer_;
1418
1419 // Used by test cases where 2 streams are run on the same channel.
1420 cricket::FakeVideoRenderer renderer2_;
1421};
1422
1423// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001424TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001425 EXPECT_FALSE(channel_->sending());
1426 EXPECT_TRUE(
1427 channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
1428 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1429 EXPECT_FALSE(channel_->sending());
1430 EXPECT_TRUE(SetSend(true));
1431 EXPECT_TRUE(channel_->sending());
1432 EXPECT_TRUE(SendFrame());
1433 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1434 EXPECT_TRUE(SetSend(false));
1435 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001436}
Niels Möller6557d0c2018-04-11 15:18:34 +02001437
1438// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001439TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001440 EXPECT_FALSE(channel_->sending());
1441 EXPECT_FALSE(SetSend(true));
1442 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001443}
Niels Möller6557d0c2018-04-11 15:18:34 +02001444
1445// Test that we properly set the send and recv buffer sizes by the time
1446// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001447TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001448 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1449 EXPECT_TRUE(SetSend(true));
1450 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1451 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
srtee0c2eea2017-12-15 17:44:33 +01001452}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001453
Niels Möller6557d0c2018-04-11 15:18:34 +02001454// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001455TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001456 const int kDurationSec = 3;
1457 const int kFps = 10;
1458 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1459
1460 cricket::VideoMediaInfo info;
1461 EXPECT_TRUE(channel_->GetStats(&info));
1462
1463 ASSERT_EQ(1U, info.senders.size());
1464 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1465 // For webrtc, bytes_sent does not include the RTP header length.
1466 EXPECT_GT(info.senders[0].bytes_sent, 0);
1467 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1468 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1469 ASSERT_TRUE(info.senders[0].codec_payload_type);
1470 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1471 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1472 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1473 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1474 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1475 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1476 EXPECT_GT(info.senders[0].framerate_input, 0);
1477 EXPECT_GT(info.senders[0].framerate_sent, 0);
1478
1479 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1480 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1481 info.send_codecs[DefaultCodec().id]);
1482
1483 ASSERT_EQ(1U, info.receivers.size());
1484 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1485 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1486 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1487 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1488 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1489 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1490 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1491 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1492 EXPECT_EQ(0, info.receivers[0].packets_lost);
1493 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1494 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1495 EXPECT_EQ(0, info.receivers[0].firs_sent);
1496 EXPECT_EQ(0, info.receivers[0].plis_sent);
1497 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1498 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1499 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1500 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1501 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1502 EXPECT_GT(info.receivers[0].framerate_output, 0);
1503
1504 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1505 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1506 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001507}
Niels Möller6557d0c2018-04-11 15:18:34 +02001508
1509// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001510TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001511 cricket::FakeVideoRenderer renderer1, renderer2;
1512 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1513 cricket::VideoSendParameters parameters;
1514 parameters.codecs.push_back(DefaultCodec());
1515 parameters.conference_mode = true;
1516 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1517 EXPECT_TRUE(SetSend(true));
1518 EXPECT_TRUE(channel_->AddRecvStream(
1519 cricket::StreamParams::CreateLegacy(1)));
1520 EXPECT_TRUE(channel_->AddRecvStream(
1521 cricket::StreamParams::CreateLegacy(2)));
1522 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1523 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1524 EXPECT_EQ(0, renderer1.num_rendered_frames());
1525 EXPECT_EQ(0, renderer2.num_rendered_frames());
1526 std::vector<uint32_t> ssrcs;
1527 ssrcs.push_back(1);
1528 ssrcs.push_back(2);
1529 network_interface_.SetConferenceMode(true, ssrcs);
1530 EXPECT_TRUE(SendFrame());
1531 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1532 kTimeout);
1533 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1534 kTimeout);
1535
1536 EXPECT_TRUE(channel_->SetSend(false));
1537
1538 cricket::VideoMediaInfo info;
1539 EXPECT_TRUE(channel_->GetStats(&info));
1540 ASSERT_EQ(1U, info.senders.size());
1541 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1542 // For webrtc, bytes_sent does not include the RTP header length.
1543 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1544 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1545 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1546 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1547
1548 ASSERT_EQ(2U, info.receivers.size());
1549 for (size_t i = 0; i < info.receivers.size(); ++i) {
1550 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1551 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1552 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
1553 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd,
1554 kTimeout);
1555 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1556 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1557 }
srtee0c2eea2017-12-15 17:44:33 +01001558}
Niels Möller6557d0c2018-04-11 15:18:34 +02001559
1560// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001561TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001562 // Normal setup; note that we set the SSRC explicitly to ensure that
1563 // it will come first in the senders map.
1564 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1565 cricket::VideoSendParameters parameters;
1566 parameters.codecs.push_back(DefaultCodec());
1567 parameters.conference_mode = true;
1568 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1569 EXPECT_TRUE(channel_->AddRecvStream(
1570 cricket::StreamParams::CreateLegacy(kSsrc)));
1571 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1572 EXPECT_TRUE(SetSend(true));
1573 EXPECT_TRUE(SendFrame());
1574 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1575 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1576
1577 // Add an additional capturer, and hook up a renderer to receive it.
1578 cricket::FakeVideoRenderer renderer2;
1579 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1580 CreateFakeVideoCapturer());
1581 const int kTestWidth = 160;
1582 const int kTestHeight = 120;
1583 cricket::VideoFormat format(kTestWidth, kTestHeight,
1584 cricket::VideoFormat::FpsToInterval(5),
1585 cricket::FOURCC_I420);
1586 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1587 EXPECT_TRUE(channel_->AddSendStream(
1588 cricket::StreamParams::CreateLegacy(5678)));
1589 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
1590 EXPECT_TRUE(channel_->AddRecvStream(
1591 cricket::StreamParams::CreateLegacy(5678)));
1592 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1593 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
1594 EXPECT_FRAME_ON_RENDERER_WAIT(
1595 renderer2, 1, kTestWidth, kTestHeight, kTimeout);
1596
1597 // Get stats, and make sure they are correct for two senders. We wait until
1598 // the number of expected packets have been sent to avoid races where we
1599 // check stats before it has been updated.
1600 cricket::VideoMediaInfo info;
1601 for (uint32_t i = 0; i < kTimeout; ++i) {
1602 rtc::Thread::Current()->ProcessMessages(1);
1603 EXPECT_TRUE(channel_->GetStats(&info));
1604 ASSERT_EQ(2U, info.senders.size());
1605 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1606 NumRtpPackets()) {
1607 // Stats have been updated for both sent frames, expectations can be
1608 // checked now.
1609 break;
1610 }
1611 }
1612 EXPECT_EQ(NumRtpPackets(),
1613 info.senders[0].packets_sent + info.senders[1].packets_sent)
1614 << "Timed out while waiting for packet counts for all sent packets.";
1615 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1616 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1617 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1618 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1619 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1620 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1621 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1622 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1623 // The capturer must be unregistered here as it runs out of it's scope next.
1624 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001625}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001626
Niels Möller6557d0c2018-04-11 15:18:34 +02001627// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001628TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001629 cricket::VideoSendParameters parameters;
1630 parameters.codecs.push_back(DefaultCodec());
1631 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1632 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1633 parameters.max_bandwidth_bps = 128 * 1024;
1634 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001635}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001636
Niels Möller6557d0c2018-04-11 15:18:34 +02001637// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001638TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001639 EXPECT_TRUE(SetDefaultCodec());
1640 EXPECT_TRUE(SetSend(true));
1641 EXPECT_TRUE(SendFrame());
1642 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1643 uint32_t ssrc = 0;
1644 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1645 ParseRtpPacket(p.get(), NULL, NULL, NULL, NULL, &ssrc, NULL);
1646 EXPECT_EQ(kSsrc, ssrc);
1647 // Packets are being paced out, so these can mismatch between the first and
1648 // second call to NumRtpPackets until pending packets are paced out.
1649 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(ssrc), kTimeout);
1650 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(ssrc), kTimeout);
1651 EXPECT_EQ(1, NumSentSsrcs());
1652 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1653 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001654}
Niels Möller6557d0c2018-04-11 15:18:34 +02001655
1656// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001657TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001658 // Remove stream added in Setup.
1659 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1660 EXPECT_TRUE(SetDefaultCodec());
1661 EXPECT_TRUE(channel_->AddSendStream(
1662 cricket::StreamParams::CreateLegacy(999)));
1663 EXPECT_TRUE(
1664 channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
1665 EXPECT_TRUE(SetSend(true));
1666 EXPECT_TRUE(WaitAndSendFrame(0));
1667 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1668 uint32_t ssrc = 0;
1669 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1670 ParseRtpPacket(p.get(), NULL, NULL, NULL, NULL, &ssrc, NULL);
1671 EXPECT_EQ(999u, ssrc);
1672 // Packets are being paced out, so these can mismatch between the first and
1673 // second call to NumRtpPackets until pending packets are paced out.
1674 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(ssrc), kTimeout);
1675 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(ssrc), kTimeout);
1676 EXPECT_EQ(1, NumSentSsrcs());
1677 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1678 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001679}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001680
Niels Möller6557d0c2018-04-11 15:18:34 +02001681// Test that we can set the default video renderer before and after
1682// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001683TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001684 uint8_t data1[] = {
1685 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
1686
1687 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1688 rtc::SetBE32(packet1.data() + 8, kSsrc);
1689 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1690 EXPECT_TRUE(SetDefaultCodec());
1691 EXPECT_TRUE(SetSend(true));
1692 EXPECT_EQ(0, renderer_.num_rendered_frames());
1693 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1694 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1695 EXPECT_TRUE(SendFrame());
1696 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001697}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001698
Niels Möller6557d0c2018-04-11 15:18:34 +02001699// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001700TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001701 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1702 EXPECT_TRUE(SetSend(true));
1703 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1704 EXPECT_TRUE(SendFrame());
1705 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1706 EXPECT_GT(NumRtpPackets(), 0);
1707 uint32_t ssrc = 0;
1708 size_t last_packet = NumRtpPackets() - 1;
1709 std::unique_ptr<const rtc::CopyOnWriteBuffer>
1710 p(GetRtpPacket(static_cast<int>(last_packet)));
1711 ParseRtpPacket(p.get(), NULL, NULL, NULL, NULL, &ssrc, NULL);
1712 EXPECT_EQ(kSsrc, ssrc);
1713
1714 // Remove the send stream that was added during Setup.
1715 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1716 int rtp_packets = NumRtpPackets();
1717
1718 EXPECT_TRUE(channel_->AddSendStream(
1719 cricket::StreamParams::CreateLegacy(789u)));
1720 EXPECT_TRUE(
1721 channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
1722 EXPECT_EQ(rtp_packets, NumRtpPackets());
1723 // Wait 30ms to guarantee the engine does not drop the frame.
1724 EXPECT_TRUE(WaitAndSendFrame(30));
1725 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1726
1727 last_packet = NumRtpPackets() - 1;
1728 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
1729 ParseRtpPacket(p.get(), NULL, NULL, NULL, NULL, &ssrc, NULL);
1730 EXPECT_EQ(789u, ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001731}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001732
Niels Möller6557d0c2018-04-11 15:18:34 +02001733// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001734TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001735 cricket::FakeVideoRenderer renderer1, renderer2;
1736 EXPECT_TRUE(SetDefaultCodec());
1737 cricket::VideoSendParameters parameters;
1738 parameters.codecs.push_back(DefaultCodec());
1739 parameters.conference_mode = true;
1740 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1741 EXPECT_TRUE(SetSend(true));
1742 EXPECT_TRUE(channel_->AddRecvStream(
1743 cricket::StreamParams::CreateLegacy(1)));
1744 EXPECT_TRUE(channel_->AddRecvStream(
1745 cricket::StreamParams::CreateLegacy(2)));
1746 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1747 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1748 EXPECT_EQ(0, renderer1.num_rendered_frames());
1749 EXPECT_EQ(0, renderer2.num_rendered_frames());
1750 std::vector<uint32_t> ssrcs;
1751 ssrcs.push_back(1);
1752 ssrcs.push_back(2);
1753 network_interface_.SetConferenceMode(true, ssrcs);
1754 EXPECT_TRUE(SendFrame());
1755 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1756 kTimeout);
1757 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1758 kTimeout);
1759
1760 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1761 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1762 EXPECT_EQ(kVideoWidth, renderer1.width());
1763 EXPECT_EQ(kVideoHeight, renderer1.height());
1764 EXPECT_EQ(kVideoWidth, renderer2.width());
1765 EXPECT_EQ(kVideoHeight, renderer2.height());
1766 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1767 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001768}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001769
Niels Möller6557d0c2018-04-11 15:18:34 +02001770// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001771TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001772 using cricket::VideoCodec;
1773 using cricket::VideoOptions;
1774 using cricket::VideoFormat;
1775 using cricket::FOURCC_I420;
1776
1777 VideoCodec codec = DefaultCodec();
1778 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1779 EXPECT_TRUE(SetOneCodec(codec));
1780 EXPECT_TRUE(SetSend(true));
1781 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1782 EXPECT_EQ(0, renderer_.num_rendered_frames());
1783 EXPECT_TRUE(SendFrame());
1784 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1785 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1786 CreateFakeVideoCapturer());
1787
1788 // TODO(nisse): This testcase fails if we don't configure
1789 // screencast. It's unclear why, I see nothing obvious in this
1790 // test which is related to screencast logic.
1791 VideoOptions video_options;
1792 video_options.is_screencast = true;
1793 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1794
1795 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1796 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1797 // All capturers start generating frames with the same timestamp. ViE does
1798 // not allow the same timestamp to be used. Capture one frame before
1799 // associating the capturer with the channel.
1800 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1801
1802 int captured_frames = 1;
1803 for (int iterations = 0; iterations < 2; ++iterations) {
1804 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1805 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1806 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1807 ++captured_frames;
1808 // Wait until frame of right size is captured.
1809 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
1810 format.width == renderer_.width() &&
1811 format.height == renderer_.height() &&
1812 !renderer_.black_frame(), kTimeout);
1813 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1814 EXPECT_EQ(format.width, renderer_.width());
1815 EXPECT_EQ(format.height, renderer_.height());
1816 captured_frames = renderer_.num_rendered_frames() + 1;
1817 EXPECT_FALSE(renderer_.black_frame());
1818 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1819 // Make sure a black frame is generated within the specified timeout.
1820 // The black frame should be the resolution of the previous frame to
1821 // prevent expensive encoder reconfigurations.
1822 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
1823 format.width == renderer_.width() &&
1824 format.height == renderer_.height() &&
1825 renderer_.black_frame(), kTimeout);
1826 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1827 EXPECT_EQ(format.width, renderer_.width());
1828 EXPECT_EQ(format.height, renderer_.height());
1829 EXPECT_TRUE(renderer_.black_frame());
1830
1831 // The black frame has the same timestamp as the next frame since it's
1832 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1833 // not render a frame with the same timestamp so capture another frame
1834 // with the frame capturer to increment the next frame's timestamp.
1835 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1836 }
srtee0c2eea2017-12-15 17:44:33 +01001837}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001838
Niels Möller6557d0c2018-04-11 15:18:34 +02001839// Tests that if SetVideoSend is called with a NULL capturer after the
1840// capturer was already removed, the application doesn't crash (and no black
1841// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001842TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001843 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1844 EXPECT_TRUE(SetSend(true));
1845 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1846 EXPECT_EQ(0, renderer_.num_rendered_frames());
1847 EXPECT_TRUE(SendFrame());
1848 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1849 // Wait for one frame so they don't get dropped because we send frames too
1850 // tightly.
1851 rtc::Thread::Current()->ProcessMessages(30);
1852 // Remove the capturer.
1853 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1854
1855 // No capturer was added, so this SetVideoSend shouldn't do anything.
1856 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1857 rtc::Thread::Current()->ProcessMessages(300);
1858 // Verify no more frames were sent.
1859 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001860}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001861
Niels Möller6557d0c2018-04-11 15:18:34 +02001862// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001863TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001864 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1865 // interval time to avoid that.
1866 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1867 // interval time to avoid that.
1868 // Set up the stream associated with the engine.
1869 EXPECT_TRUE(channel_->AddRecvStream(
1870 cricket::StreamParams::CreateLegacy(kSsrc)));
1871 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1872 cricket::VideoFormat capture_format(
1873 kVideoWidth, kVideoHeight,
1874 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1875 // Set up additional stream 1.
1876 cricket::FakeVideoRenderer renderer1;
1877 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
1878 EXPECT_TRUE(channel_->AddRecvStream(
1879 cricket::StreamParams::CreateLegacy(1)));
1880 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1881 EXPECT_TRUE(channel_->AddSendStream(
1882 cricket::StreamParams::CreateLegacy(1)));
1883 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1884 CreateFakeVideoCapturer());
1885 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1886 // Set up additional stream 2.
1887 cricket::FakeVideoRenderer renderer2;
1888 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
1889 EXPECT_TRUE(channel_->AddRecvStream(
1890 cricket::StreamParams::CreateLegacy(2)));
1891 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1892 EXPECT_TRUE(channel_->AddSendStream(
1893 cricket::StreamParams::CreateLegacy(2)));
1894 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1895 CreateFakeVideoCapturer());
1896 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1897 // State for all the streams.
1898 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1899 // A limitation in the lmi implementation requires that SetVideoSend() is
1900 // called after SetOneCodec().
1901 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1902 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1903 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1904 EXPECT_TRUE(SetSend(true));
1905 // Test capturer associated with engine.
1906 const int kTestWidth = 160;
1907 const int kTestHeight = 120;
1908 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
1909 EXPECT_FRAME_ON_RENDERER_WAIT(
1910 renderer1, 1, kTestWidth, kTestHeight, kTimeout);
1911 // Capture a frame with additional capturer2, frames should be received
1912 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
1913 EXPECT_FRAME_ON_RENDERER_WAIT(
1914 renderer2, 1, kTestWidth, kTestHeight, kTimeout);
1915 // Successfully remove the capturer.
1916 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1917 // The capturers must be unregistered here as it runs out of it's scope
1918 // next.
1919 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1920 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001921}
Niels Möller6557d0c2018-04-11 15:18:34 +02001922
1923// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001924TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001925 // Remove the send stream that was added during Setup.
1926 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1927
1928 cricket::StreamParams empty;
1929 EXPECT_FALSE(channel_->AddSendStream(empty));
1930 EXPECT_TRUE(channel_->AddSendStream(
1931 cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001932}
Niels Möller6557d0c2018-04-11 15:18:34 +02001933
1934// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001935TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001936 // Remove stream added in Setup. I.e. remove stream corresponding to default
1937 // channel.
1938 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1939 const unsigned int kSsrcsSize = sizeof(kSsrcs4)/sizeof(kSsrcs4[0]);
1940 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1941 EXPECT_TRUE(channel_->AddSendStream(
1942 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1943 }
1944 // Delete one of the non default channel streams, let the destructor delete
1945 // the remaining ones.
1946 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1947 // Stream should already be deleted.
1948 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001949}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001950
eladalonf1841382017-06-12 01:16:46 -07001951TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001952 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001953}
1954
eladalonf1841382017-06-12 01:16:46 -07001955TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001956 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001957}
1958
eladalonf1841382017-06-12 01:16:46 -07001959TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001960 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001961}
1962
eladalonf1841382017-06-12 01:16:46 -07001963TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001964 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1965 // bitrates. This currently happens at <250k, and two streams sharing 300k
1966 // initially will use QVGA instead of VGA.
1967 // TODO(pbos): Set up the quality scaler so that both senders reliably start
1968 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08001969 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02001970 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02001971 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001972}
1973
eladalonf1841382017-06-12 01:16:46 -07001974class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001975 public:
eladalonf1841382017-06-12 01:16:46 -07001976 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
1977 explicit WebRtcVideoChannelTest(const char* field_trials)
1978 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001979 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001980 encoder_factory_->AddSupportedVideoCodecType("VP8");
1981 encoder_factory_->AddSupportedVideoCodecType("VP9");
1982#if defined(WEBRTC_USE_H264)
1983 encoder_factory_->AddSupportedVideoCodecType("H264");
1984#endif
1985
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001986 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08001987 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
1988 VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08001989 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001990 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001991 send_parameters_.codecs = engine_.codecs();
1992 recv_parameters_.codecs = engine_.codecs();
1993 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001994 }
1995
1996 protected:
1997 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001998 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001999 }
2000
2001 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002002 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002003 EXPECT_TRUE(channel_->AddSendStream(sp));
2004 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002005 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002006 EXPECT_EQ(num_streams + 1, streams.size());
2007 return streams[streams.size() - 1];
2008 }
2009
2010 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002011 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002012 }
2013
2014 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002015 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002016 }
2017
2018 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002019 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002020 EXPECT_TRUE(channel_->AddRecvStream(sp));
2021 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002022 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002023 EXPECT_EQ(num_streams + 1, streams.size());
2024 return streams[streams.size() - 1];
2025 }
2026
pbos@webrtc.org00873182014-11-25 14:03:34 +00002027 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2028 int expected_min_bitrate_bps,
2029 const char* start_bitrate_kbps,
2030 int expected_start_bitrate_bps,
2031 const char* max_bitrate_kbps,
2032 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002033 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2034 expected_start_bitrate_bps,
2035 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002036 auto& codecs = send_parameters_.codecs;
2037 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002038 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002039 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2040 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2041 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002042 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002043 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002044
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002045 void ExpectSetBitrateParameters(int min_bitrate_bps,
2046 int start_bitrate_bps,
2047 int max_bitrate_bps) {
2048 EXPECT_CALL(
2049 *fake_call_->GetMockTransportControllerSend(),
2050 SetSdpBitrateParameters(AllOf(
2051 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2052 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2053 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2054 }
2055
2056 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2057 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2058 SetSdpBitrateParameters(Field(
2059 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002060 }
2061
isheriff6f8d6862016-05-26 11:24:55 -07002062 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002063 // Enable extension.
2064 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002065 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002066 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002067 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002068 FakeVideoSendStream* send_stream =
2069 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2070
2071 // Verify the send extension id.
2072 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2073 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002074 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002075 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002076 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002077 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2078 // receivers.
2079 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2080 ->GetConfig()
2081 .rtp.extensions.empty());
2082
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002083 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002084 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002085 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2086 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002087 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2088
2089 // Verify that adding receive RTP header extensions adds them for existing
2090 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002091 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002092 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002093 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2094 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002095 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002096 }
2097
isheriff6f8d6862016-05-26 11:24:55 -07002098 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002099 // Enable extension.
2100 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002101 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002102 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002103 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002104
2105 FakeVideoReceiveStream* recv_stream =
2106 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2107
2108 // Verify the recv extension id.
2109 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2110 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002111 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002112 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002113 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002114
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002115 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2116 // senders.
2117 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2118 ->GetConfig()
2119 .rtp.extensions.empty());
2120
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002121 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002122 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002123 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2124 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002125 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2126
2127 // Verify that adding receive RTP header extensions adds them for existing
2128 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002129 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002130 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002131 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2132 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002133 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002134 }
2135
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002136 void TestExtensionFilter(const std::vector<std::string>& extensions,
2137 const std::string& expected_extension) {
2138 cricket::VideoSendParameters parameters = send_parameters_;
2139 int expected_id = -1;
2140 int id = 1;
2141 for (const std::string& extension : extensions) {
2142 if (extension == expected_extension)
2143 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002144 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002145 }
2146 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2147 FakeVideoSendStream* send_stream =
2148 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2149
2150 // Verify that only one of them has been set, and that it is the one with
2151 // highest priority (transport sequence number).
2152 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2153 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2154 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002155 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002156 }
2157
asapersson3c81a1a2017-06-14 05:52:21 -07002158 void TestDegradationPreference(bool resolution_scaling_enabled,
2159 bool fps_scaling_enabled);
2160
Erik Språngefbde372015-04-29 16:21:28 +02002161 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002162 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002163 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2164 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002165
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002166 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002167 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002168 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002169 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002170 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002171 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002172 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002173 // Options only take effect on the next frame.
2174 EXPECT_TRUE(capturer->CaptureFrame());
2175
Erik Språng143cec12015-04-28 10:01:41 +02002176 return fake_call_->GetVideoSendStreams().back();
2177 }
2178
Peter Boström2feafdb2015-09-09 14:32:14 +02002179 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2180 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002181 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002182 std::vector<uint32_t> ssrcs;
2183 std::vector<uint32_t> rtx_ssrcs;
2184 uint32_t num_streams = enabled ? 3 : 1;
2185 for (uint32_t i = 0; i < num_streams; ++i) {
2186 uint32_t ssrc = last_ssrc_ + i;
2187 ssrcs.push_back(ssrc);
2188 if (with_rtx) {
2189 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2190 }
Erik Språng143cec12015-04-28 10:01:41 +02002191 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002192 if (with_rtx) {
2193 return AddSendStream(
2194 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2195 }
2196 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002197 }
2198
perkjfa10b552016-10-02 23:45:26 -07002199 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002200 std::vector<FakeVideoSendStream*> streams =
2201 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002202 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002203 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002204 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002205 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002206 }
2207
perkjfa10b552016-10-02 23:45:26 -07002208 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002209 int stream_max,
2210 int expected_encoder_bitrate) {
2211 VideoSendParameters limited_send_params = send_parameters_;
2212 limited_send_params.max_bandwidth_bps = global_max;
2213 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002214 webrtc::RtpParameters parameters =
2215 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002216 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002217 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002218 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002219 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002220 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002221 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002222 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002223 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002224 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002225 }
2226
kwiberg686a8ef2016-02-26 03:00:35 -08002227 std::unique_ptr<FakeCall> fake_call_;
2228 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002229 cricket::VideoSendParameters send_parameters_;
2230 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002231 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002232};
2233
eladalonf1841382017-06-12 01:16:46 -07002234TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002235 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002236 const std::string kSyncLabel = "AvSyncLabel";
2237
2238 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002239 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002240 EXPECT_TRUE(channel_->AddRecvStream(sp));
2241
Mirko Bonadeif859e552018-05-30 15:31:29 +02002242 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002243 EXPECT_EQ(kSyncLabel,
2244 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2245 << "SyncGroup should be set based on sync_label";
2246}
2247
eladalonf1841382017-06-12 01:16:46 -07002248TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002249 cricket::VideoSendParameters parameters;
2250 parameters.codecs = engine_.codecs();
2251 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002252 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002253 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002254 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002255
2256 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002257 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2258 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002259 FakeVideoSendStream* send_stream = AddSendStream(
2260 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2261
2262 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2263 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2264 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2265
2266 // Receiver side.
2267 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2268 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002269 EXPECT_FALSE(
2270 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002271 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002272 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002273 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
2274 GetEngineCodec("red").id))
2275 << "RTX should be mapped for the RED payload type";
2276
brandtr14742122017-01-27 04:53:07 -08002277 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002278}
2279
eladalonf1841382017-06-12 01:16:46 -07002280TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002281 // Setup one channel with an associated RTX stream.
2282 cricket::StreamParams params =
2283 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2284 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2285 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002286 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002287
2288 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2289 << "RTX should be mapped for all decoders/payload types.";
2290 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
2291 GetEngineCodec("red").id))
2292 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002293}
2294
eladalonf1841382017-06-12 01:16:46 -07002295TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002296 // Setup one channel without an associated RTX stream.
2297 cricket::StreamParams params =
2298 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2299 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002300 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002301}
2302
eladalonf1841382017-06-12 01:16:46 -07002303TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002304 FakeVideoSendStream* send_stream =
2305 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2306 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2307
2308 FakeVideoReceiveStream* recv_stream =
2309 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2310 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002311}
2312
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002313// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002314TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002315 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002316}
isheriff6f8d6862016-05-26 11:24:55 -07002317
eladalonf1841382017-06-12 01:16:46 -07002318TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002319 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002320}
2321
2322// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002323TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002324 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002325}
isheriff6f8d6862016-05-26 11:24:55 -07002326
eladalonf1841382017-06-12 01:16:46 -07002327TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002328 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002329}
2330
eladalonf1841382017-06-12 01:16:46 -07002331TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002332 // Enable three redundant extensions.
2333 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002334 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2335 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2336 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2337 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002338}
2339
eladalonf1841382017-06-12 01:16:46 -07002340TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002341 // Enable two redundant extensions.
2342 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002343 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2344 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2345 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002346}
2347
stefanc1aeaf02015-10-15 07:26:07 -07002348// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002349TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002350 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002351}
eladalonf1841382017-06-12 01:16:46 -07002352TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002353 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002354}
2355
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002356// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002357TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002358 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002359}
eladalonf1841382017-06-12 01:16:46 -07002360TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002361 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002362}
2363
eladalonf1841382017-06-12 01:16:46 -07002364TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002365 const int kAbsSendTimeId = 1;
2366 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002367 send_parameters_.extensions.push_back(
2368 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2369 send_parameters_.extensions.push_back(
2370 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002371
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002372 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002373 FakeVideoSendStream* send_stream =
2374 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2375
2376 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002377 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002378
2379 // Setting the same extensions (even if in different order) shouldn't
2380 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002381 std::reverse(send_parameters_.extensions.begin(),
2382 send_parameters_.extensions.end());
2383 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002384
2385 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2386
2387 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002388 send_parameters_.extensions.resize(1);
2389 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002390
2391 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2392}
2393
eladalonf1841382017-06-12 01:16:46 -07002394TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002395 const int kTOffsetId = 1;
2396 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002397 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002398 recv_parameters_.extensions.push_back(
2399 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2400 recv_parameters_.extensions.push_back(
2401 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2402 recv_parameters_.extensions.push_back(
2403 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002404
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002405 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002406 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002407 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2408
2409 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002410 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002411
2412 // Setting the same extensions (even if in different order) shouldn't
2413 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002414 std::reverse(recv_parameters_.extensions.begin(),
2415 recv_parameters_.extensions.end());
2416 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002417
2418 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2419
2420 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002421 recv_parameters_.extensions.resize(1);
2422 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002423
2424 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2425}
2426
eladalonf1841382017-06-12 01:16:46 -07002427TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002428 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002429 const int kUnsupportedId = 1;
2430 const int kTOffsetId = 2;
2431
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002432 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002433 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002434 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002435 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002436 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002437 FakeVideoSendStream* send_stream =
2438 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2439
2440 // Only timestamp offset extension is set to send stream,
2441 // unsupported rtp extension is ignored.
2442 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002443 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2444 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002445}
2446
eladalonf1841382017-06-12 01:16:46 -07002447TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002448 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002449 const int kUnsupportedId = 1;
2450 const int kTOffsetId = 2;
2451
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002452 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002453 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002454 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002455 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002456 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002457 FakeVideoReceiveStream* recv_stream =
2458 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2459
2460 // Only timestamp offset extension is set to receive stream,
2461 // unsupported rtp extension is ignored.
2462 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002463 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2464 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002465}
2466
eladalonf1841382017-06-12 01:16:46 -07002467TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002468 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002469 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002470 send_parameters_.extensions.push_back(
2471 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002472 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002473 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2474 }
2475}
2476
eladalonf1841382017-06-12 01:16:46 -07002477TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002478 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002479 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002480 recv_parameters_.extensions.push_back(
2481 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002482 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002483 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2484 }
2485}
2486
eladalonf1841382017-06-12 01:16:46 -07002487TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002488 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002489 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002490 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002491 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002492 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002493 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002494
2495 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002496 send_parameters_.extensions.clear();
2497 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002498 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002499 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2500 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002501}
2502
eladalonf1841382017-06-12 01:16:46 -07002503TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002504 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002505 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002506 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002507 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002508 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002509 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002510
2511 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002512 recv_parameters_.extensions.clear();
2513 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002514 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002515 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2516 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002517}
2518
eladalonf1841382017-06-12 01:16:46 -07002519TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002520 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002521 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002522}
2523
eladalonf1841382017-06-12 01:16:46 -07002524TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002525 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002526 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002527}
2528
eladalonf1841382017-06-12 01:16:46 -07002529TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002530 FakeVideoReceiveStream* stream = AddRecvStream();
2531 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002532}
2533
eladalonf1841382017-06-12 01:16:46 -07002534TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002535 FakeVideoReceiveStream* stream = AddRecvStream();
2536 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2537}
2538
eladalonf1841382017-06-12 01:16:46 -07002539TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002540 FakeVideoReceiveStream* stream = AddRecvStream();
2541 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2542
Peter Boström126c03e2015-05-11 12:48:12 +02002543 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002544 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002545 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002546 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2547 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002548 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002549 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2550
2551 // Verify that REMB is turned on when setting default codecs since the
2552 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002553 parameters.codecs = engine_.codecs();
2554 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002555 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002556 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002557}
2558
eladalonf1841382017-06-12 01:16:46 -07002559TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002560 FakeVideoReceiveStream* stream = AddRecvStream();
2561 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2562
2563 // Verify that transport cc feedback is turned off when send(!) codecs without
2564 // transport cc feedback are set.
2565 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002566 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002567 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2568 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2569 stream = fake_call_->GetVideoReceiveStreams()[0];
2570 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2571
2572 // Verify that transport cc feedback is turned on when setting default codecs
2573 // since the default codecs have transport cc feedback enabled.
2574 parameters.codecs = engine_.codecs();
2575 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2576 stream = fake_call_->GetVideoReceiveStreams()[0];
2577 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2578}
2579
eladalonf1841382017-06-12 01:16:46 -07002580TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002581 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002582 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2583
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002584 cricket::VideoSendParameters parameters;
2585 parameters.codecs = engine_.codecs();
2586 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002587 EXPECT_TRUE(channel_->SetSend(true));
2588
2589 // Send side.
2590 FakeVideoSendStream* send_stream =
2591 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2592 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2593
2594 // Receiver side.
2595 FakeVideoReceiveStream* recv_stream =
2596 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2597 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2598
2599 // Nack history size should match between sender and receiver.
2600 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2601 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002602}
2603
eladalonf1841382017-06-12 01:16:46 -07002604TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002605 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002606 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002607
2608 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2609 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2610
2611 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002612 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002613 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002614 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2615 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002616 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2617 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2618 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002619 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2620
Peter Boström67c9df72015-05-11 14:34:58 +02002621 // Verify that NACK is turned on when setting default codecs since the
2622 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002623 parameters.codecs = engine_.codecs();
2624 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002625 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2626 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2627 send_stream = fake_call_->GetVideoSendStreams()[0];
2628 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002629}
2630
Peter Boströme7ba0862016-03-12 00:02:28 +01002631// This test verifies that new frame sizes reconfigures encoders even though not
2632// (yet) sending. The purpose of this is to permit encoding as quickly as
2633// possible once we start sending. Likely the frames being input are from the
2634// same source that will be sent later, which just means that we're ready
2635// earlier.
eladalonf1841382017-06-12 01:16:46 -07002636TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002637 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002638 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002639 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2640 channel_->SetSend(false);
2641
2642 FakeVideoSendStream* stream = AddSendStream();
2643
perkjfa10b552016-10-02 23:45:26 -07002644 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002645 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Niels Möllerefc71e52018-06-08 08:46:04 +02002646 EXPECT_EQ(0, streams[0].width);
2647 EXPECT_EQ(0, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002648
Tommi85959932018-02-07 19:26:06 +01002649 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002650 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002651 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2652 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002653 EXPECT_TRUE(capturer.CaptureFrame());
2654
2655 // Frame entered, should be reconfigured to new dimensions.
2656 streams = stream->GetVideoStreams();
Niels Möllerefc71e52018-06-08 08:46:04 +02002657 EXPECT_EQ(capture_format.width, streams[0].width);
2658 EXPECT_EQ(capture_format.height, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002659
Niels Möllerff40b142018-04-09 08:49:14 +02002660 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002661}
2662
eladalonf1841382017-06-12 01:16:46 -07002663TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002664 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002665 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002666 cricket::VideoSendParameters parameters;
2667 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002668 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002669 AddSendStream();
2670
Tommi85959932018-02-07 19:26:06 +01002671 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002672 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002673 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möllerff40b142018-04-09 08:49:14 +02002674 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
deadbeef5a4a75a2016-06-02 16:23:38 -07002675 &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002676 cricket::VideoFormat capture_format_hd =
2677 capturer.GetSupportedFormats()->front();
2678 EXPECT_EQ(1280, capture_format_hd.width);
2679 EXPECT_EQ(720, capture_format_hd.height);
2680 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2681
2682 EXPECT_TRUE(channel_->SetSend(true));
2683
2684 EXPECT_TRUE(capturer.CaptureFrame());
2685 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2686 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2687
2688 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2689
2690 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002691 webrtc::VideoEncoderConfig encoder_config =
2692 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002693 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002694 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002695 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möllerefc71e52018-06-08 08:46:04 +02002696 EXPECT_EQ(capture_format_hd.width, streams.front().width);
2697 EXPECT_EQ(capture_format_hd.height, streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002698 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2699 << "Non-screenshare shouldn't use min-transmit bitrate.";
2700
Niels Möllerff40b142018-04-09 08:49:14 +02002701 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002702 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002703 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002704 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002705 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002706 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002707 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002708 // Send stream recreated after option change.
2709 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2710 send_stream = fake_call_->GetVideoSendStreams().front();
2711 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002712
2713 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002714 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002715 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002716 encoder_config.content_type);
2717 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2718 encoder_config.min_transmit_bitrate_bps);
2719
perkjfa10b552016-10-02 23:45:26 -07002720 streams = send_stream->GetVideoStreams();
Niels Möllerefc71e52018-06-08 08:46:04 +02002721 EXPECT_EQ(capture_format_hd.width, streams.front().width);
2722 EXPECT_EQ(capture_format_hd.height, streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002723 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002724 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002725}
2726
eladalonf1841382017-06-12 01:16:46 -07002727TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002728 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002729 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002730 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002731 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002732
2733 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002734 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002735 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002736 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002737 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002738 cricket::VideoFormat capture_format_hd =
2739 capturer.GetSupportedFormats()->front();
2740 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2741
2742 EXPECT_TRUE(channel_->SetSend(true));
2743
2744 EXPECT_TRUE(capturer.CaptureFrame());
2745 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2746 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2747
perkj26091b12016-09-01 01:17:40 -07002748 webrtc::VideoEncoderConfig encoder_config =
2749 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002750
2751 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002752 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002753 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002754 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002755
2756 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2757 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002758 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002759 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002760 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002761
Niels Möllerff40b142018-04-09 08:49:14 +02002762 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002763}
2764
eladalonf1841382017-06-12 01:16:46 -07002765TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002766 FakeVideoSendStream* stream = AddSendStream();
2767 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2768}
2769
eladalonf1841382017-06-12 01:16:46 -07002770TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002771 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002772 media_config.video.suspend_below_min_bitrate = true;
2773
2774 channel_.reset(
2775 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002776 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002777
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002778 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002779
2780 FakeVideoSendStream* stream = AddSendStream();
2781 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2782
nisse0db023a2016-03-01 04:29:59 -08002783 media_config.video.suspend_below_min_bitrate = false;
2784 channel_.reset(
2785 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002786 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002787
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002788 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002789
nisse0db023a2016-03-01 04:29:59 -08002790 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002791 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2792}
2793
eladalonf1841382017-06-12 01:16:46 -07002794TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002795 FakeVideoSendStream* stream = AddSendStream();
2796 webrtc::VideoCodecVP8 vp8_settings;
2797 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2798 EXPECT_TRUE(vp8_settings.denoisingOn);
2799}
2800
eladalonf1841382017-06-12 01:16:46 -07002801TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002802 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002803 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002804 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002805
Peter Boström2feafdb2015-09-09 14:32:14 +02002806 // Single-stream settings should apply with RTX as well (verifies that we
2807 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2808 // both RTX and regular SSRCs).
2809 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002810
Tommi85959932018-02-07 19:26:06 +01002811 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002812 EXPECT_EQ(cricket::CS_RUNNING,
2813 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002814 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002815 channel_->SetSend(true);
2816
2817 EXPECT_TRUE(capturer.CaptureFrame());
2818
pbos4cba4eb2015-10-26 11:18:18 -07002819 webrtc::VideoCodecVP8 vp8_settings;
2820 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2821 EXPECT_TRUE(vp8_settings.denoisingOn)
2822 << "VP8 denoising should be on by default.";
2823
nisse05103312016-03-16 02:22:50 -07002824 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002825
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002826 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2827 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002828 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2829 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002830
nisse05103312016-03-16 02:22:50 -07002831 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002832
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002833 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2834 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002835 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2836 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2837
Niels Möllerff40b142018-04-09 08:49:14 +02002838 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002839 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002840 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002841 channel_->SetSend(true);
2842 EXPECT_TRUE(capturer.CaptureFrame());
2843
Mirko Bonadeif859e552018-05-30 15:31:29 +02002844 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002845 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2846 // Autmatic resize off when using simulcast.
2847 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2848 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2849
2850 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002851 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002852 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002853 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002854
nisse05103312016-03-16 02:22:50 -07002855 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002856
Mirko Bonadeif859e552018-05-30 15:31:29 +02002857 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002858 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2859 EXPECT_FALSE(vp8_settings.denoisingOn);
2860 // Resizing and frame dropping always off for screen sharing.
2861 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2862 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2863
nisse05103312016-03-16 02:22:50 -07002864 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002865
2866 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2867 EXPECT_FALSE(vp8_settings.denoisingOn);
2868 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2869 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2870
Niels Möllerff40b142018-04-09 08:49:14 +02002871 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002872}
2873
deadbeef119760a2016-04-04 11:43:27 -07002874// Test that setting the same options doesn't result in the encoder being
2875// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002876TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002877 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002878 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002879
perkjfa10b552016-10-02 23:45:26 -07002880 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002881 EXPECT_EQ(cricket::CS_RUNNING,
2882 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002883 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002884 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002885 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2886 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2887
Niels Möllerff40b142018-04-09 08:49:14 +02002888 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2889 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002890 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002891 // Expect 1 reconfigurations at this point from the initial configuration.
2892 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002893
2894 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002895 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002896 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2897
2898 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002899 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002900 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002901 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2902
Niels Möllerff40b142018-04-09 08:49:14 +02002903 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002904}
2905
eladalonf1841382017-06-12 01:16:46 -07002906class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002907 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002908 Vp9SettingsTest() : Vp9SettingsTest("") {}
2909 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002910 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002911 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002912 }
2913 virtual ~Vp9SettingsTest() {}
2914
2915 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002916 void TearDown() override {
2917 // Remove references to encoder_factory_ since this will be destroyed
2918 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002919 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002920 }
Erik Språng143cec12015-04-28 10:01:41 +02002921};
2922
2923TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002924 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002925 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002926 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02002927
Peter Boström2feafdb2015-09-09 14:32:14 +02002928 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02002929
Tommi85959932018-02-07 19:26:06 +01002930 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002931 EXPECT_EQ(cricket::CS_RUNNING,
2932 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002933 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002934 channel_->SetSend(true);
2935
2936 EXPECT_TRUE(capturer.CaptureFrame());
2937
pbos4cba4eb2015-10-26 11:18:18 -07002938 webrtc::VideoCodecVP9 vp9_settings;
2939 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07002940 EXPECT_TRUE(vp9_settings.denoisingOn)
2941 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07002942
nisse05103312016-03-16 02:22:50 -07002943 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002944
Erik Språng143cec12015-04-28 10:01:41 +02002945 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2946 EXPECT_FALSE(vp9_settings.denoisingOn);
2947 // Frame dropping always on for real time video.
2948 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2949
nisse05103312016-03-16 02:22:50 -07002950 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002951
2952 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2953 EXPECT_TRUE(vp9_settings.denoisingOn);
2954 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2955
2956 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07002957 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002958 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002959 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002960
nisse05103312016-03-16 02:22:50 -07002961 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002962
2963 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2964 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02002965 // Frame dropping always on for screen sharing.
2966 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002967
nisse05103312016-03-16 02:22:50 -07002968 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002969
2970 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2971 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02002972 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002973
Niels Möllerff40b142018-04-09 08:49:14 +02002974 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002975}
2976
Sergey Silkinf18072e2018-03-14 10:35:35 +01002977TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
2978 cricket::VideoSendParameters parameters;
2979 parameters.codecs.push_back(GetEngineCodec("VP9"));
2980 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2981
2982 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
2983
2984 FakeVideoSendStream* stream =
2985 AddSendStream(CreateSimStreamParams("cname", ssrcs));
2986
2987 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
2988 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
2989
2990 FakeVideoCapturerWithTaskQueue capturer;
2991 EXPECT_EQ(cricket::CS_RUNNING,
2992 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002993 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01002994 channel_->SetSend(true);
2995
2996 EXPECT_TRUE(capturer.CaptureFrame());
2997
2998 webrtc::VideoCodecVP9 vp9_settings;
2999 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3000
3001 const size_t kNumSpatialLayers = ssrcs.size();
3002 const size_t kNumTemporalLayers = 3;
3003 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3004 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3005
Niels Möllerff40b142018-04-09 08:49:14 +02003006 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003007}
3008
asaperssonc5dabdd2016-03-21 04:15:50 -07003009class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3010 public:
brandtr468da7c2016-11-22 02:16:47 -08003011 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003012 : Vp9SettingsTest(field_trials) {}
3013
3014 protected:
3015 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3016 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003017 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003018 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3019
3020 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3021
Tommi85959932018-02-07 19:26:06 +01003022 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003023 EXPECT_EQ(cricket::CS_RUNNING,
3024 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003025 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003026 channel_->SetSend(true);
3027
3028 EXPECT_TRUE(capturer.CaptureFrame());
3029
3030 webrtc::VideoCodecVP9 vp9_settings;
3031 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3032 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3033 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3034
Niels Möllerff40b142018-04-09 08:49:14 +02003035 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003036 }
3037};
3038
3039class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3040 public:
3041 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3042};
3043
3044TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3045 const int kNumSpatialLayers = 1;
3046 const int kNumTemporalLayers = 1;
3047 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3048}
3049
3050class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3051 public:
3052 Vp9SettingsTestWithInvalidFlag()
3053 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3054};
3055
3056TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3057 const int kNumSpatialLayers = 1;
3058 const int kNumTemporalLayers = 1;
3059 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3060}
3061
3062class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3063 public:
3064 Vp9SettingsTestWith2SL3TLFlag()
3065 : Vp9SettingsTestWithFieldTrial(
3066 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3067};
3068
3069TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3070 const int kNumSpatialLayers = 2;
3071 const int kNumTemporalLayers = 3;
3072 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3073}
3074
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003075TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3076 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3077 ASSERT_EQ(1u, streams.size());
3078 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3079}
3080
3081TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3082 webrtc::test::ScopedFieldTrials override_field_trials_(
3083 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3084 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3085 ASSERT_EQ(1u, streams.size());
3086 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3087}
3088
asapersson3c81a1a2017-06-14 05:52:21 -07003089TEST_F(WebRtcVideoChannelTest,
3090 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3091 webrtc::test::ScopedFieldTrials override_field_trials_(
3092 "WebRTC-Video-BalancedDegradation/Disabled/");
3093 const bool kResolutionScalingEnabled = true;
3094 const bool kFpsScalingEnabled = false;
3095 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3096}
3097
3098TEST_F(WebRtcVideoChannelTest,
3099 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3100 webrtc::test::ScopedFieldTrials override_field_trials_(
3101 "WebRTC-Video-BalancedDegradation/Enabled/");
3102 const bool kResolutionScalingEnabled = true;
3103 const bool kFpsScalingEnabled = true;
3104 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3105}
3106
eladalonf1841382017-06-12 01:16:46 -07003107TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003108 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003109}
3110
eladalonf1841382017-06-12 01:16:46 -07003111TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003112 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003113}
3114
eladalonf1841382017-06-12 01:16:46 -07003115TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003116 TestCpuAdaptation(true, true);
3117}
3118
eladalonf1841382017-06-12 01:16:46 -07003119TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003120 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003121 cricket::VideoSendParameters parameters;
3122 parameters.codecs.push_back(codec);
3123
kthelgason2bc68642017-02-07 07:02:22 -08003124 MediaConfig media_config = GetMediaConfig();
perkj2d5f0912016-02-29 00:04:41 -08003125 channel_.reset(
3126 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003127 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003128 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3129
3130 AddSendStream();
3131
Tommi85959932018-02-07 19:26:06 +01003132 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003133 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003134 ASSERT_EQ(cricket::CS_RUNNING,
3135 capturer.Start(capturer.GetSupportedFormats()->front()));
3136 ASSERT_TRUE(channel_->SetSend(true));
3137
3138 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3139 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003140
Niels Möllera6cc0f92018-02-12 17:14:55 +01003141 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003142 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3143 EXPECT_EQ(1280, send_stream->GetLastWidth());
3144 EXPECT_EQ(720, send_stream->GetLastHeight());
3145
3146 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003147 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003148 wants.max_pixel_count =
3149 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003150 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003151 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003152 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3153 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3154 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3155
3156 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003157 wants.max_pixel_count =
3158 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003159 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003160 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003161 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3162 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3163 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3164
3165 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003166 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003167 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003168 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3169 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3170
3171 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003172 int current_pixel_count =
3173 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3174 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3175 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003176 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003177 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003178 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003179 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003180 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003181 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003182 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3183 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3184
sprang84a37592017-02-10 07:04:27 -08003185 // Trigger underuse again, should go back up to full resolution.
3186 current_pixel_count =
3187 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003188 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003189 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003190 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003191 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003192 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003193 EXPECT_EQ(1284, send_stream->GetLastWidth());
3194 EXPECT_EQ(724, send_stream->GetLastHeight());
3195
Niels Möllerff40b142018-04-09 08:49:14 +02003196 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003197}
3198
eladalonf1841382017-06-12 01:16:46 -07003199TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003200 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003201 cricket::VideoSendParameters parameters;
3202 parameters.codecs.push_back(codec);
3203
kthelgason2bc68642017-02-07 07:02:22 -08003204 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003205 media_config.video.enable_cpu_adaptation = true;
Per766ad3b2016-04-05 15:23:49 +02003206 channel_.reset(
3207 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003208 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003209 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3210
3211 AddSendStream();
3212
Tommi85959932018-02-07 19:26:06 +01003213 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003214 ASSERT_EQ(cricket::CS_RUNNING,
3215 capturer.Start(capturer.GetSupportedFormats()->front()));
3216 ASSERT_TRUE(channel_->SetSend(true));
3217 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003218 camera_options.is_screencast = false;
Niels Möllerff40b142018-04-09 08:49:14 +02003219 channel_->SetVideoSend(last_ssrc_, &camera_options,
deadbeef5a4a75a2016-06-02 16:23:38 -07003220 &capturer);
Per766ad3b2016-04-05 15:23:49 +02003221
3222 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3223 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003224
Niels Möllera6cc0f92018-02-12 17:14:55 +01003225 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003226 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3227 EXPECT_EQ(1280, send_stream->GetLastWidth());
3228 EXPECT_EQ(720, send_stream->GetLastHeight());
3229
3230 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003231 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003232 wants.max_pixel_count =
3233 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003234 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003235 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003236 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3237 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3238 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3239
3240 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003241 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003242 ASSERT_EQ(cricket::CS_RUNNING,
3243 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003244 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003245 screenshare_options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003246 channel_->SetVideoSend(last_ssrc_, &screenshare_options,
deadbeef5a4a75a2016-06-02 16:23:38 -07003247 &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003248 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003249 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3250 send_stream = fake_call_->GetVideoSendStreams().front();
3251 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003252 EXPECT_EQ(1284, send_stream->GetLastWidth());
3253 EXPECT_EQ(724, send_stream->GetLastHeight());
3254
3255 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Niels Möllerff40b142018-04-09 08:49:14 +02003256 channel_->SetVideoSend(last_ssrc_, &camera_options,
deadbeef5a4a75a2016-06-02 16:23:38 -07003257 &capturer);
sprangf24a0642017-02-28 13:23:26 -08003258 send_stream = fake_call_->GetVideoSendStreams().front();
3259 // We have a new fake send stream, so it doesn't remember the old sink wants.
3260 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003261 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003262 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003263 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003264 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3265 send_stream = fake_call_->GetVideoSendStreams().front();
3266 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003267 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3268 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3269
Niels Möllerff40b142018-04-09 08:49:14 +02003270 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003271}
3272
asapersson3c81a1a2017-06-14 05:52:21 -07003273// TODO(asapersson): Remove this test when the balanced field trial is removed.
3274void WebRtcVideoChannelTest::TestDegradationPreference(
3275 bool resolution_scaling_enabled,
3276 bool fps_scaling_enabled) {
3277 cricket::VideoCodec codec = GetEngineCodec("VP8");
3278 cricket::VideoSendParameters parameters;
3279 parameters.codecs.push_back(codec);
3280
3281 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003282 media_config.video.enable_cpu_adaptation = true;
asapersson3c81a1a2017-06-14 05:52:21 -07003283 channel_.reset(
3284 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
3285 channel_->OnReadyToSend(true);
3286
3287 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3288
3289 AddSendStream();
3290
Tommi85959932018-02-07 19:26:06 +01003291 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003292 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003293 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003294 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3295 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3296
3297 EXPECT_TRUE(channel_->SetSend(true));
3298
3299 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3300 EXPECT_EQ(resolution_scaling_enabled,
3301 send_stream->resolution_scaling_enabled());
3302 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3303
Niels Möllerff40b142018-04-09 08:49:14 +02003304 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003305}
3306
eladalonf1841382017-06-12 01:16:46 -07003307void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3308 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003309 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003310 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003311 cricket::VideoSendParameters parameters;
3312 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003313
kthelgason2bc68642017-02-07 07:02:22 -08003314 MediaConfig media_config = GetMediaConfig();
3315 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003316 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003317 }
nisse51542be2016-02-12 02:27:06 -08003318 channel_.reset(
3319 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003320 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003321
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003322 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003323
3324 AddSendStream();
3325
Tommi85959932018-02-07 19:26:06 +01003326 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003327 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003328 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003329 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003330 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003331 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003332 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003333
3334 EXPECT_TRUE(channel_->SetSend(true));
3335
solenberge5269742015-09-08 05:13:22 -07003336 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003337
sprangc5d62e22017-04-02 23:53:04 -07003338 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003339 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003340 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3341 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003342
3343 EXPECT_TRUE(capturer.CaptureFrame());
3344 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3345
perkj26752742016-10-24 01:21:16 -07003346 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3347 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003348
Niels Möllerff40b142018-04-09 08:49:14 +02003349 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003350 return;
3351 }
3352
sprangc5d62e22017-04-02 23:53:04 -07003353 if (is_screenshare) {
3354 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3355 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3356 } else {
3357 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3358 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3359 }
3360
perkj803d97f2016-11-01 11:45:46 -07003361 // Trigger overuse.
3362 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3363
3364 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003365 if (is_screenshare) {
3366 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3367 } else {
3368 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3369 }
perkj803d97f2016-11-01 11:45:46 -07003370 send_stream->InjectVideoSinkWants(wants);
3371
sprangc5d62e22017-04-02 23:53:04 -07003372 for (int i = 0; i < kDefaultFps; ++i)
3373 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003374
sprangc5d62e22017-04-02 23:53:04 -07003375 if (is_screenshare) {
3376 // Drops every third frame.
3377 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3378 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3379 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3380 } else {
3381 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3382 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3383 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3384 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003385
3386 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003387 int last_pixel_count =
3388 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003389 if (is_screenshare) {
3390 wants.max_framerate_fps = kDefaultFps;
3391 } else {
3392 wants.max_pixel_count = last_pixel_count * 4;
3393 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3394 }
perkj803d97f2016-11-01 11:45:46 -07003395 send_stream->InjectVideoSinkWants(wants);
3396
sprangc5d62e22017-04-02 23:53:04 -07003397 for (int i = 0; i < kDefaultFps; ++i)
3398 EXPECT_TRUE(capturer.CaptureFrame());
3399
3400 if (is_screenshare) {
3401 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3402 send_stream->GetNumberOfSwappedFrames());
3403 } else {
3404 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3405 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003406
perkj26752742016-10-24 01:21:16 -07003407 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3408 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003409
Niels Möllerff40b142018-04-09 08:49:14 +02003410 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003411}
3412
eladalonf1841382017-06-12 01:16:46 -07003413TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003414 // Start at last timestamp to verify that wraparounds are estimated correctly.
3415 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3416 static const int64_t kInitialNtpTimeMs = 1247891230;
3417 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003418 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003419
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003420 FakeVideoReceiveStream* stream = AddRecvStream();
3421 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003422 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003423
nisse64ec8f82016-09-27 00:17:25 -07003424 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3425 kInitialTimestamp, 0,
3426 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003427 // Initial NTP time is not available on the first frame, but should still be
3428 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003429 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003430
3431 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003432
3433 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3434 // triggers a constant-overflow warning, hence we're calculating it explicitly
3435 // here.
3436 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3437 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003438 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003439
3440 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003441
3442 // Verify that NTP time has been correctly deduced.
3443 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003444 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003445 ASSERT_EQ(1u, info.receivers.size());
3446 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003447}
3448
eladalonf1841382017-06-12 01:16:46 -07003449TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003450 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003451 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003452
3453 VideoCodec codec;
3454 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003455 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003456
3457 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003458 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3459 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003460 FakeVideoSendStream* stream = AddSendStream(
3461 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003462 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003463
3464 // Make sure NACK and FEC are enabled on the correct payload types.
3465 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003466 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3467 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003468
3469 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3470 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003471 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003472 // TODO(juberti): Check RTCP, PLI, TMMBR.
3473}
3474
brandtr31bd2242017-05-19 05:47:46 -07003475// The following four tests ensures that FlexFEC is not activated by default
3476// when the field trials are not enabled.
3477// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3478// default.
eladalonf1841382017-06-12 01:16:46 -07003479TEST_F(WebRtcVideoChannelTest,
brandtr31bd2242017-05-19 05:47:46 -07003480 FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003481 FakeVideoSendStream* stream = AddSendStream();
3482 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3483
brandtr3d200bd2017-01-16 06:59:19 -08003484 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003485 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3486 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003487}
3488
eladalonf1841382017-06-12 01:16:46 -07003489TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003490 FakeVideoSendStream* stream = AddSendStream(
3491 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3492 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3493
brandtr3d200bd2017-01-16 06:59:19 -08003494 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003495 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3496 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3497}
3498
eladalonf1841382017-06-12 01:16:46 -07003499TEST_F(WebRtcVideoChannelTest,
brandtr31bd2242017-05-19 05:47:46 -07003500 FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
3501 AddRecvStream();
3502
3503 const std::vector<FakeFlexfecReceiveStream*>& streams =
3504 fake_call_->GetFlexfecReceiveStreams();
3505 EXPECT_TRUE(streams.empty());
3506}
3507
eladalonf1841382017-06-12 01:16:46 -07003508TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003509 AddRecvStream(
3510 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3511
3512 const std::vector<FakeFlexfecReceiveStream*>& streams =
3513 fake_call_->GetFlexfecReceiveStreams();
3514 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003515}
3516
3517// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3518// tests that use this test fixture into the corresponding "non-field trial"
3519// tests.
eladalonf1841382017-06-12 01:16:46 -07003520class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003521 public:
eladalonf1841382017-06-12 01:16:46 -07003522 WebRtcVideoChannelFlexfecRecvTest()
3523 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003524};
3525
eladalonf1841382017-06-12 01:16:46 -07003526TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003527 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3528 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3529 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3530}
3531
eladalonf1841382017-06-12 01:16:46 -07003532TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003533 AddRecvStream();
3534
3535 const std::vector<FakeFlexfecReceiveStream*>& streams =
3536 fake_call_->GetFlexfecReceiveStreams();
3537 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003538
3539 const std::vector<FakeVideoReceiveStream*>& video_streams =
3540 fake_call_->GetVideoReceiveStreams();
3541 ASSERT_EQ(1U, video_streams.size());
3542 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3543 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3544 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003545}
3546
eladalonf1841382017-06-12 01:16:46 -07003547TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003548 AddRecvStream(
3549 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3550
3551 const std::vector<FakeFlexfecReceiveStream*>& streams =
3552 fake_call_->GetFlexfecReceiveStreams();
3553 ASSERT_EQ(1U, streams.size());
3554 const FakeFlexfecReceiveStream* stream = streams.front();
3555 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3556 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3557 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3558 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3559 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003560
3561 const std::vector<FakeVideoReceiveStream*>& video_streams =
3562 fake_call_->GetVideoReceiveStreams();
3563 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003564 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3565 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003566 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003567 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003568 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003569}
3570
eladalonf1841382017-06-12 01:16:46 -07003571TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003572 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3573 cricket::VideoRecvParameters recv_parameters;
3574 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3575 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3576
3577 AddRecvStream(
3578 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3579 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003580 const std::vector<FakeVideoReceiveStream*>& video_streams =
3581 fake_call_->GetVideoReceiveStreams();
3582 ASSERT_EQ(1U, video_streams.size());
3583 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3584 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3585 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003586
3587 // Enable FlexFEC.
3588 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3589 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3590 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3591 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3592 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3593 << "Enabling FlexFEC should not create VideoReceiveStream.";
3594 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3595 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003596 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3597 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003598}
3599
eladalonf1841382017-06-12 01:16:46 -07003600TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003601 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3602 cricket::VideoRecvParameters recv_parameters;
3603 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3604 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3605 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3606
3607 AddRecvStream(
3608 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3609 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003610 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003611 const std::vector<FakeVideoReceiveStream*>& video_streams =
3612 fake_call_->GetVideoReceiveStreams();
3613 ASSERT_EQ(1U, video_streams.size());
3614 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3615 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3616 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003617
3618 // Disable FlexFEC.
3619 recv_parameters.codecs.clear();
3620 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3621 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3622 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3623 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3624 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3625 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3626 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3627 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003628 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3629 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003630}
3631
brandtr31bd2242017-05-19 05:47:46 -07003632// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3633// tests that use this test fixture into the corresponding "non-field trial"
3634// tests.
eladalonf1841382017-06-12 01:16:46 -07003635class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003636 public:
eladalonf1841382017-06-12 01:16:46 -07003637 WebRtcVideoChannelFlexfecSendRecvTest()
3638 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003639 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3640 }
3641};
3642
eladalonf1841382017-06-12 01:16:46 -07003643TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003644 SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003645 FakeVideoSendStream* stream = AddSendStream();
3646 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3647
brandtr3d200bd2017-01-16 06:59:19 -08003648 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3649 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3650 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003651}
3652
eladalonf1841382017-06-12 01:16:46 -07003653TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003654 FakeVideoSendStream* stream = AddSendStream(
3655 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3656 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3657
brandtr3d200bd2017-01-16 06:59:19 -08003658 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3659 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3660 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3661 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003662}
3663
eladalonf1841382017-06-12 01:16:46 -07003664TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003665 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003666 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003667 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003668
3669 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003670 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003671
brandtrb5f2c3f2016-10-04 23:28:39 -07003672 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3673 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003674}
3675
eladalonf1841382017-06-12 01:16:46 -07003676TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003677 cricket::VideoSendParameters parameters;
3678 parameters.codecs.push_back(GetEngineCodec("VP8"));
3679 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3680
3681 FakeVideoSendStream* stream = AddSendStream();
3682 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3683
brandtr3d200bd2017-01-16 06:59:19 -08003684 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003685}
3686
eladalonf1841382017-06-12 01:16:46 -07003687TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003688 AddRecvStream(
3689 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003690
3691 cricket::VideoRecvParameters recv_parameters;
3692 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3693 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3694 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003695
3696 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3697 fake_call_->GetFlexfecReceiveStreams();
3698 ASSERT_EQ(1U, flexfec_streams.size());
3699 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3700 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3701 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003702 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003703 flexfec_stream_config.payload_type);
3704 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3705 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3706 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3707 const std::vector<FakeVideoReceiveStream*>& video_streams =
3708 fake_call_->GetVideoReceiveStreams();
3709 const FakeVideoReceiveStream* video_stream = video_streams.front();
3710 const webrtc::VideoReceiveStream::Config& video_stream_config =
3711 video_stream->GetConfig();
3712 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3713 flexfec_stream_config.local_ssrc);
3714 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3715 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3716 flexfec_stream_config.rtcp_send_transport);
3717 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3718 // spec-compliant way.
3719 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3720 flexfec_stream_config.transport_cc);
3721 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3722 EXPECT_EQ(video_stream_config.rtp.extensions,
3723 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003724}
3725
brandtr31bd2242017-05-19 05:47:46 -07003726// We should not send FlexFEC, even if we advertise it, unless the right
3727// field trial is set.
3728// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003729TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003730 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3731 cricket::VideoSendParameters parameters;
3732 parameters.codecs.push_back(GetEngineCodec("VP8"));
3733 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3734 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3735
3736 FakeVideoSendStream* stream = AddSendStream();
3737 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3738
3739 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003740 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003741 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3742}
3743
eladalonf1841382017-06-12 01:16:46 -07003744TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003745 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3746 cricket::VideoSendParameters parameters;
3747 parameters.codecs.push_back(GetEngineCodec("VP8"));
3748 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3749 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3750
3751 FakeVideoSendStream* stream = AddSendStream(
3752 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3753 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3754
3755 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003756 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003757 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3758}
3759
eladalonf1841382017-06-12 01:16:46 -07003760TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003761 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003762 const int kUnusedPayloadType = 127;
3763 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3764
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003765 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003766 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003767 parameters.codecs.push_back(rtx_codec);
3768 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003769 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003770}
3771
eladalonf1841382017-06-12 01:16:46 -07003772TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003773 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003774 const int kUnusedPayloadType1 = 126;
3775 const int kUnusedPayloadType2 = 127;
3776 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3777 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3778 {
3779 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3780 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3781 cricket::VideoSendParameters parameters;
3782 parameters.codecs.push_back(GetEngineCodec("VP8"));
3783 parameters.codecs.push_back(rtx_codec);
3784 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3785 }
3786 {
3787 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3788 kUnusedPayloadType1, kUnusedPayloadType2);
3789 cricket::VideoSendParameters parameters;
3790 parameters.codecs.push_back(GetEngineCodec("VP8"));
3791 parameters.codecs.push_back(rtx_codec);
3792 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3793 << "RTX without matching video codec should be rejected.";
3794 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003795}
3796
eladalonf1841382017-06-12 01:16:46 -07003797TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003798 const int kUnusedPayloadType1 = 126;
3799 const int kUnusedPayloadType2 = 127;
3800 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3801 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3802
3803 // SSRCs for RTX.
3804 cricket::StreamParams params =
3805 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3806 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3807 AddSendStream(params);
3808
3809 // Original payload type for RTX.
3810 cricket::VideoSendParameters parameters;
3811 parameters.codecs.push_back(GetEngineCodec("VP8"));
3812 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3813 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3814 parameters.codecs.push_back(rtx_codec);
3815 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3816 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3817 const webrtc::VideoSendStream::Config& config_before =
3818 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3819 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3820 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3821 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3822
3823 // Change payload type for RTX.
3824 parameters.codecs[1].id = kUnusedPayloadType2;
3825 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3826 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3827 const webrtc::VideoSendStream::Config& config_after =
3828 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3829 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3830 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3831 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3832}
3833
eladalonf1841382017-06-12 01:16:46 -07003834TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003835 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003836 parameters.codecs.push_back(GetEngineCodec("VP8"));
3837 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003838 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003839
3840 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003841 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003842
magjed509e4fe2016-11-18 01:34:11 -08003843 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003844
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003845 parameters.codecs.pop_back();
3846 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003847 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003848 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003849 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003850 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003851 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3852}
3853
eladalonf1841382017-06-12 01:16:46 -07003854TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003855 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003856 cricket::VideoSendParameters parameters;
3857 parameters.codecs.push_back(GetEngineCodec("VP8"));
3858 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3859 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3860
3861 FakeVideoSendStream* stream = AddSendStream(
3862 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3863 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3864
brandtr3d200bd2017-01-16 06:59:19 -08003865 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3866 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003867 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3868 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3869
3870 parameters.codecs.pop_back();
3871 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3872 stream = fake_call_->GetVideoSendStreams()[0];
3873 ASSERT_TRUE(stream != nullptr);
3874 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003875 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003876 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003877}
3878
eladalonf1841382017-06-12 01:16:46 -07003879TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003880 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003881 cricket::VideoCodec codec(100, "VP8");
3882 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3883 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003884
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003885 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003886 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003887
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003888 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003889 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003890 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003891
3892 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003893 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003894
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003895 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003896 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3897 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003898 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003899 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003900 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003901 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003902}
3903
eladalonf1841382017-06-12 01:16:46 -07003904TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003905 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3906 200000);
3907}
3908
eladalonf1841382017-06-12 01:16:46 -07003909TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003910 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3911 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3912 ASSERT_EQ(1u, streams.size());
3913 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3914}
3915
eladalonf1841382017-06-12 01:16:46 -07003916TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003917 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003918 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003919}
3920
eladalonf1841382017-06-12 01:16:46 -07003921TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003922 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003923}
3924
eladalonf1841382017-06-12 01:16:46 -07003925TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003926 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3927 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3928 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003929}
3930
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003931// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3932// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003933TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003934 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3935 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3936 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3937 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003938 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003939 ExpectSetBitrateParameters(100000, 200000, 400000);
3940 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3941 // Since the codec isn't changing, start_bitrate_bps should be -1.
3942 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003943
3944 // Decrease max_bandwidth_bps.
3945 send_parameters_.max_bandwidth_bps = 350000;
3946 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003947
3948 // Now try again with the values flipped around.
3949 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3950 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003951 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003952 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003953
3954 // If we change the codec max, max_bandwidth_bps should still apply.
3955 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003956 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003957 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003958}
3959
eladalonf1841382017-06-12 01:16:46 -07003960TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003961 SetMaxSendBandwidthShouldPreserveOtherBitrates) {
3962 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3963 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003964 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003965 // Setting max bitrate should keep previous min bitrate.
3966 // Setting max bitrate should not reset start bitrate.
3967 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003968 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00003969}
3970
eladalonf1841382017-06-12 01:16:46 -07003971TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003972 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003973 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003974 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08003975 // -1 means to disable max bitrate (set infinite).
3976 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003977 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003978 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003979}
3980
eladalonf1841382017-06-12 01:16:46 -07003981TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07003982 send_parameters_.max_bandwidth_bps = 99999;
3983 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003984 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003985 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07003986 ASSERT_EQ(1u, stream->GetVideoStreams().size());
3987 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3988 stream->GetVideoStreams()[0].max_bitrate_bps);
3989
3990 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003991 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003992 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3993 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07003994 stream->GetVideoStreams()[0].max_bitrate_bps);
3995}
3996
eladalonf1841382017-06-12 01:16:46 -07003997TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003998 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003999 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004000 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004001 channel_->SetSend(true);
4002
4003 FakeVideoSendStream* stream = AddSendStream();
4004
Tommi85959932018-02-07 19:26:06 +01004005 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004006 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004007 EXPECT_EQ(cricket::CS_RUNNING,
4008 capturer.Start(capturer.GetSupportedFormats()->front()));
4009
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004010 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4011 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4012 EXPECT_GT(initial_max_bitrate_bps, 0);
4013
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004014 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4015 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004016 // Insert a frame to update the encoder config.
4017 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004018 streams = stream->GetVideoStreams();
4019 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004020 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004021}
4022
eladalonf1841382017-06-12 01:16:46 -07004023TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004024 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004025 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004026 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004027 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004028 channel_->SetSend(true);
4029
4030 FakeVideoSendStream* stream = AddSendStream(
4031 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4032
4033 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004034 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004035 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004036 EXPECT_EQ(cricket::CS_RUNNING,
4037 capturer.Start(capturer.GetSupportedFormats()->front()));
4038 EXPECT_TRUE(capturer.CaptureFrame());
4039
4040 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4041 ASSERT_GT(streams.size(), 1u)
4042 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004043 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004044 EXPECT_GT(initial_max_bitrate_bps, 0);
4045
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004046 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4047 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004048 // Insert a frame to update the encoder config.
4049 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004050 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004051 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004052 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4053
Niels Möllerff40b142018-04-09 08:49:14 +02004054 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004055}
4056
eladalonf1841382017-06-12 01:16:46 -07004057TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004058 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004059 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004060 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004061 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4062 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004063 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004064 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004065
4066 VideoCodec codec;
4067 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4068 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4069}
4070
eladalonf1841382017-06-12 01:16:46 -07004071TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004072 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004073 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004074 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004075 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004076 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004077 parameters.codecs[0].id = kIncorrectPayloads[i];
4078 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004079 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004080 }
4081}
4082
eladalonf1841382017-06-12 01:16:46 -07004083TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004084 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004085 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004086 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004087 parameters.codecs[0].id = payload_type;
4088 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004089 << "Payload type '" << payload_type << "' rejected.";
4090 }
4091}
4092
deadbeef67cf2c12016-04-13 10:07:16 -07004093// Test that setting the a different set of codecs but with an identical front
4094// codec doesn't result in the stream being recreated.
4095// This may happen when a subsequent negotiation includes fewer codecs, as a
4096// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004097TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004098 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4099 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004100 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4101 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004102 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4103
4104 AddSendStream();
4105 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4106
4107 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004108 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004109 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4110 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4111}
4112
eladalonf1841382017-06-12 01:16:46 -07004113TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004114 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004115 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004116 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004117}
4118
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004119// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004120TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004121 const int kUnusedPayloadType1 = 126;
4122 const int kUnusedPayloadType2 = 127;
4123 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4124 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4125
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004126 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004127 parameters.codecs.push_back(GetEngineCodec("VP8"));
4128 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004129 parameters.codecs.push_back(rtx_codec);
4130 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004131 << "RTX codec without associated payload should be rejected.";
4132
magjed509e4fe2016-11-18 01:34:11 -08004133 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004134 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004135 << "RTX codec with invalid associated payload type should be rejected.";
4136
magjed509e4fe2016-11-18 01:34:11 -08004137 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004138 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004139
magjed509e4fe2016-11-18 01:34:11 -08004140 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004141 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004142 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004143
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004144 EXPECT_FALSE(channel_->SetRecvParameters(parameters)) <<
4145 "RTX codec with another RTX as associated payload type should be "
4146 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004147}
4148
eladalonf1841382017-06-12 01:16:46 -07004149TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004150 const int kUnusedPayloadType1 = 126;
4151 const int kUnusedPayloadType2 = 127;
4152 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4153 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4154
4155 // SSRCs for RTX.
4156 cricket::StreamParams params =
4157 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4158 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4159 AddRecvStream(params);
4160
4161 // Original payload type for RTX.
4162 cricket::VideoRecvParameters parameters;
4163 parameters.codecs.push_back(GetEngineCodec("VP8"));
4164 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4165 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4166 parameters.codecs.push_back(rtx_codec);
4167 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4168 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4169 const webrtc::VideoReceiveStream::Config& config_before =
4170 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004171 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4172 const int* payload_type_before = FindKeyByValue(
4173 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4174 ASSERT_NE(payload_type_before, nullptr);
4175 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004176 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4177
4178 // Change payload type for RTX.
4179 parameters.codecs[1].id = kUnusedPayloadType2;
4180 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4181 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4182 const webrtc::VideoReceiveStream::Config& config_after =
4183 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004184 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4185 const int* payload_type_after = FindKeyByValue(
4186 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4187 ASSERT_NE(payload_type_after, nullptr);
4188 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004189 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4190}
4191
eladalonf1841382017-06-12 01:16:46 -07004192TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004193 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004194 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004195 parameters.codecs[0].id = 99;
4196 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004197}
4198
eladalonf1841382017-06-12 01:16:46 -07004199TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004200 cricket::VideoRecvParameters parameters;
4201 parameters.codecs = engine_.codecs();
4202 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004203
4204 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004205 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004206 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].payload_name);
4207 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004208}
4209
eladalonf1841382017-06-12 01:16:46 -07004210TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004211 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004212 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004213 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004214 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004215}
4216
eladalonf1841382017-06-12 01:16:46 -07004217TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004218 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004219 parameters.codecs.push_back(GetEngineCodec("VP8"));
4220 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004221 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004222}
4223
eladalonf1841382017-06-12 01:16:46 -07004224TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004225 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004226 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4227 send_parameters.codecs.push_back(GetEngineCodec("red"));
4228 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004229 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004230
4231 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004232
magjed509e4fe2016-11-18 01:34:11 -08004233 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004234 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004235
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004236 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004237 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004238 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004239 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004240 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004241 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004242 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4243}
4244
eladalonf1841382017-06-12 01:16:46 -07004245TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004246 AddRecvStream(
4247 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004248 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004249 fake_call_->GetFlexfecReceiveStreams();
4250
4251 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004252 const FakeFlexfecReceiveStream* stream = streams.front();
4253 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4254 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4255 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4256 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004257
4258 cricket::VideoRecvParameters recv_parameters;
4259 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4260 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4261 EXPECT_TRUE(streams.empty())
4262 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004263}
4264
eladalonf1841382017-06-12 01:16:46 -07004265TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004266 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004267 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004268 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004269
4270 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004271 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4272 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4273 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004274 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4275 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004276 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004277 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004278 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004279 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004280
4281 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004282 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4283 send_parameters.codecs.push_back(GetEngineCodec("red"));
4284 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004285 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4286 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004287 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004288 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004289 << "ULPFEC should be enabled on the receive stream.";
4290}
4291
eladalonf1841382017-06-12 01:16:46 -07004292TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004293 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004294 AddRecvStream(
4295 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004296 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004297 fake_call_->GetFlexfecReceiveStreams();
4298
4299 cricket::VideoRecvParameters recv_parameters;
4300 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4301 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4302 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4303 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004304 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004305 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004306 stream_with_recv_params->GetConfig().payload_type);
4307 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004308 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004309 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004310 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004311 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004312
4313 cricket::VideoSendParameters send_parameters;
4314 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4315 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4316 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4317 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004318 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004319 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004320 stream_with_send_params->GetConfig().payload_type);
4321 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004322 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004323 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004324 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004325 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004326}
4327
eladalonf1841382017-06-12 01:16:46 -07004328TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004329 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004330 parameters.codecs.push_back(GetEngineCodec("VP8"));
4331 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004332 parameters.codecs[1].id = parameters.codecs[0].id;
4333 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004334}
4335
eladalonf1841382017-06-12 01:16:46 -07004336TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004337 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004338 cricket::VideoRecvParameters parameters;
4339 parameters.codecs.push_back(GetEngineCodec("VP8"));
4340 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4341 parameters.codecs[1].id = parameters.codecs[0].id;
4342 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4343}
4344
eladalonf1841382017-06-12 01:16:46 -07004345TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004346 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004347 parameters.codecs.push_back(GetEngineCodec("VP8"));
4348 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004349 parameters.codecs[1].id = parameters.codecs[0].id;
4350 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004351}
4352
eladalonf1841382017-06-12 01:16:46 -07004353TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004354 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004355 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004356 parameters.codecs.push_back(GetEngineCodec("VP8"));
4357 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004358 parameters.codecs[1].id += 1;
4359 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004360}
4361
deadbeef67cf2c12016-04-13 10:07:16 -07004362// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004363// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004364TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004365 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004366 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004367 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4368 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004369 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004370
4371 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4372 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4373
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004374 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004375 parameters2.codecs.push_back(GetEngineCodec("red"));
4376 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004377 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004378 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4379}
4380
eladalonf1841382017-06-12 01:16:46 -07004381TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004382 EXPECT_FALSE(AddSendStream()->IsSending());
4383}
4384
eladalonf1841382017-06-12 01:16:46 -07004385TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004386 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004387}
4388
eladalonf1841382017-06-12 01:16:46 -07004389TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004390 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004391 EXPECT_FALSE(stream->IsSending());
4392
4393 // false->true
4394 EXPECT_TRUE(channel_->SetSend(true));
4395 EXPECT_TRUE(stream->IsSending());
4396 // true->true
4397 EXPECT_TRUE(channel_->SetSend(true));
4398 EXPECT_TRUE(stream->IsSending());
4399 // true->false
4400 EXPECT_TRUE(channel_->SetSend(false));
4401 EXPECT_FALSE(stream->IsSending());
4402 // false->false
4403 EXPECT_TRUE(channel_->SetSend(false));
4404 EXPECT_FALSE(stream->IsSending());
4405
4406 EXPECT_TRUE(channel_->SetSend(true));
4407 FakeVideoSendStream* new_stream = AddSendStream();
4408 EXPECT_TRUE(new_stream->IsSending())
4409 << "Send stream created after SetSend(true) not sending initially.";
4410}
4411
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004412// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004413TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004414 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004415 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004416 MediaConfig config;
kwiberg686a8ef2016-02-26 03:00:35 -08004417 std::unique_ptr<VideoMediaChannel> channel;
nisse51542be2016-02-12 02:27:06 -08004418
4419 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4420 channel->SetInterface(network_interface.get());
4421 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004422 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004423
4424 config.enable_dscp = true;
4425 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4426 channel->SetInterface(network_interface.get());
4427 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
4428
4429 // Verify that setting the option to false resets the
4430 // DiffServCodePoint.
4431 config.enable_dscp = false;
4432 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4433 channel->SetInterface(network_interface.get());
4434 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004435}
4436
deadbeef13871492015-12-09 12:37:51 -08004437// This test verifies that the RTCP reduced size mode is properly applied to
4438// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004439TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004440 // Create stream, expecting that default mode is "compound".
4441 FakeVideoSendStream* stream1 = AddSendStream();
4442 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004443 webrtc::RtpParameters rtp_parameters =
4444 channel_->GetRtpSendParameters(last_ssrc_);
4445 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004446
4447 // Now enable reduced size mode.
4448 send_parameters_.rtcp.reduced_size = true;
4449 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4450 stream1 = fake_call_->GetVideoSendStreams()[0];
4451 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004452 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4453 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004454
4455 // Create a new stream and ensure it picks up the reduced size mode.
4456 FakeVideoSendStream* stream2 = AddSendStream();
4457 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4458}
4459
4460// This test verifies that the RTCP reduced size mode is properly applied to
4461// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004462TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004463 // Create stream, expecting that default mode is "compound".
4464 FakeVideoReceiveStream* stream1 = AddRecvStream();
4465 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4466
4467 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004468 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4469 // the reduced_size flag should come from that.
4470 send_parameters_.rtcp.reduced_size = true;
4471 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004472 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4473 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4474
4475 // Create a new stream and ensure it picks up the reduced size mode.
4476 FakeVideoReceiveStream* stream2 = AddRecvStream();
4477 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4478}
4479
eladalonf1841382017-06-12 01:16:46 -07004480TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004481 EXPECT_EQ(webrtc::kNetworkUp,
4482 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4483 EXPECT_EQ(webrtc::kNetworkUp,
4484 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004485
4486 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004487 EXPECT_EQ(webrtc::kNetworkDown,
4488 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4489 EXPECT_EQ(webrtc::kNetworkUp,
4490 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004491
4492 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004493 EXPECT_EQ(webrtc::kNetworkUp,
4494 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4495 EXPECT_EQ(webrtc::kNetworkUp,
4496 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004497}
4498
eladalonf1841382017-06-12 01:16:46 -07004499TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004500 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004501 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004502 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004503
4504 AddSendStream();
4505
4506 cricket::VideoMediaInfo info;
4507 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004508 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004509}
4510
eladalonf1841382017-06-12 01:16:46 -07004511TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004512 FakeVideoSendStream* stream = AddSendStream();
4513 webrtc::VideoSendStream::Stats stats;
4514 stats.encoder_implementation_name = "encoder_implementation_name";
4515 stream->SetStats(stats);
4516
4517 cricket::VideoMediaInfo info;
4518 ASSERT_TRUE(channel_->GetStats(&info));
4519 EXPECT_EQ(stats.encoder_implementation_name,
4520 info.senders[0].encoder_implementation_name);
4521}
4522
eladalonf1841382017-06-12 01:16:46 -07004523TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004524 FakeVideoSendStream* stream = AddSendStream();
4525 webrtc::VideoSendStream::Stats stats;
4526 stats.avg_encode_time_ms = 13;
4527 stats.encode_usage_percent = 42;
4528 stream->SetStats(stats);
4529
4530 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004531 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004532 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4533 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4534}
4535
eladalonf1841382017-06-12 01:16:46 -07004536TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004537 FakeVideoSendStream* stream = AddSendStream();
4538 webrtc::VideoSendStream::Stats stats;
4539 stats.frames_encoded = 13;
4540 stream->SetStats(stats);
4541
4542 cricket::VideoMediaInfo info;
4543 ASSERT_TRUE(channel_->GetStats(&info));
4544 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4545}
4546
eladalonf1841382017-06-12 01:16:46 -07004547TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004548 FakeVideoSendStream* stream = AddSendStream();
4549 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004550 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004551 stream->SetStats(stats);
4552
4553 cricket::VideoMediaInfo info;
4554 ASSERT_TRUE(channel_->GetStats(&info));
4555 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4556}
4557
eladalonf1841382017-06-12 01:16:46 -07004558TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004559 FakeVideoSendStream* stream = AddSendStream();
4560 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004561 stats.substreams[17].width = 123;
4562 stats.substreams[17].height = 40;
4563 stats.substreams[42].width = 80;
4564 stats.substreams[42].height = 31;
4565 stats.substreams[11].width = 20;
4566 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004567 stream->SetStats(stats);
4568
4569 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004570 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004571 ASSERT_EQ(1u, info.senders.size());
4572 EXPECT_EQ(123, info.senders[0].send_frame_width);
4573 EXPECT_EQ(90, info.senders[0].send_frame_height);
4574}
4575
eladalonf1841382017-06-12 01:16:46 -07004576TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004577 FakeVideoSendStream* stream = AddSendStream();
4578 webrtc::VideoSendStream::Stats stats;
4579 stats.number_of_cpu_adapt_changes = 2;
4580 stats.cpu_limited_resolution = true;
4581 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004582
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004583 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004584 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004585 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004586 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004587 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004588}
4589
eladalonf1841382017-06-12 01:16:46 -07004590TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004591 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004592 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004593 stats.number_of_cpu_adapt_changes = 2;
4594 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004595 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004596 stream->SetStats(stats);
4597
4598 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004599 EXPECT_TRUE(channel_->GetStats(&info));
4600 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004601 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4602 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004603 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004604 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004605}
4606
eladalonf1841382017-06-12 01:16:46 -07004607TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004608 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4609 FakeVideoSendStream* stream = AddSendStream();
4610 webrtc::VideoSendStream::Stats stats;
4611 stats.bw_limited_resolution = true;
4612 stream->SetStats(stats);
4613
4614 cricket::VideoMediaInfo info;
4615 EXPECT_TRUE(channel_->GetStats(&info));
4616 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004617 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004618 info.senders[0].adapt_reason);
4619}
4620
eladalonf1841382017-06-12 01:16:46 -07004621TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004622 GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
4623 FakeVideoSendStream* stream = AddSendStream();
4624 webrtc::VideoSendStream::Stats stats;
4625 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4626 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4627 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4628
4629 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4630 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4631 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4632
4633 stream->SetStats(stats);
4634
4635 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004636 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004637 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4638 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4639 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4640}
4641
eladalonf1841382017-06-12 01:16:46 -07004642TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004643 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4644 FakeVideoReceiveStream* stream = AddRecvStream();
4645 webrtc::VideoReceiveStream::Stats stats;
4646 stats.rtcp_packet_type_counts.fir_packets = 2;
4647 stats.rtcp_packet_type_counts.nack_packets = 3;
4648 stats.rtcp_packet_type_counts.pli_packets = 4;
4649 stream->SetStats(stats);
4650
4651 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004652 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004653 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004654 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004655 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004656 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004657 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004658 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004659}
4660
eladalonf1841382017-06-12 01:16:46 -07004661TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004662 FakeVideoReceiveStream* stream = AddRecvStream();
4663 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004664 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004665 stats.decode_ms = 2;
4666 stats.max_decode_ms = 3;
4667 stats.current_delay_ms = 4;
4668 stats.target_delay_ms = 5;
4669 stats.jitter_buffer_ms = 6;
4670 stats.min_playout_delay_ms = 7;
4671 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004672 stats.width = 9;
4673 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004674 stats.frame_counts.key_frames = 11;
4675 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004676 stats.frames_rendered = 13;
4677 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004678 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004679 stream->SetStats(stats);
4680
4681 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004682 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004683 EXPECT_EQ(stats.decoder_implementation_name,
4684 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004685 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4686 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4687 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4688 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4689 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4690 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4691 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004692 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4693 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004694 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4695 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004696 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004697 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004698 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004699 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004700}
4701
eladalonf1841382017-06-12 01:16:46 -07004702TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004703 FakeVideoReceiveStream* stream = AddRecvStream();
4704 webrtc::VideoReceiveStream::Stats stats;
4705 stats.rtp_stats.transmitted.payload_bytes = 2;
4706 stats.rtp_stats.transmitted.header_bytes = 3;
4707 stats.rtp_stats.transmitted.padding_bytes = 4;
4708 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004709 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004710 stats.rtcp_stats.fraction_lost = 7;
4711 stream->SetStats(stats);
4712
4713 cricket::VideoMediaInfo info;
4714 ASSERT_TRUE(channel_->GetStats(&info));
4715 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4716 stats.rtp_stats.transmitted.header_bytes +
4717 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004718 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004719 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004720 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004721 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004722 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004723 info.receivers[0].fraction_lost);
4724}
4725
eladalonf1841382017-06-12 01:16:46 -07004726TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004727 AddSendStream();
4728 AddSendStream();
4729 webrtc::Call::Stats stats;
4730 stats.rtt_ms = 123;
4731 fake_call_->SetStats(stats);
4732
4733 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004734 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004735 ASSERT_EQ(2u, info.senders.size());
4736 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4737 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4738}
4739
eladalonf1841382017-06-12 01:16:46 -07004740TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004741 FakeVideoSendStream* stream = AddSendStream();
4742 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004743 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004744 stats.media_bitrate_bps = 123;
4745 stats.substreams[17].total_bitrate_bps = 1;
4746 stats.substreams[17].retransmit_bitrate_bps = 2;
4747 stats.substreams[42].total_bitrate_bps = 3;
4748 stats.substreams[42].retransmit_bitrate_bps = 4;
4749 stream->SetStats(stats);
4750
4751 FakeVideoSendStream* stream2 = AddSendStream();
4752 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004753 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004754 stats2.media_bitrate_bps = 321;
4755 stats2.substreams[13].total_bitrate_bps = 5;
4756 stats2.substreams[13].retransmit_bitrate_bps = 6;
4757 stats2.substreams[21].total_bitrate_bps = 7;
4758 stats2.substreams[21].retransmit_bitrate_bps = 8;
4759 stream2->SetStats(stats2);
4760
4761 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004762 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004763 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004764 BandwidthEstimationInfo bwe_info;
4765 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004766 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4767 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4768 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4769 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004770 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004771 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004772 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004773 bwe_info.actual_enc_bitrate);
4774 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004775 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004776 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004777 << "Bandwidth stats should take all streams into account.";
4778}
4779
eladalonf1841382017-06-12 01:16:46 -07004780TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004781 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004782
Peter Boström0c4e06b2015-10-07 12:23:21 +02004783 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4784 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004785
4786 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4787 const size_t kDataLength = 12;
4788 uint8_t data[kDataLength];
4789 memset(data, 0, sizeof(data));
4790 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004791 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004792 rtc::PacketTime packet_time;
4793 channel_->OnPacketReceived(&packet, packet_time);
4794
4795 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4796 << "No default receive stream created.";
4797 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004798 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004799 << "Default receive stream should not have configured RTX";
4800
4801 EXPECT_TRUE(channel_->AddRecvStream(
4802 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4803 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004804 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004805 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004806 EXPECT_FALSE(
4807 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004808 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004809 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004810 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
4811 GetEngineCodec("red").id))
4812 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004813 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004814}
4815
eladalonf1841382017-06-12 01:16:46 -07004816TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004817 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004818
Peter Boström0c4e06b2015-10-07 12:23:21 +02004819 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4820 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004821
4822 StreamParams sp =
4823 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4824 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4825
4826 EXPECT_FALSE(channel_->AddSendStream(sp));
4827 EXPECT_FALSE(channel_->AddRecvStream(sp));
4828}
4829
eladalonf1841382017-06-12 01:16:46 -07004830TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004831 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004832
Peter Boström0c4e06b2015-10-07 12:23:21 +02004833 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4834 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004835
4836 StreamParams sp =
4837 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4838
4839 EXPECT_TRUE(channel_->AddSendStream(sp));
4840 EXPECT_TRUE(channel_->AddRecvStream(sp));
4841
4842 // The RTX SSRC is already used in previous streams, using it should fail.
4843 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
4844 EXPECT_FALSE(channel_->AddSendStream(sp));
4845 EXPECT_FALSE(channel_->AddRecvStream(sp));
4846
4847 // After removing the original stream this should be fine to add (makes sure
4848 // that RTX ssrcs are not forever taken).
4849 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
4850 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
4851 EXPECT_TRUE(channel_->AddSendStream(sp));
4852 EXPECT_TRUE(channel_->AddRecvStream(sp));
4853}
4854
eladalonf1841382017-06-12 01:16:46 -07004855TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01004856 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02004857 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
4858 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004859 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004860
Peter Boströmd6f4c252015-03-26 16:23:04 +01004861 StreamParams sp =
4862 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
4863
4864 EXPECT_TRUE(channel_->AddSendStream(sp));
4865 EXPECT_TRUE(channel_->AddRecvStream(sp));
4866
4867 // One of the SSRCs is already used in previous streams, using it should fail.
4868 sp = cricket::CreateSimStreamParams("cname",
4869 MAKE_VECTOR(kOverlappingStreamSsrcs));
4870 EXPECT_FALSE(channel_->AddSendStream(sp));
4871 EXPECT_FALSE(channel_->AddRecvStream(sp));
4872
4873 // After removing the original stream this should be fine to add (makes sure
4874 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02004875 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
4876 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004877 EXPECT_TRUE(channel_->AddSendStream(sp));
4878 EXPECT_TRUE(channel_->AddRecvStream(sp));
4879}
4880
eladalonf1841382017-06-12 01:16:46 -07004881TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004882 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02004883
4884 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
4885 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
4886
4887 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
4888 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
4889
4890 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
4891
4892 static const uint32_t kReceiverSsrcs[] = {3};
4893 static const uint32_t kReceiverRtxSsrcs[] = {2};
4894
4895 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
4896 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
4897 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
4898
4899 cricket::VideoMediaInfo info;
4900 ASSERT_TRUE(channel_->GetStats(&info));
4901
4902 ASSERT_EQ(1u, info.senders.size());
4903 ASSERT_EQ(1u, info.receivers.size());
4904
4905 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
4906 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
4907 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
4908}
4909
eladalonf1841382017-06-12 01:16:46 -07004910TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07004911 FakeVideoReceiveStream* stream = AddRecvStream();
4912 webrtc::VideoReceiveStream::Stats stats;
4913 cricket::VideoMediaInfo info;
4914
4915 // Report no codec name before receiving.
4916 stream->SetStats(stats);
4917 ASSERT_TRUE(channel_->GetStats(&info));
4918 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4919
4920 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08004921 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07004922 stream->SetStats(stats);
4923 ASSERT_TRUE(channel_->GetStats(&info));
4924 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
4925
4926 // Report no codec name for unknown playload types.
4927 stats.current_payload_type = 3;
4928 stream->SetStats(stats);
4929 ASSERT_TRUE(channel_->GetStats(&info));
4930 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4931}
4932
Seth Hampson5897a6e2018-04-03 11:16:33 -07004933// Tests that when we add a stream without SSRCs, but contains a stream_id
4934// that it is stored and its stream id is later used when the first packet
4935// arrives to properly create a receive stream with a sync label.
4936TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
4937 const char kSyncLabel[] = "sync_label";
4938 cricket::StreamParams unsignaled_stream;
4939 unsignaled_stream.set_stream_ids({kSyncLabel});
4940 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
4941 // The stream shouldn't have been created at this point because it doesn't
4942 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02004943 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07004944
4945 // Create and deliver packet.
4946 const size_t kDataLength = 12;
4947 uint8_t data[kDataLength];
4948 memset(data, 0, sizeof(data));
4949 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
4950 rtc::CopyOnWriteBuffer packet(data, kDataLength);
4951 rtc::PacketTime packet_time;
4952 channel_->OnPacketReceived(&packet, packet_time);
4953
4954 // The stream should now be created with the appropriate sync label.
4955 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4956 EXPECT_EQ(kSyncLabel,
4957 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
4958
4959 // Removing the unsignaled stream should clear the cache. This time when
4960 // a default video receive stream is created it won't have a sync_group.
4961 ASSERT_TRUE(channel_->RemoveRecvStream(0));
4962 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
4963 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4964
4965 channel_->OnPacketReceived(&packet, packet_time);
4966 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4967 EXPECT_TRUE(
4968 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
4969}
4970
eladalonf1841382017-06-12 01:16:46 -07004971void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07004972 uint8_t payload_type,
4973 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08004974 // kRedRtxPayloadType must currently be unused.
4975 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
4976
noahricd10a68e2015-07-10 11:27:55 -07004977 // Add a RED RTX codec.
4978 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08004979 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004980 recv_parameters_.codecs.push_back(red_rtx_codec);
4981 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07004982
4983 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4984 const size_t kDataLength = 12;
4985 uint8_t data[kDataLength];
4986 memset(data, 0, sizeof(data));
4987
4988 rtc::Set8(data, 1, payload_type);
4989 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07004990 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07004991 rtc::PacketTime packet_time;
4992 channel_->OnPacketReceived(&packet, packet_time);
4993
4994 if (expect_created_receive_stream) {
4995 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4996 << "Should have created a receive stream for payload type: "
4997 << payload_type;
4998 } else {
4999 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5000 << "Shouldn't have created a receive stream for payload type: "
5001 << payload_type;
5002 }
5003}
5004
eladalonf1841382017-06-12 01:16:46 -07005005TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005006 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5007 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005008}
5009
eladalonf1841382017-06-12 01:16:46 -07005010TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005011 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5012 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005013}
5014
eladalonf1841382017-06-12 01:16:46 -07005015TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005016 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005017 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5018 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5019 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5020 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005021}
5022
eladalonf1841382017-06-12 01:16:46 -07005023TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005024 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5025 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005026}
5027
eladalonf1841382017-06-12 01:16:46 -07005028TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005029 FlexfecPacketDoesntCreateUnsignalledStream) {
5030 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5031 false /* expect_created_receive_stream */);
5032}
5033
eladalonf1841382017-06-12 01:16:46 -07005034TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005035 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5036 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005037}
5038
mzanaty8a855d62017-02-17 15:46:43 -08005039// Test that receiving any unsignalled SSRC works even if it changes.
5040// The first unsignalled SSRC received will create a default receive stream.
5041// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005042TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005043 // Allow receiving VP8, VP9, H264 (if enabled).
5044 cricket::VideoRecvParameters parameters;
5045 parameters.codecs.push_back(GetEngineCodec("VP8"));
5046 parameters.codecs.push_back(GetEngineCodec("VP9"));
5047
5048#if defined(WEBRTC_USE_H264)
5049 cricket::VideoCodec H264codec(126, "H264");
5050 parameters.codecs.push_back(H264codec);
5051#endif
5052
5053 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5054 // No receive streams yet.
5055 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5056 cricket::FakeVideoRenderer renderer;
5057 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5058
5059 // Receive VP8 packet on first SSRC.
5060 uint8_t data[kMinRtpPacketLen];
5061 cricket::RtpHeader rtpHeader;
5062 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5063 rtpHeader.seq_num = rtpHeader.timestamp = 0;
5064 rtpHeader.ssrc = kIncomingUnsignalledSsrc+1;
5065 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5066 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5067 rtc::PacketTime packet_time;
5068 channel_->OnPacketReceived(&packet, packet_time);
5069 // VP8 packet should create default receive stream.
5070 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5071 FakeVideoReceiveStream* recv_stream =
5072 fake_call_->GetVideoReceiveStreams()[0];
5073 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5074 // Verify that the receive stream sinks to a renderer.
5075 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5076 webrtc::kVideoRotation_0);
5077 recv_stream->InjectFrame(video_frame);
5078 EXPECT_EQ(1, renderer.num_rendered_frames());
5079
5080 // Receive VP9 packet on second SSRC.
5081 rtpHeader.payload_type = GetEngineCodec("VP9").id;
5082 rtpHeader.ssrc = kIncomingUnsignalledSsrc+2;
5083 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5084 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5085 channel_->OnPacketReceived(&packet2, packet_time);
5086 // VP9 packet should replace the default receive SSRC.
5087 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5088 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5089 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5090 // Verify that the receive stream sinks to a renderer.
5091 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005092 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005093 recv_stream->InjectFrame(video_frame2);
5094 EXPECT_EQ(2, renderer.num_rendered_frames());
5095
5096#if defined(WEBRTC_USE_H264)
5097 // Receive H264 packet on third SSRC.
5098 rtpHeader.payload_type = 126;
5099 rtpHeader.ssrc = kIncomingUnsignalledSsrc+3;
5100 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5101 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5102 channel_->OnPacketReceived(&packet3, packet_time);
5103 // H264 packet should replace the default receive SSRC.
5104 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5105 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5106 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5107 // Verify that the receive stream sinks to a renderer.
5108 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005109 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005110 recv_stream->InjectFrame(video_frame3);
5111 EXPECT_EQ(3, renderer.num_rendered_frames());
5112#endif
5113}
5114
brandtr0dc57ea2017-05-29 23:33:31 -07005115// This test verifies that when a new default stream is created for a new
5116// unsignaled SSRC, the new stream does not overwrite any old stream that had
5117// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005118TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005119 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5120 cricket::VideoRecvParameters parameters;
5121 parameters.codecs.push_back(GetEngineCodec("VP8"));
5122 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5123
5124 // No streams signaled and no packets received, so we should not have any
5125 // stream objects created yet.
5126 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5127
5128 // Receive packet on an unsignaled SSRC.
5129 uint8_t data[kMinRtpPacketLen];
5130 cricket::RtpHeader rtp_header;
5131 rtp_header.payload_type = GetEngineCodec("VP8").id;
5132 rtp_header.seq_num = rtp_header.timestamp = 0;
5133 rtp_header.ssrc = kSsrcs3[0];
5134 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5135 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5136 rtc::PacketTime packet_time;
5137 channel_->OnPacketReceived(&packet, packet_time);
5138 // Default receive stream should be created.
5139 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5140 FakeVideoReceiveStream* recv_stream0 =
5141 fake_call_->GetVideoReceiveStreams()[0];
5142 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5143
5144 // Signal the SSRC.
5145 EXPECT_TRUE(
5146 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5147 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5148 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5149 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5150
5151 // Receive packet on a different unsignaled SSRC.
5152 rtp_header.ssrc = kSsrcs3[1];
5153 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5154 packet.SetData(data, sizeof(data));
5155 channel_->OnPacketReceived(&packet, packet_time);
5156 // New default receive stream should be created, but old stream should remain.
5157 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5158 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5159 FakeVideoReceiveStream* recv_stream1 =
5160 fake_call_->GetVideoReceiveStreams()[1];
5161 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5162}
5163
Seth Hampson7c682e02018-05-04 16:28:15 -07005164TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005165 AddSendStream();
5166
Tommi85959932018-02-07 19:26:06 +01005167 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005168 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005169 cricket::VideoFormat capture_format_hd =
5170 capturer.GetSupportedFormats()->front();
5171 EXPECT_EQ(1280, capture_format_hd.width);
5172 EXPECT_EQ(720, capture_format_hd.height);
5173 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5174 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005175 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005176
perkjfa10b552016-10-02 23:45:26 -07005177 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005178 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005179
5180 // TODO(skvlad): Resolve the inconsistency between the interpretation
5181 // of the global bitrate limit for audio and video:
5182 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5183 // max_bandwidth_bps = -1 - remove the bandwidth limit
5184 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005185 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005186
perkjfa10b552016-10-02 23:45:26 -07005187 SetAndExpectMaxBitrate(1000, 0, 1000);
5188 SetAndExpectMaxBitrate(1000, 800, 800);
5189 SetAndExpectMaxBitrate(600, 800, 600);
5190 SetAndExpectMaxBitrate(0, 800, 800);
5191 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005192
Niels Möllerff40b142018-04-09 08:49:14 +02005193 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005194}
5195
eladalonf1841382017-06-12 01:16:46 -07005196TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005197 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005198 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005199 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005200
5201 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005202 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005203 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005204}
5205
eladalonf1841382017-06-12 01:16:46 -07005206TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005207 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
5208 AddSendStream();
5209 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5210 EXPECT_EQ(1UL, parameters.encodings.size());
5211 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5212 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5213
5214 // Note that this is testing the behavior of the FakeVideoSendStream, which
5215 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5216 // we are just testing the behavior of
5217 // EncoderStreamFactory::CreateEncoderStreams.
5218 std::vector<webrtc::VideoStream> video_streams =
5219 fake_call_->GetVideoSendStreams().front()->GetVideoStreams();
5220 ASSERT_EQ(1UL, video_streams.size());
5221 EXPECT_EQ(kMinVideoBitrateBps, video_streams[0].min_bitrate_bps);
5222
5223 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5224 // by this amount.
5225 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5226 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5227 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5228 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5229
5230 video_streams = fake_call_->GetVideoSendStreams().front()->GetVideoStreams();
5231 ASSERT_EQ(1UL, video_streams.size());
5232 EXPECT_GE(low_max_bitrate_bps, video_streams[0].min_bitrate_bps);
5233}
5234
5235TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005236 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005237 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005238 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005239 // Two or more encodings should result in failure.
5240 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005241 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005242 // Zero encodings should also fail.
5243 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005244 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005245}
5246
Zach Stein3ca452b2018-01-18 10:01:24 -08005247TEST_F(WebRtcVideoChannelTest,
5248 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5249 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5250 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5251 AddSendStream(sp);
5252
5253 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5254
5255 // Additional encodings should result in failure.
5256 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005257 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005258 // Zero encodings should also fail.
5259 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005260 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005261}
5262
deadbeeffb2aced2017-01-06 23:05:37 -08005263// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005264TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005265 AddSendStream();
5266 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005267 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005268 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005269}
5270
Seth Hampson24722b32017-12-22 09:36:42 -08005271// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5272// a value <= 0, setting the parameters returns false.
5273TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5274 AddSendStream();
5275 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5276 EXPECT_EQ(1UL, parameters.encodings.size());
5277 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5278 parameters.encodings[0].bitrate_priority);
5279
5280 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005281 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005282 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005283 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005284}
5285
5286// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5287// properly on the VideoChannel and propogates down to the video encoder.
5288TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5289 AddSendStream();
5290 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5291 EXPECT_EQ(1UL, parameters.encodings.size());
5292 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5293 parameters.encodings[0].bitrate_priority);
5294
5295 // Change the value and set it on the VideoChannel.
5296 double new_bitrate_priority = 2.0;
5297 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005298 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005299
5300 // Verify that the encoding parameters bitrate_priority is set for the
5301 // VideoChannel.
5302 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5303 EXPECT_EQ(1UL, parameters.encodings.size());
5304 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5305
5306 // Verify that the new value propagated down to the encoder.
5307 std::vector<FakeVideoSendStream*> video_send_streams =
5308 fake_call_->GetVideoSendStreams();
5309 EXPECT_EQ(1UL, video_send_streams.size());
5310 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5311 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5312 // appropriately.
5313 EXPECT_EQ(new_bitrate_priority,
5314 video_send_stream->GetEncoderConfig().bitrate_priority);
5315 // Check that the vector of VideoStreams also was propagated correctly. Note
5316 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5317 // the calls to CreateEncoderStreams to get the VideoStreams.
5318 EXPECT_EQ(rtc::Optional<double>(new_bitrate_priority),
5319 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5320}
5321
5322// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5323// VideoChannel and the value propogates to the video encoder with all simulcast
5324// streams.
5325TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5326 // Create the stream params with multiple ssrcs for simulcast.
5327 const int kNumSimulcastStreams = 3;
5328 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5329 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5330 AddSendStream(stream_params);
5331 uint32_t primary_ssrc = stream_params.first_ssrc();
5332
Tommi85959932018-02-07 19:26:06 +01005333 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5334 // frame. This creates multiple VideoStreams for all simulcast layers when
5335 // reconfiguring, and allows us to test this behavior.
5336 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005337 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005338 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005339 EXPECT_EQ(cricket::CS_RUNNING,
5340 capturer.Start(cricket::VideoFormat(
5341 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5342 cricket::FOURCC_I420)));
5343 channel_->SetSend(true);
5344 EXPECT_TRUE(capturer.CaptureFrame());
5345 // Get and set the rtp encoding parameters.
5346 webrtc::RtpParameters parameters =
5347 channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005348 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5349 parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005350 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5351 parameters.encodings[0].bitrate_priority);
5352 // Change the value and set it on the VideoChannel.
5353 double new_bitrate_priority = 2.0;
5354 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005355 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005356
5357 // Verify that the encoding parameters priority is set on the VideoChannel.
5358 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005359 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5360 parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005361 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5362
5363 // Verify that the new value propagated down to the encoder.
5364 std::vector<FakeVideoSendStream*> video_send_streams =
5365 fake_call_->GetVideoSendStreams();
5366 EXPECT_EQ(1UL, video_send_streams.size());
5367 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5368 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5369 // appropriately.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005370 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
Seth Hampson24722b32017-12-22 09:36:42 -08005371 video_send_stream->GetEncoderConfig().number_of_streams);
5372 EXPECT_EQ(new_bitrate_priority,
5373 video_send_stream->GetEncoderConfig().bitrate_priority);
5374 // Check that the vector of VideoStreams also propagated correctly. The
5375 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5376 // these are created appropriately for the simulcast case.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005377 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5378 video_send_stream->GetVideoStreams().size());
Seth Hampson24722b32017-12-22 09:36:42 -08005379 EXPECT_EQ(rtc::Optional<double>(new_bitrate_priority),
5380 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5381 // Since we are only setting bitrate priority per-sender, the other
5382 // VideoStreams should have a bitrate priority of 0.
5383 EXPECT_EQ(rtc::nullopt,
5384 video_send_stream->GetVideoStreams()[1].bitrate_priority);
5385 EXPECT_EQ(rtc::nullopt,
5386 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005387 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005388}
5389
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005390// Test that a stream will not be sending if its encoding is made inactive
5391// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08005392TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07005393 FakeVideoSendStream* stream = AddSendStream();
5394 EXPECT_TRUE(channel_->SetSend(true));
5395 EXPECT_TRUE(stream->IsSending());
5396
5397 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005398 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07005399 ASSERT_EQ(1u, parameters.encodings.size());
5400 ASSERT_TRUE(parameters.encodings[0].active);
5401 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08005402 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07005403 EXPECT_FALSE(stream->IsSending());
5404
5405 // Now change it back to active and verify we resume sending.
5406 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08005407 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07005408 EXPECT_TRUE(stream->IsSending());
5409}
5410
Seth Hampson8234ead2018-02-02 15:16:24 -08005411// Tests that when active is updated for any simulcast layer then the send
5412// stream's sending state will be updated and it will be reconfigured with the
5413// new appropriate active simulcast streams.
5414TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
5415 // Create the stream params with multiple ssrcs for simulcast.
5416 const int kNumSimulcastStreams = 3;
5417 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5418 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5419 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
5420 uint32_t primary_ssrc = stream_params.first_ssrc();
5421
Tommi85959932018-02-07 19:26:06 +01005422 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5423 // frame. This allows us to test that ReconfigureEncoder is called
5424 // appropriately.
5425 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08005426 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005427 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08005428 EXPECT_EQ(cricket::CS_RUNNING,
5429 capturer.Start(cricket::VideoFormat(
5430 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5431 cricket::FOURCC_I420)));
5432 channel_->SetSend(true);
5433 EXPECT_TRUE(capturer.CaptureFrame());
5434
5435 // Check that all encodings are initially active.
5436 webrtc::RtpParameters parameters =
5437 channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005438 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5439 parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005440 EXPECT_TRUE(parameters.encodings[0].active);
5441 EXPECT_TRUE(parameters.encodings[1].active);
5442 EXPECT_TRUE(parameters.encodings[2].active);
5443 EXPECT_TRUE(fake_video_send_stream->IsSending());
5444
5445 // Only turn on only the middle stream.
5446 parameters.encodings[0].active = false;
5447 parameters.encodings[1].active = true;
5448 parameters.encodings[2].active = false;
5449 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
5450 // Verify that the active fields are set on the VideoChannel.
5451 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005452 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5453 parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005454 EXPECT_FALSE(parameters.encodings[0].active);
5455 EXPECT_TRUE(parameters.encodings[1].active);
5456 EXPECT_FALSE(parameters.encodings[2].active);
5457 // Check that the VideoSendStream is updated appropriately. This means its
5458 // send state was updated and it was reconfigured.
5459 EXPECT_TRUE(fake_video_send_stream->IsSending());
5460 std::vector<webrtc::VideoStream> simulcast_streams =
5461 fake_video_send_stream->GetVideoStreams();
Mirko Bonadeif859e552018-05-30 15:31:29 +02005462 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5463 simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005464 EXPECT_FALSE(simulcast_streams[0].active);
5465 EXPECT_TRUE(simulcast_streams[1].active);
5466 EXPECT_FALSE(simulcast_streams[2].active);
5467
5468 // Turn off all streams.
5469 parameters.encodings[0].active = false;
5470 parameters.encodings[1].active = false;
5471 parameters.encodings[2].active = false;
5472 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
5473 // Verify that the active fields are set on the VideoChannel.
5474 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005475 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5476 parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005477 EXPECT_FALSE(parameters.encodings[0].active);
5478 EXPECT_FALSE(parameters.encodings[1].active);
5479 EXPECT_FALSE(parameters.encodings[2].active);
5480 // Check that the VideoSendStream is off.
5481 EXPECT_FALSE(fake_video_send_stream->IsSending());
5482 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Mirko Bonadeif859e552018-05-30 15:31:29 +02005483 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5484 simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005485 EXPECT_FALSE(simulcast_streams[0].active);
5486 EXPECT_FALSE(simulcast_streams[1].active);
5487 EXPECT_FALSE(simulcast_streams[2].active);
5488
Niels Möllerff40b142018-04-09 08:49:14 +02005489 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08005490}
5491
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005492// Test that if a stream is reconfigured (due to a codec change or other
5493// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07005494TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005495 InactiveStreamDoesntStartSendingWhenReconfigured) {
5496 // Set an initial codec list, which will be modified later.
5497 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08005498 parameters1.codecs.push_back(GetEngineCodec("VP8"));
5499 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005500 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
5501
5502 FakeVideoSendStream* stream = AddSendStream();
5503 EXPECT_TRUE(channel_->SetSend(true));
5504 EXPECT_TRUE(stream->IsSending());
5505
5506 // Get current parameters and change "active" to false.
5507 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5508 ASSERT_EQ(1u, parameters.encodings.size());
5509 ASSERT_TRUE(parameters.encodings[0].active);
5510 parameters.encodings[0].active = false;
5511 EXPECT_EQ(1u, GetFakeSendStreams().size());
5512 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08005513 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005514 EXPECT_FALSE(stream->IsSending());
5515
5516 // Reorder the codec list, causing the stream to be reconfigured.
5517 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08005518 parameters2.codecs.push_back(GetEngineCodec("VP9"));
5519 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005520 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
5521 auto new_streams = GetFakeSendStreams();
5522 // Assert that a new underlying stream was created due to the codec change.
5523 // Otherwise, this test isn't testing what it set out to test.
5524 EXPECT_EQ(1u, GetFakeSendStreams().size());
5525 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
5526
5527 // Verify that we still are not sending anything, due to the inactive
5528 // encoding.
5529 EXPECT_FALSE(new_streams[0]->IsSending());
5530}
5531
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005532// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07005533TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005534 AddSendStream();
5535 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08005536 parameters.codecs.push_back(GetEngineCodec("VP8"));
5537 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005538 EXPECT_TRUE(channel_->SetSendParameters(parameters));
5539
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005540 webrtc::RtpParameters rtp_parameters =
5541 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005542 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08005543 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
5544 rtp_parameters.codecs[0]);
5545 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
5546 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005547}
5548
Florent Castellidacec712018-05-24 16:24:21 +02005549// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
5550TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
5551 StreamParams params = StreamParams::CreateLegacy(kSsrc);
5552 params.cname = "rtcpcname";
5553 AddSendStream(params);
5554
5555 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
5556 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
5557}
5558
deadbeeffb2aced2017-01-06 23:05:37 -08005559// Test that RtpParameters for send stream has one encoding and it has
5560// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07005561TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08005562 AddSendStream();
5563
5564 webrtc::RtpParameters rtp_parameters =
5565 channel_->GetRtpSendParameters(last_ssrc_);
5566 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01005567 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08005568}
5569
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005570// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07005571TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005572 AddSendStream();
5573 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08005574 parameters.codecs.push_back(GetEngineCodec("VP8"));
5575 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005576 EXPECT_TRUE(channel_->SetSendParameters(parameters));
5577
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005578 webrtc::RtpParameters initial_params =
5579 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005580
5581 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08005582 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005583
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005584 // ... And this shouldn't change the params returned by GetRtpSendParameters.
5585 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
5586}
5587
5588// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07005589TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005590 AddRecvStream();
5591 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08005592 parameters.codecs.push_back(GetEngineCodec("VP8"));
5593 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005594 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5595
5596 webrtc::RtpParameters rtp_parameters =
5597 channel_->GetRtpReceiveParameters(last_ssrc_);
5598 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08005599 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
5600 rtp_parameters.codecs[0]);
5601 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
5602 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005603}
5604
johan073ece42016-08-26 02:59:47 -07005605#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07005606TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07005607#else
eladalonf1841382017-06-12 01:16:46 -07005608TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07005609#endif
johan3859c892016-08-05 09:19:25 -07005610 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07005611 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08005612 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07005613 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07005614 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08005615 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07005616 parameters.codecs.push_back(kH264sprop2);
5617 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5618
5619 FakeVideoReceiveStream* recv_stream = AddRecvStream();
5620 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
5621 webrtc::RtpParameters rtp_parameters =
5622 channel_->GetRtpReceiveParameters(last_ssrc_);
5623 ASSERT_EQ(2u, rtp_parameters.codecs.size());
5624 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
5625 ASSERT_EQ(2u, cfg.decoders.size());
5626 EXPECT_EQ(101, cfg.decoders[0].payload_type);
5627 EXPECT_EQ("H264", cfg.decoders[0].payload_name);
magjed5dfac562016-11-25 03:56:37 -08005628 const auto it0 =
5629 cfg.decoders[0].codec_params.find(kH264FmtpSpropParameterSets);
5630 ASSERT_TRUE(it0 != cfg.decoders[0].codec_params.end());
5631 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07005632
5633 EXPECT_EQ(102, cfg.decoders[1].payload_type);
5634 EXPECT_EQ("H264", cfg.decoders[1].payload_name);
magjed5dfac562016-11-25 03:56:37 -08005635 const auto it1 =
5636 cfg.decoders[1].codec_params.find(kH264FmtpSpropParameterSets);
5637 ASSERT_TRUE(it1 != cfg.decoders[1].codec_params.end());
5638 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07005639}
5640
sakal1fd95952016-06-22 00:46:15 -07005641// Test that RtpParameters for receive stream has one encoding and it has
5642// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07005643TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07005644 AddRecvStream();
5645
5646 webrtc::RtpParameters rtp_parameters =
5647 channel_->GetRtpReceiveParameters(last_ssrc_);
5648 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01005649 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07005650}
5651
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005652// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07005653TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005654 AddRecvStream();
5655 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08005656 parameters.codecs.push_back(GetEngineCodec("VP8"));
5657 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005658 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5659
5660 webrtc::RtpParameters initial_params =
5661 channel_->GetRtpReceiveParameters(last_ssrc_);
5662
5663 // We should be able to set the params we just got.
5664 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
5665
5666 // ... And this shouldn't change the params returned by
5667 // GetRtpReceiveParameters.
5668 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005669}
5670
deadbeef3bc15102017-04-20 19:25:07 -07005671// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
5672// aren't signaled. It should always return an empty "RtpEncodingParameters",
5673// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07005674TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07005675 // Call necessary methods to configure receiving a default stream as
5676 // soon as it arrives.
5677 cricket::VideoRecvParameters parameters;
5678 parameters.codecs.push_back(GetEngineCodec("VP8"));
5679 parameters.codecs.push_back(GetEngineCodec("VP9"));
5680 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5681
5682 // Call GetRtpReceiveParameters before configured to receive an unsignaled
5683 // stream. Should return nothing.
5684 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
5685
5686 // Set a sink for an unsignaled stream.
5687 cricket::FakeVideoRenderer renderer;
5688 // Value of "0" means "unsignaled stream".
5689 EXPECT_TRUE(channel_->SetSink(0, &renderer));
5690
5691 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
5692 // in this method means "unsignaled stream".
5693 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
5694 ASSERT_EQ(1u, rtp_parameters.encodings.size());
5695 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
5696
5697 // Receive VP8 packet.
5698 uint8_t data[kMinRtpPacketLen];
5699 cricket::RtpHeader rtpHeader;
5700 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5701 rtpHeader.seq_num = rtpHeader.timestamp = 0;
5702 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
5703 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5704 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5705 rtc::PacketTime packet_time;
5706 channel_->OnPacketReceived(&packet, packet_time);
5707
5708 // The |ssrc| member should still be unset.
5709 rtp_parameters = channel_->GetRtpReceiveParameters(0);
5710 ASSERT_EQ(1u, rtp_parameters.encodings.size());
5711 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
5712}
5713
eladalonf1841382017-06-12 01:16:46 -07005714void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02005715 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005716 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02005717
5718 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02005719 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02005720 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02005721 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02005722
5723 if (receiver_first) {
5724 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
5725 std::vector<FakeVideoReceiveStream*> receive_streams =
5726 fake_call_->GetVideoReceiveStreams();
5727 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02005728 // Default local SSRC when we have no sender.
5729 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
5730 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02005731 }
5732 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
5733 if (!receiver_first)
5734 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
5735 std::vector<FakeVideoReceiveStream*> receive_streams =
5736 fake_call_->GetVideoReceiveStreams();
5737 ASSERT_EQ(1u, receive_streams.size());
5738 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02005739
5740 // Removing first sender should fall back to another (in this case the second)
5741 // local send stream's SSRC.
5742 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
5743 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
5744 receive_streams =
5745 fake_call_->GetVideoReceiveStreams();
5746 ASSERT_EQ(1u, receive_streams.size());
5747 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
5748
5749 // Removing the last sender should fall back to default local SSRC.
5750 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
5751 receive_streams =
5752 fake_call_->GetVideoReceiveStreams();
5753 ASSERT_EQ(1u, receive_streams.size());
5754 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
5755 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02005756}
5757
eladalonf1841382017-06-12 01:16:46 -07005758TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02005759 TestReceiverLocalSsrcConfiguration(false);
5760}
5761
eladalonf1841382017-06-12 01:16:46 -07005762TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02005763 TestReceiverLocalSsrcConfiguration(true);
5764}
5765
eladalonf1841382017-06-12 01:16:46 -07005766class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005767 public:
eladalonf1841382017-06-12 01:16:46 -07005768 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01005769 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02005770 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
5771 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02005772 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02005773 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02005774 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02005775 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07005776 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005777
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00005778 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005779 encoder_factory_->AddSupportedVideoCodecType("VP8");
nisse51542be2016-02-12 02:27:06 -08005780 channel_.reset(
kthelgason2bc68642017-02-07 07:02:22 -08005781 engine_.CreateChannel(&fake_call_, GetMediaConfig(), VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08005782 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005783 last_ssrc_ = 123;
5784 }
5785
5786 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005787 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07005788 int capture_width,
5789 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005790 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08005791 size_t expected_num_streams,
5792 bool screenshare,
5793 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005794 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005795 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08005796 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005797 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005798
Peter Boström0c4e06b2015-10-07 12:23:21 +02005799 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07005800 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005801 ssrcs.resize(num_configured_streams);
5802
sprangf24a0642017-02-28 13:23:26 -08005803 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00005804 // Send a full-size frame to trigger a stream reconfiguration to use all
5805 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01005806 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08005807 VideoOptions options;
5808 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01005809 options.is_screencast = screenshare;
deadbeef5a4a75a2016-06-02 16:23:38 -07005810 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02005811 channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08005812 // Fetch the latest stream since SetVideoSend() may recreate it if the
5813 // screen content setting is changed.
5814 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00005815 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07005816 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00005817 cricket::VideoFormat::FpsToInterval(30),
5818 cricket::FOURCC_I420)));
5819 channel_->SetSend(true);
5820 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005821
Zach Stein3ca452b2018-01-18 10:01:24 -08005822 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
5823 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
5824
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005825 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5826 ASSERT_EQ(expected_num_streams, video_streams.size());
5827
sprang429600d2017-01-26 06:12:26 -08005828 std::vector<webrtc::VideoStream> expected_streams;
5829 if (conference_mode) {
5830 expected_streams = GetSimulcastConfig(
5831 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08005832 webrtc::kDefaultBitratePriority, kDefaultQpMax,
5833 kDefaultVideoMaxFramerate, screenshare);
sprang3ebabf12017-02-16 07:35:22 -08005834 if (screenshare) {
5835 for (const webrtc::VideoStream& stream : expected_streams) {
5836 // Never scale screen content.
Niels Möllerefc71e52018-06-08 08:46:04 +02005837 EXPECT_EQ(stream.width, capture_width);
5838 EXPECT_EQ(stream.height, capture_height);
sprang3ebabf12017-02-16 07:35:22 -08005839 }
5840 }
sprang429600d2017-01-26 06:12:26 -08005841 } else {
5842 webrtc::VideoStream stream;
5843 stream.width = capture_width;
5844 stream.height = capture_height;
5845 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01005846 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08005847 int max_bitrate_kbps;
5848 if (capture_width * capture_height <= 320 * 240) {
5849 max_bitrate_kbps = 600;
5850 } else if (capture_width * capture_height <= 640 * 480) {
5851 max_bitrate_kbps = 1700;
5852 } else if (capture_width * capture_height <= 960 * 540) {
5853 max_bitrate_kbps = 2000;
5854 } else {
5855 max_bitrate_kbps = 2500;
5856 }
5857 stream.target_bitrate_bps = stream.max_bitrate_bps =
5858 max_bitrate_kbps * 1000;
5859 stream.max_qp = kDefaultQpMax;
5860 expected_streams.push_back(stream);
5861 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005862
5863 ASSERT_EQ(expected_streams.size(), video_streams.size());
5864
5865 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005866 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005867 for (size_t i = 0; i < num_streams; ++i) {
5868 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
5869 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
5870
5871 EXPECT_GT(video_streams[i].max_framerate, 0);
5872 EXPECT_EQ(expected_streams[i].max_framerate,
5873 video_streams[i].max_framerate);
5874
5875 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
5876 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
5877 video_streams[i].min_bitrate_bps);
5878
5879 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
5880 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
5881 video_streams[i].target_bitrate_bps);
5882
5883 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
5884 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
5885 video_streams[i].max_bitrate_bps);
5886
5887 EXPECT_GT(video_streams[i].max_qp, 0);
5888 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
5889
Sergey Silkina796a7e2018-03-01 15:11:29 +01005890 EXPECT_EQ(conference_mode,
5891 expected_streams[i].num_temporal_layers.has_value());
5892
5893 if (conference_mode) {
5894 EXPECT_EQ(expected_streams[i].num_temporal_layers,
5895 video_streams[i].num_temporal_layers);
5896 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005897
5898 if (i == num_streams - 1) {
5899 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
5900 } else {
5901 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
5902 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005903 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005904
Niels Möllerff40b142018-04-09 08:49:14 +02005905 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005906 }
5907
5908 FakeVideoSendStream* AddSendStream() {
5909 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
5910 }
5911
5912 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
5913 size_t num_streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005914 fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005915 EXPECT_TRUE(channel_->AddSendStream(sp));
5916 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005917 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005918 EXPECT_EQ(num_streams + 1, streams.size());
5919 return streams[streams.size() - 1];
5920 }
5921
5922 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005923 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005924 }
5925
5926 FakeVideoReceiveStream* AddRecvStream() {
5927 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
5928 }
5929
5930 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
5931 size_t num_streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005932 fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005933 EXPECT_TRUE(channel_->AddRecvStream(sp));
5934 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005935 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005936 EXPECT_EQ(num_streams + 1, streams.size());
5937 return streams[streams.size() - 1];
5938 }
5939
skvlad11a9cbf2016-10-07 11:53:05 -07005940 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005941 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02005942 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
5943 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07005944 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08005945 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02005946 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005947};
5948
eladalonf1841382017-06-12 01:16:46 -07005949TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08005950 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
5951 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005952}
5953
eladalonf1841382017-06-12 01:16:46 -07005954TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08005955 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
5956 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005957}
5958
5959// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07005960TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08005961 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
5962 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005963}
sprang429600d2017-01-26 06:12:26 -08005964
eladalonf1841382017-06-12 01:16:46 -07005965TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
sprang429600d2017-01-26 06:12:26 -08005966 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
5967 false);
5968}
5969
eladalonf1841382017-06-12 01:16:46 -07005970TEST_F(WebRtcVideoChannelSimulcastTest,
sprang429600d2017-01-26 06:12:26 -08005971 SetSendCodecsForConferenceModeScreenshare) {
5972 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
5973 true);
5974}
5975
eladalonf1841382017-06-12 01:16:46 -07005976TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08005977 webrtc::test::ScopedFieldTrials override_field_trials_(
5978 "WebRTC-SimulcastScreenshare/Enabled/");
5979 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
5980 true);
5981}
5982
eladalonf1841382017-06-12 01:16:46 -07005983TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07005984 NoSimulcastScreenshareWithoutConference) {
5985 webrtc::test::ScopedFieldTrials override_field_trials_(
5986 "WebRTC-SimulcastScreenshare/Enabled/");
5987 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
5988 false);
5989}
5990
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00005991} // namespace cricket