Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2019 The WebRTC Project Authors. All rights reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | #include "api/task_queue/task_queue_test.h" |
| 11 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 12 | #include <memory> |
| 13 | |
| 14 | #include "absl/cleanup/cleanup.h" |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 15 | #include "absl/strings/string_view.h" |
Markus Handell | 82da932 | 2022-12-16 15:50:24 +0100 | [diff] [blame] | 16 | #include "api/task_queue/task_queue_base.h" |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 17 | #include "api/units/time_delta.h" |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 18 | #include "rtc_base/event.h" |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 19 | #include "rtc_base/ref_counter.h" |
Steve Anton | f380284 | 2019-01-24 19:07:40 -0800 | [diff] [blame] | 20 | #include "rtc_base/time_utils.h" |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 21 | |
| 22 | namespace webrtc { |
| 23 | namespace { |
| 24 | |
Markus Handell | 82da932 | 2022-12-16 15:50:24 +0100 | [diff] [blame] | 25 | // Avoids a dependency to system_wrappers. |
| 26 | void SleepFor(TimeDelta duration) { |
| 27 | rtc::ScopedAllowBaseSyncPrimitivesForTesting allow; |
| 28 | rtc::Event event; |
| 29 | event.Wait(duration); |
| 30 | } |
| 31 | |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 32 | std::unique_ptr<TaskQueueBase, TaskQueueDeleter> CreateTaskQueue( |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 33 | const std::unique_ptr<webrtc::TaskQueueFactory>& factory, |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 34 | absl::string_view task_queue_name, |
| 35 | TaskQueueFactory::Priority priority = TaskQueueFactory::Priority::NORMAL) { |
| 36 | return factory->CreateTaskQueue(task_queue_name, priority); |
| 37 | } |
| 38 | |
| 39 | TEST_P(TaskQueueTest, Construct) { |
Ali Tofigh | 4b68194 | 2022-08-23 12:57:16 +0200 | [diff] [blame] | 40 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 41 | auto queue = CreateTaskQueue(factory, "Construct"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 42 | EXPECT_FALSE(queue->IsCurrent()); |
| 43 | } |
| 44 | |
| 45 | TEST_P(TaskQueueTest, PostAndCheckCurrent) { |
Ali Tofigh | 4b68194 | 2022-08-23 12:57:16 +0200 | [diff] [blame] | 46 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 47 | rtc::Event event; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 48 | auto queue = CreateTaskQueue(factory, "PostAndCheckCurrent"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 49 | |
Artem Titov | 0e61fdd | 2021-07-25 21:50:14 +0200 | [diff] [blame] | 50 | // We're not running a task, so `queue` shouldn't be current. |
Tommi | 6866dc7 | 2020-05-15 10:11:56 +0200 | [diff] [blame] | 51 | // Note that because rtc::Thread also supports the TQ interface and |
| 52 | // TestMainImpl::Init wraps the main test thread (bugs.webrtc.org/9714), that |
| 53 | // means that TaskQueueBase::Current() will still return a valid value. |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 54 | EXPECT_FALSE(queue->IsCurrent()); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 55 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 56 | queue->PostTask([&event, &queue] { |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 57 | EXPECT_TRUE(queue->IsCurrent()); |
| 58 | event.Set(); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 59 | }); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame] | 60 | EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 61 | } |
| 62 | |
| 63 | TEST_P(TaskQueueTest, PostCustomTask) { |
Ali Tofigh | 4b68194 | 2022-08-23 12:57:16 +0200 | [diff] [blame] | 64 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 65 | rtc::Event ran; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 66 | auto queue = CreateTaskQueue(factory, "PostCustomImplementation"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 67 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 68 | class CustomTask { |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 69 | public: |
| 70 | explicit CustomTask(rtc::Event* ran) : ran_(ran) {} |
| 71 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 72 | void operator()() { ran_->Set(); } |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 73 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 74 | private: |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 75 | rtc::Event* const ran_; |
| 76 | } my_task(&ran); |
| 77 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 78 | queue->PostTask(my_task); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame] | 79 | EXPECT_TRUE(ran.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 80 | } |
| 81 | |
| 82 | TEST_P(TaskQueueTest, PostDelayedZero) { |
Ali Tofigh | 4b68194 | 2022-08-23 12:57:16 +0200 | [diff] [blame] | 83 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 84 | rtc::Event event; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 85 | auto queue = CreateTaskQueue(factory, "PostDelayedZero"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 86 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 87 | queue->PostDelayedTask([&event] { event.Set(); }, TimeDelta::Zero()); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame] | 88 | EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 89 | } |
| 90 | |
| 91 | TEST_P(TaskQueueTest, PostFromQueue) { |
Ali Tofigh | 4b68194 | 2022-08-23 12:57:16 +0200 | [diff] [blame] | 92 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 93 | rtc::Event event; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 94 | auto queue = CreateTaskQueue(factory, "PostFromQueue"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 95 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 96 | queue->PostTask( |
| 97 | [&event, &queue] { queue->PostTask([&event] { event.Set(); }); }); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame] | 98 | EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 99 | } |
| 100 | |
| 101 | TEST_P(TaskQueueTest, PostDelayed) { |
Ali Tofigh | 4b68194 | 2022-08-23 12:57:16 +0200 | [diff] [blame] | 102 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 103 | rtc::Event event; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 104 | auto queue = |
| 105 | CreateTaskQueue(factory, "PostDelayed", TaskQueueFactory::Priority::HIGH); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 106 | |
| 107 | int64_t start = rtc::TimeMillis(); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 108 | queue->PostDelayedTask( |
| 109 | [&event, &queue] { |
| 110 | EXPECT_TRUE(queue->IsCurrent()); |
| 111 | event.Set(); |
| 112 | }, |
| 113 | TimeDelta::Millis(100)); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame] | 114 | EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 115 | int64_t end = rtc::TimeMillis(); |
| 116 | // These tests are a little relaxed due to how "powerful" our test bots can |
| 117 | // be. Most recently we've seen windows bots fire the callback after 94-99ms, |
| 118 | // which is why we have a little bit of leeway backwards as well. |
| 119 | EXPECT_GE(end - start, 90u); |
| 120 | EXPECT_NEAR(end - start, 190u, 100u); // Accept 90-290. |
| 121 | } |
| 122 | |
| 123 | TEST_P(TaskQueueTest, PostMultipleDelayed) { |
Ali Tofigh | 4b68194 | 2022-08-23 12:57:16 +0200 | [diff] [blame] | 124 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 125 | auto queue = CreateTaskQueue(factory, "PostMultipleDelayed"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 126 | |
| 127 | std::vector<rtc::Event> events(100); |
| 128 | for (int i = 0; i < 100; ++i) { |
| 129 | rtc::Event* event = &events[i]; |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 130 | queue->PostDelayedTask( |
| 131 | [event, &queue] { |
| 132 | EXPECT_TRUE(queue->IsCurrent()); |
| 133 | event->Set(); |
| 134 | }, |
| 135 | TimeDelta::Millis(i)); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 136 | } |
| 137 | |
| 138 | for (rtc::Event& e : events) |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame] | 139 | EXPECT_TRUE(e.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 140 | } |
| 141 | |
| 142 | TEST_P(TaskQueueTest, PostDelayedAfterDestruct) { |
Ali Tofigh | 4b68194 | 2022-08-23 12:57:16 +0200 | [diff] [blame] | 143 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 144 | rtc::Event run; |
| 145 | rtc::Event deleted; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 146 | auto queue = CreateTaskQueue(factory, "PostDelayedAfterDestruct"); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 147 | absl::Cleanup cleanup = [&deleted] { deleted.Set(); }; |
| 148 | queue->PostDelayedTask([&run, cleanup = std::move(cleanup)] { run.Set(); }, |
| 149 | TimeDelta::Millis(100)); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 150 | // Destroy the queue. |
| 151 | queue = nullptr; |
| 152 | // Task might outlive the TaskQueue, but still should be deleted. |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame] | 153 | EXPECT_TRUE(deleted.Wait(TimeDelta::Seconds(1))); |
| 154 | EXPECT_FALSE(run.Wait(TimeDelta::Zero())); // and should not run. |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 155 | } |
| 156 | |
Markus Handell | 82da932 | 2022-12-16 15:50:24 +0100 | [diff] [blame] | 157 | TEST_P(TaskQueueTest, PostDelayedHighPrecisionAfterDestruct) { |
| 158 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
| 159 | rtc::Event run; |
| 160 | rtc::Event deleted; |
| 161 | auto queue = |
| 162 | CreateTaskQueue(factory, "PostDelayedHighPrecisionAfterDestruct"); |
| 163 | absl::Cleanup cleanup = [&deleted] { deleted.Set(); }; |
| 164 | queue->PostDelayedHighPrecisionTask( |
| 165 | [&run, cleanup = std::move(cleanup)] { run.Set(); }, |
| 166 | TimeDelta::Millis(100)); |
| 167 | // Destroy the queue. |
| 168 | queue = nullptr; |
| 169 | // Task might outlive the TaskQueue, but still should be deleted. |
| 170 | EXPECT_TRUE(deleted.Wait(TimeDelta::Seconds(1))); |
| 171 | EXPECT_FALSE(run.Wait(TimeDelta::Zero())); // and should not run. |
| 172 | } |
| 173 | |
| 174 | TEST_P(TaskQueueTest, PostedUnexecutedClosureDestroyedOnTaskQueue) { |
| 175 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
| 176 | auto queue = |
| 177 | CreateTaskQueue(factory, "PostedUnexecutedClosureDestroyedOnTaskQueue"); |
| 178 | TaskQueueBase* queue_ptr = queue.get(); |
| 179 | queue->PostTask([] { SleepFor(TimeDelta::Millis(100)); }); |
| 180 | // Give the task queue a chance to start executing the first lambda. |
| 181 | SleepFor(TimeDelta::Millis(10)); |
| 182 | // Then ensure the next lambda (which is likely not executing yet) is |
| 183 | // destroyed in the task queue context when the queue is deleted. |
| 184 | auto cleanup = absl::Cleanup( |
| 185 | [queue_ptr] { EXPECT_EQ(queue_ptr, TaskQueueBase::Current()); }); |
| 186 | queue->PostTask([cleanup = std::move(cleanup)] {}); |
| 187 | queue = nullptr; |
| 188 | } |
| 189 | |
| 190 | TEST_P(TaskQueueTest, PostedExecutedClosureDestroyedOnTaskQueue) { |
| 191 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
| 192 | auto queue = |
| 193 | CreateTaskQueue(factory, "PostedExecutedClosureDestroyedOnTaskQueue"); |
| 194 | TaskQueueBase* queue_ptr = queue.get(); |
| 195 | // Ensure an executed lambda is destroyed on the task queue. |
| 196 | rtc::Event finished; |
| 197 | queue->PostTask([cleanup = absl::Cleanup([queue_ptr, &finished] { |
| 198 | EXPECT_EQ(queue_ptr, TaskQueueBase::Current()); |
| 199 | finished.Set(); |
| 200 | })] {}); |
| 201 | finished.Wait(rtc::Event::kForever); |
| 202 | } |
| 203 | |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 204 | TEST_P(TaskQueueTest, PostAndReuse) { |
Ali Tofigh | 4b68194 | 2022-08-23 12:57:16 +0200 | [diff] [blame] | 205 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 206 | rtc::Event event; |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 207 | auto post_queue = CreateTaskQueue(factory, "PostQueue"); |
| 208 | auto reply_queue = CreateTaskQueue(factory, "ReplyQueue"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 209 | |
| 210 | int call_count = 0; |
| 211 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 212 | class ReusedTask { |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 213 | public: |
| 214 | ReusedTask(int* counter, TaskQueueBase* reply_queue, rtc::Event* event) |
| 215 | : counter_(*counter), reply_queue_(reply_queue), event_(*event) { |
| 216 | EXPECT_EQ(counter_, 0); |
| 217 | } |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 218 | ReusedTask(ReusedTask&&) = default; |
| 219 | ReusedTask& operator=(ReusedTask&&) = delete; |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 220 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 221 | void operator()() && { |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 222 | if (++counter_ == 1) { |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 223 | reply_queue_->PostTask(std::move(*this)); |
| 224 | // At this point, the object is in the moved-from state. |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 225 | } else { |
| 226 | EXPECT_EQ(counter_, 2); |
| 227 | EXPECT_TRUE(reply_queue_->IsCurrent()); |
| 228 | event_.Set(); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 229 | } |
| 230 | } |
| 231 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 232 | private: |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 233 | int& counter_; |
| 234 | TaskQueueBase* const reply_queue_; |
| 235 | rtc::Event& event_; |
| 236 | }; |
| 237 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 238 | ReusedTask task(&call_count, reply_queue.get(), &event); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 239 | post_queue->PostTask(std::move(task)); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame] | 240 | EXPECT_TRUE(event.Wait(TimeDelta::Seconds(1))); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 241 | } |
| 242 | |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 243 | TEST_P(TaskQueueTest, PostALot) { |
Artem Titov | 0e61fdd | 2021-07-25 21:50:14 +0200 | [diff] [blame] | 244 | // Waits until DecrementCount called `count` times. Thread safe. |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 245 | class BlockingCounter { |
| 246 | public: |
| 247 | explicit BlockingCounter(int initial_count) : count_(initial_count) {} |
| 248 | |
| 249 | void DecrementCount() { |
| 250 | if (count_.DecRef() == rtc::RefCountReleaseStatus::kDroppedLastRef) { |
| 251 | event_.Set(); |
| 252 | } |
| 253 | } |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame] | 254 | bool Wait(TimeDelta give_up_after) { return event_.Wait(give_up_after); } |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 255 | |
| 256 | private: |
| 257 | webrtc_impl::RefCounter count_; |
| 258 | rtc::Event event_; |
| 259 | }; |
| 260 | |
Ali Tofigh | 4b68194 | 2022-08-23 12:57:16 +0200 | [diff] [blame] | 261 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 262 | static constexpr int kTaskCount = 0xffff; |
| 263 | rtc::Event posting_done; |
| 264 | BlockingCounter all_destroyed(kTaskCount); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 265 | |
| 266 | int tasks_executed = 0; |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 267 | auto task_queue = CreateTaskQueue(factory, "PostALot"); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 268 | |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 269 | task_queue->PostTask([&] { |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 270 | // Post tasks from the queue to guarantee that the 1st task won't be |
| 271 | // executed before the last one is posted. |
| 272 | for (int i = 0; i < kTaskCount; ++i) { |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 273 | absl::Cleanup cleanup = [&] { all_destroyed.DecrementCount(); }; |
| 274 | task_queue->PostTask([&tasks_executed, cleanup = std::move(cleanup)] { |
| 275 | ++tasks_executed; |
| 276 | }); |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 277 | } |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 278 | |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 279 | posting_done.Set(); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 280 | }); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 281 | |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 282 | // Before destroying the task queue wait until all child tasks are posted. |
Danil Chapovalov | 95e0a60 | 2019-06-11 13:49:20 +0200 | [diff] [blame] | 283 | posting_done.Wait(rtc::Event::kForever); |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 284 | // Destroy the task queue. |
| 285 | task_queue = nullptr; |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 286 | |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 287 | // Expect all tasks are destroyed eventually. In some task queue |
| 288 | // implementations that might happen on a different thread after task queue is |
| 289 | // destroyed. |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame] | 290 | EXPECT_TRUE(all_destroyed.Wait(TimeDelta::Minutes(1))); |
Danil Chapovalov | f504dd3 | 2019-06-05 14:16:59 +0200 | [diff] [blame] | 291 | EXPECT_LE(tasks_executed, kTaskCount); |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 292 | } |
| 293 | |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 294 | // Test posting two tasks that have shared state not protected by a |
| 295 | // lock. The TaskQueue should guarantee memory read-write order and |
| 296 | // FIFO task execution order, so the second task should always see the |
| 297 | // changes that were made by the first task. |
| 298 | // |
| 299 | // If the TaskQueue doesn't properly synchronize the execution of |
| 300 | // tasks, there will be a data race, which is undefined behavior. The |
| 301 | // EXPECT calls may randomly catch this, but to make the most of this |
| 302 | // unit test, run it under TSan or some other tool that is able to |
| 303 | // directly detect data races. |
| 304 | TEST_P(TaskQueueTest, PostTwoWithSharedUnprotectedState) { |
Ali Tofigh | 4b68194 | 2022-08-23 12:57:16 +0200 | [diff] [blame] | 305 | std::unique_ptr<webrtc::TaskQueueFactory> factory = GetParam()(nullptr); |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 306 | struct SharedState { |
| 307 | // First task will set this value to 1 and second will assert it. |
| 308 | int state = 0; |
| 309 | } state; |
| 310 | |
Danil Chapovalov | 710f3d3 | 2019-02-06 16:00:44 +0100 | [diff] [blame] | 311 | auto queue = CreateTaskQueue(factory, "PostTwoWithSharedUnprotectedState"); |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 312 | rtc::Event done; |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 313 | queue->PostTask([&state, &queue, &done] { |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 314 | // Post tasks from queue to guarantee, that 1st task won't be |
| 315 | // executed before the second one will be posted. |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 316 | queue->PostTask([&state] { state.state = 1; }); |
| 317 | queue->PostTask([&state, &done] { |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 318 | EXPECT_EQ(state.state, 1); |
| 319 | done.Set(); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 320 | }); |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 321 | // Check, that state changing tasks didn't start yet. |
| 322 | EXPECT_EQ(state.state, 0); |
Danil Chapovalov | 8feb6fd | 2022-07-05 11:01:27 +0200 | [diff] [blame] | 323 | }); |
Markus Handell | 2cfc1af | 2022-08-19 08:16:48 +0000 | [diff] [blame] | 324 | EXPECT_TRUE(done.Wait(TimeDelta::Seconds(1))); |
Artem Titov | 01f64e0 | 2019-01-31 13:31:09 +0100 | [diff] [blame] | 325 | } |
| 326 | |
Danil Chapovalov | 5ad16a5 | 2020-06-09 14:44:31 +0200 | [diff] [blame] | 327 | // TaskQueueTest is a set of tests for any implementation of the TaskQueueBase. |
| 328 | // Tests are instantiated next to the concrete implementation(s). |
| 329 | // https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#creating-value-parameterized-abstract-tests |
| 330 | GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(TaskQueueTest); |
| 331 | |
Danil Chapovalov | 33b716f | 2019-01-22 18:15:37 +0100 | [diff] [blame] | 332 | } // namespace |
| 333 | } // namespace webrtc |