Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2019 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #include "modules/pacing/pacing_controller.h" |
| 12 | |
| 13 | #include <algorithm> |
| 14 | #include <list> |
| 15 | #include <memory> |
| 16 | #include <string> |
| 17 | #include <utility> |
| 18 | #include <vector> |
| 19 | |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 20 | #include "api/transport/network_types.h" |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 21 | #include "api/units/data_rate.h" |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 22 | #include "api/units/time_delta.h" |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 23 | #include "modules/pacing/packet_router.h" |
| 24 | #include "system_wrappers/include/clock.h" |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 25 | #include "test/explicit_key_value_config.h" |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 26 | #include "test/gmock.h" |
| 27 | #include "test/gtest.h" |
| 28 | |
| 29 | using ::testing::_; |
| 30 | using ::testing::Field; |
| 31 | using ::testing::Pointee; |
| 32 | using ::testing::Property; |
| 33 | using ::testing::Return; |
Erik Språng | 1a08096 | 2022-03-17 15:16:59 +0100 | [diff] [blame] | 34 | using ::testing::WithoutArgs; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 35 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 36 | using ::webrtc::test::ExplicitKeyValueConfig; |
| 37 | |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 38 | namespace webrtc { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 39 | namespace { |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 40 | constexpr DataRate kFirstClusterRate = DataRate::KilobitsPerSec(900); |
| 41 | constexpr DataRate kSecondClusterRate = DataRate::KilobitsPerSec(1800); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 42 | |
| 43 | // The error stems from truncating the time interval of probe packets to integer |
| 44 | // values. This results in probing slightly higher than the target bitrate. |
| 45 | // For 1.8 Mbps, this comes to be about 120 kbps with 1200 probe packets. |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 46 | constexpr DataRate kProbingErrorMargin = DataRate::KilobitsPerSec(150); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 47 | |
| 48 | const float kPaceMultiplier = 2.5f; |
| 49 | |
| 50 | constexpr uint32_t kAudioSsrc = 12345; |
| 51 | constexpr uint32_t kVideoSsrc = 234565; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 52 | |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 53 | constexpr DataRate kTargetRate = DataRate::KilobitsPerSec(800); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 54 | |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 55 | std::unique_ptr<RtpPacketToSend> BuildPacket(RtpPacketMediaType type, |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 56 | uint32_t ssrc, |
| 57 | uint16_t sequence_number, |
| 58 | int64_t capture_time_ms, |
| 59 | size_t size) { |
Mirko Bonadei | 317a1f0 | 2019-09-17 17:06:18 +0200 | [diff] [blame] | 60 | auto packet = std::make_unique<RtpPacketToSend>(nullptr); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 61 | packet->set_packet_type(type); |
| 62 | packet->SetSsrc(ssrc); |
| 63 | packet->SetSequenceNumber(sequence_number); |
Danil Chapovalov | 9af4aa7 | 2022-02-27 21:10:55 +0000 | [diff] [blame] | 64 | packet->set_capture_time(Timestamp::Millis(capture_time_ms)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 65 | packet->SetPayloadSize(size); |
| 66 | return packet; |
| 67 | } |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 68 | |
| 69 | class MediaStream { |
| 70 | public: |
| 71 | MediaStream(SimulatedClock& clock, |
| 72 | RtpPacketMediaType type, |
| 73 | uint32_t ssrc, |
| 74 | size_t packet_size) |
| 75 | : clock_(clock), type_(type), ssrc_(ssrc), packet_size_(packet_size) {} |
| 76 | |
| 77 | std::unique_ptr<RtpPacketToSend> BuildNextPacket() { |
| 78 | return BuildPacket(type_, ssrc_, seq_num_++, clock_.TimeInMilliseconds(), |
| 79 | packet_size_); |
| 80 | } |
| 81 | std::unique_ptr<RtpPacketToSend> BuildNextPacket(size_t size) { |
| 82 | return BuildPacket(type_, ssrc_, seq_num_++, clock_.TimeInMilliseconds(), |
| 83 | size); |
| 84 | } |
| 85 | |
| 86 | private: |
| 87 | SimulatedClock& clock_; |
| 88 | const RtpPacketMediaType type_; |
| 89 | const uint32_t ssrc_; |
| 90 | const size_t packet_size_; |
| 91 | uint16_t seq_num_ = 1000; |
| 92 | }; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 93 | |
| 94 | // Mock callback proxy, where both new and old api redirects to common mock |
| 95 | // methods that focus on core aspects. |
| 96 | class MockPacingControllerCallback : public PacingController::PacketSender { |
| 97 | public: |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 +0000 | [diff] [blame] | 98 | void SendPacket(std::unique_ptr<RtpPacketToSend> packet, |
| 99 | const PacedPacketInfo& cluster_info) override { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 100 | SendPacket(packet->Ssrc(), packet->SequenceNumber(), |
Danil Chapovalov | 9af4aa7 | 2022-02-27 21:10:55 +0000 | [diff] [blame] | 101 | packet->capture_time().ms(), |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 102 | packet->packet_type() == RtpPacketMediaType::kRetransmission, |
| 103 | packet->packet_type() == RtpPacketMediaType::kPadding); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 104 | } |
| 105 | |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 106 | std::vector<std::unique_ptr<RtpPacketToSend>> GeneratePadding( |
| 107 | DataSize target_size) override { |
| 108 | std::vector<std::unique_ptr<RtpPacketToSend>> ret; |
| 109 | size_t padding_size = SendPadding(target_size.bytes()); |
| 110 | if (padding_size > 0) { |
Mirko Bonadei | 317a1f0 | 2019-09-17 17:06:18 +0200 | [diff] [blame] | 111 | auto packet = std::make_unique<RtpPacketToSend>(nullptr); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 112 | packet->SetPayloadSize(padding_size); |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 113 | packet->set_packet_type(RtpPacketMediaType::kPadding); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 114 | ret.emplace_back(std::move(packet)); |
| 115 | } |
| 116 | return ret; |
| 117 | } |
| 118 | |
Danil Chapovalov | 014197b | 2020-05-26 19:18:17 +0200 | [diff] [blame] | 119 | MOCK_METHOD(void, |
| 120 | SendPacket, |
| 121 | (uint32_t ssrc, |
| 122 | uint16_t sequence_number, |
| 123 | int64_t capture_timestamp, |
| 124 | bool retransmission, |
| 125 | bool padding)); |
Erik Språng | 1d50cb6 | 2020-07-02 17:41:32 +0200 | [diff] [blame] | 126 | MOCK_METHOD(std::vector<std::unique_ptr<RtpPacketToSend>>, |
| 127 | FetchFec, |
| 128 | (), |
| 129 | (override)); |
Danil Chapovalov | 014197b | 2020-05-26 19:18:17 +0200 | [diff] [blame] | 130 | MOCK_METHOD(size_t, SendPadding, (size_t target_size)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 131 | }; |
| 132 | |
| 133 | // Mock callback implementing the raw api. |
| 134 | class MockPacketSender : public PacingController::PacketSender { |
| 135 | public: |
Danil Chapovalov | 014197b | 2020-05-26 19:18:17 +0200 | [diff] [blame] | 136 | MOCK_METHOD(void, |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 +0000 | [diff] [blame] | 137 | SendPacket, |
Danil Chapovalov | 014197b | 2020-05-26 19:18:17 +0200 | [diff] [blame] | 138 | (std::unique_ptr<RtpPacketToSend> packet, |
| 139 | const PacedPacketInfo& cluster_info), |
| 140 | (override)); |
| 141 | MOCK_METHOD(std::vector<std::unique_ptr<RtpPacketToSend>>, |
Erik Språng | 1d50cb6 | 2020-07-02 17:41:32 +0200 | [diff] [blame] | 142 | FetchFec, |
| 143 | (), |
| 144 | (override)); |
| 145 | |
| 146 | MOCK_METHOD(std::vector<std::unique_ptr<RtpPacketToSend>>, |
Danil Chapovalov | 014197b | 2020-05-26 19:18:17 +0200 | [diff] [blame] | 147 | GeneratePadding, |
| 148 | (DataSize target_size), |
| 149 | (override)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 150 | }; |
| 151 | |
| 152 | class PacingControllerPadding : public PacingController::PacketSender { |
| 153 | public: |
| 154 | static const size_t kPaddingPacketSize = 224; |
| 155 | |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 156 | PacingControllerPadding() : padding_sent_(0), total_bytes_sent_(0) {} |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 157 | |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 +0000 | [diff] [blame] | 158 | void SendPacket(std::unique_ptr<RtpPacketToSend> packet, |
| 159 | const PacedPacketInfo& pacing_info) override { |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 160 | total_bytes_sent_ += packet->payload_size(); |
| 161 | } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 162 | |
Erik Språng | 1d50cb6 | 2020-07-02 17:41:32 +0200 | [diff] [blame] | 163 | std::vector<std::unique_ptr<RtpPacketToSend>> FetchFec() override { |
| 164 | return {}; |
| 165 | } |
| 166 | |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 167 | std::vector<std::unique_ptr<RtpPacketToSend>> GeneratePadding( |
| 168 | DataSize target_size) override { |
| 169 | size_t num_packets = |
| 170 | (target_size.bytes() + kPaddingPacketSize - 1) / kPaddingPacketSize; |
| 171 | std::vector<std::unique_ptr<RtpPacketToSend>> packets; |
| 172 | for (size_t i = 0; i < num_packets; ++i) { |
Mirko Bonadei | 317a1f0 | 2019-09-17 17:06:18 +0200 | [diff] [blame] | 173 | packets.emplace_back(std::make_unique<RtpPacketToSend>(nullptr)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 174 | packets.back()->SetPadding(kPaddingPacketSize); |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 175 | packets.back()->set_packet_type(RtpPacketMediaType::kPadding); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 176 | padding_sent_ += kPaddingPacketSize; |
| 177 | } |
| 178 | return packets; |
| 179 | } |
| 180 | |
| 181 | size_t padding_sent() { return padding_sent_; } |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 182 | size_t total_bytes_sent() { return total_bytes_sent_; } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 183 | |
| 184 | private: |
| 185 | size_t padding_sent_; |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 186 | size_t total_bytes_sent_; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 187 | }; |
| 188 | |
| 189 | class PacingControllerProbing : public PacingController::PacketSender { |
| 190 | public: |
| 191 | PacingControllerProbing() : packets_sent_(0), padding_sent_(0) {} |
| 192 | |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 +0000 | [diff] [blame] | 193 | void SendPacket(std::unique_ptr<RtpPacketToSend> packet, |
| 194 | const PacedPacketInfo& pacing_info) override { |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 195 | if (packet->packet_type() != RtpPacketMediaType::kPadding) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 196 | ++packets_sent_; |
| 197 | } |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 198 | last_pacing_info_ = pacing_info; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 199 | } |
| 200 | |
Erik Språng | 1d50cb6 | 2020-07-02 17:41:32 +0200 | [diff] [blame] | 201 | std::vector<std::unique_ptr<RtpPacketToSend>> FetchFec() override { |
| 202 | return {}; |
| 203 | } |
| 204 | |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 205 | std::vector<std::unique_ptr<RtpPacketToSend>> GeneratePadding( |
| 206 | DataSize target_size) override { |
Erik Språng | b210eeb | 2019-11-05 11:21:48 +0100 | [diff] [blame] | 207 | // From RTPSender: |
| 208 | // Max in the RFC 3550 is 255 bytes, we limit it to be modulus 32 for SRTP. |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 209 | const DataSize kMaxPadding = DataSize::Bytes(224); |
Erik Språng | b210eeb | 2019-11-05 11:21:48 +0100 | [diff] [blame] | 210 | |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 211 | std::vector<std::unique_ptr<RtpPacketToSend>> packets; |
Erik Språng | b210eeb | 2019-11-05 11:21:48 +0100 | [diff] [blame] | 212 | while (target_size > DataSize::Zero()) { |
| 213 | DataSize padding_size = std::min(kMaxPadding, target_size); |
| 214 | packets.emplace_back(std::make_unique<RtpPacketToSend>(nullptr)); |
| 215 | packets.back()->SetPadding(padding_size.bytes()); |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 216 | packets.back()->set_packet_type(RtpPacketMediaType::kPadding); |
Erik Språng | b210eeb | 2019-11-05 11:21:48 +0100 | [diff] [blame] | 217 | padding_sent_ += padding_size.bytes(); |
| 218 | target_size -= padding_size; |
| 219 | } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 220 | return packets; |
| 221 | } |
| 222 | |
| 223 | int packets_sent() const { return packets_sent_; } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 224 | int padding_sent() const { return padding_sent_; } |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 225 | int total_packets_sent() const { return packets_sent_ + padding_sent_; } |
| 226 | PacedPacketInfo last_pacing_info() const { return last_pacing_info_; } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 227 | |
| 228 | private: |
| 229 | int packets_sent_; |
| 230 | int padding_sent_; |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 231 | PacedPacketInfo last_pacing_info_; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 232 | }; |
| 233 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 234 | class PacingControllerTest : public ::testing::Test { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 235 | protected: |
Erik Språng | e486a7b | 2022-03-15 15:13:25 +0100 | [diff] [blame] | 236 | PacingControllerTest() : clock_(123456), trials_("") {} |
Erik Språng | 9acc18d | 2020-04-16 19:41:07 +0200 | [diff] [blame] | 237 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 238 | void SendAndExpectPacket(PacingController* pacer, |
| 239 | RtpPacketMediaType type, |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 240 | uint32_t ssrc, |
| 241 | uint16_t sequence_number, |
| 242 | int64_t capture_time_ms, |
| 243 | size_t size) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 244 | pacer->EnqueuePacket( |
| 245 | BuildPacket(type, ssrc, sequence_number, capture_time_ms, size)); |
| 246 | |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 247 | EXPECT_CALL(callback_, |
| 248 | SendPacket(ssrc, sequence_number, capture_time_ms, |
Erik Språng | 41bbc3d | 2021-10-05 10:17:39 +0200 | [diff] [blame] | 249 | type == RtpPacketMediaType::kRetransmission, false)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 250 | } |
| 251 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 252 | void AdvanceTimeUntil(webrtc::Timestamp time) { |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 253 | Timestamp now = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 254 | clock_.AdvanceTime(std::max(TimeDelta::Zero(), time - now)); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 255 | } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 256 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 257 | void ConsumeInitialBudget(PacingController* pacer) { |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 258 | const uint32_t kSsrc = 54321; |
| 259 | uint16_t sequence_number = 1234; |
| 260 | int64_t capture_time_ms = clock_.TimeInMilliseconds(); |
| 261 | const size_t kPacketSize = 250; |
| 262 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 263 | EXPECT_TRUE(pacer->OldestPacketEnqueueTime().IsInfinite()); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 264 | |
| 265 | // Due to the multiplicative factor we can send 5 packets during a send |
| 266 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 267 | // (packet size * #send intervals per second) |
| 268 | const size_t packets_to_send_per_interval = |
| 269 | kTargetRate.bps() * kPaceMultiplier / (8 * kPacketSize * 200); |
| 270 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 271 | SendAndExpectPacket(pacer, RtpPacketMediaType::kVideo, kSsrc, |
| 272 | sequence_number++, capture_time_ms, kPacketSize); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 273 | } |
| 274 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 275 | while (pacer->QueueSizePackets() > 0) { |
| 276 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 277 | pacer->ProcessPackets(); |
| 278 | } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 279 | } |
| 280 | |
| 281 | SimulatedClock clock_; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 282 | |
| 283 | MediaStream audio_ = MediaStream(clock_, |
| 284 | /*type*/ RtpPacketMediaType::kAudio, |
| 285 | /*ssrc*/ kAudioSsrc, |
| 286 | /*packet_size*/ 100); |
| 287 | MediaStream video_ = MediaStream(clock_, |
| 288 | /*type*/ RtpPacketMediaType::kVideo, |
| 289 | /*ssrc*/ kVideoSsrc, |
| 290 | /*packet_size*/ 1000); |
| 291 | |
Erik Språng | 1d50cb6 | 2020-07-02 17:41:32 +0200 | [diff] [blame] | 292 | ::testing::NiceMock<MockPacingControllerCallback> callback_; |
Erik Språng | e486a7b | 2022-03-15 15:13:25 +0100 | [diff] [blame] | 293 | ExplicitKeyValueConfig trials_; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 294 | }; |
| 295 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 296 | TEST_F(PacingControllerTest, DefaultNoPaddingInSilence) { |
Erik Språng | e486a7b | 2022-03-15 15:13:25 +0100 | [diff] [blame] | 297 | const test::ExplicitKeyValueConfig trials(""); |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 298 | PacingController pacer(&clock_, &callback_, trials); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 299 | pacer.SetPacingRates(kTargetRate, DataRate::Zero()); |
| 300 | // Video packet to reset last send time and provide padding data. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 301 | pacer.EnqueuePacket(video_.BuildNextPacket()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 302 | EXPECT_CALL(callback_, SendPacket).Times(1); |
| 303 | clock_.AdvanceTimeMilliseconds(5); |
| 304 | pacer.ProcessPackets(); |
| 305 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 306 | // Waiting 500 ms should not trigger sending of padding. |
| 307 | clock_.AdvanceTimeMilliseconds(500); |
| 308 | pacer.ProcessPackets(); |
| 309 | } |
| 310 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 311 | TEST_F(PacingControllerTest, PaddingInSilenceWithTrial) { |
Erik Språng | e486a7b | 2022-03-15 15:13:25 +0100 | [diff] [blame] | 312 | const test::ExplicitKeyValueConfig trials( |
| 313 | "WebRTC-Pacer-PadInSilence/Enabled/"); |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 314 | PacingController pacer(&clock_, &callback_, trials); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 315 | pacer.SetPacingRates(kTargetRate, DataRate::Zero()); |
| 316 | // Video packet to reset last send time and provide padding data. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 317 | pacer.EnqueuePacket(video_.BuildNextPacket()); |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 318 | EXPECT_CALL(callback_, SendPacket).Times(2); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 319 | clock_.AdvanceTimeMilliseconds(5); |
| 320 | pacer.ProcessPackets(); |
| 321 | EXPECT_CALL(callback_, SendPadding).WillOnce(Return(1000)); |
| 322 | // Waiting 500 ms should trigger sending of padding. |
| 323 | clock_.AdvanceTimeMilliseconds(500); |
| 324 | pacer.ProcessPackets(); |
| 325 | } |
| 326 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 327 | TEST_F(PacingControllerTest, CongestionWindowAffectsAudioInTrial) { |
Erik Språng | e486a7b | 2022-03-15 15:13:25 +0100 | [diff] [blame] | 328 | const test::ExplicitKeyValueConfig trials("WebRTC-Pacer-BlockAudio/Enabled/"); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 329 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 330 | PacingController pacer(&clock_, &callback_, trials); |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 331 | pacer.SetPacingRates(DataRate::KilobitsPerSec(10000), DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 332 | // Video packet fills congestion window. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 333 | pacer.EnqueuePacket(video_.BuildNextPacket()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 334 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 335 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 336 | pacer.ProcessPackets(); |
Erik Språng | 6673437 | 2022-03-16 14:20:49 +0100 | [diff] [blame] | 337 | pacer.SetCongested(true); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 338 | // Audio packet blocked due to congestion. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 339 | pacer.EnqueuePacket(audio_.BuildNextPacket()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 340 | EXPECT_CALL(callback_, SendPacket).Times(0); |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 341 | // Forward time to where we send keep-alive. |
| 342 | EXPECT_CALL(callback_, SendPadding(1)).Times(2); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 343 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 344 | pacer.ProcessPackets(); |
| 345 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 346 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 347 | // Audio packet unblocked when congestion window clear. |
| 348 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
Erik Språng | 6673437 | 2022-03-16 14:20:49 +0100 | [diff] [blame] | 349 | pacer.SetCongested(false); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 350 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 351 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 352 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 353 | } |
| 354 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 355 | TEST_F(PacingControllerTest, DefaultCongestionWindowDoesNotAffectAudio) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 356 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Erik Språng | e486a7b | 2022-03-15 15:13:25 +0100 | [diff] [blame] | 357 | const test::ExplicitKeyValueConfig trials(""); |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 358 | PacingController pacer(&clock_, &callback_, trials); |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 359 | pacer.SetPacingRates(DataRate::BitsPerSec(10000000), DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 360 | // Video packet fills congestion window. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 361 | pacer.EnqueuePacket(video_.BuildNextPacket()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 362 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 363 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 364 | pacer.ProcessPackets(); |
Erik Språng | 6673437 | 2022-03-16 14:20:49 +0100 | [diff] [blame] | 365 | pacer.SetCongested(true); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 366 | // Audio not blocked due to congestion. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 367 | pacer.EnqueuePacket(audio_.BuildNextPacket()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 368 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 369 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 370 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 371 | } |
| 372 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 373 | TEST_F(PacingControllerTest, BudgetAffectsAudioInTrial) { |
Erik Språng | e486a7b | 2022-03-15 15:13:25 +0100 | [diff] [blame] | 374 | ExplicitKeyValueConfig trials("WebRTC-Pacer-BlockAudio/Enabled/"); |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 375 | PacingController pacer(&clock_, &callback_, trials); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 376 | const size_t kPacketSize = 1000; |
| 377 | const int kProcessIntervalsPerSecond = 1000 / 5; |
| 378 | DataRate pacing_rate = |
| 379 | DataRate::BitsPerSec(kPacketSize / 3 * 8 * kProcessIntervalsPerSecond); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 380 | pacer.SetPacingRates(pacing_rate, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 381 | // Video fills budget for following process periods. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 382 | pacer.EnqueuePacket(video_.BuildNextPacket(kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 383 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 384 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 385 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 386 | // Audio packet blocked due to budget limit. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 387 | pacer.EnqueuePacket(audio_.BuildNextPacket()); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 388 | Timestamp wait_start_time = clock_.CurrentTime(); |
| 389 | Timestamp wait_end_time = Timestamp::MinusInfinity(); |
Erik Språng | 1a08096 | 2022-03-17 15:16:59 +0100 | [diff] [blame] | 390 | EXPECT_CALL(callback_, SendPacket).WillOnce(WithoutArgs([&]() { |
| 391 | wait_end_time = clock_.CurrentTime(); |
| 392 | })); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 393 | while (!wait_end_time.IsFinite()) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 394 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 395 | pacer.ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 396 | } |
| 397 | const TimeDelta expected_wait_time = |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 398 | DataSize::Bytes(kPacketSize) / pacing_rate; |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 399 | // Verify delay is near expectation, within timing margin. |
| 400 | EXPECT_LT(((wait_end_time - wait_start_time) - expected_wait_time).Abs(), |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 401 | PacingController::kMinSleepTime); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 402 | } |
| 403 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 404 | TEST_F(PacingControllerTest, DefaultBudgetDoesNotAffectAudio) { |
| 405 | const size_t kPacketSize = 1000; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 406 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Erik Språng | e486a7b | 2022-03-15 15:13:25 +0100 | [diff] [blame] | 407 | const test::ExplicitKeyValueConfig trials(""); |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 408 | PacingController pacer(&clock_, &callback_, trials); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 409 | const int kProcessIntervalsPerSecond = 1000 / 5; |
| 410 | pacer.SetPacingRates( |
| 411 | DataRate::BitsPerSec(kPacketSize / 3 * 8 * kProcessIntervalsPerSecond), |
| 412 | DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 413 | // Video fills budget for following process periods. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 414 | pacer.EnqueuePacket(video_.BuildNextPacket(kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 415 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 416 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 417 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 418 | // Audio packet not blocked due to budget limit. |
| 419 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 420 | pacer.EnqueuePacket(audio_.BuildNextPacket()); |
| 421 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 422 | pacer.ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 423 | } |
| 424 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 425 | TEST_F(PacingControllerTest, FirstSentPacketTimeIsSet) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 426 | const Timestamp kStartTime = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 427 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 428 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 429 | |
| 430 | // No packet sent. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 431 | EXPECT_FALSE(pacer->FirstSentPacketTime().has_value()); |
| 432 | pacer->EnqueuePacket(video_.BuildNextPacket()); |
| 433 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 434 | pacer->ProcessPackets(); |
| 435 | EXPECT_EQ(kStartTime, pacer->FirstSentPacketTime()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 436 | } |
| 437 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 438 | TEST_F(PacingControllerTest, QueueAndPacePackets) { |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 439 | const uint32_t kSsrc = 12345; |
| 440 | uint16_t sequence_number = 1234; |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 441 | const DataSize kPackeSize = DataSize::Bytes(250); |
Danil Chapovalov | 5528402 | 2020-02-07 14:53:52 +0100 | [diff] [blame] | 442 | const TimeDelta kSendInterval = TimeDelta::Millis(5); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 443 | |
| 444 | // Due to the multiplicative factor we can send 5 packets during a 5ms send |
| 445 | // interval. (send interval * network capacity * multiplier / packet size) |
| 446 | const size_t kPacketsToSend = (kSendInterval * kTargetRate).bytes() * |
| 447 | kPaceMultiplier / kPackeSize.bytes(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 448 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 449 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 450 | |
| 451 | for (size_t i = 0; i < kPacketsToSend; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 452 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, kSsrc, |
| 453 | sequence_number++, clock_.TimeInMilliseconds(), |
| 454 | kPackeSize.bytes()); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 455 | } |
| 456 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 457 | |
| 458 | // Enqueue one extra packet. |
| 459 | int64_t queued_packet_timestamp = clock_.TimeInMilliseconds(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 460 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, kSsrc, |
| 461 | sequence_number, queued_packet_timestamp, |
| 462 | kPackeSize.bytes())); |
| 463 | EXPECT_EQ(kPacketsToSend + 1, pacer->QueueSizePackets()); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 464 | |
| 465 | // Send packets until the initial kPacketsToSend packets are done. |
| 466 | Timestamp start_time = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 467 | while (pacer->QueueSizePackets() > 1) { |
| 468 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 469 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 470 | } |
| 471 | EXPECT_LT(clock_.CurrentTime() - start_time, kSendInterval); |
| 472 | |
| 473 | // Proceed till last packet can be sent. |
| 474 | EXPECT_CALL(callback_, SendPacket(kSsrc, sequence_number, |
| 475 | queued_packet_timestamp, false, false)) |
| 476 | .Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 477 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 478 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 479 | EXPECT_GE(clock_.CurrentTime() - start_time, kSendInterval); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 480 | EXPECT_EQ(pacer->QueueSizePackets(), 0u); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 481 | } |
| 482 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 483 | TEST_F(PacingControllerTest, PaceQueuedPackets) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 484 | uint32_t ssrc = 12345; |
| 485 | uint16_t sequence_number = 1234; |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 486 | const size_t kPacketSize = 250; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 487 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 488 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 489 | |
| 490 | // Due to the multiplicative factor we can send 5 packets during a send |
| 491 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 492 | // (packet size * #send intervals per second) |
| 493 | const size_t packets_to_send_per_interval = |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 494 | kTargetRate.bps() * kPaceMultiplier / (8 * kPacketSize * 200); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 495 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 496 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 497 | sequence_number++, clock_.TimeInMilliseconds(), |
| 498 | kPacketSize); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 499 | } |
| 500 | |
| 501 | for (size_t j = 0; j < packets_to_send_per_interval * 10; ++j) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 502 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 503 | sequence_number++, |
| 504 | clock_.TimeInMilliseconds(), kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 505 | } |
| 506 | EXPECT_EQ(packets_to_send_per_interval + packets_to_send_per_interval * 10, |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 507 | pacer->QueueSizePackets()); |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 508 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 509 | while (pacer->QueueSizePackets() > packets_to_send_per_interval * 10) { |
| 510 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 511 | pacer->ProcessPackets(); |
| 512 | } |
| 513 | EXPECT_EQ(pacer->QueueSizePackets(), packets_to_send_per_interval * 10); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 514 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 515 | |
| 516 | EXPECT_CALL(callback_, SendPacket(ssrc, _, _, false, false)) |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 517 | .Times(pacer->QueueSizePackets()); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 518 | const TimeDelta expected_pace_time = |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 519 | DataSize::Bytes(pacer->QueueSizePackets() * kPacketSize) / |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 520 | (kPaceMultiplier * kTargetRate); |
| 521 | Timestamp start_time = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 522 | while (pacer->QueueSizePackets() > 0) { |
| 523 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 524 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 525 | } |
| 526 | const TimeDelta actual_pace_time = clock_.CurrentTime() - start_time; |
Danil Chapovalov | 5528402 | 2020-02-07 14:53:52 +0100 | [diff] [blame] | 527 | EXPECT_LT((actual_pace_time - expected_pace_time).Abs(), |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 528 | PacingController::kMinSleepTime); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 529 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 530 | EXPECT_EQ(0u, pacer->QueueSizePackets()); |
| 531 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 532 | EXPECT_EQ(0u, pacer->QueueSizePackets()); |
| 533 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 534 | |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 535 | // Send some more packet, just show that we can..? |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 536 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 537 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 538 | sequence_number++, clock_.TimeInMilliseconds(), 250); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 539 | } |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 540 | EXPECT_EQ(packets_to_send_per_interval, pacer->QueueSizePackets()); |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 541 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 542 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 543 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 544 | } |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 545 | EXPECT_EQ(0u, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 546 | } |
| 547 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 548 | TEST_F(PacingControllerTest, RepeatedRetransmissionsAllowed) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 549 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 550 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
| 551 | |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 552 | // Send one packet, then two retransmissions of that packet. |
| 553 | for (size_t i = 0; i < 3; i++) { |
| 554 | constexpr uint32_t ssrc = 333; |
| 555 | constexpr uint16_t sequence_number = 444; |
| 556 | constexpr size_t bytes = 250; |
| 557 | bool is_retransmission = (i != 0); // Original followed by retransmissions. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 558 | SendAndExpectPacket(pacer.get(), |
| 559 | is_retransmission ? RtpPacketMediaType::kRetransmission |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 560 | : RtpPacketMediaType::kVideo, |
| 561 | ssrc, sequence_number, clock_.TimeInMilliseconds(), |
| 562 | bytes); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 563 | clock_.AdvanceTimeMilliseconds(5); |
| 564 | } |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 565 | while (pacer->QueueSizePackets() > 0) { |
| 566 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 567 | pacer->ProcessPackets(); |
| 568 | } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 569 | } |
| 570 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 571 | TEST_F(PacingControllerTest, |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 572 | CanQueuePacketsWithSameSequenceNumberOnDifferentSsrcs) { |
| 573 | uint32_t ssrc = 12345; |
| 574 | uint16_t sequence_number = 1234; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 575 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 576 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 577 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 578 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 579 | sequence_number, clock_.TimeInMilliseconds(), 250); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 580 | |
| 581 | // Expect packet on second ssrc to be queued and sent as well. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 582 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc + 1, |
| 583 | sequence_number, clock_.TimeInMilliseconds(), 250); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 584 | |
| 585 | clock_.AdvanceTimeMilliseconds(1000); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 586 | while (pacer->QueueSizePackets() > 0) { |
| 587 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 588 | pacer->ProcessPackets(); |
| 589 | } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 590 | } |
| 591 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 592 | TEST_F(PacingControllerTest, Padding) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 593 | uint32_t ssrc = 12345; |
| 594 | uint16_t sequence_number = 1234; |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 595 | const size_t kPacketSize = 250; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 596 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 597 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 598 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 599 | const size_t kPacketsToSend = 20; |
| 600 | for (size_t i = 0; i < kPacketsToSend; ++i) { |
| 601 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 602 | sequence_number++, clock_.TimeInMilliseconds(), |
| 603 | kPacketSize); |
| 604 | } |
| 605 | const TimeDelta expected_pace_time = |
| 606 | DataSize::Bytes(pacer->QueueSizePackets() * kPacketSize) / |
| 607 | (kPaceMultiplier * kTargetRate); |
| 608 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 609 | // Only the media packets should be sent. |
| 610 | Timestamp start_time = clock_.CurrentTime(); |
| 611 | while (pacer->QueueSizePackets() > 0) { |
| 612 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 613 | pacer->ProcessPackets(); |
| 614 | } |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 615 | const TimeDelta actual_pace_time = clock_.CurrentTime() - start_time; |
| 616 | EXPECT_LE((actual_pace_time - expected_pace_time).Abs(), |
| 617 | PacingController::kMinSleepTime); |
| 618 | |
Erik Språng | b1ccae2 | 2019-11-25 18:22:09 +0100 | [diff] [blame] | 619 | // Pacing media happens at 2.5x, but padding was configured with 1.0x |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 620 | // factor. We have to wait until the padding debt is gone before we start |
| 621 | // sending padding. |
| 622 | const TimeDelta time_to_padding_debt_free = |
| 623 | (expected_pace_time * kPaceMultiplier) - actual_pace_time; |
Erik Språng | b1ccae2 | 2019-11-25 18:22:09 +0100 | [diff] [blame] | 624 | clock_.AdvanceTime(time_to_padding_debt_free - |
| 625 | PacingController::kMinSleepTime); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 626 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 627 | |
| 628 | // Send 10 padding packets. |
| 629 | const size_t kPaddingPacketsToSend = 10; |
| 630 | DataSize padding_sent = DataSize::Zero(); |
Erik Språng | b1ccae2 | 2019-11-25 18:22:09 +0100 | [diff] [blame] | 631 | size_t packets_sent = 0; |
| 632 | Timestamp first_send_time = Timestamp::MinusInfinity(); |
| 633 | Timestamp last_send_time = Timestamp::MinusInfinity(); |
| 634 | |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 635 | EXPECT_CALL(callback_, SendPadding) |
| 636 | .Times(kPaddingPacketsToSend) |
| 637 | .WillRepeatedly([&](size_t target_size) { |
Erik Språng | b1ccae2 | 2019-11-25 18:22:09 +0100 | [diff] [blame] | 638 | ++packets_sent; |
| 639 | if (packets_sent < kPaddingPacketsToSend) { |
| 640 | // Don't count bytes of last packet, instead just |
| 641 | // use this as the time the last packet finished |
| 642 | // sending. |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 643 | padding_sent += DataSize::Bytes(target_size); |
Erik Språng | b1ccae2 | 2019-11-25 18:22:09 +0100 | [diff] [blame] | 644 | } |
| 645 | if (first_send_time.IsInfinite()) { |
| 646 | first_send_time = clock_.CurrentTime(); |
| 647 | } else { |
| 648 | last_send_time = clock_.CurrentTime(); |
| 649 | } |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 650 | return target_size; |
| 651 | }); |
| 652 | EXPECT_CALL(callback_, SendPacket(_, _, _, false, true)) |
| 653 | .Times(kPaddingPacketsToSend); |
Erik Språng | b1ccae2 | 2019-11-25 18:22:09 +0100 | [diff] [blame] | 654 | |
| 655 | while (packets_sent < kPaddingPacketsToSend) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 656 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 657 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 658 | } |
| 659 | |
| 660 | // Verify rate of sent padding. |
Erik Språng | b1ccae2 | 2019-11-25 18:22:09 +0100 | [diff] [blame] | 661 | TimeDelta padding_duration = last_send_time - first_send_time; |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 662 | DataRate padding_rate = padding_sent / padding_duration; |
| 663 | EXPECT_EQ(padding_rate, kTargetRate); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 664 | } |
| 665 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 666 | TEST_F(PacingControllerTest, NoPaddingBeforeNormalPacket) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 667 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 668 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 669 | |
| 670 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 671 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 672 | pacer->ProcessPackets(); |
| 673 | AdvanceTimeUntil(pacer->NextSendTime()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 674 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 675 | pacer->ProcessPackets(); |
| 676 | AdvanceTimeUntil(pacer->NextSendTime()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 677 | |
| 678 | uint32_t ssrc = 12345; |
| 679 | uint16_t sequence_number = 1234; |
| 680 | int64_t capture_time_ms = 56789; |
| 681 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 682 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 683 | sequence_number++, capture_time_ms, 250); |
Erik Språng | b1ccae2 | 2019-11-25 18:22:09 +0100 | [diff] [blame] | 684 | bool padding_sent = false; |
| 685 | EXPECT_CALL(callback_, SendPadding).WillOnce([&](size_t padding) { |
| 686 | padding_sent = true; |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 687 | return padding; |
| 688 | }); |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 689 | EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1); |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 690 | while (!padding_sent) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 691 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 692 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 693 | } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 694 | } |
| 695 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 696 | TEST_F(PacingControllerTest, VerifyAverageBitrateVaryingMediaPayload) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 697 | uint32_t ssrc = 12345; |
| 698 | uint16_t sequence_number = 1234; |
| 699 | int64_t capture_time_ms = 56789; |
Danil Chapovalov | 5528402 | 2020-02-07 14:53:52 +0100 | [diff] [blame] | 700 | const TimeDelta kAveragingWindowLength = TimeDelta::Seconds(10); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 701 | PacingControllerPadding callback; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 702 | auto pacer = std::make_unique<PacingController>(&clock_, &callback, trials_); |
| 703 | pacer->SetProbingEnabled(false); |
| 704 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 705 | |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 706 | Timestamp start_time = clock_.CurrentTime(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 707 | size_t media_bytes = 0; |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 708 | while (clock_.CurrentTime() - start_time < kAveragingWindowLength) { |
| 709 | // Maybe add some new media packets corresponding to expected send rate. |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 710 | int rand_value = rand(); // NOLINT (rand_r instead of rand) |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 711 | while ( |
| 712 | media_bytes < |
| 713 | (kTargetRate * (clock_.CurrentTime() - start_time)).bytes<size_t>()) { |
| 714 | size_t media_payload = rand_value % 400 + 800; // [400, 1200] bytes. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 715 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 716 | sequence_number++, capture_time_ms, |
| 717 | media_payload)); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 718 | media_bytes += media_payload; |
| 719 | } |
| 720 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 721 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 722 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 723 | } |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 724 | |
| 725 | EXPECT_NEAR( |
| 726 | kTargetRate.bps(), |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 727 | (DataSize::Bytes(callback.total_bytes_sent()) / kAveragingWindowLength) |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 728 | .bps(), |
| 729 | (kTargetRate * 0.01 /* 1% error marging */).bps()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 730 | } |
| 731 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 732 | TEST_F(PacingControllerTest, Priority) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 733 | uint32_t ssrc_low_priority = 12345; |
| 734 | uint32_t ssrc = 12346; |
| 735 | uint16_t sequence_number = 1234; |
| 736 | int64_t capture_time_ms = 56789; |
| 737 | int64_t capture_time_ms_low_priority = 1234567; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 738 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 739 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 740 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 741 | ConsumeInitialBudget(pacer.get()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 742 | |
| 743 | // Expect normal and low priority to be queued and high to pass through. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 744 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, |
| 745 | ssrc_low_priority, sequence_number++, |
| 746 | capture_time_ms_low_priority, 250)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 747 | |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 748 | const size_t packets_to_send_per_interval = |
| 749 | kTargetRate.bps() * kPaceMultiplier / (8 * 250 * 200); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 750 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 751 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kRetransmission, ssrc, |
| 752 | sequence_number++, capture_time_ms, 250)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 753 | } |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 754 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kAudio, ssrc, |
| 755 | sequence_number++, capture_time_ms, 250)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 756 | |
| 757 | // Expect all high and normal priority to be sent out first. |
| 758 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 759 | EXPECT_CALL(callback_, SendPacket(ssrc, _, capture_time_ms, _, _)) |
| 760 | .Times(packets_to_send_per_interval + 1); |
| 761 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 762 | while (pacer->QueueSizePackets() > 1) { |
| 763 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 764 | pacer->ProcessPackets(); |
| 765 | } |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 766 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 767 | EXPECT_EQ(1u, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 768 | |
| 769 | EXPECT_CALL(callback_, SendPacket(ssrc_low_priority, _, |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 770 | capture_time_ms_low_priority, _, _)); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 771 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 772 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 773 | } |
| 774 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 775 | TEST_F(PacingControllerTest, RetransmissionPriority) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 776 | uint32_t ssrc = 12345; |
| 777 | uint16_t sequence_number = 1234; |
| 778 | int64_t capture_time_ms = 45678; |
| 779 | int64_t capture_time_ms_retransmission = 56789; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 780 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 781 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 782 | |
| 783 | // Due to the multiplicative factor we can send 5 packets during a send |
| 784 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 785 | // (packet size * #send intervals per second) |
| 786 | const size_t packets_to_send_per_interval = |
| 787 | kTargetRate.bps() * kPaceMultiplier / (8 * 250 * 200); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 788 | pacer->ProcessPackets(); |
| 789 | EXPECT_EQ(0u, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 790 | |
| 791 | // Alternate retransmissions and normal packets. |
| 792 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 793 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 794 | sequence_number++, capture_time_ms, 250)); |
| 795 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kRetransmission, ssrc, |
| 796 | sequence_number++, |
| 797 | capture_time_ms_retransmission, 250)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 798 | } |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 799 | EXPECT_EQ(2 * packets_to_send_per_interval, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 800 | |
| 801 | // Expect all retransmissions to be sent out first despite having a later |
| 802 | // capture time. |
| 803 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 804 | EXPECT_CALL(callback_, SendPacket(_, _, _, false, _)).Times(0); |
| 805 | EXPECT_CALL(callback_, |
| 806 | SendPacket(ssrc, _, capture_time_ms_retransmission, true, _)) |
| 807 | .Times(packets_to_send_per_interval); |
| 808 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 809 | while (pacer->QueueSizePackets() > packets_to_send_per_interval) { |
| 810 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 811 | pacer->ProcessPackets(); |
| 812 | } |
| 813 | EXPECT_EQ(packets_to_send_per_interval, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 814 | |
| 815 | // Expect the remaining (non-retransmission) packets to be sent. |
| 816 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 817 | EXPECT_CALL(callback_, SendPacket(_, _, _, true, _)).Times(0); |
| 818 | EXPECT_CALL(callback_, SendPacket(ssrc, _, capture_time_ms, false, _)) |
| 819 | .Times(packets_to_send_per_interval); |
| 820 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 821 | while (pacer->QueueSizePackets() > 0) { |
| 822 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 823 | pacer->ProcessPackets(); |
| 824 | } |
| 825 | EXPECT_EQ(0u, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 826 | } |
| 827 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 828 | TEST_F(PacingControllerTest, HighPrioDoesntAffectBudget) { |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 829 | const size_t kPacketSize = 250; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 830 | uint32_t ssrc = 12346; |
| 831 | uint16_t sequence_number = 1234; |
| 832 | int64_t capture_time_ms = 56789; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 833 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 834 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 835 | |
| 836 | // As high prio packets doesn't affect the budget, we should be able to send |
| 837 | // a high number of them at once. |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 838 | const size_t kNumAudioPackets = 25; |
| 839 | for (size_t i = 0; i < kNumAudioPackets; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 840 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kAudio, ssrc, |
| 841 | sequence_number++, capture_time_ms, kPacketSize); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 842 | } |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 843 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 844 | // Low prio packets does affect the budget. |
| 845 | // Due to the multiplicative factor we can send 5 packets during a send |
| 846 | // interval. (network capacity * multiplier / (8 bits per byte * |
| 847 | // (packet size * #send intervals per second) |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 848 | const size_t kPacketsToSendPerInterval = |
| 849 | kTargetRate.bps() * kPaceMultiplier / (8 * kPacketSize * 200); |
| 850 | for (size_t i = 0; i < kPacketsToSendPerInterval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 851 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 852 | sequence_number++, clock_.TimeInMilliseconds(), |
| 853 | kPacketSize); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 854 | } |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 855 | |
| 856 | // Send all packets and measure pace time. |
| 857 | Timestamp start_time = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 858 | while (pacer->QueueSizePackets() > 0) { |
| 859 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 860 | pacer->ProcessPackets(); |
| 861 | } |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 862 | |
| 863 | // Measure pacing time. Expect only low-prio packets to affect this. |
| 864 | TimeDelta pacing_time = clock_.CurrentTime() - start_time; |
| 865 | TimeDelta expected_pacing_time = |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 866 | DataSize::Bytes(kPacketsToSendPerInterval * kPacketSize) / |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 867 | (kTargetRate * kPaceMultiplier); |
| 868 | EXPECT_NEAR(pacing_time.us<double>(), expected_pacing_time.us<double>(), |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 869 | PacingController::kMinSleepTime.us<double>()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 870 | } |
| 871 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 872 | TEST_F(PacingControllerTest, SendsOnlyPaddingWhenCongested) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 873 | uint32_t ssrc = 202020; |
| 874 | uint16_t sequence_number = 1000; |
| 875 | int kPacketSize = 250; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 876 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 877 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 878 | |
Erik Språng | 6673437 | 2022-03-16 14:20:49 +0100 | [diff] [blame] | 879 | // Send an initial packet so we have a last send time. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 880 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 881 | sequence_number++, clock_.TimeInMilliseconds(), |
| 882 | kPacketSize); |
| 883 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 884 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 885 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
Erik Språng | 6673437 | 2022-03-16 14:20:49 +0100 | [diff] [blame] | 886 | |
| 887 | // Set congested state, we should not send anything until the 500ms since |
| 888 | // last send time limit for keep-alives is triggered. |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 889 | EXPECT_CALL(callback_, SendPacket).Times(0); |
| 890 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 891 | pacer->SetCongested(true); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 892 | size_t blocked_packets = 0; |
| 893 | int64_t expected_time_until_padding = 500; |
| 894 | while (expected_time_until_padding > 5) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 895 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 896 | sequence_number++, |
| 897 | clock_.TimeInMilliseconds(), kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 898 | blocked_packets++; |
| 899 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 900 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 901 | expected_time_until_padding -= 5; |
| 902 | } |
Erik Språng | 6673437 | 2022-03-16 14:20:49 +0100 | [diff] [blame] | 903 | |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 904 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 905 | EXPECT_CALL(callback_, SendPadding(1)).WillOnce(Return(1)); |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 906 | EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 907 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 908 | pacer->ProcessPackets(); |
| 909 | EXPECT_EQ(blocked_packets, pacer->QueueSizePackets()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 910 | } |
| 911 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 912 | TEST_F(PacingControllerTest, DoesNotAllowOveruseAfterCongestion) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 913 | uint32_t ssrc = 202020; |
| 914 | uint16_t seq_num = 1000; |
| 915 | int size = 1000; |
| 916 | auto now_ms = [this] { return clock_.TimeInMilliseconds(); }; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 917 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 918 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 919 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 920 | // The pacing rate is low enough that the budget should not allow two packets |
| 921 | // to be sent in a row. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 922 | pacer->SetPacingRates(DataRate::BitsPerSec(400 * 8 * 1000 / 5), |
| 923 | DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 924 | // Not yet budget limited or congested, packet is sent. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 925 | pacer->EnqueuePacket( |
| 926 | BuildPacket(RtpPacketMediaType::kVideo, ssrc, seq_num++, now_ms(), size)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 927 | EXPECT_CALL(callback_, SendPacket).Times(1); |
| 928 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 929 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 930 | // Packet blocked due to congestion. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 931 | pacer->SetCongested(true); |
| 932 | pacer->EnqueuePacket( |
| 933 | BuildPacket(RtpPacketMediaType::kVideo, ssrc, seq_num++, now_ms(), size)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 934 | EXPECT_CALL(callback_, SendPacket).Times(0); |
| 935 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 936 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 937 | // Packet blocked due to congestion. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 938 | pacer->EnqueuePacket( |
| 939 | BuildPacket(RtpPacketMediaType::kVideo, ssrc, seq_num++, now_ms(), size)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 940 | EXPECT_CALL(callback_, SendPacket).Times(0); |
| 941 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 942 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 943 | // Congestion removed and budget has recovered, packet is sent. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 944 | pacer->EnqueuePacket( |
| 945 | BuildPacket(RtpPacketMediaType::kVideo, ssrc, seq_num++, now_ms(), size)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 946 | EXPECT_CALL(callback_, SendPacket).Times(1); |
| 947 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 948 | pacer->SetCongested(false); |
| 949 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 950 | // Should be blocked due to budget limitation as congestion has be removed. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 951 | pacer->EnqueuePacket( |
| 952 | BuildPacket(RtpPacketMediaType::kVideo, ssrc, seq_num++, now_ms(), size)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 953 | EXPECT_CALL(callback_, SendPacket).Times(0); |
| 954 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 955 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 956 | } |
| 957 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 958 | TEST_F(PacingControllerTest, Pause) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 959 | uint32_t ssrc_low_priority = 12345; |
| 960 | uint32_t ssrc = 12346; |
| 961 | uint32_t ssrc_high_priority = 12347; |
| 962 | uint16_t sequence_number = 1234; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 963 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 964 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 965 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 966 | EXPECT_TRUE(pacer->OldestPacketEnqueueTime().IsInfinite()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 967 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 968 | ConsumeInitialBudget(pacer.get()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 969 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 970 | pacer->Pause(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 971 | |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 972 | int64_t capture_time_ms = clock_.TimeInMilliseconds(); |
| 973 | const size_t packets_to_send_per_interval = |
| 974 | kTargetRate.bps() * kPaceMultiplier / (8 * 250 * 200); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 975 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 976 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, |
| 977 | ssrc_low_priority, sequence_number++, |
| 978 | capture_time_ms, 250)); |
| 979 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kRetransmission, ssrc, |
| 980 | sequence_number++, capture_time_ms, 250)); |
| 981 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kAudio, |
| 982 | ssrc_high_priority, sequence_number++, |
| 983 | capture_time_ms, 250)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 984 | } |
| 985 | clock_.AdvanceTimeMilliseconds(10000); |
| 986 | int64_t second_capture_time_ms = clock_.TimeInMilliseconds(); |
| 987 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 988 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, |
| 989 | ssrc_low_priority, sequence_number++, |
| 990 | second_capture_time_ms, 250)); |
| 991 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kRetransmission, ssrc, |
| 992 | sequence_number++, second_capture_time_ms, |
| 993 | 250)); |
| 994 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kAudio, |
| 995 | ssrc_high_priority, sequence_number++, |
| 996 | second_capture_time_ms, 250)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 997 | } |
| 998 | |
| 999 | // Expect everything to be queued. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1000 | EXPECT_EQ(capture_time_ms, pacer->OldestPacketEnqueueTime().ms()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1001 | |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1002 | // Process triggers keep-alive packet. |
| 1003 | EXPECT_CALL(callback_, SendPadding).WillOnce([](size_t padding) { |
| 1004 | return padding; |
| 1005 | }); |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 1006 | EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1007 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1008 | |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1009 | // Verify no packets sent for the rest of the paused process interval. |
Danil Chapovalov | 5528402 | 2020-02-07 14:53:52 +0100 | [diff] [blame] | 1010 | const TimeDelta kProcessInterval = TimeDelta::Millis(5); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1011 | TimeDelta expected_time_until_send = PacingController::kPausedProcessInterval; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1012 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1013 | while (expected_time_until_send >= kProcessInterval) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1014 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1015 | clock_.AdvanceTime(kProcessInterval); |
| 1016 | expected_time_until_send -= kProcessInterval; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1017 | } |
| 1018 | |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1019 | // New keep-alive packet. |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1020 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1021 | EXPECT_CALL(callback_, SendPadding).WillOnce([](size_t padding) { |
| 1022 | return padding; |
| 1023 | }); |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 1024 | EXPECT_CALL(callback_, SendPacket(_, _, _, _, true)).Times(1); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1025 | clock_.AdvanceTime(kProcessInterval); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1026 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1027 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1028 | |
| 1029 | // Expect high prio packets to come out first followed by normal |
| 1030 | // prio packets and low prio packets (all in capture order). |
| 1031 | { |
| 1032 | ::testing::InSequence sequence; |
| 1033 | EXPECT_CALL(callback_, |
| 1034 | SendPacket(ssrc_high_priority, _, capture_time_ms, _, _)) |
| 1035 | .Times(packets_to_send_per_interval); |
| 1036 | EXPECT_CALL(callback_, |
| 1037 | SendPacket(ssrc_high_priority, _, second_capture_time_ms, _, _)) |
| 1038 | .Times(packets_to_send_per_interval); |
| 1039 | |
| 1040 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 1041 | EXPECT_CALL(callback_, SendPacket(ssrc, _, capture_time_ms, _, _)) |
| 1042 | .Times(1); |
| 1043 | } |
| 1044 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 1045 | EXPECT_CALL(callback_, SendPacket(ssrc, _, second_capture_time_ms, _, _)) |
| 1046 | .Times(1); |
| 1047 | } |
| 1048 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 1049 | EXPECT_CALL(callback_, |
| 1050 | SendPacket(ssrc_low_priority, _, capture_time_ms, _, _)) |
| 1051 | .Times(1); |
| 1052 | } |
| 1053 | for (size_t i = 0; i < packets_to_send_per_interval; ++i) { |
| 1054 | EXPECT_CALL(callback_, SendPacket(ssrc_low_priority, _, |
| 1055 | second_capture_time_ms, _, _)) |
| 1056 | .Times(1); |
| 1057 | } |
| 1058 | } |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1059 | pacer->Resume(); |
| 1060 | while (pacer->QueueSizePackets() > 0) { |
| 1061 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1062 | pacer->ProcessPackets(); |
| 1063 | } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1064 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1065 | EXPECT_TRUE(pacer->OldestPacketEnqueueTime().IsInfinite()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1066 | } |
| 1067 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1068 | TEST_F(PacingControllerTest, InactiveFromStart) { |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1069 | // Recreate the pacer without the inital time forwarding. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1070 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 1071 | pacer->SetProbingEnabled(false); |
| 1072 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1073 | |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1074 | // No packets sent, there should be no keep-alives sent either. |
| 1075 | EXPECT_CALL(callback_, SendPadding).Times(0); |
| 1076 | EXPECT_CALL(callback_, SendPacket).Times(0); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1077 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1078 | |
| 1079 | const Timestamp start_time = clock_.CurrentTime(); |
| 1080 | |
| 1081 | // Determine the margin need so we can advance to the last possible moment |
| 1082 | // that will not cause a process event. |
| 1083 | const TimeDelta time_margin = |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1084 | PacingController::kMinSleepTime + TimeDelta::Micros(1); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1085 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1086 | EXPECT_EQ(pacer->NextSendTime() - start_time, |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1087 | PacingController::kPausedProcessInterval); |
| 1088 | clock_.AdvanceTime(PacingController::kPausedProcessInterval - time_margin); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1089 | pacer->ProcessPackets(); |
| 1090 | EXPECT_EQ(pacer->NextSendTime() - start_time, |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1091 | PacingController::kPausedProcessInterval); |
| 1092 | |
| 1093 | clock_.AdvanceTime(time_margin); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1094 | pacer->ProcessPackets(); |
| 1095 | EXPECT_EQ(pacer->NextSendTime() - start_time, |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1096 | 2 * PacingController::kPausedProcessInterval); |
| 1097 | } |
| 1098 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1099 | TEST_F(PacingControllerTest, QueueTimeGrowsOverTime) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1100 | uint32_t ssrc = 12346; |
| 1101 | uint16_t sequence_number = 1234; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1102 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 1103 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
| 1104 | EXPECT_TRUE(pacer->OldestPacketEnqueueTime().IsInfinite()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1105 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1106 | pacer->SetPacingRates(DataRate::BitsPerSec(30000 * kPaceMultiplier), |
| 1107 | DataRate::Zero()); |
| 1108 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 1109 | sequence_number, clock_.TimeInMilliseconds(), 1200); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1110 | |
| 1111 | clock_.AdvanceTimeMilliseconds(500); |
Jianhui Dai | 9445779 | 2021-12-07 19:34:36 +0800 | [diff] [blame] | 1112 | EXPECT_EQ(clock_.TimeInMilliseconds() - 500, |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1113 | pacer->OldestPacketEnqueueTime().ms()); |
| 1114 | pacer->ProcessPackets(); |
| 1115 | EXPECT_TRUE(pacer->OldestPacketEnqueueTime().IsInfinite()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1116 | } |
| 1117 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1118 | TEST_F(PacingControllerTest, ProbingWithInsertedPackets) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1119 | const size_t kPacketSize = 1200; |
| 1120 | const int kInitialBitrateBps = 300000; |
| 1121 | uint32_t ssrc = 12346; |
| 1122 | uint16_t sequence_number = 1234; |
| 1123 | |
| 1124 | PacingControllerProbing packet_sender; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1125 | auto pacer = |
| 1126 | std::make_unique<PacingController>(&clock_, &packet_sender, trials_); |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1127 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1128 | {.at_time = clock_.CurrentTime(), |
| 1129 | .target_data_rate = kFirstClusterRate, |
| 1130 | .target_duration = TimeDelta::Millis(15), |
| 1131 | .target_probe_count = 5, |
| 1132 | .id = 0}, |
| 1133 | {.at_time = clock_.CurrentTime(), |
| 1134 | .target_data_rate = kSecondClusterRate, |
| 1135 | .target_duration = TimeDelta::Millis(15), |
| 1136 | .target_probe_count = 5, |
| 1137 | .id = 1}}; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1138 | pacer->CreateProbeClusters(probe_clusters); |
| 1139 | pacer->SetPacingRates( |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 1140 | DataRate::BitsPerSec(kInitialBitrateBps * kPaceMultiplier), |
| 1141 | DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1142 | |
| 1143 | for (int i = 0; i < 10; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1144 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1145 | sequence_number++, |
| 1146 | clock_.TimeInMilliseconds(), kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1147 | } |
| 1148 | |
| 1149 | int64_t start = clock_.TimeInMilliseconds(); |
| 1150 | while (packet_sender.packets_sent() < 5) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1151 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1152 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1153 | } |
| 1154 | int packets_sent = packet_sender.packets_sent(); |
| 1155 | // Validate first cluster bitrate. Note that we have to account for number |
| 1156 | // of intervals and hence (packets_sent - 1) on the first cluster. |
| 1157 | EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 / |
| 1158 | (clock_.TimeInMilliseconds() - start), |
| 1159 | kFirstClusterRate.bps(), kProbingErrorMargin.bps()); |
Erik Språng | 279f370 | 2020-10-13 21:55:07 +0200 | [diff] [blame] | 1160 | // Probing always starts with a small padding packet. |
| 1161 | EXPECT_EQ(1, packet_sender.padding_sent()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1162 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1163 | AdvanceTimeUntil(pacer->NextSendTime()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1164 | start = clock_.TimeInMilliseconds(); |
| 1165 | while (packet_sender.packets_sent() < 10) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1166 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1167 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1168 | } |
| 1169 | packets_sent = packet_sender.packets_sent() - packets_sent; |
| 1170 | // Validate second cluster bitrate. |
| 1171 | EXPECT_NEAR((packets_sent - 1) * kPacketSize * 8000 / |
| 1172 | (clock_.TimeInMilliseconds() - start), |
| 1173 | kSecondClusterRate.bps(), kProbingErrorMargin.bps()); |
| 1174 | } |
| 1175 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1176 | TEST_F(PacingControllerTest, SkipsProbesWhenProcessIntervalTooLarge) { |
Erik Språng | b210eeb | 2019-11-05 11:21:48 +0100 | [diff] [blame] | 1177 | const size_t kPacketSize = 1200; |
| 1178 | const int kInitialBitrateBps = 300000; |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1179 | const uint32_t ssrc = 12346; |
| 1180 | const int kProbeClusterId = 3; |
Erik Språng | b210eeb | 2019-11-05 11:21:48 +0100 | [diff] [blame] | 1181 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1182 | uint16_t sequence_number = 1234; |
Erik Språng | b210eeb | 2019-11-05 11:21:48 +0100 | [diff] [blame] | 1183 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1184 | PacingControllerProbing packet_sender; |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1185 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1186 | const test::ExplicitKeyValueConfig trials( |
| 1187 | "WebRTC-Bwe-ProbingBehavior/max_probe_delay:2ms/"); |
| 1188 | auto pacer = |
| 1189 | std::make_unique<PacingController>(&clock_, &packet_sender, trials); |
| 1190 | pacer->SetPacingRates( |
| 1191 | DataRate::BitsPerSec(kInitialBitrateBps * kPaceMultiplier), |
| 1192 | DataRate::BitsPerSec(kInitialBitrateBps)); |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1193 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1194 | for (int i = 0; i < 10; ++i) { |
| 1195 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1196 | sequence_number++, |
| 1197 | clock_.TimeInMilliseconds(), kPacketSize)); |
| 1198 | } |
| 1199 | while (pacer->QueueSizePackets() > 0) { |
| 1200 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1201 | pacer->ProcessPackets(); |
| 1202 | } |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1203 | |
| 1204 | // Probe at a very high rate. |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1205 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1206 | {.at_time = clock_.CurrentTime(), |
| 1207 | .target_data_rate = DataRate::KilobitsPerSec(10000), // 10 Mbps, |
| 1208 | .target_duration = TimeDelta::Millis(15), |
| 1209 | .target_probe_count = 5, |
| 1210 | .id = kProbeClusterId}}; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1211 | pacer->CreateProbeClusters(probe_clusters); |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1212 | |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1213 | // We need one packet to start the probe. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1214 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1215 | sequence_number++, |
| 1216 | clock_.TimeInMilliseconds(), kPacketSize)); |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1217 | const int packets_sent_before_probe = packet_sender.packets_sent(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1218 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1219 | pacer->ProcessPackets(); |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1220 | EXPECT_EQ(packet_sender.packets_sent(), packets_sent_before_probe + 1); |
| 1221 | |
| 1222 | // Figure out how long between probe packets. |
| 1223 | Timestamp start_time = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1224 | AdvanceTimeUntil(pacer->NextSendTime()); |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1225 | TimeDelta time_between_probes = clock_.CurrentTime() - start_time; |
| 1226 | // Advance that distance again + 1ms. |
| 1227 | clock_.AdvanceTime(time_between_probes); |
| 1228 | |
| 1229 | // Send second probe packet. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1230 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1231 | sequence_number++, |
| 1232 | clock_.TimeInMilliseconds(), kPacketSize)); |
| 1233 | pacer->ProcessPackets(); |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1234 | EXPECT_EQ(packet_sender.packets_sent(), packets_sent_before_probe + 2); |
| 1235 | PacedPacketInfo last_pacing_info = packet_sender.last_pacing_info(); |
| 1236 | EXPECT_EQ(last_pacing_info.probe_cluster_id, kProbeClusterId); |
| 1237 | |
| 1238 | // We're exactly where we should be for the next probe. |
| 1239 | const Timestamp probe_time = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1240 | EXPECT_EQ(pacer->NextSendTime(), clock_.CurrentTime()); |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1241 | |
| 1242 | BitrateProberConfig probing_config(&trials); |
| 1243 | EXPECT_GT(probing_config.max_probe_delay.Get(), TimeDelta::Zero()); |
| 1244 | // Advance to within max probe delay, should still return same target. |
| 1245 | clock_.AdvanceTime(probing_config.max_probe_delay.Get()); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1246 | EXPECT_EQ(pacer->NextSendTime(), probe_time); |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1247 | |
| 1248 | // Too high probe delay, drop it! |
| 1249 | clock_.AdvanceTime(TimeDelta::Micros(1)); |
| 1250 | |
| 1251 | int packets_sent_before_timeout = packet_sender.total_packets_sent(); |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1252 | // Expected next process time is unchanged, but calling should not |
| 1253 | // generate new packets. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1254 | EXPECT_EQ(pacer->NextSendTime(), probe_time); |
| 1255 | pacer->ProcessPackets(); |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1256 | EXPECT_EQ(packet_sender.total_packets_sent(), packets_sent_before_timeout); |
Erik Språng | b9d3809 | 2020-07-17 12:06:12 +0200 | [diff] [blame] | 1257 | |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1258 | // Next packet sent is not part of probe. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1259 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1260 | pacer->ProcessPackets(); |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1261 | const int expected_probe_id = PacedPacketInfo::kNotAProbe; |
| 1262 | EXPECT_EQ(packet_sender.last_pacing_info().probe_cluster_id, |
| 1263 | expected_probe_id); |
Erik Språng | b210eeb | 2019-11-05 11:21:48 +0100 | [diff] [blame] | 1264 | } |
| 1265 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1266 | TEST_F(PacingControllerTest, ProbingWithPaddingSupport) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1267 | const size_t kPacketSize = 1200; |
| 1268 | const int kInitialBitrateBps = 300000; |
| 1269 | uint32_t ssrc = 12346; |
| 1270 | uint16_t sequence_number = 1234; |
| 1271 | |
| 1272 | PacingControllerProbing packet_sender; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1273 | auto pacer = |
| 1274 | std::make_unique<PacingController>(&clock_, &packet_sender, trials_); |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1275 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1276 | {.at_time = clock_.CurrentTime(), |
| 1277 | .target_data_rate = kFirstClusterRate, |
| 1278 | .target_duration = TimeDelta::Millis(15), |
| 1279 | .target_probe_count = 5, |
| 1280 | .id = 0}}; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1281 | pacer->CreateProbeClusters(probe_clusters); |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1282 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1283 | pacer->SetPacingRates( |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 1284 | DataRate::BitsPerSec(kInitialBitrateBps * kPaceMultiplier), |
| 1285 | DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1286 | |
| 1287 | for (int i = 0; i < 3; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1288 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1289 | sequence_number++, |
| 1290 | clock_.TimeInMilliseconds(), kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1291 | } |
| 1292 | |
| 1293 | int64_t start = clock_.TimeInMilliseconds(); |
| 1294 | int process_count = 0; |
| 1295 | while (process_count < 5) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1296 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1297 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1298 | ++process_count; |
| 1299 | } |
| 1300 | int packets_sent = packet_sender.packets_sent(); |
| 1301 | int padding_sent = packet_sender.padding_sent(); |
| 1302 | EXPECT_GT(packets_sent, 0); |
| 1303 | EXPECT_GT(padding_sent, 0); |
| 1304 | // Note that the number of intervals here for kPacketSize is |
| 1305 | // packets_sent due to padding in the same cluster. |
| 1306 | EXPECT_NEAR((packets_sent * kPacketSize * 8000 + padding_sent) / |
| 1307 | (clock_.TimeInMilliseconds() - start), |
| 1308 | kFirstClusterRate.bps(), kProbingErrorMargin.bps()); |
| 1309 | } |
| 1310 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1311 | TEST_F(PacingControllerTest, PaddingOveruse) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1312 | uint32_t ssrc = 12346; |
| 1313 | uint16_t sequence_number = 1234; |
| 1314 | const size_t kPacketSize = 1200; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1315 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 1316 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1317 | |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1318 | // Initially no padding rate. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1319 | pacer->ProcessPackets(); |
| 1320 | pacer->SetPacingRates(DataRate::BitsPerSec(60000 * kPaceMultiplier), |
| 1321 | DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1322 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1323 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 1324 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1325 | kPacketSize); |
| 1326 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1327 | |
| 1328 | // Add 30kbit padding. When increasing budget, media budget will increase from |
| 1329 | // negative (overuse) while padding budget will increase from 0. |
| 1330 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1331 | pacer->SetPacingRates(DataRate::BitsPerSec(60000 * kPaceMultiplier), |
| 1332 | DataRate::BitsPerSec(30000)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1333 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1334 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 1335 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1336 | kPacketSize); |
| 1337 | EXPECT_LT(TimeDelta::Millis(5), pacer->ExpectedQueueTime()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1338 | // Don't send padding if queue is non-empty, even if padding budget > 0. |
| 1339 | EXPECT_CALL(callback_, SendPadding).Times(0); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1340 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1341 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1342 | } |
| 1343 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1344 | TEST_F(PacingControllerTest, ProbeClusterId) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1345 | MockPacketSender callback; |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1346 | uint32_t ssrc = 12346; |
| 1347 | uint16_t sequence_number = 1234; |
| 1348 | const size_t kPacketSize = 1200; |
| 1349 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1350 | auto pacer = std::make_unique<PacingController>(&clock_, &callback, trials_); |
| 1351 | pacer->CreateProbeClusters(std::vector<ProbeClusterConfig>( |
| 1352 | {{.at_time = clock_.CurrentTime(), |
| 1353 | .target_data_rate = kFirstClusterRate, |
| 1354 | .target_duration = TimeDelta::Millis(15), |
| 1355 | .target_probe_count = 5, |
| 1356 | .id = 0}, |
| 1357 | {.at_time = clock_.CurrentTime(), |
| 1358 | .target_data_rate = kSecondClusterRate, |
| 1359 | .target_duration = TimeDelta::Millis(15), |
| 1360 | .target_probe_count = 5, |
| 1361 | .id = 1}})); |
| 1362 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, kTargetRate); |
| 1363 | pacer->SetProbingEnabled(true); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1364 | for (int i = 0; i < 10; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1365 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, ssrc, |
| 1366 | sequence_number++, |
| 1367 | clock_.TimeInMilliseconds(), kPacketSize)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1368 | } |
| 1369 | |
| 1370 | // First probing cluster. |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 1371 | EXPECT_CALL(callback, |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 +0000 | [diff] [blame] | 1372 | SendPacket(_, Field(&PacedPacketInfo::probe_cluster_id, 0))) |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 1373 | .Times(5); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1374 | |
| 1375 | for (int i = 0; i < 5; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1376 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1377 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1378 | } |
| 1379 | |
| 1380 | // Second probing cluster. |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 1381 | EXPECT_CALL(callback, |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 +0000 | [diff] [blame] | 1382 | SendPacket(_, Field(&PacedPacketInfo::probe_cluster_id, 1))) |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 1383 | .Times(5); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1384 | |
| 1385 | for (int i = 0; i < 5; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1386 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1387 | pacer->ProcessPackets(); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1388 | } |
| 1389 | |
| 1390 | // Needed for the Field comparer below. |
| 1391 | const int kNotAProbe = PacedPacketInfo::kNotAProbe; |
| 1392 | // No more probing packets. |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 1393 | EXPECT_CALL(callback, GeneratePadding).WillOnce([&](DataSize padding_size) { |
| 1394 | std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets; |
| 1395 | padding_packets.emplace_back( |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 1396 | BuildPacket(RtpPacketMediaType::kPadding, ssrc, sequence_number++, |
Erik Språng | f5815fa | 2019-08-21 14:27:31 +0200 | [diff] [blame] | 1397 | clock_.TimeInMilliseconds(), padding_size.bytes())); |
| 1398 | return padding_packets; |
| 1399 | }); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1400 | bool non_probe_packet_seen = false; |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 +0000 | [diff] [blame] | 1401 | EXPECT_CALL(callback, SendPacket) |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1402 | .WillOnce([&](std::unique_ptr<RtpPacketToSend> packet, |
| 1403 | const PacedPacketInfo& cluster_info) { |
| 1404 | EXPECT_EQ(cluster_info.probe_cluster_id, kNotAProbe); |
| 1405 | non_probe_packet_seen = true; |
| 1406 | }); |
| 1407 | while (!non_probe_packet_seen) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1408 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1409 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1410 | } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1411 | } |
| 1412 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1413 | TEST_F(PacingControllerTest, OwnedPacketPrioritizedOnType) { |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1414 | MockPacketSender callback; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1415 | uint32_t ssrc = 123; |
| 1416 | |
| 1417 | auto pacer = std::make_unique<PacingController>(&clock_, &callback, trials_); |
| 1418 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1419 | |
| 1420 | // Insert a packet of each type, from low to high priority. Since priority |
| 1421 | // is weighted higher than insert order, these should come out of the pacer |
| 1422 | // in backwards order with the exception of FEC and Video. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1423 | |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 1424 | for (RtpPacketMediaType type : |
| 1425 | {RtpPacketMediaType::kPadding, |
| 1426 | RtpPacketMediaType::kForwardErrorCorrection, RtpPacketMediaType::kVideo, |
| 1427 | RtpPacketMediaType::kRetransmission, RtpPacketMediaType::kAudio}) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1428 | pacer->EnqueuePacket(BuildPacket(type, ++ssrc, /*sequence_number=*/123, |
| 1429 | clock_.TimeInMilliseconds(), |
| 1430 | /*size=*/150)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1431 | } |
| 1432 | |
| 1433 | ::testing::InSequence seq; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1434 | EXPECT_CALL(callback, |
| 1435 | SendPacket(Pointee(Property(&RtpPacketToSend::packet_type, |
| 1436 | RtpPacketMediaType::kAudio)), |
| 1437 | _)); |
| 1438 | EXPECT_CALL(callback, |
| 1439 | SendPacket(Pointee(Property(&RtpPacketToSend::packet_type, |
| 1440 | RtpPacketMediaType::kRetransmission)), |
| 1441 | _)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1442 | |
| 1443 | // FEC and video actually have the same priority, so will come out in |
| 1444 | // insertion order. |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1445 | EXPECT_CALL( |
| 1446 | callback, |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1447 | SendPacket(Pointee(Property(&RtpPacketToSend::packet_type, |
| 1448 | RtpPacketMediaType::kForwardErrorCorrection)), |
| 1449 | _)); |
| 1450 | EXPECT_CALL(callback, |
| 1451 | SendPacket(Pointee(Property(&RtpPacketToSend::packet_type, |
| 1452 | RtpPacketMediaType::kVideo)), |
| 1453 | _)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1454 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1455 | EXPECT_CALL(callback, |
| 1456 | SendPacket(Pointee(Property(&RtpPacketToSend::packet_type, |
| 1457 | RtpPacketMediaType::kPadding)), |
| 1458 | _)); |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1459 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1460 | while (pacer->QueueSizePackets() > 0) { |
| 1461 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1462 | pacer->ProcessPackets(); |
| 1463 | } |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 1464 | } |
Erik Språng | 78c82a4 | 2019-10-03 18:46:04 +0200 | [diff] [blame] | 1465 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1466 | TEST_F(PacingControllerTest, SmallFirstProbePacket) { |
Erik Språng | 78c82a4 | 2019-10-03 18:46:04 +0200 | [diff] [blame] | 1467 | MockPacketSender callback; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1468 | auto pacer = std::make_unique<PacingController>(&clock_, &callback, trials_); |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1469 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1470 | {.at_time = clock_.CurrentTime(), |
| 1471 | .target_data_rate = kFirstClusterRate, |
| 1472 | .target_duration = TimeDelta::Millis(15), |
| 1473 | .target_probe_count = 5, |
| 1474 | .id = 0}}; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1475 | pacer->CreateProbeClusters(probe_clusters); |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1476 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1477 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
Erik Språng | 78c82a4 | 2019-10-03 18:46:04 +0200 | [diff] [blame] | 1478 | |
| 1479 | // Add high prio media. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1480 | pacer->EnqueuePacket(audio_.BuildNextPacket(234)); |
Erik Språng | 78c82a4 | 2019-10-03 18:46:04 +0200 | [diff] [blame] | 1481 | |
| 1482 | // Expect small padding packet to be requested. |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 1483 | EXPECT_CALL(callback, GeneratePadding(DataSize::Bytes(1))) |
Erik Språng | 78c82a4 | 2019-10-03 18:46:04 +0200 | [diff] [blame] | 1484 | .WillOnce([&](DataSize padding_size) { |
| 1485 | std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets; |
| 1486 | padding_packets.emplace_back( |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 1487 | BuildPacket(RtpPacketMediaType::kPadding, kAudioSsrc, 1, |
Erik Språng | 78c82a4 | 2019-10-03 18:46:04 +0200 | [diff] [blame] | 1488 | clock_.TimeInMilliseconds(), 1)); |
| 1489 | return padding_packets; |
| 1490 | }); |
| 1491 | |
| 1492 | size_t packets_sent = 0; |
| 1493 | bool media_seen = false; |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 +0000 | [diff] [blame] | 1494 | EXPECT_CALL(callback, SendPacket) |
Erik Språng | 78c82a4 | 2019-10-03 18:46:04 +0200 | [diff] [blame] | 1495 | .Times(::testing::AnyNumber()) |
| 1496 | .WillRepeatedly([&](std::unique_ptr<RtpPacketToSend> packet, |
| 1497 | const PacedPacketInfo& cluster_info) { |
| 1498 | if (packets_sent == 0) { |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 1499 | EXPECT_EQ(packet->packet_type(), RtpPacketMediaType::kPadding); |
Erik Språng | 78c82a4 | 2019-10-03 18:46:04 +0200 | [diff] [blame] | 1500 | } else { |
Björn Terelius | 31d0f7c | 2020-02-06 16:35:46 +0100 | [diff] [blame] | 1501 | if (packet->packet_type() == RtpPacketMediaType::kAudio) { |
Erik Språng | 78c82a4 | 2019-10-03 18:46:04 +0200 | [diff] [blame] | 1502 | media_seen = true; |
| 1503 | } |
| 1504 | } |
| 1505 | packets_sent++; |
| 1506 | }); |
| 1507 | while (!media_seen) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1508 | pacer->ProcessPackets(); |
Erik Språng | 78c82a4 | 2019-10-03 18:46:04 +0200 | [diff] [blame] | 1509 | clock_.AdvanceTimeMilliseconds(5); |
| 1510 | } |
| 1511 | } |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1512 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1513 | TEST_F(PacingControllerTest, TaskLate) { |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1514 | // Set a low send rate to more easily test timing issues. |
Danil Chapovalov | cad3e0e | 2020-02-17 18:46:07 +0100 | [diff] [blame] | 1515 | DataRate kSendRate = DataRate::KilobitsPerSec(30); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1516 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 1517 | pacer->SetPacingRates(kSendRate, DataRate::Zero()); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1518 | |
| 1519 | // Add four packets of equal size and priority. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1520 | pacer->EnqueuePacket(video_.BuildNextPacket(1000)); |
| 1521 | pacer->EnqueuePacket(video_.BuildNextPacket(1000)); |
| 1522 | pacer->EnqueuePacket(video_.BuildNextPacket(1000)); |
| 1523 | pacer->EnqueuePacket(video_.BuildNextPacket(1000)); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1524 | |
| 1525 | // Process packets, only first should be sent. |
| 1526 | EXPECT_CALL(callback_, SendPacket).Times(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1527 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1528 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1529 | Timestamp next_send_time = pacer->NextSendTime(); |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1530 | // Determine time between packets (ca 62ms) |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1531 | const TimeDelta time_between_packets = next_send_time - clock_.CurrentTime(); |
| 1532 | |
| 1533 | // Simulate a late process call, executed just before we allow sending the |
| 1534 | // fourth packet. |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1535 | const TimeDelta kOffset = TimeDelta::Millis(1); |
| 1536 | clock_.AdvanceTime((time_between_packets * 3) - kOffset); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1537 | |
| 1538 | EXPECT_CALL(callback_, SendPacket).Times(2); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1539 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1540 | |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1541 | // Check that next scheduled send time is in ca 1ms. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1542 | next_send_time = pacer->NextSendTime(); |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1543 | const TimeDelta time_left = next_send_time - clock_.CurrentTime(); |
| 1544 | EXPECT_EQ(time_left.RoundTo(TimeDelta::Millis(1)), kOffset); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1545 | |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1546 | clock_.AdvanceTime(time_left); |
| 1547 | EXPECT_CALL(callback_, SendPacket); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1548 | pacer->ProcessPackets(); |
Erik Språng | eb48799 | 2019-11-14 14:15:15 +0100 | [diff] [blame] | 1549 | } |
| 1550 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1551 | TEST_F(PacingControllerTest, NoProbingWhilePaused) { |
Erik Språng | ae10029 | 2019-12-17 17:49:49 +0100 | [diff] [blame] | 1552 | uint32_t ssrc = 12345; |
| 1553 | uint16_t sequence_number = 1234; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1554 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
| 1555 | pacer->SetProbingEnabled(true); |
| 1556 | pacer->SetPacingRates(kTargetRate * kPaceMultiplier, DataRate::Zero()); |
| 1557 | pacer->CreateProbeClusters(std::vector<ProbeClusterConfig>( |
| 1558 | {{.at_time = clock_.CurrentTime(), |
| 1559 | .target_data_rate = kFirstClusterRate, |
| 1560 | .target_duration = TimeDelta::Millis(15), |
| 1561 | .target_probe_count = 5, |
| 1562 | .id = 0}, |
| 1563 | {.at_time = clock_.CurrentTime(), |
| 1564 | .target_data_rate = kSecondClusterRate, |
| 1565 | .target_duration = TimeDelta::Millis(15), |
| 1566 | .target_probe_count = 5, |
| 1567 | .id = 1}})); |
Erik Språng | ae10029 | 2019-12-17 17:49:49 +0100 | [diff] [blame] | 1568 | |
| 1569 | // Send at least one packet so probing can initate. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1570 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, ssrc, |
| 1571 | sequence_number, clock_.TimeInMilliseconds(), 250); |
| 1572 | while (pacer->QueueSizePackets() > 0) { |
| 1573 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1574 | pacer->ProcessPackets(); |
| 1575 | } |
Erik Språng | ae10029 | 2019-12-17 17:49:49 +0100 | [diff] [blame] | 1576 | |
| 1577 | // Trigger probing. |
Per Kjellander | 88af203 | 2022-05-16 19:58:40 +0200 | [diff] [blame] | 1578 | std::vector<ProbeClusterConfig> probe_clusters = { |
| 1579 | {.at_time = clock_.CurrentTime(), |
| 1580 | .target_data_rate = DataRate::KilobitsPerSec(10000), // 10 Mbps. |
| 1581 | .target_duration = TimeDelta::Millis(15), |
| 1582 | .target_probe_count = 5, |
| 1583 | .id = 3}}; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1584 | pacer->CreateProbeClusters(probe_clusters); |
Erik Språng | ae10029 | 2019-12-17 17:49:49 +0100 | [diff] [blame] | 1585 | |
| 1586 | // Time to next send time should be small. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1587 | EXPECT_LT(pacer->NextSendTime() - clock_.CurrentTime(), |
Erik Språng | ae10029 | 2019-12-17 17:49:49 +0100 | [diff] [blame] | 1588 | PacingController::kPausedProcessInterval); |
| 1589 | |
| 1590 | // Pause pacer, time to next send time should now be the pause process |
| 1591 | // interval. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1592 | pacer->Pause(); |
Erik Språng | ae10029 | 2019-12-17 17:49:49 +0100 | [diff] [blame] | 1593 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1594 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), |
Erik Språng | ae10029 | 2019-12-17 17:49:49 +0100 | [diff] [blame] | 1595 | PacingController::kPausedProcessInterval); |
| 1596 | } |
| 1597 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1598 | TEST_F(PacingControllerTest, AudioNotPacedEvenWhenAccountedFor) { |
Erik Språng | 9cb58d5 | 2020-03-28 17:15:54 +0100 | [diff] [blame] | 1599 | const uint32_t kSsrc = 12345; |
| 1600 | uint16_t sequence_number = 1234; |
| 1601 | const size_t kPacketSize = 123; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1602 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | 9cb58d5 | 2020-03-28 17:15:54 +0100 | [diff] [blame] | 1603 | |
| 1604 | // Account for audio - so that audio packets can cause pushback on other |
| 1605 | // types such as video. Audio packet should still be immediated passed |
| 1606 | // through though ("WebRTC-Pacer-BlockAudio" needs to be enabled in order |
| 1607 | // to pace audio packets). |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1608 | pacer->SetAccountForAudioPackets(true); |
Erik Språng | 9cb58d5 | 2020-03-28 17:15:54 +0100 | [diff] [blame] | 1609 | |
| 1610 | // Set pacing rate to 1 packet/s, no padding. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1611 | pacer->SetPacingRates(DataSize::Bytes(kPacketSize) / TimeDelta::Seconds(1), |
| 1612 | DataRate::Zero()); |
Erik Språng | 9cb58d5 | 2020-03-28 17:15:54 +0100 | [diff] [blame] | 1613 | |
| 1614 | // Add and send an audio packet. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1615 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kAudio, kSsrc, |
| 1616 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1617 | kPacketSize); |
| 1618 | pacer->ProcessPackets(); |
Erik Språng | 9cb58d5 | 2020-03-28 17:15:54 +0100 | [diff] [blame] | 1619 | |
| 1620 | // Advance time, add another audio packet and process. It should be sent |
| 1621 | // immediately. |
| 1622 | clock_.AdvanceTimeMilliseconds(5); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1623 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kAudio, kSsrc, |
| 1624 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1625 | kPacketSize); |
| 1626 | pacer->ProcessPackets(); |
Erik Språng | 9cb58d5 | 2020-03-28 17:15:54 +0100 | [diff] [blame] | 1627 | } |
| 1628 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1629 | TEST_F(PacingControllerTest, |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1630 | PaddingResumesAfterSaturationEvenWithConcurrentAudio) { |
Erik Språng | 0920d5d | 2020-03-30 17:14:08 +0200 | [diff] [blame] | 1631 | const uint32_t kSsrc = 12345; |
| 1632 | const DataRate kPacingDataRate = DataRate::KilobitsPerSec(125); |
| 1633 | const DataRate kPaddingDataRate = DataRate::KilobitsPerSec(100); |
| 1634 | const TimeDelta kMaxBufferInTime = TimeDelta::Millis(500); |
| 1635 | const DataSize kPacketSize = DataSize::Bytes(130); |
| 1636 | const TimeDelta kAudioPacketInterval = TimeDelta::Millis(20); |
| 1637 | |
| 1638 | // In this test, we fist send a burst of video in order to saturate the |
| 1639 | // padding debt level. |
| 1640 | // We then proceed to send audio at a bitrate that is slightly lower than |
| 1641 | // the padding rate, meaning there will be a period with audio but no |
| 1642 | // padding sent while the debt is draining, then audio and padding will |
| 1643 | // be interlieved. |
| 1644 | |
| 1645 | // Verify both with and without accounting for audio. |
| 1646 | for (bool account_for_audio : {false, true}) { |
| 1647 | uint16_t sequence_number = 1234; |
| 1648 | MockPacketSender callback; |
Erik Språng | ed1fb19 | 2020-06-30 11:53:37 +0000 | [diff] [blame] | 1649 | EXPECT_CALL(callback, SendPacket).Times(::testing::AnyNumber()); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1650 | auto pacer = |
| 1651 | std::make_unique<PacingController>(&clock_, &callback, trials_); |
| 1652 | pacer->SetAccountForAudioPackets(account_for_audio); |
Erik Språng | 0920d5d | 2020-03-30 17:14:08 +0200 | [diff] [blame] | 1653 | |
| 1654 | // First, saturate the padding budget. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1655 | pacer->SetPacingRates(kPacingDataRate, kPaddingDataRate); |
Erik Språng | 0920d5d | 2020-03-30 17:14:08 +0200 | [diff] [blame] | 1656 | |
| 1657 | const TimeDelta kPaddingSaturationTime = |
| 1658 | kMaxBufferInTime * kPaddingDataRate / |
| 1659 | (kPacingDataRate - kPaddingDataRate); |
| 1660 | const DataSize kVideoToSend = kPaddingSaturationTime * kPacingDataRate; |
| 1661 | const DataSize kVideoPacketSize = DataSize::Bytes(1200); |
| 1662 | DataSize video_sent = DataSize::Zero(); |
| 1663 | while (video_sent < kVideoToSend) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1664 | pacer->EnqueuePacket( |
Erik Språng | 0920d5d | 2020-03-30 17:14:08 +0200 | [diff] [blame] | 1665 | BuildPacket(RtpPacketMediaType::kVideo, kSsrc, sequence_number++, |
| 1666 | clock_.TimeInMilliseconds(), kVideoPacketSize.bytes())); |
| 1667 | video_sent += kVideoPacketSize; |
| 1668 | } |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1669 | while (pacer->QueueSizePackets() > 0) { |
| 1670 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1671 | pacer->ProcessPackets(); |
| 1672 | } |
Erik Språng | 0920d5d | 2020-03-30 17:14:08 +0200 | [diff] [blame] | 1673 | |
| 1674 | // Add a stream of audio packets at a rate slightly lower than the padding |
| 1675 | // rate, once the padding debt is paid off we expect padding to be |
| 1676 | // generated. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1677 | pacer->SetPacingRates(kPacingDataRate, kPaddingDataRate); |
Erik Språng | 0920d5d | 2020-03-30 17:14:08 +0200 | [diff] [blame] | 1678 | bool padding_seen = false; |
| 1679 | EXPECT_CALL(callback, GeneratePadding).WillOnce([&](DataSize padding_size) { |
| 1680 | padding_seen = true; |
| 1681 | std::vector<std::unique_ptr<RtpPacketToSend>> padding_packets; |
| 1682 | padding_packets.emplace_back( |
| 1683 | BuildPacket(RtpPacketMediaType::kPadding, kSsrc, sequence_number++, |
| 1684 | clock_.TimeInMilliseconds(), padding_size.bytes())); |
| 1685 | return padding_packets; |
| 1686 | }); |
| 1687 | |
| 1688 | Timestamp start_time = clock_.CurrentTime(); |
| 1689 | Timestamp last_audio_time = start_time; |
| 1690 | while (!padding_seen) { |
| 1691 | Timestamp now = clock_.CurrentTime(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1692 | Timestamp next_send_time = pacer->NextSendTime(); |
Erik Språng | 0920d5d | 2020-03-30 17:14:08 +0200 | [diff] [blame] | 1693 | TimeDelta sleep_time = |
| 1694 | std::min(next_send_time, last_audio_time + kAudioPacketInterval) - |
| 1695 | now; |
| 1696 | clock_.AdvanceTime(sleep_time); |
| 1697 | while (clock_.CurrentTime() >= last_audio_time + kAudioPacketInterval) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1698 | pacer->EnqueuePacket( |
Erik Språng | 0920d5d | 2020-03-30 17:14:08 +0200 | [diff] [blame] | 1699 | BuildPacket(RtpPacketMediaType::kAudio, kSsrc, sequence_number++, |
| 1700 | clock_.TimeInMilliseconds(), kPacketSize.bytes())); |
| 1701 | last_audio_time += kAudioPacketInterval; |
| 1702 | } |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1703 | pacer->ProcessPackets(); |
Erik Språng | 0920d5d | 2020-03-30 17:14:08 +0200 | [diff] [blame] | 1704 | } |
| 1705 | |
| 1706 | // Verify how long it took to drain the padding debt. Allow 2% error margin. |
| 1707 | const DataRate kAudioDataRate = kPacketSize / kAudioPacketInterval; |
| 1708 | const TimeDelta expected_drain_time = |
| 1709 | account_for_audio ? (kMaxBufferInTime * kPaddingDataRate / |
| 1710 | (kPaddingDataRate - kAudioDataRate)) |
| 1711 | : kMaxBufferInTime; |
| 1712 | const TimeDelta actual_drain_time = clock_.CurrentTime() - start_time; |
| 1713 | EXPECT_NEAR(actual_drain_time.ms(), expected_drain_time.ms(), |
| 1714 | expected_drain_time.ms() * 0.02) |
| 1715 | << " where account_for_audio = " |
| 1716 | << (account_for_audio ? "true" : "false"); |
| 1717 | } |
| 1718 | } |
| 1719 | |
Erik Språng | df9e51a | 2022-06-10 11:42:15 +0200 | [diff] [blame] | 1720 | TEST_F(PacingControllerTest, AccountsForAudioEnqueueTime) { |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1721 | const uint32_t kSsrc = 12345; |
| 1722 | const DataRate kPacingDataRate = DataRate::KilobitsPerSec(125); |
| 1723 | const DataRate kPaddingDataRate = DataRate::Zero(); |
| 1724 | const DataSize kPacketSize = DataSize::Bytes(130); |
| 1725 | const TimeDelta kPacketPacingTime = kPacketSize / kPacingDataRate; |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1726 | uint32_t sequnce_number = 1; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1727 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1728 | // Audio not paced, but still accounted for in budget. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1729 | pacer->SetAccountForAudioPackets(true); |
| 1730 | pacer->SetPacingRates(kPacingDataRate, kPaddingDataRate); |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1731 | |
| 1732 | // Enqueue two audio packets, advance clock to where one packet |
| 1733 | // should have drained the buffer already, has they been sent |
| 1734 | // immediately. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1735 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kAudio, kSsrc, |
| 1736 | sequnce_number++, clock_.TimeInMilliseconds(), |
| 1737 | kPacketSize.bytes()); |
| 1738 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kAudio, kSsrc, |
| 1739 | sequnce_number++, clock_.TimeInMilliseconds(), |
| 1740 | kPacketSize.bytes()); |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1741 | clock_.AdvanceTime(kPacketPacingTime); |
| 1742 | // Now process and make sure both packets were sent. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1743 | pacer->ProcessPackets(); |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1744 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1745 | |
| 1746 | // Add a video packet. I can't be sent until debt from audio |
| 1747 | // packets have been drained. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1748 | pacer->EnqueuePacket( |
| 1749 | BuildPacket(RtpPacketMediaType::kVideo, kSsrc + 1, sequnce_number++, |
| 1750 | clock_.TimeInMilliseconds(), kPacketSize.bytes())); |
| 1751 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), kPacketPacingTime); |
Erik Språng | b571ff4 | 2020-04-04 17:20:37 +0200 | [diff] [blame] | 1752 | } |
| 1753 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1754 | TEST_F(PacingControllerTest, NextSendTimeAccountsForPadding) { |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1755 | const uint32_t kSsrc = 12345; |
| 1756 | const DataRate kPacingDataRate = DataRate::KilobitsPerSec(125); |
| 1757 | const DataSize kPacketSize = DataSize::Bytes(130); |
| 1758 | const TimeDelta kPacketPacingTime = kPacketSize / kPacingDataRate; |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1759 | uint32_t sequnce_number = 1; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1760 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1761 | |
| 1762 | // Start with no padding. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1763 | pacer->SetPacingRates(kPacingDataRate, DataRate::Zero()); |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1764 | |
| 1765 | // Send a single packet. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1766 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, kSsrc, |
| 1767 | sequnce_number++, clock_.TimeInMilliseconds(), |
| 1768 | kPacketSize.bytes()); |
| 1769 | pacer->ProcessPackets(); |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1770 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1771 | |
| 1772 | // With current conditions, no need to wake until next keep-alive. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1773 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1774 | PacingController::kPausedProcessInterval); |
| 1775 | |
| 1776 | // Enqueue a new packet, that can't be sent until previous buffer has |
| 1777 | // drained. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1778 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, kSsrc, |
| 1779 | sequnce_number++, clock_.TimeInMilliseconds(), |
| 1780 | kPacketSize.bytes()); |
| 1781 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), kPacketPacingTime); |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1782 | clock_.AdvanceTime(kPacketPacingTime); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1783 | pacer->ProcessPackets(); |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1784 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1785 | |
| 1786 | // With current conditions, again no need to wake until next keep-alive. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1787 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1788 | PacingController::kPausedProcessInterval); |
| 1789 | |
| 1790 | // Set a non-zero padding rate. Padding also can't be sent until |
| 1791 | // previous debt has cleared. Since padding was disabled before, there |
| 1792 | // currently is no padding debt. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1793 | pacer->SetPacingRates(kPacingDataRate, kPacingDataRate / 2); |
| 1794 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), kPacketPacingTime); |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1795 | |
| 1796 | // Advance time, expect padding. |
| 1797 | EXPECT_CALL(callback_, SendPadding).WillOnce(Return(kPacketSize.bytes())); |
| 1798 | clock_.AdvanceTime(kPacketPacingTime); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1799 | pacer->ProcessPackets(); |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1800 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1801 | |
| 1802 | // Since padding rate is half of pacing rate, next time we can send |
| 1803 | // padding is double the packet pacing time. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1804 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1805 | kPacketPacingTime * 2); |
| 1806 | |
| 1807 | // Insert a packet to be sent, this take precedence again. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1808 | pacer->EnqueuePacket( |
| 1809 | BuildPacket(RtpPacketMediaType::kVideo, kSsrc, sequnce_number++, |
| 1810 | clock_.TimeInMilliseconds(), kPacketSize.bytes())); |
| 1811 | EXPECT_EQ(pacer->NextSendTime() - clock_.CurrentTime(), kPacketPacingTime); |
Erik Språng | be152f5 | 2020-04-06 16:30:23 +0200 | [diff] [blame] | 1812 | } |
| 1813 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1814 | TEST_F(PacingControllerTest, PaddingTargetAccountsForPaddingRate) { |
Erik Språng | c52e627 | 2022-07-07 12:41:57 +0200 | [diff] [blame] | 1815 | // Target size for a padding packet is 5ms * padding rate. |
| 1816 | const TimeDelta kPaddingTarget = TimeDelta::Millis(5); |
Erik Språng | e486a7b | 2022-03-15 15:13:25 +0100 | [diff] [blame] | 1817 | srand(0); |
| 1818 | // Need to initialize PacingController after we initialize clock. |
Erik Språng | c52e627 | 2022-07-07 12:41:57 +0200 | [diff] [blame] | 1819 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | 9acc18d | 2020-04-16 19:41:07 +0200 | [diff] [blame] | 1820 | |
| 1821 | const uint32_t kSsrc = 12345; |
| 1822 | const DataRate kPacingDataRate = DataRate::KilobitsPerSec(125); |
| 1823 | const DataSize kPacketSize = DataSize::Bytes(130); |
| 1824 | |
| 1825 | uint32_t sequnce_number = 1; |
| 1826 | |
| 1827 | // Start with pacing and padding rate equal. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1828 | pacer->SetPacingRates(kPacingDataRate, kPacingDataRate); |
Erik Språng | 9acc18d | 2020-04-16 19:41:07 +0200 | [diff] [blame] | 1829 | |
| 1830 | // Send a single packet. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1831 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, kSsrc, |
| 1832 | sequnce_number++, clock_.TimeInMilliseconds(), |
| 1833 | kPacketSize.bytes()); |
| 1834 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1835 | pacer->ProcessPackets(); |
Erik Språng | 9acc18d | 2020-04-16 19:41:07 +0200 | [diff] [blame] | 1836 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1837 | |
| 1838 | size_t expected_padding_target_bytes = |
| 1839 | (kPaddingTarget * kPacingDataRate).bytes(); |
| 1840 | EXPECT_CALL(callback_, SendPadding(expected_padding_target_bytes)) |
| 1841 | .WillOnce(Return(expected_padding_target_bytes)); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1842 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1843 | pacer->ProcessPackets(); |
Erik Språng | 9acc18d | 2020-04-16 19:41:07 +0200 | [diff] [blame] | 1844 | |
| 1845 | // Half the padding rate - expect half the padding target. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1846 | pacer->SetPacingRates(kPacingDataRate, kPacingDataRate / 2); |
Erik Språng | 9acc18d | 2020-04-16 19:41:07 +0200 | [diff] [blame] | 1847 | EXPECT_CALL(callback_, SendPadding(expected_padding_target_bytes / 2)) |
| 1848 | .WillOnce(Return(expected_padding_target_bytes / 2)); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1849 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1850 | pacer->ProcessPackets(); |
Erik Språng | 9acc18d | 2020-04-16 19:41:07 +0200 | [diff] [blame] | 1851 | } |
| 1852 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1853 | TEST_F(PacingControllerTest, SendsFecPackets) { |
Erik Språng | 1d50cb6 | 2020-07-02 17:41:32 +0200 | [diff] [blame] | 1854 | const uint32_t kSsrc = 12345; |
| 1855 | const uint32_t kFlexSsrc = 54321; |
| 1856 | uint16_t sequence_number = 1234; |
| 1857 | uint16_t flexfec_sequence_number = 4321; |
| 1858 | const size_t kPacketSize = 123; |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1859 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | 1d50cb6 | 2020-07-02 17:41:32 +0200 | [diff] [blame] | 1860 | |
| 1861 | // Set pacing rate to 1000 packet/s, no padding. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1862 | pacer->SetPacingRates( |
Erik Språng | 1d50cb6 | 2020-07-02 17:41:32 +0200 | [diff] [blame] | 1863 | DataSize::Bytes(1000 * kPacketSize) / TimeDelta::Seconds(1), |
| 1864 | DataRate::Zero()); |
| 1865 | |
| 1866 | int64_t now = clock_.TimeInMilliseconds(); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1867 | pacer->EnqueuePacket(BuildPacket(RtpPacketMediaType::kVideo, kSsrc, |
| 1868 | sequence_number, now, kPacketSize)); |
Erik Språng | 1d50cb6 | 2020-07-02 17:41:32 +0200 | [diff] [blame] | 1869 | EXPECT_CALL(callback_, SendPacket(kSsrc, sequence_number, now, false, false)); |
| 1870 | EXPECT_CALL(callback_, FetchFec).WillOnce([&]() { |
| 1871 | EXPECT_CALL(callback_, SendPacket(kFlexSsrc, flexfec_sequence_number, now, |
| 1872 | false, false)); |
| 1873 | EXPECT_CALL(callback_, FetchFec); |
| 1874 | std::vector<std::unique_ptr<RtpPacketToSend>> fec_packets; |
| 1875 | fec_packets.push_back( |
| 1876 | BuildPacket(RtpPacketMediaType::kForwardErrorCorrection, kFlexSsrc, |
| 1877 | flexfec_sequence_number, now, kPacketSize)); |
| 1878 | return fec_packets; |
| 1879 | }); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1880 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1881 | pacer->ProcessPackets(); |
| 1882 | AdvanceTimeUntil(pacer->NextSendTime()); |
| 1883 | pacer->ProcessPackets(); |
Erik Språng | 1d50cb6 | 2020-07-02 17:41:32 +0200 | [diff] [blame] | 1884 | } |
| 1885 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1886 | TEST_F(PacingControllerTest, GapInPacingDoesntAccumulateBudget) { |
Erik Språng | 41bbc3d | 2021-10-05 10:17:39 +0200 | [diff] [blame] | 1887 | const uint32_t kSsrc = 12345; |
| 1888 | uint16_t sequence_number = 1234; |
| 1889 | const DataSize kPackeSize = DataSize::Bytes(250); |
| 1890 | const TimeDelta kPacketSendTime = TimeDelta::Millis(15); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1891 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | 41bbc3d | 2021-10-05 10:17:39 +0200 | [diff] [blame] | 1892 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1893 | pacer->SetPacingRates(kPackeSize / kPacketSendTime, |
| 1894 | /*padding_rate=*/DataRate::Zero()); |
Erik Språng | 41bbc3d | 2021-10-05 10:17:39 +0200 | [diff] [blame] | 1895 | |
| 1896 | // Send an initial packet. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1897 | SendAndExpectPacket(pacer.get(), RtpPacketMediaType::kVideo, kSsrc, |
| 1898 | sequence_number++, clock_.TimeInMilliseconds(), |
| 1899 | kPackeSize.bytes()); |
| 1900 | pacer->ProcessPackets(); |
Erik Språng | 41bbc3d | 2021-10-05 10:17:39 +0200 | [diff] [blame] | 1901 | ::testing::Mock::VerifyAndClearExpectations(&callback_); |
| 1902 | |
| 1903 | // Advance time kPacketSendTime past where the media debt should be 0. |
| 1904 | clock_.AdvanceTime(2 * kPacketSendTime); |
| 1905 | |
| 1906 | // Enqueue two new packets. Expect only one to be sent one ProcessPackets(). |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1907 | pacer->EnqueuePacket( |
| 1908 | BuildPacket(RtpPacketMediaType::kVideo, kSsrc, sequence_number + 1, |
| 1909 | clock_.TimeInMilliseconds(), kPackeSize.bytes())); |
| 1910 | pacer->EnqueuePacket( |
| 1911 | BuildPacket(RtpPacketMediaType::kVideo, kSsrc, sequence_number + 2, |
| 1912 | clock_.TimeInMilliseconds(), kPackeSize.bytes())); |
Erik Språng | 41bbc3d | 2021-10-05 10:17:39 +0200 | [diff] [blame] | 1913 | EXPECT_CALL(callback_, SendPacket(kSsrc, sequence_number + 1, |
| 1914 | clock_.TimeInMilliseconds(), false, false)); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1915 | pacer->ProcessPackets(); |
Erik Språng | 41bbc3d | 2021-10-05 10:17:39 +0200 | [diff] [blame] | 1916 | } |
| 1917 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1918 | TEST_F(PacingControllerTest, HandlesSubMicrosecondSendIntervals) { |
Erik Språng | b844dd8 | 2022-04-22 12:18:17 +0200 | [diff] [blame] | 1919 | static constexpr DataSize kPacketSize = DataSize::Bytes(1); |
| 1920 | static constexpr TimeDelta kPacketSendTime = TimeDelta::Micros(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1921 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | b844dd8 | 2022-04-22 12:18:17 +0200 | [diff] [blame] | 1922 | |
| 1923 | // Set pacing rate such that a packet is sent in 0.5us. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1924 | pacer->SetPacingRates(/*pacing_rate=*/2 * kPacketSize / kPacketSendTime, |
| 1925 | /*padding_rate=*/DataRate::Zero()); |
Erik Språng | b844dd8 | 2022-04-22 12:18:17 +0200 | [diff] [blame] | 1926 | |
| 1927 | // Enqueue three packets, the first two should be sent immediately - the third |
| 1928 | // should cause a non-zero delta to the next process time. |
| 1929 | EXPECT_CALL(callback_, SendPacket).Times(2); |
| 1930 | for (int i = 0; i < 3; ++i) { |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1931 | pacer->EnqueuePacket(BuildPacket( |
| 1932 | RtpPacketMediaType::kVideo, /*ssrc=*/12345, /*sequence_number=*/i, |
| 1933 | clock_.TimeInMilliseconds(), kPacketSize.bytes())); |
Erik Språng | b844dd8 | 2022-04-22 12:18:17 +0200 | [diff] [blame] | 1934 | } |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1935 | pacer->ProcessPackets(); |
Erik Språng | b844dd8 | 2022-04-22 12:18:17 +0200 | [diff] [blame] | 1936 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1937 | EXPECT_GT(pacer->NextSendTime(), clock_.CurrentTime()); |
Erik Språng | b844dd8 | 2022-04-22 12:18:17 +0200 | [diff] [blame] | 1938 | } |
| 1939 | |
Erik Språng | 6aa5cea | 2022-05-16 13:20:36 +0200 | [diff] [blame] | 1940 | TEST_F(PacingControllerTest, HandlesSubMicrosecondPaddingInterval) { |
Erik Språng | b844dd8 | 2022-04-22 12:18:17 +0200 | [diff] [blame] | 1941 | static constexpr DataSize kPacketSize = DataSize::Bytes(1); |
| 1942 | static constexpr TimeDelta kPacketSendTime = TimeDelta::Micros(1); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1943 | auto pacer = std::make_unique<PacingController>(&clock_, &callback_, trials_); |
Erik Språng | b844dd8 | 2022-04-22 12:18:17 +0200 | [diff] [blame] | 1944 | |
| 1945 | // Set both pacing and padding rates to 1 byte per 0.5us. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1946 | pacer->SetPacingRates(/*pacing_rate=*/2 * kPacketSize / kPacketSendTime, |
| 1947 | /*padding_rate=*/2 * kPacketSize / kPacketSendTime); |
Erik Språng | b844dd8 | 2022-04-22 12:18:17 +0200 | [diff] [blame] | 1948 | |
| 1949 | // Enqueue and send one packet. |
| 1950 | EXPECT_CALL(callback_, SendPacket); |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1951 | pacer->EnqueuePacket(BuildPacket( |
| 1952 | RtpPacketMediaType::kVideo, /*ssrc=*/12345, /*sequence_number=*/1234, |
| 1953 | clock_.TimeInMilliseconds(), kPacketSize.bytes())); |
| 1954 | pacer->ProcessPackets(); |
Erik Språng | b844dd8 | 2022-04-22 12:18:17 +0200 | [diff] [blame] | 1955 | |
| 1956 | // The padding debt is now 1 byte, and the pacing time for that is lower than |
| 1957 | // the precision of a TimeStamp tick. Make sure the pacer still indicates a |
| 1958 | // non-zero sleep time is needed until the next process. |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 1959 | EXPECT_GT(pacer->NextSendTime(), clock_.CurrentTime()); |
Erik Språng | b844dd8 | 2022-04-22 12:18:17 +0200 | [diff] [blame] | 1960 | } |
| 1961 | |
Per Kjellander | 8d847f0 | 2022-06-01 20:21:58 +0200 | [diff] [blame] | 1962 | TEST_F(PacingControllerTest, SendsPacketsInBurstImmediately) { |
| 1963 | constexpr TimeDelta kMaxDelay = TimeDelta::Millis(20); |
| 1964 | PacingController pacer(&clock_, &callback_, trials_); |
| 1965 | pacer.SetSendBurstInterval(kMaxDelay); |
| 1966 | pacer.SetPacingRates(DataRate::BytesPerSec(10000), DataRate::Zero()); |
| 1967 | |
| 1968 | // Max allowed send burst size is 100000*20/1000) = 200byte |
| 1969 | pacer.EnqueuePacket(video_.BuildNextPacket(100)); |
| 1970 | pacer.EnqueuePacket(video_.BuildNextPacket(100)); |
| 1971 | pacer.EnqueuePacket(video_.BuildNextPacket(100)); |
| 1972 | pacer.ProcessPackets(); |
| 1973 | EXPECT_EQ(pacer.QueueSizePackets(), 1u); |
| 1974 | EXPECT_EQ(pacer.NextSendTime(), clock_.CurrentTime() + kMaxDelay); |
| 1975 | |
| 1976 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 1977 | pacer.ProcessPackets(); |
| 1978 | EXPECT_EQ(pacer.QueueSizePackets(), 0u); |
| 1979 | } |
| 1980 | |
| 1981 | TEST_F(PacingControllerTest, SendsPacketsInBurstEvenIfNotEnqueedAtSameTime) { |
| 1982 | constexpr TimeDelta kMaxDelay = TimeDelta::Millis(20); |
| 1983 | PacingController pacer(&clock_, &callback_, trials_); |
| 1984 | pacer.SetSendBurstInterval(kMaxDelay); |
| 1985 | pacer.SetPacingRates(DataRate::BytesPerSec(10000), DataRate::Zero()); |
| 1986 | pacer.EnqueuePacket(video_.BuildNextPacket(200)); |
| 1987 | EXPECT_EQ(pacer.NextSendTime(), clock_.CurrentTime()); |
| 1988 | pacer.ProcessPackets(); |
| 1989 | clock_.AdvanceTime(TimeDelta::Millis(1)); |
| 1990 | pacer.EnqueuePacket(video_.BuildNextPacket(200)); |
| 1991 | EXPECT_EQ(pacer.NextSendTime(), clock_.CurrentTime()); |
| 1992 | pacer.ProcessPackets(); |
| 1993 | EXPECT_EQ(pacer.QueueSizePackets(), 0u); |
| 1994 | } |
| 1995 | |
| 1996 | TEST_F(PacingControllerTest, RespectsTargetRateWhenSendingPacketsInBursts) { |
| 1997 | PacingController pacer(&clock_, &callback_, trials_); |
| 1998 | pacer.SetSendBurstInterval(TimeDelta::Millis(20)); |
| 1999 | pacer.SetAccountForAudioPackets(true); |
| 2000 | pacer.SetPacingRates(DataRate::KilobitsPerSec(1000), DataRate::Zero()); |
| 2001 | Timestamp start_time = clock_.CurrentTime(); |
| 2002 | // Inject 100 packets, with size 1000bytes over 100ms. |
| 2003 | // Expect only 1Mbps / (8*1000) / 10 = 12 packets to be sent. |
| 2004 | // Packets are sent in burst. Each burst is then 3 packets * 1000bytes at |
| 2005 | // 1Mbits = 24ms long. Thus, expect 4 bursts. |
| 2006 | EXPECT_CALL(callback_, SendPacket).Times(12); |
| 2007 | int number_of_bursts = 0; |
| 2008 | while (clock_.CurrentTime() < start_time + TimeDelta::Millis(100)) { |
| 2009 | pacer.EnqueuePacket(video_.BuildNextPacket(1000)); |
| 2010 | pacer.EnqueuePacket(video_.BuildNextPacket(1000)); |
| 2011 | pacer.EnqueuePacket(video_.BuildNextPacket(1000)); |
| 2012 | pacer.EnqueuePacket(video_.BuildNextPacket(1000)); |
| 2013 | pacer.EnqueuePacket(video_.BuildNextPacket(1000)); |
| 2014 | if (pacer.NextSendTime() <= clock_.CurrentTime()) { |
| 2015 | pacer.ProcessPackets(); |
| 2016 | ++number_of_bursts; |
| 2017 | } |
| 2018 | clock_.AdvanceTime(TimeDelta::Millis(5)); |
| 2019 | } |
| 2020 | EXPECT_EQ(pacer.QueueSizePackets(), 88u); |
| 2021 | EXPECT_EQ(number_of_bursts, 4); |
| 2022 | } |
| 2023 | |
Erik Språng | df9e51a | 2022-06-10 11:42:15 +0200 | [diff] [blame] | 2024 | TEST_F(PacingControllerTest, RespectsQueueTimeLimit) { |
| 2025 | static constexpr DataSize kPacketSize = DataSize::Bytes(100); |
| 2026 | static constexpr DataRate kNominalPacingRate = DataRate::KilobitsPerSec(200); |
| 2027 | static constexpr TimeDelta kPacketPacingTime = |
| 2028 | kPacketSize / kNominalPacingRate; |
| 2029 | static constexpr TimeDelta kQueueTimeLimit = TimeDelta::Millis(1000); |
| 2030 | |
| 2031 | PacingController pacer(&clock_, &callback_, trials_); |
| 2032 | pacer.SetPacingRates(kNominalPacingRate, /*padding_rate=*/DataRate::Zero()); |
| 2033 | pacer.SetQueueTimeLimit(kQueueTimeLimit); |
| 2034 | |
| 2035 | // Fill pacer up to queue time limit. |
| 2036 | static constexpr int kNumPackets = kQueueTimeLimit / kPacketPacingTime; |
| 2037 | for (int i = 0; i < kNumPackets; ++i) { |
| 2038 | pacer.EnqueuePacket(video_.BuildNextPacket(kPacketSize.bytes())); |
| 2039 | } |
| 2040 | EXPECT_EQ(pacer.ExpectedQueueTime(), kQueueTimeLimit); |
| 2041 | EXPECT_EQ(pacer.pacing_rate(), kNominalPacingRate); |
| 2042 | |
| 2043 | // Double the amount of packets in the queue, the queue time limit should |
| 2044 | // effectively double the pacing rate in response. |
| 2045 | for (int i = 0; i < kNumPackets; ++i) { |
| 2046 | pacer.EnqueuePacket(video_.BuildNextPacket(kPacketSize.bytes())); |
| 2047 | } |
| 2048 | EXPECT_EQ(pacer.ExpectedQueueTime(), kQueueTimeLimit); |
| 2049 | EXPECT_EQ(pacer.pacing_rate(), 2 * kNominalPacingRate); |
| 2050 | |
| 2051 | // Send all the packets, should take as long as the queue time limit. |
| 2052 | Timestamp start_time = clock_.CurrentTime(); |
| 2053 | while (pacer.QueueSizePackets() > 0) { |
| 2054 | AdvanceTimeUntil(pacer.NextSendTime()); |
| 2055 | pacer.ProcessPackets(); |
| 2056 | } |
| 2057 | EXPECT_EQ(clock_.CurrentTime() - start_time, kQueueTimeLimit); |
| 2058 | |
| 2059 | // We're back in a normal state - pacing rate should be back to previous |
| 2060 | // levels. |
| 2061 | EXPECT_EQ(pacer.pacing_rate(), kNominalPacingRate); |
| 2062 | } |
| 2063 | |
Per Kjellander | bfd3065 | 2022-05-27 13:15:17 +0200 | [diff] [blame] | 2064 | } // namespace |
Erik Språng | d05edec | 2019-08-14 10:43:47 +0200 | [diff] [blame] | 2065 | } // namespace webrtc |