| commit | fc02a793c2285b9286077fae16d64eabe940b1fd | [log] [tgz] |
|---|---|---|
| author | Henrik Andreassson <henrika@webrtc.org> | Mon Apr 29 10:52:23 2019 +0000 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Apr 29 11:23:16 2019 +0000 |
| tree | 160ce44cd42f7af6318faf55edd73a2fd6971494 | |
| parent | 98499d5a205822d7e27899ed772266b3d7c8071e [diff] [blame] |
Revert "Piping audio interruption metrics to API layer" This reverts commit 299c4e68461f1c4428b2a919913b161115025dff. Reason for revert: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win10%20Tester/2753 ../../chrome/browser/media/webrtc/webrtc_browsertest_base.cc(539): error: Expected equality of these values: "ok-got-stats" ExecuteJavascript("verifyLegacyStatsGenerated()", tab) Which is: "Test failed: Error: \"googInterruptionCount\" is not a whitelisted stat. Exposing new metrics in the legacy getStats() API is not allowed. Please follow the standardization process: https://docs.google.com/document/d/1q1CJVUqJ6YW9NNRc0tENkLNny8AHrKZfqjy3SL89zjc/edit?usp=sharing\n at failTest (http://127.0.0.1:50650/webrtc/test_functions.js:46:15)\n at http://127.0.0.1:50650/webrtc/peerconnection.js:481:19" With diff: @@ -1,1 +1,3 @@ -ok-got-stats +Test failed: Error: \"googInterruptionCount\" is not a whitelisted stat. Exposing new metrics in the legacy getStats() API is not allowed. Please follow the standardization process: https://docs.google.com/document/d/1q1CJVUqJ6YW9NNRc0tENkLNny8AHrKZfqjy3SL89zjc/edit?usp=sharing + at failTest (http://127.0.0.1:50650/webrtc/test_functions.js:46:15) + at http://127.0.0.1:50650/webrtc/peerconnection.js:481:19 Original change's description: > Piping audio interruption metrics to API layer > > Bug: webrtc:10549 > Change-Id: Ie6abe5819c5b73dc5f5f89bdc375bad77f44ce97 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134303 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#27788} TBR=henrik.lundin@webrtc.org,kwiberg@webrtc.org,ivoc@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:10549 Change-Id: I345306ba9758c0a3b1597724fa860d3e3fdb8995 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134464 Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27802}
diff --git a/modules/audio_coding/neteq/neteq_impl_unittest.cc b/modules/audio_coding/neteq/neteq_impl_unittest.cc index 8269526..025ed69 100644 --- a/modules/audio_coding/neteq/neteq_impl_unittest.cc +++ b/modules/audio_coding/neteq/neteq_impl_unittest.cc
@@ -745,7 +745,7 @@ } auto lifetime_stats = neteq_->GetLifetimeStatistics(); - EXPECT_EQ(0, lifetime_stats.interruption_count); + EXPECT_EQ(0u, lifetime_stats.interruption_count); } // This test verifies that NetEq can handle comfort noise and enters/quits codec