Return `const char*` from ToString(RTCErrorType error).
Returning absl::string_view causes problems to the Chromium/WebRTC
component build because absl::operator<< needs to be exported.
This CL switches to `const char*` which should be enough to avoid
to generate temporaries.
Bug: webrtc:9419
Change-Id: If169a6f95c7efd21ac8ce108c7f2f80a76ff2313
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153842
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29250}
diff --git a/api/rtc_error.h b/api/rtc_error.h
index fdc1999..ffdcc0a 100644
--- a/api/rtc_error.h
+++ b/api/rtc_error.h
@@ -17,7 +17,6 @@
#include <string>
#include <utility> // For std::move.
-#include "absl/strings/string_view.h"
#include "rtc_base/checks.h"
#include "rtc_base/logging.h"
#include "rtc_base/system/rtc_export.h"
@@ -130,9 +129,9 @@
// Outputs the error as a friendly string. Update this method when adding a new
// error type.
//
-// Only intended to be used for logging/diagnostics. The string_view points
+// Only intended to be used for logging/diagnostics. The returned char* points
// to literal string that lives for the whole duration of the program.
-absl::string_view ToString(RTCErrorType error);
+const char* ToString(RTCErrorType error);
#ifdef UNIT_TEST
inline std::ostream& operator<<( // no-presubmit-check TODO(webrtc:8982)