commit f9381f0e734a64a3a58f19312c3d26825616cc3d
author Steve Anton <steveanton@webrtc.org> Thu Dec 14 10:23:57 2017 -0800
committer Commit Bot <commit-bot@chromium.org> Fri Dec 15 18:54:37 2017 +0000
tree c23f7a25f54da16ac655da68f2ba4784c7fbdd66
parent f1a7a8c60298980c92d94d589400630e285bb021

Implement PeerConnection::AddTrack/RemoveTrack for Unified Plan

Bug: webrtc:7600
Change-Id: I2a48426a29ac67b6bdbd7817fe07273cdd5fd980
Reviewed-on: https://webrtc-review.googlesource.com/31647
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Peter Thatcher <pthatcher@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21305}

api/peerconnectioninterface.h

diff --git a/api/peerconnectioninterface.h b/api/peerconnectioninterface.h
index a1e7d7e..eb6685a 100644
--- a/api/peerconnectioninterface.h
+++ b/api/peerconnectioninterface.h
@@ -590,10 +590,24 @@
   virtual void RemoveStream(MediaStreamInterface* stream) = 0;
 
   // Add a new MediaStreamTrack to be sent on this PeerConnection, and return
-  // the newly created RtpSender.
+  // the newly created RtpSender. The RtpSender will be associated with the
+  // streams specified in the |stream_labels| list.
   //
+  // Errors:
+  // - INVALID_PARAMETER: |track| is null, has a kind other than audio or video,
+  //       or a sender already exists for the track.
+  // - INVALID_STATE: The PeerConnection is closed.
+  // TODO(steveanton): Remove default implementation once downstream
+  // implementations have been updated.
+  virtual RTCErrorOr<rtc::scoped_refptr<RtpSenderInterface>>
+  AddTrackWithStreamLabels(rtc::scoped_refptr<MediaStreamTrackInterface> track,
+                           const std::vector<std::string>& stream_labels) {
+    return RTCError(RTCErrorType::UNSUPPORTED_OPERATION, "Not implemented");
+  }
   // |streams| indicates which stream labels the track should be associated
   // with.
+  // TODO(steveanton): Remove this overload once callers have moved to the
+  // signature with stream labels.
   virtual rtc::scoped_refptr<RtpSenderInterface> AddTrack(
       MediaStreamTrackInterface* track,
       std::vector<MediaStreamInterface*> streams) = 0;