commit f5318e1f391859c82aaa47b297429e50f41f6b3c
author kjellander <kjellander@webrtc.org> Thu Mar 09 02:26:46 2017 -0800
committer Commit bot <commit-bot@chromium.org> Thu Mar 09 10:26:46 2017 +0000
tree dc312f9f107d9f6f3d2cce70da5dc77f274fcad4
parent 735da3ad38b9387f3a2b4ef778a0c8c40a1e75ff

PyLint fixes for tools-webrtc and webrtc/tools

Fix a lot of errors before bringing in the new config in
https://codereview.webrtc.org/2737963003/

BUG=webrtc:7303
NOTRY=True

Review-Url: https://codereview.webrtc.org/2736233003
Cr-Commit-Position: refs/heads/master@{#17137}

tools-webrtc/autoroller/unittests/roll_deps_test.py

diff --git a/tools-webrtc/autoroller/unittests/roll_deps_test.py b/tools-webrtc/autoroller/unittests/roll_deps_test.py
index 98351ce..65b5288 100755
--- a/tools-webrtc/autoroller/unittests/roll_deps_test.py
+++ b/tools-webrtc/autoroller/unittests/roll_deps_test.py
@@ -49,7 +49,7 @@
   def __init__(self):
     self.expectations = []
 
-  def add_expectation(self, *args, **kwargs):
+  def AddExpectation(self, *args, **kwargs):
     returns = kwargs.pop('_returns', None)
     self.expectations.append((args, kwargs, returns))
 
@@ -74,13 +74,13 @@
     self._new_cr_depsfile = os.path.join(self._output_dir, 'DEPS.chromium.new')
 
     self.fake = FakeCmd()
-    self.old_RunCommand = getattr(roll_deps, '_RunCommand')
+    self.old_run_command = getattr(roll_deps, '_RunCommand')
     setattr(roll_deps, '_RunCommand', self.fake)
 
   def tearDown(self):
     shutil.rmtree(self._output_dir, ignore_errors=True)
     self.assertEqual(self.fake.expectations, [])
-    setattr(roll_deps, '_RunCommand', self.old_RunCommand)
+    setattr(roll_deps, '_RunCommand', self.old_run_command)
 
   def testUpdateDepsFile(self):
     new_rev = 'aaaaabbbbbcccccdddddeeeeefffff0000011111'
@@ -98,10 +98,10 @@
     local_scope = ParseDepsDict(deps_contents)
     vars_dict = local_scope['vars']
 
-    def assertVar(variable_name):
+    def AssertVar(variable_name):
       self.assertEquals(vars_dict[variable_name], TEST_DATA_VARS[variable_name])
-    assertVar('chromium_git')
-    assertVar('chromium_revision')
+    AssertVar('chromium_git')
+    AssertVar('chromium_revision')
     self.assertEquals(len(local_scope['deps']), 3)
     self.assertEquals(len(local_scope['deps_os']), 1)
 
@@ -137,7 +137,7 @@
 
 def _SetupGitLsRemoteCall(cmd_fake, url, revision):
   cmd = ['git', 'ls-remote', url, revision]
-  cmd_fake.add_expectation(cmd, _returns=(revision, None))
+  cmd_fake.AddExpectation(cmd, _returns=(revision, None))
 
 
 if __name__ == '__main__':