PyLint fixes for tools-webrtc and webrtc/tools
Fix a lot of errors before bringing in the new config in
https://codereview.webrtc.org/2737963003/
BUG=webrtc:7303
NOTRY=True
Review-Url: https://codereview.webrtc.org/2736233003
Cr-Commit-Position: refs/heads/master@{#17137}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 72e4326..189be25 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -116,7 +116,7 @@
non_existing_paths)]
return []
-api_change_msg = """
+API_CHANGE_MSG = """
You seem to be changing native API header files. Please make sure that you:
1. Make compatible changes that don't break existing clients. Usually
this is done by keeping the existing method signatures unchanged.
@@ -145,7 +145,7 @@
files.append(f)
if files:
- return [output_api.PresubmitNotifyResult(api_change_msg, files)]
+ return [output_api.PresubmitNotifyResult(API_CHANGE_MSG, files)]
return []
@@ -190,7 +190,7 @@
return []
-def _CheckNoFRIEND_TEST(input_api, output_api):
+def _CheckNoFRIEND_TEST(input_api, output_api): # pylint: disable=invalid-name
"""Make sure that gtest's FRIEND_TEST() macro is not used, the
FRIEND_TEST_ALL_PREFIXES() macro from testsupport/gtest_prod_util.h should be
used instead since that allows for FLAKY_, FAILS_ and DISABLED_ prefixes."""
@@ -452,13 +452,13 @@
def _RunPythonTests(input_api, output_api):
- def join(*args):
+ def Join(*args):
return input_api.os_path.join(input_api.PresubmitLocalPath(), *args)
test_directories = [
- join('webrtc', 'tools', 'py_event_log_analyzer')
+ Join('webrtc', 'tools', 'py_event_log_analyzer')
] + [
- root for root, _, files in os.walk(join('tools-webrtc'))
+ root for root, _, files in os.walk(Join('tools-webrtc'))
if any(f.endswith('_test.py') for f in files)
]