commit f2a2bf4ae448dff45974a7f38f8db005f643f3a3
author jbauch <jbauch@webrtc.org> Wed Feb 03 16:45:32 2016 -0800
committer Commit bot <commit-bot@chromium.org> Thu Feb 04 00:45:38 2016 +0000
tree 520c1ac6b81410247277edccf839e4560db22d29
parent 14d024d88261933153afd5eedeaf459ac31cb80a

Stay writable after partial socket writes.

This CL fixes an issue where the "writable" flag didn't stay set after
::send or ::sendto only sent a partial buffer.

Also SocketTest::TcpInternal has been updated to use rtc::Buffer instead
of manually allocating data.

BUG=webrtc:4898

Review URL: https://codereview.webrtc.org/1616153007

Cr-Commit-Position: refs/heads/master@{#11480}

webrtc/base/socket_unittest.h

diff --git a/webrtc/base/socket_unittest.h b/webrtc/base/socket_unittest.h
index e4a6b32..adc69f1 100644
--- a/webrtc/base/socket_unittest.h
+++ b/webrtc/base/socket_unittest.h
@@ -62,6 +62,10 @@
   const IPAddress kIPv4Loopback;
   const IPAddress kIPv6Loopback;
 
+ protected:
+  void TcpInternal(const IPAddress& loopback, size_t data_size,
+      ssize_t max_send_size);
+
  private:
   void ConnectInternal(const IPAddress& loopback);
   void ConnectWithDnsLookupInternal(const IPAddress& loopback,
@@ -76,7 +80,6 @@
   void ServerCloseInternal(const IPAddress& loopback);
   void CloseInClosedCallbackInternal(const IPAddress& loopback);
   void SocketServerWaitInternal(const IPAddress& loopback);
-  void TcpInternal(const IPAddress& loopback);
   void SingleFlowControlCallbackInternal(const IPAddress& loopback);
   void UdpInternal(const IPAddress& loopback);
   void UdpReadyToSend(const IPAddress& loopback);