commit f28a3894465f5f78a61064f35bf7939da61ee225
author peah <peah@webrtc.org> Thu Sep 01 08:58:21 2016 -0700
committer Commit bot <commit-bot@chromium.org> Thu Sep 01 15:58:27 2016 +0000
tree 95fde5061a8da3c1c02c12147d1f2fe6553a0f98
parent a0e60e8550a11ae78136b590c91d0de5a27436cb

Moved the place for the aec_debug_dump build flag and changed the name to apm_debug_dump

Currently, the aec_debug_dump buildflag can and is used to store data in the whole of
the audio processing module. Therefore a more appropriate name is apm_debug_dump which
also matches the names of the data dumping functionality. This CL makes that name change.

The CL also changes the WEBRTC_AEC_DEBUG_DUMP define to
WEBRTC_APM_DEBUG_DUMP == 1

Furthermore, this CL moves the buildflag to a more appropriate place.

BUG=webrtc:5298

Review-Url: https://codereview.webrtc.org/2300813004
Cr-Commit-Position: refs/heads/master@{#14026}

webrtc/modules/audio_processing/audio_processing.gypi

diff --git a/webrtc/modules/audio_processing/audio_processing.gypi b/webrtc/modules/audio_processing/audio_processing.gypi
index 14e1b66..cbd4fdf 100644
--- a/webrtc/modules/audio_processing/audio_processing.gypi
+++ b/webrtc/modules/audio_processing/audio_processing.gypi
@@ -9,8 +9,6 @@
 {
   'variables': {
     'shared_generated_dir': '<(SHARED_INTERMEDIATE_DIR)/audio_processing/asm_offsets',
-    # Outputs some low-level debug files.
-    'aec_debug_dump%': 0,
   },
   'targets': [
     {
@@ -165,10 +163,10 @@
         'voice_detection_impl.h',
       ],
       'conditions': [
-        ['aec_debug_dump==1', {
-          'defines': ['WEBRTC_AEC_DEBUG_DUMP=1',],
+        ['apm_debug_dump==1', {
+          'defines': ['WEBRTC_APM_DEBUG_DUMP=1',],
         }, {
-          'defines': ['WEBRTC_AEC_DEBUG_DUMP=0',],
+          'defines': ['WEBRTC_APM_DEBUG_DUMP=0',],
         }],
         ['aec_untrusted_delay_for_testing==1', {
           'defines': ['WEBRTC_UNTRUSTED_DELAY',],
@@ -278,10 +276,10 @@
             'aec/aec_rdft_sse2.cc',
           ],
           'conditions': [
-            ['aec_debug_dump==1', {
-              'defines': ['WEBRTC_AEC_DEBUG_DUMP=1',],
+            ['apm_debug_dump==1', {
+              'defines': ['WEBRTC_APM_DEBUG_DUMP=1',],
             }, {
-              'defines': ['WEBRTC_AEC_DEBUG_DUMP=0',],
+              'defines': ['WEBRTC_APM_DEBUG_DUMP=0',],
             }],
             ['os_posix==1', {
               'cflags': [ '-msse2', ],
@@ -308,11 +306,11 @@
           'ns/nsx_core_neon.c',
         ],
         'conditions': [
-          ['aec_debug_dump==1', {
-            'defines': ['WEBRTC_AEC_DEBUG_DUMP=1',],
+          ['apm_debug_dump==1', {
+            'defines': ['WEBRTC_APM_DEBUG_DUMP=1',],
           }],
-          ['aec_debug_dump==0', {
-            'defines': ['WEBRTC_AEC_DEBUG_DUMP=0',],
+          ['apm_debug_dump==0', {
+            'defines': ['WEBRTC_APM_DEBUG_DUMP=0',],
           }],
         ],
       }],